Partial revert of r203811 - this key is not needed.
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Partial revert of r203811 - this key is not needed.
4
5         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
6
7 2016-08-19  Daniel Bates  <dabates@apple.com>
8
9         Another attempt to fix the iOS 9.3 build
10
11         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
12
13         * DumpRenderTree/mac/Configurations/Base.xcconfig:
14         * WebKitTestRunner/Configurations/Base.xcconfig:
15
16 2016-08-19  Lucas Forschler  <lforschler@apple.com>
17
18         Remove Yosemite Leaks bot from config.json
19         
20         Reviewed by Alexey Proskuryakov.
21
22         * BuildSlaveSupport/build.webkit.org-config/config.json:
23
24 2016-08-18  Dan Bernstein  <mitz@apple.com>
25
26         [Cocoa] API::Number needs to be wrapped by an NSNumber
27         https://bugs.webkit.org/show_bug.cgi?id=160977
28         <rdar://problem/27877735>
29
30         Reviewed by Anders Carlsson.
31
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
34         (TestWebKitAPI::TEST):
35
36 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
37
38         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
39         https://bugs.webkit.org/show_bug.cgi?id=160895
40
41         Reviewed by Dean Jackson.
42
43         Link to the existing CoreText framework.
44
45         * DumpRenderTree/PlatformWin.cmake:
46         * TestWebKitAPI/PlatformWin.cmake:
47
48 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
49
50         [Win] Remove old libraries from build inputs
51         https://bugs.webkit.org/show_bug.cgi?id=160949
52
53         Reviewed by Dean Jackson.
54
55         Modify the download script to remove the old 'icuuc.lib' and
56         'icuin.lib' files for Windows builds.
57
58         * Scripts/update-webkit-auxiliary-libs:
59
60 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
61
62         Extra logging for crash reason
63         https://bugs.webkit.org/show_bug.cgi?id=160943
64
65         Reviewed by Alexey Proskuryakov.
66
67         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
68
69         * Scripts/webkitpy/port/server_process.py:
70         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
71         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
72         (ServerProcess.has_crashed): Ditto.
73
74 2016-08-17  Dan Bernstein  <mitz@apple.com>
75
76         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
77         https://bugs.webkit.org/show_bug.cgi?id=160938
78         <rdar://problem/27876652>
79
80         Reviewed by Anders Carlsson.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
84         (TestWebKitAPI::TEST):
85
86 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
87
88         AX: Support abbreviations in iOS
89         https://bugs.webkit.org/show_bug.cgi?id=160907
90
91         Reviewed by Joanmarie Diggs.
92
93         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
94         (AccessibilityUIElement::stringAttributeValue):
95         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
96         (WTR::AccessibilityUIElement::stringAttributeValue):
97
98 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
99
100         [EFL] Bump efl version from 1.17 to 1.18
101         https://bugs.webkit.org/show_bug.cgi?id=160899
102
103         Reviewed by Antonio Gomes.
104
105         To use efl-1.18, EFL port needs to update install dependencies as well.
106
107         * efl/install-dependencies:
108         * efl/jhbuild.modules:
109
110 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
111
112         [Win] Add tests for linked fonts.
113         https://bugs.webkit.org/show_bug.cgi?id=160898
114
115         Reviewed by Brent Fulgham.
116
117         Add tests for https://trac.webkit.org/changeset/204502.
118
119         * TestWebKitAPI/PlatformWin.cmake:
120         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
121         (TestWebKitAPI::TEST):
122
123 2016-08-16  Daniel Bates  <dabates@apple.com>
124
125         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
126         https://bugs.webkit.org/show_bug.cgi?id=160924
127
128         Reviewed by Stephanie Lewis.
129
130         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
131         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
132         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
133         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
134         object that mocks out the file system and SCM operations.
135
136         * Scripts/VCSUtils.pm:
137         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
138         * Scripts/prepare-ChangeLog:
139         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
140         abstracting the logic to query the file system and SCM into functions on a delegate object that
141         we pass to it.
142         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
143         (diffHeaderFormat): Deleted.
144
145 2016-08-16  Alex Christensen  <achristensen@webkit.org>
146
147         URLParser should parse URLs without credentials
148         https://bugs.webkit.org/show_bug.cgi?id=160913
149
150         Reviewed by Brady Eidson.
151
152         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
153         (TestWebKitAPI::s):
154         (TestWebKitAPI::checkURL):
155         (TestWebKitAPI::TEST_F):
156
157 2016-08-16  Anders Carlsson  <andersca@apple.com>
158
159         Add WTF::ScopeExit
160         https://bugs.webkit.org/show_bug.cgi?id=160908
161
162         Reviewed by Geoffrey Garen.
163
164         * TestWebKitAPI/CMakeLists.txt:
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
167         (TestWebKitAPI::TEST):
168
169 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
170
171         EWS logs file are rotated too quickly
172         https://bugs.webkit.org/show_bug.cgi?id=160724
173
174         Reviewed by Daniel Bates.
175
176         Currently we are rotating the log file after 10 iterations of queue. If the queue
177         doesn't have any pending patches, these iterations result in very small amount of 
178         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
179         This results in a lot of log files in a day. This patch ensures that we rotate the
180         log file when its file size is greater than or equal to 100 KB.
181
182         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
183
184 2016-08-16  Daniel Bates  <dabates@apple.com>
185
186         WKSI static library should be named by major iOS revision, not individual updates
187         https://bugs.webkit.org/show_bug.cgi?id=160727
188         <rdar://problem/22274848>
189
190         Reviewed by Alexey Proskuryakov.
191
192         * DumpRenderTree/mac/Configurations/Base.xcconfig:
193         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
194         * Scripts/copy-webkitlibraries-to-product-directory:
195         * WebKitTestRunner/Configurations/Base.xcconfig:
196         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
197
198 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
199
200         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
201         https://bugs.webkit.org/show_bug.cgi?id=160909
202
203         Reviewed by Enrica Casucci.
204         
205         Add functions to UIScriptController to dismiss the form accessory view for iOS,
206         and to programmatically pick a row from a <select> picker.
207
208         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
209         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
210         (WTR::UIScriptController::dismissFormAccessoryView):
211         (WTR::UIScriptController::selectFormAccessoryPickerRow):
212         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
213         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
214         (WTR::UIScriptController::dismissFormAccessoryView):
215         (WTR::UIScriptController::selectFormAccessoryPickerRow):
216
217 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
218
219         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
220         https://bugs.webkit.org/show_bug.cgi?id=160878
221
222         Reviewed by Tim Horton.
223         
224         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
225         now that we have the ability to run tests in the iPad simulator.
226
227         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
228         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
229         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
230         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
231         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
232         * WebKitTestRunner/ios/TestControllerIOS.mm:
233         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
234         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
235         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
236         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
237
238 2016-08-15  Anders Carlsson  <andersca@apple.com>
239
240         Add an address-of operator to RetainPtr
241         https://bugs.webkit.org/show_bug.cgi?id=160879
242
243         Reviewed by Tim Horton.
244
245         Test HashMap and HashSet with an object whose operator& is deleted.
246
247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
248         Sort the Xcode project.
249
250         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
251         (DeletedAddressOfOperator::DeletedAddressOfOperator):
252         (DeletedAddressOfOperator::value):
253         (DeletedAddressOfOperator::operator==):
254         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
255         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
256         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
257         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
258         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
259         (TestWebKitAPI::TEST):
260         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
261         (TestWebKitAPI::TEST):
262
263 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
264
265         False crashes in fast/text/emoji-gender-* tests
266         https://bugs.webkit.org/show_bug.cgi?id=160779
267
268         Reviewed by Alexey Proskuryakov.
269
270         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
271
272         * Scripts/webkitpy/port/driver.py:
273         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
274         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
275         * Scripts/webkitpy/port/server_process.py:
276         (ServerProcess.write): Allow caller to disable crash flag on exception.
277
278 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
279
280         webkitpy error in TestRunResults.merge()
281         https://bugs.webkit.org/show_bug.cgi?id=160882
282
283         Reviewed by Daniel Bates.
284         
285         The argument to TestRunResults.merge() can be None if there are no device-specifc
286         initial results or retry results in Manager.run(), so just return early in that case.
287
288         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
289         (TestRunResults.merge):
290
291 2016-08-15  Sam Weinig  <sam@webkit.org>
292
293         Speed up compile times by not including wtf/Variant.h so much
294         https://bugs.webkit.org/show_bug.cgi?id=160847
295
296         Reviewed by Alex Christensen and Saam Barati.
297
298         * TestWebKitAPI/Tests/WTF/Variant.cpp:
299         (TestWebKitAPI::TEST):
300         Explicitly use std::experimental::variant.
301
302 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
303
304         Allow a port to run tests with a custom device setup
305         https://bugs.webkit.org/show_bug.cgi?id=160833
306
307         Reviewed by Daniel Bates.
308
309         These changes allow the IOSSimulator port to run tests in iPad mode.
310
311         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
312         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
313         a custom device will be collected into a set, and run in that device's environment after
314         the other tests have run.
315
316         * Scripts/webkitpy/layout_tests/controllers/manager.py:
317         (Manager._custom_device_for_test): If the test contains a directory matching a
318         custom device suffix, return that custom device.
319         (Manager._set_up_run): Push the custom device class, if any, into options so
320         that the Worker can get to it.
321         (Manager.run): Go through the list of tests, and break it down into device-generic
322         tests, and tests for each device class. _run_test_subset is then called for
323         each collection of tests, and the results merged.
324         (Manager._run_test_subset): Some lines unwrapped.
325         (Manager._end_test_run):
326         (Manager._run_tests):
327         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
328         (SingleTestRunner.__init__): Unwrapped a line.
329         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
330         (TestRunResults.merge): Add this function to merge TestRunResults
331         * Scripts/webkitpy/layout_tests/views/printing.py:
332         (Printer.print_workers_and_shards): Print the custom device, if any.
333         * Scripts/webkitpy/port/base.py:
334         (Port): Base port has empty array of custom devices.
335         (Port.setup_test_run): Add device_class argument.
336         * Scripts/webkitpy/port/driver.py:
337         (DriverInput.__repr__):
338         (Driver.check_driver.implementation):
339         * Scripts/webkitpy/port/efl.py:
340         (EflPort.setup_test_run):
341         * Scripts/webkitpy/port/gtk.py:
342         (GtkPort.setup_test_run):
343         * Scripts/webkitpy/port/ios.py:
344         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
345         (IOSSimulatorPort.__init__):
346         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
347         based on the custom device class.
348         (IOSSimulatorPort._set_device_class):
349         (IOSSimulatorPort._create_simulators): Factor some code into this function.
350         (IOSSimulatorPort.setup_test_run):
351         (IOSSimulatorPort.testing_device):
352         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
353         seemed wrong for this function. That was moved to setup_test_run().
354         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
355         but this happened too early, before we knew which kind of devices to create. Devices
356         are now created in setup_test_run().
357         * Scripts/webkitpy/port/win.py:
358         (WinPort.setup_test_run):
359
360 2016-08-15  Daniel Bates  <dabates@apple.com>
361
362         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
363         private frameworks and libraries
364         https://bugs.webkit.org/show_bug.cgi?id=155931
365         <rdar://problem/25807989>
366
367         Reviewed by Dan Bernstein.
368
369         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
370         where X is the major version of the active iOS SDK.
371
372         * DumpRenderTree/mac/Configurations/Base.xcconfig:
373         * WebKitTestRunner/Configurations/Base.xcconfig:
374
375 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
376
377         Add a setting and preferences to enable visual viewport mode
378         https://bugs.webkit.org/show_bug.cgi?id=160843
379
380         Reviewed by Sam Weinig.
381         
382         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
383
384         * MiniBrowser/mac/SettingsController.h:
385         * MiniBrowser/mac/SettingsController.m:
386         (-[SettingsController _populateMenu]):
387         (-[SettingsController validateMenuItem:]):
388         (-[SettingsController visualViewportEnabled]):
389         (-[SettingsController toggleVisualViewportEnabled:]):
390         * MiniBrowser/mac/WK1BrowserWindowController.m:
391         (-[WK1BrowserWindowController didChangeSettings]):
392         * MiniBrowser/mac/WK2BrowserWindowController.m:
393         (-[WK2BrowserWindowController didChangeSettings]):
394
395 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
396
397         Allow using make-dist with non-GTK ports
398         https://bugs.webkit.org/show_bug.cgi?id=160842
399
400         Reviewed by Michael Catanzaro.
401
402         This patch adds support for setting base name of tarball and argument
403         passed to cmake's -DPORT= via command line arguments.
404
405         * gtk/make-dist.py:
406         (Distcheck.configure):
407         (Distcheck.check):
408         (get_tarball_root_and_output_filename_from_arguments):
409
410 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
411
412         [GTK] Install script lacks gstreamer related dependencies
413         https://bugs.webkit.org/show_bug.cgi?id=160814
414
415         Reviewed by Carlos Garcia Campos.
416
417         * gtk/install-dependencies: Fedora case had already listed this dependencies,
418         but both Arch and Debian/Ubuntu were missing them.
419
420 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
421
422         make-dist.py should not allow unknown rules in manifest
423         https://bugs.webkit.org/show_bug.cgi?id=160841
424
425         Reviewed by Carlos Garcia Campos.
426
427         * gtk/make-dist.py:
428         (Manifest.process_line):
429
430 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
431
432         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
433         https://bugs.webkit.org/show_bug.cgi?id=160809
434
435         Reviewed by Carlos Garcia Campos.
436
437         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
438         case, and use it also for the new package names of libpng and libgeoclue.
439         * gtk/install-dependencies: Ditto.
440
441 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
442
443         Skip to check directories existence in build-webkit
444         https://bugs.webkit.org/show_bug.cgi?id=160691
445
446         Reviewed by Alex Christensen.
447
448         CMake checks if directories are there itself. So CMake ports
449         don't need to check it in the build-webkit script.
450
451         * Scripts/build-webkit:
452         * Scripts/webkitdirs.pm:
453         (determineSourceDir):
454         (isCMakeBuild):
455
456 2016-08-12  Alex Christensen  <achristensen@webkit.org>
457
458         Make URLParser work with URLs missing URL parts
459         https://bugs.webkit.org/show_bug.cgi?id=160824
460
461         Reviewed by Brady Eidson.
462
463         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
464         (TestWebKitAPI::s):
465         (TestWebKitAPI::checkURL):
466         (TestWebKitAPI::TEST_F):
467         (TestWebKitAPI::eq): Deleted.
468
469 2016-08-12  John Wilander  <wilander@apple.com>
470
471         Add HashCountedSet API tests to TestWTFLibrary target
472         https://bugs.webkit.org/show_bug.cgi?id=160815
473
474         Reviewed by Alex Christensen.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477             Added HashCountedSet.cpp and sorted the file reference section
478             according to UNIX sort.
479
480 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
481
482         run-benchmark should run JetStream 1.1 instead of 1.0.1
483         https://bugs.webkit.org/show_bug.cgi?id=160816
484
485         Reviewed by Filip Pizlo.
486
487         Use the latest JetStream 1.1 in run-benchmark.
488
489         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
490         (BenchmarkBuilder.__exit__):
491         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
492         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
493         change to JetStream directory.
494
495 2016-08-12  Alex Christensen  <achristensen@webkit.org>
496
497         Initial URLParser implementation
498         https://bugs.webkit.org/show_bug.cgi?id=160811
499
500         Reviewed by Brady Eidson.
501
502         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
503         (TestWebKitAPI::eq):
504         (TestWebKitAPI::checkURL):
505         (TestWebKitAPI::TEST_F):
506
507 2016-08-12  Brady Eidson  <beidson@apple.com>
508
509         Fix the 32-bit Mac build after:
510         Add WK2 ExperimentalFeature support to MiniBrowser
511         https://bugs.webkit.org/show_bug.cgi?id=160788
512
513         Unreviewed.
514
515         Sprinkle "#if WK_API_ENABLED"s liberally.
516         
517         * MiniBrowser/mac/AppDelegate.m:
518         (defaultConfiguration):
519         * MiniBrowser/mac/SettingsController.m:
520         (-[SettingsController _populateMenu]):
521         (-[SettingsController validateMenuItem:]):
522
523 2016-08-12  Philippe Normand  <pnormand@igalia.com>
524
525         [GStreamer][OWR] Video rendering fixes
526         https://bugs.webkit.org/show_bug.cgi?id=160764
527
528         Reviewed by Xabier Rodriguez-Calvar.
529
530         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
531
532 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
533
534         Add missing return statement in convertFast function added in r204376.
535
536         Unreviewed.
537
538         * Scripts/webkitpy/common/system/path.py:
539         (_CygPath.convertFast):
540
541 2016-08-11  Brady Eidson  <beidson@apple.com>
542
543         Add WK2 ExperimentalFeature support to MiniBrowser.
544         https://bugs.webkit.org/show_bug.cgi?id=160788
545
546         Reviewed by Alex Christensen.
547
548         * MiniBrowser/mac/AppDelegate.h:
549         * MiniBrowser/mac/AppDelegate.m:
550         (defaultConfiguration):
551         (defaultPreferences):
552         
553         * MiniBrowser/mac/SettingsController.m:
554         (-[SettingsController _populateMenu]):
555         (-[SettingsController validateMenuItem:]):
556         (-[SettingsController toggleExperimentalFeature:]):
557
558 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
559
560         Keep EWS logs for longer
561         https://bugs.webkit.org/show_bug.cgi?id=160776
562
563         Reviewed by Daniel Bates.
564
565         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
566
567 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
568
569         iOS DRT/WTR project cleanup
570         https://bugs.webkit.org/show_bug.cgi?id=160778
571
572         Reviewed by Tim Horton.
573
574         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
575
576         Remove AppDelegate.* which were unused.
577
578         Exclude ios/Launch.storyboard on more platforms.
579
580         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
581         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
582         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
583         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
584         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
585         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
586         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
587
588 2016-08-11  Alex Christensen  <achristensen@webkit.org>
589
590         Fix Yosemite bots' cookie accept policies after r204365.
591         https://bugs.webkit.org/show_bug.cgi?id=160758
592
593         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
594         (TEST):
595         This makes the test fully clean up after itself.
596
597 2016-08-11  Alex Christensen  <achristensen@webkit.org>
598
599         Fix Yosemite bots' cookie accept policies after r204365.
600         https://bugs.webkit.org/show_bug.cgi?id=160758
601
602         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
603         (TEST):
604         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
605         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
606         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
607         causing any problems because there are no other API tests that do anything with cookies.
608         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
609         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
610         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
611
612 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
613
614         EWS should check if the patch is still valid before executing every major step
615         https://bugs.webkit.org/show_bug.cgi?id=160739
616         rdar://problem/27768813
617
618         Reviewed by Alexey Proskuryakov.
619
620         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
621         (CommitQueueTask.run): validate method is now executed in base class.
622         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
623         (EarlyWarningSystemTask.run): validate method is now executed in base class.
624         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
625         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
626         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
627         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
628         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
629         * Scripts/webkitpy/tool/commands/perfalizer.py:
630         (PerfalizerTask.validate): Added.
631         * Scripts/webkitpy/tool/commands/queues_unittest.py:
632         (test_manual_reject_during_processing): Updated test case.
633
634 2016-08-11  Alex Christensen  <achristensen@webkit.org>
635
636         Add URLParser stub
637         https://bugs.webkit.org/show_bug.cgi?id=160770
638
639         Reviewed by Sam Weinig.
640
641         * TestWebKitAPI/PlatformGTK.cmake:
642         * TestWebKitAPI/PlatformWin.cmake:
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
645         (TestWebKitAPI::TEST_F):
646
647 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
648
649         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
650         https://bugs.webkit.org/show_bug.cgi?id=160761
651
652         Reviewed by Tim Horton.
653
654         Give iOS DRT a Launch storyboard.
655
656         Have it use a UIViewController so future forms testing works correctly.
657
658         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
659         can run in iPad mode.
660
661         Remove empty InfoPlist.strings files.
662
663         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
664         * DumpRenderTree/ios/Info.plist:
665         * DumpRenderTree/ios/Launch.storyboard: Added.
666         * DumpRenderTree/mac/DumpRenderTree.mm:
667         (createWebViewAndOffscreenWindow):
668         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
669         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
670         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
671         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
672
673 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
674
675         [Win] Unable to reliably run tests in parallel
676         https://bugs.webkit.org/show_bug.cgi?id=140914
677
678         Reviewed by Brent Fulgham.
679
680         The cygpath utility function can fail badly when running with multiple DumpRenderTree
681         processes. We can use string replacement to convert the Cygwin path to a Windows path
682         instead.
683
684         * Scripts/webkitpy/common/system/path.py:
685         (cygpathFast):
686         * Scripts/webkitpy/port/driver.py:
687         (Driver._command_from_driver_input):
688
689 2016-08-10  Alex Christensen  <achristensen@webkit.org>
690
691         Fix crash when changing cookie accept policy after r204327
692         https://bugs.webkit.org/show_bug.cgi?id=160758
693
694         Reviewed by Simon Fraser.
695
696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
697         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
698         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
699         (TEST):
700         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
701
702 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
703
704         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
705         https://bugs.webkit.org/show_bug.cgi?id=160757
706
707         Reviewed by Tim Horton.
708
709         When programmatically creating the test UIWindow, make a root UIViewController and parent
710         the WKWebView in its view. This makes the app more like a normal UIKit application.
711         
712         Move the WKWebView down 20px to avoid the status bar.
713         
714         Give the UIWindow a gray background so it's obvious where the window and view positioned.
715
716         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
717         
718         Remove duplicate references to Launch.storyboard.
719
720         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
721         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
722         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
723         (-[AppDelegate applicationWillResignActive:]): Deleted.
724         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
725         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
726         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
727         (-[AppDelegate applicationWillTerminate:]): Deleted.
728         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
729         (WTR::viewRectForWindowRect):
730         (WTR::PlatformWebView::PlatformWebView):
731         (WTR::PlatformWebView::setWindowFrame):
732
733 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
734
735         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
736         https://bugs.webkit.org/show_bug.cgi?id=160748
737
738         Reviewed by Tim Horton.
739         
740         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
741         opens the door for tests using other device sizes.
742
743         * WebKitTestRunner/ios/TestControllerIOS.mm:
744         (WTR::TestController::platformConfigureViewForTest):
745
746 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
747
748         Sort the feature flags in the FEATURE_DEFINES lines
749         https://bugs.webkit.org/show_bug.cgi?id=160742
750
751         Reviewed by Anders Carlsson.
752         
753         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
754
755 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
756
757         Logging and other minor improvements to iOS webkitpy
758         https://bugs.webkit.org/show_bug.cgi?id=160722
759
760         Reviewed by Dan Bates.
761
762         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
763         to make it easier to debug launching issues.
764
765         Have reset_preferences() reset the device, rather than just nuking the data
766         directory (which broke some versions of the simulator).
767
768         Make the Simulator.app launch in the background with open -g.
769
770         Wait for the simulator device to be in a known state in some more places.
771
772         * Scripts/webkitpy/port/ios.py:
773         (IOSSimulatorPort.setup_test_run):
774         (IOSSimulatorPort._quit_ios_simulator):
775         (IOSSimulatorPort.clean_up_test_run):
776         (IOSSimulatorPort.setup_environ_for_server):
777         (IOSSimulatorPort.reset_preferences):
778         * Scripts/webkitpy/xcode/simulator.py:
779         (Device.create):
780         (Device.delete):
781         (Device):
782         (Device.reset):
783         (Simulator.wait_until_device_is_booted):
784         (Simulator.wait_until_device_is_in_state):
785         (Simulator):
786         (Simulator.delete_device):
787         (Simulator.reset_device):
788         (Simulator.lookup_or_create_device):
789
790 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
791
792         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
793         https://bugs.webkit.org/show_bug.cgi?id=160697
794
795         Reviewed by Antonio Gomes.
796
797         * Scripts/webkitpy/port/base.py:
798         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
799         list of environment variables to copy.
800
801 2016-08-09  George Ruan  <gruan@apple.com>
802
803         Implement functionality of media capture on iOS
804         https://bugs.webkit.org/show_bug.cgi?id=158945
805         <rdar://problem/26893343>
806
807         Reviewed by Tim Horton.
808
809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
810         Capture feature on iOS.
811
812 2016-08-09  Saam Barati  <sbarati@apple.com>
813
814         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
815         https://bugs.webkit.org/show_bug.cgi?id=160671
816         <rdar://problem/27756112>
817
818         Reviewed by Mark Lam.
819
820         * Scripts/run-jsc-stress-tests:
821
822 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
823
824         Make directory reading code in iOSSimulatorDevices() more strict
825         https://bugs.webkit.org/show_bug.cgi?id=160702
826
827         Reviewed by Tim Horton.
828
829         * Scripts/webkitdirs.pm:
830         (iOSSimulatorDevices):
831
832 2016-08-06  Sam Weinig  <sam@webkit.org>
833
834         Replace NodeOrString with std::variant<RefPtr<Node>, String>
835         https://bugs.webkit.org/show_bug.cgi?id=160638
836
837         Reviewed by Anders Carlsson.
838
839         * TestWebKitAPI/CMakeLists.txt:
840         * TestWebKitAPI/Tests/WTF/Variant.cpp:
841         Add additional tests for the initial state of std::variant and using
842         makeVisitor for visiting.
843
844 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
845
846         EWS logging should ensure the logging to file is stopped on queue termination
847         https://bugs.webkit.org/show_bug.cgi?id=160698
848         rdar://problem/24464570
849
850         Reviewed by Daniel Bates.
851
852         * Scripts/webkitpy/tool/bot/queueengine.py:
853         (QueueEngine._stopping): Stop logging to file on queue termination.
854         (QueueEngine._begin_logging): Configure the Python logger to log to file.
855         * Scripts/webkitpy/common/system/logutils.py:
856         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
857         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
858         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
859         * Scripts/webkitpy/tool/commands/queues.py:
860         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
861         (AbstractQueue.queue_log_path): Same.
862         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
863         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
864         which moved to QueueEngine now.
865         (PatchProcessingQueue.__init__): Same.
866         (CommitQueue.__init__): Same.
867         (AbstractReviewQueue.__init__): Same.
868         (StyleQueue.__init__): Same.
869         * Scripts/webkitpy/tool/commands/queues_unittest.py:
870         (TestCommitQueue): Removed host parameter.
871         (TestCommitQueue.__init__): Same.
872         (AbstractPatchQueueTest.test_next_patch): Same.
873         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
874         (test_commit_queue_failure): Same.
875         (mock_run_webkit_patch):
876         (MockCommitQueueTask.results_from_patch_test_run): Same.
877         (test_rollout_lands): Same.
878         (test_non_valid_patch): Same.
879         (test_auto_retry): Same.
880         (test_style_queue_with_watch_list_exception): Same.
881         (TestQueue.__init__): Deleted.
882         (TestReviewQueue.__init__): Deleted.
883         (TestFeederQueue.__init__): Deleted.
884
885 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
886
887         webkit-gtk tarball fails to build due to missing files
888         https://bugs.webkit.org/show_bug.cgi?id=160684
889
890         Reviewed by Alex Christensen.
891
892         * gtk/manifest.txt.in: Added back spi directories.
893
894 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
895
896         [GTK] Build the jhbuild with -O2 optimization level by default
897         https://bugs.webkit.org/show_bug.cgi?id=160544
898
899         Reviewed by Michael Catanzaro.
900
901         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
902         which don't increases the required disk space significatively and
903         provides better debug information than no passing it.
904
905 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
906
907         Allow more --cmakeargs option in build-jsc and build-webkit
908         https://bugs.webkit.org/show_bug.cgi?id=160340
909
910         Reviewed by Michael Catanzaro.
911
912         * Scripts/build-jsc:
913         * Scripts/build-webkit:
914
915 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
916
917         Do not check if WebKitLibraries folder exists on EFL and GTK
918         https://bugs.webkit.org/show_bug.cgi?id=160659
919
920         Reviewed by Csaba Osztrogonác.
921
922         Though WebKitLibraries is only needed by mac and win ports,
923         EFL and GTK ports have checked whether it exists.
924
925         * Scripts/build-webkit:
926
927 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
928
929         Some EWS console logs doesn't go to log file
930         https://bugs.webkit.org/show_bug.cgi?id=160585
931         rdar://problem/24464570
932
933         Reviewed by Daniel Bates.
934
935         * Scripts/webkitpy/common/system/logutils.py:
936         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
937         any possible overwriting.
938         * Scripts/webkitpy/common/system/filesystem.py:
939         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
940         * Scripts/webkitpy/common/system/filesystem_mock.py:
941         (MockFileSystem.open_text_file_for_writing): Same.
942         * Scripts/webkitpy/common/system/filesystem_unittest.py:
943         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
944         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
945         * Scripts/webkitpy/tool/commands/queues.py:
946         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
947         This will ensure that all the sub-modules inside webkitpy will log to file.
948
949 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
950
951         Have the iOS platform interit from the Apple platform in webkitpy
952         https://bugs.webkit.org/show_bug.cgi?id=160672
953
954         Reviewed by Dan Bates.
955         
956         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
957         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
958         ApplePort.
959         
960         Since WinPort also inherits from ApplePort, it needs to stub out some things
961         that are unavailable on Windows (leaks, sampling).
962         
963         Some SnowLeopard-related code and the associated test were removed.
964
965         * Scripts/webkitpy/port/apple.py:
966         (ApplePort.__init__):
967         (ApplePort):
968         (ApplePort._make_leak_detector):
969         (ApplePort.default_timeout_ms):
970         (ApplePort.supports_per_test_timeout):
971         (ApplePort.should_retry_crashes):
972         (ApplePort._generate_all_test_configurations):
973         (ApplePort.check_for_leaks):
974         (ApplePort.print_leaks_summary):
975         (ApplePort._path_to_webcore_library):
976         (ApplePort.show_results_html_file):
977         (ApplePort._merge_crash_logs):
978         (ApplePort._look_for_all_crash_logs_in_log_dir):
979         (ApplePort._get_crash_log):
980         (ApplePort.look_for_new_crash_logs):
981         (ApplePort.sample_process):
982         (ApplePort.sample_file_path):
983         (ApplePort.look_for_new_samples):
984         (ApplePort._path_to_helper):
985         (ApplePort.determine_full_port_name): Deleted.
986         * Scripts/webkitpy/port/ios.py:
987         (IOSSimulatorPort):
988         (IOSSimulatorPort.__init__):
989         (IOSSimulatorPort.default_timeout_ms): Deleted.
990         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
991         (IOSSimulatorPort.should_retry_crashes): Deleted.
992         (IOSSimulatorPort.check_for_leaks): Deleted.
993         (IOSSimulatorPort.print_leaks_summary): Deleted.
994         (IOSSimulatorPort._path_to_webcore_library): Deleted.
995         (IOSSimulatorPort.show_results_html_file): Deleted.
996         (IOSSimulatorPort.sample_file_path): Deleted.
997         (IOSSimulatorPort._merge_crash_logs): Deleted.
998         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
999         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1000         (IOSSimulatorPort.look_for_new_samples): Deleted.
1001         (IOSSimulatorPort.sample_process): Deleted.
1002         (IOSSimulatorPort._path_to_helper): Deleted.
1003         (IOSSimulatorPort.make_command): Deleted.
1004         * Scripts/webkitpy/port/mac.py:
1005         (MacPort.__init__):
1006         (MacPort.make_command):
1007         (MacPort._build_java_test_support):
1008         (MacPort): Deleted.
1009         (MacPort.default_timeout_ms): Deleted.
1010         (MacPort.supports_per_test_timeout): Deleted.
1011         (MacPort.should_retry_crashes): Deleted.
1012         (MacPort.default_child_processes): Deleted.
1013         (MacPort.check_for_leaks): Deleted.
1014         (MacPort.print_leaks_summary): Deleted.
1015         (MacPort._path_to_webcore_library): Deleted.
1016         (MacPort.show_results_html_file): Deleted.
1017         (MacPort.sample_file_path): Deleted.
1018         (MacPort._merge_crash_logs): Deleted.
1019         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1020         (MacPort.look_for_new_crash_logs): Deleted.
1021         (MacPort.look_for_new_samples): Deleted.
1022         (MacPort.sample_process): Deleted.
1023         (MacPort._path_to_helper): Deleted.
1024         * Scripts/webkitpy/port/mac_unittest.py:
1025         (MacTest.test_default_child_processes): Deleted.
1026         * Scripts/webkitpy/port/win.py:
1027         (WinPort.look_for_new_samples):
1028         (WinPort):
1029         (WinPort.sample_process):
1030         (WinPort._make_leak_detector):
1031         (WinPort.check_for_leaks):
1032         (WinPort.print_leaks_summary):
1033         (WinPort._path_to_webcore_library):
1034
1035 2016-08-08  Matt Baker  <mattbaker@apple.com>
1036
1037         Unreviewed: moved myself to the reviewers list.
1038
1039         * Scripts/webkitpy/common/config/contributors.json:
1040
1041 2016-08-08  Chris Dumez  <cdumez@apple.com>
1042
1043         Update API tests in mac/SetDocumentURI.mm after r204247
1044         https://bugs.webkit.org/show_bug.cgi?id=160660
1045
1046         Reviewed by Alex Christensen.
1047
1048         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1049         (TestWebKitAPI::TEST):
1050
1051 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1052
1053         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1054         https://bugs.webkit.org/show_bug.cgi?id=159827
1055
1056         Reviewed by Daniel Bates.
1057
1058         This change was spurred by a process hang which occurred between tests and did
1059         not produce a meaningful crashlog.
1060
1061         * Scripts/webkitpy/port/driver.py:
1062         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1063
1064          * Scripts/webkitpy/port/ios.py:
1065         (IOSSimulatorPort):
1066         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1067         * Scripts/webkitpy/port/mac.py:
1068         (MacPort):
1069         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1070
1071         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1072         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1073
1074         * WebKitTestRunner/TestController.h:
1075         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1076         * WebKitTestRunner/TestInvocation.cpp:
1077         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1078
1079 2016-08-07  Dan Bernstein  <mitz@apple.com>
1080
1081         [Cocoa] Reply block leaks if the remote object doesn’t call it
1082         https://bugs.webkit.org/show_bug.cgi?id=160642
1083
1084         Reviewed by Sam Weinig.
1085
1086         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1087         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1088         (TEST): Added a test case that checks that the reply block is released even when it’s not
1089           called.
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1091         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1092           calling the completion handler.
1093
1094 2016-08-07  Chris Dumez  <cdumez@apple.com>
1095
1096         Write API test to cover crash fix in r204135
1097         https://bugs.webkit.org/show_bug.cgi?id=160587
1098
1099         Reviewed by Darin Adler.
1100
1101         Add API test to cover crash fix in r204135. This reproduces the crash
1102         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1103         callback.
1104
1105         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1106         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1107         (TEST):
1108
1109 2016-08-06  Chris Dumez  <cdumez@apple.com>
1110
1111         Unreviewed, rolling out r204226.
1112
1113         Broke some API tests
1114
1115         Reverted changeset:
1116
1117         "Write API test to cover crash fix in r204135"
1118         https://bugs.webkit.org/show_bug.cgi?id=160587
1119         http://trac.webkit.org/changeset/204226
1120
1121 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1122
1123         EWS Style Queue fails to process patches which fails validation
1124         https://bugs.webkit.org/show_bug.cgi?id=160632
1125
1126         Reviewed by Alexey Proskuryakov.
1127
1128         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1129         (StyleQueueTask.validate): Add more information about validation failure.
1130         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1131         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1132         (test_non_valid_patch): Add a unit test to test the above code path.
1133
1134 2016-08-06  Sam Weinig  <sam@webkit.org>
1135
1136         WTF needs a variant implementation
1137         https://bugs.webkit.org/show_bug.cgi?id=160618
1138
1139         Reviewed by Darin Adler.
1140
1141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1143         Add tests for the variant implementation.
1144
1145 2016-08-06  Chris Dumez  <cdumez@apple.com>
1146
1147         Write API test to cover crash fix in r204135
1148         https://bugs.webkit.org/show_bug.cgi?id=160587
1149
1150         Reviewed by Darin Adler.
1151
1152         Add API test to cover crash fix in r204135. This reproduces the crash
1153         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1154         callback.
1155
1156         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1157         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1158         (TEST):
1159
1160 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1161
1162         run-api-tests should use a headed simulator
1163         https://bugs.webkit.org/show_bug.cgi?id=160611
1164
1165         Reviewed by Sam Weinig.
1166
1167         CADisplayLink doesn't work in a headless simulator, but is
1168         vital for the proper functioning of WebKit2 painting on iOS.
1169         So, we should not use a headless simulator.
1170
1171         * Scripts/run-api-tests:
1172         Launch a simulator app, don't just boot the simulator.
1173
1174         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1175         Re-enable a test that works now.
1176
1177 2016-08-05  Dan Bernstein  <mitz@apple.com>
1178
1179         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1180         https://bugs.webkit.org/show_bug.cgi?id=160589
1181
1182         Reviewed by Tim Horton.
1183
1184         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1185         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1186           blocks, which wasn’t caught because the test wasn’t run correctly.
1187         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1188         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1189           added a test that sends over an NSRange.
1190         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1191         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1192           handler with the range‘s location and length.
1193
1194 2016-08-05  Enrica Casucci  <enrica@apple.com>
1195
1196         Fixing tests failing after r204175.
1197
1198         Unreviewed.
1199
1200         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1201
1202 2016-08-05  Enrica Casucci  <enrica@apple.com>
1203
1204         Build fix after 204053.
1205
1206         Unreviewed.
1207
1208         * TestWebKitAPI/Configurations/Base.xcconfig:
1209         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1210         (-[MockContentFilterEnabler initWithCoder:]):
1211         (-[MockContentFilterEnabler dealloc]):
1212
1213 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1214
1215         Print test name in "Last character read from DRT..." error message.
1216         https://bugs.webkit.org/show_bug.cgi?id=160559
1217
1218         Reviewed by Michael Catanzaro.
1219
1220         * Scripts/webkitpy/port/driver.py:
1221         (Driver.run_test):
1222         (Driver._read_first_block):
1223         (Driver._read_optional_image_block):
1224         (Driver._read_block):
1225         * Scripts/webkitpy/port/driver_unittest.py:
1226         (DriverTest.test_read_block):
1227         (DriverTest.test_read_binary_block):
1228         (DriverTest.test_read_base64_block):
1229
1230 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1231
1232         Unreviewed, rolling out r204123.
1233         https://bugs.webkit.org/show_bug.cgi?id=160597
1234
1235         Caused layout test timeouts on Windows. (Requested by perarne
1236         on #webkit).
1237
1238         Reverted changeset:
1239
1240         "[Win] Unable to reliably run tests in parallel"
1241         https://bugs.webkit.org/show_bug.cgi?id=140914
1242         http://trac.webkit.org/changeset/204123
1243
1244 2016-08-04  Saam Barati  <sbarati@apple.com>
1245
1246         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1247         https://bugs.webkit.org/show_bug.cgi?id=151241
1248
1249         Reviewed by Benjamin Poulain.
1250
1251         * Scripts/run-jsc-stress-tests:
1252
1253 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1254
1255         UI improvements to Flakiness Dashboard.
1256         https://bugs.webkit.org/show_bug.cgi?id=153295
1257
1258         Reviewed by Alexey Proskuryakov.
1259
1260         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1261         (td.options-container): Center text in most fields.
1262         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1263         (createBugHTML): Text/Grammar updates.
1264         (tableHeaders): Ditto.
1265         (htmlForSingleTestRow): Ditto.
1266         (headerForTestTableHtml): Ditto.
1267         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1268         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1269
1270 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1271
1272         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1273         https://bugs.webkit.org/show_bug.cgi?id=160518
1274
1275         Reviewed by Michael Catanzaro.
1276
1277         * Scripts/webkitpy/thirdparty/__init__.py:
1278         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1279         * gtk/install-dependencies:
1280
1281 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1282
1283         Optimize bot watcher's dashboard a little
1284         https://bugs.webkit.org/show_bug.cgi?id=160515
1285         rdar://problem/26096900
1286
1287         Reviewed by Lucas Forschler.
1288
1289         Made re-sorting after loading an iteration more efficient.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1292         (BuildbotIteration.prototype._updateWithData):
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1294         (BuildbotQueue.prototype.updateIterationPosition):
1295
1296 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1297
1298         [Win] Unable to reliably run tests in parallel
1299         https://bugs.webkit.org/show_bug.cgi?id=140914
1300
1301         Reviewed by Brent Fulgham.
1302
1303         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1304         processes. We can use string replacement to convert the Cygwin path to a Windows path
1305         instead.
1306  
1307         * Scripts/webkitpy/common/system/path.py:
1308         (cygpathFast):
1309         * Scripts/webkitpy/port/driver.py:
1310         (Driver._command_from_driver_input):
1311
1312 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1313
1314         Document instructions for increasing process and file limits
1315         https://bugs.webkit.org/show_bug.cgi?id=160528
1316         rdar://problem/24777576
1317
1318         Reviewed by Alexey Proskuryakov.
1319
1320         * Scripts/webkitpy/port/ios.py:
1321         (IOSSimulatorPort.default_child_processes):
1322
1323 2016-08-03  Anders Carlsson  <andersca@apple.com>
1324
1325         Remove the Objective-C bindings generator
1326         https://bugs.webkit.org/show_bug.cgi?id=160526
1327
1328         Reviewed by Sam Weinig.
1329
1330         * Scripts/run-bindings-tests:
1331         Update test.
1332
1333 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1334
1335         Revise a TestWebKitAPI comment to mention the actual underlying problem
1336
1337         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1338         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1339
1340 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1341
1342         Benchmark test content-animation timeouts always
1343         https://bugs.webkit.org/show_bug.cgi?id=160057
1344
1345         Reviewed by Simon Fraser.
1346
1347         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1348         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1349         (start):
1350
1351 2016-08-02  Nan Wang  <n_wang@apple.com>
1352
1353         AX: Simulated touch events are not working on iOS
1354         https://bugs.webkit.org/show_bug.cgi?id=160395
1355         <rdar://problem/27633597>
1356
1357         Reviewed by Chris Fleizach.
1358
1359         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1360         (WTR::AccessibilityUIElement::press):
1361         (WTR::AccessibilityUIElement::setSelectedChild):
1362
1363 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1364
1365         run-javascriptcore-tests should accept multiple --extra-tests
1366         https://bugs.webkit.org/show_bug.cgi?id=160486
1367
1368         Reviewed by Saam Barati.
1369         
1370         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1371         test suites. This does it by using GetOpt::Long's array support.
1372
1373         * Scripts/run-javascriptcore-tests:
1374         (runJSCStressTests):
1375
1376 2016-08-02  Enrica Casucci  <enrica@apple.com>
1377
1378         Allow building with content filtering disabled.
1379         https://bugs.webkit.org/show_bug.cgi?id=160454
1380
1381         Reviewed by Simon Fraser.
1382
1383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1384
1385 2016-08-02  Brady Eidson  <beidson@apple.com>
1386
1387         Removing IndexedDB WebsiteData can fail for some users.
1388         https://bugs.webkit.org/show_bug.cgi?id=160463
1389
1390         Reviewed by Alex Christensen.
1391
1392         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1393
1394 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1395
1396         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1397         https://bugs.webkit.org/show_bug.cgi?id=160437
1398         <rdar://problem/27578272>
1399
1400         Reviewed by Brady Eidson.
1401
1402         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1403         (-[DownloadDelegate _download:didReceiveResponse:]):
1404         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1405         (runTest):
1406         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1407
1408 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1409
1410         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1411         https://bugs.webkit.org/show_bug.cgi?id=160414
1412
1413         Reviewed by Michael Catanzaro.
1414
1415         * Scripts/webkitpy/port/linux_get_crash_log.py:
1416         (GDBCrashLogGenerator._wait_for_corefile):
1417
1418 2016-08-01  Youenn Fablet  <youenn@apple.com>
1419
1420         Make wpt server generate its certificates in layout test results folder
1421         https://bugs.webkit.org/show_bug.cgi?id=160422
1422
1423         Reviewed by Chris Dumez.
1424
1425         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1426         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1427
1428 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1429
1430         Function Call on NULL Object
1431         https://bugs.webkit.org/show_bug.cgi?id=160325
1432
1433         Reviewed by Darin Adler.
1434
1435         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1436         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1437         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1438
1439 2016-08-01  Keith Miller  <keith_miller@apple.com>
1440
1441         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1442         https://bugs.webkit.org/show_bug.cgi?id=160372
1443
1444         Rubber stamped by Geoffrey Garen.
1445
1446         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1447         a new top level directory, JSTests. Having the tests in the Source directory
1448         was both confusing an inconvenient for people that just want to checkout the
1449         source code of WebKit. Since there is no other obvious place to put all the
1450         JavaScript tests a new top level directory seemed the most sensible.
1451
1452         * Scripts/import-test262-tests:
1453         * Scripts/run-javascriptcore-tests:
1454         * Scripts/update-javascriptcore-test-res:
1455
1456 2016-07-31  Nan Wang  <n_wang@apple.com>
1457
1458         AX: Add a check for touch event listener on iOS accessibility object
1459         https://bugs.webkit.org/show_bug.cgi?id=160388
1460
1461         Reviewed by Chris Fleizach.
1462
1463         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1464         (AccessibilityUIElement::boolAttributeValue):
1465         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1466         (WTR::AccessibilityUIElement::boolAttributeValue):
1467
1468 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1469
1470         Unreviewed: add myself to the reviewers list.
1471
1472         * Scripts/webkitpy/common/config/contributors.json:
1473
1474 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1475
1476         Undo r203939, and copy over a rule that clips the logos.
1477
1478         Sierra wasn't the only logo without transparency.
1479
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1483
1484 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1485
1486         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1487         https://bugs.webkit.org/show_bug.cgi?id=160377
1488
1489         Reviewed by Brian Weinstein.
1490
1491         Update assets to remove the white background and use a transparent background instead.
1492
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1495
1496 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1497
1498         Ignore most check-webkit-style checks for ANGLE project
1499         <https://webkit.org/b/160333>
1500
1501         Reviewed by Daniel Bates.
1502
1503         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1504         - No tabs.
1505         - No spaces at the end of lines.
1506         - No carriage returns (DOS line endings).
1507
1508 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1509
1510         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1511         https://bugs.webkit.org/show_bug.cgi?id=160360
1512         <rdar://problem/27179484>
1513
1514         Reviewed by Myles C. Maxfield.
1515
1516         Adds two tests verifying that videos may be considered main content as long as they
1517         are large enough and cover a majority of the mainframe's viewport.
1518
1519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1520         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1521         (TestWebKitAPI::TEST):
1522         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1523         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1524
1525 2016-07-29  Mark Lam  <mark.lam@apple.com>
1526
1527         Gardening: removed unused variable.
1528
1529         Not reviewed.
1530
1531         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1532         (TestWebKitAPI::TEST):
1533
1534 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1535
1536         Add TestWebKitAPI support for interacting with media controls
1537         https://bugs.webkit.org/show_bug.cgi?id=160342
1538         <rdar://problem/27610246>
1539
1540         Reviewed by Beth Dakin.
1541
1542         Adds support for testing interaction with some media controls, as well as a basic test
1543         verifying that media control teardown after interaction does not result in a crash.
1544
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1546         (-[WKWebView mouseDownAtPoint:]):
1547         (-[WKWebView performAfterLoading:]):
1548         (TestWebKitAPI::TEST):
1549
1550 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1551
1552         Crash Log Clobbering on Unbound Crashes
1553         https://bugs.webkit.org/show_bug.cgi?id=160198
1554         <rdar://problem/27472618>
1555
1556         Reviewed by Alexey Proskuryakov.
1557
1558         * Scripts/webkitpy/common/system/crashlogs.py:
1559         (CrashLogs): Fix header order.
1560         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1561         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1562
1563 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1564
1565         Update for contributors.json
1566         https://bugs.webkit.org/show_bug.cgi?id=160294
1567
1568         * Scripts/webkitpy/common/config/contributors.json:
1569
1570 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1571
1572         Remove deprecated SPI for video inline / fullscreen controls
1573         https://bugs.webkit.org/show_bug.cgi?id=160318
1574
1575         Reviewed by Tim Horton.
1576
1577         * DumpRenderTree/mac/DumpRenderTree.mm:
1578         (setDefaultsToConsistentValuesForTesting): Deleted.
1579         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1580         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1583         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1584         (WTR::initializeWebViewConfiguration): Deleted.
1585
1586 2016-07-28  Daniel Bates  <dabates@apple.com>
1587
1588         [iOS] TestWebKitAPI bundle targets are not code signed
1589         https://bugs.webkit.org/show_bug.cgi?id=160328
1590         <rdar://problem/27409246>
1591
1592         Reviewed by Andy Estes.
1593
1594         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1595         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1596         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1597
1598         * TestWebKitAPI/Configurations/Base.xcconfig:
1599
1600 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1601
1602         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1603
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1605         (animatedResizeWebView):
1606         (TEST):
1607         This test times out only when run in the WebKit Testing simulator environment,
1608         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1609
1610 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1611
1612         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1613         https://bugs.webkit.org/show_bug.cgi?id=160289
1614         <rdar://problem/27553464>
1615
1616         Reviewed by Simon Fraser.
1617
1618         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1620         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1621         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1622         (-[AnimatedResizeWebView _endAnimatedResize]):
1623         (animatedResizeWebView):
1624         (TEST):
1625         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1626         Add two tests that ensure that hidden-content and animated resizes
1627         don't cause unnecessary synchronous waits. Only the hidden-content
1628         one fails before my patch, but it seemed reasonable to add both anyway.
1629
1630 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1631
1632         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1633         <https://webkit.org/b/83342>
1634
1635         Reviewed by Ryosuke Niwa.
1636
1637         * Scripts/webkitpy/common/checkout/scm/git.py:
1638         (Git.revisions_changing_file): Remove code to raise an exception
1639         when the file doesn't exist.  If a file was moved or renamed,
1640         then this caused the script to terminate, which was very
1641         frustrating when you wanted a list of reviewers.
1642         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1643         (SCMTest._shared_test_revisions_changing_file): Update test
1644         expectation to return an empty list of revisions.
1645         (test_create_patch_is_full_patch): Drive-by fix when running all
1646         webkitpy tests (including scm tests).
1647         * Scripts/webkitpy/common/checkout/scm/svn.py:
1648         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1649         return an empty array of revisions if this occurs.
1650
1651 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1652
1653         EWS error message "Error: * did not process patch" should include explanation
1654         https://bugs.webkit.org/show_bug.cgi?id=159903
1655         <rdar://problem/27410788>
1656
1657         Reviewed by Alexey Proskuryakov.
1658
1659         * QueueStatusServer/handlers/statusbubble.py:
1660         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1661         is not processed.
1662         * QueueStatusServer/handlers/processingtimesjson.py:
1663         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1664         of the code.
1665         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1666         (CommitQueueTask.validate): Add more information about validation failure.
1667         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1668         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1669         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1670         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1671         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1672         (PatchIsNotValid.__init__): Add the failure_message argument.
1673         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1674         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1675         failure details.
1676         * Scripts/webkitpy/tool/commands/queues.py:
1677         (CommitQueue.process_work_item): Same.
1678         (StyleQueue.review_patch): Same.
1679         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1680         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1681
1682 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1683
1684         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1685         https://bugs.webkit.org/show_bug.cgi?id=160262
1686
1687         Reviewed by Daniel Bates.
1688
1689         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1690         (-[LTRelayController installApp]):
1691
1692 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1693
1694         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1695         https://bugs.webkit.org/show_bug.cgi?id=160225
1696
1697         Reviewed by Alexey Proskuryakov.
1698
1699         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1700
1701 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1702
1703         [GTK] Fix some video/canvas tests that should be passing
1704         https://bugs.webkit.org/show_bug.cgi?id=160023
1705
1706         Reviewed by Carlos Garcia Campos.
1707
1708         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1709         EFL or GTK platforms.
1710
1711         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1712         (WTR::TestController::platformConfigureViewForTest):
1713         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1714         (WTR::TestController::platformConfigureViewForTest):
1715
1716 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1717
1718         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1719         https://bugs.webkit.org/show_bug.cgi?id=160247
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         * BuildSlaveSupport/built-product-archive:
1724         (createZip):
1725         (dirContainsdwo):
1726         (archiveBuiltProduct):
1727
1728 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1729
1730         Fix tests after r203743.
1731         https://bugs.webkit.org/show_bug.cgi?id=156947
1732
1733         * WebKitTestRunner/TestController.cpp:
1734         (WTR::TestController::resetStateToConsistentValues):
1735         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1736
1737 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1738
1739         [iPhone] Playing a video on tudou.com plays only sound, no video
1740         https://bugs.webkit.org/show_bug.cgi?id=160178
1741         <rdar://problem/27535468>
1742
1743         Reviewed by Dan Bernstein.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (setDefaultsToConsistentValuesForTesting):
1747         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1748         (RequiresUserActionForPlaybackTest::SetUp):
1749         * WebKitTestRunner/TestController.cpp:
1750         (WTR::TestController::resetPreferencesToConsistentValues):
1751         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1752         (WTR::initializeWebViewConfiguration):
1753
1754 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1755
1756         Allow LOG macros to be used outside the namespace, and other logging cleanup
1757         https://bugs.webkit.org/show_bug.cgi?id=160216
1758
1759         Reviewed by Anders Carlsson.
1760         
1761         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1762
1763         * DumpRenderTree/TestRunner.cpp:
1764         * DumpRenderTree/mac/DumpRenderTree.mm:
1765         (resetWebViewToConsistentStateBeforeTesting):
1766
1767 2016-07-26  David Kilzer <ddkilzer@apple.com>
1768
1769         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1770         https://bugs.webkit.org/show_bug.cgi?id=156947
1771         <rdar://problem/23325160>
1772
1773         Reviewed by Alex Christensen.
1774
1775         * DumpRenderTree/TestRunner.cpp:
1776         (TestRunner::TestRunner):
1777         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1778         * DumpRenderTree/TestRunner.h:
1779         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1780         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1781         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1782         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1783         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1785         (WTR::TestRunner::queueNonLoadingScript):
1786         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1787         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1788         * WebKitTestRunner/TestController.cpp:
1789         (WTR::TestController::didReceiveAuthenticationChallenge):
1790         * WebKitTestRunner/TestController.h:
1791         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1792         * WebKitTestRunner/TestInvocation.cpp:
1793         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1794         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1795
1796 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1797
1798         check-for-exit-time-destructors should be usable outside Xcode
1799         <https://webkit.org/b/160195>
1800
1801         Reviewed by Darin Adler.
1802
1803         * Scripts/check-for-exit-time-destructors: Update to parse
1804         -h|--help switch, or to take one argument to a binary to check
1805         for exit time destructors on the command-line.  The clang
1806         compiler will find these at compile-time with the
1807         -Wexit-time-destructors switch, but this script will check for
1808         them after-the-fact.
1809
1810 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1811
1812         Test svn.webkit.org functionality after maintenance.
1813
1814 2016-07-25  Brady Eidson  <beidson@apple.com>
1815
1816         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1817         https://bugs.webkit.org/show_bug.cgi?id=153783
1818
1819         Reviewed by Alex Christensen.
1820
1821         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1822         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1823         
1824         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1825         
1826         Change the relevant API tests to make sure this continues to be no longer required.
1827
1828         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1829         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1830         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1831         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1833         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1834
1835 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1836
1837         Media controls should not be displayed for a video until it starts playing
1838         https://bugs.webkit.org/show_bug.cgi?id=160092
1839         <rdar://problem/26986673>
1840
1841         Reviewed by Beth Dakin.
1842
1843         Verify that multiple videos do or don't show the media controller depending on whether videos
1844         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1845         passing because we were always showing media controls for large videos with audio, even if they
1846         had not played back yet. This change ensures that large videos with audio show media controls
1847         only after they begin to play back, and not by virtue of being large enough for main content.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1853         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1854         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1855
1856 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1857
1858         Media controls on apple.com don't disappear when movie finishes playing
1859         https://bugs.webkit.org/show_bug.cgi?id=160068
1860         <rdar://problem/26668526>
1861
1862         Reviewed by Darin Adler.
1863
1864         Adds new API tests. Please see WebCore ChangeLog for more details.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1868         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1869         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1870         (TestWebKitAPI::TEST):
1871         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1872         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1873         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1874         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1875         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1876
1877 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1878
1879         Unreviewed, fix test-webkitpy after r203674.
1880
1881         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1882         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1883
1884 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1885
1886         Unreviewed, forgot to commit this file in r203674.
1887
1888         * Scripts/process-linux-coredump: Added.
1889         (main):
1890
1891 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1892
1893         Improve GDB backtrace generation for GTK/EFL
1894         https://bugs.webkit.org/show_bug.cgi?id=128928
1895
1896         Reviewed by Carlos Garcia Campos.
1897
1898         The PID of the crashed process is now correctly supplied to the
1899         crash log reporter. The kernel core_pattern needs to be updated
1900         after this change to something like:
1901
1902         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1903
1904         * Scripts/process-linux-coredump: Added.
1905         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1906         * Scripts/webkitpy/port/efl.py:
1907         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1908         * Scripts/webkitpy/port/gtk.py:
1909         (GtkPort._get_crash_log): Ditto.
1910         * Scripts/webkitpy/port/linux_get_crash_log.py:
1911         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1912         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1913         (GDBCrashLogGenerator): Deleted.
1914         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1915         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1916         * WebKitTestRunner/TestController.cpp:
1917         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1918         (WTR::TestController::databaseProcessDidCrash): Ditto.
1919         (WTR::TestController::processDidCrash): Ditto.
1920
1921 2016-07-23  Youenn Fablet  <youenn@apple.com>
1922
1923         WPT stash server should be kept running when launching wpt server
1924         https://bugs.webkit.org/show_bug.cgi?id=160052
1925
1926         Reviewed by Sam Weinig.
1927
1928         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1929         (main): waiting to read stdin while stash server is started.
1930
1931 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1932
1933         Media controls should be displayed for media in media documents
1934         https://bugs.webkit.org/show_bug.cgi?id=160104
1935         <rdar://problem/27438936>
1936
1937         Reviewed by Myles C. Maxfield.
1938
1939         Verifies that even a small video with audio in a media document gets media controls.
1940
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1942         (TestWebKitAPI::TEST):
1943
1944 2016-07-22  Michael Saboff  <msaboff@apple.com>
1945
1946         REGRESSION(203616): no FTL testing was inadvertently removed
1947         https://bugs.webkit.org/show_bug.cgi?id=160100
1948
1949         Rubber-stamped by Filip Pizlo.
1950
1951         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1952         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1953         logic for the runLayout and runNoisy variants to match the run test logic,
1954         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1955         enabled platforms.
1956
1957         * Scripts/run-jsc-stress-tests:
1958
1959 2016-07-22  Brady Eidson  <beidson@apple.com>
1960
1961         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1962         https://bugs.webkit.org/show_bug.cgi?id=160089
1963
1964         Reviewed by Darin Adler.
1965
1966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1967         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1968         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1969
1970 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1971
1972         [GTK] Improved exclusion patterns in make-dist.py manifest.
1973         https://bugs.webkit.org/show_bug.cgi?id=160094
1974
1975         Reviewed by Michael Catanzaro.
1976
1977         * gtk/manifest.txt.in:
1978         Exclude Platform*.cmake files for more ports.
1979         Removed obsolete .gyp and .pro.user patterns.
1980         Exclude 'Configurations' and 'spi' directories.
1981         Exclude CMakeLists.txt.user (Qt Creator IDE).
1982
1983 2016-07-22  Michael Saboff  <msaboff@apple.com>
1984
1985         Don't run FTL related JSC stress tests on non-FTL platforms
1986         https://bugs.webkit.org/show_bug.cgi?id=160033
1987
1988         Reviewed by Mark Lam.
1989
1990         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1991         Refactored several of the runXXX test methods to always runXXXDefault and made those
1992         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1993         doesn't cause a problem.
1994
1995         * Scripts/run-jsc-stress-tests:
1996
1997 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1998
1999         IWebView::mainFrame crashes if called after IWebView::close
2000         https://bugs.webkit.org/show_bug.cgi?id=32868
2001
2002         Reviewed by Brent Fulgham.
2003
2004         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2005         (TestWebKitAPI::TEST_F): Added test.
2006
2007 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2008
2009         [GTK] Enable threaded compositor by default
2010         https://bugs.webkit.org/show_bug.cgi?id=160079
2011
2012         Reviewed by Žan Doberšek.
2013
2014         * Scripts/webkitperl/FeatureList.pm:
2015
2016 2016-07-22  Youenn Fablet  <youenn@apple.com>
2017
2018         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2019         https://bugs.webkit.org/show_bug.cgi?id=159921
2020
2021         Reviewed by Brian Burg.
2022
2023         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2024
2025         * Scripts/webkitpy/codegen/main.py:
2026         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2027         (BuiltinsGeneratorTests):
2028         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2029         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2030         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2031         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2032
2033 2016-07-21  Dan Bernstein  <mitz@apple.com>
2034
2035         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2036         https://bugs.webkit.org/show_bug.cgi?id=160072
2037
2038         Reviewed by Andy Estes.
2039
2040         * Scripts/webkitdirs.pm:
2041         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2042           for old Xcode versions.
2043         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2044           to readXcodeUserDefault.
2045         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2046           debugger.
2047         (determineDebugger): Ditto.
2048         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2049           7.0.
2050         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2051           switches.
2052         (execMacWebKitAppForDebugging): Removed support for GDB.
2053
2054 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2055
2056         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2057         https://bugs.webkit.org/show_bug.cgi?id=160066
2058
2059         Reviewed by Dean Jackson.
2060
2061         * DumpRenderTree/mac/DumpRenderTree.mm:
2062         (setDefaultsToConsistentValuesForTesting): Deleted.
2063         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2064         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2065         * WebKitTestRunner/TestController.cpp:
2066         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2067         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2068         (WTR::initializeWebViewConfiguration): Deleted.
2069
2070 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2071
2072         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2073         https://bugs.webkit.org/show_bug.cgi?id=159980
2074         rdar://problem/27450825
2075
2076         Reviewed by Dan Bernstein.
2077
2078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2079         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2080         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2081         when our delegate has hit -dealloc.
2082         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2083         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2084         will not be messaged.
2085
2086 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2087
2088         Follow-up patch to r203520
2089         https://bugs.webkit.org/show_bug.cgi?id=159967
2090         <rdar://problem/26964090>
2091
2092         Unreviewed.
2093
2094         * DumpRenderTree/mac/DumpRenderTree.mm:
2095         (setDefaultsToConsistentValuesForTesting):
2096         * WebKitTestRunner/TestController.cpp:
2097         (WTR::TestController::resetPreferencesToConsistentValues):
2098
2099 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2100
2101         [iPhone] Playing a video on tudou.com plays only sound, no video
2102         https://bugs.webkit.org/show_bug.cgi?id=159967
2103         <rdar://problem/26964090>
2104
2105         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2106
2107         Migrate tests to use new SPI.
2108
2109         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2110         (RequiresUserActionForPlaybackTest::SetUp):
2111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2112         (WTR::initializeWebViewConfiguration):
2113
2114 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2115
2116         Clarify testing mode names in run-jsc-stress-tests
2117         https://bugs.webkit.org/show_bug.cgi?id=160021
2118
2119         Reviewed by Mark Lam.
2120
2121         Default should mean really default, not default with disabled FTL, renamed
2122         - runMozillaTestDefault to runMozillaTestNoFTL
2123         - runMozillaTestDefaultFTL to runMozillaTestDefault
2124         - runDefault to runNoFTL
2125         - runDefaultFTL to runDefault
2126         - runLayoutTestDefault to runLayoutTestNoFTL
2127         - runLayoutTestDefaultFTL to runLayoutTestDefault
2128         - runNoisyTestDefault to runNoisyTestNoFTL
2129         - runNoisyTestDefaultFTL to runNoisyTestDefault
2130
2131         * Scripts/run-jsc-stress-tests:
2132
2133 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2134
2135         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2136         https://bugs.webkit.org/show_bug.cgi?id=159986
2137
2138         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2139         to 0.
2140
2141         Reviewed by Dan Bernstein.
2142
2143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2144         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2145         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2146         (TEST):
2147
2148 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2149
2150         [GTK] Web view background colors don't work in accelerated compositing mode
2151         https://bugs.webkit.org/show_bug.cgi?id=159455
2152
2153         Reviewed by Michael Catanzaro.
2154
2155         Set always RGBA visual to the view widget when setting a background color.
2156
2157         * MiniBrowser/gtk/BrowserWindow.c:
2158         (browser_window_set_background_color):
2159
2160 2016-07-20  Youenn Fablet  <youenn@apple.com>
2161
2162         Bots should run built-ins generator tests
2163         https://bugs.webkit.org/show_bug.cgi?id=159971
2164
2165         Reviewed by Alexey Proskuryakov.
2166
2167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2168         (RunBuiltinsTests): New step to run built-in generator tests.
2169         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2170         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2172
2173 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2174
2175         Revert temporary fix r203417
2176         https://bugs.webkit.org/show_bug.cgi?id=160001
2177
2178         Reviewed by Alexey Proskuryakov.
2179
2180         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2181
2182 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2183
2184         REGRESSION(r148588): ews classes might get garbage collected
2185         https://bugs.webkit.org/show_bug.cgi?id=159990
2186
2187         Reviewed by Ryosuke Niwa.
2188
2189         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2190         in a variable so that they do not get garbage collected.
2191
2192 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2193
2194         Add API test for layout constraints after exit fullscreen
2195         https://bugs.webkit.org/show_bug.cgi?id=159900
2196
2197         Reviewed by Jon Lee.
2198
2199         Added Fullscreen.LaytoutConstraints API test. 
2200         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2201
2202         This test compares layout constraints on the web view before and after fullscreen to make sure 
2203         they are preserved.
2204
2205         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2206         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2207         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2208         (TestWebKitAPI::TEST):
2209
2210 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2211
2212         Disable two failing API tests.
2213
2214         Unreviewed test gardening.
2215
2216         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2217         (TestWebKitAPI::TEST):
2218
2219 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2220
2221         Unreviewed iOS build fix.
2222
2223         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2224
2225 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2226
2227         Media controls don't appear when pausing a small autoplaying video
2228         https://bugs.webkit.org/show_bug.cgi?id=159972
2229         <rdar://problem/27180657>
2230
2231         Reviewed by Beth Dakin.
2232
2233         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2234         for simulating basic user interaction in VideoControlsManager.
2235
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2238         (-[WKWebView mouseDownAtPoint:]):
2239         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2240         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2241         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2242         (TestWebKitAPI::TEST):
2243         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2244
2245 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2246
2247         [Win] MathML fonts are not found.
2248         https://bugs.webkit.org/show_bug.cgi?id=159920
2249
2250         Reviewed by Alex Christensen.
2251
2252         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2253         for a specific registry key value.
2254
2255         * Scripts/webkitdirs.pm:
2256         (fontExists):
2257
2258 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2259
2260         Improve prepare-ChangeLog for @media blocks
2261         https://bugs.webkit.org/show_bug.cgi?id=159907
2262
2263         Reviewed by Timothy Hatcher.
2264
2265         * Scripts/prepare-ChangeLog:
2266         (get_selector_line_ranges_for_css):
2267         Get a range for @media blocks just like a selector.
2268             Start Line = line with '{'
2269             End line = line with '}'
2270             Name = "@media ..."
2271
2272         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2273         Improved error messages for unbalanced portions.
2274
2275         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2276         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2277         (.media-query::before):
2278         (@media only screen and (max-width: 980px)):
2279         (.media-query a):
2280         (@media (-webkit-min-device-pixel-ratio: 2)):
2281         (.both a):
2282         (.both b):
2283         (.media-query b):
2284         (.media-query::after):
2285
2286 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2287
2288         Fix expectedFailErrorHandler in run-jsc-stress-tests
2289         https://bugs.webkit.org/show_bug.cgi?id=159811
2290
2291         Reviewed by Yusuke Suzuki.
2292
2293         * Scripts/run-jsc-stress-tests:
2294
2295 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2296
2297         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2298
2299         * TestWebKitAPI/PlatformMac.cmake:
2300
2301 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2302
2303         The default testing mode should not involve disabling the FTL JIT
2304         https://bugs.webkit.org/show_bug.cgi?id=159929
2305
2306         Rubber stamped by Mark Lam and Saam Barati.
2307         
2308         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2309         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2310         FTL was not the default. You had to enable it with an option.
2311         
2312         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2313         all of the major ports. This has become a serious pain. For example, it's useful to be able
2314         to say that a test should only run in the default config that is representative of what a
2315         normal user would see if they ran JSC. Clearly, this would be a config that does not
2316         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2317         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2318         
2319         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2320         try to fix it, because:
2321         
2322         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2323           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2324           doesn't do anything. The code is not really structured to allow this.
2325         
2326         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2327           disabled in testing. On the other hand there are already build bots that do FTL tests
2328           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2329           preserving this broken feature, we should create something that (a) acknowledges the fact
2330           that the FTL is the default on those platforms that support it and (b) avoids running
2331           no-ftl tests on precisely those platforms that don't have FTL.
2332         
2333         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2334           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2335           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2336           pretending that the FTL JIT is not the default just because some bots used that as an
2337           optimization.
2338         
2339         This change allows me to speed up some debug tests and paint some bots green.
2340
2341         * Scripts/run-javascriptcore-tests:
2342         (runJSCStressTests):
2343         * Scripts/run-jsc-stress-tests:
2344
2345 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2346
2347         Fix API test after r203426.
2348         https://bugs.webkit.org/show_bug.cgi?id=159949
2349
2350         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2351         (TEST):
2352         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2353         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2354
2355 2016-07-19  Andy Estes  <aestes@apple.com>
2356
2357         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2358         https://bugs.webkit.org/show_bug.cgi?id=159956
2359
2360         Reviewed by Dan Bernstein.
2361
2362         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2363         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2364         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2365         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2366
2367 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2368
2369         Add regression test for r203392
2370         https://bugs.webkit.org/show_bug.cgi?id=159949
2371
2372         Reviewed by Brady Eidson.
2373
2374         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2375         (fileSize):
2376         (swizzledBundleIdentifierWebBookmarksD):
2377         (defaultApplicationCacheDirectory):
2378         (TEST):
2379         (swizzledBundleIdentifierMobileSafari): Deleted.
2380         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2381         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2382         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2383
2384 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2385
2386         Add regression test for r203392
2387         https://bugs.webkit.org/show_bug.cgi?id=159949
2388
2389         Reviewed by Brady Eidson.
2390
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2392         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2393         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2394         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2395         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2396         (TEST):
2397         (fileSize):
2398         (swizzledBundleIdentifierMobileSafari):
2399         (swizzledBundleIdentifierWebBookmarksD):
2400         (defaultApplicationCacheDirectory):
2401         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2402         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2403         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2404         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2405
2406 2016-07-19  Keith Miller  <keith_miller@apple.com>
2407
2408         Test262 should have a file with the revision and url
2409         https://bugs.webkit.org/show_bug.cgi?id=159937
2410
2411         Reviewed by Mark Lam.
2412
2413         The import script should update the information from
2414         the path to the test262 repository it gets.
2415
2416         * Scripts/import-test262-tests:
2417
2418 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2419
2420         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2421         To be deleted once the root cause is found and addressed.
2422
2423         * EWSTools/start-queue-mac.sh:
2424
2425 2016-07-19  Frederic Wang  <fwang@igalia.com>
2426
2427         [win] Fixup the register name for STIX Math and Latin Modern Math
2428
2429         Unreviewed follow-up of r203406
2430
2431         * Scripts/webkitdirs.pm:
2432         (checkInstalledTools):
2433
2434 2016-07-19  Frederic Wang  <fwang@igalia.com>
2435
2436         [win] Update the list of MathML fonts
2437         https://bugs.webkit.org/show_bug.cgi?id=156838
2438
2439         The set of recommended math fonts is now described at
2440         https://trac.webkit.org/wiki/MathML/Fonts
2441         We update the Perl script to use the latest list of fonts.
2442
2443         Reviewed by Brent Fulgham.
2444
2445         * Scripts/webkitdirs.pm:
2446         (checkInstalledTools):
2447
2448 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2449
2450         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2451         https://bugs.webkit.org/show_bug.cgi?id=159342
2452
2453         Reviewed by Darin Adler.
2454
2455         Implement required functions in event sender.
2456
2457         * DumpRenderTree/PlatformWin.cmake:
2458         * DumpRenderTree/win/EventSender.cpp:
2459         (monitorWheelEvents): Added.
2460         (callAfterScrollingCompletes): Added.
2461
2462 2016-07-19  Youenn Fablet  <youenn@apple.com>
2463
2464         Add new aliases to http test server
2465         https://bugs.webkit.org/show_bug.cgi?id=159878
2466
2467         Reviewed by Darin Adler.
2468
2469         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2470         Adding explicitly these links to perl script.
2471         Extracting default alias in an aliases.json file.
2472         Reading that file from python scripts to initialize aliases from that file.
2473
2474         Python script changes covered by unit tests and changed layout test.
2475
2476         * Scripts/webkitperl/httpd.pm:
2477         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2478         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2479         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2480         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2481         Adding -c directives for each alias.
2482         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2483         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2484         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2485         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2486         Adding alias directive for each alias.
2487         (Lighttpd._prepare_config):
2488         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2489         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2490         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2491         layout tests directory.
2492         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2493         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2494         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2495
2496 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2497
2498         EWS console logs doesn't go to log file
2499         https://bugs.webkit.org/show_bug.cgi?id=159539
2500         <rdar://problem/24464570>
2501
2502         Reviewed by David Kilzer.
2503
2504         * Scripts/webkitpy/common/system/logutils.py:
2505         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2506         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2507         to filesystem. It also supports passing MockFilesystem.
2508         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2509         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2510         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2511         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2512         (_test_ews): Same.
2513         * Scripts/webkitpy/tool/commands/queues.py:
2514         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2515         (AbstractQueue._log_directory): Using filesystem object instead of os.
2516         (AbstractQueue.queue_log_path): Same.
2517         (AbstractQueue.__init__): Passed host parameter.
2518         (PatchProcessingQueue.__init__): Same.
2519         (CommitQueue.__init__): Same.
2520         (AbstractReviewQueue.__init__): Same.
2521         (StyleQueue.__init__): Same.
2522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2523         (TestCommitQueue): Passed MockHost() as host.
2524         (TestCommitQueue.__init__): Same.
2525         (TestQueue.__init__): Same.
2526         (TestReviewQueue.__init__): Same.
2527         (TestFeederQueue.__init__): Same.
2528         (AbstractPatchQueueTest.test_next_patch): Same.
2529         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2530         (test_commit_queue_failure): Same.
2531         (MockCommitQueueTask.results_from_patch_test_run): Same.
2532         (test_rollout_lands): Same.
2533         (test_non_valid_patch): Same.
2534         (test_auto_retry): Same.
2535         (test_style_queue_with_watch_list_exception): Same.
2536
2537 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2538
2539         WTF::Lock should be fair eventually
2540         https://bugs.webkit.org/show_bug.cgi?id=159384
2541
2542         Reviewed by Geoffrey Garen.
2543
2544         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2545
2546 2016-07-17  Sam Weinig  <sam@webkit.org>
2547
2548         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2549         <rdar://problem/26554137>
2550         https://bugs.webkit.org/show_bug.cgi?id=159856
2551
2552         Reviewed by Dan Bernstein.
2553
2554         * MiniBrowser/mac/WK2BrowserWindowController.m:
2555         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2556         Add basic window.open implementation.
2557
2558         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2559         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2560         to open a single non-web URL, all others are dropped.
2561
2562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2563         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2564         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2565         Add API for the new SPI.
2566
2567 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2568
2569         [JSC] Enable test262 module tests
2570         https://bugs.webkit.org/show_bug.cgi?id=159854
2571
2572         Reviewed by Saam Barati.
2573
2574         Use --module-file instead.
2575
2576         * Scripts/run-jsc-stress-tests:
2577
2578 2016-07-16  Chris Dumez  <cdumez@apple.com>
2579
2580         Unreviewed, rolling out r203318.
2581
2582         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2583         SunSpider)
2584
2585         Reverted changeset:
2586
2587         "[JSC] Change some parameters based on a random search"
2588         https://bugs.webkit.org/show_bug.cgi?id=158514
2589         http://trac.webkit.org/changeset/203318
2590
2591 2016-07-16  Chris Dumez  <cdumez@apple.com>
2592
2593         Add move constructor / assignment operator to ListHashSet
2594         https://bugs.webkit.org/show_bug.cgi?id=159837
2595
2596         Reviewed by Darin Adler.
2597
2598         Add API tests.
2599
2600         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2601         (TestWebKitAPI::TEST):
2602
2603 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2604
2605         [JSC] Change some parameters based on a random search
2606         https://bugs.webkit.org/show_bug.cgi?id=158514
2607
2608         Reviewed by Saam Barati.
2609
2610         * Scripts/run-jsc-stress-tests:
2611
2612 2016-07-15  Jon Davis  <jond@apple.com>
2613
2614         Changed the start page URL for WebKit Nightly builds.
2615         https://bugs.webkit.org/show_bug.cgi?id=159816
2616
2617         Reviewed by Timothy Hatcher.
2618
2619         * WebKitLauncher/start.html:
2620
2621 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2622
2623         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2624         https://bugs.webkit.org/show_bug.cgi?id=159414
2625
2626         Reviewed by Brent Fulgham.
2627
2628         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2629         when the HDC parameter is invalid.
2630
2631         * TestWebKitAPI/PlatformWin.cmake:
2632         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2633         (TestWebKitAPI::TEST):
2634
2635 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2636
2637         [GTK] Add basic tabs support to MiniBrowser
2638         https://bugs.webkit.org/show_bug.cgi?id=159803
2639
2640         Reviewed by Sergio Villar Senin.
2641
2642         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2643         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2644
2645         * MiniBrowser/gtk/BrowserTab.c: Added.
2646         (titleChanged):
2647         (isLoadingChanged):
2648         (decidePolicy):
2649         (removeChildIfInfoBar):
2650         (loadChanged):
2651         (createInfoBarQuestionMessage):
2652         (tlsErrorsDialogResponse):
2653         (loadFailedWithTLSerrors):
2654         (permissionRequestDialogResponse):
2655         (decidePermissionRequest):
2656         (colorChooserRGBAChanged):
2657         (popoverColorClosed):
2658         (colorChooserRequestFinished):
2659         (runColorChooserCallback):
2660         (inspectorOpenedInWindow):
2661         (inspectorClosed):
2662         (browserTabSetProperty):
2663         (browserTabFinalize):
2664         (browser_tab_init):
2665         (browserTabConstructed):
2666         (browser_tab_class_init):
2667         (getInternalURI):
2668         (browser_tab_new):
2669         (browser_tab_get_web_view):
2670         (browser_tab_load_uri):
2671         (browser_tab_get_title_widget):
2672         (browser_tab_set_status_text):
2673         (browser_tab_toggle_inspector):
2674         (browser_tab_start_search):
2675         (browser_tab_stop_search):
2676         (browser_tab_add_accelerators):
2677         (fullScreenMessageTimeoutCallback):
2678         (browser_tab_enter_fullscreen):
2679         (browser_tab_leave_fullscreen):
2680         * MiniBrowser/gtk/BrowserTab.h: Added.
2681         * MiniBrowser/gtk/BrowserWindow.c:
2682         (getExternalURI):
2683         (browserWindowSetStatusText):
2684         (reloadOrStopCallback):
2685         (goBackCallback):
2686         (goForwardCallback):
2687         (settingsCallback):
2688         (webViewURIChanged):
2689         (browserWindowHistoryItemActivated):
2690         (browserWindowUpdateNavigationActions):
2691         (webViewCreate):
2692         (webViewEnterFullScreen):
2693         (webViewLeaveFullScreen):
2694         (webViewDecidePolicy):
2695         (browserWindowCanZoomIn):
2696         (browserWindowCanZoomOut):
2697         (browserWindowZoomIn):
2698         (browserWindowZoomOut):
2699         (scrollEventCallback):
2700         (faviconChanged):
2701         (webViewIsLoadingChanged):
2702         (defaultZoomCallback):
2703         (searchCallback):
2704         (newTabCallback):
2705         (toggleWebInspector):
2706         (reloadPage):
2707         (reloadPageIgnoringCache):
2708         (stopPageLoad):
2709         (loadHomePage):
2710         (editingCommandCallback):
2711         (insertImageCommandCallback):
2712         (insertLinkCommandCallback):
2713         (browserWindowSetupEditorToolbar):
2714         (browserWindowSwitchTab):
2715         (browserWindowTabAddedOrRemoved):
2716         (browser_window_init):
2717         (browserWindowConstructed):
2718         (browserWindowSaveSession):
2719         (browserWindowDeleteEvent):
2720         (browser_window_new):
2721         (browser_window_append_view):
2722         (browser_window_load_uri):
2723         (browser_window_load_session):
2724         (browser_window_set_background_color):
2725         (resetStatusText): Deleted.
2726         (activateUriEntryCallback): Deleted.
2727         (webViewTitleChanged): Deleted.
2728         (resetEntryProgress): Deleted.
2729         (browserWindowCreateBackForwardMenu): Deleted.
2730         (webViewReadyToShow): Deleted.
2731         (webViewLoadFailed): Deleted.
2732         (webViewMouseTargetChanged): Deleted.
2733         (browserWindowUpdateZoomActions): Deleted.
2734         (webViewZoomLevelChanged): Deleted.
2735         (updateUriEntryIcon): Deleted.
2736         (zoomInCallback): Deleted.
2737         (zoomOutCallback): Deleted.
2738         (toggleFullScreen): Deleted.
2739         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2740         (browserWindowFinalize): Deleted.
2741         (browser_window_class_init): Deleted.
2742         * MiniBrowser/gtk/BrowserWindow.h:
2743         * MiniBrowser/gtk/CMakeLists.txt:
2744         * MiniBrowser/gtk/main.c:
2745         (createBrowserTab):
2746         (aboutURISchemeRequestCallback):
2747         (main):
2748         (parseBackgroundColor): Deleted.
2749
2750 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2751
2752         Allow RefPtrs of const RefCounted types
2753         https://bugs.webkit.org/show_bug.cgi?id=158269
2754
2755         Reviewed by Anders Carlsson.
2756
2757         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2758         (TestWebKitAPI::TEST):
2759         (TestWebKitAPI::ConstRefCounted::create):
2760         (TestWebKitAPI::returnConstRefCountedRef):
2761         (TestWebKitAPI::returnRefCountedRef):
2762
2763 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2764
2765         Test WTF.StringViewIterators is crashing since r203119
2766         https://bugs.webkit.org/show_bug.cgi?id=159710
2767
2768         Reviewed by Darin Adler.
2769
2770         There are two problems in the test case added in r203119. First is that it's testing
2771         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2772         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2773         const reference to the string view member of the deleted CodePoints object.
2774
2775         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2776         (TestWebKitAPI::TEST):
2777
2778 2016-07-13  Daniel Bates  <dabates@apple.com>
2779
2780         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2781         https://bugs.webkit.org/show_bug.cgi?id=159738
2782         <rdar://problem/27304649>
2783
2784         Reviewed by Dan Bernstein.
2785
2786         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2787         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2788         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2789         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2790
2791         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2792         * WebKitTestRunner/ios/TestControllerIOS.mm:
2793         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2794         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2795
2796 2016-07-13  Beth Dakin  <bdakin@apple.com>
2797
2798         Attempted build fix.
2799
2800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2801
2802 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2803
2804         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2805         https://bugs.webkit.org/show_bug.cgi?id=159686
2806
2807         Reviewed by Chris Dumez.
2808
2809         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2810
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::runOpenPanel):
2813         (WTR::TestController::createOtherPage):
2814         (WTR::TestController::createWebViewWithOptions):
2815
2816 2016-07-13  Beth Dakin  <bdakin@apple.com>
2817
2818         Add more candidate tests
2819         https://bugs.webkit.org/show_bug.cgi?id=159730
2820
2821         Reviewed by Tim Horton.
2822
2823         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2824         two new tests to that file.
2825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2826         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2827         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2828         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2829         (TestWebKitAPI::TEST):
2830         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2831
2832 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2833
2834         AX: [ATK] spinbutton-crash.html fails
2835         https://bugs.webkit.org/show_bug.cgi?id=159723
2836
2837         Reviewed by Chris Fleizach.
2838
2839         Implement support for AXDecrementButton and AXIncrementButton in
2840         ATK's AccessibilityUIElement::uiElementAttributeValue().
2841
2842         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2843         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2844
2845 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2846
2847         [EFL] [GTK] Enable back crypto subtle on development builds.
2848         https://bugs.webkit.org/show_bug.cgi?id=159260
2849
2850         Reviewed by Carlos Garcia Campos.
2851
2852         * Scripts/webkitperl/FeatureList.pm:
2853
2854 2016-07-12  Mark Lam  <mark.lam@apple.com>
2855
2856         We should use different stack limits for stack checks from JS and host code.
2857         https://bugs.webkit.org/show_bug.cgi?id=159442
2858         <rdar://problem/26889188>
2859
2860         Reviewed by Geoffrey Garen.
2861
2862         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2863         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2864         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2865         order to keep the js/regress-139548.html test happy with this patch.
2866
2867         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2868         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2869
2870         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2871         (-[LTRelayController _environmentVariables]):
2872         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2873         (main):
2874
2875 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2876
2877         platformUserPreferredLanguages on Mac should not try to put the region into the language
2878         https://bugs.webkit.org/show_bug.cgi?id=159693
2879
2880         Rubber stamped by Alexey Proskuryakov.
2881         
2882         Revert the test change in r200105.
2883
2884         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2885         (TestWebKitAPI::languageForSystemLanguage):
2886
2887 2016-07-12  Chris Dumez  <cdumez@apple.com>
2888
2889         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2890         https://bugs.webkit.org/show_bug.cgi?id=159663
2891         <rdar://problem/18995873>
2892
2893         Reviewed by Benjamin Poulain.
2894
2895         Add API test coverage.
2896
2897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2898         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2899         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2900         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2901         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2902         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2903         (TEST):
2904
2905 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2906
2907         Relax ordering requirements on StringView::CodePoints iterator
2908         https://bugs.webkit.org/show_bug.cgi?id=159609
2909
2910         Reviewed by Darin Adler.
2911
2912         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2913         (TestWebKitAPI::TEST):
2914
2915 2016-07-12  Youenn Fablet  <youenn@apple.com>
2916
2917         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2918         https://bugs.webkit.org/show_bug.cgi?id=159564
2919
2920         Reviewed by Brian Burg.
2921
2922         * Scripts/webkitpy/codegen/main.py:
2923         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2924
2925 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2926
2927         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2928         https://bugs.webkit.org/show_bug.cgi?id=159671
2929
2930         Reviewed by Csaba Osztrogonác.
2931
2932         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2933         https://bugs.webkit.org/show_bug.cgi?id=89235
2934
2935         So this guard can be removed in build scripts.
2936
2937         * Scripts/webkitperl/FeatureList.pm:
2938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2939
2940 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2941
2942         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2943         https://bugs.webkit.org/show_bug.cgi?id=159652
2944
2945         Reviewed by Daniel Bates.
2946
2947         * Scripts/webkitpy/common/checkout/scm/svn.py:
2948         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2949
2950 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2951
2952         Implement grapheme cluster iterator on StringView
2953         https://bugs.webkit.org/show_bug.cgi?id=159598
2954
2955         Reviewed by Anders Carlsson.
2956
2957         This is in preparation for honoring the second argument to FontFaceSet.load().
2958
2959         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2960         (TestWebKitAPI::compareLoopIterations):
2961         (TestWebKitAPI::TEST):
2962
2963 2016-07-11  Nan Wang  <n_wang@apple.com>
2964
2965         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2966         https://bugs.webkit.org/show_bug.cgi?id=158364
2967
2968         Reviewed by Anders Carlsson.
2969
2970         Added a function in TestRunner so that we can toggle the ignoring viewport
2971         scale limits setting. Also added a test option for that in order to change the 
2972         configuration of the webview in test.
2973
2974         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2975         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2976         (WTR::TestRunner::setNavigationGesturesEnabled):
2977         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2978         (WTR::nextUIScriptCallbackID):
2979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2980         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2981         * WebKitTestRunner/TestController.cpp:
2982         (WTR::TestController::resetStateToConsistentValues):
2983         (WTR::updateTestOptionsFromTestHeader):
2984         (WTR::TestController::setNavigationGesturesEnabled):
2985         (WTR::TestController::setIgnoresViewportScaleLimits):
2986         (WTR::TestController::platformWillRunTest):
2987         * WebKitTestRunner/TestController.h:
2988         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2989         * WebKitTestRunner/TestInvocation.cpp:
2990         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2991         * WebKitTestRunner/TestOptions.h:
2992         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2993         (WTR::TestController::platformCreateWebView):
2994
2995 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2996
2997         [GTK] install-dependencies should not install packages built by jhbuild.
2998         https://bugs.webkit.org/show_bug.cgi?id=159628
2999
3000         Reviewed by Michael Catanzaro.
3001
3002         * gtk/install-dependencies:
3003         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3004
3005 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3006
3007         System proxy settings not used when building deps with jhbuild
3008         https://bugs.webkit.org/show_bug.cgi?id=159567
3009
3010         Reviewed by Michael Catanzaro.
3011
3012         This adds the gsettings-desktop-schemas-devel build dep to enable
3013         the libgiognomeproxy.so gio module in glib-networking, which uses
3014         GSettings on org.gnome.system.proxy.
3015         This is needed to query system proxy settings for Gnome desktops.
3016
3017         dconf can be manually added to jhbuild to build the
3018         libdconfsettings.so gio module for GSettings, so that
3019         libgiognomeproxy.so can access system settings.
3020           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3021
3022         As an alternative to dconf settings, this commit also adds the
3023         libproxy-devel build dep to enable the libgiolibproxy.so module in
3024         glib-networking (suggested by Fujii Hironori).
3025
3026         It is useful to read proxy settings from environment variables.
3027         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3028         environment variable to force using the envvar module in libproxy.
3029
3030         * gtk/install-dependencies:
3031
3032 2016-07-11  Mark Lam  <mark.lam@apple.com>
3033
3034         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3035         https://bugs.webkit.org/show_bug.cgi?id=159524
3036
3037         Reviewed by Michael Saboff.
3038
3039         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3040         Also fixed up some tests to behave better to work with this new limit.  This
3041         should make stack overflow tests complete sooner.
3042
3043         * Scripts/run-jsc-stress-tests:
3044         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3045         (main):
3046
3047 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3048
3049         [GTK] Whitespace fixes in install-dependencies script
3050
3051         Unreviewed.
3052
3053         * gtk/install-dependencies:
3054
3055 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3056
3057         [GTK] Install missing Fedora dependencies
3058
3059         Unreviewed.
3060
3061         * gtk/install-dependencies:
3062
3063 2016-07-09  Dan Bernstein  <mitz@apple.com>
3064
3065         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3066         https://bugs.webkit.org/show_bug.cgi?id=159600
3067
3068         Reviewed by Daniel Bates.
3069
3070         * Scripts/git-add-reviewer:
3071         Added the -s|--rubber-stamp option.
3072         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3073           new option.
3074
3075 2016-07-08  Andy Estes  <aestes@apple.com>
3076
3077         [Content Filtering] Load blocked pages more like other error pages are loaded
3078         https://bugs.webkit.org/show_bug.cgi?id=159485
3079         <rdar://problem/26014076>
3080
3081         Reviewed by Brady Eidson.
3082
3083         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3084         to a content filtering provisional navigation failure is ignored in preference of
3085         ContentFilter's own error page.
3086
3087         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3090         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3091         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3092         (loadAlternateTest):
3093         (TEST):
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3095         (-[MockContentFilterEnabler initWithCoder:]):
3096         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3097         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3098         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3099         (TestWebKitAPI::loadAlternateTest):
3100         (TestWebKitAPI::TEST):
3101
3102 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3103
3104         Unreviewed, rolling out r202944.
3105         https://bugs.webkit.org/show_bug.cgi?id=159570
3106
3107         caused some tests to crash under GuardMalloc (Requested by
3108         estes on #webkit).
3109
3110         Reverted changeset:
3111
3112         "[Content Filtering] Load blocked pages more like other error
3113         pages are loaded"
3114         https://bugs.webkit.org/show_bug.cgi?id=159485
3115         http://trac.webkit.org/changeset/202944
3116
3117 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3118
3119         Remove mrobinson from the MathML watchlist
3120         https://bugs.webkit.org/show_bug.cgi?id=159559
3121
3122         Reviewed by Philippe Normand.
3123
3124         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3125
3126 2016-07-08  Brady Eidson  <beidson@apple.com>
3127
3128         Clearing LocalStorage doesn't also delete -wal and -shm files.
3129         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3130
3131         Reviewed by Brent Fulgham.
3132         Also helpfully picked over by Andy "Never Forgets" Estes.
3133
3134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3135         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3137
3138 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3139
3140         Removed Qt leftovers from Tools.
3141         https://bugs.webkit.org/show_bug.cgi?id=159557
3142
3143         Reviewed by Csaba Osztrogonác.
3144
3145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3146         Removed 'qt' platform config.
3147         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3148         Deleted non-functional e-mail address.
3149
3150 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3151
3152         Unreviewed, rolling out r202967.
3153         https://bugs.webkit.org/show_bug.cgi?id=159556
3154
3155         This patch caused crashes in https tests on Windows (Requested
3156         by perarne on #webkit).
3157
3158         Reverted changeset:
3159
3160         "[Win] The test http/tests/security/contentSecurityPolicy
3161         /upgrade-insecure-requests/basic-upgrade.https.html is
3162         failing."
3163         https://bugs.webkit.org/show_bug.cgi?id=159510
3164         http://trac.webkit.org/changeset/202967
3165
3166 2016-07-08  Youenn Fablet  <youenn@apple.com>
3167
3168         Generate WebCore builtin wrapper files
3169         https://bugs.webkit.org/show_bug.cgi?id=159461
3170
3171         Reviewed by Brian Burg.
3172
3173         * Scripts/webkitpy/codegen/main.py:
3174         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3175         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3176
3177 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3178
3179         [EFL] Fix build when media-stream is enabled.
3180         https://bugs.webkit.org/show_bug.cgi?id=159206
3181
3182         Bump up the openwebrtc to find the correct package.
3183
3184         Reviewed by Gyuyoung Kim.
3185
3186         * efl/jhbuild.modules:
3187         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3188
3189 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3190
3191         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3192         https://bugs.webkit.org/show_bug.cgi?id=159510
3193
3194         Reviewed by Brent Fulgham.
3195
3196         Allow any https certificate when running tests.
3197
3198         * DumpRenderTree/win/DumpRenderTree.cpp:
3199         (runTest):
3200
3201 2016-07-07  Beth Dakin  <bdakin@apple.com>
3202
3203         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3204         https://bugs.webkit.org/show_bug.cgi?id=159532
3205         -and corresponding-
3206         rdar://problem/27177179
3207
3208         Reviewed by Tim Horton.
3209
3210         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3211         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3212
3213 2016-07-07  Andy Estes  <aestes@apple.com>
3214
3215         [Content Filtering] Load blocked pages more like other error pages are loaded
3216         https://bugs.webkit.org/show_bug.cgi?id=159485
3217         <rdar://problem/26014076>
3218
3219         Reviewed by Brady Eidson.
3220
3221         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3222         to a content filtering provisional navigation failure is ignored in preference of
3223         ContentFilter's own error page.
3224
3225         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3227         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3228         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3229         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3230         (loadAlternateTest):
3231         (TEST):
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3233         (-[MockContentFilterEnabler initWithCoder:]):
3234         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3235         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3236         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3237         (TestWebKitAPI::loadAlternateTest):
3238         (TestWebKitAPI::TEST):
3239
3240 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3241
3242         Unreviewed: add myself to the reviewers list.
3243
3244         * Scripts/webkitpy/common/config/contributors.json:
3245
3246 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3247
3248         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3249         https://bugs.webkit.org/show_bug.cgi?id=159509
3250
3251         Reviewed by Alex Christensen.
3252
3253         We should always insert the url in the url map when identifierForInitialRequest
3254         is called. Otherwise we can end up with identifiers not having an entry in the
3255         url map when urls are written to the test output file. 
3256
3257         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3258         (ResourceLoadDelegate::identifierForInitialRequest):
3259
3260 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3261
3262         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3263         https://bugs.webkit.org/show_bug.cgi?id=159498
3264         <rdar://problem/26719903>
3265
3266         Reviewed by Sam Weinig.
3267
3268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3269         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3270         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3271         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3272         (expectLinkCount):
3273         (TEST):
3274         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3275         when deciding what to linkify.
3276
3277 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3278
3279         Build fix - work around rdar://problem/27196668.
3280
3281         * LayoutTestRelay/Configurations/Base.xcconfig:
3282
3283 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3284
3285         Enhance Windows DRT implementation to support platform scroll wheel events.
3286         https://bugs.webkit.org/show_bug.cgi?id=36002
3287
3288         Reviewed by Brent Fulgham.
3289
3290         Implement function continuousMouseScrollBy in Windows event sender.
3291
3292         * DumpRenderTree/win/EventSender.cpp:
3293         (mouseScrollBy):
3294         (continuousMouseScrollBy):
3295
3296 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3297
3298         [Sierra] Rebaseline tests to use un-mocked system font metrics
3299         https://bugs.webkit.org/show_bug.cgi?id=159311
3300         <rdar://problem/24138411>
3301
3302         Reviewed in person by Alexey Proskuryakov.
3303
3304         Stop mocking the system font on Sierra.
3305
3306         * DumpRenderTree/mac/DumpRenderTree.mm:
3307         (setDefaultsToConsistentValuesForTesting):
3308         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3309         (WTR::InjectedBundle::platformInitialize):
3310
3311 2016-07-05  Brady Eidson  <beidson@apple.com>
3312
3313         Database process crashes deleting a corrupt SQLite database file (null deref).
3314         https://bugs.webkit.org/show_bug.cgi?id=155506.
3315
3316         Reviewed by Alex Christensen.
3317
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3320         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3322         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3323         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3324
3325 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3326
3327         run-webkit-tests should print more complete baseline search paths
3328         https://bugs.webkit.org/show_bug.cgi?id=159354
3329
3330         Reviewed by Daniel Bates.
3331
3332         run-webkit-tests used to only print directory names in baseline search paths.
3333         This was ok in basic usage, but quickly got confusing when using
3334         --additional-platform-directory flags.
3335
3336         * Scripts/webkitpy/layout_tests/views/printing.py:
3337         (Printer.print_config):
3338         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3339         (Testprinter.test_print_config):
3340         (Testprinter.test_print_one_line_summary):
3341
3342 2016-07-04  Brady Eidson  <beidson@apple.com>
3343
3344         WebProcesses don't handle DatabaseProcess going away uncleanly..
3345         https://bugs.webkit.org/show_bug.cgi?id=159371
3346
3347         Reviewed by Alex Christensen.
3348
3349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3350         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3351         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3352         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3353         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3354
3355 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3356
3357         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3358         https://bugs.webkit.org/show_bug.cgi?id=158141
3359
3360         Rubber-stamped by Michael Catanzaro.
3361
3362         Instead of checking for an specific Ubuntu version, query the apt
3363         database to see which version of PHP is available.
3364
3365         * efl/install-dependencies:
3366         * gtk/install-dependencies:
3367
3368 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3369
3370         webkit-patch failure-reason always raises TypeError
3371         https://bugs.webkit.org/show_bug.cgi?id=159394
3372
3373         Reviewed by Benjamin Poulain.
3374
3375         In r170637 (Bug 133067), the first and second arguments of
3376         pluralize were swapped.
3377
3378         * Scripts/webkitpy/tool/commands/queries.py:
3379         (FailureReason._builder_to_explain): Swap the first and second
3380         arguments of pluralize.
3381
3382 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3383
3384         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3385         https://bugs.webkit.org/show_bug.cgi?id=152486
3386
3387         Reviewed by Daniel Bates.
3388
3389         Add launch of web-platform-tests server by run-webkit-httpd.
3390         Add two options to disable starting httpd and web-platform-tests servers.
3391
3392         * Scripts/run-webkit-httpd:
3393         (parse_args):
3394         (main):
3395
3396 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3397
3398         REGRESSION(r189668): Notification tests are flakey
3399         https://bugs.webkit.org/show_bug.cgi?id=159375
3400         <rdar://problem/22760990>
3401
3402         Reviewed by Alexey Proskuryakov.
3403
3404         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3405         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3406         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3407         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3408
3409         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3410         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3411         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3412         global notification ID mapping, causing the wrong notification to be investigated.
3413
3414         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3415         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3416         notification is created or destroyed. However, because this object is implemented outside WebKit,
3417         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3418         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3419         WebNotificationProvider can properly map between the different IDs.
3420
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::TestController::runTestingServerLoop):
3423         (WTR::TestController::simulateWebNotificationClick):
3424         * WebKitTestRunner/WebNotificationProvider.cpp:
3425         (WTR::WebNotificationProvider::showWebNotification):
3426         (WTR::removeGlobalIDFromIDMap):
3427         (WTR::WebNotificationProvider::closeWebNotification):
3428         (WTR::WebNotificationProvider::removeNotificationManager):
3429         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3430         (WTR::WebNotificationProvider::reset):
3431         * WebKitTestRunner/WebNotificationProvider.h:
3432
3433 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3434
3435         Simplify LayoutTestRelay
3436         https://bugs.webkit.org/show_bug.cgi?id=159353
3437
3438         Reviewed by Daniel Bates.
3439
3440         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3441         by name and runtime makes no sense.
3442         2. Removed code to create devices, webkitpy always does this in advance.
3443         3. Don't create copies of testing apps - we can install the same one into
3444         each simulator, now that we don't run multiple tester processes in a single simulator.
3445         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3446         5. Removed code that kept testing apps alive in the background.
3447         6. Slightly updated coding style in functions that I touched.
3448
3449         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3450         Updated for what we acually use at this point.
3451
3452         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3453         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3454         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3455         (-[LTRelayController ipcIdentifier]):
3456         (-[LTRelayController processName]):
3457         (-[LTRelayController didReceiveStdoutData:]):
3458         (-[LTRelayController didCrashWithMessage:]):
3459         (-[LTRelayController installApp]):
3460         (-[LTRelayController _environmentVariables]):
3461         (-[LTRelayController launchApp]):
3462         (-[LTRelayController start]):
3463         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3464         (-[LTRelayController uniqueAppPath]): Deleted.
3465         (-[LTRelayController uniqueAppURL]): Deleted.
3466         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3467         (-[LTRelayController createUniqueApp]): Deleted.
3468         * LayoutTestRelay/LayoutTestRelay/main.m:
3469         (usage):
3470         (getRequiredStringArgument):
3471         (main):
3472         (getTestingSimDevice): Deleted.
3473         * Scripts/webkitpy/port/driver.py:
3474         (IOSSimulatorDriver.cmd_line):
3475         * WebKitTestRunner/ios/TestControllerIOS.mm:
3476         (WTR::TestController::platformInitialize):
3477         * WebKitTestRunner/ios/mainIOS.mm:
3478         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3479         * DumpRenderTree/mac/DumpRenderTree.mm:
3480         (dumpRenderTree):
3481         (-[DumpRenderTree applicationDidEnterBackground:]):
3482
3483 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3484
3485         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3486         https://bugs.webkit.org/show_bug.cgi?id=159344
3487
3488         Reviewed by Alex Christensen.
3489
3490         * DumpRenderTree/CMakeLists.txt:
3491
3492 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3493
3494         Add a runtime flag for DOM iterators
3495         https://bugs.webkit.org/show_bug.cgi?id=159300
3496
3497         Reviewed by Alex Christensen.
3498
3499         * DumpRenderTree/mac/DumpRenderTree.mm:
3500         (resetWebPreferencesToConsistentValues):
3501         * DumpRenderTree/win/DumpRenderTree.cpp:
3502         (resetWebPreferencesToConsistentValues):
3503         * Scripts/webkitperl/FeatureList.pm:
3504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3505         (WTR::InjectedBundle::beginTesting):
3506         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3507         (WTR::TestRunner::setDOMIteratorEnabled):
3508         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3509
3510 2016-06-30  Tina Liu  <iting_liu@apple.com>
3511
3512         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3513         https://bugs.webkit.org/show_bug.cgi?id=159326
3514
3515         Reviewed by Brady Eidson.
3516
3517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3518         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3519         (TestWebKitAPI::didFinishLoadForFrame):
3520         (TestWebKitAPI::didChangeBackForwardListForPage):
3521         (TestWebKitAPI::setPageLoaderClient):
3522         Set the page loader client and register for didFinishLoadForFrame and
3523         didChangeBackForwardList callbacks.
3524         (TestWebKitAPI::createSessionStateData):
3525         Load a webpage ("simple.html") and return the session state for this page.
3526         (TestWebKitAPI::TEST):
3527         Restore the page session state with that of "simple.html" without navigation.
3528         Verify that the committed URL is NULL since there's no navigation involved.
3529         Verify that the current item in the back forward list, which should be what
3530         we restored from the session state, has the expected URL.
3531
3532 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3533
3534         Generators violate bytecode liveness validation
3535         https://bugs.webkit.org/show_bug.cgi?id=159279
3536
3537         Reviewed by Yusuke Suzuki.
3538         
3539         Add Basic to our test harness.
3540
3541         * Scripts/run-javascriptcore-tests:
3542         (runJSCStressTests):
3543
3544 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3545
3546         [Win][Debug] Assertion fails in TestWTF.
3547         https://bugs.webkit.org/show_bug.cgi?id=159299
3548
3549         Reviewed by Alex Christensen.
3550
3551         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3552         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3553         the assertion failure. Since the variable is actually used, there is no need to use the
3554         UNUSED_PARAM macro.
3555
3556         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3557         (TestWebKitAPI::TEST):
3558
3559 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3560
3561         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3562         https://bugs.webkit.org/show_bug.cgi?id=159166
3563         <rdar://problem/27051759>
3564
3565         Reviewed by Alexey Proskuryakov.
3566
3567         Setting the certificate directory to the copied config.json.
3568
3569         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3570         (WebPlatformTestServer._copy_webkit_test_files):
3571
3572 2016-06-29  Mark Lam  <mark.lam@apple.com>
3573
3574         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3575         https://bugs.webkit.org/show_bug.cgi?id=159274
3576
3577         Reviewed by Keith Miller.
3578
3579         * DumpRenderTree/mac/DumpRenderTree.mm:
3580         (DumpRenderTreeMain):
3581
3582 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3583
3584         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3585         https://bugs.webkit.org/show_bug.cgi?id=159176
3586
3587         Reviewed by Sam Weinig.
3588
3589         * MiniBrowser/mac/WK2BrowserWindowController.m:
3590         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3591         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3592         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3593
3594 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3595
3596         [GTK] Add missing install dependency after r202619
3597         https://bugs.webkit.org/show_bug.cgi?id=156716
3598
3599         Unreviewed.
3600
3601         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3602
3603 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3604
3605         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3606         https://bugs.webkit.org/show_bug.cgi?id=156716
3607
3608         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3609
3610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3611         (parse_args):
3612         * Scripts/webkitpy/port/gtk.py:
3613         (GtkPort.__init__):
3614         (GtkPort._driver_class):
3615         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3616         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3617         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3618         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3619         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3620         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3621         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3622         (WestonDriver.check_driver):
3623         (WestonDriver.__init__):
3624         (WestonDriver._start):
3625         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3626         (WestonXvfbDriverDisplayTest):
3627         (WestonXvfbDriverDisplayTest.__init__):
3628         (WestonXvfbDriverDisplayTest._xvfb_run):
3629         (WestonDriverTest.make_driver):
3630         (WestonDriverTest.test_start):
3631         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3632         or to satisfy the pkg-config check of the new added modules in JHBuild.
3633         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3634         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3635         provided by the system are already new enough.
3636         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3637         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3638         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3639         feature to avoid building libdrm when the one provided by the system is new enough.