Unreviewed, rolling out r244627.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r244627.
4         https://bugs.webkit.org/show_bug.cgi?id=197282
5
6         Causing internal build failures (Requested by ShawnRoberts on
7         #webkit).
8
9         Reverted changeset:
10
11         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
12         https://bugs.webkit.org/show_bug.cgi?id=197171
13         https://trac.webkit.org/changeset/244627
14
15 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [GTK] Hardcoded text color in input fields
18         https://bugs.webkit.org/show_bug.cgi?id=126907
19
20         Reviewed by Michael Catanzaro.
21
22         Add dark-mode command line option to MiniBrowser.
23
24         * MiniBrowser/gtk/main.c:
25         (main):
26
27 2019-04-24  Zalan Bujtas  <zalan@apple.com>
28
29         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
30         https://bugs.webkit.org/show_bug.cgi?id=196948
31         <rdar://problem/49927131>
32
33         Reviewed by Tim Horton.
34
35         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
36         (TEST):
37         The expected order of incoming events is
38         1. didInvalidateIntrinsicContentSize
39         2. didFirstLayout
40         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
41         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
42         (and remember, all we care about is ordering).
43
44 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
45
46         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
47         https://bugs.webkit.org/show_bug.cgi?id=197171
48         <rdar://problem/47454979>
49
50         Reviewed by Youenn Fablet.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
54         (TestWebKitAPI::TEST):
55
56 2019-04-24  Brady Eidson  <beidson@apple.com>
57
58         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
59         https://bugs.webkit.org/show_bug.cgi?id=191362
60
61         Reviewed by Alex Christensen.
62
63         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
64           from an XHR to a custom protocol.
65
66 2019-04-24  John Wilander  <wilander@apple.com>
67
68         Age out unconverted Ad Click Attributions after one week.
69         https://bugs.webkit.org/show_bug.cgi?id=197238
70         <rdar://problem/50177349>
71
72         Reviewed by Chris Dumez.
73
74         This patch adds infrastructure to allow tests to expire all unconverted
75         attributions early.
76
77         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
78         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
79         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
80         * WebKitTestRunner/InjectedBundle/TestRunner.h:
81         * WebKitTestRunner/TestController.cpp:
82         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
83         * WebKitTestRunner/TestController.h:
84         * WebKitTestRunner/TestInvocation.cpp:
85         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
86
87 2019-04-24  Chris Dumez  <cdumez@apple.com>
88
89         Fix flaky crashes in a couple of PSON API tests
90         https://bugs.webkit.org/show_bug.cgi?id=197239
91
92         Reviewed by Tim Horton.
93
94         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
95
96         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
97
98 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
99
100         Make it possible to control the renderTreeAsText output by setting options on testRunner
101         https://bugs.webkit.org/show_bug.cgi?id=197133
102
103         Reviewed by Sam Weinig.
104
105         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
106         that make sense in testing (those that don't dump unstable data like addresses), and plumb
107         these flags through the various framework layers.
108
109         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
110
111         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
112         and hand-code DumpRenderTree bindings.
113
114         Some cleanup of the TestRunners, using member initializers.
115
116         * DumpRenderTree/TestRunner.cpp:
117         (TestRunner::TestRunner):
118         (setRenderTreeDumpOptionsCallback):
119         (TestRunner::staticFunctions):
120         (TestRunner::setRenderTreeDumpOptions):
121         * DumpRenderTree/TestRunner.h:
122         (TestRunner::renderTreeDumpOptions const):
123         * DumpRenderTree/mac/DumpRenderTree.mm:
124         (dump):
125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
127         (WTR::InjectedBundlePage::dump):
128         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
129         (WTR::TestRunner::TestRunner):
130         (WTR::TestRunner::setRenderTreeDumpOptions):
131         * WebKitTestRunner/InjectedBundle/TestRunner.h:
132         (WTR::TestRunner::renderTreeDumpOptions const):
133
134 2019-04-24  Alex Christensen  <achristensen@webkit.org>
135
136         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
137         https://bugs.webkit.org/show_bug.cgi?id=197078
138         <rdar://problem/49564348>
139
140         Reviewed by Geoff Garen.
141
142         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
143         (TEST_F):
144         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
145         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
146         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
147
148 2019-04-24  Alex Christensen  <achristensen@webkit.org>
149
150         Add unit test for r239322
151         https://bugs.webkit.org/show_bug.cgi?id=197236
152
153         Reviewed by Chris Dumez.
154
155         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
156         May as well add the test infrastructure which was needed before and will be needed in the future.
157
158         * TestWebKitAPI/TCPServer.cpp:
159         (TestWebKitAPI::TCPServer::TCPServer):
160         * TestWebKitAPI/TCPServer.h:
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
163         (TestWebKitAPI::TEST):
164         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
165         (TestWebKitAPI::downloadAtRate):
166         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
167         (TEST):
168         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
169         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
170         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
171         (TestWebKitAPI::TEST):
172         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
173         (TEST):
174
175 2019-04-24  Chris Dumez  <cdumez@apple.com>
176
177         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
178         https://bugs.webkit.org/show_bug.cgi?id=197214
179         <rdar://problem/49237544>
180
181         Reviewed by Alex Christensen.
182
183         Extend API test coverage.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
186         (TEST):
187
188 2019-04-24  Philippe Normand  <pnormand@igalia.com>
189
190         [Build][GStreamer] Update to 1.16.0
191         https://bugs.webkit.org/show_bug.cgi?id=197157
192
193         Reviewed by Xabier Rodriguez-Calvar.
194
195         The upstreamed patches were removed and a new one was added for a
196         regression detected in the scaletempo GStreamer element. The GNOME
197         Flatpak was migrated to 3.32 and I switched a few modules to Meson
198         on the way, as it is the preferred build system now in GStreamer
199         1.16.
200
201         * flatpak/files/httpd-autogen.sh:
202         * flatpak/flatpakutils.py:
203         (FlatpakPackage.install):
204         (WebkitFlatpak.run_in_sandbox):
205         * flatpak/org.webkit.CommonModules.yaml:
206         * flatpak/org.webkit.WebKit.yaml:
207         * gstreamer/jhbuild.modules:
208         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
209         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
210         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
211         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
212         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
213         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
214         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
215         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
216         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
217         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
218         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
219         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
220         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
221         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
222         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
223         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
224         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
225         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
226         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
227         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
228         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
229         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
230
231 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
232
233         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
234         https://bugs.webkit.org/show_bug.cgi?id=197156
235
236         Reviewed by Michael Catanzaro.
237
238         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
239         support was added.
240
241         * MiniBrowser/gtk/BrowserTab.c:
242         (browser_tab_set_background_color): Set the passed in color as web view background color.
243         * MiniBrowser/gtk/BrowserTab.h:
244         * MiniBrowser/gtk/BrowserWindow.c:
245         (browser_window_init): Initialize backgroundColor.
246         (browser_window_append_view): Call browser_tab_set_background_color().
247         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
248         are added.
249         * MiniBrowser/gtk/main.c:
250         (main): Call browser_window_set_background_color() before creating the tabs.
251
252 2019-04-23  John Wilander  <wilander@apple.com>
253
254         Move Ad Click Attribution from internal feature to experimental feature
255         https://bugs.webkit.org/show_bug.cgi?id=197218
256         <rdar://problem/47651691>
257
258         Reviewed by Brent Fulgham.
259
260         * DumpRenderTree/TestOptions.cpp:
261         (TestOptions::TestOptions):
262
263 2019-04-23  Andy Estes  <aestes@apple.com>
264
265         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
266         https://bugs.webkit.org/show_bug.cgi?id=196749
267         <rdar://problem/35773454>
268
269         Reviewed by Daniel Bates.
270
271         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
274         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
275         (-[QuickLookDelegate webView:didFinishNavigation:]):
276         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
277         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
278         (runTest):
279         (runTestDecideBeforeLoading):
280         (runTestDecideAfterLoading):
281         (TEST):
282
283 2019-04-23  John Wilander  <wilander@apple.com>
284
285         Remove Ad Click Attribution data when removing website data
286         https://bugs.webkit.org/show_bug.cgi?id=197215
287         <rdar://problem/47668988>
288
289         Reviewed by Chris Dumez.
290
291         This patch adds test infrastructure to delete Ad Click Attribution data
292         through WebsiteDataStore::removeData().
293
294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::clearAdClickAttribution):
297         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
299         * WebKitTestRunner/TestController.cpp:
300         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
301         * WebKitTestRunner/TestController.h:
302         * WebKitTestRunner/TestInvocation.cpp:
303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
304
305 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
306
307         webkitpy: Kill unresponsive worker processes
308         https://bugs.webkit.org/show_bug.cgi?id=197205
309         <rdar://problem/50104388>
310
311         Reviewed by Lucas Forschler.
312
313         * Scripts/webkitpy/common/message_pool.py:
314         (_MessagePool.__init__): Add close timeout.
315         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
316
317 2019-04-23  Alex Christensen  <achristensen@webkit.org>
318
319         Add unit tests for WKWebView.serverTrust
320         https://bugs.webkit.org/show_bug.cgi?id=197202
321
322         Reviewed by Youenn Fablet
323
324         * TestWebKitAPI/TCPServer.cpp:
325         (TestWebKitAPI::deleter<BIO>::operator()):
326         (TestWebKitAPI::deleter<SSL>::operator()):
327         (TestWebKitAPI::deleter<X509>::operator()):
328         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
329         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
330         (TestWebKitAPI::TCPServer::TCPServer):
331         (TestWebKitAPI::TCPServer::listenForConnections):
332         * TestWebKitAPI/TCPServer.h:
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
335         (TestWebKitAPI::TEST):
336         (verifyCertificateAndPublicKey):
337         (-[ServerTrustDelegate webView:didFinishNavigation:]):
338         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
339         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
340         (TestWebKitAPI::downloadAtRate):
341         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
342         (TEST):
343         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
344         (TEST):
345
346 2019-04-23  Commit Queue  <commit-queue@webkit.org>
347
348         Unreviewed, rolling out r244556.
349         https://bugs.webkit.org/show_bug.cgi?id=197212
350
351         Causing build failures on multiple builders (Requested by
352         ShawnRoberts on #webkit).
353
354         Reverted changeset:
355
356         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
357         https://bugs.webkit.org/show_bug.cgi?id=197171
358         https://trac.webkit.org/changeset/244556
359
360 2019-04-23  Alex Christensen  <achristensen@webkit.org>
361
362         Fix iOS build.
363         https://bugs.webkit.org/show_bug.cgi?id=195537
364
365         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
366         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
367         AdoptWK constructor is private now.  Use adoptWK instead.
368
369 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
370
371         Accessibility text search and selection API enhancements.
372         https://bugs.webkit.org/show_bug.cgi?id=197095
373         <rdar://problem/48181791>
374
375         Reviewed by Chris Fleizach.
376
377         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
378
379         * DumpRenderTree/AccessibilityTextMarker.h:
380         * DumpRenderTree/AccessibilityUIElement.cpp:
381         (searchTextWithCriteriaCallback):
382         (AccessibilityUIElement::getJSClass):
383         * DumpRenderTree/AccessibilityUIElement.h:
384         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
385         (convertVectorToObjectArray):
386         (convertNSArrayToVector):
387         (searchTextParameterizedAttributeForCriteria):
388         (AccessibilityUIElement::getLinkedUIElements):
389         (AccessibilityUIElement::getDocumentLinks):
390         (AccessibilityUIElement::getChildren):
391         (AccessibilityUIElement::getChildrenWithRange):
392         (AccessibilityUIElement::rowHeaders const):
393         (AccessibilityUIElement::columnHeaders const):
394         (AccessibilityUIElement::uiElementArrayAttributeValue const):
395         (AccessibilityUIElement::searchTextWithCriteria):
396         (AccessibilityUIElement::attributesOfColumnHeaders):
397         (AccessibilityUIElement::attributesOfRowHeaders):
398         (AccessibilityUIElement::attributesOfColumns):
399         (AccessibilityUIElement::attributesOfRows):
400         (AccessibilityUIElement::attributesOfVisibleCells):
401         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
402         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
403         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
404         (WTR::convertVectorToObjectArray):
405         (WTR::convertNSArrayToVector):
406         (WTR::searchTextParameterizedAttributeForCriteria):
407         (WTR::AccessibilityUIElement::getLinkedUIElements):
408         (WTR::AccessibilityUIElement::getDocumentLinks):
409         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
410         (WTR::AccessibilityUIElement::getChildren):
411         (WTR::AccessibilityUIElement::getChildrenWithRange):
412         (WTR::AccessibilityUIElement::rowHeaders const):
413         (WTR::AccessibilityUIElement::columnHeaders const):
414         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
415         (WTR::AccessibilityUIElement::searchTextWithCriteria):
416         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
417         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
418         (WTR::AccessibilityUIElement::attributesOfColumns):
419         (WTR::AccessibilityUIElement::attributesOfRows):
420         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
421         (WTR::convertElementsToObjectArray): Deleted.
422
423 2019-04-23  Guy Lewin  <guy@lewin.co.il>
424
425         Multiple File Input Icon Set Regardless of File List
426         https://bugs.webkit.org/show_bug.cgi?id=195537
427
428         Reviewed by Alexey Proskuryakov.
429
430         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
431         display string in iOS file inputs
432
433         * DumpRenderTree/TestRunner.cpp:
434         (SetOpenPanelFilesMediaIconCallback):
435         (TestRunner::staticFunctions):
436         (TestRunner::setOpenPanelFilesMediaIcon):
437         * DumpRenderTree/TestRunner.h:
438         (TestRunner::openPanelFilesMediaIcon const):
439         * DumpRenderTree/mac/UIDelegate.mm:
440         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
441         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
443         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
445         * WebKitTestRunner/TestController.cpp:
446         (WTR::runOpenPanel):
447         (WTR::TestController::resetStateToConsistentValues):
448         * WebKitTestRunner/TestController.h:
449         (WTR::TestController::openPanelFileURLsMediaIcon const):
450         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
451         * WebKitTestRunner/TestInvocation.cpp:
452         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
453
454 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
455
456         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
457         https://bugs.webkit.org/show_bug.cgi?id=197171
458         <rdar://problem/47454979>
459
460         Reviewed by Youenn Fablet.
461
462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
464         (TestWebKitAPI::TEST):
465
466 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
467
468         [ews-build] Add unit tests for UnApplyPatchIfRequired
469         https://bugs.webkit.org/show_bug.cgi?id=197197
470
471         Reviewed by Lucas Forschler.
472
473         * BuildSlaveSupport/ews-build/steps_unittest.py:
474         (TestUnApplyPatchIfRequired):
475         (TestUnApplyPatchIfRequired.test_success):
476         (TestUnApplyPatchIfRequired.test_failure):
477         (TestUnApplyPatchIfRequired.test_skip):
478
479 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
480
481         [ews-build] Add unit tests for CleanWorkingDirectory
482         https://bugs.webkit.org/show_bug.cgi?id=197195
483
484         Reviewed by Lucas Forschler.
485
486         * BuildSlaveSupport/ews-build/steps_unittest.py:
487         (TestCleanWorkingDirectory):
488         (TestCleanWorkingDirectory.test_success):
489         (TestCleanWorkingDirectory.test_failure):
490
491 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
492
493         [ews-build] Use explicit imports instead of wildcard imports
494         https://bugs.webkit.org/show_bug.cgi?id=197194
495
496         Reviewed by Lucas Forschler.
497
498         * BuildSlaveSupport/ews-build/factories.py:
499         * BuildSlaveSupport/ews-build/loadConfig.py:
500         * BuildSlaveSupport/ews-build/steps_unittest.py:
501
502 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
503
504         [ews-build] Add unit tests for DownloadBuiltProduct
505         https://bugs.webkit.org/show_bug.cgi?id=197193
506
507         Reviewed by Lucas Forschler.
508
509         * BuildSlaveSupport/ews-build/steps_unittest.py:
510         (TestDownloadBuiltProduct):
511         (TestDownloadBuiltProduct.setUp):
512         (TestDownloadBuiltProduct.tearDown):
513         (TestDownloadBuiltProduct.test_success):
514         (TestDownloadBuiltProduct.test_failure):
515
516 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-app] Exception while loading status-bubble when no build step has started
519         https://bugs.webkit.org/show_bug.cgi?id=196676
520
521         Reviewed by Lucas Forschler.
522
523         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
524         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
525
526 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
527
528         [PlayStation] Support running of JSC tests on remote playstation devices
529         https://bugs.webkit.org/show_bug.cgi?id=197170
530
531         Reviewed by Ross Kirsling.
532
533         Script changes
534
535         * Scripts/run-javascriptcore-tests:
536         (runJSCStressTests): Pass arguments for playstation to
537         run-jsc-stress-tests
538         * Scripts/run-jsc-stress-tests:
539         Handle $hostOS=="playstation" for determineArchitecture, turning
540         off $isFTLPlatform and runProfiler and defaulting test writer.
541         * Scripts/webkitdirs.pm:
542         (jscPath): PlayStation WebKit executables have .elf extension
543         (executableProductDir): PlayStation builds on Windows hosts but
544         uses bin directory rather than bin64/bin32 for executable output
545         location.
546         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
547
548 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
549
550         [CMake][Win] Use target oriented design for WebKit
551         https://bugs.webkit.org/show_bug.cgi?id=197173
552
553         Reviewed by Alex Christensen.
554
555         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
556         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
557
558 2019-04-23  Chris Dumez  <cdumez@apple.com>
559
560         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
561         https://bugs.webkit.org/show_bug.cgi?id=197097
562         <rdar://problem/50048318>
563
564         Reviewed by Alex Christensen.
565
566         Add API test coverage.
567
568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
569         (-[PSONScheme webView:startURLSchemeTask:]):
570
571 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
572
573         [ATK] Implement AtkComponentIface scroll_to methods
574         https://bugs.webkit.org/show_bug.cgi?id=196856
575
576         Reviewed by Michael Catanzaro.
577
578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
579         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
580         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
581         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
582
583 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
584
585         [ews-build] Improve summary for UploadBuiltProduct step
586         https://bugs.webkit.org/show_bug.cgi?id=197182
587
588         Reviewed by Lucas Forschler.
589
590         * BuildSlaveSupport/ews-build/steps.py:
591         (UploadBuiltProduct): Added descriptionDone.
592         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
593         * BuildSlaveSupport/ews-build/steps_unittest.py:
594         (TestUploadBuiltProduct.test_success): Updated unit-test.
595         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
596
597 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-build] Trigger queues only after uploading the archive
600         https://bugs.webkit.org/show_bug.cgi?id=197180
601
602         Reviewed by Lucas Forschler.
603
604         * BuildSlaveSupport/ews-build/factories.py:
605         (Factory.__init__):
606         (BuildFactory.__init__): Remove trigger step from factories.
607         (BuildFactory.propertiesToPassToTriggers): Deleted.
608         * BuildSlaveSupport/ews-build/steps.py:
609         (ConfigureBuild.__init__): Confiure triggers property.
610         (Trigger): Step to trigger other queues.
611         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
612         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
613
614 2019-04-22  Alex Christensen  <achristensen@webkit.org>
615
616         Deprecate WKContextCreateWithInjectedBundlePath
617         https://bugs.webkit.org/show_bug.cgi?id=197169
618
619         Reviewed by Youenn Fablet.
620
621         * TestWebKitAPI/PlatformUtilities.cpp:
622         (TestWebKitAPI::Util::createContextWithInjectedBundle):
623         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
624
625 2019-04-22  Alex Christensen  <achristensen@webkit.org>
626
627         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
628         https://bugs.webkit.org/show_bug.cgi?id=197093
629         <rdar://problem/49708268>
630
631         Reviewed by Chris Dumez.
632
633         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
634         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
635         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
636         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
637         and one for loads without credentials, so there are two TCP connections to the same server in this test.
638
639         * TestWebKitAPI/TCPServer.cpp:
640         (TestWebKitAPI::TCPServer::TCPServer):
641         (TestWebKitAPI::TCPServer::~TCPServer):
642         (TestWebKitAPI::TCPServer::socketBindListen):
643         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
644         * TestWebKitAPI/TCPServer.h:
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
646         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
647         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
648         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
649         (respondWithChallengeThenOK):
650         (TestWebKitAPI::TEST):
651         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
652         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
653         (TEST):
654
655 2019-04-22  Chris Dumez  <cdumez@apple.com>
656
657         Delayed WebProcessLaunch may break the _relatedWebView SPI
658         https://bugs.webkit.org/show_bug.cgi?id=197160
659
660         Reviewed by Alex Christensen.
661
662         Add API test coverage.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
665
666 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
667
668         Use curl to download packages for webkitpy autoinstaller
669         https://bugs.webkit.org/show_bug.cgi?id=197164
670
671         Reviewed by Darin Adler.
672
673         * Scripts/webkitpy/common/system/autoinstall.py:
674         (AutoInstaller._download): Use curl(1) to download packages necessary for
675         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
676         errors which are not present when using curl(1).
677
678 2019-04-22  Chris Dumez  <cdumez@apple.com>
679
680         Unreviewed, rolling out r244502.
681
682         Caused crashes on the bots
683
684         Reverted changeset:
685
686         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
687         https://bugs.webkit.org/show_bug.cgi?id=197160
688         https://trac.webkit.org/changeset/244502
689
690 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
691
692         Unreviewed, rolling out r244437.
693
694         Still breaks internal tests.
695
696         Reverted changeset:
697
698         "InjectedBundle parameters often need initialization function
699         called before unarchiving"
700         https://bugs.webkit.org/show_bug.cgi?id=189709
701         https://trac.webkit.org/changeset/244437
702
703 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews-build] Use singular verb in failure description in case of single api test failure
706         https://bugs.webkit.org/show_bug.cgi?id=197013
707
708         Reviewed by Lucas Forschler.
709
710         * BuildSlaveSupport/ews-build/steps.py:
711         (AnalyzeAPITestsResults.analyzeResults):
712
713 2019-04-22  Chris Dumez  <cdumez@apple.com>
714
715         Delayed WebProcessLaunch may break the _relatedWebView SPI
716         https://bugs.webkit.org/show_bug.cgi?id=197160
717
718         Reviewed by Alex Christensen.
719
720         Add API test coverage.
721
722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
723
724 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
727         https://bugs.webkit.org/show_bug.cgi?id=194630
728
729         Reviewed by Michael Catanzaro.
730
731         Return early from getAttributeSet() is passed in accessible is nullptr.
732
733         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
734
735 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
736
737         Defer EditorState updates until the next layer tree flush in a few additional circumstances
738         https://bugs.webkit.org/show_bug.cgi?id=197145
739         <rdar://problem/50078170>
740
741         Reviewed by Darin Adler.
742
743         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
744         focus, or showing the font manager.
745
746         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
747         (TestWebKitAPI::TEST):
748         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
749         (TEST):
750         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
751         (TestWebKitAPI::TEST):
752
753 2019-04-21  Brian Burg  <bburg@apple.com>
754
755         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
756         https://bugs.webkit.org/show_bug.cgi?id=197125
757         <rdar://problem/50061468>
758
759         Reviewed by Darin Adler.
760
761         Sometimes I want to run wptserve independently of tests. Make it easier to script that
762         using this class rather than making our own ./wpt serve invocation.
763
764         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
765         (WebDriverW3CWebServer):
766         (WebDriverW3CWebServer.document_root): Expose this to clients.
767         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
768
769         (WebDriverW3CWebServer.__enter__):
770         (WebDriverW3CWebServer.__exit__):
771         Make it possible to use the web server with a 'with' statement.
772
773 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
774
775         [CMake][Win] Use target oriented design for WebKitLegacy
776         https://bugs.webkit.org/show_bug.cgi?id=197112
777
778         Reviewed by Konstantin Tokarev.
779
780         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
781
782         * DumpRenderTree/CMakeLists.txt:
783         * DumpRenderTree/PlatformWin.cmake:
784         * DumpRenderTree/win/EventSender.cpp:
785
786 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
787
788         Update text for old EWS submit button
789         https://bugs.webkit.org/show_bug.cgi?id=197140
790
791         Reviewed by Alexey Proskuryakov.
792
793         * QueueStatusServer/templates/statusbubble.html:
794
795 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-app] New EWS should poll bugzilla more frequently
798         https://bugs.webkit.org/show_bug.cgi?id=197138
799
800         Reviewed by Alexey Proskuryakov.
801
802         * BuildSlaveSupport/ews-app/ews/fetcher.py:
803         (FetchLoop.__init__):
804
805 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
806
807         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
808         https://bugs.webkit.org/show_bug.cgi?id=197139
809
810         Reviewed by Alexey Proskuryakov.
811
812         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
813         * QueueStatusServer/templates/statusbubble.html:
814
815 2019-04-20  Chris Dumez  <cdumez@apple.com>
816
817         Unreviewed, fix iOS build with recent SDKs.
818
819         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
820
821 2019-04-19  Keith Miller  <keith_miller@apple.com>
822
823         Add script to merge run_benchmark jsons
824         https://bugs.webkit.org/show_bug.cgi?id=197107
825
826         Reviewed by Michael Saboff.
827
828         The script basically recursively decends through all json objects until it gets
829         to an array or JSON primitive and concats or takes the first value, respectively.
830
831         This patch also adds +x bits to the compare-results script so it
832         can be run directly from the command line. I had to add a new line so that svn
833         will accept the change... yay svn!
834
835         * Scripts/compare-results:
836         * Scripts/merge-result-jsons: Added.
837         (readJSONFile):
838         (deepAppend):
839         (mergeJSONs):
840         (main):
841
842 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
843
844         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
845         https://bugs.webkit.org/show_bug.cgi?id=197079
846
847         Reviewed by Darin Adler.
848
849         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
853
854 2019-04-18  Commit Queue  <commit-queue@webkit.org>
855
856         Unreviewed, rolling out r244434.
857         https://bugs.webkit.org/show_bug.cgi?id=197089
858
859         caused 1 API test failure (Requested by zalan on #webkit).
860
861         Reverted changeset:
862
863         "Regression (r244291): Broken API Test
864         AutoLayoutRenderingProgressRelativeOrdering"
865         https://bugs.webkit.org/show_bug.cgi?id=196948
866         https://trac.webkit.org/changeset/244434
867
868 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
869
870         Add new compatibility mode API on WKNavigation
871         https://bugs.webkit.org/show_bug.cgi?id=197069
872         <rdar://problem/50025800>
873
874         Reviewed by Tim Horton.
875
876         Add a block property for -didCommitNavigation to TestNavigationDelegate.
877
878         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
879         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
880         (-[TestNavigationDelegate webView:didCommitNavigation:]):
881
882 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
883
884         [CMake] Make WebCore headers copies
885         https://bugs.webkit.org/show_bug.cgi?id=182512
886         <rdar://problem/37510435>
887
888         Reviewed by Alex Christensen.
889
890         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
891         ports.
892
893         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
894         of WebCore headers using "*.h" were modified to <WebCore/*.h>
895
896         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
897         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
898         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
899         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
900         * TestWebKitAPI/CMakeLists.txt:
901         * TestWebKitAPI/PlatformWin.cmake:
902         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
903         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
904         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
905
906 2019-04-18  Jer Noble  <jer.noble@apple.com>
907
908         Add support for parsing FairPlayStreaming PSSH boxes.
909         https://bugs.webkit.org/show_bug.cgi?id=197064
910
911         Reviewed by Eric Carlson.
912
913         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
914         (TestWebKitAPI::TEST):
915
916 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
917
918         InjectedBundle parameters often need initialization function called before unarchiving
919         https://bugs.webkit.org/show_bug.cgi?id=189709
920         <rdar://problem/44573653>
921
922         Reviewed by Ryosuke Niwa.
923
924         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
925         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
926
927 2019-04-18  Zalan Bujtas  <zalan@apple.com>
928
929         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
930         https://bugs.webkit.org/show_bug.cgi?id=196948
931         <rdar://problem/49927131>
932
933         Reviewed by Tim Horton.
934
935         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
936         (TEST): 
937         The expected order of incoming events is
938         1. didInvalidateIntrinsicContentSize
939         2. didFirstLayout
940         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
941         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
942         (and remember, all we care about is ordering).
943
944 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
945
946         Unreviewed, rolling out r244299.
947
948         Breaks internal tests.
949
950         Reverted changeset:
951
952         "InjectedBundle parameters often need initialization function
953         called before unarchiving"
954         https://bugs.webkit.org/show_bug.cgi?id=189709
955         https://trac.webkit.org/changeset/244299
956
957 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
958
959         [WTF] StringBuilder should set correct m_is8Bit flag when merging
960         https://bugs.webkit.org/show_bug.cgi?id=197053
961
962         Reviewed by Saam Barati.
963
964         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
965         (TestWebKitAPI::TEST):
966
967 2019-04-17  Tim Horton  <timothy_horton@apple.com>
968
969         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
970         https://bugs.webkit.org/show_bug.cgi?id=197028
971         <rdar://problem/49985290>
972
973         Reviewed by Wenson Hsieh.
974
975         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
976         (TEST):
977         Liberal application of waitForNextPresentationUpdate works around a race
978         where if the page rapidly changes its viewport arguments (or an API client
979         rapidly changes its viewport arguments), we'd get stuck thinking that the
980         user had intentionally zoomed the page, and stop resetting the initial scale.
981         This deserves a separate bug, but no need to keep the test failing while
982         we think about it.
983
984 2019-04-17  Tim Horton  <timothy_horton@apple.com>
985
986         REGRESSION (r241988): Switching tabs is slow
987         https://bugs.webkit.org/show_bug.cgi?id=197037
988         <rdar://problem/49951473>
989
990         Reviewed by Simon Fraser.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
994         (TEST):
995         * TestWebKitAPI/cocoa/TestWKWebView.h:
996         * TestWebKitAPI/cocoa/TestWKWebView.mm:
997         (-[TestWKWebView addToTestWindow]):
998         Add a test that hangs without this fix.
999
1000 2019-04-17  Truitt Savell  <tsavell@apple.com>
1001
1002         Unreviewed, rolling out r244400.
1003
1004         Caused testing to exit early with assertionon Debug WK2
1005
1006         Reverted changeset:
1007
1008         "UI↔Web deadlock when printing with a JavaScript alert
1009         visible"
1010         https://bugs.webkit.org/show_bug.cgi?id=196839
1011         https://trac.webkit.org/changeset/244400
1012
1013 2019-04-17  Brady Eidson  <beidson@apple.com>
1014
1015         Link clicks in PDFs shouldn't send referrer headers.
1016         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1017
1018         Reviewed by Tim Horton.
1019
1020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1021         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1022         (putPDFBytesCallback):
1023         (emptyReleaseInfoCallback):
1024         (createPDFWithLinkToURL):
1025         (TEST):
1026
1027 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1028
1029         UI↔Web deadlock when printing with a JavaScript alert visible
1030         https://bugs.webkit.org/show_bug.cgi?id=196839
1031         <rdar://problem/49157642>
1032
1033         Reviewed by Andy Estes.
1034
1035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1036         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1037         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1038         (TEST):
1039
1040 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1041
1042         WKRetainPtr's adoption constructor should be private
1043         https://bugs.webkit.org/show_bug.cgi?id=197019
1044
1045         Reviewed by Tim Horton.
1046
1047         * DumpRenderTree/mac/DumpRenderTree.mm:
1048         (dumpFramesAsText):
1049         * TestWebKitAPI/InjectedBundleController.cpp:
1050         (TestWebKitAPI::InjectedBundleController::initialize):
1051         * TestWebKitAPI/PlatformUtilities.cpp:
1052         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1053         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1054         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1055         (TestWebKitAPI::Util::toWK):
1056         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1059         (TestWebKitAPI::TEST):
1060         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1061         (TestWebKitAPI::TEST):
1062         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1063         (TestWebKitAPI::TEST):
1064         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1065         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1066         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1067         (TestWebKitAPI::TEST):
1068         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1069         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1070         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1071         (TestWebKitAPI::TEST):
1072         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1073         (TestWebKitAPI::TEST):
1074         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1075         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1076         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1079         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1080         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1085         (TestWebKitAPI::TEST):
1086         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1089         (TestWebKitAPI::TEST):
1090         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1091         (TestWebKitAPI::TEST):
1092         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1093         (TestWebKitAPI::TEST):
1094         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1097         (TestWebKitAPI::TEST):
1098         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1099         (TestWebKitAPI::TEST):
1100         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1103         (TestWebKitAPI::TEST):
1104         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1105         (TestWebKitAPI::TEST):
1106         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1107         (TestWebKitAPI::TEST):
1108         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1109         (TestWebKitAPI::TEST):
1110         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1111         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1112         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1113         (TestWebKitAPI::TEST):
1114         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1117         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1118         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1119         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1120         (TestWebKitAPI::TEST):
1121         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1122         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1123         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1124         (TestWebKitAPI::TEST):
1125         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1126         (TestWebKitAPI::TEST):
1127         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1128         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1129         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1130         (TestWebKitAPI::TEST):
1131         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1132         (TestWebKitAPI::loadAlternateHTMLString):
1133         (TestWebKitAPI::TEST):
1134         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1135         (TestWebKitAPI::TEST):
1136         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1137         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1138         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1139         (TestWebKitAPI::buildAndPerformTest):
1140         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1141         (TestWebKitAPI::TEST):
1142         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1143         (TestWebKitAPI::TEST):
1144         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1145         (TestWebKitAPI::TEST):
1146         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1159         (TestWebKitAPI::TEST):
1160         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1161         (TestWebKitAPI::TEST):
1162         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1163         (TestWebKitAPI::TEST):
1164         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1165         (TestWebKitAPI::TEST):
1166         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1171         (TestWebKitAPI::TEST):
1172         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1173         (TestWebKitAPI::TEST):
1174         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1175         (TestWebKitAPI::TEST):
1176         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1177         (TestWebKitAPI::TEST):
1178         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1179         (TestWebKitAPI::TEST):
1180         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1181         (TestWebKitAPI::TEST):
1182         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1183         (TestWebKitAPI::TEST):
1184         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1185         (TestWebKitAPI::TEST):
1186         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1187         (TestWebKitAPI::TEST):
1188         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1189         (TestWebKitAPI::TEST):
1190         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1191         (TestWebKitAPI::TEST):
1192         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1193         (TestWebKitAPI::TEST):
1194         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1195         (TestWebKitAPI::TEST):
1196         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1197         (TestWebKitAPI::TEST):
1198         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1199         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1200         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1201         (TestWebKitAPI::TEST):
1202         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1203         (TestWebKitAPI::TEST):
1204         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1205         (TestWebKitAPI::TEST):
1206         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1207         (TestWebKitAPI::TEST):
1208         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1209         (TestWebKitAPI::TEST):
1210         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1211         (TestWebKitAPI::TEST):
1212         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1213         (TestWebKitAPI::TEST):
1214         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1215         (TestWebKitAPI::TEST):
1216         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1217         (TestWebKitAPI::TEST):
1218         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1219         (TestWebKitAPI::TEST):
1220         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1221         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1222         (TEST):
1223         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1224         (TEST):
1225         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1226         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1227         (TEST):
1228         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1229         (TestWebKitAPI::TEST):
1230         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1231         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1232         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1233         (WTR::getMenuItemTitleCallback):
1234         (WTR::createMouseMessageBody):
1235         (WTR::EventSendingController::mouseDown):
1236         (WTR::EventSendingController::mouseUp):
1237         (WTR::EventSendingController::mouseMoveTo):
1238         (WTR::EventSendingController::mouseForceClick):
1239         (WTR::EventSendingController::startAndCancelMouseForceClick):
1240         (WTR::EventSendingController::mouseForceDown):
1241         (WTR::EventSendingController::mouseForceUp):
1242         (WTR::EventSendingController::mouseForceChanged):
1243         (WTR::EventSendingController::leapForward):
1244         (WTR::EventSendingController::scheduleAsynchronousClick):
1245         (WTR::createKeyDownMessageBody):
1246         (WTR::EventSendingController::keyDown):
1247         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1248         (WTR::EventSendingController::mouseScrollBy):
1249         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1250         (WTR::EventSendingController::continuousMouseScrollBy):
1251         (WTR::EventSendingController::addTouchPoint):
1252         (WTR::EventSendingController::updateTouchPoint):
1253         (WTR::EventSendingController::setTouchModifier):
1254         (WTR::EventSendingController::setTouchPointRadius):
1255         (WTR::EventSendingController::touchStart):
1256         (WTR::EventSendingController::touchMove):
1257         (WTR::EventSendingController::touchEnd):
1258         (WTR::EventSendingController::touchCancel):
1259         (WTR::EventSendingController::clearTouchPoints):
1260         (WTR::EventSendingController::releaseTouchPoint):
1261         (WTR::EventSendingController::cancelTouchPoint):
1262         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1263         (WTR::InjectedBundle::didCreatePage):
1264         (WTR::InjectedBundle::didReceiveMessage):
1265         (WTR::InjectedBundle::didReceiveMessageToPage):
1266         (WTR::InjectedBundle::booleanForKey):
1267         (WTR::InjectedBundle::done):
1268         (WTR::InjectedBundle::dumpToStdErr):
1269         (WTR::InjectedBundle::outputText):
1270         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1271         (WTR::InjectedBundle::postAddChromeInputField):
1272         (WTR::InjectedBundle::postRemoveChromeInputField):
1273         (WTR::InjectedBundle::postFocusWebView):
1274         (WTR::InjectedBundle::postSetBackingScaleFactor):
1275         (WTR::InjectedBundle::postSetWindowIsKey):
1276         (WTR::InjectedBundle::postSetViewSize):
1277         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1278         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1279         (WTR::InjectedBundle::setGeolocationPermission):
1280         (WTR::InjectedBundle::setMockGeolocationPosition):
1281         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1282         (WTR::InjectedBundle::isGeolocationProviderActive const):
1283         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1284         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1285         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1286         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1287         (WTR::InjectedBundle::setCustomPolicyDelegate):
1288         (WTR::InjectedBundle::setHidden):
1289         (WTR::InjectedBundle::setCacheModel):
1290         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1291         (WTR::InjectedBundle::processWorkQueue):
1292         (WTR::InjectedBundle::queueBackNavigation):
1293         (WTR::InjectedBundle::queueForwardNavigation):
1294         (WTR::InjectedBundle::queueLoad):
1295         (WTR::InjectedBundle::queueLoadHTMLString):
1296         (WTR::InjectedBundle::queueReload):
1297         (WTR::InjectedBundle::queueLoadingScript):
1298         (WTR::InjectedBundle::queueNonLoadingScript):
1299         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1300         (WTR::frameToStr):
1301         (WTR::InjectedBundlePage::InjectedBundlePage):
1302         (WTR::dumpFrameDescriptionSuitableForTestResult):
1303         (WTR::dumpFrameScrollPosition):
1304         (WTR::dumpDescendantFrameScrollPositions):
1305         (WTR::dumpFrameText):
1306         (WTR::dumpDescendantFramesText):
1307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1308         (WTR::TestRunner::shouldDumpPixels const):
1309         (WTR::TestRunner::setDumpPixels):
1310         (WTR::TestRunner::whatToDump const):
1311         (WTR::TestRunner::setWhatToDump):
1312         (WTR::TestRunner::setWaitUntilDone):
1313         (WTR::TestRunner::shouldWaitUntilDone const):
1314         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1315         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1316         (WTR::TestRunner::clearAllDatabases):
1317         (WTR::TestRunner::setIDBPerOriginQuota):
1318         (WTR::TestRunner::originsWithApplicationCache):
1319         (WTR::TestRunner::setCanOpenWindows):
1320         (WTR::TestRunner::setXSSAuditorEnabled):
1321         (WTR::TestRunner::setMediaDevicesEnabled):
1322         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1323         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1324         (WTR::TestRunner::setCustomUserAgent):
1325         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1326         (WTR::TestRunner::setModernMediaControlsEnabled):
1327         (WTR::TestRunner::setWebGL2Enabled):
1328         (WTR::TestRunner::setWritableStreamAPIEnabled):
1329         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1330         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1331         (WTR::TestRunner::setAllowsAnySSLCertificate):
1332         (WTR::TestRunner::setPluginsEnabled):
1333         (WTR::TestRunner::setValueForUser):
1334         (WTR::TestRunner::setAudioResult):
1335         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1336         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1337         (WTR::TestRunner::setAlwaysAcceptCookies):
1338         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1339         (WTR::TestRunner::isDoingMediaCapture const):
1340         (WTR::TestRunner::queueLoad):
1341         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1342         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1343         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1344         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1345         (WTR::TestRunner::setAuthenticationUsername):
1346         (WTR::TestRunner::setAuthenticationPassword):
1347         (WTR::TestRunner::secureEventInputIsEnabled const):
1348         (WTR::TestRunner::setBlockAllPlugins):
1349         (WTR::TestRunner::setPluginSupportedMode):
1350         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1351         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1352         (WTR::TestRunner::setNavigationGesturesEnabled):
1353         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1354         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1355         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1356         (WTR::TestRunner::terminateNetworkProcess):
1357         (WTR::TestRunner::terminateServiceWorkerProcess):
1358         (WTR::TestRunner::runUIScript):
1359         (WTR::TestRunner::setStatisticsDebugMode):
1360         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1361         (WTR::TestRunner::setStatisticsLastSeen):
1362         (WTR::TestRunner::setStatisticsPrevalentResource):
1363         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1364         (WTR::TestRunner::dumpResourceLoadStatistics):
1365         (WTR::TestRunner::isStatisticsPrevalentResource):
1366         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1367         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1368         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1369         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1370         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1371         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1372         (WTR::TestRunner::setStatisticsGrandfathered):
1373         (WTR::TestRunner::isStatisticsGrandfathered):
1374         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1375         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1376         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1377         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1378         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1379         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1380         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1381         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1382         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1383         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1384         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1385         (WTR::TestRunner::statisticsSubmitTelemetry):
1386         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1387         (WTR::TestRunner::setStatisticsIsRunningTest):
1388         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1389         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1390         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1391         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1392         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1393         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1394         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1395         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1396         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1397         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1398         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1399         (WTR::TestRunner::statisticsResetToConsistentState):
1400         (WTR::TestRunner::setStorageAccessAPIEnabled):
1401         (WTR::TestRunner::getAllStorageAccessEntries):
1402         (WTR::TestRunner::addMockMediaDevice):
1403         (WTR::TestRunner::clearMockMediaDevices):
1404         (WTR::TestRunner::removeMockMediaDevice):
1405         (WTR::TestRunner::resetMockMediaDevices):
1406         (WTR::TestRunner::connectMockGamepad):
1407         (WTR::TestRunner::disconnectMockGamepad):
1408         (WTR::TestRunner::setMockGamepadDetails):
1409         (WTR::TestRunner::setMockGamepadAxisValue):
1410         (WTR::TestRunner::setMockGamepadButtonValue):
1411         (WTR::TestRunner::removeAllSessionCredentials):
1412         (WTR::TestRunner::clearDOMCache):
1413         (WTR::TestRunner::clearDOMCaches):
1414         (WTR::TestRunner::hasDOMCache):
1415         (WTR::TestRunner::domCacheSize):
1416         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1417         (WTR::TestRunner::getApplicationManifestThen):
1418         (WTR::TestRunner::injectUserScript):
1419         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1420         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1421         (WTR::TestRunner::addTestKeyToKeychain):
1422         (WTR::TestRunner::cleanUpKeychain):
1423         (WTR::TestRunner::keyExistsInKeychain):
1424         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1425         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1426         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1427         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1428         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1429         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1430         * WebKitTestRunner/TestController.cpp:
1431         (WTR::TestController::initialize):
1432         (WTR::parseStringTestHeaderValueAsRelativePath):
1433         (WTR::updateTestOptionsFromTestHeader):
1434         (WTR::TestController::runTest):
1435         (WTR::TestController::didReceiveLiveDocumentsList):
1436         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1437         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1438         (WTR::TestController::didFinishNavigation):
1439         (WTR::TestController::didReceiveAuthenticationChallenge):
1440         * WebKitTestRunner/TestInvocation.cpp:
1441         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1442         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1443         (WTR::TestInvocation::uiScriptDidComplete):
1444         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1445         * WebKitTestRunner/WebNotificationProvider.cpp:
1446         (WTR::WebNotificationProvider::closeWebNotification):
1447         * WebKitTestRunner/WorkQueueManager.cpp:
1448         (WTR::ScriptItem::ScriptItem):
1449         (WTR::WorkQueueManager::queueLoad):
1450         (WTR::WorkQueueManager::queueLoadHTMLString):
1451
1452 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1453
1454         Add a comment to make my test from r244139 less mysterious.
1455         https://bugs.webkit.org/show_bug.cgi?id=196744
1456
1457         As suggested by Darin Adler.
1458
1459         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1460         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1461
1462 2019-04-17  Chris Dumez  <cdumez@apple.com>
1463
1464         Remember device orientation permission for the duration of the browsing session
1465         https://bugs.webkit.org/show_bug.cgi?id=196992
1466         <rdar://problem/49946067>
1467
1468         Reviewed by Alex Christensen.
1469
1470         Add API test coverage.
1471
1472         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1473         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1474         (TEST):
1475
1476 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1477
1478         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1479         https://bugs.webkit.org/show_bug.cgi?id=196675
1480
1481         Reviewed by Lucas Forschler.
1482
1483         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1484         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1485
1486 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1487
1488         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1489         https://bugs.webkit.org/show_bug.cgi?id=196919
1490         <rdar://problem/41630459>
1491
1492         Reviewed by Tim Horton.
1493
1494         Add iOS support for several new testing hooks. See below for more detail.
1495
1496         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1497         (WTR::UIScriptController::isDismissingMenu const):
1498
1499         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1500         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1501         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1502
1503         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1504         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1505         (WTR::UIScriptController::isDismissingMenu const):
1506         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1507         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1508         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1509         (WTR::InjectedBundle::didReceiveMessageToPage):
1510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1511         (WTR::TestRunner::setAllowedMenuActions):
1512
1513         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1514         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1515         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1516         against the name of the custom action.
1517
1518         (WTR::TestRunner::installCustomMenuAction):
1519
1520         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1521         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1522         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1523         triggered.
1524
1525         (WTR::TestRunner::performCustomMenuAction):
1526
1527         Invoked when the custom menu action is triggered.
1528
1529         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1530         * WebKitTestRunner/TestController.cpp:
1531         (WTR::TestController::installCustomMenuAction):
1532         (WTR::TestController::setAllowedMenuActions):
1533         * WebKitTestRunner/TestController.h:
1534         * WebKitTestRunner/TestInvocation.cpp:
1535         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1536         (WTR::TestInvocation::performCustomMenuAction):
1537
1538         Add plumbing to call back into the injected bundle when performing the custom action.
1539
1540         * WebKitTestRunner/TestInvocation.h:
1541         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1542         (WTR::TestController::installCustomMenuAction):
1543         (WTR::TestController::setAllowedMenuActions):
1544         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1545         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1546         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1547         (-[TestRunnerWKWebView becomeFirstResponder]):
1548         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1549
1550         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1551         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1552         in the Mail app on iOS.
1553
1554         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1555         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1556         (-[TestRunnerWKWebView resetCustomMenuAction]):
1557         (-[TestRunnerWKWebView performCustomAction:]):
1558         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1559         (-[TestRunnerWKWebView _willHideMenu]):
1560         (-[TestRunnerWKWebView _didHideMenu]):
1561         * WebKitTestRunner/ios/TestControllerIOS.mm:
1562         (WTR::TestController::platformResetStateToConsistentValues):
1563
1564         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1565         if specified.
1566
1567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1568         (WTR::UIScriptController::isDismissingMenu const):
1569
1570 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1571
1572         Allow sharing from imageSheet on an image document
1573         https://bugs.webkit.org/show_bug.cgi?id=196891
1574         <rdar://problem/25377386>
1575
1576         Reviewed by Tim Horton.
1577
1578         Test to make sure that the correct imageURL is extracted from an image element.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1581         (TestWebKitAPI::TEST):
1582
1583 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1584
1585         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1586         https://bugs.webkit.org/show_bug.cgi?id=196995
1587
1588         Reviewed by Brady Eidson.
1589
1590         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1591         (TEST):
1592
1593 2019-04-16  Chris Dumez  <cdumez@apple.com>
1594
1595         URL set by document.open() is not communicated to the UIProcess
1596         https://bugs.webkit.org/show_bug.cgi?id=196941
1597         <rdar://problem/49237544>
1598
1599         Reviewed by Geoff Garen.
1600
1601         Add API test coverage.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1605         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1606         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1607         (TEST):
1608
1609 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1610
1611         Unreviewed, rolling out r244321.
1612         https://bugs.webkit.org/show_bug.cgi?id=196968
1613
1614         Causing all WK2 Debug builds to exit early after Assertion
1615         failures. (Requested by ShawnRoberts on #webkit).
1616
1617         Reverted changeset:
1618
1619         "URL set by document.open() is not communicated to the
1620         UIProcess"
1621         https://bugs.webkit.org/show_bug.cgi?id=196941
1622         https://trac.webkit.org/changeset/244321
1623
1624 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1625
1626         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1627         https://bugs.webkit.org/show_bug.cgi?id=196948
1628
1629         Reviewed by Zalan Bujtas.
1630
1631         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1632         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1633
1634 2019-04-15  Chris Dumez  <cdumez@apple.com>
1635
1636         URL set by document.open() is not communicated to the UIProcess
1637         https://bugs.webkit.org/show_bug.cgi?id=196941
1638         <rdar://problem/49237544>
1639
1640         Reviewed by Geoffrey Garen.
1641
1642         Add API test coverage.
1643
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1646         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1647         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1648         (TEST):
1649
1650 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1651
1652         Using Tools/Scripts/clean-webkit should not install requests
1653         https://bugs.webkit.org/show_bug.cgi?id=196940
1654
1655         Reviewed by Lucas Forschler.
1656
1657         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1658         existing, depending on the path autoinstalled is run through.
1659         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1660         needed.
1661         (Port.configuration_for_upload):
1662         (Port.commits_for_upload):
1663
1664 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1665
1666         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1667         https://bugs.webkit.org/show_bug.cgi?id=196773
1668
1669         Reviewed by Jer Noble.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1672         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1673         (TEST):
1674
1675 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1676
1677         ews-build should clearly indicate flaky test failures
1678         https://bugs.webkit.org/show_bug.cgi?id=196947
1679
1680         Reviewed by Lucas Forschler.
1681
1682         * BuildSlaveSupport/ews-build/steps.py:
1683         (AnalyzeAPITestsResults.analyzeResults):
1684
1685 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1686
1687         InjectedBundle parameters often need initialization function called before unarchiving
1688         https://bugs.webkit.org/show_bug.cgi?id=189709
1689         <rdar://problem/44573653>
1690
1691         Reviewed by Ryosuke Niwa.
1692
1693         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1694         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1695
1696 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1697
1698         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1699         https://bugs.webkit.org/show_bug.cgi?id=196681
1700
1701         Reviewed by Darin Adler.
1702
1703         Added tests.
1704
1705         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1706         (WTF_HashSet.RemoveIf):
1707         (WTF_HashSet.RemoveIfShrinkToBestSize):
1708
1709 2019-04-15  John Wilander  <wilander@apple.com>
1710
1711         Send delayed Ad Click Attribution conversion requests to the click source
1712         https://bugs.webkit.org/show_bug.cgi?id=196838
1713         <rdar://problem/47650157>
1714
1715         Reviewed by Chris Dumez and Youenn Fablet.
1716
1717         This patch adds test infrastructure to override the default behavior in
1718         WebKit::NetworkAdClickAttribution.
1719
1720         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1721         (TestWebKitAPI::TEST):
1722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1724         (WTR::TestRunner::dumpAdClickAttribution):
1725         (WTR::TestRunner::clearAdClickAttribution):
1726         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1727         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1731         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1732         * WebKitTestRunner/TestController.h:
1733         * WebKitTestRunner/TestInvocation.cpp:
1734         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1735
1736 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-app] status-bubble should display position in queue
1739         https://bugs.webkit.org/show_bug.cgi?id=196607
1740
1741         Reviewed by Lucas Forschler.
1742
1743         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1744         (StatusBubble._build_bubble):
1745         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1746
1747 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-build] Do not run clean build by default on EWS builders
1750         https://bugs.webkit.org/show_bug.cgi?id=196897
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * BuildSlaveSupport/ews-build/steps.py:
1755         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1756         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1757         untracked directories like WebKitBuild).
1758         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1759         untracked files/directories (like WebKitBuild).
1760
1761 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1762
1763         TestRunner::notifyDone() should be safely reentrant
1764         https://bugs.webkit.org/show_bug.cgi?id=196898
1765
1766         Reviewed by Darin Adler.
1767
1768         It is currently possible that TestRunner::notifyDone() will call itself, since
1769         notifyDone() will force a repaint, which can start executing JavaScript, which
1770         may call notifyDone() again. This can lead to test failures and flakiness.
1771         Fix this by setting the m_waitToDump flag before calling the dump() method.
1772
1773         * DumpRenderTree/mac/TestRunnerMac.mm:
1774         (TestRunner::notifyDone):
1775         (TestRunner::forceImmediateCompletion):
1776         * DumpRenderTree/win/TestRunnerWin.cpp:
1777         (TestRunner::notifyDone):
1778         (TestRunner::forceImmediateCompletion):
1779
1780 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1781
1782         [GTK][WPE] Add enable-media websetting
1783         https://bugs.webkit.org/show_bug.cgi?id=196863
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1788         (testWebKitSettings): Add test for the enable-media web-setting.
1789
1790 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1793         https://bugs.webkit.org/show_bug.cgi?id=196905
1794         <rdar://problem/49886096>
1795
1796         Reviewed by Tim Horton.
1797
1798         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1799         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1800         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1801         delay timer, we end up with this sequence of events in the problematic (failure) case:
1802
1803         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1804             ...IPC from UI to web process...
1805         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1806             ...IPC from web to UI process...
1807         (c) [UI]    Invoke completion handler for script #1
1808         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1809             ...IPC from UI to web process...
1810         (e) [Web]   Evaluate script #2 in the web process
1811         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1812
1813         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1814         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1815         #2 is run in step (e).
1816
1817         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1818         the UI process by waiting on a script message posted by the web process, after attachment updates are
1819         dispatched.
1820
1821         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1822         (TestWebKitAPI::TEST):
1823
1824 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1825
1826         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1827         https://bugs.webkit.org/show_bug.cgi?id=196909
1828
1829         Reviewed by Wenson Hsieh.
1830
1831         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1832         (TestWebKitAPI::TEST):
1833
1834 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1835
1836         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1837         https://bugs.webkit.org/show_bug.cgi?id=196880
1838
1839         Reviewed by Yusuke Suzuki.
1840
1841         Add a new function for bytecode cache tests that does not forceDiskCache
1842         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1843         test added in this patch, since the code is invalid and therefore won't be
1844         cached. It should also be useful for tests that evaluate dynamically
1845         generated code.
1846
1847         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1848         * Scripts/run-jsc-stress-tests:
1849
1850 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1851
1852         Update AudioSession route sharing policy
1853         https://bugs.webkit.org/show_bug.cgi?id=196776
1854         <rdar://problem/46501611>
1855
1856         Reviewed by Jer Noble.
1857
1858         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1859         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1860         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1861         (TestWebKitAPI::TEST):
1862
1863 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1864
1865         [iOS] Software keyboard is shown too frequently on some websites
1866         https://bugs.webkit.org/show_bug.cgi?id=195856
1867         <rdar://problem/49191395>
1868
1869         Reviewed by Darin Adler.
1870
1871         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1872
1873         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1874         (WTR::UIScriptController::setHardwareKeyboardAttached):
1875         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1876         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1877         (WTR::UIScriptController::setHardwareKeyboardAttached):
1878         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1879         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1880
1881         Additionally link against GraphicsServices in WebKitTestRunner.
1882
1883         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1884         (WTR::TestController::platformResetStateToConsistentValues):
1885         (WTR::UIScriptController::setHardwareKeyboardAttached):
1886
1887 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1888
1889         [GTK][WPE] Fix pacman install-dependencies packages
1890         https://bugs.webkit.org/show_bug.cgi?id=196817
1891
1892         Reviewed by Žan Doberšek.
1893         
1894         python3-setuptools is called python-setuptools
1895         ruby-highline is only available on AUR
1896         libv4l-devel is incorporated in v4l-utils
1897
1898         * gtk/install-dependencies:
1899         * wpe/install-dependencies:
1900
1901 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1902
1903         [GTK] REGRESSION(r243860): Many tests failing
1904         https://bugs.webkit.org/show_bug.cgi?id=196791
1905
1906         Reviewed by Joanmarie Diggs.
1907
1908         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1909         multiple documents and check that accessibility hierarchy is updated after a navigation.
1910
1911         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1912         (loadChangedCallback):
1913         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1914         (AccessibilityTest::AccessibilityTest):
1915         (AccessibilityTest::~AccessibilityTest):
1916         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1917         (AccessibilityTest::findTestServerApplication):
1918         (AccessibilityTest::findDocumentWeb):
1919         (AccessibilityTest::findRootObject):
1920         (AccessibilityTest::waitUntilChildrenRemoved):
1921         (AccessibilityTest::ensureProxy):
1922         (testAtspiBasicHierarchy):
1923         (beforeAll):
1924         (afterAll):
1925
1926 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1927
1928         [ews-build] Handle bug titles with unicode characters
1929         https://bugs.webkit.org/show_bug.cgi?id=196802
1930
1931         Reviewed by Dewei Zhu.
1932
1933         * BuildSlaveSupport/ews-build/steps.py:
1934         (ValidatePatch._is_bug_closed):
1935
1936 2019-04-11  Michael Saboff  <msaboff@apple.com>
1937
1938         Improve the Inline Cache Stats code
1939         https://bugs.webkit.org/show_bug.cgi?id=196836
1940
1941         Reviewed by Saam Barati.
1942
1943         Added a new script to consolidate and arrange the output of --useICStats option.
1944
1945         This script merges the output from every group into one large table and sorts it from most common to
1946         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1947         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1948         Put together, this is useful to see what property accesses are not getting cached.
1949
1950         * Scripts/ic-stats.py: Added.
1951         (ICStats):
1952         (ICStats.__init__):
1953         (ICStats.parse):
1954         (ICStats.dumpStats):
1955         (usage):
1956
1957 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1958
1959         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1960         https://bugs.webkit.org/show_bug.cgi?id=196809
1961         <rdar://49800762>
1962
1963         Reviewed by Brady Eidson.
1964
1965         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1966         (TEST):
1967
1968 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1969
1970         requestAnimationFrame should execute before the next frame
1971         https://bugs.webkit.org/show_bug.cgi?id=177484
1972
1973         Reviewed by Simon Fraser.
1974
1975         Add trace points for the page RenderingUpdate.
1976
1977         * Tracing/SystemTracePoints.plist:
1978
1979 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1980
1981         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1982         https://bugs.webkit.org/show_bug.cgi?id=196760
1983
1984         Reviewed by Don Olmstead.
1985
1986         vswhere.exe has been bundled since Visual Studio 2017 version
1987         15.2. We shouldn't download vswhere.exe.
1988
1989         * Scripts/build-jsc: Do not call update-vswhere.py.
1990         * Scripts/build-webkit: Ditto.
1991         * Scripts/update-vswhere.py: Removed.
1992         * Scripts/webkitdirs.pm:
1993         (requireModulesForVSWhere): Deleted.
1994         (pickCurrentVisualStudioInstallation): Deleted.
1995         (visualStudioInstallDirVSWhere): Return the latest installed VS
1996         installation path by using the bundled vswhere.exe.
1997         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1998         (visualStudioInstallDirFallback): Removed.
1999
2000 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2003         https://bugs.webkit.org/show_bug.cgi?id=196780
2004
2005         Reviewed by Alexey Proskuryakov.
2006
2007         * BuildSlaveSupport/ews-build/steps.py:
2008         * BuildSlaveSupport/ews-build/steps_unittest.py:
2009
2010 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2011
2012         Add SPI WKNavigationResponse._downloadAttribute
2013         https://bugs.webkit.org/show_bug.cgi?id=196755
2014         <rdar://49587365>
2015
2016         Reviewed by Brady Eidson.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2019         (-[NavigationResponseTestDelegate navigationResponse]):
2020         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2021         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2022         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2023         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2024         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2025         (readRequest):
2026         (writeResponse):
2027         (TEST):
2028
2029 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2030
2031         Add modern API for overriding the page's specified viewport configuration
2032         https://bugs.webkit.org/show_bug.cgi?id=167734
2033         <rdar://problem/30331795>
2034
2035         Reviewed by Simon Fraser.
2036
2037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2038         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2039
2040 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2041
2042         Add support for incremental bytecode cache updates
2043         https://bugs.webkit.org/show_bug.cgi?id=195000
2044
2045         Reviewed by Filip Pizlo.
2046
2047         Exit when the initial run to generate bytecode fails.
2048
2049         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2050
2051 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2052
2053         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2054         https://bugs.webkit.org/show_bug.cgi?id=196744
2055         <rdar://49415309>
2056
2057         Reviewed by Chris Dumez.
2058
2059         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2060         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2061
2062 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2063
2064         Add a way to opt into modern compatibility mode in layout tests
2065         https://bugs.webkit.org/show_bug.cgi?id=196770
2066         <rdar://problem/49777550>
2067
2068         Reviewed by Antoine Quint.
2069
2070         Add a new test option to enable modern compatibility mode in layout tests.
2071
2072         * WebKitTestRunner/TestController.cpp:
2073         (WTR::updateTestOptionsFromTestHeader):
2074         * WebKitTestRunner/TestController.h:
2075         * WebKitTestRunner/TestOptions.h:
2076         (WTR::TestOptions::hasSameInitializationOptions const):
2077         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2078         (WTR::TestController::platformCreateWebView):
2079         (WTR::TestController::enableModernCompatibilityMode):
2080
2081 2019-04-10  Andy Estes  <aestes@apple.com>
2082
2083         Try to fix the 32-bit watchOS build.
2084
2085         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2086         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2087
2088 2019-04-10  Antoine Quint  <graouts@apple.com>
2089
2090         Enable Pointer Events on watchOS
2091         https://bugs.webkit.org/show_bug.cgi?id=196771
2092         <rdar://problem/49040909>
2093
2094         Reviewed by Dean Jackson.
2095
2096         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2097
2098 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2099
2100         Unreviewed. Fix WPE accessibility tests after r244059.
2101
2102         We are failing to load the injected bundle due to undefined symbol
2103         AccessibilityUIElement::replaceTextInRange().
2104
2105         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2106         (WTR::AccessibilityUIElement::replaceTextInRange):
2107
2108 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2109
2110         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2111         https://bugs.webkit.org/show_bug.cgi?id=196727
2112
2113         Reviewed by Fujii Hironori.
2114
2115         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2116         (WebKitBrowserWindow::create):
2117
2118 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2119
2120         [ews-build] Add unit tests for PrintConfiguration
2121         https://bugs.webkit.org/show_bug.cgi?id=196752
2122
2123         Reviewed by Dewei Zhu.
2124
2125         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2126
2127 2019-04-09  Keith Rollin  <krollin@apple.com>
2128
2129         Unreviewed build maintenance -- update .xcfilelists.
2130
2131         * DumpRenderTree/DerivedSources-input.xcfilelist:
2132         * DumpRenderTree/DerivedSources-output.xcfilelist:
2133
2134 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2135
2136         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2137         https://bugs.webkit.org/show_bug.cgi?id=196743
2138         <rdar://problem/43897551>
2139
2140         Reviewed by Tim Horton.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2143         (TEST):
2144
2145 2019-04-09  Youenn Fablet  <youenn@apple.com>
2146
2147         Close service worker database on network process suspension
2148         https://bugs.webkit.org/show_bug.cgi?id=196623
2149         <rdar://problem/48930869>
2150
2151         Reviewed by Alex Christensen.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2154
2155 2019-04-09  Daniel Bates  <dabates@apple.com>
2156
2157         [iPad] Should open popover when the spacebar is pressed
2158         https://bugs.webkit.org/show_bug.cgi?id=196360
2159         <rdar://problem/49389129>
2160
2161         Reviewed by Brent Fulgham.
2162
2163         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2164
2165         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2166         (WTR::UIScriptController::isShowingPopover const): Added.
2167         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2168         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2169         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2170         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2172         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2173         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2174         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2175         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2176         (WTR::UIScriptController::isShowingPopover const): Added.
2177         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2178         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2179         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2180         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2182         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2183         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2184         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2185         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2186         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2187         (WTR::UIScriptController::isShowingPopover const): Added.
2188         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2189         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2190
2191 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2192
2193         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2194         https://bugs.webkit.org/show_bug.cgi?id=196665
2195         <rdar://45115669>
2196
2197         Reviewed by Geoff Garen.
2198
2199         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2200         (goBack):
2201         (+[SimpleLookupContext sharedLookupContext]):
2202         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2203         (TEST):
2204         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2205         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2206
2207 2019-04-09  John Wilander  <wilander@apple.com>
2208
2209         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2210         https://bugs.webkit.org/show_bug.cgi?id=196558
2211         <rdar://problem/47650245>
2212
2213         Reviewed by Youenn Fablet.
2214
2215         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2216         (TestWebKitAPI::TEST):
2217             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2218
2219 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2220
2221         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2222         https://bugs.webkit.org/show_bug.cgi?id=196720
2223
2224         Reviewed by Konstantin Tokarev.
2225
2226         * TestWebKitAPI/PlatformMac.cmake:
2227
2228 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2229
2230         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2231         https://bugs.webkit.org/show_bug.cgi?id=196694
2232         <rdar://problem/48388734>
2233
2234         Rubber-stamped by Aakash Jain.
2235
2236         * Scripts/webkitpy/port/image_diff.py:
2237         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2238         * Scripts/webkitpy/port/server_process.py:
2239         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2240         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2241         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2242         * Scripts/webkitpy/port/server_process_mock.py:
2243         (MockServerProcess.has_available_stdout):
2244         * Scripts/webkitpy/port/server_process_unittest.py:
2245         (TestServerProcess.serial_test_basic):
2246
2247 2019-04-09  Jer Noble  <jer.noble@apple.com>
2248
2249         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2250         https://bugs.webkit.org/show_bug.cgi?id=196097
2251
2252         Reviewed by Eric Carlson.
2253
2254         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (resetWebPreferencesToConsistentValues):
2258         * WebKitTestRunner/TestController.cpp:
2259         (WTR::TestController::resetPreferencesToConsistentValues):
2260
2261 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2262
2263         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2264         https://bugs.webkit.org/show_bug.cgi?id=196690
2265
2266         Reviewed by Michael Catanzaro.
2267
2268         * QueueStatusServer/config/queues.py:
2269         * Scripts/webkitpy/common/config/ews.json:
2270         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2271         (test_ews_name):
2272
2273 2019-04-09  Chris Dumez  <cdumez@apple.com>
2274
2275         Loads using loadHTMLString() cause flashing when process-swapping
2276         https://bugs.webkit.org/show_bug.cgi?id=196714
2277         <rdar://problem/49637354>
2278
2279         Reviewed by Antti Koivisto.
2280
2281         Add API test coverage.
2282
2283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2284
2285 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2286
2287         Unreviewed. Fix ATK accessibility tests after r244059.
2288
2289         We are failing to load the injected bundle due to undefined symbol
2290         AccessibilityUIElement::replaceTextInRange().
2291
2292         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2293         (WTR::AccessibilityUIElement::replaceTextInRange):
2294
2295 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2296
2297         AX: Support API: accessibilityReplaceRange:withText
2298         https://bugs.webkit.org/show_bug.cgi?id=196636
2299
2300         Unreviewed build fix for Windows port.
2301
2302         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2303         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2304
2305 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2306
2307         [CMake][WinCairo] Separate copied headers into different directories
2308         https://bugs.webkit.org/show_bug.cgi?id=196655
2309
2310         Reviewed by Michael Catanzaro.
2311
2312         * DumpRenderTree/CMakeLists.txt:
2313         * MiniBrowser/win/CMakeLists.txt:
2314         * TestWebKitAPI/CMakeLists.txt:
2315         * TestWebKitAPI/PlatformWin.cmake:
2316
2317 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2318
2319         Log stack-trace for run-webkit-tests when interrupted
2320         https://bugs.webkit.org/show_bug.cgi?id=176393
2321         <rdar://problem/34262310>
2322
2323         Reviewed by Lucas Forschler.
2324
2325         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2326         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2327         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2328         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2329         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2331         (main): Set handlers to log stack trace on interruption.
2332
2333 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2334
2335         AX: Support API: accessibilityReplaceRange:withText
2336         https://bugs.webkit.org/show_bug.cgi?id=196636
2337
2338         Unreviewed build fix for Windows port.
2339
2340         * DumpRenderTree/AccessibilityUIElement.cpp:
2341         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2342
2343 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Scripts using Buildbot API have CORS error
2346         https://bugs.webkit.org/show_bug.cgi?id=196709
2347
2348         Reviewed by Alexey Proskuryakov.
2349
2350         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2351
2352 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2353
2354         AX: Support API: accessibilityReplaceRange:withText
2355         https://bugs.webkit.org/show_bug.cgi?id=196636
2356
2357         Reviewed by Daniel Bates.
2358
2359         * DumpRenderTree/AccessibilityUIElement.cpp:
2360         (replaceTextInRangeCallback):
2361         (AccessibilityUIElement::replaceTextInRange):
2362         (AccessibilityUIElement::getJSClass):
2363         * DumpRenderTree/AccessibilityUIElement.h:
2364         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2365         (AccessibilityUIElement::replaceTextInRange):
2366         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2367         (AccessibilityUIElement::replaceTextInRange):
2368         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2369         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2370         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2371         (WTR::AccessibilityUIElement::replaceTextInRange):
2372         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2373         (WTR::AccessibilityUIElement::replaceTextInRange):
2374
2375 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2376
2377         [iOS] Do not allow starting selection drags when selection views are not visible
2378         https://bugs.webkit.org/show_bug.cgi?id=196686
2379         <rdar://problem/49399192>
2380
2381         Reviewed by Tim Horton.
2382
2383         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2384         also add some new API tests to cover scenarios where the web view is not first responder.
2385
2386         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2387         (TestWebKitAPI::TEST):
2388         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2389
2390         Add a switch to optionally make the web view first responder when starting the simulated drag.
2391
2392         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2393         (-[DragAndDropSimulator initWithWebView:]):
2394         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2395
2396 2019-04-08  Justin Fan  <justin_fan@apple.com>
2397
2398         [Web GPU] Fix Web GPU experimental feature on iOS
2399         https://bugs.webkit.org/show_bug.cgi?id=196632
2400
2401         Reviewed by Myles C. Maxfield.
2402
2403         Properly make Web GPU available on iOS 11+.
2404
2405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2406
2407 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2408
2409         [ews-build] Do not upload archive when Compile Fails
2410         https://bugs.webkit.org/show_bug.cgi?id=196674
2411
2412         Reviewed by Alexey Proskuryakov.
2413
2414         * BuildSlaveSupport/ews-build/factories.py:
2415         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2416         * BuildSlaveSupport/ews-build/steps.py:
2417         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2418         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2419         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2420
2421 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2422
2423         Enable DFG on MIPS
2424         https://bugs.webkit.org/show_bug.cgi?id=196689
2425
2426         Reviewed by Žan Doberšek.
2427
2428         Since the bytecode change, we enabled the baseline JIT on mips in
2429         r240432, but DFG is still missing. With this change, all tests are
2430         passing on a ci20 board.
2431
2432         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2433
2434 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2435
2436         [Flatpak] Second run update-webkitwpe-flatpak fails
2437         https://bugs.webkit.org/show_bug.cgi?id=192702
2438
2439         Reviewed by Carlos Garcia Campos.
2440
2441         * flatpak/flatpakutils.py:
2442         (FlatpakObject.flatpak): Fix typo.
2443         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2444         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2445
2446 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2447
2448         [GTK][WPE] outlook.live.com displays old-fashioned UI
2449         https://bugs.webkit.org/show_bug.cgi?id=196642
2450
2451         Reviewed by Carlos Garcia Campos.
2452
2453         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2454         (TestWebKitAPI::TEST): New Mac platform quirk test.
2455
2456 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2457
2458         Unreviewed, rolling out r243956.
2459         https://bugs.webkit.org/show_bug.cgi?id=196688
2460
2461         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2462         by aakashjain on #webkit).
2463
2464         Reverted changeset:
2465
2466         "Clicking "Go Back" from a safe browsing warning from an
2467         iframe should navigate the WKWebView back to the previous
2468         page"
2469         https://bugs.webkit.org/show_bug.cgi?id=196665
2470         https://trac.webkit.org/changeset/243956
2471
2472 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2473
2474         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2475         https://bugs.webkit.org/show_bug.cgi?id=196669
2476
2477         Reviewed by Geoffrey Garen.
2478
2479         Added three new unit tests for WeakHashSet.
2480
2481         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2482         (WTF_WeakPtr.WeakHashSetConstObjects):
2483         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2484         (WTF_WeakPtr.WeakHashSetComputeSize):
2485
2486 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2487
2488         Hide next and previous form control buttons when WKWebView is editable
2489         https://bugs.webkit.org/show_bug.cgi?id=196672
2490         <rdar://problem/35625321>
2491
2492         Reviewed by Tim Horton.
2493
2494         Add a new API test.
2495
2496         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2497         (-[TestWKWebView lastTrailingBarButtonGroup]):
2498         (TestWebKitAPI::TEST):
2499         * TestWebKitAPI/ios/UIKitSPI.h:
2500
2501 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2502
2503         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2504         https://bugs.webkit.org/show_bug.cgi?id=196077
2505         <rdar://problem/49108202>
2506
2507         Reviewed by Chris Dumez.
2508
2509         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2510         on new web view.
2511
2512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2513
2514 2019-04-05  Saam Barati  <sbarati@apple.com>
2515
2516         Make compare-results understand MotionMark
2517         https://bugs.webkit.org/show_bug.cgi?id=196666
2518
2519         Reviewed by Yusuke Suzuki.
2520
2521         * Scripts/compare-results:
2522         (PLT5Results):
2523         (detectMotionMark):
2524         (detectMotionMark1_1):
2525         (motionMarkResults):
2526         (motionMark1_1Results):
2527         (detectBenchmark):
2528         (biggerIsBetter):
2529         (main):
2530
2531 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2532
2533         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2534         https://bugs.webkit.org/show_bug.cgi?id=196665
2535         <rdar://45115669>
2536
2537         Reviewed by Geoff Garen.
2538
2539         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2540         (goBack):
2541         (+[SimpleLookupContext sharedLookupContext]):
2542         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2543         (TEST):
2544         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2545         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2546
2547 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2548
2549         [ews-build] Add configuration and architecture for windows builders
2550         https://bugs.webkit.org/show_bug.cgi?id=196660
2551
2552         Reviewed by Lucas Forschler.
2553
2554         * BuildSlaveSupport/ews-build/config.json:
2555
2556 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2557
2558         webkitpy: Don't run subsequent rounds if interrupted
2559         https://bugs.webkit.org/show_bug.cgi?id=196646
2560
2561         Reviewed by Aakash Jain.
2562
2563         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2564         (Manager.run): Bail out if interrupted.
2565
2566 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2567
2568         Test sessionStorage in PSON private browsing mode
2569         https://bugs.webkit.org/show_bug.cgi?id=196561
2570
2571         Reviewed by Alex Christensen.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2574
2575 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2576
2577         Unreviewed, rolling out r243833.
2578         https://bugs.webkit.org/show_bug.cgi?id=196645
2579
2580         This change breaks build of WPE and GTK ports (Requested by
2581         annulen on #webkit).
2582
2583         Reverted changeset:
2584
2585         "[CMake][WTF] Mirror XCode header directories"
2586         https://bugs.webkit.org/show_bug.cgi?id=191662
2587         https://trac.webkit.org/changeset/243833
2588
2589 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2590
2591         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2592         https://bugs.webkit.org/show_bug.cgi?id=196635
2593
2594         Reviewed by Antti Koivisto.
2595         
2596         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2597         for a test to enable async frame scrolling via:
2598             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2599         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2600         
2601         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2602
2603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2604         (WTR::InjectedBundle::beginTesting):
2605         * WebKitTestRunner/TestController.cpp:
2606         (WTR::TestController::resetPreferencesToConsistentValues):
2607
2608 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2609
2610         Use a correct LC_RPATH when building with ASan
2611         https://bugs.webkit.org/show_bug.cgi?id=196576
2612
2613         Reviewed by David Kilzer.
2614
2615         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2616         so that ../Frameworks is checked. This is simpler and more reliable than updating
2617         each SPC service xcconfig.
2618
2619 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2620
2621         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2622         https://bugs.webkit.org/show_bug.cgi?id=196629
2623
2624         Reviewed by Lucas Forschler.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2627
2628 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2631         https://bugs.webkit.org/show_bug.cgi?id=196618
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2636         (StatusBubble): Added QUEUE_TRIGGERS.
2637         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2638         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2639         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2640         its parent(builder).
2641
2642 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2645         https://bugs.webkit.org/show_bug.cgi?id=196625
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2650         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2651
2652 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2653
2654         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2655         https://bugs.webkit.org/show_bug.cgi?id=196630
2656
2657         Reviewed by Wenson Hsieh.
2658
2659         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2660
2661 2019-04-04  Youenn Fablet  <youenn@apple.com>
2662
2663         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2664         https://bugs.webkit.org/show_bug.cgi?id=196543
2665
2666         Reviewed by Alex Christensen.
2667
2668         * WebKitTestRunner/TestController.cpp:
2669         (WTR::TestController::generatePageConfiguration):
2670
2671 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2672
2673         [ews-app] Status bubble should not display skipped buildbot steps
2674         https://bugs.webkit.org/show_bug.cgi?id=196584
2675
2676         Reviewed by Lucas Forschler.
2677
2678         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2679
2680 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2681
2682         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2683         https://bugs.webkit.org/show_bug.cgi?id=196620
2684
2685         Reviewed by Lucas Forschler.
2686
2687         * BuildSlaveSupport/ews-app/ews/config.py:
2688
2689 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2690
2691         [Win] DumpRenderTreeWatchDog.py is not checked into source
2692         https://bugs.webkit.org/show_bug.cgi?id=196567
2693         <rdar://problem/49525901>
2694
2695         Reviewed by Lucas Forschler.
2696
2697         This script is used on Win EWS bots to terminate hanging DRT processes.
2698
2699         * EWSTools/dumprendertreewatchdog.py: Added.
2700
2701 2019-04-04  Chris Dumez  <cdumez@apple.com>
2702
2703         Unreviewed, roll out r243858 which made tests time out.
2704
2705         Disable new API tests on Windows instead.
2706
2707         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2708         (TestWebKitAPI::TEST):
2709
2710 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2711
2712         [ATK] Cleanup WebPageAccessibilityObjectAtk
2713         https://bugs.webkit.org/show_bug.cgi?id=196537
2714
2715         Reviewed by Michael Catanzaro.
2716
2717         Also consider files under atk directories as exceptions for GObject conventions.
2718
2719         * Scripts/webkitpy/style/checkers/cpp.py:
2720         (check_identifier_name_in_declaration):
2721
2722 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2723
2724         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2725         https://bugs.webkit.org/show_bug.cgi?id=196588
2726         <rdar://problem/49365787>
2727
2728         Unreviewed build fix for Windows port.
2729
2730         error C3861: 'kill': identifier not found
2731
2732         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2733         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2734
2735 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2736
2737         [ews-build] Cancel build and similar operations should have authentication
2738         https://bugs.webkit.org/show_bug.cgi?id=196520
2739
2740         Reviewed by Dewei Zhu.
2741
2742         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2743         environment variables.
2744
2745 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2746
2747         [ews-build] Do not trigger queues which are not in production yet
2748         https://bugs.webkit.org/show_bug.cgi?id=196581
2749
2750         Reviewed by Dewei Zhu.
2751
2752         * BuildSlaveSupport/ews-build/config.json:
2753
2754 2019-04-03  Chris Dumez  <cdumez@apple.com>
2755
2756         Unreviewed, fix typo in the name of API test added in r243848.
2757
2758         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2759         (TestWebKitAPI::TEST):
2760
2761 2019-04-03  Chris Dumez  <cdumez@apple.com>
2762
2763         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2764         https://bugs.webkit.org/show_bug.cgi?id=196588
2765         <rdar://problem/49365787>
2766
2767         Reviewed by Ryosuke Niwa.
2768
2769         Add API test coverage.
2770
2771         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2772         (TestWebKitAPI::nullJavaScriptCallback):
2773         (TestWebKitAPI::didCrashCheckFrames):
2774         (TestWebKitAPI::TEST):
2775
2776 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2777
2778         run-webkit-tests: Upload test results (new results database)
2779         https://bugs.webkit.org/show_bug.cgi?id=196577
2780         <rdar://problem/34841155>
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2785         (Manager.run): Upload results after each device shard, since the configuration will be
2786         different for each device.
2787         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2788         uploaded to a results database.
2789         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2790         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2791
2792 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2793
2794         -apple-trailing-word is needed for browser detection
2795         https://bugs.webkit.org/show_bug.cgi?id=196575
2796
2797         Unreviewed.
2798
2799         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2800
2801 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2802
2803         [CMake][WTF] Mirror XCode header directories
2804         https://bugs.webkit.org/show_bug.cgi?id=191662
2805
2806         Reviewed by Konstantin Tokarev.
2807
2808         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2809         builds.
2810
2811         * CMakeLists.txt:
2812         * DumpRenderTree/CMakeLists.txt:
2813         * DumpRenderTree/PlatformWin.cmake:
2814         * MiniBrowser/win/CMakeLists.txt:
2815         * TestWebKitAPI/CMakeLists.txt:
2816         * TestWebKitAPI/PlatformWin.cmake:
2817         * WebKitTestRunner/PlatformGTK.cmake:
2818         * WebKitTestRunner/PlatformWin.cmake:
2819
2820 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2821
2822         [ews-app] Status bubble should not display certain infrastructure status messages
2823         https://bugs.webkit.org/show_bug.cgi?id=196550
2824
2825         Reviewed by Lucas Forschler.
2826
2827         Do not display the steps which are un-needed for end-user. This information is still avaiable
2828         if the user click on the bubble and look at the Buildbot build.
2829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2830         (StatusBubble._steps_messages):
2831         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2832
2833 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2834
2835         [ews-build] Use https for sending data to ews-app
2836         https://bugs.webkit.org/show_bug.cgi?id=196492
2837
2838         Reviewed by Lucas Forschler.
2839
2840         * BuildSlaveSupport/ews-build/events.py:
2841
2842 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2843
2844         Remove support for -apple-trailing-word
2845         https://bugs.webkit.org/show_bug.cgi?id=196525
2846
2847         Reviewed by Zalan Bujtas.
2848
2849         This CSS property is nonstandard and not used.
2850
2851         * Scripts/webkitperl/FeatureList.pm:
2852         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2853
2854 2019-04-03  Youenn Fablet  <youenn@apple.com>
2855
2856         Add a test for DOMCache on multiple browsing in case of private browsing
2857         https://bugs.webkit.org/show_bug.cgi?id=196524
2858
2859         Reviewed by Alex Christensen.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2862         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2863
2864 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2865
2866         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2867         https://bugs.webkit.org/show_bug.cgi?id=196540
2868
2869         Reviewed by Aakash Jain.
2870
2871         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2872
2873 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2874
2875         Add plumbing for a compatibility mode preference in WebKit
2876         https://bugs.webkit.org/show_bug.cgi?id=196005
2877
2878         Reviewed by Tim Horton.
2879
2880         Add new API tests.
2881
2882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2883         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2884
2885 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2886
2887         [WPE][GTK] Update libsrtp dependency package for Debian
2888         https://bugs.webkit.org/show_bug.cgi?id=196528
2889
2890         Reviewed by Frédéric Wang.
2891
2892         * gtk/install-dependencies:
2893         * wpe/install-dependencies:
2894
2895 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2896
2897         [WK2] Add support for Window's beforeprint / afterprint events
2898         https://bugs.webkit.org/show_bug.cgi?id=196478
2899         <rdar://problem/49535124>
2900
2901         Unreviewed build fix for MSVC.
2902
2903         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2904
2905         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2906
2907         * WebKitTestRunner/TestController.cpp:
2908         (WTR::printFrame): Use int and float literals.
2909
2910 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2911
2912         [ews-build] Reassign bots to queues
2913
2914         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2915
2916 2019-04-02  Chris Dumez  <cdumez@apple.com>
2917
2918         [WK2] Add support for Window's beforeprint / afterprint events
2919         https://bugs.webkit.org/show_bug.cgi?id=196478
2920
2921         Reviewed by Alex Christensen.
2922
2923         Add minimal implementation for printFrame in WebKitTestRunner.
2924
2925         * WebKitTestRunner/TestController.cpp:
2926         (WTR::printFrame):
2927         (WTR::TestController::createOtherPage):
2928         (WTR::TestController::createWebViewWithOptions):
2929
2930 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2931
2932         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2933         https://bugs.webkit.org/show_bug.cgi?id=196491
2934
2935         Reviewed by Lucas Forschler.
2936
2937         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2938
2939 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2940
2941         [ews-build] Configure buildbot try credentials in environment variables
2942         https://bugs.webkit.org/show_bug.cgi?id=196501
2943
2944         Reviewed by Lucas Forschler.
2945
2946         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2947         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2948         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2949
2950 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2951
2952         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2953         https://bugs.webkit.org/show_bug.cgi?id=196496
2954         <rdar://problem/49521634>
2955
2956         Reviewed by Chris Dumez.
2957
2958         Add new API tests (see WebKit ChangeLog for more detail).
2959
2960         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2961         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2962         (TEST):
2963
2964 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2965
2966         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2967         <https://webkit.org/b/196499>
2968
2969         Reviewed by Alexey Proskuryakov.
2970
2971         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2972         ENABLE_ADDRESS_SANITIZER.
2973
2974 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2975
2976         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2977         https://bugs.webkit.org/show_bug.cgi?id=182757
2978
2979         Reviewed by Don Olmstead.
2980
2981         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2982         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2983
2984 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2985
2986         run-api-tests: Upload test results
2987         https://bugs.webkit.org/show_bug.cgi?id=196323
2988         <rdar://problem/49356714>
2989
2990         Reviewed by Lucas Forschler.
2991
2992         * Scripts/webkitpy/api_tests/manager.py:
2993         (Manager):
2994         (Manager.run): Upload results to a results database.
2995         * Scripts/webkitpy/api_tests/run_api_tests.py:
2996         (parse_args): Add upload arguments.
2997         * Scripts/webkitpy/port/base.py:
2998         (Port):
2999         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3000         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3001         with commits from any other associated repositories.
3002         * Scripts/webkitpy/port/device.py:
3003         (Device):
3004         (Device.build_version): Access build_versoin of underlying platform device.
3005         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3006         (IOSSimulatorTest):
3007         (IOSSimulatorTest.test_configuration_for_upload):
3008         * Scripts/webkitpy/port/device_port.py:
3009         (DevicePort):
3010         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3011         the same as the machine uploading results.
3012         * Scripts/webkitpy/port/mac.py:
3013         (MacPort):
3014         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3015         * Scripts/webkitpy/port/mac_unittest.py:
3016         (MacTest):
3017         (MacTest.test_configuration_for_upload):
3018         * Scripts/webkitpy/xcode/simulated_device.py:
3019         (SimulatedDeviceManager._create_device_with_runtime):
3020         (SimulatedDevice.__init__): Create simulated device with a build_version.
3021         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3022         (test_existing_simulator):
3023
3024 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3025
3026         Remove extra newline characters (Follow-up fix to r243707)
3027
3028         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3029
3030 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3031
3032         [ews-app] Use API_KEY to accept results data
3033         https://bugs.webkit.org/show_bug.cgi?id=196461
3034
3035         Reviewed by Dewei Zhu.
3036
3037         * BuildSlaveSupport/ews-app/ews/views/results.py:
3038         (Results.post): Validate EWS_API_KEY before accepting any data.
3039         * BuildSlaveSupport/ews-build/events.py:
3040         (Events.sendData): Send EWS_API_KEY if available along with event data.
3041
3042 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3043
3044         Unable to copy and paste a PDF from Notes into Mail compose body
3045         https://bugs.webkit.org/show_bug.cgi?id=196442
3046         <rdar://problem/48573098>
3047
3048         Reviewed by Tim Horton.
3049
3050         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3051         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3052         to be specified on the item providers.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3055         (TestWebKitAPI::mapItemForTesting):
3056         (TestWebKitAPI::contactItemForTesting):
3057
3058 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3059
3060         Make UIWKDocumentContext rects per-character instead of per-word
3061         https://bugs.webkit.org/show_bug.cgi?id=196459
3062
3063         Reviewed by Wenson Hsieh.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3066         (TEST):
3067         Adjust test results due to switching to per-character rects.
3068
3069 2019-04-01  Chris Dumez  <cdumez@apple.com>
3070
3071         UIProcess crash when a prewarmed process is terminated
3072         https://bugs.webkit.org/show_bug.cgi?id=196451
3073         <rdar://problem/49245471>
3074
3075         Reviewed by Geoffrey Garen.
3076
3077         Add API test coverage.
3078
3079         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3080         (TEST):
3081
3082 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3085         https://bugs.webkit.org/show_bug.cgi?id=196449
3086
3087         Reviewed by Lucas Forschler.
3088
3089         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3090         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3091         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3092         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3093
3094 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3095
3096         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3097         https://bugs.webkit.org/show_bug.cgi?id=196444
3098
3099         Reviewed by Lucas Forschler.
3100
3101         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3102
3103 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3104
3105         Add SPI to canonicalize NSURLs with WTF::URL
3106         https://bugs.webkit.org/show_bug.cgi?id=196415
3107         <rdar://problem/44980271>
3108
3109         Reviewed by Darin Adler.
3110
3111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3112         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3113         (TestWebKitAPI::TEST):
3114
3115 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3116
3117         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3118         https://bugs.webkit.org/show_bug.cgi?id=196441
3119
3120         Reviewed by Carlos Garcia Campos.
3121
3122         Don't cache the wpe_view_backend object that might not exist yet at the
3123         time of EventSenderProxy constructor invocation, but instead retrieve
3124         that object whenever it's required for event dispatching. This should
3125         avoid crashes in this constructor now that it's invoked before any
3126         PlatformWindow has been set up (as changed in r243496).
3127
3128         * WebKitTestRunner/EventSenderProxy.h:
3129         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3130         (WTR::viewBackend):
3131         (WTR::EventSenderProxy::EventSenderProxy):
3132         (WTR::EventSenderProxy::mouseDown):
3133         (WTR::EventSenderProxy::mouseUp):
3134         (WTR::EventSenderProxy::mouseMoveTo):
3135         (WTR::EventSenderProxy::mouseScrollBy):
3136         (WTR::EventSenderProxy::keyDown):
3137         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3138
3139 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3140
3141         [Win][WebKit] MiniBrowser should support high DPI display
3142         https://bugs.webkit.org/show_bug.cgi?id=196391
3143
3144         Reviewed by Alex Christensen.
3145
3146         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3147         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3148         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3149         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3150
3151 2019-03-31  Sam Weinig  <weinig@apple.com>
3152
3153         Remove more i386 specific configurations
3154         https://bugs.webkit.org/show_bug.cgi?id=196430
3155
3156         Reviewed by Alexey Proskuryakov.
3157
3158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3159         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3160
3161 2019-03-31  Andy Estes  <aestes@apple.com>
3162
3163         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3164         https://bugs.webkit.org/show_bug.cgi?id=196433
3165         <rdar://problem/49293305>
3166
3167         Reviewed by Tim Horton.
3168
3169         Enhanced API test coverage to include all navigation response policy decisions in both
3170         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3171
3172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3173         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3174         (TestWebKitAPI::TEST):
3175         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3176         (readFile):
3177         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3178         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3179         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3180         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3181         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3182         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3183         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3184         (-[QuickLookDelegate _downloadDidStart:]):
3185         (-[QuickLookDelegate _download:didReceiveResponse:]):
3186         (-[QuickLookDelegate _download:didReceiveData:]):
3187         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3188         (-[QuickLookDelegate _downloadDidFinish:]):
3189         (-[QuickLookDelegate _download:didFailWithError:]):
3190         (-[QuickLookDelegate _downloadDidCancel:]):
3191         (-[QuickLookDelegate verifyDownload]):
3192         (runTest):
3193         (runTestDecideBeforeLoading):
3194         (runTestDecideAfterLoading):
3195         (TEST):
3196         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3197         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3198         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3199         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3200         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3201         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3202         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3203         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3204         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3205         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3206         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3207         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3208         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3209         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3210
3211 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3212
3213         [CMake] add testdfg as target with build-jsc
3214         https://bugs.webkit.org/show_bug.cgi?id=196393
3215
3216         Reviewed by Saam Barati.
3217
3218         Added testdfg as one of the targets to build when
3219         using CMake.
3220
3221         * Scripts/build-jsc:
3222
3223 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3224
3225         Delete WebMetal implementation in favor of WebGPU
3226         https://bugs.webkit.org/show_bug.cgi?id=195418
3227
3228         Reviewed by Dean Jackson.
3229
3230         * DumpRenderTree/mac/DumpRenderTree.mm:
3231         (enableExperimentalFeatures):
3232         (resetWebPreferencesToConsistentValues):
3233         * Scripts/webkitperl/FeatureList.pm:
3234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3237         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3238         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3239         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3240         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3241         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3242         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3243         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3244         (WTR::InjectedBundle::beginTesting):
3245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3246         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3247         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3248
3249 2019-03-29  Chris Dumez  <cdumez@apple.com>
3250
3251         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3252         https://bugs.webkit.org/show_bug.cgi?id=196405
3253         <rdar://problem/49428130>
3254
3255         Reviewed by Wenson Hsieh.
3256
3257         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3258         the popover presentation methods to be no-ops. Use this in the new test added in
3259         r243523 so that we do not swizzle those methods for all tests. This is needed because
3260         those WatchOS tests rely on the popover getting presented and interactive.
3261
3262         * WebKitTestRunner/TestController.cpp:
3263         (WTR::updateTestOptionsFromTestHeader):
3264         * WebKitTestRunner/TestController.h:
3265         * WebKitTestRunner/TestOptions.h:
3266         (WTR::TestOptions::hasSameInitializationOptions const):
3267         * WebKitTestRunner/ios/TestControllerIOS.mm:
3268         (WTR::TestController::platformInitialize):
3269         (WTR::TestController::platformResetStateToConsistentValues):
3270
3271 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3272
3273         [Curl] Add Server Trust Evaluation Support.
3274         https://bugs.webkit.org/show_bug.cgi?id=191646
3275
3276         Reviewed by Fujii Hironori.
3277
3278         Implemented MiniBrowser UI for asking if user trusts the server.
3279
3280         * MiniBrowser/win/Common.cpp:
3281         (askServerTrustEvaluation):
3282         (replaceString):
3283         * MiniBrowser/win/Common.h:
3284         * MiniBrowser/win/MiniBrowserLib.rc:
3285         * MiniBrowser/win/MiniBrowserLibResource.h:
3286         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3287         (createPEMString):
3288         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3289         (WebKitBrowserWindow::canTrustServerCertificate):
3290         * MiniBrowser/win/WebKitBrowserWindow.h:
3291
3292 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3293
3294         Implement ResizeObserver.
3295         https://bugs.webkit.org/show_bug.cgi?id=157743
3296
3297         Reviewed by Simon Fraser.
3298
3299         Support resizeObserverEnabled webPreferences.
3300
3301         * DumpRenderTree/TestOptions.cpp:
3302         (TestOptions::TestOptions):
3303         * DumpRenderTree/TestOptions.h:
3304         * DumpRenderTree/mac/DumpRenderTree.mm:
3305         (setWebPreferencesForTestOptions):
3306         * DumpRenderTree/win/DumpRenderTree.cpp:
3307         (enableExperimentalFeatures):
3308         * Scripts/webkitperl/FeatureList.pm:
3309         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3310
3311 2019-03-28  John Wilander  <wilander@apple.com>
3312
3313         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3314         https://bugs.webkit.org/show_bug.cgi?id=196281
3315         <rdar://problem/48938748>
3316
3317         Reviewed by Alex Christensen.
3318
3319         This patch adds the function isStatisticsHasLocalStorage() to the
3320         TestRunner. With it, the page can query the WebsiteDataStore in the
3321         UI process to make sure that it sees LocalStorage.
3322
3323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3325         (WTR::TestRunner::isStatisticsHasLocalStorage):
3326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3327         * WebKitTestRunner/TestController.cpp:
3328         (WTR::TestController::isStatisticsHasLocalStorage):
3329         * WebKitTestRunner/TestController.h:
3330         * WebKitTestRunner/TestInvocation.cpp:
3331         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3332
3333 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3334
3335         API::Data::createWithoutCopying should do a null check before calling CFRelease
3336         https://bugs.webkit.org/show_bug.cgi?id=196276
3337         <rdar://problem/48059859>
3338
3339         Reviewed by Alex Christensen.
3340
3341         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3342
3343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3344         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3345         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3346         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3347         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3348         (TestWebKitAPI::TEST):
3349
3350 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3351
3352         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3353         https://bugs.webkit.org/show_bug.cgi?id=186276
3354
3355         Reviewed by Carlos Garcia Campos.
3356
3357         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3358         (webViewLoadChanged):
3359         (testWebResourceGetDataError):
3360         (testWebResourceGetDataEmpty):
3361         (beforeAll):
3362         (webViewloadChanged): Deleted.
3363
3364 2019-03-27  Andy Estes  <aestes@apple.com>
3365
3366         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3367         https://bugs.webkit.org/show_bug.cgi?id=196317
3368
3369         Reviewed by Dan Bernstein.
3370
3371         package-root copies built products into a staging directory using ditto(1), which does not
3372         follow symbolic links as it traverses a directory. Now that the files in
3373         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3374         itself, these become broken links when ditto'd into the staging directory.
3375
3376         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3377
3378         * Scripts/package-root:
3379
3380 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3381
3382         [ews-app] Update display text of Submit for ews analysis
3383         https://bugs.webkit.org/show_bug.cgi?id=196309
3384
3385         Reviewed by Dewei Zhu.
3386
3387         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3388
3389 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3390
3391         run-webkit-tests should check for leaks in WebKit processes
3392         <https://webkit.org/b/193772>
3393         <rdar://problem/46526680>
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         This works by doing the following:
3398         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3399           The list of child processes are returned one per line:
3400           process.name: pid
3401         - Run the "#LIST CHILD PROCESSES" command just before the
3402           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3403           processes on the ServerProcess object.
3404         - When the `--leaks` switch is handled, run check_for_leaks() on
3405           each child process after the main test harness.
3406
3407         * DumpRenderTree/mac/DumpRenderTree.mm:
3408         (handleControlCommand):
3409         - Use strncmp() instead of strcmp().
3410         - Add support for handling "#LIST CHILD PROCESSES" command.
3411
3412         * Scripts/webkitpy/port/base.py:
3413         (Port.check_for_leaks):
3414         * Scripts/webkitpy/port/darwin.py:
3415         (DarwinPort.check_for_leaks):
3416         - Rename redundant 'process_pid' argument to 'process_id'.
3417
3418         * Scripts/webkitpy/port/driver.py:
3419         (Driver.do_post_tests_work):
3420         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3421           longer the only command this sends to WebKitTestRunner.
3422         - If the `--leaks` switch is present, send the
3423           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3424           result using Port.set_webkit_processes().
3425         (Driver._parse_child_processes_output):
3426         - Add helper method to parse list of child process names and
3427           process IDs returned from WebKitTestRunner.
3428
3429         * Scripts/webkitpy/port/ios_device.py:
3430         (IOSDevicePort.check_for_leaks):
3431         - Rename redundant 'process_pid' argument to 'process_id'.
3432
3433         * Scripts/webkitpy/port/leakdetector.py:
3434         (LeakDetector._parse_leaks_output):
3435         - Return early if there is no leaks_output.
3436         (LeakDetector.check_for_leaks):
3437         - Rename redundant 'process_pid' argument to 'process_id'.
3438
3439         * Scripts/webkitpy/port/server_process.py:
3440         (ServerProcess.__init__):
3441         (ServerProcess.child_processes):
3442         (ServerProcess.set_child_processes):
3443         - Add instance variable to Port to store list of child process
3444           names and process IDs returned from WebKitTestRunner.
3445         (ServerProcess._start):
3446         - Clear self._child_processes.
3447         (ServerProcess.stop):
3448         - If self._child_processes is set, call
3449           self._port.check_for_leaks() for each child process.
3450
3451         * Scripts/webkitpy/port/server_process_unittest.py:
3452         (TrivialMockPort.check_for_leaks):
3453         - Rename redundant 'process_pid' argument to 'process_id'.
3454
3455         * Scripts/webkitpy/port/simulator_process.py:
3456         (SimulatorProcess.stop):
3457         - If self._child_processes is set, call
3458           self._port.check_for_leaks() for each child process.
3459
3460         * Scripts/webkitpy/port/watch_device.py:
3461         (WatchDevicePort.check_for_leaks):
3462         - Rename redundant 'process_pid' argument to 'process_id'.
3463
3464         * WebKitTestRunner/TestController.cpp:
3465         (WTR::TestController::dumpResponse):
3466         - Extract method from findAndDumpWorldLeaks() so that it may be
3467           reused by findAndDumpWebKitProcessIdentifiers().
3468         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3469         - Add method to output process name and process ID of both the
3470           WebContent and Networking processes.
3471         (WTR::TestController::findAndDumpWorldLeaks):
3472         - Fix missing newline in output when there were no abandoned
3473           documents.
3474         - Call dumpResponse() for extracted code.
3475         (WTR::TestController::handleControlCommand):
3476         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3477         - Use strncmp() instead of strcmp().
3478         - Call findAndDumpWebKitProcessIdentifiers() when
3479           "#LIST CHILD PROCESSES" command is sent.
3480         * WebKitTestRunner/TestController.h:
3481         (WTR::TestController::dumpResponse):
3482         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3483         - Declare methods.
3484
3485 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         Unreviewed. Add GLib API test cases after r243434.
3488
3489         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3490         (testWebViewActiveURI):
3491         (serverCallback):
3492         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3493         (sendRequestCallback):
3494
3495 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         Geolocation request not complete when watch request was started in a different web process
3498         https://bugs.webkit.org/show_bug.cgi?id=195996
3499
3500         Reviewed by Alex Christensen.
3501
3502         Add a test case.
3503
3504         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3505         (TestWebKitAPI::runJavaScriptAlert):
3506         (TestWebKitAPI::TEST):
3507
3508 2019-03-26  Keith Rollin  <krollin@apple.com>
3509
3510         Update the way generate-xcfilelists returns strings from functions
3511         https://bugs.webkit.org/show_bug.cgi?id=195975
3512         <rdar://problem/49040807>
3513
3514         Reviewed by Dean Jackson.
3515
3516         There are places where generate-xcfilelists executes assignments with
3517         statements like:
3518
3519             FOO=$(some_function)
3520
3521         where "some_function" return a string by echoing it. E.g.
3522
3523             some_function()
3524             {
3525                 echo "Hello, World"
3526             }
3527
3528         This is a common idiom, but it has a problem if "some_function" needs
3529         to call "exit" in an attempt to halt the entire script right then and
3530         there. Since "some_function" is called inside of $(), it's being
3531         executed in a sub-shell. Calling exit in that sub-shell simply exits
3532         that shell; it doesn't not exit the outer shell in which the main part
3533         of the script is still running. As such, the main script keeps
3534         executing when the intent was for the script to halt.
3535
3536         The solution to this is to use a different idiom for returning
3537         strings. The one we now is to pass in the name of the variable to
3538         receive the string result:
3539
3540             some_function()
3541             {
3542                 variable_name=$1
3543                 eval $variable_name ="Hello, World"
3544             }
3545
3546         The call site now looks like
3547
3548             some_function FOO
3549
3550         Because there's no invocation of a sub-shell, some_function can now
3551         call "exit" if it wants to, and the entire script will exit at that
3552         point.
3553
3554         * Scripts/generate-xcfilelists:
3555
3556 2019-03-26  Chris Dumez  <cdumez@apple.com>
3557
3558         Add basic layout test coverage for File Picker on iOS
3559         https://bugs.webkit.org/show_bug.cgi?id=196265
3560
3561         Reviewed by Wenson Hsieh.
3562
3563         Add layout test infrastructure to test the file picker on iOS.
3564
3565         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3566         (WTR::UIScriptController::dismissFilePicker):
3567         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3568         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3569         (WTR::UIScriptController::dismissFilePicker):
3570         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3571         * WebKitTestRunner/TestController.cpp:
3572         (WTR::TestController::createWebViewWithOptions):
3573         (WTR::updateTestOptionsFromTestHeader):
3574         * WebKitTestRunner/TestOptions.h:
3575         (WTR::TestOptions::hasSameInitializationOptions const):
3576         * WebKitTestRunner/ios/TestControllerIOS.mm:
3577         (overridePresentViewController):
3578         (WTR::TestController::platformInitialize):
3579         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3580         (WTR::UIScriptController::dismissFilePicker):
3581
3582 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3583
3584         Implement async paste method on UIWKInteractionViewProtocol
3585         https://bugs.webkit.org/show_bug.cgi?id=196267
3586         <rdar://problem/49236346>
3587
3588         Reviewed by Tim Horton.
3589
3590         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3591         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3592         are now a part of all iOS 12 internal SDKs.
3593
3594         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3595
3596         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3597         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3598
3599         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3600         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3601         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3602         * TestWebKitAPI/ios/UIKitSPI.h:
3603
3604 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3605
3606         [ews-build] Use PostgreSQL for ews.webkit.org database
3607         https://bugs.webkit.org/show_bug.cgi?id=196270
3608
3609         Reviewed by Lucas Forschler.
3610
3611         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3612
3613 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3614
3615         [ews] Reset simctl states on reboot
3616         https://bugs.webkit.org/show_bug.cgi?id=196260
3617
3618         Rubber-stamped by Aakash Jain.
3619
3620         * EWSTools/start-queue-mac.sh:
3621
3622 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3623
3624         [ews-build] Use PostgreSQL for ews-build database
3625         https://bugs.webkit.org/show_bug.cgi?id=196229
3626
3627         Reviewed by Lucas Forschler.
3628
3629         * BuildSlaveSupport/ews-build/master.cfg:
3630
3631 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3632
3633         [ews-build] Get master_hostname dynamically in master.cfg
3634         https://bugs.webkit.org/show_bug.cgi?id=196255
3635
3636         Reviewed by Lucas Forschler.
3637
3638         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3639         send events data in test mode.
3640
3641 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3642
3643         [ews-app] Set db_constraint to False for Foreign Keys
3644         https://bugs.webkit.org/show_bug.cgi?id=196252
3645
3646         Reviewed by Lucas Forschler.
3647
3648         * BuildSlaveSupport/ews-app/ews/models/build.py:
3649