[Win] MiniBrowser should default to webkit.org
[WebKit-https.git] / Tools / ChangeLog
1 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
2
3         [Win] MiniBrowser should default to webkit.org
4         https://bugs.webkit.org/show_bug.cgi?id=199201
5
6         Reviewed by Don Olmstead.
7
8         * MiniBrowser/win/BrowserWindow.h:
9         * MiniBrowser/win/MiniBrowserReplace.h:
10         * MiniBrowser/win/WebKitBrowserWindow.cpp:
11         (WebKitBrowserWindow::loadHTMLString): Deleted.
12         * MiniBrowser/win/WebKitBrowserWindow.h:
13         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
14         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
15         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
16         * MiniBrowser/win/WinMain.cpp:
17         (wWinMain):
18
19 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
20
21         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
22         https://bugs.webkit.org/show_bug.cgi?id=199192
23         <rdar://problem/51554509>
24
25         Reviewed by Tim Horton.
26
27         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
28         verify that we gracefully handle web process termination and web view unparenting mid-drag.
29
30         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
31         (TestWebKitAPI::TEST):
32         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
33         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
34         (-[DragAndDropSimulator _resetSimulatedState]):
35         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
36         (-[DragAndDropSimulator _advanceProgress]):
37         (-[DragAndDropSimulator liftPreviews]):
38         (-[DragAndDropSimulator cancellationPreviews]):
39         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
40         (-[DragAndDropSimulator sessionWillBeginBlock]):
41         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
42
43 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
44
45         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
46         https://bugs.webkit.org/show_bug.cgi?id=199178
47
48         Reviewed by Jonathan Bedard.
49
50         * BuildSlaveSupport/ews-build/steps.py:
51         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
52         (ExtractTestResults.__init__): Ditto.
53         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
54
55 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
56
57         Add user agent quirk for bankofamerica.com
58         https://bugs.webkit.org/show_bug.cgi?id=199154
59
60         Reviewed by Carlos Garcia Campos.
61
62         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
63         (TestWebKitAPI::TEST):
64
65 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
66
67         Fully rename WebKitGTK+ -> WebKitGTK everywhere
68         https://bugs.webkit.org/show_bug.cgi?id=199159
69
70         Reviewed by Carlos Garcia Campos.
71
72         * BuildSlaveSupport/gtk/README:
73         * MiniBrowser/gtk/BrowserWindow.c:
74         * MiniBrowser/gtk/main.c:
75         (aboutURISchemeRequestCallback):
76         * Scripts/webkitpy/common/config/contributionareas.py:
77         * Scripts/webkitpy/common/config/contributors.json:
78         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
79         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
80         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
81         (testWebViewResources):
82         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
83         (testWebViewMouseTarget):
84         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
85         (testWebExtensionGetTitle):
86         (testDocumentLoadedSignal):
87         (testWebExtensionFormControlsAssociated):
88         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
89         (testWebKitSettingsUserAgent):
90         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
91         (testWebViewRunJavaScript):
92         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
93         (main):
94         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
95         (prepareContextMenuTestView):
96         (testContextMenuPopulateMenu):
97         (testContextMenuCustomMenu):
98         (testContextMenuDisableMenu):
99         (testContextMenuSubMenu):
100         (testContextMenuDismissed):
101         (testContextMenuWebExtensionMenu):
102         (testContextMenuWebExtensionNode):
103         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
104         (testInspectorDefault):
105         (testInspectorManualAttachDetach):
106         (testInspectorCustomContainerDestroyed):
107         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
108         (testWebViewPrint):
109         (testPrintOperationPrint):
110         (testPrintOperationErrors):
111         * gtk/install-dependencies:
112         * gtk/jhbuild.modules:
113         * gtkdoc/generate-gtkdoc:
114         * wpe/install-dependencies:
115
116 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
117
118         contributors.json not canonicalized since r243297
119         https://bugs.webkit.org/show_bug.cgi?id=199161
120
121         Reviewed by Alexey Proskuryakov.
122
123         Canonicalize it using 'validate-committer-lists --canonicalize'
124
125         * Scripts/webkitpy/common/config/contributors.json:
126
127 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
128
129         webkitpy: Build style should be lower-case
130         https://bugs.webkit.org/show_bug.cgi?id=199158
131
132         Reviewed by Aakash Jain.
133
134         * Scripts/webkitpy/test/main.py:
135         (Tester._run_tests): Make all styles lower-case.
136
137 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
138
139         [ews-build] Remove iOS queue from old EWS and dashboard
140         https://bugs.webkit.org/show_bug.cgi?id=199150
141
142         Reviewed by Jonathan Bedard.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
145         * QueueStatusServer/config/queues.py:
146
147 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
148
149         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
150         https://bugs.webkit.org/show_bug.cgi?id=198795
151
152         Unreviewed test gardening.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
155         (TestWebKitAPI::TEST): Disable flaky test.
156
157 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
158
159         [ews-build] Enable iOS-12-Build queue on new EWS
160         https://bugs.webkit.org/show_bug.cgi?id=199149
161
162         Reviewed by Jonathan Bedard.
163
164         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
165         this queue.
166         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
167         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
168         will keep the builders to the left and testers to the right.
169
170 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-build] Upload test results after running layout-tests
173         https://bugs.webkit.org/show_bug.cgi?id=199120
174
175         Reviewed by Jonathan Bedard.
176
177         * BuildSlaveSupport/ews-build/steps.py:
178         (RunWebKitTests.evaluateCommand):
179         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
180
181 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
182
183         [ews-build] EWS should provide option to download layout test results zip file
184         https://bugs.webkit.org/show_bug.cgi?id=199121
185
186         Reviewed by Jonathan Bedard.
187
188         * BuildSlaveSupport/ews-build/steps.py:
189         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
190         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
191
192 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
193
194         Add user agent quirk for Google Drive
195         https://bugs.webkit.org/show_bug.cgi?id=199153
196
197         Reviewed by Carlos Garcia Campos.
198
199         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
200         (TestWebKitAPI::TEST):
201
202 2019-06-22  Zalan Bujtas  <zalan@apple.com>
203
204         [LFC] Expand tests coverage (328 new tests -> 2652).
205
206         * LayoutReloaded/misc/LFC-passing-tests.txt:
207
208 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
209
210         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
211         https://bugs.webkit.org/show_bug.cgi?id=199107
212         <rdar://problem/43663611>
213
214         Reviewed by Chris Fleizach.
215
216         iOS implementation for AccessibilityUIElement::hasPopup.
217         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
218         (WTR::AccessibilityUIElement::hasPopup const):
219
220 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
221
222         Unreviewed, add myself to CMake watchlist
223
224         * Scripts/webkitpy/common/config/watchlist:
225
226 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
227
228         openDatabase should return an empty object when WebSQL is disabled
229         https://bugs.webkit.org/show_bug.cgi?id=198805
230
231         Reviewed by Geoffrey Garen.
232
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
235         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
236         (TEST):
237         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
238
239 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
240
241         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
242         https://bugs.webkit.org/show_bug.cgi?id=199114
243         <rdar://problem/51671674>
244
245         Reviewed by Youenn Fablet.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
248         (-[TestSOAuthorizationNavigationDelegate init]):
249         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
250         (configureSOAuthorizationWebView):
251         (TestWebKitAPI::TEST):
252
253 2019-06-21  Youenn Fablet  <youenn@apple.com>
254
255         WebPageProxy should use the right path for sandbox extension
256         https://bugs.webkit.org/show_bug.cgi?id=198902
257         <rdar://problem/50772810>
258
259         Reviewed by Geoffrey Garen.
260
261         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
262         (TEST):
263         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
264
265 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
266
267         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
268         https://bugs.webkit.org/show_bug.cgi?id=199094
269
270         Reviewed by Carlos Garcia Campos.
271
272         * MiniBrowser/gtk/BrowserTab.c:
273         (runColorChooserCallback):
274         (browserTabConstructed):
275         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
276         (testWebViewSyncRequestOnMaxConns):
277         (beforeAll):
278         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
279         (testWebSocketTLSErrors):
280         (beforeAll):
281         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
282         (WebKitTestServer::~WebKitTestServer):
283         (WebKitTestServer::getWebSocketURIForPath const):
284         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
285         (WTR::AccessibilityUIElement::rowHeaders const):
286         (WTR::AccessibilityUIElement::columnHeaders const):
287         (WTR::AccessibilityUIElement::isAttributeSettable):
288         (WTR::AccessibilityUIElement::x):
289         (WTR::AccessibilityUIElement::y):
290         (WTR::AccessibilityUIElement::width):
291         (WTR::AccessibilityUIElement::height):
292         (WTR::AccessibilityUIElement::clickPointX):
293         (WTR::AccessibilityUIElement::clickPointY):
294         (WTR::AccessibilityUIElement::intValue const):
295         (WTR::AccessibilityUIElement::minValue):
296         (WTR::AccessibilityUIElement::maxValue):
297         (WTR::stringAtOffset):
298
299 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
300
301         test-webkitpy is broken on macOS Catalina
302         https://bugs.webkit.org/show_bug.cgi?id=199078
303
304         Reviewed by Jonathan Bedard.
305
306         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
307         to the runner.
308         (main): 
309         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
310
311 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
312
313         Change status to "committer" in contributors.json
314
315         Unreviewed.
316
317         * Scripts/webkitpy/common/config/contributors.json:
318
319 2019-06-20  Alex Christensen  <achristensen@webkit.org>
320
321         Add unit test for UIContextMenuConfiguration API
322         https://bugs.webkit.org/show_bug.cgi?id=199043
323
324         Reviewed by Wenson Hsieh.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
328         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
329         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
330         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
331         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
332         (TEST):
333         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
334         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
335         (-[TestContextMenuDriver delegate]):
336         (-[TestContextMenuDriver setDelegate:]):
337         (-[TestContextMenuDriver view]):
338         (-[TestContextMenuDriver setView:]):
339         (-[TestContextMenuDriver allowableMovement]):
340         (-[TestContextMenuDriver setAllowableMovement:]):
341         (-[TestContextMenuDriver primaryGestureRecognizer]):
342         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
343         (-[TestContextMenuDriver touchDuration]):
344         (-[TestContextMenuDriver setTouchDuration:]):
345         (-[TestContextMenuDriver locationInCoordinateSpace:]):
346         (-[TestContextMenuDriver cancelInteraction]):
347         (-[TestContextMenuDriver begin:]):
348         (-[TestContextMenuDriver clickDown]):
349         (-[TestContextMenuDriver clickUp]):
350         (-[TestContextMenuDriver end]):
351         * TestWebKitAPI/ios/UIKitSPI.h:
352
353 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
354
355         [ews-app] Status bubble should not turn orange when any build step is skipped
356         https://bugs.webkit.org/show_bug.cgi?id=199079
357
358         Reviewed by Jonathan Bedard.
359
360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
361
362 2019-06-20  Alex Christensen  <achristensen@webkit.org>
363
364         Fix an internal engineering build after r246605
365        ​https://bugs.webkit.org/show_bug.cgi?id=197800
366
367         * TestWebKitAPI/TCPServer.cpp:
368
369 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
370
371         [ews-build] Triggered builds should use same revision as parent build
372         https://bugs.webkit.org/show_bug.cgi?id=198289
373
374         Reviewed by Jonathan Bedard.
375
376         * BuildSlaveSupport/ews-build/steps.py:
377         (CheckOutSpecificRevision): Build step to checkout specific revision.
378         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
379         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
380         (CheckOutSpecificRevision.start): Run appropriate git command.
381         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
382         builds use same revision as parent build.
383         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
384         * BuildSlaveSupport/ews-build/factories.py:
385         (Factory.__init__): Added CheckOutSpecificRevision step.
386
387 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
388
389         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
390         https://bugs.webkit.org/show_bug.cgi?id=199073
391
392         Reviewed by Jonathan Bedard.
393
394         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
395
396 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
397
398         [GTK] Enable navigation swipe layout tests
399         https://bugs.webkit.org/show_bug.cgi?id=198995
400
401         Reviewed by Michael Catanzaro.
402
403         Add a way for tests to enable and then control swipe gesture on GTK.
404
405         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
406         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
407         * WebKitTestRunner/PlatformGTK.cmake:
408         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
409         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
410         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
411         (WTR::UIScriptController::beginBackSwipe):
412         (WTR::UIScriptController::completeBackSwipe):
413
414 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
415
416         [GTK] HTTP layout tests don't run in flatpak
417         https://bugs.webkit.org/show_bug.cgi?id=199067
418
419         Reviewed by Michael Catanzaro.
420
421         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
422         check that path. Instead, add /app/lib/perl to Apache config directly.
423
424         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
425         /.flatpak-info instead.
426
427         * Scripts/webkitpy/port/base.py:
428         (Port._is_flatpak):
429         (Port._in_flatpak_sandbox):
430         * flatpak/flatpakutils.py:
431         (WebkitFlatpak.run_in_sandbox):
432         (is_sandboxed):
433
434 2019-06-18  Darin Adler  <darin@apple.com>
435
436         Tidy up the remaining bits of the AtomicString to AtomString rename
437         https://bugs.webkit.org/show_bug.cgi?id=198990
438
439         Reviewed by Michael Catanzaro.
440
441         * Scripts/do-webcore-rename: Removed already-done renames.
442         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
443
444 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
445
446         [GTK] Remove support for GTK2 plugins
447         https://bugs.webkit.org/show_bug.cgi?id=199065
448
449         Reviewed by Sergio Villar Senin.
450
451         * EWSTools/ubuntu-ews-packages:
452         * TestWebKitAPI/PlatformGTK.cmake:
453         * WebKitTestRunner/PlatformGTK.cmake:
454         * flatpak/org.webkit.GTK.yaml:
455         * gtk/install-dependencies:
456
457 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
458
459         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
460         https://bugs.webkit.org/show_bug.cgi?id=199053
461
462         Reviewed by Saam Barati.
463
464         Added a test stressing IsoHeap with multiple threads.
465
466         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
467         (assertHasObjects):
468         (assertHasOnlyObjects):
469         (assertClean):
470         (TEST):
471
472 2019-06-19  Zalan Bujtas  <zalan@apple.com>
473
474         [LFC] Expand tests coverage (1126 new tests -> 2324).
475
476         * LayoutReloaded/misc/LFC-passing-tests.txt:
477
478 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
479
480         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
481         https://bugs.webkit.org/show_bug.cgi?id=198957
482
483         Reviewed by Alex Christensen.
484
485         * TestWebKitAPI/CMakeLists.txt:
486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
487         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
488
489 2019-06-19  Keith Rollin  <krollin@apple.com>
490
491         Relocate some test tools in non-mac builds
492         https://bugs.webkit.org/show_bug.cgi?id=198984
493         <rdar://problem/51873261>
494
495         Reviewed by Andy Estes.
496
497         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
498         TestNetscapePlugin get created in
499         WebKit.framework/Versions/A/Resources on non-mac builds. This is
500         incorrect, as those bundles are shallow bundles that don't use the
501         Versions hierarchy. Instead, store these files directly in
502         WebKit.framework.
503
504         Note that getting rid of just the "Versions/A" path components and
505         putting the files in WebKit.framework/Resources doesn't work as
506         `codesign` treats the result as an invalid layout.
507
508         The work in this patch involves changing the definition of the custom
509         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
510         variable INSTALL_PATH is defined in terms of this variable. In order
511         to increase visiblity into this relationship, move both of these
512         variables into .xcconfig files if they weren't already. This
513         refactoring was done in a way to be the least disruptive and most
514         compatible with the previous definitions, even at the cost of being
515         repetitive.
516
517         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
518         * DumpRenderTree/mac/Configurations/Base.xcconfig:
519         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
520         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
521         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
522         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
523
524 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
525
526         [ews-build] Patch link should open the pretty patch
527         https://bugs.webkit.org/show_bug.cgi?id=199031
528
529         Reviewed by Jonathan Bedard.
530
531         * BuildSlaveSupport/ews-build/steps.py:
532         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
533
534 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
535
536         [ews-build] Add step to analyze Compile WebKit failures
537         https://bugs.webkit.org/show_bug.cgi?id=199025
538
539         Reviewed by Jonathan Bedard.
540
541         * BuildSlaveSupport/ews-build/steps.py:
542         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
543         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
544         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
545         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
546         this step is run only when compile-webkit failed.
547
548 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-build] Send email notifications for failures
551         https://bugs.webkit.org/show_bug.cgi?id=198919
552
553         Reviewed by Jonathan Bedard.
554
555         * BuildSlaveSupport/ews-build/master.cfg:
556
557 2019-06-19  Alex Christensen  <achristensen@webkit.org>
558
559         Add a unit test for client certificate authentication
560         https://bugs.webkit.org/show_bug.cgi?id=197800
561
562         Reviewed by Youenn Fablet.
563
564         Make better abstractions for reading and writing from/to TCPServer.
565         Add a unit test that causes a client certificate authentication challenge to happen.
566
567         * TestWebKitAPI/TCPServer.cpp:
568         (TestWebKitAPI::TCPServer::TCPServer):
569         (TestWebKitAPI::TCPServer::read):
570         (TestWebKitAPI::TCPServer::write):
571         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
572         (TestWebKitAPI::TCPServer::respondWithOK):
573         * TestWebKitAPI/TCPServer.h:
574         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
575         (credentialWithIdentity):
576         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
577         (TEST):
578         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
579         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
580         (-[ClientCertificateDelegate challengeCount]):
581         (TestWebKitAPI::TEST):
582         (respondWithChallengeThenOK): Deleted.
583         (credentialWithIdentityAndKeychainPath): Deleted.
584         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
585         (TEST):
586         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
587         (TestWebKitAPI::TEST):
588         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
589         (TEST):
590         (readRequest): Deleted.
591         (writeResponse): Deleted.
592         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
593         (TestWebKitAPI::TEST):
594         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
595
596 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
597
598         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
599
600         System headers are being included without SYSTEM again here.
601
602         * TestWebKitAPI/PlatformGTK.cmake:
603
604 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
605
606         [JSC] JSLock should be WebThread aware
607         https://bugs.webkit.org/show_bug.cgi?id=198911
608
609         Reviewed by Geoffrey Garen.
610
611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
612         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
613         (TestWebKitAPI::TEST):
614
615 2019-06-18  Keith Miller  <keith_miller@apple.com>
616
617         webkit-patch should allow for a bugzilla url not just bugzilla id
618         https://bugs.webkit.org/show_bug.cgi?id=198972
619
620         Reviewed by Dewei Zhu.
621
622         When prompting for a bugzilla id or a new title we should also
623         allow for a bugzilla url.
624
625         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
626         (PromptForBugOrTitle.run):
627
628 2019-06-18  David Quesada  <david_quesada@apple.com>
629
630         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
631         https://bugs.webkit.org/show_bug.cgi?id=198954
632         rdar://problem/51711556
633
634         Reviewed by Alex Christensen.
635
636         For these tests, kill the web process after the download starts. This makes the deallocation
637         of the download-originating web views, which these tests depend on, more reliable.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
640         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
641         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
642
643 2019-06-18  Dan Bernstein  <mitz@apple.com>
644
645         Revert workaround for bug 198904 from run-webkit-archive
646         https://bugs.webkit.org/show_bug.cgi?id=198931
647
648         Reviewed by Alexey Proskuryakov.
649
650         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
651         pick up the built frameworks.
652
653         * WebKitArchiveSupport/run-webkit-archive:
654         (set_dyld_framework_path):
655
656 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
657
658         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
659         https://bugs.webkit.org/show_bug.cgi?id=198854
660         <rdar://problem/51386058>
661
662         Reviewed by Geoffrey Garen.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
665         (TestWebKitAPI::TEST):
666
667 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
668
669         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
670         https://bugs.webkit.org/show_bug.cgi?id=198831
671
672         Reviewed by Žan Doberšek.
673
674         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
675         * wpe/jhbuild.modules: Ditto.
676         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
677         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
678
679 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
680
681         Move SOAuthorization from WebKitAdditions to WebKit
682         https://bugs.webkit.org/show_bug.cgi?id=198874
683         <rdar://problem/47573431>
684
685         Reviewed by Brent Fulgham.
686
687         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
688
689         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
691         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
692         (-[TestSOAuthorizationNavigationDelegate init]):
693         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
694         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
695         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
696         (-[TestSOAuthorizationViewController viewDidAppear]):
697         (-[TestSOAuthorizationViewController viewDidDisappear]):
698         (overrideCanPerformAuthorizationWithURL):
699         (overrideSetDelegate):
700         (overrideBeginAuthorizationWithURL):
701         (overrideCancelAuthorization):
702         (overrideAddObserverForName):
703         (overrideIsURLFromAppleOwnedDomain):
704         (resetState):
705         (configureSOAuthorizationWebView):
706         (generateHtml):
707         (checkAuthorizationOptions):
708         (TestWebKitAPI::TEST):
709
710 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
711
712         Ensure ITP state is relayed to Network Process on restart
713         https://bugs.webkit.org/show_bug.cgi?id=198797
714         <rdar://problem/51646944>
715
716         Reviewed by Youenn Fablet.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
719         (cleanupITPDatabase): Added.
720         (TEST:EnableDisableITP): Update to use cleanup method.
721         (TEST:NetworkProcessRestart): Added.
722
723 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
724
725         New EWS can't process patches larger than 640kb
726         https://bugs.webkit.org/show_bug.cgi?id=198851
727
728         Reviewed by Jonathan Bedard.
729
730         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
731
732 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
733
734         webkitpy: Add macOS Catalina, iOS 13
735         https://bugs.webkit.org/show_bug.cgi?id=198492
736
737         Reviewed by Alexey Proskuryakov.
738
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
747         * BuildSlaveSupport/ews-build/steps.py:
748         * Scripts/webkitpy/common/version_name_map.py:
749         * Scripts/webkitpy/common/version_name_map_unittest.py:
750         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
751         * TestResultServer/static-dashboards/flakiness_dashboard.js:
752
753 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
754
755         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
756
757         * gtk/jhbuild.modules:
758         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
759         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
760
761 2019-06-16  Zalan Bujtas  <zalan@apple.com>
762
763         [LFC] Expand tests coverage (325 new tests -> 1198).
764
765         * LayoutReloaded/misc/LFC-passing-tests.txt:
766
767 2019-06-16  Darin Adler  <darin@apple.com>
768
769         Rename AtomicString to AtomString
770         https://bugs.webkit.org/show_bug.cgi?id=195276
771
772         Reviewed by Michael Catanzaro.
773
774         * many files: Let do-webcore-rename do the renaming.
775
776         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
777         that mention "atomic string" and changed them to instead say "atom string".
778
779 2019-06-16  Zalan Bujtas  <zalan@apple.com>
780
781         [LFC] Unreviewed test gardening.
782
783         Unsupported alignments.
784
785         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
786         fast/borders/empty-outline-border-assert.html -vertical-align: super
787         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
788
789         * LayoutReloaded/misc/LFC-passing-tests.txt:
790
791 2019-06-15  Youenn Fablet  <youenn@apple.com>
792
793         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
794         https://bugs.webkit.org/show_bug.cgi?id=198780
795
796         Reviewed by Jonathan Bedard.
797
798         * Scripts/webkitpy/w3c/test_importer.py:
799         (TestImporter._webkit_test_runner_options):
800         In case the test file cannot be read as text, consider that there is no WTR option.
801
802 2019-06-14  Youenn Fablet  <youenn@apple.com>
803
804         WebResourceLoadStatisticsStore should not use its network session if invalidated
805         https://bugs.webkit.org/show_bug.cgi?id=198814
806
807         Reviewed by Geoffrey Garen.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
810         (TEST):
811
812 2019-06-14  Youenn Fablet  <youenn@apple.com>
813
814         import-w3c-tests should respect WEBKIT_OUTPUTDIR
815         https://bugs.webkit.org/show_bug.cgi?id=198682
816         <rdar://problem/51536931>
817
818         Reviewed by Jonathan Bedard.
819
820         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
821         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
822
823         * Scripts/webkitpy/common/webkit_finder.py:
824         (WebKitFinder.path_from_webkit_outputdir):
825         * Scripts/webkitpy/w3c/common.py:
826         (WPTPaths):
827         (WPTPaths.checkout_directory):
828         (WPTPaths.wpt_checkout_path):
829         * Scripts/webkitpy/w3c/test_importer.py:
830         (TestImporter.__init__):
831         * Scripts/webkitpy/w3c/test_importer_unittest.py:
832         (test_checkout_directory):
833
834 2019-06-13  Antoine Quint  <graouts@apple.com>
835
836         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
837         https://bugs.webkit.org/show_bug.cgi?id=198800
838         <rdar://problem/51679634>
839
840         Reviewed by Tim Horton.
841
842         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
843         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
844
845         * DumpRenderTree/mac/EventSendingController.mm:
846         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
847         (-[EventSendingController mouseDown:withModifiers:]):
848         (-[EventSendingController mouseUp:withModifiers:]):
849         (-[EventSendingController mouseMoveToX:Y:]):
850
851 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
852
853         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
854         https://bugs.webkit.org/show_bug.cgi?id=198820
855
856         Reviewed by Ross Kirsling.
857
858         WebView window paints nothing because it is moved out of the
859         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
860         as DumpRenderTree does.
861
862         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
863         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
864
865 2019-06-13  Tim Horton  <timothy_horton@apple.com>
866
867         Make it possible for validate-committer-lists to dump a mailmap file
868         https://bugs.webkit.org/show_bug.cgi?id=198517
869
870         Reviewed by Simon Fraser.
871
872         Mailmaps wildly improve the output of various Git tools, including
873         `git shortlog -sne`, mapping committers to our canonical name/email pair.
874
875         * Scripts/validate-committer-lists:
876         (CommitterListFromGit):
877         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
878         Add some missing legacy username mappings.
879
880         (dump_mailmap):
881         (dump_mailmap.format_email):
882         (dump_mailmap.format_email_with_gitsvn_uuid):
883         (dump_mailmap.map_emails_to_legacy_username):
884         (main):
885         Add `validate-committer-lists --dump-mailmap`, which generates
886         one given committers.json and the existing mapping of legacy username
887         to email addresses that exists in validate-committer-lists.
888
889 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
890
891         Replace double-quotes with single quotes in loadConfig.py
892         https://bugs.webkit.org/show_bug.cgi?id=198792
893
894         Reviewed by Jonathan Bedard.
895
896         * BuildSlaveSupport/ews-build/loadConfig.py:
897         * BuildSlaveSupport/ews-build/steps_unittest.py:
898
899 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
900
901         Add mechanism and test case to check if ITP is active
902         https://bugs.webkit.org/show_bug.cgi?id=198694
903         <rdar://problem/51557704>
904
905         Reviewed by Youenn Fablet.
906
907         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
908         (TEST):
909
910 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
911
912         [WPE][GTK] Deprecate WebSQL APIs
913         https://bugs.webkit.org/show_bug.cgi?id=195011
914
915         Reviewed by Carlos Garcia Campos.
916
917         * MiniBrowser/gtk/main.c:
918         (gotWebsiteDataCallback):
919         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
920         (testWebsiteDataConfiguration):
921         (testWebsiteDataEphemeral):
922         (testWebsiteDataDatabases):
923
924 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
925
926         [WPE][GTK] Enable hyperlink auditing
927         https://bugs.webkit.org/show_bug.cgi?id=197845
928
929         Reviewed by Carlos Garcia Campos.
930
931         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
932         (testWebKitSettings):
933
934 2019-06-11  Keith Rollin  <krollin@apple.com>
935
936         Open up xcfilelist processing to more platforms
937         https://bugs.webkit.org/show_bug.cgi?id=198675
938         <rdar://problem/51533238>
939
940         Reviewed by Jonathan Bedard.
941
942         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
943         platforms on which to perform xcfilelist generation/updating.
944
945         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
946         (JavaScriptCoreGenerator):
947         (WebCoreGenerator):
948         (WebKitGenerator):
949
950 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
951
952         webkitpy: Fix device ASan reporting, add testing for report configurations
953         https://bugs.webkit.org/show_bug.cgi?id=198756
954
955         Reviewed by Aakash Jain.
956
957         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
958         configuration thoroughly in webkitpy.
959
960         * Scripts/webkitpy/port/config.py:
961         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
962         * Scripts/webkitpy/port/device_port.py:
963         (DevicePort.configuration_for_upload): Add ASan as style.
964         * Scripts/webkitpy/port/ios_device_unittest.py:
965         (IOSDeviceTest):
966         (IOSDeviceTest.test_default_upload_configuration):
967         * Scripts/webkitpy/port/ios_simulator_unittest.py:
968         (IOSSimulatorTest.test_default_upload_configuration):
969         * Scripts/webkitpy/port/mock_drt_unittest.py:
970         (MockDRTPortTest.test_asan_upload_configuration):
971         * Scripts/webkitpy/port/port_testcase.py:
972         (test_default_upload_configuration):
973         (test_debug_upload_configuration):
974         (test_asan_upload_configuration):
975         (test_guard_malloc_configuration):
976         * Scripts/webkitpy/port/watch_simulator_unittest.py:
977         (WatchSimulatorTest):
978         (WatchSimulatorTest.test_default_upload_configuration):
979
980 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
981
982         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
983         https://bugs.webkit.org/show_bug.cgi?id=198749
984
985         Reviewed by Carlos Garcia Campos.
986
987         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
988         (TestWebKitAPI::TEST):
989
990 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
991
992         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
993         https://bugs.webkit.org/show_bug.cgi?id=198735
994         <rdar://problem/51557159>
995
996         Reviewed by Megan Gardner.
997
998         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
999         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
1000
1001         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1002         (TestWebKitAPI::TEST):
1003
1004 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1005
1006         Unreviewed, add myself to the JavaScriptCore watchlist.
1007
1008         * Scripts/webkitpy/common/config/watchlist:
1009
1010 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1011
1012         Unreviewed, change my status to be a WebKit reviewer
1013
1014         * Scripts/webkitpy/common/config/contributors.json:
1015
1016 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1017
1018         [WPE] Use new exported image API from fdo backend
1019         https://bugs.webkit.org/show_bug.cgi?id=198558
1020
1021         Reviewed by Philippe Normand.
1022
1023         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
1024         WPEToolingBackends that already depends on fdo backend and libxkb
1025         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
1026         * wpe/backends/HeadlessViewBackend.cpp:
1027         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1028         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1029         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1030         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1031         * wpe/backends/HeadlessViewBackend.h:
1032         * wpe/backends/ViewBackend.cpp:
1033         (WPEToolingBackends::ViewBackend::initialize):
1034         * wpe/backends/ViewBackend.h:
1035         * wpe/backends/WindowViewBackend.cpp:
1036         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1037         * wpe/backends/WindowViewBackend.h:
1038
1039 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
1040
1041         Extend run-benchmark to allow diagnosing before closing browser on test failure.
1042         https://bugs.webkit.org/show_bug.cgi?id=198729
1043
1044         Reviewed by Ryosuke Niwa.
1045
1046         Add '--diagnose-directory' option to store diagnose information when test failed.
1047
1048         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1049         (BenchmarkRunner.__init__):
1050         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1051         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
1052         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
1053         (parse_args):
1054         (run_benchmark_plan):
1055         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1056         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1057         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1058         (WebServerBenchmarkRunner.__init__):
1059         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1060
1061 2019-06-10  Sam Weinig  <weinig@apple.com>
1062
1063         Remove Dashboard support
1064         https://bugs.webkit.org/show_bug.cgi?id=198615
1065
1066         Reviewed by Ryosuke Niwa.
1067
1068         * DumpRenderTree/TestRunner.cpp:
1069         (TestRunner::staticFunctions):
1070         (setUseDashboardCompatibilityModeCallback): Deleted.
1071         * DumpRenderTree/TestRunner.h:
1072         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1073         * DumpRenderTree/mac/DumpRenderTree.mm:
1074         (resetWebViewToConsistentStateBeforeTesting):
1075         * DumpRenderTree/mac/TestRunnerMac.mm:
1076         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
1077         * ImageDiff/cg/Configurations/Base.xcconfig:
1078         * Scripts/webkitperl/FeatureList.pm:
1079         * TestWebKitAPI/Configurations/Base.xcconfig:
1080         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1082         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
1083         * WebKitTestRunner/Configurations/Base.xcconfig:
1084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1085         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1086         (WTR::InjectedBundle::beginTesting):
1087         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1088         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
1089         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1090
1091 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
1092
1093         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
1094         https://bugs.webkit.org/show_bug.cgi?id=198616
1095         rdar://problem/36386573
1096
1097         Reviewed by David Kilzer.
1098
1099         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
1100
1101         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1102         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1103         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1104         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
1105         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
1106         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
1107         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1108         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1109         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1110         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1111
1112 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1113
1114         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
1115         https://bugs.webkit.org/show_bug.cgi?id=198699
1116         <rdar://problem/50501718>
1117
1118         Reviewed by Simon Fraser.
1119
1120         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
1121         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
1122         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
1123         viewport parameters are used.
1124
1125         * WebKitTestRunner/ios/TestControllerIOS.mm:
1126         (WTR::TestController::platformResetPreferencesToConsistentValues):
1127         (WTR::TestController::platformConfigureViewForTest):
1128
1129 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
1130
1131         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
1132         https://bugs.webkit.org/show_bug.cgi?id=198023
1133
1134         Reviewed by Saam Barati.
1135
1136         * Scripts/run-jsc-stress-tests:
1137
1138 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1139
1140         Integrate dark mode support for iOS.
1141         https://bugs.webkit.org/show_bug.cgi?id=198687
1142         rdar://problem/51545643
1143
1144         Reviewed by Tim Horton.
1145
1146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1147
1148 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
1149
1150         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
1151         https://bugs.webkit.org/show_bug.cgi?id=198723
1152
1153         Reviewed by Aakash Jain.
1154
1155         * Scripts/webkitpy/xcode/simulated_device.py:
1156         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
1157
1158 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
1159
1160         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
1161         https://bugs.webkit.org/show_bug.cgi?id=198635
1162         <rdar://problem/46010232>
1163
1164         Reviewed by Ryosuke Niwa.
1165
1166         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1167         (areCookiesEqual):
1168         (TEST):
1169
1170 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1171
1172         [JHBuild] Bump shared-mime-info to version ≥ 1.6
1173         https://bugs.webkit.org/show_bug.cgi?id=198714
1174
1175         Reviewed by Carlos Garcia Campos.
1176
1177         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
1178         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
1179         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
1180
1181 2019-06-10  Philippe Normand  <pnormand@igalia.com>
1182
1183         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
1184         https://bugs.webkit.org/show_bug.cgi?id=198713
1185
1186         Reviewed by Carlos Garcia Campos.
1187
1188         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
1189         patches currently used in JHBuild.
1190
1191 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1192
1193         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
1194         https://bugs.webkit.org/show_bug.cgi?id=198711
1195
1196         Reviewed by Philippe Normand.
1197
1198         * flatpak/org.webkit.GTK.yaml: Also include modules from
1199         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
1200
1201 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
1202
1203         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
1204         avoids double-free condition that's causing bots to exit early.
1205
1206         * gtk/jhbuild.modules:
1207         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1208         * wpe/jhbuild.modules:
1209         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1210
1211 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1212
1213         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
1214         https://bugs.webkit.org/show_bug.cgi?id=198655
1215
1216         Reviewed by Ross Kirsling.
1217
1218         MediaCapabilities is enabled by default for WK2, but WinCairo
1219         doesn't implemented yet. Disable it in MiniBrowser.
1220
1221         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1222         (WebKitBrowserWindow::create):
1223
1224 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1225
1226         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
1227         https://bugs.webkit.org/show_bug.cgi?id=198693
1228         <rdar://problem/51555371>
1229
1230         Reviewed by Tim Horton.
1231
1232         Augment an existing API test to exercise three additional scenarios:
1233             -   The web view configuration's application name is never set; the default should not include
1234                 "Mobile/15E148" in desktop mode.
1235             -   The application name is explicitly set to nil; the default application name should still not include
1236                 "Mobile/15E148".
1237             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
1238                 this when generating the user agent, even in desktop mode.
1239
1240         * TestWebKitAPI/ios/PreferredContentMode.mm:
1241         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
1242         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
1243         (TestWebKitAPI::TEST):
1244
1245 2019-06-08  Zalan Bujtas  <zalan@apple.com>
1246
1247         [LFC] Unreviewed test gardening.
1248
1249         Remove rtl tests. They were mistakenly marked as pass.
1250
1251         * LayoutReloaded/misc/LFC-passing-tests.txt:
1252
1253 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1254
1255         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1256         https://bugs.webkit.org/show_bug.cgi?id=198664
1257
1258         Reviewed by Simon Fraser.
1259
1260         Delete repeated entries which were submitted by mistake.
1261
1262         * Tracing/SystemTracePoints.plist:
1263
1264 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1265
1266         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
1267         https://bugs.webkit.org/show_bug.cgi?id=198631
1268         <rdar://problem/51505431>
1269
1270         Reviewed by Tim Horton.
1271
1272         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
1273
1274         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1275         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
1276         (-[CustomInputWebView inputView]):
1277         (-[CustomInputWebView inputAccessoryView]):
1278         (TestWebKitAPI::TEST):
1279
1280 2019-06-07  Daniel Bates  <dabates@apple.com>
1281
1282         [lldb-webkit] Pretty-print all kinds of Documents
1283         https://bugs.webkit.org/show_bug.cgi?id=198620
1284
1285         Reviewed by Simon Fraser.
1286
1287         Register formatters for all classes derived from WebCore::Document so we get nice summaries
1288         without having to drill down in Xcode- or casting- to the base class, Document.
1289
1290         Older LLDB versions use to do this automatically, but this functionality was removed in newer
1291         versions:
1292             [[
1293                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
1294                 chains, but also through inheritance chains. This feature has been removed since it
1295                 significantly degrades performance. You need to set up your formatters for every type in
1296                 inheritance chains to which you want the formatter to apply.
1297             ]]
1298             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
1299
1300         * lldb/lldb_webkit.py:
1301         (__lldb_init_module):
1302
1303 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
1304
1305         webkitpy: Support reporting results for uncommon test configurations
1306         https://bugs.webkit.org/show_bug.cgi?id=198662
1307         <rdar://problem/51524128>
1308
1309         Reviewed by Aakash Jain.
1310
1311         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1312         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
1313         * Scripts/webkitpy/port/base.py:
1314         (Port.configuration_for_upload): Set flavor based on options.
1315         * Scripts/webkitpy/results/options.py:
1316         (upload_options): Add result-report-flavor option.
1317         * Scripts/webkitpy/test/main.py:
1318         (Tester._run_tests): Set flavor based on options.
1319
1320 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1321
1322         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
1323         https://bugs.webkit.org/show_bug.cgi?id=198641
1324         <rdar://problem/51266310>
1325
1326         Reviewed by Tim Horton.
1327
1328         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
1329         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
1330         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
1331         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
1332         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
1333         reproduces on iOS simulator.
1334
1335         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
1336         representation is actually ignored by most clients anyways (including WebKit), in favor of using
1337         "com.apple.flat-rtfd".
1338
1339         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1342         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1343         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1344
1345 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1346
1347         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
1348         https://bugs.webkit.org/show_bug.cgi?id=198607
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
1353         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
1354         determine the type of the tests.
1355
1356         * Scripts/run-gtk-tests:
1357         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1358         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
1359         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1360         (GtkTestRunner.is_google_test): Ditto.
1361         * Scripts/run-wpe-tests:
1362         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1363         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1364         (WPETestRunner.is_google_test): Ditto.
1365         * glib/api_test_runner.py:
1366         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
1367         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
1368
1369 2019-06-06  Keith Rollin  <krollin@apple.com>
1370
1371         Remove SSL-based tests from TestWebKitAPI on some configurations
1372         https://bugs.webkit.org/show_bug.cgi?id=198551
1373         <rdar://problem/51424996>
1374
1375         Reviewed by Jonathan Bedard.
1376
1377         Not all platforms have SSL handy, so don't include SSL-based tests on
1378         those platforms.
1379
1380         * TestWebKitAPI/TCPServer.cpp:
1381         * TestWebKitAPI/TCPServer.h:
1382         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1383         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1384         * TestWebKitAPI/config.h:
1385
1386 2019-06-06  Daniel Bates  <dabates@apple.com>
1387
1388         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
1389         non-default port number
1390         https://bugs.webkit.org/show_bug.cgi?id=198618
1391
1392         Reviewed by Brent Fulgham.
1393
1394         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
1395         a string before we concatenate it with another string when building the string representation
1396         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
1397         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
1398
1399         * lldb/lldb_webkit.py:
1400         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
1401
1402 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1403
1404         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
1405         https://bugs.webkit.org/show_bug.cgi?id=198613
1406
1407         Reviewed by Alexey Proskuryakov.
1408
1409         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
1410
1411 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1412
1413         webkitpluginhost: Support ASan as a style
1414         https://bugs.webkit.org/show_bug.cgi?id=198586
1415         <rdar://problem/51459088>
1416
1417         Reviewed by Alexey Proskuryakov.
1418
1419         * Scripts/webkitpy/port/base.py:
1420         (Port.configuration_for_upload): Add ASan as a style.
1421         * Scripts/webkitpy/port/config.py:
1422         (Config._read_configuration):
1423         (Config):
1424         (Config.asan): Add property to check if the ASan configuration is active.
1425         * Scripts/webkitpy/port/config_unittest.py:
1426         (ConfigTest.test_default_configuration__scripterror):
1427         (ConfigTest):
1428         (ConfigTest.test_asan):
1429         * Scripts/webkitpy/test/main.py:
1430         (Tester._run_tests): Add Asan as a style.
1431
1432 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
1433
1434         block-spammers tool doesn't block e-mail
1435         https://bugs.webkit.org/show_bug.cgi?id=198570
1436
1437         Reviewed by Jonathan Bedard.
1438
1439         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
1440         recognize "false" here. Also, request body is unnecessary.
1441
1442 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1443
1444         [GTK][WPE] Enable PSON
1445         https://bugs.webkit.org/show_bug.cgi?id=194979
1446
1447         Reviewed by Žan Doberšek.
1448
1449         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
1450
1451         * gtk/jhbuild.modules:
1452         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1453         * wpe/jhbuild.modules:
1454         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1455
1456 2019-06-05  Andy Estes  <aestes@apple.com>
1457
1458         [macOS] Stop calling -[NSDraggingItem setItem:]
1459         https://bugs.webkit.org/show_bug.cgi?id=198588
1460         <rdar://problem/48297453>
1461
1462         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
1463
1464         Reviewed by Wenson Hsieh.
1465
1466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
1467         TestRunnerShared group.
1468
1469         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1470         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1471         Changed to call -[NSDraggingItem _initWithItem:] when available.
1472
1473         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
1474         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
1475         declarations here from DumpRenderTree.
1476
1477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1478         Added TestRunnerShared/spi/AppKitTestSPI.h.
1479
1480         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1481         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1482         Changed to call -[NSDraggingItem _initWithItem:] when available.
1483
1484 2019-06-05  Jer Noble  <jer.noble@apple.com>
1485
1486         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
1487         https://bugs.webkit.org/show_bug.cgi?id=198585
1488
1489         Reviewed by Chris Dumez.
1490
1491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1493         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
1494         (TEST):
1495         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
1496
1497 2019-06-05  Alex Christensen  <achristensen@webkit.org>
1498
1499         Re-enable safe browsing in WKWebView
1500         https://bugs.webkit.org/show_bug.cgi?id=196161
1501         <rdar://problem/49171413>
1502
1503         Reviewed by Ryosuke Niwa.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1506         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1507         (TEST):
1508         (safeBrowsingView):
1509
1510 == Rolled over to ChangeLog-2019-06-05 ==