Unreviewed, rolling out r245857.
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-29  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, rolling out r245857.
4
5         Breaks internal builds.
6
7         Reverted changeset:
8
9         "WeakPtr breaks vtables when upcasting to base classes"
10         https://bugs.webkit.org/show_bug.cgi?id=188799
11         https://trac.webkit.org/changeset/245857
12
13 2019-05-28  Geoffrey Garen  <ggaren@apple.com>
14
15         WeakPtr breaks vtables when upcasting to base classes
16         https://bugs.webkit.org/show_bug.cgi?id=188799
17
18         Reviewed by Youenn Fablet.
19
20         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Adopt the new macro API instead
21         of template specialization for observing weak references.
22
23         (TestWebKitAPI::Int::Int):
24         (TestWebKitAPI::Int::operator int const):
25         (TestWebKitAPI::Int::operator== const): Use a class for integer tests
26         because WeakPtr doesn't naturally support pointing to non-class objects
27         now.
28
29         (TestWebKitAPI::Base::foo):
30         (TestWebKitAPI::Derived::foo): Inherit from CanMakeWeakPtr to enable
31         deduction of the weak pointer type.
32
33         (TestWebKitAPI::TEST): Updated to use Int.
34
35         (TestWebKitAPI::Base::weakPtrFactory const): Deleted.
36         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference): Deleted.
37         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference): Deleted.
38
39 2019-05-29  Aakash Jain  <aakash_jain@apple.com>
40
41         Disable Flaky API Test TestWebKitAPI._WKDownload.DownloadMonitorCancel
42         https://bugs.webkit.org/show_bug.cgi?id=198328
43
44         Reviewed by Alexey Proskuryakov.
45
46         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
47
48 2019-05-28  Justin Michaud  <justin_michaud@apple.com>
49
50         Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
51         https://bugs.webkit.org/show_bug.cgi?id=198322
52
53         Reviewed by Saam Barati.
54
55         Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
56         the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
57
58         * Scripts/run-jsc-stress-tests:
59
60 2019-05-28  Wenson Hsieh  <wenson_hsieh@apple.com>
61
62         [iOS] Respect NSItemProvider's registered types when dropping files that are loaded in-place
63         https://bugs.webkit.org/show_bug.cgi?id=198315
64         <rdar://problem/51183762>
65
66         Reviewed by Tim Horton.
67
68         Adds a new API test to verify that when dropping a file that is loaded in-place with a file extension that is
69         not a .png (but was registered to the item provider as "public.png"), the resulting attachment is contained in
70         an image element, and the resulting attachment info indicates that the dropped attachment is a png file.
71
72         Additionally, rebaseline some existing tests.
73
74         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
75         (runTestWithTemporaryImageFile):
76         (TestWebKitAPI::TEST):
77
78 2019-05-28  Yusuke Suzuki  <ysuzuki@apple.com>
79
80         GCHeapInspector should accept weird filename
81         https://bugs.webkit.org/show_bug.cgi?id=198314
82
83         Reviewed by Simon Fraser.
84
85         GCHeapInspector filenameForPath should have a fallback path if regexp does not match against the given path.
86
87         * GCHeapInspector/script/interface.js:
88         (filenameForPath):
89
90 2019-05-28  Eric Carlson  <eric.carlson@apple.com>
91
92         [MacOS] Filter GVA warning logged to stdout
93         https://bugs.webkit.org/show_bug.cgi?id=198303
94         <rdar://problem/50098041>
95
96         Reviewed by Jer Noble.
97
98         * Scripts/webkitpy/port/mac.py:
99         (MacPort.logging_patterns_to_strip): Filter GVA warnings.
100
101 2019-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
102
103         Web Inspector: Provide UIString descriptions to improve localizations
104         https://bugs.webkit.org/show_bug.cgi?id=195132
105         <rdar://problem/48457817>
106
107         Reviewed by Devin Rousso.
108
109         Allow WI.UIString to take:
110         - WI.UIString(string, key, comment)
111         - WI.UIString(string, comment)
112         - WI.UIString(string)
113
114         * Scripts/extract-localizable-js-strings:
115
116 2019-05-25  Dewei Zhu  <dewei_zhu@apple.com>
117
118         Limit run-benchmark http server to specific interface.
119         https://bugs.webkit.org/show_bug.cgi?id=198247
120
121         Reviewed by Ryosuke Niwa.
122
123         Add '--interface' option to 'twisted_http_server.py'.
124         'SimpleHTTPServerDriver' should specify interface for http server.
125         Update regex that determines http server port from 'lsof' output to support ipv6 address.
126
127         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
128         Added '--interface' argument.
129         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
130         Limited http server to a specific interfce.
131         Added '-P' option to 'lsof' invocation to inhibits the conversion of port numbers to port name so script won't
132         fail if it's listening on a 'well-known' port.
133         Abstracted '_check_http_server_is_running' to allow potential child class to have its own implementation.
134         (SimpleHTTPServerDriver.serve): Updated regex that determines http server port from 'lsof' output to support ipv6 address.
135         (SimpleHTTPServerDriver.kill_server): Added null check for 'self._server_process'.
136
137 2019-05-28  David Xiong  <w_xiong@apple.com>
138
139         webkitpy: Switch run-webkit-tests to tailspin
140         https://bugs.webkit.org/show_bug.cgi?id=198144
141         <rdar://problem/32463212>
142
143         Reviewed by Jonathan Bedard.
144
145         Changes run-webkit-tests to run tailspin on test time out
146         rather than spindump, and edited tests to look for tailspin logs
147         instead.
148
149         * Scripts/webkitpy/port/darwin.py:
150         (DarwinPort.sample_process): Replaced spindump with tailspin (+ symbolication)
151         (DarwinPort):
152         (DarwinPort.tailspin_file_path):
153         (DarwinTest.spindump_file_path): Deleted.
154         * Scripts/webkitpy/port/darwin_testcase.py:
155         (DarwinTest.test_tailspin): Changed spindump test (below) to test for tailspin instead
156         (DarwinTest.test_spindump): Deleted.
157         (DarwinTest.test_spindump.logging_run_command): Deleted.
158         * Scripts/webkitpy/port/ios_device_unittest.py:
159         (IOSDeviceTest.test_tailspin): Changed spindump tests (inc. below) to test for tailspin instead
160         (IOSDeviceTest.test_sample_process.logging_run_command):
161         (IOSDeviceTest.test_sample_process_exception.throwing_run_command):
162         (IOSDeviceTest.test_spindump): Deleted.
163         (IOSDeviceTest.test_spindump.logging_run_command): Deleted.
164
165 2019-05-28  David Xiong  <w_xiong@apple.com>
166
167         webkitpy: Using sudo on iOS device during timeout spindumps 
168         https://bugs.webkit.org/show_bug.cgi?id=198142
169
170         Reviewed by Jonathan Bedard.
171
172         * Scripts/webkitpy/port/darwin.py:
173         (DarwinPort.sample_process): Check target host instead of source host for sudo command.
174
175 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
176
177         [ews-build] Remove unused buildbot tabs
178         https://bugs.webkit.org/show_bug.cgi?id=198108
179
180         Reviewed by Jonathan Bedard.
181
182         * BuildSlaveSupport/ews-build/templates/build.jade: Removed unused 'Changes' and 'Responsible Users' tabs.
183
184 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
185
186         [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
187         https://bugs.webkit.org/show_bug.cgi?id=197944
188
189         Reviewed by Michael Catanzaro.
190
191         Add WPEBackend-fdo to jhbuild moduleset.
192
193         * gtk/jhbuild.modules:
194
195 2019-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
196
197         [iOS] Dropping in an editable element should result in a ranged selection
198         https://bugs.webkit.org/show_bug.cgi?id=198267
199         <rdar://problem/51145977>
200
201         Reviewed by Tim Horton.
202
203         Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
204         visible selection rects, simply check for the start caret rect, as determined by WKContentView's
205         -selectionRange.
206
207         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
208         (TestWebKitAPI::TEST):
209         (makeCGRectValue): Deleted.
210         (checkSelectionRectsWithLogging): Deleted.
211         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
212
213         Replace finalSelectionRects with finalSelectionStartRect.
214
215         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
216         (-[DragAndDropSimulator _resetSimulatedState]):
217         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
218         (-[DragAndDropSimulator finalSelectionRects]): Deleted.
219
220 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
221
222         [css-grid] Preserve repeat() notation when serializing declared values
223         https://bugs.webkit.org/show_bug.cgi?id=197840
224
225         Reviewed by Manuel Rego Casasnovas.
226
227         Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
228
229         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
230         (TestWebKitAPI::computeNumberOfTracks):
231
232 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
233
234         [iOS] Dropped text, attachments, and images should animate into place
235         https://bugs.webkit.org/show_bug.cgi?id=198243
236         <rdar://problem/35205373>
237
238         Reviewed by Tim Horton.
239
240         Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
241
242         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
243         (TestWebKitAPI::isCompletelyWhite):
244         (TestWebKitAPI::TEST):
245
246         Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
247         UITargetedDragPreviews upon drop.
248
249         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
250         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
251         (-[DragAndDropSimulator _resetSimulatedState]):
252         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
253         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
254
255         Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
256         delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
257         the end of the simulated drag and drop until after drag previews have been received during an edit drag.
258
259         (-[DragAndDropSimulator dropPreviews]):
260         (-[DragAndDropSimulator delayedDropPreviews]):
261
262         Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
263         previews were provided asynchronously.
264
265         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
266         * TestWebKitAPI/ios/UIKitSPI.h:
267
268         Stage the new private drop interacton delegate method.
269
270 2019-05-25  Simon Fraser  <simon.fraser@apple.com>
271
272         MobileMiniBrowser: Add iPad support, and allow insecure loads
273         https://bugs.webkit.org/show_bug.cgi?id=198249
274
275         Reviewed by Tim Horton.
276
277         Add iPad support to MobileMiniBrowser, and allow insecure loads.
278
279         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
280         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
281
282 2019-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
283
284         [iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
285         https://bugs.webkit.org/show_bug.cgi?id=198242
286
287         Reviewed by Beth Dakin.
288
289         Add a new test that simulates dropping an image with a preferred presentation size into an editable element
290         with attachment elements enabled.
291
292         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
293         (TestWebKitAPI::TEST):
294
295 2019-05-24  Yusuke Suzuki  <ysuzuki@apple.com>
296
297         Make display-profiler-output work with newer HighLine
298         https://bugs.webkit.org/show_bug.cgi?id=198205
299
300         Reviewed by Saam Barati.
301
302         Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
303
304         * Scripts/display-profiler-output:
305
306 2019-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
307
308         run-webkit-tests: Remove feature detection support
309         https://bugs.webkit.org/show_bug.cgi?id=198105
310
311         Reviewed by Jonathan Bedard.
312
313         Feature detection support was added to DRT for Windows and old
314         run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
315         But, it doesn't work for DRT for Windows because of feature name
316         mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
317         removed in Bug 127833, it is not needed anymore.
318
319         * DumpRenderTree/win/DumpRenderTree.cpp:
320         (main):
321         * Scripts/webkitpy/port/base.py:
322         (Port._tests_for_other_platforms):
323         (Port._skipped_tests_for_unsupported_features):
324         (Port._runtime_feature_list): Deleted.
325         (Port.nm_command): Deleted.
326         (Port._modules_to_search_for_symbols): Deleted.
327         (Port._symbols_string): Deleted.
328         (Port._missing_feature_to_skipped_tests): Deleted.
329         (Port._has_test_in_directories): Deleted.
330         * Scripts/webkitpy/port/darwin.py:
331         (DarwinPort.make_command):
332         (DarwinPort.nm_command): Deleted.
333         * Scripts/webkitpy/port/ios_simulator.py:
334         (IOSSimulatorPort.reset_preferences):
335         (IOSSimulatorPort.nm_command): Deleted.
336         * Scripts/webkitpy/port/port_testcase.py:
337         (TestWebKitPort.__init__):
338         (TestWebKitPort.all_test_configurations):
339         (PortTestCase.test_path_to_test_expectations_file):
340         (TestWebKitPort._symbols_string): Deleted.
341         (PortTestCase.test_skipped_directories_for_features): Deleted.
342         (PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
343         (PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
344         * Scripts/webkitpy/port/watch_simulator.py:
345         (WatchSimulatorPort.reset_preferences):
346         (WatchSimulatorPort.nm_command): Deleted.
347         * Scripts/webkitpy/port/win.py:
348         (WinPort.show_results_html_file):
349         (WinPort._runtime_feature_list): Deleted.
350         * Scripts/webkitpy/port/win_unittest.py:
351         (WinPortTest.test_operating_system):
352         (WinPortTest.test_runtime_feature_list): Deleted.
353         * WebKitTestRunner/Options.cpp:
354         (WTR::OptionsHandler::OptionsHandler):
355         (WTR::handleOptionPrintSupportedFeatures): Deleted.
356         * WebKitTestRunner/Options.h:
357         * WebKitTestRunner/TestController.cpp:
358         (WTR::TestController::initialize):
359
360 2019-05-23  Commit Queue  <commit-queue@webkit.org>
361
362         Unreviewed, rolling out r245665.
363         https://bugs.webkit.org/show_bug.cgi?id=198203
364
365         Inspector appears blank, again. (Requested by NVI on #webkit).
366
367         Reverted changeset:
368
369         "Web Inspector: Provide UIString descriptions to improve
370         localizations"
371         https://bugs.webkit.org/show_bug.cgi?id=195132
372         https://trac.webkit.org/changeset/245665
373
374 2019-05-23  Stephan Szabo  <stephan.szabo@sony.com>
375
376         [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
377         https://bugs.webkit.org/show_bug.cgi?id=198098
378
379         Reviewed by Don Olmstead.
380
381         With current CMake and Visual Studio 2019, the default
382         architecture will match the host, so we should make sure
383         to explicitly mention the architecture we want for 32-bit
384         builds as well for cases where we are on x64 and not in an
385         x64_x32 cross-build vcvars environment.
386
387         * Scripts/webkitdirs.pm:
388         (getVisualStudioToolset): Get toolset name for cmake/msbuild
389         (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
390         (getCMakeWindowsToolsetArgument): Get -A argument for cmake
391         based on toolset
392         (generateBuildSystemFromCMakeProject): Remove explicit -A x64
393         in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
394
395 2019-05-23  Youenn Fablet  <youenn@apple.com>
396
397         Set default WebsiteDataStore storage quota based on StorageQuotaManager
398         https://bugs.webkit.org/show_bug.cgi?id=198133
399         <rdar://problem/51031436>
400
401         Reviewed by Geoffrey Garen.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
404         (doTest):
405
406 2019-05-23  Keith Rollin  <krollin@apple.com>
407
408         generate-xcfilelists should not store temporary build files in /tmp
409         https://bugs.webkit.org/show_bug.cgi?id=198136
410
411         Reviewed by Jonathan Bedard.
412
413         Provide the build infrastructure control of the location of
414         generate-xcfilelists' temporary files by creating them in the build
415         directory when possible.
416
417         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
418         (get_xcode_project_temp_dir):
419         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
420         (BaseGenerator._generate_derived):
421         (BaseGenerator._generate_unified):
422         (BaseGenerator):
423         (BaseGenerator._get_temp_dir):
424
425 2019-05-23  Philippe Normand  <philn@igalia.com>
426
427         [JHBuild][GStreamer] Enable libsrtp
428         https://bugs.webkit.org/show_bug.cgi?id=198041
429
430         Reviewed by Xabier Rodriguez-Calvar.
431
432         * gstreamer/jhbuild.modules: Enable libsrtp. The system version
433         can't be used from Stretch because it's too old.
434
435 2019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
436
437         Move win-ews queue bubble to Win10 section of dashboard
438         https://bugs.webkit.org/show_bug.cgi?id=198159
439
440         Reviewed by Alexey Proskuryakov.
441
442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
443         (BubbleQueueServer): Change platform to Windows10 to match the OS version of the bots.
444
445 2019-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
446
447         [Mac] Add API test to make sure the system font is drawn just like in native code
448         https://bugs.webkit.org/show_bug.cgi?id=198010
449
450         Reviewed by Daniel Bates.
451
452         We can compare the width of using font-family:system-ui to a CTLine.
453
454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
455         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html: Added.
456         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm: Added.
457         (TEST):
458
459 2019-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
460
461         Web Inspector: Provide UIString descriptions to improve localizations
462         https://bugs.webkit.org/show_bug.cgi?id=195132
463         <rdar://problem/48457817>
464
465         Reviewed by Devin Rousso.
466
467         Allow WI.UIString to take:
468         - WI.UIString(string, key, comment)
469         - WI.UIString(string, comment)
470         - WI.UIString(string)
471
472         * Scripts/extract-localizable-js-strings:
473
474 2019-05-22  Wenson Hsieh  <wenson_hsieh@apple.com>
475
476         [iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests
477         https://bugs.webkit.org/show_bug.cgi?id=198135
478         <rdar://problem/51001306>
479
480         Reviewed by Alexey Proskuryakov.
481
482         When shouldIgnoreMetaViewport=true is specified on a test, if the following test does not use a flexible
483         viewport, we will continue ignoring the meta viewport, since we'll bail before we attempt to reset
484         WKPreferences' _shouldIgnoreMetaViewport property to NO.
485
486         We fix this by simply allowing shouldIgnoreMetaViewport to take precedence over useFlexibleViewport, such that
487         -[WKPreferences _shouldIgnoreMetaViewport] will always be updated to its intended value between tests.
488
489         * WebKitTestRunner/ios/TestControllerIOS.mm:
490         (WTR::TestController::platformConfigureViewForTest):
491
492 2019-05-22  Sihui Liu  <sihui_liu@apple.com>
493
494         API Test landed in r245540 [Mac WK2] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky failure
495         https://bugs.webkit.org/show_bug.cgi?id=198090
496         <rdar://problem/51003644>
497
498         Reviewed by Youenn Fablet.
499
500         WebView was wrongly loaded multiple times.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
503         (TEST):
504
505 2019-05-22  Jiewen Tan  <jiewen_tan@apple.com>
506
507         [WebAuthN] Support Attestation Conveyance Preference
508         https://bugs.webkit.org/show_bug.cgi?id=192722
509         <rdar://problem/49939647>
510
511         Reviewed by Brent Fulgham.
512
513         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
514         (TestWebKitAPI::TEST):
515         Updates the test with AttestationConveyancePreference.
516
517 2019-05-22  Zalan Bujtas  <zalan@apple.com>
518
519         [Paste] Add support for preferred presentation size when pasting an image
520         https://bugs.webkit.org/show_bug.cgi?id=198132
521         <rdar://problem/50886917>
522
523         Reviewed by Wenson Hsieh.
524
525         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
526         (TestWebKitAPI::TEST):
527
528 2019-05-22  Keith Rollin  <krollin@apple.com>
529
530         Use a different variable when testing for Xcode context in generate-xcfilelists
531         https://bugs.webkit.org/show_bug.cgi?id=198130
532         <rdar://problem/51032752>
533
534         Reviewed by Jonathan Bedard.
535
536         The generate-xcfilelists script can run stand-alone or in the context
537         of Xcode. There are a couple of places where it helps to know which
538         context is current. To determine the context, genreate-xfilelists
539         checks an environment variable that should be defined only when Xcode
540         is running. The variable chosen was XCODE_INSTALL_PATH. It turns out
541         that this variable is not always defined. Therefore, switch to
542         checking XCODE_PRODUCT_BUILD_VERSION.
543
544         * Scripts/webkitpy/generate_xcfilelists_lib/util.py:
545         (subprocess_run):
546         (is_running_under_xcode):
547
548 2019-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
549
550         Unreviewed. Fix WPE unit tests after r245565
551
552         Backend creation is failing when the a11y bus is not running because atk produces warning messages. We should
553         not make warnings fatal during backend creation.
554
555         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
556         (testAutomationSessionRequestSession):
557         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
558         (testWebViewGeolocationPermissionRequests):
559         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
560         (Test::createWebViewBackend):
561         (Test::addLogFatalFlag):
562         (Test::removeLogFatalFlag):
563
564 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-build] Use custom templates for Buildbot (follow-up fix)
567         https://bugs.webkit.org/show_bug.cgi?id=198076
568
569         Unreviewed minor follow-up fix.
570
571         * BuildSlaveSupport/ews-build/templates/build.jade:
572
573 2019-05-21  Alex Christensen  <achristensen@webkit.org>
574
575         Fix branch build.
576         <rdar://problem/50625279>
577
578         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
579         We need to explicitly include WebKit.h on the branch.
580
581 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
582
583         [ews-build] Use custom templates for Buildbot
584         https://bugs.webkit.org/show_bug.cgi?id=198076
585
586         Rubber-stamped by Jonathan Bedard.
587
588         * BuildSlaveSupport/ews-build/master.cfg:
589         * BuildSlaveSupport/ews-build/templates: Added.
590         * BuildSlaveSupport/ews-build/templates/build.jade: Copied from https://github.com/buildbot/buildbot/blob/v1.7.0/www/base/src/app/builders/builds/build.tpl.jade
591
592 2019-05-21  Chris Dumez  <cdumez@apple.com>
593
594         [PSON] Assertion hit when navigating back after a process swap forced by the client
595         https://bugs.webkit.org/show_bug.cgi?id=198006
596
597         Reviewed by Alex Christensen.
598
599         Add API test coverage.
600
601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
602
603 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
606
607         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
608         (WTR::AccessibilityController::elementAtPoint):
609         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
610         (WTR::AccessibilityController::rootElement):
611         (WTR::AccessibilityController::focusedElement):
612
613 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [WPE] Add initial accessibility support using ATK
616         https://bugs.webkit.org/show_bug.cgi?id=197413
617
618         Reviewed by Michael Catanzaro.
619
620         Add accessibility support in MiniBrowser and backends used by MiniBrowser and tests.
621
622         * MiniBrowser/wpe/CMakeLists.txt:
623         * MiniBrowser/wpe/main.cpp:
624         (main):
625         * TestWebKitAPI/PlatformWPE.cmake:
626         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
627         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
628         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
630         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
631         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
632         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Removed.
633         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Removed.
634         * WebKitTestRunner/PlatformWPE.cmake:
635         * wpe/backends/CMakeLists.txt:
636         * wpe/backends/HeadlessViewBackend.cpp:
637         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
638         * wpe/backends/ViewBackend.cpp:
639         (WPEToolingBackends::addKeyEventListener):
640         (WPEToolingBackends::removeKeyEventListener):
641         (WPEToolingBackends::notifyAccessibilityKeyEventListeners):
642         (WPEToolingBackends::ViewBackend::initialize):
643         (WPEToolingBackends::ViewBackend::initializeAccessibility):
644         (WPEToolingBackends::ViewBackend::updateAccessibilityState):
645         (WPEToolingBackends::ViewBackend::setAccessibleChild):
646         (WPEToolingBackends::ViewBackend::addActivityState):
647         (WPEToolingBackends::ViewBackend::removeActivityState):
648         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
649         * wpe/backends/ViewBackend.h:
650         * wpe/backends/WebKitAccessibleApplication.cpp: Added.
651         (webkitAccessibleApplicationWindowInterfaceInit):
652         (webkitAccessibleApplicationFinalize):
653         (webkitAccessibleApplicationInitialize):
654         (webkitAccessibleApplicationGetNChildren):
655         (webkitAccessibleApplicationRefChild):
656         (webkitAccessibleApplicationGetName):
657         (webkit_accessible_application_class_init):
658         (webkit_accessible_application_init):
659         (webkitAccessibleApplicationNew):
660         (webkitAccessibleApplicationSetChild):
661         * wpe/backends/WebKitAccessibleApplication.h: Added.
662         * wpe/backends/WindowViewBackend.cpp:
663         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
664         * wpe/jhbuild.modules:
665
666 2019-05-20  Fujii Hironori  <Hironori.Fujii@sony.com>
667
668         run-webkit-tests not gathering crash logs on Cygwin Python and Windows Python
669         https://bugs.webkit.org/show_bug.cgi?id=179828
670
671         Reviewed by Jonathan Bedard.
672
673         ServerProcess should store its Windows PID for Cygwin before
674         process crashing because the Windows PID is required to get a
675         correct CrashLog.
676
677         CrashLog format has been changed. CrashLogs.GLOBAL_PID_REGEX
678         should accept the new format.
679
680         * Scripts/webkitpy/common/system/crashlogs.py:
681         (CrashLogs.GLOBAL_PID_REGEX): Accept any words between 'Global' and 'PID:'.
682
683         * Scripts/webkitpy/port/driver.py:
684         (Driver.has_crashed):
685         (Driver._check_for_driver_crash_or_unresponsiveness):
686         (Driver._read_block):
687         Store server_process.system_pid() to self._crashed_pid instead of server_process.pid().
688
689         * Scripts/webkitpy/port/server_process.py:
690         (ServerProcess.__init__):
691         (ServerProcess.system_pid): Added.
692         (ServerProcess._find_system_pid): Added.
693         (ServerProcess._start): Set self._system_pid.
694         * Scripts/webkitpy/port/win.py:
695         (WinPort._get_crash_log): Removed broken old code converting Cygwin pid to Windows pid.
696
697 2019-05-20  Aakash Jain  <aakash_jain@apple.com>
698
699         Windows 10 test results missing on flakiness dashboard
700         https://bugs.webkit.org/show_bug.cgi?id=198058
701
702         Rubber-stamped by Alexey Proskuryakov.
703
704         * TestResultServer/static-dashboards/flakiness_dashboard.js:
705
706 2019-05-20  Sihui Liu  <sihui_liu@apple.com>
707
708         Move Web Storage to Network Process
709         https://bugs.webkit.org/show_bug.cgi?id=197636
710  
711         Reviewed by Youenn Fablet.
712  
713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
714         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Remove the wait for database file update.
715         (TEST):
716         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Add a test for network process crash recovery.
717         (TEST):
718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Fix a typo and add a test case to cover it.
719         * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html: Added.
720
721 2019-05-20  Keith Rollin  <krollin@apple.com>
722
723         generate-xcfilelists is stranding temporary files
724         https://bugs.webkit.org/show_bug.cgi?id=198008
725         <rdar://problem/50893659>
726
727         Reviewed by Jonathan Bedard.
728
729         generate-xcfilelists makes use of temporary files on disk. These files
730         are opened with the OS's "temporary" bit set, causing them to get
731         deleted when closed or the process exists. However, these temporary
732         files actually end up persisting after the script exists. This is
733         because `sed` is used to process the files, and is done so in a way
734         that causes the "temporary" bit to get cleared.
735
736         Address this issue by no longer using `sed` and instead performing the
737         equivalent processing the file content in-memory.
738
739         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
740         (BaseGenerator._generate_derived):
741         (BaseGenerator._generate_unified):
742         (BaseGenerator._replace):
743         (BaseGenerator._unexpand):
744         (BaseGenerator._find_added_lines.get_lines):
745         (BaseGenerator._find_added_lines):
746
747 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
748
749         [WPE][Qt] Use C++17 instead of C++14
750         https://bugs.webkit.org/show_bug.cgi?id=197415
751
752         Reviewed by Philippe Normand.
753
754         There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
755         The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
756
757         * TestWebKitAPI/glib/CMakeLists.txt:
758
759 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
760
761         [Flatpak][Qt] Meson: Unknown type feature for gstreamer
762         https://bugs.webkit.org/show_bug.cgi?id=197408
763
764         Reviewed by Philippe Normand.
765
766         This is a regression that has been introduced when
767         GStreamer was updated to version 1.16.0
768         https://bugs.webkit.org/show_bug.cgi?id=197157
769
770         Now GStreamer requires meson >= 0.47.0
771         Updating the Kde runtime to version 5.12 we fulfill
772         this requirement.
773
774         * flatpak/org.webkit.WPEQT.yaml:
775
776 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
777
778         [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
779         https://bugs.webkit.org/show_bug.cgi?id=198037
780
781         Reviewed by Michael Catanzaro.
782
783         Add a test case to check the crash is fixed.
784
785         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
786         (testWebExtensionWindowObjectCleared):
787         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
788         (windowObjectCleared):
789
790 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
791
792         [GLIB] Repeating timer is not stopped when stop is called from the callback
793         https://bugs.webkit.org/show_bug.cgi?id=197986
794
795         Reviewed by Michael Catanzaro.
796
797         Check the timer is no longer active after it has been stopped.
798
799         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
800         (TestWebKitAPI::TEST):
801
802 2019-05-19  Darin Adler  <darin@apple.com>
803
804         Change String::number to use "shortest" instead of "fixed precision 6 digits"
805         https://bugs.webkit.org/show_bug.cgi?id=178319
806
807         Reviewed by Sam Weinig.
808
809         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
810         (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
811
812         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
813         (attributesOfElement): Use appendFixedPrecisionNumber.
814
815 2019-05-18  Jiewen Tan  <jiewen_tan@apple.com>
816
817         [WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
818         https://bugs.webkit.org/show_bug.cgi?id=197974
819         <rdar://problem/50879746>
820
821         Reviewed by Brent Fulgham.
822
823         Add a canDowngrade option for mock hid devices to simulate the situation.
824
825         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
826         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
827
828 2019-05-18  Tadeu Zagallo  <tzagallo@apple.com>
829
830         Add extra information to dumpJITMemory
831         https://bugs.webkit.org/show_bug.cgi?id=197998
832
833         Reviewed by Saam Barati.
834
835         Add description for the new dumpJITMemory trace point code.
836
837         * Tracing/SystemTracePoints.plist:
838
839 2019-05-17  Justin Michaud  <justin_michaud@apple.com>
840
841         [WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
842         https://bugs.webkit.org/show_bug.cgi?id=197969
843
844         Run wasm tests additionally with wasmBBQUsesAir=0.
845
846         Reviewed by Keith Miller.
847
848         * Scripts/run-jsc-stress-tests:
849
850 2019-05-17  Don Olmstead  <don.olmstead@sony.com>
851
852         [CMake] Use builtin FindICU
853         https://bugs.webkit.org/show_bug.cgi?id=197934
854
855         Reviewed by Michael Catanzaro.
856
857         Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.
858
859         * TestWebKitAPI/PlatformMac.cmake:
860         * TestWebKitAPI/PlatformPlayStation.cmake:
861         * TestWebKitAPI/PlatformWin.cmake:
862         * WebKitTestRunner/CMakeLists.txt:
863
864 2019-05-17  Alex Christensen  <achristensen@webkit.org>
865
866         Enable legacy EME for iOS WKWebView
867         https://bugs.webkit.org/show_bug.cgi?id=197964
868         <rdar://problem/50625666>
869
870         Reviewed by Wenson Hsieh.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
873         (TEST):
874
875 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
876
877         [ews-build] Add clickable url in UI for uploaded S3 archive
878         https://bugs.webkit.org/show_bug.cgi?id=197996
879
880         Reviewed by Jonathan Bedard.
881
882         * BuildSlaveSupport/ews-build/steps.py:
883
884 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
885
886         [ews-app] Status bubble should not turn orange when any build step has warnings
887         https://bugs.webkit.org/show_bug.cgi?id=198000
888
889         Reviewed by Jonathan Bedard.
890
891         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
892         (StatusBubble._does_build_contains_any_failed_step):
893
894 2019-05-17  Alex Christensen  <achristensen@webkit.org>
895
896         Add SPI to set a list of hosts to which to send custom header fields cross-origin
897         https://bugs.webkit.org/show_bug.cgi?id=197397
898
899         Reviewed by Geoff Garen.
900
901         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
902         (TEST):
903         (expectLegacyHeaders):
904         (expectHeaders):
905         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
906         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
907         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
908
909 2019-05-17  Keith Rollin  <krollin@apple.com>
910
911         Unreviewed build fix.
912
913         Teach generate-xcfilelists about iphonesimulator.
914
915         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
916         (JavaScriptCoreGenerator):
917         (WebCoreGenerator):
918         (WebKitGenerator):
919
920 2019-05-17  Keith Rollin  <krollin@apple.com>
921
922         Re-enable generate-xcfilelists
923         https://bugs.webkit.org/show_bug.cgi?id=197933
924         <rdar://problem/50831677>
925
926         Reviewed by Jonathan Bedard.
927
928         The following two tasks have been completed, and we can re-enable
929         generate-xcfilelists:
930
931         Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
932         Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
933
934         * DumpRenderTree/Scripts/check-xcfilelists.sh:
935         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
936
937 2019-05-17  Commit Queue  <commit-queue@webkit.org>
938
939         Unreviewed, rolling out r245401.
940         https://bugs.webkit.org/show_bug.cgi?id=197990
941
942         Causing internal build failures (Requested by ShawnRoberts on
943         #webkit).
944
945         Reverted changeset:
946
947         "Add SPI to set a list of hosts to which to send custom header
948         fields cross-origin"
949         https://bugs.webkit.org/show_bug.cgi?id=197397
950         https://trac.webkit.org/changeset/245401
951
952 2019-05-17  Commit Queue  <commit-queue@webkit.org>
953
954         Unreviewed, rolling out r245418.
955         https://bugs.webkit.org/show_bug.cgi?id=197989
956
957         New API test causing crashes on Mojave testers (Requested by
958         ShawnRoberts on #webkit).
959
960         Reverted changeset:
961
962         "Add a unit test for client certificate authentication"
963         https://bugs.webkit.org/show_bug.cgi?id=197800
964         https://trac.webkit.org/changeset/245418
965
966 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews-build] Add build step to Transfer archive to S3
969         https://bugs.webkit.org/show_bug.cgi?id=197922
970
971         Reviewed by Jonathan Bedard.
972
973         * BuildSlaveSupport/ews-build/steps.py:
974         (TransferToS3):
975         (TransferToS3.finished): Invoke triggers after transfer is successful.
976         (TransferToS3.getResultSummary): Create more readable failure string.
977         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
978         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
979
980 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [GTK] Need WebKitContextMenuItemType to open emoji picker
983         https://bugs.webkit.org/show_bug.cgi?id=176760
984
985         Reviewed by Michael Catanzaro.
986
987         Update context menu test to check insert emoji action is included in default context menu for editable content.
988
989         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
990
991 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
992
993         [ews-build] Download archives from S3
994         https://bugs.webkit.org/show_bug.cgi?id=197949
995
996         Reviewed by Jonathan Bedard.
997
998         * BuildSlaveSupport/ews-build/steps.py:
999         (DownloadBuiltProduct): Updated to use S3 URL.
1000         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
1001         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1002
1003 2019-05-16  David Kilzer  <ddkilzer@apple.com>
1004
1005         REGRESSION (r15133): Fix leak of JSStringRef in minidom
1006         <https://webkit.org/b/197968>
1007         <rdar://problem/50872430>
1008
1009         Reviewed by Joseph Pecoraro.
1010
1011         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
1012         (expectScriptValueIsString): Drive-by fix to use adopt() instead
1013         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
1014
1015 2019-05-16  David Kilzer  <ddkilzer@apple.com>
1016
1017         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
1018         <https://webkit.org/b/197965>
1019
1020         Reviewed by Joseph Pecoraro.
1021
1022         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1023         (WTR::TestRunner::pathToLocalResource): Don't call
1024         JSStringRetain() here because the JSRetainPtr<JSStringRef>
1025         return type will increment the retain count for us.
1026
1027 2019-05-16  Alex Christensen  <achristensen@webkit.org>
1028
1029         Add a unit test for client certificate authentication
1030         https://bugs.webkit.org/show_bug.cgi?id=197800
1031
1032         Reviewed by Youenn Fablet.
1033
1034         Make better abstractions for reading and writing from/to TCPServer.
1035         Add a unit test that causes a client certificate authentication challenge to happen.
1036
1037         * TestWebKitAPI/TCPServer.cpp:
1038         (TestWebKitAPI::TCPServer::TCPServer):
1039         (TestWebKitAPI::TCPServer::read):
1040         (TestWebKitAPI::TCPServer::write):
1041         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1042         (TestWebKitAPI::TCPServer::respondWithOK):
1043         * TestWebKitAPI/TCPServer.h:
1044         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1045         (credentialWithIdentity):
1046         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1047         (TEST):
1048         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1049         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1050         (-[ClientCertificateDelegate challengeCount]):
1051         (TestWebKitAPI::TEST):
1052         (respondWithChallengeThenOK): Deleted.
1053         (credentialWithIdentityAndKeychainPath): Deleted.
1054         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1055         (TEST):
1056         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1059         (TEST):
1060         (readRequest): Deleted.
1061         (writeResponse): Deleted.
1062         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1063         (TestWebKitAPI::TEST):
1064         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1065
1066 2019-05-16  Alex Christensen  <achristensen@webkit.org>
1067
1068         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1069         https://bugs.webkit.org/show_bug.cgi?id=197397
1070
1071         Reviewed by Geoff Garen.
1072
1073         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1074         (TEST):
1075         (expectLegacyHeaders):
1076         (expectHeaders):
1077         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1078         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1079         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1080
1081 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1082
1083         Replace double-quotes with single quotes in steps.py
1084         https://bugs.webkit.org/show_bug.cgi?id=197921
1085
1086         Reviewed by Jonathan Bedard.
1087
1088         * BuildSlaveSupport/ews-build/steps.py:
1089
1090 2019-05-15  Keith Rollin  <krollin@apple.com>
1091
1092         Rewrite generate-xcfilelists in Python
1093         https://bugs.webkit.org/show_bug.cgi?id=197622
1094         <rdar://problem/50508222>
1095
1096         Reviewed by Jonathan Bedard, Alex Christensen.
1097
1098         For a number of reasons, rewrite generate-xcfilelists in Python:
1099
1100         - The previous bash script was large and unmaintainable.
1101         - We have more internal expertise with Python than with bash.
1102         - The bash script used temporary files in /tmp that got stranded and
1103           were owned by root, making them awkward to clear out.
1104           <rdar://problem/49490262>
1105         - We needed to complete support for engineers that built with Xcode
1106           rather than the command line.
1107         - There are some bugs leading to mildly corrupted .xcfilelist files.
1108           It's not apparent the source of the bugs, but one general reason
1109           might be due to approaches born of using bash. Rewriting in Python
1110           may clear these up.
1111
1112         * Scripts/generate-xcfilelists:
1113         * Scripts/webkitpy/common/attribute_saver.py: Added.
1114         (AttributeSaver):
1115         (AttributeSaver.__init__):
1116         (AttributeSaver.__enter__):
1117         (AttributeSaver.__exit__):
1118         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
1119         (AttributeSaverTest):
1120         (AttributeSaverTest.SimpleTestClass):
1121         (AttributeSaverTest.SimpleTestClass.__init__):
1122         (AttributeSaverTest.test_class):
1123         (AttributeSaverTest.test_normal_default):
1124         (AttributeSaverTest.test_normal_value):
1125         (AttributeSaverTest.test_normal_value_on_exception):
1126         (AttributeSaverTest.test_normal_value_on_normal_exit):
1127         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
1128         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
1129         (AttributeSaverTest.test_normal_value_with_else_on_exception):
1130         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
1131         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
1132         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
1133         (Application):
1134         (Application.__init__):
1135         (Application.run):
1136         (Application._initialize):
1137         (Application._initialize.collect_attributes):
1138         (Application._create_parser):
1139         (_validate_args):
1140         (_cmd_generate):
1141         (_cmd_check):
1142         (_cmd_subgenerate):
1143         (_cmd_help):
1144         (_do_generate):
1145         (_do_merge):
1146         (_report_results):
1147         (_report_merge_results):
1148         (_report_remediation_steps):
1149         (_report_remediation_steps.add_to_message):
1150         (_any_have_errors):
1151         (_any_have_actions):
1152         (_log_progress):
1153         (_log_results):
1154         (get_generate_xcfilelists_script_path):
1155         (_get_root_dir):
1156         (get_opensource_dir):
1157         (get_build_scripts_dir):
1158         (get_extract_dependencies_from_makefile_script):
1159         (get_xcode_built_products_dir):
1160         (_getenv):
1161         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
1162         (BaseGenerator):
1163         (BaseGenerator.__init__):
1164         (BaseGenerator.__str__):
1165         (BaseGenerator.generate):
1166         (BaseGenerator._sublaunch_under_xcode):
1167         (BaseGenerator.subgenerate):
1168         (BaseGenerator.merge):
1169         (BaseGenerator.pickle_to_file):
1170         (BaseGenerator.has_action):
1171         (BaseGenerator.has_error):
1172         (BaseGenerator.is_valid):
1173         (BaseGenerator.report_error):
1174         (BaseGenerator._generate_derived):
1175         (BaseGenerator._merge_derived):
1176         (BaseGenerator._generate_unified):
1177         (BaseGenerator._merge_unified):
1178         (BaseGenerator._replace):
1179         (BaseGenerator._unexpand):
1180         (BaseGenerator._find_added_lines):
1181         (BaseGenerator._merge_added_lines):
1182         (BaseGenerator._get_file_lines):
1183         (BaseGenerator._getenv):
1184         (BaseGenerator._get_project_file_path):
1185         (BaseGenerator._get_project_dir):
1186         (BaseGenerator._get_project_file_name):
1187         (BaseGenerator._get_project_name):
1188         (BaseGenerator._get_sym_root):
1189         (BaseGenerator._get_obj_root):
1190         (BaseGenerator._get_shared_precomps_dir):
1191         (BaseGenerator._get_build_dirs):
1192         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
1193         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
1194         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
1195         (BaseGenerator._get_derived_sources_dir):
1196         (BaseGenerator._get_xcfilelist_dir):
1197         (BaseGenerator._get_input_derived_xcfilelist_project_path):
1198         (BaseGenerator._get_output_derived_xcfilelist_project_path):
1199         (BaseGenerator._get_input_unified_xcfilelist_project_path):
1200         (BaseGenerator._get_output_unified_xcfilelist_project_path):
1201         (BaseGenerator._get_generate_derived_sources_script):
1202         (BaseGenerator._get_generate_unified_sources_script):
1203         (JavaScriptCoreGenerator):
1204         (JavaScriptCoreGenerator._get_project_file_path):
1205         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
1206         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
1207         (WebCoreGenerator):
1208         (WebCoreGenerator._get_project_file_path):
1209         (WebCoreGenerator._get_generate_derived_sources_script):
1210         (WebCoreGenerator._get_generate_unified_sources_script):
1211         (WebKitGenerator):
1212         (WebKitGenerator._get_project_file_path):
1213         (WebKitGenerator._get_derived_sources_dir):
1214         (WebKitGenerator._get_generate_derived_sources_script):
1215         (WebKitGenerator._get_generate_unified_sources_script):
1216         (DumpRenderTreeGenerator):
1217         (DumpRenderTreeGenerator._get_project_file_path):
1218         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
1219         (WebKitTestRunnerGenerator):
1220         (WebKitTestRunnerGenerator._get_project_file_path):
1221         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1222         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
1223         (debug_log):
1224         (LogEntryHelper):
1225         (LogEntryHelper.__init__):
1226         (LogEntryHelper.log_entry):
1227         (LogEntryHelper.log_result):
1228         (LogEntryHelper.log_exception):
1229         (LogEntryHelper._print):
1230         (LogEntryExit):
1231         (LogEntryExit._show_debug_logging):
1232         (LogEntryExitClass):
1233         (LogEntryExitClass._show_debug_logging):
1234         (LogEntryExitGlobal):
1235         (LogEntryExitGlobal._show_debug_logging):
1236         (subprocess_run):
1237         (is_running_under_xcode):
1238         (CheckValidItemAction):
1239         (CheckValidItemAction.__init__):
1240         (CheckValidItemAction.__call__):
1241         (CheckValidItemAction.validate_item):
1242         (CheckCommandAction):
1243         (CheckCommandAction.__call__):
1244         (InvalidCommandError):
1245         (InvalidArgumentError):
1246         (InvalidConfigurationError):
1247         (CalledProcessError):
1248         (CalledProcessError.__str__):
1249         * Scripts/webkitpy/xcode/__init__.py:
1250         (xcode_hash_for_path):
1251         (xcode_hash_for_path.convert_to_string):
1252         * Scripts/webkitpy/xcode/sdk.py: Added.
1253         (SDK):
1254         (SDK.__init__):
1255         (SDK.__repr__):
1256         (SDK.as_xcode_specification):
1257         (SDK.get_preferred_sdk_for_platform):
1258         (SDK._parse_sdk):
1259         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
1260         (SDKTest):
1261
1262 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1263
1264         [ews-build] Enabling uploading EWS archives to S3
1265         https://bugs.webkit.org/show_bug.cgi?id=197914
1266
1267         Reviewed by Jonathan Bedard.
1268
1269         * BuildSlaveSupport/Shared: Added.
1270         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
1271         (archiveExists): Replace tab with space.
1272         (main): Added main method.
1273         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1274         (TransferToS3): Updated path to the script.
1275         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
1276
1277 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1278
1279         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
1280         https://bugs.webkit.org/show_bug.cgi?id=197916
1281         <rdar://problem/50815427>
1282
1283         Reviewed by Timothy Hatcher.
1284
1285         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
1286         inputmode="numeric".
1287
1288         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1289         (TestWebKitAPI::TEST):
1290
1291 2019-05-15  Youenn Fablet  <youenn@apple.com>
1292
1293         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
1294         https://bugs.webkit.org/show_bug.cgi?id=197463
1295         <rdar://problem/47403621>
1296
1297         Reviewed by Alex Christensen.
1298
1299         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
1300         (-[QuotaDelegate init]):
1301         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1302         (-[QuotaDelegate quotaDelegateCalled]):
1303         (-[QuotaDelegate grantQuota]):
1304         (-[StorageSchemes webView:startURLSchemeTask:]):
1305         (-[StorageSchemes webView:stopURLSchemeTask:]):
1306         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
1307         (doTest):
1308
1309 2019-05-15  Youenn Fablet  <youenn@apple.com>
1310
1311         Constant crashes under WebPage::isThrottleable() after r245299
1312         https://bugs.webkit.org/show_bug.cgi?id=197902
1313         <rdar://problem/50793796>
1314
1315         Reviewed by Alex Christensen.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1318
1319 2019-05-15  Philippe Normand  <pnormand@igalia.com>
1320
1321         [GTK][jhbuild] misc cleanups and bumps
1322         https://bugs.webkit.org/show_bug.cgi?id=197913
1323
1324         Reviewed by Xabier Rodriguez-Calvar.
1325
1326         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
1327         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
1328
1329 2019-05-15  Chris Dumez  <cdumez@apple.com>
1330
1331         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1332         https://bugs.webkit.org/show_bug.cgi?id=195102
1333         <rdar://problem/48456786>
1334
1335         Reviewed by Alex Christensen.
1336
1337         Try to wait longer for the number of processes to reach the expected number
1338         and before failing.
1339
1340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1341
1342 2019-05-15  Alex Christensen  <achristensen@webkit.org>
1343
1344         Allow NSFileCoordinator to be called from WebContent process
1345         https://bugs.webkit.org/show_bug.cgi?id=197895
1346         <rdar://problem/50107679>
1347
1348         Reviewed by Brent Fulgham.
1349
1350         Add a unit test that verifies calling the block succeeds.
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1353         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1354
1355 2019-05-14  Andy Estes  <aestes@apple.com>
1356
1357         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
1358         https://bugs.webkit.org/show_bug.cgi?id=197751
1359         <rdar://problem/50631563>
1360
1361         Reviewed by Alex Christensen.
1362
1363         Added new API tests.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1366         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
1367         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1368         (TestWebKitAPI::TEST):
1369         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
1370         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
1371
1372 2019-05-14  Youenn Fablet  <youenn@apple.com>
1373
1374         A service worker process should app nap when all its clients app nap
1375         https://bugs.webkit.org/show_bug.cgi?id=185626
1376         <rdar://problem/46785908>
1377
1378         Reviewed by Alex Christensen.
1379
1380         Allow to enable app nap through test header.
1381
1382         * WebKitTestRunner/TestController.cpp:
1383         (WTR::TestController::resetPreferencesToConsistentValues):
1384         (WTR::updateTestOptionsFromTestHeader):
1385         * WebKitTestRunner/TestOptions.h:
1386         (WTR::TestOptions::hasSameInitializationOptions const):
1387
1388 2019-05-14  Commit Queue  <commit-queue@webkit.org>
1389
1390         Unreviewed, rolling out r245281.
1391         https://bugs.webkit.org/show_bug.cgi?id=197887
1392
1393         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
1394         (Requested by aakashjain on #webkit).
1395
1396         Reverted changeset:
1397
1398         "Add a unit test for client certificate authentication"
1399         https://bugs.webkit.org/show_bug.cgi?id=197800
1400         https://trac.webkit.org/changeset/245281
1401
1402 2019-05-14  Youenn Fablet  <youenn@apple.com>
1403
1404         Add support for webkit-test-runner options to WPT importer
1405         https://bugs.webkit.org/show_bug.cgi?id=197826
1406
1407         Reviewed by Alex Christensen.
1408
1409         In case of overwriting an existing test, check if the existing test
1410         contains a <!-- webkit-test-runner --> comment and insert it back if
1411         needed in the new test.
1412
1413         For exporter, forbid creating a WPT PR if there are changes containing
1414         the webkit-test-runner string.
1415
1416         * Scripts/webkitpy/w3c/test_converter.py:
1417         (convert_for_webkit):
1418         (_W3CTestConverter.__init__):
1419         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
1420         (_W3CTestConverter.handle_starttag):
1421         (_W3CTestConverter.handle_comment):
1422         (_W3CTestConverter.handle_decl):
1423         (_W3CTestConverter.handle_pi):
1424         * Scripts/webkitpy/w3c/test_exporter.py:
1425         (WebPlatformTestExporter.write_git_patch_file):
1426         (WebPlatformTestExporter.make_pull_request):
1427         * Scripts/webkitpy/w3c/test_importer.py:
1428         (TestImporter.webkit_test_runner_options):
1429         (TestImporter):
1430         (TestImporter.add_webkit_test_runner_options_to_content):
1431         (TestImporter.copy_html_file):
1432         (TestImporter.write_html_template):
1433         (TestImporter.write_html_files_for_templated_js_tests):
1434         (TestImporter.import_tests):
1435         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1436         (test_manual_slow_test):
1437         (test_webkit_test_runner_options):
1438
1439 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
1440
1441         [ews-app] Status bubble should turn orange when any build step fails
1442         https://bugs.webkit.org/show_bug.cgi?id=197812
1443
1444         Reviewed by Jonathan Bedard.
1445
1446         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1447         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
1448         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
1449
1450 2019-05-14  Alex Christensen  <achristensen@webkit.org>
1451
1452         Add a unit test for client certificate authentication
1453         https://bugs.webkit.org/show_bug.cgi?id=197800
1454
1455         Reviewed by Youenn Fablet.
1456
1457         Make better abstractions for reading and writing from/to TCPServer.
1458         Add a unit test that causes a client certificate authentication challenge to happen.
1459
1460         * TestWebKitAPI/TCPServer.cpp:
1461         (TestWebKitAPI::TCPServer::TCPServer):
1462         (TestWebKitAPI::TCPServer::read):
1463         (TestWebKitAPI::TCPServer::write):
1464         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1465         (TestWebKitAPI::TCPServer::respondWithOK):
1466         * TestWebKitAPI/TCPServer.h:
1467         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1468         (credentialWithIdentity):
1469         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1470         (TEST):
1471         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1472         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1473         (-[ClientCertificateDelegate challengeCount]):
1474         (TestWebKitAPI::TEST):
1475         (respondWithChallengeThenOK): Deleted.
1476         (credentialWithIdentityAndKeychainPath): Deleted.
1477         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1478         (TEST):
1479         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1480         (TestWebKitAPI::TEST):
1481         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1482         (TEST):
1483         (readRequest): Deleted.
1484         (writeResponse): Deleted.
1485         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1486         (TestWebKitAPI::TEST):
1487         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1488
1489 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1490
1491         [CG] Adding support for HEIF-sequence ('public.heics') images
1492         https://bugs.webkit.org/show_bug.cgi?id=197384
1493
1494         Reviewed by Simon Fraser.
1495
1496         * DumpRenderTree/TestOptions.cpp:
1497         (TestOptions::TestOptions):
1498         * DumpRenderTree/TestOptions.h:
1499         * DumpRenderTree/mac/DumpRenderTree.mm:
1500         (resetWebViewToConsistentStateBeforeTesting):
1501         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1502         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
1503         the test.
1504
1505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1506         (WTR::InjectedBundle::stringForKey):
1507         (WTR::InjectedBundle::beginTesting):
1508         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::resetStateToConsistentValues):
1511         (WTR::updateTestOptionsFromTestHeader):
1512         * WebKitTestRunner/TestInvocation.cpp:
1513         (WTR::TestInvocation::createTestSettingsDictionary):
1514         * WebKitTestRunner/TestOptions.h:
1515         (WTR::TestOptions::hasSameInitializationOptions const):
1516         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1517         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
1518         the test.
1519
1520 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
1521
1522         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
1523         https://bugs.webkit.org/show_bug.cgi?id=197730
1524
1525         Reviewed by Filip Pizlo.
1526
1527         * TestWebKitAPI/CMakeLists.txt:
1528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1529         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1530         (TestWebKitAPI::TEST):
1531         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
1532         (TestWebKitAPI::TEST):
1533
1534 2019-05-10  Chris Dumez  <cdumez@apple.com>
1535
1536         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
1537
1538         It became flaky after r245198.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1541
1542 2019-05-10  Youenn Fablet  <youenn@apple.com>
1543
1544         A service worker instance should be terminated when its SWServer is destroyed
1545         https://bugs.webkit.org/show_bug.cgi?id=197801
1546         <rdar://problem/50587270>
1547
1548         Reviewed by Chris Dumez.
1549
1550         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1551
1552 2019-05-10  Chris Dumez  <cdumez@apple.com>
1553
1554         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
1555         https://bugs.webkit.org/show_bug.cgi?id=197750
1556
1557         Reviewed by Geoffrey Garen.
1558
1559         Add API test coverage.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1562         (TEST):
1563
1564 2019-05-10  Keith Miller  <keith_miller@apple.com>
1565
1566         Remove legacy test262 import script
1567         https://bugs.webkit.org/show_bug.cgi?id=197788
1568
1569         Reviewed by Yusuke Suzuki.
1570
1571         import-test262-tests doesn't work anymore. We should be using test262-import instead.
1572
1573         * Scripts/import-test262-tests: Removed.
1574
1575 2019-05-10  Charlie Turner  <cturner@igalia.com>
1576
1577         [WPE] Forward libepoxy cflags
1578         https://bugs.webkit.org/show_bug.cgi?id=197784
1579
1580         Reviewed by Žan Doberšek.
1581
1582         Patch by Zan Dobersek.
1583
1584         * wpe/backends/CMakeLists.txt: This is required to keep
1585         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
1586         up trying to include X11 headers even when they're not present in the
1587         environment.
1588
1589 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1590
1591         Fix a bunch of compiler warnings
1592         https://bugs.webkit.org/show_bug.cgi?id=197785
1593
1594         Reviewed by Don Olmstead.
1595
1596         Add preprocessor guards to avoid -Wunused-function warnings.
1597
1598         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1599         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1600         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1601
1602 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1603
1604         [WPE][GTK] Add webkit_frame_get_id() API
1605         https://bugs.webkit.org/show_bug.cgi?id=197270
1606
1607         Reviewed by Carlos Garcia Campos.
1608
1609         This was hard, but I added a test to verify that two different WebKitFrames of the same
1610         WebKitWebPage return two different frame IDs.
1611
1612         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1613         (WebKitFrameTest::willSubmitFormCallback):
1614         (WebKitFrameTest::testSubframe):
1615         (registerTests):
1616         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1617         (testWebKitFrameSubframe):
1618         (beforeAll):
1619         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1620         (willSubmitFormCallback):
1621         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
1622         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
1623
1624 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1625
1626         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
1627         https://bugs.webkit.org/show_bug.cgi?id=197271
1628
1629         Reviewed by Youenn Fablet.
1630
1631         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1632         (formControlsAssociatedForFrameCallback):
1633         (pageCreatedCallback):
1634         (formControlsAssociatedCallback): Deleted.
1635
1636 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
1637
1638         [Flatpak] Use the safe PyYAML loader if available
1639         https://bugs.webkit.org/show_bug.cgi?id=197771
1640
1641         Reviewed by Philippe Normand.
1642
1643         * flatpak/flatpakutils.py:
1644         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
1645         still used as fallback when the former is not provided by the module.
1646
1647 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1648
1649         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
1650         https://bugs.webkit.org/show_bug.cgi?id=197734
1651
1652         Reviewed by Don Olmstead.
1653
1654         * Scripts/webkitpy/port/win.py:
1655         (WinCairoPort._search_paths): Add 'wk2' and
1656         additional_platform_directory to paths as well as other ports do.
1657
1658 2019-05-09  Daniel Bates  <dabates@apple.com>
1659
1660         [iOS] Numpad comma key has incorrect keyIdentifier property
1661         https://bugs.webkit.org/show_bug.cgi?id=197753
1662         <rdar://problem/50636274>
1663
1664         Reviewed by Brent Fulgham.
1665
1666         Recognize "numpadComma" and return the appropriate HID usage code.
1667
1668         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1669         (hidUsageCodeForCharacter):
1670
1671 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
1672
1673         Refine AudioSession route sharing policy
1674         https://bugs.webkit.org/show_bug.cgi?id=197742
1675         <rdar://problem/50590818>
1676
1677         Reviewed by Darin Adler.
1678
1679         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1680         (TestWebKitAPI::TEST):
1681
1682 2019-05-09  Alex Christensen  <achristensen@webkit.org>
1683
1684         Remove unnecessary test SPI after r244883
1685         https://bugs.webkit.org/show_bug.cgi?id=197575
1686
1687         Reviewed by Tim Horton.
1688
1689         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1690         (TEST):
1691         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1692         (TestWebKitAPI::TEST):
1693
1694 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews-app] Add migrations file to repository
1697         https://bugs.webkit.org/show_bug.cgi?id=197729
1698
1699         Reviewed by Jonathan Bedard.
1700
1701         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
1702
1703 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1704
1705         [ews-build] Fix formatting issues and typos
1706         https://bugs.webkit.org/show_bug.cgi?id=197737
1707
1708         Reviewed by Jonathan Bedard.
1709
1710         * BuildSlaveSupport/ews-build/steps.py:
1711         (CompileWebKit.evaluateCommand): Removed extra empty line.
1712         * BuildSlaveSupport/ews-build/steps_unittest.py:
1713         (TestRunWebKitPerlTests): Fixed typo.
1714         * BuildSlaveSupport/ews-app/ews/models/step.py:
1715         (Step.save_step): Changed log level to info so that it is logged in production.
1716
1717 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1718
1719         [ews-app] Production and Development env should configure DEBUG appropriately
1720         https://bugs.webkit.org/show_bug.cgi?id=197700
1721
1722         Reviewed by Jonathan Bedard.
1723
1724         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1725
1726 2019-05-09  Xan López  <xan@igalia.com>
1727
1728         [CMake] Detect SSE2 at compile time
1729         https://bugs.webkit.org/show_bug.cgi?id=196488
1730
1731         Reviewed by Carlos Garcia Campos.
1732
1733         * Scripts/webkitdirs.pm:
1734         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
1735         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
1736
1737 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
1738
1739         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
1740         https://bugs.webkit.org/show_bug.cgi?id=197697
1741
1742         Reviewed by Žan Doberšek.
1743
1744         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
1745         * wpe/jhbuild.modules: Ditto.
1746
1747 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1748
1749         Update ANGLE
1750         https://bugs.webkit.org/show_bug.cgi?id=197676
1751
1752         Reviewed by Alex Christensen.
1753
1754         * TestWebKitAPI/PlatformWin.cmake:
1755         Remove unnecessary library linkage.
1756
1757 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
1758
1759         [Win] build-webkit should be ready for Visual Studio 2019
1760         https://bugs.webkit.org/show_bug.cgi?id=196622
1761
1762         Reviewed by Ross Kirsling.
1763
1764         1. Accommodated to the new msbuild.exe location of VS 2019.
1765         2. Removed the hard coded "Visual Studio 15" generator.
1766
1767         build-webkit is going to choose a Visual Studio generator version
1768         matching with the latest installed VS. If you invoke vcvars.bat
1769         before build-webkit, it chooses the corresponding Visual Studio
1770         generator version by cheking 'VisualStudioVersion' env var which
1771         is set by vcvars.bat.
1772
1773         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
1774         (msBuildPath): When looking for MSBuild, look in
1775         "MSBuild\Current\bin" (the new expected location) and fallback
1776         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
1777         first location.
1778         (msBuildInstallDir): Renamed to msBuildPath.
1779         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
1780         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
1781
1782 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1783
1784         [PlayStation] Update port options
1785         https://bugs.webkit.org/show_bug.cgi?id=197723
1786
1787         Reviewed by Ross Kirsling.
1788
1789         ICU headers were missing from TestWTF.
1790
1791         * TestWebKitAPI/PlatformPlayStation.cmake:
1792
1793 2019-05-08  Alex Christensen  <achristensen@webkit.org>
1794
1795         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
1796         https://bugs.webkit.org/show_bug.cgi?id=197712
1797         <rdar://problem/50429770>
1798
1799         Reviewed by Tim Horton.
1800
1801         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
1802         (TestWebKitAPI::TEST):
1803
1804 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
1805
1806         Change my status to be a WebKit reviewer.
1807
1808         * Scripts/webkitpy/common/config/contributors.json:
1809
1810 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1811
1812         Unreviewed, rolling out r244952.
1813
1814         Caused inspector to appear blank.
1815
1816         Reverted changeset:
1817
1818         "Web Inspector: Provide UIString descriptions to improve
1819         localizations"
1820         https://bugs.webkit.org/show_bug.cgi?id=195132
1821         https://trac.webkit.org/changeset/244952
1822
1823 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1824
1825         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
1826         https://bugs.webkit.org/show_bug.cgi?id=197685
1827
1828         Reviewed by Alex Christensen.
1829
1830         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
1831         completion. See LayoutTests/ChangeLog for more details.
1832
1833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1834         (WTR::UIScriptController::platformClearAllCallbacks):
1835
1836 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
1837
1838         Unreviewed. Add myself as a committer.
1839
1840         * Scripts/webkitpy/common/config/contributors.json:
1841
1842 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1843
1844         Unreviewed, rolling out r245038.
1845
1846         Breaks internal builds.
1847
1848         Reverted changeset:
1849
1850         "Add SPI to set a list of hosts to which to send custom header
1851         fields cross-origin"
1852         https://bugs.webkit.org/show_bug.cgi?id=197397
1853         https://trac.webkit.org/changeset/245038
1854
1855 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
1856
1857         Unreviewed. Add myself as a committer.
1858
1859         * Scripts/webkitpy/common/config/contributors.json:
1860
1861 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
1862
1863         Define media buffering policy
1864         https://bugs.webkit.org/show_bug.cgi?id=196979
1865         <rdar://problem/28383861>
1866
1867         Reviewed by Jer Noble.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
1871         (waitUntilBufferingPolicyIsEqualTo):
1872         (TEST):
1873
1874 2019-05-07  Alex Christensen  <achristensen@webkit.org>
1875
1876         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1877         https://bugs.webkit.org/show_bug.cgi?id=197397
1878
1879         Reviewed by Geoff Garen.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1882         (TEST):
1883         (expectLegacyHeaders):
1884         (expectHeaders):
1885         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1886         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1887         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1888
1889 2019-05-07  Keith Rollin  <krollin@apple.com>
1890
1891         Add option to build-webkit to control whether or not XCBuild is used
1892         https://bugs.webkit.org/show_bug.cgi?id=197668
1893         <rdar://problem/50549728>
1894
1895         Reviewed by Tim Horton.
1896
1897         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
1898         Also update build-webkit and the makefiles with the foundation for
1899         automatically using XCBuild when the conditions allow it. This latter
1900         facility is currently turned off until Xcode fully supports building
1901         WebKit with XCBuild.
1902
1903         * Scripts/build-webkit:
1904         * Scripts/webkitdirs.pm:
1905         (XcodeOptions):
1906         (canUseXCBuild):
1907
1908 2019-05-07  Andy Estes  <aestes@apple.com>
1909
1910         run-bindings-tests should test global scope constructor generation
1911         https://bugs.webkit.org/show_bug.cgi?id=197669
1912
1913         Reviewed by Alex Christensen.
1914
1915         * Scripts/webkitpy/bindings/main.py:
1916         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
1917         invoking preprocess-idls.pl.
1918
1919 2019-05-07  Youenn Fablet  <youenn@apple.com>
1920
1921         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
1922         https://bugs.webkit.org/show_bug.cgi?id=195997
1923         <rdar://problem/50509884>
1924
1925         Reviewed by Chris Dumez.
1926
1927         Spin test until successful.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1930
1931 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
1932
1933         [Flatpak] webkit-build fails due to missing GTK2 in build environment
1934         https://bugs.webkit.org/show_bug.cgi?id=197352
1935
1936         Reviewed by Philippe Normand.
1937
1938         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
1939         to build it ourselves on top in order to be able to build the GTK 2.x plugin
1940         process.
1941
1942         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
1943
1944 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1945
1946         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
1947         https://bugs.webkit.org/show_bug.cgi?id=197644
1948         <rdar://problem/50526364>
1949
1950         Reviewed by Tim Horton.
1951
1952         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1955         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1956         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1957         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1958
1959 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1960
1961         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1962         https://bugs.webkit.org/show_bug.cgi?id=197651
1963
1964         Reviewed by Žan Doberšek.
1965
1966         This is required since the process creation was delayed until something is loaded in the view.
1967
1968         * MiniBrowser/gtk/BrowserWindow.c:
1969         (browser_window_get_or_create_web_view_for_automation):
1970         * MiniBrowser/wpe/main.cpp:
1971         (main):
1972
1973 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1974
1975         _overrideViewportWithArguments does not work when called before loading
1976         https://bugs.webkit.org/show_bug.cgi?id=197638
1977         <rdar://problem/50505111>
1978
1979         Reviewed by Wenson Hsieh.
1980
1981         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1982         (TEST):
1983
1984 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1985
1986         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1987         https://bugs.webkit.org/show_bug.cgi?id=197510
1988
1989         Reviewed by Alex Christensen.
1990
1991         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1992         (TestWebKitAPI::TEST):
1993
1994 2019-05-06  Keith Rollin  <krollin@apple.com>
1995
1996         Temporarily disable generate-xcfilelists
1997         https://bugs.webkit.org/show_bug.cgi?id=197619
1998         <rdar://problem/50507392>
1999
2000         Reviewed by Alex Christensen.
2001
2002         We need to perform a significant update to the generate-xcfilelist
2003         scripts. This work involves coordinated work with another facility. If
2004         the work does not occur in tandem, the build will be broken. To avoid
2005         this, disable the invoking of the scripts during the transition. The
2006         checking will be restored once the new scripts are in place.
2007
2008         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2009         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2010
2011 2019-05-04  Alex Christensen  <achristensen@webkit.org>
2012
2013         Revert r244953 and r244954 because they broke internal builds.
2014         https://bugs.webkit.org/show_bug.cgi?id=197534
2015
2016         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2017         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2018         * DumpRenderTree/mac/DumpRenderTree.mm:
2019         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2020         * DumpRenderTree/mac/TestRunnerMac.mm:
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2023         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2024         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2025         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2026         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2027         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2028         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2029         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2030         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2031         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2032         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2033         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2034         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2035         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2036         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2037         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2038         * TestWebKitAPI/ios/UIKitSPI.h: Added.
2039         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2040         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2041         * WebKitTestRunner/ios/HIDEventGenerator.h:
2042         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2043         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2044         * WebKitTestRunner/ios/TestControllerIOS.mm:
2045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2046         * WebKitTestRunner/ios/mainIOS.mm:
2047
2048 2019-05-04  Alex Christensen  <achristensen@webkit.org>
2049
2050         Merge the three UIKitSPI.h files into a single one in PAL
2051         https://bugs.webkit.org/show_bug.cgi?id=197534
2052
2053         Reviewed by Darin Adler.
2054
2055         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2056         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2057         * DumpRenderTree/mac/DumpRenderTree.mm:
2058         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2059         * DumpRenderTree/mac/TestRunnerMac.mm:
2060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2061         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2062         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2063         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2064         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2065         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2066         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2067         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2068         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2069         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2070         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2071         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2072         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2073         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2074         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2075         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2076         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2077         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
2078         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2079         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2080         * WebKitTestRunner/ios/HIDEventGenerator.h:
2081         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2082         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2083         * WebKitTestRunner/ios/TestControllerIOS.mm:
2084         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2085         * WebKitTestRunner/ios/mainIOS.mm:
2086
2087 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
2088
2089         Web Inspector: Provide UIString descriptions to improve localizations
2090         https://bugs.webkit.org/show_bug.cgi?id=195132
2091         <rdar://problem/48457817>
2092
2093         Reviewed by Devin Rousso.
2094
2095         Allow WI.UIString to take:
2096         - WI.UIString(string, key, comment)
2097         - WI.UIString(string, comment)
2098         - WI.UIString(string)
2099
2100         * Scripts/extract-localizable-js-strings:
2101
2102 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2103
2104         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
2105         https://bugs.webkit.org/show_bug.cgi?id=197579
2106
2107         Reviewed by Tim Horton.
2108
2109         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
2110         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
2111         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
2112         ensure that the the focused element has been blurred.
2113
2114         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2115
2116 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
2117
2118         Add a tool to block spammer accounts
2119         https://bugs.webkit.org/show_bug.cgi?id=197537
2120
2121         Reviewed by Darin Adler.
2122
2123         Usage: block-spammers email1 email2 ...
2124
2125         The tool finds and hides all bugs and comments from this account. Before any work
2126         is done, these bugs and comments are displayed for confirmation.
2127
2128         * Scripts/block-spammers: Added.
2129         (get_bugzilla_token):
2130         (invalidate_bugzilla_token):
2131         (get_user_info):
2132         (get_user_info_self):
2133         (can_use_this_tool):
2134         (disable_user):
2135         (get_bugs_created_by_user):
2136         (get_bugs_commented_on_by_user):
2137         (get_comments):
2138         (hide_bug):
2139         (hide_comments):
2140         (ask_yes_no):
2141         (sanitized_string):
2142         (main):
2143
2144 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
2145
2146         run-apit-tests: Add --iterations and --repeat-each
2147         https://bugs.webkit.org/show_bug.cgi?id=197563
2148
2149         Reviewed by Aakash Jain.
2150
2151         * Scripts/webkitpy/api_tests/manager.py:
2152         (Manager.run): Add --iterations and --repeat-each/
2153         * Scripts/webkitpy/api_tests/run_api_tests.py:
2154         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
2155
2156 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2157
2158         New EWS: Clicking on white bubble navigates to page with only bubbles
2159         https://bugs.webkit.org/show_bug.cgi?id=197520
2160
2161         Reviewed by Lucas Forschler.
2162
2163         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
2164
2165 2019-05-03  Daniel Bates  <dabates@apple.com>
2166
2167         [lldb-webkit] Support adding pretty-printing for qualified types
2168         https://bugs.webkit.org/show_bug.cgi?id=197518
2169
2170         Reviewed by Darin Adler.
2171
2172         Remove all "::"s from the name of the specified type when computing the name for the Python classes
2173         that will provide summary and synthetic details as LLDB is not happy about registering such classes
2174         when they contain :: in their name.
2175
2176         * lldb/lldb_webkit.py:
2177         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2178
2179 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2180
2181         New EWS: patches on recently added queues listed as #1 for older bugs
2182         https://bugs.webkit.org/show_bug.cgi?id=197496
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2187         (StatusBubble._build_bubble):
2188         (StatusBubble._queue_position):
2189
2190 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2191
2192         webkit-patch --no-review upload does not submit patch to New EWS
2193         https://bugs.webkit.org/show_bug.cgi?id=197519
2194         <rdar://problem/50424887>
2195
2196         Reviewed by Lucas Forschler.
2197
2198         * Scripts/webkitpy/tool/steps/submittoews.py:
2199         (SubmitToEWS.run): Submit to both old and new EWS.
2200         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
2201         * Scripts/webkitpy/common/net/ewsserver.py: Added.
2202         (EWSServer._server_url): Method to return server url.
2203         (EWSServer._post_patch_to_ews): Method to post patch to ews.
2204         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
2205         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
2206         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
2207         * Scripts/webkitpy/common/net/statusserver_mock.py:
2208         (MockStatusServer.submit_to_ews): Updated the log text.
2209         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
2210         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2211         * Scripts/webkitpy/tool/main.py:
2212         (WebKitPatch.__init__): Initialize ews_server. 
2213         * Scripts/webkitpy/tool/mocktool.py:
2214         (MockTool.__init__): Ditto.
2215
2216 2019-05-03  Chris Dumez  <cdumez@apple.com>
2217
2218         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
2219         https://bugs.webkit.org/show_bug.cgi?id=197574
2220         <rdar://problem/50453181>
2221
2222         Reviewed by Tim Horton.
2223
2224         Add API test coverage.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2227         (TEST):
2228
2229 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
2230
2231         [JSC] Generator CodeBlock generation should be idempotent
2232         https://bugs.webkit.org/show_bug.cgi?id=197552
2233
2234         Reviewed by Keith Miller.
2235
2236         * Scripts/run-javascriptcore-tests:
2237         (runJSCStressTests):
2238         * Scripts/run-jsc-stress-tests:
2239
2240 2019-05-03  Commit Queue  <commit-queue@webkit.org>
2241
2242         Unreviewed, rolling out r244881.
2243         https://bugs.webkit.org/show_bug.cgi?id=197559
2244
2245         Breaks compilation of jsconly on linux, breaking compilation
2246         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
2247         guijemont on #webkit).
2248
2249         Reverted changeset:
2250
2251         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
2252         WEBKIT_COPY_FILES"
2253         https://bugs.webkit.org/show_bug.cgi?id=197174
2254         https://trac.webkit.org/changeset/244881
2255
2256 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
2257
2258         Unreviewed WPE build fix after r244898.
2259
2260         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2261         (WTR::TestController::abortModal): Add the missing (no-op) definition.
2262
2263 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2264
2265         Mark U+01C0 as a homograph of U+006C
2266         https://bugs.webkit.org/show_bug.cgi?id=197526
2267         <rdar://problem/50301904>
2268
2269         Reviewed by Tim Horton.
2270
2271         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2272         (TestWebKitAPI::TEST):
2273
2274 2019-05-02  Chris Dumez  <cdumez@apple.com>
2275
2276         Add test coverage for <rdar://problem/49731231>
2277         https://bugs.webkit.org/show_bug.cgi?id=196730
2278         <rdar://problem/49731231>
2279
2280         Reviewed by Ryosuke Niwa.
2281
2282         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
2283         to match DumpRenderTree.
2284
2285         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2287         (WTR::TestRunner::abortModal):
2288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2289         * WebKitTestRunner/TestController.cpp:
2290         (WTR::TestController::runModal):
2291         * WebKitTestRunner/TestController.h:
2292         * WebKitTestRunner/TestInvocation.cpp:
2293         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2294         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2295         (WTR::TestController::abortModal):
2296         * WebKitTestRunner/ios/TestControllerIOS.mm:
2297         (WTR::TestController::abortModal):
2298         * WebKitTestRunner/mac/TestControllerMac.mm:
2299         (WTR::TestController::abortModal):
2300         * WebKitTestRunner/win/TestControllerWin.cpp:
2301         (WTR::TestController::abortModal):
2302
2303 2019-05-02  Christopher Reid  <chris.reid@sony.com>
2304
2305         [CMake] Add support for LTO builds
2306         https://bugs.webkit.org/show_bug.cgi?id=188986
2307
2308         Reviewed by Don Olmstead.
2309
2310         Add support to configure --lto-mode with cmake builds.
2311
2312         * Scripts/build-webkit:
2313         * Scripts/webkitdirs.pm:
2314         (generateBuildSystemFromCMakeProject):
2315
2316 2019-05-02  John Wilander  <wilander@apple.com>
2317
2318         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
2319         https://bugs.webkit.org/show_bug.cgi?id=197521
2320         <rdar://problem/49651503>
2321
2322         Reviewed by Brent Fulgham.
2323
2324         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2325         (TestWebKitAPI::TEST):
2326            Added a test for host strings with leading dots since they are
2327            often used for the domain attribute in cookies.
2328
2329 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
2330
2331         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2332         https://bugs.webkit.org/show_bug.cgi?id=197510
2333
2334         Reviewed by Alex Christensen.
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2337         (TestWebKitAPI::TEST):
2338
2339 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
2340
2341         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
2342         https://bugs.webkit.org/show_bug.cgi?id=197174
2343
2344         Reviewed by Alex Christensen.
2345
2346         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
2347
2348         * TestWebKitAPI/PlatformGTK.cmake:
2349         * TestWebKitAPI/PlatformWPE.cmake:
2350
2351 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2352
2353         Build fix for internal branch.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2356         RetainPtr.h was not explicitly included.
2357
2358 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
2359
2360         webkitpy: Ignore errors when shutting down an already shutdown simulator
2361         <https://bugs.webkit.org/show_bug.cgi?id=197514>
2362         <rdar://problem/50390247>
2363
2364         Reviewed by Lucas Forschler.
2365
2366         * Scripts/webkitpy/xcode/simulated_device.py:
2367         (SimulatedDevice._shut_down):
2368
2369 2019-05-02  Frederic Wang  <fwang@igalia.com>
2370
2371         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
2372         https://bugs.webkit.org/show_bug.cgi?id=196142
2373
2374         This patch introduces some experimental runtime flag to let users
2375         disable MathML features that are removed from MathML Core [1]. For now,
2376         these features are only disabled on GTK and WPE ports.
2377
2378         [1] https://mathml-refresh.github.io/mathml-core/
2379
2380         Reviewed by Rob Buis.
2381
2382         * DumpRenderTree/TestOptions.cpp:
2383         (TestOptions::TestOptions):
2384         * DumpRenderTree/TestOptions.h:
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (setWebPreferencesForTestOptions):
2387
2388 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
2389
2390         TestWebKitAPI config.h should be aware of what suite is being built
2391         https://bugs.webkit.org/show_bug.cgi?id=196583
2392
2393         Reviewed by Konstantin Tokarev.
2394
2395         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
2396         benefit the macro defines BUILDING_* for the executable which allows the includes
2397         of the config.h to be tailored to the test suite being built. Because of that the
2398         dependencies of the Test* executable are specific to the test suite which may
2399         speed up the build.
2400
2401         Some source files were including "PlatformUtilities.h" which includes WebKit headers
2402         when "Utilities.h" is what was needed.
2403
2404         * TestWebKitAPI/CMakeLists.txt:
2405         * TestWebKitAPI/PlatformGTK.cmake:
2406         * TestWebKitAPI/PlatformJSCOnly.cmake:
2407         * TestWebKitAPI/PlatformMac.cmake:
2408         * TestWebKitAPI/PlatformPlayStation.cmake:
2409         * TestWebKitAPI/PlatformUtilities.h:
2410         * TestWebKitAPI/PlatformWPE.cmake:
2411         * TestWebKitAPI/PlatformWin.cmake:
2412         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2413         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2414         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2415         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
2416         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2417         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2418         * TestWebKitAPI/config.h:
2419
2420 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
2421
2422         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
2423         https://bugs.webkit.org/show_bug.cgi?id=181950
2424         <rdar://problem/43357371>
2425
2426         Reviewed by Brent Fulgham.
2427
2428         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2429         (TestWebKitAPI::TEST_F):
2430
2431 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2432
2433         Remove webkitpy and bindings EWS queues from dashboard
2434         https://bugs.webkit.org/show_bug.cgi?id=197475
2435
2436         Reviewed by Alexey Proskuryakov.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2439
2440 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2441
2442         Remove webkitpy and bindings test queues from old EWS
2443         https://bugs.webkit.org/show_bug.cgi?id=197468
2444
2445         Reviewed by Alexey Proskuryakov.
2446
2447         * QueueStatusServer/config/queues.py:
2448
2449 2019-04-30  Tim Horton  <timothy_horton@apple.com>
2450
2451         Fix the WebKitTestRunner build
2452         https://bugs.webkit.org/show_bug.cgi?id=197449
2453         <rdar://problem/50334169>
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         * WebKitTestRunner/mac/EventSenderProxy.mm:
2458         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2459         (WTR::EventSenderProxy::mouseForceChanged):
2460         Use some SPI instead of IPI.
2461
2462 2019-04-30  Chris Dumez  <cdumez@apple.com>
2463
2464         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2465         https://bugs.webkit.org/show_bug.cgi?id=197426
2466         <rdar://problem/50256169>
2467
2468         Reviewed by Brady Eidson.
2469
2470         Add API test coverage.
2471
2472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2473         (-[PSONScheme setShouldRespondAsynchronously:]):
2474         (-[PSONScheme webView:startURLSchemeTask:]):
2475         (-[PSONScheme webView:stopURLSchemeTask:]):
2476
2477 2019-04-30  Chris Dumez  <cdumez@apple.com>
2478
2479         Unreviewed, rolling out r244802.
2480
2481         Caused an API test failure
2482
2483         Reverted changeset:
2484
2485         "Regression(PSON) URL scheme handlers can no longer respond
2486         asynchronously"
2487         https://bugs.webkit.org/show_bug.cgi?id=197426
2488         https://trac.webkit.org/changeset/244802
2489
2490 2019-04-30  Chris Dumez  <cdumez@apple.com>
2491
2492         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2493         https://bugs.webkit.org/show_bug.cgi?id=197426
2494         <rdar://problem/50256169>
2495
2496         Reviewed by Brady Eidson.
2497
2498         Add API test coverage.
2499
2500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2501         (-[PSONScheme setShouldRespondAsynchronously:]):
2502         (-[PSONScheme webView:startURLSchemeTask:]):
2503         (-[PSONScheme webView:stopURLSchemeTask:]):
2504
2505 2019-04-30  Chris Dumez  <cdumez@apple.com>
2506
2507         Only use a related page's process if that page has not been closed yet
2508         https://bugs.webkit.org/show_bug.cgi?id=197393
2509         <rdar://problem/50302423>
2510
2511         Reviewed by Tim Horton.
2512
2513         Add API test coverage.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2516
2517 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2518
2519         [ews-build] Enable Bindings tests queue on new EWS
2520         https://bugs.webkit.org/show_bug.cgi?id=197424
2521
2522         Reviewed by Lucas Forschler.
2523
2524         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2525         (StatusBubble):
2526         * BuildSlaveSupport/ews-build/config.json:
2527
2528 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2529
2530         [ews-build] Configure ews151 for running various tests
2531         https://bugs.webkit.org/show_bug.cgi?id=197419
2532
2533         Reviewed by Lucas Forschler.
2534
2535         * BuildSlaveSupport/ews-build/config.json:
2536
2537 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2538
2539         [ews-build] Parse and display bindings test failures
2540         https://bugs.webkit.org/show_bug.cgi?id=197423
2541
2542         Reviewed by Lucas Forschler.
2543
2544         * BuildSlaveSupport/ews-build/steps.py:
2545         (RunBindingsTests.__init__): Set timeout of 5 minutes.
2546         (RunBindingsTests.start): Initialize log_observer for json output.
2547         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
2548         (RunBindingsTests._addToLog): Method to add message to log.
2549         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2550
2551 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
2552
2553         Unreviewed. Add myself as a committer.
2554
2555         * Scripts/webkitpy/common/config/contributors.json:
2556
2557 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2558
2559         [ews-build] Enable webkitpy queue on new EWS
2560         https://bugs.webkit.org/show_bug.cgi?id=197396
2561
2562         Reviewed by Lucas Forschler.
2563
2564         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2565         (StatusBubble):
2566         * BuildSlaveSupport/ews-build/config.json:
2567
2568 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-build] Parse and display webkitpy failures
2571         https://bugs.webkit.org/show_bug.cgi?id=197395
2572
2573         Reviewed by Lucas Forschler.
2574
2575         * BuildSlaveSupport/ews-build/steps.py:
2576         (RunWebKitPyTests.start): Initialize log_observer for json output.
2577         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
2578         (RunWebKitPyTests._addToLog): Method to add message to log.
2579         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2580
2581 2019-04-29  Alex Christensen  <achristensen@webkit.org>
2582
2583         <rdar://problem/50299396> Fix internal High Sierra build
2584         https://bugs.webkit.org/show_bug.cgi?id=197388
2585
2586         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2587         * MiniBrowser/Configurations/Base.xcconfig:
2588         * MobileMiniBrowser/Configurations/Base.xcconfig:
2589         * TestWebKitAPI/Configurations/Base.xcconfig:
2590         * WebKitTestRunner/Configurations/Base.xcconfig:
2591
2592 2019-04-29  Youenn Fablet  <youenn@apple.com>
2593
2594         Remove spurious GVA printf logging
2595         https://bugs.webkit.org/show_bug.cgi?id=197368
2596         <rdar://problem/35975256>
2597
2598         Reviewed by Alexey Proskuryakov.
2599
2600         * Scripts/webkitpy/port/mac.py:
2601         (MacPort.logging_patterns_to_strip):
2602
2603 2019-04-29  Youenn Fablet  <youenn@apple.com>
2604
2605         getDisplayMedia should be called on user gesture
2606         https://bugs.webkit.org/show_bug.cgi?id=197356
2607         <rdar://problem/50296074>
2608
2609         Reviewed by Eric Carlson.
2610
2611         Update test configuration to inject internals
2612         so that we can use it to simulate a user click to call getDisplayMedia.
2613
2614         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2615         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2616         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
2617
2618 2019-04-26  Stephanie Lewis  <slewis@apple.com>
2619
2620         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
2621         https://bugs.webkit.org/show_bug.cgi?id=197339
2622
2623         Reviewed by Dewei Zhu.
2624
2625         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
2626         test run for setup steps that are too expensive to do every iteration.
2627
2628         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2629         (BenchmarkRunner._run_benchmark):
2630         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2631         (BrowserDriver):
2632         (BrowserDriver.prepare_initial_env):
2633         (BrowserDriver.restore_env_after_all_testing):
2634         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2635         (LinuxBrowserDriver.prepare_initial_env):
2636         (LinuxBrowserDriver.restore_env_after_all_testing):
2637         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2638         (OSXBrowserDriver.prepare_initial_env):
2639         (OSXBrowserDriver.restore_env_after_all_testing):
2640
2641 2019-04-28  Andy Estes  <aestes@apple.com>
2642
2643         Fix the watchOS engineering build.
2644
2645         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2646         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
2647
2648 2019-04-27  Chris Dumez  <cdumez@apple.com>
2649
2650         [WKTR] Move test timeout handling to the UIProcess
2651         https://bugs.webkit.org/show_bug.cgi?id=197333
2652
2653         Reviewed by Darin Adler.
2654
2655         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
2656         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
2657         every WebContent process in the case of swapping.
2658
2659         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
2660         would lead to crashes when firing the timer.
2661
2662         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2663         (WTR::InjectedBundle::didReceiveMessageToPage):
2664         (WTR::InjectedBundle::done):
2665         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2666         (WTR::InjectedBundle::shouldDumpPixels const):
2667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2668         (WTR::TestRunner::TestRunner):
2669         (WTR::TestRunner::waitUntilDone):
2670         (WTR::TestRunner::setWaitUntilDone):
2671         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2672         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2673         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2674         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2675         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
2676         * WebKitTestRunner/TestInvocation.cpp:
2677         (WTR::TestInvocation::TestInvocation):
2678         (WTR::TestInvocation::createTestSettingsDictionary):
2679         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2680         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2681         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
2682         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
2683         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
2684         (WTR::TestInvocation::setWaitUntilDone):
2685         (WTR::TestInvocation::done):
2686         * WebKitTestRunner/TestInvocation.h:
2687
2688 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
2689
2690         [JSC] linkPolymorphicCall now does GC
2691         https://bugs.webkit.org/show_bug.cgi?id=197306
2692
2693         Reviewed by Saam Barati.
2694
2695         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
2696         To add this test, we add `runWithoutBaseOption`.
2697
2698         * Scripts/run-jsc-stress-tests:
2699
2700 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2701
2702         Update inactive reviewers' status to 'contributor'.
2703
2704         Accidentally skipped one at first.
2705
2706         * Scripts/webkitpy/common/config/contributors.json:
2707
2708 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2709
2710         Update inactive reviewers' status to 'contributor'.
2711
2712         * Scripts/webkitpy/common/config/contributors.json: The change.
2713
2714         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2715         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2716         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2717         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2718         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2719         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2720         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2721         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2722         Sadly, regression tests operate on a crazy mix of mock and live data for
2723         contributors.json. It would be a substantial project to mock all code paths,
2724         so changing the tests instead.
2725
2726 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
2727
2728         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2729         https://bugs.webkit.org/show_bug.cgi?id=197171
2730         <rdar://problem/47454979>
2731
2732         Reviewed by Youenn Fablet.
2733
2734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2735         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2736         (TestWebKitAPI::TEST):
2737
2738 2019-04-26  David Kilzer  <ddkilzer@apple.com>
2739
2740         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
2741         <https://webkit.org/b/197314>
2742         <rdar://problem/50245252>
2743
2744         Reviewed by Simon Fraser.
2745
2746         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2747         (WTR::UIScriptController::lastUndoLabel const):
2748         (WTR::UIScriptController::firstRedoLabel const):
2749         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2750
2751         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2752         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2753         - Call -autorelease to fix leak of NSDictionary.
2754
2755         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2756         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
2757         (WTR::UIScriptController::selectFormPopoverTitle const):
2758         (WTR::UIScriptController::textContentType const):
2759         (WTR::UIScriptController::formInputLabel const):
2760         (WTR::UIScriptController::scrollingTreeAsText const):
2761         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2762
2763 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
2764
2765         webkitpy: Running a single test will always use the default device
2766         https://bugs.webkit.org/show_bug.cgi?id=195472
2767         <rdar://problem/48724825>
2768
2769         Reviewed by Lucas Forschler.
2770
2771         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
2772         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
2773         requested will be run regardless of what shard they are in.
2774
2775         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2776         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
2777         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2778         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
2779         on the default device type.
2780         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2781         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
2782         (RunTest.test_run_part): Ditto.
2783
2784 2019-04-26  Alex Christensen  <achristensen@webkit.org>
2785
2786         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
2787         https://bugs.webkit.org/show_bug.cgi?id=197165
2788
2789         Reviewed by Youenn Fablet.
2790
2791         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2792
2793 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2794
2795         Replace iOS build queue hardware
2796         https://bugs.webkit.org/show_bug.cgi?id=197312
2797
2798         Reviewed by Aakash Jain.
2799
2800         * BuildSlaveSupport/build.webkit.org-config/config.json:
2801         Use newer hardware that supports macOS Mojave.
2802
2803 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2804
2805         check-webkit-style complains the first block in while loop.
2806         https://bugs.webkit.org/show_bug.cgi?id=197307
2807
2808         The style checker shouldn't complain about an open brace on
2809         its own line if the last non-whitespace character on the previous
2810         non-blank line is another open brace, because it's likely to
2811         indicate the begining of a nested code block.
2812
2813         Reviewed by Alex Christensen.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (check_braces):
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (WebKitStyleTest.test_braces):
2819
2820 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
2821
2822         Stop IDB transactions to release locked database files when network process is ready to suspend
2823         https://bugs.webkit.org/show_bug.cgi?id=196372
2824         <rdar://problem/48930116>
2825
2826         Reviewed by Brady Eidson.
2827
2828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2829         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
2830         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
2831         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
2832         (runTestAndCheckResult):
2833         (keepNetworkProcessActive):
2834         (TEST):
2835
2836 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2837
2838         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
2839         https://bugs.webkit.org/show_bug.cgi?id=188357
2840         <rdar://problem/42986633>
2841
2842         Reviewed by Dean Jackson.
2843
2844         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
2845         tests would fall into low memory mode and have different behavior.
2846         
2847         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
2848         to Internals, so it's shared by DRT and WTR.
2849         
2850         We no longer need the WK2 C SPI glue.
2851
2852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2853         (WTR::InjectedBundlePage::prepare):
2854
2855 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
2856
2857         webkitpy: Including skipped tests in the final count
2858         https://bugs.webkit.org/show_bug.cgi?id=197298
2859         <rdar://problem/49705424>
2860
2861         Reviewed by Lucas Forschler.
2862
2863         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2864         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
2865
2866 2019-04-25  Timothy Hatcher  <timothy@apple.com>
2867
2868         Disable date and time inputs on iOSMac.
2869         https://bugs.webkit.org/show_bug.cgi?id=197287
2870         rdar://problem/46794376
2871
2872         Reviewed by Wenson Hsieh.
2873
2874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2875
2876 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2877
2878         Fix test-webkitpy after r244653
2879         https://bugs.webkit.org/show_bug.cgi?id=197131
2880
2881         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2882         Also use C++17.
2883
2884 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
2885
2886         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
2887         https://bugs.webkit.org/show_bug.cgi?id=196991
2888         <rdar://problem/45507423>
2889
2890         Reviewed by Alex Christensen.
2891
2892         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2893         (-[NavigationTestDelegate init]):
2894         (-[NavigationTestDelegate waitForDidFinishNavigation]):
2895         (-[NavigationTestDelegate webView:didFinishNavigation:]):
2896         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2897         (TestWebKitAPI::TEST):
2898         (TEST): Deleted.
2899
2900 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2901
2902         Revert some code accidentally committed with r244653
2903         https://bugs.webkit.org/show_bug.cgi?id=197131
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2906         (TestWebKitAPI::TEST):
2907
2908 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2909
2910         Start using C++17
2911         https://bugs.webkit.org/show_bug.cgi?id=197131
2912
2913         Reviewed by Darin Adler.
2914
2915         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2916         * MiniBrowser/Configurations/Base.xcconfig:
2917         * MobileMiniBrowser/Configurations/Base.xcconfig:
2918         * TestWebKitAPI/Configurations/Base.xcconfig:
2919         * WebKitTestRunner/Configurations/Base.xcconfig:
2920
2921 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2922
2923         Unreviewed, rolling out r244627.
2924         https://bugs.webkit.org/show_bug.cgi?id=197282
2925
2926         Causing internal build failures (Requested by ShawnRoberts on
2927         #webkit).
2928
2929         Reverted changeset:
2930
2931         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2932         https://bugs.webkit.org/show_bug.cgi?id=197171
2933         https://trac.webkit.org/changeset/244627
2934
2935 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2936
2937         [GTK] Hardcoded text color in input fields
2938         https://bugs.webkit.org/show_bug.cgi?id=126907
2939
2940         Reviewed by Michael Catanzaro.
2941
2942         Add dark-mode command line option to MiniBrowser.
2943
2944         * MiniBrowser/gtk/main.c:
2945         (main):
2946
2947 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2948
2949         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2950         https://bugs.webkit.org/show_bug.cgi?id=196948
2951         <rdar://problem/49927131>
2952
2953         Reviewed by Tim Horton.
2954
2955         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2956         (TEST):
2957         The expected order of incoming events is
2958         1. didInvalidateIntrinsicContentSize
2959         2. didFirstLayout
2960         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2961         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2962         (and remember, all we care about is ordering).
2963
2964 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2965
2966         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2967         https://bugs.webkit.org/show_bug.cgi?id=197171
2968         <rdar://problem/47454979>
2969
2970         Reviewed by Youenn Fablet.
2971
2972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2973         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2974         (TestWebKitAPI::TEST):
2975
2976 2019-04-24  Brady Eidson  <beidson@apple.com>
2977
2978         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2979         https://bugs.webkit.org/show_bug.cgi?id=191362
2980
2981         Reviewed by Alex Christensen.
2982
2983         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2984           from an XHR to a custom protocol.
2985
2986 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2987
2988         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2989         https://bugs.webkit.org/show_bug.cgi?id=197273
2990
2991         Reviewed by Dean Jackson.
2992
2993         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2994         so that WebCoreTestSupport::resetInternalsObject() is always run.
2995
2996         * DumpRenderTree/mac/DumpRenderTree.mm:
2997         (resetWebViewToConsistentStateBeforeTesting):
2998         (runTest):
2999
3000 2019-04-24  John Wilander  <wilander@apple.com>
3001
3002         Age out unconverted Ad Click Attributions after one week.
3003         https://bugs.webkit.org/show_bug.cgi?id=197238
3004         <rdar://problem/50177349>
3005
3006         Reviewed by Chris Dumez.
3007
3008         This patch adds infrastructure to allow tests to expire all unconverted
3009         attributions early.
3010
3011         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3012         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3013         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
3014         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3015         * WebKitTestRunner/TestController.cpp:
3016         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
3017         * WebKitTestRunner/TestController.h:
3018         * WebKitTestRunner/TestInvocation.cpp:
3019         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3020
3021 2019-04-24  Chris Dumez  <cdumez@apple.com>
3022
3023         Fix flaky crashes in a couple of PSON API tests
3024         https://bugs.webkit.org/show_bug.cgi?id=197239
3025
3026         Reviewed by Tim Horton.
3027
3028         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
3029
3030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3031
3032 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
3033
3034         Make it possible to control the renderTreeAsText output by setting options on testRunner
3035         https://bugs.webkit.org/show_bug.cgi?id=197133
3036
3037         Reviewed by Sam Weinig.
3038
3039         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
3040         that make sense in testing (those that don't dump unstable data like addresses), and plumb
3041         these flags through the various framework layers.
3042
3043         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
3044
3045         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
3046         and hand-code DumpRenderTree bindings.
3047
3048         Some cleanup of the TestRunners, using member initializers.
3049
3050         * DumpRenderTree/TestRunner.cpp:
3051         (TestRunner::TestRunner):
3052         (setRenderTreeDumpOptionsCallback):
3053         (TestRunner::staticFunctions):
3054         (TestRunner::setRenderTreeDumpOptions):
3055         * DumpRenderTree/TestRunner.h:
3056         (TestRunner::renderTreeDumpOptions const):
3057         * DumpRenderTree/mac/DumpRenderTree.mm:
3058         (dump):
3059         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3060         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3061         (WTR::InjectedBundlePage::dump):
3062         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3063         (WTR::TestRunner::TestRunner):
3064         (WTR::TestRunner::setRenderTreeDumpOptions):
3065         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3066         (WTR::TestRunner::renderTreeDumpOptions const):
3067
3068 2019-04-24  Alex Christensen  <achristensen@webkit.org>
3069
3070         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
3071         https://bugs.webkit.org/show_bug.cgi?id=197078
3072         <rdar://problem/49564348>
3073
3074         Reviewed by Geoff Garen.
3075
3076         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3077         (TEST_F):
3078         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
3079         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
3080         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
3081
3082 2019-04-24  Alex Christensen  <achristensen@webkit.org>
3083
3084         Add unit test for r239322
3085         https://bugs.webkit.org/show_bug.cgi?id=197236
3086
3087         Reviewed by Chris Dumez.
3088
3089         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
3090         May as well add the test infrastructure which was needed before and will be needed in the future.
3091
3092         * TestWebKitAPI/TCPServer.cpp:
3093         (TestWebKitAPI::TCPServer::TCPServer):
3094         * TestWebKitAPI/TCPServer.h:
3095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3096         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3097         (TestWebKitAPI::TEST):
3098         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3099         (TestWebKitAPI::downloadAtRate):
3100         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3101         (TEST):
3102         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
3103         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3104         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3105         (TestWebKitAPI::TEST):
3106         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3107         (TEST):
3108
3109 2019-04-24  Chris Dumez  <cdumez@apple.com>
3110
3111         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
3112         https://bugs.webkit.org/show_bug.cgi?id=197214
3113         <rdar://problem/49237544>
3114
3115         Reviewed by Alex Christensen.
3116
3117         Extend API test coverage.
3118
3119         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3120         (TEST):
3121
3122 2019-04-24  Philippe Normand  <pnormand@igalia.com>
3123
3124         [Build][GStreamer] Update to 1.16.0
3125         https://bugs.webkit.org/show_bug.cgi?id=197157
3126
3127         Reviewed by Xabier Rodriguez-Calvar.
3128
3129         The upstreamed patches were removed and a new one was added for a
3130         regression detected in the scaletempo GStreamer element. The GNOME
3131         Flatpak was migrated to 3.32 and I switched a few modules to Meson
3132         on the way, as it is the preferred build system now in GStreamer
3133         1.16.
3134
3135         * flatpak/files/httpd-autogen.sh:
3136         * flatpak/flatpakutils.py:
3137         (FlatpakPackage.install):
3138         (WebkitFlatpak.run_in_sandbox):
3139         * flatpak/org.webkit.CommonModules.yaml:
3140         * flatpak/org.webkit.WebKit.yaml:
3141         * gstreamer/jhbuild.modules:
3142         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
3143         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
3144         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
3145         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
3146         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
3147         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
3148         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
3149         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
3150         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
3151         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
3152         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
3153         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
3154         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
3155         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
3156         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
3157         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
3158         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
3159         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
3160         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
3161         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
3162         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
3163         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
3164
3165 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3166
3167         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
3168         https://bugs.webkit.org/show_bug.cgi?id=197156
3169
3170         Reviewed by Michael Catanzaro.
3171
3172         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
3173         support was added.
3174
3175         * MiniBrowser/gtk/BrowserTab.c:
3176         (browser_tab_set_background_color): Set the passed in color as web view background color.
3177         * MiniBrowser/gtk/BrowserTab.h:
3178         * MiniBrowser/gtk/BrowserWindow.c:
3179         (browser_window_init): Initialize backgroundColor.
3180         (browser_window_append_view): Call browser_tab_set_background_color().
3181         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
3182         are added.
3183         * MiniBrowser/gtk/main.c:
3184         (main): Call browser_window_set_background_color() before creating the tabs.
3185
3186 2019-04-23  John Wilander  <wilander@apple.com>
3187
3188         Move Ad Click Attribution from internal feature to experimental feature
3189         https://bugs.webkit.org/show_bug.cgi?id=197218
3190         <rdar://problem/47651691>
3191
3192         Reviewed by Brent Fulgham.
3193
3194         * DumpRenderTree/TestOptions.cpp:
3195         (TestOptions::TestOptions):
3196
3197 2019-04-23  Andy Estes  <aestes@apple.com>
3198
3199         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
3200         https://bugs.webkit.org/show_bug.cgi?id=196749
3201         <rdar://problem/35773454>
3202
3203         Reviewed by Daniel Bates.
3204
3205         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3208         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
3209         (-[QuickLookDelegate webView:didFinishNavigation:]):
3210         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
3211         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3212         (runTest):
3213         (runTestDecideBeforeLoading):
3214         (runTestDecideAfterLoading):
3215         (TEST):
3216
3217 2019-04-23  John Wilander  <wilander@apple.com>
3218
3219         Remove Ad Click Attribution data when removing website data
3220         https://bugs.webkit.org/show_bug.cgi?id=197215
3221         <rdar://problem/47668988>
3222
3223         Reviewed by Chris Dumez.
3224
3225         This patch adds test infrastructure to delete Ad Click Attribution data
3226         through WebsiteDataStore::removeData().
3227
3228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3229         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3230         (WTR::TestRunner::clearAdClickAttribution):
3231         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
3232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3233         * WebKitTestRunner/TestController.cpp:
3234         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3235         * WebKitTestRunner/TestController.h:
3236         * WebKitTestRunner/TestInvocation.cpp:
3237         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3238
3239 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
3240
3241         webkitpy: Kill unresponsive worker processes
3242         https://bugs.webkit.org/show_bug.cgi?id=197205
3243         <rdar://problem/50104388>
3244
3245         Reviewed by Lucas Forschler.
3246
3247         * Scripts/webkitpy/common/message_pool.py:
3248         (_MessagePool.__init__): Add close timeout.
3249         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
3250
3251 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3252
3253         Add unit tests for WKWebView.serverTrust
3254         https://bugs.webkit.org/show_bug.cgi?id=197202
3255
3256         Reviewed by Youenn Fablet
3257
3258         * TestWebKitAPI/TCPServer.cpp:
3259         (TestWebKitAPI::deleter<BIO>::operator()):
3260         (TestWebKitAPI::deleter<SSL>::operator()):
3261         (TestWebKitAPI::deleter<X509>::operator()):
3262         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
3263         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
3264         (TestWebKitAPI::TCPServer::TCPServer):
3265         (TestWebKitAPI::TCPServer::listenForConnections):
3266         * TestWebKitAPI/TCPServer.h:
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3269         (TestWebKitAPI::TEST):
3270         (verifyCertificateAndPublicKey):
3271         (-[ServerTrustDelegate webView:didFinishNavigation:]):
3272         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3273         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3274         (TestWebKitAPI::downloadAtRate):
3275         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3276         (TEST):
3277         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3278         (TEST):
3279
3280 2019-04-23  Commit Queue  <commit-queue@webkit.org>
3281
3282         Unreviewed, rolling out r244556.
3283         https://bugs.webkit.org/show_bug.cgi?id=197212
3284
3285         Causing build failures on multiple builders (Requested by
3286         ShawnRoberts on #webkit).
3287
3288         Reverted changeset:
3289
3290         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
3291         https://bugs.webkit.org/show_bug.cgi?id=197171
3292         https://trac.webkit.org/changeset/244556
3293
3294 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3295
3296         Fix iOS build.
3297         https://bugs.webkit.org/show_bug.cgi?id=195537
3298
3299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3300         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3301         AdoptWK constructor is private now.  Use adoptWK instead.
3302
3303 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
3304
3305         Accessibility text search and selection API enhancements.
3306         https://bugs.webkit.org/show_bug.cgi?id=197095
3307         <rdar://problem/48181791>
3308
3309         Reviewed by Chris Fleizach.
3310
3311         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
3312
3313         * DumpRenderTree/AccessibilityTextMarker.h:
3314         * DumpRenderTree/AccessibilityUIElement.cpp:
3315         (searchTextWithCriteriaCallback):
3316         (AccessibilityUIElement::getJSClass):
3317         * DumpRenderTree/AccessibilityUIElement.h:
3318         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3319         (convertVectorToObjectArray):
3320         (convertNSArrayToVector):
3321         (searchTextParameterizedAttributeForCriteria):
3322         (AccessibilityUIElement::getLinkedUIElements):
3323         (AccessibilityUIElement::getDocumentLinks):
3324         (AccessibilityUIElement::getChildren):
3325         (AccessibilityUIElement::getChildrenWithRange):
3326         (AccessibilityUIElement::rowHeaders const):
3327         (AccessibilityUIElement::columnHeaders const):
3328         (AccessibilityUIElement::uiElementArrayAttributeValue const):
3329         (AccessibilityUIElement::searchTextWithCriteria):
3330         (AccessibilityUIElement::attributesOfColumnHeaders):
3331         (AccessibilityUIElement::attributesOfRowHeaders):
3332         (AccessibilityUIElement::attributesOfColumns):
3333         (AccessibilityUIElement::attributesOfRows):
3334         (AccessibilityUIElement::attributesOfVisibleCells):
3335         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3336         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3337         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3338         (WTR::convertVectorToObjectArray):
3339         (WTR::convertNSArrayToVector):
3340         (WTR::searchTextParameterizedAttributeForCriteria):
3341         (WTR::AccessibilityUIElement::getLinkedUIElements):
3342         (WTR::AccessibilityUIElement::getDocumentLinks):
3343         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
3344         (WTR::AccessibilityUIElement::getChildren):
3345         (WTR::AccessibilityUIElement::getChildrenWithRange):
3346         (WTR::AccessibilityUIElement::rowHeaders const):
3347         (WTR::AccessibilityUIElement::columnHeaders const):
3348         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
3349         (WTR::AccessibilityUIElement::searchTextWithCriteria):
3350         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3351         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3352         (WTR::AccessibilityUIElement::attributesOfColumns):
3353         (WTR::AccessibilityUIElement::attributesOfRows):
3354         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3355         (WTR::convertElementsToObjectArray): Deleted.
3356
3357 2019-04-23  Guy Lewin  <guy@lewin.co.il>
3358
3359         Multiple File Input Icon Set Regardless of File List
3360         https://bugs.webkit.org/show_bug.cgi?id=195537
3361
3362         Reviewed by Alexey Proskuryakov.
3363
3364         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
3365         display string in iOS file inputs
3366
3367         * DumpRenderTree/TestRunner.cpp:
3368         (SetOpenPanelFilesMediaIconCallback):
3369         (TestRunner::staticFunctions):
3370         (TestRunner::setOpenPanelFilesMediaIcon):
3371         * DumpRenderTree/TestRunner.h:
3372         (TestRunner::openPanelFilesMediaIcon const):
3373         * DumpRenderTree/mac/UIDelegate.mm:
3374         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
3375         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3377         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3378         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3379         * WebKitTestRunner/TestController.cpp:
3380         (WTR::runOpenPanel):
3381         (WTR::TestController::resetStateToConsistentValues):
3382         * WebKitTestRunner/TestController.h:
3383         (WTR::TestController::openPanelFileURLsMediaIcon const):
3384         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
3385         * WebKitTestRunner/TestInvocation.cpp:
3386         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3387
3388 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
3389
3390         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3391         https://bugs.webkit.org/show_bug.cgi?id=197171
3392         <rdar://problem/47454979>
3393
3394         Reviewed by Youenn Fablet.
3395
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3398         (TestWebKitAPI::TEST):
3399
3400 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3401
3402         [ews-build] Add unit tests for UnApplyPatchIfRequired
3403         https://bugs.webkit.org/show_bug.cgi?id=197197
3404
3405         Reviewed by Lucas Forschler.
3406
3407         * BuildSlaveSupport/ews-build/steps_unittest.py:
3408         (TestUnApplyPatchIfRequired):
3409         (TestUnApplyPatchIfRequired.test_success):
3410         (TestUnApplyPatchIfRequired.test_failure):
3411         (TestUnApplyPatchIfRequired.test_skip):
3412
3413 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3414
3415         [ews-build] Add unit tests for CleanWorkingDirectory
3416         https://bugs.webkit.org/show_bug.cgi?id=197195
3417
3418         Reviewed by Lucas Forschler.
3419
3420         * BuildSlaveSupport/ews-build/steps_unittest.py:
3421         (TestCleanWorkingDirectory):
3422         (TestCleanWorkingDirectory.test_success):
3423         (TestCleanWorkingDirectory.test_failure):
3424
3425 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-build] Use explicit imports instead of wildcard imports
3428         https://bugs.webkit.org/show_bug.cgi?id=197194
3429
3430         Reviewed by Lucas Forschler.
3431
3432         * BuildSlaveSupport/ews-build/factories.py:
3433         * BuildSlaveSupport/ews-build/loadConfig.py:
3434         * BuildSlaveSupport/ews-build/steps_unittest.py:
3435
3436 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3437
3438         [ews-build] Add unit tests for DownloadBuiltProduct
3439         https://bugs.webkit.org/show_bug.cgi?id=197193
3440
3441         Reviewed by Lucas Forschler.
3442
3443         * BuildSlaveSupport/ews-build/steps_unittest.py:
3444         (TestDownloadBuiltProduct):
3445         (TestDownloadBuiltProduct.setUp):
3446         (TestDownloadBuiltProduct.tearDown):
3447         (TestDownloadBuiltProduct.test_success):
3448         (TestDownloadBuiltProduct.test_failure):
3449
3450 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3451
3452         [ews-app] Exception while loading status-bubble when no build step has started
3453         https://bugs.webkit.org/show_bug.cgi?id=196676
3454
3455         Reviewed by Lucas Forschler.
3456
3457         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3458         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
3459
3460 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
3461
3462         [PlayStation] Support running of JSC tests on remote playstation devices
3463         https://bugs.webkit.org/show_bug.cgi?id=197170
3464
3465         Reviewed by Ross Kirsling.
3466
3467         Script changes
3468
3469         * Scripts/run-javascriptcore-tests:
3470         (runJSCStressTests): Pass arguments for playstation to
3471         run-jsc-stress-tests
3472         * Scripts/run-jsc-stress-tests:
3473         Handle $hostOS=="playstation" for determineArchitecture, turning
3474         off $isFTLPlatform and runProfiler and defaulting test writer.
3475         * Scripts/webkitdirs.pm:
3476         (jscPath): PlayStation WebKit executables have .elf extension
3477         (executableProductDir): PlayStation builds on Windows hosts but
3478         uses bin directory rather than bin64/bin32 for executable output
3479         location.
3480         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
3481
3482 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
3483
3484         [CMake][Win] Use target oriented design for WebKit
3485         https://bugs.webkit.org/show_bug.cgi?id=197173
3486
3487         Reviewed by Alex Christensen.
3488
3489         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
3490         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
3491
3492 2019-04-23  Chris Dumez  <cdumez@apple.com>
3493
3494         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
3495         https://bugs.webkit.org/show_bug.cgi?id=197097
3496         <rdar://problem/50048318>
3497
3498         Reviewed by Alex Christensen.
3499
3500         Add API test coverage.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3503         (-[PSONScheme webView:startURLSchemeTask:]):
3504
3505 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3506
3507         [ATK] Implement AtkComponentIface scroll_to methods
3508         https://bugs.webkit.org/show_bug.cgi?id=196856
3509
3510         Reviewed by Michael Catanzaro.
3511
3512         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3513         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
3514         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
3515         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
3516
3517 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3518
3519         [ews-build] Improve summary for UploadBuiltProduct step
3520         https://bugs.webkit.org/show_bug.cgi?id=197182
3521
3522         Reviewed by Lucas Forschler.
3523
3524         * BuildSlaveSupport/ews-build/steps.py:
3525         (UploadBuiltProduct): Added descriptionDone.
3526         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
3527         * BuildSlaveSupport/ews-build/steps_unittest.py:
3528         (TestUploadBuiltProduct.test_success): Updated unit-test.
3529         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
3530
3531 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3532
3533         [ews-build] Trigger queues only after uploading the archive
3534         https://bugs.webkit.org/show_bug.cgi?id=197180
3535
3536         Reviewed by Lucas Forschler.
3537
3538         * BuildSlaveSupport/ews-build/factories.py:
3539         (Factory.__init__):
3540         (BuildFactory.__init__): Remove trigger step from factories.
3541         (BuildFactory.propertiesToPassToTriggers): Deleted.
3542         * BuildSlaveSupport/ews-build/steps.py:
3543         (ConfigureBuild.__init__): Confiure triggers property.
3544         (Trigger): Step to trigger other queues.
3545         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
3546         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
3547
3548 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3549
3550         Deprecate WKContextCreateWithInjectedBundlePath
3551         https://bugs.webkit.org/show_bug.cgi?id=197169
3552
3553         Reviewed by Youenn Fablet.
3554
3555         * TestWebKitAPI/PlatformUtilities.cpp:
3556         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3557         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
3558
3559 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3560
3561         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
3562         https://bugs.webkit.org/show_bug.cgi?id=197093
3563         <rdar://problem/49708268>
3564
3565         Reviewed by Chris Dumez.
3566
3567         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
3568         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
3569         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
3570         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
3571         and one for loads without credentials, so there are two TCP connections to the same server in this test.
3572
3573         * TestWebKitAPI/TCPServer.cpp:
3574         (TestWebKitAPI::TCPServer::TCPServer):
3575         (TestWebKitAPI::TCPServer::~TCPServer):
3576         (TestWebKitAPI::TCPServer::socketBindListen):
3577         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
3578         * TestWebKitAPI/TCPServer.h:
3579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3580         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
3581         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3582         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3583         (respondWithChallengeThenOK):
3584         (TestWebKitAPI::TEST):
3585         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
3586         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3587         (TEST):
3588
3589 2019-04-22  Chris Dumez  <cdumez@apple.com>
3590
3591         Delayed WebProcessLaunch may break the _relatedWebView SPI
3592         https://bugs.webkit.org/show_bug.cgi?id=197160
3593
3594         Reviewed by Alex Christensen.
3595
3596         Add API test coverage.
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3599
3600 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
3601
3602         Use curl to download packages for webkitpy autoinstaller
3603         https://bugs.webkit.org/show_bug.cgi?id=197164
3604
3605         Reviewed by Darin Adler.
3606
3607         * Scripts/webkitpy/common/system/autoinstall.py:
3608         (AutoInstaller._download): Use curl(1) to download packages necessary for
3609         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
3610         errors which are not present when using curl(1).
3611
3612 2019-04-22  Chris Dumez  <cdumez@apple.com>
3613
3614         Unreviewed, rolling out r244502.
3615
3616         Caused crashes on the bots
3617
3618         Reverted changeset:
3619
3620         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
3621         https://bugs.webkit.org/show_bug.cgi?id=197160
3622         https://trac.webkit.org/changeset/244502
3623
3624 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
3625
3626         Unreviewed, rolling out r244437.
3627
3628         Still breaks internal tests.
3629
3630         Reverted changeset:
3631
3632         "InjectedBundle parameters often need initialization function
3633         called before unarchiving"
3634         https://bugs.webkit.org/show_bug.cgi?id=189709
3635         https://trac.webkit.org/changeset/244437
3636
3637 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-build] Use singular verb in failure description in case of single api test failure
3640         https://bugs.webkit.org/show_bug.cgi?id=197013
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * BuildSlaveSupport/ews-build/steps.py:
3645         (AnalyzeAPITestsResults.analyzeResults):
3646
3647 2019-04-22  Chris Dumez  <cdumez@apple.com>
3648
3649         Delayed WebProcessLaunch may break the _relatedWebView SPI
3650         https://bugs.webkit.org/show_bug.cgi?id=197160
3651
3652         Reviewed by Alex Christensen.
3653
3654         Add API test coverage.
3655
3656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3657
3658 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3659
3660         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
3661         https://bugs.webkit.org/show_bug.cgi?id=194630
3662
3663         Reviewed by Michael Catanzaro.
3664
3665         Return early from getAttributeSet() is passed in accessible is nullptr.
3666
3667         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3668
3669 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3670
3671         Defer EditorState updates until the next layer tree flush in a few additional circumstances
3672         https://bugs.webkit.org/show_bug.cgi?id=197145
3673         <rdar://problem/50078170>
3674
3675         Reviewed by Darin Adler.
3676
3677         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
3678         focus, or showing the font manager.
3679
3680         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3681         (TestWebKitAPI::TEST):
3682         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
3683         (TEST):
3684         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3685         (