[WTF] Drop Thread::create(obsolete things) API since we can use lambda
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
4         https://bugs.webkit.org/show_bug.cgi?id=173825
5
6         Reviewed by Saam Barati.
7
8         * DumpRenderTree/JavaScriptThreading.cpp:
9         (runJavaScriptThread):
10         (startJavaScriptThreads):
11         * DumpRenderTree/mac/DumpRenderTree.mm:
12         (runThread):
13         (runPthread):
14         (testThreadIdentifierMap):
15
16 2017-06-26  David Kilzer  <ddkilzer@apple.com>
17
18         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
19         <https://webkit.org/b/173837>
20
21         Reviewed by Geoffrey Garen.
22
23         The clang static analyzer can't reason about objects that are
24         assigned to a delegate as +1 retained, and then released
25         later in a different method when the delegate is cleared.
26
27         Instead, use a common idiom where the object setting the
28         delegate retains it as an instance variable on initialization.
29         Then the same object clears the delegate and releases its
30         instance variable during teardown.
31
32         Also add EXPECT_TRUE() tests to make sure the delegate objects
33         match before teardown.
34
35         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
36         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
37         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
38         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
39         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
40         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
41
42 2017-06-26  David Kilzer  <ddkilzer@apple.com>
43
44         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
45         <https://webkit.org/b/173836>
46
47         Reviewed by Brady Eidson.
48
49         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
50         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
51         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
52         objects in this test.
53
54 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
55
56         [ATK] Add support for aria-details and aria-errormessage
57         https://bugs.webkit.org/show_bug.cgi?id=172588
58
59         Reviewed by Chris Fleizach.
60
61         Add additional methods to test ARIA properties which are exposed via
62         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
63         to versions which support the details and error-message relation types.
64
65         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
66         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
67         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
68         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
69         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
70         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
71         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
72         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
73         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
74         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
75         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
76         * gtk/jhbuild.modules:
77
78 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
79
80         Unreviewed. Add libfii to GTK+ install dependencies script.
81
82         * gtk/install-dependencies:
83
84 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
85
86         Unreviewed, rolling out r215190.
87
88         Broke product select element on GNOME Bugzilla
89
90         Reverted changeset:
91
92         "[GTK] Misplaced right click menu on web page due to
93         deprecated gtk_menu_popup()"
94         https://bugs.webkit.org/show_bug.cgi?id=170553
95         http://trac.webkit.org/changeset/215190
96
97 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
98
99         Remove Reflect.enumerate
100         https://bugs.webkit.org/show_bug.cgi?id=173806
101
102         Reviewed by Yusuke Suzuki.
103
104         * Scripts/run-jsc-stress-tests:
105
106 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
107
108         AX: Cannot call setValue() on contenteditable or ARIA text controls
109         https://bugs.webkit.org/show_bug.cgi?id=173520
110
111         Reviewed by Ryosuke Niwa.
112
113         Add setValue() method to WKTR (already existed in DRT).
114
115         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
116         (WTR::AccessibilityUIElement::setValue):
117         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
118         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
119         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
120         (WTR::AccessibilityUIElement::setValue):
121
122 2017-06-23  Keith Miller  <keith_miller@apple.com>
123
124         Switch VMTraps to use halt instructions rather than breakpoint instructions
125         https://bugs.webkit.org/show_bug.cgi?id=173677
126
127         Reviewed by JF Bastien.
128
129         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
130         (TEST):
131
132 2017-06-23  Youenn Fablet  <youenn@apple.com>
133
134         Set getUserMedia permission to true by default on WTR
135         https://bugs.webkit.org/show_bug.cgi?id=173610
136
137         Reviewed by Alex Christensen.
138
139         Adding a way to reset the getUserMedia permission to pending.
140
141         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
142         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
143         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
144         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
146         (WTR::TestRunner::setUserMediaPermissionAsUnset):
147         * WebKitTestRunner/InjectedBundle/TestRunner.h:
148         * WebKitTestRunner/TestController.cpp:
149         (WTR::TestController::resetStateToConsistentValues):
150         (WTR::TestController::setUserMediaPermissionAsUnset):
151         * WebKitTestRunner/TestController.h:
152         * WebKitTestRunner/TestInvocation.cpp:
153         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
154
155 2017-06-23  Alex Christensen  <achristensen@webkit.org>
156
157         Add SPI to WKURLSchemeTask for redirection
158         https://bugs.webkit.org/show_bug.cgi?id=173730
159
160         Reviewed by Brady Eidson.
161
162         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
163         (-[SchemeHandler webView:startURLSchemeTask:]):
164         (-[SchemeHandler webView:stopURLSchemeTask:]):
165         (TEST):
166         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
167         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
168         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
169         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
170         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
171
172 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         [WPE] Use JSC API to send script messages from web extension in tests
175         https://bugs.webkit.org/show_bug.cgi?id=173757
176
177         Reviewed by Žan Doberšek.
178
179         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
180         to run postMessage().
181
182         Fixes: /wpe/WebKitSecurityManager/file-xhr
183                /wpe/WebKitConsoleMessage/console-api
184                /wpe/WebKitConsoleMessage/js-exception
185                /wpe/WebKitConsoleMessage/network-error
186                /wpe/WebKitConsoleMessage/security-error
187
188         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
189         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
190         (beforeAll): Ditto.
191         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
192         (testWebContextSecurityFileXHR): Ditto.
193         (beforeAll): Ditto.
194         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
195         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
196         (pageCreatedCallback): Remove ifdefs.
197
198 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
199
200         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
201
202         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
203         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
204         doesn't exist yet in WPE.
205
206         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
207         (testWebViewJavaScriptDialogs):
208         (testWebViewWindowProperties):
209
210 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
211
212         [GTK] Upgrade pixman and cairo in jhbuild
213         https://bugs.webkit.org/show_bug.cgi?id=173710
214
215         Reviewed by Carlos Alberto Lopez Perez.
216
217         * gtk/jhbuild.modules:
218
219 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
220
221         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
222         https://bugs.webkit.org/show_bug.cgi?id=173711
223
224         Reviewed by Carlos Alberto Lopez Perez.
225
226         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
227         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
228
229         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
230         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
231
232 2017-06-22  David Kilzer  <ddkilzer@apple.com>
233
234         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
235         <https://webkit.org/b/173721>
236
237         Reviewed by Joseph Pecoraro.
238
239         Use RetainPtr<> to create NSMutableDictionary and NSNumber
240         objects to fix leaks and to avoid the autoreleasepool.
241
242         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
243         (TEST):
244
245 2017-06-22  Matt Lewis  <jlewis3@apple.com>
246
247         Unreviewed, rolling out r218633.
248
249         The test is failing frequently on Sierra Debug and Windows
250
251         Reverted changeset:
252
253         "AX: Cannot call setValue() on contenteditable or ARIA text
254         controls"
255         https://bugs.webkit.org/show_bug.cgi?id=173520
256         http://trac.webkit.org/changeset/218633
257
258 2017-06-22  David Kilzer  <ddkilzer@apple.com>
259
260         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
261         <https://webkit.org/b/173690>
262
263         Reviewed by Chris Dumez.
264
265         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
266         ownership of malloc()-ed memory, then frees it when it's
267         released.  These tests were passing global variables into the
268         method, which is not malloc()-ed memory, which violates the API
269         contract.
270
271         The fix is to switch to use
272         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
273         NO for the last argument.
274
275         Caught by the clang static analyzer.
276
277         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
278         (TEST):
279         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
280         (TEST):
281
282 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
283
284         [GTK] Upgrade Harfbuzz to version 1.4.2
285         https://bugs.webkit.org/show_bug.cgi?id=173592
286
287         Reviewed by Carlos Alberto Lopez Perez.
288
289         * gtk/jhbuild.modules:
290
291 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
292
293         [WPE] Update WPEBackend-mesa
294         https://bugs.webkit.org/show_bug.cgi?id=173705
295
296         Reviewed by Carlos Alberto Lopez Perez.
297
298         A crash has been fixed, needed for unit tests to work.
299
300         * wpe/jhbuild.modules:
301
302 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
303
304         Remove unused coordinated graphics C API
305         https://bugs.webkit.org/show_bug.cgi?id=173706
306
307         Reviewed by Žan Doberšek.
308
309         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
310         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
311         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
312         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
313         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
314         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
315
316 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
317
318         [WPE] Build glib API tests
319         https://bugs.webkit.org/show_bug.cgi?id=173702
320
321         Reviewed by Žan Doberšek.
322
323         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
324         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
325         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
326         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
327         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
328         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
329         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
330         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
331         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
332         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
333         and implement the missing features.
334
335         * CMakeLists.txt:
336         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
337         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
338         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
339         (testAutomationSessionRequestSession):
340         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
341         (testWebKitWebViewSessionState):
342         (testWebKitWebViewSessionStateWithFormData):
343         (testWebKitWebViewNavigationAfterSessionRestore):
344         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
345         (beforeAll):
346         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
347         (testCookieManagerEphemeral):
348         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
349         (testBlobDownload):
350         (beforeAll):
351         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
352         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
353         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
354         (testProcessPerWebView):
355         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
356         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
357         (testWebViewCreateNavigationData):
358         (testWebViewJavaScriptDialogs):
359         (testWebViewWindowProperties):
360         (testWebViewMouseTarget):
361         (testWebViewGeolocationPermissionRequests):
362         (testWebViewUserMediaPermissionRequests):
363         (testWebViewAudioOnlyUserMediaPermissionRequests):
364         (testWebViewFileChooserRequest):
365         (beforeAll):
366         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
367         (beforeAll):
368         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
369         (testPrivateBrowsing):
370         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
371         (testFindControllerHide):
372         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
373         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
374         (testWebKitSettings):
375         (beforeAll):
376         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
377         (testWebViewNewWithUserContentManager):
378         (beforeAll):
379         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
380         (testWebContextEphemeral):
381         (testWebContextProxySettings):
382         (beforeAll):
383         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
384         (testWebViewWebContext):
385         (testWebViewWebContextLifetime):
386         (testWebViewEphemeral):
387         (testWebViewSettings):
388         (testWebViewCanShowMIMEType):
389         (testWebViewPageVisibility):
390         (testWebViewIsPlayingAudio):
391         (beforeAll):
392         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
393         (testWebsiteDataEphemeral):
394         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
395         (documentLoadedCallback):
396         (pageCreatedCallback):
397         (methodCallCallback):
398         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
399         * TestWebKitAPI/glib/CMakeLists.txt:
400         * TestWebKitAPI/glib/PlatformGTK.cmake:
401         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
402         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
403         (main):
404         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
405         (Test::adoptView):
406         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
407         (WebKitTestBus::run):
408         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
409         (WebViewTest::~WebViewTest):
410         (WebViewTest::initializeWebView):
411         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
412         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
413         (WebViewTest::platformDestroy):
414         (WebViewTest::platformInitializeWebView):
415         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
416         (WebViewTest::resizeView):
417         (WebViewTest::hideView):
418         (parentWindowMapped):
419         (WebViewTest::showInWindow):
420         (WebViewTest::showInWindowAndWaitUntilMapped):
421         (WebViewTest::mouseMoveTo):
422         (WebViewTest::clickMouseButton):
423         (WebViewTest::emitPopupMenuSignal):
424         (WebViewTest::keyStroke):
425         (WebViewTest::doMouseButtonEvent):
426         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
427         (WebViewTest::platformDestroy):
428         (WebViewTest::platformInitializeWebView):
429         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
430         (WebViewTest::resizeView):
431         (WebViewTest::hideView):
432         (WebViewTest::mouseMoveTo):
433         (WebViewTest::clickMouseButton):
434         (WebViewTest::keyStroke):
435
436 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
437
438         [GTK] Move WebKit2 GLib API tests to glib directories
439         https://bugs.webkit.org/show_bug.cgi?id=173642
440
441         Reviewed by Žan Doberšek.
442
443         * CMakeLists.txt:
444         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
445         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
446         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
447         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
448         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
449         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
450         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
451         (testWebKitConsoleMessageNetworkError):
452         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
453         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
454         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
455         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
456         (testLoadFromGResource):
457         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
458         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
459         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
460         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
461         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
462         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
463         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
464         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
465         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
466         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
467         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
468         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
469         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
470         (testWebViewRunJavaScript):
471         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
472         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
473         (registerGResource):
474         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
475         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
476         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
477         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
478         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
479         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
480         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
481         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
482         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
483         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
484         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
485         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
486         * TestWebKitAPI/glib/CMakeLists.txt: Added.
487         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
488         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
489         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
490         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
491         (registerGResource):
492         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
493         (Test::getResourcesDir):
494         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
495         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
496         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
497         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
498         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
499         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
500
501 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
502
503         [WPE] Add initial web extensions API
504         https://bugs.webkit.org/show_bug.cgi?id=173640
505
506         Reviewed by Žan Doberšek.
507
508         Add style checker exceptions for WPE web extensions API files.
509
510         * Scripts/webkitpy/style/checker.py:
511
512 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
515         https://bugs.webkit.org/show_bug.cgi?id=173659
516         <rdar://problem/32879788>
517
518         Reviewed by Tim Horton.
519
520         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
521
522         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
523
524         Augment this test page to log dragend and dragstart events on the drag source as well.
525
526         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
527         (checkStringArraysAreEqual):
528         (TestWebKitAPI::TEST):
529
530 2017-06-21  Antoine Quint  <graouts@apple.com>
531
532         Ensure DRT always logs rAF suspension debugging code
533         https://bugs.webkit.org/show_bug.cgi?id=173681
534
535         Reviewed by Tim "Mr. T" Horton.
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (resetWebPreferencesToConsistentValues):
539
540 2017-06-21  Chris Dumez  <cdumez@apple.com>
541
542         Allow constructing a WTF:Function from a function pointer
543         https://bugs.webkit.org/show_bug.cgi?id=173660
544
545         Reviewed by Alex Christensen.
546
547         Add API test coverage.
548
549         * TestWebKitAPI/Tests/WTF/Function.cpp:
550         (TestWebKitAPI::returnThree):
551         (TestWebKitAPI::returnFour):
552         (TestWebKitAPI::returnPassedValue):
553         (TestWebKitAPI::TEST):
554
555 2017-06-21  Antoine Quint  <graouts@apple.com>
556
557         Add logging to identify when the Page suspends scripted animations
558         https://bugs.webkit.org/show_bug.cgi?id=173626
559
560         Reviewed by Tim Horton.
561
562         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
563
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (resetWebPreferencesToConsistentValues):
566
567 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
568
569         AX: Cannot call setValue() on contenteditable or ARIA text controls
570         https://bugs.webkit.org/show_bug.cgi?id=173520
571
572         Reviewed by Ryosuke Niwa.
573
574         Add setValue() method to WKTR (already existed in DRT).
575
576         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
577         (WTR::AccessibilityUIElement::setValue):
578         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
579         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
580         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
581         (WTR::AccessibilityUIElement::setValue):
582
583 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
584
585         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
586         as one of the dependencies required to build the product.
587
588         Rubber-stamped by Carlos Garcia Campos.
589
590         * gtk/install-dependencies:
591         * wpe/install-dependencies:
592
593 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
594
595         Disable font variations on macOS Sierra and iOS 10
596         https://bugs.webkit.org/show_bug.cgi?id=173618
597         <rdar://problem/32879164>
598
599         Reviewed by Jon Lee.
600
601         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
602
603 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
604
605         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
606         https://bugs.webkit.org/show_bug.cgi?id=173578
607         <rdar://problem/32825028>
608
609         Reviewed by Tim Horton.
610
611         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
612         a custom popover does not cause dragging to fail when the popover is presented.
613
614         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
615         (-[DataInteractionSimulator _advanceProgress]):
616
617 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
618
619         [WPE] Add initial implementation of glib API
620         https://bugs.webkit.org/show_bug.cgi?id=173546
621
622         Reviewed by Žan Doberšek.
623
624         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
625         include WPE glib API files.
626
627         * Scripts/webkitperl/FeatureList.pm:
628         * Scripts/webkitpy/style/checker.py:
629         * Scripts/webkitpy/style/checkers/cpp.py:
630         (check_identifier_name_in_declaration):
631
632 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
633
634         [GTK] Upgrade to ICU to version 57.1
635         https://bugs.webkit.org/show_bug.cgi?id=173538
636
637         Reviewed by Žan Doberšek.
638
639         * gtk/jhbuild.modules:
640
641 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
642
643         [GTK] Remove unneeded modules from the jhbuild
644         https://bugs.webkit.org/show_bug.cgi?id=170540
645
646         Reviewed by Michael Catanzaro.
647
648         We are building libxslt and libffi that we don't really need to build from sources.
649
650         * gtk/jhbuild.modules:
651
652 2017-06-19  Frederic Wang  <fwang@igalia.com>
653
654         [Mac] Add an experimental feature setting for async frame scrolling
655         https://bugs.webkit.org/show_bug.cgi?id=173359
656
657         Reviewed by Simon Fraser.
658
659         * DumpRenderTree/mac/DumpRenderTree.mm:
660         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
661         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
662         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
663         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
664
665 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
666
667         Unreviewed, adding myself to contributors.json
668
669         * Scripts/webkitpy/common/config/contributors.json:
670
671 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
672
673         test262: Completion values for control flow do not match the spec
674         https://bugs.webkit.org/show_bug.cgi?id=171265
675
676         Reviewed by Saam Barati.
677
678         * Scripts/run-jsc-stress-tests:
679         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
680
681 2017-06-19  Zalan Bujtas  <zalan@apple.com>
682
683         Opening certain mails brings up a mail that grows indefinitely.
684         https://bugs.webkit.org/show_bug.cgi?id=173562
685         <rdar://problem/32766579>
686
687         Reviewed by Tim Horton.
688
689         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
690         (TEST):
691
692 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
693
694         [iOS DnD] Support .zip archives for file uploads via drag and drop
695         https://bugs.webkit.org/show_bug.cgi?id=173511
696         <rdar://problem/32521025>
697
698         Reviewed by Tim Horton.
699
700         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
701         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
702
703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
704         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
705         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
706         (testZIPArchive):
707         (TestWebKitAPI::TEST):
708
709 2017-06-18  Darin Adler  <darin@apple.com>
710
711         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
712         https://bugs.webkit.org/show_bug.cgi?id=173526
713
714         Reviewed by Sam Weinig.
715
716         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
718
719         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
720         tests for assignment before destruction ones.
721
722         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
723         as a function, so it can be used in WTF::Function tests.
724
725         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
726         Added tests for swap and for assignment before deref.
727
728         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
729         to inline everything. Also removed the unnecessary clearing of the log every time
730         the DerivedRefLogger constructor is called.
731         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
732
733         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
734         Added tests for assignment before deref and similar for releaseNonNull.
735
736 2017-06-19  Sam Weinig  <sam@webkit.org>
737
738         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
739         https://bugs.webkit.org/show_bug.cgi?id=173513
740
741         Reviewed by Alex Christensen.
742
743         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
744         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
745         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
746
747 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
748
749         [Win] fast/dom/assign-to-window-status.html is flaky.
750         https://bugs.webkit.org/show_bug.cgi?id=173512
751
752         Reviewed by Alex Christensen.
753
754         We should not dump status callbacks when test is done.
755
756         * DumpRenderTree/win/UIDelegate.cpp:
757         (UIDelegate::setStatusText):
758
759 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
760
761         [WPE][JHBuild] Update WPEBackend-mesa
762         https://bugs.webkit.org/show_bug.cgi?id=173433
763
764         Unreviewed.
765
766         Update WPEBackend-mesa back (like it was done originally in r218344)
767         after fixing the issue with the DISPLAY environment variables that
768         caused the crashes.
769
770         * wpe/jhbuild.modules:
771
772 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
773
774         Rename unit test file after r218482
775         https://bugs.webkit.org/show_bug.cgi?id=173483
776
777         Unreviewed.
778
779         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
780
781 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
782
783         Unreviewed. Fix wrong style checker condition added in r218487.
784
785         * Scripts/webkitpy/style/checkers/cpp.py:
786         (check_identifier_name_in_declaration):
787
788 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
789
790         Missing <functional> includes make builds fail with GCC 7.x
791         https://bugs.webkit.org/show_bug.cgi?id=173544
792
793         Unreviewed gardening.
794
795         Fix compilation with GCC 7.
796
797         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
798         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
799
800 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         [GTK] Move GTK+ API files that could be shared to glib dirs
803         https://bugs.webkit.org/show_bug.cgi?id=173545
804
805         Reviewed by Žan Doberšek.
806
807         Update paths of GTK+ API in watchlist and style checker.
808
809         * Scripts/webkitpy/common/config/watchlist:
810         * Scripts/webkitpy/style/checker.py:
811         * Scripts/webkitpy/style/checkers/cpp.py:
812         (check_identifier_name_in_declaration):
813
814 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
815
816         Port setup_environ_for_server should not set environment variables related with the driver.
817         https://bugs.webkit.org/show_bug.cgi?id=173483
818
819         Reviewed by Carlos Garcia Campos.
820
821         The port setup_environ_for_server() should not set environment variables
822         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
823         This varibles should be only set on the driver setup_environ_for_test().
824
825         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
826         into the test environment even when running the tests with a driver
827         that is not the Xorg or Xvfb one.
828
829         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
830         (Port.to.setup_environ_for_server):
831         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
832         (Driver._setup_environ_for_driver):
833         * Scripts/webkitpy/port/driver_unittest.py:
834         (DriverTest.test_setup_environ_for_test):
835         (DriverTest):
836         (DriverTest.test_setup_environ_base_vars):
837         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
838         (GtkPort.setup_environ_for_server):
839         * Scripts/webkitpy/port/wayland_unittest.py: Added.
840         (WaylandDriverTest):
841         (WaylandDriverTest.make_driver):
842         (WaylandDriverTest.make_environment):
843         (WaylandDriverTest.test_checkdriver):
844         (WaylandDriverTest.test_environment_needed_variables):
845         (WaylandDriverTest.test_environment_forbidden_variables):
846         (WaylandDriverTest.test_environment_optional_variables):
847         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
848         (WaylandDriver.check_driver):
849         (WaylandDriver._setup_environ_for_test):
850         * Scripts/webkitpy/port/xorgdriver.py:
851         (XorgDriver.check_driver):
852         (XorgDriver._setup_environ_for_test):
853         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
854         (XorgDriverTest):
855         (XorgDriverTest.make_driver):
856         (XorgDriverTest.make_environment):
857         (XorgDriverTest.test_checkdriver):
858         (XorgDriverTest.test_environment_needed_variables):
859         (XorgDriverTest.test_environment_forbidden_variables):
860         (XorgDriverTest.test_environment_optional_variables):
861         * Scripts/webkitpy/port/xvfbdriver.py:
862         (XvfbDriver._setup_environ_for_test):
863         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
864         (XvfbDriverTest.assertDriverStartSuccessful):
865
866
867 2017-05-14 Frederic Wang  <fwang@igalia.com>
868
869         Add heuristic to avoid flattening "fullscreen" iframes
870         https://bugs.webkit.org/show_bug.cgi?id=171914
871
872         Reviewed by Simon Fraser.
873
874         * DumpRenderTree/mac/DumpRenderTree.mm:
875         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
876
877 2017-06-18  Chris Dumez  <cdumez@apple.com>
878
879         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
880         https://bugs.webkit.org/show_bug.cgi?id=173522
881         <rdar://problem/31185739>
882
883         Reviewed by Darin Adler.
884
885         Add API test for re-entering Function's assignment operators.
886
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
889         (TestWebKitAPI::TestObject::TestObject):
890         (TestWebKitAPI::TestObject::~TestObject):
891         (TestWebKitAPI::TestObject::operator()):
892         (TestWebKitAPI::TEST):
893
894 2017-06-16  Dan Bernstein  <mitz@apple.com>
895
896         [Cocoa] Some declarations have missing or incorrect availability attributes
897         https://bugs.webkit.org/show_bug.cgi?id=173508
898
899         Reviewed by Tim Horton.
900
901         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
902         (TestWebKitAPI::TEST): Updated for renames.
903
904 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
905
906         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
907         https://bugs.webkit.org/show_bug.cgi?id=173366
908         <rdar://problem/32767014>
909
910         Reviewed by Tim Horton.
911
912         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
913         change in behavior.
914
915         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
917         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
918         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
919         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
920         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
921         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
922         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
923         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
924         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
925         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
926         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
927         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
928         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
929         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
930         (-[MockDragDropSession initWithItems:location:window:]):
931         (-[MockDragDropSession allowsMoveOperation]):
932         (-[MockDragDropSession isRestrictedToDraggingApplication]):
933         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
934         (-[MockDragDropSession canLoadObjectsOfClass:]):
935         (-[MockDragDropSession canLoadObjectsOfClasses:]):
936         (-[MockDragDropSession items]):
937         (-[MockDragDropSession setItems:]):
938         (-[MockDragDropSession locationInView:]):
939         (-[MockDataOperationSession initWithProviders:location:window:]):
940         (-[MockDataOperationSession session]):
941         (-[MockDataOperationSession isLocal]):
942         (-[MockDataOperationSession progress]):
943         (-[MockDataOperationSession setProgressIndicatorStyle:]):
944         (-[MockDataOperationSession progressIndicatorStyle]):
945         (-[MockDataOperationSession operationMask]):
946         (-[MockDataOperationSession localDragSession]):
947         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
948         (-[MockDataOperationSession canCreateItemsOfClass:]):
949         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
950         (-[MockDataInteractionSession initWithWindow:]):
951         (-[MockDataInteractionSession localOperationMask]):
952         (-[MockDataInteractionSession externalOperationMask]):
953         (-[MockDataInteractionSession session]):
954         (-[DataInteractionSimulator _advanceProgress]):
955
956 2017-06-16  Alex Christensen  <achristensen@webkit.org>
957
958         Show punycode to user if a URL has dotless i or j followed by diacritic dot
959         https://bugs.webkit.org/show_bug.cgi?id=173431
960
961         Reviewed by Darin Adler.
962
963         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
964         (TestWebKitAPI::TEST):
965
966 2017-06-16  Chris Dumez  <cdumez@apple.com>
967
968         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
969         https://bugs.webkit.org/show_bug.cgi?id=173472
970         <rdar://problem/28858817>
971
972         Reviewed by Brady Eidson.
973
974         Add API test coverage.
975
976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
977         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
978         (TEST):
979
980 2017-06-16  Brady Eidson  <beidson@apple.com>
981
982         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
983         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
984
985         Reviewed by Daniel Bates.
986
987         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
988
989 2017-06-16  Chris Dumez  <cdumez@apple.com>
990
991         DRT fails to reset page visibility between tests
992         https://bugs.webkit.org/show_bug.cgi?id=173485
993
994         Reviewed by Alexey Proskuryakov.
995
996         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
997         Fix this to address flakiness.
998
999         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1000         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1001         The test became flaky without the DRT change and was no longer flaky with the DRT
1002         change.
1003
1004         WebKitTestRunner already does this.
1005
1006         * DumpRenderTree/mac/DumpRenderTree.mm:
1007         (resetWebViewToConsistentStateBeforeTesting):
1008
1009 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1010
1011         Implement basic authentication in MiniBrowser
1012         https://bugs.webkit.org/show_bug.cgi?id=173443
1013
1014         Reviewed by Tim Horton.
1015
1016         * MiniBrowser/mac/WK2BrowserWindowController.m:
1017         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1018
1019 2017-06-16  Jer Noble  <jer.noble@apple.com>
1020
1021         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1022         https://bugs.webkit.org/show_bug.cgi?id=173398
1023         <rdar://problem/32592961>
1024
1025         Reviewed by Eric Carlson.
1026
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1029         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1030         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1031         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1032         (TestWebKitAPI::TEST):
1033         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1034
1035 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1036
1037         Unreviewed, rolling out r218375.
1038
1039         The API test MediaStreamTrackDetached is still timing out
1040         after the patch
1041
1042         Reverted changeset:
1043
1044         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1045         reports no recording to WebKit clients"
1046         https://bugs.webkit.org/show_bug.cgi?id=173398
1047         http://trac.webkit.org/changeset/218375
1048
1049 2017-06-15  Jer Noble  <jer.noble@apple.com>
1050
1051         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1052         https://bugs.webkit.org/show_bug.cgi?id=173398
1053         <rdar://problem/32592961>
1054
1055         Reviewed by Eric Carlson.
1056
1057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1059         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1060         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1061         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1062         (TestWebKitAPI::TEST):
1063         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1064
1065 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1066
1067         Unreviewed, rolling out r218365.
1068
1069         The revision caused API timeouts on all builds.
1070
1071         Reverted changeset:
1072
1073         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1074         reports no recording to WebKit clients"
1075         https://bugs.webkit.org/show_bug.cgi?id=173398
1076         http://trac.webkit.org/changeset/218365
1077
1078 2017-06-15  Jer Noble  <jer.noble@apple.com>
1079
1080         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1081         https://bugs.webkit.org/show_bug.cgi?id=173398
1082         <rdar://problem/32592961>
1083
1084         Reviewed by Eric Carlson.
1085
1086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1087         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1088         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1089         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1090         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1091         (TestWebKitAPI::TEST):
1092         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1093
1094 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1095
1096         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1097         https://bugs.webkit.org/show_bug.cgi?id=173433
1098
1099         Unreviewed.
1100
1101         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1102
1103 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1104
1105         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1106         https://bugs.webkit.org/show_bug.cgi?id=173061
1107
1108         Reviewed by Žan Doberšek.
1109
1110         Launch dyz <https://github.com/Igalia/dyz> with the script
1111         run-minibrowser for the wpe port. It is now built as part of the
1112         WPE dependencies with JHBuild.
1113
1114         * Scripts/run-minibrowser:
1115         * Scripts/webkitdirs.pm:
1116         (launcherPath):
1117         (launcherName):
1118         * wpe/install-dependencies: Luajit is needed for building dyz.
1119         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1120
1121 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1122
1123         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1124         https://bugs.webkit.org/show_bug.cgi?id=173338
1125         <rdar://problem/32777720>
1126
1127         Reviewed by Tim Horton.
1128
1129         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1130         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1131         these remaining items on drop.
1132
1133         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1134         (TestWebKitAPI::TEST):
1135         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1136         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1137
1138         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1139
1140         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1141
1142 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1143
1144         [Win] Crash in accessibility layout test.
1145         https://bugs.webkit.org/show_bug.cgi?id=173401
1146
1147         Reviewed by Brent Fulgham.
1148
1149         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1150         member will be automatically released when the _variant_t object goes out of scope if the vt member
1151         does not equal VT_UNKNOWN | VT_BYREF.
1152         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1153
1154         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1155         (AccessibilityUIElement::titleUIElement):
1156
1157 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1158
1159         [GTK] Add API to allow overriding popup menus
1160         https://bugs.webkit.org/show_bug.cgi?id=172905
1161
1162         Reviewed by Michael Catanzaro.
1163
1164         Add a unit test to check the new API.
1165
1166         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1167         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1168         (OptionMenuTest::OptionMenuTest):
1169         (OptionMenuTest::~OptionMenuTest):
1170         (OptionMenuTest::destroyMenu):
1171         (OptionMenuTest::showOptionMenuCallback):
1172         (OptionMenuTest::menuCloseCallback):
1173         (OptionMenuTest::showOptionMenu):
1174         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1175         (OptionMenuTest::close):
1176         (OptionMenuTest::activateItem):
1177         (OptionMenuTest::selectItem):
1178         (testOptionMenuSimple):
1179         (testOptionMenuGroups):
1180         (testOptionMenuActivate):
1181         (testOptionMenuSelect):
1182         (beforeAll):
1183         (afterAll):
1184
1185 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1186
1187         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1188         https://bugs.webkit.org/show_bug.cgi?id=173399
1189
1190         Reviewed by Per Arne Vollan.
1191
1192         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1193         Curl port needs to do nothing because libcurl doesn't have disk cache.
1194
1195         * DumpRenderTree/win/DumpRenderTree.cpp:
1196         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1197         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1198
1199 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1200
1201         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1202         https://bugs.webkit.org/show_bug.cgi?id=173356
1203
1204         Reviewed by Michael Catanzaro.
1205
1206         Use the correct operator to compare the strings.
1207
1208         * gtk/install-dependencies:
1209
1210 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1211
1212         Unreviewed, rolling out r218285.
1213         https://bugs.webkit.org/show_bug.cgi?id=173391
1214
1215         API test fails on iOS (Requested by alexchristensen on
1216         #webkit).
1217
1218         Reverted changeset:
1219
1220         "Add SPI for immediate injection of user scripts"
1221         https://bugs.webkit.org/show_bug.cgi?id=173342
1222         http://trac.webkit.org/changeset/218285
1223
1224 2017-06-14  Chris Dumez  <cdumez@apple.com>
1225
1226         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1227         https://bugs.webkit.org/show_bug.cgi?id=173384
1228         <rdar://problem/32723779>
1229
1230         Reviewed by Dan Bernstein.
1231
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1233         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1234         Add API test coverage.
1235
1236         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1237         (TestWebKitAPI::Util::sleep):
1238         Update implementation of Util::sleep() so that we actually run the run loop.
1239         Otherwise, we don't process events while sleeping.
1240
1241 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1242
1243         Add SPI for immediate injection of user scripts
1244         https://bugs.webkit.org/show_bug.cgi?id=173342
1245         <rdar://problem/29202285>
1246
1247         Reviewed by Brady Eidson.
1248
1249         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1250         (waitForMessage):
1251         (TEST):
1252
1253 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1254
1255         Add WPE to the flakiness dashboard
1256         https://bugs.webkit.org/show_bug.cgi?id=173365
1257
1258         Reviewed by Carlos Alberto Lopez Perez.
1259
1260         * TestResultServer/static-dashboards/builders.jsonp:
1261         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1262         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1263         (resetGlobals):
1264         * TestResultServer/static-dashboards/loader_unittests.js:
1265
1266 2017-06-14  Brady Eidson  <beidson@apple.com>
1267
1268         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1269         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1270
1271         Reviewed by Alex Christensen.
1272
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1275         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1276         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1277         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1278         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1279         (TEST):
1280
1281 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1282
1283         WKContentViewEditingActions API test always fails
1284         https://bugs.webkit.org/show_bug.cgi?id=173374
1285
1286         Reviewed by Wenson Hsieh.
1287
1288         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1289         (TEST):
1290         selectAll isn't working, because canPerformAction for selectAll returns NO
1291         if selectionIsNone (which is true in the non-contenteditable case).
1292         Instead, make use of r218180's test page, which knows how to select itself.
1293         Also, reset the pasteboard at the beginning of the test to reduce confusion
1294         (I landed the test broken because my simulator had the correct text
1295         stuck in its pasteboard).
1296
1297 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1298
1299         Configure screen scale for running layout tests on plus devices
1300         https://bugs.webkit.org/show_bug.cgi?id=173319
1301
1302         Reviewed by Tim Horton.
1303
1304         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (dumpRenderTree): Set screen scale to 2.0.
1307         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1308         add _setScale for UIScreen.
1309         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1310         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1311         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1312         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1313         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1314         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1315         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1316         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1317         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1318         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1319
1320 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1321
1322         Add iOS 11 support to the bot watcher's dashboard
1323         https://bugs.webkit.org/show_bug.cgi?id=173369
1324
1325         Reviewed by Lucas Forschler.
1326
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1333
1334 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1335
1336         [GTK][WPE] Raise the timeout values for layout tests
1337         https://bugs.webkit.org/show_bug.cgi?id=173368
1338
1339         Reviewed by Carlos Garcia Campos.
1340
1341         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1342         When running under valgrind a 10x multiplier is applied.
1343
1344         * Scripts/webkitpy/port/gtk.py:
1345         (GtkPort.default_timeout_ms):
1346         * Scripts/webkitpy/port/gtk_unittest.py:
1347         (GtkPortTest.test_default_timeout_ms):
1348         * Scripts/webkitpy/port/wpe.py:
1349         (WPEPort.default_timeout_ms):
1350         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1351         (WPEPortTest):
1352         (WPEPortTest.make_port):
1353         (WPEPortTest.test_default_timeout_ms):
1354         (WPEPortTest.test_get_crash_log):
1355
1356 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1357
1358         Test persistent WKHTTPCookieStorages on iOS.
1359         https://bugs.webkit.org/show_bug.cgi?id=173284
1360
1361         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1362         (TEST):
1363         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1364
1365 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1366
1367         [Win] DRT should not use disk cache.
1368         https://bugs.webkit.org/show_bug.cgi?id=173361
1369
1370         Reviewed by Darin Adler.
1371
1372         Like on macOS/iOS, DRT on Windows should only use memory cache.
1373
1374         * DumpRenderTree/win/DumpRenderTree.cpp:
1375         (setDefaultsToConsistentValuesForTesting):
1376         (prepareConsistentTestingEnvironment):
1377
1378 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1379
1380         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1381         https://bugs.webkit.org/show_bug.cgi?id=171668
1382
1383         Reviewed by Jer Noble.
1384
1385         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1386         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1387         Infinity when the double value passed as argument is greater than 2^64.
1388
1389         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1390         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1391         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1392         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1393         method. No behavior change for rational MediaTime.
1394
1395         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1396         (TestWebKitAPI::TEST):
1397
1398 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1399
1400         Test persistent WKHTTPCookieStorages on iOS
1401         https://bugs.webkit.org/show_bug.cgi?id=173284
1402         <rdar://problem/32260156>
1403
1404         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1405         (TEST):
1406
1407 2017-06-13  Matt Rajca  <mrajca@apple.com>
1408
1409         WebsitePolicies: let clients select specific autoplay quirks
1410         https://bugs.webkit.org/show_bug.cgi?id=173343
1411
1412         Reviewed by Alex Christensen.
1413
1414         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1415         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1416         (TEST): Updated tests.
1417
1418 2017-06-13  Daniel Bates  <dabates@apple.com>
1419
1420         Implement W3C Secure Contexts Draft Specification
1421         https://bugs.webkit.org/show_bug.cgi?id=158121
1422         <rdar://problem/26012994>
1423
1424         Reviewed by Brent Fulgham.
1425
1426         Part 4
1427
1428         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1429         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1430         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1431
1432         * DumpRenderTree/TestOptions.h:
1433         * DumpRenderTree/TestOptions.mm:
1434         (TestOptions::TestOptions):
1435         * DumpRenderTree/mac/DumpRenderTree.mm:
1436         (setWebPreferencesForTestOptions):
1437         * DumpRenderTree/win/DumpRenderTree.cpp:
1438         (enableExperimentalFeatures):
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::TestController::resetPreferencesToConsistentValues):
1441         (WTR::updateTestOptionsFromTestHeader):
1442         * WebKitTestRunner/TestOptions.h:
1443         (WTR::TestOptions::hasSameInitializationOptions):
1444
1445 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1446
1447         Test persistent WKHTTPCookieStorages on iOS
1448         https://bugs.webkit.org/show_bug.cgi?id=173284
1449         <rdar://problem/32260156>
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1454         (TEST):
1455
1456 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1457
1458         [GTK] Blob download doesn't work
1459         https://bugs.webkit.org/show_bug.cgi?id=172442
1460
1461         Reviewed by Carlos Alberto Lopez Perez.
1462
1463         Add a unit test to check blob downloads.
1464
1465         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1466         (testBlobDownload):
1467         (beforeAll):
1468
1469 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1470
1471         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
1472         https://bugs.webkit.org/show_bug.cgi?id=173316
1473
1474         Reviewed by Alex Christensen.
1475
1476         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
1477
1478         * gtk/manifest.txt.in:
1479
1480 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1481
1482         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
1483         https://bugs.webkit.org/show_bug.cgi?id=173315
1484
1485         Reviewed by Darin Adler.
1486
1487         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
1488         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
1489         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
1490         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
1491         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
1492         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
1493         WKGeolocationManagerRef is not destroyed.
1494
1495         * WebKitTestRunner/GeolocationProviderMock.cpp:
1496         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1497         * WebKitTestRunner/GeolocationProviderMock.h:
1498
1499 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1500
1501         Unable to paste text that was copied from a page into the universal search field
1502         https://bugs.webkit.org/show_bug.cgi?id=173293
1503         <rdar://problem/32440918>
1504
1505         Reviewed by Ryosuke Niwa.
1506
1507         Adds 2 new unit tests for copying plain and rich selected web content.
1508         See WebCore and WebKit ChangeLogs for more detail.
1509
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
1512         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
1513         (TestWebKitAPI::dataForPasteboardType):
1514         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1515         (TestWebKitAPI::TEST):
1516
1517 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
1518
1519         AX: [ATK] Implement missing AtkRelation types
1520         https://bugs.webkit.org/show_bug.cgi?id=155494
1521
1522         Reviewed by Darin Adler.
1523
1524         Add additional methods to test ARIA properties which are exposed via
1525         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
1526
1527         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1528         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1529         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1530         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1531         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1532         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1533         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1534         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1535         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1536         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1537         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1538         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1539         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1540         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1541         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1542         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1543         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1544         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1545
1546 2017-06-12  Daniel Bates  <dabates@apple.com>
1547
1548         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
1549         https://bugs.webkit.org/show_bug.cgi?id=173286
1550         <rdar://problem/32726102>
1551
1552         Reviewed by Brent Fulgham.
1553
1554         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1555         (TestWebKitAPI::TEST_F):
1556
1557 2017-06-12  Lucas Forschler  <lforschler@apple.com>
1558
1559         <rdar://problem/32683422>
1560         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
1561
1562         Reviewed by Conrad Schultz.
1563
1564         * Scripts/copy-webkitlibraries-to-product-directory:
1565
1566 2017-06-12  Tim Horton  <timothy_horton@apple.com>
1567
1568         [iOS] Cmd-C doesn't copy text from WKWebView
1569         https://bugs.webkit.org/show_bug.cgi?id=173277
1570         <rdar://problem/32396742>
1571
1572         Reviewed by Dan Bernstein.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1576         Add a test ensuring that -copy on WKContentView will cause text to be copied.
1577
1578 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1579
1580         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1581         https://bugs.webkit.org/show_bug.cgi?id=173197
1582         <rdar://problem/32688148>
1583
1584         Reviewed by Brent Fulgham.
1585
1586         * DumpRenderTree/mac/DumpRenderTree.mm:
1587         (enableExperimentalFeatures):
1588         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1589         (WTR::InjectedBundle::beginTesting):
1590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1591         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1592         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1593
1594 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1595
1596         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1597         https://bugs.webkit.org/show_bug.cgi?id=173238
1598         <rdar://problem/31943370>
1599
1600         Reviewed by Ryosuke Niwa and Tim Horton.
1601
1602         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1603         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1604         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1605
1606         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1607         (TestWebKitAPI::TEST):
1608         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1609         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1610         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1611         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1612
1613 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1614
1615         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1616         https://bugs.webkit.org/show_bug.cgi?id=173225
1617         <rdar://problem/32713144>
1618
1619         Reviewed by Tim Horton.
1620
1621         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1622         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1623
1624         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1625         (TestWebKitAPI::TEST):
1626
1627 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1628
1629         Return correct process names for iOS on-device testing
1630         https://bugs.webkit.org/show_bug.cgi?id=173263
1631
1632         Reviewed by Alex Christensen.
1633
1634         When running tests on iOS devices, process names do not end with '.Development'
1635         as they do on Mac and iOS simulator.
1636
1637         * WebKitTestRunner/TestController.cpp:
1638         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1639         for iOS on-device testing.
1640         (WTR::TestController::networkProcessName): Ditto.
1641         (WTR::TestController::databaseProcessName): Ditto.
1642
1643 2017-06-12  Chris Dumez  <cdumez@apple.com>
1644
1645         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1646         https://bugs.webkit.org/show_bug.cgi?id=173267
1647         <rdar://problem/32701257>
1648
1649         Reviewed by Simon Fraser.
1650
1651         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1652         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1653         though as this covers the crash that r217867 was fixing.
1654
1655         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1656         (TestWebKitAPI::createSessionStateData):
1657         (TestWebKitAPI::TEST):
1658         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1659
1660 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         [GTK] Stop dismissing menus attached to the web view for every injected event
1663         https://bugs.webkit.org/show_bug.cgi?id=172708
1664
1665         Reviewed by Alex Christensen.
1666
1667         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1668         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1669         events while the menu is open.
1670
1671         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1672         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1673         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1674         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1675
1676 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1677
1678         [GTK][WPE] Enable GStreamer GL on development builds
1679         https://bugs.webkit.org/show_bug.cgi?id=173248
1680
1681         Enable GStreamer GL for GTK and WPE.
1682
1683         Reviewed by Carlos Garcia Campos.
1684
1685         * Scripts/webkitperl/FeatureList.pm:
1686
1687 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1688
1689         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1690
1691         Notifications are no longer cleared on page navigation.
1692
1693         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1694         (testWebViewNotification):
1695
1696 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1697
1698         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1699
1700         DBus interface and object path names were updated in r217831.
1701
1702         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1703
1704 2017-06-10  Dan Bernstein  <mitz@apple.com>
1705
1706         Reverted r218056 because it made the IDE reindex constantly.
1707
1708         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1709         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1710         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1711         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1712         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1713         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1714         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1715         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1716
1717 2017-06-10  Dan Bernstein  <mitz@apple.com>
1718
1719         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1720         https://bugs.webkit.org/show_bug.cgi?id=173223
1721
1722         Reviewed by Sam Weinig.
1723
1724         The rebuilds were happening due to a difference in the compiler options that the IDE and
1725         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1726         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1727         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1728
1729         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1730         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1731         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1732         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1733         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1734         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1735         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1736         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1737
1738 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1739
1740         webkitpy: Reduce polling in ServerProcess
1741         https://bugs.webkit.org/show_bug.cgi?id=173116
1742
1743         Reviewed by Ryosuke Niwa.
1744
1745         We should be smarter about polling. We do not need to poll every time a line is read from
1746         stdout and stderr since lines are usually read from cached data. We should only poll
1747         when extracting that cached data from stdout and stderr.
1748
1749         * Scripts/webkitpy/port/driver.py:
1750         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1751         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1752         * Scripts/webkitpy/port/driver_unittest.py:
1753         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1754         ServerProcess.
1755         * Scripts/webkitpy/port/server_process.py:
1756         (ServerProcess._read): Allow for data to be read from _output even if the process has
1757         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1758         * Scripts/webkitpy/port/server_process_mock.py:
1759         (MockServerProcess): Add number_of_times_polled.
1760         (MockServerProcess.poll): Increment number_of_times_polled.
1761         (MockServerProcess.has_crashed): Poll before returning crash state.
1762         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1763         just like a ServerProcess would.
1764         (MockServerProcess.read_stdout): Ditto.
1765         * Scripts/webkitpy/port/server_process_unittest.py:
1766         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1767         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1768         (TestServerProcess):
1769         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1770         the processes is polled.
1771         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1772         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1773
1774 2017-06-10  Andy Estes  <aestes@apple.com>
1775
1776         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1777         https://bugs.webkit.org/show_bug.cgi?id=173190
1778         <rdar://problem/31360659>
1779
1780         Reviewed by Brady Eidson.
1781         
1782         Added a release assert that tries to create a proper test failure if the web process crashes.
1783
1784         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1785         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1786
1787 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1788
1789         [iOS DnD] Add a hook to perform two-step drops in editable content
1790         https://bugs.webkit.org/show_bug.cgi?id=172992
1791         <rdar://problem/32590174>
1792
1793         Reviewed by Tim Horton.
1794
1795         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
1796         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
1797                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
1798
1799         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1800         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1801         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
1802
1803         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
1804         be overridden. Currently, this is overridden to just return true.
1805
1806         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1807         (TestWebKitAPI::TEST):
1808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1809         (WTR::InjectedBundlePage::InjectedBundlePage):
1810
1811 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1812
1813         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
1814         https://bugs.webkit.org/show_bug.cgi?id=173103
1815
1816         Reviewed by Xabier Rodriguez-Calvar.
1817
1818         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
1819         when building the WPE port through build-webkit.
1820
1821 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1822
1823         [WPE] Enable MEDIA_SOURCE for build-webkit builds
1824         https://bugs.webkit.org/show_bug.cgi?id=173136
1825
1826         Reviewed by Xabier Rodriguez-Calvar.
1827
1828         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
1829
1830 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1831
1832         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
1833         https://bugs.webkit.org/show_bug.cgi?id=173098
1834
1835         Reviewed by Žan Doberšek.
1836
1837         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
1838         assuming that all tests containing forms define ids for the form elements like
1839         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
1840
1841         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1842         (formControlsAssociatedCallback):
1843
1844 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
1845
1846         webkitpy: Run sample/spindump on iOS devices
1847         https://bugs.webkit.org/show_bug.cgi?id=171881
1848         <rdar://problem/32084602>
1849
1850         Reviewed by Daniel Bates.
1851
1852         * Scripts/webkitpy/port/darwin.py:
1853         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
1854         requires sudo to run spindump.
1855         * Scripts/webkitpy/port/ios_device.py:
1856         (IOSDevicePort.look_for_new_samples): Deleted.
1857         (IOSDevicePort.sample_process): Deleted.
1858         * Scripts/webkitpy/port/ios_device_unittest.py:
1859         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
1860         (IOSDeviceTest.test_spindump):
1861         (IOSDeviceTest.test_sample_process):
1862         (IOSDeviceTest.test_sample_process_exception):
1863         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1864         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
1865
1866 2017-06-08  Keith Miller  <keith_miller@apple.com>
1867
1868         WebAssembly: We should only create wrappers for functions that can be exported
1869         https://bugs.webkit.org/show_bug.cgi?id=173088
1870
1871         Reviewed by Saam Barati.
1872
1873         Add quick mode for wasm tests.
1874
1875         * Scripts/run-jsc-stress-tests:
1876
1877 2017-06-08  Darin Adler  <darin@apple.com>
1878
1879         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
1880         https://bugs.webkit.org/show_bug.cgi?id=173106
1881
1882         Reviewed by Sam Weinig.
1883
1884         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
1885         destroyed last.
1886         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
1887         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1888
1889 2017-06-07  Dan Bernstein  <mitz@apple.com>
1890
1891         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
1892         https://bugs.webkit.org/show_bug.cgi?id=173086
1893
1894         Reviewed by Andy Estes.
1895
1896         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1897         (TEST):
1898
1899 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
1900
1901         Add High Sierra support to WebKit tools
1902         https://bugs.webkit.org/show_bug.cgi?id=173080
1903
1904         Rubber-stamped by Daniel Bates.
1905
1906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
1907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1910         Added dashboard support.
1911
1912         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1913         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1914         Trigger the right build queues on check-in.
1915
1916         * Scripts/webkitpy/common/system/platforminfo.py:
1917         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1918         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1919         * Scripts/webkitpy/port/mac.py:
1920         * Scripts/webkitpy/port/mac_unittest.py:
1921         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1922         Added cases for Sierra, and updated tests for new baseline search paths.
1923
1924 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
1925
1926         Unreviewed, rolling out r217902.
1927
1928         This change appears to have caused imported/w3c/web-platform-
1929         tests/fetch/api/cors tests to fail on El Capitan.
1930
1931         Reverted changeset:
1932
1933         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
1934         https://bugs.webkit.org/show_bug.cgi?id=172930
1935         http://trac.webkit.org/changeset/217902
1936
1937 2017-06-07  Daniel Bates  <dabates@apple.com>
1938
1939         Teach run-webkit-tests how to run HTTPS Web Platform Tests
1940         https://bugs.webkit.org/show_bug.cgi?id=172930
1941         <rdar://problem/32570201>
1942
1943         Reviewed by Youenn Fablet.
1944
1945         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
1946         that is conditioned on the page being delivered over a secure protocol. One example of such
1947         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
1948
1949         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
1950         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
1951         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
1952
1953         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1954         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
1955         to the Web Platform Tests HTTPS server.
1956         * Scripts/webkitpy/port/base.py:
1957         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
1958         * Scripts/webkitpy/port/driver.py:
1959         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
1960         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
1961         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
1962         indicate that they should be considered private instance variables.
1963         (Driver.is_web_platform_test): Update code for renamed instance variables.
1964         (Driver):
1965         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
1966         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
1967         determine the base URL to use to access the test.
1968         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
1969         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
1970
1971 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
1972
1973         Support removal of authentication data through the Website data store API.
1974         https://bugs.webkit.org/show_bug.cgi?id=171217
1975
1976         Reviewed by Brady Eidson.
1977
1978         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1979         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1980         (WTR::InjectedBundle::didReceiveMessageToPage):
1981         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1982         (WTR::TestRunner::removeAllSessionCredentials):
1983         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
1984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1985         * WebKitTestRunner/TestController.h:
1986         * WebKitTestRunner/TestInvocation.cpp:
1987         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1988         (WTR::TestInvocation::didRemoveAllSessionCredentials):
1989         * WebKitTestRunner/TestInvocation.h:
1990         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1991         (WTR::TestController::removeAllSessionCredentials):
1992
1993 2017-06-07  Charlie Turner  <cturner@igalia.com>
1994
1995         Add Charlie Turner as contributor
1996         https://bugs.webkit.org/show_bug.cgi?id=173055
1997
1998         Reviewed by Carlos Alberto Lopez Perez.
1999
2000         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2001         of webkit-patch upload, which reordered some fields and removed a newline.
2002
2003         * Scripts/webkitpy/common/config/contributors.json:
2004
2005 2017-06-06  Chris Dumez  <cdumez@apple.com>
2006
2007         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2008         https://bugs.webkit.org/show_bug.cgi?id=173033
2009         <rdar://problem/32591099>
2010
2011         Reviewed by Simon Fraser.
2012
2013         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2014         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2015
2016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2017         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2018         (TestWebKitAPI::didFinishLoadForFrame):
2019         (TestWebKitAPI::setPageLoaderClient):
2020         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2021         (TestWebKitAPI::TEST):
2022
2023 2017-06-06  Andy Estes  <aestes@apple.com>
2024
2025         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2026         https://bugs.webkit.org/show_bug.cgi?id=172849
2027         <rdar://problem/32567454>
2028
2029         Reviewed by Darin Adler.
2030
2031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2032         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2033         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2034         (TestWebKitAPI::TEST):
2035
2036 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2037
2038         [preload] Conditional support for media preloading and align media `as` values.
2039         https://bugs.webkit.org/show_bug.cgi?id=172501
2040
2041         Reviewed by Dean Jackson.
2042
2043         Turn on media preloading preference for tests.
2044
2045         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2046         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2047         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2048
2049 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2050
2051         webkitpy: Return correct process names from SimulatorProcess
2052         https://bugs.webkit.org/show_bug.cgi?id=172940
2053
2054         Reviewed by Aakash Jain.
2055
2056         * Scripts/webkitpy/port/darwin.py:
2057         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2058         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2059         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2060         * Scripts/webkitpy/port/driver.py:
2061         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2062         _server_process.name() will not return the correct process name for iOS.
2063         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2064         (Driver._read_block): Ditto.
2065         * Scripts/webkitpy/port/driver_unittest.py:
2066         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2067         process_name() instead of name().
2068         * Scripts/webkitpy/port/server_process.py:
2069         (ServerProcess._start): Use process_name() instead of name().
2070         (ServerProcess.stop): Ditto.
2071         (ServerProcess.name): Deleted.
2072         * Scripts/webkitpy/port/simulator_process.py:
2073         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2074
2075 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2076
2077         test-webkitpy: stop forking unsafely from within a spawned process
2078         https://bugs.webkit.org/show_bug.cgi?id=172774
2079
2080         Reviewed by Darin Adler.
2081
2082         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2083         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2084         it's going to be used.
2085         (Builder.force_build):
2086
2087 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2088
2089         webkitpy: Process crash-logs for iOS devices
2090         https://bugs.webkit.org/show_bug.cgi?id=171976
2091         <rdar://problem/32134551>
2092
2093         Reviewed by David Kilzer.
2094
2095         When running layout tests on an iOS device, crash logs should be processed.
2096         Implement crash log searching and parsing for iOS devices.
2097
2098         * Scripts/webkitpy/common/system/crashlogs.py:
2099         (CrashLogs): Moved process regular expression for Darwin to class variable.
2100         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2101         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2102         (CrashLogs.find_all_logs): Ditto.
2103         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2104         Do not assume that a Darwin crash log starts with the process.
2105         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2106         shared code for parsing Darwin crash logs.
2107         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2108         object so that crash logs already on the system before testing are not parsed.
2109         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2110         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2111         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2112         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2113         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2114         * Scripts/webkitpy/common/system/systemhost.py:
2115         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2116         systems is just the crashlog, use this behavior by default.
2117         * Scripts/webkitpy/common/system/systemhost_mock.py:
2118         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2119         systems is just the crashlog, use this behavior by default.
2120         * Scripts/webkitpy/port/apple.py:
2121         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2122         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2123         the system before testing begins
2124         * Scripts/webkitpy/port/base.py:
2125         (Port._get_crash_log): Pass optional target host when getting crash logs.
2126         * Scripts/webkitpy/port/darwin.py:
2127         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2128         CrashLogs object.
2129         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2130         logs to be skipped to CrashLogs object.
2131         * Scripts/webkitpy/port/darwin_testcase.py:
2132         (DarwinTest.test_get_crash_log): Removed unused local function.
2133         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2134         * Scripts/webkitpy/port/device.py:
2135         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2136         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2137         * Scripts/webkitpy/port/driver.py:
2138         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2139         * Scripts/webkitpy/port/gtk.py:
2140         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2141         * Scripts/webkitpy/port/ios.py: Ditto.
2142         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2143         to be skipped for each host.
2144         * Scripts/webkitpy/port/ios_device.py:
2145         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2146         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2147         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2148         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2149         host is specified. Else, search all connected devices for the specified crash-log.
2150         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2151         * Scripts/webkitpy/port/ios_device_unittest.py:
2152         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2153         (IOSDeviceTest.test_get_crash_log): Ditto.
2154         * Scripts/webkitpy/port/simulator_process.py:
2155         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2156         * Scripts/webkitpy/port/win.py:
2157         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2158         logs to be skipped to CrashLogs object.
2159         * Scripts/webkitpy/port/wpe.py:
2160         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2161
2162 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2163
2164         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2165         <https://webkit.org/b/172804>
2166
2167         Reviewed by Darin Adler.
2168
2169         WTF_ATTRIBUTE_PRINTF() only works outside the current
2170         compilation unit if it's on the declaration, not the
2171         implementation, of a function or class method.
2172
2173         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2174         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2175         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2176         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2177         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2178         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2179         - Remove redundant CRASH() macro definition.  Use the one from
2180           <wtf/Assertions.h> instead.
2181
2182 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2183
2184         Move Resource Timing / User Timing from experimental features into main preferences
2185         https://bugs.webkit.org/show_bug.cgi?id=172950
2186
2187         Reviewed by Darin Adler.
2188
2189         * DumpRenderTree/mac/DumpRenderTree.mm:
2190         (enableExperimentalFeatures):
2191         (resetWebPreferencesToConsistentValues):
2192         * DumpRenderTree/win/DumpRenderTree.cpp:
2193         (enableExperimentalFeatures):
2194         (resetWebPreferencesToConsistentValues):
2195         * WebKitTestRunner/TestController.cpp:
2196         (WTR::TestController::resetPreferencesToConsistentValues):
2197         Move out no longer experimental features to the main list.
2198
2199 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2200
2201         [WPE] Add an install-dependencies script
2202         https://bugs.webkit.org/show_bug.cgi?id=172948
2203
2204         Reviewed by Žan Doberšek.
2205
2206         It is based on the gtk/install-dependencies script.
2207         Includes support for Debian based distrubutions, Fedora and Arch.
2208         It has been tested on a minimal Debian 9 chroot.
2209
2210         * wpe/install-dependencies: Added.
2211
2212 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2213
2214         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2215         https://bugs.webkit.org/show_bug.cgi?id=172891
2216         <rdar://problem/32204540>
2217
2218         Reviewed by Darin Adler.
2219
2220         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2221         contenteditable. See WebCore ChangeLog for more details.
2222
2223         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2224         (TestWebKitAPI::TEST):
2225
2226 2017-06-05  Daniel Bates  <dabates@apple.com>
2227
2228         webkitpy: Abstract Executive class
2229         https://bugs.webkit.org/show_bug.cgi?id=172928
2230         <rdar://problem/32569531>
2231
2232         Reviewed by Ryosuke Niwa.
2233
2234         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2235         This will make it straightforward to create additional derived classes that
2236         adhere to the same interface, say for iOS on-device testing.
2237
2238         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2239         (AbstractExecutive):
2240         (AbstractExecutive.run_and_throw_if_fail):
2241         (AbstractExecutive.cpu_count):
2242         (AbstractExecutive.interpreter_for_script):
2243         (AbstractExecutive.shell_command_for_script):
2244         (AbstractExecutive.kill_process):
2245         (AbstractExecutive.check_running_pid):
2246         (AbstractExecutive.running_pids):
2247         (AbstractExecutive.wait_newest):
2248         (AbstractExecutive.wait_limited):
2249         (AbstractExecutive.interrupt):
2250         (AbstractExecutive.default_error_handler):
2251         (AbstractExecutive.ignore_error):
2252         (AbstractExecutive._stringify_args):
2253         (AbstractExecutive.command_for_printing):
2254         (AbstractExecutive.run_command):
2255         (AbstractExecutive.popen):
2256         (AbstractExecutive.run_in_parallel):
2257         * Scripts/webkitpy/common/system/executive.py:
2258         (Executive):
2259         (Executive.cpu_count):
2260         (Executive.running_pids):
2261         (Executive.kill_all):
2262         (Executive._compute_stdin):
2263         (Executive.interpreter_for_script): Deleted.
2264         (Executive.shell_command_for_script): Deleted.
2265         (Executive.wait_newest): Deleted.
2266         (Executive.wait_limited): Deleted.
2267         (Executive.default_error_handler): Deleted.
2268         (Executive.ignore_error): Deleted.
2269         (Executive.command_for_printing): Deleted.
2270
2271 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2272
2273         webkitpy: Add iOS to platform
2274         https://bugs.webkit.org/show_bug.cgi?id=172931
2275
2276         Reviewed by Daniel Bates.
2277
2278         * Scripts/webkitpy/common/system/platforminfo.py:
2279         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2280         (PlatformInfo.is_ios): Added.
2281         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2282         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2283         (MockPlatformInfo.is_ios): Added.
2284
2285 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2286
2287         [WPE][JHBuild] Switch github repository from git:// to https://
2288         https://bugs.webkit.org/show_bug.cgi?id=172921
2289
2290         Reviewed by Alex Christensen.
2291
2292         * wpe/jhbuild.modules:
2293
2294 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2295
2296         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2297         https://bugs.webkit.org/show_bug.cgi?id=172887
2298         <rdar://problem/32546061>
2299
2300         Reviewed by Sam Weinig.
2301
2302         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2303         (WTR::UIScriptController::applyAutocorrection):
2304         applyAutocorrection can call its completion handler synchronously,
2305         which makes UIScriptController unhappy (see bug 172884).
2306
2307 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2308
2309         webkitpy: Add contextmanager to disable logging for a block
2310         https://bugs.webkit.org/show_bug.cgi?id=172876
2311
2312         Reviewed by Daniel Bates.
2313
2314         Add a context manager which will use an OutputCapture object to capture logging
2315         in a block and hold it in a variable.
2316
2317         * Scripts/webkitpy/common/system/outputcapture.py:
2318         (OutputCaptureScope):
2319         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2320         (OutputCaptureScope.__enter__): Begin capturing output. 
2321         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2322         output and retain the resulting log.
2323         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2324         (OutputCaptureTest.test_output_capture_scope): Added.
2325
2326 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2327
2328         Cleanup FrameView::autoSizeIfEnabled.
2329         https://bugs.webkit.org/show_bug.cgi?id=172889
2330         <rdar://problem/32550783>
2331
2332         Reviewed by Tim Horton.
2333
2334         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2335         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2336         (TEST):
2337
2338 2017-06-02  Chris Dumez  <cdumez@apple.com>
2339
2340         ResourceLoadStatistics are not using unique paths during test runs
2341         https://bugs.webkit.org/show_bug.cgi?id=172861
2342         <rdar://problem/32442251>
2343
2344         Reviewed by Darin Adler.
2345
2346         Make sure WebKitTestRunner sets a temporary path for saving resource
2347         load statistics.
2348
2349         * WebKitTestRunner/TestController.cpp:
2350         (WTR::TestController::generateContextConfiguration):
2351
2352 2017-06-02  Brady Eidson  <beidson@apple.com>
2353
2354         Prevent scheme handlers from handling all built-in URL schemes.
2355         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2356
2357         Reviewed by Andy Estes.
2358
2359         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2360
2361 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2362
2363         [JSCOnly] Build static jsc.exe on Windows
2364         https://bugs.webkit.org/show_bug.cgi?id=172833
2365
2366         Reviewed by Konstantin Tokarev.
2367
2368         * CMakeLists.txt:
2369         * Scripts/build-jsc:
2370
2371 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2372
2373         Disable ViewportSizeForViewportUnits tests on iOS.
2374         https://bugs.webkit.org/show_bug.cgi?id=172872
2375
2376         Reviewed by Tim Horton.
2377
2378         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2379
2380 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2381
2382         Allow clients to override viewport size for CSS viewport units.
2383         https://bugs.webkit.org/show_bug.cgi?id=172838
2384         <rdar://problem/32523441>
2385
2386         Reviewed by Tim Horton.
2387
2388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2389         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2390         (TEST):
2391
2392 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2393
2394         Get <chrono> out of StdLibExtras.h
2395         https://bugs.webkit.org/show_bug.cgi?id=172744
2396
2397         Reviewed by Zalan Bujtas.
2398
2399         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2400
2401 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2402
2403         [WPE] Enable SUBTLE_CRYPTO
2404         https://bugs.webkit.org/show_bug.cgi?id=172756
2405
2406         Reviewed by Michael Catanzaro.
2407
2408         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2409         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2410         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2411         exhausting entropy when running the crypto layout tests.
2412
2413 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2414
2415         [GTK] Bump GTK+ and its dependencies in jhbuild
2416         https://bugs.webkit.org/show_bug.cgi?id=171918
2417
2418         Reviewed by Carlos Alberto Lopez Perez.
2419
2420         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2421         (WTR::initializeGtkSettings):
2422         * gtk/jhbuild.modules:
2423         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2424         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2425
2426 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2427
2428         [GTK] Bump wayland and weston in jhbuild
2429         https://bugs.webkit.org/show_bug.cgi?id=171921
2430
2431         Reviewed by Carlos Alberto Lopez Perez.
2432
2433         * gtk/jhbuild.modules:
2434         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2435
2436 2017-06-01  Andy Estes  <aestes@apple.com>
2437
2438         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2439         https://bugs.webkit.org/show_bug.cgi?id=172828
2440
2441         Reviewed by Beth Dakin.
2442
2443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2444
2445 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2446
2447         webkitpy: Remove unneeded simulator teardown
2448         https://bugs.webkit.org/show_bug.cgi?id=171891
2449
2450         Reviewed by Aakash Jain.
2451
2452         * Scripts/webkitpy/port/ios_simulator.py:
2453         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
2454         for communication between Python and WebKitTestRunner/DumpRenderTree.
2455
2456 2017-06-01  Keith Miller  <keith_miller@apple.com>
2457
2458         Undo rollout in r217638 with bug fix
2459         https://bugs.webkit.org/show_bug.cgi?id=172824
2460
2461         Unreviewed, reland patch with unused set_state code removed.
2462
2463         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2464         (runThreadMessageTest):
2465         (TEST):
2466
2467 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2468
2469         webkitpy: Do not send 0 or -1 as a pid to kill_process
2470         https://bugs.webkit.org/show_bug.cgi?id=172818
2471
2472         Reviewed by Darin Adler.
2473
2474         Sending a signal to process 0 will result in all processes in the group receiving 
2475         the signal. Sending a signal to process -1 will result in all non-system processes
2476         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
2477         should consider these cases
2478
2479         * Scripts/webkitpy/common/system/executive.py:
2480         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
2481         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
2482         never be running, although os.kill may succeed.
2483         * Scripts/webkitpy/port/simulator_process.py:
2484         (SimulatorProcess.stop): Do not kill process if it is undefined.
2485
2486 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
2487
2488         JSC EWS bot does not run on WTF only patches
2489         https://bugs.webkit.org/show_bug.cgi?id=172777
2490         rdar://problem/32495975
2491
2492         Reviewed by Aakash Jain.
2493
2494         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2495         (CheckPatchRelevance): Add a missing comma.
2496
2497 2017-05-31  Commit Queue  <commit-queue@webkit.org>
2498
2499         Unreviewed, rolling out r217611 and r217631.
2500         https://bugs.webkit.org/show_bug.cgi?id=172785
2501
2502         "caused wasm-hashset-many.html to become flaky." (Requested by
2503         keith_miller on #webkit).
2504
2505         Reverted changesets:
2506
2507         "Reland r216808, underlying lldb bug has been fixed."
2508         https://bugs.webkit.org/show_bug.cgi?id=172759
2509         http://trac.webkit.org/changeset/217611
2510
2511         "Use dispatch queues for mach exceptions"
2512         https://bugs.webkit.org/show_bug.cgi?id=172775
2513         http://trac.webkit.org/changeset/217631
2514
2515 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2516
2517         EWS bots should reboot themselves more frequently
2518         https://bugs.webkit.org/show_bug.cgi?id=172402
2519
2520         Reviewed by Alexey Proskuryakov.
2521
2522         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
2523
2524         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
2525
2526 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2527
2528         Reallocate hardware for iOS bots.
2529         https://bugs.webkit.org/show_bug.cgi?id=172657
2530
2531         Reviewed by Alexey Proskuryakov.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/config.json:
2534
2535 2017-05-31  Andy Estes  <aestes@apple.com>
2536
2537         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2538         https://bugs.webkit.org/show_bug.cgi?id=172366
2539
2540         Reviewed by Daniel Bates.
2541
2542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2543
2544 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
2545
2546         Unreviewed, add Jiewen Tan as a reviewer
2547
2548         * Scripts/webkitpy/common/config/contributors.json:
2549
2550 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2551
2552         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
2553         https://bugs.webkit.org/show_bug.cgi?id=172770
2554
2555         Reviewed by Michael Catanzaro.
2556
2557         * MiniBrowser/gtk/BrowserWindow.c:
2558         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
2559         which caused the body of the if-clause to be accidentally empty.
2560
2561 2017-05-31  Keith Miller  <keith_miller@apple.com>
2562
2563         Reland r216808, underlying lldb bug has been fixed.
2564         https://bugs.webkit.org/show_bug.cgi?id=172759
2565
2566         Unreviewed, relanding old patch. See: rdar://problem/31183352
2567
2568         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2569         (runThreadMessageTest):
2570         (TEST):
2571
2572 2017-05-31  Matt Lewis  <jlewis3@apple.com>
2573
2574         Unreviewed, rolling out r217603.
2575
2576         This patch broke the internal builds.
2577
2578         Reverted changeset:
2579
2580         "Get <chrono> out of StdLibExtras.h"
2581         https://bugs.webkit.org/show_bug.cgi?id=172744
2582         http://trac.webkit.org/changeset/217603
2583
2584 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2585
2586         Make ResourceLoadStatistics testing more reliable
2587         https://bugs.webkit.org/show_bug.cgi?id=172730
2588         <rdar://problem/32028373>
2589
2590         Reviewed by Andy Estes.
2591
2592         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2593         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2594
2595         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2596         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2597
2598 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2599
2600         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2601         https://bugs.webkit.org/show_bug.cgi?id=172757
2602
2603         Reviewed by Xabier Rodriguez-Calvar.
2604
2605         When needed, add the jhbuild wrapper at the beginning of the array
2606         that will be invoked to execute the run-jsc-stress-test or testapi
2607         commands.
2608
2609         * Scripts/run-javascriptcore-tests:
2610         (runJSCStressTests):
2611         * Scripts/webkitdirs.pm:
2612         (shouldUseJhbuild):
2613
2614 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2615
2616         Get <chrono> out of StdLibExtras.h
2617         https://bugs.webkit.org/show_bug.cgi?id=172744
2618
2619         Reviewed by Saam Barati.
2620
2621         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2622
2623 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2624
2625         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2626         https://bugs.webkit.org/show_bug.cgi?id=172735
2627         <rdar://problem/32015977>
2628
2629         Reviewed by Enrica Casucci.
2630
2631         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2632         (WTR::UIScriptController::applyAutocorrection):
2633         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2634         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2635         (WTR::UIScriptController::applyAutocorrection):
2636         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2637         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2638         (WTR::UIScriptController::applyAutocorrection):
2639         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2640         because I don't know how to tap the button in the autocorrection bar from a test.
2641
2642 2017-05-30  Daniel Bates  <dabates@apple.com>
2643
2644         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2645         https://bugs.webkit.org/show_bug.cgi?id=172671
2646
2647         Reviewed by Alex Christensen.
2648
2649         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2650         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2651
2652         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2653         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2654         to trigger a navigation to test it.
2655         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2656         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2657
2658 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2659
2660         webkitpy: Start servers before setting-up for testing
2661         https://bugs.webkit.org/show_bug.cgi?id=172176
2662         <rdar://problem/32225538>
2663
2664         Reviewed by Alexey Proskuryakov.
2665
2666         On-device testing requires that servers are started before ports set-up their
2667         test environments.
2668
2669         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2670         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2671         Servers are unconditionally stopped on exit.
2672         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2673         Manager now stops servers.
2674         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2675         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2676         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2677         (Manager.__init__): Delay construction of the test runner until we can determine
2678         if servers need to be started.
2679         (Manager.run): Determine if servers need to be started and construct the test runner.
2680         Shut servers down when the test run is finished.
2681         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2682         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2683         (is_wpt_server_running): Server is not running if no config is found.
2684         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2685         (PyWebSocket.is_running): Check if this WebSocket server is running.
2686         * Scripts/webkitpy/port/base.py:
2687         (Port.__init__): Define secure WebSocket server.
2688         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2689
2690 2017-05-30  Daniel Bates  <dabates@apple.com>
2691
2692         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2693         https://bugs.webkit.org/show_bug.cgi?id=172603
2694         <rdar://problem/32471306>
2695
2696         Reviewed by Brady Eidson.
2697
2698         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2699         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2700         unloading is initiated for a page that registered a onbeforeunload handler.
2701
2702         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2703         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2704         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2705
2706         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2707         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2708         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2709         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2710
2711         * MiniBrowser/mac/WK2BrowserWindowController.m:
2712         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2713         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2714         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2715         (sawDialog):
2716         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2717         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2718         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2719
2720 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2721
2722         Update libwebrtc configuration
2723         https://bugs.webkit.org/show_bug.cgi?id=172727
2724
2725         Reviewed by Geoffrey Garen.
2726
2727         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2728
2729 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2730
2731         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2732         https://bugs.webkit.org/show_bug.cgi?id=172702
2733
2734         Reviewed by Alex Christensen.
2735
2736         EGL PlatformDisplay needs to be shut down before existing a
2737         program on Windows.
2738
2739         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2740         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2741         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2742         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2743
2744 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2745
2746         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2747         https://bugs.webkit.org/show_bug.cgi?id=172709
2748
2749         Reviewed by Brent Fulgham.
2750
2751         Exit fullscreen mode after a fullscreen test.
2752
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (resetWebViewToConsistentStateBeforeTesting):
2755
2756 2017-05-30  Antti Koivisto  <antti@apple.com>
2757
2758         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2759         https://bugs.webkit.org/show_bug.cgi?id=172713
2760
2761         Reviewed by Zalan Bujtas.
2762
2763         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2764         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2765
2766             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2767             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2768             because on Mac WK1 it may get invoked from middle of a layout.
2769
2770             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2771
2772 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2773
2774         Add a WPE EWS queue
2775         https://bugs.webkit.org/show_bug.cgi?id=172693
2776
2777         Reviewed by Carlos Garcia Campos.
2778
2779         * QueueStatusServer/config/queues.py:
2780         * QueueStatusServer/model/queues.py: Capitalize the name of the
2781         port on the tooltip of the bubbles. Do the same for the GTK port.
2782         (Queue.display_name):
2783         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2784         for the GTK+ EWS also. Set for both ports as watcher the alias
2785         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2786         * Scripts/webkitpy/common/config/ports.py:
2787         (DeprecatedPort.port):
2788         (WpePort):
2789         (WpePort.build_webkit_command):
2790         (WpePort.run_webkit_tests_command):
2791         * Scripts/webkitpy/common/config/ports_unittest.py:
2792         (DeprecatedPortTest):
2793         (DeprecatedPortTest.test_wpe_port):
2794         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2795         (test_ews_name):
2796
2797 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
2798
2799         Unreviewed. Bumping the WPEBackend-mesa dependency version.
2800
2801         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
2802         priorities for IPC communication.
2803
2804 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
2805
2806         [JSC] Map and Set constructors should have fast path for cloning
2807         https://bugs.webkit.org/show_bug.cgi?id=172413
2808
2809         Reviewed by Saam Barati.
2810
2811         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2812         (TestWebKitAPI::TEST):
2813
2814 2017-05-27  Zalan Bujtas  <zalan@apple.com>
2815
2816         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
2817         https://bugs.webkit.org/show_bug.cgi?id=172676
2818
2819         Reviewed by Simon Fraser.
2820
2821         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2822         (TestWebKitAPI::TEST):
2823
2824 2017-05-26  Zalan Bujtas  <zalan@apple.com>
2825
2826         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
2827         https://bugs.webkit.org/show_bug.cgi?id=172674
2828
2829         Reviewed by Simon Fraser.
2830
2831         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2832         (TestWebKitAPI::TEST):
2833
2834 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2835
2836         Add test resources back into TestWebKitAPI Copy Resources phase
2837
2838         Rubber-stamped by Beth Dakin.
2839
2840         Add two files back into the Copy Resources phase after they were unintentionally
2841         removed in r217447 and r217496.
2842
2843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2844
2845 2017-05-26  Beth Dakin  <bdakin@apple.com>
2846
2847         Media documents inside iframes should not get controls in the TouchBar unless the 
2848         video is playing
2849         https://bugs.webkit.org/show_bug.cgi?id=172620
2850         -and corresponding-
2851         rdar://problem/32165477
2852
2853         Reviewed by Jon Lee.
2854
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2857         (TestWebKitAPI::TEST):
2858         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
2859
2860 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
2861
2862         _WKUserStyleSheet and WKUserScript leak string data
2863         https://bugs.webkit.org/show_bug.cgi?id=172583
2864         <rdar://problem/32395209>
2865
2866         Reviewed by Sam Weinig.
2867
2868         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2869         We should not have been adopting an autoreleased object.
2870
2871 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
2872
2873         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
2874         https://bugs.webkit.org/show_bug.cgi?id=172554
2875         <rdar://problem/31247133>
2876
2877         Reviewed by Simon Fraser.
2878
2879         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
2880         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
2881         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
2882         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
2883         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
2884         codepath.
2885
2886         * DumpRenderTree/TestOptions.h:
2887         * DumpRenderTree/TestOptions.mm:
2888         (TestOptions::TestOptions):
2889         (TestOptions::webViewIsCompatibleWithOptions):
2890         * DumpRenderTree/mac/DumpRenderTree.mm:
2891         (shouldIgnoreWebCoreNodeLeaks):
2892         (allowedFontFamilySet):
2893         (-[DRTMockScroller rectForPart:]):
2894         (-[DRTMockScroller drawKnob]):
2895         (-[DRTMockScroller drawRect:]):
2896         (createWebViewAndOffscreenWindow):
2897         (initializeGlobalsFromCommandLineOptions):
2898         (prepareConsistentTestingEnvironment):
2899         (dumpRenderTree):
2900         (dumpAudio):
2901         (dumpHistoryItem):
2902         (dumpBackForwardListForWebView):
2903         (resetWebViewToConsistentStateBeforeTesting):
2904         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
2905         (runTest):
2906
2907 2017-05-25  Sam Weinig  <sam@webkit.org>
2908
2909         [WebIDL] Use the term 'operation' more consistently
2910         https://bugs.webkit.org/show_bug.cgi?id=172601
2911
2912         Reviewed by Chris Dumez.
2913
2914         We were using the term 'operation', a WebIDL term for function-like
2915         constructs, inconsistently in the code generator. Now, when we use
2916         'operation' when referring to the IDL concept (usually the object the
2917         parser produces) and 'function' when referring to code being generated.
2918
2919         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2920         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2921
2922 2017-05-25  Jer Noble  <jer.noble@apple.com>
2923
2924         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
2925
2926         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2927
2928 2017-05-25  Jer Noble  <jer.noble@apple.com>
2929
2930         System sleeps while playing to wireless target, ending stream.
2931         https://bugs.webkit.org/show_bug.cgi?id=172541
2932
2933         Reviewed by Eric Carlson.
2934
2935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2936         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
2937         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
2938         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2939         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2940         (TestWebKitAPI::simulateKeyDown):
2941         (TestWebKitAPI::hasAssertionType):
2942         (TestWebKitAPI::TEST):
2943
2944 2017-05-25  Commit Queue  <commit-queue@webkit.org>
2945
2946         Unreviewed, rolling out r217423 and r217424.
2947         https://bugs.webkit.org/show_bug.cgi?id=172607
2948
2949         These caused an api failure on all testers. (Requested by
2950         mlewis13 on #webkit).
2951
2952         Reverted changesets:
2953
2954         "REGRESSION (r216977): 4 leaks introduced in new
2955         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
2956         https://bugs.webkit.org/show_bug.cgi?id=172558
2957         http://trac.webkit.org/changeset/217423
2958
2959         "REGRESSION (r217423): Fix last-second typo in 'auto'"
2960         http://trac.webkit.org/changeset/217424
2961
2962 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
2963
2964         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
2965         https://bugs.webkit.org/show_bug.cgi?id=172355
2966
2967         Reviewed by Chris Fleizach.
2968
2969         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
2970         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
2971         releases which support the new platform footnote accessibility role.
2972
2973         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2974         * gtk/jhbuild.modules:
2975
2976 2017-05-25  David Kilzer  <ddkilzer@apple.com>
2977
2978         REGRESSION (r217423): Fix last-second typo in 'auto'
2979
2980         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2981         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
2982
2983 2017-05-24  David Kilzer  <ddkilzer@apple.com>
2984
2985         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
2986         <https://webkit.org/b/172558>
2987
2988         Reviewed by Sam Weinig.
2989
2990         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2991         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
2992
2993 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2994
2995         [CMake] Consolidate CMake code related to Cairo
2996         https://bugs.webkit.org/show_bug.cgi?id=172568
2997
2998         Reviewed by Alex Christensen.
2999
3000         * DumpRenderTree/config.h:
3001         * TestWebKitAPI/config.h:
3002
3003 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3004
3005         Plumb additional image metadata to item providers when beginning data interaction on an image
3006         https://bugs.webkit.org/show_bug.cgi?id=172536
3007         <rdar://problem/32371300>
3008
3009         Reviewed by Beth Dakin.
3010
3011         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3012         source item providers.
3013
3014         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3015         (checkSuggestedNameAndEstimatedSize):
3016         (TestWebKitAPI::TEST):
3017
3018 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3019
3020         [Win] Create unique network storage session for each DRT.
3021         https://bugs.webkit.org/show_bug.cgi?id=172540
3022
3023         Reviewed by Brent Fulgham.
3024
3025         During layout testing, each DRT instance should have its own network storage session.
3026
3027         * DumpRenderTree/win/DumpRenderTree.cpp:
3028         (prepareConsistentTestingEnvironment):
3029
3030 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3031
3032         Respect image UTIs when writing to item providers when beginning data interaction on an image
3033         https://bugs.webkit.org/show_bug.cgi?id=172436
3034         <rdar://problem/31786569>
3035
3036         Reviewed by Beth Dakin.
3037
3038         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3039         details.
3040
3041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3042         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3043         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3044
3045         Create a new test page containing a GIF and a file input.
3046
3047         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3048         (checkTypeIdentifierIsRegisteredAtIndex):
3049         (TestWebKitAPI::TEST):
3050
3051 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
3052
3053         [Win] Increase test timeout for slow tests.
3054         https://bugs.webkit.org/show_bug.cgi?id=172449
3055
3056         Reviewed by Alexey Proskuryakov.
3057
3058         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
3059         timeout member in the TestRunner class.
3060
3061         * DumpRenderTree/win/TestRunnerWin.cpp:
3062         (TestRunner::setWaitToDump):
3063
3064 2017-05-15  Matt Rajca  <mrajca@apple.com>
3065
3066         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
3067         https://bugs.webkit.org/show_bug.cgi?id=172138
3068
3069         Reviewed by Alex Christensen.
3070
3071         Added API tests.
3072
3073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3074         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
3075         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3076         (TEST):
3077         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
3078
3079 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3080
3081         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3082         https://bugs.webkit.org/show_bug.cgi?id=172522
3083         rdar://problem/31071812
3084
3085         Reviewed by Sam Weinig.
3086
3087         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
3088         We set this in the .xib file now.
3089
3090         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3091
3092 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3093
3094         Snapshotting via -renderInContext: should do synchronous image decodes
3095         https://bugs.webkit.org/show_bug.cgi?id=172485
3096         rdar://problem/32276146
3097
3098         Reviewed by Tim Horton.
3099
3100         New API test.
3101
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
3104         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3105         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3106         (TestWebKitAPI::getPixelIndex):
3107         (TestWebKitAPI::TEST):
3108
3109 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3110
3111         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3112         https://bugs.webkit.org/show_bug.cgi?id=172517
3113
3114         Rubber-stamped by Simon Fraser.
3115
3116         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3117
3118 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3119
3120         Multiple links should be inserted separately when performing data interaction
3121         https://bugs.webkit.org/show_bug.cgi?id=172489
3122         <rdar://problem/31510832>
3123
3124         Reviewed by Dan Bernstein.
3125
3126         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
3127
3128         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3129         (TestWebKitAPI::TEST):
3130
3131 2017-05-23  Tim Horton  <timothy_horton@apple.com>
3132
3133         REGRESSION: API test WebKit2.WKObject is failing
3134         https://bugs.webkit.org/show_bug.cgi?id=172497
3135         <rdar://problem/31694641>
3136
3137         Reviewed by Geoff Garen.
3138
3139         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3140         (TestWebKitAPI::TEST):
3141         Add a test that ensures that we pretend to at least be *some* kind of
3142         NSString, which my first fix would not have passed.
3143
3144 2017-05-23  youenn fablet  <youenn@apple.com>
3145
3146         There should be an easy way to run HTTP/WPT served tests on a browser
3147         https://bugs.webkit.org/show_bug.cgi?id=172068
3148
3149         Reviewed by Sam Weinig.
3150
3151         Adding a new script open-layout-test to open a layout-test in a
3152         browser and making sure it is served as done through run-webkit-tests.
3153         In case tests should be run using a server, detecting whether the
3154         server are running. If not, calling run-webkit-httpd to run the
3155         servers and open the URL in a browser.
3156         Otherwise, open directly the URL.
3157
3158         Adding an option in run-webkit-httpd to open an URL after having
3159         started the servers.
3160
3161         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
3162         This allows running run-webkit-httpd once and not having to restart
3163         servers everytime a test should be served.
3164
3165         Moving most of run-webkit-httpd logic in its own python file to reuse
3166         it in open-layout-test script.
3167
3168         Adding routines to check whether HTTP and WPT servers are running.
3169
3170         * Scripts/open-layout-test: Added.
3171         (parse_args):
3172         (main):
3173         * Scripts/run-webkit-httpd:
3174         (main):
3175         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3176         (LayoutTestFinder.find_tests):
3177         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3178         (LayoutTestRunner.run_tests):
3179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3180         (parse_args):
3181         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3182         (HttpServerBase._is_server_running_on_all_ports):
3183         (HttpServerBase):
3184         (HttpServerBase._is_running_on_port):
3185         (HttpServerBase._check_that_all_ports_are_available):
3186         (is_http_server_running):
3187         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
3188         (parse_args):
3189         (main):
3190         (run_server):
3191         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3192         (is_wpt_server_running):
3193         * Scripts/webkitpy/port/base.py:
3194         (Port.to.is_http_server_running):
3195         (Port.to):
3196         (Port.to.is_wpt_server_running):
3197         (Port.to.start_web_platform_test_server):
3198         * Scripts/webkitpy/port/driver.py:
3199         (DriverProxy.is_web_platform_test):
3200         (DriverProxy):
3201         (DriverProxy.is_webkit_specific_web_platform_test):
3202
3203 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3204
3205         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3206         https://bugs.webkit.org/show_bug.cgi?id=171984
3207
3208         Reviewed by Antti Koivisto.
3209
3210         * DumpRenderTree/mac/DumpRenderTree.mm:
3211         (enableExperimentalFeatures):
3212         * WebKitTestRunner/TestController.cpp:
3213         (WTR::TestController::resetPreferencesToConsistentValues):
3214
3215 2017-05-20  Alex Christensen  <achristensen@webkit.org>
3216
3217         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
3218         https://bugs.webkit.org/show_bug.cgi?id=172406
3219         <rdar://32109532>
3220
3221         Reviewed by Brady Eidson.
3222
3223         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3224         (TestWebKitAPI::checkBuffer):
3225         (TestWebKitAPI::TEST_F):
3226
3227 2017-05-22  Jason Marcell  <jmarcell@apple.com>
3228
3229         Do not enter Subversion-specific logic when parsing Git-based Trac data.
3230         https://bugs.webkit.org/show_bug.cgi?id=172433
3231         <rdar://problem/32234188>
3232
3233         Reviewed by Alexey Proskuryakov.
3234
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3236         (Trac.prototype._convertCommitInfoElementToObject):
3237
3238 2017-05-22  Tim Horton  <timothy_horton@apple.com>
3239
3240         ExplicitSnapshotsChangeUponNavigation API test often fails
3241         https://bugs.webkit.org/show_bug.cgi?id=172475
3242         <rdar://problem/31688322>
3243
3244         Reviewed by Simon Fraser.
3245
3246         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3247         (-[TestWKWebView _setUpTestWindow:]):
3248         Make TestWKWebView's window layer-backed. This is now the default,
3249         and it's also easy to accidentally write a test that depends on it
3250         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
3251         which becomes layer backed, just like the WKWebView, but with no
3252         common layer-backed ancestor).
3253
3254 2017-05-22  youenn fablet  <youenn@apple.com>
3255
3256         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
3257         https://bugs.webkit.org/show_bug.cgi?id=172426
3258
3259         Reviewed by Chris Dumez.
3260
3261         * Scripts/webkitpy/w3c/test_importer.py:
3262         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
3263
3264 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
3265
3266         Unreviewed, change my status to reviewer and fill "expertise" field
3267
3268         * Scripts/webkitpy/common/config/contributors.json:
3269
3270 2017-05-22  Tomas Popela  <tpopela@redhat.com>
3271
3272         Remove some of the EFL port leftovers
3273         https://bugs.webkit.org/show_bug.cgi?id=172440
3274
3275         Reviewed by Carlos Garcia Campos.
3276
3277         * BuildSlaveSupport/built-product-archive:
3278         (archiveBuiltProduct):
3279         (extractBuiltProduct):
3280         * BuildSlaveSupport/test-result-archive:
3281         (archiveTestResults):
3282         * ImageDiff/PlatformEfl.cmake: Removed.
3283         * Scripts/run-efl-tests: Removed.
3284         * Scripts/webkit-build-directory:
3285         * Scripts/webkitpy/common/config/contributionareas.py:
3286         * Scripts/webkitpy/common/config/watchlist:
3287         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3288         (parse_args):
3289         (_set_up_derived_options):
3290         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3291         (PerfTestsRunner.__init__):
3292         * Scripts/webkitpy/style/checker.py:
3293         * Scripts/webkitpy/style/checker_unittest.py:
3294         (GlobalVariablesTest.test_path_rules_specifier):
3295         * gtk/manifest.txt.in:
3296         * jhbuild/jhbuild-wrapper:
3297
3298 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3299
3300         Unreviewed. Do not include WPE files in GTK+ tarballs.
3301
3302         * gtk/manifest.txt.in:
3303
3304 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3305
3306         [GTK] Add webkit_context_menu_item_new_from_gaction
3307         https://bugs.webkit.org/show_bug.cgi?id=159631
3308
3309         Reviewed by Michael Catanzaro.
3310
3311         Update context menu tests to check the new GAction API.
3312
3313         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3314         (testContextMenuPopulateMenu):
3315
3316 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3317
3318         [GTK] Remove Firefox user agent quirk for Google domains
3319         https://bugs.webkit.org/show_bug.cgi?id=171941
3320
3321         Reviewed by Carlos Garcia Campos.
3322
3323         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3324         (TestWebKitAPI::TEST):
3325         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
3326
3327 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
3328
3329         [GTK] gtkdoc-fixxref needs --module argument to work
3330         https://bugs.webkit.org/show_bug.cgi?id=172415
3331
3332         Reviewed by Michael Catanzaro.
3333
3334         * gtk/gtkdoc.py:
3335         (GTKDoc._run_gtkdoc_fixxref):
3336
3337 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
3338
3339         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
3340         https://bugs.webkit.org/show_bug.cgi?id=172416
3341
3342         Reviewed by Daniel Bates.
3343
3344         * Scripts/make-new-script-test:
3345
3346 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3347
3348         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
3349         https://bugs.webkit.org/show_bug.cgi?id=172267
3350
3351         Reviewed by Per Arne Vollan.
3352
3353         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
3354         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
3355         should link only with WebKit.
3356
3357         Unfortunately, there is a layer violation at the moment.
3358         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
3359         in WebKit. This change contains a stub of loadResourceIntoBuffer
3360         in TestWebCoreLib for the workaround.
3361
3362         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
3363         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
3364         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
3365         (loadResourceIntoBuffer): Added a stub.
3366
3367 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
3368
3369         Fix dump-class-layout to handle different file architectures
3370         https://bugs.webkit.org/show_bug.cgi?id=172392
3371
3372         Reviewed by Zalan Bujtas.
3373
3374         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
3375         and use the first architecture reported. Also add a "--architecture" argument
3376         to allow the user to specify an architecture.
3377
3378         * Scripts/dump-class-layout:
3379         (import_lldb):
3380         (verify_type_recursive):
3381         (get_first_file_architecture):
3382         (dump_class):
3383         (main):
3384         (find_build_directory): Deleted.
3385
3386 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3387
3388         Unreviewed infrastructure fix.
3389
3390         * Scripts/webkitpy/port/ios_simulator.py:
3391         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
3392
3393 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3394
3395         webkitpy: Use simctl boot to run multiple simulators at once
3396         https://bugs.webkit.org/show_bug.cgi?id=172374
3397
3398         Reviewed by Alexey Proskuryakov.
3399
3400         * Scripts/webkitpy/common/system/platforminfo.py:
3401         (PlatformInfo.xcode_version): Return the current version of Xcode.
3402         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3403         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
3404         * Scripts/webkitpy/port/ios_simulator.py:
3405         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
3406         run multiple Simulator.app instances.
3407         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
3408         versions of Xcode.
3409         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
3410         an older version of Xcode.
3411
3412 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3413
3414         Unreviewed, fix the build on the latest internal SDK.
3415
3416         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3417         (TestWebKitAPI::TEST):
3418
3419 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
3420
3421         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
3422         https://bugs.webkit.org/show_bug.cgi?id=172369
3423
3424         Reviewed by Mark Lam.
3425         
3426         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
3427         would be a good idea to write this down.
3428
3429         * Scripts/run-jsc-stress-tests:
3430
3431 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3432
3433         webkitpy: Layout tests which have no output will succeed
3434         https://bugs.webkit.org/show_bug.cgi?id=172322
3435         <rdar://problem/32258350>
3436
3437         Reviewed by David Kilzer.
3438
3439         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3440         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
3441         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3442         (determine_result_type): FailureNotTested means that the test could not be loaded. This
3443         is classified as a MISSING failure.
3444         (FailureNotTested): Added.
3445         (FailureNotTested.message):
3446
3447 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3448
3449         Add SixSpeed benchmark to PerformanceTests
3450         https://bugs.webkit.org/show_bug.cgi?id=172326
3451
3452         Reviewed by Sam Weinig.
3453
3454         * Scripts/run-jsc-benchmarks:
3455
3456 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3457
3458         [WK1] MiniBrowser should navigate when handling a dropped URL
3459         https://bugs.webkit.org/show_bug.cgi?id=172350
3460
3461         Reviewed by Tim Horton.
3462
3463         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
3464
3465         * MiniBrowser/mac/WK1BrowserWindowController.m:
3466         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
3467
3468 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
3469
3470         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
3471         https://bugs.webkit.org/show_bug.cgi?id=172077
3472
3473         Reviewed by Chris Dumez.
3474
3475         Fixed perftest.py by updating the lines to ignore in Speedometer.
3476
3477         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
3478
3479         * Scripts/webkitpy/performance_tests/perftest.py:
3480         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
3481         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3482         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
3483         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
3484         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3485         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
3486
3487 2017-05-18  Andy Estes  <aestes@apple.com>
3488
3489         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3490         https://bugs.webkit.org/show_bug.cgi?id=172305
3491
3492         Reviewed by Anders Carlsson.
3493
3494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3495
3496 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3497
3498         Selection around attachment elements should not persist when beginning a drag
3499         https://bugs.webkit.org/show_bug.cgi?id=172319
3500         <rdar://problem/32283008>
3501
3502         Reviewed by Tim Horton.
3503
3504         Tests that temporary selection around an attachment does not persist longer than it needs to.
3505
3506         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3507         (TestWebKitAPI::TEST):
3508
3509 2017-05-18  John Wilander  <wilander@apple.com>
3510
3511         Resource Load Statistics: Grandfather domains for existing data records
3512         https://bugs.webkit.org/show_bug.cgi?id=172155
3513         <rdar://problem/24913532>
3514
3515         Reviewed by Alex Christensen.
3516
3517         Adds test infrastructure needed for the added functionality.
3518
3519         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3521         (WTR::InjectedBundle::didReceiveMessageToPage):
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::TestRunner::setStatisticsGrandfathered):
3524         (WTR::TestRunner::isStatisticsGrandfathered):
3525         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3526         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3527         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::setStatisticsGrandfathered):
3531         (WTR::TestController::isStatisticsGrandfathered):
3532         (WTR::TestController::setStatisticsGrandfatheringTime):
3533         * WebKitTestRunner/TestController.h:
3534         * WebKitTestRunner/TestInvocation.cpp:
3535         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3536
3537 2017-05-18  Saam Barati  <sbarati@apple.com>
3538
3539         WebAssembly: perform stack checks
3540         https://bugs.webkit.org/show_bug.cgi?id=165546
3541         <rdar://problem/29760307>
3542
3543         Reviewed by Filip Pizlo.
3544
3545         Add some new testing modes for using and not using fast TLS wasm contexts.
3546
3547         * Scripts/run-jsc-stress-tests:
3548
3549 2017-05-18  Daniel Bates  <dabates@apple.com>
3550
3551         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
3552         window CSP when object-src 'none' is set
3553         https://bugs.webkit.org/show_bug.cgi?id=172038
3554         <rdar://problem/32258262>
3555
3556         Reviewed by Andy Estes.
3557
3558         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
3559         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
3560
3561         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3562         (NPP_New):
3563
3564 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
3565
3566         [Win] Many layout tests are failing.
3567         https://bugs.webkit.org/show_bug.cgi?id=172286
3568
3569         Reviewed by Brent Fulgham.
3570
3571         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
3572  
3573         * DumpRenderTree/win/TestRunnerWin.cpp:
3574         (TestRunner::grantWebNotificationPermission):
3575         (TestRunner::denyWebNotificationPermission):
3576         (TestRunner::removeAllWebNotificationPermissions):
3577         (TestRunner::simulateWebNotificationClick):
3578
3579 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
3580
3581         [Win] Remove usage of _snprintf
3582         https://bugs.webkit.org/show_bug.cgi?id=172251
3583
3584         Reviewed by Per Arne Vollan.
3585
3586         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3587         * MiniBrowser/win/PageLoadTestClient.cpp:
3588         (PageLoadTestClient::dumpRunStatistics):
3589
3590 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3591
3592         Unreviewed, rolling out r217014.
3593
3594         This change caused mac-wk2 LayoutTests to exit early due to
3595         crashes.
3596
3597         Reverted changeset:
3598
3599         "Resource Load Statistics: Grandfather domains for existing
3600         data records"
3601         https://bugs.webkit.org/show_bug.cgi?id=172155
3602         http://trac.webkit.org/changeset/217014
3603
3604 2017-05-17  John Wilander  <wilander@apple.com>
3605
3606         Resource Load Statistics: Grandfather domains for existing data records
3607         https://bugs.webkit.org/show_bug.cgi?id=172155
3608         <rdar://problem/24913532>
3609
3610         Reviewed by Alex Christensen.
3611
3612         Adds test infrastructure needed for the added functionality.
3613
3614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3615         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3616         (WTR::InjectedBundle::didReceiveMessageToPage):
3617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3618         (WTR::TestRunner::setStatisticsGrandfathered):
3619         (WTR::TestRunner::isStatisticsGrandfathered):
3620         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3621         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3622         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3623         * WebKitTestRunner/InjectedBundle/TestRunner.h: