a2b9c312244cd8c12947c7608d594c3e184f5c77
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
4
5         For DRT we didn't install the message handler early enough to
6         catch output while constructing the QApplication. For WTR we
7         didn't even install a message handler.
8
9         Since the UI process will forward any output from the web process
10         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
11         in WTR before the web process is started. This is picked up by the
12         web process which installs its own message handler.
13
14         The environment variable can be overriden on the command line if you
15         want to see output from the web process, or you can pass --verbose to
16         WTR to see output from both processes.
17
18         https://bugs.webkit.org/show_bug.cgi?id=69132
19
20         Reviewed by Andreas Kling.
21
22         * DumpRenderTree/qt/main.cpp:
23         * WebKitTestRunner/qt/main.cpp:
24
25 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26
27         [Qt] Make sure WTR sizes the window and item correctly
28
29         Revision 96345 changed the logic for how the view and
30         window was created, but missed a vital part, setting
31         the size.
32
33         We now use a QSGView for the window, that has a simple
34         item as its root object that is always resized to fit
35         within the window. The webview is then parented to the
36         root object and set to anchors.fill: parent. That way
37         any window geometry changes will propagate to the web
38         view.
39
40         https://bugs.webkit.org/show_bug.cgi?id=69134
41
42         Reviewed by Andreas Kling.
43
44         * WebKitTestRunner/PlatformWebView.h:
45         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
46
47 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
48
49         [EFL] Only save the current viewport in PixelDumpSupportEfl.
50         https://bugs.webkit.org/show_bug.cgi?id=68450
51
52         Reviewed by Antonio Gomes.
53
54         The previous implementation saved the whole page contents in the final
55         PNG, however the baselines and expectations in the tree only want the
56         current viewport (with a scrollbar, if needed), so we now only save the
57         currently visible contents.
58
59         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
60         (createBitmapContextFromWebView): Use
61         ewk_frame_visible_content_geometry_get instead of
62         ewk_frame_contents_size_get.
63
64 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
65
66         [EFL] Support and keep track of extra windows (views).
67         https://bugs.webkit.org/show_bug.cgi?id=68454
68
69         Reviewed by Antonio Gomes.
70
71         So far, window.open and related JavaScript code would not work, as
72         DRTView did not implementation
73         Ewk_View_Smart_Class::window_{open,close}. The default implementation
74         in ewk just returns the current window/view, which broke any
75         layouttest which relied on window.open.
76
77         We now properly create and remove these new views. Unfortunately, the
78         current way ewk works (and due to the fact that we cannot pass class
79         methods as function pointers to the EFL functions), DRTView needs to
80         know that DRTChrome exists and call `browser' directly in some points.
81
82         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
83         (onWindowCreate):
84         (onWindowCloseDelayed):
85         (onWindowClose):
86         (drtViewTiledAdd):
87
88 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
89
90         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
91         https://bugs.webkit.org/show_bug.cgi?id=42698
92
93         Reviewed by Andreas Kling.
94
95         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
96         and call clearApplicationCache when layoutTest start up.
97
98         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
99         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
100         (WTR::InjectedBundle::beginTesting):
101         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
102         (WTR::LayoutTestController::clearAllApplicationCaches):
103         (WTR::LayoutTestController::setAppCacheMaximumSize):
104         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
105
106 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
107
108         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
109         https://bugs.webkit.org/show_bug.cgi?id=69145
110
111         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
112         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
113         and is perfectly suitable for SceneGraph as well. GraphicsScene events
114         will not be available in QtGui anymore in future. Therefore we also have to change
115         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
116
117         Reviewed by Chang Shu.
118
119         * WebKitTestRunner/EventSenderProxy.h:
120         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
121         (WTR::EventSenderProxy::createMouseEvent):
122         (WTR::EventSenderProxy::mouseDown):
123         (WTR::EventSenderProxy::mouseUp):
124         (WTR::EventSenderProxy::mouseMoveTo):
125
126 2011-09-30  James Robinson  <jamesr@chromium.org>
127
128         [chromium] Add WebKit API for sending input events to the compositor thread
129         https://bugs.webkit.org/show_bug.cgi?id=69117
130
131         Reviewed by Darin Fisher.
132
133         Adds support for creating and setting a compositor thread in DRT.
134
135         * DumpRenderTree/chromium/WebViewHost.cpp:
136         (WebViewHost::WebViewHost):
137         * DumpRenderTree/chromium/WebViewHost.h:
138
139 2011-09-29  David Levin  <levin@chromium.org>
140
141         watchlist: Add cross-checks for WatchList once it is filled.
142         https://bugs.webkit.org/show_bug.cgi?id=68975
143
144         Reviewed by Eric Seidel.
145
146         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
147         instead of having trivial getter and setters.
148         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
149         pass the validation checks.
150         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
151         and fix a few style nits.
152         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
153         validation checks.
154         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
155
156 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
157
158         run-api-tests fails on chromium-win bot
159         https://bugs.webkit.org/show_bug.cgi?id=69121
160
161         On Windows running a perl script needs the interpreter.
162
163         Reviewed by Adam Barth.
164
165         * Scripts/run-api-tests:
166         (buildTestTool):
167
168 2011-09-29  Adam Barth  <abarth@webkit.org>
169
170         Attempt to make this tool work on Windows.
171
172         * Scripts/run-api-tests:
173         (buildTestTool):
174
175 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
176
177         [Qt] Try to fix the minial build
178
179         * QtTestBrowser/launcherwindow.cpp:
180         * QtTestBrowser/webpage.cpp:
181
182 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
183
184         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
185
186         QWidget and friends now live in the QtWidgets library. We update
187         includes in implementation files and private headers to us the
188         non-module-prefixed path, and leave the lookup for the include
189         path. For public headers we have to ifdef the includes as the
190         user might now have the modules we need in his QT config.
191
192         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
193         have to update our code and use windowHandle() for setting the
194         parent relationships.
195
196         https://bugs.webkit.org/show_bug.cgi?id=68687
197
198         Reviewed by Andreas Kling.
199
200         * DumpRenderTree/qt/DumpRenderTree.pro:
201         * DumpRenderTree/qt/ImageDiff.pro:
202         * MiniBrowser/qt/BrowserView.cpp:
203         * MiniBrowser/qt/BrowserView.h:
204         * MiniBrowser/qt/BrowserWindow.cpp:
205         * MiniBrowser/qt/BrowserWindow.h:
206         * MiniBrowser/qt/MiniBrowser.pro:
207         * MiniBrowser/qt/MiniBrowserApplication.h:
208         * MiniBrowser/qt/main.cpp:
209         * QtTestBrowser/QtTestBrowser.pro:
210         * QtTestBrowser/launcherwindow.cpp:
211         * QtTestBrowser/launcherwindow.h:
212         * QtTestBrowser/locationedit.h:
213         * QtTestBrowser/main.cpp:
214         * QtTestBrowser/mainwindow.cpp:
215         * QtTestBrowser/mainwindow.h:
216         * QtTestBrowser/webinspector.h:
217         * QtTestBrowser/webpage.cpp:
218         * QtTestBrowser/webview.cpp:
219         * WebKitTestRunner/PlatformWebView.h:
220         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
221
222 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
223
224         Initial implementation of WebInspector for WebKit2 GTK port.
225         https://bugs.webkit.org/show_bug.cgi?id=68235
226
227         Reviewed by Martin Robinson.
228
229         * MiniBrowser/gtk/BrowserWindow.c:
230         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
231
232 2011-09-29  Adam Barth  <abarth@webkit.org>
233
234         Unbreak the "update expectatations" button by using the existing
235         machinery to create the failureInfo objects.
236
237         Unbreak the "close" button on the progress dialog by using |this|
238         instead of the old name of the object.
239
240         Teach the controllers unit test not to talk to the actual network.
241
242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
245
246 2011-09-29  Hans Wennborg  <hans@chromium.org>
247
248         IndexedDB: Use LevelDB also for in-memory databases
249         https://bugs.webkit.org/show_bug.cgi?id=68903
250
251         Reviewed by Steve Block.
252
253         Remove the temporary dir that was necessary before LevelDB supported
254         in-memory databases.
255
256         * DumpRenderTree/chromium/TestShell.cpp:
257         (TestShell::TestShell):
258         * DumpRenderTree/chromium/TestShell.h:
259
260 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
261
262         Run TestWebKitAPI on Chromium buildbots
263         https://bugs.webkit.org/show_bug.cgi?id=68678
264
265         Reviewed by Tony Chang.
266
267         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
268
269 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
270
271         garden-o-matic results should anticipate 0 unexpected failures.
272         https://bugs.webkit.org/show_bug.cgi?id=69036
273
274         Also fixes controllers: UnexpectedFailures test.
275
276         Reviewed by Adam Barth.
277
278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
279
280 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
281
282         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
283
284         https://bugs.webkit.org/show_bug.cgi?id=67253
285
286         Reviewed by Eric Seidel.
287
288         Nearly all of the work in this was done by Simon Fraser; I'm
289         just repackaging it and cleaning it up a bit. This change
290         modifies port.diff_image() to return a tuple of (pass/fail,
291         %age), adds the value to the FailureImageHashMismatch, and
292         writes the value into the full_results.json files to be
293         displayed in the results page.
294
295         * Scripts/webkitpy/layout_tests/controllers/manager.py:
296         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
297         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
298         * Scripts/webkitpy/layout_tests/models/test_failures.py:
299         * Scripts/webkitpy/layout_tests/port/base.py:
300         * Scripts/webkitpy/layout_tests/port/chromium.py:
301         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
302         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
303         * Scripts/webkitpy/layout_tests/port/test.py:
304         * Scripts/webkitpy/layout_tests/port/webkit.py:
305         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
306
307 2011-09-25  Kentaro Hara  <haraken@chromium.org>
308
309         Unreviewed. Adding myself to committers.py.
310
311         * Scripts/webkitpy/common/config/committers.py:
312
313 2011-09-28  Adam Barth  <abarth@webkit.org>
314
315         garden-o-matic shouldn't depend on test-results.appspot.com
316         https://bugs.webkit.org/show_bug.cgi?id=69019
317
318         Reviewed by Dimitri Glazkov.
319
320         This patch moves garden-o-matic from getting full_results.json from
321         test-results.appspot.com to getting that information directly from the
322         buildbot.  This patch improve the load time and accuracy of
323         garden-o-matic because test-results.appspot.com is slow and is dropping
324         a significant number of writes (see
325         https://bugs.webkit.org/show_bug.cgi?id=68748).
326
327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
330
331 2011-09-28  David Levin  <levin@chromium.org>
332
333         watchlist: Add a way to load the watchlist from config.
334         https://bugs.webkit.org/show_bug.cgi?id=68991
335
336         Reviewed by Eric Seidel.
337
338         * Scripts/webkitpy/common/config/watchlist: Added.
339         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
340         Support for loading the watch list.
341         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
342         Tests for the loading.
343         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
344         Adjusted to use the common base class.
345         * Scripts/webkitpy/common/webkitunittest.py: Added.
346         Made a common base class for functionality used in more than one.
347
348 2011-09-28  David Levin  <levin@chromium.org>
349
350         Attempt fix for Leopard python unit test run.
351
352         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
353
354 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
355
356         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
357         https://bugs.webkit.org/show_bug.cgi?id=68938
358
359         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
360
361         Reviewed by David Hyatt.
362
363         * DumpRenderTree/chromium/WebViewHost.cpp:
364         (WebViewHost::didUpdateLayout): Added width/height queries.
365         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
366
367 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
368
369         Get rebaseline server running again
370         https://bugs.webkit.org/show_bug.cgi?id=69020
371
372         Reviewed by Adam Barth.
373
374         Make rebaseline server run again after r90337 (missing format_date_time
375         import, results_json wasn't outputting anything).
376
377         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
378         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
379
380 2011-09-28  David Grogan  <dgrogan@chromium.org>
381
382         Move dgrogan from contributor to committer
383         https://bugs.webkit.org/show_bug.cgi?id=69021
384
385         * Scripts/webkitpy/common/config/committers.py:
386
387 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
388
389         Add Mac Skia GPU bots to builders.py
390         https://bugs.webkit.org/show_bug.cgi?id=69016
391
392         Reviewed by Eric Seidel.
393
394         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
395         GPU tests.
396
397         * Scripts/webkitpy/layout_tests/port/builders.py:
398         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
399
400 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
401
402         Second try at fixing the GTK+ build.
403
404         * GNUmakefile.am:
405
406 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
407
408         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
409         https://bugs.webkit.org/show_bug.cgi?id=68680
410
411         Reviewed by Tony Chang.
412
413         * Scripts/run-chromium-webkit-unit-tests:
414         * Scripts/webkitdirs.pm:
415         (determineBaseProductDir):
416
417 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
418
419         [Gtk] Implement textInputController.doCommand
420         https://bugs.webkit.org/show_bug.cgi?id=66496
421
422         Reviewed by Martin Robinson.
423
424         * DumpRenderTree/gtk/TextInputController.cpp:
425         (doCommandCallback): Callback function for textInputController.doCommand
426
427 2011-09-28  David Levin  <levin@chromium.org>
428
429         watchlist: Suggest corrections for typos and improve error message consistency.
430         https://bugs.webkit.org/show_bug.cgi?id=68976
431
432         Reviewed by Adam Barth.
433
434         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
435         for typos and improve consistency of the error messages.
436         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
437         and improve the regex that were already present.
438
439 2011-09-28  David Levin  <levin@chromium.org>
440
441         watchlist: Add support for matching added or deleted lines.
442         https://bugs.webkit.org/show_bug.cgi?id=68972
443
444         Reviewed by Adam Barth.
445
446         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
447         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
448         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
449         to the pattern match to only have the diff lines instead of the DiffFile.
450         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
451         Add tests for the new patterns and combinations of the patterns.
452         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
453         Sort imports. Add changeline support.
454
455 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
456
457         [GTK] Add WebKitError to GTK+ WebKit2 API
458         https://bugs.webkit.org/show_bug.cgi?id=68508
459
460         Reviewed by Martin Robinson.
461
462         * GNUmakefile.am: Add path to webkitgtk derived sources to the
463         include path.
464
465 2011-09-28  Philippe Normand  <pnormand@igalia.com>
466
467         [GTK] missing WebKit2 support in run-gtk-tests
468         https://bugs.webkit.org/show_bug.cgi?id=68992
469
470         Rubber-stamped by Andreas Kling.
471
472         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
473         webkit2 directory.
474
475 2011-09-27  Philippe Normand  <pnormand@igalia.com>
476
477         [GTK] build-webkit --no-webkit2 still builds WebKit2
478         https://bugs.webkit.org/show_bug.cgi?id=68892
479
480         Reviewed by Martin Robinson.
481
482         Take the --no-webkit2 option in account when building WebKitGTK+.
483
484         * Scripts/build-webkit:
485         * Scripts/webkitdirs.pm:
486         (buildAutotoolsProject):
487         (buildGtkProject):
488
489 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
490
491         Make Chromium Win Release (Tests) a core builder
492         https://bugs.webkit.org/show_bug.cgi?id=68906
493
494         Reviewed by Adam Barth.
495
496         Add Chromium Win Release (Tests) to the list of core builders.
497
498         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
499         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
500
501 2011-09-27  Adam Barth  <abarth@webkit.org>
502
503         garden-o-matic should load faster and inform the user what is happening
504         https://bugs.webkit.org/show_bug.cgi?id=68954
505
506         Reviewed by Dimitri Glazkov.
507
508         This test disables the expected failures tab.  The web inspector showed
509         that loading the data for this tab was slowing down the loading time
510         for the whole app.  We need to find a way to load that data lazily.
511
512         This patch also improves the update message to better describe the
513         progress the app is making analyzing data from the buildbot.
514
515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
518
519 2011-09-27  Adam Barth  <abarth@webkit.org>
520
521         garden-o-matic should show the first result when examining results
522         https://bugs.webkit.org/show_bug.cgi?id=68960
523
524         Reviewed by Dimitri Glazkov.
525
526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
527
528 2011-09-27  David Levin  <levin@chromium.org>
529
530         watchlist: Add support for cc and message rules.
531         https://bugs.webkit.org/show_bug.cgi?id=68950
532
533         Reviewed by Adam Barth.
534
535         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
536         the cc's and messages for a patch.
537         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
538         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
539         for the rules.
540         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
541         A generic encapsulation of either a message list or a cc list.
542         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
543
544 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
545
546         webkit-patch doesn't like UTF-8 characters in reviewers names
547         https://bugs.webkit.org/show_bug.cgi?id=63452
548
549         Reviewed by Eric Seidel.
550
551         * Scripts/webkit-patch:
552
553 2011-09-27  Adam Barth  <abarth@webkit.org>
554
555         garden-o-matic examine buttons shows both expected and unexpected failures
556         https://bugs.webkit.org/show_bug.cgi?id=68918
557
558         Reviewed by Dimitri Glazkov.
559
560         This was a copy/paste error when I refactored this classes to share
561         more code.
562
563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
564
565 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
566
567         Add Kaustubh Atrawalkar to the list of contributors.
568
569         * Scripts/webkitpy/common/config/committers.py:
570
571 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
572
573         [Chromium] Fixed layout mode tests break subsequent tests
574         https://bugs.webkit.org/show_bug.cgi?id=68923
575         
576         Reviewed by Adam Barth.        
577
578         Reset fixed layout mode between tests, so that tests that run after
579         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
580         regular 800x600 non-fixed layout.
581
582         * DumpRenderTree/chromium/TestShell.cpp:
583         (TestShell::resetTestController):
584
585 2011-09-27  David Levin  <levin@chromium.org>
586
587         watchlist: Add the filename pattern for definitions.
588         https://bugs.webkit.org/show_bug.cgi?id=68917
589
590         Reviewed by Adam Barth.
591
592         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
593         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
594         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
595         for definitions.
596         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
597         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
598
599 2011-09-27  Adam Barth  <abarth@webkit.org>
600
601         garden-o-matic results view should sort test and builder names
602         https://bugs.webkit.org/show_bug.cgi?id=68488
603
604         Reviewed by Andy Estes.
605
606         Previously, the test and builder names were displayed in an arbitrary
607         order that changed from time to time.  That confused one user study
608         participant.  This patch sorts the lists so that they occur in a
609         predictable order.
610
611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
612
613 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
614
615         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
616         http://trac.webkit.org/changeset/96108
617         http://trac.webkit.org/changeset/96111
618         http://trac.webkit.org/changeset/96113
619         http://trac.webkit.org/changeset/96116
620         https://bugs.webkit.org/show_bug.cgi?id=68913
621
622         Wait for working Qt5 (Requested by ossy on #webkit).
623
624         * DumpRenderTree/qt/DumpRenderTree.pro:
625         * DumpRenderTree/qt/ImageDiff.pro:
626         * MiniBrowser/qt/BrowserView.cpp:
627         (BrowserView::BrowserView):
628         * MiniBrowser/qt/BrowserView.h:
629         * MiniBrowser/qt/BrowserWindow.cpp:
630         (BrowserWindow::BrowserWindow):
631         (BrowserWindow::urlChanged):
632         (BrowserWindow::~BrowserWindow):
633         * MiniBrowser/qt/BrowserWindow.h:
634         * MiniBrowser/qt/MiniBrowser.pro:
635         * MiniBrowser/qt/MiniBrowserApplication.h:
636         * MiniBrowser/qt/main.cpp:
637         * QtTestBrowser/QtTestBrowser.pro:
638         * QtTestBrowser/launcherwindow.cpp:
639         * QtTestBrowser/launcherwindow.h:
640         * QtTestBrowser/locationedit.h:
641         * QtTestBrowser/main.cpp:
642         * QtTestBrowser/mainwindow.cpp:
643         * QtTestBrowser/mainwindow.h:
644         * QtTestBrowser/webinspector.h:
645         * QtTestBrowser/webpage.cpp:
646         * QtTestBrowser/webview.cpp:
647         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
648         * WebKitTestRunner/PlatformWebView.h:
649         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
650         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
651         (WTR::WebView::wkView):
652         (WTR::WebView::pageRef):
653         (WTR::WebView::~WebView):
654         (WTR::WebView::WebView):
655         (WTR::PlatformWebView::PlatformWebView):
656         (WTR::PlatformWebView::sendEvent):
657         (WTR::PlatformWebView::postEvent):
658         * WebKitTestRunner/qt/WebKitTestRunner.pro:
659
660 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
661
662         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
663         https://bugs.webkit.org/show_bug.cgi?id=65178
664
665         Reviewed by Martin Robinson.
666
667         * GNUmakefile.am:
668         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
669
670 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
671
672         [Qt][WK2] Buildfix after r96108.
673
674         Rubber-stamped by Andreas Kling.
675
676         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
677         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
678         * WebKitTestRunner/qt/WebKitTestRunner.pro:
679
680 2011-09-27  David Levin  <levin@chromium.org>
681
682         watchlist: Change watchlistparser.py to be class based.
683         https://bugs.webkit.org/show_bug.cgi?id=68869
684
685         Reviewed by Eric Seidel.
686
687         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
688         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
689
690 2011-09-27  David Levin  <levin@chromium.org>
691
692         watchlist: Break out the diff boilerplate to allow for re-use.
693         https://bugs.webkit.org/show_bug.cgi?id=68871
694
695         Reviewed by Eric Seidel.
696
697         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
698         Break out the diff into a new file.
699         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
700
701 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
702
703         Web Inspector: UI performance: introduce heap size tracking stats.
704         https://bugs.webkit.org/show_bug.cgi?id=68901
705
706         It is interesting how much the heap memory is used by Inspector in order of running the test.
707
708         Reviewed by Yury Semikhatsky.
709
710         * DumpRenderTree/chromium/TestShell.cpp:
711         (TestShell::showDevTools):
712         (TestShell::closeDevTools):
713
714 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
715
716         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
717
718         QWidget and friends now live in the QtWidgets library. We update
719         includes in implementation files and private headers to us the
720         non-module-prefixed path, and leave the lookup for the include
721         path. For public headers we have to ifdef the includes as the
722         user might now have the modules we need in his QT config.
723
724         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
725         have to update our code and use windowHandle() for setting the
726         parent relationships.
727
728         https://bugs.webkit.org/show_bug.cgi?id=68687
729
730         Reviewed by Andreas Kling.
731
732         * DumpRenderTree/qt/DumpRenderTree.pro:
733         * DumpRenderTree/qt/ImageDiff.pro:
734         * MiniBrowser/qt/BrowserView.cpp:
735         * MiniBrowser/qt/BrowserView.h:
736         * MiniBrowser/qt/BrowserWindow.cpp:
737         * MiniBrowser/qt/BrowserWindow.h:
738         * MiniBrowser/qt/MiniBrowser.pro:
739         * MiniBrowser/qt/MiniBrowserApplication.h:
740         * MiniBrowser/qt/main.cpp:
741         * QtTestBrowser/QtTestBrowser.pro:
742         * QtTestBrowser/launcherwindow.cpp:
743         * QtTestBrowser/launcherwindow.h:
744         * QtTestBrowser/locationedit.h:
745         * QtTestBrowser/main.cpp:
746         * QtTestBrowser/mainwindow.cpp:
747         * QtTestBrowser/mainwindow.h:
748         * QtTestBrowser/webinspector.h:
749         * QtTestBrowser/webpage.cpp:
750         * QtTestBrowser/webview.cpp:
751         * WebKitTestRunner/PlatformWebView.h:
752         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
753
754 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
755
756         [Qt][WK2] Add support for hover API in Qt WebKit2
757         https://bugs.webkit.org/show_bug.cgi?id=68369
758
759         Reviewed by Andreas Kling.
760
761         Change the statusbar to show the link URL when hovering links in
762         MiniBrowser using QDesktopWebView.
763
764         * MiniBrowser/qt/BrowserWindow.cpp:
765         (BrowserWindow::BrowserWindow):
766         (BrowserWindow::onLinkHovered):
767         * MiniBrowser/qt/BrowserWindow.h:
768
769 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
770
771         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
772         https://bugs.webkit.org/show_bug.cgi?id=68864
773
774         Reviewed by Adam Barth.
775
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
780
781 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
782
783         [Qt][WK2] One more unreviewed buildfix after r96005.
784
785         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
786
787 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
788
789         [Qt][WK2] Unreviewed buildfix after r96005.
790
791         * WebKitTestRunner/qt/TestInvocationQt.cpp:
792         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
793
794 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
795
796         garden-o-matic should be pretty in Open Sans.
797         https://bugs.webkit.org/show_bug.cgi?id=68845
798
799         Reviewed by Adam Barth.
800
801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
802
803 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
804
805         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
806         https://bugs.webkit.org/show_bug.cgi?id=68841
807
808         Reviewed by Adam Barth.
809
810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
813
814 2011-09-26  David Levin  <levin@chromium.org>
815
816         watchlist: Add parsing for definition section.
817         https://bugs.webkit.org/show_bug.cgi?id=68850
818
819         Reviewed by Adam Barth.
820
821         * Scripts/webkitpy/common/watchlist/watchlist.py:
822         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
823         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
824
825 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
826
827         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
828
829         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
830         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
831         * WebKitTestRunner/win/TestInvocationWin.cpp:
832         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
833
834 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
835
836         Repaint tests don't work in WebKit2
837         https://bugs.webkit.org/show_bug.cgi?id=68453
838
839         Reviewed by Sam Weinig.
840         
841         Convert DumpRenderTree to use use the repaint rects
842         exposed via WebKit API when generating the repaint test
843         overlay.
844         
845         Fix WebKitTestRunner to work with repaint tests, again
846         using the repaint rects exposed from WK2.
847         
848         In both cases, layoutTestController.display() now just
849         forces a display of the web view, and turns on repaint
850         rect tracking on the main FrameView.
851         
852         Later, when pixel results are requested, the alpha overlay
853         that shows the repaint rects is generated using the list
854         of rects supplied by WebCore.
855
856         * DumpRenderTree/mac/DumpRenderTree.mm:
857         (resetDefaultsToConsistentValues):
858         (resetWebViewToConsistentStateBeforeTesting):
859         (displayWebView):
860         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
861         (paintRepaintRectOverlay):
862         (createBitmapContextFromWebView):
863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
864         (WTR::InjectedBundle::beginTesting):
865         (WTR::InjectedBundle::done):
866         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
867         (WTR::InjectedBundle::setRepaintRects):
868         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
869         (WTR::InjectedBundlePage::reset):
870         (WTR::InjectedBundlePage::dump):
871         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
872         (WTR::LayoutTestController::display):
873         * WebKitTestRunner/TestInvocation.cpp:
874         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
875         * WebKitTestRunner/TestInvocation.h:
876         * WebKitTestRunner/cg/TestInvocationCG.cpp:
877         (WTR::paintRepaintRectOverlay):
878         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
879
880 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
881
882         Get hover'ed element URL from HitTest.
883
884         mouseDidMoveOverElement now gets the hover'ed element link using
885         WKHitTestResult API's.
886         https://bugs.webkit.org/show_bug.cgi?id=68426 
887
888         Reviewed by Anders Carlsson.
889
890         * MiniBrowser/gtk/BrowserWindow.c:
891         (mouseDidMoveOverElement):
892
893 2011-09-26  David Levin  <levin@chromium.org>
894
895         Add skeleton parsing for a WatchList.
896         https://bugs.webkit.org/show_bug.cgi?id=68823
897
898         Reviewed by Adam Barth.
899
900         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
901         Parses the top level watch list sections -- none are defined yet -- and
902         throws an exception if an invalid one is listed.
903         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
904         Verify the exception for an invalid section in a watch list.
905         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
906
907 2011-09-26  Adam Roben  <aroben@apple.com>
908
909         Clean up code imported from WebKitAPITest
910
911         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
912         TestWebKitAPI conventions
913
914         Reviewed by David Levin.
915
916         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
917         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
918         namespace name.
919
920         (TestWebKitAPI::WebViewDestruction::SetUp):
921         (TestWebKitAPI::WebViewDestruction::webViewCount):
922         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
923         (TestWebKitAPI::WebViewDestruction::runMessagePump):
924         (TestWebKitAPI::WebViewDestruction::TearDown):
925         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
926         Moved functionality from free functions into these new test fixtures.
927
928         * TestWebKitAPI/win/HostWindow.cpp:
929         * TestWebKitAPI/win/HostWindow.h:
930         Prefixed Win32 API calls with ::. Updated namespace name.
931
932 2011-09-23  Adam Roben  <aroben@apple.com>
933
934         Merge WebKitAPITest into TestWebKitAPI
935
936         This also means that our formerly-WebKitAPITest tests will be run on the bots!
937
938         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
939         them more idiomatic in a separate pass.
940
941         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
942         functionality (and names!)
943
944         Reviewed by Anders Carlsson.
945
946         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
947         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
948         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
949
950         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
951
952         * TestWebKitAPI/win/main.cpp:
953         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
954
955         * WebKitAPITest: Removed this directory and its contents.
956
957 2011-09-23  Adam Roben  <aroben@apple.com>
958
959         Remove two failing WebKitAPITest tests
960
961         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
962
963         Reviewed by Anders Carlsson.
964
965         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
966         MainFrameAfterClose tests.
967
968 2011-09-25  Adam Barth  <abarth@webkit.org>
969
970         Finish removing PLATFORM(BREWMP) by removing associated code
971         https://bugs.webkit.org/show_bug.cgi?id=68779
972
973         Reviewed by Sam Weinig.
974
975         * Scripts/webkitpy/common/config/build.py:
976         * waf/build/settings.py:
977
978 2011-09-21  Ai Makabi  <makabi@google.com>
979
980         Provides a simple LRU cache class in Python.
981
982         https://bugs.webkit.org/show_bug.cgi?id=67823
983
984         Reviewed by Tony Chang.
985
986         * Scripts/webkitpy/common/lru_cache.py:
987         * Scripts/webkitpy/common/lru_cache_unittest.py:
988
989 2011-09-25  Adam Barth  <abarth@webkit.org>
990
991         Remove PLATFORM(HAIKU) and associated code
992         https://bugs.webkit.org/show_bug.cgi?id=68774
993
994         Reviewed by Sam Weinig.
995
996         * Scripts/webkitpy/common/config/build.py:
997         * waf/build/settings.py:
998
999 2011-09-24  Adam Barth  <abarth@webkit.org>
1000
1001         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1002         https://bugs.webkit.org/show_bug.cgi?id=68767
1003
1004         Reviewed by Eric Seidel.
1005
1006         * Scripts/build-webkit:
1007
1008 2011-09-24  Adam Barth  <abarth@webkit.org>
1009
1010         Remove ENABLE(WCSS) and associated code
1011         https://bugs.webkit.org/show_bug.cgi?id=68759
1012
1013         Reviewed by Darin Adler.
1014
1015         * Scripts/build-webkit:
1016         * Scripts/old-run-webkit-tests:
1017         * Scripts/webkitperl/features.pm:
1018         (hasFeature):
1019         * Scripts/webkitpy/layout_tests/port/webkit.py:
1020         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1021
1022 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1023
1024         Fixed GTK compilation after r95878, the operator== was defined
1025         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1026
1027         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1028
1029 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1030
1031         [DRT] Include the right config file for EFL's DRT.
1032         https://bugs.webkit.org/show_bug.cgi?id=67042
1033
1034         Reviewed by Martin Robinson.
1035
1036         Ports which use CMake as their buildsystem (such as the EFL one) also
1037         have config.h files, but they are named differently, so include the
1038         right one depending on the buildsystem being used.
1039
1040         * DumpRenderTree/config.h:
1041
1042 2011-09-23  Adam Klein  <adamk@chromium.org>
1043
1044         Add ENABLE_MUTATION_OBSERVERS feature flag
1045         https://bugs.webkit.org/show_bug.cgi?id=68732
1046
1047         Reviewed by Ojan Vafai.
1048
1049         This flag will guard an implementation of the "Mutation Observers" proposed in
1050         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1051
1052         * Scripts/build-webkit:
1053
1054 2011-09-23  Chang Shu  <cshu@webkit.org>
1055
1056         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1057         https://bugs.webkit.org/show_bug.cgi?id=68556
1058
1059         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1060
1061         Reviewed by Darin Adler.
1062
1063         * WebKitTestRunner/EventSenderProxy.h:
1064         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1065         * WebKitTestRunner/PlatformWebView.h:
1066         * WebKitTestRunner/mac/EventSenderProxy.mm:
1067         (WTR::EventSenderProxy::EventSenderProxy):
1068         (WTR::EventSenderProxy::leapForward):
1069         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1070         (WTR::EventSenderProxy::EventSenderProxy):
1071         (WTR::getMouseButton):
1072         (WTR::getModifiers):
1073         (WTR::EventSenderProxy::updateClickCountForButton):
1074         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1075         (WTR::EventSenderProxy::mouseDown):
1076         (WTR::EventSenderProxy::mouseUp):
1077         (WTR::EventSenderProxy::mouseMoveTo):
1078         (WTR::EventSenderProxy::leapForward):
1079         (WTR::EventSenderProxy::sendOrQueueEvent):
1080         (WTR::EventSenderProxy::replaySavedEvents):
1081         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1082         (WTR::PlatformWebView::postEvent):
1083         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1084
1085 2011-09-23  Lei Zhang  <thestig@chromium.org>
1086
1087         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1088         https://bugs.webkit.org/show_bug.cgi?id=68026
1089
1090         Reviewed by Dirk Pranke.
1091
1092         * Scripts/webkitpy/layout_tests/port/chromium.py:
1093
1094 2011-09-23  Elliot Poger  <epoger@google.com>
1095
1096         update layout_tests to account for new default of use_skia=1
1097         https://bugs.webkit.org/show_bug.cgi?id=68698
1098
1099         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1100         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1101         (Chromium-on-Mac now uses the Skia graphics library instead of
1102         Core Graphics).
1103
1104         Also updates layout_test code to work with that change.
1105
1106         Reviewed by Mihai Parparita.
1107
1108         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1109         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1110
1111 2011-09-23  Mark Rowe  <mrowe@apple.com>
1112
1113         Fix the build.
1114         
1115         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1116         the WTF namespace.
1117
1118 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1119
1120         enable NRWT for run-webkit-tests on Lion
1121         https://bugs.webkit.org/show_bug.cgi?id=68673
1122
1123         Reviewed by Eric Seidel.
1124
1125         * Scripts/run-webkit-tests:
1126         (useNewRunWebKitTests):
1127
1128 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1129
1130         Add unit test for existing StringBuilder
1131         https://bugs.webkit.org/show_bug.cgi?id=67080
1132
1133         Reviewed by Darin Adler.
1134
1135         * TestWebKitAPI/TestWebKitAPI.gypi:
1136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1137         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1138         (operator<<):
1139         (TestWebKitAPI::expectBuilderContent):
1140         (TestWebKitAPI::expectEmpty):
1141         (TestWebKitAPI::TEST):
1142
1143 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1144
1145         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1146         https://bugs.webkit.org/show_bug.cgi?id=68455
1147
1148         Reviewed by Antonio Gomes.
1149
1150         BackForwardItem::invoke() was using ewk_history functions to navigate
1151         in history; however, this will only call WebCore::BackForwardListImpl
1152         and not move between pages at all. We now call ewk_view_navigate and
1153         its siblings to make sure the navigation actually happens.
1154
1155         This should make tests like fast/dom/navigation-type-back-forward.html
1156         stop timing out.
1157
1158         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1159         (BackForwardItem::invoke):
1160
1161 2011-09-22  Dean Jackson  <dino@apple.com>
1162
1163         Add ENABLE_CSS_FILTERS
1164         https://bugs.webkit.org/show_bug.cgi?id=68652
1165
1166         Reviewed by Simon Fraser.
1167
1168         * Scripts/build-webkit:
1169
1170 2011-09-22  Anders Carlsson  <andersca@apple.com>
1171
1172         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1173         https://bugs.webkit.org/show_bug.cgi?id=68660
1174
1175         Reviewed by Adam Barth.
1176
1177         * WebKitTestRunner/mac/EventSenderProxy.mm:
1178         (WTR::EventSenderProxy::mouseUp):
1179
1180 2011-09-22  Adam Roben  <aroben@apple.com>
1181
1182         Remove FindSafari
1183
1184         It isn't used or built anymore.
1185
1186         Fixes <http://webkit.org/b/68628>
1187
1188         Reviewed by Darin Adler.
1189
1190         * FindSafari: Removed this directory and its contents.
1191
1192 2011-09-22  Adam Roben  <aroben@apple.com>
1193
1194         Remove FindSafari from all our .sln files
1195
1196         It isn't used anymore, so there's no point in building it.
1197
1198         Part of <http://webkit.org/b/68628> Remove FindSafari
1199
1200         Reviewed by Steve Falkenburg.
1201
1202         * DumpRenderTree/DumpRenderTree.sln:
1203         * WebKitTestRunner/WebKitTestRunner.sln:
1204
1205 2011-09-22  Adam Roben  <aroben@apple.com>
1206
1207         Remove all uses of FindSafari
1208
1209         It isn't really needed anymore.
1210
1211         Fixes <http://webkit.org/b/68626>.
1212
1213         Reviewed by Darin Adler.
1214
1215         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1216
1217         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1218         WebKit, but now we use WebKit.exe for that.
1219
1220         * Scripts/webkitdirs.pm:
1221         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1222         do the same thing.
1223
1224         (readRegistryString):
1225         (writeRegistryString):
1226         Moved here from old-run-webkit-tests.
1227
1228 2011-09-22  Adam Roben  <aroben@apple.com>
1229
1230         Use the "direct object" form of system() to run WebKit.exe
1231
1232         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1233         path to WebKit.exe.
1234
1235         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1236         %WEBKITOUTPUTDIR%
1237
1238         Reviewed by Steve Falkenburg.
1239
1240         * Scripts/webkitdirs.pm:
1241         (runSafari):
1242
1243 2011-09-22  Adam Roben  <aroben@apple.com>
1244
1245         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1246
1247         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1248         spaces in the path to the WebKit source tree
1249
1250         Reviewed by John Sullivan.
1251
1252         * Scripts/webkitdirs.pm:
1253         (setupCygwinEnv):
1254
1255 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1256
1257         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1258
1259         QApplication will initialize the default application font based
1260         on the application DPI at construction time, but we then override
1261         the application DPI using QX11Info (hard-coding it to 96 for
1262         consistency). This hard-coding is not reflected in the application
1263         font, so we explicitly have update the font ourselves.
1264
1265         The 6 test results that are updated were originally produced with
1266         a DPI of 75, as this is the default fallback DPI when a QFont is
1267         constructed before QApplication. This was wrong, and the results
1268         are updated to match a DPI of 96.
1269
1270         Reviewed by Csaba Osztrogonác.
1271
1272         * DumpRenderTree/qt/main.cpp:
1273         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1274
1275 2011-09-21  Anna Cavender  <annacc@chromium.org>
1276
1277         Update committers.py with a new contributor contact        
1278         https://bugs.webkit.org/show_bug.cgi?id=68565
1279
1280         Reviewed by Eric Carlson.
1281
1282         * Scripts/webkitpy/common/config/committers.py:
1283
1284 2011-09-21  Chang Shu  <cshu@webkit.org>
1285
1286         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1287         https://bugs.webkit.org/show_bug.cgi?id=68108
1288
1289         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1290         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1291         platform as the first step so the existing code is still kept for other platforms.
1292
1293         Reviewed by Darin Adler.
1294
1295         * WebKitTestRunner/EventSenderProxy.h:
1296         (WTR::EventSenderProxy::EventSenderProxy):
1297         (WTR::EventSenderProxy::leapForward):
1298         (WTR::EventSenderProxy::currentEventTime):
1299         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1300         (WTR::EventSendingController::EventSendingController):
1301         (WTR::EventSendingController::mouseDown):
1302         (WTR::EventSendingController::mouseUp):
1303         (WTR::EventSendingController::mouseMoveTo):
1304         (WTR::EventSendingController::leapForward):
1305         (WTR::EventSendingController::keyDown):
1306         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1307         * WebKitTestRunner/TestController.cpp:
1308         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1309         * WebKitTestRunner/mac/EventSenderProxy.mm:
1310         (WTR::eventTypeForMouseButtonAndAction):
1311         (WTR::operator==):
1312         (WTR::EventSenderProxy::updateClickCountForButton):
1313         (WTR::EventSenderProxy::mouseDown):
1314         (WTR::EventSenderProxy::mouseUp):
1315         (WTR::EventSenderProxy::mouseMoveTo):
1316         (WTR::EventSenderProxy::keyDown):
1317         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1318         (WTR::EventSenderProxy::keyDown):
1319         (WTR::EventSenderProxy::mouseDown):
1320         (WTR::EventSenderProxy::mouseUp):
1321         (WTR::EventSenderProxy::mouseMoveTo):
1322
1323 2011-09-21  Dan Bernstein  <mitz@apple.com>
1324
1325         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1326         https://bugs.webkit.org/show_bug.cgi?id=68451
1327
1328         Reviewed by Darin Adler.
1329
1330         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1331         Objective-C classes with names not having one of a list of prefixes
1332         passed on the command line.
1333
1334 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1335
1336         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1337         https://bugs.webkit.org/show_bug.cgi?id=68206
1338
1339         Reviewed by Tony Chang.
1340
1341         * Scripts/webkitdirs.pm:
1342         (determineBaseProductDir): add support for chromium-mac
1343         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1344         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1345
1346 2011-09-21  Adam Barth  <abarth@webkit.org>
1347
1348         garden-o-matic command should explain that it is starting a local server
1349         https://bugs.webkit.org/show_bug.cgi?id=68486
1350
1351         Reviewed by Dimitri Glazkov.
1352
1353         In the user study, both participants didn't understand why the
1354         garden-o-matic command appeared to hang.  This patch adds an
1355         explaination of what's going on.  It also adds a confirmation prompt
1356         before launching the browser to give the user a chance to read the
1357         text.  If that's too much of a speed bump, we can iterate.
1358
1359         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1360
1361 2011-09-21  Chang Shu  <cshu@webkit.org>
1362
1363         [Qt] Implement KeyDown function for WebKit2 EventSender.
1364         https://bugs.webkit.org/show_bug.cgi?id=56485
1365
1366         Implement the KeyDown function on Qt platform.
1367
1368         Reviewed by Andreas Kling.
1369
1370         * WebKitTestRunner/PlatformWebView.h:
1371         * WebKitTestRunner/TestController.cpp:
1372         (WTR::TestController::TestController):
1373         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1374         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1375         (WTR::getModifiers):
1376         (WTR::EventSenderProxy::keyDown):
1377         (buildModifierFlags):
1378         (EventSenderProxy::keyDown):
1379         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1380         (WTR::PlatformWebView::sendEvent):
1381         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1382
1383 2011-09-20  Adam Barth  <abarth@webkit.org>
1384
1385         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1386         https://bugs.webkit.org/show_bug.cgi?id=68496
1387
1388         Reviewed by Dimitri Glazkov.
1389
1390         This patch adds a bunch of sorting to make sure things happen in a
1391         predictable order in both JavaScriptCore and V8.  We've talked before
1392         about whether these two JavaScript engines should enumerate
1393         dictionaries in the same order, but the consensus has been that they
1394         shouldn't.  Personally, I disagree with that consensus, but such is life.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1400
1401 2011-09-20  Adam Barth  <abarth@webkit.org>
1402
1403         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1404         https://bugs.webkit.org/show_bug.cgi?id=68495
1405
1406         Reviewed by Dimitri Glazkov.
1407
1408         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1411
1412 2011-09-20  Eric Seidel  <eric@webkit.org>
1413
1414         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1415         https://bugs.webkit.org/show_bug.cgi?id=65781
1416
1417         Reviewed by Ryosuke Niwa.
1418
1419         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1420         to resolve the passed in url relative to the absolute url for the test.
1421         For http tests, since the test url is an http url, we can't resolve relative
1422         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1423         for resolving.
1424
1425         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1426         (which resolves the path relative to the built location of the DRT executable)
1427         and we should move this new code into a shared location in a follow-up patch.
1428
1429         It turns out that there was a second use for pathToLocalResource, used by one
1430         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1431         To support this test I made the new pathToLocalResource smart enough to map
1432         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1433
1434         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1435         (LayoutTestController::pathToLocalResource):
1436         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1437
1438 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1439
1440         Need to specify a django version, instead of using default
1441         https://bugs.webkit.org/show_bug.cgi?id=68398
1442
1443         Reviewed by Eric Seidel.
1444
1445         * QueueStatusServer/__init__.py:
1446         * QueueStatusServer/main.py:
1447
1448 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1449
1450         Update committers.py with a few more contributor contacts
1451         https://bugs.webkit.org/show_bug.cgi?id=68487
1452
1453         Reviewed by Eric Seidel.
1454
1455         * Scripts/webkitpy/common/config/committers.py:
1456
1457 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1458
1459         Fix webkitpy unit tests after 95547 and 95549
1460         https://bugs.webkit.org/show_bug.cgi?id=68483
1461
1462         Reviewed by Adam Barth.
1463         
1464         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1465
1466         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1467         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1468         While testing parse_latest_entry_from_file(), expect the correct
1469         touched_files() list.
1470
1471 2011-09-20  Adam Barth  <abarth@webkit.org>
1472
1473         garden-o-matic makes it hard to compare images when scroll bars appear
1474         https://bugs.webkit.org/show_bug.cgi?id=68482
1475
1476         Reviewed by Eric Seidel.
1477
1478         Because we autoscale image width, the images rescale if we overflow
1479         vertically and get a scrollbar.  That makes it hard to compare two sets
1480         of images.  This patch reserves space for the scrollbar so we won't
1481         have the layout change.
1482
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1484
1485 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1486
1487         Unreviewed, rolling out r95565.
1488         http://trac.webkit.org/changeset/95565
1489         https://bugs.webkit.org/show_bug.cgi?id=68470
1490
1491         Broke builds (Requested by andersca on #webkit).
1492
1493         * MiniBrowser/gtk/BrowserWindow.c:
1494         (mouseDidMoveOverElement):
1495
1496 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1497
1498         Get hover'ed element URL from HitTest.
1499         
1500         mouseDidMoveOverElement now gets the hover'ed element link using
1501         WKHitTestResult API's.
1502         https://bugs.webkit.org/show_bug.cgi?id=68426
1503
1504         Reviewed by Anders Carlsson.
1505
1506         * MiniBrowser/gtk/BrowserWindow.c:
1507         (mouseDidMoveOverElement):
1508
1509 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1510
1511         Changelog class should have a method to return all entries
1512         https://bugs.webkit.org/show_bug.cgi?id=68399
1513         
1514         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1515         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1516
1517         Reviewed by Ryosuke Niwa.
1518
1519         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1520         and adapt it to become a generator.
1521         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1522
1523 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1524
1525         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1526         https://bugs.webkit.org/show_bug.cgi?id=51159
1527
1528         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1529         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1530         
1531         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1532
1533         Reviewed by Kenneth Rohde Christiansen.
1534
1535         * DumpRenderTree/qt/DumpRenderTree.pro:
1536         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1537         * DumpRenderTree/qt/resources/user.css: Added.
1538         (body):
1539         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1540         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1541         * WebKitTestRunner/qt/resources/user.css: Added.
1542         (body):
1543
1544 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1545
1546         ChangeLogEntry class should contain a list of touched files
1547         https://bugs.webkit.org/show_bug.cgi?id=68115
1548
1549         Reviewed by Eric Seidel.
1550         
1551         Add method to return the list of files touched in a ChangeLog entry.
1552
1553         * Scripts/webkitpy/common/checkout/changelog.py: Add
1554         touched_files_regexp and touched_files() method.
1555         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1556         unit tests for touched_files() method.
1557
1558 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1559
1560         Unreviewed, rolling out r95526 and r95541.
1561         http://trac.webkit.org/changeset/95526
1562         http://trac.webkit.org/changeset/95541
1563         https://bugs.webkit.org/show_bug.cgi?id=68443
1564
1565         It broke 6 tests (Requested by ossy_ on #webkit).
1566
1567         * DumpRenderTree/qt/main.cpp:
1568         (main):
1569         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1570         (WTR::activateFonts):
1571
1572 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1573
1574         Fix patch and bug numbering in the mocktool simulation code
1575         https://bugs.webkit.org/show_bug.cgi?id=68374
1576
1577         Reviewed by Adam Barth.
1578
1579         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1580         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1581         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1582         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1583         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1584         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1585         * Scripts/webkitpy/tool/commands/download_unittest.py:
1586         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1587         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1588         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1589         * Scripts/webkitpy/tool/commands/queuestest.py:
1590         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1591         * Scripts/webkitpy/tool/mocktool.py:
1592         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1593         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1594
1595 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1596
1597         [Qt] Don't override default QApplication font for DRT and WTR
1598
1599         Revision 95526 moved the relevant code below the QApplication
1600         constructor, to fix a potential crash, and that made the code
1601         take effect, breaking 6 tests.
1602
1603         We should rely on the QWebSettings to set default fonts, and
1604         this QApplication::setFont() is a relic from when we didn't
1605         have that option, so we remove the code.
1606
1607         Reviewed by Csaba Osztrogonác.
1608
1609         * DumpRenderTree/qt/main.cpp:
1610         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1611
1612 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1613
1614         WebKitTestRunner: Provide usage if run without arguments
1615
1616         If WTR is run without either one or more filenames, or
1617         a '-' to indicate server mode, we don't need to start
1618         up the test machinery. Doing so might actually crash,
1619         as we'll exit the application immedeatly after anyways.
1620
1621         Reviewed by Simon Hausmann.
1622
1623         * WebKitTestRunner/TestController.cpp:
1624         (WTR::TestController::initialize):
1625
1626 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1627
1628         [Qt] Don't use QFont before initializing QApplication
1629
1630         Could potentially result in crash.
1631
1632         Reviewed by Simon Hausmann.
1633
1634         * DumpRenderTree/qt/main.cpp:
1635         (main):
1636
1637 2011-09-19  Adam Barth  <abarth@webkit.org>
1638
1639         Always enable ENABLE(EVENTSOURCE)
1640         https://bugs.webkit.org/show_bug.cgi?id=68414
1641
1642         Reviewed by Eric Seidel.
1643
1644         * Scripts/build-webkit:
1645
1646 2011-09-19  David Levin  <levin@chromium.org>
1647
1648         Sheriffbot rollout should be more intuitive.
1649         https://bugs.webkit.org/show_bug.cgi?id=68415
1650
1651         Reviewed by Adam Barth.
1652
1653         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1654         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1655           and a few others cases.
1656         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
1657
1658 2011-09-19  David Levin  <levin@chromium.org>
1659
1660         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
1661         https://bugs.webkit.org/show_bug.cgi?id=68391
1662
1663         Reviewed by Darin Adler.
1664
1665         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
1666         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
1667
1668 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
1669
1670         Style checker should not check public Qt WK2 API for parameter_name.
1671         https://bugs.webkit.org/show_bug.cgi?id=68359
1672
1673         Reviewed by Andreas Kling.
1674
1675         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
1676         Add an exception in the style checker to disable the check. Also added the test for it.
1677
1678         * Scripts/webkitpy/style/checker.py:
1679         * Scripts/webkitpy/style/checker_unittest.py:
1680
1681 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
1682
1683         GTK DRT leaks memory while comparing history items
1684         https://bugs.webkit.org/show_bug.cgi?id=68086
1685
1686         Reviewed by Martin Robinson.
1687         
1688         webkit_web_history_item_get_target() returns a g_strdup()'d string,
1689         so memory must be freed before compareHistoryItems() returns.
1690
1691         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1692         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
1693
1694 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1695
1696         Buildbot marks a nrwt bot red when tests are missing results
1697         https://bugs.webkit.org/show_bug.cgi?id=64812
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1702         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1703
1704 2011-09-19  Jessie Berlin  <jberlin@apple.com>
1705
1706         Sites that use history pushState or replaceState are recorded in history in Private Browsing
1707         mode.
1708         https://bugs.webkit.org/show_bug.cgi?id=68208
1709
1710         Reviewed by Brady Eidson.
1711
1712         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1713         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1714
1715         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1716         (TestWebKitAPI::didNavigateWithNavigationData):
1717         This is a context history client callback, so it should not be called when in Private
1718         Browsing. Add a call to FAIL().
1719         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1720         This is a page load client callback that happens after the didNavigateWithNavigationData
1721         callback. End the test.
1722         (TestWebKitAPI::TEST):
1723         Enable Private Browsing and load a page that uses history.pushState.
1724
1725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1726         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1727         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1728         Ditto.
1729         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1730         Ditto.
1731         * TestWebKitAPI/win/copy-resources.cmd:
1732         Ditto.
1733
1734 2011-09-16  Elliot Poger  <epoger@google.com>
1735
1736         add non-CG Webkit-Mac builds to flakiness dashboard
1737         https://bugs.webkit.org/show_bug.cgi?id=68265
1738
1739         Reviewed by Adam Barth.
1740
1741         As Chromium-on-Mac approaches the switchover from Core Graphics to
1742         Skia, we need to add the Skia version to the flakiness dashboard.
1743
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1745         * TestResultServer/static-dashboards/builders.js:
1746         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1747
1748 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1749
1750         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1751         https://bugs.webkit.org/show_bug.cgi?id=68071
1752
1753         Reviewed by Adam Barth.
1754
1755         * DumpRenderTree/chromium/WebPermissions.cpp:
1756         (WebPermissions::allowImage):
1757         * DumpRenderTree/chromium/WebPermissions.h:
1758
1759 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1760
1761         update-webkit-chromium should retry the gclient call if it fails once
1762         https://bugs.webkit.org/show_bug.cgi?id=68252
1763
1764         Reviewed by Adam Barth.
1765
1766         * Scripts/update-webkit-chromium:
1767
1768 2011-09-16  Rob Buis  <rbuis@rim.com>
1769
1770         Add Eli's rim address and change the nick.
1771
1772         * Scripts/webkitpy/common/config/committers.py:
1773
1774 2011-09-16  Anders Carlsson  <andersca@apple.com>
1775
1776         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1777         https://bugs.webkit.org/show_bug.cgi?id=68269
1778
1779         Reviewed by Geoffrey Garen.
1780
1781         Update client function signatures.
1782
1783         * MiniBrowser/gtk/BrowserWindow.c:
1784         (browserWindowUIClientInit):
1785         * MiniBrowser/mac/BrowserWindowController.m:
1786         (mouseDidMoveOverElement):
1787         (-[BrowserWindowController awakeFromNib]):
1788         * MiniBrowser/win/BrowserView.cpp:
1789         (BrowserView::create):
1790         * WebKitTestRunner/TestController.cpp:
1791         (WTR::TestController::createOtherPage):
1792         (WTR::TestController::initialize):
1793
1794 2011-09-16  Anders Carlsson  <andersca@apple.com>
1795
1796         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1797         https://bugs.webkit.org/show_bug.cgi?id=68266
1798
1799         Reviewed by John Sullivan.
1800
1801         * MiniBrowser/mac/BrowserWindowController.m:
1802         (mouseDidMoveOverElement):
1803
1804 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1805
1806         Add Vincent Scheib to the committers list.
1807
1808         * Scripts/webkitpy/common/config/committers.py:
1809
1810 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1811
1812         Unreviewed, rolling out r95285.
1813         http://trac.webkit.org/changeset/95285
1814         https://bugs.webkit.org/show_bug.cgi?id=68247
1815
1816         It broke a webkitpy test (Requested by ossy on #webkit).
1817
1818         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1819
1820 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1821
1822         Buildbot marks a nrwt bot red when tests are missing results
1823         https://bugs.webkit.org/show_bug.cgi?id=64812
1824
1825         Reviewed by Dirk Pranke.
1826
1827         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1828
1829 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1830
1831         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1832         https://bugs.webkit.org/show_bug.cgi?id=68178
1833
1834         Reviewed by Xan Lopez.
1835
1836         Add a work-around to enable WebKit2 when using build-webkit.
1837
1838         * Scripts/webkitdirs.pm:
1839         (buildAutotoolsProject): 
1840
1841 2011-09-15  James Robinson  <jamesr@chromium.org>
1842
1843         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1844
1845         * Scripts/webkitpy/common/config/committers.py:
1846
1847 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1848
1849         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1850         https://bugs.webkit.org/show_bug.cgi?id=68003
1851
1852         Reviewed by Adam Barth.
1853
1854         * Scripts/webkitpy/tool/mocktool.py:
1855         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1856         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1857
1858 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1859
1860         Python version check is confusing in test-webkitpy
1861         https://bugs.webkit.org/show_bug.cgi?id=68004
1862
1863         Reviewed by Adam Barth.
1864
1865         * Scripts/test-webkitpy:
1866
1867 2011-09-15  Eric Seidel  <eric@webkit.org>
1868
1869         Reviewed by Adam Barth.
1870
1871         webkit-patch should be able to find users and add them to bugzilla groups
1872         https://bugs.webkit.org/show_bug.cgi?id=63351
1873
1874         These are both very basic commands.  But it's now possible to find
1875         all users matching a regexp, as well as add all users matching a regexp
1876         to a set of groups.
1877
1878         bugzilla.py already knew how to find users (for validate-committer-lists)
1879         but now it has the ability to modify the user records.
1880
1881         I split some of the logic out into a new EditUsersParser class
1882         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
1883
1884         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1885         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1886         * Scripts/webkitpy/tool/commands/__init__.py:
1887         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
1888         * Scripts/webkitpy/tool/commands/findusers.py: Added.
1889
1890 2011-09-15  Eric Seidel  <eric@webkit.org>
1891
1892         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
1893         https://bugs.webkit.org/show_bug.cgi?id=68182
1894
1895         Reviewed by Adam Barth.
1896
1897         * Scripts/build-webkit:
1898         * waf/build/settings.py:
1899
1900 2011-09-15  Eric Seidel  <eric@webkit.org>
1901
1902         Unreviewed.  Make contributor email look-up case-insensitive.
1903
1904         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
1905         was missing from committers.py due to case sensitivity.
1906
1907         This also includes a test expectations update to committers_unittest.py
1908         after my previous change.
1909
1910         * Scripts/webkitpy/common/config/committers.py:
1911         * Scripts/webkitpy/common/config/committers_unittest.py:
1912         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1913
1914 2011-09-15  Eric Seidel  <eric@webkit.org>
1915
1916         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
1917
1918         Add a bunch of email aliases to committers.py for regular contributors
1919         who are committing using other email addresses than they have listed in the file.
1920
1921         * Scripts/webkitpy/common/config/committers.py:
1922
1923 2011-09-15  Eric Seidel  <eric@webkit.org>
1924
1925         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
1926         https://bugs.webkit.org/show_bug.cgi?id=68022
1927
1928         Reviewed by Ryosuke Niwa.
1929
1930         * Scripts/build-webkit:
1931         * waf/build/settings.py:
1932
1933 2011-09-15  Anders Carlsson  <andersca@apple.com>
1934
1935         Fix Mac build by including config.h where needed.
1936
1937         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1938         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1939         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1940         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1941         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1942         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1943         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1944         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1945         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1946         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1947         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1948         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1949         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1950         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
1951         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1952         * TestWebKitAPI/mac/main.mm:
1953
1954 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1955
1956         Let TestWebKitAPI work for chromium
1957         https://bugs.webkit.org/show_bug.cgi?id=67756
1958
1959         Reviewed by Sam Weinig.
1960
1961         * Scripts/build-api-tests:
1962         * Scripts/run-api-tests:
1963         (isSupportedPlatform):
1964         (runTest):
1965         (populateTests):
1966         * Scripts/webkitdirs.pm:
1967         (determineBaseProductDir):
1968         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1969         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1970         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1971         * TestWebKitAPI/InjectedBundleController.cpp:
1972         * TestWebKitAPI/InjectedBundleMain.cpp:
1973         * TestWebKitAPI/JavaScriptTest.cpp:
1974         * TestWebKitAPI/PlatformUtilities.cpp:
1975         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
1976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1977         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
1978         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1979         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1980         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1981         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1982         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1983         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1984         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1985         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1986         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1987         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1988         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1989         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1990         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1991         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1992         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1993         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1994         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1995         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1996         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1997         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1998         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1999         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2000         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2001         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2002         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2003         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2004         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2005         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2006         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2007         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2008         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2009         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2010         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2011         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2012         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2013         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2014         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2015         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2016         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2017         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2018         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2019         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2020         * TestWebKitAPI/TestsController.cpp:
2021         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2022         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2023         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2024         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2025         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2026         * TestWebKitAPI/win/main.cpp:
2027
2028 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2029
2030         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2031         https://bugs.webkit.org/show_bug.cgi?id=68145
2032
2033         This will allow for other classes in DumpRenderTree to reuse this functionality
2034
2035         Reviewed by David Levin.
2036
2037         * DumpRenderTree/chromium/TestShell.cpp:
2038         (normalizeLayoutTestURLInternal):
2039         (dumpHistoryItem):
2040         (TestShell::normalizeLayoutTestURL):
2041         * DumpRenderTree/chromium/TestShell.h:
2042
2043 2011-09-14  Ada Chan  <adachan@apple.com>
2044
2045         Add test for WKBundleFrameCopyWebArchive().
2046         https://bugs.webkit.org/show_bug.cgi?id=67857
2047
2048         Reviewed by Anders Carlsson.
2049
2050         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2051         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2052         the returned data is a valid webarchive.
2053         (TestWebKitAPI::setInjectedBundleClient):
2054         (TestWebKitAPI::didFinishLoadForFrame):
2055         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2056         injected bundle for the webarchive and check the returned webarchive.
2057         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2058         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2059         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2060         the web archive.
2061
2062         Add files to project.
2063         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2064         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066
2067 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2068
2069         committers.py should support multiple IRC nicknames
2070         https://bugs.webkit.org/show_bug.cgi?id=68110
2071
2072         Reviewed by Eric Seidel.
2073
2074         Add multiple IRC nickname support to committers.py
2075
2076         * Scripts/webkitpy/common/config/committers.py:
2077         * Scripts/webkitpy/common/config/committers_unittest.py:
2078         * Scripts/webkitpy/tool/bot/irc_command.py:
2079         * Scripts/webkitpy/tool/bot/sheriff.py:
2080
2081 2011-09-14  Jon Lee  <jonlee@apple.com>
2082
2083         Implement globalFlag for WebKitTestRunner
2084         https://bugs.webkit.org/show_bug.cgi?id=68033
2085         <rdar://problem/10119204>
2086
2087         Reviewed by Sam Weinig.
2088
2089         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2090         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2091         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2092         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2093         (WTR::LayoutTestController::globalFlag): simple getter
2094         (WTR::LayoutTestController::setGlobalFlag): simple setter
2095
2096 2011-09-13  Eric Seidel  <eric@webkit.org>
2097
2098         Remove ENABLE_SVG_USE as <use> is required by HTML5
2099         https://bugs.webkit.org/show_bug.cgi?id=68019
2100
2101         Reviewed by Ryosuke Niwa.
2102
2103         * Scripts/build-webkit:
2104         * waf/build/settings.py:
2105
2106 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2107
2108         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2109         since I can't confirm acceptable his committership.
2110
2111         * Scripts/webkitpy/common/config/committers.py:
2112
2113 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2114
2115         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2116         https://bugs.webkit.org/show_bug.cgi?id=68066
2117
2118         Reviewed by Adam Barth.
2119
2120         * DumpRenderTree/chromium/WebViewHost.cpp:
2121         * DumpRenderTree/chromium/WebViewHost.h:
2122
2123 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2124
2125         committers.py is missing some contributors
2126         https://bugs.webkit.org/show_bug.cgi?id=68059
2127
2128         Reviewed by Adam Barth.
2129
2130         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2131
2132         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2133
2134         * Scripts/webkitpy/common/config/committers.py:
2135
2136 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2137
2138         Fix webkit python test after r95061.
2139
2140         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2141
2142 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2143
2144         Add myself as a contributor. No review needed.
2145
2146         * Scripts/webkitpy/common/config/committers.py:
2147
2148 2011-09-13  Adam Barth  <abarth@webkit.org>
2149
2150         garden-o-matic has unfriendly error messages when the local server is not available
2151         https://bugs.webkit.org/show_bug.cgi?id=68042
2152
2153         Reviewed by Dimitri Glazkov.
2154
2155         This patch moves us from using alert to showing the error inline in the
2156         progress dialog.
2157
2158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2163
2164 2011-09-13  Adam Barth  <abarth@webkit.org>
2165
2166         FailureGrid in garden-o-matic should link to the builder's waterfall page
2167         https://bugs.webkit.org/show_bug.cgi?id=68036
2168
2169         Reviewed by Dimitri Glazkov.
2170
2171         One of the users in the user study thought the configurations names in
2172         the failure grid would link to the underlying bots.  That makes sense,
2173         so this patch adds the behavior.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2179
2180 2011-09-13  Adam Barth  <abarth@webkit.org>
2181
2182         garden-o-matic should be able to mark failures as expected
2183         https://bugs.webkit.org/show_bug.cgi?id=68027
2184
2185         Reviewed by Dimitri Glazkov.
2186
2187         All the back-end infrastructure exists for this operation.  This patch
2188         just adds some UI to the front-end and wires that UI up to the back
2189         end.  This exact UI will likely need some more polish, but this should
2190         be a reasonable first cut.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2197
2198 2011-09-13  Adam Barth  <abarth@webkit.org>
2199
2200         garden-o-matic should tell you about the progress of your rebaseline
2201         https://bugs.webkit.org/show_bug.cgi?id=67967
2202
2203         Reviewed by Dimitri Glazkov.
2204
2205         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2206         UI's dialog widget.  We then use ui.MessageBox to show status messages
2207         about in-progress rebaselines.  As each baseline is downloaded, the
2208         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2209
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2216
2217 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2218
2219         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2220         https://bugs.webkit.org/show_bug.cgi?id=68024
2221
2222         Reviewed by Gustavo Noronha Silva.
2223         
2224         Using g_list_count() and g_list_nth_data() together on a loop is
2225         inneficient since they're both O(n). Iterate over lists in a saner
2226         way.
2227
2228         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2229         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2230         iterate on it using g_list_next(). Free the list after done with it.
2231         (dumpBackForwardListForWebView): Instead of appending (which is
2232         expensive in GLists) history items and then iterating from the tail
2233         of the itemsToPrint list, prepend items and walk forwards as usual.
2234         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2235         remove the (unneeded) viewList variable.
2236
2237 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2238
2239         Add Eric's IRC nick.
2240
2241         * Scripts/webkitpy/common/config/committers.py:
2242
2243 2011-09-13  Anders Carlsson  <andersca@apple.com>
2244
2245         Disable C++ exceptions when building with clang
2246         https://bugs.webkit.org/show_bug.cgi?id=68031
2247         <rdar://problem/9556880>
2248
2249         Reviewed by Mark Rowe.
2250
2251         * MiniBrowser/Configurations/Base.xcconfig:
2252         * TestWebKitAPI/Configurations/Base.xcconfig:
2253         * WebKitTestRunner/Configurations/Base.xcconfig:
2254
2255 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2256
2257         [chromium] fix flakiness dashboard for chromium interactive tests
2258         https://bugs.webkit.org/show_bug.cgi?id=68029
2259
2260         Reviewed by Tony Chang.
2261
2262         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2263         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2264
2265 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2266
2267         Add Alice and Aryeh to the list of contributors.
2268
2269         * Scripts/webkitpy/common/config/committers.py:
2270
2271 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2272
2273         sheriffbot whois should also tell us email addresses
2274         https://bugs.webkit.org/show_bug.cgi?id=67975
2275
2276         Reviewed by Eric Seidel and David Levin.
2277
2278         Taught sheriffbot how to tell us contributor's email addresses.
2279
2280         * Scripts/webkitpy/tool/bot/irc_command.py:
2281         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2282
2283 2011-09-13  Eric Seidel  <eric@webkit.org>
2284
2285         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2286         https://bugs.webkit.org/show_bug.cgi?id=68018
2287
2288         Reviewed by Ryosuke Niwa.
2289
2290         * Scripts/build-webkit:
2291         * waf/build/settings.py:
2292
2293 2011-09-13  Chang Shu  <cshu@webkit.org>
2294
2295         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2296         https://bugs.webkit.org/show_bug.cgi?id=57515
2297
2298         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2299         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2300         which is synchronous, too.
2301
2302         Reviewed by Darin Adler.
2303
2304         * WebKitTestRunner/EventSenderProxy.h: Added.
2305         (WTR::EventSenderProxy::EventSenderProxy):
2306         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2307         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2308         (WTR::EventSendingController::keyDown):
2309         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2310         * WebKitTestRunner/PlatformWebView.h:
2311         (WTR::PlatformWebView::platformWindow):
2312         * WebKitTestRunner/TestController.cpp:
2313         (WTR::TestController::TestController):
2314         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2315         * WebKitTestRunner/TestController.h:
2316         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2317         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2318         (WTR::buildModifierFlags):
2319         (WTR::EventSenderProxy::keyDown):
2320
2321 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2322
2323         [EFL] DRT: Add DumpRenderTreeEfl.h
2324         https://bugs.webkit.org/show_bug.cgi?id=63993
2325
2326         Reviewed by Eric Seidel.
2327         
2328         This header contains some global variables used by EFL's
2329         DumpRenderTree implementation.
2330
2331         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2332         appropriate.
2333         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2334
2335 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2336
2337         [EFL] Send the right key names for PageUp and PageDown.
2338         https://bugs.webkit.org/show_bug.cgi?id=67044
2339
2340         Reviewed by Kenneth Rohde Christiansen.
2341
2342         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2343         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2344         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2345         such as editing/input/page-up-down-scrolls.html were timing out due to
2346         the right key down events not being sent.
2347
2348         * DumpRenderTree/efl/EventSender.cpp:
2349         (keyPadNameFromJSValue):
2350         (keyNameFromJSValue):
2351
2352 2011-09-12  Eric Seidel  <eric@webkit.org>
2353
2354         sheriffbot whois is case sensitive
2355         https://bugs.webkit.org/show_bug.cgi?id=67972
2356
2357         Reviewed by Adam Barth.
2358
2359         I also fixed a typo in the "More than 5 contributors" message
2360         from my previous commit.
2361
2362         * Scripts/webkitpy/common/config/committers.py:
2363         * Scripts/webkitpy/common/config/committers_unittest.py:
2364         * Scripts/webkitpy/tool/bot/irc_command.py:
2365         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2366
2367 2011-09-12  Eric Seidel  <eric@webkit.org>
2368
2369         sheriffbot whois should be smarter
2370         https://bugs.webkit.org/show_bug.cgi?id=67971
2371
2372         Reviewed by Adam Barth.
2373
2374         This makes sheriffbot whois basically grep the committers list
2375         making it much easier to find a contributor by name.
2376
2377         Unfortunately the current unittests depend on the real committers.py
2378         file, so as we add more eric's to the project, this unittest result will
2379         change.  I think that's OK for now.  We'll fix it when it breaks.
2380
2381         * Scripts/webkitpy/common/config/committers.py:
2382         * Scripts/webkitpy/tool/bot/irc_command.py:
2383         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2384
2385 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2386
2387         Unreviewed, rolling out r94976.
2388         http://trac.webkit.org/changeset/94976
2389         https://bugs.webkit.org/show_bug.cgi?id=67953
2390
2391         Broke a bunch of security/load& tests (Requested by rniwa on
2392         #webkit).
2393
2394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2395         (LayoutTestController::pathToLocalResource):
2396
2397 2011-09-12  Eric Seidel  <eric@webkit.org>
2398
2399         Rubber-stamped by Adam Barth.
2400
2401         Remove the "the tree is burning!" warning previously shown
2402         when landing patches.  It was a dream.  But it's just noise now.
2403
2404         Some bots will require a restart to notice the removal of the option
2405         so I've left the --ignore-builders option in for now.
2406
2407         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2408         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2409         * Scripts/webkitpy/tool/commands/download.py:
2410         * Scripts/webkitpy/tool/commands/download_unittest.py:
2411         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2412         * Scripts/webkitpy/tool/steps/__init__.py:
2413         * Scripts/webkitpy/tool/steps/commit.py:
2414         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2415         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2416
2417 2011-09-12  Eric Seidel  <eric@webkit.org>
2418
2419         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2420         https://bugs.webkit.org/show_bug.cgi?id=65781
2421
2422         Reviewed by Ryosuke Niwa.
2423
2424         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2425         to resolve the passed in url relative to the absolute url for the test.
2426
2427         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2428         (which resolves the path relative to the built location of the DRT executable)
2429         and we should move this new code into a shared location in a follow-up patch.
2430
2431         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2432         (LayoutTestController::pathToLocalResource):
2433
2434 2011-09-12  Eric Seidel  <eric@webkit.org>
2435
2436         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2437         https://bugs.webkit.org/show_bug.cgi?id=67530
2438
2439         Reviewed by Adam Barth.
2440
2441         I believe I've fixed the bug in the original patch which prompted the rollout.
2442         The previous patch was using the wrong deadline for the initial read,
2443         subtracting time.time() twice from the deadline value.
2444
2445         * Scripts/webkitpy/layout_tests/port/webkit.py:
2446         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2447
2448 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2449
2450         [Qt][WK2] WebKitTestRunner does not produce crash logs
2451         https://bugs.webkit.org/show_bug.cgi?id=67714
2452
2453         Reviewed by Chang Shu.
2454
2455         Added a simple way of generating backtrace on crash
2456         to the web process. The implementation is similar what
2457         we have in DRT. It depends on GNU libc functionality
2458         so it is only enabled where we are running in such an environment.
2459
2460         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2461         (WTR::printBacktrace):
2462         (WTR::crashHandler):
2463         (WTR::InjectedBundle::platformInitialize):
2464
2465 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2466
2467         Added my IRC nick to the committers file.
2468
2469         * Scripts/webkitpy/common/config/committers.py:
2470
2471 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2472
2473         The executable allocator makes it difficult to free individual
2474         chunks of executable memory
2475         https://bugs.webkit.org/show_bug.cgi?id=66363
2476
2477         Reviewed by Oliver Hunt.
2478         
2479         Introduced a best-fit, balanced-tree based allocator. The allocator
2480         required a balanced tree that does not allocate memory and that
2481         permits the removal of individual nodes directly (as opposed to by
2482         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2483         Changed all references to executable code to use a reference counted
2484         handle.
2485
2486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2487         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2488         (TestWebKitAPI::TEST_F):
2489         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2490         (TestWebKitAPI::Pair::findExact):
2491         (TestWebKitAPI::Pair::remove):
2492         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2493         (TestWebKitAPI::Pair::assertFoundAndRemove):
2494         (TestWebKitAPI::Pair::assertEqual):
2495         (TestWebKitAPI::Pair::assertSameValuesForKey):
2496         (TestWebKitAPI::Pair::testDriver):
2497         (TestWebKitAPI::TEST_F):
2498
2499 2011-09-10  Andy Estes  <aestes@apple.com>
2500
2501         Move myself from committers_unable_to_review to reviewers_list.
2502
2503         * Scripts/webkitpy/common/config/committers.py:
2504
2505 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2506
2507         [wx] Unreviewed build fix. MSW build fixes.
2508
2509         * DumpRenderTree/config.h:
2510         * waf/build/wxpresets.py:
2511
2512 2011-09-10  Andreas Kling  <kling@webkit.org>
2513
2514         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2515         https://bugs.webkit.org/show_bug.cgi?id=59328
2516
2517         Reviewed by Kenneth Rohde Christiansen.
2518
2519         * MiniBrowser/mac/BrowserWindowController.m:
2520         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2521
2522 2011-09-10  Adam Barth  <abarth@webkit.org>
2523
2524         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2525         and does not have access to notImplemented().
2526
2527         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2528         (openStartupDialog):
2529
2530 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2531
2532         Add a script to create a monolithic script-test
2533         https://bugs.webkit.org/show_bug.cgi?id=67747
2534
2535         Reviewed by Darin Adler.
2536
2537         * Scripts/make-new-script-test: Added.
2538
2539 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2540
2541         Adding myself to the reviewers list.
2542
2543         * Scripts/webkitpy/common/config/committers.py:
2544
2545 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2546
2547         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2548         https://bugs.webkit.org/show_bug.cgi?id=67855
2549
2550         Reviewed by Dirk Pranke.
2551
2552         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2553         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2554
2555         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2556
2557         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2558
2559 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2560
2561         Add myself to committers.py
2562         https://bugs.webkit.org/show_bug.cgi?id=67853
2563
2564         Reviewed by Darin Adler.
2565
2566         * Scripts/webkitpy/common/config/committers.py:
2567
2568 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2569
2570         [Qt] Remove common.pri
2571         https://bugs.webkit.org/show_bug.cgi?id=67814
2572
2573         Reviewed by Andreas Kling.
2574
2575         * Tools.pro:
2576
2577 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2578
2579         [NRWT] the nrwt check httpd with --no-http option
2580         https://bugs.webkit.org/show_bug.cgi?id=67835
2581
2582         Reviewed by Tony Chang.
2583
2584         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2585         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2586
2587 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2588
2589         [chromium] Implement DRT support for Android.
2590         https://bugs.webkit.org/show_bug.cgi?id=67590
2591
2592         Reviewed by Tony Chang.
2593
2594         Add 2 mechanism to make DRT interaction more robust on Android:
2595         - Send 'QUIT' to DRT to make it stop.
2596         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2597         input commands before it starts.
2598         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2599         and <clocale> for 'LC_ALL' to compile on Android.
2600
2601         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2602         as signal() man page recommends using sigaction().
2603
2604         * DumpRenderTree/DumpRenderTree.gypi:
2605         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2606         (main):
2607         * DumpRenderTree/chromium/LayoutTestController.cpp:
2608         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2609         (AlarmHandler):
2610         (TestShell::waitTestFinished):
2611         (platformInit):
2612         (openStartupDialog):
2613         (checkLayoutTestSystemDependencies):
2614         * DumpRenderTree/chromium/TestShellGtk.cpp:
2615         (AlarmHandler):
2616         (TestShell::waitTestFinished):
2617
2618 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2619
2620         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2621
2622         * waf/build/settings.py:
2623
2624 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2625
2626         Unreviewed, rolling out r94851.
2627         http://trac.webkit.org/changeset/94851
2628         https://bugs.webkit.org/show_bug.cgi?id=67847
2629
2630         It broke a webkitpy test (Requested by ossy on #webkit).
2631
2632         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2633
2634 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2635
2636         [NRWT] the nrwt check httpd with --no-http option
2637         https://bugs.webkit.org/show_bug.cgi?id=67835
2638
2639         Reviewed by Csaba Osztrogonác.
2640
2641         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2642
2643 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2644
2645         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2646         https://bugs.webkit.org/show_bug.cgi?id=67794
2647         <rdar://problem/9892024>
2648         
2649         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2650
2651         Reviewed by Brady Eidson.
2652
2653         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2654         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2655         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2656         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
2657             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
2658             didPerformServerRedirect.
2659
2660         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
2661         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
2662             our InjectedBundleTest.
2663         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
2664             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
2665             the request.
2666         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
2667
2668         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
2669         
2670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2671         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2672         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
2673         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
2674
2675 2011-09-08  David Levin  <levin@chromium.org>
2676
2677         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
2678         https://bugs.webkit.org/show_bug.cgi?id=67797
2679
2680         Reviewed by Eric Seidel.
2681
2682         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
2683         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
2684
2685 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
2686
2687         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
2688         https://bugs.webkit.org/show_bug.cgi?id=67723
2689
2690         Reviewed by Adam Barth.
2691
2692         * DumpRenderTree/chromium/EventSender.h:
2693         * DumpRenderTree/chromium/LayoutTestController.cpp:
2694         (LayoutTestController::LayoutTestController):
2695         (LayoutTestController::enableFixedLayoutMode):
2696         (LayoutTestController::setFixedLayoutSize):
2697         * DumpRenderTree/chromium/LayoutTestController.h:
2698
2699 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2700
2701         Add standalone script that filters the output of build-webkit to be more human-readable
2702         https://bugs.webkit.org/show_bug.cgi?id=44081
2703
2704         Reviewed by Daniel Bates.
2705
2706         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
2707         a build script (e.g. build-webkit) and it spits out a prettier version.
2708         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
2709         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
2710
2711 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2712
2713         Add myself to committers.py                 
2714         https://bugs.webkit.org/show_bug.cgi?id=67696
2715
2716         Reviewed by Kent Tamura.
2717
2718         * Scripts/webkitpy/common/config/committers.py:
2719
2720 2011-09-07  Adam Barth  <abarth@webkit.org>
2721
2722         rebaseline button in garden-o-matic details view should work
2723         https://bugs.webkit.org/show_bug.cgi?id=67738
2724
2725         Reviewed by Dimitri Glazkov.
2726
2727         This patch wires up the rebaseline button in garden-o-matic results
2728         details view.  The button is current per-test, so there isn't a way to
2729         rebaseline individual bots.  This is a place to start.  If we decide we
2730         want per-bot rebaselining, we'll need to think of some better UI.
2731
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2736
2737 2011-09-07  Eric Seidel  <eric@webkit.org>
2738
2739         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2740         https://bugs.webkit.org/show_bug.cgi?id=67737
2741
2742         Reviewed by Adam Barth.
2743
2744         I got a little over-eager when deprecating host.port_factory in the previous commit.
2745         Turns out that Host.port_factory was already the "modern" port/factory.py
2746         it was just the Module object.  I un-deprecated the variable, and changed it from
2747         being the module to being an actual PortFactory, passing it a host object.
2748         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2749         when instantiating a new Port object.
2750         This magically fixed the test_rebaseline test, since its now no longer talking
2751         to the real filesystem.
2752
2753         * Scripts/webkitpy/common/host.py:
2754         * Scripts/webkitpy/layout_tests/port/factory.py:
2755         * Scripts/webkitpy/tool/commands/queries.py:
2756         * Scripts/webkitpy/tool/mocktool.py:
2757
2758 2011-09-07  Eric Seidel  <eric@webkit.org>
2759
2760         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2761         https://bugs.webkit.org/show_bug.cgi?id=67734
2762
2763         Reviewed by Adam Barth.
2764
2765         Right now every place that creates a Port object has to be very careful
2766         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2767         The correct fix is for port/factory.py (which creates most port objects)
2768         to know how to pass these in automatically.  However, currently all port/factory.py
2769         functions are free functions instead of being on an object.  This patch
2770         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2771
2772         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2773         pass along the proper scm/user/filesystem to the Port object.
2774
2775         * Scripts/webkitpy/common/host.py:
2776         * Scripts/webkitpy/layout_tests/port/factory.py:
2777         * Scripts/webkitpy/tool/commands/queries.py:
2778         * Scripts/webkitpy/tool/mocktool.py:
2779
2780 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2781
2782         Unreviewed, rolling out r94441.
2783         http://trac.webkit.org/changeset/94441
2784         https://bugs.webkit.org/show_bug.cgi?id=67731
2785
2786         "MacEWSes are backed up due to new machines not able to reach
2787         git.webkit.org.  Disabling tests for now" (Requested by
2788         eseidel2 on #webkit).
2789
2790         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2791
2792 2011-09-07  Elliot Poger  <epoger@google.com>
2793
2794         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2795         https://bugs.webkit.org/show_bug.cgi?id=67324
2796
2797         Reviewed by Dirk Pranke.
2798
2799         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2800         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2801         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2802         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2803         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2804
2805 2011-09-07  Eric Boren  <borenet@gmail.com>
2806
2807         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2808         https://bugs.webkit.org/show_bug.cgi?id=66800
2809
2810         Reviewed by Darin Fisher.
2811
2812         * DumpRenderTree/chromium/EventSender.cpp:
2813         (EventSender::sendCurrentTouchEvent):
2814
2815 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2816
2817         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2818         https://bugs.webkit.org/show_bug.cgi?id=67254
2819
2820         Reviewed by Csaba Osztrogonác.
2821
2822         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2823         derived from the running location of DumpRenderTree binary.
2824
2825         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2826         (LayoutTestController::pathToLocalResource):
2827         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2828
2829 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2830
2831         REGRESSION(r94288) build-webkit doesn't work on Symbian
2832         https://bugs.webkit.org/show_bug.cgi?id=67706
2833
2834         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2835         (buildQMakeProject):
2836
2837 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2838
2839         REGRESSION(r94288) build-webkit doesn't work on Windows
2840         https://bugs.webkit.org/show_bug.cgi?id=67646
2841
2842         Roll back r94655 with a small fix.
2843
2844         * Scripts/webkitdirs.pm:
2845         (buildQMakeProject):
2846
2847 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2848
2849         Unreviewed, rolling out r94635.
2850         http://trac.webkit.org/changeset/94635
2851         https://bugs.webkit.org/show_bug.cgi?id=67704
2852
2853         Linux Touch build is failing to compile this change.
2854         (Requested by loislo on #webkit).
2855
2856         * DumpRenderTree/chromium/EventSender.cpp:
2857         (EventSender::sendCurrentTouchEvent):
2858
2859 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2860
2861         Unreviewed, rolling out r94655.
2862         http://trac.webkit.org/changeset/94655
2863         https://bugs.webkit.org/show_bug.cgi?id=67703
2864
2865         It broke Leopard debug bot (Requested by ossy on #webkit).
2866
2867         * Scripts/webkitdirs.pm:
2868
2869 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2870
2871         REGRESSION(r94288) build-webkit doesn't work on Windows
2872         https://bugs.webkit.org/show_bug.cgi?id=67646
2873
2874         Reviewed by Csaba Osztrogonác.
2875
2876         * Scripts/webkitdirs.pm:
2877
2878 2011-09-06  Eric Boren  <borenet@gmail.com>
2879
2880         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2881         https://bugs.webkit.org/show_bug.cgi?id=66800
2882
2883         Reviewed by Darin Fisher.
2884
2885         * DumpRenderTree/chromium/EventSender.cpp:
2886         (EventSender::sendCurrentTouchEvent):
2887
2888 2011-09-06  Adam Barth  <abarth@webkit.org>
2889
2890         garden-o-matic details view should having working rebaseline and next/previous buttons
2891         https://bugs.webkit.org/show_bug.cgi?id=67659
2892
2893         Reviewed by Dimitri Glazkov.
2894
2895         This patch wires up basic back/forward buttons that let you traverse
2896         through the results we're examining in the details view.  This ended up
2897         being more code than I expected, but I wanted to keep all the state
2898         information in the DOM itself.
2899
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2903
2904 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
2905
2906         fix MockFileSystem.glob(), refactor filesystem tests
2907         https://bugs.webkit.org/show_bug.cgi?id=67462
2908
2909         Reviewed by Eric Seidel.
2910
2911         In debugging why my proposed change for MockFileSystem.glob()
2912         in bug 66228 didn't work, I stumbled across two real bugs
2913         that cancelled each other out for the unit tests. I fixed those
2914         (glob shouldn't recurse into subdirs, and we weren't populating
2915         self.dirs from self.files properly).
2916
2917         I have also created a "mixin" class for tests that can be shared
2918         between the real filesystem and the mock filesystem - MockFileSystem
2919         is being used enough it needs its own tests.
2920
2921         * Scripts/webkitpy/common/system/filesystem_mock.py:
2922         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
2923         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2924
2925 2011-09-06  Anders Carlsson  <andersca@apple.com>
2926
2927         Move NPAPI headers in bridge to plugins
2928         https://bugs.webkit.org/show_bug.cgi?id=67661
2929
2930         Update forwarding headers.
2931
2932         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2933         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2934
2935 2011-09-06  Tony Chang  <tony@chromium.org>
2936
2937         [chromium] Check in 'build' for compiled binaries first
2938         https://bugs.webkit.org/show_bug.cgi?id=67549
2939
2940         Reviewed by Dirk Pranke.
2941
2942         I'm working on moving the windows build output to a common location
2943         rather than relative to the sln file.  Because of that, we need to
2944         check those build locations first for DumpRenderTree.exe.
2945
2946         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2947
2948 2011-09-06  Adam Barth  <abarth@webkit.org>
2949
2950         Use a hierarchial structure for the garden-o-matic results view
2951         https://bugs.webkit.org/show_bug.cgi?id=67620
2952
2953         Reviewed by Dimitri Glazkov.
2954
2955         This patch re-organizes the results view to use a hierachial structure
2956         for selection.  At the top-level are sections for each test.  Expanding
2957         the test section shows a tab selector for builders.
2958
2959         This structure prepares us for wiring up various actions to this view.
2960
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2962         (.):
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2964         ():
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2966         (.):
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2969         (.results-view>.toolbar):
2970         (.results-view>.toolbar ul.actions):
2971         (.results-view>.toolbar ul.actions li):
2972         (.results-grid table):
2973         (.results-grid table td, .results-view table th):
2974         (.results-grid table th):
2975         (.results-grid .text-result):
2976         (.results-grid .image-result):
2977
2978 2011-09-06  Adam Barth  <abarth@webkit.org>
2979
2980         garden-o-matic's base.probe generates spam in the JavaScript console
2981         https://bugs.webkit.org/show_bug.cgi?id=67622
2982
2983         Reviewed by Dimitri Glazkov.
2984
2985         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
2986         instead of HTMLScriptElement to test whether results exist.  This
2987         reduces the console.log spam and saves bandwidth because we can use a
2988         HEAD request instead of a GET request.
2989
2990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2991
2992 2011-09-05  Adam Barth  <abarth@webkit.org>
2993
2994         Add a tab to garden-o-matic for viewing expected failures
2995         https://bugs.webkit.org/show_bug.cgi?id=67619
2996
2997         Reviewed by Dimitri Glazkov.
2998
2999         This patch adds a basic tab to garden-o-matic that shows all the tests
3000         failing on the bots, including the expected failures.  This patch
3001         mostly involves refactoring existing classes to allow new subclasses.
3002
3003         This view is useful for when gardeners mark tests as expected to fail
3004         and then rebaseline them later.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3013
3014 2011-09-05  Adam Barth  <abarth@webkit.org>
3015
3016         Fix global variable leak in garden-o-matic
3017         https://bugs.webkit.org/show_bug.cgi?id=67617
3018
3019         Reviewed by Dimitri Glazkov.
3020
3021         Caught by running the unit tests with noglobals turned on.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3024
3025 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3026
3027         [Qt][WK2] Add pixel test support
3028         https://bugs.webkit.org/show_bug.cgi?id=66283
3029
3030         Reviewed by Andreas Kling.
3031
3032         Implemented pixel result generation by reusing the logic
3033         that we have in DumpRenderTree.
3034         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3035         (WTR::dumpImage):
3036         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3037
3038 2011-09-04  Robin Dunn  <robin@alldunn.com>
3039
3040         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3041         https://bugs.webkit.org/show_bug.cgi?id=67577
3042
3043         Reviewed by Kevin Ollivier.
3044
3045         * waf/build/settings.py:
3046
3047 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3048
3049         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3050
3051         * waf/build/settings.py:
3052
3053 2011-09-03  Dan Bernstein  <mitz@apple.com>
3054
3055         32-bit build fix.
3056
3057         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3058         (TestWebKitAPI::Util::toSTD):
3059
3060 2011-09-03  Dan Bernstein  <mitz@apple.com>
3061
3062         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3063         https://bugs.webkit.org/show_bug.cgi?id=67559
3064
3065         Reviewed by Darin Adler.
3066
3067         * DumpRenderTree/mac/DumpRenderTree.mm:
3068         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3069         the call to it.
3070         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3072         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3073         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3074         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3075         (TestWebKitAPI::Util::toSTD): Added.
3076
3077 2011-09-03  Adam Barth  <abarth@webkit.org>
3078
3079         garden-o-matic results view should have a better results selector
3080         https://bugs.webkit.org/show_bug.cgi?id=67542
3081
3082         Reviewed by Dimitri Glazkov.
3083
3084         This patch adds a basic grid-based results selector to the results
3085         view.  Currently, this grid just shows how the tests fail on the
3086         various bots.  A future patch will let you select which failure to view
3087         and to mark the failures for rebaselining.
3088
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3091           - Add some more basic functions for manipulating dictionaries.
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3095
3096 2011-09-03  Adam Barth  <abarth@webkit.org>
3097
3098         garden-o-matic results view should show Actual and Expected results for text failures
3099         https://bugs.webkit.org/show_bug.cgi?id=67536
3100
3101         Reviewed by Eric Seidel.
3102
3103         In the past, we didn't show actual and expected text results (we just
3104         showed the diff) because we didn't have the awesome six-by-two results
3105         grid.  Now that we do, we can move show these results.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3109           - Fixed some typos that were preventing these unit tests from running.
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3111         (.):
3112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3113           - Report -actual.txt and -expected.txt as possible results URLs.
3114
3115 2011-09-03  Adam Barth  <abarth@webkit.org>
3116
3117         garden-o-matic shows "ghost" failures that are already fixed
3118         https://bugs.webkit.org/show_bug.cgi?id=67535
3119
3120         Reviewed by Eric Seidel.
3121
3122         About 10% of writes fail to stick on test-results.appspot.com.  This
3123         patch causes us to fetch the full_results.json blob directly from
3124         build.chromium.org rather than relying upon AppEngine.
3125
3126         Unforuntately, we still need to get historical information from
3127         AppEngine.  That will take several patches to fix becuase I need to
3128         change the bots to write the full_results.json file to the
3129         build-specific directory in addition to the zip file.
3130
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3134
3135 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3136
3137         Unreviewed, rolling out r94458.
3138         http://trac.webkit.org/changeset/94458
3139         https://bugs.webkit.org/show_bug.cgi?id=67558
3140
3141         Caused appcache test to fail on various bots (Requested by
3142         rniwa on #webkit).
3143
3144         * Scripts/webkitpy/layout_tests/port/webkit.py:
3145         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3146
3147 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3148
3149         Unreviewed, rolling out r94453.
3150         http://trac.webkit.org/changeset/94453
3151         https://bugs.webkit.org/show_bug.cgi?id=67557
3152
3153         Caused appcache test to fail on various bots (Requested by
3154         rniwa on #webkit).
3155
3156         * Scripts/webkitpy/layout_tests/port/webkit.py:
3157
3158 2011-09-02  Michael Saboff  <msaboff@apple.com>
3159
3160         Add JSC:RegExp functional tests
3161         https://bugs.webkit.org/show_bug.cgi?id=67339
3162
3163         New perl script to build JavaScriptCore and run the RegExp tests.
3164
3165         Reviewed by Gavin Barraclough.
3166
3167         * Scripts/run-regexp-tests: Added.
3168
3169 2011-09-02  Michael Saboff  <msaboff@apple.com>
3170
3171         Add JSC:RegExp functional tests
3172         https://bugs.webkit.org/show_bug.cgi?id=67339
3173
3174         New perl script to build JavaScriptCore and run the RegExp tests.
3175
3176         Reviewed by Gavin Barraclough.
3177
3178         * Scripts/run-regexp-tests: Added.
3179
3180 2011-09-02  Eric Seidel  <eric@webkit.org>
3181
3182         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3183         https://bugs.webkit.org/show_bug.cgi?id=67530
3184
3185         Unreviewed.  Fixing typo from previous commit.
3186
3187         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3188         which exercises the code I previously made a typo in.
3189
3190         * Scripts/webkitpy/layout_tests/port/webkit.py:
3191         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3192
3193 2011-09-02  Eric Seidel  <eric@webkit.org>
3194
3195         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3196         https://bugs.webkit.org/show_bug.cgi?id=67530
3197
3198         Reviewed by Adam Barth.
3199
3200         No functional change, just reshuffling code.
3201
3202         * Scripts/webkitpy/layout_tests/port/webkit.py:
3203
3204 2011-09-02  Darin Adler  <darin@apple.com>
3205
3206         Added Subversion ignore for .pyc generated files.
3207
3208         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3209         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3210         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3211
3212 2011-09-02  Adam Barth  <abarth@webkit.org>
3213
3214         Enable testing on mac-ews
3215         https://bugs.webkit.org/show_bug.cgi?id=67505
3216
3217         Reviewed by Eric Seidel.
3218
3219         This patch enables testing on the Mac EWS, which should help
3220         contributors not turn the Mac bots red.
3221
3222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3223
3224 2011-09-01  Beth Dakin  <bdakin@apple.com>
3225
3226         https://bugs.webkit.org/show_bug.cgi?id=67451
3227         Add a test for going back to a cached page after changing the device scale factor
3228
3229         Reviewed by Adam Roben.
3230
3231         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3233         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3234         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3235         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3236         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3237         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3238         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3239         (TestWebKitAPI::TEST_F):
3240
3241         Added new function to WebKitAgnosticTest to goBack. Separated 
3242         waitForLoadToFinish() into its own function (instead of being a part of 
3243         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3244         well. Also added initializeView() so we can set the cache model.
3245         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3246         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3247         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3248         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3249         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3250         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3251         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3252         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3253         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3254
3255 2011-09-02  Anders Carlsson  <andersca@apple.com>
3256
3257         Build fix.
3258
3259         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3260         (PrivateBrowsing::ScriptableObject::pluginTest):
3261
3262 2011-09-02  Anders Carlsson  <andersca@apple.com>
3263
3264         Move private browsing test to a PluginTest subclass
3265         https://bugs.webkit.org/show_bug.cgi?id=67498
3266
3267         Reviewed by Darin Adler.
3268
3269         * DumpRenderTree/DumpRenderTree.gypi:
3270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3271         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3272         (pluginGetProperty):
3273         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3274         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3275         (PluginTest::NPP_SetValue):
3276         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3277         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3278         (PrivateBrowsing::PrivateBrowsing):
3279         (PrivateBrowsing::privateBrowsingEnabled):
3280         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3281         (PrivateBrowsing::ScriptableObject::hasProperty):
3282         (PrivateBrowsing::ScriptableObject::getProperty):
3283         (PrivateBrowsing::ScriptableObject::pluginTest):
3284         (PrivateBrowsing::NPP_New):
3285         (PrivateBrowsing::NPP_GetValue):
3286         (PrivateBrowsing::NPP_SetValue):
3287         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3288         (NPP_New):
3289         (NPP_SetValue):
3290         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3291         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3292         * GNUmakefile.am:
3293
3294 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3295
3296         [Qt] Build dependency problems
3297         https://bugs.webkit.org/show_bug.cgi?id=38054
3298
3299         Trivial fix after r94288.
3300
3301         Rubber-stamped by Andras Becsi.
3302
3303         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3304         (buildQMakeProject):
3305
3306 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3307
3308         Remove my old e-mail address and add my new one.
3309
3310         Rubber-stamped by Tor Arne Vestbø.
3311
3312         * Scripts/webkitpy/common/config/committers.py:
3313
3314 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3315
3316         [GTK] run-gtk-tests leaves a zombie Xvfb process
3317         https://bugs.webkit.org/show_bug.cgi?id=67389
3318
3319         Reviewed by Martin Robinson.
3320
3321         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3322         child process instead of doing shell redirection.
3323
3324 2011-09-01  Mark Rowe  <mrowe@apple.com>
3325
3326         Fix the build by adding some more missing return types.
3327
3328         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3329         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3330
3331 2011-09-01  Eric Seidel  <eric@webkit.org>
3332
3333         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
3334         https://bugs.webkit.org/show_bug.cgi?id=66228
3335
3336         Reviewed by Dirk Pranke.
3337
3338         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
3339         The LeaksViewer tool globs for all *-leaks.txt files.
3340         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
3341
3342         In order to test this I had to fix a limitation in our MockFileSystem.glob
3343         method.  However, doing so uncovered a typo and bug in the integration tests.
3344         I've disabled the offending integration tests.
3345
3346         * Scripts/webkitpy/common/system/filesystem_mock.py:
3347         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3348         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3349
3350 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
3351
3352         Adds a LayoutTestController method to make it possible to test
3353         starting speech input via an API call.
3354         https://bugs.webkit.org/show_bug.cgi?id=60170
3355
3356         Reviewed by Dimitri Glazkov.
3357
3358         * DumpRenderTree/LayoutTestController.h:
3359         * DumpRenderTree/chromium/LayoutTestController.cpp:
3360         (LayoutTestController::LayoutTestController):
3361         (LayoutTestController::startSpeechInput):
3362         * DumpRenderTree/chromium/LayoutTestController.h:
3363         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3364         (LayoutTestController::startSpeechInput):
3365         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3366         (LayoutTestController::startSpeechInput):
3367         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3368         (LayoutTestController::startSpeechInput):
3369         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3370         (LayoutTestController::startSpeechInput):
3371         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3372         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3373         (LayoutTestController::startSpeechInput):
3374         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3375         (LayoutTestController::startSpeechInput):
3376
3377 2011-09-01  Tim Horton  <hortont424@gmail.com>
3378
3379         Fix TestWebKitAPI build on clang-2.0
3380
3381         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3382
3383 2011-09-01  Adam Barth  <abarth@webkit.org>
3384
3385         Remove unused "extension" parameter from rebaseline gardeningserver handler
3386         https://bugs.webkit.org/show_bug.cgi?id=67384
3387
3388         Reviewed by James Robinson.
3389
3390         This parameter hasn't done anything in a while.
3391
3392         * Scripts/webkitpy/tool/commands/rebaseline.py:
3393         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3394         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3395
3396 2011-09-01  Eric Seidel  <eric@webkit.org>
3397
3398         Unreviewed.
3399
3400         Fix a typo in unittests.  Unfortunately fixing it
3401         caused several assertions.  Just disabling the test
3402         instead, since it was providing no value before due to the typo.
3403
3404         * Scripts/webkitpy/layout_tests/port/test.py:
3405
3406 2011-09-01  Adam Barth  <abarth@webkit.org>
3407
3408         Add a "rebaseline" button to the garden-o-matic summary page
3409         https://bugs.webkit.org/show_bug.cgi?id=67382
3410
3411         Reviewed by Dimitri Glazkov.
3412
3413         As much as we might wish folks to not rebaseline entire test groups at
3414         once, the truth is that doing so is a common operation.  Adding a
3415         button for this operation is likely to make folks happy.
3416
3417         This patch also cleans up a bunch of plumbing surrounding failureInfo
3418         objects.
3419
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3430
3431 2011-09-01  Adam Barth  <abarth@webkit.org>
3432
3433         garden-o-matic should let the gardener assign blame for a group of test failures
3434         https://bugs.webkit.org/show_bug.cgi?id=67379
3435
3436         Reviewed by Dimitri Glazkov.
3437
3438         If a group of test failures has a large revision range, the gardener
3439         might wish to blame a specific revision for the failure.  Currently,
3440         this only effect of assigning blame in this way is to hide the other
3441         suspect commits.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3446
3447 2011-09-01  Adam Barth  <abarth@webkit.org>
3448
3449         Hide garden-o-matic failure table until hover
3450         https://bugs.webkit.org/show_bug.cgi?id=67376
3451
3452         Reviewed by Dimitri Glazkov.
3453
3454         This patch removes the failure table for build failures (because it
3455         does not make sense) and hides the failure table for test groups until
3456         the user hovers over the test failure block, reducing visual noise.
3457
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3461
3462 2011-09-01  Adam Barth  <abarth@webkit.org>
3463
3464         Switch garden-o-matic from commitData.title to commitData.summary
3465         https://bugs.webkit.org/show_bug.cgi?id=67375
3466
3467         Reviewed by Dimitri Glazkov.
3468
3469         commitData.title is a string provided by Trac, which isn't great in all
3470         cases.  commitData.summary is my attempt to find the most important
3471         one-line summary of the commit.  This patch switches garden-o-matic
3472         over to summary.
3473
3474         Also, this patch tweaks a bunch of CSS to tighten up the summary page
3475         and reduce visual noise.
3476
3477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3480
3481 2011-09-01  Adam Barth  <abarth@webkit.org>
3482
3483         Group failing tests in garden-o-matic if there are more than three in a folder
3484         https://bugs.webkit.org/show_bug.cgi?id=67373
3485
3486         Reviewed by Dimitri Glazkov.
3487
3488         Sometimes a failure will cause many tests in a given directory to fail.
3489         When that happens, it's better to list the directory as a single item
3490         (with a count) rather than spamming all the test names.
3491
3492         (This patch also updates a bunch of unit test expected results after my last commit.)
3493
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3499
3500 2011-09-01  Adam Barth  <abarth@webkit.org>
3501
3502         Lower the visual noise from the failing builders display
3503         https://bugs.webkit.org/show_bug.cgi?id=67369
3504
3505         Reviewed by Dimitri Glazkov.
3506
3507         This patch ensures that the "Building" row in the failing builders
3508         display is always last and dims it by 50% to reduce visual noise.  This
3509         lets the gardener focus on the actual failures.
3510
3511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
3514
3515 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3516
3517         [Qt] Build dependency problems
3518         https://bugs.webkit.org/show_bug.cgi?id=38054
3519
3520         Make clean build after the defines are changed.
3521
3522         Reviewed by Csaba Osztrogonác.
3523
3524         * Scripts/webkitdirs.pm:
3525         (buildQMakeProject):
3526
3527 2011-08-31  Adam Barth  <abarth@webkit.org>
3528
3529         Move DumpRenderTree to WebKitPlatformSupport
3530         https://bugs.webkit.org/show_bug.cgi?id=67331
3531
3532         Reviewed by Darin Fisher.
3533
3534         This patch update DumpRenderTree to account for the WebKitClient =>
3535         WebKitPlatformSupport rename.
3536
3537         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3538         (NotificationPresenter::show):
3539         * DumpRenderTree/chromium/Task.cpp:
3540         (postTask):
3541
3542 2011-08-31  Eric Seidel  <eric@webkit.org>
3543
3544         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
3545         https://bugs.webkit.org/show_bug.cgi?id=67314
3546
3547         Reviewed by Adam Barth.
3548
3549         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
3550         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
3551         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
3552
3553         I also moved a bunch of code into dashboard.css which belonged there.
3554
3555         * QueueStatusServer/handlers/activebots.py: Added.
3556         * QueueStatusServer/main.py:
3557         * QueueStatusServer/stylesheets/dashboard.css:
3558         (.queue_bubble):
3559         (.queue_name):
3560         (.last_heard_from):
3561         (.status_text):
3562         (.alive):
3563         (.behind):
3564         (.dead):
3565         * QueueStatusServer/templates/activebots.html: Added.
3566         * QueueStatusServer/templates/dashboard.html:
3567         * QueueStatusServer/templates/recentstatus.html:
3568
3569 2011-08-31  Oliver Hunt  <oliver@apple.com>
3570
3571         Move CheckedArithmeticOperations.cpp to the intended location
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
3575
3576 2011-08-31  Elliot Poger  <epoger@google.com>
3577
3578         add unittest to validate the complete set of Chromium configurations
3579         https://bugs.webkit.org/show_bug.cgi?id=67211
3580
3581         Reviewed by Adam Barth.
3582
3583         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3584
3585 2011-08-31  Nico Weber  <thakis@chromium.org>
3586
3587         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
3588         https://bugs.webkit.org/show_bug.cgi?id=67297
3589
3590         Reviewed by Tony Chang.
3591
3592         Explicitly disable smooth scrolling in chromium's DRT.
3593
3594         * DumpRenderTree/chromium/WebPreferences.cpp:
3595         (WebPreferences::applyTo):
3596
3597 2011-08-31  Oliver Hunt  <oliver@apple.com>
3598
3599         Add Checked<> tests to windows build
3600
3601         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3602
3603 2011-08-30  Oliver Hunt  <oliver@apple.com>
3604
3605         Add support for checked arithmetic
3606         https://bugs.webkit.org/show_bug.cgi?id=67095
3607
3608         Reviewed by Sam Weinig.
3609
3610         Add test cases for Checked<>
3611
3612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3613         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
3614
3615 2011-08-31  Adam Barth  <abarth@webkit.org>
3616
3617         Move summary.html to garden-o-matic.html.
3618
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
3623
3624 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
3625
3626         [chromium] DRT linux should pass nativeKeyCode to plugins
3627         https://bugs.webkit.org/show_bug.cgi?id=66679
3628
3629         Reviewed by Tony Chang.
3630
3631         * DumpRenderTree/chromium/EventSender.cpp:
3632         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
3633         (simulated) nativeKeyCode for the given input keyboard code.
3634
3635 2011-08-31  Adam Barth  <abarth@webkit.org>
3636
3637         Tighen up UI for garden-o-matic tab strip
3638         https://bugs.webkit.org/show_bug.cgi?id=67266
3639
3640         Reviewed by Dimitri Glazkov.
3641
3642         This patch add CSS to move the tab strip to the edges of the page and
3643         to remove some gratuitous border-radius.
3644
3645         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3646         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3647
3648 2011-08-31  Adam Barth  <abarth@webkit.org>
3649
3650         garden-o-matic results view shouldn't be horrifically ugly
3651         https://bugs.webkit.org/show_bug.cgi?id=67264
3652
3653         Reviewed by Dimitri Glazkov.
3654
3655         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
3656
3657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3660
3661 2011-08-31  Adam Barth  <abarth@webkit.org>
3662
3663         garden-o-matic needs a tabstrip
3664         https://bugs.webkit.org/show_bug.cgi?id=67263
3665
3666         Reviewed by Dimitri Glazkov.
3667
3668         This patch adds a basic tabstrip to garden-o-matic.  The results
3669         details view now opens in the "Results" tab, and the user can flip back
3670         and forth between the Summary and the Results tab quickly.  There's
3671         also a stub for a "Commits" tab, which is disabled.
3672
3673         This patch isn't the most beautiful in the world, but it gets the ball
3674         rolling on a multi-modal UI.
3675
3676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3681
3682 2011-08-31  Ai Makabi  <makabi@google.com>
3683
3684         Extract reference links from reftest test file.
3685         https://bugs.webkit.org/show_bug.cgi?id=66838
3686
3687         Reviewed by Shinichiro Hamaji.
3688
3689         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
3690         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
3691         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
3692
3693 2011-08-03  Philippe Normand  <pnormand@igalia.com>
3694
3695         [webkitpy] missing log import in common/net/resultsjsonparser.py
3696         https://bugs.webkit.org/show_bug.cgi?id=65606
3697
3698         Reviewed by Martin Robinson.
3699
3700         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
3701
3702 2011-08-30  Philippe Normand  <pnormand@igalia.com>
3703
3704         [stylechecker] complains about NULL usage in some gst_structure_ calls
3705         https://bugs.webkit.org/show_bug.cgi?id=67194
3706
3707         Reviewed by Martin Robinson.
3708
3709         Don't warn about NULL in some gst_structure_ calls. 0 can't be
3710         used for these, a proper sentinel is required.
3711
3712         * Scripts/webkitpy/style/checkers/cpp.py:
3713         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3714
3715 2011-08-30  Adam Barth  <abarth@webkit.org>
3716
3717         Remove old-style UI from garden-o-matic
3718         https://bugs.webkit.org/show_bug.cgi?id=67257
3719
3720         Reviewed by Dimitri Glazkov.
3721
3722         This code is nowhere near as awesome as the new hotness.  Let's remove
3723         it so it doesn't weigh us down.
3724
3725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
3726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
3727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
3730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
3731
3732 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3733
3734         [WebSocket] update pywebsocket to 0.6b5.
3735         https://bugs.webkit.org/show_bug.cgi?id=66924
3736
3737         Reviewed by Kent Tamura.
3738
3739         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3740         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
3741         0.6b3 or later supports a closing handshake handler and it is useful to
3742         verify client's closing handshake implementation.
3743         0.6b4 supports AbortedByUserException. It is useful to eliminate
3744         unnecessary server warning messages on intended abnormal closures.
3745         0.6b5 supports Python 2.5.1 or Mac 10.5.
3746
3747         * Scripts/webkitpy/thirdparty/__init__.py:
3748         Update download URL and directory path.
3749
3750 2011-08-30  Dan Bernstein  <mitz@apple.com>
3751
3752         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
3753         https://bugs.webkit.org/show_bug.cgi?id=67230
3754
3755         Reviewed by Darin Adler.
3756
3757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3758         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
3759         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
3760         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
3761         (TestWebKitAPI::TEST):
3762
3763 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
3764
3765         Add MediaSource API to HTMLMediaElement
3766         https://bugs.webkit.org/show_bug.cgi?id=64731
3767
3768         Reviewed by Eric Carlson.
3769
3770         * Scripts/build-webkit:
3771
3772 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3773
3774         Emit last progress notification before calling dispatchDidFinishLoad
3775         https://bugs.webkit.org/show_bug.cgi?id=28851
3776
3777         Reviewed by Adam Barth.
3778
3779         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
3780         Chromium and GTK ports. The first two were simple changes.
3781
3782         Some refactoring was needed in GTK port to assure that the dumps are emitted
3783         correctly and the processing after the page load finished is in the right place.
3784
3785         To detect the load finished, we use the callback for the "load-status" notifier
3786         signal of the top loading frame. And we use the deprecated "load-finished" signal
3787         for dumping (if enabled) the progress finished expected output.
3788
3789         * DumpRenderTree/LayoutTestController.cpp:
3790         (LayoutTestController::LayoutTestController):
3791         (dumpProgressFinishedCallbackCallback):
3792         (LayoutTestController::staticFunctions):
3793         * DumpRenderTree/LayoutTestController.h:
3794         (LayoutTestController::dumpProgressFinishedCallback):
3795         (LayoutTestController::setDumpProgressFinishedCallback):
3796         * DumpRenderTree/chromium/LayoutTestController.cpp:
3797         (LayoutTestController::LayoutTestController):
3798         (LayoutTestController::dumpProgressFinishedCallback):
3799         (LayoutTestController::reset):
3800         * DumpRenderTree/chromium/LayoutTestController.h:
3801         (LayoutTestController::shouldDumpProgressFinishedCallback):
3802         (LayoutTestController::setShouldDumpProgressFinishedCallback):
3803         * DumpRenderTree/chromium/WebViewHost.cpp:
3804         (WebViewHost::didStopLoading):
3805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3806         (webViewLoadFinished):
3807         (topLoadingFrameLoadFinished):
3808         (webFrameLoadStatusNotified):
3809         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3810         (LayoutTestController::reset):
3811         (LayoutTestController::dumpProgressFinishedCallback):
3812         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3813
3814 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
3815
3816         JavaScriptCore does not have a good mechanism for performance
3817         regression testing
3818         https://bugs.webkit.org/show_bug.cgi?id=67177
3819
3820         Reviewed by Darin Adler.
3821         
3822         Added a new script, which allows for testing one, two, or more VMs
3823         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
3824         are interleaved at random to minimize systematics.  The results
3825         that bencher prints includes all possible relevant information about
3826         how bencher was invoked.  Bencher can be easily used to measure
3827         performance changes down to fractions of a percent.
3828         
3829         Bencher also includes experimental support for running benchmarks in
3830         a DumpRenderTree release build.  This works in SunSpider and V8, but
3831         not yet in Kraken.  Running benchmarks in DumpRenderTree more
3832         closely mimics the performance when running in browser.
3833
3834         * Scripts/bencher: Added.
3835
3836 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
3837
3838         DumpRenderTree should begin each test with an empty cookie store
3839         https://bugs.webkit.org/show_bug.cgi?id=63545
3840         <rdar://problem/5666907>
3841
3842         Reviewed by Darin Adler.
3843
3844         * DumpRenderTree/mac/DumpRenderTree.mm:
3845         (resetDefaultsToConsistentValues):
3846         (setDefaultsToConsistentValuesForTesting):
3847         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3848         (LayoutTestController::setAlwaysAcceptCookies):
3849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3850         (WTR::InjectedBundle::beginTesting):
3851         Use new SPIs to manipulate sessions.
3852
3853 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3854
3855         Unreviewed, rolling out r94055 and r94057.
3856         http://trac.webkit.org/changeset/94055
3857         http://trac.webkit.org/changeset/94057
3858         https://bugs.webkit.org/show_bug.cgi?id=67191
3859
3860         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
3861
3862         * Scripts/webkitpy/thirdparty/__init__.py:
3863
3864 2011-08-30  Adam Barth  <abarth@webkit.org>
3865
3866         Chromium Android should not be a core builder
3867         https://bugs.webkit.org/show_bug.cgi?id=67184
3868
3869         Reviewed by Ryosuke Niwa.
3870
3871         This bot hasn't been consistently green yet because it has never actually run!
3872
3873         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3874         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3875
3876 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3877
3878         [WebSocket] update pywebsocket to 0.6b4.
3879         https://bugs.webkit.org/show_bug.cgi?id=66924
3880
3881         Reviewed by Kent Tamura.
3882
3883         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3884         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
3885         0.6b3 or later supports a closing handshake handler and it is useful to
3886         verify client's closing handshake implementation.
3887         0.6b4 supports AbortedByUserException. It is useful to eliminate
3888         unnecessary server warning messages on intended abnormal closures.
3889
3890         * Scripts/webkitpy/thirdparty/__init__.py:
3891         Update download URL and directory path.
3892
3893 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
3894
3895         sheriffbot "usage" help statements are wrong
3896         https://bugs.webkit.org/show_bug.cgi?id=67170
3897
3898         Reviewed by Adam Barth.
3899
3900         * Scripts/webkitpy/tool/bot/irc_command.py:
3901         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3902         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3903
3904 2011-08-29  Adam Barth  <abarth@webkit.org>
3905
3906         Add support for chomium-mac (non-CoreGraphics) baselines
3907         https://bugs.webkit.org/show_bug.cgi?id=67163
3908
3909         Reviewed by Eric Seidel.
3910
3911         This patch teaches the non-CG chromium-mac bots to look at non-CG
3912         baselines.  However, the patch still leaves CG as the default set of
3913         baselines.
3914
3915         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3916         * Scripts/webkitpy/common/config/build.py:
3917         * Scripts/webkitpy/common/config/build_unittest.py:
3918         * Scripts/webkitpy/layout_tests/port/builders.py:
3919         * Scripts/webkitpy/layout_tests/port/chromium.py:
3920         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3921         * Scripts/webkitpy/layout_tests/port/factory.py:
3922         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3923         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3924         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3925         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3926
3927 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
3928
3929         Small fix in chromium port of new-run-webkit-tests.
3930         https://bugs.webkit.org/show_bug.cgi?id=67078
3931
3932         Reviewed by Dirk Pranke.
3933
3934         * Scripts/webkitpy/layout_tests/port/chromium.py:
3935
3936 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3937
3938         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
3939         r93999.
3940         http://trac.webkit.org/changeset/93987
3941         http://trac.webkit.org/changeset/93992
3942         http://trac.webkit.org/changeset/93995
3943         http://trac.webkit.org/changeset/93998
3944         http://trac.webkit.org/changeset/93999
3945         https://bugs.webkit.org/show_bug.cgi?id=67147
3946
3947         Many failing tests (Requested by ap on #webkit).
3948
3949         * DumpRenderTree/mac/DumpRenderTree.mm:
3950         (setDefaultsToConsistentValuesForTesting):
3951         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3952         (WTR::InjectedBundle::beginTesting):
3953
3954 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
3955
3956         DumpRenderTree should begin each test with an empty cookie store
3957         https://bugs.webkit.org/show_bug.cgi?id=63545
3958         <rdar://problem/5666907>
3959
3960         Reviewed by Darin Adler.
3961
3962         * DumpRenderTree/mac/DumpRenderTree.mm:
3963         (setDefaultsToConsistentValuesForTesting):
3964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3965         (WTR::InjectedBundle::beginTesting):
3966         Tell WebCore to use a temporary session, starting with a clean cookie store.
3967
3968 2011-08-23  Chris Marrin  <cmarrin@apple.com>
3969
3970         [mac] requestAnimationFrame support for mac port
3971         https://bugs.webkit.org/show_bug.cgi?id=59146
3972
3973         Reviewed by Simon Fraser.
3974
3975         Add support for request-animation-callback flag
3976
3977         * Scripts/build-webkit:
3978
3979 2011-08-27  Peter Beverloo  <peter@chromium.org>
3980
3981         Add a build bot for Chromium with OS(ANDROID)
3982         https://bugs.webkit.org/show_bug.cgi?id=66687
3983
3984         Reviewed by Adam Barth.
3985
3986         * BuildSlaveSupport/build.webkit.org-config/config.json:
3987
3988 2011-08-27  Peter Beverloo  <peter@chromium.org>
3989
3990         Update the master build bot configuration script to properly
3991         deal with the --chromium-android switch.
3992         https://bugs.webkit.org/show_bug.cgi?id=66687
3993
3994         The --chromium-android switch is needed when running
3995         update-webkit-chromium and build-webkit, as it'll tell the
3996         scripts to pull in the right dependencies and cross-compile
3997         WebKit using the Android NDK.
3998
3999         Reviewed by Adam Barth.
4000
4001         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4002
4003 2011-08-27  Peter Beverloo  <peter@chromium.org>
4004
4005         Teach the update and build scripts how to handle dependencies
4006         and cross-compiling rules for the Chromium port on OS(ANDROID).
4007         https://bugs.webkit.org/show_bug.cgi?id=66687
4008
4009         Reviewed by Adam Barth.
4010
4011         * Scripts/build-webkit:
4012         * Scripts/update-webkit:
4013         * Scripts/update-webkit-chromium:
4014         * Scripts/webkitdirs.pm:
4015         (argumentsForConfiguration):
4016         (isChromium):
4017         (isChromiumAndroid):
4018         (determineIsChromiumAndroid):
4019         (buildChromium):
4020
4021 2011-08-26  Adam Barth  <abarth@webkit.org>
4022
4023         garden-o-matic should let me know that I need to run the local server
4024         https://bugs.webkit.org/show_bug.cgi?id=66985
4025
4026         Reviewed by Dimitri Glazkov.
4027
4028         The patch triggers an alert dialog whenever the user tries to use a
4029         feature that requires the local server.
4030
4031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
4033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
4034
4035 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4036
4037         garden-o-matic summary view should have pretty commit data information.
4038         https://bugs.webkit.org/show_bug.cgi?id=67069
4039
4040         Reviewed by Adam Barth.
4041
4042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
4043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
4044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
4045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
4046
4047 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4048
4049         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
4050         https://bugs.webkit.org/show_bug.cgi?id=67066
4051
4052         Reviewed by Adam Barth.
4053
4054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
4055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4056
4057 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
4058
4059         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
4060         https://bugs.webkit.org/show_bug.cgi?id=67041
4061
4062         Reviewed by Martin Robinson.
4063
4064         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
4065         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
4066         when the GTK+ port was being built.
4067
4068         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
4069
4070 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4071
4072         Clean up and line up layout in garden-o-matic summary view.
4073         https://bugs.webkit.org/show_bug.cgi?id=67057
4074
4075         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
4076         2) Rearranged DOM structure a bit to accommodate recent changes;
4077         3) Added minimal CSS to line things up.
4078
4079         Reviewed by Adam Barth.
4080
4081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
4082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
4083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
4084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
4085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
4086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
4087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
4088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
4089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
4090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4091
4092 2011-08-26  Alice Liu  <alice.liu@apple.com>
4093
4094         https://bugs.webkit.org/show_bug.cgi?id=66823
4095         Add the request info to the WebPageProxy::CreateNewPage message
4096
4097         Reviewed by Anders Carlsson.
4098
4099         Update function declarations with additional parameter:
4100         * MiniBrowser/gtk/BrowserWindow.c:
4101         (createNewPage):
4102         * MiniBrowser/mac/BrowserWindowController.m:
4103         (createNewPage):
4104         * MiniBrowser/win/BrowserView.cpp:
4105         (createNewPage):
4106         * WebKitTestRunner/TestController.cpp:
4107         (WTR::TestController::createOtherPage):
4108         * WebKitTestRunner/TestController.h:
4109
4110 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
4111
4112         Make show-pretty-diff work on linux
4113         https://bugs.webkit.org/show_bug.cgi?id=67017
4114
4115         Reviewed by Adam Barth.
4116
4117         * Scripts/show-pretty-diff:
4118
4119 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4120
4121         Reorganize garden-o-matic CSS files to match JS-built views.
4122         https://bugs.webkit.org/show_bug.cgi?id=66998
4123
4124         Reviewed by Adam Barth.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
4130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
4131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
4132
4133 2011-08-25  Adam Barth  <abarth@webkit.org>
4134
4135         garden-o-matic should be able to roll out patches
4136         https://bugs.webkit.org/show_bug.cgi?id=66982
4137
4138         Reviewed by Dimitri Glazkov.
4139
4140         This patch just wires the rollout event through the controller to the
4141         local server, which is already set up to perform rollouts.
4142
4143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
4147
4148 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
4149
4150         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
4151         https://bugs.webkit.org/show_bug.cgi?id=66951
4152
4153         Reviewed by Andreas Kling.
4154
4155         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
4156         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
4157
4158         * MiniBrowser/qt/BrowserView.cpp:
4159         (BrowserView::resizeEvent):
4160
4161 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4162
4163         garden-o-matic summary view should provide information on builders still in flight.
4164         https://bugs.webkit.org/show_bug.cgi?id=66992
4165
4166         Reviewed by Adam Barth.
4167
4168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
4169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
4170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
4171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
4173
4174 2011-08-25  Adam Barth  <abarth@webkit.org>
4175
4176         webkit-patch rebaseline-expectations don't work when run outside the root
4177         https://bugs.webkit.org/show_bug.cgi?id=66966
4178
4179         Reviewed by Eric Seidel.
4180
4181         Turns out tool.path() used to be relative, which caused problems when
4182         running webkit-patch outside the root directory.  This patch makes it
4183         absolute.  I checked all callers, and they all appear to want this
4184         behavior.
4185
4186         It was unclear to me how to test this change because we only really
4187         have a testing strategy for webkitpy, not for the main script.
4188
4189         * Scripts/webkit-patch:
4190
4191 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4192
4193         garden-o-matic summary needs a mock view that could be used for working on styling
4194         https://bugs.webkit.org/show_bug.cgi?id=66971
4195
4196         Reviewed by Adam Barth.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
4199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
4200
4201 2011-08-25  Anders Carlsson  <andersca@apple.com>
4202
4203         Return the correct value for NPNVsupportsCarbonBool
4204         https://bugs.webkit.org/show_bug.cgi?id=66964
4205
4206         Add a test.
4207
4208         Reviewed by Adam Roben.
4209
4210         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4211         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
4212         (SupportsCarbonEventModel::SupportsCarbonEventModel):
4213         (SupportsCarbonEventModel::testConvert):
4214         (SupportsCarbonEventModel::runTest):
4215         (SupportsCarbonEventModel::NPP_New):
4216
4217 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4218
4219         garden-o-matic summary view should not be broken.
4220
4221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
4222         (table.comparison): Added more specificity.
4223
4224 2011-08-25  Adam Barth  <abarth@webkit.org>
4225
4226         This command has been broken for a while.  This patch updates the
4227         callsite to the new API.
4228
4229         * Scripts/webkitpy/tool/commands/rebaseline.py:
4230
4231 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
4232
4233         garden-o-matic needs a way to report where and how tests are failing in the summary view.
4234         https://bugs.webkit.org/show_bug.cgi?id=66955
4235
4236         Introduce FailureGrid, your one-stop failure-indicating destination. 
4237
4238         Reviewed by Adam Barth.
4239
4240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
4241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
4242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
4243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
4244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
4245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
4246
4247 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
4248
4249         Add myself to the committers list
4250         https://bugs.webkit.org/show_bug.cgi?id=66941
4251
4252         Reviewed by Andreas Kling.
4253
4254         * Scripts/webkitpy/common/config/committers.py:
4255
4256 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
4257
4258         Unreviewed, rolling out r93767.
4259         http://trac.webkit.org/changeset/93767
4260         https://bugs.webkit.org/show_bug.cgi?id=66931
4261
4262         Broke Qt bot. (Requested by yutak on #webkit).
4263
4264         * Scripts/webkitpy/thirdparty/__init__.py:
4265
4266 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
4267
4268         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
4269         https://bugs.webkit.org/show_bug.cgi?id=66924
4270
4271         Reviewed by Kent Tamura.
4272
4273         * Scripts/webkitpy/thirdparty/__init__.py:
4274
4275 2011-08-24  Adam Barth  <abarth@webkit.org>
4276
4277         The user can't close the details view in garden-o-matic
4278         https://bugs.webkit.org/show_bug.cgi?id=66911
4279
4280         Reviewed by Dimitri Glazkov.
4281
4282         In addition to adding a close button, this patch changes the test
4283         selector to use a <select> element and refactors the test selector to
4284         share code with the builder selector.
4285
4286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
4288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
4289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4290
4291 2011-08-24  James Robinson  <jamesr@chromium.org>
4292
4293         [chromium] Stacktrace not in test output when a test crashes
4294         https://bugs.webkit.org/show_bug.cgi?id=66806
4295
4296         Reviewed by Dirk Pranke.
4297
4298         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
4299         trace.
4300
4301         * Scripts/webkitpy/layout_tests/port/chromium.py:
4302
4303 2011-08-24  Adam Barth  <abarth@webkit.org>
4304
4305         Remove empty directory.
4306
4307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
4308
4309 2011-08-24  Adam Barth  <abarth@webkit.org>
4310
4311         Finish writing up details-view in garden-o-matic
4312         https://bugs.webkit.org/show_bug.cgi?id=66891
4313
4314         Reviewed by Dimitri Glazkov.
4315
4316         This patch mostly just copies a bunch of CSS from main.css to
4317         summary.css.  Presumably we'll delete main.css soon.
4318
4319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
4321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
4322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
4323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
4324
4325 2011-08-24  James Robinson  <jamesr@chromium.org>
4326
4327         Some compositing LayoutTests flakily crashing on Mac 10.6
4328         https://bugs.webkit.org/show_bug.cgi?id=66740
4329
4330         Reviewed by Adam Barth.
4331
4332         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
4333         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
4334         chromium configuration.
4335
4336         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4337         (NPP_Destroy):
4338
4339 2011-08-24 &