WebDriver: fix some nits that prevent running W3C tests on Mac
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-20  Brian Burg  <bburg@apple.com>
2
3         WebDriver: fix some nits that prevent running W3C tests on Mac
4         https://bugs.webkit.org/show_bug.cgi?id=181864
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
9         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
10         as we assume that the property exists later.
11
12         (WebDriverW3CWebServer.stop): If the temporary file doesn't
13         exist for some reason, the remove call will raise and exception.
14         Gracefully handle the case where the file isn't created due to
15         a problem/exception that happened elsewhere.
16
17 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
18
19         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
20         https://bugs.webkit.org/show_bug.cgi?id=181881
21
22         Reviewed by Alexey Proskuryakov.
23
24         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
25         (BubbleQueueServer):
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
28         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
29
30 2018-01-19  Youenn Fablet  <youenn@apple.com>
31
32         Do not go to the storage process when registering a service worker client if there is no service worker registered
33         https://bugs.webkit.org/show_bug.cgi?id=181740
34         <rdar://problem/36650400>
35
36         Reviewed by Chris Dumez.
37
38         Add support for internals inside API tests.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
42         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
43         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
44         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
45         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
46         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
47         (setConfigurationInjectedBundlePath):
48         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
49
50 2018-01-19  John Wilander  <wilander@apple.com>
51
52         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
53         https://bugs.webkit.org/show_bug.cgi?id=181822
54         https://bugs.webkit.org/show_bug.cgi?id=175263
55         https://bugs.webkit.org/show_bug.cgi?id=178536
56         https://bugs.webkit.org/show_bug.cgi?id=181223
57         https://bugs.webkit.org/show_bug.cgi?id=181482
58         <rdar://problem/33491222>
59         <rdar://problem/33805293>
60         <rdar://problem/36332683>
61         <rdar://problem/36549026>
62
63         Reviewed by Alex Christensen.
64
65         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
66         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
67         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
68         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
69         * WebKitTestRunner/InjectedBundle/TestRunner.h:
70         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
71         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
72         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
73
74 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
75
76         run-webkit-tests fails when there is a curly brace in Xcode build output
77         https://bugs.webkit.org/show_bug.cgi?id=181254
78         <rdar://problem/36453374>
79
80         Reviewed by Daniel Bates.
81
82         * Scripts/webkitpy/port/base.py:
83         (Port._run_script): Encode script output before logging it.
84
85 2018-01-19  Chris Dumez  <cdumez@apple.com>
86
87         Service worker registrations restored from disk may not be reused when the JS calls register() again
88         https://bugs.webkit.org/show_bug.cgi?id=181810
89         <rdar://problem/36591711>
90
91         Reviewed by Youenn Fablet.
92
93         Add API test coverage.
94
95         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
96         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
97         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
98
99 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
100
101         Remove El Capitan queues from flakiness dashboard
102         https://bugs.webkit.org/show_bug.cgi?id=181860
103
104         Reviewed by Aakash Jain.
105
106         * TestResultServer/static-dashboards/builders.jsonp:
107
108 2018-01-19  Keith Miller  <keith_miller@apple.com>
109
110         HaveInternalSDK includes should be "#include?"
111         https://bugs.webkit.org/show_bug.cgi?id=179670
112
113         Reviewed by Dan Bernstein.
114
115         * MiniBrowser/Configurations/Base.xcconfig:
116         * MobileMiniBrowser/Configurations/Base.xcconfig:
117         * TestWebKitAPI/Configurations/Base.xcconfig:
118         * WebKitTestRunner/Configurations/Base.xcconfig:
119
120 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
121
122         WebDriver: driver environment not passed to pytest when running w3c tests
123         https://bugs.webkit.org/show_bug.cgi?id=181852
124
125         Reviewed by Carlos Alberto Lopez Perez.
126
127         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
128
129         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
130         (WebDriverW3CExecutor.run):
131
132 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
133
134         [GTK] WebDriver: wayland display no used in wayland bot
135         https://bugs.webkit.org/show_bug.cgi?id=181851
136
137         Reviewed by Carlos Alberto Lopez Perez.
138
139         We need to handle the additionalArguments property in the WebDriverTests step.
140
141         * BuildSlaveSupport/build.webkit.org-config/steps.py:
142         (RunWebDriverTests.start):
143
144 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
145
146         [GTK] TERM environment variable is not passed to the test driver.
147         https://bugs.webkit.org/show_bug.cgi?id=181847
148
149         Rubber-stamped by by Carlos Garcia Campos.
150
151         * Scripts/webkitpy/port/base.py:
152         (Port.to.setup_environ_for_server):
153
154 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
155
156         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
157         https://bugs.webkit.org/show_bug.cgi?id=181844
158
159         Reviewed by Carlos Alberto Lopez Perez.
160
161         We always try to create the directory where to store the json file, but when the filename is given directly,
162         like in the bots, the current dir is used.
163
164         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
165         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
166         empty string.
167
168 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
169
170         [GTK] WebDriver tests are running outside the jhbuild env
171         https://bugs.webkit.org/show_bug.cgi?id=181842
172
173         Reviewed by Žan Doberšek.
174
175         We need to enter jhbuild env in run-webdriver-tests.
176
177         * Scripts/run-webdriver-tests:
178
179 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
180
181         [GTK] Run WebDriver tests in the bots
182         https://bugs.webkit.org/show_bug.cgi?id=181787
183
184         Reviewed by Michael Catanzaro.
185
186         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
187         factory for the GTK port for now.
188
189         * BuildSlaveSupport/build.webkit.org-config/factories.py:
190         (TestFactory.__init__):
191         * BuildSlaveSupport/build.webkit.org-config/steps.py:
192         (RunWebDriverTests):
193         (RunWebDriverTests.start):
194         (RunWebDriverTests.commandComplete):
195         (RunWebDriverTests.evaluateCommand):
196         (RunWebDriverTests.getText):
197         (RunWebDriverTests.getText2):
198
199 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
200
201         [WinCairo] Pass correct url for http test to test driver.
202         https://bugs.webkit.org/show_bug.cgi?id=181814
203
204         Reviewed by Alex Christensen.
205
206         * Scripts/webkitpy/port/driver.py:
207         (Driver):
208         (Driver.http_test_path_to_uri):
209         (Driver.is_secure_path):
210         (Driver.http_base_url):
211         (Driver.uri_to_test):
212
213 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
214
215         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
216
217         * BuildSlaveSupport/build.webkit.org-config/config.json:
218
219 2018-01-18  Dan Bernstein  <mitz@apple.com>
220
221         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
222         https://bugs.webkit.org/show_bug.cgi?id=181803
223
224         Reviewed by Tim Horton.
225
226         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
227         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
228         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
229         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
230         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
231         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
232         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
233         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
235           helpers.
236         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
237           settings useful for defining settings that depend on the target macOS version.
238         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
239         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
240
241 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
242
243         Remove Opensource El Capitan queues from buildbot
244         https://bugs.webkit.org/show_bug.cgi?id=181712
245
246         Reviewed by Aakash Jain.
247
248         * BuildSlaveSupport/build.webkit.org-config/config.json:
249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
250         (WebKitBuildbot):
251         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
252
253 2018-01-18  Chris Dumez  <cdumez@apple.com>
254
255         Service Workers restored from persistent storage have 'redundant' state
256         https://bugs.webkit.org/show_bug.cgi?id=181749
257         <rdar://problem/36556486>
258
259         Reviewed by Youenn Fablet.
260
261         Add API test coverage.
262
263         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
264         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
265
266 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
267
268         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
269         https://bugs.webkit.org/show_bug.cgi?id=176796
270
271         Reviewed by Chris Fleizach.
272
273         Add sanity check that we have a URL before calling g_strstr_len().
274
275         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
276         (WTR::AccessibilityUIElement::url):
277
278 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
279
280         Add triggers for Sierra test262 and perf queues
281         https://bugs.webkit.org/show_bug.cgi?id=181799
282
283         Reviewed by Aakash Jain.
284
285         * BuildSlaveSupport/build.webkit.org-config/config.json:
286
287 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
288
289         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
290         https://bugs.webkit.org/show_bug.cgi?id=181783
291         <rdar://problem/35785445>
292
293         Reviewed by Ryosuke Niwa.
294
295         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
296         copying an image contains a relevant title.
297
298         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
299         (TestWebKitAPI::TEST):
300         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
301         * TestWebKitAPI/ios/UIKitSPI.h:
302
303 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
304
305         WebDriver: ignore the driver in selenium test names when getting expectations
306         https://bugs.webkit.org/show_bug.cgi?id=181738
307
308         Reviewed by Carlos Alberto Lopez Perez.
309
310         In selenium tests, the driver is added as a parameter to every test which results in tests names like
311         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
312         driver name in the test expectations file, so we need to remove it when querying the expectations.
313
314         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
315         (TestExpectationsMarker.__init__): Save the param to ignore.
316         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
317         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
318         (run): Pass param to ignore to TestExpectationsMarker().
319         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
320         (WebDriverSeleniumExecutor.__init__): Save the driver name.
321         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
322
323 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
324
325         [GTK][WPE] Show unit tests unexpectedly passing in the bots
326         https://bugs.webkit.org/show_bug.cgi?id=181726
327
328         Reviewed by Michael Catanzaro.
329
330         Now that we have the info, let's show it also in the bots.
331
332         * BuildSlaveSupport/build.webkit.org-config/steps.py:
333         (RunGLibAPITests.commandComplete):
334
335 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
336
337         Fix broken unittest after r227048
338         https://bugs.webkit.org/show_bug.cgi?id=181760
339
340         Reviewed by Aakash Jain.
341
342
343 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
344
345         WEBKIT_FRAMEWORK should not modify file-global include directories
346         https://bugs.webkit.org/show_bug.cgi?id=181656
347
348         Reviewed by Konstantin Tokarev.
349
350         * TestWebKitAPI/PlatformWPE.cmake:
351         * TestWebKitAPI/glib/CMakeLists.txt:
352
353 2018-01-17  Alicia Boya García  <aboya@igalia.com>
354
355         Unreviewed, mark Alicia as committer in contributors.json
356
357         * Scripts/webkitpy/common/config/contributors.json:
358
359 2018-01-17  Youenn Fablet  <youenn@apple.com>
360
361         Put fetch Request.keepalive behind a runtime flag
362         https://bugs.webkit.org/show_bug.cgi?id=181592
363
364         Reviewed by Chris Dumez.
365
366         * DumpRenderTree/mac/DumpRenderTree.mm:
367         (enableExperimentalFeatures):
368         * DumpRenderTree/win/DumpRenderTree.cpp:
369         (enableExperimentalFeatures):
370         * WebKitTestRunner/TestController.cpp:
371         (WTR::TestController::resetPreferencesToConsistentValues):
372
373 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
374
375         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
376         https://bugs.webkit.org/show_bug.cgi?id=181637
377         <rdar://problem/36508471>
378
379         Reviewed by Tim Horton.
380
381         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
382         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
383
384         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
385         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
386         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
387
388         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
389         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
392         (webViewForTestingAttachments):
393         (-[TestWKWebView tagsInBody]):
394         (-[TestWKWebView expectElementTagsInOrder:]):
395         (-[TestWKWebView expectElementTag:toComeBefore:]):
396
397         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
398         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
399
400         (TestWebKitAPI::TEST):
401         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
402         (WTR::InjectedBundlePage::InjectedBundlePage):
403
404 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
405
406         WebDriver: add support for test expectations
407         https://bugs.webkit.org/show_bug.cgi?id=180420
408
409         Reviewed by Carlos Alberto Lopez Perez.
410
411         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
412
413         * Scripts/run-webdriver-tests: Get the retval from process_results().
414         * Scripts/webkitpy/thirdparty/__init__.py:
415         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
416         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
417         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
418         (TestExpectationsMarker.__init__): Initialize expectations.
419         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
420         (run): Create and use TestExpectationsMarker plugin.
421         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
422         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
423         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
424         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
425         (WebDriverTestRunner.run): Do not count results here.
426         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
427         amount of failures. Printing the test summary while processing results will be made optional in a follow up
428         patch.
429         (WebDriverTestRunner.process_results.report): Return the amount of failures.
430         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
431         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
432         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
433         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
434         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
435         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
436         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
437         (WebDriverTestRunnerW3C._scan_directory): Ditto.
438         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
439         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
440         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
441
442 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
443
444         Unreviewed WPE gardening. Mark some known unit test failures.
445
446         * TestWebKitAPI/glib/TestExpectations.json:
447
448 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
449
450         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
451         https://bugs.webkit.org/show_bug.cgi?id=181724
452
453         Reviewed by Philippe Normand.
454
455         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
456         reason to use different names. This way we can refer to the same test names for both and we can share the
457         expectations in the TestExpectations.json file.
458
459         * TestWebKitAPI/glib/TestExpectations.json:
460         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
461
462 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
465
466         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
467         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
468
469         * glib/api_test_runner.py:
470         (TestRunner._run_test_glib):
471         (TestRunner._run_google_test):
472
473 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
474
475         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
476         https://bugs.webkit.org/show_bug.cgi?id=179914
477
478         Reviewed by Žan Doberšek.
479
480         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
481         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
482         all symbols listed in the script are present in the library.
483
484         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
485         (bss_symbols):
486         * Scripts/check-for-invalid-symbols-in-version-script: Added.
487         (script_symbols):
488         * Scripts/make-dist:
489         (Distcheck.build):
490         (Distcheck):
491         (Distcheck.check_symbols):
492         (Distcheck.check):
493
494 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
495
496         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
497         https://bugs.webkit.org/show_bug.cgi?id=181722
498
499         Reviewed by Žan Doberšek.
500
501         I forgot to pass the parameters to run() when restarting.
502
503         * glib/glib_test_runner.py:
504         (GLibTestRunner.run):
505
506 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
507
508         [CMake] Remove WebCoreDerivedSources library target
509         https://bugs.webkit.org/show_bug.cgi?id=181664
510
511         Reviewed by Carlos Garcia Campos.
512
513         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
514         * TestWebKitAPI/PlatformWin.cmake: Ditto.
515
516 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
517
518         Move Debug Test262, Release Test262 and Performance queues to Sierra
519         https://bugs.webkit.org/show_bug.cgi?id=181692
520
521         Unreviewed
522
523 2018-01-16  Zach Li  <zachli@apple.com>
524
525         Add pop-up policy support in website policies.
526         https://bugs.webkit.org/show_bug.cgi?id=181544.
527         rdar://problem/30521400.
528
529         Reviewed by Alex Christensen.
530
531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
532         Added pop-up-check.html.
533
534         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
535
536         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
537         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
538         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
539         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
540         (TEST):
541
542 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
543
544         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
545         https://bugs.webkit.org/show_bug.cgi?id=181638
546         <rdar://problem/36508702>
547
548         Reviewed by Dan Bernstein.
549
550         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
551         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
552
553         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
554         (-[AttachmentUpdateObserver init]):
555         (-[AttachmentUpdateObserver sourceForIdentifier:]):
556         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
557         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
558         (TestWebKitAPI::TEST):
559         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
560
561 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
564
565         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
566
567         * glib/api_test_runner.py:
568         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
569         * glib/glib_test_runner.py:
570         (GLibTestRunner.run): Use given env.
571
572 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
573
574         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
575         https://bugs.webkit.org/show_bug.cgi?id=181676
576
577         Reviewed by Carlos Alberto Lopez Perez.
578
579         The option was removed in r226967.
580
581         * BuildSlaveSupport/build.webkit.org-config/steps.py:
582         (RunGtkAPITests):
583         (RunWPEAPITests):
584
585 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
588
589         The bots are still passing that option and the step is failing because it was removed in r226967.
590
591         * glib/api_test_runner.py:
592         (add_options):
593
594 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
595
596         [GTK][WPE] Improve the way glib tests are run
597         https://bugs.webkit.org/show_bug.cgi?id=181674
598
599         Reviewed by Žan Doberšek.
600
601         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
602         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
603         tests failing due to an expected assert in the test and unexpected crashes.
604         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
605         not showing the subtest name in stdout in case of timeouts.
606         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
607         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
608         of every test case.
609
610         * glib/api_test_runner.py:
611         (TestRunner._run_test_glib): Use GLibTestRunner.
612         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
613         (add_options):
614         * glib/glib_test_runner.py: Added.
615         (TestTimeout):
616         (Message):
617         (Message.__init__):
618         (Message.create):
619         (Message.create.read_unsigned):
620         (Message.create.read_double):
621         (Message.create.read_string):
622         (GLibTestRunner):
623         (GLibTestRunner.__init__):
624         (GLibTestRunner._process_data):
625         (GLibTestRunner._process_message):
626         (GLibTestRunner._read_from_pipe):
627         (GLibTestRunner._read_from_stderr):
628         (GLibTestRunner._start_timeout):
629         (GLibTestRunner._start_timeout._alarm_handler):
630         (GLibTestRunner._stop_timeout):
631         (GLibTestRunner._subtest_start):
632         (GLibTestRunner._subtest_message):
633         (GLibTestRunner._subtest_stderr):
634         (GLibTestRunner._subtest_end):
635         (GLibTestRunner.run):
636
637 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
638
639         Unreviewed, add Thibault to contributors.json
640
641         It's a bit weird to add someone here before their first contribution, but this affects
642         Bugzilla autocomplete, and that is serious business.
643
644         * Scripts/webkitpy/common/config/contributors.json:
645
646 2018-01-15  JF Bastien  <jfbastien@apple.com>
647
648         Remove makePoisonedUnique
649         https://bugs.webkit.org/show_bug.cgi?id=181630
650         <rdar://problem/36498623>
651
652         Reviewed by Mark Lam.
653
654         Update tests.
655
656         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
657         (TestWebKitAPI::TEST):
658         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
659         (TestWebKitAPI::TEST):
660
661 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
662
663         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
664         https://bugs.webkit.org/show_bug.cgi?id=181476
665
666         Reviewed by Michael Catanzaro.
667
668         Update to xorg-server 1.19.6 which depends on libxfont2, and change
669         the lists of packages to install libxfont2-devel (or equivalent).
670
671         * gtk/install-dependencies:
672         * gtk/jhbuild.modules:
673
674 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
675
676         [GTK][WPE] Add support for unit test expectations
677         https://bugs.webkit.org/show_bug.cgi?id=181589
678
679         Reviewed by Michael Catanzaro.
680
681         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
682         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
683         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
684         script itself is not a good idea either.
685
686         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
687         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
688         convenient methods to query them.
689
690         * Scripts/run-gtk-tests:
691         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
692         * Scripts/run-wpe-tests:
693         (WPETestRunner): Ditto.
694         * Scripts/webkitpy/common/test_expectations.py: Added.
695         (TestExpectations):
696         (TestExpectations.__init__):
697         (TestExpectations._port_name_for_expected):
698         (TestExpectations._expected_value):
699         (TestExpectations.skipped_tests):
700         (TestExpectations.skipped_subtests):
701         (TestExpectations._expectation_value):
702         (TestExpectations.is_slow):
703         (TestExpectations.get_expectation):
704         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
705         (MockTestExpectations):
706         (MockTestExpectations.__init__):
707         (MockTestExpectations.is_skip):
708         (ExpectationsTest):
709         (assert_exp):
710         (assert_not_exp):
711         (assert_bad_exp):
712         (assert_skip):
713         (test_basic):
714         (test_skip):
715         (test_flaky):
716         (test_build_type):
717         * TestWebKitAPI/glib/TestExpectations.json: Added.
718         * glib/api_test_runner.py:
719         (TestRunner): Remove SkippedTest implementation.
720         (TestRunner.__init__): Create a TestExpectations.
721         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
722         (TestRunner._should_run_test_program): Ditto.
723         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
724         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
725         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
726         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
727         (TestRunner.run_tests.report): Helper to write report to stdout.
728
729 2018-01-13  Mark Lam  <mark.lam@apple.com>
730
731         Replace all use of ConstExprPoisoned with Poisoned.
732         https://bugs.webkit.org/show_bug.cgi?id=181542
733         <rdar://problem/36442138>
734
735         Reviewed by JF Bastien.
736
737         1. Converted tests to using new uintptr_t& poison type.
738         2. Added tests for Poisoned comparison operators.
739
740         * TestWebKitAPI/CMakeLists.txt:
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
743         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
744         (TestWebKitAPI::TEST):
745         (TestWebKitAPI::initializeTestPoison): Deleted.
746         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
747         (TestWebKitAPI::TEST):
748         (TestWebKitAPI::passWithRef):
749         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
750         (TestWebKitAPI::TEST):
751         (TestWebKitAPI::f1):
752         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
753         (TestWebKitAPI::TEST):
754         (TestWebKitAPI::poisonedPtrFoo):
755         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
756         (TestWebKitAPI::TEST):
757         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
758         (TestWebKitAPI::TEST):
759
760 2018-01-13  David Kilzer  <ddkilzer@apple.com>
761
762         check-webkit-style: false positive for [whitespace/braces] with os_log format string
763         <https://webkit.org/b/181606>
764
765         Reviewed by Darin Adler.
766
767         * Scripts/webkitpy/style/checkers/cpp.py:
768         (check_spacing): Modify regular expression to ignore
769         os_log format strings like '%{public}'.
770         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
771         (CppStyleTest.test_spacing_before_braces): Add os_log
772         format string test.
773
774 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
775
776         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
777         https://bugs.webkit.org/show_bug.cgi?id=181626
778
779         Reviewed by Joseph Pecoraro.
780
781         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
782         Additionally, write a new API test covering the change in r226915.
783
784         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
785         (webViewForTestingAttachments):
786         (TestWebKitAPI::TEST):
787
788 2018-01-12  Alex Christensen  <achristensen@webkit.org>
789
790         History state should be updated during client redirects with asynchronous policy decisions
791         https://bugs.webkit.org/show_bug.cgi?id=181358
792         <rdar://problem/35547689>
793
794         Reviewed by Andy Estes.
795
796         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
797         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
798         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
799         (TEST):
800
801 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
802
803         webkitpy: Refactor simulator code (Part 4)
804         https://bugs.webkit.org/show_bug.cgi?id=180555
805         <rdar://problem/36131381>
806
807         Reviewed by Aakash Jain.
808
809         Move new_simulated_device.py to simulated_device.py.
810
811         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
812         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
813         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
814         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
815         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
816
817 2018-01-12  Alex Christensen  <achristensen@webkit.org>
818
819         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
820         https://bugs.webkit.org/show_bug.cgi?id=181595
821
822         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
823         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
824         I change the < and > to $ to make this test pass and continue to test what it used to.
825
826         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
827         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
828         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
829
830 2018-01-11  Keith Miller  <keith_miller@apple.com>
831
832         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
833         https://bugs.webkit.org/show_bug.cgi?id=181573
834
835         Reviewed by Simon Fraser.
836
837         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
838
839 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
840
841         [WebAuthN] Import a CBOR coder from Chromium
842         https://bugs.webkit.org/show_bug.cgi?id=181522
843         <rdar://problem/36055729>
844
845         Reviewed by Brent Fulgham.
846
847         This patch also imports all unit tests into our API tests to ensure all
848         workarounds and modification against the original codebase doesn't change
849         any original functionalities.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
853         (TestWebKitAPI::TEST):
854         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
855         (TestWebKitAPI::TEST):
856         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
857         (TestWebKitAPI::eq):
858         Workarounds applied.
859         (TestWebKitAPI::TEST):
860
861 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
862
863         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
864         https://bugs.webkit.org/show_bug.cgi?id=181538
865         <rdar://problem/36440580>
866
867         Reviewed by Aakash Jain.
868
869         When disambiguating a device type, it is possible that the provided device type is sufficiently
870         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
871         will result in a failure to disambiguate the type.
872
873         * Scripts/webkitpy/xcode/new_simulated_device.py:
874         (SimulatedDeviceManager._disambiguate_device_type):
875
876 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
877
878         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
879         https://bugs.webkit.org/show_bug.cgi?id=181136
880         <rdar://problem/36116604>
881
882         Reviewed by Chris Dumez.
883
884         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
885         browsing sessions.
886
887         * Scripts/run-gtk-tests:
888         (GtkTestRunner): Unskip test now that it passes.
889         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
890         (TEST): Add new WebsiteDataStoreEphemeral test.
891
892 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
893
894         Unreviewed, rolling out r226816.
895
896         This change broke LayoutTests on the bots.
897
898         Reverted changeset:
899
900         "run-webkit-tests fails when there is a curly brace in Xcode
901         build output"
902         https://bugs.webkit.org/show_bug.cgi?id=181254
903         https://trac.webkit.org/changeset/226816
904
905 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
906
907         webkitpy: Fix flakey webserver tests
908         https://bugs.webkit.org/show_bug.cgi?id=181555
909         <rdar://problem/36448273>
910
911         Reviewed by Aakash Jain.
912
913         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
914         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
915         determine if a specific server is running.
916
917 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
918
919         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
920         https://bugs.webkit.org/show_bug.cgi?id=181561
921         <rdar://problem/36452652>
922
923         Reviewed by Aakash Jain.
924
925         BeautifulSoup.find may return None, this case should be gracefully handled.
926
927         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
928         (BugzillaQueries._parse_result_count):
929         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
930
931 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
932
933         run-webkit-tests fails when there is a curly brace in Xcode build output
934         https://bugs.webkit.org/show_bug.cgi?id=181254
935
936         Reviewed by Daniel Bates.
937
938         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
939         (MeteredStream.write):
940
941 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
942
943         webkitpy: Reimplement simulator code (Part 3)
944         https://bugs.webkit.org/show_bug.cgi?id=180555
945         <rdar://problem/36131381>
946
947         Reviewed by Aakash Jain.
948
949         Remove old simulator code.
950
951         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
952         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
953         * Scripts/webkitpy/xcode/simulator.py: Removed.
954         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
955
956 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
957
958         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
959         https://bugs.webkit.org/show_bug.cgi?id=181337
960         <rdar://problem/36324813>
961
962         Reviewed by Tim Horton.
963
964         Add 3 new API tests for attachment element dragging.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
967         (-[TestWKWebView expectElementTag:toComeBefore:]):
968         (-[NSItemProvider expectType:withData:]):
969         (TestWebKitAPI::TEST):
970
971 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
972
973         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
974         https://bugs.webkit.org/show_bug.cgi?id=179621
975         <rdar://problem/35589585>
976
977         Unreviewed infrastructure fix.
978
979         * Scripts/webkitpy/port/mac.py:
980         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
981         list if we are the VERSION_MAX, which usually corresponds with future.
982
983 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
984
985         CodeBlocks should be in IsoSubspaces
986         https://bugs.webkit.org/show_bug.cgi?id=180884
987
988         Reviewed by Saam Barati.
989         
990         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
991         shouldn't take a long time due to benchmarks we don't optimize for.
992         
993         * Scripts/run-jsc-benchmarks:
994
995 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
996
997         Test gardening for GTK.
998         https://bugs.webkit.org/show_bug.cgi?id=181477
999
1000         Unreviewed test gardening.
1001
1002         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1003         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1004
1005 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1006
1007         Add the new JSCOnly bot to the scheduler.
1008         https://bugs.webkit.org/show_bug.cgi?id=181487
1009
1010         Unreviewed follow-up patch after r226729
1011
1012         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1013         This is needed to make the bot automatically pick each commit for testing.
1014
1015         * BuildSlaveSupport/build.webkit.org-config/config.json:
1016
1017 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1018
1019         [Attachment Support] Support dragging attachment elements out as files on iOS
1020         https://bugs.webkit.org/show_bug.cgi?id=181199
1021         <rdar://problem/36299316>
1022
1023         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1024
1025         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1026         attachment API tests.
1027
1028         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1029         (-[NSItemProvider expectType:withData:]):
1030         (TestWebKitAPI::TEST):
1031
1032         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1033         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1034         -expectType:withData: helper to inspect the item providers created from the drag source.
1035
1036         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1037         (TestWebKitAPI::TEST):
1038         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1039         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1040         (-[MockDragSession localContext]):
1041         (-[MockDragSession setLocalContext:]):
1042         (-[DataInteractionSimulator _resetSimulatedState]):
1043         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1044         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1045         (-[DataInteractionSimulator _advanceProgress]):
1046         (-[DataInteractionSimulator endDataTransfer]):
1047
1048         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1049         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1050         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1051         MockDragSession to hold on to a localContext.
1052
1053 2018-01-11  Ali Juma  <ajuma@chromium.org>
1054
1055         Unreviewed. Add Ali Juma as contributor
1056
1057         * Scripts/webkitpy/common/config/contributors.json:
1058
1059 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1060
1061         Unreviewed. Update Selenium WebDriver imported tests.
1062
1063         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1064         environment variables.
1065
1066         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1067         (collect): Reorder the arguments to make pytest happy.
1068         (run): Ditto.
1069         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1070         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1071
1072 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1073
1074         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1075         https://bugs.webkit.org/show_bug.cgi?id=181492
1076         <rdar://problem/36359679>
1077
1078         Reviewed by Alexey Proskuryakov. 
1079
1080 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1081
1082         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1083         https://bugs.webkit.org/show_bug.cgi?id=181475
1084
1085         Reviewed by Michael Catanzaro.
1086
1087         * gtk/install-dependencies: Update package list for Arch Linux, extend
1088         message shown at end of installation with additional tips.
1089
1090 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1091
1092         REGRESSION(r222507): Composition highlight doesn't render when using IME
1093         https://bugs.webkit.org/show_bug.cgi?id=181485
1094         <rdar://problem/35896516>
1095
1096         Reviewed by Ryosuke Niwa.
1097
1098         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1099         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1100         allow rendering composition backgrounds (see InlineTextBox::paint).
1101
1102         * DumpRenderTree/ios/TextInputControllerIOS.m:
1103         (+[TextInputController isSelectorExcludedFromWebScript:]):
1104         (+[TextInputController webScriptNameForSelector:]):
1105         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1106         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1107         * DumpRenderTree/mac/TextInputControllerMac.m:
1108         (+[TextInputController isSelectorExcludedFromWebScript:]):
1109         (+[TextInputController webScriptNameForSelector:]):
1110         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1111         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1112         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1113         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1114         (WTR::TextInputController::setMarkedText):
1115         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1116
1117 2018-01-10  JF Bastien  <jfbastien@apple.com>
1118
1119         Poison small JSObject derivatives which only contain pointers
1120         https://bugs.webkit.org/show_bug.cgi?id=181483
1121         <rdar://problem/36407127>
1122
1123         Reviewed by Mark Lam.
1124
1125         Test the new move-assign and move-copy from unique_ptr, as well as
1126         nullptr_t ctors.
1127
1128         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1129         (TestWebKitAPI::TEST):
1130         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1131         (TestWebKitAPI::TEST):
1132         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1133         (TestWebKitAPI::TEST):
1134
1135 2018-01-10  Chris Dumez  <cdumez@apple.com>
1136
1137         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1138         https://bugs.webkit.org/show_bug.cgi?id=179256
1139         <rdar://problem/35401978>
1140
1141         Reviewed by Alex Christensen.
1142
1143         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1144         instance gets its own folder to avoid conflicts and flakiness.
1145
1146         * WebKitTestRunner/mac/TestControllerMac.mm:
1147         (WTR::TestController::platformConfigureViewForTest):
1148
1149 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1150
1151         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1152         https://bugs.webkit.org/show_bug.cgi?id=181269
1153         <rdar://problem/35110344>
1154
1155         Reviewed by Simon Fraser.
1156
1157         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1158         (WTR::UIScriptController::beginBackSwipe):
1159         (WTR::UIScriptController::completeBackSwipe):
1160         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1161         (WTR::UIScriptController::beginBackSwipe):
1162         (WTR::UIScriptController::completeBackSwipe):
1163         (WTR::UIScriptController::overridePreference):
1164         (WTR::UIScriptController::replaceTextAtRange):
1165         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1166         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1167         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1168         (WTR::UIScriptController::beginBackSwipe):
1169         (WTR::UIScriptController::completeBackSwipe):
1170         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1171         exist on Mac) in terms of the new WKWebView testing SPI.
1172
1173 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1174
1175         REGRESSION (r226715): ignore WARNING output in linter tests
1176         https://bugs.webkit.org/show_bug.cgi?id=181486
1177         <rdar://problem/36408847>
1178
1179         Reviewed by Aakash Jain.
1180
1181         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1182
1183         * Scripts/webkitpy/common/system/outputcapture.py:
1184         (OutputCapture.__init__): Pass logging level to be captured.
1185         * Scripts/webkitpy/style/main_unittest.py:
1186         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1187         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1188         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1189         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1190         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1191         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1192         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1193         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1194
1195 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1196
1197         Add a JSCOnly MIPS buildbot
1198         https://bugs.webkit.org/show_bug.cgi?id=181487
1199
1200         Reviewed by Michael Catanzaro.
1201
1202         Add the new bot configs definitions for the master and update the unit tests.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/config.json:
1205         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1206
1207 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1208
1209         REGRESSION (r226715): don't re-check number of simulators in child processes
1210         https://bugs.webkit.org/show_bug.cgi?id=181484
1211         <rdar://problem/36407151>
1212
1213         Reviewed by Aakash Jain.
1214
1215         * Scripts/webkitpy/port/ios_simulator.py:
1216         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1217         are already initialized.
1218
1219 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1220
1221         Unreviewed, rolling out r226667 and r226673.
1222         https://bugs.webkit.org/show_bug.cgi?id=181488
1223
1224         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1225
1226         Reverted changesets:
1227
1228         "CodeBlocks should be in IsoSubspaces"
1229         https://bugs.webkit.org/show_bug.cgi?id=180884
1230         https://trac.webkit.org/changeset/226667
1231
1232         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1233         https://bugs.webkit.org/show_bug.cgi?id=180884
1234         https://trac.webkit.org/changeset/226673
1235
1236 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1237
1238         Follow-up fix to r226715
1239         https://bugs.webkit.org/show_bug.cgi?id=180555
1240         <rdar://problem/36131381>
1241
1242         Unreviewed infrastructure fix.
1243
1244         * Scripts/webkitpy/xcode/new_simulated_device.py:
1245         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1246         of delete.
1247
1248 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1249
1250         webkitpy: Refactor simulator code (Part 2)
1251         https://bugs.webkit.org/show_bug.cgi?id=180555
1252         <rdar://problem/36131381>
1253
1254         Reviewed by Aakash Jain.
1255
1256         The patch leverages the SimulatedDeviceManager when running layout tests.
1257         This patch is primarily code removal, since much of the IOSSimulatorPort
1258         was dedicated to managing simulators. The removed code is either now owned by the
1259         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1260         boot multiple simulators which was made obsolete in Xcode 9.
1261
1262         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1263         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1264         strip those spaces.
1265         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1266         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1267         * Scripts/webkitpy/port/ios.py:
1268         (IOSPort.__init__): The _current_device idiom is no longer required since the
1269         SimulatedDeviceManager keeps track of any previously booted devices.
1270         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1271         through the array of managed devices.
1272         (IOSPort.using_multiple_devices): Deleted.
1273         * Scripts/webkitpy/port/ios_device.py:
1274         (IOSDevicePort.using_multiple_devices): Deleted.
1275         * Scripts/webkitpy/port/ios_simulator.py:
1276         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1277         class strings so they can be parsed by the DeviceType class.
1278         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1279         the number of simulators currently booted, the number of child processes specified
1280         and the maximum number of simulators supported by this system.
1281         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1282         devices owned by the SimulatedDeviceManager.
1283         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1284         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1285         the maximum number of supported simulators on this system.
1286         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1287         request for each child process and send this list to the SimulatedDeviceManager to
1288         initialize the devices.
1289         (IOSSimulatorPort.clean_up_test_run):
1290         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1291         specified version of iOS.
1292         (IOSSimulatorPort.reset_preferences):
1293         (IOSSimulatorPort.simulator_runtime): Deleted.
1294         (IOSSimulatorPort.simulator_device_type): Deleted.
1295         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1296         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1297         (IOSSimulatorPort._create_simulators): Deleted.
1298         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1299         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1300         (IOSSimulatorPort.using_multiple_devices): Deleted.
1301         (IOSSimulatorPort._create_device): Deleted.
1302         (IOSSimulatorPort.get_simulator_path): Deleted.
1303         (IOSSimulatorPort._createSimulatorApps): Deleted.
1304         (IOSSimulatorPort._createSimulatorApp): Deleted.
1305         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1306         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1307         maximum number of simulators run on this system.
1308         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1309         * Scripts/webkitpy/xcode/new_simulated_device.py:
1310         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1311
1312 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1313
1314         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1315         https://bugs.webkit.org/show_bug.cgi?id=181474
1316
1317         Reviewed by Carlos Alberto Lopez Perez.
1318
1319         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1320         name as the name.
1321
1322         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1323         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1324         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1325
1326 2018-01-09  Andy Estes  <aestes@apple.com>
1327
1328         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1329         https://bugs.webkit.org/show_bug.cgi?id=181459
1330
1331         Reviewed by Dan Bernstein.
1332
1333         * ImageDiff/cg/Configurations/Base.xcconfig:
1334
1335 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1336
1337         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1338         https://bugs.webkit.org/show_bug.cgi?id=181374
1339
1340         Reviewed by Simon Fraser.
1341
1342         The test requires Palatino.
1343
1344         * DumpRenderTree/mac/DumpRenderTree.mm:
1345         (allowedFontFamilySet):
1346         * WebKitTestRunner/mac/TestControllerMac.mm:
1347         (WTR::allowedFontFamilySet):
1348
1349 2018-01-09  Saam Barati  <sbarati@apple.com>
1350
1351         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1352         https://bugs.webkit.org/show_bug.cgi?id=181449
1353
1354         Reviewed by JF Bastien.
1355
1356         This allows me to Cmd+f in my terminal to search for things without
1357         having the results become misaligned.
1358
1359         * Scripts/display-profiler-output:
1360
1361 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1362
1363         [webkitpy] PlatformInfo should have default argument for casual use
1364         https://bugs.webkit.org/show_bug.cgi?id=180827
1365
1366         Reviewed by David Kilzer.
1367
1368         PlatformInfo should be the only way to check platform specific thing instead
1369         of sys.platform or other various checks. If there is something you want to check,
1370         it should be placed in PlatformInfo.
1371
1372         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1373         sys, platform and Executive(). They are straight forward and should be handled
1374         by default arguments. Then we can instantiate PlatformInfo more casual.
1375
1376         * Scripts/webkitpy/common/system/platforminfo.py:
1377         (PlatformInfo): Use relative module path import
1378         (PlatformInfo.__init__):
1379         (PlatformInfo.executive): Lazy instantiation of Executive()
1380         (PlatformInfo.total_bytes_memory): Accessing via above property
1381         (PlatformInfo.xcode_sdk_version): Ditto
1382         (PlatformInfo.xcode_simctl_list): Ditto
1383         (PlatformInfo.xcode_version): Ditto
1384         (PlatformInfo._win_version_str): Ditto
1385         * Scripts/webkitpy/common/system/systemhost.py:
1386         (SystemHost.__init__):
1387         * Scripts/webkitpy/common/system/user.py:
1388         (User.__init__):
1389
1390 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1391
1392         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1393         https://bugs.webkit.org/show_bug.cgi?id=176443
1394
1395         Reviewed by Darin Adler.
1396
1397         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1398         (TEST):
1399
1400 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1401
1402         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1403         https://bugs.webkit.org/show_bug.cgi?id=181394
1404
1405         Reviewed by Darin Adler.
1406
1407         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1408         as the second parameter instead of ios(WK_IOS_TBA). This generally
1409         builds for iOS on EWS but not when using the public SDK. See r224057,
1410         r223207 and r226211 for example. This patch adds a basic style check
1411         for that macro to prevent this kind of mistake.
1412
1413         * Scripts/webkitpy/style/checkers/cpp.py:
1414         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1415         (check_style): Run new style check.
1416         (CppChecker): Add build type for the new style check.
1417         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1418         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1419
1420 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1421
1422         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1423         https://bugs.webkit.org/show_bug.cgi?id=181420
1424         <rdar://problem/36365827>
1425
1426         Reviewed by Alex Christensen.
1427
1428         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1429         of corresponding _WKAttachments.
1430
1431         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1432         (TestWebKitAPI::TEST):
1433
1434 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1435
1436         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1437         https://bugs.webkit.org/show_bug.cgi?id=181410
1438         <rdar://problem/36167199>
1439
1440         Reviewed by Wenson Hsieh.
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1443         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1444         (TEST):
1445
1446 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1447
1448         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1449         https://bugs.webkit.org/show_bug.cgi?id=181408
1450         <rdar://problem/35884960>
1451
1452         Reviewed by Tim Horton.
1453
1454         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1455         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1456
1457 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1458
1459         [Attachment Support] Expose file name and content type of WKAttachment
1460         https://bugs.webkit.org/show_bug.cgi?id=181390
1461         <rdar://problem/36336837>
1462
1463         Reviewed by Tim Horton.
1464
1465         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1468         (-[_WKAttachment synchronouslyRequestInfo:]):
1469         (-[_WKAttachment synchronouslyRequestData:]):
1470
1471         Reimplement this in terms of -synchronouslyRequestInfo:.
1472
1473         (-[_WKAttachment expectRequestedDataToBe:]):
1474         (TestWebKitAPI::TEST):
1475
1476 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1477
1478         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1479         https://bugs.webkit.org/show_bug.cgi?id=181365
1480         <rdar://problem/36340647>
1481
1482         Reviewed by Tim Horton.
1483
1484         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1485         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1486         detail.
1487
1488         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1489         (TestWebKitAPI::TEST):
1490
1491 2018-01-08  Youenn Fablet  <youenn@apple.com>
1492
1493         navigator.onLine does not work inside service workers
1494         https://bugs.webkit.org/show_bug.cgi?id=181079
1495         <rdar://problem/36178606>
1496
1497         Reviewed by Darin Adler.
1498
1499         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1500         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1501
1502 2018-01-07  Saam Barati  <sbarati@apple.com>
1503
1504         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1505         https://bugs.webkit.org/show_bug.cgi?id=181372
1506
1507         Reviewed by Filip Pizlo.
1508
1509         Adding these sorting modes makes it easier to analyze functions
1510         that recompile a lot and exit a lot.
1511
1512         * Scripts/display-profiler-output:
1513
1514 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1515
1516         Unreviewed, remove my Cisco email from contributors.json
1517
1518         * Scripts/webkitpy/common/config/contributors.json:
1519
1520 2018-01-05  JF Bastien  <jfbastien@apple.com>
1521
1522         WebAssembly: poison JS object's secrets
1523         https://bugs.webkit.org/show_bug.cgi?id=181339
1524         <rdar://problem/36325001>
1525
1526         Reviewed by Mark Lam.
1527
1528         Update tests for swap(Poisoned<k, T>, T*)
1529
1530         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1533         (TestWebKitAPI::TEST):
1534         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1535         (TestWebKitAPI::TEST):
1536
1537 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1538
1539         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1540         https://bugs.webkit.org/show_bug.cgi?id=181359
1541
1542         Reviewed by Tim Horton.
1543
1544         Ensure that these tests still pass using older SDKs.
1545
1546         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1547         (TestWebKitAPI::TEST):
1548
1549 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1550
1551         Rebase API test after r226469
1552         https://bugs.webkit.org/show_bug.cgi?id=181308
1553
1554         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1555         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1556         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1557
1558 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1559
1560         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1561         https://bugs.webkit.org/show_bug.cgi?id=181217
1562
1563         Reviewed by Tim Horton.
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1566         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1567         (TEST):
1568
1569 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1570
1571         Add WKBundleFrameCreateFrameHandle
1572         https://bugs.webkit.org/show_bug.cgi?id=181232
1573         <rdar://problem/35926696>
1574
1575         Reviewed by Tim Horton.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1579         (mouseDidMoveOverElement):
1580         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1581         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1582         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1583         (TEST):
1584
1585 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1586
1587         iOS: Build fix after r226432.
1588         
1589         Unreviewed. Stop duplicating speakAs symbols for iOS.
1590
1591         * DumpRenderTree/AccessibilityUIElement.cpp:
1592         (AccessibilityUIElement::speakAs):
1593
1594 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1595
1596         Unreviewed, added myself as WebKit reviewer
1597
1598         * Scripts/webkitpy/common/config/contributors.json:
1599
1600 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1601
1602         WPE: Build fix after r226432.
1603
1604         Unreviewed. Rename ::speak() to ::speakAs().
1605         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1606         (WTR::AccessibilityUIElement::speakAs):
1607         (WTR::AccessibilityUIElement::speak): Deleted.
1608
1609 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1610
1611         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1612         https://bugs.webkit.org/show_bug.cgi?id=180361
1613
1614         Reviewed by Zalan Bujtas.
1615
1616         * DumpRenderTree/AccessibilityUIElement.cpp:
1617         (speakAsCallback):
1618         (AccessibilityUIElement::speakAs):
1619         (AccessibilityUIElement::getJSClass):
1620         (speakCallback): Deleted.
1621         (AccessibilityUIElement::speak): Deleted.
1622         * DumpRenderTree/AccessibilityUIElement.h:
1623         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1624         (AccessibilityUIElement::speakAs):
1625         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1626         (AccessibilityUIElement::speakAs):
1627         (AccessibilityUIElement::speak): Deleted.
1628         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1629         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1630         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1631         (WTR::AccessibilityUIElement::speakAs):
1632         (WTR::AccessibilityUIElement::speak): Deleted.
1633         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1634         (WTR::AccessibilityUIElement::speakAs):
1635         (WTR::AccessibilityUIElement::speak): Deleted.
1636
1637 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1638
1639         REGRESSION (r226395): test-webkitperl test expectations incorrect
1640         https://bugs.webkit.org/show_bug.cgi?id=181307
1641         <rdar://problem/36306558>
1642
1643         Rubber-stamped by Aakash Jain.
1644
1645         r226395 added two lines towards the beginning of
1646         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1647         numbers in the test expectations need to update.
1648
1649         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1650
1651 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1652
1653         WKWebView loses minimum layout size overrides that happen while the process is terminated
1654         https://bugs.webkit.org/show_bug.cgi?id=181306
1655         <rdar://problem/34398288>
1656
1657         Reviewed by Dan Bernstein.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1660         (TEST):
1661         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1662         while the process is terminated results in the page getting the correct
1663         minimum layout size.
1664
1665 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1666
1667         [MediaStream] Add Mock screen capture source
1668         https://bugs.webkit.org/show_bug.cgi?id=181291
1669         <rdar://problem/36298164>
1670
1671         Reviewed by Dean Jackson.
1672
1673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1674         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1675         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1676
1677 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1678
1679         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1680
1681         Reviewed by Ling Ho.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1684
1685 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1686
1687         [Attachment Support] Create attachment elements when dropping files on iOS
1688         https://bugs.webkit.org/show_bug.cgi?id=181192
1689         <rdar://problem/36280945>
1690
1691         Reviewed by Tim Horton.
1692
1693         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1694         switch is enabled. See below for more details.
1695
1696         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1697         (-[NSItemProvider registerData:type:]):
1698         (platformCopyPNG):
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1701
1702         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1703         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1704         kUTTypeRTF instead.
1705
1706         (TestWebKitAPI::TEST):
1707
1708         Tests a few cases of inserting attachment elements via drop:
1709         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1710             Instead of inserting the contents as inline web content, this should generate attachment elements.
1711         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1712             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1713             back to inserting the content as an attachment.
1714         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1715             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1716             or at the end).
1717
1718         * TestWebKitAPI/cocoa/TestWKWebView.h:
1719         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1720         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1721
1722         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1723         -stringByEvaluatingJavaScript to just turn around and call this.
1724
1725         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1726
1727 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1728
1729         Replace hard-coded paths in shebangs with #!/usr/bin/env
1730         https://bugs.webkit.org/show_bug.cgi?id=181040
1731
1732         Reviewed by Alex Christensen.
1733
1734         * BuildSlaveSupport/build-launcher-app:
1735         * BuildSlaveSupport/build-launcher-dmg:
1736         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1737         * BuildSlaveSupport/built-product-archive:
1738         * BuildSlaveSupport/clean-build:
1739         * BuildSlaveSupport/delete-stale-build-files:
1740         * BuildSlaveSupport/download-built-product:
1741         * BuildSlaveSupport/gtk/buildbot/log/run:
1742         * BuildSlaveSupport/gtk/buildbot/run:
1743         * BuildSlaveSupport/gtk/pulseaudio/run:
1744         * BuildSlaveSupport/kill-old-processes:
1745         * BuildSlaveSupport/test-result-archive:
1746         * BuildSlaveSupport/win/kill-old-processes:
1747         * Scripts/SpacingHeuristics.pm:
1748         * Scripts/add-include:
1749         * Scripts/build-api-tests:
1750         * Scripts/build-dumprendertree:
1751         * Scripts/build-imagediff:
1752         * Scripts/build-jsc:
1753         * Scripts/build-webkit:
1754         * Scripts/build-webkittestrunner:
1755         * Scripts/check-Xcode-source-file-types:
1756         * Scripts/check-dom-results:
1757         * Scripts/check-for-exit-time-destructors:
1758         * Scripts/check-for-global-initializers:
1759         * Scripts/check-for-inappropriate-objc-class-names:
1760         * Scripts/check-for-weak-vtables-and-externals:
1761         * Scripts/clean-header-guards:
1762         * Scripts/compare-timing-files:
1763         * Scripts/configure-xcode-for-ios-development:
1764         * Scripts/copy-webkitlibraries-to-product-directory:
1765         * Scripts/create-exports:
1766         * Scripts/debug-minibrowser:
1767         * Scripts/debug-safari:
1768         * Scripts/debug-test-runner:
1769         * Scripts/do-file-rename:
1770         * Scripts/do-webcore-rename:
1771         * Scripts/dump-webkit-tests-run:
1772         * Scripts/ensure-valid-python:
1773         * Scripts/execAppWithEnv:
1774         * Scripts/extract-localizable-js-strings:
1775         * Scripts/filter-build-webkit:
1776         * Scripts/find-extra-includes:
1777         * Scripts/fix-blink-patch:
1778         * Scripts/generate-coverage-data:
1779         * Scripts/git-add-reviewer:
1780         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1781         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1782         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1783         * Scripts/make-new-script-test:
1784         * Scripts/make-script-test-wrappers:
1785         * Scripts/package-root:
1786         * Scripts/parse-malloc-history:
1787         * Scripts/report-include-statistics:
1788         * Scripts/resolve-ChangeLogs:
1789         * Scripts/run-api-tests:
1790         * Scripts/run-bindings-tests:
1791         * Scripts/run-content-extension-tester:
1792         * Scripts/run-iexploder-tests:
1793         * Scripts/run-javascriptcore-tests:
1794         * Scripts/run-jsc:
1795         * Scripts/run-leaks:
1796         * Scripts/run-mangleme-tests:
1797         * Scripts/run-minibrowser:
1798         * Scripts/run-pageloadtest:
1799         * Scripts/run-regexp-tests:
1800         * Scripts/run-safari:
1801         * Scripts/run-sunspider:
1802         * Scripts/run-test-runner:
1803         * Scripts/run-webkit-app:
1804         * Scripts/run-webkit-httpd:
1805         * Scripts/run-webkit-websocketserver:
1806         * Scripts/set-webkit-configuration:
1807         * Scripts/show-pretty-diff:
1808         * Scripts/sort-Xcode-project-file:
1809         * Scripts/split-file-by-class:
1810         * Scripts/sunspider-compare-results:
1811         * Scripts/svn-apply:
1812         * Scripts/svn-unapply:
1813         * Scripts/test-webkit-scripts:
1814         * Scripts/test-webkitperl:
1815         * Scripts/update-iexploder-cssproperties:
1816         * Scripts/update-javascriptcore-test-results:
1817         * Scripts/update-webkit:
1818         * Scripts/update-webkit-auxiliary-libs:
1819         * Scripts/update-webkit-dependency:
1820         * Scripts/update-webkit-libs-jhbuild:
1821         * Scripts/update-webkit-localizable-strings:
1822         * Scripts/update-webkit-support-libs:
1823         * Scripts/update-webkitgtk-libs:
1824         * Scripts/update-webkitwpe-libs:
1825         * Scripts/webkit-build-directory:
1826         * Scripts/webkitperl/LoadAsModule.pm:
1827         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1828         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1829         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1830         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1831         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1832         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1833         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1834         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1835         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1836         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1837         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1838         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1839         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1840         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1841         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1842         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1843         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1844         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1845         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1846         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1847         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1848         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1849         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1850         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1851         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1852         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1853         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1854         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1855         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1856         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1857         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1858         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1859         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1860         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1861         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1862         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1863         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1864         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1865         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1866         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1867         * ccache/ccache-clang:
1868         * ccache/ccache-clang++:
1869         * ccache/ccache-wrapper:
1870         * gtk/install-dependencies:
1871         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1872         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1873         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1874         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1875         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1876         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1877         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1878         * iExploder/iexploder-1.7.2/src/webserver.rb:
1879         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1880         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1881         * wpe/install-dependencies:
1882
1883 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1884
1885         filter-build-webkit filters out useful compiler error lines
1886         https://bugs.webkit.org/show_bug.cgi?id=179864
1887
1888         Reviewed by Tim Horton.
1889
1890         Don't filter out lines that contain information about build errors by always showing lines
1891         after a line that contains "note:" or "error:".
1892
1893         * Scripts/filter-build-webkit:
1894         (shouldShowSubsequentLine):
1895         (shouldIgnoreLine):
1896
1897 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1898
1899         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1900         https://bugs.webkit.org/show_bug.cgi?id=173915
1901
1902         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1903         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1904         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1905         empty string in this case.
1906
1907         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1908         (emitFormSubmissionEvent):
1909
1910 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1911
1912         [GTK] Add web process API to detect when form is submitted via JavaScript
1913         https://bugs.webkit.org/show_bug.cgi?id=173915
1914
1915         Reviewed by Carlos Garcia Campos.
1916
1917         Test it.
1918
1919         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1920         (FormSubmissionTest::FormSubmissionTest):
1921         (FormSubmissionTest::~FormSubmissionTest):
1922         (FormSubmissionTest::testFormSubmissionResult):
1923         (FormSubmissionTest::willSendDOMEventCallback):
1924         (FormSubmissionTest::willCompleteCallback):
1925         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1926         (testWebExtensionFormSubmissionSteps):
1927         (beforeAll):
1928         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1929         (DelayedSignal::DelayedSignal):
1930         (emitFormSubmissionEvent):
1931         (handleFormSubmissionCallback):
1932         (willSubmitFormCallback):
1933         (pageCreatedCallback):
1934
1935 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1936
1937         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1938         https://bugs.webkit.org/show_bug.cgi?id=181251
1939
1940         * Scripts/run-gtk-tests:
1941         (GtkTestRunner):
1942
1943 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1944
1945         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1946         https://bugs.webkit.org/show_bug.cgi?id=181136
1947
1948         * Scripts/run-gtk-tests:
1949         (GtkTestRunner):
1950
1951 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1952
1953         [macOS, iOS] Adopt new secure coding APIs in WebKit
1954         https://bugs.webkit.org/show_bug.cgi?id=181085
1955         <rdar://problem/34837397>
1956
1957         Reviewed by Tim Horton.
1958
1959         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1960         capable of supporting NSSecureCoding, so pass through the current coding routines.
1961
1962         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1963         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1964         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1965         routines if necessary.
1966         (TEST): Updated for NSSecureCoding.
1967         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1968         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1969
1970 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1971
1972         Remove std::chrono completely
1973         https://bugs.webkit.org/show_bug.cgi?id=181186
1974
1975         Reviewed by Alex Christensen.
1976
1977         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1978         (WTR::TestController::platformRunUntil):
1979
1980 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1981
1982         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1983         https://bugs.webkit.org/show_bug.cgi?id=181231
1984
1985         Reviewed by Alex Christensen.
1986
1987         Implement TestController APIs needed by ResourceLoadStatistics tests.
1988
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1991         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1992
1993 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1994
1995         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1996         https://bugs.webkit.org/show_bug.cgi?id=181219
1997
1998         Reviewed by Wenson Hsieh.
1999
2000         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2001
2002 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2003
2004         Add a WebAuthentication runtime feature flag
2005         https://bugs.webkit.org/show_bug.cgi?id=181220
2006         <rdar://problem/36055305>
2007
2008         Reviewed by Brent Fulgham.
2009
2010         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2011
2012         * DumpRenderTree/TestOptions.h:
2013         * DumpRenderTree/TestOptions.mm:
2014         (TestOptions::TestOptions):
2015         * DumpRenderTree/mac/DumpRenderTree.mm:
2016         (enableExperimentalFeatures):
2017         (setWebPreferencesForTestOptions):
2018         * WebKitTestRunner/TestController.cpp:
2019         (WTR::TestController::resetPreferencesToConsistentValues):
2020         (WTR::updateTestOptionsFromTestHeader):
2021         * WebKitTestRunner/TestOptions.h:
2022         (WTR::TestOptions::hasSameInitializationOptions const):
2023
2024 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2025
2026         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2027         https://bugs.webkit.org/show_bug.cgi?id=181143
2028         <rdar://problem/36200381>
2029
2030         Reviewed by Tim Horton.
2031
2032         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2033         attachment elements are enabled.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2037         (TestWebKitAPI::TEST):
2038
2039 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2040
2041         Update Credential Management API for WebAuthentication
2042         https://bugs.webkit.org/show_bug.cgi?id=181082
2043         <rdar://problem/36055239>
2044
2045         Reviewed by Brent Fulgham.
2046
2047         Enable Credential Management API for testing.
2048
2049         * DumpRenderTree/TestOptions.h:
2050         * WebKitTestRunner/TestOptions.h:
2051
2052 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2053
2054         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2055         https://bugs.webkit.org/show_bug.cgi?id=168194
2056
2057         Reviewed by Carlos Garcia Campos.
2058
2059         Fix an assertion and unskip the test. The order that form controls are associated is not
2060         guaranteed.
2061
2062         * Scripts/run-gtk-tests:
2063         (GtkTestRunner):
2064         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2065         (didAssociateFormControlsCallback):
2066
2067 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2068
2069         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2070         https://bugs.webkit.org/show_bug.cgi?id=180897
2071         <rdar://problem/35535328>
2072
2073         Reviewed by Brent Fulgham.
2074
2075         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2076
2077         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2078         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2079         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2080         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2081         (websiteDataStoreTestWebView):
2082         (TEST):
2083
2084 == Rolled over to ChangeLog-2018-01-01 ==