a1de027ac09ba22152dfa829bef1125f493b12d2
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
4         https://bugs.webkit.org/show_bug.cgi?id=182953
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/webkitpy/port/gtk.py:
9         (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
12         (WTR::TestController::networkProcessName): Ditto.
13         (WTR::TestController::databaseProcessName): Ditto.
14
15 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
16
17         Unreviewed, rolling out r228696.
18
19         The API test added with this change is timing out on macOS.
20
21         Reverted changeset:
22
23         "Null pointer dereference in
24         WebPageProxy::urlSchemeHandlerForScheme()"
25         https://bugs.webkit.org/show_bug.cgi?id=182905
26         https://trac.webkit.org/changeset/228696
27
28 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
29
30         Add an entitlement check for service worker on iOS
31         https://bugs.webkit.org/show_bug.cgi?id=182865
32         <rdar://problem/37505903>
33
34         Reviewed by Brady Eidson.
35
36         Added the service worker entitlements to WebKitTestRunner and TestWebKitAPI on iOS.
37
38         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
39         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
40         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
41         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
42
43 2018-02-16  Youenn Fablet  <youenn@apple.com>
44
45         Allow specifying which plug-ins are supported
46         https://bugs.webkit.org/show_bug.cgi?id=182748
47
48         Reviewed by Chris Dumez.
49
50         Add support for a test runner API to specificy supported plug-ins.
51
52         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
53         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
54         (WTR::TestRunner::setPluginsAsUnsupported):
55         * WebKitTestRunner/InjectedBundle/TestRunner.h:
56         * WebKitTestRunner/TestController.cpp:
57         (WTR::TestController::resetStateToConsistentValues):
58         (WTR::TestController::setPluginsAsUnsupported):
59         * WebKitTestRunner/TestController.h:
60         * WebKitTestRunner/TestInvocation.cpp:
61         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
62
63 2018-02-16  Per Arne Vollan  <pvollan@apple.com>
64
65         Implement stopping of run loop in the WebContent process when using NSRunLoop.
66         https://bugs.webkit.org/show_bug.cgi?id=182499
67         <rdar://problem/37247424>
68
69         Reviewed by Brent Fulgham.
70
71         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
72         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm: Added.
73         (TEST):
74
75 2018-02-15  Alexey Proskuryakov  <ap@apple.com>
76
77         Speed up dSYM generation on build.webkit.org with -gline-tables-only
78         https://bugs.webkit.org/show_bug.cgi?id=182841
79         rdar://problem/34579649
80
81         Reviewed by Aakash Jain.
82
83         Build speed and binary size improvements are so substantial that I'm willing to make
84         CI builds less suitable for debugging, which is not a common scenario anyway.
85         Crash logs will still have line numbers in them.
86
87         * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
88
89 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
90
91         WebCore headers should not be included relatively within dependent projects
92         https://bugs.webkit.org/show_bug.cgi?id=182805
93
94         Reviewed by Chris Dumez.
95
96         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
97         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
98         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
99         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
100         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
101         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
102
103 2018-02-15  Tomas Popela  <tpopela@redhat.com>
104
105         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
106         https://bugs.webkit.org/show_bug.cgi?id=182729
107
108         If multiple run commands are specified and one of them evals to skip,
109         then the test is not skipped, because the run is scheduled while
110         evaluating other commands.
111
112         Remember if the test is going to be skipped - if yes, just stop
113         evaluating the other run commands.
114
115         Reviewed by Saam Barati.
116
117         * Scripts/run-jsc-stress-tests:
118
119 2018-02-14  Charlie Turner  <cturner@igalia.com>
120
121         Get Garden-O-Matic running again.
122         https://bugs.webkit.org/show_bug.cgi?id=179089
123
124         Reviewed by Carlos Alberto Lopez Perez.
125
126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
127         (parseCommitData): Author field is not always spelled 'author' these days.
128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
129         No longer have a 32-bit builder.
130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
131         (ui.perf.View.base.init): createElement has a required parameter these days.
132         * Scripts/webkitpy/tool/commands/gardenomatic.py:
133         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
134
135 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
136
137         Remove unused ForwardingHeaders directories from Tools
138         https://bugs.webkit.org/show_bug.cgi?id=182813
139
140         Reviewed by Konstantin Tokarev.
141
142         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
143         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
144         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
145         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
146         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
147
148 2018-02-14  Daniel Bates  <dabates@apple.com>
149
150         Disallow cross-origin subresources from asking for credentials
151         https://bugs.webkit.org/show_bug.cgi?id=182579
152         <rdar://problem/36162271>
153
154         Reviewed by Andy Estes.
155
156         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
157         so that tests can toggle between the old behavior and new behavior.
158
159         * DumpRenderTree/TestOptions.h:
160         * DumpRenderTree/TestOptions.mm:
161         (TestOptions::TestOptions):
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (setWebPreferencesForTestOptions):
164         * WebKitTestRunner/TestController.cpp:
165         (WTR::TestController::resetPreferencesToConsistentValues):
166         (WTR::updateTestOptionsFromTestHeader):
167         * WebKitTestRunner/TestOptions.h:
168         (WTR::TestOptions::hasSameInitializationOptions const):
169
170 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
171
172         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
173         https://bugs.webkit.org/show_bug.cgi?id=182564
174
175         Reviewed by Wenson Hsieh.
176
177         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
178         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
179         and the style content is enclosed in "<!--" and "-->".
180
181         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
182         to make sure our pasting code preserves the special style element for MSO list quirks.
183
184         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
187         (TEST):
188         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
189         (TEST):
190
191 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
192
193         [Tools] --wincairo should imply --64-bit by default.
194         https://bugs.webkit.org/show_bug.cgi?id=182753
195
196         Reviewed by Daniel Bates.
197
198         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
199         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
200
201         * Scripts/webkitdirs.pm:
202         (determinePassedArchitecture):
203         (shouldBuild32Bit):
204         (determineShouldBuild32Bit):
205         (determineIsWin64):
206         * Scripts/webkitpy/common/config/ports.py:
207         (WinCairoPort.build_webkit_command):
208         * Scripts/webkitpy/common/config/ports_unittest.py:
209         (DeprecatedPortTest.test_wincairo_port):
210         * Scripts/webkitpy/port/win.py:
211         (WinCairoPort):
212
213 2018-02-13  Commit Queue  <commit-queue@webkit.org>
214
215         Unreviewed, rolling out r228431.
216         https://bugs.webkit.org/show_bug.cgi?id=182766
217
218         Regressed CMake build stability (Requested by dolmstead on
219         #webkit).
220
221         Reverted changeset:
222
223         "[CMake] Make WebCore headers copies"
224         https://bugs.webkit.org/show_bug.cgi?id=182512
225         https://trac.webkit.org/changeset/228431
226
227 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
228
229         [CMake] Make WebCore headers copies
230         https://bugs.webkit.org/show_bug.cgi?id=182512
231
232         Reviewed by Keith Miller.
233
234         * DumpRenderTree/CMakeLists.txt:
235         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
236         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
237         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
238         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
239         * TestWebKitAPI/PlatformGTK.cmake:
240         * TestWebKitAPI/PlatformWPE.cmake:
241         * TestWebKitAPI/PlatformWin.cmake:
242         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
243         (loadResourceIntoBuffer):
244         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
245         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
246         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
247         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
248         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
249
250 2018-02-13  Chris Dumez  <cdumez@apple.com>
251
252         REGRESSION (r228299): Broke reader mode in Safari
253         https://bugs.webkit.org/show_bug.cgi?id=182697
254         <rdar://problem/37399012>
255
256         Reviewed by Ryosuke Niwa.
257
258         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
259         delegate.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
263         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
264         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
265         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
266         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
267         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
268         (TestWebKitAPI::TEST):
269
270 2018-02-12  John Wilander  <wilander@apple.com>
271
272         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
273         https://bugs.webkit.org/show_bug.cgi?id=182664
274         <rdar://problem/37372572>
275
276         Reviewed by Brent Fulgham.
277
278         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
280         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
281         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
282         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
283         * WebKitTestRunner/InjectedBundle/TestRunner.h:
284         * WebKitTestRunner/TestController.cpp:
285         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
286         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
287         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
288         * WebKitTestRunner/TestController.h:
289         * WebKitTestRunner/TestInvocation.cpp:
290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
291
292 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
293
294         download-latest-github-release .py should not use "browser download URL".
295         https://bugs.webkit.org/show_bug.cgi?id=182646
296
297         Reviewed by Per Arne Vollan.
298
299         * Scripts/download-latest-github-release.py:
300         Download request should be a proper GitHub API call and should actually include the token when applicable.
301         (Also clean up usage of args and print while we're in here.)
302
303 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
304
305         EWS should run Windows tests.
306         https://bugs.webkit.org/show_bug.cgi?id=177967
307
308         Reviewed by Lucas Forschler.
309
310         This will help catch regressions at an early stage.
311
312         * Scripts/webkitpy/common/config/ews.json:
313
314 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
315
316         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
317         https://bugs.webkit.org/show_bug.cgi?id=182564
318
319         Reviewed by Wenson Hsieh.
320
321         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
322         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
323
324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
326         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
327         (msoListMarkupWithoutProperHTMLElement): Added.
328         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
329
330 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
331
332         [CMake] Make PAL headers copies
333         https://bugs.webkit.org/show_bug.cgi?id=182645
334
335         Reviewed by Alex Christensen.
336
337         * TestWebKitAPI/CMakeLists.txt:
338
339 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
340
341         Pasting from Excel no longer provides text/html data
342         https://bugs.webkit.org/show_bug.cgi?id=182636
343         <rdar://problem/37087060>
344
345         Reviewed by Ryosuke Niwa.
346
347         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
348         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
349
350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
351         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
352
353         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
354         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
355         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
356         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
359         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
360
361         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
362         file, with some combination of plain text, rich text, and URLs.
363
364         (imagePath):
365         (writeTypesAndDataToPasteboard):
366
367         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
368
369         (setUpWebView):
370         (markupString):
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
373         (TestWebKitAPI::testIconImageData):
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/cocoa/TestWKWebView.h:
376
377         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
378         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
379
380 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
381
382         Add a way to check if a host is an IP address
383         https://bugs.webkit.org/show_bug.cgi?id=182427
384
385         Reviewed by Alex Christensen.
386
387         Add unit test for URL::hostIsIPAddress().
388
389         * TestWebKitAPI/Tests/WebCore/URL.cpp:
390         (TestWebKitAPI::TEST_F):
391
392 2018-02-09  Philippe Normand  <pnormand@igalia.com>
393
394         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
395         https://bugs.webkit.org/show_bug.cgi?id=176802
396
397         Reviewed by Xabier Rodriguez-Calvar.
398
399         * gstreamer/jhbuild.modules:
400         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
401
402 2018-02-09  Philippe Normand  <pnormand@igalia.com>
403
404         [JHBuild] Update Mesa to version 17
405         https://bugs.webkit.org/show_bug.cgi?id=182599
406
407         Reviewed by Carlos Alberto Lopez Perez.
408
409         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
410
411 2018-02-08  Chris Dumez  <cdumez@apple.com>
412
413         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
414         https://bugs.webkit.org/show_bug.cgi?id=182524
415         <rdar://problem/9057327>
416
417         Reviewed by Ryosuke Niwa.
418
419         Add API test coverage.
420
421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
422         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
423         (TestWebKitAPI::runJavaScriptAlert):
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
426         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
427         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
428         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
429
430 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
431
432         TestController should not exercise cocoa-specific resource load statistics APIs
433         https://bugs.webkit.org/show_bug.cgi?id=182355
434
435         Reviewed by Alex Christensen.
436
437         Remove unnecessary use of platform-specific APIs in the TestController, since there are
438         cross-platform APIs to do the same thing.
439
440         Also, ensure callbacks execute before returning from TestController's functions, since
441         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
442         prevent the TestController from being destroyed before the callbacks execute.
443
444         * WebKitTestRunner/TestController.cpp:
445         (WTR::resourceStatisticsVoidResultCallback):
446         (WTR::resourceStatisticsBooleanResultCallback):
447         (WTR::TestController::isStatisticsPrevalentResource):
448         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
449         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
450         (WTR::TestController::isStatisticsHasHadUserInteraction):
451         (WTR::TestController::isStatisticsGrandfathered):
452         (WTR::TestController::statisticsUpdateCookiePartitioning):
453         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
454         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
455         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
456         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
457         (WTR::resourceStatisticsCallback): Deleted.
458         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
459         * WebKitTestRunner/TestController.h:
460         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
461         (WTR::toNSString): Deleted.
462         (WTR::TestController::setStatisticsLastSeen): Deleted.
463         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
464         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
465         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
466         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
467         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
468         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
469         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
470         (WTR::TestController::setStatisticsGrandfathered): Deleted.
471         (WTR::TestController::isStatisticsGrandfathered): Deleted.
472         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
473         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
474         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
475         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
476         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
477         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
478         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
479         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
480         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
481         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
482         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
483         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
484         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
485         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
486         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
487         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
488         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
489         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
490         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
491         (WTR::TestController::statisticsResetToConsistentState): Deleted.
492
493 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
494
495         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
496         https://bugs.webkit.org/show_bug.cgi?id=182584
497
498         Reviewed by Daniel Bates.
499
500         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
501         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
502
503         * Scripts/webkitpy/common/checkout/checkout.py:
504         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
505         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
506
507 2018-02-08  Matt Lewis  <jlewis3@apple.com>
508
509         Unreviewed, rolling out r228261.
510
511         This broke an internal build
512
513         Reverted changeset:
514
515         "Add a way to check if a host is an IP address"
516         https://bugs.webkit.org/show_bug.cgi?id=182427
517         https://trac.webkit.org/changeset/228261
518
519 2018-02-08  Commit Queue  <commit-queue@webkit.org>
520
521         Unreviewed, rolling out r228267, r228268, and r228269.
522         https://bugs.webkit.org/show_bug.cgi?id=182601
523
524         jhbuild socks (Requested by philn on #webkit).
525
526         Reverted changesets:
527
528         "[JHBuild] Update Mesa to version 17"
529         https://bugs.webkit.org/show_bug.cgi?id=182599
530         https://trac.webkit.org/changeset/228267
531
532         "Unreviewed, GTK build fix attempt after r228267."
533         https://trac.webkit.org/changeset/228268
534
535         "Unreviewed, final GTK build fix attempt after r228267."
536         https://trac.webkit.org/changeset/228269
537
538 2018-02-08  Philippe Normand  <pnormand@igalia.com>
539
540         Unreviewed, final GTK build fix attempt after r228267.
541
542         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
543
544 2018-02-08  Philippe Normand  <pnormand@igalia.com>
545
546         Unreviewed, GTK build fix attempt after r228267.
547
548         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
549
550 2018-02-08  Philippe Normand  <pnormand@igalia.com>
551
552         [JHBuild] Update Mesa to version 17
553         https://bugs.webkit.org/show_bug.cgi?id=182599
554
555         Reviewed by Carlos Alberto Lopez Perez.
556
557         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
558
559 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         Add a way to check if a host is an IP address
562         https://bugs.webkit.org/show_bug.cgi?id=182427
563
564         Reviewed by Alex Christensen.
565
566         Add unit test for URL::hostIsIPAddress().
567
568         * TestWebKitAPI/Tests/WebCore/URL.cpp:
569         (TestWebKitAPI::TEST_F):
570
571 2018-02-07  Tim Horton  <timothy_horton@apple.com>
572
573         Evernote device management web view sometimes displays at the wrong scale
574         https://bugs.webkit.org/show_bug.cgi?id=182590
575         <rdar://problem/36633687>
576
577         Reviewed by Simon Fraser.
578
579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
580         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
581         (-[TestDelegateForScrollView dealloc]):
582         (TestWebKitAPI::TEST):
583         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
584         Add a test that failed before the change that ensures that we don't
585         consult the external delegate for viewForZoomingInScrollView:, and that
586         we succesfully update the scale even if it matches that of the view
587         the external delegate returns for viewForZoomingInScrollView:.
588
589 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
590
591         REGRESSION(r226396): File paths are inserted when dropping image files
592         https://bugs.webkit.org/show_bug.cgi?id=182557
593         <rdar://problem/37294120>
594
595         Reviewed by Ryosuke Niwa.
596
597         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
598         file paths on disk.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
601         (TEST):
602
603 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
604
605         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
606         https://bugs.webkit.org/show_bug.cgi?id=125068
607
608         Unreviewed test gardening.
609
610         They do not appear to have failed since we started running them again in r226944.
611
612         * TestWebKitAPI/glib/TestExpectations.json:
613
614 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
615
616         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
617         https://bugs.webkit.org/show_bug.cgi?id=120303
618
619         Unreviewed test gardening.
620
621         It does not appear to have failed since we started running it again in r226944.
622
623         * TestWebKitAPI/glib/TestExpectations.json:
624
625 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
626
627         [GTK] Enable WebKit.ForceRepaint test
628         https://bugs.webkit.org/show_bug.cgi?id=105532
629
630         Unreviewed test gardening.
631
632         It does not appear to have failed since we started running it again in r226944.
633
634         * TestWebKitAPI/glib/TestExpectations.json:
635
636 2018-02-07  Philippe Normand  <pnormand@igalia.com>
637
638         [JHBuild] Add libva in moduleset
639         https://bugs.webkit.org/show_bug.cgi?id=182384
640
641         Reviewed by Xabier Rodriguez-Calvar.
642
643         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
644         * gtk/install-dependencies: Remove libva from dependencies.
645         * wpe/install-dependencies: Ditto.
646
647 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
648
649         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
650         https://bugs.webkit.org/show_bug.cgi?id=85037
651
652         Unreviewed test gardening.
653
654         It does not appear to have failed since we started running it again in r226944.
655
656         * TestWebKitAPI/glib/TestExpectations.json:
657
658 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
659
660         Nit fix for ruby script called through Perl
661         https://bugs.webkit.org/show_bug.cgi?id=182552
662
663         Reviewed by Yusuke Suzuki.
664
665         * BuildSlaveSupport/build.webkit.org-config/steps.py:
666         (RunTest262Tests):
667
668 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
669
670         Remove WebCore/ForwardingHeaders directory
671         https://bugs.webkit.org/show_bug.cgi?id=182347
672
673         Reviewed by Keith Miller.
674
675         * WebKitTestRunner/TestController.cpp:
676
677 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
678
679         webkit-patch upload should ask for confirmation before creating a new bug
680         https://bugs.webkit.org/show_bug.cgi?id=182551
681
682         Reviewed by Daniel Bates.
683
684         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
685         first comment, which could result in embarrassment or potentially even a proprietary information leak.
686
687         * Scripts/webkitpy/tool/commands/upload_unittest.py:
688         (test_prepare):
689         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
690         (PromptForBugOrTitle):
691         (PromptForBugOrTitle.options):
692         (PromptForBugOrTitle.run):
693
694 2018-02-06  Youenn Fablet  <youenn@apple.com>
695
696         HasServiceWorkerRegistration bit should be sent when creating a new page
697         https://bugs.webkit.org/show_bug.cgi?id=182410
698
699         Reviewed by Chris Dumez.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
702
703 2018-02-06  Andres Gomez  <agomez@igalia.com>
704
705         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
706         https://bugs.webkit.org/show_bug.cgi?id=182346
707
708         Reviewed by Michael Catanzaro.
709
710         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
711         watchlist since they are running WKGTK+ EWS.
712
713         Similarly, Adrian and Carlos are running a WPE EWS.
714
715         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
716           and WebKitGTKDependencies watchlists with the proper people.
717
718 2018-02-06  Andres Gomez  <agomez@igalia.com>
719
720         Unreviewed, canonicalize contributors.json
721
722         After Thibault's addition, automatic checks complain about
723         contributors.json with:
724
725         "[...] Use "validate-committer-lists --canonicalize" to reformat
726         it. [...]"
727
728         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
729
730 2018-02-06  Andres Gomez  <agomez@igalia.com>
731
732         Unreviewed, add Lorenzo Tilve to contributors.json
733
734         We need to add Loren to the contributors list in order to CC him
735         in Bugzilla.
736
737         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
738           Tilve.
739
740 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
741
742         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
743         https://bugs.webkit.org/show_bug.cgi?id=182478
744
745         Reviewed by Alex Christensen.
746
747         For TestWebKitAPI, sources related to WebKitLegacy are built
748         at WebKit build. Those files should be reffered for WebKitLegacy build.
749
750         * TestWebKitAPI/PlatformWin.cmake:
751
752 2018-02-05  Daniel Bates  <dabates@apple.com>
753
754         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
755         https://bugs.webkit.org/show_bug.cgi?id=182360
756
757         Rubber-stamped by Aakash Jain.
758
759         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
760         In the terminal this looks like:
761
762             $ Tools/Scripts/run-webkit-tests
763             Expected to fail, but passed: (7)
764             ...
765             Stopping WebSocket server ...$
766
767         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
768         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
769         control-C interruption) we would stop all such servers twice: once as part of ending the test
770         run and once from the at-exit handler. The latter never prints a trailing newline character hence
771         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
772         stop servers that it started in LayoutTestRunner.start_servers().
773
774         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
775         (LayoutTestRunner.__init__):
776         (LayoutTestRunner.start_servers):
777         (LayoutTestRunner.stop_servers):
778         Only start servers that run-webkit-tests has not already started and only stop servers that
779         run-webkit-tests started.
780
781         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
782         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
783         (LayoutTestRunnerTests.test_servers_started):
784         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
785         Update due to rename below.
786
787         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
788         (is_web_socket_server_running): Added.
789         (PyWebSocket.is_running): Deleted.
790
791         * Scripts/webkitpy/port/base.py:
792         (Port.is_http_server_running): Check if we already started the server ourself.
793         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
794         to check if we already started the server ourself. Take a similar approach as the other
795         Port.is_*_running methods and only check if an existing WebSocket server is running on the
796         non-secure server port. This is a simple heuristic and should be sufficient in practice.
797         (Port.is_wpt_server_running): Check if we already started the server ourself.
798         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
799
800 2018-02-05  Daniel Bates  <dabates@apple.com>
801
802         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
803         https://bugs.webkit.org/show_bug.cgi?id=182405
804
805         Reviewed by David Kilzer.
806
807         String literal statements, including docstrings, do not demarcate a new scope in Python.
808         So, do not treat them like they do when building up the list of modified functions.
809
810         * Scripts/prepare-ChangeLog:
811         (get_function_line_ranges_for_python):
812         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
813         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
814         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
815         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
816         is used as a syntactic placeholder when a statement is required. Ideally we would make
817         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
818         not syntactic purpose.
819         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
820         (Class5):
821         (Class6):
822         (Class6.__init__):
823         (Class7):
824         (Class7.__init__):
825         (Class8):
826         (Class8.__init__):
827         Add some more tests.
828
829 2018-02-05  Matt Lewis  <jlewis3@apple.com>
830
831         Unreviewed, rolling out r228086.
832
833         This introduced a failure with API test
834         URLTest.HostIsIPAddress.
835
836         Reverted changeset:
837
838         "Add a way to check if a host is an IP address"
839         https://bugs.webkit.org/show_bug.cgi?id=182427
840         https://trac.webkit.org/changeset/228086
841
842 2018-02-05  John Wilander  <wilander@apple.com>
843
844         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
845         https://bugs.webkit.org/show_bug.cgi?id=181601
846         <rdar://problem/36475837>
847
848         Reviewed by Alex Christensen.
849
850         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
851         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
852         it's possible to check access even if a frame doesn't respond timely to
853         postMessage after detach and attach.
854
855         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
856         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
857         (WTR::InjectedBundle::didReceiveMessageToPage):
858         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
859         (WTR::TestRunner::setStorageAccessAPIEnabled):
860             Just moved for source file grouping.
861         (WTR::TestRunner::getAllStorageAccessEntries):
862         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
863         * WebKitTestRunner/InjectedBundle/TestRunner.h:
864         * WebKitTestRunner/TestController.cpp:
865         (WTR::TestController::getAllStorageAccessEntries):
866             Note that this is just stubbed out, i.e. not implemented.
867         * WebKitTestRunner/TestController.h:
868         * WebKitTestRunner/TestInvocation.cpp:
869         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
870         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
871         * WebKitTestRunner/TestInvocation.h:
872         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
873         (WTR::TestController::getAllStorageAccessEntries):
874             This is the Cocoa-specific version of this test infrastructure.
875
876 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
877
878         [Win] Enable multi CPU building on MSBuild.
879         https://bugs.webkit.org/show_bug.cgi?id=182446
880
881         Compiling itself already uses multi cores, but other stuff is still on single core.
882         This patch enables that by passing an argument to MSBuild.exe.
883
884         Reviewed by Alex Christensen.
885
886         * Scripts/webkitdirs.pm:
887         (determineNumberOfCPUs):
888         (buildVisualStudioProject):
889
890 2018-02-05  Alicia Boya García  <aboya@igalia.com>
891
892         Fix bug in MediaTime comparison for negative values with different scale.
893         https://bugs.webkit.org/show_bug.cgi?id=182433
894
895         Improved test coverage for MediaTime::compare().
896
897         Reviewed by Xabier Rodriguez-Calvar.
898
899         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
900         (TestWebKitAPI::TEST):
901
902 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
903
904         [SOUP] WebSockets must use system proxy settings
905         https://bugs.webkit.org/show_bug.cgi?id=126384
906
907         Reviewed by Michael Catanzaro.
908
909         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
910
911         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
912         (ProxyTest::webSocketProxyServerCallback):
913         (ProxyTest::ProxyTest):
914         (ProxyTest::webSocketConnected):
915         (ProxyTest::createWebSocketAndWaitUntilConnected):
916         (webSocketServerCallback):
917         (testWebContextProxySettings):
918         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
919         (WebKitTestServer::~WebKitTestServer):
920         (WebKitTestServer::addWebSocketHandler):
921         (WebKitTestServer::removeWebSocketHandler):
922         (WebKitTestServer::getWebSocketURIForPath const):
923         (WebKitTestServer::getURIForPath const):
924         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
925         (WebKitTestServer::baseURI const):
926         (WebKitTestServer::baseWebSocketURI const):
927
928 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         Add a way to check if a host is an IP address
931         https://bugs.webkit.org/show_bug.cgi?id=182427
932
933         Reviewed by Alex Christensen.
934
935         Add unit test for URL::hostIsIPAddress().
936
937         * TestWebKitAPI/Tests/WebCore/URL.cpp:
938         (TestWebKitAPI::TEST_F):
939
940 2018-02-03  Charlie Turner  <cturner@igalia.com>
941
942         Add libmount to WPE dependencies
943         https://bugs.webkit.org/show_bug.cgi?id=182345
944
945         Reviewed by Michael Catanzaro.
946
947         * wpe/install-dependencies:
948
949 2018-02-02  Youenn Fablet  <youenn@apple.com>
950
951         W3C test exporter should allow exporting newly added files
952         https://bugs.webkit.org/show_bug.cgi?id=182369
953
954         Reviewed by Ryosuke Niwa.
955
956         * Scripts/webkitpy/common/checkout/scm/git.py:
957         (Git.apply_mail_patch):
958
959 2018-02-02  David Quesada  <david_quesada@apple.com>
960
961         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
962         https://bugs.webkit.org/show_bug.cgi?id=182363
963         rdar://problem/37093498
964
965         Reviewed by Ryosuke Niwa.
966
967         Updated ApplicationManifestParserTests to account for the new default scope behavior.
968
969         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
970         (assertManifestHasDefaultValues):
971         (TEST_F):
972
973 2018-02-02  Youenn Fablet  <youenn@apple.com>
974
975         Clearing all service worker registrations should wait for importing service worker registration to finish
976         https://bugs.webkit.org/show_bug.cgi?id=182407
977
978         Reviewed by Chris Dumez.
979
980         Make sure we finish clearing service worker registrations before running tests.
981
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::resetStateToConsistentValues):
984         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
985         (WTR::clearServiceWorkerRegistrationsCallback):
986         (WTR::TestController::clearServiceWorkerRegistrations):
987         * WebKitTestRunner/TestController.h:
988
989 2018-02-02  Youenn Fablet  <youenn@apple.com>
990
991         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
992         https://bugs.webkit.org/show_bug.cgi?id=182403
993
994         Reviewed by Alex Christensen.
995
996         * WebKitTestRunner/TestController.cpp:
997         (WTR::TestController::generateContextConfiguration const):
998         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
999         (WTR::initializeWebViewConfiguration):
1000
1001 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1002
1003         [GTK] WebDriver: tests step always times out in the bot
1004         https://bugs.webkit.org/show_bug.cgi?id=182437
1005
1006         Reviewed by Carlos Alberto Lopez Perez.
1007
1008         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
1009         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
1010
1011         * Scripts/run-webdriver-tests: Call teardown() after run().
1012         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1013         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
1014         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1015         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
1016         the display driver once and pass it to the test runners.
1017         (WebDriverTestRunner.teardown): Stop the display server.
1018         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1019         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
1020         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
1021         (WebDriverTestRunnerSelenium.run): Ditto.
1022         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1023         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
1024         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
1025         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1026         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
1027
1028 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1029
1030         Unreviewed, rolling out r227999.
1031
1032         It didn't fix the problem
1033
1034         Reverted changeset:
1035
1036         "Unreviewed. Try to avoid webdriver tests step timing out in
1037         the bots."
1038         https://trac.webkit.org/changeset/227999
1039
1040 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1041
1042         Start timeout for the run-buildbot-test script is too aggressive
1043         https://bugs.webkit.org/show_bug.cgi?id=182429
1044
1045         Reviewed by Carlos Garcia Campos.
1046
1047         15 seconds is not enough waiting for the update database process
1048         to complete on a system backed with rotational HDDs. Raise it to 60.
1049
1050         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1051         (wait_for_master_ready):
1052
1053 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1054
1055         re-add ARM JSCOnly bots on buildbot waterfall
1056         https://bugs.webkit.org/show_bug.cgi?id=182428
1057
1058         Reviewed by Csaba Osztrogonác.
1059
1060         * BuildSlaveSupport/build.webkit.org-config/config.json:
1061         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1062
1063 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1064
1065         Remove ARM JSCOnly bots from buildbot waterfall
1066         https://bugs.webkit.org/show_bug.cgi?id=182398
1067
1068         Reviewed by Alexey Proskuryakov.
1069
1070         * BuildSlaveSupport/build.webkit.org-config/config.json:
1071         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1072
1073 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1076
1077         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
1078         workaround for a bug in python2.7 when using multiprocess module.
1079
1080         * Scripts/run-webdriver-tests:
1081
1082 2018-02-01  Youenn Fablet  <youenn@apple.com>
1083
1084         Delay service worker process creation until actually needed by SWServer
1085         https://bugs.webkit.org/show_bug.cgi?id=182301
1086
1087         Reviewed by Chris Dumez.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1090         (function):
1091
1092 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
1093
1094         Bubbles intermittently disappear from bot watchers dashboard
1095         https://bugs.webkit.org/show_bug.cgi?id=182085
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1100         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
1101         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1102         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1103
1104 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1105
1106         [GTK] Problem with Washington Post images
1107         https://bugs.webkit.org/show_bug.cgi?id=181421
1108
1109         Reviewed by Carlos Alberto Lopez Perez.
1110
1111         Add test case for the new user agent quirk.
1112
1113         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1114         (TestWebKitAPI::TEST):
1115
1116 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         [GTK] MiniBrowser settings are just a list of names
1119         https://bugs.webkit.org/show_bug.cgi?id=182005
1120
1121         Reviewed by Sergio Villar Senin.
1122
1123         The default size we are using is too small to show the values column, and the window is not resizable because
1124         GObjectClass::constructed() is not called in the parent class.
1125
1126         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1127         (browser_settings_dialog_init): Use 600x400 as default size.
1128         (browserSettingsDialogConstructed): Chain up to parent constructed.
1129
1130 2018-01-31  Andres Gomez  <agomez@igalia.com>
1131
1132         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
1133
1134         * Scripts/webkitpy/common/config/watchlist:
1135
1136 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
1137
1138         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1139         https://bugs.webkit.org/show_bug.cgi?id=181204
1140         <rdar://problem/36256274>
1141
1142         Reviewed by Ryosuke Niwa.
1143
1144         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1145
1146         * DumpRenderTree/TestRunner.cpp:
1147         (forceImmediateCompletionCallback):
1148         (TestRunner::staticFunctions):
1149
1150 2018-01-31  Alex Christensen  <achristensen@webkit.org>
1151
1152         Unreviewed, rolling out r227942.
1153
1154         r227875 should not have been rolled out.
1155
1156         Reverted changeset:
1157
1158         "Unreviewed, rolling out r227875."
1159         https://bugs.webkit.org/show_bug.cgi?id=182357
1160         https://trac.webkit.org/changeset/227942
1161
1162 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1163
1164         Unreviewed, rolling out r227875.
1165         https://bugs.webkit.org/show_bug.cgi?id=182357
1166
1167         Missing cross-platform TestController implementation
1168
1169         Reverted changeset:
1170
1171         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
1172         https://bugs.webkit.org/show_bug.cgi?id=181958
1173         https://trac.webkit.org/changeset/227875
1174
1175         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1176         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1177         (WTR::InjectedBundle::didReceiveMessageToPage):
1178         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1179         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1180         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1181         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
1182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1183         * WebKitTestRunner/TestInvocation.cpp:
1184         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1185         * WebKitTestRunner/TestInvocation.h:
1186         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1187         (WTR::TestController::statisticsUpdateCookiePartitioning):
1188         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1189
1190 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1191
1192         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
1193         https://bugs.webkit.org/show_bug.cgi?id=182222
1194
1195         Reviewed by Alex Christensen.
1196
1197         Use the new API to notify when resource load statistics deletion is complete.
1198
1199         * WebKitTestRunner/TestController.cpp:
1200         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
1201         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1202         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1203
1204 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1205
1206         Add the support for running StyleBench to run-benchmark
1207         https://bugs.webkit.org/show_bug.cgi?id=182323
1208
1209         Reviewed by Antti Koivisto.
1210
1211         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
1212
1213         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
1214         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
1215
1216 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1217
1218         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
1219         https://bugs.webkit.org/show_bug.cgi?id=182339
1220         <rdar://problem/36041396>
1221
1222         Reviewed by Andy Estes.
1223
1224         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
1225         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
1226         check against the length of the data written.
1227
1228         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1229         (testIconImageData):
1230         (runTestWithTemporaryFolder):
1231         (TestWebKitAPI::TEST):
1232
1233 2018-01-31  Dan Bernstein  <mitz@apple.com>
1234
1235         [macOS] MiniBrowser isn’t app-sandboxed
1236         https://bugs.webkit.org/show_bug.cgi?id=182147
1237
1238         Reviewed by Sam Weinig.
1239
1240         Enable App Sandbox and add a temporary exception allowing read access to all files.
1241
1242         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
1243         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
1244         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
1245           and read access from /.
1246         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
1247
1248 2018-01-31  Philippe Normand  <pnormand@igalia.com>
1249
1250         [JHBuild] Add gstreamer-vaapi in moduleset
1251         https://bugs.webkit.org/show_bug.cgi?id=182283
1252
1253         Reviewed by Carlos Alberto Lopez Perez.
1254
1255         GStreamer-VAAPI is required for hardware-accelerated video
1256         playback support on Intel and AMD (using radeosi driver)
1257         platforms.
1258
1259         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
1260         * gtk/install-dependencies: Install libva.
1261         * wpe/install-dependencies: Ditto.
1262         * Scripts/webkitpy/port/gtk.py:
1263         (GtkPort.setup_environ_for_server): Disable va-api support when
1264         testing because it's incompatible with Mesa's softGL driver.
1265
1266 2018-01-31  Charlie Turner  <cturner@igalia.com>
1267
1268         [WPE] Update jhbuild dependencies
1269         https://bugs.webkit.org/show_bug.cgi?id=182286
1270
1271         This upgrades the following packages,
1272         glib 2.44.1 -> 2.54.3
1273         glib-networking 2.42.0 -> 2.54.1
1274         libsoup 2.48.0 -> 2.60.3
1275
1276         The initial reason for performing these upgrades was that when
1277         visiting https://youtube.com, WPE was getting TLS certificate
1278         errors. After upgrading glib-networking, these were fixed, but the
1279         upgrade introduced dependencies on newer versions of the other
1280         packages upgraded in this commit.
1281
1282         The upgrade to glib caused a linking error in gstreamer, the
1283         following errors were being logged during linking,
1284
1285         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
1286         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
1287         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
1288
1289         This was fixed by adding the glib package built in the jhbuild to
1290         harfbuzz.
1291
1292         Finally, the upgrade of glib caused the glib-warning-fix.patch to
1293         no longer apply, so this patch was removed.
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * wpe/jhbuild.modules: Added dependecies.
1298         * wpe/patches/glib-warning-fix.patch: Removed.
1299
1300 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1301
1302         Unreviewed, rolling out r227782.
1303
1304         It didn't fix the problem
1305
1306         Reverted changeset:
1307
1308         "Unreviewed. Try to avoid webdriver tests step timing out in
1309         the bots."
1310         https://trac.webkit.org/changeset/227782
1311
1312 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1313
1314         WebDriver: add domains to server config in w3c tests
1315         https://bugs.webkit.org/show_bug.cgi?id=182294
1316
1317         Reviewed by Carlos Alberto Lopez Perez.
1318
1319         Several cookie tests expect server_config to have a domains key.
1320
1321         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
1322                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
1323
1324         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1325         (WebDriverW3CExecutor.__init__):
1326
1327 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         Unreviewed. Update W3C WebDriver imported tests.
1330
1331         Show full pytest failure logs.
1332
1333         pytest truncates long lists when printing a failed assertion.
1334         This is not great for debugging and arguably it should be the
1335         default to show the full diff when comparing lists.
1336
1337         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1338         (run):
1339
1340 2018-01-30  John Wilander  <wilander@apple.com>
1341
1342         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
1343         https://bugs.webkit.org/show_bug.cgi?id=181958
1344         https://bugs.webkit.org/show_bug.cgi?id=182072
1345         <rdar://problem/36801804>
1346         <rdar://problem/36845795>
1347
1348         Reviewed by Brent Fulgham.
1349
1350         Because of the asynchronous nature of XPC and cookies,
1351         we need callbacks in these TestRunner functions so that
1352         the layout tests can wait for state changes to finish
1353         before checking test conditions.
1354
1355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1356         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1357         (WTR::InjectedBundle::didReceiveMessageToPage):
1358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1359         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1360         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1361         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
1362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1363         * WebKitTestRunner/TestInvocation.cpp:
1364         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
1365         * WebKitTestRunner/TestInvocation.h:
1366         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1367         (WTR::TestController::statisticsUpdateCookiePartitioning):
1368         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1369
1370 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1371
1372         [webkitpy] Config file for apache is copied twice.
1373         https://bugs.webkit.org/show_bug.cgi?id=182131
1374
1375         Reviewed by Daniel Bates.
1376
1377         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1378         (LayoutTestApacheHttpd.__init__):
1379         (LayoutTestApacheHttpd._copy_apache_config_file):
1380         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
1381
1382 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1383
1384         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1385         https://bugs.webkit.org/show_bug.cgi?id=182312
1386
1387         Reviewed by Michael Catanzaro.
1388
1389         * DumpRenderTree/config.h:
1390         * TestWebKitAPI/config.h:
1391         * WebKitTestRunner/config.h:
1392
1393 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1394
1395         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
1396         https://bugs.webkit.org/show_bug.cgi?id=182307
1397         <rdar://problem/36041485>
1398
1399         Reviewed by Ryosuke Niwa.
1400
1401         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
1402         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
1403         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
1404         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
1405
1406         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
1407         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1408         (TestWebKitAPI::TEST):
1409
1410 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
1411
1412         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
1413         https://bugs.webkit.org/show_bug.cgi?id=182284
1414
1415         Reviewed by Michael Catanzaro.
1416
1417         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
1418         * wpe/manifest.txt.in: Ditto.
1419
1420 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1421
1422         Unreviewed, try to fix JSCOnly build
1423         https://bugs.webkit.org/show_bug.cgi?id=177202
1424
1425         * CMakeLists.txt:
1426
1427 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1428
1429         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1430
1431         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
1432         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
1433         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
1434         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
1435
1436         * Scripts/run-webdriver-tests:
1437         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1438         (WebDriverTestRunner.dump_results_to_json_file):
1439
1440 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1441
1442         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
1443         https://bugs.webkit.org/show_bug.cgi?id=177202
1444
1445         Reviewed by Alex Christensen.
1446
1447         * CMakeLists.txt:
1448
1449 2018-01-29  Alex Christensen  <achristensen@webkit.org>
1450
1451         Clean up API after bugs 178240 and 176474
1452         https://bugs.webkit.org/show_bug.cgi?id=182259
1453
1454         Reviewed by Dan Bernstein.
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1457         (TEST):
1458         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1459
1460 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1461
1462         [WebAuthN] Add a compile-time feature flag
1463         https://bugs.webkit.org/show_bug.cgi?id=182211
1464         <rdar://problem/36936365>
1465
1466         Reviewed by Brent Fulgham.
1467
1468         * Scripts/webkitperl/FeatureList.pm:
1469         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1470
1471 2018-01-29  Brady Eidson  <beidson@apple.com>
1472
1473         Make the API test added in r227737 be Mac-only.
1474
1475         Unreviewed gardening.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
1478
1479 2018-01-29  Matt Lewis  <jlewis3@apple.com>
1480
1481         Unreviewed, rolling out r227731.
1482
1483         This caused and assertion failure in API tests.
1484
1485         Reverted changeset:
1486
1487         "Layout Test fast/events/beforeunload-dom-manipulation-
1488         crash.html is crashing"
1489         https://bugs.webkit.org/show_bug.cgi?id=181204
1490         https://trac.webkit.org/changeset/227731
1491
1492 2018-01-29  Youenn Fablet  <youenn@apple.com>
1493
1494         WPT test exporter should add WebKit export in its PR description
1495         https://bugs.webkit.org/show_bug.cgi?id=182246
1496
1497         Reviewed by Chris Dumez.
1498
1499         Updating PR description body to contain the words 'WebKit export'.
1500         That way, WPT PR bot will mark the PR as reviewed downstream.
1501
1502         * Scripts/webkitpy/w3c/test_exporter.py:
1503         (TestExporter.__init__):
1504         (TestExporter.make_pull_request):
1505         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1506         (TestExporterTest.test_export):
1507
1508 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
1509
1510         Add the support for running Speedometer 2.0 to run-benchmark
1511         https://bugs.webkit.org/show_bug.cgi?id=182231
1512
1513         Reviewed by Antti Koivisto.
1514
1515         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
1516         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
1517         requires aggregating the geometric mean out of total time spent in each suite.
1518
1519         Also added --show-iteration-values to show individual measured values in each iteration.
1520
1521         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1522         (BenchmarkResults.format): Added show_iteration_values as an option.
1523         (BenchmarkResults._format_tests): Ditto.
1524         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
1525         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
1526         is easily parsable as a JSON array.
1527         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
1528         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
1529         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
1530         had exactly one aggregator.
1531         (BenchmarkResults._lint_results):
1532         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
1533         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
1534         parent_aggregator_list.
1535         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
1536         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
1537         (BenchmarkResults._lint_configuration):
1538         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1539         (test_format_values_with_no_unit_scaling): Added.
1540         (test_format_values_with_iteration_values): Added.
1541         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
1542         (test_aggregate_results_from_another_aggregator): Added.
1543         (test_lint_results): Added a test case.
1544         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1545         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
1546         (BenchmarkRunner._run_benchmark): Ditto.
1547         (BenchmarkRunner.show_results): Ditto.
1548         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
1549         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
1550         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1551         (parse_args): Added --show-iteration-values as a boolean argument.
1552         (run_benchmark_plan): Ditto.
1553         (start): Ditto.
1554         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1555         (WebServerBenchmarkRunner.__init__): Ditto.
1556
1557 2018-01-29  Brady Eidson  <beidson@apple.com>
1558
1559         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
1560         https://bugs.webkit.org/show_bug.cgi?id=182229
1561
1562         Reviewed by Chris Dumez.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
1566
1567 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1568
1569         WebDriver: properly recover w3c tests after a webdriver server crash
1570         https://bugs.webkit.org/show_bug.cgi?id=182242
1571
1572         Reviewed by Carlos Alberto Lopez Perez.
1573
1574         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
1575         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
1576         relaunching the server after every test failure, because other failures, even when not crashing the server,
1577         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
1578         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
1579
1580         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1581         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
1582         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1583         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
1584         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
1585         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
1586         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
1587         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
1588
1589 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
1590
1591         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1592         https://bugs.webkit.org/show_bug.cgi?id=181204
1593         <rdar://problem/36256274>
1594
1595         Reviewed by Ryosuke Niwa.
1596
1597         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1598
1599         * DumpRenderTree/TestRunner.cpp:
1600         (forceImmediateCompletionCallback):
1601         (TestRunner::staticFunctions):
1602
1603 2018-01-29  Frederic Wang  <fwang@igalia.com>
1604
1605         Unreviewed, add myself to some watch lists.
1606
1607         * Scripts/webkitpy/common/config/watchlist:
1608
1609 2018-01-27  Dan Bernstein  <mitz@apple.com>
1610
1611         HaveInternalSDK includes should be "#include?"
1612         https://bugs.webkit.org/show_bug.cgi?id=179670
1613
1614         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1615
1616 2018-01-26  Chris Dumez  <cdumez@apple.com>
1617
1618         Make sure service worker code does not launch a StorageProcess unnecessarily
1619         https://bugs.webkit.org/show_bug.cgi?id=182192
1620         <rdar://problem/36927427>
1621
1622         Reviewed by Geoffrey Garen.
1623
1624         Add API test coverage.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1627
1628 2018-01-26  Chris Dumez  <cdumez@apple.com>
1629
1630         Offlined content does not work for apps on home screen
1631         https://bugs.webkit.org/show_bug.cgi?id=182070
1632         <rdar://problem/36843906>
1633
1634         Reviewed by Youenn Fablet.
1635
1636         Add API test coverage to make sure an already registered service worker is able to intercept
1637         the very first load.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1640         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
1641
1642 2018-01-26  Chris Nardi  <cnardi@chromium.org>
1643
1644         Addressing post-review comments after r226614
1645         https://bugs.webkit.org/show_bug.cgi?id=182151
1646
1647         Reviewed by Myles C. Maxfield.
1648
1649         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
1650         (TestWebKitAPI::TEST):
1651
1652 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
1653
1654         Unreviewed, rolling out r224920.
1655
1656         Some Win EWS bots are not coming back up after starting reboot.
1657
1658         * EWSTools/start-queue-win.sh:
1659
1660 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         WebDriver: simplify the tests json report
1663         https://bugs.webkit.org/show_bug.cgi?id=182171
1664
1665         Reviewed by Carlos Alberto Lopez Perez.
1666
1667         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
1668         form the subtest name. We should do the same for simplicity and compatibility with WPT.
1669
1670         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1671         (WebDriverTestRunner.dump_results_to_json_file):
1672
1673 2018-01-25  Alex Christensen  <achristensen@webkit.org>
1674
1675         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
1676         https://bugs.webkit.org/show_bug.cgi?id=182152
1677
1678         Reviewed by Joseph Pecoraro.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1681         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1682         (TEST):
1683
1684 2018-01-25  Youenn Fablet  <youenn@apple.com>
1685
1686         WebPluginInfoProvider should handle null host queries
1687         https://bugs.webkit.org/show_bug.cgi?id=182112
1688
1689         Reviewed by Chris Dumez.
1690
1691         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
1692         (TEST):
1693
1694 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1695
1696         [webkitpy] Stop modifying path information only when running on Cygwin
1697         https://bugs.webkit.org/show_bug.cgi?id=182136
1698
1699         On LayoutTestApacheHttpd, some path configuration is modified when platform
1700         is Windows. This modification is only required for AppleWin running on Cygwin.
1701         WinCairo uses native Windows environment, so the condition should be changed.
1702
1703         Reviewed by Per Arne Vollan.
1704
1705         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1706         (LayoutTestApacheHttpd.__init__):
1707         (LayoutTestApacheHttpd._get_apache_config_file_path):
1708
1709 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
1710
1711         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
1712         https://bugs.webkit.org/show_bug.cgi?id=182038
1713         <rdar://problem/36812083>
1714
1715         Reviewed by Jer Noble.
1716
1717         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1718         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
1719
1720 2018-01-24  Daniel Bates  <dabates@apple.com>
1721
1722         webkit-patch upload emits irrelevant simulator warnings
1723         https://bugs.webkit.org/show_bug.cgi?id=181702
1724         <rdar://problem/36556359>
1725
1726         Reviewed by Aakash Jain.
1727
1728         Remove warning when a person explicitly passes --child-processes with a value greater than
1729         the default number of simulator instances webkitpy would have used had --child-processes
1730         been omitted. Moreover, the placement of the warning logic to support printing such a message
1731         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
1732
1733         By default, webkitpy will parallelize running tests using the maximum number of simulator
1734         instances that can be supported based on available system resources at the time run-webkit-tests
1735         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
1736         by specifying --child-processes knows what they are doing. The effects of picking a large
1737         value be obvious, the system may become sluggish.
1738
1739         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
1740         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
1741
1742         * Scripts/webkitpy/port/ios_simulator.py:
1743         (IOSSimulatorPort.__init__):
1744
1745 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
1746
1747         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
1748         https://bugs.webkit.org/show_bug.cgi?id=182102
1749
1750         Reviewed by Carlos Garcia Campos.
1751
1752         * MiniBrowser/gtk/main.c:
1753         (main): Removed the call to set_enable_webvr().
1754
1755 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1756
1757         WebDriver: add support for slow tests
1758         https://bugs.webkit.org/show_bug.cgi?id=182095
1759
1760         Reviewed by Carlos Alberto Lopez Perez.
1761
1762         Add timeout mark to slow tests.
1763
1764         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1765         (TestExpectationsMarker.__init__): Save the timeout.
1766         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
1767         (run): Pass timeout to TestExpectationsMarker constructor.
1768
1769 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1770
1771         Gracefully recover from NetworkProcess crashes in private browsing
1772         https://bugs.webkit.org/show_bug.cgi?id=182073
1773         <rdar://problem/36572023>
1774
1775         Reviewed by Geoff Garen.
1776
1777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1778         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
1779         (-[CrashDelegate webView:didFinishNavigation:]):
1780         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
1781         (-[CrashDelegate webView:didFailNavigation:withError:]):
1782         (TEST):
1783
1784 2018-01-24  Ali Juma  <ajuma@chromium.org>
1785
1786         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
1787         https://bugs.webkit.org/show_bug.cgi?id=182052
1788
1789         Reviewed by Simon Fraser.
1790
1791         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
1792         immediately.
1793
1794         Test: fast/visual-viewport/viewport-dimensions.html
1795
1796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1797         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1798
1799 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1800
1801         Remove pre-Sierra-OS-specific code in Tools
1802         https://bugs.webkit.org/show_bug.cgi?id=182034
1803
1804         Reviewed by Tim Horton.
1805
1806         * DumpRenderTree/mac/DumpRenderTree.mm:
1807         (setDefaultsToConsistentValuesForTesting):
1808         * MiniBrowser/mac/BrowserWindowController.m:
1809         (-[BrowserWindowController windowDidLoad]):
1810         (-[BrowserWindowController share:]):
1811         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1812         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1813         (-[EventStreamPlayer playbackTimerFired:]):
1814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1815         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1816         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1817         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1818         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1819         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1820         (WTR::InjectedBundle::platformInitialize):
1821         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1822         (WTR::initializeWebViewConfiguration):
1823
1824 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
1825
1826         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1827         https://bugs.webkit.org/show_bug.cgi?id=181400
1828         <rdar://problem/36358768>
1829
1830         Reviewed by Joseph Pecoraro.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
1833
1834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
1835         Always disable poisoning when running with --leaks, as this should work locally,
1836         not just on bots.
1837
1838 2018-01-24  Daniel Bates  <dabates@apple.com>
1839
1840         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
1841         https://bugs.webkit.org/show_bug.cgi?id=181993
1842         <rdar://problem/36421080>
1843
1844         Reviewed by David Hyatt.
1845
1846         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
1847         as we no longer support this strategy.
1848
1849         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
1850
1851 2018-01-24  David Kilzer  <ddkilzer@apple.com>
1852
1853         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
1854         <https://webkit.org/b/182015>
1855         <rdar://problem/36449728>
1856
1857         Reviewed by Tim Horton.
1858
1859         * Scripts/webkitpy/style/checkers/cpp.py:
1860         (regex_for_lambdas_and_blocks): Update regex to include
1861         optional return type for block argument in Objective-C.
1862         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1863         (WebKitStyleTest.test_braces): Add test.
1864
1865 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
1866
1867         WPE-focused test gardening.
1868         https://bugs.webkit.org/show_bug.cgi?id=182051
1869
1870         Unreviewed test gardening.
1871
1872         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
1873
1874 2018-01-23  Mark Lam  <mark.lam@apple.com>
1875
1876         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
1877         https://bugs.webkit.org/show_bug.cgi?id=182017
1878         <rdar://problem/36795513>
1879
1880         Reviewed by Filip Pizlo and JF Bastien.
1881
1882         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1883         (TestWebKitAPI::TEST):
1884         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1885         (TestWebKitAPI::TEST):
1886         (TestWebKitAPI::passWithRef):
1887         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1888         (TestWebKitAPI::TEST):
1889         (TestWebKitAPI::f1):
1890         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1891         (TestWebKitAPI::TEST):
1892         (TestWebKitAPI::poisonedPtrFoo):
1893         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1896         (TestWebKitAPI::TEST):
1897
1898 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
1899
1900         [WebVR] Add OpenVR to the tree and to the build
1901         https://bugs.webkit.org/show_bug.cgi?id=177298
1902
1903         Reviewed by Žan Doberšek.
1904
1905         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1906         with reduced style checks.
1907
1908 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1909
1910         Add Chris Nardi to contributors list
1911         https://bugs.webkit.org/show_bug.cgi?id=182029
1912
1913         Reviewed by Antti Koivisto.
1914
1915         * Scripts/webkitpy/common/config/contributors.json:
1916
1917 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1918
1919         Mac Sierra perf bots have been failing due to CG errors
1920         https://bugs.webkit.org/show_bug.cgi?id=181955
1921
1922         Reviewed by Antti Koivisto.
1923
1924         Ignore the CoreGraphics error messages on macOS Sierra.
1925
1926         Also added tests for ignoring lines in stdout and stderr.
1927
1928         * Scripts/webkitpy/performance_tests/perftest.py:
1929         (PerfTest.run_failed): Refactored for clarity.
1930         (PerfTest):
1931         (PerfTest.filter_ignored_lines): Added.
1932         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1933         are now used to ignore lines in other kinds of tests than parser tests.
1934         (PerfTest._errors_to_ignore_in_sierra): Added.
1935         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1936         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1937         (test_parse_output_with_ignored_stdout): Added.
1938         (test_parse_output_with_ignored_stderr): Added.
1939         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1940
1941 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1942
1943         Resign NowPlaying status when no media element is eligible
1944         https://bugs.webkit.org/show_bug.cgi?id=181914
1945         <rdar://problem/35294116>
1946
1947         Reviewed by Jer Noble.
1948
1949         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1950         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1951         (TestWebKitAPI::TEST):
1952         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1953
1954 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1955
1956         [WinCairo] Use 64-bit toolset
1957         https://bugs.webkit.org/show_bug.cgi?id=181979
1958
1959         Reviewed by Alex Christensen.
1960
1961         Use 64-bit toolset for 64-bit build in order to improve build time. 
1962
1963         * Scripts/webkitdirs.pm:
1964         (generateBuildSystemFromCMakeProject):
1965
1966 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1967
1968         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1969         https://bugs.webkit.org/show_bug.cgi?id=181741
1970         rdar://problem/36593581
1971
1972         Reviewed by Tim Horton.
1973         
1974         If zoomToScale:animated: is called with the current zoom level, call the callback
1975         rather than doing nothing.
1976
1977         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1978         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1979
1980 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1981
1982         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1983         https://bugs.webkit.org/show_bug.cgi?id=180820
1984
1985         Reviewed by David Kilzer.
1986
1987         * Scripts/webkitpy/common/checkout/scm/git.py:
1988         (Git.in_working_directory):
1989         (Git.clone):
1990         (Git.read_git_config):
1991         (Git.apply_reverse_diff):
1992         * Scripts/webkitpy/common/checkout/scm/scm.py:
1993         (SCM.run):
1994         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1995         * Scripts/webkitpy/common/checkout/scm/svn.py:
1996         (SVNRepository.has_authorization_for_realm):
1997         * Scripts/webkitpy/common/net/credentials_unittest.py:
1998         * Scripts/webkitpy/common/system/abstractexecutive.py:
1999         (AbstractExecutive.run_command):
2000         * Scripts/webkitpy/common/system/executive.py:
2001         (Executive.kill_process.is):
2002         (Executive.running_pids):
2003         (Executive.kill_all):
2004         (Executive.run_command):
2005         * Scripts/webkitpy/common/system/executive_mock.py:
2006         (MockExecutive.run_command):
2007         (MockExecutive2.run_command):
2008         * Scripts/webkitpy/common/system/executive_unittest.py:
2009         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
2010         * Scripts/webkitpy/common/system/platforminfo.py:
2011         (PlatformInfo.xcode_sdk_version):
2012         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2013         (Lighttpd._check_and_kill):
2014         * Scripts/webkitpy/port/base.py:
2015         (Port._symbols_string):
2016         * Scripts/webkitpy/port/gtk.py:
2017         (GtkPort.setup_environ_for_server):
2018         * Scripts/webkitpy/port/win.py:
2019         (WinPort._runtime_feature_list):
2020         (WinPort.read_registry_value):
2021         * Scripts/webkitpy/port/win_unittest.py:
2022         (WinPortTest.test_runtime_feature_list):
2023         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2024         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2025
2026 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2027
2028         Unreviewed, rolling out r227279 and r227373.
2029         https://bugs.webkit.org/show_bug.cgi?id=181988
2030
2031         The LayoutTest crash fix introduced an API test failure.
2032         (Requested by ryanhaddad on #webkit).
2033
2034         Reverted changesets:
2035
2036         "Resign NowPlaying status when no media element is eligible"
2037         https://bugs.webkit.org/show_bug.cgi?id=181914
2038         https://trac.webkit.org/changeset/227279
2039
2040         "Resign NowPlaying status when no media element is eligible"
2041         https://bugs.webkit.org/show_bug.cgi?id=181914
2042         https://trac.webkit.org/changeset/227373
2043
2044 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2045
2046         Unreviewed. Add test case for slow in test_expectations.py.
2047
2048         I forgot to also check slow tests in test_expectations.py unit tests.
2049
2050         * Scripts/webkitpy/common/test_expectations_unittest.py:
2051         (assert_slow):
2052         (test_build_type):
2053         (test_slow):
2054
2055 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2056
2057         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
2058
2059         * TestWebKitAPI/glib/TestExpectations.json:
2060
2061 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
2064         https://bugs.webkit.org/show_bug.cgi?id=181616
2065         <rdar://problem/36484908>
2066
2067         Reviewed by Wenson Hsieh.
2068
2069         Added tests to make sure we sanitize plain HTML, not just web archives,
2070         when and only when custom pasteboard data is enabled.
2071
2072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2073         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
2074         (writeHTMLToPasteboard): Added.
2075         (createWebViewWithCustomPasteboardDataSetting): Added.
2076
2077 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
2078
2079         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2080         https://bugs.webkit.org/show_bug.cgi?id=181400
2081         rdar://problem/36358768
2082
2083         Reviewed by JF Bastien.
2084
2085         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
2086
2087 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
2090         https://bugs.webkit.org/show_bug.cgi?id=181929
2091
2092         Reviewed by Michael Catanzaro.
2093
2094         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
2095         the website data completion callback is not called immediately, and a new file is created when the operation
2096         finishes. We need to check that the file was removing after calling clear.
2097
2098         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2099         (fileChangedCallback):
2100         (testWebsiteDataResourceLoadStatistics):
2101
2102 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2103
2104         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2105
2106         * TestWebKitAPI/glib/TestExpectations.json:
2107
2108 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2109
2110         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2111
2112         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2113
2114         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2115         (testWebKitConsoleMessageNetworkError):
2116
2117 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2118
2119         Unreviewed. Remove unused verbose mode from GLib API tests runner.
2120
2121         * glib/api_test_runner.py:
2122         (add_options):
2123
2124 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2125
2126         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2127         https://bugs.webkit.org/show_bug.cgi?id=181918
2128
2129         Reviewed by Tim Horton.
2130
2131         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2132
2133         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2134
2135 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
2136
2137         Resign NowPlaying status when no media element is eligible
2138         https://bugs.webkit.org/show_bug.cgi?id=181914
2139         <rdar://problem/35294116>
2140
2141         Reviewed by Jer Noble.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2144         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2147
2148 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
2149
2150         Fix broken unit-tests after r227192
2151         https://bugs.webkit.org/show_bug.cgi?id=181909
2152
2153         Reviewed by Carlos Garcia Campos.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2156
2157 2018-01-20  Chris Dumez  <cdumez@apple.com>
2158
2159         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
2160         https://bugs.webkit.org/show_bug.cgi?id=174984
2161         <rdar://problem/33665676>
2162
2163         Reviewed by Alexey Proskuryakov.
2164
2165         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2168         (TEST):
2169
2170 2018-01-20  Brian Burg  <bburg@apple.com>
2171
2172         WebDriver: fix some nits that prevent running W3C tests on Mac
2173         https://bugs.webkit.org/show_bug.cgi?id=181864
2174
2175         Reviewed by Carlos Garcia Campos.
2176
2177         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2178         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
2179         as we assume that the property exists later.
2180
2181         (WebDriverW3CWebServer.stop): If the temporary file doesn't
2182         exist for some reason, the remove call will raise and exception.
2183         Gracefully handle the case where the file isn't created due to
2184         a problem/exception that happened elsewhere.
2185
2186 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
2187
2188         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
2189         https://bugs.webkit.org/show_bug.cgi?id=181881
2190
2191         Reviewed by Alexey Proskuryakov.
2192
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2194         (BubbleQueueServer):
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2197         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
2198
2199 2018-01-19  Youenn Fablet  <youenn@apple.com>
2200
2201         Do not go to the storage process when registering a service worker client if there is no service worker registered
2202         https://bugs.webkit.org/show_bug.cgi?id=181740
2203         <rdar://problem/36650400>
2204
2205         Reviewed by Chris Dumez.
2206
2207         Add support for internals inside API tests.
2208
2209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2210         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
2211         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
2212         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
2213         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
2214         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
2215         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2216         (setConfigurationInjectedBundlePath):
2217         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
2218
2219 2018-01-19  John Wilander  <wilander@apple.com>
2220
2221         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
2222         https://bugs.webkit.org/show_bug.cgi?id=181822
2223         https://bugs.webkit.org/show_bug.cgi?id=175263
2224         https://bugs.webkit.org/show_bug.cgi?id=178536
2225         https://bugs.webkit.org/show_bug.cgi?id=181223
2226         https://bugs.webkit.org/show_bug.cgi?id=181482
2227         <rdar://problem/33491222>
2228         <rdar://problem/33805293>
2229         <rdar://problem/36332683>
2230         <rdar://problem/36549026>
2231
2232         Reviewed by Alex Christensen.
2233
2234         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2235         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2236         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2237         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2238         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2239         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2240         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2241         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2242
2243 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
2244
2245         run-webkit-tests fails when there is a curly brace in Xcode build output
2246         https://bugs.webkit.org/show_bug.cgi?id=181254
2247         <rdar://problem/36453374>
2248
2249         Reviewed by Daniel Bates.
2250
2251         * Scripts/webkitpy/port/base.py:
2252         (Port._run_script): Encode script output before logging it.
2253
2254 2018-01-19  Chris Dumez  <cdumez@apple.com>
2255
2256         Service worker registrations restored from disk may not be reused when the JS calls register() again
2257         https://bugs.webkit.org/show_bug.cgi?id=181810
2258         <rdar://problem/36591711>
2259
2260         Reviewed by Youenn Fablet.
2261
2262         Add API test coverage.
2263
2264         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2265         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
2266         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
2267
2268 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2269
2270         Remove El Capitan queues from flakiness dashboard
2271         https://bugs.webkit.org/show_bug.cgi?id=181860
2272
2273         Reviewed by Aakash Jain.
2274
2275         * TestResultServer/static-dashboards/builders.jsonp:
2276
2277 2018-01-19  Keith Miller  <keith_miller@apple.com>
2278
2279         HaveInternalSDK includes should be "#include?"
2280         https://bugs.webkit.org/show_bug.cgi?id=179670
2281
2282         Reviewed by Dan Bernstein.
2283
2284         * MiniBrowser/Configurations/Base.xcconfig:
2285         * MobileMiniBrowser/Configurations/Base.xcconfig:
2286         * TestWebKitAPI/Configurations/Base.xcconfig:
2287         * WebKitTestRunner/Configurations/Base.xcconfig:
2288
2289 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2290
2291         WebDriver: driver environment not passed to pytest when running w3c tests
2292         https://bugs.webkit.org/show_bug.cgi?id=181852
2293
2294         Reviewed by Carlos Alberto Lopez Perez.
2295
2296         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
2297
2298         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2299         (WebDriverW3CExecutor.run):
2300
2301 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         [GTK] WebDriver: wayland display no used in wayland bot
2304         https://bugs.webkit.org/show_bug.cgi?id=181851
2305
2306         Reviewed by Carlos Alberto Lopez Perez.
2307
2308         We need to handle the additionalArguments property in the WebDriverTests step.
2309
2310         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2311         (RunWebDriverTests.start):
2312
2313 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2314
2315         [GTK] TERM environment variable is not passed to the test driver.
2316         https://bugs.webkit.org/show_bug.cgi?id=181847
2317
2318         Rubber-stamped by by Carlos Garcia Campos.
2319
2320         * Scripts/webkitpy/port/base.py:
2321         (Port.to.setup_environ_for_server):
2322
2323 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2324
2325         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
2326         https://bugs.webkit.org/show_bug.cgi?id=181844
2327
2328         Reviewed by Carlos Alberto Lopez Perez.
2329
2330         We always try to create the directory where to store the json file, but when the filename is given directly,
2331         like in the bots, the current dir is used.
2332
2333         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2334         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
2335         empty string.
2336
2337 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         [GTK] WebDriver tests are running outside the jhbuild env
2340         https://bugs.webkit.org/show_bug.cgi?id=181842
2341
2342         Reviewed by Žan Doberšek.
2343
2344         We need to enter jhbuild env in run-webdriver-tests.
2345
2346         * Scripts/run-webdriver-tests:
2347
2348 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         [GTK] Run WebDriver tests in the bots
2351         https://bugs.webkit.org/show_bug.cgi?id=181787
2352
2353         Reviewed by Michael Catanzaro.
2354
2355         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
2356         factory for the GTK port for now.
2357
2358         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2359         (TestFactory.__init__):
2360         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2361         (RunWebDriverTests):
2362         (RunWebDriverTests.start):
2363         (RunWebDriverTests.commandComplete):
2364         (RunWebDriverTests.evaluateCommand):
2365         (RunWebDriverTests.getText):
2366         (RunWebDriverTests.getText2):
2367
2368 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2369
2370         [WinCairo] Pass correct url for http test to test driver.
2371         https://bugs.webkit.org/show_bug.cgi?id=181814
2372
2373         Reviewed by Alex Christensen.
2374
2375         * Scripts/webkitpy/port/driver.py:
2376         (Driver):
2377         (Driver.http_test_path_to_uri):
2378         (Driver.is_secure_path):
2379         (Driver.http_base_url):
2380         (Driver.uri_to_test):
2381
2382 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2383
2384         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
2385
2386         * BuildSlaveSupport/build.webkit.org-config/config.json:
2387
2388 2018-01-18  Dan Bernstein  <mitz@apple.com>
2389
2390         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2391         https://bugs.webkit.org/show_bug.cgi?id=181803
2392
2393         Reviewed by Tim Horton.
2394
2395         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
2396         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
2397         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
2398         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
2399         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2400         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2401         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2402         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2403         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
2404           helpers.
2405         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
2406           settings useful for defining settings that depend on the target macOS version.
2407         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
2408         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
2409
2410 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
2411
2412         Remove Opensource El Capitan queues from buildbot
2413         https://bugs.webkit.org/show_bug.cgi?id=181712
2414
2415         Reviewed by Aakash Jain.
2416
2417         * BuildSlaveSupport/build.webkit.org-config/config.json:
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2419         (WebKitBuildbot):
2420         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2421
2422 2018-01-18  Chris Dumez  <cdumez@apple.com>
2423
2424         Service Workers restored from persistent storage have 'redundant' state
2425         https://bugs.webkit.org/show_bug.cgi?id=181749
2426         <rdar://problem/36556486>
2427
2428         Reviewed by Youenn Fablet.
2429
2430         Add API test coverage.
2431
2432         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2433         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
2434
2435 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2436
2437         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
2438         https://bugs.webkit.org/show_bug.cgi?id=176796
2439
2440         Reviewed by Chris Fleizach.
2441
2442         Add sanity check that we have a URL before calling g_strstr_len().
2443
2444         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2445         (WTR::AccessibilityUIElement::url):
2446
2447 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2448
2449         Add triggers for Sierra test262 and perf queues
2450         https://bugs.webkit.org/show_bug.cgi?id=181799
2451
2452         Reviewed by Aakash Jain.
2453
2454         * BuildSlaveSupport/build.webkit.org-config/config.json:
2455
2456 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2457
2458         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
2459         https://bugs.webkit.org/show_bug.cgi?id=181783
2460         <rdar://problem/35785445>
2461
2462         Reviewed by Ryosuke Niwa.
2463
2464         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
2465         copying an image contains a relevant title.
2466
2467         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2468         (TestWebKitAPI::TEST):
2469         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2470         * TestWebKitAPI/ios/UIKitSPI.h:
2471
2472 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         WebDriver: ignore the driver in selenium test names when getting expectations
2475         https://bugs.webkit.org/show_bug.cgi?id=181738
2476
2477         Reviewed by Carlos Alberto Lopez Perez.
2478
2479         In selenium tests, the driver is added as a parameter to every test which results in tests names like
2480         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
2481         driver name in the test expectations file, so we need to remove it when querying the expectations.
2482
2483         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2484         (TestExpectationsMarker.__init__): Save the param to ignore.
2485         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
2486         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
2487         (run): Pass param to ignore to TestExpectationsMarker().
2488         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2489         (WebDriverSeleniumExecutor.__init__): Save the driver name.
2490         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
2491
2492 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2493
2494         [GTK][WPE] Show unit tests unexpectedly passing in the bots
2495         https://bugs.webkit.org/show_bug.cgi?id=181726
2496
2497         Reviewed by Michael Catanzaro.
2498
2499         Now that we have the info, let's show it also in the bots.
2500
2501         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2502         (RunGLibAPITests.commandComplete):
2503
2504 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
2505
2506         Fix broken unittest after r227048
2507         https://bugs.webkit.org/show_bug.cgi?id=181760
2508
2509         Reviewed by Aakash Jain.
2510
2511
2512 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2513
2514         WEBKIT_FRAMEWORK should not modify file-global include directories
2515         https://bugs.webkit.org/show_bug.cgi?id=181656
2516
2517         Reviewed by Konstantin Tokarev.
2518
2519         * TestWebKitAPI/PlatformWPE.cmake:
2520         * TestWebKitAPI/glib/CMakeLists.txt:
2521
2522 2018-01-17  Alicia Boya García  <aboya@igalia.com>
2523
2524         Unreviewed, mark Alicia as committer in contributors.json
2525
2526         * Scripts/webkitpy/common/config/contributors.json:
2527
2528 2018-01-17  Youenn Fablet  <youenn@apple.com>
2529
2530         Put fetch Request.keepalive behind a runtime flag
2531         https://bugs.webkit.org/show_bug.cgi?id=181592
2532
2533         Reviewed by Chris Dumez.
2534
2535         * DumpRenderTree/mac/DumpRenderTree.mm:
2536         (enableExperimentalFeatures):
2537         * DumpRenderTree/win/DumpRenderTree.cpp:
2538         (enableExperimentalFeatures):
2539         * WebKitTestRunner/TestController.cpp:
2540         (WTR::TestController::resetPreferencesToConsistentValues):
2541
2542 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2543
2544         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2545         https://bugs.webkit.org/show_bug.cgi?id=181637
2546         <rdar://problem/36508471>
2547
2548         Reviewed by Tim Horton.
2549
2550         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
2551         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
2552
2553         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2554         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2555         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
2556
2557         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
2558         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
2559
2560         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2561         (webViewForTestingAttachments):
2562         (-[TestWKWebView tagsInBody]):
2563         (-[TestWKWebView expectElementTagsInOrder:]):
2564         (-[TestWKWebView expectElementTag:toComeBefore:]):
2565
2566         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
2567         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
2568
2569         (TestWebKitAPI::TEST):
2570         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2571         (WTR::InjectedBundlePage::InjectedBundlePage):
2572
2573 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2574
2575         WebDriver: add support for test expectations
2576         https://bugs.webkit.org/show_bug.cgi?id=180420
2577
2578         Reviewed by Carlos Alberto Lopez Perez.
2579
2580         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
2581
2582         * Scripts/run-webdriver-tests: Get the retval from process_results().
2583         * Scripts/webkitpy/thirdparty/__init__.py:
2584         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
2585         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2586         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
2587         (TestExpectationsMarker.__init__): Initialize expectations.
2588         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
2589         (run): Create and use TestExpectationsMarker plugin.
2590         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2591         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
2592         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2593         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
2594         (WebDriverTestRunner.run): Do not count results here.
2595         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
2596         amount of failures. Printing the test summary while processing results will be made optional in a follow up
2597         patch.
2598         (WebDriverTestRunner.process_results.report): Return the amount of failures.
2599         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2600         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
2601         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
2602         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
2603         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2604         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
2605         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
2606         (WebDriverTestRunnerW3C._scan_directory): Ditto.
2607         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
2608         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2609         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
2610
2611 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2612
2613         Unreviewed WPE gardening. Mark some known unit test failures.
2614
2615         * TestWebKitAPI/glib/TestExpectations.json:
2616
2617 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2618
2619         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
2620         https://bugs.webkit.org/show_bug.cgi?id=181724
2621
2622         Reviewed by Philippe Normand.
2623
2624         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
2625         reason to use different names. This way we can refer to the same test names for both and we can share the
2626         expectations in the TestExpectations.json file.
2627
2628         * TestWebKitAPI/glib/TestExpectations.json:
2629         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
2630
2631 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2632
2633         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
2634
2635         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
2636         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
2637
2638         * glib/api_test_runner.py:
2639         (TestRunner._run_test_glib):
2640         (TestRunner._run_google_test):
2641
2642 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2643
2644         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
2645         https://bugs.webkit.org/show_bug.cgi?id=179914
2646
2647         Reviewed by Žan Doberšek.
2648
2649         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
2650         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
2651         all symbols listed in the script are present in the library.
2652
2653         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
2654         (bss_symbols):
2655         * Scripts/check-for-invalid-symbols-in-version-script: Added.
2656         (script_symbols):
2657         * Scripts/make-dist:
2658         (Distcheck.build):
2659         (Distcheck):
2660         (Distcheck.check_symbols):
2661         (Distcheck.check):
2662
2663 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2664
2665         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
2666         https://bugs.webkit.org/show_bug.cgi?id=181722
2667
2668         Reviewed by Žan Doberšek.
2669
2670         I forgot to pass the parameters to run() when restarting.
2671
2672         * glib/glib_test_runner.py:
2673         (GLibTestRunner.run):
2674
2675 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2676
2677         [CMake] Remove WebCoreDerivedSources library target
2678         https://bugs.webkit.org/show_bug.cgi?id=181664
2679
2680         Reviewed by Carlos Garcia Campos.
2681
2682         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
2683         * TestWebKitAPI/PlatformWin.cmake: Ditto.
2684
2685 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
2686
2687         Move Debug Test262, Release Test262 and Performance queues to Sierra
2688         https://bugs.webkit.org/show_bug.cgi?id=181692
2689
2690         Unreviewed
2691
2692 2018-01-16  Zach Li  <zachli@apple.com>
2693
2694         Add pop-up policy support in website policies.
2695         https://bugs.webkit.org/show_bug.cgi?id=181544.
2696         rdar://problem/30521400.
2697
2698         Reviewed by Alex Christensen.
2699
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         Added pop-up-check.html.
2702
2703         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2706         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2707         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2708         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2709         (TEST):
2710
2711 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
2714         https://bugs.webkit.org/show_bug.cgi?id=181638
2715         <rdar://problem/36508702>
2716
2717         Reviewed by Dan Bernstein.
2718
2719         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
2720         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
2721
2722         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2723         (-[AttachmentUpdateObserver init]):
2724         (-[AttachmentUpdateObserver sourceForIdentifier:]):
2725         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
2726         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
2727         (TestWebKitAPI::TEST):
2728         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
2729
2730 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2731
2732         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
2733
2734         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
2735
2736         * glib/api_test_runner.py:
2737         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
2738         * glib/glib_test_runner.py:
2739         (GLibTestRunner.run): Use given env.
2740
2741 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2742
2743         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
2744         https://bugs.webkit.org/show_bug.cgi?id=181676
2745
2746         Reviewed by Carlos Alberto Lopez Perez.
2747
2748         The option was removed in r226967.
2749
2750         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2751         (RunGtkAPITests):
2752         (RunWPEAPITests):
2753
2754 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2755
2756         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
2757
2758         The bots are still passing that option and the step is failing because it was removed in r226967.
2759
2760         * glib/api_test_runner.py:
2761         (add_options):
2762
2763 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2764
2765         [GTK][WPE] Improve the way glib tests are run
2766         https://bugs.webkit.org/show_bug.cgi?id=181674
2767
2768         Reviewed by Žan Doberšek.
2769
2770         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
2771         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
2772         tests failing due to an expected assert in the test and unexpected crashes.
2773         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
2774         not showing the subtest name in stdout in case of timeouts.
2775         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
2776         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
2777         of every test case.
2778
2779         * glib/api_test_runner.py:
2780         (TestRunner._run_test_glib): Use GLibTestRunner.
2781         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
2782         (add_options):
2783         * glib/glib_test_runner.py: Added.
2784         (TestTimeout):
2785         (Message):
2786         (Message.__init__):
2787         (Message.create):
2788         (Message.create.read_unsigned):
2789         (Message.create.read_double):
2790         (Message.create.read_string):
2791         (GLibTestRunner):
2792         (GLibTestRunner.__init__):
2793         (GLibTestRunner._process_data):
2794         (GLibTestRunner._process_message):
2795         (GLibTestRunner._read_from_pipe):
2796         (GLibTestRunner._read_from_stderr):
2797         (GLibTestRunner._start_timeout):
2798         (GLibTestRunner._start_timeout._alarm_handler):
2799         (GLibTestRunner._stop_timeout):
2800         (GLibTestRunner._subtest_start):
2801         (GLibTestRunner._subtest_message):
2802         (GLibTestRunner._subtest_stderr):
2803         (GLibTestRunner._subtest_end):
2804         (GLibTestRunner.run):
2805
2806 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2807
2808         Unreviewed, add Thibault to contributors.json
2809
2810         It's a bit weird to add someone here before their first contribution, but this affects
2811         Bugzilla autocomplete, and that is serious business.
2812
2813         * Scripts/webkitpy/common/config/contributors.json:
2814
2815 2018-01-15  JF Bastien  <jfbastien@apple.com>
2816
2817         Remove makePoisonedUnique
2818         https://bugs.webkit.org/show_bug.cgi?id=181630
2819         <rdar://problem/36498623>
2820
2821         Reviewed by Mark Lam.
2822
2823         Update tests.
2824
2825         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2826         (TestWebKitAPI::TEST):
2827         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2828         (TestWebKitAPI::TEST):
2829
2830 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
2831
2832         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
2833         https://bugs.webkit.org/show_bug.cgi?id=181476
2834
2835         Reviewed by Michael Catanzaro.
2836
2837         Update to xorg-server 1.19.6 which depends on libxfont2, and change
2838         the lists of packages to install libxfont2-devel (or equivalent).
2839
2840         * gtk/install-dependencies:
2841         * gtk/jhbuild.modules:
2842
2843 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2844
2845         [GTK][WPE] Add support for unit test expectations
2846         https://bugs.webkit.org/show_bug.cgi?id=181589
2847
2848         Reviewed by Michael Catanzaro.
2849
2850         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
2851         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
2852         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
2853         script itself is not a good idea either.
2854
2855         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
2856         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
2857         convenient methods to query them.
2858
2859         * Scripts/run-gtk-tests:
2860         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
2861         * Scripts/run-wpe-tests:
2862         (WPETestRunner): Ditto.
2863         * Scripts/webkitpy/common/test_expectations.py: Added.
2864         (TestExpectations):
2865         (TestExpectations.__init__):
2866         (TestExpectations._port_name_for_expected):
2867         (TestExpectations._expected_value):
2868         (TestExpectations.skipped_tests):
2869         (TestExpectations.skipped_subtests):
2870         (TestExpectations._expectation_value):
2871         (TestExpectations.is_slow):
2872         (TestExpectations.get_expectation):
2873         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
2874         (MockTestExpectations):
2875         (MockTestExpectations.__init__):
2876         (MockTestExpectations.is_skip):
2877         (ExpectationsTest):
2878         (assert_exp):
2879         (assert_not_exp):
2880         (assert_bad_exp):
2881         (assert_skip):
2882         (test_basic):
2883         (test_skip):
2884         (test_flaky):
2885         (test_build_type):
2886         * TestWebKitAPI/glib/TestExpectations.json: Added.
2887         * glib/api_test_runner.py:
2888         (TestRunner): Remove SkippedTest implementation.
2889         (TestRunner.__init__): Create a TestExpectations.
2890         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
2891         (TestRunner._should_run_test_program): Ditto.
2892         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
2893         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
2894         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
2895         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
2896         (TestRunner.run_tests.report): Helper to write report to stdout.
2897
2898 2018-01-13  Mark Lam  <mark.lam@apple.com>
2899
2900         Replace all use of ConstExprPoisoned with Poisoned.
2901         https://bugs.webkit.org/show_bug.cgi?id=181542
2902         <rdar://problem/36442138>
2903
2904         Reviewed by JF Bastien.
2905
2906         1. Converted tests to using new uintptr_t& poison type.
2907         2. Added tests for Poisoned comparison operators.
2908
2909         * TestWebKitAPI/CMakeLists.txt:
2910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2911         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2912         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2913         (TestWebKitAPI::TEST):
2914         (TestWebKitAPI::initializeTestPoison): Deleted.
2915         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2916         (TestWebKitAPI::TEST):
2917         (TestWebKitAPI::passWithRef):
2918         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2919         (TestWebKitAPI::TEST):
2920         (TestWebKitAPI::f1):
2921         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2922         (TestWebKitAPI::TEST):
2923         (TestWebKitAPI::poisonedPtrFoo):
2924         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2925         (TestWebKitAPI::TEST):
2926         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2927         (TestWebKitAPI::TEST):
2928
2929 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2930
2931         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2932         <https://webkit.org/b/181606>
2933
2934         Reviewed by Darin Adler.
2935
2936         * Scripts/webkitpy/style/checkers/cpp.py:
2937         (check_spacing): Modify regular expression to ignore
2938         os_log format strings like '%{public}'.
2939         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2940         (CppStyleTest.test_spacing_before_braces): Add os_log
2941         format string test.
2942
2943 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2944
2945         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2946         https://bugs.webkit.org/show_bug.cgi?id=181626
2947
2948         Reviewed by Joseph Pecoraro.
2949
2950         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2951         Additionally, write a new API test covering the change in r226915.
2952
2953         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2954         (webViewForTestingAttachments):
2955         (TestWebKitAPI::TEST):
2956
2957 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2958
2959         History state should be updated during client redirects with asynchronous policy decisions
2960         https://bugs.webkit.org/show_bug.cgi?id=181358
2961         <rdar://problem/35547689>
2962
2963         Reviewed by Andy Estes.
2964
2965         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2966         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2967         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2968         (TEST):
2969
2970 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2971
2972         webkitpy: Refactor simulator code (Part 4)
2973         https://bugs.webkit.org/show_bug.cgi?id=180555
2974         <rdar://problem/36131381>
2975
2976         Reviewed by Aakash Jain.
2977
2978         Move new_simulated_device.py to simulated_device.py.
2979
2980         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2981         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2982         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2983         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2984         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2985
2986 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2987
2988         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2989         https://bugs.webkit.org/show_bug.cgi?id=181595
2990
2991         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2992         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2993         I change the < and > to $ to make this test pass and continue to test what it used to.
2994
2995         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2996         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2997         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2998
2999 2018-01-11  Keith Miller  <keith_miller@apple.com>
3000
3001         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3002         https://bugs.webkit.org/show_bug.cgi?id=181573
3003
3004         Reviewed by Simon Fraser.
3005
3006         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3007
3008 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
3009
3010         [WebAuthN] Import a CBOR coder from Chromium
3011         https://bugs.webkit.org/show_bug.cgi?id=181522
3012         <rdar://problem/36055729>
3013
3014         Reviewed by Brent Fulgham.
3015
3016         This patch also imports all unit tests into our API tests to ensure all
3017         workarounds and modification against the original codebase doesn't change
3018         any original functionalities.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
3022         (TestWebKitAPI::TEST):
3023         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
3024         (TestWebKitAPI::TEST):
3025         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
3026         (TestWebKitAPI::eq):
3027         Workarounds applied.
3028         (TestWebKitAPI::TEST):
3029
3030 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3031
3032         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
3033         https://bugs.webkit.org/show_bug.cgi?id=181538
3034         <rdar://problem/36440580>
3035
3036         Reviewed by Aakash Jain.
3037
3038         When disambiguating a device type, it is possible that the provided device type is sufficiently
3039         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
3040         will result in a failure to disambiguate the type.
3041
3042         * Scripts/webkitpy/xcode/new_simulated_device.py:
3043         (SimulatedDeviceManager._disambiguate_device_type):
3044
3045 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
3046
3047         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
3048         https://bugs.webkit.org/show_bug.cgi?id=181136
3049         <rdar://problem/36116604>
3050
3051         Reviewed by Chris Dumez.
3052
3053         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
3054         browsing sessions.
3055
3056         * Scripts/run-gtk-tests:
3057         (GtkTestRunner): Unskip test now that it passes.
3058         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3059         (TEST): Add new WebsiteDataStoreEphemeral test.
3060
3061 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3062
3063         Unreviewed, rolling out r226816.
3064
3065         This change broke LayoutTests on the bots.
3066
3067         Reverted changeset:
3068
3069         "run-webkit-tests fails when there is a curly brace in Xcode
3070         build output"
3071         https://bugs.webkit.org/show_bug.cgi?id=181254
3072         https://trac.webkit.org/changeset/226816
3073
3074 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3075
3076         webkitpy: Fix flakey webserver tests
3077         https://bugs.webkit.org/show_bug.cgi?id=181555
3078         <rdar://problem/36448273>
3079
3080         Reviewed by Aakash Jain.
3081
3082         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3083         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
3084         determine if a specific server is running.
3085
3086 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3087
3088         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
3089         https://bugs.webkit.org/show_bug.cgi?id=181561
3090         <rdar://problem/36452652>
3091
3092         Reviewed by Aakash Jain.
3093
3094         BeautifulSoup.find may return None, this case should be gracefully handled.
3095
3096         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3097         (BugzillaQueries._parse_result_count):
3098         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
3099
3100 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
3101
3102         run-webkit-tests fails when there is a curly brace in Xcode build output
3103         https://bugs.webkit.org/show_bug.cgi?id=181254
3104
3105         Reviewed by Daniel Bates.
3106
3107         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3108         (MeteredStream.write):
3109
3110 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3111
3112         webkitpy: Reimplement simulator code (Part 3)
3113         https://bugs.webkit.org/show_bug.cgi?id=180555
3114         <rdar://problem/36131381>
3115
3116         Reviewed by Aakash Jain.
3117
3118         Remove old simulator code.
3119
3120         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
3121         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
3122         * Scripts/webkitpy/xcode/simulator.py: Removed.
3123         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
3124
3125 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3126
3127         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
3128         https://bugs.webkit.org/show_bug.cgi?id=181337
3129         <rdar://problem/36324813>
3130
3131         Reviewed by Tim Horton.
3132
3133         Add 3 new API tests for attachment element dragging.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3136         (-[TestWKWebView expectElementTag:toComeBefore:]):
3137         (-[NSItemProvider expectType:withData:]):
3138         (TestWebKitAPI::TEST):
3139
3140 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3141
3142         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
3143         https://bugs.webkit.org/show_bug.cgi?id=179621
3144         <rdar://problem/35589585>
3145
3146         Unreviewed infrastructure fix.
3147
3148         * Scripts/webkitpy/port/mac.py:
3149         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
3150         list if we are the VERSION_MAX, which usually corresponds with future.
3151
3152 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
3153
3154         CodeBlocks should be in IsoSubspaces
3155         https://bugs.webkit.org/show_bug.cgi?id=180884
3156
3157         Reviewed by Saam Barati.
3158         
3159         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
3160         shouldn't take a long time due to benchmarks we don't optimize for.
3161         
3162         * Scripts/run-jsc-benchmarks:
3163
3164 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
3165
3166         Test gardening for GTK.
3167         https://bugs.webkit.org/show_bug.cgi?id=181477
3168
3169         Unreviewed test gardening.
3170
3171         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
3172         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
3173
3174 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3175
3176         Add the new JSCOnly bot to the scheduler.
3177         https://bugs.webkit.org/show_bug.cgi?id=181487
3178
3179         Unreviewed follow-up patch after r226729
3180
3181         On r226729 I missed to add the new JSCOnly bot the default scheduler.
3182         This is needed to make the bot automatically pick each commit for testing.
3183
3184         * BuildSlaveSupport/build.webkit.org-config/config.json:
3185
3186 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3187
3188         [Attachment Support] Support dragging attachment elements out as files on iOS
3189         https://bugs.webkit.org/show_bug.cgi?id=181199
3190         <rdar://problem/36299316>
3191
3192         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
3193
3194         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
3195         attachment API tests.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3198         (-[NSItemProvider expectType:withData:]):
3199         (TestWebKitAPI::TEST):
3200
3201         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
3202         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
3203         -expectType:withData: helper to inspect the item providers created from the drag source.
3204
3205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3206         (TestWebKitAPI::TEST):
3207         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3208         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3209         (-[MockDragSession localContext]):
3210         (-[MockDragSession setLocalContext:]):
3211         (-[DataInteractionSimulator _resetSimulatedState]):
3212         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
3213         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3214         (-[DataInteractionSimulator _advanceProgress]):
3215         (-[DataInteractionSimulator endDataTransfer]):
3216
3217         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
3218         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
3219         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
3220         MockDragSession to hold on to a localContext.
3221
3222 2018-01-11  Ali Juma  <ajuma@chromium.org>
3223
3224         Unreviewed. Add Ali Juma as contributor
3225
3226         * Scripts/webkitpy/common/config/contributors.json:
3227
3228 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3229
3230         Unreviewed. Update Selenium WebDriver imported tests.
3231
3232         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
3233         environment variables.
3234
3235         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3236         (collect): Reorder the arguments to make pytest happy.
3237         (run): Ditto.
3238         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3239         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
3240
3241 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
3242
3243         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
3244         https://bugs.webkit.org/show_bug.cgi?id=181492
3245         <rdar://problem/36359679>
3246
3247         Reviewed by Alexey Proskuryakov. 
3248
3249 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
3250
3251         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
3252         https://bugs.webkit.org/show_bug.cgi?id=181475
3253
3254         Reviewed by Michael Catanzaro.
3255
3256         * gtk/install-dependencies: Update package list for Arch Linux, extend
3257         message shown at end of installation with additional tips.
3258
3259 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3260
3261         REGRESSION(r222507): Composition highlight doesn't render when using IME
3262         https://bugs.webkit.org/show_bug.cgi?id=181485
3263         <rdar://problem/35896516>
3264
3265         Reviewed by Ryosuke Niwa.
3266
3267         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
3268         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
3269         allow rendering composition backgrounds (see InlineTextBox::paint).
3270
3271         * DumpRenderTree/ios/TextInputControllerIOS.m:
3272         (+[TextInputController isSelectorExcludedFromWebScript:]):
3273         (+[TextInputController webScriptNameForSelector:]):
3274         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3275         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3276         * DumpRenderTree/mac/TextInputControllerMac.m:
3277         (+[TextInputController isSelectorExcludedFromWebScript:]):
3278         (+[TextInputController webScriptNameForSelector:]):
3279         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3280         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3281         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3282         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3283         (WTR::TextInputController::setMarkedText):
3284         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3285
3286 2018-01-10  JF Bastien  <jfbastien@apple.com>
3287
3288         Poison small JSObject derivatives which only contain pointers
3289         https://bugs.webkit.org/show_bug.cgi?id=181483
3290         <rdar://problem/36407127>
3291
3292         Reviewed by Mark Lam.
3293
3294         Test the new move-assign and move-copy from unique_ptr, as well as
3295         nullptr_t ctors.
3296
3297         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3298         (TestWebKitAPI::TEST):
3299         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3300         (TestWebKitAPI::TEST):
3301         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3302         (TestWebKitAPI::TEST):
3303
3304 2018-01-10  Chris Dumez  <cdumez@apple.com>
3305
3306         Multiple http/wpt/beacon/contentextensions/ test are flaky.
3307         https://bugs.webkit.org/show_bug.cgi?id=179256
3308         <rdar://problem/35401978>
3309
3310         Reviewed by Alex Christensen.
3311
3312         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
3313         instance gets its own folder to avoid conflicts and flakiness.
3314
3315         * WebKitTestRunner/mac/TestControllerMac.mm:
3316         (WTR::TestController::platformConfigureViewForTest):
3317
3318 2018-01-10  Tim Horton  <timothy_horton@apple.com>
3319
3320         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
3321         https://bugs.webkit.org/show_bug.cgi?id=181269
3322         <rdar://problem/35110344>
3323
3324         Reviewed by Simon Fraser.
3325
3326         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3327         (WTR::UIScriptController::beginBackSwipe):
3328         (WTR::UIScriptController::completeBackSwipe):
3329         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3330         (WTR::UIScriptController::beginBackSwipe):
3331         (WTR::UIScriptController::completeBackSwipe):
3332         (WTR::UIScriptController::overridePreference):
3333         (WTR::UIScriptController::replaceTextAtRange):
3334         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3335         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3336         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3337         (WTR::UIScriptController::beginBackSwipe):
3338         (WTR::UIScriptController::completeBackSwipe):
3339         Implement beginBackSwipe and completeBackSwipe on iOS (they already
3340         exist on Mac) in terms of the new WKWebView testing SPI.
3341
3342 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3343
3344         REGRESSION (r226715): ignore WARNING output in linter tests
3345         https://bugs.webkit.org/show_bug.cgi?id=181486
3346         <rdar://problem/36408847>
3347
3348         Reviewed by Aakash Jain.
3349
3350         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
3351
3352         * Scripts/webkitpy/common/system/outputcapture.py:
3353         (OutputCapture.__init__): Pass logging level to be captured.
3354         * Scripts/webkitpy/style/main_unittest.py:
3355         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
3356         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
3357         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
3358         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
3359         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
3360         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
3361         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
3362         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
3363
3364 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3365
3366         Add a JSCOnly MIPS buildbot
3367         https://bugs.webkit.org/show_bug.cgi?id=181487
3368
3369         Reviewed by Michael Catanzaro.
3370
3371         Add the new bot configs definitions for the master and update the unit tests.
3372
3373         * BuildSlaveSupport/build.webkit.org-config/config.json:
3374         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3375
3376 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3377
3378         REGRESSION (r226715): don't re-check number of simulators in child processes
3379         https://bugs.webkit.org/show_bug.cgi?id=181484
3380         <rdar://problem/36407151>
3381
3382         Reviewed by Aakash Jain.
3383
3384         * Scripts/webkitpy/port/ios_simulator.py:
3385         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
3386         are already initialized.
3387
3388 2018-01-10  Commit Queue  <commit-queue@webkit.org>
3389
3390         Unreviewed, rolling out r226667 and r226673.
3391         https://bugs.webkit.org/show_bug.cgi?id=181488
3392
3393         This caused a flaky crash. (Requested by mlewis13 on #webkit).
3394
3395         Reverted changesets:
3396
3397         "CodeBlocks should be in IsoSubspaces"
3398         https://bugs.webkit.org/show_bug.cgi?id=180884
3399         https://trac.webkit.org/changeset/226667
3400
3401         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
3402         https://bugs.webkit.org/show_bug.cgi?id=180884
3403         https://trac.webkit.org/changeset/226673
3404
3405 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3406
3407         Follow-up fix to r226715
3408         https://bugs.webkit.org/show_bug.cgi?id=180555
3409         <rdar://problem/36131381>
3410
3411         Unreviewed infrastructure fix.
3412
3413         * Scripts/webkitpy/xcode/new_simulated_device.py:
3414         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
3415         of delete.
3416
3417 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3418
3419         webkitpy: Refactor simulator code (Part 2)
3420         https://bugs.webkit.org/show_bug.cgi?id=180555
3421         <rdar://problem/36131381>
3422
3423         Reviewed by Aakash Jain.
3424
3425         The patch leverages the SimulatedDeviceManager when running layout tests.
3426         This patch is primarily code removal, since much of the IOSSimulatorPort
3427         was dedicated to managing simulators. The removed code is either now owned by the
3428         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
3429         boot multiple simulators which was made obsolete in Xcode 9.
3430
3431         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3432         (Manager._custom_device_for_test.in): Device names now have spaces in them,
3433         strip those spaces.
3434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3435         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
3436         * Scripts/webkitpy/port/ios.py:
3437         (IOSPort.__init__): The _current_device idiom is no longer required since the
3438         SimulatedDeviceManager keeps track of any previously booted devices.
3439         (IOSPort.target_host): Even when only a single device is used, it will be accessed
3440         through the array of managed devices.
3441         (IOSPort.using_multiple_devices): Deleted.
3442         * Scripts/webkitpy/port/ios_device.py:
3443         (IOSDevicePort.using_multiple_devices): Deleted.
3444         * Scripts/webkitpy/port/ios_simulator.py:
3445         (IOSSimulatorPort): Remove constants required to manage simulators, change device
3446         class strings so they can be parsed by the DeviceType class.
3447         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
3448         the number of simulators currently booted, the number of child processes specified
3449         and the maximum number of simulators supported by this system.
3450         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
3451         devices owned by the SimulatedDeviceManager.
3452         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
3453         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
3454         the maximum number of supported simulators on this system.
3455         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
3456         request for each child process and send this list to the SimulatedDeviceManager to
3457         initialize the devices.
3458         (IOSSimulatorPort.clean_up_test_run):
3459         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
3460         specified version of iOS.
3461         (IOSSimulatorPort.reset_preferences):
3462         (IOSSimulatorPort.simulator_runtime): Deleted.
3463         (IOSSimulatorPort.simulator_device_type): Deleted.
3464         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
3465         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
3466         (IOSSimulatorPort._create_simulators): Deleted.
3467         (IOSSimulatorPort._quit_ios_simulator): Deleted.
3468         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
3469         (IOSSimulatorPort.using_multiple_devices): Deleted.
3470         (IOSSimulatorPort._create_device): Deleted.
3471         (IOSSimulatorPort.get_simulator_path): Deleted.
3472         (IOSSimulatorPort._createSimulatorApps): Deleted.
3473         (IOSSimulatorPort._createSimulatorApp): Deleted.
3474         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3475         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
3476         maximum number of simulators run on this system.
3477         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
3478         * Scripts/webkitpy/xcode/new_simulated_device.py:
3479         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
3480
3481 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3482
3483         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
3484         https://bugs.webkit.org/show_bug.cgi?id=181474
3485
3486         Reviewed by Carlos Alberto Lopez Perez.
3487
3488         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
3489         name as the name.
3490
3491         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3492         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
3493         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
3494
3495 2018-01-09  Andy Estes  <aestes@apple.com>
3496
3497         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
3498         https://bugs.webkit.org/show_bug.cgi?id=181459
3499
3500         Reviewed by Dan Bernstein.
3501
3502         * ImageDiff/cg/Configurations/Base.xcconfig:
3503
3504 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
3505
3506         font-display:fallback can cause a visual flash (which is supposed to be impossible)
3507         https://bugs.webkit.org/show_bug.cgi?id=181374
3508
3509         Reviewed by Simon Fraser.
3510
3511         The test requires Palatino.
3512
3513         * DumpRenderTree/mac/DumpRenderTree.mm:
3514         (allowedFontFamilySet):
3515         * WebKitTestRunner/mac/TestControllerMac.mm:
3516         (WTR::allowedFontFamilySet):
3517
3518 2018-01-09  Saam Barati  <sbarati@apple.com>
3519
3520         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
3521         https://bugs.webkit.org/show_bug.cgi?id=181449
3522
3523         Reviewed by JF Bastien.
3524
3525         This allows me to Cmd+f in my terminal to search for things without
3526         having the results become misaligned.
3527
3528         * Scripts/display-profiler-output:
3529
3530 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3531
3532         [webkitpy] PlatformInfo should have default argument for casual use
3533         https://bugs.webkit.org/show_bug.cgi?id=180827
3534
3535         Reviewed by David Kilzer.
3536
3537         PlatformInfo should be the only way to check platform specific thing instead
3538         of sys.platform or other various checks. If there is something you want to check,
3539         it should be placed in PlatformInfo.
3540
3541         Currently to instantiate PlatformInfo, it requires arguments, which is usually
3542         sys, platform and Executive(). They are straight forward and should be handled
3543         by default arguments. Then we can instantiate PlatformInfo more casual.
3544
3545         * Scripts/webkitpy/common/system/platforminfo.py:
3546         (PlatformInfo): Use relative module path import
3547         (PlatformInfo.__init__):
3548         (PlatformInfo.executive): Lazy instantiation of Executive()
3549         (PlatformInfo.total_bytes_memory): Accessing via above property
3550         (PlatformInfo.xcode_sdk_version): Ditto
3551         (PlatformInfo.xcode_simctl_list): Ditto
3552         (PlatformInfo.xcode_version): Ditto
3553         (PlatformInfo._win_version_str): Ditto
3554         * Scripts/webkitpy/common/system/systemhost.py:
3555         (SystemHost.__init__):
3556         * Scripts/webkitpy/common/system/user.py:
3557         (User.__init__):
3558
3559 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3560
3561         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
3562         https://bugs.webkit.org/show_bug.cgi?id=176443
3563
3564         Reviewed by Darin Adler.
3565
3566         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
3567         (TEST):
3568
3569 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
3570
3571         check-webkit-style: Verify syntax for WK_API_AVAILABLE
3572         https://bugs.webkit.org/show_bug.cgi?id=181394
3573
3574         Reviewed by Darin Adler.
3575
3576         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
3577         as the second parameter instead of ios(WK_IOS_TBA). This generally
3578         builds for iOS on EWS but not when using the public SDK. See r224057,
3579         r223207 and r226211 for example. This patch adds a basic style check
3580         for that macro to prevent this kind of mistake.
3581
3582         * Scripts/webkitpy/style/checkers/cpp.py:
3583         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
3584         (check_style): Run new style check.
3585         (CppChecker): Add build type for the new style check.
3586         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3587         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
3588
3589 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3590
3591         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
3592         https://bugs.webkit.org/show_bug.cgi?id=181420
3593         <rdar://problem/36365827>
3594
3595         Reviewed by Alex Christensen.
3596
3597         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
3598         of corresponding _WKAttachments.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3601         (TestWebKitAPI::TEST):
3602
3603 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3604
3605         Add WKNavigationDelegate SPI exposing WebProcess crash reason
3606         https://bugs.webkit.org/show_bug.cgi?id=181410
3607         <rdar://problem/36167199>
3608
3609         Reviewed by Wenson Hsieh.
3610
3611         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3612         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
3613         (TEST):
3614
3615 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3616
3617         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
3618         https://bugs.webkit.org/show_bug.cgi?id=181408
3619         <rdar://problem/35884960>
3620
3621         Reviewed by Tim Horton.
3622
3623         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
3624         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3625
3626 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3627
3628         [Attachment Support] Expose file name and content type of WKAttachment
3629         https://bugs.webkit.org/show_bug.cgi?id=181390
3630         <rdar://problem/36336837>
3631
3632         Reviewed by Tim Horton.
3633
3634         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
3635
3636         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3637         (-[_WKAttachment synchronouslyRequestInfo:]):
3638         (-[_WKAttachment synchronouslyRequestData:]):
3639
3640         Reimplement this in terms of -synchronouslyRequestInfo:.
3641
3642         (-[_WKAttachment expectRequestedDataToBe:]):
3643         (TestWebKitAPI::TEST):
3644
3645 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3646
3647         Copying, pasting, and then deleting an attachment element breaks attachment data requests
3648         https://bugs.webkit.org/show_bug.cgi?id=181365
3649         <rdar://problem/36340647>
3650
3651         Reviewed by Tim Horton.
3652
3653         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
3654         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
3655         detail.
3656
3657         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3658         (TestWebKitAPI::TEST):
3659
3660 2018-01-08  Youenn Fablet  <youenn@apple.com>
3661
3662         navigator.onLine does not work inside service workers
3663         https://bugs.webkit.org/show_bug.cgi?id=181079
3664         <rdar://problem/36178606>
3665
3666         Reviewed by Darin Adler.
3667
3668         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3669         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
3670
3671 2018-01-07  Saam Barati  <sbarati@apple.com>
3672
3673         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
3674         https://bugs.webkit.org/show_bug.cgi?id=181372
3675
3676         Reviewed by Filip Pizlo.
3677
3678         Adding these sorting modes makes it easier to analyze functions
3679         that recompile a lot and exit a lot.
3680
3681         * Scripts/display-profiler-output:
3682
3683 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
3684
3685         Unreviewed, remove my Cisco email from contributors.json
3686
3687         * Scripts/webkitpy/common/config/contributors.json:
3688
3689 2018-01-05  JF Bastien  <jfbastien@apple.com>
3690
3691         WebAssembly: poison JS object's secrets
3692         https://bugs.webkit.org/show_bug.cgi?id=181339
3693         <rdar://problem/36325001>
3694
3695         Reviewed by Mark Lam.
3696
3697         Update tests for swap(Poisoned<k, T>, T*)
3698
3699         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
3700         (TestWebKitAPI::TEST):
3701         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3702         (TestWebKitAPI::TEST):
3703         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
3704         (TestWebKitAPI::TEST):
3705
3706 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3707
3708         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
3709         https://bugs.webkit.org/show_bug.cgi?id=181359
3710
3711         Reviewed by Tim Horton.
3712
3713         Ensure that these tests still pass using older SDKs.
3714
3715         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3716         (TestWebKitAPI::TEST):
3717
3718 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3719
3720         Rebase API test after r226469
3721         https://bugs.webkit.org/show_bug.cgi?id=181308
3722
3723         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
3724         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3725         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
3726
3727 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3728
3729         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
3730         https://bugs.webkit.org/show_bug.cgi?id=181217
3731
3732         Reviewed by Tim Horton.
3733
3734         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3735         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3736         (TEST):
3737
3738 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3739
3740         Add WKBundleFrameCreateFrameHandle
3741         https://bugs.webkit.org/show_bug.cgi?id=181232
3742         <rdar://problem/35926696>
3743
3744         Reviewed by Tim Horton.
3745
3746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3747         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
3748         (mouseDidMoveOverElement):
3749         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
3750         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3751         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
3752         (TEST):
3753
3754 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
3755
3756         iOS: Build fix after r226432.
3757         
3758         Unreviewed. Stop duplicating speakAs symbols for iOS.
3759
3760         * DumpRenderTree/AccessibilityUIElement.cpp:
3761         (AccessibilityUIElement::speakAs):
3762
3763 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
3764
3765         Unreviewed, added myself as WebKit reviewer
3766
3767         * Scripts/webkitpy/common/config/contributors.json:
3768
3769 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
3770
3771         WPE: Build fix after r226432.
3772
3773         Unreviewed. Rename ::speak() to ::speakAs().
3774         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3775         (WTR::AccessibilityUIElement::speakAs):
3776         (WTR::AccessibilityUIElement::speak): Deleted.
3777
3778 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
3779
3780         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
3781         https://bugs.webkit.org/show_bug.cgi?id=180361
3782
3783         Reviewed by Zalan Bujtas.
3784
3785         * DumpRenderTree/AccessibilityUIElement.cpp:
3786         (speakAsCallback):
3787         (AccessibilityUIElement::speakAs):
3788         (AccessibilityUIElement::getJSClass):
3789         (speakCallback): Deleted.
3790         (AccessibilityUIElement::speak): Deleted.
3791         * DumpRenderTree/AccessibilityUIElement.h:
3792         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3793         (AccessibilityUIElement::speakAs):
3794         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3795         (AccessibilityUIElement::speakAs):
3796         (AccessibilityUIElement::speak): Deleted.
3797         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3798         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3799         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3800         (WTR::AccessibilityUIElement::speakAs):
3801         (WTR::AccessibilityUIElement::speak): Deleted.
3802         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3803         (WTR::AccessibilityUIElement::speakAs):
3804         (WTR::AccessibilityUIElement::speak): Deleted.
3805
3806 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
3807
3808         REGRESSION (r226395): test-webkitperl test expectations incorrect
3809         https://bugs.webkit.org/show_bug.cgi?id=181307
3810         <rdar://problem/36306558>
3811
3812         Rubber-stamped by Aakash Jain.
3813
3814         r226395 added two lines towards the beginning of
3815         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
3816         numbers in the test expectations need to update.
3817
3818         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3819
3820 2018-01-04  Tim Horton  <timothy_horton@apple.com>
3821
3822         WKWebView loses minimum layout size overrides that happen while the process is terminated
3823         https://bugs.webkit.org/show_bug.cgi?id=181306
3824         <rdar://problem/34398288>
3825
3826         Reviewed by Dan Bernstein.
3827
3828         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3829         (TEST):
3830         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
3831         while the process is terminated results in the page getting the correct
3832         minimum layout size.
3833
3834 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
3835
3836         [MediaStream] Add Mock screen capture source
3837         https://bugs.webkit.org/show_bug.cgi?id=181291
3838         <rdar://problem/36298164>
3839
3840         Reviewed by Dean Jackson.
3841
3842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
3843         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3844         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
3845
3846 2018-01-04  Lucas Forschler  <lforschler@apple.com>
3847
3848         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
3849
3850         Reviewed by Ling Ho.
3851
3852         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3853
3854 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3855
3856         [Attachment Support] Create attachment elements when dropping files on iOS
3857         https://bugs.webkit.org/show_bug.cgi?id=181192
3858         <rdar://problem/36280945>
3859
3860         Reviewed by Tim Horton.
3861
3862         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
3863         switch is enabled. See below for more details.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3866         (-[NSItemProvider registerData:type:]):
3867         (platformCopyPNG):
3868         (TestWebKitAPI::TEST):
3869         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3870
3871         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
3872         source item provider when dragging rich text *without* attachments, so this should have been a check for just
3873         kUTTypeRTF instead.
3874
3875         (TestWebKitAPI::TEST):
3876
3877         Tests a few cases of inserting attachment elements via drop:
3878         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
3879             Instead of inserting the contents as inline web content, this should generate attachment elements.
3880         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
3881             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
3882             back to inserting the content as an attachment.
3883         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
3884             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
3885             or at the end).
3886
3887         * TestWebKitAPI/cocoa/TestWKWebView.h:
3888         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3889         (-[TestWKWebView objectByEvaluatingJavaScript:]):
3890
3891         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
3892         -stringByEvaluatingJavaScript to just turn around and call this.
3893
3894         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3895
3896 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
3897
3898         Replace hard-coded paths in shebangs with #!/usr/bin/env
3899         https://bugs.webkit.org/show_bug.cgi?id=181040
3900
3901         Reviewed by Alex Christensen.
3902
3903         * BuildSlaveSupport/build-launcher-app:
3904         * BuildSlaveSupport/build-launcher-dmg:
3905         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3906         * BuildSlaveSupport/built-product-archive:
3907         * BuildSlaveSupport/clean-build:
3908         * BuildSlaveSupport/delete-stale-build-files:
3909         * BuildSlaveSupport/download-built-product:
3910         * BuildSlaveSupport/gtk/buildbot/log/run:
3911         * BuildSlaveSupport/gtk/buildbot/run:
3912         * BuildSlaveSupport/gtk/pulseaudio/run:
3913         * BuildSlaveSupport/kill-old-processes:
3914         * BuildSlaveSupport/test-result-archive:
3915         * BuildSlaveSupport/win/kill-old-processes:
3916         * Scripts/SpacingHeuristics.pm:
3917         * Scripts/add-include:
3918         * Scripts/build-api-tests:
3919         * Scripts/build-dumprendertree:
3920         * Scripts/build-imagediff:
3921         * Scripts/build-jsc:
3922         * Scripts/build-webkit:
3923         * Scripts/build-webkittestrunner:
3924         * Scripts/check-Xcode-source-file-types:
3925         * Scripts/check-dom-results:
3926         * Scripts/check-for-exit-time-destructors:
3927         * Scripts/check-for-global-initializers:
3928         * Scripts/check-for-inappropriate-objc-class-names:
3929         * Scripts/check-for-weak-vtables-and-externals:
3930         * Scripts/clean-header-guards:
3931         * Scripts/compare-timing-files:
3932         * Scripts/configure-xcode-for-ios-development:
3933         * Scripts/copy-webkitlibraries-to-product-directory:
3934         * Scripts/create-exports:
3935         * Scripts/debug-minibrowser:
3936         * Scripts/debug-safari:
3937         * Scripts/debug-test-runner:
3938         * Scripts/do-file-rename:
3939         * Scripts/do-webcore-rename:
3940         * Scripts/dump-webkit-tests-run:
3941         * Scripts/ensure-valid-python:
3942         * Scripts/execAppWithEnv:
3943         * Scripts/extract-localizable-js-strings:
3944         * Scripts/filter-build-webkit:
3945         * Scripts/find-extra-includes:
3946         * Scripts/fix-blink-patch:
3947         * Scripts/generate-coverage-data:
3948         * Scripts/git-add-reviewer:
3949         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3950         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3951         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3952         * Scripts/make-new-script-test:
3953         * Scripts/make-script-test-wrappers:
3954         * Scripts/package-root:
3955         * Scripts/parse-malloc-history:
3956         * Scripts/report-include-statistics:
3957         * Scripts/resolve-ChangeLogs:
3958         * Scripts/run-api-tests:
3959         * Scripts/run-bindings-tests:
3960         * Scripts/run-content-extension-tester:
3961         * Scripts/run-iexploder-tests:
3962         * Scripts/run-javascriptcore-tests:
3963         * Scripts/run-jsc:
3964         * Scripts/run-leaks:
3965         * Scripts/run-mangleme-tests:
3966         * Scripts/run-minibrowser:
3967         * Scripts/run-pageloadtest:
3968         * Scripts/run-regexp-tests:
3969         * Scripts/run-safari:
3970         * Scripts/run-sunspider:
3971         * Scripts/run-test-runner:
3972         * Scripts/run-webkit-app:
3973         * Scripts/run-webkit-httpd:
3974         * Scripts/run-webkit-websocketserver:
3975         * Scripts/set-webkit-configuration:
3976         * Scripts/show-pretty-diff:
3977         * Scripts/sort-Xcode-project-file:
3978         * Scripts/split-file-by-class:
3979         * Scripts/sunspider-compare-results:
3980         * Scripts/svn-apply:
3981         * Scripts/svn-unapply:
3982         * Scripts/test-webkit-scripts:
3983         * Scripts/test-webkitperl:
3984         * Scripts/update-iexploder-cssproperties:
3985         * Scripts/update-javascriptcore-test-results:
3986         * Scripts/update-webkit:
3987         * Scripts/update-webkit-auxiliary-libs:
3988         * Scripts/update-webkit-dependency:
3989         * Scripts/update-webkit-libs-jhbuild:
3990         * Scripts/update-webkit-localizable-strings:
3991         * Scripts/update-webkit-support-libs:
3992         * Scripts/update-webkitgtk-libs:
3993         * Scripts/update-webkitwpe-libs:
3994         * Scripts/webkit-build-directory:
3995         * Scripts/webkitperl/LoadAsModule.pm:
3996         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3997         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3998         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3999         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
4000         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
4001         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
4002         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
4003         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
4004         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
4005         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
4006         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
4007         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
4008         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
4009         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
4010         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
4011         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
4012         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
4013         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
4014         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
4015         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
4016         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
4017         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
4018         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
4019         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
4020         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
4021         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
4022         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
4023         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
4024         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
4025         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
4026         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
4027         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
4028         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
4029         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
4030         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
4031         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
4032         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
4033         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
4034         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
4035         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
4036         * ccache/ccache-clang:
4037         * ccache/ccache-clang++:
4038         * ccache/ccache-wrapper:
4039         * gtk/install-dependencies:
4040         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
4041         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
4042         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
4043         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
4044         * iExploder/iexploder-1.3.2/tools/showtest.rb:
4045         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
4046         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
4047         * iExploder/iexploder-1.7.2/src/webserver.rb:
4048         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
4049         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
4050         * wpe/install-dependencies:
4051
4052 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
4053
4054         filter-build-webkit filters out useful compiler error lines
4055         https://bugs.webkit.org/show_bug.cgi?id=179864
4056
4057         Reviewed by Tim Horton.
4058
4059         Don't filter out lines that contain information about build errors by always showing lines
4060         after a line that contains "note:" or "error:".
4061
4062         * Scripts/filter-build-webkit:
4063         (shouldShowSubsequentLine):
4064         (shouldIgnoreLine):
4065
4066 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4067
4068         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
4069         https://bugs.webkit.org/show_bug.cgi?id=173915
4070
4071         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
4072         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
4073         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
4074         empty string in this case.
4075
4076         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4077         (emitFormSubmissionEvent):
4078
4079 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4080
4081         [GTK] Add web process API to detect when form is submitted via JavaScript
4082         https://bugs.webkit.org/show_bug.cgi?id=173915
4083
4084         Reviewed by Carlos Garcia Campos.
4085
4086         Test it.
4087
4088         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4089         (FormSubmissionTest::FormSubmissionTest):
4090         (FormSubmissionTest::~FormSubmissionTest):
4091         (FormSubmissionTest::testFormSubmissionResult):
4092         (FormSubmissionTest::willSendDOMEventCallback):
4093         (FormSubmissionTest::willCompleteCallback):
4094         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
4095         (testWebExtensionFormSubmissionSteps):
4096         (beforeAll):
4097         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4098         (DelayedSignal::DelayedSignal):
4099         (emitFormSubmissionEvent):
4100         (handleFormSubmissionCallback):
4101         (willSubmitFormCallback):
4102         (pageCreatedCallback):
4103
4104 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4105
4106         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
4107         https://bugs.webkit.org/show_bug.cgi?id=181251
4108
4109         * Scripts/run-gtk-tests:
4110         (GtkTestRunner):
4111
4112 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4113
4114         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
4115         https://bugs.webkit.org/show_bug.cgi?id=181136
4116
4117         * Scripts/run-gtk-tests:
4118         (GtkTestRunner):
4119
4120 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
4121
4122         [macOS, iOS] Adopt new secure coding APIs in WebKit
4123         https://bugs.webkit.org/show_bug.cgi?id=181085
4124         <rdar://problem/34837397>
4125
4126         Reviewed by Tim Horton.
4127
4128         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
4129         capable of supporting NSSecureCoding, so pass through the current coding routines.
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
4132         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
4133         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
4134         routines if necessary.
4135         (TEST): Updated for NSSecureCoding.
4136         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
4137         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
4138
4139 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
4140
4141         Remove std::chrono completely
4142         https://bugs.webkit.org/show_bug.cgi?id=181186
4143
4144         Reviewed by Alex Christensen.
4145
4146         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4147         (WTR::TestController::platformRunUntil):
4148
4149 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
4150
4151         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
4152         https://bugs.webkit.org/show_bug.cgi?id=181231
4153
4154         Reviewed by Alex Christensen.
4155
4156         Implement TestController APIs needed by ResourceLoadStatistics tests.
4157
4158         * WebKitTestRunner/TestController.cpp:
4159         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
4160         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
4161
4162 2018-01-02  Tim Horton  <timothy_horton@apple.com>
4163
4164         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
4165         https://bugs.webkit.org/show_bug.cgi?id=181219
4166
4167         Reviewed by Wenson Hsieh.
4168
4169         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4170
4171 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
4172
4173         Add a WebAuthentication runtime feature flag
4174         https://bugs.webkit.org/show_bug.cgi?id=181220
4175         <rdar://problem/36055305>
4176
4177         Reviewed by Brent Fulgham.
4178
4179         Renames the CredentialManagement runtime feature flag into WebAuthentication.
4180
4181         * DumpRenderTree/TestOptions.h:
4182         * DumpRenderTree/TestOptions.mm:
4183         (TestOptions::TestOptions):
4184         * DumpRenderTree/mac/DumpRenderTree.mm:
4185         (enableExperimentalFeatures):
4186         (setWebPreferencesForTestOptions):
4187         * WebKitTestRunner/TestController.cpp:
4188         (WTR::TestController::resetPreferencesToConsistentValues):
4189         (WTR::updateTestOptionsFromTestHeader):
4190         * WebKitTestRunner/TestOptions.h:
4191         (WTR::TestOptions::hasSameInitializationOptions const):
4192
4193 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4194
4195         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
4196         https://bugs.webkit.org/show_bug.cgi?id=181143
4197         <rdar://problem/36200381>
4198
4199         Reviewed by Tim Horton.
4200
4201         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
4202         attachment elements are enabled.
4203
4204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4205         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4206         (TestWebKitAPI::TEST):
4207
4208 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
4209
4210         Update Credential Management API for WebAuthentication
4211         https://bugs.webkit.org/show_bug.cgi?id=181082
4212         <rdar://problem/36055239>
4213
4214         Reviewed by Brent Fulgham.
4215
4216         Enable Credential Management API for testing.
4217
4218         * DumpRenderTree/TestOptions.h:
4219         * WebKitTestRunner/TestOptions.h:
4220
4221 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
4222
4223         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
4224         https://bugs.webkit.org/show_bug.cgi?id=168194
4225
4226         Reviewed by Carlos Garcia Campos.
4227
4228         Fix an assertion and unskip the test. The order that form controls are associated is not
4229         guaranteed.
4230
4231         * Scripts/run-gtk-tests:
4232         (GtkTestRunner):
4233         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4234         (didAssociateFormControlsCallback):
4235
4236 2018-01-02  Alex Christensen  <achristensen@webkit.org>
4237
4238         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
4239         https://bugs.webkit.org/show_bug.cgi?id=180897
4240         <rdar://problem/35535328>
4241
4242         Reviewed by Brent Fulgham.
4243
4244         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
4245
4246         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4247         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4248         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
4249         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4250         (websiteDataStoreTestWebView):
4251         (TEST):
4252
4253 == Rolled over to ChangeLog-2018-01-01 ==