[ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
4         https://bugs.webkit.org/show_bug.cgi?id=196780
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         * BuildSlaveSupport/ews-build/steps_unittest.py:
10
11 2019-04-10  Alex Christensen  <achristensen@webkit.org>
12
13         Add SPI WKNavigationResponse._downloadAttribute
14         https://bugs.webkit.org/show_bug.cgi?id=196755
15         <rdar://49587365>
16
17         Reviewed by Brady Eidson.
18
19         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
20         (-[NavigationResponseTestDelegate navigationResponse]):
21         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
22         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
23         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
24         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
25         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
26         (readRequest):
27         (writeResponse):
28         (TEST):
29
30 2019-04-10  Tim Horton  <timothy_horton@apple.com>
31
32         Add modern API for overriding the page's specified viewport configuration
33         https://bugs.webkit.org/show_bug.cgi?id=167734
34         <rdar://problem/30331795>
35
36         Reviewed by Simon Fraser.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
40
41 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
42
43         Add support for incremental bytecode cache updates
44         https://bugs.webkit.org/show_bug.cgi?id=195000
45
46         Reviewed by Filip Pizlo.
47
48         Exit when the initial run to generate bytecode fails.
49
50         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
51
52 2019-04-10  Alex Christensen  <achristensen@webkit.org>
53
54         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
55         https://bugs.webkit.org/show_bug.cgi?id=196744
56         <rdar://49415309>
57
58         Reviewed by Chris Dumez.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
61         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
62
63 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
64
65         Add a way to opt into modern compatibility mode in layout tests
66         https://bugs.webkit.org/show_bug.cgi?id=196770
67         <rdar://problem/49777550>
68
69         Reviewed by Antoine Quint.
70
71         Add a new test option to enable modern compatibility mode in layout tests.
72
73         * WebKitTestRunner/TestController.cpp:
74         (WTR::updateTestOptionsFromTestHeader):
75         * WebKitTestRunner/TestController.h:
76         * WebKitTestRunner/TestOptions.h:
77         (WTR::TestOptions::hasSameInitializationOptions const):
78         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
79         (WTR::TestController::platformCreateWebView):
80         (WTR::TestController::enableModernCompatibilityMode):
81
82 2019-04-10  Andy Estes  <aestes@apple.com>
83
84         Try to fix the 32-bit watchOS build.
85
86         * TestWebKitAPI/cocoa/TestWKWebView.mm:
87         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
88
89 2019-04-10  Antoine Quint  <graouts@apple.com>
90
91         Enable Pointer Events on watchOS
92         https://bugs.webkit.org/show_bug.cgi?id=196771
93         <rdar://problem/49040909>
94
95         Reviewed by Dean Jackson.
96
97         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
98
99 2019-04-10  Philippe Normand  <pnormand@igalia.com>
100
101         Unreviewed. Fix WPE accessibility tests after r244059.
102
103         We are failing to load the injected bundle due to undefined symbol
104         AccessibilityUIElement::replaceTextInRange().
105
106         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
107         (WTR::AccessibilityUIElement::replaceTextInRange):
108
109 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
110
111         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
112         https://bugs.webkit.org/show_bug.cgi?id=196727
113
114         Reviewed by Fujii Hironori.
115
116         * MiniBrowser/win/WebKitBrowserWindow.cpp:
117         (WebKitBrowserWindow::create):
118
119 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
120
121         [ews-build] Add unit tests for PrintConfiguration
122         https://bugs.webkit.org/show_bug.cgi?id=196752
123
124         Reviewed by Dewei Zhu.
125
126         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
127
128 2019-04-09  Keith Rollin  <krollin@apple.com>
129
130         Unreviewed build maintenance -- update .xcfilelists.
131
132         * DumpRenderTree/DerivedSources-input.xcfilelist:
133         * DumpRenderTree/DerivedSources-output.xcfilelist:
134
135 2019-04-09  Zalan Bujtas  <zalan@apple.com>
136
137         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
138         https://bugs.webkit.org/show_bug.cgi?id=196743
139         <rdar://problem/43897551>
140
141         Reviewed by Tim Horton.
142
143         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
144         (TEST):
145
146 2019-04-09  Youenn Fablet  <youenn@apple.com>
147
148         Close service worker database on network process suspension
149         https://bugs.webkit.org/show_bug.cgi?id=196623
150         <rdar://problem/48930869>
151
152         Reviewed by Alex Christensen.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
155
156 2019-04-09  Daniel Bates  <dabates@apple.com>
157
158         [iPad] Should open popover when the spacebar is pressed
159         https://bugs.webkit.org/show_bug.cgi?id=196360
160         <rdar://problem/49389129>
161
162         Reviewed by Brent Fulgham.
163
164         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
165
166         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
167         (WTR::UIScriptController::isShowingPopover const): Added.
168         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
169         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
171         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
172         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
173         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
174         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
175         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
176         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
177         (WTR::UIScriptController::isShowingPopover const): Added.
178         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
179         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
180         * TestRunnerShared/UIScriptContext/UIScriptController.h:
181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
182         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
183         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
184         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
185         (-[TestRunnerWKWebView _willPresentPopover]): Added.
186         (-[TestRunnerWKWebView _didDismissPopover]): Added.
187         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
188         (WTR::UIScriptController::isShowingPopover const): Added.
189         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
190         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
191
192 2019-04-09  Alex Christensen  <achristensen@webkit.org>
193
194         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
195         https://bugs.webkit.org/show_bug.cgi?id=196665
196         <rdar://45115669>
197
198         Reviewed by Geoff Garen.
199
200         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
201         (goBack):
202         (+[SimpleLookupContext sharedLookupContext]):
203         (-[SimpleLookupContext lookUpURL:completionHandler:]):
204         (TEST):
205         (+[Simple3LookupContext sharedLookupContext]): Deleted.
206         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
207
208 2019-04-09  John Wilander  <wilander@apple.com>
209
210         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
211         https://bugs.webkit.org/show_bug.cgi?id=196558
212         <rdar://problem/47650245>
213
214         Reviewed by Youenn Fablet.
215
216         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
217         (TestWebKitAPI::TEST):
218             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
219
220 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
221
222         [CMake] Apple builds should use ICU_INCLUDE_DIRS
223         https://bugs.webkit.org/show_bug.cgi?id=196720
224
225         Reviewed by Konstantin Tokarev.
226
227         * TestWebKitAPI/PlatformMac.cmake:
228
229 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
230
231         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
232         https://bugs.webkit.org/show_bug.cgi?id=196694
233         <rdar://problem/48388734>
234
235         Rubber-stamped by Aakash Jain.
236
237         * Scripts/webkitpy/port/image_diff.py:
238         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
239         * Scripts/webkitpy/port/server_process.py:
240         (ServerProcess.has_available_stdout): Check if stdout has data in it.
241         (ServerProcess._wait_for_data_and_update_buffers_using_select):
242         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
243         * Scripts/webkitpy/port/server_process_mock.py:
244         (MockServerProcess.has_available_stdout):
245         * Scripts/webkitpy/port/server_process_unittest.py:
246         (TestServerProcess.serial_test_basic):
247
248 2019-04-09  Jer Noble  <jer.noble@apple.com>
249
250         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
251         https://bugs.webkit.org/show_bug.cgi?id=196097
252
253         Reviewed by Eric Carlson.
254
255         Drive-by bug fix: allow tests to play audio without a user gesture by default.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (resetWebPreferencesToConsistentValues):
259         * WebKitTestRunner/TestController.cpp:
260         (WTR::TestController::resetPreferencesToConsistentValues):
261
262 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
263
264         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
265         https://bugs.webkit.org/show_bug.cgi?id=196690
266
267         Reviewed by Michael Catanzaro.
268
269         * QueueStatusServer/config/queues.py:
270         * Scripts/webkitpy/common/config/ews.json:
271         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
272         (test_ews_name):
273
274 2019-04-09  Chris Dumez  <cdumez@apple.com>
275
276         Loads using loadHTMLString() cause flashing when process-swapping
277         https://bugs.webkit.org/show_bug.cgi?id=196714
278         <rdar://problem/49637354>
279
280         Reviewed by Antti Koivisto.
281
282         Add API test coverage.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
285
286 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
287
288         Unreviewed. Fix ATK accessibility tests after r244059.
289
290         We are failing to load the injected bundle due to undefined symbol
291         AccessibilityUIElement::replaceTextInRange().
292
293         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
294         (WTR::AccessibilityUIElement::replaceTextInRange):
295
296 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
297
298         AX: Support API: accessibilityReplaceRange:withText
299         https://bugs.webkit.org/show_bug.cgi?id=196636
300
301         Unreviewed build fix for Windows port.
302
303         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
304         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
305
306 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
307
308         [CMake][WinCairo] Separate copied headers into different directories
309         https://bugs.webkit.org/show_bug.cgi?id=196655
310
311         Reviewed by Michael Catanzaro.
312
313         * DumpRenderTree/CMakeLists.txt:
314         * MiniBrowser/win/CMakeLists.txt:
315         * TestWebKitAPI/CMakeLists.txt:
316         * TestWebKitAPI/PlatformWin.cmake:
317
318 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
319
320         Log stack-trace for run-webkit-tests when interrupted
321         https://bugs.webkit.org/show_bug.cgi?id=176393
322         <rdar://problem/34262310>
323
324         Reviewed by Lucas Forschler.
325
326         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
327         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
328         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
329         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
330         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
331         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
332         (main): Set handlers to log stack trace on interruption.
333
334 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
335
336         AX: Support API: accessibilityReplaceRange:withText
337         https://bugs.webkit.org/show_bug.cgi?id=196636
338
339         Unreviewed build fix for Windows port.
340
341         * DumpRenderTree/AccessibilityUIElement.cpp:
342         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
343
344 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews-build] Scripts using Buildbot API have CORS error
347         https://bugs.webkit.org/show_bug.cgi?id=196709
348
349         Reviewed by Alexey Proskuryakov.
350
351         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
352
353 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
354
355         AX: Support API: accessibilityReplaceRange:withText
356         https://bugs.webkit.org/show_bug.cgi?id=196636
357
358         Reviewed by Daniel Bates.
359
360         * DumpRenderTree/AccessibilityUIElement.cpp:
361         (replaceTextInRangeCallback):
362         (AccessibilityUIElement::replaceTextInRange):
363         (AccessibilityUIElement::getJSClass):
364         * DumpRenderTree/AccessibilityUIElement.h:
365         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
366         (AccessibilityUIElement::replaceTextInRange):
367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
368         (AccessibilityUIElement::replaceTextInRange):
369         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
370         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
371         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
372         (WTR::AccessibilityUIElement::replaceTextInRange):
373         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
374         (WTR::AccessibilityUIElement::replaceTextInRange):
375
376 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
377
378         [iOS] Do not allow starting selection drags when selection views are not visible
379         https://bugs.webkit.org/show_bug.cgi?id=196686
380         <rdar://problem/49399192>
381
382         Reviewed by Tim Horton.
383
384         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
385         also add some new API tests to cover scenarios where the web view is not first responder.
386
387         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
390
391         Add a switch to optionally make the web view first responder when starting the simulated drag.
392
393         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
394         (-[DragAndDropSimulator initWithWebView:]):
395         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
396
397 2019-04-08  Justin Fan  <justin_fan@apple.com>
398
399         [Web GPU] Fix Web GPU experimental feature on iOS
400         https://bugs.webkit.org/show_bug.cgi?id=196632
401
402         Reviewed by Myles C. Maxfield.
403
404         Properly make Web GPU available on iOS 11+.
405
406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
407
408 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
409
410         [ews-build] Do not upload archive when Compile Fails
411         https://bugs.webkit.org/show_bug.cgi?id=196674
412
413         Reviewed by Alexey Proskuryakov.
414
415         * BuildSlaveSupport/ews-build/factories.py:
416         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
417         * BuildSlaveSupport/ews-build/steps.py:
418         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
419         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
420         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
421
422 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
423
424         Enable DFG on MIPS
425         https://bugs.webkit.org/show_bug.cgi?id=196689
426
427         Reviewed by Žan Doberšek.
428
429         Since the bytecode change, we enabled the baseline JIT on mips in
430         r240432, but DFG is still missing. With this change, all tests are
431         passing on a ci20 board.
432
433         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
434
435 2019-04-08  Philippe Normand  <pnormand@igalia.com>
436
437         [Flatpak] Second run update-webkitwpe-flatpak fails
438         https://bugs.webkit.org/show_bug.cgi?id=192702
439
440         Reviewed by Carlos Garcia Campos.
441
442         * flatpak/flatpakutils.py:
443         (FlatpakObject.flatpak): Fix typo.
444         (FlatpakPackage.install): When installing, also update to the configured remote commit.
445         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
446
447 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
448
449         [GTK][WPE] outlook.live.com displays old-fashioned UI
450         https://bugs.webkit.org/show_bug.cgi?id=196642
451
452         Reviewed by Carlos Garcia Campos.
453
454         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
455         (TestWebKitAPI::TEST): New Mac platform quirk test.
456
457 2019-04-07  Commit Queue  <commit-queue@webkit.org>
458
459         Unreviewed, rolling out r243956.
460         https://bugs.webkit.org/show_bug.cgi?id=196688
461
462         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
463         by aakashjain on #webkit).
464
465         Reverted changeset:
466
467         "Clicking "Go Back" from a safe browsing warning from an
468         iframe should navigate the WKWebView back to the previous
469         page"
470         https://bugs.webkit.org/show_bug.cgi?id=196665
471         https://trac.webkit.org/changeset/243956
472
473 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
474
475         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
476         https://bugs.webkit.org/show_bug.cgi?id=196669
477
478         Reviewed by Geoffrey Garen.
479
480         Added three new unit tests for WeakHashSet.
481
482         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
483         (WTF_WeakPtr.WeakHashSetConstObjects):
484         (WTF_WeakPtr.WeakHashSetComputesEmpty):
485         (WTF_WeakPtr.WeakHashSetComputeSize):
486
487 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
488
489         Hide next and previous form control buttons when WKWebView is editable
490         https://bugs.webkit.org/show_bug.cgi?id=196672
491         <rdar://problem/35625321>
492
493         Reviewed by Tim Horton.
494
495         Add a new API test.
496
497         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
498         (-[TestWKWebView lastTrailingBarButtonGroup]):
499         (TestWebKitAPI::TEST):
500         * TestWebKitAPI/ios/UIKitSPI.h:
501
502 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
503
504         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
505         https://bugs.webkit.org/show_bug.cgi?id=196077
506         <rdar://problem/49108202>
507
508         Reviewed by Chris Dumez.
509
510         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
511         on new web view.
512
513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
514
515 2019-04-05  Saam Barati  <sbarati@apple.com>
516
517         Make compare-results understand MotionMark
518         https://bugs.webkit.org/show_bug.cgi?id=196666
519
520         Reviewed by Yusuke Suzuki.
521
522         * Scripts/compare-results:
523         (PLT5Results):
524         (detectMotionMark):
525         (detectMotionMark1_1):
526         (motionMarkResults):
527         (motionMark1_1Results):
528         (detectBenchmark):
529         (biggerIsBetter):
530         (main):
531
532 2019-04-05  Alex Christensen  <achristensen@webkit.org>
533
534         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
535         https://bugs.webkit.org/show_bug.cgi?id=196665
536         <rdar://45115669>
537
538         Reviewed by Geoff Garen.
539
540         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
541         (goBack):
542         (+[SimpleLookupContext sharedLookupContext]):
543         (-[SimpleLookupContext lookUpURL:completionHandler:]):
544         (TEST):
545         (+[Simple3LookupContext sharedLookupContext]): Deleted.
546         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
547
548 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-build] Add configuration and architecture for windows builders
551         https://bugs.webkit.org/show_bug.cgi?id=196660
552
553         Reviewed by Lucas Forschler.
554
555         * BuildSlaveSupport/ews-build/config.json:
556
557 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
558
559         webkitpy: Don't run subsequent rounds if interrupted
560         https://bugs.webkit.org/show_bug.cgi?id=196646
561
562         Reviewed by Aakash Jain.
563
564         * Scripts/webkitpy/layout_tests/controllers/manager.py:
565         (Manager.run): Bail out if interrupted.
566
567 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
568
569         Test sessionStorage in PSON private browsing mode
570         https://bugs.webkit.org/show_bug.cgi?id=196561
571
572         Reviewed by Alex Christensen.
573
574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
575
576 2019-04-05  Commit Queue  <commit-queue@webkit.org>
577
578         Unreviewed, rolling out r243833.
579         https://bugs.webkit.org/show_bug.cgi?id=196645
580
581         This change breaks build of WPE and GTK ports (Requested by
582         annulen on #webkit).
583
584         Reverted changeset:
585
586         "[CMake][WTF] Mirror XCode header directories"
587         https://bugs.webkit.org/show_bug.cgi?id=191662
588         https://trac.webkit.org/changeset/243833
589
590 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
591
592         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
593         https://bugs.webkit.org/show_bug.cgi?id=196635
594
595         Reviewed by Antti Koivisto.
596         
597         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
598         for a test to enable async frame scrolling via:
599             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
600         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
601         
602         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
603
604         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
605         (WTR::InjectedBundle::beginTesting):
606         * WebKitTestRunner/TestController.cpp:
607         (WTR::TestController::resetPreferencesToConsistentValues):
608
609 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
610
611         Use a correct LC_RPATH when building with ASan
612         https://bugs.webkit.org/show_bug.cgi?id=196576
613
614         Reviewed by David Kilzer.
615
616         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
617         so that ../Frameworks is checked. This is simpler and more reliable than updating
618         each SPC service xcconfig.
619
620 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
621
622         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
623         https://bugs.webkit.org/show_bug.cgi?id=196629
624
625         Reviewed by Lucas Forschler.
626
627         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
628
629 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
630
631         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
632         https://bugs.webkit.org/show_bug.cgi?id=196618
633
634         Reviewed by Lucas Forschler.
635
636         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
637         (StatusBubble): Added QUEUE_TRIGGERS.
638         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
639         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
640         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
641         its parent(builder).
642
643 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
644
645         [ews-app] Status-bubble steps are sometimes displayed in reverse order
646         https://bugs.webkit.org/show_bug.cgi?id=196625
647
648         Reviewed by Lucas Forschler.
649
650         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
651         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
652
653 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
654
655         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
656         https://bugs.webkit.org/show_bug.cgi?id=196630
657
658         Reviewed by Wenson Hsieh.
659
660         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
661
662 2019-04-04  Youenn Fablet  <youenn@apple.com>
663
664         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
665         https://bugs.webkit.org/show_bug.cgi?id=196543
666
667         Reviewed by Alex Christensen.
668
669         * WebKitTestRunner/TestController.cpp:
670         (WTR::TestController::generatePageConfiguration):
671
672 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews-app] Status bubble should not display skipped buildbot steps
675         https://bugs.webkit.org/show_bug.cgi?id=196584
676
677         Reviewed by Lucas Forschler.
678
679         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
680
681 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
682
683         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
684         https://bugs.webkit.org/show_bug.cgi?id=196620
685
686         Reviewed by Lucas Forschler.
687
688         * BuildSlaveSupport/ews-app/ews/config.py:
689
690 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
691
692         [Win] DumpRenderTreeWatchDog.py is not checked into source
693         https://bugs.webkit.org/show_bug.cgi?id=196567
694         <rdar://problem/49525901>
695
696         Reviewed by Lucas Forschler.
697
698         This script is used on Win EWS bots to terminate hanging DRT processes.
699
700         * EWSTools/dumprendertreewatchdog.py: Added.
701
702 2019-04-04  Chris Dumez  <cdumez@apple.com>
703
704         Unreviewed, roll out r243858 which made tests time out.
705
706         Disable new API tests on Windows instead.
707
708         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
709         (TestWebKitAPI::TEST):
710
711 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
712
713         [ATK] Cleanup WebPageAccessibilityObjectAtk
714         https://bugs.webkit.org/show_bug.cgi?id=196537
715
716         Reviewed by Michael Catanzaro.
717
718         Also consider files under atk directories as exceptions for GObject conventions.
719
720         * Scripts/webkitpy/style/checkers/cpp.py:
721         (check_identifier_name_in_declaration):
722
723 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
724
725         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
726         https://bugs.webkit.org/show_bug.cgi?id=196588
727         <rdar://problem/49365787>
728
729         Unreviewed build fix for Windows port.
730
731         error C3861: 'kill': identifier not found
732
733         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
734         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
735
736 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
737
738         [ews-build] Cancel build and similar operations should have authentication
739         https://bugs.webkit.org/show_bug.cgi?id=196520
740
741         Reviewed by Dewei Zhu.
742
743         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
744         environment variables.
745
746 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
747
748         [ews-build] Do not trigger queues which are not in production yet
749         https://bugs.webkit.org/show_bug.cgi?id=196581
750
751         Reviewed by Dewei Zhu.
752
753         * BuildSlaveSupport/ews-build/config.json:
754
755 2019-04-03  Chris Dumez  <cdumez@apple.com>
756
757         Unreviewed, fix typo in the name of API test added in r243848.
758
759         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
760         (TestWebKitAPI::TEST):
761
762 2019-04-03  Chris Dumez  <cdumez@apple.com>
763
764         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
765         https://bugs.webkit.org/show_bug.cgi?id=196588
766         <rdar://problem/49365787>
767
768         Reviewed by Ryosuke Niwa.
769
770         Add API test coverage.
771
772         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
773         (TestWebKitAPI::nullJavaScriptCallback):
774         (TestWebKitAPI::didCrashCheckFrames):
775         (TestWebKitAPI::TEST):
776
777 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
778
779         run-webkit-tests: Upload test results (new results database)
780         https://bugs.webkit.org/show_bug.cgi?id=196577
781         <rdar://problem/34841155>
782
783         Reviewed by Lucas Forschler.
784
785         * Scripts/webkitpy/layout_tests/controllers/manager.py:
786         (Manager.run): Upload results after each device shard, since the configuration will be
787         different for each device.
788         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
789         uploaded to a results database.
790         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
791         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
792
793 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
794
795         -apple-trailing-word is needed for browser detection
796         https://bugs.webkit.org/show_bug.cgi?id=196575
797
798         Unreviewed.
799
800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
801
802 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
803
804         [CMake][WTF] Mirror XCode header directories
805         https://bugs.webkit.org/show_bug.cgi?id=191662
806
807         Reviewed by Konstantin Tokarev.
808
809         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
810         builds.
811
812         * CMakeLists.txt:
813         * DumpRenderTree/CMakeLists.txt:
814         * DumpRenderTree/PlatformWin.cmake:
815         * MiniBrowser/win/CMakeLists.txt:
816         * TestWebKitAPI/CMakeLists.txt:
817         * TestWebKitAPI/PlatformWin.cmake:
818         * WebKitTestRunner/PlatformGTK.cmake:
819         * WebKitTestRunner/PlatformWin.cmake:
820
821 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
822
823         [ews-app] Status bubble should not display certain infrastructure status messages
824         https://bugs.webkit.org/show_bug.cgi?id=196550
825
826         Reviewed by Lucas Forschler.
827
828         Do not display the steps which are un-needed for end-user. This information is still avaiable
829         if the user click on the bubble and look at the Buildbot build.
830         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
831         (StatusBubble._steps_messages):
832         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
833
834 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
835
836         [ews-build] Use https for sending data to ews-app
837         https://bugs.webkit.org/show_bug.cgi?id=196492
838
839         Reviewed by Lucas Forschler.
840
841         * BuildSlaveSupport/ews-build/events.py:
842
843 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
844
845         Remove support for -apple-trailing-word
846         https://bugs.webkit.org/show_bug.cgi?id=196525
847
848         Reviewed by Zalan Bujtas.
849
850         This CSS property is nonstandard and not used.
851
852         * Scripts/webkitperl/FeatureList.pm:
853         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
854
855 2019-04-03  Youenn Fablet  <youenn@apple.com>
856
857         Add a test for DOMCache on multiple browsing in case of private browsing
858         https://bugs.webkit.org/show_bug.cgi?id=196524
859
860         Reviewed by Alex Christensen.
861
862         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
863         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
864
865 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
866
867         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
868         https://bugs.webkit.org/show_bug.cgi?id=196540
869
870         Reviewed by Aakash Jain.
871
872         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
873
874 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
875
876         Add plumbing for a compatibility mode preference in WebKit
877         https://bugs.webkit.org/show_bug.cgi?id=196005
878
879         Reviewed by Tim Horton.
880
881         Add new API tests.
882
883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
884         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
885
886 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
887
888         [WPE][GTK] Update libsrtp dependency package for Debian
889         https://bugs.webkit.org/show_bug.cgi?id=196528
890
891         Reviewed by Frédéric Wang.
892
893         * gtk/install-dependencies:
894         * wpe/install-dependencies:
895
896 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
897
898         [WK2] Add support for Window's beforeprint / afterprint events
899         https://bugs.webkit.org/show_bug.cgi?id=196478
900         <rdar://problem/49535124>
901
902         Unreviewed build fix for MSVC.
903
904         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
905
906         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
907
908         * WebKitTestRunner/TestController.cpp:
909         (WTR::printFrame): Use int and float literals.
910
911 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
912
913         [ews-build] Reassign bots to queues
914
915         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
916
917 2019-04-02  Chris Dumez  <cdumez@apple.com>
918
919         [WK2] Add support for Window's beforeprint / afterprint events
920         https://bugs.webkit.org/show_bug.cgi?id=196478
921
922         Reviewed by Alex Christensen.
923
924         Add minimal implementation for printFrame in WebKitTestRunner.
925
926         * WebKitTestRunner/TestController.cpp:
927         (WTR::printFrame):
928         (WTR::TestController::createOtherPage):
929         (WTR::TestController::createWebViewWithOptions):
930
931 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
932
933         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
934         https://bugs.webkit.org/show_bug.cgi?id=196491
935
936         Reviewed by Lucas Forschler.
937
938         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
939
940 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
941
942         [ews-build] Configure buildbot try credentials in environment variables
943         https://bugs.webkit.org/show_bug.cgi?id=196501
944
945         Reviewed by Lucas Forschler.
946
947         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
948         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
949         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
950
951 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
952
953         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
954         https://bugs.webkit.org/show_bug.cgi?id=196496
955         <rdar://problem/49521634>
956
957         Reviewed by Chris Dumez.
958
959         Add new API tests (see WebKit ChangeLog for more detail).
960
961         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
962         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
963         (TEST):
964
965 2019-04-02  David Kilzer  <ddkilzer@apple.com>
966
967         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
968         <https://webkit.org/b/196499>
969
970         Reviewed by Alexey Proskuryakov.
971
972         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
973         ENABLE_ADDRESS_SANITIZER.
974
975 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
976
977         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
978         https://bugs.webkit.org/show_bug.cgi?id=182757
979
980         Reviewed by Don Olmstead.
981
982         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
983         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
984
985 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
986
987         run-api-tests: Upload test results
988         https://bugs.webkit.org/show_bug.cgi?id=196323
989         <rdar://problem/49356714>
990
991         Reviewed by Lucas Forschler.
992
993         * Scripts/webkitpy/api_tests/manager.py:
994         (Manager):
995         (Manager.run): Upload results to a results database.
996         * Scripts/webkitpy/api_tests/run_api_tests.py:
997         (parse_args): Add upload arguments.
998         * Scripts/webkitpy/port/base.py:
999         (Port):
1000         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1001         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1002         with commits from any other associated repositories.
1003         * Scripts/webkitpy/port/device.py:
1004         (Device):
1005         (Device.build_version): Access build_versoin of underlying platform device.
1006         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1007         (IOSSimulatorTest):
1008         (IOSSimulatorTest.test_configuration_for_upload):
1009         * Scripts/webkitpy/port/device_port.py:
1010         (DevicePort):
1011         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1012         the same as the machine uploading results.
1013         * Scripts/webkitpy/port/mac.py:
1014         (MacPort):
1015         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1016         * Scripts/webkitpy/port/mac_unittest.py:
1017         (MacTest):
1018         (MacTest.test_configuration_for_upload):
1019         * Scripts/webkitpy/xcode/simulated_device.py:
1020         (SimulatedDeviceManager._create_device_with_runtime):
1021         (SimulatedDevice.__init__): Create simulated device with a build_version.
1022         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1023         (test_existing_simulator):
1024
1025 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1026
1027         Remove extra newline characters (Follow-up fix to r243707)
1028
1029         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1030
1031 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-app] Use API_KEY to accept results data
1034         https://bugs.webkit.org/show_bug.cgi?id=196461
1035
1036         Reviewed by Dewei Zhu.
1037
1038         * BuildSlaveSupport/ews-app/ews/views/results.py:
1039         (Results.post): Validate EWS_API_KEY before accepting any data.
1040         * BuildSlaveSupport/ews-build/events.py:
1041         (Events.sendData): Send EWS_API_KEY if available along with event data.
1042
1043 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1044
1045         Unable to copy and paste a PDF from Notes into Mail compose body
1046         https://bugs.webkit.org/show_bug.cgi?id=196442
1047         <rdar://problem/48573098>
1048
1049         Reviewed by Tim Horton.
1050
1051         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1052         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1053         to be specified on the item providers.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1056         (TestWebKitAPI::mapItemForTesting):
1057         (TestWebKitAPI::contactItemForTesting):
1058
1059 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1060
1061         Make UIWKDocumentContext rects per-character instead of per-word
1062         https://bugs.webkit.org/show_bug.cgi?id=196459
1063
1064         Reviewed by Wenson Hsieh.
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1067         (TEST):
1068         Adjust test results due to switching to per-character rects.
1069
1070 2019-04-01  Chris Dumez  <cdumez@apple.com>
1071
1072         UIProcess crash when a prewarmed process is terminated
1073         https://bugs.webkit.org/show_bug.cgi?id=196451
1074         <rdar://problem/49245471>
1075
1076         Reviewed by Geoffrey Garen.
1077
1078         Add API test coverage.
1079
1080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1081         (TEST):
1082
1083 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1084
1085         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1086         https://bugs.webkit.org/show_bug.cgi?id=196449
1087
1088         Reviewed by Lucas Forschler.
1089
1090         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1091         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1092         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1093         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1094
1095 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1098         https://bugs.webkit.org/show_bug.cgi?id=196444
1099
1100         Reviewed by Lucas Forschler.
1101
1102         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1103
1104 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1105
1106         Add SPI to canonicalize NSURLs with WTF::URL
1107         https://bugs.webkit.org/show_bug.cgi?id=196415
1108         <rdar://problem/44980271>
1109
1110         Reviewed by Darin Adler.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1114         (TestWebKitAPI::TEST):
1115
1116 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1117
1118         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1119         https://bugs.webkit.org/show_bug.cgi?id=196441
1120
1121         Reviewed by Carlos Garcia Campos.
1122
1123         Don't cache the wpe_view_backend object that might not exist yet at the
1124         time of EventSenderProxy constructor invocation, but instead retrieve
1125         that object whenever it's required for event dispatching. This should
1126         avoid crashes in this constructor now that it's invoked before any
1127         PlatformWindow has been set up (as changed in r243496).
1128
1129         * WebKitTestRunner/EventSenderProxy.h:
1130         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1131         (WTR::viewBackend):
1132         (WTR::EventSenderProxy::EventSenderProxy):
1133         (WTR::EventSenderProxy::mouseDown):
1134         (WTR::EventSenderProxy::mouseUp):
1135         (WTR::EventSenderProxy::mouseMoveTo):
1136         (WTR::EventSenderProxy::mouseScrollBy):
1137         (WTR::EventSenderProxy::keyDown):
1138         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1139
1140 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1141
1142         [Win][WebKit] MiniBrowser should support high DPI display
1143         https://bugs.webkit.org/show_bug.cgi?id=196391
1144
1145         Reviewed by Alex Christensen.
1146
1147         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1148         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1149         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1150         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1151
1152 2019-03-31  Sam Weinig  <weinig@apple.com>
1153
1154         Remove more i386 specific configurations
1155         https://bugs.webkit.org/show_bug.cgi?id=196430
1156
1157         Reviewed by Alexey Proskuryakov.
1158
1159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1160         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1161
1162 2019-03-31  Andy Estes  <aestes@apple.com>
1163
1164         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1165         https://bugs.webkit.org/show_bug.cgi?id=196433
1166         <rdar://problem/49293305>
1167
1168         Reviewed by Tim Horton.
1169
1170         Enhanced API test coverage to include all navigation response policy decisions in both
1171         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1172
1173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1174         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1175         (TestWebKitAPI::TEST):
1176         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1177         (readFile):
1178         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1179         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1180         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1181         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1182         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1183         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1184         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1185         (-[QuickLookDelegate _downloadDidStart:]):
1186         (-[QuickLookDelegate _download:didReceiveResponse:]):
1187         (-[QuickLookDelegate _download:didReceiveData:]):
1188         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1189         (-[QuickLookDelegate _downloadDidFinish:]):
1190         (-[QuickLookDelegate _download:didFailWithError:]):
1191         (-[QuickLookDelegate _downloadDidCancel:]):
1192         (-[QuickLookDelegate verifyDownload]):
1193         (runTest):
1194         (runTestDecideBeforeLoading):
1195         (runTestDecideAfterLoading):
1196         (TEST):
1197         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1198         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1199         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1200         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1201         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1202         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1203         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1204         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1205         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1206         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1207         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1208         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1209         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1210         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1211
1212 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1213
1214         [CMake] add testdfg as target with build-jsc
1215         https://bugs.webkit.org/show_bug.cgi?id=196393
1216
1217         Reviewed by Saam Barati.
1218
1219         Added testdfg as one of the targets to build when
1220         using CMake.
1221
1222         * Scripts/build-jsc:
1223
1224 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1225
1226         Delete WebMetal implementation in favor of WebGPU
1227         https://bugs.webkit.org/show_bug.cgi?id=195418
1228
1229         Reviewed by Dean Jackson.
1230
1231         * DumpRenderTree/mac/DumpRenderTree.mm:
1232         (enableExperimentalFeatures):
1233         (resetWebPreferencesToConsistentValues):
1234         * Scripts/webkitperl/FeatureList.pm:
1235         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1238         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1239         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1240         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1241         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1242         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1243         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1244         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1245         (WTR::InjectedBundle::beginTesting):
1246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1247         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1249
1250 2019-03-29  Chris Dumez  <cdumez@apple.com>
1251
1252         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1253         https://bugs.webkit.org/show_bug.cgi?id=196405
1254         <rdar://problem/49428130>
1255
1256         Reviewed by Wenson Hsieh.
1257
1258         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1259         the popover presentation methods to be no-ops. Use this in the new test added in
1260         r243523 so that we do not swizzle those methods for all tests. This is needed because
1261         those WatchOS tests rely on the popover getting presented and interactive.
1262
1263         * WebKitTestRunner/TestController.cpp:
1264         (WTR::updateTestOptionsFromTestHeader):
1265         * WebKitTestRunner/TestController.h:
1266         * WebKitTestRunner/TestOptions.h:
1267         (WTR::TestOptions::hasSameInitializationOptions const):
1268         * WebKitTestRunner/ios/TestControllerIOS.mm:
1269         (WTR::TestController::platformInitialize):
1270         (WTR::TestController::platformResetStateToConsistentValues):
1271
1272 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1273
1274         [Curl] Add Server Trust Evaluation Support.
1275         https://bugs.webkit.org/show_bug.cgi?id=191646
1276
1277         Reviewed by Fujii Hironori.
1278
1279         Implemented MiniBrowser UI for asking if user trusts the server.
1280
1281         * MiniBrowser/win/Common.cpp:
1282         (askServerTrustEvaluation):
1283         (replaceString):
1284         * MiniBrowser/win/Common.h:
1285         * MiniBrowser/win/MiniBrowserLib.rc:
1286         * MiniBrowser/win/MiniBrowserLibResource.h:
1287         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1288         (createPEMString):
1289         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1290         (WebKitBrowserWindow::canTrustServerCertificate):
1291         * MiniBrowser/win/WebKitBrowserWindow.h:
1292
1293 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1294
1295         Implement ResizeObserver.
1296         https://bugs.webkit.org/show_bug.cgi?id=157743
1297
1298         Reviewed by Simon Fraser.
1299
1300         Support resizeObserverEnabled webPreferences.
1301
1302         * DumpRenderTree/TestOptions.cpp:
1303         (TestOptions::TestOptions):
1304         * DumpRenderTree/TestOptions.h:
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (setWebPreferencesForTestOptions):
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (enableExperimentalFeatures):
1309         * Scripts/webkitperl/FeatureList.pm:
1310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1311
1312 2019-03-28  John Wilander  <wilander@apple.com>
1313
1314         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1315         https://bugs.webkit.org/show_bug.cgi?id=196281
1316         <rdar://problem/48938748>
1317
1318         Reviewed by Alex Christensen.
1319
1320         This patch adds the function isStatisticsHasLocalStorage() to the
1321         TestRunner. With it, the page can query the WebsiteDataStore in the
1322         UI process to make sure that it sees LocalStorage.
1323
1324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1326         (WTR::TestRunner::isStatisticsHasLocalStorage):
1327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1328         * WebKitTestRunner/TestController.cpp:
1329         (WTR::TestController::isStatisticsHasLocalStorage):
1330         * WebKitTestRunner/TestController.h:
1331         * WebKitTestRunner/TestInvocation.cpp:
1332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1333
1334 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1335
1336         API::Data::createWithoutCopying should do a null check before calling CFRelease
1337         https://bugs.webkit.org/show_bug.cgi?id=196276
1338         <rdar://problem/48059859>
1339
1340         Reviewed by Alex Christensen.
1341
1342         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1343
1344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1345         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1346         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1347         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1348         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1349         (TestWebKitAPI::TEST):
1350
1351 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1352
1353         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1354         https://bugs.webkit.org/show_bug.cgi?id=186276
1355
1356         Reviewed by Carlos Garcia Campos.
1357
1358         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1359         (webViewLoadChanged):
1360         (testWebResourceGetDataError):
1361         (testWebResourceGetDataEmpty):
1362         (beforeAll):
1363         (webViewloadChanged): Deleted.
1364
1365 2019-03-27  Andy Estes  <aestes@apple.com>
1366
1367         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1368         https://bugs.webkit.org/show_bug.cgi?id=196317
1369
1370         Reviewed by Dan Bernstein.
1371
1372         package-root copies built products into a staging directory using ditto(1), which does not
1373         follow symbolic links as it traverses a directory. Now that the files in
1374         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1375         itself, these become broken links when ditto'd into the staging directory.
1376
1377         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1378
1379         * Scripts/package-root:
1380
1381 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1382
1383         [ews-app] Update display text of Submit for ews analysis
1384         https://bugs.webkit.org/show_bug.cgi?id=196309
1385
1386         Reviewed by Dewei Zhu.
1387
1388         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1389
1390 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1391
1392         run-webkit-tests should check for leaks in WebKit processes
1393         <https://webkit.org/b/193772>
1394         <rdar://problem/46526680>
1395
1396         Reviewed by Ryosuke Niwa.
1397
1398         This works by doing the following:
1399         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1400           The list of child processes are returned one per line:
1401           process.name: pid
1402         - Run the "#LIST CHILD PROCESSES" command just before the
1403           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1404           processes on the ServerProcess object.
1405         - When the `--leaks` switch is handled, run check_for_leaks() on
1406           each child process after the main test harness.
1407
1408         * DumpRenderTree/mac/DumpRenderTree.mm:
1409         (handleControlCommand):
1410         - Use strncmp() instead of strcmp().
1411         - Add support for handling "#LIST CHILD PROCESSES" command.
1412
1413         * Scripts/webkitpy/port/base.py:
1414         (Port.check_for_leaks):
1415         * Scripts/webkitpy/port/darwin.py:
1416         (DarwinPort.check_for_leaks):
1417         - Rename redundant 'process_pid' argument to 'process_id'.
1418
1419         * Scripts/webkitpy/port/driver.py:
1420         (Driver.do_post_tests_work):
1421         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1422           longer the only command this sends to WebKitTestRunner.
1423         - If the `--leaks` switch is present, send the
1424           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1425           result using Port.set_webkit_processes().
1426         (Driver._parse_child_processes_output):
1427         - Add helper method to parse list of child process names and
1428           process IDs returned from WebKitTestRunner.
1429
1430         * Scripts/webkitpy/port/ios_device.py:
1431         (IOSDevicePort.check_for_leaks):
1432         - Rename redundant 'process_pid' argument to 'process_id'.
1433
1434         * Scripts/webkitpy/port/leakdetector.py:
1435         (LeakDetector._parse_leaks_output):
1436         - Return early if there is no leaks_output.
1437         (LeakDetector.check_for_leaks):
1438         - Rename redundant 'process_pid' argument to 'process_id'.
1439
1440         * Scripts/webkitpy/port/server_process.py:
1441         (ServerProcess.__init__):
1442         (ServerProcess.child_processes):
1443         (ServerProcess.set_child_processes):
1444         - Add instance variable to Port to store list of child process
1445           names and process IDs returned from WebKitTestRunner.
1446         (ServerProcess._start):
1447         - Clear self._child_processes.
1448         (ServerProcess.stop):
1449         - If self._child_processes is set, call
1450           self._port.check_for_leaks() for each child process.
1451
1452         * Scripts/webkitpy/port/server_process_unittest.py:
1453         (TrivialMockPort.check_for_leaks):
1454         - Rename redundant 'process_pid' argument to 'process_id'.
1455
1456         * Scripts/webkitpy/port/simulator_process.py:
1457         (SimulatorProcess.stop):
1458         - If self._child_processes is set, call
1459           self._port.check_for_leaks() for each child process.
1460
1461         * Scripts/webkitpy/port/watch_device.py:
1462         (WatchDevicePort.check_for_leaks):
1463         - Rename redundant 'process_pid' argument to 'process_id'.
1464
1465         * WebKitTestRunner/TestController.cpp:
1466         (WTR::TestController::dumpResponse):
1467         - Extract method from findAndDumpWorldLeaks() so that it may be
1468           reused by findAndDumpWebKitProcessIdentifiers().
1469         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1470         - Add method to output process name and process ID of both the
1471           WebContent and Networking processes.
1472         (WTR::TestController::findAndDumpWorldLeaks):
1473         - Fix missing newline in output when there were no abandoned
1474           documents.
1475         - Call dumpResponse() for extracted code.
1476         (WTR::TestController::handleControlCommand):
1477         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1478         - Use strncmp() instead of strcmp().
1479         - Call findAndDumpWebKitProcessIdentifiers() when
1480           "#LIST CHILD PROCESSES" command is sent.
1481         * WebKitTestRunner/TestController.h:
1482         (WTR::TestController::dumpResponse):
1483         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1484         - Declare methods.
1485
1486 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         Unreviewed. Add GLib API test cases after r243434.
1489
1490         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1491         (testWebViewActiveURI):
1492         (serverCallback):
1493         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1494         (sendRequestCallback):
1495
1496 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1497
1498         Geolocation request not complete when watch request was started in a different web process
1499         https://bugs.webkit.org/show_bug.cgi?id=195996
1500
1501         Reviewed by Alex Christensen.
1502
1503         Add a test case.
1504
1505         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1506         (TestWebKitAPI::runJavaScriptAlert):
1507         (TestWebKitAPI::TEST):
1508
1509 2019-03-26  Keith Rollin  <krollin@apple.com>
1510
1511         Update the way generate-xcfilelists returns strings from functions
1512         https://bugs.webkit.org/show_bug.cgi?id=195975
1513         <rdar://problem/49040807>
1514
1515         Reviewed by Dean Jackson.
1516
1517         There are places where generate-xcfilelists executes assignments with
1518         statements like:
1519
1520             FOO=$(some_function)
1521
1522         where "some_function" return a string by echoing it. E.g.
1523
1524             some_function()
1525             {
1526                 echo "Hello, World"
1527             }
1528
1529         This is a common idiom, but it has a problem if "some_function" needs
1530         to call "exit" in an attempt to halt the entire script right then and
1531         there. Since "some_function" is called inside of $(), it's being
1532         executed in a sub-shell. Calling exit in that sub-shell simply exits
1533         that shell; it doesn't not exit the outer shell in which the main part
1534         of the script is still running. As such, the main script keeps
1535         executing when the intent was for the script to halt.
1536
1537         The solution to this is to use a different idiom for returning
1538         strings. The one we now is to pass in the name of the variable to
1539         receive the string result:
1540
1541             some_function()
1542             {
1543                 variable_name=$1
1544                 eval $variable_name ="Hello, World"
1545             }
1546
1547         The call site now looks like
1548
1549             some_function FOO
1550
1551         Because there's no invocation of a sub-shell, some_function can now
1552         call "exit" if it wants to, and the entire script will exit at that
1553         point.
1554
1555         * Scripts/generate-xcfilelists:
1556
1557 2019-03-26  Chris Dumez  <cdumez@apple.com>
1558
1559         Add basic layout test coverage for File Picker on iOS
1560         https://bugs.webkit.org/show_bug.cgi?id=196265
1561
1562         Reviewed by Wenson Hsieh.
1563
1564         Add layout test infrastructure to test the file picker on iOS.
1565
1566         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1567         (WTR::UIScriptController::dismissFilePicker):
1568         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1569         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1570         (WTR::UIScriptController::dismissFilePicker):
1571         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1572         * WebKitTestRunner/TestController.cpp:
1573         (WTR::TestController::createWebViewWithOptions):
1574         (WTR::updateTestOptionsFromTestHeader):
1575         * WebKitTestRunner/TestOptions.h:
1576         (WTR::TestOptions::hasSameInitializationOptions const):
1577         * WebKitTestRunner/ios/TestControllerIOS.mm:
1578         (overridePresentViewController):
1579         (WTR::TestController::platformInitialize):
1580         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1581         (WTR::UIScriptController::dismissFilePicker):
1582
1583 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1584
1585         Implement async paste method on UIWKInteractionViewProtocol
1586         https://bugs.webkit.org/show_bug.cgi?id=196267
1587         <rdar://problem/49236346>
1588
1589         Reviewed by Tim Horton.
1590
1591         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1592         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1593         are now a part of all iOS 12 internal SDKs.
1594
1595         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1596
1597         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1598         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1599
1600         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1601         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1602         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1603         * TestWebKitAPI/ios/UIKitSPI.h:
1604
1605 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1606
1607         [ews-build] Use PostgreSQL for ews.webkit.org database
1608         https://bugs.webkit.org/show_bug.cgi?id=196270
1609
1610         Reviewed by Lucas Forschler.
1611
1612         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1613
1614 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1615
1616         [ews] Reset simctl states on reboot
1617         https://bugs.webkit.org/show_bug.cgi?id=196260
1618
1619         Rubber-stamped by Aakash Jain.
1620
1621         * EWSTools/start-queue-mac.sh:
1622
1623 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1624
1625         [ews-build] Use PostgreSQL for ews-build database
1626         https://bugs.webkit.org/show_bug.cgi?id=196229
1627
1628         Reviewed by Lucas Forschler.
1629
1630         * BuildSlaveSupport/ews-build/master.cfg:
1631
1632 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-build] Get master_hostname dynamically in master.cfg
1635         https://bugs.webkit.org/show_bug.cgi?id=196255
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1640         send events data in test mode.
1641
1642 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1643
1644         [ews-app] Set db_constraint to False for Foreign Keys
1645         https://bugs.webkit.org/show_bug.cgi?id=196252
1646
1647         Reviewed by Lucas Forschler.
1648
1649         * BuildSlaveSupport/ews-app/ews/models/build.py:
1650         * BuildSlaveSupport/ews-app/ews/models/step.py:
1651
1652 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1653
1654         [ews-build] is_test_mode_enabled should default to True
1655         https://bugs.webkit.org/show_bug.cgi?id=196248
1656
1657         Reviewed by Lucas Forschler.
1658
1659         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1660
1661 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1662
1663         [ews-app] Add webkitperl to ENABLED_QUEUES
1664         https://bugs.webkit.org/show_bug.cgi?id=196253
1665
1666         Reviewed by Lucas Forschler.
1667
1668         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1669
1670 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1671
1672         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1673         https://bugs.webkit.org/show_bug.cgi?id=196211
1674         rdar://problem/49110552
1675
1676         Reviewed by Tim Horton.
1677
1678         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1679         Make sure that EventSenderProxy always exists when running tests. We used to create
1680         it when resetting before the first test, which is a bit too late.
1681
1682         * WebKitTestRunner/TestController.h:
1683         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1684         (WTR::TestController::platformCreateWebView):
1685         (WTR::TestController::platformCreateOtherPage):
1686         (WTR::TestController::finishCreatingPlatformWebView):
1687         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1688         (WTR::PlatformWebView::PlatformWebView):
1689         Moved some code that made NSWindow use NSEvent during web view creation. We may
1690         need to move more if some other case us found, but this is enough for now.
1691
1692 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1693
1694         Unreviewed. Fix typo in GLib geolocation API after r243285.
1695
1696         gelocation -> geolocation.
1697
1698         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1699         (testGeolocationManagerWatchPosition):
1700
1701 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1702
1703         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1704         https://bugs.webkit.org/show_bug.cgi?id=196213
1705
1706         Reviewed by Geoff Garen.
1707
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1710         (credentialWithIdentityAndKeychainPath):
1711         (-[ChallengeDelegate webView:didFinishNavigation:]):
1712         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1713         (TestWebKitAPI::TEST):
1714
1715 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1716
1717         Expected shouldn't assume its contained types are copyable
1718         https://bugs.webkit.org/show_bug.cgi?id=195986
1719
1720         Reviewed by JF Bastien.
1721
1722         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1723         (TestWebKitAPI::NonCopyable::operator== const):
1724         (TestWebKitAPI::NonCopyable::operator!= const):
1725         (TestWebKitAPI::TEST):
1726
1727 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1728
1729         Remove some now-unnecessary dynamic class lookup
1730         https://bugs.webkit.org/show_bug.cgi?id=196237
1731
1732         Reviewed by Simon Fraser.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1735         (makeRequest):
1736         (TEST):
1737
1738 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1739
1740         Unreviewed, rolling out r243450.
1741
1742         AppleWin and WinCairo port builds get broken.
1743
1744         Reverted changeset:
1745
1746         "Add test for fix of #196095"
1747         https://bugs.webkit.org/show_bug.cgi?id=196097
1748         https://trac.webkit.org/changeset/243450
1749
1750 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1751
1752         Unreviewed, rolling out r243465.
1753         https://bugs.webkit.org/show_bug.cgi?id=196226
1754
1755         the test doesn't build (Requested by thorton on #webkit).
1756
1757         Reverted changeset:
1758
1759         "Do not terminate the NetworkProcess if a third party
1760         application sends a NSCredential with a SecIdentityRef"
1761         https://bugs.webkit.org/show_bug.cgi?id=196213
1762         https://trac.webkit.org/changeset/243465
1763
1764 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1765
1766         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1767         https://bugs.webkit.org/show_bug.cgi?id=196213
1768
1769         Reviewed by Geoff Garen.
1770
1771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1772         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1773         (credentialWithIdentityAndKeychainPath):
1774         (-[ChallengeDelegate webView:didFinishNavigation:]):
1775         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1776         (TestWebKitAPI::TEST):
1777
1778 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-build] Gracefully handle missing patch_id in events
1781         https://bugs.webkit.org/show_bug.cgi?id=196216
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * BuildSlaveSupport/ews-build/events.py:
1786
1787 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1788
1789         [ews-build] use lz4 compression for improving buildbot performance
1790         https://bugs.webkit.org/show_bug.cgi?id=196155
1791
1792         Reviewed by Lucas Forschler.
1793
1794         * BuildSlaveSupport/ews-build/master.cfg:
1795
1796 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1797
1798         Pull some API testing helper methods out of TestWKWebView
1799         https://bugs.webkit.org/show_bug.cgi?id=196212
1800
1801         Reviewed by Tim Horton.
1802
1803         Refactor some more API testing utility methods, so that they can be used in
1804         tests that do not use TestWKWebView.
1805
1806         * TestWebKitAPI/cocoa/TestWKWebView.h:
1807         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1808         (-[WKWebView loadTestPageNamed:]):
1809         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1810         (-[WKWebView synchronouslyLoadHTMLString:]):
1811         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1812         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1813         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1814         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1815         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1816
1817 2019-03-25  Jer Noble  <jer.noble@apple.com>
1818
1819         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1820         https://bugs.webkit.org/show_bug.cgi?id=196097
1821
1822         Reviewed by Eric Carlson.
1823
1824         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1825
1826         * DumpRenderTree/mac/DumpRenderTree.mm:
1827         (resetWebPreferencesToConsistentValues):
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::TestController::resetPreferencesToConsistentValues):
1830
1831 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1832
1833         Pull IPadUserInterfaceSwizzler out into a separate header file
1834         https://bugs.webkit.org/show_bug.cgi?id=196193
1835
1836         Reviewed by Anders Carlsson.
1837
1838         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1839         be used in other API tests.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1843         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1844         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1845         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1846         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1847         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1848
1849 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1850
1851         Remove NavigatorContentUtils in WebCore/Modules
1852         https://bugs.webkit.org/show_bug.cgi?id=196070
1853
1854         Reviewed by Alex Christensen.
1855
1856         NavigatorContentUtils was to support the custom scheme spec [1].
1857         However, in WebKit side, no port has supported the feature in
1858         WebKit layer after EFL port was removed. So there has been the
1859         only IDL implementation of the NavigatorContentUtils in WebCore.
1860         So we don't need to keep the implementation in WebCore anymore.
1861
1862         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1863
1864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1865
1866 2019-03-24  Andy Estes  <aestes@apple.com>
1867
1868         [watchOS] Remove unused Proximity Networking code
1869         https://bugs.webkit.org/show_bug.cgi?id=196188
1870
1871         Reviewed by Tim Horton.
1872
1873         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1874         (TEST):
1875
1876 2019-03-23  Keith Miller  <keith_miller@apple.com>
1877
1878         Refactor clz/ctz and fix getLSBSet.
1879         https://bugs.webkit.org/show_bug.cgi?id=196162
1880
1881         Reviewed by Saam Barati.
1882
1883         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1884
1885         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1886         (TestWebKitAPI::TEST):
1887
1888 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1889
1890         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1891         https://bugs.webkit.org/show_bug.cgi?id=196143
1892
1893         Reviewed by Michael Catanzaro.
1894
1895         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1896         directories.
1897
1898         * Scripts/webkitpy/style/checkers/cpp.py:
1899         (check_identifier_name_in_declaration):
1900         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1901         (WebKitStyleTest.test_names):
1902
1903 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1904
1905         [Flatpak] Manifest expanding fails for qt WPE extension
1906         https://bugs.webkit.org/show_bug.cgi?id=196148
1907
1908         Reviewed by Alex Christensen.
1909
1910         * flatpak/flatpakutils.py:
1911         (expand_submodules_recurse): The last recurse manifest expand
1912         iteration might lead to a single module so take it into account
1913         and don't try to recurse further.
1914
1915 2019-03-22  Chris Dumez  <cdumez@apple.com>
1916
1917         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1918         https://bugs.webkit.org/show_bug.cgi?id=195348
1919         <rdar://problem/48622090>
1920
1921         Reviewed by Alex Christensen.
1922
1923         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1924         to NO when test.options().shouldIgnoreMetaViewport is false.
1925
1926         * WebKitTestRunner/ios/TestControllerIOS.mm:
1927         (WTR::TestController::platformConfigureViewForTest):
1928
1929 2019-03-22  Chris Dumez  <cdumez@apple.com>
1930
1931         Prewarmed processes should be usable with any website data store
1932         https://bugs.webkit.org/show_bug.cgi?id=196104
1933
1934         Reviewed by Alex Christensen.
1935
1936         Add API test coverage.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1939         (runInitialWarmedProcessUsedTest):
1940         (TEST):
1941
1942 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1943
1944         Back out local changes to Alex's Subversion working directory
1945
1946         They were accidentally committed.
1947
1948         * Scripts/webkitpy/common/system/abstractexecutive.py:
1949         (AbstractExecutive.wait_newest):
1950         * Scripts/webkitpy/common/system/executive.py:
1951         (Executive.running_pids):
1952         * Scripts/webkitpy/common/system/executive_mock.py:
1953         (MockExecutive.running_pids):
1954         * Scripts/webkitpy/common/system/executive_unittest.py:
1955         (ExecutiveTest.serial_test_running_pids):
1956         * Scripts/webkitpy/port/darwin.py:
1957         (DarwinPort.check_for_leaks):
1958         * Scripts/webkitpy/port/leakdetector.py:
1959         (LeakDetector.check_for_leaks):
1960         - This was the hack attached to Bug 193772.
1961
1962         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1963         (+[WebKitTestRunnerEvent mouseLocation]):
1964         - This works around a crash on an internal build.
1965
1966 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1967
1968         Fix the build after r243354
1969         https://bugs.webkit.org/show_bug.cgi?id=196138
1970         <rdar://problem/49145951>
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1973         (TEST):
1974         * TestWebKitAPI/ios/UIKitSPI.h:
1975
1976 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1977
1978         Adopt UIWKDocumentContext
1979         https://bugs.webkit.org/show_bug.cgi?id=196040
1980         <rdar://problem/48642440>
1981
1982         Reviewed by Ryosuke Niwa.
1983
1984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1985         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1986         (makeRequest):
1987         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1988         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1989         (applyStyle):
1990         (TEST):
1991         Add tests for UIWKDocumentContext.
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1994         (TEST):
1995         (recursiveFindWKContentView): Deleted.
1996         * TestWebKitAPI/cocoa/TestWKWebView.h:
1997         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1998         (recursiveFindWKContentView):
1999         (-[TestWKWebView wkContentView]):
2000         * TestWebKitAPI/ios/UIKitSPI.h:
2001         Share the WKContentView finding code between tests.
2002
2003 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2004
2005         [iOS WK2] Turn on async overflow scrolling by default
2006         https://bugs.webkit.org/show_bug.cgi?id=196011
2007         rdar://problem/48453859
2008
2009         Reviewed by Antti Koivisto.
2010         
2011         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2012         since so many basic layout tests have different results when compositing is triggered for
2013         overflow.
2014         
2015         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2016
2017         * WebKitTestRunner/TestController.cpp:
2018         (WTR::TestController::resetPreferencesToConsistentValues):
2019
2020 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2021
2022         [ews-build] Retry API test in case of failures
2023         https://bugs.webkit.org/show_bug.cgi?id=196004
2024
2025         Reviewed by Lucas Forschler.
2026
2027         * BuildSlaveSupport/ews-build/steps.py:
2028         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2029         (CompileWebKitToT.doStepIf): Ditto.
2030         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2031         (ReRunAPITests): Re-run API tests.
2032         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2033         (RunAPITestsWithoutPatch): Run API tests without patch.
2034         (RunAPITestsWithoutPatch.doStepIf):
2035         (RunAPITestsWithoutPatch.hideStepIf):
2036         (RunAPITestsWithoutPatch.evaluateCommand):
2037         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2038         (AnalyzeAPITestsResults.start):
2039         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2040         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2041         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2042         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2043
2044 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2045
2046         [ews-build] Update queues configurations
2047         https://bugs.webkit.org/show_bug.cgi?id=196074
2048
2049         Reviewed by Dewei Zhu.
2050
2051         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2052         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2053
2054 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2055
2056         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2057         https://bugs.webkit.org/show_bug.cgi?id=195680
2058         <rdar://problem/48903534>
2059
2060         Unreviewed infrastructure fix.
2061
2062         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2063         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2064
2065 2019-03-21  Andy Estes  <aestes@apple.com>
2066
2067         [iOS] Apple Pay should be available in documents with no user agent scripts
2068         https://bugs.webkit.org/show_bug.cgi?id=196061
2069         <rdar://problem/48649391>
2070
2071         Reviewed by Brady Eidson.
2072
2073         Added API tests and related infrastructure.
2074
2075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2076         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2077         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2078         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2079         (TestWebKitAPI::TEST):
2080         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2081         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2082         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2083         * TestWebKitAPI/cocoa/TestProtocol.mm:
2084         (-[TestProtocol startLoading]):
2085         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2086         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2087         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2088         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2089
2090 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2091
2092         REGRESSSION (r243297): webkitpy tests broken
2093         https://bugs.webkit.org/show_bug.cgi?id=196108
2094
2095         Reviewed by Aakash Jain.
2096
2097         r243297 updated contributors.json, which broke a few unit tests.
2098
2099         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2100         (IRCCommandTest.test_whois):
2101         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2102
2103 2019-03-21  Chris Dumez  <cdumez@apple.com>
2104
2105         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2106         https://bugs.webkit.org/show_bug.cgi?id=196041
2107         <rdar://problem/49083230>
2108
2109         Reviewed by Alex Christensen.
2110
2111         Add API test coverage.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2114         (TEST):
2115
2116 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2117
2118         Add SPI to inform applications of WKContentRuleList actions
2119         https://bugs.webkit.org/show_bug.cgi?id=195965
2120         <rdar://problem/42664365>
2121
2122         Reviewed by Geoff Garen.
2123
2124         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2125         (TestWebKitAPI::allActionsForResourceLoad):
2126         (TestWebKitAPI::testRequest):
2127         (TestWebKitAPI::TEST_F):
2128         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2129         (Notification::description):
2130         (Notification::operator== const):
2131         (toVector):
2132         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2133         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2134         (makeContentRuleList):
2135         (TEST):
2136         (makeWarnContentRuleList): Deleted.
2137
2138 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2139
2140         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2141         https://bugs.webkit.org/show_bug.cgi?id=196088
2142
2143         Reviewed by Brian Burg.
2144
2145         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2146         Support checks when only one platform is specified. Also deprecate macosx() and
2147         force the use of macos() instead.
2148
2149         * Scripts/webkitpy/style/checkers/cpp.py:
2150         (check_min_versions_of_wk_api_available):
2151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2152         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2153
2154 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2155
2156         Update status inactive committers' status to 'contributor'.
2157
2158         * Scripts/webkitpy/common/config/contributors.json:
2159
2160 2019-03-21  Xan Lopez  <xan@igalia.com>
2161
2162         [JSC][x86] Drop support for x87 floating point
2163         https://bugs.webkit.org/show_bug.cgi?id=194853
2164
2165         Reviewed by Don Olmstead.
2166
2167         Force SSE2 on x86/32bit builds.
2168
2169         * Scripts/webkitdirs.pm:
2170         (generateBuildSystemFromCMakeProject):
2171
2172 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2173
2174         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2175         https://bugs.webkit.org/show_bug.cgi?id=196073
2176
2177         Reviewed by Michael Catanzaro.
2178
2179         Add test cases to check functions and constructors with no arguments but receiving user data.
2180
2181         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2182         (checkUserData):
2183         (testJSCFunction):
2184         (fooCreateWithUserData):
2185         (testJSCClass):
2186
2187 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2188
2189         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2190
2191         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2192
2193         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2194
2195 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         [GTK][WPE] Add API to provide geolocation information
2198         https://bugs.webkit.org/show_bug.cgi?id=195940
2199
2200         Reviewed by Michael Catanzaro.
2201
2202         Add a new test to check the new API.
2203
2204         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2205         (testGeolocationManagerCurrentPosition):
2206         (testGeolocationManagerWatchPosition):
2207         (beforeAll):
2208         (afterAll):
2209         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2210         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2211         (beforeAll): Ditto.
2212         * TestWebKitAPI/glib/CMakeLists.txt:
2213
2214 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2215
2216         [GLib] Returning G_TYPE_OBJECT from a method does not work
2217         https://bugs.webkit.org/show_bug.cgi?id=195574
2218
2219         Reviewed by Michael Catanzaro.
2220
2221         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2222
2223         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2224         (getGFile):
2225         (getParent):
2226         (createGString):
2227         (getGString):
2228         (getGStringCopyWillRaise):
2229         (getGStringCopy):
2230         (getGStringStr):
2231         (getGStringLen):
2232         (freeGString):
2233         (testJSCClass):
2234
2235 2019-03-20  Saam Barati  <sbarati@apple.com>
2236
2237         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2238         https://bugs.webkit.org/show_bug.cgi?id=195721
2239
2240         Reviewed by Filip Pizlo.
2241
2242         * Scripts/run-javascriptcore-tests:
2243
2244 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2245
2246         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2247         https://bugs.webkit.org/show_bug.cgi?id=196049
2248
2249         Reviewed by Tim Horton.
2250
2251         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2252         overflow scrolling in general, so rename it.
2253
2254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2255
2256 2019-03-20  Daniel Bates  <dabates@apple.com>
2257
2258         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2259         https://bugs.webkit.org/show_bug.cgi?id=196031
2260         <rdar://problem/49078172>
2261
2262         Reviewed by Tim Horton.
2263
2264         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2265         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2266         same code path used when the Done button is pressed to dismiss the <select> picker.
2267
2268         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2269         (TestWebKitAPI::TEST):
2270
2271 2019-03-20  Chris Dumez  <cdumez@apple.com>
2272
2273         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2274         https://bugs.webkit.org/show_bug.cgi?id=196029
2275         <rdar://problem/48954651>
2276
2277         Reviewed by Tim Horton.
2278
2279         Add API test coverage.
2280
2281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2282
2283 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-build] Improve failure summary string for ApplyPatch step
2286         https://bugs.webkit.org/show_bug.cgi?id=195995
2287
2288         Reviewed by Alexey Proskuryakov.
2289
2290         * BuildSlaveSupport/ews-build/steps.py:
2291         (ApplyPatch.getResultSummary): Override getResultSummary.
2292
2293 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2294
2295         AX: Implement support for new meter ARIA role
2296         https://bugs.webkit.org/show_bug.cgi?id=195966
2297
2298         Reviewed by Chris Fleizach.
2299
2300         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2301         to AXLevelIndicator.
2302
2303         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2304
2305 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2306
2307         [WebAuthN] Implement FIDO AppID extension
2308         https://bugs.webkit.org/show_bug.cgi?id=143491
2309         <rdar://problem/48298273>
2310
2311         Reviewed by Brent Fulgham.
2312
2313         Add a test that covers the new flag of convertToU2fSignCommand.
2314
2315         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2318         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2319         (TestWebKitAPI::TEST):
2320
2321 2019-03-19  Keith Rollin  <krollin@apple.com>
2322
2323         Add support for more platforms to generate-xcfilelists
2324         https://bugs.webkit.org/show_bug.cgi?id=195977
2325
2326         Reviewed by Alexey Proskuryakov.
2327
2328         generate-xcfilelists incorrectly complains when involved with building
2329         WebKit for iphonesimulator:
2330
2331             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2332             …
2333             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2334
2335         Address this by teaching generate-xcfilelists about more platforms.
2336
2337         * Scripts/generate-xcfilelists:
2338
2339 2019-03-19  John Wilander  <wilander@apple.com>
2340
2341         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2342         https://bugs.webkit.org/show_bug.cgi?id=195923
2343         <rdar://problem/49001272>
2344
2345         Reviewed by Alex Christensen.
2346
2347         This patch does the following to the TestRunner:
2348         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2349         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2350         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2351
2352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2354         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2355         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2356         * WebKitTestRunner/TestController.cpp:
2357         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2358         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2359         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2360         * WebKitTestRunner/TestController.h:
2361         * WebKitTestRunner/TestInvocation.cpp:
2362         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2363
2364 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2365
2366         [CMake] Support more clang and gcc sanitizers
2367         https://bugs.webkit.org/show_bug.cgi?id=195956
2368
2369         Reviewed by Michael Catanzaro.
2370
2371         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2372
2373 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2374
2375         [ews-build] Improve summary for PrintConfiguration step
2376         https://bugs.webkit.org/show_bug.cgi?id=195945
2377
2378         Reviewed by Lucas Forschler.
2379
2380         * BuildSlaveSupport/ews-build/steps.py:
2381         (PrintConfiguration.getResultSummary): Override getResultSummary.
2382
2383 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2384
2385         [ews-build] Improve summary for CheckOutSource step
2386         https://bugs.webkit.org/show_bug.cgi?id=195963
2387
2388         Reviewed by Lucas Forschler.
2389
2390         * BuildSlaveSupport/ews-build/steps.py:
2391         (CheckOutSource.getResultSummary):
2392
2393 2019-03-19  Daniel Bates  <dabates@apple.com>
2394
2395         [iOS] Focus not preserved when switching between tabs
2396         https://bugs.webkit.org/show_bug.cgi?id=195820
2397         <rdar://problem/43614450>
2398
2399         Reviewed by Brent Fulgham.
2400
2401         Add tests to ensure that we restore focus when resigning and becoming first responder.
2402
2403         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2404         (TestWebKitAPI::TEST):
2405
2406 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2407
2408         Make WTFLogChannelState and WTFLogLevel enum classes
2409         https://bugs.webkit.org/show_bug.cgi?id=195904
2410
2411         Reviewed by Eric Carlson.
2412
2413         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2414         (TestWebKitAPI::TEST_F):
2415
2416 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2417
2418         [GStreamer][EME] Backported mssdemux protection data crash fix
2419         https://bugs.webkit.org/show_bug.cgi?id=195918
2420
2421         Reviewed by Philippe Normand.
2422
2423         * gstreamer/jhbuild.modules:
2424         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2425
2426 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2427
2428         Unreviewed, rolling out r243132.
2429
2430         Broke GTK build
2431
2432         Reverted changeset:
2433
2434         "Make WTFLogChannelState and WTFLogLevel enum classes"
2435         https://bugs.webkit.org/show_bug.cgi?id=195904
2436         https://trac.webkit.org/changeset/243132
2437
2438 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2439
2440         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2441
2442         * Scripts/webkitdirs.pm:
2443         (builtDylibPathForName): Adjust the shared library name that's changed
2444         with the API version bump in r243073.
2445
2446 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2447
2448         Make WTFLogChannelState and WTFLogLevel enum classes
2449         https://bugs.webkit.org/show_bug.cgi?id=195904
2450
2451         Reviewed by Eric Carlson.
2452
2453         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2454         (TestWebKitAPI::TEST_F):
2455
2456 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2457
2458         Disable flaky test added in r2431100
2459         https://webkit.org/b/195785
2460
2461         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2462         (TestWebKitAPI::TEST):
2463         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2464
2465 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2466
2467         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2468         https://bugs.webkit.org/show_bug.cgi?id=195916
2469
2470         Reviewed by Tim Horton.
2471
2472         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2473         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2474
2475 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2478
2479         * Scripts/webkitpy/common/config/contributors.json:
2480
2481 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2482
2483         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2484         https://bugs.webkit.org/show_bug.cgi?id=195785
2485
2486         Reviewed by Geoffrey Garen.
2487
2488         * TestWebKitAPI/TCPServer.cpp: Added.
2489         (TestWebKitAPI::TCPServer::TCPServer):
2490         (TestWebKitAPI::TCPServer::~TCPServer):
2491         (TestWebKitAPI::TCPServer::socketBindListen):
2492         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2493         * TestWebKitAPI/TCPServer.h: Added.
2494         (TestWebKitAPI::TCPServer::port const):
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2496         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2497         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2498         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2499         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2500         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2501         (TestWebKitAPI::respondSlowly):
2502         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2503         (TestWebKitAPI::downloadAtRate):
2504         (TestWebKitAPI::TEST):
2505
2506 2019-03-18  Saam Barati  <sbarati@apple.com>
2507
2508         Add a plan file for JetStream 2
2509         https://bugs.webkit.org/show_bug.cgi?id=190734
2510
2511         Reviewed by Mark Lam.
2512
2513         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2514
2515 2019-03-18  Chris Dumez  <cdumez@apple.com>
2516
2517         Delay WebProcess launch until a load is triggered in a Web view
2518         https://bugs.webkit.org/show_bug.cgi?id=195758
2519         <rdar://problem/48126013>
2520
2521         Reviewed by Geoff Garen.
2522
2523         Add API test coverage. Also update some existing API tests to not expect
2524         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2525
2526         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2527         (TestWebKitAPI::TEST):
2528         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2531         (TEST):
2532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2533         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2534         (TEST):
2535         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2536         (TEST):
2537         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2538
2539 2019-03-18  Xan Lopez  <xan@igalia.com>
2540
2541         [CMake] Prevent potential warning when determining $architecture
2542         https://bugs.webkit.org/show_bug.cgi?id=195891
2543
2544         Reviewed by Michael Catanzaro.
2545
2546         It's possible for generateBuildSystemForCMakeProject to be called
2547         before determineArchitecture() is ever called. This will make the
2548         first eq check with $architecture to be bogus (and print a
2549         warning). Change that to an eq check with architecture(), which
2550         implicitly calls determineArchitecture() if needed, and change all
2551         the other similar cases in the method in the same way to prevent
2552         future bugs like this one.
2553
2554         * Scripts/webkitdirs.pm:
2555         (generateBuildSystemFromCMakeProject):
2556
2557 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2558
2559         [WPE] Tarballs generated with “make dist” cannot build documentation
2560         https://bugs.webkit.org/show_bug.cgi?id=195885
2561
2562         Reviewed by Carlos Garcia Campos.
2563
2564         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2565
2566 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2567
2568         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2569         https://bugs.webkit.org/show_bug.cgi?id=195883
2570
2571         Reviewed by Carlos Garcia Campos.
2572
2573         * gtkdoc/gtkdoc.py:
2574         (GTKDoc._run_command): When commands fail to run, include the full command line for
2575         the program invocation and the output it has generated on the standard error stream.
2576
2577 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2578
2579         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2580         https://bugs.webkit.org/show_bug.cgi?id=195786
2581
2582         Reviewed by Philippe Normand.
2583
2584         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2585         * wpe/jhbuild.modules: Ditto.
2586
2587 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews-build] Don't run clean builds on EWS builders
2590         https://bugs.webkit.org/show_bug.cgi?id=195851
2591
2592         Reviewed by Geoffrey Garen.
2593
2594         * BuildSlaveSupport/ews-build/factories.py:
2595
2596 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2597
2598         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2599         https://bugs.webkit.org/show_bug.cgi?id=195849
2600
2601         Reviewed by Chris Dumez.
2602
2603         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2606         (runWebsiteDataStoreCustomPaths):
2607
2608 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2609
2610         webkitpy: Upload test results
2611         https://bugs.webkit.org/show_bug.cgi?id=195755
2612         <rdar://problem/48896182>
2613
2614         Reviewed by Aakash Jain.
2615
2616         Establish a new format for uploading results that is not tied to layout tests, apply
2617         that format to webkitpy tests.
2618
2619         * Scripts/webkitpy/common/checkout/scm/git.py:
2620         (Git.native_branch): Return what branch the current checkout is on.
2621         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2622         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2623         * Scripts/webkitpy/common/checkout/scm/svn.py:
2624         (SVN.native_branch): Ditto.
2625         * Scripts/webkitpy/common/system/platforminfo.py:
2626         (PlatformInfo.build_version): Return a build version for Mac.
2627         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2628         (MockPlatformInfo.__init__):
2629         (MockPlatformInfo.build_version):
2630         * Scripts/webkitpy/results: Added.
2631         * Scripts/webkitpy/results/__init__.py: Added.
2632         * Scripts/webkitpy/results/options.py: Added.
2633         (upload_options): OptParse list for upload options.
2634         * Scripts/webkitpy/results/upload.py: Added.
2635         (Upload): Class which enforces the upload format expected by the results server.
2636         (Upload.Expectations):
2637         (Upload.create_configuration):
2638         (Upload.create_commit):
2639         (Upload.create_details):
2640         (Upload.create_run_stats):
2641         (Upload.create_test_result):
2642         (Upload.__init__):
2643         (Upload.Encoder): Encode Upload object as json.
2644         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2645         * Scripts/webkitpy/results/upload_unittest.py: Added.
2646         * Scripts/webkitpy/test/main.py:
2647         (Tester._parse_args): Add upload arguments.
2648         (Tester._run_tests): Allow results to be uploaded.
2649         * Scripts/webkitpy/test/runner.py:
2650         (Runner.__init__): Record which tests were run, rather than just counting them.
2651         (Runner.handle):
2652         * Scripts/webkitpy/test/runner_unittest.py:
2653         (RunnerTest.test_run):
2654         * Scripts/webkitpy/thirdparty/__init__.py:
2655         (AutoinstallImportHook.find_module): Add requests auto-install.
2656         (AutoinstallImportHook._install_requests):
2657         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2658         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2659
2660 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2661
2662         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2663         https://bugs.webkit.org/show_bug.cgi?id=195810
2664
2665         Reviewed by Tim Horton.
2666
2667         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2668         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2669         ending certain layout tests.
2670
2671         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2672         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2673         (-[TestRunnerWKWebView dealloc]):
2674         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2675
2676         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2677         helper method when destroying the web view, and when resetting state between tests.
2678
2679         * WebKitTestRunner/ios/TestControllerIOS.mm:
2680         (WTR::TestController::platformResetStateToConsistentValues):
2681
2682         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2683
2684 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2685
2686         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2687         https://bugs.webkit.org/show_bug.cgi?id=190350
2688         <rdar://problem/45089503>
2689
2690         Reviewed by Geoffrey Garen.
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2694         (TEST):
2695         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2696         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2697         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2698         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2699         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2700         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2701         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2702         (runTest):
2703         (createDirectories):
2704         (TEST):
2705         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2706         (TEST):
2707         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2708         (TEST):
2709
2710 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2711
2712         Add support to WebPage for getting the contents as an attributed string.
2713         https://bugs.webkit.org/show_bug.cgi?id=195636
2714         rdar://problem/45055697
2715
2716         Reviewed by Tim Horton.
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2719         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2720
2721 2019-03-15  Chris Dumez  <cdumez@apple.com>
2722
2723         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2724         https://bugs.webkit.org/show_bug.cgi?id=195747
2725
2726         Reviewed by Geoff Garen.
2727
2728         Add API test coverage.
2729
2730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2731
2732 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2733
2734         Unreviewed, rolling out r242952.
2735
2736         Causing API failures on iOS Simulator
2737
2738         Reverted changeset:
2739
2740         "[PSON] Make sure the WebProcessCache is leverage when
2741         relaunching a process after termination"
2742         https://bugs.webkit.org/show_bug.cgi?id=195747
2743         https://trac.webkit.org/changeset/242952
2744
2745 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2746
2747         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2748         https://bugs.webkit.org/show_bug.cgi?id=195740
2749
2750         Reviewed by Ross Kirsling.
2751
2752         window.open doesn't work for WebKitBrowserWindow because it is not
2753         implemented yet.
2754
2755         1. Implemented createNewPage callback of WKPageUIClient.
2756         2. Changed MainWindow to take a BrowserWindow factory function
2757           instead of BrowserWindowType to be flexible to create
2758           BrowserWindow with extra settings.
2759         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2760           because it is not relevant with MainWindow anymore.
2761
2762         * MiniBrowser/win/Common.cpp:
2763         (parseCommandLine):
2764         * MiniBrowser/win/Common.h:
2765         (CommandLineOptions::CommandLineOptions):
2766         * MiniBrowser/win/MainWindow.cpp:
2767         (MainWindow::MainWindow):
2768         (MainWindow::create):
2769         (MainWindow::init):
2770         (MainWindow::WndProc):
2771         * MiniBrowser/win/MainWindow.h:
2772         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2773         (PrintWebUIDelegate::createWebViewWithRequest):
2774         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2775         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2776         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2777         (WebKitBrowserWindow::updateProxySettings):
2778         (WebKitBrowserWindow::createNewPage):
2779         * MiniBrowser/win/WebKitBrowserWindow.h:
2780         * MiniBrowser/win/WinMain.cpp:
2781         (wWinMain):
2782
2783 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2784
2785         Make it possible to test scrolling tree layer manipulation more easily
2786         https://bugs.webkit.org/show_bug.cgi?id=195780
2787
2788         Reviewed by Tim Horton.
2789         
2790         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2791         cuts off communication of scrolling tree scrolls back to the web process
2792         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2793         allows tests to trigger scrolls which run the scrolling tree layer positioning
2794         logic, but never get another commit from the web process that might mask
2795         scrolling tree bugs.
2796         
2797         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2798         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2799         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2800
2801         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2802         (WTR::UIScriptController::scrollUpdatesDisabled const):
2803         (WTR::UIScriptController::setScrollUpdatesDisabled):
2804         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2805         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2806         (WTR::UIScriptController::scrollUpdatesDisabled const):
2807         (WTR::UIScriptController::setScrollUpdatesDisabled):
2808         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2809         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2810         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2811         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2812         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2813         * WebKitTestRunner/ios/TestControllerIOS.mm:
2814         (WTR::TestController::platformResetStateToConsistentValues):
2815         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2816         (WTR::UIScriptController::scrollUpdatesDisabled const):
2817         (WTR::UIScriptController::setScrollUpdatesDisabled):
2818
2819 2019-03-14  Youenn Fablet  <youenn@apple.com>
2820
2821         Move IDB storage in private browsing mode to NetworkProcess
2822         https://bugs.webkit.org/show_bug.cgi?id=195602
2823
2824         Reviewed by Brady Eidson.
2825
2826         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2827         (TEST):
2828
2829 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2830
2831         [ews-build] Make descriptionDone messages more readable
2832         https://bugs.webkit.org/show_bug.cgi?id=195760
2833
2834         Reviewed by Lucas Forschler.
2835
2836         * BuildSlaveSupport/ews-build/steps.py:
2837         * BuildSlaveSupport/ews-build/steps_unittest.py:
2838
2839 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2840
2841         [ews-build] Generate status-bubble hover-over messages
2842         https://bugs.webkit.org/show_bug.cgi?id=195680
2843
2844         Reviewed by Lucas Forschler.
2845
2846         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2847         (StatusBubble):
2848         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2849         on hover-over.
2850         (StatusBubble._iso_time):
2851         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2852         hover-over message.
2853         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2854
2855 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2856
2857         [ews-app] Gracefully handle the case when state_string is None
2858         https://bugs.webkit.org/show_bug.cgi?id=195753
2859
2860         Reviewed by Lucas Forschler.
2861
2862         * BuildSlaveSupport/ews-app/ews/models/build.py:
2863         * BuildSlaveSupport/ews-app/ews/models/step.py:
2864
2865 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2866
2867         [ews-app] Status bubble display pending for currently running build step
2868         https://bugs.webkit.org/show_bug.cgi?id=195744
2869
2870         Reviewed by Lucas Forschler.
2871
2872         * BuildSlaveSupport/ews-build/events.py:
2873         (Events.stepStarted): If state_string is pending, replace it with step name.
2874
2875 2019-03-14  Chris Dumez  <cdumez@apple.com>
2876
2877         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2878         https://bugs.webkit.org/show_bug.cgi?id=195750
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         Add API test coverage.
2883
2884         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2885         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2886         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2887         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2888
2889 2019-03-14  Chris Dumez  <cdumez@apple.com>
2890
2891         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2892         https://bugs.webkit.org/show_bug.cgi?id=195747
2893
2894         Reviewed by Geoff Garen.
2895
2896         Add API test coverage.
2897
2898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2899
2900 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2901
2902         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2903         https://bugs.webkit.org/show_bug.cgi?id=195725
2904         <rdar://problem/48545062>
2905
2906         Reviewed by Tim Horton.
2907
2908         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2909         handler is nil.
2910
2911         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2912         (TestWebKitAPI::TEST):
2913
2914 2019-03-13  Sam Weinig  <sam@webkit.org>
2915
2916         Add utility function to allow easy reverse range-based iteration of a container
2917         https://bugs.webkit.org/show_bug.cgi?id=195542
2918
2919         Reviewed by Antti Koivisto.
2920
2921         * TestWebKitAPI/CMakeLists.txt:
2922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2923         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2924         (TestWebKitAPI::TEST):
2925         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2926
2927 2019-03-13  Chris Dumez  <cdumez@apple.com>
2928
2929         Use a ServiceWorker process per registrable domain
2930         https://bugs.webkit.org/show_bug.cgi?id=195649
2931
2932         Reviewed by Youenn Fablet.
2933
2934         Update API test coverage.
2935
2936         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2937
2938 2019-03-13  Chris Dumez  <cdumez@apple.com>
2939
2940         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2941         https://bugs.webkit.org/show_bug.cgi?id=195684
2942         <rdar://problem/48294714>
2943
2944         Reviewed by Antti Koivisto.
2945
2946         Add API test coverage.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2949
2950 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2951
2952         [ews-app] Remove unused patch view
2953         https://bugs.webkit.org/show_bug.cgi?id=195669
2954
2955         Reviewed by Lucas Forschler.
2956
2957         * BuildSlaveSupport/ews-app/ews/urls.py:
2958         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2959
2960 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2961
2962         [ews-app] Use Buildbot result code variables
2963         https://bugs.webkit.org/show_bug.cgi?id=195668
2964
2965         Reviewed by Alexey Proskuryakov.
2966
2967         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2968         (Buildbot): Added Buildbot result code variables.
2969         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2970         (StatusBubble._build_bubble): Used Buildbot result code variables.
2971
2972 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2973
2974         [Flatpak] Expand submodule recursively
2975         https://bugs.webkit.org/show_bug.cgi?id=195672
2976
2977         Building WPE with flatpak was impossible without that as it was raising an exception.
2978         Also update wpebackend-fdo to match what is built in jhbuild
2979
2980         Reviewed by Philippe Normand.
2981
2982         * flatpak/flatpakutils.py:
2983         (expand_submodules_recurse):
2984         (expand_manifest):
2985         * flatpak/org.webkit.WPEModules.yaml:
2986
2987 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-app] status bubble should be hidden for certain builds
2990         https://bugs.webkit.org/show_bug.cgi?id=194597
2991
2992         Reviewed by Dewei Zhu.
2993
2994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2995         (StatusBubble._build_bubble):
2996         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2997         because the patch didn't have relevant changes.
2998         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2999         in production yet.
3000
3001 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3002
3003         [Win] Fix a slew of simple clang-cl warnings.
3004         https://bugs.webkit.org/show_bug.cgi?id=195652
3005
3006         Reviewed by Don Olmstead.
3007
3008         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3009         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3010
3011 2019-03-12  Justin Fan  <justin_fan@apple.com>
3012
3013         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3014         https://bugs.webkit.org/show_bug.cgi?id=195518
3015         <rdar://problem/46322356>
3016
3017         Reviewed by Myles C. Maxfield.
3018
3019         * DumpRenderTree/DerivedSources-input.xcfilelist:
3020         * DumpRenderTree/DerivedSources-output.xcfilelist:
3021
3022 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3023
3024         Unreviewed, rolling out r242825.
3025         https://bugs.webkit.org/show_bug.cgi?id=195648
3026
3027         "Broke webkitpy tests with my change to
3028         lldb_dump_class_layout.py" (Requested by rmorisset on
3029         #webkit).
3030
3031         Reverted changeset:
3032
3033         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3034         classes with suspicious padding"
3035         https://bugs.webkit.org/show_bug.cgi?id=195573
3036         https://trac.webkit.org/changeset/242825
3037
3038 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3039
3040         [ews-build] Show status bubbles while the patch is waiting in queue
3041         https://bugs.webkit.org/show_bug.cgi?id=195618
3042
3043         Reviewed by Lucas Forschler.
3044
3045         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3046         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3047         enabled in initial deployment.
3048         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3049         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3050         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3051         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3052         (StatusBubble._build_bubbles_for_patch):
3053
3054 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3055
3056         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3057         https://bugs.webkit.org/show_bug.cgi?id=195573
3058
3059         Reviewed by Simon Fraser.
3060
3061         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3062
3063         * Scripts/dump-class-layout:
3064         (main):
3065         * lldb/lldb_dump_class_layout.py:
3066         (ClassLayout.__init__):
3067         (ClassLayout._compute_padding_recursive):
3068         (LLDBDebuggerInstance.dump_layout_for_classname):
3069         (LLDBDebuggerInstance):
3070         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3071         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3072
3073 2019-03-12  Chris Dumez  <cdumez@apple.com>
3074
3075         Device Orientation access permission should be denied unless explicitly granted by the client
3076         https://bugs.webkit.org/show_bug.cgi?id=195625
3077
3078         Reviewed by Youenn Fablet.
3079
3080         add API test coverage.
3081
3082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3083         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3084         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3085         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3086         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3087         (runDeviceOrientationTest):
3088         (TEST):
3089         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3090         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3091
3092 2019-03-12  Jer Noble  <jer.noble@apple.com>
3093
3094         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3095         https://bugs.webkit.org/show_bug.cgi?id=195137
3096         <rdar://problem/48810307>
3097
3098         Reviewed by Eric Carlson.
3099
3100         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3101         (TestWebKitAPI::TEST):
3102
3103 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3104
3105         [ews-build] Change urls from uat to production
3106         https://bugs.webkit.org/show_bug.cgi?id=195566
3107
3108         Reviewed by Lucas Forschler.
3109
3110         * BuildSlaveSupport/ews-app/ews/config.py:
3111         * BuildSlaveSupport/ews-build/events.py:
3112         * BuildSlaveSupport/ews-build/steps.py:
3113
3114 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3115
3116         [ews-build] change max_builds for local-worker to 1
3117         https://bugs.webkit.org/show_bug.cgi?id=195568
3118
3119         Reviewed by Lucas Forschler.
3120
3121         * BuildSlaveSupport/ews-build/loadConfig.py:
3122
3123 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3124
3125         Fix the build
3126
3127         * TestRunnerShared/spi/PencilKitTestSPI.h:
3128         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3129
3130 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3131
3132         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3133         https://bugs.webkit.org/show_bug.cgi?id=194131
3134
3135         Reviewed by Michael Catanzaro.
3136
3137         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3138         (uriChanged):
3139         (testUnfinishedSubresourceLoad):
3140         (serverCallback):
3141         (beforeAll):
3142
3143 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3144
3145         WTF::Expected should use std::addressof instead of operator&
3146         https://bugs.webkit.org/show_bug.cgi?id=195604
3147
3148         Reviewed by Myles Maxfield.
3149
3150         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3151         (TestWebKitAPI::Unique::Unique):
3152         (TestWebKitAPI::Unique::operator&):
3153         (TestWebKitAPI::TEST):
3154
3155 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3156
3157         Add Optional to Forward.h.
3158         https://bugs.webkit.org/show_bug.cgi?id=195586
3159
3160         Reviewed by Darin Adler.
3161
3162         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3163         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3164         Remove unnecessary includes from headers.
3165
3166 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3167
3168         Add testing API to hit-test and scroll overflow scrollers
3169         https://bugs.webkit.org/show_bug.cgi?id=195278
3170
3171         Reviewed by Antti Koivisto.
3172         
3173         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3174         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3175         
3176         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3177
3178         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3179         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3180         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3181         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3182         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3183         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3184         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3185         (WTR::enclosingScrollViewIncludingSelf):
3186         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3187
3188 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3189
3190         API test WebKit.RequestTextInputContext fails on iOS
3191         https://bugs.webkit.org/show_bug.cgi?id=195585
3192
3193         Reviewed by Wenson Hsieh and Simon Fraser.
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3196         (applyStyle):
3197         (TEST):
3198         Add a viewport, so that the coordinates match up on iOS.
3199         Scroll by moving the UIScrollView's contentOffset.
3200
3201 2019-03-11  Chris Dumez  <cdumez@apple.com>
3202
3203         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3204         https://bugs.webkit.org/show_bug.cgi?id=195506
3205         <rdar://problem/48733477>
3206
3207         Reviewed by Alex Christensen.
3208
3209         Add API test coverage.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3212
3213 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3214
3215         Adding myself to contributors.json
3216
3217         Unreviewed, addming myself to contributors.json .
3218
3219         * Scripts/webkitpy/common/config/contributors.json:
3220
3221 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3222
3223         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3224         https://bugs.webkit.org/show_bug.cgi?id=195511
3225         <rdar://problem/44873269>
3226
3227         Reviewed by Darin Adler.
3228
3229         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3230         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3231         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3232         (TEST_F):
3233
3234 2019-03-11  Chris Dumez  <cdumez@apple.com>
3235
3236         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3237         https://bugs.webkit.org/show_bug.cgi?id=195561
3238
3239         Reviewed by Youenn Fablet.
3240
3241         Make sure the JS in the test requests for permission to receive device orientation events.
3242
3243         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3244
3245 2019-03-11  Youenn Fablet  <youenn@apple.com>
3246
3247         Allow storage quota increase by default in WTR
3248         https://bugs.webkit.org/show_bug.cgi?id=195541
3249
3250         Reviewed by Geoffrey Garen.
3251
3252         Allow storage quota increase by default in WTR.
3253         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3254         Use this for tests that explicitly need cache increase.
3255
3256         Instead of increasing quota by 2, make sure the next request is
3257         granted by adding all given parameters.
3258
3259         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3261         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3262         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3264         * WebKitTestRunner/TestController.cpp:
3265         (WTR::TestController::setAllowStorageQuotaIncrease):
3266         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3267         * WebKitTestRunner/TestController.h:
3268         * WebKitTestRunner/TestInvocation.cpp:
3269         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3270         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3271         (WTR::TestController::cocoaResetStateToConsistentValues):
3272         (WTR::TestController::setAllowStorageQuotaIncrease):
3273         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3274         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3275         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3276
3277 2019-03-11  Xan Lopez  <xan@igalia.com>
3278
3279         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3280         https://bugs.webkit.org/show_bug.cgi?id=194147
3281
3282         Reviewed by Michael Saboff.
3283
3284         To make --32-bit work correctly on Linux/64bit we need to:
3285
3286         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3287         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3288         unfortunately CMake only allows us to do this during
3289         crosscompilation, which is overkill here.
3290         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3291         pkg-config detection module uses the x86 .pc files instead of the
3292         x86_64 ones.
3293         - Set the -m32 flags for the compiler.
3294
3295         * Scripts/webkitdirs.pm:
3296         (generateBuildSystemFromCMakeProject):
3297
3298 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3299
3300         Add MotionMark-1.1 plan file for run-benchmark script.
3301         https://bugs.webkit.org/show_bug.cgi?id=195481
3302
3303         Rubber-stamped by Darin Adler.
3304
3305         Run-benchmark script should support MontionMark-1.1.
3306
3307         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3308
3309 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3310
3311         [ews-app] Add support for submit-to-ews url
3312         https://bugs.webkit.org/show_bug.cgi?id=195477
3313
3314         Reviewed by Lucas Forschler.
3315
3316         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3317         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3318         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3319         * BuildSlaveSupport/ews-app/ews/urls.py:
3320         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3321
3322 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3323
3324         Unreviewed, rolling out r242688, r242643, r242624.
3325
3326         Caused multiple layout test failures and crashes on iOS and macOS.
3327
3328         Reverted changeset:
3329
3330         "requestAnimationFrame should execute before the next frame"
3331         https://bugs.webkit.org/show_bug.cgi?id=177484
3332         https://trac.webkit.org/changeset/242624/webkit
3333
3334         * Tracing/SystemTracePoints.plist:
3335
3336 2019-03-11  John Wilander  <wilander@apple.com>
3337
3338         Resource Load Statistics: Make it possible exclude localhost from classification
3339         https://bugs.webkit.org/show_bug.cgi?id=195474
3340         <rdar://problem/47520577>
3341
3342         Reviewed by Brent Fulgham.
3343
3344         This patch allows for localhost to be excluded from classification and
3345         treatment as a prevalent resource.
3346
3347         The WebKit Tools change adds a new function called
3348         testRunner.setStatisticsIsRunningTest() which can be used to control this
3349         behavior.
3350
3351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3353         (WTR::TestRunner::setStatisticsIsRunningTest):
3354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3355         * WebKitTestRunner/TestController.cpp:
3356         (WTR::TestController::setStatisticsIsRunningTest):
3357         * WebKitTestRunner/TestController.h:
3358         * WebKitTestRunner/TestInvocation.cpp:
3359         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3360
3361 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3362
3363         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3364         https://bugs.webkit.org/show_bug.cgi?id=195560
3365
3366         Reviewed by Lucas Forschler.
3367
3368         * BuildSlaveSupport/ews-build/master.cfg:
3369
3370 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3371
3372         Unreviewed, rolling out r242698.
3373
3374         API test crashes on bots.
3375
3376         Reverted changeset:
3377
3378         "Add a WKContentRuleList variant that uses copied memory
3379         instead of mmap'd shared memory for class A containerized
3380         apps"
3381         https://bugs.webkit.org/show_bug.cgi?id=195511
3382         https://trac.webkit.org/changeset/242698
3383
3384 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3385
3386         [WPE] Enable web process sandbox
3387         https://bugs.webkit.org/show_bug.cgi?id=195169
3388
3389         Reviewed by Daniel Bates.
3390
3391         * wpe/install-dependencies:
3392         * wpe/jhbuild.modules:
3393
3394 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3395
3396         [ews-app] Use port 17000 for worker communication
3397         https://bugs.webkit.org/show_bug.cgi?id=195558
3398
3399         Reviewed by Lucas Forschler.
3400
3401         * BuildSlaveSupport/ews-build/master.cfg:
3402
3403 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-build] unit-tests fail when passwords.json is missing
3406         https://bugs.webkit.org/show_bug.cgi?id=195557
3407
3408         Reviewed by Lucas Forschler.
3409
3410         * BuildSlaveSupport/ews-build/loadConfig.py:
3411         (loadBuilderConfig):
3412         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3413         (ConfigDotJSONTest.test_configuration):
3414         * BuildSlaveSupport/ews-build/master.cfg:
3415
3416 2019-03-11  Truitt Savell  <tsavell@apple.com>
3417
3418         Unreviewed, rolling out r242702.
3419
3420         Broke High Sierra builders.
3421
3422         Reverted changeset:
3423
3424         "Add utility function to allow easy reverse range-based
3425         iteration of a container"
3426         https://bugs.webkit.org/show_bug.cgi?id=195542
3427         https://trac.webkit.org/changeset/242702
3428
3429 2019-03-11  Sam Weinig  <sam@webkit.org>
3430
3431         Add utility function to allow easy reverse range-based iteration of a container
3432         https://bugs.webkit.org/show_bug.cgi?id=195542
3433
3434         Reviewed by Antti Koivisto.
3435
3436         * TestWebKitAPI/CMakeLists.txt:
3437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3438         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3439         (TestWebKitAPI::TEST):
3440         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3441
3442 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3443
3444         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3445         https://bugs.webkit.org/show_bug.cgi?id=195511
3446         <rdar://problem/44873269>
3447
3448         Reviewed by Darin Adler.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3451         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3452         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3453         (TEST_F):
3454
3455 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3456
3457         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3458         https://bugs.webkit.org/show_bug.cgi?id=195499
3459
3460         Reviewed by Darin Adler.
3461
3462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3463         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3464         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3465         (-[WKWebView synchronouslyFocusTextInputContext:]):
3466         (applyStyle):
3467         (applyIframe):
3468         (TEST):
3469         Add some tests for this SPI.
3470
3471 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3472
3473         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3474         https://bugs.webkit.org/show_bug.cgi?id=181151
3475
3476         Reviewed by Don Olmstead.
3477
3478         * TestWebKitAPI/CMakeLists.txt:
3479         * TestWebKitAPI/PlatformWin.cmake:
3480         Enable TestWTF RunLoop tests in all platforms.
3481
3482         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3483         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3484         (TestWebKitAPI::DerivedOneShotTimer::fired):
3485         (TestWebKitAPI::TEST):
3486         Only a few platforms support nested RunLoop.
3487
3488         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3489         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3490
3491 2019-03-10  David Quesada  <david_quesada@apple.com>
3492
3493         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3494         https://bugs.webkit.org/show_bug.cgi?id=152480
3495
3496         Reviewed by Chris Dumez.
3497
3498         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3499         there are no additional references to the process pool besides the one held by
3500         the download, waits for the download to finish (in the sense that the
3501         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3502         measure, also check that the process pool has been deallocated at the end of the
3503         test. The test wouldn't be meaningful if the process pool were still alive.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3506         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3507         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3508             The download will be canceled because the delegate does not implement the
3509             method to decide the download's destination, so this is where we know the
3510             DownloadProxyMap is done with the DownloadProxy.
3511         (TEST):
3512
3513 2019-03-08  Chris Dumez  <cdumez@apple.com>
3514
3515         Add support for Device Orientation / Motion permission API
3516         https://bugs.webkit.org/show_bug.cgi?id=195329
3517         <rdar://problem/47645367>
3518
3519         Reviewed by Geoffrey Garen.
3520
3521         Add test infrastructure to help test the Device Orientation / Motion permission API.
3522
3523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3525         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3527         * WebKitTestRunner/TestController.cpp:
3528         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3529         (WTR::TestController::createWebViewWithOptions):
3530         (WTR::TestController::resetStateToConsistentValues):
3531         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3532         * WebKitTestRunner/TestController.h:
3533         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3534         * WebKitTestRunner/TestInvocation.cpp:
3535         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3536
3537 2019-03-08  Saam barati  <sbarati@apple.com>
3538
3539         Add a compare-results script to compare benchmark results
3540         https://bugs.webkit.org/show_bug.cgi?id=195486
3541         <rdar://problem/48723397>
3542
3543         Reviewed by Geoffrey Garen.
3544
3545         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3546         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3547         to extend it to learn about our other benchmarks.
3548
3549         * Scripts/compare-results: Added.
3550         (readJSONFile):
3551         (detectJetStream2):
3552         (JetStream2Results):
3553         (detectSpeedometer2):
3554         (Speedometer2Results):
3555         (detectPLT5):
3556         (PLT5Results):
3557         (detectBenchmark):
3558         (biggerIsBetter):
3559         (ttest):
3560         (getOptions):
3561         (main):
3562
3563 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3564
3565         Ensure old tab state is cleared between iterations of run-benchmark
3566         https://bugs.webkit.org/show_bug.cgi?id=195393
3567         <rdar://problem/46885583>
3568
3569         Reviewed by Dewei Zhu.
3570
3571         a) ensure the default to restore state is not set
3572         b) terminate Safari correctly
3573         c) Set the system default to ignore Persistent State in Safari
3574
3575         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3576         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3577         (OSXBrowserDriver.prepare_env): 
3578         (OSXBrowserDriver.restore_env):
3579         (OSXBrowserDriver.close_browsers):
3580         (OSXBrowserDriver._terminate_processes):
3581         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3582         (OSXChromeDriver):
3583         (OSXChromeCanaryDriver):
3584         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3585         (OSXFirefoxDriver):
3586         (OSXFirefoxNightlyDriver):
3587         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3588         (OSXSafariDriver):
3589         (OSXSafariDriver.prepare_env):
3590
3591 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3592
3593         [GTK] Several InputMethodFilter tests are failing
3594         https://bugs.webkit.org/show_bug.cgi?id=195408
3595
3596         Reviewed by Carlos Garcia Campos.
3597
3598         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3599         Regressed in r241751.
3600         Hexadecimal values of keycodes are expressed now in upper letters.
3601         Composited characters should be cast to UTF8 strings.
3602
3603         (TestWebKitAPI::TEST):
3604
3605 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3606
3607         [GTK] Make Tools/gtkdoc python3 compatible
3608         https://bugs.webkit.org/show_bug.cgi?id=195359
3609
3610         Reviewed by Carlos Garcia Campos.
3611
3612         * gtkdoc/generate-gtkdoc:
3613         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3614         work with Python 2 and 3.
3615         (get_gtkdoc_module_paths):
3616         The iteritems() was removed in Python 3, so let's use items() that's
3617         available in Python 2 and 3.
3618         (get_generator_for_config):
3619         * gtkdoc/gtkdoc.py:
3620         (GTKDoc._run_command):
3621         The sys.stdout.write() is expecting str in Python 3 and not bytes
3622         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3623         for passing the bytes there.
3624
3625 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3626
3627         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3628         https://bugs.webkit.org/show_bug.cgi?id=195346
3629         <rdar://problem/48667048>
3630
3631         Unreviewed build fix for clang-cl.
3632
3633         * DumpRenderTree/win/DumpRenderTree.cpp:
3634         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3635
3636 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3637
3638         requestAnimationFrame should execute before the next frame
3639         https://bugs.webkit.org/show_bug.cgi?id=177484
3640
3641         Reviewed by Simon Fraser.
3642
3643         Add trace points for the page RenderingUpdate.
3644
3645         * Tracing/SystemTracePoints.plist:
3646
3647 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3648
3649         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3650         https://bugs.webkit.org/show_bug.cgi?id=195353
3651         <rdar://problem/48626394>
3652
3653         Reviewed by Simon Fraser.
3654
3655         * WebKitTestRunner/ios/TestControllerIOS.mm:
3656         (WTR::TestController::platformResetPreferencesToConsistentValues):
3657
3658 2019-03-07  John Wilander  <wilander@apple.com>
3659
3660         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3661         https://bugs.webkit.org/show_bug.cgi?id=195383
3662         <rdar://problem/48570136>
3663
3664         Reviewed by Brent Fulgham.
3665
3666         This patch adds test infrastructure to purge only script-accessible cookies,
3667         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3668
3669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3671         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3672         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3673         * WebKitTestRunner/TestController.cpp:
3674         (WTR::TestController::statisticsDeleteCookiesForHost):
3675         * WebKitTestRunner/TestController.h:
3676         * WebKitTestRunner/TestInvocation.cpp:
3677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3678
3679 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3680
3681         Unreviewed, rolling out r242354.
3682         https://bugs.webkit.org/show_bug.cgi?id=195402
3683
3684         breaks layout tests in all configurations (Requested by
3685         zdobersek on #webkit).
3686
3687         Reverted changeset:
3688
3689         "[WPE] Enable web process sandbox"
3690         https://bugs.webkit.org/show_bug.cgi?id=195169
3691         https://trac.webkit.org/changeset/242354
3692
3693 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3694
3695         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3696         https://bugs.webkit.org/show_bug.cgi?id=195346
3697
3698         Reviewed by Fujii Hironori.
3699
3700         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3701         (TestWebKitAPI::TEST):
3702         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.