garden-o-matic makes it hard to compare images when scroll bars appear
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-20  Adam Barth  <abarth@webkit.org>
2
3         garden-o-matic makes it hard to compare images when scroll bars appear
4         https://bugs.webkit.org/show_bug.cgi?id=68482
5
6         Reviewed by Eric Seidel.
7
8         Because we autoscale image width, the images rescale if we overflow
9         vertically and get a scrollbar.  That makes it hard to compare two sets
10         of images.  This patch reserves space for the scrollbar so we won't
11         have the layout change.
12
13         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
14
15 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
16
17         Unreviewed, rolling out r95565.
18         http://trac.webkit.org/changeset/95565
19         https://bugs.webkit.org/show_bug.cgi?id=68470
20
21         Broke builds (Requested by andersca on #webkit).
22
23         * MiniBrowser/gtk/BrowserWindow.c:
24         (mouseDidMoveOverElement):
25
26 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
27
28         Get hover'ed element URL from HitTest.
29         
30         mouseDidMoveOverElement now gets the hover'ed element link using
31         WKHitTestResult API's.
32         https://bugs.webkit.org/show_bug.cgi?id=68426
33
34         Reviewed by Anders Carlsson.
35
36         * MiniBrowser/gtk/BrowserWindow.c:
37         (mouseDidMoveOverElement):
38
39 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
40
41         Changelog class should have a method to return all entries
42         https://bugs.webkit.org/show_bug.cgi?id=68399
43         
44         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
45         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
46
47         Reviewed by Ryosuke Niwa.
48
49         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
50         and adapt it to become a generator.
51         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
52
53 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
54
55         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
56         https://bugs.webkit.org/show_bug.cgi?id=51159
57
58         Permit any URL with a local scheme to set a user style sheet. Allow qrc
59         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
60         
61         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
62
63         Reviewed by Kenneth Rohde Christiansen.
64
65         * DumpRenderTree/qt/DumpRenderTree.pro:
66         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
67         * DumpRenderTree/qt/resources/user.css: Added.
68         (body):
69         * WebKitTestRunner/qt/WebKitTestRunner.pro:
70         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
71         * WebKitTestRunner/qt/resources/user.css: Added.
72         (body):
73
74 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
75
76         ChangeLogEntry class should contain a list of touched files
77         https://bugs.webkit.org/show_bug.cgi?id=68115
78
79         Reviewed by Eric Seidel.
80         
81         Add method to return the list of files touched in a ChangeLog entry.
82
83         * Scripts/webkitpy/common/checkout/changelog.py: Add
84         touched_files_regexp and touched_files() method.
85         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
86         unit tests for touched_files() method.
87
88 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
89
90         Unreviewed, rolling out r95526 and r95541.
91         http://trac.webkit.org/changeset/95526
92         http://trac.webkit.org/changeset/95541
93         https://bugs.webkit.org/show_bug.cgi?id=68443
94
95         It broke 6 tests (Requested by ossy_ on #webkit).
96
97         * DumpRenderTree/qt/main.cpp:
98         (main):
99         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
100         (WTR::activateFonts):
101
102 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
103
104         Fix patch and bug numbering in the mocktool simulation code
105         https://bugs.webkit.org/show_bug.cgi?id=68374
106
107         Reviewed by Adam Barth.
108
109         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
110         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
111         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
112         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
113         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
114         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
115         * Scripts/webkitpy/tool/commands/download_unittest.py:
116         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
117         * Scripts/webkitpy/tool/commands/queries_unittest.py:
118         * Scripts/webkitpy/tool/commands/queues_unittest.py:
119         * Scripts/webkitpy/tool/commands/queuestest.py:
120         * Scripts/webkitpy/tool/commands/upload_unittest.py:
121         * Scripts/webkitpy/tool/mocktool.py:
122         * Scripts/webkitpy/tool/steps/steps_unittest.py:
123         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
124
125 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
126
127         [Qt] Don't override default QApplication font for DRT and WTR
128
129         Revision 95526 moved the relevant code below the QApplication
130         constructor, to fix a potential crash, and that made the code
131         take effect, breaking 6 tests.
132
133         We should rely on the QWebSettings to set default fonts, and
134         this QApplication::setFont() is a relic from when we didn't
135         have that option, so we remove the code.
136
137         Reviewed by Csaba Osztrogonác.
138
139         * DumpRenderTree/qt/main.cpp:
140         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
141
142 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
143
144         WebKitTestRunner: Provide usage if run without arguments
145
146         If WTR is run without either one or more filenames, or
147         a '-' to indicate server mode, we don't need to start
148         up the test machinery. Doing so might actually crash,
149         as we'll exit the application immedeatly after anyways.
150
151         Reviewed by Simon Hausmann.
152
153         * WebKitTestRunner/TestController.cpp:
154         (WTR::TestController::initialize):
155
156 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
157
158         [Qt] Don't use QFont before initializing QApplication
159
160         Could potentially result in crash.
161
162         Reviewed by Simon Hausmann.
163
164         * DumpRenderTree/qt/main.cpp:
165         (main):
166
167 2011-09-19  Adam Barth  <abarth@webkit.org>
168
169         Always enable ENABLE(EVENTSOURCE)
170         https://bugs.webkit.org/show_bug.cgi?id=68414
171
172         Reviewed by Eric Seidel.
173
174         * Scripts/build-webkit:
175
176 2011-09-19  David Levin  <levin@chromium.org>
177
178         Sheriffbot rollout should be more intuitive.
179         https://bugs.webkit.org/show_bug.cgi?id=68415
180
181         Reviewed by Adam Barth.
182
183         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
184         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
185           and a few others cases.
186         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
187
188 2011-09-19  David Levin  <levin@chromium.org>
189
190         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
191         https://bugs.webkit.org/show_bug.cgi?id=68391
192
193         Reviewed by Darin Adler.
194
195         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
196         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
197
198 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
199
200         Style checker should not check public Qt WK2 API for parameter_name.
201         https://bugs.webkit.org/show_bug.cgi?id=68359
202
203         Reviewed by Andreas Kling.
204
205         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
206         Add an exception in the style checker to disable the check. Also added the test for it.
207
208         * Scripts/webkitpy/style/checker.py:
209         * Scripts/webkitpy/style/checker_unittest.py:
210
211 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
212
213         GTK DRT leaks memory while comparing history items
214         https://bugs.webkit.org/show_bug.cgi?id=68086
215
216         Reviewed by Martin Robinson.
217         
218         webkit_web_history_item_get_target() returns a g_strdup()'d string,
219         so memory must be freed before compareHistoryItems() returns.
220
221         * DumpRenderTree/gtk/DumpRenderTree.cpp:
222         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
223
224 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
225
226         Buildbot marks a nrwt bot red when tests are missing results
227         https://bugs.webkit.org/show_bug.cgi?id=64812
228
229         Reviewed by Ryosuke Niwa.
230
231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
232         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
233
234 2011-09-19  Jessie Berlin  <jberlin@apple.com>
235
236         Sites that use history pushState or replaceState are recorded in history in Private Browsing
237         mode.
238         https://bugs.webkit.org/show_bug.cgi?id=68208
239
240         Reviewed by Brady Eidson.
241
242         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
243         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
244
245         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
246         (TestWebKitAPI::didNavigateWithNavigationData):
247         This is a context history client callback, so it should not be called when in Private
248         Browsing. Add a call to FAIL().
249         (TestWebKitAPI::didSameDocumentNavigationForFrame):
250         This is a page load client callback that happens after the didNavigateWithNavigationData
251         callback. End the test.
252         (TestWebKitAPI::TEST):
253         Enable Private Browsing and load a page that uses history.pushState.
254
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
256         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
257         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
258         Ditto.
259         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
260         Ditto.
261         * TestWebKitAPI/win/copy-resources.cmd:
262         Ditto.
263
264 2011-09-16  Elliot Poger  <epoger@google.com>
265
266         add non-CG Webkit-Mac builds to flakiness dashboard
267         https://bugs.webkit.org/show_bug.cgi?id=68265
268
269         Reviewed by Adam Barth.
270
271         As Chromium-on-Mac approaches the switchover from Core Graphics to
272         Skia, we need to add the Skia version to the flakiness dashboard.
273
274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
275         * TestResultServer/static-dashboards/builders.js:
276         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
277
278 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
279
280         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
281         https://bugs.webkit.org/show_bug.cgi?id=68071
282
283         Reviewed by Adam Barth.
284
285         * DumpRenderTree/chromium/WebPermissions.cpp:
286         (WebPermissions::allowImage):
287         * DumpRenderTree/chromium/WebPermissions.h:
288
289 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
290
291         update-webkit-chromium should retry the gclient call if it fails once
292         https://bugs.webkit.org/show_bug.cgi?id=68252
293
294         Reviewed by Adam Barth.
295
296         * Scripts/update-webkit-chromium:
297
298 2011-09-16  Rob Buis  <rbuis@rim.com>
299
300         Add Eli's rim address and change the nick.
301
302         * Scripts/webkitpy/common/config/committers.py:
303
304 2011-09-16  Anders Carlsson  <andersca@apple.com>
305
306         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
307         https://bugs.webkit.org/show_bug.cgi?id=68269
308
309         Reviewed by Geoffrey Garen.
310
311         Update client function signatures.
312
313         * MiniBrowser/gtk/BrowserWindow.c:
314         (browserWindowUIClientInit):
315         * MiniBrowser/mac/BrowserWindowController.m:
316         (mouseDidMoveOverElement):
317         (-[BrowserWindowController awakeFromNib]):
318         * MiniBrowser/win/BrowserView.cpp:
319         (BrowserView::create):
320         * WebKitTestRunner/TestController.cpp:
321         (WTR::TestController::createOtherPage):
322         (WTR::TestController::initialize):
323
324 2011-09-16  Anders Carlsson  <andersca@apple.com>
325
326         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
327         https://bugs.webkit.org/show_bug.cgi?id=68266
328
329         Reviewed by John Sullivan.
330
331         * MiniBrowser/mac/BrowserWindowController.m:
332         (mouseDidMoveOverElement):
333
334 2011-09-16  Vincent Scheib  <scheib@chromium.org>
335
336         Add Vincent Scheib to the committers list.
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
341
342         Unreviewed, rolling out r95285.
343         http://trac.webkit.org/changeset/95285
344         https://bugs.webkit.org/show_bug.cgi?id=68247
345
346         It broke a webkitpy test (Requested by ossy on #webkit).
347
348         * Scripts/webkitpy/layout_tests/controllers/manager.py:
349
350 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
351
352         Buildbot marks a nrwt bot red when tests are missing results
353         https://bugs.webkit.org/show_bug.cgi?id=64812
354
355         Reviewed by Dirk Pranke.
356
357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
358
359 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
360
361         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
362         https://bugs.webkit.org/show_bug.cgi?id=68178
363
364         Reviewed by Xan Lopez.
365
366         Add a work-around to enable WebKit2 when using build-webkit.
367
368         * Scripts/webkitdirs.pm:
369         (buildAutotoolsProject): 
370
371 2011-09-15  James Robinson  <jamesr@chromium.org>
372
373         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
374
375         * Scripts/webkitpy/common/config/committers.py:
376
377 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
378
379         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
380         https://bugs.webkit.org/show_bug.cgi?id=68003
381
382         Reviewed by Adam Barth.
383
384         * Scripts/webkitpy/tool/mocktool.py:
385         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
386         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
387
388 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
389
390         Python version check is confusing in test-webkitpy
391         https://bugs.webkit.org/show_bug.cgi?id=68004
392
393         Reviewed by Adam Barth.
394
395         * Scripts/test-webkitpy:
396
397 2011-09-15  Eric Seidel  <eric@webkit.org>
398
399         Reviewed by Adam Barth.
400
401         webkit-patch should be able to find users and add them to bugzilla groups
402         https://bugs.webkit.org/show_bug.cgi?id=63351
403
404         These are both very basic commands.  But it's now possible to find
405         all users matching a regexp, as well as add all users matching a regexp
406         to a set of groups.
407
408         bugzilla.py already knew how to find users (for validate-committer-lists)
409         but now it has the ability to modify the user records.
410
411         I split some of the logic out into a new EditUsersParser class
412         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
413
414         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
415         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
416         * Scripts/webkitpy/tool/commands/__init__.py:
417         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
418         * Scripts/webkitpy/tool/commands/findusers.py: Added.
419
420 2011-09-15  Eric Seidel  <eric@webkit.org>
421
422         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
423         https://bugs.webkit.org/show_bug.cgi?id=68182
424
425         Reviewed by Adam Barth.
426
427         * Scripts/build-webkit:
428         * waf/build/settings.py:
429
430 2011-09-15  Eric Seidel  <eric@webkit.org>
431
432         Unreviewed.  Make contributor email look-up case-insensitive.
433
434         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
435         was missing from committers.py due to case sensitivity.
436
437         This also includes a test expectations update to committers_unittest.py
438         after my previous change.
439
440         * Scripts/webkitpy/common/config/committers.py:
441         * Scripts/webkitpy/common/config/committers_unittest.py:
442         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
443
444 2011-09-15  Eric Seidel  <eric@webkit.org>
445
446         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
447
448         Add a bunch of email aliases to committers.py for regular contributors
449         who are committing using other email addresses than they have listed in the file.
450
451         * Scripts/webkitpy/common/config/committers.py:
452
453 2011-09-15  Eric Seidel  <eric@webkit.org>
454
455         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
456         https://bugs.webkit.org/show_bug.cgi?id=68022
457
458         Reviewed by Ryosuke Niwa.
459
460         * Scripts/build-webkit:
461         * waf/build/settings.py:
462
463 2011-09-15  Anders Carlsson  <andersca@apple.com>
464
465         Fix Mac build by including config.h where needed.
466
467         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
468         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
469         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
470         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
471         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
472         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
473         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
474         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
475         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
476         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
477         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
478         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
479         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
480         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
481         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
482         * TestWebKitAPI/mac/main.mm:
483
484 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
485
486         Let TestWebKitAPI work for chromium
487         https://bugs.webkit.org/show_bug.cgi?id=67756
488
489         Reviewed by Sam Weinig.
490
491         * Scripts/build-api-tests:
492         * Scripts/run-api-tests:
493         (isSupportedPlatform):
494         (runTest):
495         (populateTests):
496         * Scripts/webkitdirs.pm:
497         (determineBaseProductDir):
498         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
499         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
500         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
501         * TestWebKitAPI/InjectedBundleController.cpp:
502         * TestWebKitAPI/InjectedBundleMain.cpp:
503         * TestWebKitAPI/JavaScriptTest.cpp:
504         * TestWebKitAPI/PlatformUtilities.cpp:
505         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
507         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
508         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
509         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
510         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
511         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
512         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
513         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
514         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
515         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
516         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
517         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
518         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
519         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
520         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
521         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
522         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
523         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
524         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
525         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
526         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
527         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
528         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
529         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
530         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
531         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
532         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
533         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
534         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
535         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
536         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
537         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
538         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
539         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
540         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
541         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
542         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
543         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
544         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
545         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
546         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
547         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
548         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
549         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
550         * TestWebKitAPI/TestsController.cpp:
551         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
552         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
553         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
554         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
555         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
556         * TestWebKitAPI/win/main.cpp:
557
558 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
559
560         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
561         https://bugs.webkit.org/show_bug.cgi?id=68145
562
563         This will allow for other classes in DumpRenderTree to reuse this functionality
564
565         Reviewed by David Levin.
566
567         * DumpRenderTree/chromium/TestShell.cpp:
568         (normalizeLayoutTestURLInternal):
569         (dumpHistoryItem):
570         (TestShell::normalizeLayoutTestURL):
571         * DumpRenderTree/chromium/TestShell.h:
572
573 2011-09-14  Ada Chan  <adachan@apple.com>
574
575         Add test for WKBundleFrameCopyWebArchive().
576         https://bugs.webkit.org/show_bug.cgi?id=67857
577
578         Reviewed by Anders Carlsson.
579
580         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
581         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
582         the returned data is a valid webarchive.
583         (TestWebKitAPI::setInjectedBundleClient):
584         (TestWebKitAPI::didFinishLoadForFrame):
585         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
586         injected bundle for the webarchive and check the returned webarchive.
587         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
588         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
589         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
590         the web archive.
591
592         Add files to project.
593         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
594         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
596
597 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
598
599         committers.py should support multiple IRC nicknames
600         https://bugs.webkit.org/show_bug.cgi?id=68110
601
602         Reviewed by Eric Seidel.
603
604         Add multiple IRC nickname support to committers.py
605
606         * Scripts/webkitpy/common/config/committers.py:
607         * Scripts/webkitpy/common/config/committers_unittest.py:
608         * Scripts/webkitpy/tool/bot/irc_command.py:
609         * Scripts/webkitpy/tool/bot/sheriff.py:
610
611 2011-09-14  Jon Lee  <jonlee@apple.com>
612
613         Implement globalFlag for WebKitTestRunner
614         https://bugs.webkit.org/show_bug.cgi?id=68033
615         <rdar://problem/10119204>
616
617         Reviewed by Sam Weinig.
618
619         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
620         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
621         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
622         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
623         (WTR::LayoutTestController::globalFlag): simple getter
624         (WTR::LayoutTestController::setGlobalFlag): simple setter
625
626 2011-09-13  Eric Seidel  <eric@webkit.org>
627
628         Remove ENABLE_SVG_USE as <use> is required by HTML5
629         https://bugs.webkit.org/show_bug.cgi?id=68019
630
631         Reviewed by Ryosuke Niwa.
632
633         * Scripts/build-webkit:
634         * waf/build/settings.py:
635
636 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
637
638         Remove Jan Erik Hanssen (added in my r95078) from the list for now
639         since I can't confirm acceptable his committership.
640
641         * Scripts/webkitpy/common/config/committers.py:
642
643 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
644
645         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
646         https://bugs.webkit.org/show_bug.cgi?id=68066
647
648         Reviewed by Adam Barth.
649
650         * DumpRenderTree/chromium/WebViewHost.cpp:
651         * DumpRenderTree/chromium/WebViewHost.h:
652
653 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
654
655         committers.py is missing some contributors
656         https://bugs.webkit.org/show_bug.cgi?id=68059
657
658         Reviewed by Adam Barth.
659
660         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
661
662         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
663
664         * Scripts/webkitpy/common/config/committers.py:
665
666 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
667
668         Fix webkit python test after r95061.
669
670         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
671
672 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
673
674         Add myself as a contributor. No review needed.
675
676         * Scripts/webkitpy/common/config/committers.py:
677
678 2011-09-13  Adam Barth  <abarth@webkit.org>
679
680         garden-o-matic has unfriendly error messages when the local server is not available
681         https://bugs.webkit.org/show_bug.cgi?id=68042
682
683         Reviewed by Dimitri Glazkov.
684
685         This patch moves us from using alert to showing the error inline in the
686         progress dialog.
687
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
693
694 2011-09-13  Adam Barth  <abarth@webkit.org>
695
696         FailureGrid in garden-o-matic should link to the builder's waterfall page
697         https://bugs.webkit.org/show_bug.cgi?id=68036
698
699         Reviewed by Dimitri Glazkov.
700
701         One of the users in the user study thought the configurations names in
702         the failure grid would link to the underlying bots.  That makes sense,
703         so this patch adds the behavior.
704
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
709
710 2011-09-13  Adam Barth  <abarth@webkit.org>
711
712         garden-o-matic should be able to mark failures as expected
713         https://bugs.webkit.org/show_bug.cgi?id=68027
714
715         Reviewed by Dimitri Glazkov.
716
717         All the back-end infrastructure exists for this operation.  This patch
718         just adds some UI to the front-end and wires that UI up to the back
719         end.  This exact UI will likely need some more polish, but this should
720         be a reasonable first cut.
721
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
727
728 2011-09-13  Adam Barth  <abarth@webkit.org>
729
730         garden-o-matic should tell you about the progress of your rebaseline
731         https://bugs.webkit.org/show_bug.cgi?id=67967
732
733         Reviewed by Dimitri Glazkov.
734
735         This patch adds ui.MessageBox, which is a light wrapper around jQuery
736         UI's dialog widget.  We then use ui.MessageBox to show status messages
737         about in-progress rebaselines.  As each baseline is downloaded, the
738         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
739
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
746
747 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
748
749         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
750         https://bugs.webkit.org/show_bug.cgi?id=68024
751
752         Reviewed by Gustavo Noronha Silva.
753         
754         Using g_list_count() and g_list_nth_data() together on a loop is
755         inneficient since they're both O(n). Iterate over lists in a saner
756         way.
757
758         * DumpRenderTree/gtk/DumpRenderTree.cpp:
759         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
760         iterate on it using g_list_next(). Free the list after done with it.
761         (dumpBackForwardListForWebView): Instead of appending (which is
762         expensive in GLists) history items and then iterating from the tail
763         of the itemsToPrint list, prepend items and walk forwards as usual.
764         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
765         remove the (unneeded) viewList variable.
766
767 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
768
769         Add Eric's IRC nick.
770
771         * Scripts/webkitpy/common/config/committers.py:
772
773 2011-09-13  Anders Carlsson  <andersca@apple.com>
774
775         Disable C++ exceptions when building with clang
776         https://bugs.webkit.org/show_bug.cgi?id=68031
777         <rdar://problem/9556880>
778
779         Reviewed by Mark Rowe.
780
781         * MiniBrowser/Configurations/Base.xcconfig:
782         * TestWebKitAPI/Configurations/Base.xcconfig:
783         * WebKitTestRunner/Configurations/Base.xcconfig:
784
785 2011-09-13  Ojan Vafai  <ojan@chromium.org>
786
787         [chromium] fix flakiness dashboard for chromium interactive tests
788         https://bugs.webkit.org/show_bug.cgi?id=68029
789
790         Reviewed by Tony Chang.
791
792         * TestResultServer/static-dashboards/flakiness_dashboard.html:
793         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
794
795 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
796
797         Add Alice and Aryeh to the list of contributors.
798
799         * Scripts/webkitpy/common/config/committers.py:
800
801 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
802
803         sheriffbot whois should also tell us email addresses
804         https://bugs.webkit.org/show_bug.cgi?id=67975
805
806         Reviewed by Eric Seidel and David Levin.
807
808         Taught sheriffbot how to tell us contributor's email addresses.
809
810         * Scripts/webkitpy/tool/bot/irc_command.py:
811         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
812
813 2011-09-13  Eric Seidel  <eric@webkit.org>
814
815         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
816         https://bugs.webkit.org/show_bug.cgi?id=68018
817
818         Reviewed by Ryosuke Niwa.
819
820         * Scripts/build-webkit:
821         * waf/build/settings.py:
822
823 2011-09-13  Chang Shu  <cshu@webkit.org>
824
825         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
826         https://bugs.webkit.org/show_bug.cgi?id=57515
827
828         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
829         TestController synchronously. The latter then sends simulated event to WebKit2 module,
830         which is synchronous, too.
831
832         Reviewed by Darin Adler.
833
834         * WebKitTestRunner/EventSenderProxy.h: Added.
835         (WTR::EventSenderProxy::EventSenderProxy):
836         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
837         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
838         (WTR::EventSendingController::keyDown):
839         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
840         * WebKitTestRunner/PlatformWebView.h:
841         (WTR::PlatformWebView::platformWindow):
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::TestController):
844         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
845         * WebKitTestRunner/TestController.h:
846         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
847         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
848         (WTR::buildModifierFlags):
849         (WTR::EventSenderProxy::keyDown):
850
851 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
852
853         [EFL] DRT: Add DumpRenderTreeEfl.h
854         https://bugs.webkit.org/show_bug.cgi?id=63993
855
856         Reviewed by Eric Seidel.
857         
858         This header contains some global variables used by EFL's
859         DumpRenderTree implementation.
860
861         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
862         appropriate.
863         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
864
865 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
866
867         [EFL] Send the right key names for PageUp and PageDown.
868         https://bugs.webkit.org/show_bug.cgi?id=67044
869
870         Reviewed by Kenneth Rohde Christiansen.
871
872         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
873         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
874         However, EventSender was sending "Page_Up" and "Page_Down", so tests
875         such as editing/input/page-up-down-scrolls.html were timing out due to
876         the right key down events not being sent.
877
878         * DumpRenderTree/efl/EventSender.cpp:
879         (keyPadNameFromJSValue):
880         (keyNameFromJSValue):
881
882 2011-09-12  Eric Seidel  <eric@webkit.org>
883
884         sheriffbot whois is case sensitive
885         https://bugs.webkit.org/show_bug.cgi?id=67972
886
887         Reviewed by Adam Barth.
888
889         I also fixed a typo in the "More than 5 contributors" message
890         from my previous commit.
891
892         * Scripts/webkitpy/common/config/committers.py:
893         * Scripts/webkitpy/common/config/committers_unittest.py:
894         * Scripts/webkitpy/tool/bot/irc_command.py:
895         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
896
897 2011-09-12  Eric Seidel  <eric@webkit.org>
898
899         sheriffbot whois should be smarter
900         https://bugs.webkit.org/show_bug.cgi?id=67971
901
902         Reviewed by Adam Barth.
903
904         This makes sheriffbot whois basically grep the committers list
905         making it much easier to find a contributor by name.
906
907         Unfortunately the current unittests depend on the real committers.py
908         file, so as we add more eric's to the project, this unittest result will
909         change.  I think that's OK for now.  We'll fix it when it breaks.
910
911         * Scripts/webkitpy/common/config/committers.py:
912         * Scripts/webkitpy/tool/bot/irc_command.py:
913         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
914
915 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
916
917         Unreviewed, rolling out r94976.
918         http://trac.webkit.org/changeset/94976
919         https://bugs.webkit.org/show_bug.cgi?id=67953
920
921         Broke a bunch of security/load& tests (Requested by rniwa on
922         #webkit).
923
924         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
925         (LayoutTestController::pathToLocalResource):
926
927 2011-09-12  Eric Seidel  <eric@webkit.org>
928
929         Rubber-stamped by Adam Barth.
930
931         Remove the "the tree is burning!" warning previously shown
932         when landing patches.  It was a dream.  But it's just noise now.
933
934         Some bots will require a restart to notice the removal of the option
935         so I've left the --ignore-builders option in for now.
936
937         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
938         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
939         * Scripts/webkitpy/tool/commands/download.py:
940         * Scripts/webkitpy/tool/commands/download_unittest.py:
941         * Scripts/webkitpy/tool/commands/queues_unittest.py:
942         * Scripts/webkitpy/tool/steps/__init__.py:
943         * Scripts/webkitpy/tool/steps/commit.py:
944         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
945         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
946
947 2011-09-12  Eric Seidel  <eric@webkit.org>
948
949         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
950         https://bugs.webkit.org/show_bug.cgi?id=65781
951
952         Reviewed by Ryosuke Niwa.
953
954         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
955         to resolve the passed in url relative to the absolute url for the test.
956
957         I believe this is a better approach than the on used in the Qt and Chromium DRT's
958         (which resolves the path relative to the built location of the DRT executable)
959         and we should move this new code into a shared location in a follow-up patch.
960
961         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
962         (LayoutTestController::pathToLocalResource):
963
964 2011-09-12  Eric Seidel  <eric@webkit.org>
965
966         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
967         https://bugs.webkit.org/show_bug.cgi?id=67530
968
969         Reviewed by Adam Barth.
970
971         I believe I've fixed the bug in the original patch which prompted the rollout.
972         The previous patch was using the wrong deadline for the initial read,
973         subtracting time.time() twice from the deadline value.
974
975         * Scripts/webkitpy/layout_tests/port/webkit.py:
976         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
977
978 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
979
980         [Qt][WK2] WebKitTestRunner does not produce crash logs
981         https://bugs.webkit.org/show_bug.cgi?id=67714
982
983         Reviewed by Chang Shu.
984
985         Added a simple way of generating backtrace on crash
986         to the web process. The implementation is similar what
987         we have in DRT. It depends on GNU libc functionality
988         so it is only enabled where we are running in such an environment.
989
990         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
991         (WTR::printBacktrace):
992         (WTR::crashHandler):
993         (WTR::InjectedBundle::platformInitialize):
994
995 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
996
997         Added my IRC nick to the committers file.
998
999         * Scripts/webkitpy/common/config/committers.py:
1000
1001 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1002
1003         The executable allocator makes it difficult to free individual
1004         chunks of executable memory
1005         https://bugs.webkit.org/show_bug.cgi?id=66363
1006
1007         Reviewed by Oliver Hunt.
1008         
1009         Introduced a best-fit, balanced-tree based allocator. The allocator
1010         required a balanced tree that does not allocate memory and that
1011         permits the removal of individual nodes directly (as opposed to by
1012         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1013         Changed all references to executable code to use a reference counted
1014         handle.
1015
1016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1017         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1018         (TestWebKitAPI::TEST_F):
1019         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1020         (TestWebKitAPI::Pair::findExact):
1021         (TestWebKitAPI::Pair::remove):
1022         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1023         (TestWebKitAPI::Pair::assertFoundAndRemove):
1024         (TestWebKitAPI::Pair::assertEqual):
1025         (TestWebKitAPI::Pair::assertSameValuesForKey):
1026         (TestWebKitAPI::Pair::testDriver):
1027         (TestWebKitAPI::TEST_F):
1028
1029 2011-09-10  Andy Estes  <aestes@apple.com>
1030
1031         Move myself from committers_unable_to_review to reviewers_list.
1032
1033         * Scripts/webkitpy/common/config/committers.py:
1034
1035 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1036
1037         [wx] Unreviewed build fix. MSW build fixes.
1038
1039         * DumpRenderTree/config.h:
1040         * waf/build/wxpresets.py:
1041
1042 2011-09-10  Andreas Kling  <kling@webkit.org>
1043
1044         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1045         https://bugs.webkit.org/show_bug.cgi?id=59328
1046
1047         Reviewed by Kenneth Rohde Christiansen.
1048
1049         * MiniBrowser/mac/BrowserWindowController.m:
1050         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1051
1052 2011-09-10  Adam Barth  <abarth@webkit.org>
1053
1054         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1055         and does not have access to notImplemented().
1056
1057         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1058         (openStartupDialog):
1059
1060 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1061
1062         Add a script to create a monolithic script-test
1063         https://bugs.webkit.org/show_bug.cgi?id=67747
1064
1065         Reviewed by Darin Adler.
1066
1067         * Scripts/make-new-script-test: Added.
1068
1069 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1070
1071         Adding myself to the reviewers list.
1072
1073         * Scripts/webkitpy/common/config/committers.py:
1074
1075 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1078         https://bugs.webkit.org/show_bug.cgi?id=67855
1079
1080         Reviewed by Dirk Pranke.
1081
1082         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1083         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1084
1085         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1086
1087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1088
1089 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1090
1091         Add myself to committers.py
1092         https://bugs.webkit.org/show_bug.cgi?id=67853
1093
1094         Reviewed by Darin Adler.
1095
1096         * Scripts/webkitpy/common/config/committers.py:
1097
1098 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1099
1100         [Qt] Remove common.pri
1101         https://bugs.webkit.org/show_bug.cgi?id=67814
1102
1103         Reviewed by Andreas Kling.
1104
1105         * Tools.pro:
1106
1107 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1108
1109         [NRWT] the nrwt check httpd with --no-http option
1110         https://bugs.webkit.org/show_bug.cgi?id=67835
1111
1112         Reviewed by Tony Chang.
1113
1114         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1115         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1116
1117 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1118
1119         [chromium] Implement DRT support for Android.
1120         https://bugs.webkit.org/show_bug.cgi?id=67590
1121
1122         Reviewed by Tony Chang.
1123
1124         Add 2 mechanism to make DRT interaction more robust on Android:
1125         - Send 'QUIT' to DRT to make it stop.
1126         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1127         input commands before it starts.
1128         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1129         and <clocale> for 'LC_ALL' to compile on Android.
1130
1131         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1132         as signal() man page recommends using sigaction().
1133
1134         * DumpRenderTree/DumpRenderTree.gypi:
1135         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1136         (main):
1137         * DumpRenderTree/chromium/LayoutTestController.cpp:
1138         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1139         (AlarmHandler):
1140         (TestShell::waitTestFinished):
1141         (platformInit):
1142         (openStartupDialog):
1143         (checkLayoutTestSystemDependencies):
1144         * DumpRenderTree/chromium/TestShellGtk.cpp:
1145         (AlarmHandler):
1146         (TestShell::waitTestFinished):
1147
1148 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1149
1150         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1151
1152         * waf/build/settings.py:
1153
1154 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1155
1156         Unreviewed, rolling out r94851.
1157         http://trac.webkit.org/changeset/94851
1158         https://bugs.webkit.org/show_bug.cgi?id=67847
1159
1160         It broke a webkitpy test (Requested by ossy on #webkit).
1161
1162         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1163
1164 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1165
1166         [NRWT] the nrwt check httpd with --no-http option
1167         https://bugs.webkit.org/show_bug.cgi?id=67835
1168
1169         Reviewed by Csaba Osztrogonác.
1170
1171         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1172
1173 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1174
1175         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1176         https://bugs.webkit.org/show_bug.cgi?id=67794
1177         <rdar://problem/9892024>
1178         
1179         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1180
1181         Reviewed by Brady Eidson.
1182
1183         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1184         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1185         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1186         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1187             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1188             didPerformServerRedirect.
1189
1190         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1191         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1192             our InjectedBundleTest.
1193         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1194             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1195             the request.
1196         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1197
1198         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1199         
1200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1201         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1202         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1203         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1204
1205 2011-09-08  David Levin  <levin@chromium.org>
1206
1207         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1208         https://bugs.webkit.org/show_bug.cgi?id=67797
1209
1210         Reviewed by Eric Seidel.
1211
1212         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1213         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1214
1215 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1216
1217         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1218         https://bugs.webkit.org/show_bug.cgi?id=67723
1219
1220         Reviewed by Adam Barth.
1221
1222         * DumpRenderTree/chromium/EventSender.h:
1223         * DumpRenderTree/chromium/LayoutTestController.cpp:
1224         (LayoutTestController::LayoutTestController):
1225         (LayoutTestController::enableFixedLayoutMode):
1226         (LayoutTestController::setFixedLayoutSize):
1227         * DumpRenderTree/chromium/LayoutTestController.h:
1228
1229 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1230
1231         Add standalone script that filters the output of build-webkit to be more human-readable
1232         https://bugs.webkit.org/show_bug.cgi?id=44081
1233
1234         Reviewed by Daniel Bates.
1235
1236         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1237         a build script (e.g. build-webkit) and it spits out a prettier version.
1238         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1239         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1240
1241 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1242
1243         Add myself to committers.py                 
1244         https://bugs.webkit.org/show_bug.cgi?id=67696
1245
1246         Reviewed by Kent Tamura.
1247
1248         * Scripts/webkitpy/common/config/committers.py:
1249
1250 2011-09-07  Adam Barth  <abarth@webkit.org>
1251
1252         rebaseline button in garden-o-matic details view should work
1253         https://bugs.webkit.org/show_bug.cgi?id=67738
1254
1255         Reviewed by Dimitri Glazkov.
1256
1257         This patch wires up the rebaseline button in garden-o-matic results
1258         details view.  The button is current per-test, so there isn't a way to
1259         rebaseline individual bots.  This is a place to start.  If we decide we
1260         want per-bot rebaselining, we'll need to think of some better UI.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1266
1267 2011-09-07  Eric Seidel  <eric@webkit.org>
1268
1269         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1270         https://bugs.webkit.org/show_bug.cgi?id=67737
1271
1272         Reviewed by Adam Barth.
1273
1274         I got a little over-eager when deprecating host.port_factory in the previous commit.
1275         Turns out that Host.port_factory was already the "modern" port/factory.py
1276         it was just the Module object.  I un-deprecated the variable, and changed it from
1277         being the module to being an actual PortFactory, passing it a host object.
1278         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1279         when instantiating a new Port object.
1280         This magically fixed the test_rebaseline test, since its now no longer talking
1281         to the real filesystem.
1282
1283         * Scripts/webkitpy/common/host.py:
1284         * Scripts/webkitpy/layout_tests/port/factory.py:
1285         * Scripts/webkitpy/tool/commands/queries.py:
1286         * Scripts/webkitpy/tool/mocktool.py:
1287
1288 2011-09-07  Eric Seidel  <eric@webkit.org>
1289
1290         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1291         https://bugs.webkit.org/show_bug.cgi?id=67734
1292
1293         Reviewed by Adam Barth.
1294
1295         Right now every place that creates a Port object has to be very careful
1296         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1297         The correct fix is for port/factory.py (which creates most port objects)
1298         to know how to pass these in automatically.  However, currently all port/factory.py
1299         functions are free functions instead of being on an object.  This patch
1300         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1301
1302         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1303         pass along the proper scm/user/filesystem to the Port object.
1304
1305         * Scripts/webkitpy/common/host.py:
1306         * Scripts/webkitpy/layout_tests/port/factory.py:
1307         * Scripts/webkitpy/tool/commands/queries.py:
1308         * Scripts/webkitpy/tool/mocktool.py:
1309
1310 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1311
1312         Unreviewed, rolling out r94441.
1313         http://trac.webkit.org/changeset/94441
1314         https://bugs.webkit.org/show_bug.cgi?id=67731
1315
1316         "MacEWSes are backed up due to new machines not able to reach
1317         git.webkit.org.  Disabling tests for now" (Requested by
1318         eseidel2 on #webkit).
1319
1320         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1321
1322 2011-09-07  Elliot Poger  <epoger@google.com>
1323
1324         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1325         https://bugs.webkit.org/show_bug.cgi?id=67324
1326
1327         Reviewed by Dirk Pranke.
1328
1329         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1330         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1331         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1332         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1333         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1334
1335 2011-09-07  Eric Boren  <borenet@gmail.com>
1336
1337         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1338         https://bugs.webkit.org/show_bug.cgi?id=66800
1339
1340         Reviewed by Darin Fisher.
1341
1342         * DumpRenderTree/chromium/EventSender.cpp:
1343         (EventSender::sendCurrentTouchEvent):
1344
1345 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1346
1347         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1348         https://bugs.webkit.org/show_bug.cgi?id=67254
1349
1350         Reviewed by Csaba Osztrogonác.
1351
1352         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1353         derived from the running location of DumpRenderTree binary.
1354
1355         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1356         (LayoutTestController::pathToLocalResource):
1357         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1358
1359 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1360
1361         REGRESSION(r94288) build-webkit doesn't work on Symbian
1362         https://bugs.webkit.org/show_bug.cgi?id=67706
1363
1364         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1365         (buildQMakeProject):
1366
1367 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1368
1369         REGRESSION(r94288) build-webkit doesn't work on Windows
1370         https://bugs.webkit.org/show_bug.cgi?id=67646
1371
1372         Roll back r94655 with a small fix.
1373
1374         * Scripts/webkitdirs.pm:
1375         (buildQMakeProject):
1376
1377 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1378
1379         Unreviewed, rolling out r94635.
1380         http://trac.webkit.org/changeset/94635
1381         https://bugs.webkit.org/show_bug.cgi?id=67704
1382
1383         Linux Touch build is failing to compile this change.
1384         (Requested by loislo on #webkit).
1385
1386         * DumpRenderTree/chromium/EventSender.cpp:
1387         (EventSender::sendCurrentTouchEvent):
1388
1389 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1390
1391         Unreviewed, rolling out r94655.
1392         http://trac.webkit.org/changeset/94655
1393         https://bugs.webkit.org/show_bug.cgi?id=67703
1394
1395         It broke Leopard debug bot (Requested by ossy on #webkit).
1396
1397         * Scripts/webkitdirs.pm:
1398
1399 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1400
1401         REGRESSION(r94288) build-webkit doesn't work on Windows
1402         https://bugs.webkit.org/show_bug.cgi?id=67646
1403
1404         Reviewed by Csaba Osztrogonác.
1405
1406         * Scripts/webkitdirs.pm:
1407
1408 2011-09-06  Eric Boren  <borenet@gmail.com>
1409
1410         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1411         https://bugs.webkit.org/show_bug.cgi?id=66800
1412
1413         Reviewed by Darin Fisher.
1414
1415         * DumpRenderTree/chromium/EventSender.cpp:
1416         (EventSender::sendCurrentTouchEvent):
1417
1418 2011-09-06  Adam Barth  <abarth@webkit.org>
1419
1420         garden-o-matic details view should having working rebaseline and next/previous buttons
1421         https://bugs.webkit.org/show_bug.cgi?id=67659
1422
1423         Reviewed by Dimitri Glazkov.
1424
1425         This patch wires up basic back/forward buttons that let you traverse
1426         through the results we're examining in the details view.  This ended up
1427         being more code than I expected, but I wanted to keep all the state
1428         information in the DOM itself.
1429
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1433
1434 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1435
1436         fix MockFileSystem.glob(), refactor filesystem tests
1437         https://bugs.webkit.org/show_bug.cgi?id=67462
1438
1439         Reviewed by Eric Seidel.
1440
1441         In debugging why my proposed change for MockFileSystem.glob()
1442         in bug 66228 didn't work, I stumbled across two real bugs
1443         that cancelled each other out for the unit tests. I fixed those
1444         (glob shouldn't recurse into subdirs, and we weren't populating
1445         self.dirs from self.files properly).
1446
1447         I have also created a "mixin" class for tests that can be shared
1448         between the real filesystem and the mock filesystem - MockFileSystem
1449         is being used enough it needs its own tests.
1450
1451         * Scripts/webkitpy/common/system/filesystem_mock.py:
1452         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1453         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1454
1455 2011-09-06  Anders Carlsson  <andersca@apple.com>
1456
1457         Move NPAPI headers in bridge to plugins
1458         https://bugs.webkit.org/show_bug.cgi?id=67661
1459
1460         Update forwarding headers.
1461
1462         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1463         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1464
1465 2011-09-06  Tony Chang  <tony@chromium.org>
1466
1467         [chromium] Check in 'build' for compiled binaries first
1468         https://bugs.webkit.org/show_bug.cgi?id=67549
1469
1470         Reviewed by Dirk Pranke.
1471
1472         I'm working on moving the windows build output to a common location
1473         rather than relative to the sln file.  Because of that, we need to
1474         check those build locations first for DumpRenderTree.exe.
1475
1476         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1477
1478 2011-09-06  Adam Barth  <abarth@webkit.org>
1479
1480         Use a hierarchial structure for the garden-o-matic results view
1481         https://bugs.webkit.org/show_bug.cgi?id=67620
1482
1483         Reviewed by Dimitri Glazkov.
1484
1485         This patch re-organizes the results view to use a hierachial structure
1486         for selection.  At the top-level are sections for each test.  Expanding
1487         the test section shows a tab selector for builders.
1488
1489         This structure prepares us for wiring up various actions to this view.
1490
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1492         (.):
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1494         ():
1495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1496         (.):
1497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1499         (.results-view>.toolbar):
1500         (.results-view>.toolbar ul.actions):
1501         (.results-view>.toolbar ul.actions li):
1502         (.results-grid table):
1503         (.results-grid table td, .results-view table th):
1504         (.results-grid table th):
1505         (.results-grid .text-result):
1506         (.results-grid .image-result):
1507
1508 2011-09-06  Adam Barth  <abarth@webkit.org>
1509
1510         garden-o-matic's base.probe generates spam in the JavaScript console
1511         https://bugs.webkit.org/show_bug.cgi?id=67622
1512
1513         Reviewed by Dimitri Glazkov.
1514
1515         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1516         instead of HTMLScriptElement to test whether results exist.  This
1517         reduces the console.log spam and saves bandwidth because we can use a
1518         HEAD request instead of a GET request.
1519
1520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1521
1522 2011-09-05  Adam Barth  <abarth@webkit.org>
1523
1524         Add a tab to garden-o-matic for viewing expected failures
1525         https://bugs.webkit.org/show_bug.cgi?id=67619
1526
1527         Reviewed by Dimitri Glazkov.
1528
1529         This patch adds a basic tab to garden-o-matic that shows all the tests
1530         failing on the bots, including the expected failures.  This patch
1531         mostly involves refactoring existing classes to allow new subclasses.
1532
1533         This view is useful for when gardeners mark tests as expected to fail
1534         and then rebaseline them later.
1535
1536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1543
1544 2011-09-05  Adam Barth  <abarth@webkit.org>
1545
1546         Fix global variable leak in garden-o-matic
1547         https://bugs.webkit.org/show_bug.cgi?id=67617
1548
1549         Reviewed by Dimitri Glazkov.
1550
1551         Caught by running the unit tests with noglobals turned on.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1554
1555 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1556
1557         [Qt][WK2] Add pixel test support
1558         https://bugs.webkit.org/show_bug.cgi?id=66283
1559
1560         Reviewed by Andreas Kling.
1561
1562         Implemented pixel result generation by reusing the logic
1563         that we have in DumpRenderTree.
1564         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1565         (WTR::dumpImage):
1566         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1567
1568 2011-09-04  Robin Dunn  <robin@alldunn.com>
1569
1570         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1571         https://bugs.webkit.org/show_bug.cgi?id=67577
1572
1573         Reviewed by Kevin Ollivier.
1574
1575         * waf/build/settings.py:
1576
1577 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1578
1579         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1580
1581         * waf/build/settings.py:
1582
1583 2011-09-03  Dan Bernstein  <mitz@apple.com>
1584
1585         32-bit build fix.
1586
1587         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1588         (TestWebKitAPI::Util::toSTD):
1589
1590 2011-09-03  Dan Bernstein  <mitz@apple.com>
1591
1592         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1593         https://bugs.webkit.org/show_bug.cgi?id=67559
1594
1595         Reviewed by Darin Adler.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1599         the call to it.
1600         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1602         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1603         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1604         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1605         (TestWebKitAPI::Util::toSTD): Added.
1606
1607 2011-09-03  Adam Barth  <abarth@webkit.org>
1608
1609         garden-o-matic results view should have a better results selector
1610         https://bugs.webkit.org/show_bug.cgi?id=67542
1611
1612         Reviewed by Dimitri Glazkov.
1613
1614         This patch adds a basic grid-based results selector to the results
1615         view.  Currently, this grid just shows how the tests fail on the
1616         various bots.  A future patch will let you select which failure to view
1617         and to mark the failures for rebaselining.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1621           - Add some more basic functions for manipulating dictionaries.
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1625
1626 2011-09-03  Adam Barth  <abarth@webkit.org>
1627
1628         garden-o-matic results view should show Actual and Expected results for text failures
1629         https://bugs.webkit.org/show_bug.cgi?id=67536
1630
1631         Reviewed by Eric Seidel.
1632
1633         In the past, we didn't show actual and expected text results (we just
1634         showed the diff) because we didn't have the awesome six-by-two results
1635         grid.  Now that we do, we can move show these results.
1636
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1639           - Fixed some typos that were preventing these unit tests from running.
1640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1641         (.):
1642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1643           - Report -actual.txt and -expected.txt as possible results URLs.
1644
1645 2011-09-03  Adam Barth  <abarth@webkit.org>
1646
1647         garden-o-matic shows "ghost" failures that are already fixed
1648         https://bugs.webkit.org/show_bug.cgi?id=67535
1649
1650         Reviewed by Eric Seidel.
1651
1652         About 10% of writes fail to stick on test-results.appspot.com.  This
1653         patch causes us to fetch the full_results.json blob directly from
1654         build.chromium.org rather than relying upon AppEngine.
1655
1656         Unforuntately, we still need to get historical information from
1657         AppEngine.  That will take several patches to fix becuase I need to
1658         change the bots to write the full_results.json file to the
1659         build-specific directory in addition to the zip file.
1660
1661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1664
1665 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1666
1667         Unreviewed, rolling out r94458.
1668         http://trac.webkit.org/changeset/94458
1669         https://bugs.webkit.org/show_bug.cgi?id=67558
1670
1671         Caused appcache test to fail on various bots (Requested by
1672         rniwa on #webkit).
1673
1674         * Scripts/webkitpy/layout_tests/port/webkit.py:
1675         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1676
1677 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1678
1679         Unreviewed, rolling out r94453.
1680         http://trac.webkit.org/changeset/94453
1681         https://bugs.webkit.org/show_bug.cgi?id=67557
1682
1683         Caused appcache test to fail on various bots (Requested by
1684         rniwa on #webkit).
1685
1686         * Scripts/webkitpy/layout_tests/port/webkit.py:
1687
1688 2011-09-02  Michael Saboff  <msaboff@apple.com>
1689
1690         Add JSC:RegExp functional tests
1691         https://bugs.webkit.org/show_bug.cgi?id=67339
1692
1693         New perl script to build JavaScriptCore and run the RegExp tests.
1694
1695         Reviewed by Gavin Barraclough.
1696
1697         * Scripts/run-regexp-tests: Added.
1698
1699 2011-09-02  Michael Saboff  <msaboff@apple.com>
1700
1701         Add JSC:RegExp functional tests
1702         https://bugs.webkit.org/show_bug.cgi?id=67339
1703
1704         New perl script to build JavaScriptCore and run the RegExp tests.
1705
1706         Reviewed by Gavin Barraclough.
1707
1708         * Scripts/run-regexp-tests: Added.
1709
1710 2011-09-02  Eric Seidel  <eric@webkit.org>
1711
1712         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1713         https://bugs.webkit.org/show_bug.cgi?id=67530
1714
1715         Unreviewed.  Fixing typo from previous commit.
1716
1717         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1718         which exercises the code I previously made a typo in.
1719
1720         * Scripts/webkitpy/layout_tests/port/webkit.py:
1721         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1722
1723 2011-09-02  Eric Seidel  <eric@webkit.org>
1724
1725         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1726         https://bugs.webkit.org/show_bug.cgi?id=67530
1727
1728         Reviewed by Adam Barth.
1729
1730         No functional change, just reshuffling code.
1731
1732         * Scripts/webkitpy/layout_tests/port/webkit.py:
1733
1734 2011-09-02  Darin Adler  <darin@apple.com>
1735
1736         Added Subversion ignore for .pyc generated files.
1737
1738         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1739         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1740         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1741
1742 2011-09-02  Adam Barth  <abarth@webkit.org>
1743
1744         Enable testing on mac-ews
1745         https://bugs.webkit.org/show_bug.cgi?id=67505
1746
1747         Reviewed by Eric Seidel.
1748
1749         This patch enables testing on the Mac EWS, which should help
1750         contributors not turn the Mac bots red.
1751
1752         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1753
1754 2011-09-01  Beth Dakin  <bdakin@apple.com>
1755
1756         https://bugs.webkit.org/show_bug.cgi?id=67451
1757         Add a test for going back to a cached page after changing the device scale factor
1758
1759         Reviewed by Adam Roben.
1760
1761         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1764         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1765         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1766         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1767         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1768         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1769         (TestWebKitAPI::TEST_F):
1770
1771         Added new function to WebKitAgnosticTest to goBack. Separated 
1772         waitForLoadToFinish() into its own function (instead of being a part of 
1773         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1774         well. Also added initializeView() so we can set the cache model.
1775         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1776         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1777         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1778         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1779         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1780         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1781         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1782         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1783         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1784
1785 2011-09-02  Anders Carlsson  <andersca@apple.com>
1786
1787         Build fix.
1788
1789         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1790         (PrivateBrowsing::ScriptableObject::pluginTest):
1791
1792 2011-09-02  Anders Carlsson  <andersca@apple.com>
1793
1794         Move private browsing test to a PluginTest subclass
1795         https://bugs.webkit.org/show_bug.cgi?id=67498
1796
1797         Reviewed by Darin Adler.
1798
1799         * DumpRenderTree/DumpRenderTree.gypi:
1800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1801         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1802         (pluginGetProperty):
1803         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1804         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1805         (PluginTest::NPP_SetValue):
1806         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1807         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1808         (PrivateBrowsing::PrivateBrowsing):
1809         (PrivateBrowsing::privateBrowsingEnabled):
1810         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1811         (PrivateBrowsing::ScriptableObject::hasProperty):
1812         (PrivateBrowsing::ScriptableObject::getProperty):
1813         (PrivateBrowsing::ScriptableObject::pluginTest):
1814         (PrivateBrowsing::NPP_New):
1815         (PrivateBrowsing::NPP_GetValue):
1816         (PrivateBrowsing::NPP_SetValue):
1817         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1818         (NPP_New):
1819         (NPP_SetValue):
1820         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1821         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1822         * GNUmakefile.am:
1823
1824 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1825
1826         [Qt] Build dependency problems
1827         https://bugs.webkit.org/show_bug.cgi?id=38054
1828
1829         Trivial fix after r94288.
1830
1831         Rubber-stamped by Andras Becsi.
1832
1833         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1834         (buildQMakeProject):
1835
1836 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1837
1838         Remove my old e-mail address and add my new one.
1839
1840         Rubber-stamped by Tor Arne Vestbø.
1841
1842         * Scripts/webkitpy/common/config/committers.py:
1843
1844 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1845
1846         [GTK] run-gtk-tests leaves a zombie Xvfb process
1847         https://bugs.webkit.org/show_bug.cgi?id=67389
1848
1849         Reviewed by Martin Robinson.
1850
1851         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
1852         child process instead of doing shell redirection.
1853
1854 2011-09-01  Mark Rowe  <mrowe@apple.com>
1855
1856         Fix the build by adding some more missing return types.
1857
1858         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1859         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1860
1861 2011-09-01  Eric Seidel  <eric@webkit.org>
1862
1863         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
1864         https://bugs.webkit.org/show_bug.cgi?id=66228
1865
1866         Reviewed by Dirk Pranke.
1867
1868         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
1869         The LeaksViewer tool globs for all *-leaks.txt files.
1870         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
1871
1872         In order to test this I had to fix a limitation in our MockFileSystem.glob
1873         method.  However, doing so uncovered a typo and bug in the integration tests.
1874         I've disabled the offending integration tests.
1875
1876         * Scripts/webkitpy/common/system/filesystem_mock.py:
1877         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1878         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1879
1880 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
1881
1882         Adds a LayoutTestController method to make it possible to test
1883         starting speech input via an API call.
1884         https://bugs.webkit.org/show_bug.cgi?id=60170
1885
1886         Reviewed by Dimitri Glazkov.
1887
1888         * DumpRenderTree/LayoutTestController.h:
1889         * DumpRenderTree/chromium/LayoutTestController.cpp:
1890         (LayoutTestController::LayoutTestController):
1891         (LayoutTestController::startSpeechInput):
1892         * DumpRenderTree/chromium/LayoutTestController.h:
1893         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1894         (LayoutTestController::startSpeechInput):
1895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1896         (LayoutTestController::startSpeechInput):
1897         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1898         (LayoutTestController::startSpeechInput):
1899         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1900         (LayoutTestController::startSpeechInput):
1901         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1902         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1903         (LayoutTestController::startSpeechInput):
1904         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1905         (LayoutTestController::startSpeechInput):
1906
1907 2011-09-01  Tim Horton  <hortont424@gmail.com>
1908
1909         Fix TestWebKitAPI build on clang-2.0
1910
1911         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1912
1913 2011-09-01  Adam Barth  <abarth@webkit.org>
1914
1915         Remove unused "extension" parameter from rebaseline gardeningserver handler
1916         https://bugs.webkit.org/show_bug.cgi?id=67384
1917
1918         Reviewed by James Robinson.
1919
1920         This parameter hasn't done anything in a while.
1921
1922         * Scripts/webkitpy/tool/commands/rebaseline.py:
1923         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1924         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1925
1926 2011-09-01  Eric Seidel  <eric@webkit.org>
1927
1928         Unreviewed.
1929
1930         Fix a typo in unittests.  Unfortunately fixing it
1931         caused several assertions.  Just disabling the test
1932         instead, since it was providing no value before due to the typo.
1933
1934         * Scripts/webkitpy/layout_tests/port/test.py:
1935
1936 2011-09-01  Adam Barth  <abarth@webkit.org>
1937
1938         Add a "rebaseline" button to the garden-o-matic summary page
1939         https://bugs.webkit.org/show_bug.cgi?id=67382
1940
1941         Reviewed by Dimitri Glazkov.
1942
1943         As much as we might wish folks to not rebaseline entire test groups at
1944         once, the truth is that doing so is a common operation.  Adding a
1945         button for this operation is likely to make folks happy.
1946
1947         This patch also cleans up a bunch of plumbing surrounding failureInfo
1948         objects.
1949
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1960
1961 2011-09-01  Adam Barth  <abarth@webkit.org>
1962
1963         garden-o-matic should let the gardener assign blame for a group of test failures
1964         https://bugs.webkit.org/show_bug.cgi?id=67379
1965
1966         Reviewed by Dimitri Glazkov.
1967
1968         If a group of test failures has a large revision range, the gardener
1969         might wish to blame a specific revision for the failure.  Currently,
1970         this only effect of assigning blame in this way is to hide the other
1971         suspect commits.
1972
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1976
1977 2011-09-01  Adam Barth  <abarth@webkit.org>
1978
1979         Hide garden-o-matic failure table until hover
1980         https://bugs.webkit.org/show_bug.cgi?id=67376
1981
1982         Reviewed by Dimitri Glazkov.
1983
1984         This patch removes the failure table for build failures (because it
1985         does not make sense) and hides the failure table for test groups until
1986         the user hovers over the test failure block, reducing visual noise.
1987
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1991
1992 2011-09-01  Adam Barth  <abarth@webkit.org>
1993
1994         Switch garden-o-matic from commitData.title to commitData.summary
1995         https://bugs.webkit.org/show_bug.cgi?id=67375
1996
1997         Reviewed by Dimitri Glazkov.
1998
1999         commitData.title is a string provided by Trac, which isn't great in all
2000         cases.  commitData.summary is my attempt to find the most important
2001         one-line summary of the commit.  This patch switches garden-o-matic
2002         over to summary.
2003
2004         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2005         and reduce visual noise.
2006
2007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2010
2011 2011-09-01  Adam Barth  <abarth@webkit.org>
2012
2013         Group failing tests in garden-o-matic if there are more than three in a folder
2014         https://bugs.webkit.org/show_bug.cgi?id=67373
2015
2016         Reviewed by Dimitri Glazkov.
2017
2018         Sometimes a failure will cause many tests in a given directory to fail.
2019         When that happens, it's better to list the directory as a single item
2020         (with a count) rather than spamming all the test names.
2021
2022         (This patch also updates a bunch of unit test expected results after my last commit.)
2023
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2029
2030 2011-09-01  Adam Barth  <abarth@webkit.org>
2031
2032         Lower the visual noise from the failing builders display
2033         https://bugs.webkit.org/show_bug.cgi?id=67369
2034
2035         Reviewed by Dimitri Glazkov.
2036
2037         This patch ensures that the "Building" row in the failing builders
2038         display is always last and dims it by 50% to reduce visual noise.  This
2039         lets the gardener focus on the actual failures.
2040
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2044
2045 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2046
2047         [Qt] Build dependency problems
2048         https://bugs.webkit.org/show_bug.cgi?id=38054
2049
2050         Make clean build after the defines are changed.
2051
2052         Reviewed by Csaba Osztrogonác.
2053
2054         * Scripts/webkitdirs.pm:
2055         (buildQMakeProject):
2056
2057 2011-08-31  Adam Barth  <abarth@webkit.org>
2058
2059         Move DumpRenderTree to WebKitPlatformSupport
2060         https://bugs.webkit.org/show_bug.cgi?id=67331
2061
2062         Reviewed by Darin Fisher.
2063
2064         This patch update DumpRenderTree to account for the WebKitClient =>
2065         WebKitPlatformSupport rename.
2066
2067         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2068         (NotificationPresenter::show):
2069         * DumpRenderTree/chromium/Task.cpp:
2070         (postTask):
2071
2072 2011-08-31  Eric Seidel  <eric@webkit.org>
2073
2074         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2075         https://bugs.webkit.org/show_bug.cgi?id=67314
2076
2077         Reviewed by Adam Barth.
2078
2079         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2080         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2081         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2082
2083         I also moved a bunch of code into dashboard.css which belonged there.
2084
2085         * QueueStatusServer/handlers/activebots.py: Added.
2086         * QueueStatusServer/main.py:
2087         * QueueStatusServer/stylesheets/dashboard.css:
2088         (.queue_bubble):
2089         (.queue_name):
2090         (.last_heard_from):
2091         (.status_text):
2092         (.alive):
2093         (.behind):
2094         (.dead):
2095         * QueueStatusServer/templates/activebots.html: Added.
2096         * QueueStatusServer/templates/dashboard.html:
2097         * QueueStatusServer/templates/recentstatus.html:
2098
2099 2011-08-31  Oliver Hunt  <oliver@apple.com>
2100
2101         Move CheckedArithmeticOperations.cpp to the intended location
2102
2103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2104         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2105
2106 2011-08-31  Elliot Poger  <epoger@google.com>
2107
2108         add unittest to validate the complete set of Chromium configurations
2109         https://bugs.webkit.org/show_bug.cgi?id=67211
2110
2111         Reviewed by Adam Barth.
2112
2113         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2114
2115 2011-08-31  Nico Weber  <thakis@chromium.org>
2116
2117         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2118         https://bugs.webkit.org/show_bug.cgi?id=67297
2119
2120         Reviewed by Tony Chang.
2121
2122         Explicitly disable smooth scrolling in chromium's DRT.
2123
2124         * DumpRenderTree/chromium/WebPreferences.cpp:
2125         (WebPreferences::applyTo):
2126
2127 2011-08-31  Oliver Hunt  <oliver@apple.com>
2128
2129         Add Checked<> tests to windows build
2130
2131         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2132
2133 2011-08-30  Oliver Hunt  <oliver@apple.com>
2134
2135         Add support for checked arithmetic
2136         https://bugs.webkit.org/show_bug.cgi?id=67095
2137
2138         Reviewed by Sam Weinig.
2139
2140         Add test cases for Checked<>
2141
2142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2143         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2144
2145 2011-08-31  Adam Barth  <abarth@webkit.org>
2146
2147         Move summary.html to garden-o-matic.html.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2153
2154 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2155
2156         [chromium] DRT linux should pass nativeKeyCode to plugins
2157         https://bugs.webkit.org/show_bug.cgi?id=66679
2158
2159         Reviewed by Tony Chang.
2160
2161         * DumpRenderTree/chromium/EventSender.cpp:
2162         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2163         (simulated) nativeKeyCode for the given input keyboard code.
2164
2165 2011-08-31  Adam Barth  <abarth@webkit.org>
2166
2167         Tighen up UI for garden-o-matic tab strip
2168         https://bugs.webkit.org/show_bug.cgi?id=67266
2169
2170         Reviewed by Dimitri Glazkov.
2171
2172         This patch add CSS to move the tab strip to the edges of the page and
2173         to remove some gratuitous border-radius.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2177
2178 2011-08-31  Adam Barth  <abarth@webkit.org>
2179
2180         garden-o-matic results view shouldn't be horrifically ugly
2181         https://bugs.webkit.org/show_bug.cgi?id=67264
2182
2183         Reviewed by Dimitri Glazkov.
2184
2185         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2190
2191 2011-08-31  Adam Barth  <abarth@webkit.org>
2192
2193         garden-o-matic needs a tabstrip
2194         https://bugs.webkit.org/show_bug.cgi?id=67263
2195
2196         Reviewed by Dimitri Glazkov.
2197
2198         This patch adds a basic tabstrip to garden-o-matic.  The results
2199         details view now opens in the "Results" tab, and the user can flip back
2200         and forth between the Summary and the Results tab quickly.  There's
2201         also a stub for a "Commits" tab, which is disabled.
2202
2203         This patch isn't the most beautiful in the world, but it gets the ball
2204         rolling on a multi-modal UI.
2205
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2211
2212 2011-08-31  Ai Makabi  <makabi@google.com>
2213
2214         Extract reference links from reftest test file.
2215         https://bugs.webkit.org/show_bug.cgi?id=66838
2216
2217         Reviewed by Shinichiro Hamaji.
2218
2219         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2220         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2221         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2222
2223 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2224
2225         [webkitpy] missing log import in common/net/resultsjsonparser.py
2226         https://bugs.webkit.org/show_bug.cgi?id=65606
2227
2228         Reviewed by Martin Robinson.
2229
2230         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2231
2232 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2233
2234         [stylechecker] complains about NULL usage in some gst_structure_ calls
2235         https://bugs.webkit.org/show_bug.cgi?id=67194
2236
2237         Reviewed by Martin Robinson.
2238
2239         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2240         used for these, a proper sentinel is required.
2241
2242         * Scripts/webkitpy/style/checkers/cpp.py:
2243         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2244
2245 2011-08-30  Adam Barth  <abarth@webkit.org>
2246
2247         Remove old-style UI from garden-o-matic
2248         https://bugs.webkit.org/show_bug.cgi?id=67257
2249
2250         Reviewed by Dimitri Glazkov.
2251
2252         This code is nowhere near as awesome as the new hotness.  Let's remove
2253         it so it doesn't weigh us down.
2254
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2261
2262 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2263
2264         [WebSocket] update pywebsocket to 0.6b5.
2265         https://bugs.webkit.org/show_bug.cgi?id=66924
2266
2267         Reviewed by Kent Tamura.
2268
2269         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2270         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2271         0.6b3 or later supports a closing handshake handler and it is useful to
2272         verify client's closing handshake implementation.
2273         0.6b4 supports AbortedByUserException. It is useful to eliminate
2274         unnecessary server warning messages on intended abnormal closures.
2275         0.6b5 supports Python 2.5.1 or Mac 10.5.
2276
2277         * Scripts/webkitpy/thirdparty/__init__.py:
2278         Update download URL and directory path.
2279
2280 2011-08-30  Dan Bernstein  <mitz@apple.com>
2281
2282         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2283         https://bugs.webkit.org/show_bug.cgi?id=67230
2284
2285         Reviewed by Darin Adler.
2286
2287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2288         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2289         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2290         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2291         (TestWebKitAPI::TEST):
2292
2293 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2294
2295         Add MediaSource API to HTMLMediaElement
2296         https://bugs.webkit.org/show_bug.cgi?id=64731
2297
2298         Reviewed by Eric Carlson.
2299
2300         * Scripts/build-webkit:
2301
2302 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2303
2304         Emit last progress notification before calling dispatchDidFinishLoad
2305         https://bugs.webkit.org/show_bug.cgi?id=28851
2306
2307         Reviewed by Adam Barth.
2308
2309         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2310         Chromium and GTK ports. The first two were simple changes.
2311
2312         Some refactoring was needed in GTK port to assure that the dumps are emitted
2313         correctly and the processing after the page load finished is in the right place.
2314
2315         To detect the load finished, we use the callback for the "load-status" notifier
2316         signal of the top loading frame. And we use the deprecated "load-finished" signal
2317         for dumping (if enabled) the progress finished expected output.
2318
2319         * DumpRenderTree/LayoutTestController.cpp:
2320         (LayoutTestController::LayoutTestController):
2321         (dumpProgressFinishedCallbackCallback):
2322         (LayoutTestController::staticFunctions):
2323         * DumpRenderTree/LayoutTestController.h:
2324         (LayoutTestController::dumpProgressFinishedCallback):
2325         (LayoutTestController::setDumpProgressFinishedCallback):
2326         * DumpRenderTree/chromium/LayoutTestController.cpp:
2327         (LayoutTestController::LayoutTestController):
2328         (LayoutTestController::dumpProgressFinishedCallback):
2329         (LayoutTestController::reset):
2330         * DumpRenderTree/chromium/LayoutTestController.h:
2331         (LayoutTestController::shouldDumpProgressFinishedCallback):
2332         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2333         * DumpRenderTree/chromium/WebViewHost.cpp:
2334         (WebViewHost::didStopLoading):
2335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2336         (webViewLoadFinished):
2337         (topLoadingFrameLoadFinished):
2338         (webFrameLoadStatusNotified):
2339         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2340         (LayoutTestController::reset):
2341         (LayoutTestController::dumpProgressFinishedCallback):
2342         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2343
2344 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2345
2346         JavaScriptCore does not have a good mechanism for performance
2347         regression testing
2348         https://bugs.webkit.org/show_bug.cgi?id=67177
2349
2350         Reviewed by Darin Adler.
2351         
2352         Added a new script, which allows for testing one, two, or more VMs
2353         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2354         are interleaved at random to minimize systematics.  The results
2355         that bencher prints includes all possible relevant information about
2356         how bencher was invoked.  Bencher can be easily used to measure
2357         performance changes down to fractions of a percent.
2358         
2359         Bencher also includes experimental support for running benchmarks in
2360         a DumpRenderTree release build.  This works in SunSpider and V8, but
2361         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2362         closely mimics the performance when running in browser.
2363
2364         * Scripts/bencher: Added.
2365
2366 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2367
2368         DumpRenderTree should begin each test with an empty cookie store
2369         https://bugs.webkit.org/show_bug.cgi?id=63545
2370         <rdar://problem/5666907>
2371
2372         Reviewed by Darin Adler.
2373
2374         * DumpRenderTree/mac/DumpRenderTree.mm:
2375         (resetDefaultsToConsistentValues):
2376         (setDefaultsToConsistentValuesForTesting):
2377         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2378         (LayoutTestController::setAlwaysAcceptCookies):
2379         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2380         (WTR::InjectedBundle::beginTesting):
2381         Use new SPIs to manipulate sessions.
2382
2383 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2384
2385         Unreviewed, rolling out r94055 and r94057.
2386         http://trac.webkit.org/changeset/94055
2387         http://trac.webkit.org/changeset/94057
2388         https://bugs.webkit.org/show_bug.cgi?id=67191
2389
2390         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2391
2392         * Scripts/webkitpy/thirdparty/__init__.py:
2393
2394 2011-08-30  Adam Barth  <abarth@webkit.org>
2395
2396         Chromium Android should not be a core builder
2397         https://bugs.webkit.org/show_bug.cgi?id=67184
2398
2399         Reviewed by Ryosuke Niwa.
2400
2401         This bot hasn't been consistently green yet because it has never actually run!
2402
2403         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2404         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2405
2406 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2407
2408         [WebSocket] update pywebsocket to 0.6b4.
2409         https://bugs.webkit.org/show_bug.cgi?id=66924
2410
2411         Reviewed by Kent Tamura.
2412
2413         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2414         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2415         0.6b3 or later supports a closing handshake handler and it is useful to
2416         verify client's closing handshake implementation.
2417         0.6b4 supports AbortedByUserException. It is useful to eliminate
2418         unnecessary server warning messages on intended abnormal closures.
2419
2420         * Scripts/webkitpy/thirdparty/__init__.py:
2421         Update download URL and directory path.
2422
2423 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2424
2425         sheriffbot "usage" help statements are wrong
2426         https://bugs.webkit.org/show_bug.cgi?id=67170
2427
2428         Reviewed by Adam Barth.
2429
2430         * Scripts/webkitpy/tool/bot/irc_command.py:
2431         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2432         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2433
2434 2011-08-29  Adam Barth  <abarth@webkit.org>
2435
2436         Add support for chomium-mac (non-CoreGraphics) baselines
2437         https://bugs.webkit.org/show_bug.cgi?id=67163
2438
2439         Reviewed by Eric Seidel.
2440
2441         This patch teaches the non-CG chromium-mac bots to look at non-CG
2442         baselines.  However, the patch still leaves CG as the default set of
2443         baselines.
2444
2445         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2446         * Scripts/webkitpy/common/config/build.py:
2447         * Scripts/webkitpy/common/config/build_unittest.py:
2448         * Scripts/webkitpy/layout_tests/port/builders.py:
2449         * Scripts/webkitpy/layout_tests/port/chromium.py:
2450         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2451         * Scripts/webkitpy/layout_tests/port/factory.py:
2452         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2453         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2454         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2455         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2456
2457 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2458
2459         Small fix in chromium port of new-run-webkit-tests.
2460         https://bugs.webkit.org/show_bug.cgi?id=67078
2461
2462         Reviewed by Dirk Pranke.
2463
2464         * Scripts/webkitpy/layout_tests/port/chromium.py:
2465
2466 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2467
2468         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2469         r93999.
2470         http://trac.webkit.org/changeset/93987
2471         http://trac.webkit.org/changeset/93992
2472         http://trac.webkit.org/changeset/93995
2473         http://trac.webkit.org/changeset/93998
2474         http://trac.webkit.org/changeset/93999
2475         https://bugs.webkit.org/show_bug.cgi?id=67147
2476
2477         Many failing tests (Requested by ap on #webkit).
2478
2479         * DumpRenderTree/mac/DumpRenderTree.mm:
2480         (setDefaultsToConsistentValuesForTesting):
2481         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2482         (WTR::InjectedBundle::beginTesting):
2483
2484 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2485
2486         DumpRenderTree should begin each test with an empty cookie store
2487         https://bugs.webkit.org/show_bug.cgi?id=63545
2488         <rdar://problem/5666907>
2489
2490         Reviewed by Darin Adler.
2491
2492         * DumpRenderTree/mac/DumpRenderTree.mm:
2493         (setDefaultsToConsistentValuesForTesting):
2494         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2495         (WTR::InjectedBundle::beginTesting):
2496         Tell WebCore to use a temporary session, starting with a clean cookie store.
2497
2498 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2499
2500         [mac] requestAnimationFrame support for mac port
2501         https://bugs.webkit.org/show_bug.cgi?id=59146
2502
2503         Reviewed by Simon Fraser.
2504
2505         Add support for request-animation-callback flag
2506
2507         * Scripts/build-webkit:
2508
2509 2011-08-27  Peter Beverloo  <peter@chromium.org>
2510
2511         Add a build bot for Chromium with OS(ANDROID)
2512         https://bugs.webkit.org/show_bug.cgi?id=66687
2513
2514         Reviewed by Adam Barth.
2515
2516         * BuildSlaveSupport/build.webkit.org-config/config.json:
2517
2518 2011-08-27  Peter Beverloo  <peter@chromium.org>
2519
2520         Update the master build bot configuration script to properly
2521         deal with the --chromium-android switch.
2522         https://bugs.webkit.org/show_bug.cgi?id=66687
2523
2524         The --chromium-android switch is needed when running
2525         update-webkit-chromium and build-webkit, as it'll tell the
2526         scripts to pull in the right dependencies and cross-compile
2527         WebKit using the Android NDK.
2528
2529         Reviewed by Adam Barth.
2530
2531         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2532
2533 2011-08-27  Peter Beverloo  <peter@chromium.org>
2534
2535         Teach the update and build scripts how to handle dependencies
2536         and cross-compiling rules for the Chromium port on OS(ANDROID).
2537         https://bugs.webkit.org/show_bug.cgi?id=66687
2538
2539         Reviewed by Adam Barth.
2540
2541         * Scripts/build-webkit:
2542         * Scripts/update-webkit:
2543         * Scripts/update-webkit-chromium:
2544         * Scripts/webkitdirs.pm:
2545         (argumentsForConfiguration):
2546         (isChromium):
2547         (isChromiumAndroid):
2548         (determineIsChromiumAndroid):
2549         (buildChromium):
2550
2551 2011-08-26  Adam Barth  <abarth@webkit.org>
2552
2553         garden-o-matic should let me know that I need to run the local server
2554         https://bugs.webkit.org/show_bug.cgi?id=66985
2555
2556         Reviewed by Dimitri Glazkov.
2557
2558         The patch triggers an alert dialog whenever the user tries to use a
2559         feature that requires the local server.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2564
2565 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2566
2567         garden-o-matic summary view should have pretty commit data information.
2568         https://bugs.webkit.org/show_bug.cgi?id=67069
2569
2570         Reviewed by Adam Barth.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2576
2577 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2578
2579         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2580         https://bugs.webkit.org/show_bug.cgi?id=67066
2581
2582         Reviewed by Adam Barth.
2583
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2586
2587 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2588
2589         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2590         https://bugs.webkit.org/show_bug.cgi?id=67041
2591
2592         Reviewed by Martin Robinson.
2593
2594         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2595         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2596         when the GTK+ port was being built.
2597
2598         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2599
2600 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2601
2602         Clean up and line up layout in garden-o-matic summary view.
2603         https://bugs.webkit.org/show_bug.cgi?id=67057
2604
2605         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2606         2) Rearranged DOM structure a bit to accommodate recent changes;
2607         3) Added minimal CSS to line things up.
2608
2609         Reviewed by Adam Barth.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2621
2622 2011-08-26  Alice Liu  <alice.liu@apple.com>
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=66823
2625         Add the request info to the WebPageProxy::CreateNewPage message
2626
2627         Reviewed by Anders Carlsson.
2628
2629         Update function declarations with additional parameter:
2630         * MiniBrowser/gtk/BrowserWindow.c:
2631         (createNewPage):
2632         * MiniBrowser/mac/BrowserWindowController.m:
2633         (createNewPage):
2634         * MiniBrowser/win/BrowserView.cpp:
2635         (createNewPage):
2636         * WebKitTestRunner/TestController.cpp:
2637         (WTR::TestController::createOtherPage):
2638         * WebKitTestRunner/TestController.h:
2639
2640 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2641
2642         Make show-pretty-diff work on linux
2643         https://bugs.webkit.org/show_bug.cgi?id=67017
2644
2645         Reviewed by Adam Barth.
2646
2647         * Scripts/show-pretty-diff:
2648
2649 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2650
2651         Reorganize garden-o-matic CSS files to match JS-built views.
2652         https://bugs.webkit.org/show_bug.cgi?id=66998
2653
2654         Reviewed by Adam Barth.
2655
2656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2662
2663 2011-08-25  Adam Barth  <abarth@webkit.org>
2664
2665         garden-o-matic should be able to roll out patches
2666         https://bugs.webkit.org/show_bug.cgi?id=66982
2667
2668         Reviewed by Dimitri Glazkov.
2669
2670         This patch just wires the rollout event through the controller to the
2671         local server, which is already set up to perform rollouts.
2672
2673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2677
2678 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2679
2680         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2681         https://bugs.webkit.org/show_bug.cgi?id=66951
2682
2683         Reviewed by Andreas Kling.
2684
2685         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2686         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2687
2688         * MiniBrowser/qt/BrowserView.cpp:
2689         (BrowserView::resizeEvent):
2690
2691 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2692
2693         garden-o-matic summary view should provide information on builders still in flight.
2694         https://bugs.webkit.org/show_bug.cgi?id=66992
2695
2696         Reviewed by Adam Barth.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2703
2704 2011-08-25  Adam Barth  <abarth@webkit.org>
2705
2706         webkit-patch rebaseline-expectations don't work when run outside the root
2707         https://bugs.webkit.org/show_bug.cgi?id=66966
2708
2709         Reviewed by Eric Seidel.
2710
2711         Turns out tool.path() used to be relative, which caused problems when
2712         running webkit-patch outside the root directory.  This patch makes it
2713         absolute.  I checked all callers, and they all appear to want this
2714         behavior.
2715
2716         It was unclear to me how to test this change because we only really
2717         have a testing strategy for webkitpy, not for the main script.
2718
2719         * Scripts/webkit-patch:
2720
2721 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2722
2723         garden-o-matic summary needs a mock view that could be used for working on styling
2724         https://bugs.webkit.org/show_bug.cgi?id=66971
2725
2726         Reviewed by Adam Barth.
2727
2728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2730
2731 2011-08-25  Anders Carlsson  <andersca@apple.com>
2732
2733         Return the correct value for NPNVsupportsCarbonBool
2734         https://bugs.webkit.org/show_bug.cgi?id=66964
2735
2736         Add a test.
2737
2738         Reviewed by Adam Roben.
2739
2740         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2741         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2742         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2743         (SupportsCarbonEventModel::testConvert):
2744         (SupportsCarbonEventModel::runTest):
2745         (SupportsCarbonEventModel::NPP_New):
2746
2747 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2748
2749         garden-o-matic summary view should not be broken.
2750
2751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2752         (table.comparison): Added more specificity.
2753
2754 2011-08-25  Adam Barth  <abarth@webkit.org>
2755
2756         This command has been broken for a while.  This patch updates the
2757         callsite to the new API.
2758
2759         * Scripts/webkitpy/tool/commands/rebaseline.py:
2760
2761 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2762
2763         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2764         https://bugs.webkit.org/show_bug.cgi?id=66955
2765
2766         Introduce FailureGrid, your one-stop failure-indicating destination. 
2767
2768         Reviewed by Adam Barth.
2769
2770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2776
2777 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2778
2779         Add myself to the committers list
2780         https://bugs.webkit.org/show_bug.cgi?id=66941
2781
2782         Reviewed by Andreas Kling.
2783
2784         * Scripts/webkitpy/common/config/committers.py:
2785
2786 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2787
2788         Unreviewed, rolling out r93767.
2789         http://trac.webkit.org/changeset/93767
2790         https://bugs.webkit.org/show_bug.cgi?id=66931
2791
2792         Broke Qt bot. (Requested by yutak on #webkit).
2793
2794         * Scripts/webkitpy/thirdparty/__init__.py:
2795
2796 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2797
2798         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2799         https://bugs.webkit.org/show_bug.cgi?id=66924
2800
2801         Reviewed by Kent Tamura.
2802
2803         * Scripts/webkitpy/thirdparty/__init__.py:
2804
2805 2011-08-24  Adam Barth  <abarth@webkit.org>
2806
2807         The user can't close the details view in garden-o-matic
2808         https://bugs.webkit.org/show_bug.cgi?id=66911
2809
2810         Reviewed by Dimitri Glazkov.
2811
2812         In addition to adding a close button, this patch changes the test
2813         selector to use a <select> element and refactors the test selector to
2814         share code with the builder selector.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2819         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2820
2821 2011-08-24  James Robinson  <jamesr@chromium.org>
2822
2823         [chromium] Stacktrace not in test output when a test crashes
2824         https://bugs.webkit.org/show_bug.cgi?id=66806
2825
2826         Reviewed by Dirk Pranke.
2827
2828         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2829         trace.
2830
2831         * Scripts/webkitpy/layout_tests/port/chromium.py:
2832
2833 2011-08-24  Adam Barth  <abarth@webkit.org>
2834
2835         Remove empty directory.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2838
2839 2011-08-24  Adam Barth  <abarth@webkit.org>
2840
2841         Finish writing up details-view in garden-o-matic
2842         https://bugs.webkit.org/show_bug.cgi?id=66891
2843
2844         Reviewed by Dimitri Glazkov.
2845
2846         This patch mostly just copies a bunch of CSS from main.css to
2847         summary.css.  Presumably we'll delete main.css soon.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2854
2855 2011-08-24  James Robinson  <jamesr@chromium.org>
2856
2857         Some compositing LayoutTests flakily crashing on Mac 10.6
2858         https://bugs.webkit.org/show_bug.cgi?id=66740
2859
2860         Reviewed by Adam Barth.
2861
2862         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
2863         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
2864         chromium configuration.
2865
2866         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2867         (NPP_Destroy):
2868
2869 2011-08-24  Anton D'Auria  <adauria@apple.com>
2870
2871         No review necessary.
2872
2873         Adding myself to list of committers.
2874
2875         * Scripts/webkitpy/common/config/committers.py:
2876
2877 2011-08-24  Avi Drissman  <avi@google.com>
2878
2879         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
2880         https://bugs.webkit.org/show_bug.cgi?id=66875
2881
2882         Reviewed by James Robinson.
2883
2884         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2885         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2886
2887 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2888
2889         Make notifications appear in time order again.
2890         https://bugs.webkit.org/show_bug.cgi?id=66815
2891
2892         Reviewed by Adam Barth.
2893
2894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
2895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
2896
2897 2011-08-23  James Robinson  <jamesr@chromium.org>
2898
2899         [chromium] Need a way to test lost compositor context recovery
2900         https://bugs.webkit.org/show_bug.cgi?id=66820
2901
2902         Reviewed by Kenneth Russell.
2903
2904         Exposes a LayoutTestController interface in chromium to simulate a
2905         lost compositor context.
2906
2907         * DumpRenderTree/chromium/LayoutTestController.cpp:
2908         (LayoutTestController::LayoutTestController):
2909         (LayoutTestController::loseCompositorContext):
2910         * DumpRenderTree/chromium/LayoutTestController.h:
2911
2912 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2913
2914         Change garden-o-matic frontend builder array to be a configuration map.
2915         https://bugs.webkit.org/show_bug.cgi?id=66816
2916
2917         Reviewed by Adam Barth.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
2920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
2924
2925 2011-08-23  Cary Clark  <caryclark@google.com>
2926
2927         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
2928         https://bugs.webkit.org/show_bug.cgi?id=66803
2929
2930         This fixes the WebKit Canaries, in particular avoids a crash on tests
2931         like css1/basic/comments.html.
2932
2933         Reviewed by James Robinson.
2934
2935         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2936         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2937         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
2938         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
2939         and treated it as if it were a CGContextRef.
2940
2941 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2942
2943         Fix mergeChangeLogs test on native windows
2944         https://bugs.webkit.org/show_bug.cgi?id=66797
2945
2946         Reviewed by Adam Roben.
2947
2948         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
2949         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
2950
2951         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2952         (writeTempFile):
2953
2954 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2955
2956         garden-o-matic relative time is wrong and updates too frequently.
2957         https://bugs.webkit.org/show_bug.cgi?id=66802
2958
2959         Reviewed by Adam Barth.
2960
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
2964
2965 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2966
2967         Add missing quotes around filenames in mergeChangeLogs
2968         https://bugs.webkit.org/show_bug.cgi?id=66794
2969
2970         Reviewed by Adam Roben.
2971
2972         * Scripts/VCSUtils.pm:
2973         (mergeChangeLogs):
2974
2975 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2976
2977         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
2978         https://bugs.webkit.org/show_bug.cgi?id=49080
2979
2980         Reviewed by Adam Roben.
2981
2982         Use the string form of pipe open instead (like we do at all other places).
2983
2984         * Scripts/VCSUtils.pm:
2985         (mergeChangeLogs):
2986
2987 2011-08-23  Adam Barth  <abarth@webkit.org>
2988
2989         garden-o-matic summary should be able to examine failures
2990         https://bugs.webkit.org/show_bug.cgi?id=66748
2991
2992         Reviewed by Dimitri Glazkov.
2993
2994         This patch refactors a bunch of code from summary.js to independent
2995         controllers in controllers.js.  This patch also contains the first
2996         iteration of binding the "examine" event to a the behavior showing the
2997         details view for the tests.  There's more work to do here to make this
2998         work properly (and elegantly), but this patch is a start.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3009
3010 2011-08-23  Adam Barth  <abarth@webkit.org>
3011
3012         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3013         https://bugs.webkit.org/show_bug.cgi?id=66737
3014
3015         Reviewed by Steve Block.
3016
3017         This directory doesn't exist anymore now that the Android port shares
3018         more code with Chromium.
3019
3020         * Scripts/webkitpy/common/config/build.py:
3021
3022 2011-08-22  Eric Seidel  <eric@webkit.org>
3023
3024         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3025         I won't have ssh access to the bot again for a couple days, so
3026         attempting to fix by changing this script.  If this doesn't
3027         work we'll just live with the it hung for now.
3028
3029         Unreviewed.
3030
3031         * EWSTools/start-queue.sh:
3032
3033 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3034
3035         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3036         https://bugs.webkit.org/show_bug.cgi?id=66727
3037
3038         Reviewed by Adam Barth.
3039
3040         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3041             in which case the serializer treats all expectations as unparsed.
3042         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3043
3044 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3045
3046         Update unit test expectations after r93530.
3047
3048         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3049         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3050
3051 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3052
3053         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3054         https://bugs.webkit.org/show_bug.cgi?id=66705
3055
3056         Reviewed by Adam Barth.
3057
3058         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3059         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3060
3061 2011-08-22  James Robinson  <jamesr@chromium.org>
3062
3063         [chromium] Update builder names for chromium gpu bots due to CG switchover
3064         https://bugs.webkit.org/show_bug.cgi?id=66693
3065
3066         Reviewed by Dirk Pranke.
3067
3068         Update the port and builder names for the chromium mac gpu bots to
3069         account for the CG transition.
3070
3071         * Scripts/webkitpy/layout_tests/port/builders.py:
3072
3073 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3074
3075         fix the GPU bot names on the layout test dashboard
3076         https://bugs.webkit.org/show_bug.cgi?id=66697
3077
3078         Reviewed by Dimitri Glazkov.
3079
3080         * TestResultServer/static-dashboards/builders.js:
3081
3082 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3083
3084         garden-o-matic's relative time display should be updated regularly.
3085         https://bugs.webkit.org/show_bug.cgi?id=66682
3086
3087         Reviewed by Adam Barth.
3088
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3092
3093 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3094
3095         Pass --makeargs of build-webkit to chromium linux builder
3096         https://bugs.webkit.org/show_bug.cgi?id=66361
3097
3098         Reviewed by Tony Chang.
3099
3100         * Scripts/build-webkit:
3101         * Scripts/webkitdirs.pm:
3102         (buildChromiumMakefile):
3103         (buildChromium):
3104
3105 2011-08-22  Peter Beverloo  <peter@chromium.org>
3106
3107         Add myself to the contributor list.
3108         https://bugs.webkit.org/show_bug.cgi?id=66674
3109
3110         Reviewed by Tony Gentilcore.
3111
3112         * Scripts/webkitpy/common/config/committers.py:
3113
3114 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3115
3116         [Qt] ImageDiff does not consider --tolerance
3117         https://bugs.webkit.org/show_bug.cgi?id=66299
3118
3119         Reviewed by Csaba Osztrogonác.
3120
3121         * DumpRenderTree/qt/ImageDiff.cpp:
3122         (main):
3123
3124 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3125
3126         Update contributor list.
3127
3128         Reviewed by Zoltan Herczeg.
3129
3130         * Scripts/webkitpy/common/config/committers.py:
3131
3132 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3133
3134         [ORWT] Fix --reset-results --add-platform-exceptions combo
3135         https://bugs.webkit.org/show_bug.cgi?id=65464
3136
3137         Reviewed by Csaba Osztrogonác.
3138
3139         * Scripts/old-run-webkit-tests:
3140
3141 2011-08-20  Adam Barth  <abarth@webkit.org>
3142
3143         garden-o-matic summary.html should have UI for examining failures
3144         https://bugs.webkit.org/show_bug.cgi?id=66625
3145
3146         Reviewed by Dimitri Glazkov.
3147
3148         This patch introduces the notion of UI actions and converts our
3149         existing manual <button> manipulation with this new abstraction.  The
3150         patch also adds an Examine button to failure notifications.  In a
3151         future patch, I'll add a controller that wires this button up to
3152         something useful.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3162
3163 2011-08-20  Adam Barth  <abarth@webkit.org>
3164
3165         garden-o-matic summary page should indiciate compile failures
3166         https://bugs.webkit.org/show_bug.cgi?id=66624
3167
3168         Reviewed by Dimitri Glazkov.
3169
3170         This patch creates a notification-based UI for build failures.  The new
3171         UI displays the same information that used to be displayed in the
3172         infobar.  There's lots of room for improvement in surfacing more
3173         information, but this is a start.
3174
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3178
3179 2011-08-19  James Robinson  <jamesr@chromium.org>
3180
3181         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3182         https://bugs.webkit.org/show_bug.cgi?id=66606
3183
3184         Reviewed by Dirk Pranke.
3185
3186         The chromium GPU configuration does not (currently) contain any tests
3187         incompatible with --experimental-fully-parallel, and this flag is a
3188         significan speedup because of the directory canvas/philip/tests which
3189         contains 802 tests in the same directory. Setting this option by
3190         default on this configuration is a 2x speed in release, 44s to 22s,
3191         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3192
3193         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3194         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3195         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3196
3197 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3198
3199         Unreviewed, rolling out r93426.
3200         http://trac.webkit.org/changeset/93426
3201         https://bugs.webkit.org/show_bug.cgi?id=66607
3202
3203         Broke the Mac build by not building gtest.framework anymore
3204         (Requested by andersca on #webkit).
3205
3206         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3207
3208 2011-08-19  James Robinson  <jamesr@chromium.org>
3209
3210         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3211         https://bugs.webkit.org/show_bug.cgi?id=66603
3212
3213         Reviewed by Dirk Pranke.
3214
3215         The various ChromiumGpu ports should use the same child worker
3216         selection logic as other ports so they can run with full
3217         parallelization on multicore systems.
3218
3219         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3220         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3221
3222 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3223
3224         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3225         https://bugs.webkit.org/show_bug.cgi?id=66570
3226
3227         Reviewed by Mihai Parparita.
3228
3229         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3230         (WebThemeControlDRTWin::draw):
3231         (WebThemeControlDRTWin::drawTextField):
3232         (WebThemeControlDRTWin::drawProgressBar):
3233         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3234
3235 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3236
3237         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3238         https://bugs.webkit.org/show_bug.cgi?id=66521
3239
3240         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3241
3242         Reviewed by David Levin.
3243
3244         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3245
3246 2011-08-19  Adam Roben  <aroben@apple.com>
3247
3248         Add project file changes I left out in r93417
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251
3252 2011-08-19  Adam Roben  <aroben@apple.com>
3253
3254         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3255
3256         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3257         NSScreen
3258
3259         Reviewed by Anders Carlsson.
3260
3261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3262
3263         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3264         (-[SimpleObject setValue:]): Original implementation.
3265
3266         (TestWebKitAPI::setValue2):
3267         (TestWebKitAPI::setValue3):
3268         Swizzled implementations.
3269
3270         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3271         instance method.
3272
3273         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3274         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3275         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3276         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3277
3278 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3279
3280         Fix _path_to_apache() error reporting
3281         https://bugs.webkit.org/show_bug.cgi?id=66486
3282
3283         Reviewed by Ryosuke Niwa.
3284
3285         * Scripts/webkitpy/layout_tests/port/webkit.py:
3286
3287 2011-08-19  Adam Roben  <aroben@apple.com>
3288
3289         Windows build fix after r93404
3290
3291         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3292
3293 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3294
3295         Add leandrogracia to the committers list
3296         https://bugs.webkit.org/show_bug.cgi?id=66552
3297
3298         Also fix line endings in file.
3299
3300         No reviewed required.
3301
3302         * Scripts/webkitpy/common/config/committers.py:
3303
3304 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3305
3306         Fix compilation issue in WebKitTestRunner
3307         https://bugs.webkit.org/show_bug.cgi?id=66554
3308
3309         Reviewed by Martin Robinson.
3310
3311         * WebKitTestRunner/PixelDumpSupport.cpp:
3312
3313 2011-08-19  Adam Roben  <aroben@apple.com>
3314
3315         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3316
3317         This will make it easier to write other WebKit-agnostic tests
3318
3319         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3320         code in other WebKit-agnostic tests
3321
3322         Reviewed by Anders Carlsson.
3323
3324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3325
3326         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3327         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3328         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3329         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3330         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3331         WebKitAgnosticTest handles for us.
3332         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3333
3334         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3335         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3336         DynamicDeviceScaleFactor::runTest.
3337
3338         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3339         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3340         DynamicDeviceScaleFactor.WebKit.
3341         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3342         DynamicDeviceScaleFactor.WebKit2.
3343
3344 2011-08-19  Adam Roben  <aroben@apple.com>
3345
3346         Clean up #includes in TestWebKitAPI
3347
3348         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3349
3350         Reviewed by Anders Carlsson.
3351
3352         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3353         files and WebKit/WebKit.h for ObjC files.
3354
3355         * TestWebKitAPI/InjectedBundleController.cpp:
3356         * TestWebKitAPI/JavaScriptTest.h:
3357         * TestWebKitAPI/PlatformUtilities.h:
3358         * TestWebKitAPI/PlatformWebView.h:
3359         * TestWebKitAPI/Test.h:
3360         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3361         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3362         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3363         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3364         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3365         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3366         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3367         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3368         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3369         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3370         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3371         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3372         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3373         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3374         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3375         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3376         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3377         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3378         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3379         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3380         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3381         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3382         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3383         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3384         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3385         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3386         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3387         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3388         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3389         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3390         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3391         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3392         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3393         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3394         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3395         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3396         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3397         * TestWebKitAPI/TestsController.cpp:
3398         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3399         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3400         #includes since it is no longer a special header.
3401
3402 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3403
3404         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3405         https://bugs.webkit.org/show_bug.cgi?id=64886
3406
3407         Temporarily disable the http locking to work around the issue.
3408         I'm not actually sure if this is going to work or improve things
3409         much.
3410
3411         Reviewed by Ryosuke Niwa.
3412
3413         * Scripts/webkitpy/layout_tests/port/mac.py:
3414
3415 2011-08-18  Tony Chang  <tony@chromium.org>
3416
3417         add embedded png checksums to WebKitTestRunner
3418         https://bugs.webkit.org/show_bug.cgi?id=66494
3419
3420         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
3421         some code from DRT and adds it to the WebKitTestRunner.
3422
3423         Reviewed by Darin Adler.
3424
3425         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
3426         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
3427         * WebKitTestRunner/GNUmakefile.am: Add new files
3428         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
3429         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
3430         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
3431         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3432         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3433         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3434         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3435         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3436         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3437         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
3438
3439 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=47240
3442
3443         Fixed a cygwin path problem in the chromium port of diff_image;
3444         Also made the return values of the diff_image function more consistent.
3445
3446         Reviewed by Dirk Pranke.
3447
3448         * Scripts/webkitpy/layout_tests/port/chromium.py:
3449
3450 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
3451
3452         [GTK] Fix compilation problems with deprecations in gtk+
3453         https://bugs.webkit.org/show_bug.cgi?id=66073
3454
3455         Reviewed by Martin Robinson.
3456
3457         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3458         (main): G_CONST_RETURN was deprecated
3459         * GtkLauncher/main.c:
3460         (createWindow): Added gtk_box_new conditional compilation for
3461         gtk+-3.
3462         * MiniBrowser/gtk/BrowserWindow.c:
3463         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
3464         are just supporting gtk+-3 for WebKit2.
3465
3466 2011-08-18  Anders Carlsson  <andersca@apple.com>
3467
3468         Fix libc++ C++0x build
3469         https://bugs.webkit.org/show_bug.cgi?id=66479
3470
3471         Reviewed by Adam Roben.
3472
3473         Add missing includes.
3474
3475         * DumpRenderTree/LayoutTestController.cpp:
3476         * DumpRenderTree/mac/CheckedMalloc.cpp:
3477
3478 2011-08-18  Adam Roben  <aroben@apple.com>
3479
3480         Test that WebKit updates style when a WebView is moved between differently-scaled windows
3481
3482         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
3483         WebView is moved between windows with different backing scale factors
3484
3485         Reviewed by Anders Carlsson.
3486
3487         * TestWebKitAPI/JavaScriptTest.cpp:
3488         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
3489         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
3490         gtest's built-in error messages.
3491
3492         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
3493         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
3494         those overloads.
3495
3496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3497
3498         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
3499         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
3500         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
3501         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
3502         (TestWebKitAPI::setPageLoaderClient): Set up the client.
3503         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
3504         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
3505         SyntheticBackingScaleFactorWindow and returns it.
3506         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
3507         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
3508         window, is moved to a differently-scaled window, and is taken out of the window.
3509         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
3510         WebKit1 and WebKit2.
3511         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
3512
3513         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
3514
3515         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
3516         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
3517
3518         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
3519         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
3520         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
3521         initializer.
3522         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
3523
3524         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
3525         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
3526         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
3527
3528 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3529
3530         https://bugs.webkit.org/show_bug.cgi?id=66425
3531         check-webkit-style should detect incorrectly formatted file change descriptions.
3532         Description, if present, should be separated from colon with a space.
3533
3534         Reviewed by David Levin.
3535
3536         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
3537         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
3538
3539 2011-08-18  Adam Barth  <abarth@webkit.org>
3540
3541         webkit-patch pretty-diff should be shown in main help
3542         https://bugs.webkit.org/show_bug.cgi?id=66404
3543
3544         Reviewed by Dimitri Glazkov.
3545
3546         As requested by dglazkov.
3547
3548         * Scripts/webkitpy/tool/commands/prettydiff.py:
3549
3550 2011-08-17  Dmitry Lomov  <dslomov@google.com>
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=66400
3553         Fix TestWebKitAPI build on Mac OS.
3554
3555         Reviewed by David Levin.
3556
3557         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
3558
3559 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3560
3561         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
3562         https://bugs.webkit.org/show_bug.cgi?id=66427
3563
3564         Reviewed by Adam Barth.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
3569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
3570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
3571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
3627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
3628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
3629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.