Unreviewed, rolling out r176566.
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-01  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r176566.
4         https://bugs.webkit.org/show_bug.cgi?id=139124
5
6         It broke the GTK performance tests. (Requested by clopez on
7         #webkit).
8
9         Reverted changeset:
10
11         "[GTK] Use GMainLoopSource in WebKitTestRunner"
12         https://bugs.webkit.org/show_bug.cgi?id=138831
13         http://trac.webkit.org/changeset/176566
14
15 2014-11-29  Anders Carlsson  <andersca@apple.com>
16
17         Crash when calling WKPageClose on the originated page from within createNewPage callback
18         https://bugs.webkit.org/show_bug.cgi?id=139099
19         <rdar://problem/19052564>
20
21         Reviewed by Sam Weinig.
22
23         Add a test.
24
25         * TestWebKitAPI/PlatformWebView.h:
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
28         (TestWebKitAPI::runJavaScriptAlert):
29         (TestWebKitAPI::createNewPage):
30         (TestWebKitAPI::TEST):
31         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
32         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
33         (TestWebKitAPI::PlatformWebView::PlatformWebView):
34
35 2014-11-28  Commit Queue  <commit-queue@webkit.org>
36
37         Unreviewed, rolling out r176564.
38         https://bugs.webkit.org/show_bug.cgi?id=139093
39
40         massive failures on release test bot (Requested by philn on
41         #webkit).
42
43         Reverted changeset:
44
45         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
46         https://bugs.webkit.org/show_bug.cgi?id=138866
47         http://trac.webkit.org/changeset/176564
48
49 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
50
51         [GTK] Use GMainLoopSource in WebKitTestRunner
52         https://bugs.webkit.org/show_bug.cgi?id=138831
53
54         Reviewed by Sergio Villar Senin.
55
56         * WebKitTestRunner/InjectedBundle/TestRunner.h:
57         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
58         (WTR::TestRunner::platformInitialize):
59         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
60         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
61         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
62         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
63         (WTR::TestController::notifyDone):
64         (WTR::TestController::platformRunUntil):
65         (WTR::cancelTimeout): Deleted.
66
67 2014-11-24  Philippe Normand  <pnormand@igalia.com>
68
69         [GStreamer] Bump internal jhbuild versions to 1.4.4
70         https://bugs.webkit.org/show_bug.cgi?id=138866
71
72         Reviewed by Carlos Garcia Campos.
73
74         * gtk/jhbuild.modules:
75         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
76         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
77         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
78
79 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
82         https://bugs.webkit.org/show_bug.cgi?id=138834
83
84         Reviewed by Sergio Villar Senin.
85
86         It makes everyting simpler and the tests run faster too, since we
87         don't need to spawn the private bus and wait until the DBus name
88         is registered. The web extension registers a new JavaSCript class
89         with a status method to run the tests, similar to the DBus
90         method. In the UI process side, tests use webkit_web_view_run_java_script()
91         instead of sending a DBus message.
92
93         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
94         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
95         (WebKitDOMNodeFilterTest::create):
96         (WebKitDOMNodeFilterTest::testTreeWalker):
97         (WebKitDOMNodeFilterTest::testNodeIterator):
98         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
99         (WebKitDOMNodeFilterTest::runTest): Deleted.
100         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
101         (WebKitDOMNodeTest::create):
102         (WebKitDOMNodeTest::testHierarchyNavigation):
103         (WebKitDOMNodeTest::testInsertion):
104         (WebKitDOMNodeTest::testTagNames):
105         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
106         (WebKitDOMNodeTest::runTest): Deleted.
107         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
108         (WebKitDOMXPathNSResolverTest::create):
109         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
110         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
111         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
112         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
113         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
114         (WebKitFrameTest::create):
115         (WebKitFrameTest::testMainFrame):
116         (WebKitFrameTest::testURI):
117         (WebKitFrameTest::testJavaScriptContext):
118         (WebKitFrameTest::webPageFromArgs): Deleted.
119         (WebKitFrameTest::runTest): Deleted.
120         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
121         (testWebKitDOMNodeHierarchyNavigation):
122         (testWebKitDOMNodeInsertion):
123         (testWebKitDOMNodeTagNames):
124         (beforeAll):
125         (afterAll):
126         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
127         (runTest):
128         (beforeAll):
129         (afterAll):
130         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
131         (testWebKitDOMXPathNSResolverNative):
132         (testWebKitDOMXPathNSResolverCustom):
133         (beforeAll):
134         (afterAll):
135         (runTest): Deleted.
136         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
137         (webkitFrameTestRun):
138         (beforeAll):
139         (afterAll):
140         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
141         (testsMap):
142         (WebProcessTest::add):
143         (WebProcessTest::create):
144         (runTest):
145         (windowObjectClearedCallback):
146         (webkit_web_extension_initialize):
147         (methodCallCallback): Deleted.
148         (webkit_web_extension_initialize_with_user_data): Deleted.
149         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
150         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
151         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
152         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
153         (WebViewTest::runWebProcessTest):
154         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
155
156 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
157
158         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
159         https://bugs.webkit.org/show_bug.cgi?id=139086
160
161         Reviewed by Gyuyoung Kim.
162
163         * efl/jhbuild.modules:
164         * efl/patches/libseccomp-pick-up-CC.patch: Added.
165
166 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
167
168         [EFL] Add warning if CMake version is too old for building with ninja.
169         https://bugs.webkit.org/show_bug.cgi?id=139055
170
171         Reviewed by Gyuyoung Kim.
172
173         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
174         that version in their repositories.
175
176         * efl/install-dependencies:
177
178 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
179
180         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
181         https://bugs.webkit.org/show_bug.cgi?id=139044
182
183         Reviewed by Chris Fleizach.
184
185         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
186         The proposed solution will enable the use of this method for the object table.
187         Existing test shows the result.
188
189         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
190         (WTR::AccessibilityUIElement::columnHeaders):
191
192 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
193
194         [EFL] Remove E_Dbus dependency
195         https://bugs.webkit.org/show_bug.cgi?id=136355
196
197         Reviewed by Gyuyoung Kim.
198
199         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
200
201 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
202
203         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
204         https://bugs.webkit.org/show_bug.cgi?id=139047
205
206         Reviewed by Carlos Garcia Campos.
207
208         * efl/jhbuild.modules:
209         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
210         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
211         * gtk/jhbuild-optional.modules:
212         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
213         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
214
215 2014-11-25  Tanay C  <tanay.c@samsung.com>
216
217         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
218         https://bugs.webkit.org/show_bug.cgi?id=138090
219
220         Reviewed by Carlos Garcia Campos.
221
222         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
223         (browserWindowZoomIn): Added.
224         (browserWindowZoomOut): Added.
225         (scrollEventCallback): Added.
226         (zoomInCallback): Modified.
227         (zoomOutCallback): Modified.
228         (browserWindowConstructed): Modified.
229
230 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
231
232         [EFL] REGRESSION(r176514): It made performance tests fail
233         https://bugs.webkit.org/show_bug.cgi?id=139037
234
235         Reviewed by Gyuyoung Kim.
236
237         * Scripts/webkitpy/port/efl.py:
238         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
239         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
240         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
241
242 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
243
244         [GTK] update-webkitgtk-libs fails to build fontconfig
245         https://bugs.webkit.org/show_bug.cgi?id=139032
246
247         Reviewed by Martin Robinson.
248
249         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
250         fontconfig will try to generate documentation and fail.
251
252         * gtk/install-dependencies:
253
254 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
255
256         Unreviewed. Fix GTK+ make distcheck.
257
258         * gtk/manifest.txt: Remove deleted files.
259
260 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
261
262         [EFL] Utilize Eail library to support accessibility in EFL
263         https://bugs.webkit.org/show_bug.cgi?id=137742
264
265         Reviewed by Gyuyoung Kim.
266
267         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
268
269         * efl/jhbuild-optional.modules: Added.
270         * efl/jhbuild.modules:
271
272 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
273
274         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
275         https://bugs.webkit.org/show_bug.cgi?id=139023
276
277         Reviewed by Sergio Villar Senin.
278
279         Rename WebKitWebView/default-context as WebKitWebView/web-context
280         and check we are always using the right context for new web views.
281
282         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
283         (testWebViewWebContext):
284         (beforeAll):
285         (testWebViewDefaultContext): Deleted.
286
287 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
288
289         [GTK] Add API to override the default local storage directory
290         https://bugs.webkit.org/show_bug.cgi?id=138828
291
292         Reviewed by Gustavo Noronha Silva.
293
294         Add test to check that the local storage directory is created at
295         the path given on construction.
296
297         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
298         (testWebContextConfiguration):
299         (beforeAll):
300         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
301         (Test::Test):
302         (Test::~Test): Deleted.
303
304 2014-11-21  Zalan Bujtas  <zalan@apple.com>
305
306         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
307         https://bugs.webkit.org/show_bug.cgi?id=138981
308
309         Reviewed by Simon Fraser.
310
311         * MiniBrowser/mac/SettingsController.h:
312         * MiniBrowser/mac/SettingsController.m:
313         (-[SettingsController _populateMenu]):
314         (-[SettingsController validateMenuItem:]):
315         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
316         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
317         * MiniBrowser/mac/WK1BrowserWindowController.m:
318         (-[WK1BrowserWindowController didChangeSettings]):
319         * MiniBrowser/mac/WK2BrowserWindowController.m:
320         (-[WK2BrowserWindowController didChangeSettings]):
321
322 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
323
324         Remove http lock code from webkitperl
325         https://bugs.webkit.org/show_bug.cgi?id=138959
326
327         Reviewed by Alexey Proskuryakov.
328
329         * Scripts/webkitperl/httpd.pm:
330         (cleanUp):
331         (extractLockNumber): Deleted.
332         (getLockFiles): Deleted.
333         (getNextAvailableLockNumber): Deleted.
334         (getLockNumberForCurrentRunning): Deleted.
335         (waitForHTTPDLock): Deleted.
336         (scheduleHttpTesting): Deleted.
337         (getWaitTime): Deleted.
338
339 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
340
341         [EFL] The option value of fixed layout is false in MiniBrowser
342         https://bugs.webkit.org/show_bug.cgi?id=138830
343
344         Reviewed by Gyuyoung Kim.
345
346         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
347
348         * MiniBrowser/efl/main.c:
349
350 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
351
352         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
353         https://bugs.webkit.org/show_bug.cgi?id=138871
354
355         Reviewed by Carlos Garcia Campos.
356
357         Add a test case for the convenience API for posting user messages
358         added to the DOM bindings.
359
360         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
361         (testUserContentManagerMessageFromConvenienceDOMBindings):
362         (beforeAll):
363         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
364         (documentLoadedCallback):
365
366 2014-11-19  Dana Burkart  <dburkart@apple.com>
367
368         Work around the fact that different masters may have different names for their codebases.
369         https://bugs.webkit.org/show_bug.cgi?id=138878
370
371         Reviewed by Mark Rowe.
372
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
374         (parseRevisionProperty): Changed.
375         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
376         opensource / internal codebase naming convention.
377
378 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
379
380         AX: Screen braille input doesn't work on forms.
381         https://bugs.webkit.org/show_bug.cgi?id=138804
382
383         Unreviewed build fix.
384
385         * DumpRenderTree/AccessibilityUIElement.cpp:
386         (AccessibilityUIElement::setValue):
387
388 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
389
390         AX: Screen braille input doesn't work on forms.
391         https://bugs.webkit.org/show_bug.cgi?id=138804
392
393         Reviewed by Mario Sanchez Prada.
394
395         Add a method to setValue through the AX API in DRT.
396
397         * DumpRenderTree/AccessibilityUIElement.cpp:
398         (setValueCallback):
399         (AccessibilityUIElement::getJSClass):
400         * DumpRenderTree/AccessibilityUIElement.h:
401         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
402         (AccessibilityUIElement::setValue):
403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
404         (AccessibilityUIElement::setValue):
405
406 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
407
408         Remove the WinCairo buildbot
409         https://bugs.webkit.org/show_bug.cgi?id=138805
410
411         Reviewed by Alex Christensen.
412
413         * BuildSlaveSupport/build.webkit.org-config/config.json:
414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
415         (appendCustomBuildFlags):
416         * BuildSlaveSupport/test-result-archive:
417         (archiveTestResults):
418
419 2014-11-18  Daniel Bates  <dabates@apple.com>
420
421         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
422         SPI are not available in public SDK
423         https://bugs.webkit.org/show_bug.cgi?id=138802
424
425         Reviewed by David Kilzer.
426
427         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
428
429         * DumpRenderTree/mac/CheckedMalloc.cpp:
430
431 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
432
433         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
434
435         Forgot to fix this test before landing.
436
437         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
438         (testWebViewDefaultContext):
439
440 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
441
442         [GTK] Add API to create a WebKitWebContext
443         https://bugs.webkit.org/show_bug.cgi?id=138826
444
445         Reviewed by Gustavo Noronha Silva.
446
447         Use a different WebKitWebContext for every test to ensure test
448         cases are independent to each other. Tests using DBus to
449         communicate with the injected bundle extension now use a unique
450         name for the well known DBus name.
451
452         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
453         (beforeAll): Remove comment about the order of the tests and
454         move the success test before the failed one now that tests don't
455         depend on each others.
456         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
457         (beforeAll): Remove call to set the web extensions directory,
458         since this is now done for all test in the Test constructor.
459         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
460         (beforeAll): Do not create a temporary directory, a temporary data
461         directory is now created for all tests.
462         (afterAll):
463         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
464         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
465         to the web process test runner.
466         (testWebKitDOMNodeInsertion): Ditto.
467         (testWebKitDOMNodeTagNames): Ditto.
468         (beforeAll): Remove call to set the web extensions directory.
469         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
470         (runTest): Pass the web extension ID to the web process test runner.
471         (beforeAll): Remove call to set the web extensions directory.
472         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
473         (runTest): Pass the web extension ID to the web process test runner.
474         (beforeAll): Remove call to set the web extensions directory.
475         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
476         (createFileAtDestination): Use Test::dataDirectory() as base dir
477         for temporary files.
478         (beforeAll): Do not create a temporary directory.
479         (afterAll):
480         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
481         (webkitFrameTestRun): Pass the web extension ID to the web process
482         test runner.
483         (beforeAll): Remove call to set the web extensions directory.
484         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
485         (beforeAll): Remove call to set the web extensions directory.
486         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
487         (testProcessPerWebView): Use local member instead of global variable.
488         (testMultiprocessWebViewCreateReadyClose): Ditto.
489         (beforeAll): Do not connect to initialize-web-extensions, Test now
490         connects to the signal for all tests and calls a virtual method
491         that test can override.
492         (afterAll):
493         (initializeWebExtensions): Deleted.
494         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
495         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
496         for temporary files.
497         (beforeAll): Do not create a temporary directory.
498         (afterAll):
499         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
500         (beforeAll): Remove call to set the web extensions directory.
501         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
502         (beforeAll): Remove comment about the tests order.
503         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
504         (testWebExtensionGetTitle): Build the DBus service name using the
505         web extension ID.
506         (testDocumentLoadedSignal): Ditto.
507         (testWebKitWebViewProcessCrashed): Ditto.
508         (testWebExtensionIsolatedWorld): Ditto.
509         (beforeAll): Remove initialization-user-data test, since now all
510         tests are passing user data to the web extension.
511         (testWebExtensionInitializationUserData): Deleted.
512         (initializeWebExtensions): Deleted.
513         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
514         (testSetDirectory): Use the web context member inherited from Test.
515         (testClearDatabase): Ditto.
516         (testGetFaviconURI): Ditto.
517         (beforeAll): Do not create a temporary directory.
518         (afterAll):
519         (webkitFaviconDatabaseFinalizedCallback): Deleted.
520         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
521         (UserContentManagerTest::UserContentManagerTest):
522         (beforeAll): Remove call to set the web extensions directory.
523         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
524         (testWebContextDefault): Check also that a newly create web
525         context is not the default web context.
526         (testWebContextSpellChecker): Use the web context member inherited
527         from Test.
528         (testWebContextLanguages): Ditto.
529         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
530         (methodCallCallback): Remove GetInitializationUserData method.
531         (webkit_web_extension_initialize_with_user_data): Always create
532         the DBus name using the user data provided.
533         (makeBusName): Deleted.
534         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
535         (webkit_web_extension_initialize_with_user_data): Create the DBus
536         name using the user data provided.
537         (webkit_web_extension_initialize): Deleted.
538         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
539         (Test::dataDirectory): Return the temporary data directory.
540         (removeNonEmptyDirectory): Also remove directories recursively.
541         (main): Remove the disk cache directory initialization, since this
542         is now done in the Test constructor.
543         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
544         (Test::initializeWebExtensionsCallback): Call the virtual method
545         initializeWebExtensions()
546         (Test::Test): Create a new WebKitWebContext and initialize it.
547         (Test::~Test): Disconnect initialize-web-extensions signal.
548         (Test::initializeWebExtensions): Set the web extensions directory
549         and user data.
550         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
551         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
552         (WebProcessTestRunner::runTest): Build the DBus proxy using a
553         unique name created with the Test web extension ID.
554         (WebProcessTestRunner::proxy): Deleted.
555         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
556         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
557         (WebViewTest::WebViewTest): Create the web view with the Test web
558         context.
559         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
560         content manager parameter to the constructor.
561
562 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
563
564         [GTK] Mesa build fails over llvm-3.5
565         https://bugs.webkit.org/show_bug.cgi?id=138825
566
567         Reviewed by Gustavo Noronha Silva.
568
569         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
570
571         * gtk/jhbuild.modules:
572         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
573
574 2014-11-17  Daniel Bates  <dabates@apple.com>
575
576         Unreviewed, rolling out r176232.
577
578         Broke the Mac build. Will investigate offline.
579
580         Reverted changeset:
581
582         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
583         MobileGestalt"
584         https://bugs.webkit.org/show_bug.cgi?id=138802
585         http://trac.webkit.org/changeset/176232
586
587 2014-11-17  Daniel Bates  <dabates@apple.com>
588
589         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
590         SPI are not available in public SDK
591         https://bugs.webkit.org/show_bug.cgi?id=138802
592
593         Reviewed by David Kilzer.
594
595         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
596
597         * DumpRenderTree/mac/CheckedMalloc.cpp:
598
599 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
600
601         Having 30+ flaky failures breaks EWS
602         https://bugs.webkit.org/show_bug.cgi?id=138743
603
604         Reviewed by Alexey Proskuryakov.
605
606         Adds tests to ensure that the problem has been solved.
607         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
608         (test_first_failure_limit):
609         (test_first_failure_limit_with_some_tree_redness):
610         (test_second_failure_limit):
611         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
612         (test_first_and_second_failure_limit):
613         (test_first_and_clean_failure_limit):
614         (test_first_second_and_clean_failure_limit):
615         (test_very_red_tree_retry): Deleted.
616         Really this was renamed to test_first_second_and_clean_failure_limit.
617         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
618         Makes the appropriate changes to PatchAnalysisTask to make sure that
619         even when the first test run hits the failure limit, it will still try
620         a second run.
621         (PatchAnalysisTask._results_failed_different_tests):
622         (PatchAnalysisTask._test_patch):
623         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
624
625 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
626
627         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
628         https://bugs.webkit.org/show_bug.cgi?id=136018
629
630         Reviewed by Carlos Garcia Campos.
631
632         It is possible that the order of -L arguments in the output of
633         pkg-config is wrong, which causes the linker to find the wrong
634         version (usually older version) of libraries when running
635         gtkdoc-scangobj.
636
637         * gtk/gtkdoc.py:
638         (GTKDoc._run_gtkdoc_scangobj):
639
640 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
641
642         Bump EFL version to 1.12.0
643         https://bugs.webkit.org/show_bug.cgi?id=138733
644
645         Reviewed by Gyuyoung Kim.
646
647         * efl/jhbuild.modules:
648
649 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
650
651         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
652         https://bugs.webkit.org/show_bug.cgi?id=138771
653
654         Reviewed by Chris Fleizach.
655
656         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
657
658         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
659
660 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
661
662         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
663         https://bugs.webkit.org/show_bug.cgi?id=138767
664
665         Reviewed by Chris Fleizach.
666
667         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
668
669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
670
671 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
672
673         Add shortcut macros to Mac TestExpectations
674         https://bugs.webkit.org/show_bug.cgi?id=138729
675
676         Reviewed by Simon Fraser.
677
678         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
679         Add version macros for current OS versions.
680
681 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
682
683         https://bugs.webkit.org/show_bug.cgi?id=138628
684         A patch that doesn't apply is stuck in commit queue
685
686         Rubber-stamped by David Kilzer.
687
688         This also hopefully fixes other issues:
689         - a patch that has cq+ flag set by a non-committer kills commit queue;
690         - EWS never reports failing tests, and keeps spinning instead.
691
692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
693         (Bugzilla.set_flag_on_attachment):
694         (Bugzilla.obsolete_attachment):
695         Apply the fix from r174797 to more places.
696
697 2014-11-13  Dan Bernstein  <mitz@apple.com>
698
699         Policy client not called for navigations through the page cache
700         https://bugs.webkit.org/show_bug.cgi?id=138703
701
702         Reviewed by Alexey Proskuryakov.
703
704         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
705         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
706         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
707
708 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
709
710         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
711         https://bugs.webkit.org/show_bug.cgi?id=137867
712
713         Reviewed by Chris Fleizach.
714
715         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
716         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
717         able to test for the presence of ATK_ROLE_INVALID.
718
719         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
720         (WTR::AccessibilityUIElement::role):
721
722 2014-11-13  Juergen Ributzka  <juergen@apple.com>
723
724         Update the "combineModules" script to handel more LLVM metadata.
725         https://bugs.webkit.org/show_bug.cgi?id=138514
726
727         Reviewed by Filip Pizlo.
728
729         * ReducedFTL/combineModules.rb:
730
731 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
732
733         Allow constructing a base PassRef with a derived Ref
734         https://bugs.webkit.org/show_bug.cgi?id=138701
735
736         Reviewed by Andreas Kling
737
738         * TestWebKitAPI/Tests/WTF/Ref.cpp:
739         (TestWebKitAPI::passWithPassRef):
740         (TestWebKitAPI::passWithPassRefPtr):
741         (TestWebKitAPI::TEST):
742
743 2014-11-05  Ada Chan  <adachan@apple.com>
744
745         Implement new plug-in API for muting plug-ins
746         https://bugs.webkit.org/show_bug.cgi?id=138105
747
748         Reviewed by Anders Carlsson.
749
750         Add a new plug-in test for the mute API.
751
752         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
753         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
754         (SetMuted::SetMuted):
755         (SetMuted::isMuted):
756         (SetMuted::cachedIsMuted):
757         (SetMuted::ScriptableObject::hasProperty):
758         (SetMuted::ScriptableObject::getProperty):
759         (SetMuted::ScriptableObject::pluginTest):
760         (SetMuted::NPP_New):
761         (SetMuted::NPP_GetValue):
762         (SetMuted::NPP_SetValue):
763
764 2014-11-12  Philippe Normand  <pnormand@igalia.com>
765
766         Unreviewed, GTK gardening.
767
768         * Scripts/run-gtk-tests:
769         (TestRunner): Skip the UserMediaBasic test because it depends on
770         constraints validation which is going to be fixed in bug #136449.
771
772 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
773
774         [GTK] Expose user script messages to GObject DOM bindings
775         https://bugs.webkit.org/show_bug.cgi?id=138411
776
777         Reviewed by Philippe Normand.
778
779         Add a test case to check that user script messages sent using the
780         DOM bindings API are also received in the UI process.
781
782         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
783         (UserScriptMessageTest::waitUntilMessageReceived):
784         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
785         (testUserContentManagerScriptMessageFromDOMBindings):
786         (beforeAll):
787         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
788         (documentLoadedCallback):
789
790 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
791
792         Unreviewed. Fix GTK+ clean build after r175930.
793
794         Partial rollout of r175930 to not build the new unit test that
795         broke clean builds in GTK+ port.
796
797         * TestWebKitAPI/PlatformGTK.cmake:
798
799 2014-09-01  Philippe Normand  <pnormand@igalia.com>
800
801         [WK2] UserMediaClient support
802         https://bugs.webkit.org/show_bug.cgi?id=123158
803
804         Reviewed by Benjamin Poulain.
805
806         Simple API test for the UserMedia permission request API. The
807         required test infrastructure is also added, inspired by the
808         Geolocation infrastructure.
809
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
811         Permission request.
812         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
813         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
814         (TestWebKitAPI::TEST):
815         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
816         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
817         helper method to set the permission request result without user interaction.
818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
819         (WTR::InjectedBundle::setUserMediaPermission):
820         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
822         (WTR::TestRunner::setUserMediaPermission):
823         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
824         * WebKitTestRunner/TestController.cpp:
825         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
826         request handler.
827         (WTR::TestController::createOtherPage): Enable the new UserMedia
828         permission request handler.
829         (WTR::TestController::createWebViewWithOptions): Ditto.
830         (WTR::TestController::resetPreferencesToConsistentValues): Enable
831         MediaStream support, this is needed for getUserMedia.
832         (WTR::TestController::resetStateToConsistentValues): clear
833         UserMedia permissions list and flags.
834         (WTR::TestController::setUserMediaPermission): Set permission
835         request result and distpatch it.
836         (WTR::TestController::handleUserMediaPermissionRequest): Save
837         request and dispatch it.
838         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
839         Dispatch cached permission requests.
840         * WebKitTestRunner/TestController.h:
841         * WebKitTestRunner/TestInvocation.cpp:
842         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
843
844 2014-11-11  David Kilzer  <ddkilzer@apple.com>
845
846         webkit-patch --suggest-reviewers is broken with newer versions of git
847         <http://webkit.org/b/138627>
848
849         Reviewed by Michael Saboff with feedback from Daniel Bates.
850
851         * Scripts/webkitpy/common/checkout/scm/git.py:
852         (Git._changes_files_for_commit): Strip blank lines instead of
853         assuming there is always a blank line at the beginning of the
854         list.
855
856 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
857
858         DRT and WKTR touch disk cache
859         https://bugs.webkit.org/show_bug.cgi?id=138622
860
861         Reviewed by Geoffrey Garen.
862
863         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
864         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
865         because this function uses the shared cache.
866
867         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
868         Create an empty shared cache to prevent a default one from being created on disk.
869
870 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
871
872         [CSS Grid Layout] Limit the size of explicit/implicit grid
873         https://bugs.webkit.org/show_bug.cgi?id=136217
874
875         Reviewed by Andreas Kling.
876
877         Added a new unit test for the CSS parser. Right now it only checks
878         that we properly clamp the maximum number of tracks on a grid to a
879         maximum of 1 million.
880
881         * TestWebKitAPI/CMakeLists.txt:
882         * TestWebKitAPI/PlatformEfl.cmake:
883         * TestWebKitAPI/PlatformGTK.cmake:
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
886         (TestWebKitAPI::computeNumberOfTracks): Helper function.
887         (TestWebKitAPI::TEST): Added a
888         CSSPropertyParserTest.GridTrackLimits test case.
889
890 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
891
892         webkitpy test fix after r175867
893         https://bugs.webkit.org/show_bug.cgi?id=138607
894
895         Reviewed by Philippe Normand.
896
897         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
898         (GDBCrashLogGeneratorTest.test_generate_crash_log):
899
900 2014-11-10  Philippe Normand  <pnormand@igalia.com>
901
902         webkitpy: demangle C++ symbols from crash log stderr
903         https://bugs.webkit.org/show_bug.cgi?id=138565
904
905         Reviewed by Alexey Proskuryakov.
906
907         * Scripts/webkitpy/port/linux_get_crash_log.py:
908         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
909         with c++filt.
910
911 2014-11-10  Philippe Normand  <pnormand@igalia.com>
912
913         [GTK] fix up the GDB backtrace report tool
914         https://bugs.webkit.org/show_bug.cgi?id=138564
915
916         Reviewed by Carlos Garcia Campos.
917
918         * Scripts/webkitpy/port/gtk.py:
919         (GtkPort._get_crash_log): Match the process name reported by the
920         driver with the GTK port WebProcess executable filename.
921         * Scripts/webkitpy/port/linux_get_crash_log.py:
922         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
923         program.
924         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
925         pattern to workaround the 16 characters size limit of %e.
926
927 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
928
929         Unreviewed, moved myself to the list of committers.
930
931         * Scripts/webkitpy/common/config/contributors.json:
932
933 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
934
935         [EFL] Fix the test font path after r175555.
936
937         Reviewed by Csaba Osztrogonác.
938
939         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
940
941 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
942
943         Fix the exception fuzz helper to generate targets in the correct range
944         https://bugs.webkit.org/show_bug.cgi?id=138544
945
946         Reviewed by Filip Pizlo.
947
948         Currently, the script generates exception fuzz targets in the range of
949         0..($checkCount-1). However, target 0 is never hit, while target 1 is
950         always outside of the outermost try block of the tests, which therefore
951         prints unexpected output and results in false failures when fired at.
952         Additionally, target $checkCount is never generated.
953
954         This patch fixes the script to generate targets in the range of
955         2..$checkCount.
956
957         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
958
959 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
960
961         make-passwords-json.py should generarate everything needed for testing
962         https://bugs.webkit.org/show_bug.cgi?id=138503
963
964         Reviewed by Ryosuke Niwa.
965
966         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
967         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
968         Additionally generate auth.json, credentials.cfg and committers.cfg too.
969         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
970         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
971         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
972         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
973
974 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
975
976         [GTK] generate-gtkdoc should ignore invalid files
977         https://bugs.webkit.org/show_bug.cgi?id=138542
978
979         Reviewed by Darin Adler.
980
981         * gtk/generate-gtkdoc:
982         (files_to_ignore.file_should_be_ignored): Return True to ignore
983         invalid files.
984
985 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
986
987         Delete cookies between tests
988         https://bugs.webkit.org/show_bug.cgi?id=138528
989
990         Reviewed by Sam Weinig.
991
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetWebPreferencesToConsistentValues):
994         * WebKitTestRunner/TestController.cpp:
995         (WTR::TestController::resetPreferencesToConsistentValues):
996         Do it.
997
998         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
999         (WTR::InjectedBundle::beginTesting):
1000         Added a FIXME.
1001
1002 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1003
1004         [GTK] Run layout tests using the network process
1005         https://bugs.webkit.org/show_bug.cgi?id=138428
1006
1007         Reviewed by Martin Robinson.
1008
1009         Shared secondary process is the default in the GTK+ port, but we
1010         should run the tests using the network process to ensure
1011         everything works with the network process. In the future, the
1012         shared secondary process model might be a special case of multiple
1013         processes with 1 as maximum number of processes, but always using
1014         the network process.
1015
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::initialize):
1018
1019 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1020
1021         [GTK] Allow to create a view with a related page in WTR
1022         https://bugs.webkit.org/show_bug.cgi?id=138501
1023
1024         Reviewed by Martin Robinson.
1025
1026         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1027         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1028         related page to WKViewCreate.
1029         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1030         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1031         page to WKViewCreate.
1032
1033 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1034
1035         WTR crashes after running a test when NetworkProcess enabled
1036         https://bugs.webkit.org/show_bug.cgi?id=138500
1037
1038         Reviewed by Alexey Proskuryakov.
1039
1040         WebNotificationProvider destructor is calling
1041         WKNotificationManagerSetProvider, but m_notificationManager is
1042         null because removeNotificationManager was already called.
1043
1044         * WebKitTestRunner/WebNotificationProvider.cpp:
1045         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1046         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1047
1048 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1049
1050         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1051         regarding incorrect call to PatchAnalysisTask.report_failure
1052         https://bugs.webkit.org/show_bug.cgi?id=138229
1053
1054         Reviewed by Daniel Bates.
1055
1056         * Scripts/webkitpy/common/net/layouttestresults.py:
1057         Makes sure test_results returns a list.
1058         (LayoutTestResults.test_results):
1059         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1060         Makes unit tests also check to make sure
1061         task.results_from_patch_test_run() and
1062         task.results_from_test_run_without_patch return instances of
1063         LayoutTestResults.
1064         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1065         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1066         Condenses duplicate code into _should_defer_patch_or_throw, and
1067         removes the now-unused _clean_tree_results member.
1068         (PatchAnalysisTask.__init__):
1069         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1070         (PatchAnalysisTask._should_defer_patch_or_throw):
1071         (PatchAnalysisTask._test_patch):
1072         (PatchAnalysisTask.results_from_patch_test_run):
1073         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1074         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1075         Removes needless call to results_from_test_run_without_patch
1076         (AbstractEarlyWarningSystem._failing_tests_message):
1077         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1078         Changes order of test failure messages to be in the order that they
1079         appear.
1080         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1081         * Scripts/webkitpy/tool/commands/queues.py:
1082         Removes needless call to results_from_test_run_without_patch.
1083         (CommitQueue._failing_tests_message):
1084         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1085         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1086
1087 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1088
1089         Unreviewed. Reorder my e-mail addresses in contributors.json
1090
1091         * Scripts/webkitpy/common/config/contributors.json:
1092
1093 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1094
1095         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1096         https://bugs.webkit.org/show_bug.cgi?id=138475
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1101         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1102         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1103         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1104
1105         * Scripts/webkitpy/common/checkout/scm/git.py:
1106         (Git._run_git_svn_find_rev):
1107         Add comment mentioning that svn_revisions need to begin with 'r'.
1108         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1109         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1110         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1111
1112 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         [GTK] Add context menu API to Web Process Extensions
1115         https://bugs.webkit.org/show_bug.cgi?id=138311
1116
1117         Reviewed by Gustavo Noronha Silva.
1118
1119         Add tests cases for WebKitWebPage::context-menu signal.
1120
1121         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1122         (testContextMenuWebExtensionMenu):
1123         (testContextMenuWebExtensionNode):
1124         (beforeAll):
1125         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1126         (serializeContextMenu):
1127         (serializeNode):
1128         (contextMenuCallback):
1129         (pageCreatedCallback):
1130
1131 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1132
1133         Unreviewed, rolling out r175690.
1134         https://bugs.webkit.org/show_bug.cgi?id=138460
1135
1136         We are not ready to run layout tests using the network process
1137         yet (Requested by KaL on #webkit).
1138
1139         Reverted changeset:
1140
1141         "[GTK] Run layout tests using the network process"
1142         https://bugs.webkit.org/show_bug.cgi?id=138428
1143         http://trac.webkit.org/changeset/175690
1144
1145 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1146
1147         [GTK] Run layout tests using the network process
1148         https://bugs.webkit.org/show_bug.cgi?id=138428
1149
1150         Reviewed by Martin Robinson.
1151
1152         Shared secondary process is the default in the GTK+ port, but we
1153         should run the tests using the network process to ensure
1154         everything works with the network process. In the future, the
1155         shared secondary process model might be a special case of multiple
1156         processes with 1 as maximum number of processes, but always using
1157         the network process.
1158
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::TestController::initialize):
1161
1162 2014-11-05  Dan Bernstein  <mitz@apple.com>
1163
1164         Remove the unused deletion UI feature
1165         https://bugs.webkit.org/show_bug.cgi?id=138442
1166
1167         Rubber-stamped by Alexey Proskuryakov.
1168
1169         * DumpRenderTree/mac/EditingDelegate.mm:
1170         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1171         delegate method that’s been removed.
1172
1173 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1174
1175         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1176         https://bugs.webkit.org/show_bug.cgi?id=138334
1177
1178         Reviewed by Anders Carlsson.
1179
1180         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1181         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1182         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1183         it also needs to reset internal focus explicitly.
1184
1185         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1186         WebKit behavior appears wrong, but it matches Firefox.
1187
1188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1189         (WTR::InjectedBundlePage::resetAfterTest):
1190
1191 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1194         https://bugs.webkit.org/show_bug.cgi?id=137862
1195
1196         Reviewed by Gustavo Noronha Silva.
1197
1198         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1199         is emitted when a subresource load fails due to TLS errors.
1200
1201         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1202         (TLSSubresourceTest::resourceLoadStartedCallback):
1203         (TLSSubresourceTest::TLSSubresourceTest):
1204         (TLSSubresourceTest::subresourceFailedCallback):
1205         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1206         (TLSSubresourceTest::subresourceLoadStarted):
1207         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1208         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1209         (testSubresourceLoadFailedWithTLSErrors):
1210         (httpsServerCallback):
1211         (httpServerCallback):
1212         (beforeAll):
1213
1214 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1215
1216         Build fix for some compiler versions.
1217
1218         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1219         unhappy because this is a getter, and these shouldn't have side effects.
1220
1221 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1222
1223         Add a method for performing cherrypick-merges.
1224         https://bugs.webkit.org/show_bug.cgi?id=138375
1225
1226         Reviewed by Ryosuke Niwa.
1227
1228         Adds support for cherrypick-merges.
1229
1230         * Scripts/webkitpy/common/checkout/scm/git.py:
1231         (Git.cherrypick_merge): Added.
1232
1233 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1234
1235         Add a way to ascertain the SVN URL associated with a Git branch.
1236         https://bugs.webkit.org/show_bug.cgi?id=138374
1237
1238         Reviewed by Ryosuke Niwa.
1239
1240         The svn_url method returns the SVN URL associated with the current Git branch.
1241
1242         * Scripts/webkitpy/common/checkout/scm/git.py:
1243         (Git.svn_url): Added.
1244
1245 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1246
1247         Add the ability to search for modifications that are staged for commit.
1248         https://bugs.webkit.org/show_bug.cgi?id=138373
1249
1250         Reviewed by Ryosuke Niwa and Daniel Bates.
1251
1252         This makes is easy to do identify files that require merge post-processing,
1253         in addition to stand-alone utility.
1254
1255         * Scripts/webkitpy/common/checkout/scm/git.py:
1256         (Git.modifications_staged_for_commit): Added.
1257
1258 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1259
1260         Add a branch keyword argument to _run_git_svn_find_rev.
1261         https://bugs.webkit.org/show_bug.cgi?id=138372
1262
1263         Reviewed by Ryosuke Niwa.
1264
1265         The addition of this keyword argument allows clients to determine the Git hash
1266         of commits made on an SVN branch, provided that branch has been fetched locally.
1267
1268         * Scripts/webkitpy/common/checkout/scm/git.py:
1269         (Git._run_git_svn_find_rev):
1270         Add a branch keyword argument that is added to the end of the command, if present.
1271
1272 2014-11-04  Chris Dumez  <cdumez@apple.com>
1273
1274         Add ptr() method to Ref class
1275         https://bugs.webkit.org/show_bug.cgi?id=138361
1276
1277         Reviewed by Darin Adler.
1278
1279         Use the new Ref::ptr() method.
1280
1281         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1282         (TestWebKitAPI::TEST):
1283
1284 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1285
1286         [jhbuild] Make it possible to build GTK/EFL in same repository
1287         https://bugs.webkit.org/show_bug.cgi?id=137448
1288
1289         Reviewed by Martin Robinson.
1290
1291         * Scripts/webkitdirs.pm:
1292         (getJhbuildPath):
1293         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1294         (getPlatformFontsPath):
1295         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1296         (WTR::getFontsPath):
1297         * jhbuild/jhbuild-wrapper:
1298         (determine_platform):
1299         (install_jhbuild):
1300         * jhbuild/jhbuildrc_common.py:
1301         (init):
1302
1303 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1304
1305         [EFL] Bump LLVM to version 3.5.0
1306         https://bugs.webkit.org/show_bug.cgi?id=138312
1307
1308         Reviewed by Csaba Osztrogonác.
1309
1310         * efl/jhbuild.modules:
1311         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1312         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1313
1314 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1315
1316         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1317         https://bugs.webkit.org/show_bug.cgi?id=138257
1318
1319         Reviewed by Tim Horton.
1320         
1321         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1322         the user to toggle region page overlays on and off. Two overlays are available,
1323         for the non-fast scrollable region, and the region of element with wheel
1324         event handlers.
1325
1326         * MiniBrowser/mac/SettingsController.h:
1327         * MiniBrowser/mac/SettingsController.m:
1328         (-[SettingsController _populateMenu]):
1329         (-[SettingsController validateMenuItem:]):
1330         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1331         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1332         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1333         (-[SettingsController toggleDebugOverlay:]):
1334         (-[SettingsController debugOverlayVisible:]):
1335         * MiniBrowser/mac/WK2BrowserWindowController.m:
1336         (-[WK2BrowserWindowController didChangeSettings]):
1337
1338 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1339
1340         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1341         https://bugs.webkit.org/show_bug.cgi?id=138323
1342
1343         Reviewed by Zalan Bujtas.
1344
1345         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1346
1347 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1348
1349         [ninja] Don't remove response files for verbose builds
1350         https://bugs.webkit.org/show_bug.cgi?id=137816
1351
1352         Reviewed by Csaba Osztrogonác.
1353
1354         * Scripts/webkitdirs.pm:
1355         (determineNinjaVersion):
1356         (buildCMakeGeneratedProject):
1357
1358 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1359
1360         [GTK] Fix the build of FTL JIT
1361         https://bugs.webkit.org/show_bug.cgi?id=138298
1362
1363         Reviewed by Carlos Garcia Campos.
1364
1365         * gtk/jhbuild-optional.modules:
1366         Bump up LLVM version to 3.5.0 release and apply patches.
1367         * gtk/patches/llvm-elf-add-stackmaps.patch:
1368         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1369         trunk.
1370         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1371         Added. Ensures that PC-relative relocations in EH frames are not
1372         truncated to 32 bits on x86_64.
1373
1374 2014-10-31  Michael Saboff  <msaboff@apple.com>
1375
1376         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1377         https://bugs.webkit.org/show_bug.cgi?id=138268
1378
1379         Reviewed by Andreas Kling.
1380
1381         Added a --arch and --os option to set or override the values that are
1382         normally computed based on examining the JavaScriptCore we want to test.
1383
1384         * Scripts/run-jsc-stress-tests:
1385
1386 2014-10-31  Dan Bernstein  <mitz@apple.com>
1387
1388         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1389         https://bugs.webkit.org/show_bug.cgi?id=138259
1390
1391         Reviewed by Geoff Garen.
1392
1393         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1394         going to be empty to silence the warning.
1395
1396 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1397
1398         [GTK] Support script message handlers WebKitUserContentManager
1399         https://bugs.webkit.org/show_bug.cgi?id=133730
1400
1401         Reviewed by Carlos Garcia Campos.
1402
1403         Support user script message handlers in WebKitUserContentManager.
1404         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1405         an option is added to the CMake build files. The option is disabled
1406         globally by default, and the WebKitGTK port enables it. On the API
1407         level, two new methods to register and unregister names are provided
1408         in the "window.webkit" namespace, and on message reception the
1409         "WebKitUserContentManager::script-message-received" signal is
1410         emitted, using the registered names as signal detail.
1411
1412         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1413         Add test case for user script message handlers.
1414         (scriptMessageReceived):
1415         (testUserContentManagerScriptMessageReceived):
1416         (beforeAll):
1417
1418 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1419
1420         bisect-builds should support WebKit clients other than Safari
1421         https://bugs.webkit.org/show_bug.cgi?id=138225
1422
1423         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1424
1425         The -a / --application optional argument allows the user to specify which application (or application bundle)
1426         should be run against the WebKit nightly builds.
1427
1428         Reviewed by David Kilzer.
1429
1430         * Scripts/bisect-builds:
1431         Swap out $safariPath for the more general $applicationPath
1432         Leave --safari-path as a commandline option for backwards compatibility
1433         (mountAndRunNightly):
1434         Use File::Spec->cat correctly (one directory per argument)
1435         Use open --wait-apps instead of running the target application directly
1436
1437 2014-10-30  Dana Burkart  <dburkart@apple.com>
1438
1439         <rdar://problem/18821260> Perpare for the mysterious future
1440
1441         Reviewed by Lucas Forschler.
1442
1443         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1444         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1445         * LayoutTestRelay/Configurations/Base.xcconfig:
1446         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1447         * MiniBrowser/Configurations/Base.xcconfig:
1448         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1449         * TestWebKitAPI/Configurations/Base.xcconfig:
1450         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1451         * WebKitLauncher/Configurations/Base.xcconfig:
1452         * WebKitTestRunner/Configurations/Base.xcconfig:
1453         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1454
1455 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1456
1457         Update safariVersion to safariVersionString
1458         https://bugs.webkit.org/show_bug.cgi?id=138193
1459
1460         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1461         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1462
1463         Rubber-stamped by David Kilzer.
1464
1465         * Scripts/bisect-builds:
1466         (makeNightlyList):
1467         Compare safariVersionString to a string literal, instead of safariVersion.
1468
1469 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1470
1471         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1472         https://bugs.webkit.org/show_bug.cgi?id=137775
1473
1474         Reviewed by Carlos Garcia Campos.
1475
1476         * MiniBrowser/gtk/BrowserWindow.c:
1477         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1478         (browser_window_init):
1479
1480 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1481
1482         CommitQueue and EWS should reject any patches that result in consistent test
1483         failures that aren't present on the tree.
1484         https://bugs.webkit.org/show_bug.cgi?id=138184
1485
1486         Reviewed by Alexey Proskuryakov.
1487
1488         * Scripts/webkitpy/layout_tests/models/test_results.py:
1489         Adds a simple hashing function to allow for set operations to handle
1490         TestResult objects properly.
1491         (TestResult.__hash__):
1492         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1493         Adds one unit test, and modifies others to agree with the notion that
1494         patches that introduce new test failures (but also have flakyness)
1495         should be rejected rather than spin.
1496         (MockCommitQueue.report_flaky_tests):
1497         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1498         (test_double_flaky_test_failure):
1499         (test_two_flaky_tests):
1500         (test_very_flaky_patch):
1501         (test_very_flaky_patch_with_some_tree_redness):
1502         (test_different_test_failures):
1503         (test_different_test_failures_with_some_tree_redness):
1504         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1505         (test_mildly_flaky_patch):
1506         (test_mildly_flaky_patch_with_some_tree_redness):
1507         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1508         Makes PatchAnalysisTask reject said patches.
1509         (PatchAnalysisTask._test_patch):
1510
1511 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1512
1513         WinCairoRequirements.zip cannot be downloaded from dropbox
1514         https://bugs.webkit.org/show_bug.cgi?id=138113
1515
1516         Reviewed by Alexey Proskuryakov.
1517
1518         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1519
1520 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1521
1522         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1523         https://bugs.webkit.org/show_bug.cgi?id=138193
1524
1525         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1526         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1527
1528         It also does a bit of refactoring, including distinguishing between versions and version strings and
1529         saving versions to local variables instead of using eval in each conditional.
1530
1531         Reviewed by David Kilzer.
1532
1533         * Scripts/bisect-builds:
1534         (makeNightlyList):
1535         Restrict the set of nightlies to r174650 and above when running Yosemite.
1536         Restrict the set of nightlies to r157846 and above when running Mavericks.
1537         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1538
1539 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1540
1541         [EFL] build-webkit should try harder to avoid re-running cmake
1542         https://bugs.webkit.org/show_bug.cgi?id=137949
1543
1544         Reviewed by Martin Robinson.
1545
1546         * Scripts/webkitdirs.pm:
1547         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1548         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1549
1550 2014-10-28  Daniel Bates  <dabates@apple.com>
1551
1552         Unify logic in RunTests.run() to run the Python unit tests
1553         https://bugs.webkit.org/show_bug.cgi?id=138160
1554
1555         Reviewed by Martin Robinson.
1556
1557         Unify the interactive and non-interactive code path for running the Python unit tests
1558         in step RunTests so as to remove duplicate code to compute the the path to the script
1559         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1560
1561         No new tests since no functionality was changed.
1562
1563         * Scripts/webkitpy/port/base.py:
1564         (Port.python_unittest_results_directory):
1565         * Scripts/webkitpy/tool/steps/runtests.py:
1566         (RunTests.run):
1567
1568 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1569
1570         Make runtest.py call test-webkitpy with the --json flag when in
1571         non-interactive mode.
1572         https://bugs.webkit.org/show_bug.cgi?id=137667
1573
1574         Reviewed by Daniel Bates.
1575
1576         * Scripts/webkitpy/port/base.py:
1577         Adds the python_unittest_results_directory method.
1578         (Port.python_unittest_results_directory):
1579         * Scripts/webkitpy/tool/steps/runtests.py:
1580         Changes RunTests to call test-webkitpy with the --json flag if the
1581         --non-interactive flag is set.
1582         (RunTests):
1583         (RunTests.run):
1584
1585 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1586
1587         import-w3c-tests should use re.escape() wherever it's handling file paths
1588         https://bugs.webkit.org/show_bug.cgi?id=137934
1589
1590         This patch adds re.escape() to a few places where we're doing string
1591         conversions. This prevents errors when attribute values coincidentally
1592         have character sequences that can be interpreted as regular expressions.
1593
1594         Reviewed by Bem Jones-Bey.
1595
1596         * Scripts/webkitpy/w3c/test_converter.py:
1597         (_W3CTestConverter.convert_attributes_if_needed):
1598
1599 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1600
1601         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1602         https://bugs.webkit.org/show_bug.cgi?id=138130
1603
1604         Reviewed by Csaba Osztrogonác.
1605
1606         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1607
1608 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1609
1610         Fix link to Arch Linux Wiki
1611         https://bugs.webkit.org/show_bug.cgi?id=138010
1612
1613         Reviewed by Benjamin Poulain.
1614
1615         * gtk/install-dependencies:
1616
1617 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1618
1619         Test regressions are not detected when image result is missing
1620         https://bugs.webkit.org/show_bug.cgi?id=138070
1621
1622         Reviewed by Simon Fraser.
1623
1624         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1625         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1626         Count these as regressions, not as flaky tests.
1627
1628         * Scripts/webkitpy/port/test.py:
1629         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1630         Test it.
1631
1632 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
1633
1634         Add Conrad Shultz to the contributors list.
1635
1636         * Scripts/webkitpy/common/config/contributors.json:
1637
1638 2014-10-24  Dan Bernstein  <mitz@apple.com>
1639
1640         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1641         https://bugs.webkit.org/show_bug.cgi?id=138046
1642
1643         Reviewed by Alexey Proskuryakov.
1644
1645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1646         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1647         401. Otherwise, we’ll retry normally in 45 seconds.
1648
1649 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1650
1651         [GTK] Implement is_selected method on WebKitHitTestResult
1652         https://bugs.webkit.org/show_bug.cgi?id=137110
1653
1654         Reviewed by Tim Horton.
1655
1656         Add tests for new context SELECTION on WebKitHitTestResult.
1657
1658         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1659         (testContextMenuDefaultMenu):
1660         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1661         (testWebViewMouseTarget):
1662
1663 2014-10-23  Roger Fong  <roger_fong@apple.com>
1664
1665         [Win] Skip failing JSC tests following r175078
1666         https://bugs.webkit.org/show_bug.cgi?id=130967.
1667
1668         * Scripts/run-javascriptcore-tests:
1669
1670 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1671
1672         commitqueuetask_unittest.py should be made more concise.
1673         https://bugs.webkit.org/show_bug.cgi?id=137985
1674
1675         Reviewed by Alexey Proskuryakov.
1676
1677         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1678         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1679         (MockCommitQueue.__init__):
1680         (MockCommitQueue.report_flaky_tests):
1681         (MockCommitQueue):
1682         (MockCommitQueue.get_reported_flaky_tests):
1683         (MockSimpleTestPlanCommitQueue.__init__):
1684         (MockSimpleTestPlanCommitQueue.run_command):
1685         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1686         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1687         (test_land_failure):
1688         (test_failed_archive):
1689         (test_double_flaky_test_failure):
1690         (test_test_failure):
1691         (test_red_test_failure):
1692         (test_very_red_tree_retry):
1693         (test_red_tree_patch_rejection):
1694         (test_one_flaky_test):
1695         (test_tree_more_red_than_patch):
1696         (MockCommitQueue.test_results): Deleted.
1697         (test_simple_flaky_test_failure): Deleted.
1698         (_expect_validate): Deleted.
1699         (_expect_validate.MockDelegate): Deleted.
1700         (_expect_validate.MockDelegate.refetch_patch): Deleted.
1701         (_expect_validate.MockDelegate.expected_failures): Deleted.
1702         (_mock_patch): Deleted.
1703         (test_validate): Deleted.
1704         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1705         Fixes a bug that slipped through the cracks prior to this change.
1706         (PatchAnalysisTask._test_patch):
1707
1708 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
1709
1710         Flakiness dashboard should support OS X Yosemite
1711         https://bugs.webkit.org/show_bug.cgi?id=137986
1712
1713         Reviewed by Ryosuke Niwa.
1714
1715         * TestResultServer/app.yaml:
1716         * TestResultServer/static-dashboards/builders.jsonp:
1717         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1718
1719 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1720
1721         commitqueuetask should include more tests to ensure that the behavior
1722         of PatchAnalysisTask._test_patch() is well defined
1723         https://bugs.webkit.org/show_bug.cgi?id=137977
1724
1725         Reviewed by Alexey Proskuryakov.
1726
1727         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1728         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1729         and more readable to define tests that are meant to test the behaviour
1730         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1731         (FailingTestCommitQueue.test_results):
1732         (PatchAnalysisResult):
1733         (MockSimpleTestPlanCommitQueue):
1734         (MockSimpleTestPlanCommitQueue.__init__):
1735         (MockSimpleTestPlanCommitQueue.run_command):
1736         (MockSimpleTestPlanCommitQueue._mock_test_result):
1737         (MockSimpleTestPlanCommitQueue.test_results):
1738         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1739         (test_flaky_test_failure):
1740         (test_failed_archive):
1741         (test_two_flaky_tests):
1742         (test_one_flaky_test):
1743         (test_very_flaky_patch):
1744         (test_very_flaky_patch_with_some_tree_redness):
1745         (test_different_test_failures):
1746         (test_different_test_failures_with_some_tree_redness):
1747         (test_mildly_flaky_patch):
1748         (test_mildly_flaky_patch_with_some_tree_redness):
1749         (test_tree_more_red_than_patch):
1750
1751 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1752
1753         PatchAnalysisTask._test_patch() needs refactoring
1754         https://bugs.webkit.org/show_bug.cgi?id=137904
1755
1756         Reviewed by Alexey Proskuryakov.
1757
1758         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1759         Fixes several small bugs, and makes minor changes to accomodate the
1760         changes in PatchAnalysisTask.
1761         (MockCommitQueue.refetch_patch):
1762         (MockCommitQueue.test_results):
1763         (test_flaky_test_failure):
1764         (test_failed_archive):
1765         (test_very_red_tree_retry):
1766         (_expect_validate.MockDelegate.refetch_patch):
1767         (MockCommitQueue.expected_failures): Deleted.
1768         (_expect_validate.MockDelegate.expected_failures): Deleted.
1769         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1770         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1771         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1772         Removes the unexpected_failures member, adds the _clean_tree_results
1773         member, adds a helper function for _test_patch, and refactors
1774         _test_patch to be more readable.
1775         (PatchAnalysisTask.__init__):
1776         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1777         (PatchAnalysisTask._test_patch):
1778         (PatchAnalysisTask.results_from_test_run_without_patch):
1779         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1780         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1781         (AbstractEarlyWarningSystem.begin_work_queue):
1782         (AbstractEarlyWarningSystem._failing_tests_message):
1783         (AbstractEarlyWarningSystem.command_failed):
1784         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1785         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1786         Makes changes to accomodate the changes made to PatchAnalysisTask.
1787         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1788         * Scripts/webkitpy/tool/commands/perfalizer.py:
1789         Removes Perfalizer's dependancy on ExpectedFailures. 
1790         (PerfalizerTask.refetch_patch):
1791         (PerfalizerTask.expected_failures): Deleted.
1792         * Scripts/webkitpy/tool/commands/queues.py:
1793         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1794         initializer to allow for mock injection.
1795         (CommitQueue.__init__):
1796         (CommitQueue.begin_work_queue):
1797         (CommitQueue.process_work_item):
1798         (CommitQueue._failing_tests_message):
1799         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1800         Removes dependancy on ExpectedFailures, and instead uses mock
1801         injection.
1802         (MockCommitQueueTask):
1803         (MockCommitQueueTask.results_from_patch_test_run):
1804         (MockCommitQueueTask.results_from_test_run_without_patch):
1805         (mock_run_webkit_patch):
1806
1807 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1808
1809         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1810         https://bugs.webkit.org/show_bug.cgi?id=136736
1811
1812         Reviewed by Gyuyoung Kim.
1813
1814         * MiniBrowser/efl/main.c:
1815         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1816         (window_create):
1817
1818 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1819
1820         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1821         https://bugs.webkit.org/show_bug.cgi?id=137884
1822
1823         Reviewed by Gustavo Noronha Silva.
1824
1825         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1826         and adapt it to use the new InputMethodFilter WebKit class. Instead
1827         of having virtual methods just for testing, it has a testing mode
1828         that logs the events.
1829
1830         * TestWebKitAPI/PlatformGTK.cmake:
1831         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1832         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1833         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1834         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1835         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1836         (TestWebKitAPI::TEST):
1837         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1838         (TestWebKitAPI::temporaryResetOverride):
1839         (TestWebKitAPI::verifyCanceledComposition):
1840
1841 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1842
1843         build.webkit.org/dashboard: Cannot click on green tester bubbles
1844         https://bugs.webkit.org/show_bug.cgi?id=137909
1845
1846         Reviewed by Darin Adler.
1847
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1849         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1850
1851 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1852
1853         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1854         https://bugs.webkit.org/show_bug.cgi?id=137932
1855
1856         Reviewed by Simon Fraser.
1857
1858         This is the first step in moving over to native Windows rendering for our layout tests.
1859         Once this change lands, approximately 300 tests will start failing on Windows. I will
1860         rebaseline these changes against our test hardware and update this bug with the
1861         commits related to that work.
1862
1863         * DumpRenderTree/win/DumpRenderTree.cpp:
1864         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1865         we use native Windows drawing style.
1866
1867 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1868
1869         Fix FTL Native Inlining for EFL
1870         https://bugs.webkit.org/show_bug.cgi?id=137774
1871
1872         Reviewed by Michael Saboff.
1873
1874         Added Clang as an optional module to jhbuild.
1875
1876         * efl/jhbuild.modules:
1877
1878 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1879
1880         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1881         https://bugs.webkit.org/show_bug.cgi?id=137832
1882
1883         Reviewed by Carlos Garcia Campos.
1884
1885         Ensure each test sets the TLS errors policy that it really needs.
1886         Have each test except testTLSErrorsPolicy stash and restore the original
1887         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1888         default policy.
1889
1890         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1891         (testSSL):
1892         (testInsecureContent):
1893         (testTLSErrorsPolicy):
1894         (testTLSErrorsRedirect):
1895         (testTLSErrorsHTTPAuth):
1896         (testLoadFailedWithTLSErrors):
1897         (beforeAll):
1898
1899 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1900
1901         Unreviewed. Unskip inspector server unit tests.
1902
1903         They should pass now.
1904
1905         * Scripts/run-gtk-tests:
1906         (TestRunner):
1907
1908 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1909
1910         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1911         https://bugs.webkit.org/show_bug.cgi?id=132044
1912
1913         Reviewed by Brian Burg.
1914
1915         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1916         (openRemoteDebuggingSession): Remove trailing slash when
1917         concatenating base inspector URL with the page, because the
1918         inspector returns the relative paths with a leading slash.
1919
1920 2014-10-20  Tanay C  <tanay.c@samsung.com>
1921
1922         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1923         https://bugs.webkit.org/show_bug.cgi?id=137023
1924
1925         Reviewed by Gyuyoung Kim.
1926
1927         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1928         (search_box_show): Modified.
1929         (search_box_hide): Modified.
1930         (on_search_field_activated): Modified.
1931         (on_search_backward_button_clicked): Modified.
1932         (on_search_forward_button_clicked): Modified.
1933         (on_search_case_option_changed): Added.
1934         (on_search_word_start_option_changed): Added.
1935         (window_create): Modified.
1936
1937 2014-10-20  Tanay C  <tanay.c@samsung.com>
1938
1939         [GTK][Minibrowser] Escape key does not hide the search box
1940         https://bugs.webkit.org/show_bug.cgi?id=137734
1941
1942         Reviewed by Philippe Normand.
1943
1944         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1945         (stopPageLoad): Modified.
1946
1947 2014-10-18  Antti Koivisto  <antti@apple.com>
1948
1949         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1950         https://bugs.webkit.org/show_bug.cgi?id=137855
1951
1952         Reviewed by Dan Bernstein.
1953
1954         Test and warn if the dumped response mime type differs from the platform response mime type.
1955
1956         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1957         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1958         (WTR::InjectedBundlePage::platformResponseMimeType):
1959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1960         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1961         (WTR::InjectedBundlePage::platformResponseMimeType):
1962
1963 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1964
1965         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1966         https://bugs.webkit.org/show_bug.cgi?id=137835
1967
1968         Reviewed by Andreas Kling.
1969
1970         * Scripts/run-inspector-perf-tests.py: Removed.
1971         This script is stale, as PerformanceTests/inspector no longer exists.
1972
1973 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1974
1975         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1976
1977         * Scripts/webkitpy/port/ios.py:
1978         (IOSSimulatorPort.default_baseline_search_path):
1979
1980 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1981
1982         [iOS] Simplify test fallback paths for iOS Simulator testing
1983         https://bugs.webkit.org/show_bug.cgi?id=137830
1984
1985         Reviewed by Zalan Bujtas.
1986         
1987         Make the fallback paths be:
1988             ios-simulator -> generic
1989             ios-simulator-wk2->ios-simulator -> generic
1990         
1991         so don't include mac in the fallback path. Also remove the
1992         version handling for simplicity.
1993
1994         * Scripts/webkitpy/port/ios.py:
1995         (IOSSimulatorPort):
1996         (IOSSimulatorPort.default_baseline_search_path):
1997
1998 2014-10-17  Dana Burkart  <dburkart@apple.com>
1999
2000         Fix typos in the dashboard config file.
2001
2002         Unreviewed.
2003
2004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2005         (WebKitBuildbot):
2006
2007 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2008
2009         [Win] Allow WinLauncher to specify Custom User Agent strings
2010         https://bugs.webkit.org/show_bug.cgi?id=137828
2011
2012         Reviewed by Dean Jackson.
2013
2014         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2015         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2016         and set the user agent strings.
2017         * WinLauncher/WinLauncher.h:
2018         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2019         resources and dialog for setting custom User Agent strings.
2020         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2021
2022 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2023
2024         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2025         https://bugs.webkit.org/show_bug.cgi?id=137806
2026
2027         Reviewed by Sam Weinig.
2028
2029         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2030         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2031         to disable font autosizing.
2032         
2033         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2034         test controller to set platform-specific prefs.
2035
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::resetPreferencesToConsistentValues):
2038         (WTR::TestController::platformResetPreferencesToConsistentValues):
2039         * WebKitTestRunner/TestController.h:
2040         * WebKitTestRunner/ios/TestControllerIOS.mm:
2041         (WTR::TestController::platformResetPreferencesToConsistentValues):
2042         * WebKitTestRunner/mac/TestControllerMac.mm:
2043         (WTR::TestController::platformResetPreferencesToConsistentValues):
2044
2045 2014-10-16  Dan Bernstein  <mitz@apple.com>
2046
2047         OSObjectPtr is missing leakRef()
2048         https://bugs.webkit.org/show_bug.cgi?id=137798
2049
2050         Reviewed by Sam Weinig.
2051
2052         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2053         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2054
2055 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2056
2057         Update target platform to remove Leopard, Snow Leopard, Lion.
2058         Add Yosemite. 
2059         
2060         Unreviewed.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2063         (_should_file_trigger_build):
2064
2065 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2066
2067         commit-queue: fails to replace OO-PS! with reviewer name
2068         <http://webkit.org/b/137795>
2069
2070         Reviewed by Alexey Proskuryakov.
2071
2072         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2073         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2074         email addresses to unauthenticated page loads, so we must always
2075         authenticate before getting bug data so we get full email
2076         addresses.
2077
2078 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2079
2080         commit-queue: fails to close bugs after successfully landing patches
2081         <http://webkit.org/b/137794>
2082
2083         Reviewed by Alexey Proskuryakov.
2084
2085         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2086         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2087         tell Mechanize to use the second <textarea> on the page with
2088         name="comment".
2089
2090 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2091
2092         [Win] Update DRT to match Mac Logic
2093         https://bugs.webkit.org/show_bug.cgi?id=137787
2094
2095         Reviewed by Dean Jackson.
2096
2097         * DumpRenderTree/win/DumpRenderTree.cpp:
2098         (initialize): 0 -> nullptr
2099         (runTest): Initialize MSG structure before using.
2100         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2101         Also, cleanly shut down COM when exiting.
2102         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2103         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2104         header and add printf to match Mac.
2105         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2106         * DumpRenderTree/win/FrameLoadDelegate.h:
2107         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2108         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2109         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2110         (isLocalhost): Added.
2111         (hostIsUsedBySomeTestsToGenerateError): Added.
2112         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2113         of certain error and redirect host names.
2114         * DumpRenderTree/win/UIDelegate.cpp:
2115         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2116         anything should be output to the console. This modifies behavior to match the Mac.
2117         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2118         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2119         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2120         (UIDelegate::webViewAddMessageToConsole): Ditto.
2121         * WinLauncher/PageLoadTestClient.cpp:
2122         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2123         added last week.
2124
2125 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2126
2127         Unreviewed, rolling out r174754.
2128         https://bugs.webkit.org/show_bug.cgi?id=137789
2129
2130         Speculative fix for Windows test was ineffective. (Requested
2131         by rfong on #webkit).
2132
2133         Reverted changeset:
2134
2135         "[Windows] Add some more logging to debug Windows test
2136         issues."
2137         http://trac.webkit.org/changeset/174754
2138
2139 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2140
2141         Unreviewed, add myself to CoordinatedGraphics watchers.
2142
2143         * Scripts/webkitpy/common/config/watchlist:
2144
2145 2014-10-15  Roger Fong  <roger_fong@apple.com>
2146
2147         [Windows] Speculative Windows test fix.
2148
2149         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2150
2151 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2152
2153         import-w3c-test rewrites relative src paths in ref files incorrectly
2154         https://bugs.webkit.org/show_bug.cgi?id=137586
2155
2156         This patch fixes a bug in test_converter.py where src paths were getting 
2157         rewritten as ../../some-path instead of <script src="../../some-path>". 
2158         It also adds support for rewriting src paths in style  elements, which was 
2159         missing before and it adds tests for this case.
2160
2161         Reviewed by Bem Jones-Bey.
2162
2163         * Scripts/webkitpy/w3c/test_converter.py:
2164         (_W3CTestConverter.convert_attributes_if_needed):
2165         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2166         (test_convert_attributes_if_needed):
2167         (verify_reference_relative_paths):
2168
2169 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2170
2171         Add --json flag to test-webkitpy to emit JSON formatted test results
2172         to stdout
2173         https://bugs.webkit.org/show_bug.cgi?id=137353
2174
2175         Reviewed by Daniel Bates.
2176
2177         * Scripts/webkitpy/port/server_process_unittest.py:
2178         Adds the read method to MockFile to allow the stdout of test_webkitpy
2179         to be redirected without causing erroneous test failures.
2180         In particular,
2181         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2182         and
2183         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2184         because when redirecting to a file, the
2185         _wait_for_data_and_update_buffers_using_select method in 
2186         server_process.py will find that there is a read file descriptor in
2187         its call to select.select, which eventually leads to it calling read()
2188         on the MockFile object.
2189         (MockFile.read):
2190         * Scripts/webkitpy/test/main.py:
2191         Adds the _print_results_as_json method and the --json flag which
2192         determines whether _print_results_as_json will get called.
2193         (Tester._parse_args):
2194         (Tester._print_results_as_json):
2195         (Tester._print_results_as_json.result_dict_from_tuple):
2196         (Tester._run_tests):
2197
2198 2014-10-13  David Farler  <dfarler@apple.com>
2199
2200         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2201         https://bugs.webkit.org/show_bug.cgi?id=137662
2202
2203         Reviewed by Darin Adler.
2204
2205         The layout test harness can close LayoutTestRelay's subprocess
2206         stdout and stderr in the case of a timeout or if a run is
2207         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2208         finds that no one is listening to its stdout/stderr (broken
2209         pipe), then just exit(1), there is nothing to report.
2210
2211         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2212         (-[LTRelayController didReceiveStdoutData:]):
2213         Add @try/@catch for NSFileHandleOperationException.
2214         (-[LTRelayController didReceiveStderrData:]):
2215         Add @try/@catch for NSFileHandleOperationException.
2216
2217 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2218
2219         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2220         https://bugs.webkit.org/show_bug.cgi?id=137060
2221
2222         Reviewed by Philippe Normand.
2223
2224         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2225
2226         * MiniBrowser/gtk/BrowserWindow.c:
2227         (zoomInCallback):
2228         (zoomOutCallback):
2229         (defaultZoomCallback): Callback for default zoom keyboard support.
2230         (browser_window_init):
2231
2232 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2233
2234         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2235
2236         Reviewed by Alexey Proskuryakov.
2237         
2238         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2239         logging to stderr to get associated with the next test.
2240         
2241         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2242
2243         * DumpRenderTree/mac/DumpRenderTree.mm:
2244         (dumpTestResults):
2245         (runTest):
2246
2247 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2248
2249         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2250
2251         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2252
2253 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         [cmake] Fix the make build after r174683
2256         https://bugs.webkit.org/show_bug.cgi?id=137703
2257
2258         Reviewed by Martin Robinson.
2259
2260         * Scripts/webkitdirs.pm:
2261         (buildCMakeGeneratedProject):
2262
2263 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2264
2265         Adding myself to the watchlist to CachedFont
2266
2267         Unreviewed.
2268
2269         * Scripts/webkitpy/common/config/watchlist:
2270
2271 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2272
2273         [EFL][GTK] Make it possible to get verbose output with ninja
2274         https://bugs.webkit.org/show_bug.cgi?id=137606
2275
2276         Reviewed by Csaba Osztrogonác.
2277
2278         * Scripts/webkitdirs.pm:
2279         (buildCMakeGeneratedProject):
2280
2281 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2282
2283         [EFL] Make it possible to use ninja for EFL build too
2284         https://bugs.webkit.org/show_bug.cgi?id=137605
2285
2286         Reviewed by Csaba Osztrogonác.
2287
2288         * Scripts/webkitdirs.pm:
2289         (generateBuildSystemFromCMakeProject):
2290         * efl/install-dependencies:
2291
2292 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2293
2294         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2295         https://bugs.webkit.org/show_bug.cgi?id=137486
2296
2297         Reviewed by Philippe Normand.
2298
2299         * MiniBrowser/gtk/BrowserWindow.c:
2300         (loadHomePage): Callback for home page load.
2301         (browser_window_init):
2302         * MiniBrowser/gtk/BrowserWindow.h:
2303         * MiniBrowser/gtk/main.c:
2304         (main):
2305
2306 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2307
2308         import-w3c-tests doesn't prefix property values
2309         https://bugs.webkit.org/show_bug.cgi?id=137600
2310
2311         Reviewed by Bem Jones-Bey.
2312
2313         Some property values are prefixed in WebKit. Modified the W3C import
2314         script in order to prefix property values and not only properties.
2315         The patch re-uses most of the already existent logic to prefix
2316         properties.
2317
2318         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2319         from CSSValueKeywords.in and adapt converter to modify both properties
2320         and property values.
2321         (convert_for_webkit):
2322         (_W3CTestConverter.__init__):
2323         (_W3CTestConverter.output):
2324         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2325         (_W3CTestConverter):
2326         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2327         (_W3CTestConverter.add_webkit_prefix_following_regex):
2328         (_W3CTestConverter.convert_reference_relpaths):
2329         (_W3CTestConverter.convert_style_data):
2330         (_W3CTestConverter.convert_attributes_if_needed):
2331         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2332         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2333         include checks for property values too.
2334         (W3CTestConverterTest.test_read_prefixed_property_list):
2335         (verify_no_conversion_happened):
2336         (verify_prefixed_properties):
2337         (verify_prefixed_property_values):
2338         (generate_test_content_properties_and_values):
2339         (generate_test_content):
2340         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2341         prefixed property values and inform about them.
2342         (TestImporter.import_tests):
2343         (TestImporter.write_import_log):
2344
2345 2014-10-13  Jer Noble  <jer.noble@apple.com>
2346
2347         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2348         https://bugs.webkit.org/show_bug.cgi?id=137533
2349
2350         Reviewed by Andy Estes.
2351
2352         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2353
2354         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2355         (TestWebKitAPI::isMSEEnabledCallback):
2356         (TestWebKitAPI::TEST):
2357
2358 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2359
2360         [Win] Implement a page load profiling tool
2361         https://bugs.webkit.org/show_bug.cgi?id=137673
2362
2363         Reviewed by Dean Jackson.
2364
2365         Add a tool to capture and summarize page load statistics.
2366
2367         * WinLauncher/Common.cpp:
2368         (parseCommandLine): Move from WinMain.cpp so that it can
2369         be shared with internal tools.
2370         * WinLauncher/PageLoadTestClient.cpp: Added.
2371         (PageLoadTestClient::PageLoadTestClient):
2372         (PageLoadTestClient::pageLoadStartedAtTime):
2373         (PageLoadTestClient::didStartProvisionalLoad):
2374         (PageLoadTestClient::didCommitLoad):
2375         (PageLoadTestClient::didFirstLayoutForMainFrame):
2376         (PageLoadTestClient::didHandleOnLoadEvents):
2377         (PageLoadTestClient::didFinishLoad):
2378         (PageLoadTestClient::didFailLoad):
2379         (PageLoadTestClient::didInitiateResourceLoad):
2380         (PageLoadTestClient::didEndResourceLoad):
2381         (PageLoadTestClient::pageLoadEndedAtTime):
2382         (PageLoadTestClient::endPageLoad):
2383         (PageLoadTestClient::clearPageLoadState):
2384         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2385         (PageLoadTestClient::maybeEndPageLoadSoon):
2386         (PageLoadTestClient::setPageURL):
2387         (PageLoadTestClient::dumpRunStatistics):
2388         * WinLauncher/PrintWebUIDelegate.cpp:
2389         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2390         nullptr URL properly.
2391         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2392         (ResourceLoadDelegate::QueryInterface):
2393         (ResourceLoadDelegate::AddRef):
2394         (ResourceLoadDelegate::Release):
2395         (ResourceLoadDelegate::identifierForInitialRequest):
2396         (ResourceLoadDelegate::willSendRequest):
2397         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2398         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2399         (ResourceLoadDelegate::didReceiveResponse):
2400         (ResourceLoadDelegate::didReceiveContentLength):
2401         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2402         (ResourceLoadDelegate::didFailLoadingWithError):
2403         (ResourceLoadDelegate::plugInFailedWithError):
2404         * WinLauncher/ResourceLoadDelegate.h: Added.
2405         (ResourceLoadDelegate::ResourceLoadDelegate):
2406         * WinLauncher/WinLauncher.cpp:
2407         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2408         page loading statistics.
2409         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2410         and set private load delegate state.
2411         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2412         that sets the view's resource load delegate.
2413         (WinLauncher::loadURL): If no URL is passed, load the test document.
2414         * WinLauncher/WinLauncher.h:
2415         (WinLauncher::pageLoadTestClient):
2416         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2417         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2418         * WinLauncher/WinLauncherWebHost.cpp:
2419         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2420         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2421         it could be used from other source files.
2422         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2423         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2424         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2425         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2426         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2427         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2428         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2429         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2430         * WinLauncher/WinLauncherWebHost.h:
2431         * WinLauncher/WinMain.cpp:
2432         (wWinMain): Create and use new delegates for gathering page load data.
2433         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2434
2435 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2436
2437         Improve the test image diffs page
2438         https://bugs.webkit.org/show_bug.cgi?id=137674
2439
2440         Reviewed by Alexey Proskuryakov.
2441         
2442         Don't treat the input file as a format string, otherwise we have to escape special
2443         characters. Just do a couple of replaces.
2444
2445         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2446         (TestResultWriter.write_image_diff_files):
2447
2448 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2449
2450         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2451         https://bugs.webkit.org/show_bug.cgi?id=137659
2452
2453         Reviewed by Martin Robinson.
2454
2455         * Scripts/webkitpy/port/xvfbdriver.py:
2456         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2457
2458 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2459
2460         Add more detailed wait time information to EWS metrics
2461         https://bugs.webkit.org/show_bug.cgi?id=137649
2462
2463         Reviewed by Daniel Bates.
2464
2465         Added average and worst time (we used to only have median), and also a percentage
2466         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2467
2468         There is always some wait due to the polling nature of the queues, which is well understood
2469         and doesn't need to be measured. What needs to be measured is whether there is enough
2470         bot machines to process patches as soon as they are submitted.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2473         (Analyzer.prototype._analyzeBubblePerformance):
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2475         (MetricsBubbleView.prototype._update):
2476
2477 2014-10-11  Jer Noble  <jer.noble@apple.com>
2478
2479         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2480         https://bugs.webkit.org/show_bug.cgi?id=137533
2481
2482         Reviewed by Darin Adler.
2483
2484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2485         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2488         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2489
2490 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2491
2492         iOS DRT snapshots are limited to the page visible area
2493         https://bugs.webkit.org/show_bug.cgi?id=137650
2494
2495         Reviewed by Daniel Bates.
2496         
2497         LegacyTileCache drawing was limited to the window's visible area, found by
2498         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2499         be missing non-composited content outside the iPhone visible area, which hinders
2500         testing.
2501         
2502         Fix by adding a test-only mode where the window visible area is the entire window.
2503         
2504         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2505         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2506         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2507         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2508         for the DRT window.
2509         
2510
2511 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2512
2513         Page not fully rendered in iOS DRT snapshots
2514         https://bugs.webkit.org/show_bug.cgi?id=137638
2515
2516         Reviewed by Tim Horton.
2517         
2518         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2519         to ensure that the page has laid out and is rendered by the time we take
2520         the snapshot.
2521
2522         * DumpRenderTree/mac/DumpRenderTree.mm:
2523         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2524         (-[DumpRenderTree _webThreadInvoked]): Moved.
2525         (-[DumpRenderTree _waitForWebThreadThenDump]):
2526         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2527         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2528         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2529         relies on dispatch_async too, and the inner block won't complete until the outer block
2530         has completed.
2531         (dumpTestResults): Move the guts of dump() here.
2532         (runTest): Whitespace.
2533
2534 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2535
2536         Adding svn:ignore so that .pyc files don't show up as new.
2537
2538         * Scripts/webkitpy/xcode: Added property svn:ignore.
2539
2540 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2541
2542         [EFL] Introduce EWebKit_Extension
2543         https://bugs.webkit.org/show_bug.cgi?id=134921
2544
2545         Reviewed by Gyuyoung Kim.
2546
2547         * MiniBrowser/efl/main.c: Added x option to test extension path.
2548         (window_create):
2549         (elm_main):
2550         * Scripts/webkitpy/common/config/watchlist:
2551         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2552         * Scripts/webkitpy/style/checker.py:
2553         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2554
2555 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2556
2557         After r174628 we send the test process a SIGTERM before the SIGKILL.
2558
2559         * Scripts/webkitpy/common/system/executive_unittest.py:
2560         (ExecutiveTest.serial_test_kill_process):
2561
2562 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2563
2564         [EFL] Enable WebP support.
2565         https://bugs.webkit.org/show_bug.cgi?id=136156
2566
2567         Reviewed by Gyuyoung Kim.
2568
2569         Include libwebp-dev package to support WebP for WK2 Efl.
2570
2571         * efl/install-dependencies:
2572
2573 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2574
2575         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2576         https://bugs.webkit.org/show_bug.cgi?id=137485
2577
2578         Reviewed by Sergio Villar Senin.
2579
2580         Update GMainLoopSource tests. Most of the tests are now run twice,
2581         first with a GMainLoopSource and then with a
2582         GThreadSafeMainLoopSource, since both should have the same
2583         behaviour. The threading test uses GThreadSafeMainLoopSource and
2584         the delete on destroy test uses GMainLoopSource. The tests
2585         themselves haven't changed, since there's no change in behaviour.
2586
2587         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2588         (TestWebKitAPI::GMainLoopSourceTest::source):
2589         (TestWebKitAPI::basicRescheduling):
2590         (TestWebKitAPI::TEST):
2591         (TestWebKitAPI::reentrantRescheduling):
2592         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2593         (TestWebKitAPI::basicDestroyCallbacks):
2594         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2595         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2596
2597 2014-10-10  Dana Burkart  <dburkart@apple.com>
2598
2599         Fix fat-fingered function name in git-add-reviewer.
2600
2601         Unreviewed.
2602
2603         * Scripts/git-add-reviewer:
2604         (getConfigValue):
2605
2606 2014-10-10  David Farler  <dfarler@apple.com>
2607
2608         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2609         https://bugs.webkit.org/show_bug.cgi?id=137528
2610
2611         Reviewed by Simon Fraser.
2612
2613         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2614         and SIGKILL the paired simulator app before exiting cleanly.
2615
2616         webkitpy only uses SIGKILL to kill processes which you cannot
2617         catch. Send SIGTERM to the process and give it chance to do
2618         its thing before sending SIGKILL. Sending a SIGKILL to an already
2619         dead PID is safe.
2620
2621         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2622         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2623         (-[LTRelayController finish]):
2624         * LayoutTestRelay/LayoutTestRelay/main.m:
2625         (receivedSignal):
2626         (main):
2627
2628 2014-10-10  David Farler  <dfarler@apple.com>
2629
2630         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2631         https://bugs.webkit.org/show_bug.cgi?id=137527
2632
2633         Reviewed by Simon Fraser.
2634
2635         NSFileHandle doesn't notify of EOF in its readability handler.
2636         Use a dispatch_source_t and an event handler that is called when reading is possible.
2637         In the handler block, do a run-of-the-mill read(2) from standard input and
2638         detect EOF in the usual way by checking that zero bytes were read.
2639
2640         Once an EOF is received, the FIFOs are disconnected, the simulator app
2641         is killed, and the relay exits with status 0.
2642
2643         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2644         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2645         (-[LTRelayController didDisconnect]):
2646         (-[LTRelayController didConnect]):
2647         (-[LTRelayController launchApp]):
2648         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2649         confusion with this new dispatch source, called "standardInputDispatchSource".
2650         (-[LTRelayController finish]): Added.
2651         (-[LTRelayController readFileHandle:]): Deleted.
2652
2653 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2654
2655         [EFL] Crash on facebook.com
2656         https://bugs.webkit.org/show_bug.cgi?id=137562
2657
2658         Reviewed by Chris Dumez.
2659
2660         Crash occurs on the facebook.com when the webview is resized
2661         after the <select> item is clicked but no item is chosen.
2662         This crash is just caused by the reference of invalidated variable.
2663         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2664         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2665         on MiniBrowser is called.
2666         As a result, just set ewk_menu to NULL in order to prevent crash condition.
2667
2668         * MiniBrowser/efl/main.c:
2669         (on_popup_menu_hide):
2670
2671 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2672
2673         A small wording change for clarity.
2674
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2676         (MetricsBubbleView.prototype._update):
2677
2678 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2679
2680         Dashboard metrics page should have EWS statistics
2681         https://bugs.webkit.org/show_bug.cgi?id=137626
2682
2683         Reviewed by Ryosuke Niwa.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2686         (BubbleQueue): Put shortName in the object, so that it's actually useful.
2687
2688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2689         (BubbleQueueServer): Re-ordered queues to match bubble order.
2690         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2691         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2692
2693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2694         Added analysis for bubble queues.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2699         (buildBubbleQueuesTable): Build the UI.
2700
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2702         Added JS sources to load.
2703
2704         * QueueStatusServer/app.yaml: To update app version.
2705
2706         * QueueStatusServer/handlers/processingtimesjson.py: Added.
2707
2708         * QueueStatusServer/main.py: Added a handler for processing-times-json.
2709
2710 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2711
2712         REGRESSION: Commit queue doesn't process rollouts
2713         https://bugs.webkit.org/show_bug.cgi?id=137623
2714
2715         Reviewed by Tim Horton.
2716
2717         * QueueStatusServer/app.yaml:
2718         * QueueStatusServer/handlers/updateworkitems.py:
2719         (UpdateWorkItems._work_items_from_request):
2720
2721 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2722
2723         Fix syntax error after r174601.
2724
2725         * Scripts/run-javascriptcore-tests:
2726
2727 2014-10-10  Michael Saboff  <msaboff@apple.com>
2728
2729         Add ability to select tarfile name in run-jsc-stress-tests
2730         https://bugs.webkit.org/show_bug.cgi?id=137614
2731
2732         Reviewed by Mark Hahnenberg.
2733
2734         Added optional file name argument to the --tarball option.  
2735
2736         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2737         extra test given after the options wont be used for the optional tarball file name.
2738         * Scripts/run-jsc-stress-tests:
2739
2740 2014-10-10  Chris Dumez  <cdumez@apple.com>
2741
2742         Unreviewed, update my information in contributors.json
2743
2744         Use my preferred first name and update my expertise areas.
2745
2746         * Scripts/webkitpy/common/config/contributors.json:
2747
2748 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2749
2750         Fix perl scripts to run with env on Linux
2751         https://bugs.webkit.org/show_bug.cgi?id=137601
2752
2753         Reviewed by Csaba Osztrogonác.
2754
2755         Use of arguments in #! is nonstandard and does not behave the same on
2756         different systems. Linux would look for an executable named "perl -w" 
2757         "use warnings;" does the same things in a more portable way.
2758
2759         * Scripts/commit-log-editor:
2760         * Scripts/num-cpus:
2761         * Scripts/prepare-ChangeLog:
2762         * Scripts/run-launcher:
2763         * Scripts/svn-create-patch:
2764
2765 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2766
2767         [jhbuild] We should be able to disable wiping on configuration change
2768         https://bugs.webkit.org/show_bug.cgi?id=137446
2769
2770         Reviewed by Csaba Osztrogonác.
2771
2772         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2773         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2774         or passing --no-wipe-on-change command line option.
2775
2776         * Scripts/update-webkit-libs-jhbuild:
2777
2778 2014-10-09  Andy Estes  <aestes@apple.com>
2779
2780         Teach webkitpy about OS X Yosemite
2781         https://bugs.webkit.org/show_bug.cgi?id=137585
2782
2783         Reviewed by Simon Fraser.
2784
2785         * Scripts/webkitpy/common/system/platforminfo.py:
2786         (PlatformInfo._determine_mac_version):
2787         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2788         (TestPlatformInfo.test_os_version):
2789         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2790         (TestExpectationParser):
2791         * Scripts/webkitpy/port/builders.py:
2792         * Scripts/webkitpy/port/mac.py:
2793         (MacPort):
2794         * Scripts/webkitpy/port/mac_unittest.py:
2795         (test_versions):
2796         (test_baseline_search_path):
2797         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2798         (TestRebaselineTest.test_baseline_directory):
2799         (TestRebaselineExpectations.test_rebaseline_expectations):
2800
2801 2014-10-09  Dana Burkart  <dburkart@apple.com>
2802
2803         Add Mac OS Yosemite dashboard support.
2804
2805         Rubber-stamped by Lucas Forschler.
2806
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2812
2813 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2814
2815         Add Babak to contributors.json and add historical email addresses for some contributors
2816         https://bugs.webkit.org/show_bug.cgi?id=137546
2817
2818         Reviewed by Christophe Dumez.
2819
2820         contributors.json is used to analyze historical commit data and change logs.
2821
2822         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2823
2824         * Scripts/webkitpy/common/config/contributors.json:
2825
2826 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2827
2828         Add Mac OS Yosemite webkit build infrastructure.
2829         
2830         This patch adds 15 bots to our build.webkit.org configuration.
2831         We are matching the current Mavericks machines 1:1.
2832         
2833         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2834         
2835         Reviewed by Matt Hanson.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/config.json:
2838
2839 2014-10-09  Dana Burkart  <dburkart@apple.com>
2840
2841         Don't use backticks when running commands, as we run into sh-related
2842         interpolation issues. Also, fix our usage of system() to properly
2843         retrieve the status code.
2844         https://bugs.webkit.org/show_bug.cgi?id=137541
2845
2846         Reviewed by Darin Adler.
2847
2848         * Scripts/git-add-reviewer:
2849         (interactive):
2850         (nonInteractive):
2851         (requireCleanWorkTree):
2852         (cherryPick):
2853         (commit):
2854         (addReviewerToFile):
2855         (head):
2856         (isAncestor):
2857         (toCommit):
2858         (changeLogsForCommit):
2859         (resetToCommit):
2860         (getConfigValue):
2861         (runCommandWithOutput):
2862
2863 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2864
2865         Add a WebKit1 preference for selection services
2866         https://bugs.webkit.org/show_bug.cgi?id=137498
2867         <rdar://problem/18572699>
2868
2869         Reviewed by Simon Fraser.
2870
2871         * MiniBrowser/mac/WK1BrowserWindowController.m:
2872         (-[WK1BrowserWindowController awakeFromNib]):
2873         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2874
2875 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2876
2877         Get the patch scripts running on Haiku
2878         https://bugs.webkit.org/show_bug.cgi?id=137559
2879
2880         Reviewed by Benjamin Poulain.
2881
2882         Use /usr/bin/env instead of hardcoding path to perl.
2883         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2884         failure.
2885
2886         * Scripts/commit-log-editor:
2887         * Scripts/num-cpus:
2888         * Scripts/prepare-ChangeLog:
2889         * Scripts/run-launcher:
2890         * Scripts/svn-create-patch:
2891         * Scripts/webkitpy/common/system/platforminfo.py:
2892         (PlatformInfo._determine_os_name):
2893
2894 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2895
2896         StyleQueue should throw a PatchIsNotValid exception to achieve
2897         consistency with CommitQueue and EWS
2898         https://bugs.webkit.org/show_bug.cgi?id=137500
2899
2900         Reviewed by Alexey Proskuryakov.
2901
2902         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2903         Adds a call to validate() in run().
2904         (StyleQueueTask.run):
2905         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2906         Adds a return False in the patch is not valid exception statement.
2907         (AbstractEarlyWarningSystem.review_patch):
2908         * Scripts/webkitpy/tool/commands/queues.py:
2909         Adds a return False in the patch is not valid exception statement in
2910         commit queue, and adds an except statement to catch PatchIsNotValid
2911         exceptions in style queue.
2912         (CommitQueue.process_work_item):
2913         (StyleQueue.review_patch):
2914
2915 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2916
2917         Race condition with WebKitWebView:is-loading after starting page load
2918         https://bugs.webkit.org/show_bug.cgi?id=136692
2919
2920         Reviewed by Gustavo Noronha Silva.
2921
2922         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2923         (loadChangedCallback): Only check is-loading is false when load
2924         has finished if the load didn't fail due to a cancellation.
2925         (loadFailedCallback): Only check is-loading is false if the load
2926         didn't fail due to a cancellation.
2927         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2928         (WebViewTest::loadURI): Check is-loading is true and active URI is
2929         the requested one rigth after requesting the load.
2930         (WebViewTest::loadHtml): Ditto.
2931         (WebViewTest::loadPlainText): Ditto.
2932         (WebViewTest::loadBytes): Ditto.
2933         (WebViewTest::loadRequest): Ditto.
2934         (WebViewTest::loadAlternateHTML): Ditto.
2935         (WebViewTest::goBack): Ditto.
2936         (WebViewTest::goForward): Ditto.
2937         (WebViewTest::goToBackForwardListItem): Ditto.
2938
2939 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2940
2941         [Win] Resolve various static analyzer warnings in Tools.
2942         https://bugs.webkit.org/show_bug.cgi?id=137534
2943
2944         Reviewed by Dean Jackson.
2945
2946         * DumpRenderTree/cg/ImageDiffCG.cpp:
2947         (main): User proper printf specifiers.
2948         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2949         (AccessibilityUIElement::childrenCount): Handle possibility that
2950         gcc_accChildCount returns with an error.
2951         (accessibilityState): Ditto for gcc_accState.
2952         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2953         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2954         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2955         be treated as such.
2956         * DumpRenderTree/win/DumpRenderTree.cpp:
2957         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2958         by comparing an unsigned value as being greater-than zero.
2959         * DumpRenderTree/win/EditingDelegate.cpp:
2960         (dump): Pass proper character pointer type to printf.
2961         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2962         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2963         (EditingDelegate::shouldInsertNode): Ditto.
2964         (EditingDelegate::shouldInsertText): Ditto.
2965         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2966         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2967         (EditingDelegate::shouldApplyStyle): Ditto.
2968         * DumpRenderTree/win/EventSender.cpp:
2969         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2970         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2971         system headers.
2972         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2973         from CreateDIBSection.
2974         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2975         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2976         older versions of MSVC we no longer support.
2977         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2978         for 64-bit builds.
2979         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2980         * TestWebKitAPI/TestsController.h: Ditto.
2981         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2982         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2983         performing bitwise | before the comparison is done.
2984
2985 2014-10-08  Ada Chan  <adachan@apple.com>
2986
2987         Add a test for WKPageIsPlayingAudio().
2988         https://bugs.webkit.org/show_bug.cgi?id=137048
2989
2990         Reviewed by Darin Adler.
2991
2992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2993         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2994         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2995         (TestWebKitAPI::nullJavaScriptCallback):
2996         (TestWebKitAPI::didFinishLoadForFrame):
2997         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2998         (TestWebKitAPI::setUpClients):
2999         (TestWebKitAPI::TEST):
3000         This test loads a page with a video in it. When the page is loaded, we first check that
3001         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3002         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3003         now returns true for the page.
3004         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3005         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3006         This is a video copied from LayoutTests/media/content.
3007
3008 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3009
3010         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3011         https://bugs.webkit.org/show_bug.cgi?id=137516
3012
3013         Reviewed by Alexey Proskuryakov.
3014
3015         * Scripts/webkitpy/thirdparty/__init__.py:
3016         (AutoinstallImportHook._install_irc):
3017
3018 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3019
3020         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3021         https://bugs.webkit.org/show_bug.cgi?id=137520
3022
3023         Reviewed by Philippe Normand.
3024
3025         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3026         For other distributions, we are already installing libjpeg-turbo.
3027         So, do the same for Debian and derivatives.
3028
3029         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3030
3031 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3032
3033         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3034         https://bugs.webkit.org/show_bug.cgi?id=137519
3035
3036         Reviewed by Csaba Osztrogonác.
3037
3038         It was removed by <http://trac.webkit.org/changeset/174266>,
3039         because the comment stated it is a workaround for buggy python
3040         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3041         is still valid with python 2.7 shipped on the latest Ubuntu
3042         (12.04 and 14.04) and OS X 10.9.
3043
3044         * Scripts/webkitpy/common/system/autoinstall.py:
3045         (AutoInstaller):
3046         (AutoInstaller._extract_all):
3047         (AutoInstaller._unzip):
3048
3049 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3050
3051         Unreviewed, rolling out r174335.
3052         https://bugs.webkit.org/show_bug.cgi?id=137515
3053
3054         It broke EFL layout test totally (Requested by gyuyoung on
3055         #webkit).
3056
3057         Reverted changeset:
3058
3059         "[EFL] Introduce EWebKit_Extension"
3060         https://bugs.webkit.org/show_bug.cgi?id=134921
3061         http://trac.webkit.org/changeset/174335
3062
3063 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         [GTK] Make forwarding headers generation depend on source code
3066         https://bugs.webkit.org/show_bug.cgi?id=137394
3067
3068         Reviewed by Philippe Normand.
3069
3070         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3071         * TestWebKitAPI/PlatformGTK.cmake: Only run
3072         generate-forwarding-headers.pl when source code changes.
3073         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3074
3075 2014-10-07  Tanay C  <tanay.c@samsung.com>
3076
3077         Remove build warnings in Hashmap API tests
3078         https://bugs.webkit.org/show_bug.cgi?id=137484
3079
3080         Reviewed by Darin Adler.
3081
3082         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3083         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3084
3085 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3086
3087         Commit queue doesn't drop obsolete patches sometimes
3088         https://bugs.webkit.org/show_bug.cgi?id=137460
3089
3090         Reviewed by Alexey Proskuryakov.
3091
3092         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3093         Adds another test patch for use in queues_unittest.py.
3094         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3095         (MockBugzilla):
3096         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3097         Raises a PatchIsNotValid exception in the case of validate() returning
3098         false.
3099         (CommitQueueTask.run):
3100         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3101         Raises a PatchIsNotValid exception in the case of validate() returning
3102         false.
3103         (EarlyWarningSystemTask.run):
3104         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3105         Defines PatchIsNotValid exception. 
3106         (PatchIsNotValid):
3107         (PatchIsNotValid.__init__):
3108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3109         Remove call to validate() and instead catches the PatchIsNotValid
3110         exception.
3111         (AbstractEarlyWarningSystem.review_patch):
3112         * Scripts/webkitpy/tool/commands/queues.py:
3113         Adds logic to catch the PatchIsNotValid exception.
3114         (CommitQueue.process_work_item):
3115         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3116         Adds the test_non_valid_patch test to ensure that invalid patches are
3117         handled properly, and don't just result in indefinite spinning.
3118         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3119         (test_non_valid_patch):
3120
3121 2014-10-07  Daniel Bates  <dabates@apple.com>
3122
3123         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3124         https://bugs.webkit.org/show_bug.cgi?id=137499
3125
3126         Reviewed by Simon Fraser.
3127
3128         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3129         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3130         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3131         bit simulator builds of iOS WebKit.
3132
3133         * Scripts/webkitpy/port/ios.py:
3134         (IOSSimulatorPort._generate_all_test_configurations):
3135
3136 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3137
3138         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3139         https://bugs.webkit.org/show_bug.cgi?id=137482
3140
3141         Reviewed by Martin Robinson.
3142
3143         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3144
3145 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         [SOUP] TLS errors should take precedence over HTTP authentication
3148         https://bugs.webkit.org/show_bug.cgi?id=137300
3149
3150         Reviewed by Sergio Villar Senin.
3151
3152         Add a test case to check that authenticate signal is not emitted
3153         in case of TLS errors, and the load fails instead.
3154
3155         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3156         (webViewAuthenticationCallback):
3157         (testTLSErrorsHTTPAuth):
3158         (httpsServerCallback):
3159         (beforeAll):
3160
3161 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3162
3163         Make webkit-patch find-users useful
3164         https://bugs.webkit.org/show_bug.cgi?id=137475
3165
3166         Reviewed by Alexey Proskuryakov.
3167
3168         Make find-users use the CommitterList instead of accessing Bugzilla.
3169
3170         This essentially exposes the same functionality as webkitbot's whois command.
3171
3172         * Scripts/webkitpy/tool/commands/findusers.py:
3173         (FindUsers.execute):
3174
3175 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3176
3177         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3178         https://bugs.webkit.org/show_bug.cgi?id=137289
3179
3180         Unreviewed build fix.
3181
3182         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3183         (AccessibilityUIElement::getChildrenWithRange):
3184
3185 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3186
3187         build.webkit.org/dashboard: Add commit queue
3188         https://bugs.webkit.org/show_bug.cgi?id=137462
3189
3190         Reviewed by Tim Horton.
3191
3192         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3193         Style queue is still invisible, as it doesn't have an associated platform, and also
3194         we never have problems with it anyway, so it's not worth watching.
3195
3196         The UI now allows for adding more bots to the Other column (such as leaks bot).
3197         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3198         sources of data in a cell.
3199
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3201         (BubbleQueue):
3202         (BubbleQueue.prototype.get statusPageURL):
3203         (BubbleQueue.prototype.update):
3204         (BubbleQueue.prototype.loadDetailedStatus):
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3206         (BubbleQueueServer):
3207         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3208         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3209         (BubbleQueueServer.prototype.queueStatusURL):
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3211         (BubbleQueueView):
3212         (BubbleQueueView.prototype.update.appendQueue):
3213         (BubbleQueueView.prototype.update):
3214         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3215         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3216         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3223         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3224         (.bubble-server-popover .latest-status-no-link):
3225         (.bubble-server-popover .bot-status-description):
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3227
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3229         (buildAggregateTable):
3230         (buildQueuesTable):
3231         Removed dysfunctional support for EWS for now. It will be different.
3232
3233 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3234
3235         One more case of incorrect comparison in recordpatchevent.py
3236         https://bugs.webkit.org/show_bug.cgi?id=137459
3237
3238         Reviewed by Tim Horton.
3239
3240         * QueueStatusServer/app.yaml:
3241         * QueueStatusServer/loggers/recordpatchevent.py:
3242         (RecordPatchEvent.started):
3243
3244 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3245
3246         webkit-queues PatchLog is incorrect for patches that took less than a second
3247         https://bugs.webkit.org/show_bug.cgi?id=137453
3248
3249         Reviewed by Tim Horton.
3250
3251         * QueueStatusServer/app.yaml: Updated app version.
3252
3253         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3254         Don't bail out for patches that took 0 seconds to process (as frequently happens
3255         when a patch is obsolete).
3256
3257 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3258
3259         EWS bubble hover shows wrong timestamps
3260         https://bugs.webkit.org/show_bug.cgi?id=137252
3261
3262         Reviewed by Alexey Proskuryakov.
3263
3264         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3265
3266         * QueueStatusServer/handlers/queuestatusjson.py:
3267         (QueueStatusJSON.get):
3268         * QueueStatusServer/handlers/statusbubble.py:
3269         (StatusBubble._iso_time):
3270
3271 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3272
3273         Unreviewed, updated list of email addresses in contributors.json
3274
3275         * Scripts/webkitpy/common/config/contributors.json: Added my former
3276         email address in Igalia, for the sake of completeness.
3277
3278 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3279
3280         Unreviewed, moved myself to the list of committers.
3281
3282         * Scripts/webkitpy/common/config/contributors.json:
3283
3284 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3285
3286         [EFL] Introduce EWebKit_Extension
3287         https://bugs.webkit.org/show_bug.cgi?id=134921
3288
3289         Reviewed by Gyuyoung Kim.
3290
3291         * MiniBrowser/efl/main.c: Added x option to test extension path.
3292         (window_create):
3293         (elm_main):
3294         * Scripts/webkitpy/common/config/watchlist:
3295         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3296         * Scripts/webkitpy/style/checker.py:
3297         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3298
3299 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3300
3301         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3302         https://bugs.webkit.org/show_bug.cgi?id=137390
3303
3304         Reviewed by Carlos Garcia Campos.
3305
3306         * Scripts/update-webkit-libs-jhbuild:
3307
3308 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3311         https://bugs.webkit.org/show_bug.cgi?id=137391
3312
3313         Reviewed by Martin Robinson.
3314
3315         Add a custom command to only re-generate
3316         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3317
3318         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3319
3320 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3321
3322         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3323         https://bugs.webkit.org/show_bug.cgi?id=135502
3324
3325         Reviewed by Martin Robinson.
3326
3327         When writing to stdout/stderr fails due to a UnicodeDecodeError
3328         exception, try again without encoding the output.
3329
3330         * gtk/gtkdoc.py:
3331         (GTKDoc._run_command):
3332
3333 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3334
3335         Bugzilla status bubble displays an exception showing attachment 175738
3336         https://bugs.webkit.org/show_bug.cgi?id=137410
3337
3338         Reviewed by Tim Horton.
3339
3340         * QueueStatusServer/app.yaml: Update version.
3341
3342         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3343         Don't fail even if expected status message is missing.
3344
3345         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3346         the field in the same way it's defined in QueueStatus table.
3347
3348 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3349
3350         Record latest message in PatchLog for quick access
3351         https://bugs.webkit.org/show_bug.cgi?id=137405
3352
3353         Fixing a typo.
3354
3355         * QueueStatusServer/app.yaml:
3356         * QueueStatusServer/handlers/releasepatch.py:
3357
3358 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3359
3360         Record latest message in PatchLog for quick access
3361         https://bugs.webkit.org/show_bug.cgi?id=137405
3362
3363         Reviewed by Ryosuke Niwa.
3364
3365         It's no SQL...
3366
3367         * QueueStatusServer/handlers/releasepatch.py:
3368         * QueueStatusServer/handlers/updatestatus.py:
3369         * QueueStatusServer/loggers/recordpatchevent.py:
3370         * QueueStatusServer/model/patchlog.py:
3371
3372 2014-10-02  David Farler  <dfarler@apple.com>
3373
3374         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3375         https://bugs.webkit.org/show_bug.cgi?id=137377
3376
3377         Reviewed by Daniel Bates.
3378
3379         * asan/asan.xcconfig:
3380         -asan-blacklist -> -fsanitize-blacklist
3381
3382         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3383
3384 2014-10-03  Roger Fong  <roger_fong@apple.com>
3385
3386         [Windows] Include batch size argument to layout tests on Windows.
3387
3388         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3389         (RunWebKitTests.start): 
3390         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3391         These crashes seem to happen on random tests though generally in a spread out fashion.
3392         It seems possible that the DRT instance is being clobbered somehow after running too many
3393         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3394
3395 2014-10-03  Roger Fong  <roger_fong@apple.com>
3396
3397         [Windows] Settle for 2 chid processes running NRWT on Windows.
3398
3399         * Scripts/webkitpy/port/win.py:
3400         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3401
3402 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3403
3404         [GTK] Bump up and patch dependencies to allow building for aarch64
3405         https://bugs.webkit.org/show_bug.cgi?id=137147
3406
3407         Reviewed by Martin Robinson.
3408
3409         The currently used versions of pixman, libffi, librsvg, glib,
3410         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3411         and/or build for aarch64, so they are bumped up and patched where
3412         necessary. Wherever possible, the same versions and patches were used as
3413         for the EFL port bump-up
3414         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3415
3416         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3417         regression by crashing http/tests/media/video-redirect.html . A patch
3418         already in upstream fixes that bug.
3419
3420         This change does not touch xserver, which also needs bumping up, but 
3421         will be dealt with later.
3422
3423         * gtk/jhbuild.modules:
3424         Specified versions and patches necessary to correctly build for aarch64.
3425         * gtk/patches/gst-events-arent-gstobjects.patch:
3426         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3427         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3428         Added. Patches gst-plugins-base to configure correctly for aarch64.
3429         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3430         Added. Bumps up config.guess and config.sub in librsvg to recognize
3431         aarch64.
3432         * gtk/patches/libxml2-2.9.0-dtd.patch:
3433         Removed. Not necessary for libxml2 v2.9.1 anymore.
3434
3435 2014-09-28  Sam Weinig  <sam@webkit.org>
3436
3437         Remove RefPtrHashMap
3438         https://bugs.webkit.org/show_bug.cgi?id=137200
3439
3440         Reviewed by Darin Adler.
3441
3442         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3443         (TestWebKitAPI::TEST):
3444         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3445         a minimum of refcount churn occurs.
3446
3447 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3448
3449         Remove workarounds for versions of Python before 2.7
3450         https://bugs.webkit.org/show_bug.cgi?id=137338
3451
3452         Reviewed by Csaba Osztrogonác.
3453
3454         * Scripts/webkitpy/common/system/autoinstall.py:
3455         (AutoInstaller._extract_targz):
3456         (AutoInstaller._unzip):
3457         (AutoInstaller): Deleted.
3458         (AutoInstaller._extract_all): Deleted.
3459         * Scripts/webkitpy/common/webkitunittest.py:
3460         (TestCase.setUp): Deleted.
3461         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3462         (TestConfigurationConverter.collapse_macros):
3463         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3464         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3465         (TestConfigurationConverter):
3466         (TestConfigurationConverter.combinations): Deleted.
3467         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3468         * Scripts/webkitpy/port/base.py:
3469
3470 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3471
3472         Unreviewed, rolling out r174264.
3473         https://bugs.webkit.org/show_bug.cgi?id=137392
3474
3475         It broke run-webkit-tests (Requested by ebalazsfalvi on
3476         #webkit).
3477
3478         Reverted changeset:
3479
3480         "Remove workarounds for versions of Python before 2.7"
3481         https://bugs.webkit.org/show_bug.cgi?id=137338
3482         http://trac.webkit.org/changeset/174264
3483
3484 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3485
3486         Remove workarounds for versions of Python before 2.7
3487         https://bugs.webkit.org/show_bug.cgi?id=137338
3488
3489         Reviewed by Csaba Osztrogonác.
3490
3491         * Scripts/webkitpy/common/system/autoinstall.py:
3492         (AutoInstaller._extract_targz):
3493         (AutoInstaller._unzip):
3494         (AutoInstaller): Deleted.
3495         (AutoInstaller._extract_all): Deleted.
3496         * Scripts/webkitpy/common/webkitunittest.py:
3497         (TestCase.setUp): Deleted.
3498         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3499         (TestConfigurationConverter.collapse_macros):
3500         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3501         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3502         (TestConfigurationConverter):
3503         (TestConfigurationConverter.combinations): Deleted.
3504         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3505         * Scripts/webkitpy/port/base.py:
3506         * Scripts/webkitpy/port/driver.py:
3507         (ContentBlock.__init__):
3508         * Scripts/webkitpy/port/server_process.py:
3509         (ServerProcess._reset):
3510
3511 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3512
3513         Remove autoinstaller workaround for python 2.6
3514         https://bugs.webkit.org/show_bug.cgi?id=137343
3515
3516         Reviewed by Daniel Bates.
3517
3518         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3519         2.6, nor Snow Leopard is supported anymore, so the workaround is not
3520         needed anymore.
3521
3522         * Scripts/webkitpy/common/system/autoinstall.py:
3523         (AutoInstaller.install):
3524         * Scripts/webkitpy/test/main.py:
3525         (Tester._run_tests):
3526         * Scripts/webkitpy/thirdparty/__init__.py:
3527         (AutoinstallImportHook._install_mechanize):
3528         (AutoinstallImportHook._install_pep8):
3529         (AutoinstallImportHook._install_pylint):
3530         (AutoinstallImportHook._install_buildbot):
3531         (AutoinstallImportHook._install_coverage):
3532         (AutoinstallImportHook._install_eliza):
3533         (AutoinstallImportHook._install_irc):
3534         (AutoinstallImportHook._install):
3535         (autoinstall_everything):
3536
3537 2014-10-02  Daniel Bates  <dabates@apple.com>
3538
3539         Use version number 101000 instead of 10100 for OS X Yosemite
3540         https://bugs.webkit.org/show_bug.cgi?id=137372
3541
3542         Reviewed by Mark Rowe.
3543
3544         The version number for OS X Yosemite is 101000.
3545
3546         * DumpRenderTree/mac/TextInputController.m:
3547
3548 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
3549
3550         update-work-items should never delete items
3551         https://bugs.webkit.org/show_bug.cgi?id=137366
3552
3553         Reviewed by Ryosuke Niwa.
3554
3555         As we don't just replace the whole list any more, indicate which items are high
3556         priority, and which are not. Hight priority ones will be prepended to the queue,
3557         others will be appended.
3558
3559         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3560         But hopefully we will never have many rollouts competing like that.
3561
3562         * QueueStatusServer/app.yaml: Update version.
3563
3564         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3565         priority and regular items separately. Removed some error handling that used to
3566         end up in returning status 500 - an uncaught exception does that automatically.
3567
3568         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3569
3570         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3571
3572         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3573         priority items.
3574
3575         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3576         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3577         line that complicated testing.
3578
3579         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3580
3581         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3582         priority items into separate lists.
3583
3584         * Scripts/webkitpy/common/net/statusserver_mock.py:
3585         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3586         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3587         Updated tests.
3588
3589 2014-10-02  Brendan Long  <b.long@cablelabs.com>
3590
3591         Annoying build warnings in WTFString API tests
3592         https://bugs.webkit.org/show_bug.cgi?id=137360
3593
3594         Reviewed by Darin Adler.
3595
3596         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3597         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3598
3599 2014-10-02  Roger Fong  <roger_fong@apple.com>
3600
3601         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3602
3603         * Scripts/webkitpy/port/win.py:
3604         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3605
3606 2014-10-02  David Farler  <dfarler@apple.com>
3607
3608         Move ASan arguments from LLVM (-mllvm) to the frontend
3609         https://bugs.webkit.org/show_bug.cgi?id=137365
3610
3611         Reviewed by David Kilzer.
3612
3613         * asan/asan.xcconfig:
3614         Remove the -mllvm prefix to the asan-blacklist argument, moving it
3615         to the clang frontend.
3616
3617         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3618
3619 2014-10-02  Commit Queue  <commit-queue@webkit.org>
3620
3621         Unreviewed, rolling out r174120.
3622         https://bugs.webkit.org/show_bug.cgi?id=137350
3623
3624         While number of failures is reasonable with 2 processes, test
3625         results seem to be inconsistent between runs (Requested by
3626         rfong on #webkit).
3627
3628         Reverted changeset:
3629
3630         "[Windows] Back to 2 child processes for NRWT on Windows."
3631         http://trac.webkit.org/changeset/174120
3632
3633 2014-10-02  Jeff Miller  <jeffm@apple.com>
3634
3635         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
3636         https://bugs.webkit.org/show_bug.cgi?id=137347
3637
3638         Reviewed by Dan Bernstein.
3639
3640      &n