URL set by document.open() is not communicated to the UIProcess
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-16  Chris Dumez  <cdumez@apple.com>
2
3         URL set by document.open() is not communicated to the UIProcess
4         https://bugs.webkit.org/show_bug.cgi?id=196941
5         <rdar://problem/49237544>
6
7         Reviewed by Geoff Garen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
13         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
14         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
15         (TEST):
16
17 2019-04-16  Commit Queue  <commit-queue@webkit.org>
18
19         Unreviewed, rolling out r244321.
20         https://bugs.webkit.org/show_bug.cgi?id=196968
21
22         Causing all WK2 Debug builds to exit early after Assertion
23         failures. (Requested by ShawnRoberts on #webkit).
24
25         Reverted changeset:
26
27         "URL set by document.open() is not communicated to the
28         UIProcess"
29         https://bugs.webkit.org/show_bug.cgi?id=196941
30         https://trac.webkit.org/changeset/244321
31
32 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
33
34         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
35         https://bugs.webkit.org/show_bug.cgi?id=196948
36
37         Reviewed by Zalan Bujtas.
38
39         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
40         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
41
42 2019-04-15  Chris Dumez  <cdumez@apple.com>
43
44         URL set by document.open() is not communicated to the UIProcess
45         https://bugs.webkit.org/show_bug.cgi?id=196941
46         <rdar://problem/49237544>
47
48         Reviewed by Geoffrey Garen.
49
50         Add API test coverage.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
54         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
55         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
56         (TEST):
57
58 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
59
60         Using Tools/Scripts/clean-webkit should not install requests
61         https://bugs.webkit.org/show_bug.cgi?id=196940
62
63         Reviewed by Lucas Forschler.
64
65         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
66         existing, depending on the path autoinstalled is run through.
67         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
68         needed.
69         (Port.configuration_for_upload):
70         (Port.commits_for_upload):
71
72 2019-04-15  Alex Christensen  <achristensen@webkit.org>
73
74         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
75         https://bugs.webkit.org/show_bug.cgi?id=196773
76
77         Reviewed by Jer Noble.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
80         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
81         (TEST):
82
83 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
84
85         ews-build should clearly indicate flaky test failures
86         https://bugs.webkit.org/show_bug.cgi?id=196947
87
88         Reviewed by Lucas Forschler.
89
90         * BuildSlaveSupport/ews-build/steps.py:
91         (AnalyzeAPITestsResults.analyzeResults):
92
93 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
94
95         InjectedBundle parameters often need initialization function called before unarchiving
96         https://bugs.webkit.org/show_bug.cgi?id=189709
97         <rdar://problem/44573653>
98
99         Reviewed by Ryosuke Niwa.
100
101         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
102         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
103
104 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
105
106         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
107         https://bugs.webkit.org/show_bug.cgi?id=196681
108
109         Reviewed by Darin Adler.
110
111         Added tests.
112
113         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
114         (WTF_HashSet.RemoveIf):
115         (WTF_HashSet.RemoveIfShrinkToBestSize):
116
117 2019-04-15  John Wilander  <wilander@apple.com>
118
119         Send delayed Ad Click Attribution conversion requests to the click source
120         https://bugs.webkit.org/show_bug.cgi?id=196838
121         <rdar://problem/47650157>
122
123         Reviewed by Chris Dumez and Youenn Fablet.
124
125         This patch adds test infrastructure to override the default behavior in
126         WebKit::NetworkAdClickAttribution.
127
128         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
129         (TestWebKitAPI::TEST):
130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
132         (WTR::TestRunner::dumpAdClickAttribution):
133         (WTR::TestRunner::clearAdClickAttribution):
134         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
135         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
137         * WebKitTestRunner/TestController.cpp:
138         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
139         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
140         * WebKitTestRunner/TestController.h:
141         * WebKitTestRunner/TestInvocation.cpp:
142         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
143
144 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews-app] status-bubble should display position in queue
147         https://bugs.webkit.org/show_bug.cgi?id=196607
148
149         Reviewed by Lucas Forschler.
150
151         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
152         (StatusBubble._build_bubble):
153         (StatusBubble._queue_position): Method to calculate patch's position in queue.
154
155 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-build] Do not run clean build by default on EWS builders
158         https://bugs.webkit.org/show_bug.cgi?id=196897
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-build/steps.py:
163         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
164         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
165         untracked directories like WebKitBuild).
166         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
167         untracked files/directories (like WebKitBuild).
168
169 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
170
171         TestRunner::notifyDone() should be safely reentrant
172         https://bugs.webkit.org/show_bug.cgi?id=196898
173
174         Reviewed by Darin Adler.
175
176         It is currently possible that TestRunner::notifyDone() will call itself, since
177         notifyDone() will force a repaint, which can start executing JavaScript, which
178         may call notifyDone() again. This can lead to test failures and flakiness.
179         Fix this by setting the m_waitToDump flag before calling the dump() method.
180
181         * DumpRenderTree/mac/TestRunnerMac.mm:
182         (TestRunner::notifyDone):
183         (TestRunner::forceImmediateCompletion):
184         * DumpRenderTree/win/TestRunnerWin.cpp:
185         (TestRunner::notifyDone):
186         (TestRunner::forceImmediateCompletion):
187
188 2019-04-15  Philippe Normand  <pnormand@igalia.com>
189
190         [GTK][WPE] Add enable-media websetting
191         https://bugs.webkit.org/show_bug.cgi?id=196863
192
193         Reviewed by Michael Catanzaro.
194
195         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
196         (testWebKitSettings): Add test for the enable-media web-setting.
197
198 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
199
200         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
201         https://bugs.webkit.org/show_bug.cgi?id=196905
202         <rdar://problem/49886096>
203
204         Reviewed by Tim Horton.
205
206         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
207         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
208         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
209         delay timer, we end up with this sequence of events in the problematic (failure) case:
210
211         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
212             ...IPC from UI to web process...
213         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
214             ...IPC from web to UI process...
215         (c) [UI]    Invoke completion handler for script #1
216         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
217             ...IPC from UI to web process...
218         (e) [Web]   Evaluate script #2 in the web process
219         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
220
221         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
222         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
223         #2 is run in step (e).
224
225         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
226         the UI process by waiting on a script message posted by the web process, after attachment updates are
227         dispatched.
228
229         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
230         (TestWebKitAPI::TEST):
231
232 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
233
234         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
235         https://bugs.webkit.org/show_bug.cgi?id=196909
236
237         Reviewed by Wenson Hsieh.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
240         (TestWebKitAPI::TEST):
241
242 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
243
244         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
245         https://bugs.webkit.org/show_bug.cgi?id=196880
246
247         Reviewed by Yusuke Suzuki.
248
249         Add a new function for bytecode cache tests that does not forceDiskCache
250         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
251         test added in this patch, since the code is invalid and therefore won't be
252         cached. It should also be useful for tests that evaluate dynamically
253         generated code.
254
255         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
256         * Scripts/run-jsc-stress-tests:
257
258 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
259
260         Update AudioSession route sharing policy
261         https://bugs.webkit.org/show_bug.cgi?id=196776
262         <rdar://problem/46501611>
263
264         Reviewed by Jer Noble.
265
266         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
267         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
268         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
269         (TestWebKitAPI::TEST):
270
271 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
272
273         [iOS] Software keyboard is shown too frequently on some websites
274         https://bugs.webkit.org/show_bug.cgi?id=195856
275         <rdar://problem/49191395>
276
277         Reviewed by Darin Adler.
278
279         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
280
281         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
282         (WTR::UIScriptController::setHardwareKeyboardAttached):
283         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
284         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
285         (WTR::UIScriptController::setHardwareKeyboardAttached):
286         * TestRunnerShared/UIScriptContext/UIScriptController.h:
287         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
288
289         Additionally link against GraphicsServices in WebKitTestRunner.
290
291         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
292         (WTR::TestController::platformResetStateToConsistentValues):
293         (WTR::UIScriptController::setHardwareKeyboardAttached):
294
295 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
296
297         [GTK][WPE] Fix pacman install-dependencies packages
298         https://bugs.webkit.org/show_bug.cgi?id=196817
299
300         Reviewed by Žan Doberšek.
301         
302         python3-setuptools is called python-setuptools
303         ruby-highline is only available on AUR
304         libv4l-devel is incorporated in v4l-utils
305
306         * gtk/install-dependencies:
307         * wpe/install-dependencies:
308
309 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
310
311         [GTK] REGRESSION(r243860): Many tests failing
312         https://bugs.webkit.org/show_bug.cgi?id=196791
313
314         Reviewed by Joanmarie Diggs.
315
316         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
317         multiple documents and check that accessibility hierarchy is updated after a navigation.
318
319         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
320         (loadChangedCallback):
321         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
322         (AccessibilityTest::AccessibilityTest):
323         (AccessibilityTest::~AccessibilityTest):
324         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
325         (AccessibilityTest::findTestServerApplication):
326         (AccessibilityTest::findDocumentWeb):
327         (AccessibilityTest::findRootObject):
328         (AccessibilityTest::waitUntilChildrenRemoved):
329         (AccessibilityTest::ensureProxy):
330         (testAtspiBasicHierarchy):
331         (beforeAll):
332         (afterAll):
333
334 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-build] Handle bug titles with unicode characters
337         https://bugs.webkit.org/show_bug.cgi?id=196802
338
339         Reviewed by Dewei Zhu.
340
341         * BuildSlaveSupport/ews-build/steps.py:
342         (ValidatePatch._is_bug_closed):
343
344 2019-04-11  Michael Saboff  <msaboff@apple.com>
345
346         Improve the Inline Cache Stats code
347         https://bugs.webkit.org/show_bug.cgi?id=196836
348
349         Reviewed by Saam Barati.
350
351         Added a new script to consolidate and arrange the output of --useICStats option.
352
353         This script merges the output from every group into one large table and sorts it from most common to
354         least common.  It also counts the slow path GetById and PutById variants and then calculates the
355         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
356         Put together, this is useful to see what property accesses are not getting cached.
357
358         * Scripts/ic-stats.py: Added.
359         (ICStats):
360         (ICStats.__init__):
361         (ICStats.parse):
362         (ICStats.dumpStats):
363         (usage):
364
365 2019-04-10  Alex Christensen  <achristensen@webkit.org>
366
367         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
368         https://bugs.webkit.org/show_bug.cgi?id=196809
369         <rdar://49800762>
370
371         Reviewed by Brady Eidson.
372
373         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
374         (TEST):
375
376 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
377
378         requestAnimationFrame should execute before the next frame
379         https://bugs.webkit.org/show_bug.cgi?id=177484
380
381         Reviewed by Simon Fraser.
382
383         Add trace points for the page RenderingUpdate.
384
385         * Tracing/SystemTracePoints.plist:
386
387 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
388
389         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
390         https://bugs.webkit.org/show_bug.cgi?id=196760
391
392         Reviewed by Don Olmstead.
393
394         vswhere.exe has been bundled since Visual Studio 2017 version
395         15.2. We shouldn't download vswhere.exe.
396
397         * Scripts/build-jsc: Do not call update-vswhere.py.
398         * Scripts/build-webkit: Ditto.
399         * Scripts/update-vswhere.py: Removed.
400         * Scripts/webkitdirs.pm:
401         (requireModulesForVSWhere): Deleted.
402         (pickCurrentVisualStudioInstallation): Deleted.
403         (visualStudioInstallDirVSWhere): Return the latest installed VS
404         installation path by using the bundled vswhere.exe.
405         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
406         (visualStudioInstallDirFallback): Removed.
407
408 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
409
410         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
411         https://bugs.webkit.org/show_bug.cgi?id=196780
412
413         Reviewed by Alexey Proskuryakov.
414
415         * BuildSlaveSupport/ews-build/steps.py:
416         * BuildSlaveSupport/ews-build/steps_unittest.py:
417
418 2019-04-10  Alex Christensen  <achristensen@webkit.org>
419
420         Add SPI WKNavigationResponse._downloadAttribute
421         https://bugs.webkit.org/show_bug.cgi?id=196755
422         <rdar://49587365>
423
424         Reviewed by Brady Eidson.
425
426         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
427         (-[NavigationResponseTestDelegate navigationResponse]):
428         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
429         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
430         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
431         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
432         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
433         (readRequest):
434         (writeResponse):
435         (TEST):
436
437 2019-04-10  Tim Horton  <timothy_horton@apple.com>
438
439         Add modern API for overriding the page's specified viewport configuration
440         https://bugs.webkit.org/show_bug.cgi?id=167734
441         <rdar://problem/30331795>
442
443         Reviewed by Simon Fraser.
444
445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
446         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
447
448 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
449
450         Add support for incremental bytecode cache updates
451         https://bugs.webkit.org/show_bug.cgi?id=195000
452
453         Reviewed by Filip Pizlo.
454
455         Exit when the initial run to generate bytecode fails.
456
457         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
458
459 2019-04-10  Alex Christensen  <achristensen@webkit.org>
460
461         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
462         https://bugs.webkit.org/show_bug.cgi?id=196744
463         <rdar://49415309>
464
465         Reviewed by Chris Dumez.
466
467         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
468         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
469
470 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
471
472         Add a way to opt into modern compatibility mode in layout tests
473         https://bugs.webkit.org/show_bug.cgi?id=196770
474         <rdar://problem/49777550>
475
476         Reviewed by Antoine Quint.
477
478         Add a new test option to enable modern compatibility mode in layout tests.
479
480         * WebKitTestRunner/TestController.cpp:
481         (WTR::updateTestOptionsFromTestHeader):
482         * WebKitTestRunner/TestController.h:
483         * WebKitTestRunner/TestOptions.h:
484         (WTR::TestOptions::hasSameInitializationOptions const):
485         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
486         (WTR::TestController::platformCreateWebView):
487         (WTR::TestController::enableModernCompatibilityMode):
488
489 2019-04-10  Andy Estes  <aestes@apple.com>
490
491         Try to fix the 32-bit watchOS build.
492
493         * TestWebKitAPI/cocoa/TestWKWebView.mm:
494         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
495
496 2019-04-10  Antoine Quint  <graouts@apple.com>
497
498         Enable Pointer Events on watchOS
499         https://bugs.webkit.org/show_bug.cgi?id=196771
500         <rdar://problem/49040909>
501
502         Reviewed by Dean Jackson.
503
504         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
505
506 2019-04-10  Philippe Normand  <pnormand@igalia.com>
507
508         Unreviewed. Fix WPE accessibility tests after r244059.
509
510         We are failing to load the injected bundle due to undefined symbol
511         AccessibilityUIElement::replaceTextInRange().
512
513         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
514         (WTR::AccessibilityUIElement::replaceTextInRange):
515
516 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
517
518         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
519         https://bugs.webkit.org/show_bug.cgi?id=196727
520
521         Reviewed by Fujii Hironori.
522
523         * MiniBrowser/win/WebKitBrowserWindow.cpp:
524         (WebKitBrowserWindow::create):
525
526 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
527
528         [ews-build] Add unit tests for PrintConfiguration
529         https://bugs.webkit.org/show_bug.cgi?id=196752
530
531         Reviewed by Dewei Zhu.
532
533         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
534
535 2019-04-09  Keith Rollin  <krollin@apple.com>
536
537         Unreviewed build maintenance -- update .xcfilelists.
538
539         * DumpRenderTree/DerivedSources-input.xcfilelist:
540         * DumpRenderTree/DerivedSources-output.xcfilelist:
541
542 2019-04-09  Zalan Bujtas  <zalan@apple.com>
543
544         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
545         https://bugs.webkit.org/show_bug.cgi?id=196743
546         <rdar://problem/43897551>
547
548         Reviewed by Tim Horton.
549
550         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
551         (TEST):
552
553 2019-04-09  Youenn Fablet  <youenn@apple.com>
554
555         Close service worker database on network process suspension
556         https://bugs.webkit.org/show_bug.cgi?id=196623
557         <rdar://problem/48930869>
558
559         Reviewed by Alex Christensen.
560
561         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
562
563 2019-04-09  Daniel Bates  <dabates@apple.com>
564
565         [iPad] Should open popover when the spacebar is pressed
566         https://bugs.webkit.org/show_bug.cgi?id=196360
567         <rdar://problem/49389129>
568
569         Reviewed by Brent Fulgham.
570
571         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
572
573         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
574         (WTR::UIScriptController::isShowingPopover const): Added.
575         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
576         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
577         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
578         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
579         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
580         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
581         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
582         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
583         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
584         (WTR::UIScriptController::isShowingPopover const): Added.
585         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
586         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
587         * TestRunnerShared/UIScriptContext/UIScriptController.h:
588         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
589         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
590         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
591         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
592         (-[TestRunnerWKWebView _willPresentPopover]): Added.
593         (-[TestRunnerWKWebView _didDismissPopover]): Added.
594         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
595         (WTR::UIScriptController::isShowingPopover const): Added.
596         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
597         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
598
599 2019-04-09  Alex Christensen  <achristensen@webkit.org>
600
601         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
602         https://bugs.webkit.org/show_bug.cgi?id=196665
603         <rdar://45115669>
604
605         Reviewed by Geoff Garen.
606
607         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
608         (goBack):
609         (+[SimpleLookupContext sharedLookupContext]):
610         (-[SimpleLookupContext lookUpURL:completionHandler:]):
611         (TEST):
612         (+[Simple3LookupContext sharedLookupContext]): Deleted.
613         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
614
615 2019-04-09  John Wilander  <wilander@apple.com>
616
617         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
618         https://bugs.webkit.org/show_bug.cgi?id=196558
619         <rdar://problem/47650245>
620
621         Reviewed by Youenn Fablet.
622
623         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
624         (TestWebKitAPI::TEST):
625             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
626
627 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
628
629         [CMake] Apple builds should use ICU_INCLUDE_DIRS
630         https://bugs.webkit.org/show_bug.cgi?id=196720
631
632         Reviewed by Konstantin Tokarev.
633
634         * TestWebKitAPI/PlatformMac.cmake:
635
636 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
637
638         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
639         https://bugs.webkit.org/show_bug.cgi?id=196694
640         <rdar://problem/48388734>
641
642         Rubber-stamped by Aakash Jain.
643
644         * Scripts/webkitpy/port/image_diff.py:
645         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
646         * Scripts/webkitpy/port/server_process.py:
647         (ServerProcess.has_available_stdout): Check if stdout has data in it.
648         (ServerProcess._wait_for_data_and_update_buffers_using_select):
649         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
650         * Scripts/webkitpy/port/server_process_mock.py:
651         (MockServerProcess.has_available_stdout):
652         * Scripts/webkitpy/port/server_process_unittest.py:
653         (TestServerProcess.serial_test_basic):
654
655 2019-04-09  Jer Noble  <jer.noble@apple.com>
656
657         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
658         https://bugs.webkit.org/show_bug.cgi?id=196097
659
660         Reviewed by Eric Carlson.
661
662         Drive-by bug fix: allow tests to play audio without a user gesture by default.
663
664         * DumpRenderTree/mac/DumpRenderTree.mm:
665         (resetWebPreferencesToConsistentValues):
666         * WebKitTestRunner/TestController.cpp:
667         (WTR::TestController::resetPreferencesToConsistentValues):
668
669 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
670
671         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
672         https://bugs.webkit.org/show_bug.cgi?id=196690
673
674         Reviewed by Michael Catanzaro.
675
676         * QueueStatusServer/config/queues.py:
677         * Scripts/webkitpy/common/config/ews.json:
678         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
679         (test_ews_name):
680
681 2019-04-09  Chris Dumez  <cdumez@apple.com>
682
683         Loads using loadHTMLString() cause flashing when process-swapping
684         https://bugs.webkit.org/show_bug.cgi?id=196714
685         <rdar://problem/49637354>
686
687         Reviewed by Antti Koivisto.
688
689         Add API test coverage.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
692
693 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
694
695         Unreviewed. Fix ATK accessibility tests after r244059.
696
697         We are failing to load the injected bundle due to undefined symbol
698         AccessibilityUIElement::replaceTextInRange().
699
700         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
701         (WTR::AccessibilityUIElement::replaceTextInRange):
702
703 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
704
705         AX: Support API: accessibilityReplaceRange:withText
706         https://bugs.webkit.org/show_bug.cgi?id=196636
707
708         Unreviewed build fix for Windows port.
709
710         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
711         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
712
713 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
714
715         [CMake][WinCairo] Separate copied headers into different directories
716         https://bugs.webkit.org/show_bug.cgi?id=196655
717
718         Reviewed by Michael Catanzaro.
719
720         * DumpRenderTree/CMakeLists.txt:
721         * MiniBrowser/win/CMakeLists.txt:
722         * TestWebKitAPI/CMakeLists.txt:
723         * TestWebKitAPI/PlatformWin.cmake:
724
725 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
726
727         Log stack-trace for run-webkit-tests when interrupted
728         https://bugs.webkit.org/show_bug.cgi?id=176393
729         <rdar://problem/34262310>
730
731         Reviewed by Lucas Forschler.
732
733         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
734         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
735         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
736         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
737         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
738         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
739         (main): Set handlers to log stack trace on interruption.
740
741 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
742
743         AX: Support API: accessibilityReplaceRange:withText
744         https://bugs.webkit.org/show_bug.cgi?id=196636
745
746         Unreviewed build fix for Windows port.
747
748         * DumpRenderTree/AccessibilityUIElement.cpp:
749         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
750
751 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-build] Scripts using Buildbot API have CORS error
754         https://bugs.webkit.org/show_bug.cgi?id=196709
755
756         Reviewed by Alexey Proskuryakov.
757
758         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
759
760 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
761
762         AX: Support API: accessibilityReplaceRange:withText
763         https://bugs.webkit.org/show_bug.cgi?id=196636
764
765         Reviewed by Daniel Bates.
766
767         * DumpRenderTree/AccessibilityUIElement.cpp:
768         (replaceTextInRangeCallback):
769         (AccessibilityUIElement::replaceTextInRange):
770         (AccessibilityUIElement::getJSClass):
771         * DumpRenderTree/AccessibilityUIElement.h:
772         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
773         (AccessibilityUIElement::replaceTextInRange):
774         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
775         (AccessibilityUIElement::replaceTextInRange):
776         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
777         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
778         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
779         (WTR::AccessibilityUIElement::replaceTextInRange):
780         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
781         (WTR::AccessibilityUIElement::replaceTextInRange):
782
783 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
784
785         [iOS] Do not allow starting selection drags when selection views are not visible
786         https://bugs.webkit.org/show_bug.cgi?id=196686
787         <rdar://problem/49399192>
788
789         Reviewed by Tim Horton.
790
791         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
792         also add some new API tests to cover scenarios where the web view is not first responder.
793
794         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
795         (TestWebKitAPI::TEST):
796         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
797
798         Add a switch to optionally make the web view first responder when starting the simulated drag.
799
800         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
801         (-[DragAndDropSimulator initWithWebView:]):
802         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
803
804 2019-04-08  Justin Fan  <justin_fan@apple.com>
805
806         [Web GPU] Fix Web GPU experimental feature on iOS
807         https://bugs.webkit.org/show_bug.cgi?id=196632
808
809         Reviewed by Myles C. Maxfield.
810
811         Properly make Web GPU available on iOS 11+.
812
813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
814
815 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
816
817         [ews-build] Do not upload archive when Compile Fails
818         https://bugs.webkit.org/show_bug.cgi?id=196674
819
820         Reviewed by Alexey Proskuryakov.
821
822         * BuildSlaveSupport/ews-build/factories.py:
823         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
824         * BuildSlaveSupport/ews-build/steps.py:
825         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
826         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
827         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
828
829 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
830
831         Enable DFG on MIPS
832         https://bugs.webkit.org/show_bug.cgi?id=196689
833
834         Reviewed by Žan Doberšek.
835
836         Since the bytecode change, we enabled the baseline JIT on mips in
837         r240432, but DFG is still missing. With this change, all tests are
838         passing on a ci20 board.
839
840         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
841
842 2019-04-08  Philippe Normand  <pnormand@igalia.com>
843
844         [Flatpak] Second run update-webkitwpe-flatpak fails
845         https://bugs.webkit.org/show_bug.cgi?id=192702
846
847         Reviewed by Carlos Garcia Campos.
848
849         * flatpak/flatpakutils.py:
850         (FlatpakObject.flatpak): Fix typo.
851         (FlatpakPackage.install): When installing, also update to the configured remote commit.
852         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
853
854 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
855
856         [GTK][WPE] outlook.live.com displays old-fashioned UI
857         https://bugs.webkit.org/show_bug.cgi?id=196642
858
859         Reviewed by Carlos Garcia Campos.
860
861         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
862         (TestWebKitAPI::TEST): New Mac platform quirk test.
863
864 2019-04-07  Commit Queue  <commit-queue@webkit.org>
865
866         Unreviewed, rolling out r243956.
867         https://bugs.webkit.org/show_bug.cgi?id=196688
868
869         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
870         by aakashjain on #webkit).
871
872         Reverted changeset:
873
874         "Clicking "Go Back" from a safe browsing warning from an
875         iframe should navigate the WKWebView back to the previous
876         page"
877         https://bugs.webkit.org/show_bug.cgi?id=196665
878         https://trac.webkit.org/changeset/243956
879
880 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
881
882         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
883         https://bugs.webkit.org/show_bug.cgi?id=196669
884
885         Reviewed by Geoffrey Garen.
886
887         Added three new unit tests for WeakHashSet.
888
889         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
890         (WTF_WeakPtr.WeakHashSetConstObjects):
891         (WTF_WeakPtr.WeakHashSetComputesEmpty):
892         (WTF_WeakPtr.WeakHashSetComputeSize):
893
894 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
895
896         Hide next and previous form control buttons when WKWebView is editable
897         https://bugs.webkit.org/show_bug.cgi?id=196672
898         <rdar://problem/35625321>
899
900         Reviewed by Tim Horton.
901
902         Add a new API test.
903
904         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
905         (-[TestWKWebView lastTrailingBarButtonGroup]):
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/ios/UIKitSPI.h:
908
909 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
910
911         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
912         https://bugs.webkit.org/show_bug.cgi?id=196077
913         <rdar://problem/49108202>
914
915         Reviewed by Chris Dumez.
916
917         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
918         on new web view.
919
920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
921
922 2019-04-05  Saam Barati  <sbarati@apple.com>
923
924         Make compare-results understand MotionMark
925         https://bugs.webkit.org/show_bug.cgi?id=196666
926
927         Reviewed by Yusuke Suzuki.
928
929         * Scripts/compare-results:
930         (PLT5Results):
931         (detectMotionMark):
932         (detectMotionMark1_1):
933         (motionMarkResults):
934         (motionMark1_1Results):
935         (detectBenchmark):
936         (biggerIsBetter):
937         (main):
938
939 2019-04-05  Alex Christensen  <achristensen@webkit.org>
940
941         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
942         https://bugs.webkit.org/show_bug.cgi?id=196665
943         <rdar://45115669>
944
945         Reviewed by Geoff Garen.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
948         (goBack):
949         (+[SimpleLookupContext sharedLookupContext]):
950         (-[SimpleLookupContext lookUpURL:completionHandler:]):
951         (TEST):
952         (+[Simple3LookupContext sharedLookupContext]): Deleted.
953         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
954
955 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
956
957         [ews-build] Add configuration and architecture for windows builders
958         https://bugs.webkit.org/show_bug.cgi?id=196660
959
960         Reviewed by Lucas Forschler.
961
962         * BuildSlaveSupport/ews-build/config.json:
963
964 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
965
966         webkitpy: Don't run subsequent rounds if interrupted
967         https://bugs.webkit.org/show_bug.cgi?id=196646
968
969         Reviewed by Aakash Jain.
970
971         * Scripts/webkitpy/layout_tests/controllers/manager.py:
972         (Manager.run): Bail out if interrupted.
973
974 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
975
976         Test sessionStorage in PSON private browsing mode
977         https://bugs.webkit.org/show_bug.cgi?id=196561
978
979         Reviewed by Alex Christensen.
980
981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
982
983 2019-04-05  Commit Queue  <commit-queue@webkit.org>
984
985         Unreviewed, rolling out r243833.
986         https://bugs.webkit.org/show_bug.cgi?id=196645
987
988         This change breaks build of WPE and GTK ports (Requested by
989         annulen on #webkit).
990
991         Reverted changeset:
992
993         "[CMake][WTF] Mirror XCode header directories"
994         https://bugs.webkit.org/show_bug.cgi?id=191662
995         https://trac.webkit.org/changeset/243833
996
997 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
998
999         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1000         https://bugs.webkit.org/show_bug.cgi?id=196635
1001
1002         Reviewed by Antti Koivisto.
1003         
1004         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1005         for a test to enable async frame scrolling via:
1006             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1007         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1008         
1009         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1010
1011         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1012         (WTR::InjectedBundle::beginTesting):
1013         * WebKitTestRunner/TestController.cpp:
1014         (WTR::TestController::resetPreferencesToConsistentValues):
1015
1016 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1017
1018         Use a correct LC_RPATH when building with ASan
1019         https://bugs.webkit.org/show_bug.cgi?id=196576
1020
1021         Reviewed by David Kilzer.
1022
1023         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1024         so that ../Frameworks is checked. This is simpler and more reliable than updating
1025         each SPC service xcconfig.
1026
1027 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1028
1029         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1030         https://bugs.webkit.org/show_bug.cgi?id=196629
1031
1032         Reviewed by Lucas Forschler.
1033
1034         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1035
1036 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1037
1038         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1039         https://bugs.webkit.org/show_bug.cgi?id=196618
1040
1041         Reviewed by Lucas Forschler.
1042
1043         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1044         (StatusBubble): Added QUEUE_TRIGGERS.
1045         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1046         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1047         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1048         its parent(builder).
1049
1050 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1051
1052         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1053         https://bugs.webkit.org/show_bug.cgi?id=196625
1054
1055         Reviewed by Lucas Forschler.
1056
1057         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1058         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1059
1060 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1061
1062         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1063         https://bugs.webkit.org/show_bug.cgi?id=196630
1064
1065         Reviewed by Wenson Hsieh.
1066
1067         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1068
1069 2019-04-04  Youenn Fablet  <youenn@apple.com>
1070
1071         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1072         https://bugs.webkit.org/show_bug.cgi?id=196543
1073
1074         Reviewed by Alex Christensen.
1075
1076         * WebKitTestRunner/TestController.cpp:
1077         (WTR::TestController::generatePageConfiguration):
1078
1079 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews-app] Status bubble should not display skipped buildbot steps
1082         https://bugs.webkit.org/show_bug.cgi?id=196584
1083
1084         Reviewed by Lucas Forschler.
1085
1086         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1087
1088 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1091         https://bugs.webkit.org/show_bug.cgi?id=196620
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-app/ews/config.py:
1096
1097 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1098
1099         [Win] DumpRenderTreeWatchDog.py is not checked into source
1100         https://bugs.webkit.org/show_bug.cgi?id=196567
1101         <rdar://problem/49525901>
1102
1103         Reviewed by Lucas Forschler.
1104
1105         This script is used on Win EWS bots to terminate hanging DRT processes.
1106
1107         * EWSTools/dumprendertreewatchdog.py: Added.
1108
1109 2019-04-04  Chris Dumez  <cdumez@apple.com>
1110
1111         Unreviewed, roll out r243858 which made tests time out.
1112
1113         Disable new API tests on Windows instead.
1114
1115         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1116         (TestWebKitAPI::TEST):
1117
1118 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1119
1120         [ATK] Cleanup WebPageAccessibilityObjectAtk
1121         https://bugs.webkit.org/show_bug.cgi?id=196537
1122
1123         Reviewed by Michael Catanzaro.
1124
1125         Also consider files under atk directories as exceptions for GObject conventions.
1126
1127         * Scripts/webkitpy/style/checkers/cpp.py:
1128         (check_identifier_name_in_declaration):
1129
1130 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1131
1132         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1133         https://bugs.webkit.org/show_bug.cgi?id=196588
1134         <rdar://problem/49365787>
1135
1136         Unreviewed build fix for Windows port.
1137
1138         error C3861: 'kill': identifier not found
1139
1140         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1141         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1142
1143 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1144
1145         [ews-build] Cancel build and similar operations should have authentication
1146         https://bugs.webkit.org/show_bug.cgi?id=196520
1147
1148         Reviewed by Dewei Zhu.
1149
1150         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1151         environment variables.
1152
1153 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-build] Do not trigger queues which are not in production yet
1156         https://bugs.webkit.org/show_bug.cgi?id=196581
1157
1158         Reviewed by Dewei Zhu.
1159
1160         * BuildSlaveSupport/ews-build/config.json:
1161
1162 2019-04-03  Chris Dumez  <cdumez@apple.com>
1163
1164         Unreviewed, fix typo in the name of API test added in r243848.
1165
1166         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1167         (TestWebKitAPI::TEST):
1168
1169 2019-04-03  Chris Dumez  <cdumez@apple.com>
1170
1171         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1172         https://bugs.webkit.org/show_bug.cgi?id=196588
1173         <rdar://problem/49365787>
1174
1175         Reviewed by Ryosuke Niwa.
1176
1177         Add API test coverage.
1178
1179         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1180         (TestWebKitAPI::nullJavaScriptCallback):
1181         (TestWebKitAPI::didCrashCheckFrames):
1182         (TestWebKitAPI::TEST):
1183
1184 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1185
1186         run-webkit-tests: Upload test results (new results database)
1187         https://bugs.webkit.org/show_bug.cgi?id=196577
1188         <rdar://problem/34841155>
1189
1190         Reviewed by Lucas Forschler.
1191
1192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1193         (Manager.run): Upload results after each device shard, since the configuration will be
1194         different for each device.
1195         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1196         uploaded to a results database.
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1198         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1199
1200 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1201
1202         -apple-trailing-word is needed for browser detection
1203         https://bugs.webkit.org/show_bug.cgi?id=196575
1204
1205         Unreviewed.
1206
1207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1208
1209 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1210
1211         [CMake][WTF] Mirror XCode header directories
1212         https://bugs.webkit.org/show_bug.cgi?id=191662
1213
1214         Reviewed by Konstantin Tokarev.
1215
1216         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1217         builds.
1218
1219         * CMakeLists.txt:
1220         * DumpRenderTree/CMakeLists.txt:
1221         * DumpRenderTree/PlatformWin.cmake:
1222         * MiniBrowser/win/CMakeLists.txt:
1223         * TestWebKitAPI/CMakeLists.txt:
1224         * TestWebKitAPI/PlatformWin.cmake:
1225         * WebKitTestRunner/PlatformGTK.cmake:
1226         * WebKitTestRunner/PlatformWin.cmake:
1227
1228 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [ews-app] Status bubble should not display certain infrastructure status messages
1231         https://bugs.webkit.org/show_bug.cgi?id=196550
1232
1233         Reviewed by Lucas Forschler.
1234
1235         Do not display the steps which are un-needed for end-user. This information is still avaiable
1236         if the user click on the bubble and look at the Buildbot build.
1237         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1238         (StatusBubble._steps_messages):
1239         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1240
1241 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-build] Use https for sending data to ews-app
1244         https://bugs.webkit.org/show_bug.cgi?id=196492
1245
1246         Reviewed by Lucas Forschler.
1247
1248         * BuildSlaveSupport/ews-build/events.py:
1249
1250 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1251
1252         Remove support for -apple-trailing-word
1253         https://bugs.webkit.org/show_bug.cgi?id=196525
1254
1255         Reviewed by Zalan Bujtas.
1256
1257         This CSS property is nonstandard and not used.
1258
1259         * Scripts/webkitperl/FeatureList.pm:
1260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1261
1262 2019-04-03  Youenn Fablet  <youenn@apple.com>
1263
1264         Add a test for DOMCache on multiple browsing in case of private browsing
1265         https://bugs.webkit.org/show_bug.cgi?id=196524
1266
1267         Reviewed by Alex Christensen.
1268
1269         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1270         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1271
1272 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1273
1274         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1275         https://bugs.webkit.org/show_bug.cgi?id=196540
1276
1277         Reviewed by Aakash Jain.
1278
1279         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1280
1281 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1282
1283         Add plumbing for a compatibility mode preference in WebKit
1284         https://bugs.webkit.org/show_bug.cgi?id=196005
1285
1286         Reviewed by Tim Horton.
1287
1288         Add new API tests.
1289
1290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1291         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1292
1293 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1294
1295         [WPE][GTK] Update libsrtp dependency package for Debian
1296         https://bugs.webkit.org/show_bug.cgi?id=196528
1297
1298         Reviewed by Frédéric Wang.
1299
1300         * gtk/install-dependencies:
1301         * wpe/install-dependencies:
1302
1303 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1304
1305         [WK2] Add support for Window's beforeprint / afterprint events
1306         https://bugs.webkit.org/show_bug.cgi?id=196478
1307         <rdar://problem/49535124>
1308
1309         Unreviewed build fix for MSVC.
1310
1311         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1312
1313         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1314
1315         * WebKitTestRunner/TestController.cpp:
1316         (WTR::printFrame): Use int and float literals.
1317
1318 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1319
1320         [ews-build] Reassign bots to queues
1321
1322         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1323
1324 2019-04-02  Chris Dumez  <cdumez@apple.com>
1325
1326         [WK2] Add support for Window's beforeprint / afterprint events
1327         https://bugs.webkit.org/show_bug.cgi?id=196478
1328
1329         Reviewed by Alex Christensen.
1330
1331         Add minimal implementation for printFrame in WebKitTestRunner.
1332
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::printFrame):
1335         (WTR::TestController::createOtherPage):
1336         (WTR::TestController::createWebViewWithOptions):
1337
1338 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1339
1340         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1341         https://bugs.webkit.org/show_bug.cgi?id=196491
1342
1343         Reviewed by Lucas Forschler.
1344
1345         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1346
1347 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-build] Configure buildbot try credentials in environment variables
1350         https://bugs.webkit.org/show_bug.cgi?id=196501
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1355         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1356         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1357
1358 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1359
1360         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1361         https://bugs.webkit.org/show_bug.cgi?id=196496
1362         <rdar://problem/49521634>
1363
1364         Reviewed by Chris Dumez.
1365
1366         Add new API tests (see WebKit ChangeLog for more detail).
1367
1368         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1369         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1370         (TEST):
1371
1372 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1373
1374         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1375         <https://webkit.org/b/196499>
1376
1377         Reviewed by Alexey Proskuryakov.
1378
1379         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1380         ENABLE_ADDRESS_SANITIZER.
1381
1382 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1383
1384         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1385         https://bugs.webkit.org/show_bug.cgi?id=182757
1386
1387         Reviewed by Don Olmstead.
1388
1389         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1390         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1391
1392 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1393
1394         run-api-tests: Upload test results
1395         https://bugs.webkit.org/show_bug.cgi?id=196323
1396         <rdar://problem/49356714>
1397
1398         Reviewed by Lucas Forschler.
1399
1400         * Scripts/webkitpy/api_tests/manager.py:
1401         (Manager):
1402         (Manager.run): Upload results to a results database.
1403         * Scripts/webkitpy/api_tests/run_api_tests.py:
1404         (parse_args): Add upload arguments.
1405         * Scripts/webkitpy/port/base.py:
1406         (Port):
1407         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1408         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1409         with commits from any other associated repositories.
1410         * Scripts/webkitpy/port/device.py:
1411         (Device):
1412         (Device.build_version): Access build_versoin of underlying platform device.
1413         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1414         (IOSSimulatorTest):
1415         (IOSSimulatorTest.test_configuration_for_upload):
1416         * Scripts/webkitpy/port/device_port.py:
1417         (DevicePort):
1418         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1419         the same as the machine uploading results.
1420         * Scripts/webkitpy/port/mac.py:
1421         (MacPort):
1422         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1423         * Scripts/webkitpy/port/mac_unittest.py:
1424         (MacTest):
1425         (MacTest.test_configuration_for_upload):
1426         * Scripts/webkitpy/xcode/simulated_device.py:
1427         (SimulatedDeviceManager._create_device_with_runtime):
1428         (SimulatedDevice.__init__): Create simulated device with a build_version.
1429         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1430         (test_existing_simulator):
1431
1432 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1433
1434         Remove extra newline characters (Follow-up fix to r243707)
1435
1436         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1437
1438 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1439
1440         [ews-app] Use API_KEY to accept results data
1441         https://bugs.webkit.org/show_bug.cgi?id=196461
1442
1443         Reviewed by Dewei Zhu.
1444
1445         * BuildSlaveSupport/ews-app/ews/views/results.py:
1446         (Results.post): Validate EWS_API_KEY before accepting any data.
1447         * BuildSlaveSupport/ews-build/events.py:
1448         (Events.sendData): Send EWS_API_KEY if available along with event data.
1449
1450 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1451
1452         Unable to copy and paste a PDF from Notes into Mail compose body
1453         https://bugs.webkit.org/show_bug.cgi?id=196442
1454         <rdar://problem/48573098>
1455
1456         Reviewed by Tim Horton.
1457
1458         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1459         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1460         to be specified on the item providers.
1461
1462         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1463         (TestWebKitAPI::mapItemForTesting):
1464         (TestWebKitAPI::contactItemForTesting):
1465
1466 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1467
1468         Make UIWKDocumentContext rects per-character instead of per-word
1469         https://bugs.webkit.org/show_bug.cgi?id=196459
1470
1471         Reviewed by Wenson Hsieh.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1474         (TEST):
1475         Adjust test results due to switching to per-character rects.
1476
1477 2019-04-01  Chris Dumez  <cdumez@apple.com>
1478
1479         UIProcess crash when a prewarmed process is terminated
1480         https://bugs.webkit.org/show_bug.cgi?id=196451
1481         <rdar://problem/49245471>
1482
1483         Reviewed by Geoffrey Garen.
1484
1485         Add API test coverage.
1486
1487         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1488         (TEST):
1489
1490 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1491
1492         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1493         https://bugs.webkit.org/show_bug.cgi?id=196449
1494
1495         Reviewed by Lucas Forschler.
1496
1497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1498         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1499         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1500         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1501
1502 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1503
1504         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1505         https://bugs.webkit.org/show_bug.cgi?id=196444
1506
1507         Reviewed by Lucas Forschler.
1508
1509         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1510
1511 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1512
1513         Add SPI to canonicalize NSURLs with WTF::URL
1514         https://bugs.webkit.org/show_bug.cgi?id=196415
1515         <rdar://problem/44980271>
1516
1517         Reviewed by Darin Adler.
1518
1519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1520         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1521         (TestWebKitAPI::TEST):
1522
1523 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1524
1525         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1526         https://bugs.webkit.org/show_bug.cgi?id=196441
1527
1528         Reviewed by Carlos Garcia Campos.
1529
1530         Don't cache the wpe_view_backend object that might not exist yet at the
1531         time of EventSenderProxy constructor invocation, but instead retrieve
1532         that object whenever it's required for event dispatching. This should
1533         avoid crashes in this constructor now that it's invoked before any
1534         PlatformWindow has been set up (as changed in r243496).
1535
1536         * WebKitTestRunner/EventSenderProxy.h:
1537         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1538         (WTR::viewBackend):
1539         (WTR::EventSenderProxy::EventSenderProxy):
1540         (WTR::EventSenderProxy::mouseDown):
1541         (WTR::EventSenderProxy::mouseUp):
1542         (WTR::EventSenderProxy::mouseMoveTo):
1543         (WTR::EventSenderProxy::mouseScrollBy):
1544         (WTR::EventSenderProxy::keyDown):
1545         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1546
1547 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1548
1549         [Win][WebKit] MiniBrowser should support high DPI display
1550         https://bugs.webkit.org/show_bug.cgi?id=196391
1551
1552         Reviewed by Alex Christensen.
1553
1554         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1555         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1556         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1557         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1558
1559 2019-03-31  Sam Weinig  <weinig@apple.com>
1560
1561         Remove more i386 specific configurations
1562         https://bugs.webkit.org/show_bug.cgi?id=196430
1563
1564         Reviewed by Alexey Proskuryakov.
1565
1566         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1567         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1568
1569 2019-03-31  Andy Estes  <aestes@apple.com>
1570
1571         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1572         https://bugs.webkit.org/show_bug.cgi?id=196433
1573         <rdar://problem/49293305>
1574
1575         Reviewed by Tim Horton.
1576
1577         Enhanced API test coverage to include all navigation response policy decisions in both
1578         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1584         (readFile):
1585         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1586         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1587         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1588         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1589         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1590         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1591         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1592         (-[QuickLookDelegate _downloadDidStart:]):
1593         (-[QuickLookDelegate _download:didReceiveResponse:]):
1594         (-[QuickLookDelegate _download:didReceiveData:]):
1595         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1596         (-[QuickLookDelegate _downloadDidFinish:]):
1597         (-[QuickLookDelegate _download:didFailWithError:]):
1598         (-[QuickLookDelegate _downloadDidCancel:]):
1599         (-[QuickLookDelegate verifyDownload]):
1600         (runTest):
1601         (runTestDecideBeforeLoading):
1602         (runTestDecideAfterLoading):
1603         (TEST):
1604         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1605         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1606         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1607         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1608         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1609         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1610         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1611         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1612         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1613         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1614         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1615         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1616         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1617         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1618
1619 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1620
1621         [CMake] add testdfg as target with build-jsc
1622         https://bugs.webkit.org/show_bug.cgi?id=196393
1623
1624         Reviewed by Saam Barati.
1625
1626         Added testdfg as one of the targets to build when
1627         using CMake.
1628
1629         * Scripts/build-jsc:
1630
1631 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1632
1633         Delete WebMetal implementation in favor of WebGPU
1634         https://bugs.webkit.org/show_bug.cgi?id=195418
1635
1636         Reviewed by Dean Jackson.
1637
1638         * DumpRenderTree/mac/DumpRenderTree.mm:
1639         (enableExperimentalFeatures):
1640         (resetWebPreferencesToConsistentValues):
1641         * Scripts/webkitperl/FeatureList.pm:
1642         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1644         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1645         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1646         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1647         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1648         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1649         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1650         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1651         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1652         (WTR::InjectedBundle::beginTesting):
1653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1654         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1656
1657 2019-03-29  Chris Dumez  <cdumez@apple.com>
1658
1659         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1660         https://bugs.webkit.org/show_bug.cgi?id=196405
1661         <rdar://problem/49428130>
1662
1663         Reviewed by Wenson Hsieh.
1664
1665         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1666         the popover presentation methods to be no-ops. Use this in the new test added in
1667         r243523 so that we do not swizzle those methods for all tests. This is needed because
1668         those WatchOS tests rely on the popover getting presented and interactive.
1669
1670         * WebKitTestRunner/TestController.cpp:
1671         (WTR::updateTestOptionsFromTestHeader):
1672         * WebKitTestRunner/TestController.h:
1673         * WebKitTestRunner/TestOptions.h:
1674         (WTR::TestOptions::hasSameInitializationOptions const):
1675         * WebKitTestRunner/ios/TestControllerIOS.mm:
1676         (WTR::TestController::platformInitialize):
1677         (WTR::TestController::platformResetStateToConsistentValues):
1678
1679 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1680
1681         [Curl] Add Server Trust Evaluation Support.
1682         https://bugs.webkit.org/show_bug.cgi?id=191646
1683
1684         Reviewed by Fujii Hironori.
1685
1686         Implemented MiniBrowser UI for asking if user trusts the server.
1687
1688         * MiniBrowser/win/Common.cpp:
1689         (askServerTrustEvaluation):
1690         (replaceString):
1691         * MiniBrowser/win/Common.h:
1692         * MiniBrowser/win/MiniBrowserLib.rc:
1693         * MiniBrowser/win/MiniBrowserLibResource.h:
1694         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1695         (createPEMString):
1696         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1697         (WebKitBrowserWindow::canTrustServerCertificate):
1698         * MiniBrowser/win/WebKitBrowserWindow.h:
1699
1700 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1701
1702         Implement ResizeObserver.
1703         https://bugs.webkit.org/show_bug.cgi?id=157743
1704
1705         Reviewed by Simon Fraser.
1706
1707         Support resizeObserverEnabled webPreferences.
1708
1709         * DumpRenderTree/TestOptions.cpp:
1710         (TestOptions::TestOptions):
1711         * DumpRenderTree/TestOptions.h:
1712         * DumpRenderTree/mac/DumpRenderTree.mm:
1713         (setWebPreferencesForTestOptions):
1714         * DumpRenderTree/win/DumpRenderTree.cpp:
1715         (enableExperimentalFeatures):
1716         * Scripts/webkitperl/FeatureList.pm:
1717         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1718
1719 2019-03-28  John Wilander  <wilander@apple.com>
1720
1721         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1722         https://bugs.webkit.org/show_bug.cgi?id=196281
1723         <rdar://problem/48938748>
1724
1725         Reviewed by Alex Christensen.
1726
1727         This patch adds the function isStatisticsHasLocalStorage() to the
1728         TestRunner. With it, the page can query the WebsiteDataStore in the
1729         UI process to make sure that it sees LocalStorage.
1730
1731         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1732         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1733         (WTR::TestRunner::isStatisticsHasLocalStorage):
1734         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1735         * WebKitTestRunner/TestController.cpp:
1736         (WTR::TestController::isStatisticsHasLocalStorage):
1737         * WebKitTestRunner/TestController.h:
1738         * WebKitTestRunner/TestInvocation.cpp:
1739         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1740
1741 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1742
1743         API::Data::createWithoutCopying should do a null check before calling CFRelease
1744         https://bugs.webkit.org/show_bug.cgi?id=196276
1745         <rdar://problem/48059859>
1746
1747         Reviewed by Alex Christensen.
1748
1749         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1752         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1753         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1754         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1755         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1756         (TestWebKitAPI::TEST):
1757
1758 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1759
1760         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1761         https://bugs.webkit.org/show_bug.cgi?id=186276
1762
1763         Reviewed by Carlos Garcia Campos.
1764
1765         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1766         (webViewLoadChanged):
1767         (testWebResourceGetDataError):
1768         (testWebResourceGetDataEmpty):
1769         (beforeAll):
1770         (webViewloadChanged): Deleted.
1771
1772 2019-03-27  Andy Estes  <aestes@apple.com>
1773
1774         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1775         https://bugs.webkit.org/show_bug.cgi?id=196317
1776
1777         Reviewed by Dan Bernstein.
1778
1779         package-root copies built products into a staging directory using ditto(1), which does not
1780         follow symbolic links as it traverses a directory. Now that the files in
1781         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1782         itself, these become broken links when ditto'd into the staging directory.
1783
1784         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1785
1786         * Scripts/package-root:
1787
1788 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1789
1790         [ews-app] Update display text of Submit for ews analysis
1791         https://bugs.webkit.org/show_bug.cgi?id=196309
1792
1793         Reviewed by Dewei Zhu.
1794
1795         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1796
1797 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1798
1799         run-webkit-tests should check for leaks in WebKit processes
1800         <https://webkit.org/b/193772>
1801         <rdar://problem/46526680>
1802
1803         Reviewed by Ryosuke Niwa.
1804
1805         This works by doing the following:
1806         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1807           The list of child processes are returned one per line:
1808           process.name: pid
1809         - Run the "#LIST CHILD PROCESSES" command just before the
1810           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1811           processes on the ServerProcess object.
1812         - When the `--leaks` switch is handled, run check_for_leaks() on
1813           each child process after the main test harness.
1814
1815         * DumpRenderTree/mac/DumpRenderTree.mm:
1816         (handleControlCommand):
1817         - Use strncmp() instead of strcmp().
1818         - Add support for handling "#LIST CHILD PROCESSES" command.
1819
1820         * Scripts/webkitpy/port/base.py:
1821         (Port.check_for_leaks):
1822         * Scripts/webkitpy/port/darwin.py:
1823         (DarwinPort.check_for_leaks):
1824         - Rename redundant 'process_pid' argument to 'process_id'.
1825
1826         * Scripts/webkitpy/port/driver.py:
1827         (Driver.do_post_tests_work):
1828         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1829           longer the only command this sends to WebKitTestRunner.
1830         - If the `--leaks` switch is present, send the
1831           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1832           result using Port.set_webkit_processes().
1833         (Driver._parse_child_processes_output):
1834         - Add helper method to parse list of child process names and
1835           process IDs returned from WebKitTestRunner.
1836
1837         * Scripts/webkitpy/port/ios_device.py:
1838         (IOSDevicePort.check_for_leaks):
1839         - Rename redundant 'process_pid' argument to 'process_id'.
1840
1841         * Scripts/webkitpy/port/leakdetector.py:
1842         (LeakDetector._parse_leaks_output):
1843         - Return early if there is no leaks_output.
1844         (LeakDetector.check_for_leaks):
1845         - Rename redundant 'process_pid' argument to 'process_id'.
1846
1847         * Scripts/webkitpy/port/server_process.py:
1848         (ServerProcess.__init__):
1849         (ServerProcess.child_processes):
1850         (ServerProcess.set_child_processes):
1851         - Add instance variable to Port to store list of child process
1852           names and process IDs returned from WebKitTestRunner.
1853         (ServerProcess._start):
1854         - Clear self._child_processes.
1855         (ServerProcess.stop):
1856         - If self._child_processes is set, call
1857           self._port.check_for_leaks() for each child process.
1858
1859         * Scripts/webkitpy/port/server_process_unittest.py:
1860         (TrivialMockPort.check_for_leaks):
1861         - Rename redundant 'process_pid' argument to 'process_id'.
1862
1863         * Scripts/webkitpy/port/simulator_process.py:
1864         (SimulatorProcess.stop):
1865         - If self._child_processes is set, call
1866           self._port.check_for_leaks() for each child process.
1867
1868         * Scripts/webkitpy/port/watch_device.py:
1869         (WatchDevicePort.check_for_leaks):
1870         - Rename redundant 'process_pid' argument to 'process_id'.
1871
1872         * WebKitTestRunner/TestController.cpp:
1873         (WTR::TestController::dumpResponse):
1874         - Extract method from findAndDumpWorldLeaks() so that it may be
1875           reused by findAndDumpWebKitProcessIdentifiers().
1876         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1877         - Add method to output process name and process ID of both the
1878           WebContent and Networking processes.
1879         (WTR::TestController::findAndDumpWorldLeaks):
1880         - Fix missing newline in output when there were no abandoned
1881           documents.
1882         - Call dumpResponse() for extracted code.
1883         (WTR::TestController::handleControlCommand):
1884         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1885         - Use strncmp() instead of strcmp().
1886         - Call findAndDumpWebKitProcessIdentifiers() when
1887           "#LIST CHILD PROCESSES" command is sent.
1888         * WebKitTestRunner/TestController.h:
1889         (WTR::TestController::dumpResponse):
1890         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1891         - Declare methods.
1892
1893 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1894
1895         Unreviewed. Add GLib API test cases after r243434.
1896
1897         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1898         (testWebViewActiveURI):
1899         (serverCallback):
1900         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1901         (sendRequestCallback):
1902
1903 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1904
1905         Geolocation request not complete when watch request was started in a different web process
1906         https://bugs.webkit.org/show_bug.cgi?id=195996
1907
1908         Reviewed by Alex Christensen.
1909
1910         Add a test case.
1911
1912         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1913         (TestWebKitAPI::runJavaScriptAlert):
1914         (TestWebKitAPI::TEST):
1915
1916 2019-03-26  Keith Rollin  <krollin@apple.com>
1917
1918         Update the way generate-xcfilelists returns strings from functions
1919         https://bugs.webkit.org/show_bug.cgi?id=195975
1920         <rdar://problem/49040807>
1921
1922         Reviewed by Dean Jackson.
1923
1924         There are places where generate-xcfilelists executes assignments with
1925         statements like:
1926
1927             FOO=$(some_function)
1928
1929         where "some_function" return a string by echoing it. E.g.
1930
1931             some_function()
1932             {
1933                 echo "Hello, World"
1934             }
1935
1936         This is a common idiom, but it has a problem if "some_function" needs
1937         to call "exit" in an attempt to halt the entire script right then and
1938         there. Since "some_function" is called inside of $(), it's being
1939         executed in a sub-shell. Calling exit in that sub-shell simply exits
1940         that shell; it doesn't not exit the outer shell in which the main part
1941         of the script is still running. As such, the main script keeps
1942         executing when the intent was for the script to halt.
1943
1944         The solution to this is to use a different idiom for returning
1945         strings. The one we now is to pass in the name of the variable to
1946         receive the string result:
1947
1948             some_function()
1949             {
1950                 variable_name=$1
1951                 eval $variable_name ="Hello, World"
1952             }
1953
1954         The call site now looks like
1955
1956             some_function FOO
1957
1958         Because there's no invocation of a sub-shell, some_function can now
1959         call "exit" if it wants to, and the entire script will exit at that
1960         point.
1961
1962         * Scripts/generate-xcfilelists:
1963
1964 2019-03-26  Chris Dumez  <cdumez@apple.com>
1965
1966         Add basic layout test coverage for File Picker on iOS
1967         https://bugs.webkit.org/show_bug.cgi?id=196265
1968
1969         Reviewed by Wenson Hsieh.
1970
1971         Add layout test infrastructure to test the file picker on iOS.
1972
1973         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1974         (WTR::UIScriptController::dismissFilePicker):
1975         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1976         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1977         (WTR::UIScriptController::dismissFilePicker):
1978         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1979         * WebKitTestRunner/TestController.cpp:
1980         (WTR::TestController::createWebViewWithOptions):
1981         (WTR::updateTestOptionsFromTestHeader):
1982         * WebKitTestRunner/TestOptions.h:
1983         (WTR::TestOptions::hasSameInitializationOptions const):
1984         * WebKitTestRunner/ios/TestControllerIOS.mm:
1985         (overridePresentViewController):
1986         (WTR::TestController::platformInitialize):
1987         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1988         (WTR::UIScriptController::dismissFilePicker):
1989
1990 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1991
1992         Implement async paste method on UIWKInteractionViewProtocol
1993         https://bugs.webkit.org/show_bug.cgi?id=196267
1994         <rdar://problem/49236346>
1995
1996         Reviewed by Tim Horton.
1997
1998         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1999         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2000         are now a part of all iOS 12 internal SDKs.
2001
2002         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2003
2004         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2005         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2006
2007         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2008         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2009         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2010         * TestWebKitAPI/ios/UIKitSPI.h:
2011
2012 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2013
2014         [ews-build] Use PostgreSQL for ews.webkit.org database
2015         https://bugs.webkit.org/show_bug.cgi?id=196270
2016
2017         Reviewed by Lucas Forschler.
2018
2019         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2020
2021 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2022
2023         [ews] Reset simctl states on reboot
2024         https://bugs.webkit.org/show_bug.cgi?id=196260
2025
2026         Rubber-stamped by Aakash Jain.
2027
2028         * EWSTools/start-queue-mac.sh:
2029
2030 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-build] Use PostgreSQL for ews-build database
2033         https://bugs.webkit.org/show_bug.cgi?id=196229
2034
2035         Reviewed by Lucas Forschler.
2036
2037         * BuildSlaveSupport/ews-build/master.cfg:
2038
2039 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2040
2041         [ews-build] Get master_hostname dynamically in master.cfg
2042         https://bugs.webkit.org/show_bug.cgi?id=196255
2043
2044         Reviewed by Lucas Forschler.
2045
2046         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2047         send events data in test mode.
2048
2049 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2050
2051         [ews-app] Set db_constraint to False for Foreign Keys
2052         https://bugs.webkit.org/show_bug.cgi?id=196252
2053
2054         Reviewed by Lucas Forschler.
2055
2056         * BuildSlaveSupport/ews-app/ews/models/build.py:
2057         * BuildSlaveSupport/ews-app/ews/models/step.py:
2058
2059 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews-build] is_test_mode_enabled should default to True
2062         https://bugs.webkit.org/show_bug.cgi?id=196248
2063
2064         Reviewed by Lucas Forschler.
2065
2066         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2067
2068 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-app] Add webkitperl to ENABLED_QUEUES
2071         https://bugs.webkit.org/show_bug.cgi?id=196253
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2076
2077 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2078
2079         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2080         https://bugs.webkit.org/show_bug.cgi?id=196211
2081         rdar://problem/49110552
2082
2083         Reviewed by Tim Horton.
2084
2085         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2086         Make sure that EventSenderProxy always exists when running tests. We used to create
2087         it when resetting before the first test, which is a bit too late.
2088
2089         * WebKitTestRunner/TestController.h:
2090         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2091         (WTR::TestController::platformCreateWebView):
2092         (WTR::TestController::platformCreateOtherPage):
2093         (WTR::TestController::finishCreatingPlatformWebView):
2094         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2095         (WTR::PlatformWebView::PlatformWebView):
2096         Moved some code that made NSWindow use NSEvent during web view creation. We may
2097         need to move more if some other case us found, but this is enough for now.
2098
2099 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2100
2101         Unreviewed. Fix typo in GLib geolocation API after r243285.
2102
2103         gelocation -> geolocation.
2104
2105         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2106         (testGeolocationManagerWatchPosition):
2107
2108 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2109
2110         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2111         https://bugs.webkit.org/show_bug.cgi?id=196213
2112
2113         Reviewed by Geoff Garen.
2114
2115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2116         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2117         (credentialWithIdentityAndKeychainPath):
2118         (-[ChallengeDelegate webView:didFinishNavigation:]):
2119         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2120         (TestWebKitAPI::TEST):
2121
2122 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2123
2124         Expected shouldn't assume its contained types are copyable
2125         https://bugs.webkit.org/show_bug.cgi?id=195986
2126
2127         Reviewed by JF Bastien.
2128
2129         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2130         (TestWebKitAPI::NonCopyable::operator== const):
2131         (TestWebKitAPI::NonCopyable::operator!= const):
2132         (TestWebKitAPI::TEST):
2133
2134 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2135
2136         Remove some now-unnecessary dynamic class lookup
2137         https://bugs.webkit.org/show_bug.cgi?id=196237
2138
2139         Reviewed by Simon Fraser.
2140
2141         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2142         (makeRequest):
2143         (TEST):
2144
2145 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2146
2147         Unreviewed, rolling out r243450.
2148
2149         AppleWin and WinCairo port builds get broken.
2150
2151         Reverted changeset:
2152
2153         "Add test for fix of #196095"
2154         https://bugs.webkit.org/show_bug.cgi?id=196097
2155         https://trac.webkit.org/changeset/243450
2156
2157 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2158
2159         Unreviewed, rolling out r243465.
2160         https://bugs.webkit.org/show_bug.cgi?id=196226
2161
2162         the test doesn't build (Requested by thorton on #webkit).
2163
2164         Reverted changeset:
2165
2166         "Do not terminate the NetworkProcess if a third party
2167         application sends a NSCredential with a SecIdentityRef"
2168         https://bugs.webkit.org/show_bug.cgi?id=196213
2169         https://trac.webkit.org/changeset/243465
2170
2171 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2172
2173         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2174         https://bugs.webkit.org/show_bug.cgi?id=196213
2175
2176         Reviewed by Geoff Garen.
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2180         (credentialWithIdentityAndKeychainPath):
2181         (-[ChallengeDelegate webView:didFinishNavigation:]):
2182         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2183         (TestWebKitAPI::TEST):
2184
2185 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2186
2187         [ews-build] Gracefully handle missing patch_id in events
2188         https://bugs.webkit.org/show_bug.cgi?id=196216
2189
2190         Reviewed by Lucas Forschler.
2191
2192         * BuildSlaveSupport/ews-build/events.py:
2193
2194 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2195
2196         [ews-build] use lz4 compression for improving buildbot performance
2197         https://bugs.webkit.org/show_bug.cgi?id=196155
2198
2199         Reviewed by Lucas Forschler.
2200
2201         * BuildSlaveSupport/ews-build/master.cfg:
2202
2203 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2204
2205         Pull some API testing helper methods out of TestWKWebView
2206         https://bugs.webkit.org/show_bug.cgi?id=196212
2207
2208         Reviewed by Tim Horton.
2209
2210         Refactor some more API testing utility methods, so that they can be used in
2211         tests that do not use TestWKWebView.
2212
2213         * TestWebKitAPI/cocoa/TestWKWebView.h:
2214         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2215         (-[WKWebView loadTestPageNamed:]):
2216         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2217         (-[WKWebView synchronouslyLoadHTMLString:]):
2218         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2219         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2220         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2221         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2222         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2223
2224 2019-03-25  Jer Noble  <jer.noble@apple.com>
2225
2226         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2227         https://bugs.webkit.org/show_bug.cgi?id=196097
2228
2229         Reviewed by Eric Carlson.
2230
2231         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2232
2233         * DumpRenderTree/mac/DumpRenderTree.mm:
2234         (resetWebPreferencesToConsistentValues):
2235         * WebKitTestRunner/TestController.cpp:
2236         (WTR::TestController::resetPreferencesToConsistentValues):
2237
2238 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2239
2240         Pull IPadUserInterfaceSwizzler out into a separate header file
2241         https://bugs.webkit.org/show_bug.cgi?id=196193
2242
2243         Reviewed by Anders Carlsson.
2244
2245         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2246         be used in other API tests.
2247
2248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2249         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2250         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2251         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2252         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2253         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2254         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2255
2256 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2257
2258         Remove NavigatorContentUtils in WebCore/Modules
2259         https://bugs.webkit.org/show_bug.cgi?id=196070
2260
2261         Reviewed by Alex Christensen.
2262
2263         NavigatorContentUtils was to support the custom scheme spec [1].
2264         However, in WebKit side, no port has supported the feature in
2265         WebKit layer after EFL port was removed. So there has been the
2266         only IDL implementation of the NavigatorContentUtils in WebCore.
2267         So we don't need to keep the implementation in WebCore anymore.
2268
2269         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2270
2271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2272
2273 2019-03-24  Andy Estes  <aestes@apple.com>
2274
2275         [watchOS] Remove unused Proximity Networking code
2276         https://bugs.webkit.org/show_bug.cgi?id=196188
2277
2278         Reviewed by Tim Horton.
2279
2280         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2281         (TEST):
2282
2283 2019-03-23  Keith Miller  <keith_miller@apple.com>
2284
2285         Refactor clz/ctz and fix getLSBSet.
2286         https://bugs.webkit.org/show_bug.cgi?id=196162
2287
2288         Reviewed by Saam Barati.
2289
2290         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2291
2292         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2293         (TestWebKitAPI::TEST):
2294
2295 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2296
2297         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2298         https://bugs.webkit.org/show_bug.cgi?id=196143
2299
2300         Reviewed by Michael Catanzaro.
2301
2302         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2303         directories.
2304
2305         * Scripts/webkitpy/style/checkers/cpp.py:
2306         (check_identifier_name_in_declaration):
2307         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2308         (WebKitStyleTest.test_names):
2309
2310 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2311
2312         [Flatpak] Manifest expanding fails for qt WPE extension
2313         https://bugs.webkit.org/show_bug.cgi?id=196148
2314
2315         Reviewed by Alex Christensen.
2316
2317         * flatpak/flatpakutils.py:
2318         (expand_submodules_recurse): The last recurse manifest expand
2319         iteration might lead to a single module so take it into account
2320         and don't try to recurse further.
2321
2322 2019-03-22  Chris Dumez  <cdumez@apple.com>
2323
2324         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2325         https://bugs.webkit.org/show_bug.cgi?id=195348
2326         <rdar://problem/48622090>
2327
2328         Reviewed by Alex Christensen.
2329
2330         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2331         to NO when test.options().shouldIgnoreMetaViewport is false.
2332
2333         * WebKitTestRunner/ios/TestControllerIOS.mm:
2334         (WTR::TestController::platformConfigureViewForTest):
2335
2336 2019-03-22  Chris Dumez  <cdumez@apple.com>
2337
2338         Prewarmed processes should be usable with any website data store
2339         https://bugs.webkit.org/show_bug.cgi?id=196104
2340
2341         Reviewed by Alex Christensen.
2342
2343         Add API test coverage.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2346         (runInitialWarmedProcessUsedTest):
2347         (TEST):
2348
2349 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2350
2351         Back out local changes to Alex's Subversion working directory
2352
2353         They were accidentally committed.
2354
2355         * Scripts/webkitpy/common/system/abstractexecutive.py:
2356         (AbstractExecutive.wait_newest):
2357         * Scripts/webkitpy/common/system/executive.py:
2358         (Executive.running_pids):
2359         * Scripts/webkitpy/common/system/executive_mock.py:
2360         (MockExecutive.running_pids):
2361         * Scripts/webkitpy/common/system/executive_unittest.py:
2362         (ExecutiveTest.serial_test_running_pids):
2363         * Scripts/webkitpy/port/darwin.py:
2364         (DarwinPort.check_for_leaks):
2365         * Scripts/webkitpy/port/leakdetector.py:
2366         (LeakDetector.check_for_leaks):
2367         - This was the hack attached to Bug 193772.
2368
2369         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2370         (+[WebKitTestRunnerEvent mouseLocation]):
2371         - This works around a crash on an internal build.
2372
2373 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2374
2375         Fix the build after r243354
2376         https://bugs.webkit.org/show_bug.cgi?id=196138
2377         <rdar://problem/49145951>
2378
2379         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2380         (TEST):
2381         * TestWebKitAPI/ios/UIKitSPI.h:
2382
2383 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2384
2385         Adopt UIWKDocumentContext
2386         https://bugs.webkit.org/show_bug.cgi?id=196040
2387         <rdar://problem/48642440>
2388
2389         Reviewed by Ryosuke Niwa.
2390
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2392         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2393         (makeRequest):
2394         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2395         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2396         (applyStyle):
2397         (TEST):
2398         Add tests for UIWKDocumentContext.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2401         (TEST):
2402         (recursiveFindWKContentView): Deleted.
2403         * TestWebKitAPI/cocoa/TestWKWebView.h:
2404         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2405         (recursiveFindWKContentView):
2406         (-[TestWKWebView wkContentView]):
2407         * TestWebKitAPI/ios/UIKitSPI.h:
2408         Share the WKContentView finding code between tests.
2409
2410 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2411
2412         [iOS WK2] Turn on async overflow scrolling by default
2413         https://bugs.webkit.org/show_bug.cgi?id=196011
2414         rdar://problem/48453859
2415
2416         Reviewed by Antti Koivisto.
2417         
2418         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2419         since so many basic layout tests have different results when compositing is triggered for
2420         overflow.
2421         
2422         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2423
2424         * WebKitTestRunner/TestController.cpp:
2425         (WTR::TestController::resetPreferencesToConsistentValues):
2426
2427 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2428
2429         [ews-build] Retry API test in case of failures
2430         https://bugs.webkit.org/show_bug.cgi?id=196004
2431
2432         Reviewed by Lucas Forschler.
2433
2434         * BuildSlaveSupport/ews-build/steps.py:
2435         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2436         (CompileWebKitToT.doStepIf): Ditto.
2437         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2438         (ReRunAPITests): Re-run API tests.
2439         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2440         (RunAPITestsWithoutPatch): Run API tests without patch.
2441         (RunAPITestsWithoutPatch.doStepIf):
2442         (RunAPITestsWithoutPatch.hideStepIf):
2443         (RunAPITestsWithoutPatch.evaluateCommand):
2444         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2445         (AnalyzeAPITestsResults.start):
2446         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2447         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2448         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2449         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2450
2451 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2452
2453         [ews-build] Update queues configurations
2454         https://bugs.webkit.org/show_bug.cgi?id=196074
2455
2456         Reviewed by Dewei Zhu.
2457
2458         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2459         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2460
2461 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2462
2463         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2464         https://bugs.webkit.org/show_bug.cgi?id=195680
2465         <rdar://problem/48903534>
2466
2467         Unreviewed infrastructure fix.
2468
2469         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2470         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2471
2472 2019-03-21  Andy Estes  <aestes@apple.com>
2473
2474         [iOS] Apple Pay should be available in documents with no user agent scripts
2475         https://bugs.webkit.org/show_bug.cgi?id=196061
2476         <rdar://problem/48649391>
2477
2478         Reviewed by Brady Eidson.
2479
2480         Added API tests and related infrastructure.
2481
2482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2483         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2484         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2485         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2488         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2489         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2490         * TestWebKitAPI/cocoa/TestProtocol.mm:
2491         (-[TestProtocol startLoading]):
2492         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2493         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2494         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2495         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2496
2497 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2498
2499         REGRESSSION (r243297): webkitpy tests broken
2500         https://bugs.webkit.org/show_bug.cgi?id=196108
2501
2502         Reviewed by Aakash Jain.
2503
2504         r243297 updated contributors.json, which broke a few unit tests.
2505
2506         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2507         (IRCCommandTest.test_whois):
2508         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2509
2510 2019-03-21  Chris Dumez  <cdumez@apple.com>
2511
2512         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2513         https://bugs.webkit.org/show_bug.cgi?id=196041
2514         <rdar://problem/49083230>
2515
2516         Reviewed by Alex Christensen.
2517
2518         Add API test coverage.
2519
2520         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2521         (TEST):
2522
2523 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2524
2525         Add SPI to inform applications of WKContentRuleList actions
2526         https://bugs.webkit.org/show_bug.cgi?id=195965
2527         <rdar://problem/42664365>
2528
2529         Reviewed by Geoff Garen.
2530
2531         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2532         (TestWebKitAPI::allActionsForResourceLoad):
2533         (TestWebKitAPI::testRequest):
2534         (TestWebKitAPI::TEST_F):
2535         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2536         (Notification::description):
2537         (Notification::operator== const):
2538         (toVector):
2539         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2540         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2541         (makeContentRuleList):
2542         (TEST):
2543         (makeWarnContentRuleList): Deleted.
2544
2545 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2546
2547         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2548         https://bugs.webkit.org/show_bug.cgi?id=196088
2549
2550         Reviewed by Brian Burg.
2551
2552         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2553         Support checks when only one platform is specified. Also deprecate macosx() and
2554         force the use of macos() instead.
2555
2556         * Scripts/webkitpy/style/checkers/cpp.py:
2557         (check_min_versions_of_wk_api_available):
2558         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2559         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2560
2561 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2562
2563         Update status inactive committers' status to 'contributor'.
2564
2565         * Scripts/webkitpy/common/config/contributors.json:
2566
2567 2019-03-21  Xan Lopez  <xan@igalia.com>
2568
2569         [JSC][x86] Drop support for x87 floating point
2570         https://bugs.webkit.org/show_bug.cgi?id=194853
2571
2572         Reviewed by Don Olmstead.
2573
2574         Force SSE2 on x86/32bit builds.
2575
2576         * Scripts/webkitdirs.pm:
2577         (generateBuildSystemFromCMakeProject):
2578
2579 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2580
2581         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2582         https://bugs.webkit.org/show_bug.cgi?id=196073
2583
2584         Reviewed by Michael Catanzaro.
2585
2586         Add test cases to check functions and constructors with no arguments but receiving user data.
2587
2588         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2589         (checkUserData):
2590         (testJSCFunction):
2591         (fooCreateWithUserData):
2592         (testJSCClass):
2593
2594 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2595
2596         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2597
2598         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2599
2600         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2601
2602 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2603
2604         [GTK][WPE] Add API to provide geolocation information
2605         https://bugs.webkit.org/show_bug.cgi?id=195940
2606
2607         Reviewed by Michael Catanzaro.
2608
2609         Add a new test to check the new API.
2610
2611         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2612         (testGeolocationManagerCurrentPosition):
2613         (testGeolocationManagerWatchPosition):
2614         (beforeAll):
2615         (afterAll):
2616         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2617         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2618         (beforeAll): Ditto.
2619         * TestWebKitAPI/glib/CMakeLists.txt:
2620
2621 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2622
2623         [GLib] Returning G_TYPE_OBJECT from a method does not work
2624         https://bugs.webkit.org/show_bug.cgi?id=195574
2625
2626         Reviewed by Michael Catanzaro.
2627
2628         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2629
2630         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2631         (getGFile):
2632         (getParent):
2633         (createGString):
2634         (getGString):
2635         (getGStringCopyWillRaise):
2636         (getGStringCopy):
2637         (getGStringStr):
2638         (getGStringLen):
2639         (freeGString):
2640         (testJSCClass):
2641
2642 2019-03-20  Saam Barati  <sbarati@apple.com>
2643
2644         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2645         https://bugs.webkit.org/show_bug.cgi?id=195721
2646
2647         Reviewed by Filip Pizlo.
2648
2649         * Scripts/run-javascriptcore-tests:
2650
2651 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2652
2653         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2654         https://bugs.webkit.org/show_bug.cgi?id=196049
2655
2656         Reviewed by Tim Horton.
2657
2658         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2659         overflow scrolling in general, so rename it.
2660
2661         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2662
2663 2019-03-20  Daniel Bates  <dabates@apple.com>
2664
2665         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2666         https://bugs.webkit.org/show_bug.cgi?id=196031
2667         <rdar://problem/49078172>
2668
2669         Reviewed by Tim Horton.
2670
2671         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2672         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2673         same code path used when the Done button is pressed to dismiss the <select> picker.
2674
2675         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2676         (TestWebKitAPI::TEST):
2677
2678 2019-03-20  Chris Dumez  <cdumez@apple.com>
2679
2680         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2681         https://bugs.webkit.org/show_bug.cgi?id=196029
2682         <rdar://problem/48954651>
2683
2684         Reviewed by Tim Horton.
2685
2686         Add API test coverage.
2687
2688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2689
2690 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2691
2692         [ews-build] Improve failure summary string for ApplyPatch step
2693         https://bugs.webkit.org/show_bug.cgi?id=195995
2694
2695         Reviewed by Alexey Proskuryakov.
2696
2697         * BuildSlaveSupport/ews-build/steps.py:
2698         (ApplyPatch.getResultSummary): Override getResultSummary.
2699
2700 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2701
2702         AX: Implement support for new meter ARIA role
2703         https://bugs.webkit.org/show_bug.cgi?id=195966
2704
2705         Reviewed by Chris Fleizach.
2706
2707         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2708         to AXLevelIndicator.
2709
2710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2711
2712 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2713
2714         [WebAuthN] Implement FIDO AppID extension
2715         https://bugs.webkit.org/show_bug.cgi?id=143491
2716         <rdar://problem/48298273>
2717
2718         Reviewed by Brent Fulgham.
2719
2720         Add a test that covers the new flag of convertToU2fSignCommand.
2721
2722         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2723         (TestWebKitAPI::TEST):
2724         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2725         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2726         (TestWebKitAPI::TEST):
2727
2728 2019-03-19  Keith Rollin  <krollin@apple.com>
2729
2730         Add support for more platforms to generate-xcfilelists
2731         https://bugs.webkit.org/show_bug.cgi?id=195977
2732
2733         Reviewed by Alexey Proskuryakov.
2734
2735         generate-xcfilelists incorrectly complains when involved with building
2736         WebKit for iphonesimulator:
2737
2738             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2739             …
2740             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2741
2742         Address this by teaching generate-xcfilelists about more platforms.
2743
2744         * Scripts/generate-xcfilelists:
2745
2746 2019-03-19  John Wilander  <wilander@apple.com>
2747
2748         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2749         https://bugs.webkit.org/show_bug.cgi?id=195923
2750         <rdar://problem/49001272>
2751
2752         Reviewed by Alex Christensen.
2753
2754         This patch does the following to the TestRunner:
2755         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2756         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2757         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2758
2759         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2761         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2763         * WebKitTestRunner/TestController.cpp:
2764         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2765         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2766         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2767         * WebKitTestRunner/TestController.h:
2768         * WebKitTestRunner/TestInvocation.cpp:
2769         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2770
2771 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2772
2773         [CMake] Support more clang and gcc sanitizers
2774         https://bugs.webkit.org/show_bug.cgi?id=195956
2775
2776         Reviewed by Michael Catanzaro.
2777
2778         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2779
2780 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2781
2782         [ews-build] Improve summary for PrintConfiguration step
2783         https://bugs.webkit.org/show_bug.cgi?id=195945
2784
2785         Reviewed by Lucas Forschler.
2786
2787         * BuildSlaveSupport/ews-build/steps.py:
2788         (PrintConfiguration.getResultSummary): Override getResultSummary.
2789
2790 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2791
2792         [ews-build] Improve summary for CheckOutSource step
2793         https://bugs.webkit.org/show_bug.cgi?id=195963
2794
2795         Reviewed by Lucas Forschler.
2796
2797         * BuildSlaveSupport/ews-build/steps.py:
2798         (CheckOutSource.getResultSummary):
2799
2800 2019-03-19  Daniel Bates  <dabates@apple.com>
2801
2802         [iOS] Focus not preserved when switching between tabs
2803         https://bugs.webkit.org/show_bug.cgi?id=195820
2804         <rdar://problem/43614450>
2805
2806         Reviewed by Brent Fulgham.
2807
2808         Add tests to ensure that we restore focus when resigning and becoming first responder.
2809
2810         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2811         (TestWebKitAPI::TEST):
2812
2813 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2814
2815         Make WTFLogChannelState and WTFLogLevel enum classes
2816         https://bugs.webkit.org/show_bug.cgi?id=195904
2817
2818         Reviewed by Eric Carlson.
2819
2820         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2821         (TestWebKitAPI::TEST_F):
2822
2823 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2824
2825         [GStreamer][EME] Backported mssdemux protection data crash fix
2826         https://bugs.webkit.org/show_bug.cgi?id=195918
2827
2828         Reviewed by Philippe Normand.
2829
2830         * gstreamer/jhbuild.modules:
2831         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2832
2833 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2834
2835         Unreviewed, rolling out r243132.
2836
2837         Broke GTK build
2838
2839         Reverted changeset:
2840
2841         "Make WTFLogChannelState and WTFLogLevel enum classes"
2842         https://bugs.webkit.org/show_bug.cgi?id=195904
2843         https://trac.webkit.org/changeset/243132
2844
2845 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2846
2847         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2848
2849         * Scripts/webkitdirs.pm:
2850         (builtDylibPathForName): Adjust the shared library name that's changed
2851         with the API version bump in r243073.
2852
2853 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2854
2855         Make WTFLogChannelState and WTFLogLevel enum classes
2856         https://bugs.webkit.org/show_bug.cgi?id=195904
2857
2858         Reviewed by Eric Carlson.
2859
2860         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2861         (TestWebKitAPI::TEST_F):
2862
2863 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2864
2865         Disable flaky test added in r2431100
2866         https://webkit.org/b/195785
2867
2868         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2869         (TestWebKitAPI::TEST):
2870         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2871
2872 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2873
2874         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2875         https://bugs.webkit.org/show_bug.cgi?id=195916
2876
2877         Reviewed by Tim Horton.
2878
2879         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2880         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2881
2882 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2883
2884         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2885
2886         * Scripts/webkitpy/common/config/contributors.json:
2887
2888 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2889
2890         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2891         https://bugs.webkit.org/show_bug.cgi?id=195785
2892
2893         Reviewed by Geoffrey Garen.
2894
2895         * TestWebKitAPI/TCPServer.cpp: Added.
2896         (TestWebKitAPI::TCPServer::TCPServer):
2897         (TestWebKitAPI::TCPServer::~TCPServer):
2898         (TestWebKitAPI::TCPServer::socketBindListen):
2899         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2900         * TestWebKitAPI/TCPServer.h: Added.
2901         (TestWebKitAPI::TCPServer::port const):
2902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2903         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2904         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2905         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2906         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2907         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2908         (TestWebKitAPI::respondSlowly):
2909         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2910         (TestWebKitAPI::downloadAtRate):
2911         (TestWebKitAPI::TEST):
2912
2913 2019-03-18  Saam Barati  <sbarati@apple.com>
2914
2915         Add a plan file for JetStream 2
2916         https://bugs.webkit.org/show_bug.cgi?id=190734
2917
2918         Reviewed by Mark Lam.
2919
2920         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2921
2922 2019-03-18  Chris Dumez  <cdumez@apple.com>
2923
2924         Delay WebProcess launch until a load is triggered in a Web view
2925         https://bugs.webkit.org/show_bug.cgi?id=195758
2926         <rdar://problem/48126013>
2927
2928         Reviewed by Geoff Garen.
2929
2930         Add API test coverage. Also update some existing API tests to not expect
2931         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2932
2933         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2934         (TestWebKitAPI::TEST):
2935         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2936         (TestWebKitAPI::TEST):
2937         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2938         (TEST):
2939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2940         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2941         (TEST):
2942         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2943         (TEST):
2944         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2945
2946 2019-03-18  Xan Lopez  <xan@igalia.com>
2947
2948         [CMake] Prevent potential warning when determining $architecture
2949         https://bugs.webkit.org/show_bug.cgi?id=195891
2950
2951         Reviewed by Michael Catanzaro.
2952
2953         It's possible for generateBuildSystemForCMakeProject to be called
2954         before determineArchitecture() is ever called. This will make the
2955         first eq check with $architecture to be bogus (and print a
2956         warning). Change that to an eq check with architecture(), which
2957         implicitly calls determineArchitecture() if needed, and change all
2958         the other similar cases in the method in the same way to prevent
2959         future bugs like this one.
2960
2961         * Scripts/webkitdirs.pm:
2962         (generateBuildSystemFromCMakeProject):
2963
2964 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2965
2966         [WPE] Tarballs generated with “make dist” cannot build documentation
2967         https://bugs.webkit.org/show_bug.cgi?id=195885
2968
2969         Reviewed by Carlos Garcia Campos.
2970
2971         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2972
2973 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2974
2975         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2976         https://bugs.webkit.org/show_bug.cgi?id=195883
2977
2978         Reviewed by Carlos Garcia Campos.
2979
2980         * gtkdoc/gtkdoc.py:
2981         (GTKDoc._run_command): When commands fail to run, include the full command line for
2982         the program invocation and the output it has generated on the standard error stream.
2983
2984 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2985
2986         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2987         https://bugs.webkit.org/show_bug.cgi?id=195786
2988
2989         Reviewed by Philippe Normand.
2990
2991         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2992         * wpe/jhbuild.modules: Ditto.
2993
2994 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2995
2996         [ews-build] Don't run clean builds on EWS builders
2997         https://bugs.webkit.org/show_bug.cgi?id=195851
2998
2999         Reviewed by Geoffrey Garen.
3000
3001         * BuildSlaveSupport/ews-build/factories.py:
3002
3003 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3004
3005         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3006         https://bugs.webkit.org/show_bug.cgi?id=195849
3007
3008         Reviewed by Chris Dumez.
3009
3010         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3013         (runWebsiteDataStoreCustomPaths):
3014
3015 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3016
3017         webkitpy: Upload test results
3018         https://bugs.webkit.org/show_bug.cgi?id=195755
3019         <rdar://problem/48896182>
3020
3021         Reviewed by Aakash Jain.
3022
3023         Establish a new format for uploading results that is not tied to layout tests, apply
3024         that format to webkitpy tests.
3025
3026         * Scripts/webkitpy/common/checkout/scm/git.py:
3027         (Git.native_branch): Return what branch the current checkout is on.
3028         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3029         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3030         * Scripts/webkitpy/common/checkout/scm/svn.py:
3031         (SVN.native_branch): Ditto.
3032         * Scripts/webkitpy/common/system/platforminfo.py:
3033         (PlatformInfo.build_version): Return a build version for Mac.
3034         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3035         (MockPlatformInfo.__init__):
3036         (MockPlatformInfo.build_version):
3037         * Scripts/webkitpy/results: Added.
3038         * Scripts/webkitpy/results/__init__.py: Added.
3039         * Scripts/webkitpy/results/options.py: Added.
3040         (upload_options): OptParse list for upload options.
3041         * Scripts/webkitpy/results/upload.py: Added.
3042         (Upload): Class which enforces the upload format expected by the results server.
3043         (Upload.Expectations):
3044         (Upload.create_configuration):
3045         (Upload.create_commit):
3046         (Upload.create_details):
3047         (Upload.create_run_stats):
3048         (Upload.create_test_result):
3049         (Upload.__init__):
3050         (Upload.Encoder): Encode Upload object as json.
3051         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3052         * Scripts/webkitpy/results/upload_unittest.py: Added.
3053         * Scripts/webkitpy/test/main.py:
3054         (Tester._parse_args): Add upload arguments.
3055         (Tester._run_tests): Allow results to be uploaded.
3056         * Scripts/webkitpy/test/runner.py:
3057         (Runner.__init__): Record which tests were run, rather than just counting them.
3058         (Runner.handle):
3059         * Scripts/webkitpy/test/runner_unittest.py:
3060         (RunnerTest.test_run):
3061         * Scripts/webkitpy/thirdparty/__init__.py:
3062         (AutoinstallImportHook.find_module): Add requests auto-install.
3063         (AutoinstallImportHook._install_requests):
3064         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3065         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3066
3067 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3068
3069         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3070         https://bugs.webkit.org/show_bug.cgi?id=195810
3071
3072         Reviewed by Tim Horton.
3073
3074         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3075         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3076         ending certain layout tests.
3077
3078         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3079         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3080         (-[TestRunnerWKWebView dealloc]):
3081         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3082
3083         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3084         helper method when destroying the web view, and when resetting state between tests.
3085
3086         * WebKitTestRunner/ios/TestControllerIOS.mm:
3087         (WTR::TestController::platformResetStateToConsistentValues):
3088
3089         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3090
3091 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3092
3093         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3094         https://bugs.webkit.org/show_bug.cgi?id=190350
3095         <rdar://problem/45089503>
3096
3097         Reviewed by Geoffrey Garen.
3098
3099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3100         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3101         (TEST):
3102         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3103         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3104         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3105         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3106         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3107         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3108         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3109         (runTest):
3110         (createDirectories):
3111         (TEST):
3112         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3113         (TEST):
3114         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3115         (TEST):
3116
3117 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3118
3119         Add support to WebPage for getting the contents as an attributed string.
3120         https://bugs.webkit.org/show_bug.cgi?id=195636
3121         rdar://problem/45055697
3122
3123         Reviewed by Tim Horton.
3124
3125         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3126         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3127
3128 2019-03-15  Chris Dumez  <cdumez@apple.com>
3129
3130         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3131         https://bugs.webkit.org/show_bug.cgi?id=195747
3132
3133         Reviewed by Geoff Garen.
3134
3135         Add API test coverage.
3136
3137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3138
3139 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3140
3141         Unreviewed, rolling out r242952.
3142
3143         Causing API failures on iOS Simulator
3144
3145         Reverted changeset:
3146
3147         "[PSON] Make sure the WebProcessCache is leverage when
3148         relaunching a process after termination"
3149         https://bugs.webkit.org/show_bug.cgi?id=195747
3150         https://trac.webkit.org/changeset/242952
3151
3152 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3153
3154         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3155         https://bugs.webkit.org/show_bug.cgi?id=195740
3156
3157         Reviewed by Ross Kirsling.
3158
3159         window.open doesn't work for WebKitBrowserWindow because it is not
3160         implemented yet.
3161
3162         1. Implemented createNewPage callback of WKPageUIClient.
3163         2. Changed MainWindow to take a BrowserWindow factory function
3164           instead of BrowserWindowType to be flexible to create
3165           BrowserWindow with extra settings.
3166         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3167           because it is not relevant with MainWindow anymore.
3168
3169         * MiniBrowser/win/Common.cpp:
3170         (parseCommandLine):
3171         * MiniBrowser/win/Common.h:
3172         (CommandLineOptions::CommandLineOptions):
3173         * MiniBrowser/win/MainWindow.cpp:
3174         (MainWindow::MainWindow):
3175         (MainWindow::create):
3176         (MainWindow::init):
3177         (MainWindow::WndProc):
3178         * MiniBrowser/win/MainWindow.h:
3179         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3180         (PrintWebUIDelegate::createWebViewWithRequest):
3181         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3182         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3183         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3184         (WebKitBrowserWindow::updateProxySettings):
3185         (WebKitBrowserWindow::createNewPage):
3186         * MiniBrowser/win/WebKitBrowserWindow.h:
3187         * MiniBrowser/win/WinMain.cpp:
3188         (wWinMain):
3189
3190 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3191
3192         Make it possible to test scrolling tree layer manipulation more easily
3193         https://bugs.webkit.org/show_bug.cgi?id=195780
3194
3195         Reviewed by Tim Horton.
3196         
3197         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3198         cuts off communication of scrolling tree scrolls back to the web process
3199         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3200         allows tests to trigger scrolls which run the scrolling tree layer positioning
3201         logic, but never get another commit from the web process that might mask
3202         scrolling tree bugs.
3203         
3204         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3205         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3206         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3207
3208         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3209         (WTR::UIScriptController::scrollUpdatesDisabled const):
3210         (WTR::UIScriptController::setScrollUpdatesDisabled):
3211         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3212         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3213         (WTR::UIScriptController::scrollUpdatesDisabled const):
3214         (WTR::UIScriptController::setScrollUpdatesDisabled):
3215         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3216         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3217         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3218         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3219         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3220         * WebKitTestRunner/ios/TestControllerIOS.mm:
3221         (WTR::TestController::platformResetStateToConsistentValues):
3222         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3223         (WTR::UIScriptController::scrollUpdatesDisabled const):
3224         (WTR::UIScriptController::setScrollUpdatesDisabled):
3225
3226 2019-03-14  Youenn Fablet  <youenn@apple.com>
3227
3228         Move IDB storage in private browsing mode to NetworkProcess
3229         https://bugs.webkit.org/show_bug.cgi?id=195602
3230
3231         Reviewed by Brady Eidson.
3232
3233         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3234         (TEST):
3235
3236 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3237
3238         [ews-build] Make descriptionDone messages more readable
3239         https://bugs.webkit.org/show_bug.cgi?id=195760
3240
3241         Reviewed by Lucas Forschler.
3242
3243         * BuildSlaveSupport/ews-build/steps.py:
3244         * BuildSlaveSupport/ews-build/steps_unittest.py:
3245
3246 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3247
3248         [ews-build] Generate status-bubble hover-over messages
3249         https://bugs.webkit.org/show_bug.cgi?id=195680
3250
3251         Reviewed by Lucas Forschler.
3252
3253         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3254         (StatusBubble):
3255         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3256         on hover-over.
3257         (StatusBubble._iso_time):
3258         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3259         hover-over message.
3260         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3261
3262 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3263
3264         [ews-app] Gracefully handle the case when state_string is None
3265         https://bugs.webkit.org/show_bug.cgi?id=195753
3266
3267         Reviewed by Lucas Forschler.
3268
3269         * BuildSlaveSupport/ews-app/ews/models/build.py:
3270         * BuildSlaveSupport/ews-app/ews/models/step.py:
3271
3272 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3273
3274         [ews-app] Status bubble display pending for currently running build step
3275         https://bugs.webkit.org/show_bug.cgi?id=195744
3276
3277         Reviewed by Lucas Forschler.
3278
3279         * BuildSlaveSupport/ews-build/events.py:
3280         (Events.stepStarted): If state_string is pending, replace it with step name.
3281
3282 2019-03-14  Chris Dumez  <cdumez@apple.com>
3283
3284         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3285         https://bugs.webkit.org/show_bug.cgi?id=195750
3286
3287         Reviewed by Geoffrey Garen.
3288
3289         Add API test coverage.
3290
3291         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3292         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3293         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3294         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3295
3296 2019-03-14  Chris Dumez  <cdumez@apple.com>
3297
3298         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3299         https://bugs.webkit.org/show_bug.cgi?id=195747
3300
3301         Reviewed by Geoff Garen.
3302
3303         Add API test coverage.
3304
3305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3306
3307 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3308
3309         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3310         https://bugs.webkit.org/show_bug.cgi?id=195725
3311         <rdar://problem/48545062>
3312
3313         Reviewed by Tim Horton.
3314
3315         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3316         handler is nil.
3317
3318         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3319         (TestWebKitAPI::TEST):
3320
3321 2019-03-13  Sam Weinig  <sam@webkit.org>
3322
3323         Add utility function to allow easy reverse range-based iteration of a container
3324         https://bugs.webkit.org/show_bug.cgi?id=195542
3325
3326         Reviewed by Antti Koivisto.
3327
3328         * TestWebKitAPI/CMakeLists.txt:
3329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3330         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3331         (TestWebKitAPI::TEST):
3332         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3333
3334 2019-03-13  Chris Dumez  <cdumez@apple.com>
3335
3336         Use a ServiceWorker process per registrable domain
3337         https://bugs.webkit.org/show_bug.cgi?id=195649
3338
3339         Reviewed by Youenn Fablet.
3340
3341         Update API test coverage.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3344
3345 2019-03-13  Chris Dumez  <cdumez@apple.com>
3346
3347         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3348         https://bugs.webkit.org/show_bug.cgi?id=195684
3349         <rdar://problem/48294714>
3350
3351         Reviewed by Antti Koivisto.
3352
3353         Add API test coverage.
3354
3355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3356
3357 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3358
3359         [ews-app] Remove unused patch view
3360         https://bugs.webkit.org/show_bug.cgi?id=195669
3361
3362         Reviewed by Lucas Forschler.
3363
3364         * BuildSlaveSupport/ews-app/ews/urls.py:
3365         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3366
3367 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3368
3369         [ews-app] Use Buildbot result code variables
3370         https://bugs.webkit.org/show_bug.cgi?id=195668
3371
3372         Reviewed by Alexey Proskuryakov.
3373
3374         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3375         (Buildbot): Added Buildbot result code variables.
3376         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3377         (StatusBubble._build_bubble): Used Buildbot result code variables.
3378
3379 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3380
3381         [Flatpak] Expand submodule recursively
3382         https://bugs.webkit.org/show_bug.cgi?id=195672
3383
3384         Building WPE with flatpak was impossible without that as it was raising an exception.
3385         Also update wpebackend-fdo to match what is built in jhbuild
3386
3387         Reviewed by Philippe Normand.
3388
3389         * flatpak/flatpakutils.py:
3390         (expand_submodules_recurse):
3391         (expand_manifest):
3392         * flatpak/org.webkit.WPEModules.yaml:
3393
3394 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3395
3396         [ews-app] status bubble should be hidden for certain builds
3397         https://bugs.webkit.org/show_bug.cgi?id=194597
3398
3399         Reviewed by Dewei Zhu.
3400
3401         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3402         (StatusBubble._build_bubble):
3403         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3404         because the patch didn't have relevant changes.
3405         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3406         in production yet.
3407
3408 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3409
3410         [Win] Fix a slew of simple clang-cl warnings.
3411         https://bugs.webkit.org/show_bug.cgi?id=195652
3412
3413         Reviewed by Don Olmstead.
3414
3415         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3416         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3417
3418 2019-03-12  Justin Fan  <justin_fan@apple.com>
3419
3420         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3421         https://bugs.webkit.org/show_bug.cgi?id=195518
3422         <rdar://problem/46322356>
3423
3424         Reviewed by Myles C. Maxfield.
3425
3426         * DumpRenderTree/DerivedSources-input.xcfilelist:
3427         * DumpRenderTree/DerivedSources-output.xcfilelist:
3428
3429 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3430
3431         Unreviewed, rolling out r242825.
3432         https://bugs.webkit.org/show_bug.cgi?id=195648
3433
3434         "Broke webkitpy tests with my change to
3435         lldb_dump_class_layout.py" (Requested by rmorisset on
3436         #webkit).
3437
3438         Reverted changeset:
3439
3440         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3441         classes with suspicious padding"
3442         https://bugs.webkit.org/show_bug.cgi?id=195573
3443         https://trac.webkit.org/changeset/242825
3444
3445 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3446
3447         [ews-build] Show status bubbles while the patch is waiting in queue
3448         https://bugs.webkit.org/show_bug.cgi?id=195618
3449
3450         Reviewed by Lucas Forschler.
3451
3452         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3453         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3454         enabled in initial deployment.
3455         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3456         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3457         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3458         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3459         (StatusBubble._build_bubbles_for_patch):
3460
3461 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3462
3463         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3464         https://bugs.webkit.org/show_bug.cgi?id=195573
3465
3466         Reviewed by Simon Fraser.
3467
3468         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3469
3470         * Scripts/dump-class-layout:
3471         (main):
3472         * lldb/lldb_dump_class_layout.py:
3473         (ClassLayout.__init__):
3474         (ClassLayout._compute_padding_recursive):
3475         (LLDBDebuggerInstance.dump_layout_for_classname):
3476         (LLDBDebuggerInstance):
3477         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3478         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3479
3480 2019-03-12  Chris Dumez  <cdumez@apple.com>
3481
3482         Device Orientation access permission should be denied unless explicitly granted by the client
3483         https://bugs.webkit.org/show_bug.cgi?id=195625
3484
3485         Reviewed by Youenn Fablet.
3486
3487         add API test coverage.
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3490         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3491         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3492         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3493         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3494         (runDeviceOrientationTest):
3495         (TEST):
3496         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3497         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3498
3499 2019-03-12  Jer Noble  <jer.noble@apple.com>
3500
3501         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3502         https://bugs.webkit.org/show_bug.cgi?id=195137
3503         <rdar://problem/48810307>
3504
3505         Reviewed by Eric Carlson.
3506
3507         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3508         (TestWebKitAPI::TEST):
3509
3510 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3511
3512         [ews-build] Change urls from uat to production
3513         https://bugs.webkit.org/show_bug.cgi?id=195566
3514
3515         Reviewed by Lucas Forschler.
3516
3517         * BuildSlaveSupport/ews-app/ews/config.py:
3518         * BuildSlaveSupport/ews-build/events.py:
3519         * BuildSlaveSupport/ews-build/steps.py:
3520
3521 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [ews-build] change max_builds for local-worker to 1
3524         https://bugs.webkit.org/show_bug.cgi?id=195568
3525
3526         Reviewed by Lucas Forschler.
3527
3528         * BuildSlaveSupport/ews-build/loadConfig.py:
3529
3530 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3531
3532         Fix the build
3533
3534         * TestRunnerShared/spi/PencilKitTestSPI.h:
3535         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3536
3537 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3538
3539         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3540         https://bugs.webkit.org/show_bug.cgi?id=194131
3541
3542         Reviewed by Michael Catanzaro.
3543
3544         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3545         (uriChanged):
3546         (testUnfinishedSubresourceLoad):
3547         (serverCallback):
3548         (beforeAll):
3549
3550 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3551
3552         WTF::Expected should use std::addressof instead of operator&
3553         https://bugs.webkit.org/show_bug.cgi?id=195604
3554
3555         Reviewed by Myles Maxfield.
3556
3557         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3558         (TestWebKitAPI::Unique::Unique):
3559         (TestWebKitAPI::Unique::operator&):
3560         (TestWebKitAPI::TEST):
3561
3562 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3563
3564         Add Optional to Forward.h.
3565         https://bugs.webkit.org/show_bug.cgi?id=195586
3566
3567         Reviewed by Darin Adler.
3568
3569         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3570         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3571         Remove unnecessary includes from headers.
3572
3573 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3574
3575         Add testing API to hit-test and scroll overflow scrollers
3576         https://bugs.webkit.org/show_bug.cgi?id=195278
3577
3578         Reviewed by Antti Koivisto.
3579         
3580         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3581         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3582         
3583         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3584
3585         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3586         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3587         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3588         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3589         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3590         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3591         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3592         (WTR::enclosingScrollViewIncludingSelf):
3593         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3594
3595 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3596
3597         API test WebKit.RequestTextInputContext fails on iOS
3598         https://bugs.webkit.org/show_bug.cgi?id=195585
3599
3600         Reviewed by Wenson Hsieh and Simon Fraser.
3601
3602         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3603         (applyStyle):
3604         (TEST):
3605         Add a viewport, so that the coordinates match up on iOS.
3606         Scroll by moving the UIScrollView's contentOffset.
3607
3608 2019-03-11  Chris Dumez  <cdumez@apple.com>
3609
3610         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3611         https://bugs.webkit.org/show_bug.cgi?id=195506
3612         <rdar://problem/48733477>
3613
3614         Reviewed by Alex Christensen.
3615
3616         Add API test coverage.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3619
3620 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3621
3622         Adding myself to contributors.json
3623
3624         Unreviewed, addming myself to contributors.json .
3625
3626         * Scripts/webkitpy/common/config/contributors.json:
3627
3628 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3629
3630         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3631         https://bugs.webkit.org/show_bug.cgi?id=195511
3632         <rdar://problem/44873269>
3633
3634         Reviewed by Darin Adler.
3635
3636         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3637         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3638         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3639         (TEST_F):
3640
3641 2019-03-11  Chris Dumez  <cdumez@apple.com>
3642
3643         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3644         https://bugs.webkit.org/show_bug.cgi?id=195561
3645
3646         Reviewed by Youenn Fablet.
3647
3648         Make sure the JS in the test requests for permission to receive device orientation events.
3649
3650         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3651
3652 2019-03-11  Youenn Fablet  <youenn@apple.com>
3653
3654         Allow storage quota increase by default in WTR
3655         https://bugs.webkit.org/show_bug.cgi?id=195541
3656
3657         Reviewed by Geoffrey Garen.
3658
3659         Allow storage quota increase by default in WTR.
3660         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3661         Use this for tests that explicitly need cache increase.
3662
3663         Instead of increasing quota by 2, make sure the next request is
3664         granted by adding all given parameters.
3665
3666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3668         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3669         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3670         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3671         * WebKitTestRunner/TestController.cpp:
3672         (WTR::TestController::setAllowStorageQuotaIncrease):
3673         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3674         * WebKitTestRunner/TestController.h:
3675         * WebKitTestRunner/TestInvocation.cpp:
3676         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3677         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3678         (WTR::TestController::cocoaResetStateToConsistentValues):
3679         (WTR::TestController::setAllowStorageQuotaIncrease):
3680         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3681         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3682         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3683
3684 2019-03-11  Xan Lopez  <xan@igalia.com>
3685
3686         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3687         https://bugs.webkit.org/show_bug.cgi?id=194147
3688
3689         Reviewed by Michael Saboff.
3690
3691         To make --32-bit work correctly on Linux/64bit we need to:
3692
3693         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3694         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3695         unfortunately CMake only allows us to do this during
3696         crosscompilation, which is overkill here.