Unreviewed build fix after http://trac.webkit.org/changeset/195474.
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-22  Enrica Casucci  <enrica@apple.com>
2
3         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
4
5         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
6         (WTR::TestController::platformCreateWebView):
7
8 2016-01-22  Tim Horton  <timothy_horton@apple.com>
9
10         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
11         https://bugs.webkit.org/show_bug.cgi?id=153193
12         <rdar://problem/24222034>
13
14         Reviewed by Darin Adler.
15
16         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
17         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
18         (TEST):
19         Add a test that exhibits the problems we're fixing here.
20         Before, it would both log and assert in debug, and crash in release.
21         Now it runs happily to completion.
22
23 2016-01-22  Enrica Casucci  <enrica@apple.com>
24
25         Add support for testing data detection.
26         https://bugs.webkit.org/show_bug.cgi?id=153360
27
28         Reviewed by Tim Horton.
29
30         Adding a new testing option (useDataDetection) to turn on
31         data detection when running the a test.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::updateTestOptionsFromTestHeader):
35         * WebKitTestRunner/TestOptions.h:
36         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
37         (WTR::TestController::platformCreateWebView):
38
39 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
40
41         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
42         https://bugs.webkit.org/show_bug.cgi?id=153334
43
44         Reviewed by Zalan Bujtas.
45         
46         Evaluating expressions in the LayoutUnit summary provider seems to cause
47         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
48         denominator to 64.
49
50         * lldb/lldb_webkit.py:
51         (WebCoreLayoutUnitProvider.to_string):
52
53 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
54
55         display-profiler-output should be able to display code blocks sorted by machine counts
56         https://bugs.webkit.org/show_bug.cgi?id=153298
57
58         Reviewed by Oliver Hunt.
59
60         * Scripts/display-profiler-output:
61
62 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
63
64         Ensure to use compatible liborc version with wanted gstreamer version
65         https://bugs.webkit.org/show_bug.cgi?id=153276
66
67         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
68         The user may have a very recent liborc installed on his system.
69
70         Reviewed by Philippe Normand.
71
72         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
73         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
74
75 2016-01-21  Nan Wang  <n_wang@apple.com>
76
77         AX: [IOS] Implement next/previous text marker functions using TextIterator
78         https://bugs.webkit.org/show_bug.cgi?id=153292
79         <rdar://problem/24268243>
80
81         Reviewed by Chris Fleizach.
82
83         Made text marker tests available on iOS.
84
85         * DumpRenderTree/AccessibilityTextMarker.h:
86         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
87         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
88         (AccessibilityTextMarker::AccessibilityTextMarker):
89         (AccessibilityTextMarker::~AccessibilityTextMarker):
90         (AccessibilityTextMarker::isEqual):
91         (AccessibilityTextMarker::platformTextMarker):
92         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
93         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
94         (AccessibilityTextMarkerRange::isEqual):
95         (AccessibilityTextMarkerRange::platformTextMarkerRange):
96         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
97         (AccessibilityUIElement::pathDescription):
98         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
99         (AccessibilityUIElement::textMarkerRangeForElement):
100         (AccessibilityUIElement::selectedTextMarkerRange):
101         (AccessibilityUIElement::resetSelectedTextMarkerRange):
102         (AccessibilityUIElement::textMarkerRangeLength):
103         (AccessibilityUIElement::textMarkerRangeForMarkers):
104         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
105         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
106         (AccessibilityUIElement::accessibilityElementForTextMarker):
107         (AccessibilityUIElement::endTextMarkerForBounds):
108         (AccessibilityUIElement::startTextMarkerForBounds):
109         (AccessibilityUIElement::textMarkerForPoint):
110         (AccessibilityUIElement::previousTextMarker):
111         (AccessibilityUIElement::nextTextMarker):
112         (AccessibilityUIElement::stringForTextMarkerRange):
113         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
114         (AccessibilityUIElement::indexForTextMarker):
115         (AccessibilityUIElement::isTextMarkerValid):
116         (AccessibilityUIElement::textMarkerForIndex):
117         (AccessibilityUIElement::startTextMarker):
118         (AccessibilityUIElement::endTextMarker):
119         (AccessibilityUIElement::setSelectedVisibleTextRange):
120         (AccessibilityUIElement::getLinkedUIElements):
121         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
122         (AccessibilityTextMarkerRange::platformTextMarkerRange):
123         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
124         (AccessibilityUIElement::removeSelection):
125         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
126         (AccessibilityUIElement::setSelectedVisibleTextRange):
127         (AccessibilityUIElement::supportedActions):
128         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
129         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
130         (WTR::AccessibilityUIElement::textMarkerRangeLength):
131         (WTR::AccessibilityUIElement::previousTextMarker):
132         (WTR::AccessibilityUIElement::nextTextMarker):
133         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
134         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
135         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
136         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
137         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
138         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
139         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
140
141 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
142
143         Unreviewed, revert accidental unreviewed commit.
144
145         * Scripts/display-profiler-output:
146
147 2016-01-20  Jason Marcell  <jmarcell@apple.com>
148
149         Refactor compareIterations to remove duplicate code.
150         https://bugs.webkit.org/show_bug.cgi?id=152913
151
152         Reviewed by Daniel Bates.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
155         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
156         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
158         the same behavior before and after refactor.
159
160 2016-01-20  Dana Burkart  <dburkart@apple.com>
161
162         Botwatcher's dashboard should show an 'X' when the build is broken
163         https://bugs.webkit.org/show_bug.cgi?id=152507
164
165         Reviewed by David Kilzer.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
168         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
169         (BuildbotStaticAnalyzerQueueView.prototype.update):
170
171 2016-01-19  Jason Marcell  <jmarcell@apple.com>
172
173         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
174         https://bugs.webkit.org/show_bug.cgi?id=153262
175
176         Reviewed by Alexey Proskuryakov.
177
178         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
179         such cases this revisionContentForIteration method does not have any content to return, thus the
180         assertion fails.
181
182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
183         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
184
185 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
186
187         [GTK] Runtime critical warnings when loading a URL after a session restore
188         https://bugs.webkit.org/show_bug.cgi?id=153233
189
190         Reviewed by Michael Catanzaro.
191
192         Add new test case.
193
194         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
195         (viewLoadChanged):
196         (testWebKitWebViewNavigationAfterSessionRestore):
197         (beforeAll):
198
199 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
200
201         [GTK] Remove jhbuild-optional.modules
202         https://bugs.webkit.org/show_bug.cgi?id=152964
203
204         Reviewed by Alex Christensen.
205
206         * gtk/jhbuild-optional.modules: Removed.
207         * gtk/jhbuild.modules:
208
209 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
210
211         [GTK] Add support to load/save session in MiniBrowser
212         https://bugs.webkit.org/show_bug.cgi?id=153201
213
214         Reviewed by Michael Catanzaro.
215
216         It makes it easier to test the new WebView session API.
217
218         * MiniBrowser/gtk/BrowserWindow.c:
219         (browserWindowFinalize): Free the session file path.
220         (browserWindowSaveSession): Save the current WebView session if
221         there's a session file path.
222         (browserWindowDeleteEvent): Call browserWindowSaveSession().
223         (browser_window_load_session): Try to load the session from the
224         given file path, otherwise fall back to homepage and keep the
225         session file to save the session on window close.
226         * MiniBrowser/gtk/BrowserWindow.h:
227         * MiniBrowser/gtk/main.c:
228         (createBrowserWindow): Pass the given session file path when
229         shouldLoadSession is TRUE.
230         (main): Only allow to restore/save session when MiniBrowser is
231         launched without URL arguments.
232
233 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
234
235         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
236
237         Geolocation is no longer allowed for unique origins after r195075.
238
239         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
240         (testWebViewGeolocationPermissionRequests):
241
242 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
243
244         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
245         https://bugs.webkit.org/show_bug.cgi?id=153216
246
247         Reviewed by Michael Catanzaro.
248
249         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
250         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
251
252 2016-01-18  Nan Wang  <n_wang@apple.com>
253
254         AX: [Mac] Implement next/previous text marker functions using TextIterator
255         https://bugs.webkit.org/show_bug.cgi?id=152728
256
257         Reviewed by Chris Fleizach.
258
259         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
260         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
261
262 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
263
264         [cmake] Add testair to the build system
265         https://bugs.webkit.org/show_bug.cgi?id=153126
266
267         Reviewed by Michael Catanzaro.
268
269         * Scripts/build-jsc:
270
271 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
272
273         Remove TextRun::allowsRoundingHacks()
274         https://bugs.webkit.org/show_bug.cgi?id=153185
275
276         Reviewed by Simon Fraser.
277
278         * DumpRenderTree/mac/DumpRenderTree.mm:
279         (resetWebViewToConsistentStateBeforeTesting): Deleted.
280
281 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
282
283         [webkitdirs] Avoid list form of open because it broke WinCairo
284         https://bugs.webkit.org/show_bug.cgi?id=153106
285
286         Reviewed by Alex Christensen.
287
288         * Scripts/webkitdirs.pm:
289         (determineArchitecture):
290
291 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
292
293         Add kdebug_trace signposts for a few WebCore operations
294         https://bugs.webkit.org/show_bug.cgi?id=153136
295         rdar://problem/24208487
296
297         Reviewed by Sam Weinig.
298         
299         Plist used by kdebug_trace() viewing tools.
300
301         * Tracing/SystemTracePoints.plist: Added.
302
303 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
304
305         [webkitdirs] Replaced grep invocation with perl code
306         https://bugs.webkit.org/show_bug.cgi?id=153106
307
308         Reviewed by Alex Christensen.
309
310         * Scripts/webkitdirs.pm:
311         (determineArchitecture):
312
313 2016-01-14  Brian Burg  <bburg@apple.com>
314
315         prepare-changelog does not read paths containing spaces properly
316         https://bugs.webkit.org/show_bug.cgi?id=137982
317
318         Reviewed by Joseph Pecoraro.
319
320         Escape whitespace in filenames before passing the file path to other functions.
321
322         * Scripts/prepare-ChangeLog:
323         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
324
325 2016-01-14  Jason Marcell  <jmarcell@apple.com>
326
327         Standardize the usage of "branch" vs. "branchName".
328         https://bugs.webkit.org/show_bug.cgi?id=152982
329
330         Reviewed by Daniel Bates.
331
332         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
333         "branchName" implies that the variable or property in question is simply a string.
334
335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
336         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
337         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
338         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
340         (Trac.prototype.commitsOnBranch): Change branch to branchName.
341         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
343         (MockTrac): Ditto.
344
345 2016-01-14  Jason Marcell  <jmarcell@apple.com>
346
347         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
348         https://bugs.webkit.org/show_bug.cgi?id=152910
349
350         Reviewed by Daniel Bates.
351
352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
353         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
355         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
356         the need to talk to a real Buildbot server.
357         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
358         without the need to talk to a real Buildbot server.
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
360         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
361         server.
362         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
363         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
364         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
365         trying to talk to Trac.
366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
367         QUnit unit tests.
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
369
370 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
371
372         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
373         https://bugs.webkit.org/show_bug.cgi?id=132599
374
375         Reviewed by Michael Catanzaro.
376
377         Check if cmake Ninja generators are installed.
378
379         * Scripts/webkitdirs.pm:
380         (canUseNinjaGenerator):
381         (canUseEclipseNinjaGenerator):
382         (generateBuildSystemFromCMakeProject):
383         (canUseEclipse): Deleted.
384
385 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
386
387         [Cocoa] Testing with font family name "System Font" is unused
388         https://bugs.webkit.org/show_bug.cgi?id=153073
389         <rdar://problem/24091683>
390
391         Reviewed by Brent Fulgham.
392
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (allowedFontFamilySet): Deleted.
395         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
396         (WTR::allowedFontFamilySet): Deleted.
397         * WebKitTestRunner/mac/TestControllerMac.mm:
398         (WTR::allowedFontFamilySet): Deleted.
399
400 2016-01-13  Daniel Bates  <dabates@apple.com>
401
402         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
403         https://bugs.webkit.org/show_bug.cgi?id=152871
404
405         Reviewed by Brent Fulgham.
406
407         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
408         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
409
410         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
411
412 2016-01-08  Andy Estes  <aestes@apple.com>
413
414         [Content Filtering] Lazily load platform frameworks
415         https://bugs.webkit.org/show_bug.cgi?id=152881
416         rdar://problem/23270886
417
418         Reviewed by Brady Eidson.
419
420         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
421         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
422         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
423         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
424         is loaded after an HTTPS request.
425
426         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
427         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
428         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
429         also re-enabled on iOS after mistakenly being disabled by r188892.
430
431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
432         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
435         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
436         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
437         (TEST):
438         (downloadTest):
439         (-[LazilyLoadPlatformFrameworksController init]):
440         (-[LazilyLoadPlatformFrameworksController webView]):
441         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
442         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
443         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
444         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
445         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
446         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
447         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
450         (TestWebKitAPI::TEST): Deleted.
451         * TestWebKitAPI/cocoa/TestProtocol.h:
452         * TestWebKitAPI/cocoa/TestProtocol.mm:
453         (+[TestProtocol registerWithScheme:]):
454         (+[TestProtocol unregister]):
455
456 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
457
458         Fix the Sunpider converage in slow device.
459         https://bugs.webkit.org/show_bug.cgi?id=152938
460         <rdar://problem/22511411>
461
462         Reviewed by Ryosuke Niwa.
463
464         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
465
466         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
467
468 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
469
470         Add a build flag for custom element
471         https://bugs.webkit.org/show_bug.cgi?id=153005
472
473         Reviewed by Alex Christensen.
474
475         Added --custom-elements option to enable custom elements support.
476
477         * Scripts/webkitperl/FeatureList.pm:
478
479 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
480
481         [JSC] Add a help message when run-jsc-stress-tests fails
482         https://bugs.webkit.org/show_bug.cgi?id=153014
483
484         Reviewed by Csaba Osztrogonác.
485
486         * Scripts/run-jsc-stress-tests:
487
488 2016-01-11  Saam barati  <sbarati@apple.com>
489
490         run-jsc-stress-tests should try to figure out a JSC path
491         https://bugs.webkit.org/show_bug.cgi?id=152971
492
493         Reviewed by Yusuke Suzuki.
494
495         This patch now allows run-jsc-stress-tests to be run
496         without a "--jsc <jsc-path>" argument. It tries
497         to take its best guess at a <jsc-path> automagically.
498         
499         This makes it much easier to just run run-jsc-stress-tests
500         with a directory or a yaml file as an argument.
501         You now just do this:
502         `run-jsc-stress-tests <path-to-yaml>`
503         or
504         `run-jsc-stress-tests <path-to-directory-of-js-files>`
505         
506         I wrote this patch because I'd often find myself hacking the 
507         run-javascriptcore-tests file just to run a particular subset of tests.
508         Because I always forget the arguments to run-jsc-stress-tests (which means
509         I always forgot to provide a --jsc argument), I always found it easier to 
510         just hack on that file instead of calling run-jsc-stress-tests directly.
511         No longer is this true!
512
513         * Scripts/run-jsc-stress-tests:
514
515 2016-01-09  Andy Estes  <aestes@apple.com>
516
517         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
518         https://bugs.webkit.org/show_bug.cgi?id=152950
519         rdar://problem/24066652
520
521         Reviewed by Tim Horton.
522
523         Added an API test.
524
525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
526         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
527         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
528         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
529         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
530         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
531         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
532         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
533         (TEST):
534
535 2016-01-11  Commit Queue  <commit-queue@webkit.org>
536
537         Unreviewed, rolling out r194866.
538         https://bugs.webkit.org/show_bug.cgi?id=152986
539
540         This change broke the mac build (Requested by ryanhaddad on
541         #webkit).
542
543         Reverted changeset:
544
545         "[Cocoa] Add SPI to opt out a URL scheme from the memory
546         cache"
547         https://bugs.webkit.org/show_bug.cgi?id=152950
548         http://trac.webkit.org/changeset/194866
549
550 2016-01-11  Andy Estes  <aestes@apple.com>
551
552         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
553         https://bugs.webkit.org/show_bug.cgi?id=152950
554         rdar://problem/24066652
555
556         Reviewed by Tim Horton.
557
558         Added an API test.
559
560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
561         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
562         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
563         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
564         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
565         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
566         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
567         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
568         (TEST):
569
570 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
571
572         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
573         https://bugs.webkit.org/show_bug.cgi?id=152959
574
575         Reviewed by Brent Fulgham.
576
577         * Scripts/webkitdirs.pm:
578         (determineArchitecture):
579
580 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
581
582         [GTK] W3C CSS2.1 anonymous table tests are failing
583         https://bugs.webkit.org/show_bug.cgi?id=152455
584
585         Reviewed by Mario Sanchez Prada.
586
587         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
588         tests. Add upstream patches to fix detection of XHTML files.
589
590         * gtk/jhbuild.modules:
591         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
592         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
593
594 2016-01-10  Saam barati  <sbarati@apple.com>
595
596         Implement a sampling profiler
597         https://bugs.webkit.org/show_bug.cgi?id=151713
598
599         Reviewed by Filip Pizlo.
600
601         * Scripts/run-jsc-stress-tests:
602
603 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
604
605         [webkitdirs] Try arch and uname commands on non-windows OS
606         https://bugs.webkit.org/show_bug.cgi?id=152958
607
608         Reviewed by Michael Catanzaro.
609
610         Right now, determineArchitecture()  uses `arch` and `uname -m`
611         commands to determine architecture in case of condition (isGtk() ||
612         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
613         instead, because this code is applicable to any non-windows OS WebKit
614         supports (even Haiku which once was supported is moderately
615         POSIX-compliant and has uname command).
616
617         * Scripts/webkitdirs.pm:
618         (determineArchitecture):
619
620 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
621
622         run-webkit-tests mis-counts totals when there are other crashes
623         https://bugs.webkit.org/show_bug.cgi?id=152894
624         <rdar://problem/24098697>
625
626         Reviewed by Alexey Proskuryakov.
627
628         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
629         (TestRunResults.add): Do not update result counters for other crashes.
630
631 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
632
633         webkit-patch build-and-test should have an option to iterate over new tests
634         https://bugs.webkit.org/show_bug.cgi?id=143093
635
636         Reviewed by Michael Catanzaro.
637
638         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
639         It allows running run-webkit-tests on modified or new paths in LayoutTests.
640         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
641         It implements the translation of -expected.* paths to their related tests.
642         It also implements the removal of skipped tests.
643
644         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
645         (LayoutTestFinder.find_touched_tests):
646         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
647         (MockPort):
648         (MockPort.__init__):
649         (MockPort.tests):
650         (LayoutTestFinderTests):
651         (LayoutTestFinderTests.touched_files):
652         (LayoutTestFinderTests.test_touched_test):
653         (LayoutTestFinderTests.test_expected_touched_test):
654         (LayoutTestFinderTests.test_platform_expected_touched_test):
655         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
656         (LayoutTestFinderTests.test_touched_but_skipped_test):
657         * Scripts/webkitpy/port/base.py:
658         (Port.potential_test_names_from_expected_file):
659         * Scripts/webkitpy/tool/commands/download_unittest.py:
660         (DownloadCommandsTest._default_options):
661         * Scripts/webkitpy/tool/steps/options.py:
662         (Options):
663         * Scripts/webkitpy/tool/steps/runtests.py:
664         (RunTests.options):
665         (RunTests.run):
666         (RunTests):
667         (RunTests._new_or_modified_tests):
668         (RunTests._run_webkit_tests):
669         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
670         (RunTestsTest.test_webkit_run_unit_tests):
671         * Scripts/webkitpy/tool/steps/steps_unittest.py:
672         (StepsTest._step_options):
673
674 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
675
676         prepare-ChangeLog should include radar number
677         https://bugs.webkit.org/show_bug.cgi?id=152839
678         <rdar://problem/24093563>
679
680         Reviewed by Daniel Bates.
681
682         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
683         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
684         in the ChangeLog description after the bug URL.
685
686         * Scripts/prepare-ChangeLog:
687         (main): Update signatures.
688         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
689         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
690         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
691         (generateNewChangeLogs): Include radar URL if we found one.
692
693         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
694         Tests for the radar URL extraction.
695
696 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
697
698         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
699         https://bugs.webkit.org/show_bug.cgi?id=152390
700         <rdar://problem/23948321>
701
702         Reviewed by Simon Fraser.
703
704         Fix two use-after-frees.
705
706         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
707         but we may have already progressed to another test by the time the callback fires,
708         having destroyed the TestInvocation.
709         2. UIScriptController is a RefCounted object, but it has a raw pointer to
710         UIScriptContext which has the same lifetime as a TestInvocation.
711         As a result, completion blocks of UIScriptController actions would use a destroyed
712         TestInvocation.
713
714         * WebKitTestRunner/TestInvocation.cpp:
715         (WTR::TestInvocation::~TestInvocation):
716         (WTR::TestInvocation::url):
717         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
718         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
719         (WTR::TestInvocation::runUISideScript):
720         * WebKitTestRunner/TestInvocation.h:
721         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
722         (UIScriptContext::UIScriptContext):
723         (UIScriptContext::~UIScriptContext):
724         (UIScriptContext::runUIScript):
725         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
726         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
727         (WTR::UIScriptController::UIScriptController):
728         (WTR::UIScriptController::contextDestroyed):
729         (WTR::UIScriptController::makeWindowObject):
730         (WTR::UIScriptController::setWillBeginZoomingCallback):
731         (WTR::UIScriptController::willBeginZoomingCallback):
732         (WTR::UIScriptController::setDidEndZoomingCallback):
733         (WTR::UIScriptController::didEndZoomingCallback):
734         (WTR::UIScriptController::setDidEndScrollingCallback):
735         (WTR::UIScriptController::didEndScrollingCallback):
736         (WTR::UIScriptController::setDidShowKeyboardCallback):
737         (WTR::UIScriptController::didShowKeyboardCallback):
738         (WTR::UIScriptController::setDidHideKeyboardCallback):
739         (WTR::UIScriptController::didHideKeyboardCallback):
740         (WTR::UIScriptController::uiScriptComplete):
741         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
742         (WTR::UIScriptController::create):
743         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
744         (WTR::UIScriptController::doAsyncTask):
745         (WTR::UIScriptController::zoomToScale):
746         (WTR::UIScriptController::singleTapAtPoint):
747         (WTR::UIScriptController::doubleTapAtPoint):
748         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
749         (WTR::UIScriptController::contentVisibleRect):
750         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
751         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
752         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
753         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
754         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
755         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
756         (WTR::UIScriptController::doAsyncTask):
757
758 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
759
760         [buildbot] clean-build script should remove untracked files and revert local changes too
761         https://bugs.webkit.org/show_bug.cgi?id=142400
762
763         Reviewed by Ryosuke Niwa.
764
765         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
766         A helper routine SCM.discard_untracked_files is added for that purpose.
767
768         * BuildSlaveSupport/clean-build:
769         (main): Making call to Scripts/clean-webkit
770         * Scripts/clean-webkit: Added.
771         (main): Revert changes and delete untracked files.
772         * Scripts/webkitpy/common/checkout/scm/scm.py:
773         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
774         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
775         (SCMTest._shared_test_discard_untracked_files):
776         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
777
778 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
779
780         Add a setting and preferences to enable display-list drawing. Does nothing yet.
781         https://bugs.webkit.org/show_bug.cgi?id=152807
782
783         Reviewed by Zalan Bujtas.
784         
785         Add an item to the Settings menu to toggle display-list drawing.
786
787         * MiniBrowser/mac/SettingsController.h:
788         * MiniBrowser/mac/SettingsController.m:
789         (-[SettingsController _populateMenu]):
790         (-[SettingsController validateMenuItem:]):
791         (-[SettingsController toggleDisplayListDrawingEnabled:]):
792         (-[SettingsController displayListDrawingEnabled]):
793         * MiniBrowser/mac/WK2BrowserWindowController.m:
794         (-[WK2BrowserWindowController didChangeSettings]):
795
796 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
797
798         Python SCM should be able to retrieve untracked files - Add GIT support
799         https://bugs.webkit.org/show_bug.cgi?id=143135
800
801         Reviewed by Michael Catanzaro.
802
803         * Scripts/webkitpy/common/checkout/scm/git.py:
804         (Git.untracked_files): Adding support for git.
805         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
806         (GitTest.setUp):
807         (GitTest.test_untracked_files): Adding test.
808
809 2016-01-05  Mark Lam  <mark.lam@apple.com>
810
811         Rename badly named JSC_timeout env var to JSCTEST_timeout.
812         https://bugs.webkit.org/show_bug.cgi?id=152748
813
814         Reviewed by Geoffrey Garen.
815
816         Now that we validate JSC options, the badly named JSC_timeout env var causes the
817         bots to have a bad time.
818
819         * Scripts/run-javascriptcore-tests:
820         * Scripts/run-jsc-stress-tests:
821
822 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         [GTK] Allow to save and restore session
825         https://bugs.webkit.org/show_bug.cgi?id=115600
826
827         Reviewed by Michael Catanzaro.
828
829         Add test case to check the new session API.
830
831         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
832         (testWebKitWebViewSessionState):
833         (testWebKitWebViewSessionStateWithFormData):
834         (beforeAll):
835
836 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
837
838         [EFL] Bump EFL version to 1.16.1
839         https://bugs.webkit.org/show_bug.cgi?id=152688
840
841         Reviewed by Gyuyoung Kim.
842
843         * efl/jhbuild.modules:
844
845 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
846
847         error running layout tests on iOS simulator on latest build
848         https://bugs.webkit.org/show_bug.cgi?id=152719
849         <rdar://problem/24009549>
850
851         Reviewed by Alexey Proskuryakov.
852
853         * Scripts/webkitpy/xcode/simulator.py:
854         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
855           before running simctl spawn command.
856
857 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
858
859         Unreviewed, move Frédéric Wang to committers list
860
861         He seems to be on the contributors list by accident. He has been landing his own commits for
862         about two years now.
863
864         * Scripts/webkitpy/common/config/contributors.json:
865
866 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
867
868         Unreviewed, move Sebastian Dröge to committers list harder
869
870         He accidentally added himself to the reviewers list because the file is confusing. Then I
871         accidentially moved him to the contributors list because the file is confusing, even though
872         I knew the contributors list existed in this file and was attempting to add him to the
873         committers list. Really move him to the committers list now.
874
875         * Scripts/webkitpy/common/config/contributors.json:
876
877 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
878
879         Python SCM should be able to retrieve untracked files - Add SVN support
880         https://bugs.webkit.org/show_bug.cgi?id=152546
881
882         Reviewed by Michael Catanzaro.
883
884         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
885         (test_untracked_files): Activating test for SVN.
886         * Scripts/webkitpy/common/checkout/scm/svn.py:
887         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
888
889 2015-12-31  Andy Estes  <aestes@apple.com>
890
891         Replace WTF::move with WTFMove
892         https://bugs.webkit.org/show_bug.cgi?id=152601
893
894         Reviewed by Brady Eidson.
895
896         * DumpRenderTree/TestRunner.h:
897         (TestRunner::setAllowedHosts):
898         * DumpRenderTree/win/DRTDataObject.cpp:
899         (DRTDataObject::SetData):
900         * TestWebKitAPI/Tests/WTF/Deque.cpp:
901         (TestWebKitAPI::TEST):
902         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
903         (TestWebKitAPI::TEST):
904         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
905         (TestWebKitAPI::TEST):
906         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
907         (TestWebKitAPI::TEST):
908         * TestWebKitAPI/Tests/WTF/Ref.cpp:
909         (TestWebKitAPI::passWithRef):
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/Tests/WTF/Vector.cpp:
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
918         (TestWebKitAPI::TEST):
919         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
920         (TestWebKitAPI::createTestValue):
921         (TestWebKitAPI::TEST):
922         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
923         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
924         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
925         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
926         (TestWebKitAPI::createNFAs):
927         (TestWebKitAPI::TEST_F):
928         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
929         (TestWebKitAPI::combine):
930         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
931         (TestWebKitAPI::createNFAs):
932         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
933         (TEST):
934         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
935         (WebProcessTest::add):
936
937 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
938
939         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
940         https://bugs.webkit.org/show_bug.cgi?id=152634
941
942         Reviewed by Carlos Garcia Campos.
943
944         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
945         (testLoadFromGResource): Added test.
946         (beforeAll):
947         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
948         (registerGResource): Added.
949         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
950         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
951         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
952
953 2015-12-31  David Kilzer  <ddkilzer@apple.com>
954
955         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
956         <https://bugs.webkit.org/show_bug.cgi?id=152601>
957
958         Ignore unknown pragmas on older clangs.  Fixes the following
959         build failure:
960
961             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
962             #pragma clang diagnostic ignored "-Wself-move"
963                                              ^
964             1 error generated.
965
966         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
967         (TestWebKitAPI::TEST):
968         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
969         (TestWebKitAPI::TEST):
970
971 2015-12-31  Andy Estes  <aestes@apple.com>
972
973         Update the style checker to advise using WTFMove() instead of WTF::move()
974         https://bugs.webkit.org/show_bug.cgi?id=152601
975
976         Reviewed by Daniel Bates.
977
978         * Scripts/webkitpy/style/checkers/cpp.py:
979         (check_wtf_move):
980         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
981         (WebKitStyleTest.test_wtf_move):
982
983 2015-12-31  Andy Estes  <aestes@apple.com>
984
985         Fix warnings uncovered by migrating to WTF_MOVE
986         https://bugs.webkit.org/show_bug.cgi?id=152601
987
988         Reviewed by Daniel Bates.
989
990         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
991         self-move, even if doing so would trigger a warning.
992
993         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
996         (TestWebKitAPI::TEST):
997
998 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
999
1000         [GTK] The install-dependencies script has a syntax error
1001         https://bugs.webkit.org/show_bug.cgi?id=152613
1002
1003         Reviewed by Michael Catanzaro.
1004
1005         * gtk/install-dependencies: Add the missing 'then.'
1006
1007 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1008
1009         [Mac][GTK] Jhbuild support for OSX
1010         https://bugs.webkit.org/show_bug.cgi?id=150799
1011
1012         Reviewed by Michael Catanzaro.
1013
1014         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1015         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1016         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1017         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1018
1019 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1020
1021         Unreviewed, move Sebastian Dröge to committers list
1022
1023         He accidentally added himself to the reviewers list because the file is confusing.
1024
1025         * Scripts/webkitpy/common/config/contributors.json:
1026
1027 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1028
1029         Remove the unused #define _USE_MATH_DEFINES
1030         https://bugs.webkit.org/show_bug.cgi?id=152034
1031
1032         Reviewed by Tim Horton.
1033         
1034         Update this test to use piDouble from MathExtras.h, and
1035         std::numeric_limits<>.
1036
1037         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1038
1039 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1040
1041         Python SCM should be able to retrieve untracked files - Generic changes
1042         https://bugs.webkit.org/show_bug.cgi?id=152536
1043
1044         Reviewed by Brent Fulgham.
1045
1046         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1047         No support is yet added to GIT and SVN specific implementations.
1048
1049         * Scripts/webkitpy/common/checkout/scm/scm.py:
1050         (SCM.untracked_files):
1051         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1052         (SCMTest._shared_test_untracked_files):
1053
1054 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1055
1056         SVN checkout used by RunBenchmark should be non-interactive
1057         https://bugs.webkit.org/show_bug.cgi?id=152542
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         RunBenchmark should not require user interaction while running.
1062
1063         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1064         (BenchmarkBuilder._checkout_with_subversion):
1065
1066 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1067
1068         Web Inspector: add support for running protocol-test.js tests on Windows
1069         https://bugs.webkit.org/show_bug.cgi?id=148037
1070         <rdar://problem/22292237>
1071
1072         Reviewed by Simon Fraser.
1073
1074         * DumpRenderTree/win/TestRunnerWin.cpp:
1075         (TestRunner::inspectorTestStubURL): Provide implementation.
1076
1077 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1078
1079         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1080         https://bugs.webkit.org/show_bug.cgi?id=152000
1081
1082         Reviewed by Brent Fulgham.
1083
1084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1085         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1086         (WTR::InjectedBundle::setUserMediaPermission):
1087         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1088         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1089
1090         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1091         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1092         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1093
1094         * WebKitTestRunner/TestController.cpp:
1095         (WTR::TestController::setUserMediaPermissionForOrigin):
1096         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1097         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1098           persistent permission for origin, that can be done from script now.
1099         * WebKitTestRunner/TestController.h:
1100
1101         * WebKitTestRunner/TestInvocation.cpp:
1102         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1103           SetUserMediaPermissionForOrigin.
1104
1105 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1106
1107         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1108
1109         * Scripts/webkitpy/common/system/platforminfo.py:
1110         (PlatformInfo._determine_win_version):
1111
1112 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1113
1114         Content blockers should be able to promote http to https
1115         https://bugs.webkit.org/show_bug.cgi?id=148966
1116
1117         Reviewed by Benjamin Poulain.
1118
1119         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1120         (WebCore::ContentExtensions::operator<<):
1121         (TestWebKitAPI::TEST_F):
1122
1123 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1124
1125         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1126         https://bugs.webkit.org/show_bug.cgi?id=152516
1127
1128         Reviewed by Gyuyoung Kim.
1129
1130         * MiniBrowser/efl/main.c:
1131
1132 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1133
1134         Unreviewed: Add John Wilander as a contributor.
1135
1136         * Scripts/webkitpy/common/config/contributors.json:
1137
1138 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1139
1140         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1141         https://bugs.webkit.org/show_bug.cgi?id=152482
1142
1143         Reviewed by Brent Fulgham.
1144
1145         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1146         for the same property. On WK2, the element returned will not be valid, but is still present and
1147         that can lead to looping.
1148
1149         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1150         (AccessibilityUIElement::horizontalScrollbar):
1151         (AccessibilityUIElement::verticalScrollbar):
1152         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1153         (WTR::AccessibilityUIElement::horizontalScrollbar):
1154         (WTR::AccessibilityUIElement::verticalScrollbar):
1155
1156 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1157
1158         Unreviewed.
1159
1160         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1161
1162 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1163
1164         [EFL] test_ewk2_context failed after r192808
1165         https://bugs.webkit.org/show_bug.cgi?id=151846
1166
1167         Reviewed by Gyuyoung Kim.
1168
1169         Used the added ewk_context_web_process_count_limit_set api
1170         instead of the deprecated ewk_context_process_model_set.
1171
1172         * MiniBrowser/efl/main.c:
1173         (elm_main):
1174
1175 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1176
1177         Unreviewed, move myself to reviewer list.
1178
1179         * Scripts/webkitpy/common/config/contributors.json:
1180
1181 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1182
1183         Unreviewed, add myself to the committers list.
1184
1185         * Scripts/webkitpy/common/config/contributors.json:
1186
1187 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1188
1189         [GTK] jquery.min.js violates DFSG
1190         https://bugs.webkit.org/show_bug.cgi?id=152428
1191
1192         Reviewed by Joseph Pecoraro.
1193
1194         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1195         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1196
1197         * gtk/manifest.txt.in:
1198
1199 2015-12-19  Dan Bernstein  <mitz@apple.com>
1200
1201         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1202         https://bugs.webkit.org/show_bug.cgi?id=152462
1203
1204         Reviewed by Alexey Proskuryakov.
1205
1206         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1207           OS X 10.9:
1208
1209         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1210         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1211         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1212         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1213         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1214
1215         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1216           never getting compiled:
1217
1218         * DumpRenderTree/mac/TextInputController.m:
1219         * MiniBrowser/mac/BrowserWindowController.m:
1220         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1221         * WebKitTestRunner/mac/EventSenderProxy.mm:
1222
1223 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1224
1225         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1226
1227         This is to make it easy to CC it on Bugzilla.
1228
1229         * Scripts/webkitpy/common/config/contributors.json:
1230
1231 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1232
1233         Pasteboard get messed up after running kill-old-processes
1234         https://bugs.webkit.org/show_bug.cgi?id=152426
1235
1236         Reviewed by Alexey Proskuryakov.
1237
1238         * BuildSlaveSupport/kill-old-processes:
1239         (main): Do not kill pasteboard anymore.
1240
1241 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1242
1243         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1244         https://bugs.webkit.org/show_bug.cgi?id=152157
1245         <rdar://problem/23851817>
1246
1247         Reviewed by Alexey Proskuryakov.
1248
1249         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1250         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1251         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1252         (Manager._get_test_inputs): Common method to calculate test_inputs.
1253         (Manager._update_worker_count): Calculate and update required number of workers.
1254
1255 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1256
1257         run-webkit-tests fails to delete Simulator device during cleanup
1258         https://bugs.webkit.org/show_bug.cgi?id=152363
1259
1260         Reviewed by Alexey Proskuryakov.
1261
1262         * Scripts/webkitpy/xcode/simulator.py:
1263         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1264
1265 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1266
1267         [mac-wk2] fast/events force click tests crashing
1268         https://bugs.webkit.org/show_bug.cgi?id=152339
1269
1270         Reviewed by Beth Dakin.
1271
1272         * WebKitTestRunner/mac/EventSenderProxy.mm:
1273         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1274         Set the NSEvent's _type member in addition to overriding -type,
1275         because there are assertions in touch event handling code that depend on it.
1276
1277 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1278
1279         Enforce temporarily bots to sync WebKit and WPT testharness.js
1280         https://bugs.webkit.org/show_bug.cgi?id=152334
1281
1282         Reviewed by Darin Adler.
1283
1284         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1285         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1286
1287 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1288
1289         [Fetch API] Add fetch API compile time flag
1290         https://bugs.webkit.org/show_bug.cgi?id=152254
1291
1292         Reviewed by Darin Adler.
1293
1294         * Scripts/webkitperl/FeatureList.pm:
1295
1296 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1297
1298         Unreviewed.
1299
1300         Added files that have impact in building Streams API to the watchlist.
1301
1302         * Scripts/webkitpy/common/config/watchlist:
1303
1304 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1305
1306         Unreviewed.
1307
1308         Added imported tests to Streams API watchlist.
1309
1310         * Scripts/webkitpy/common/config/watchlist:
1311
1312 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1313
1314         Remove default copy of wpt testharness.js when launching wpt server
1315         https://bugs.webkit.org/show_bug.cgi?id=152298
1316
1317         Reviewed by Darin Adler.
1318
1319         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1320         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1321
1322 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1323
1324         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1325         <http://webkit.org/b/152314>
1326
1327         Reviewed by Daniel Bates.
1328
1329         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1330         code path to exit immediately when calling main().
1331         Unfortunately, DumpRenderTreeMain.mm was used for both
1332         DumpRenderTree command-line binary and DumpRenderTree.app, which
1333         meant that the app would exit immediately with no error code
1334         when run!
1335
1336         The workaround is to introduce a separate source file called
1337         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1338         already does.
1339
1340         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1341         DumpRenderTreeAppMain.mm to the project.  Make it the only
1342         compiled source for the DumpRenderTree.app target.
1343         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1344         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1345         case someone tries mistakenly to use the app.
1346         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1347         Link to JavaScriptCore.framework on iOS for the assert.
1348         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1349         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1350         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1351         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1352         (main): Add assert for iOS so that a crash occurs if someone
1353         tries to run the wrong command.
1354
1355 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1356
1357         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1358         https://bugs.webkit.org/show_bug.cgi?id=152266
1359         <rdar://problem/22092676>
1360
1361         Reviewed by Simon Fraser.
1362
1363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1364         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1365         Add a test that crashed before this change, and doesn't crash after.
1366
1367 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1368
1369         AX: iOS: Text field variations do not have the correct traits
1370         https://bugs.webkit.org/show_bug.cgi?id=152237
1371
1372         Reviewed by Mario Sanchez Prada.
1373
1374         Add iOS calls for determing if an object is a search field or a text area.
1375
1376         * DumpRenderTree/AccessibilityUIElement.cpp:
1377         (getIsSearchFieldCallback):
1378         (getIsTextAreaCallback):
1379         (stringForSelectionCallback):
1380         (AccessibilityUIElement::getJSClass):
1381         * DumpRenderTree/AccessibilityUIElement.h:
1382         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1383         (AccessibilityUIElement::identifier):
1384         (AccessibilityUIElement::isTextArea):
1385         (AccessibilityUIElement::isSearchField):
1386         (AccessibilityUIElement::traits):
1387         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1388         (WTR::AccessibilityUIElement::scrollPageRight):
1389         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1390         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1391         (WTR::AccessibilityUIElement::isSearchField):
1392         (WTR::AccessibilityUIElement::isTextArea):
1393         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1394         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1395         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1396         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1397         (WTR::AccessibilityUIElement::isTextArea):
1398         (WTR::AccessibilityUIElement::isSearchField):
1399         (WTR::AccessibilityUIElement::rowCount):
1400
1401 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1402
1403         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1404         https://bugs.webkit.org/show_bug.cgi?id=152252
1405
1406         Reviewed by Sergio Villar Senin.
1407
1408         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1409         for building the JHBuild on Debian systems.
1410
1411 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1412
1413         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1414         https://bugs.webkit.org/show_bug.cgi?id=152156
1415
1416         Reviewed by Dan Bernstein.
1417
1418         Our frameworks should appropriately prefix all ObjC classes,
1419         not just external symbols.
1420
1421         * Scripts/check-for-inappropriate-objc-class-names:
1422         Remove the -g switch to check all ObjC class names.
1423
1424 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1425
1426         [MediaStream] Expose media capture devices persistent permissions to WebCore
1427         https://bugs.webkit.org/show_bug.cgi?id=152087
1428
1429         Add support for the new user media permission checker page UI client method.
1430
1431         Reviewed by Chris Dumez.
1432
1433         * WebKitTestRunner/TestController.cpp:
1434         (WTR::decidePolicyForUserMediaPermissionRequest):
1435         (WTR::checkUserMediaPermissionForOrigin):
1436         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1437         (WTR::TestController::createWebViewWithOptions): Ditto.
1438         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1439         (WTR::originUserVisibleName): New, create a string for the origin.
1440         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1441           according to the state of the origin permission map.
1442         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1443           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1444         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1445           origin permission map.
1446         * WebKitTestRunner/TestController.h:
1447
1448 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1449
1450         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1451         https://bugs.webkit.org/show_bug.cgi?id=152022
1452         rdar://problem/23763584
1453
1454         Reviewed by Darin Adler.
1455
1456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1457         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1458         (WTR::InjectedBundlePage::willSendRequestForFrame):
1459         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1460         (WTR::TestRunner::setWillSendRequestReturnsNull):
1461         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1462         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1463         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1464         (WTR::TestRunner::willSendRequestHTTPBody):
1465         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1466
1467 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1468
1469         Remove additional simulator checks before running layout-tests
1470         https://bugs.webkit.org/show_bug.cgi?id=152146
1471
1472         Reviewed by Darin Adler.
1473
1474         * Scripts/webkitpy/port/ios.py:
1475         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1476         * Scripts/webkitpy/xcode/simulator.py:
1477         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1478         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1479
1480 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1481
1482         Run atleast one simulator even if max process limit is low
1483         https://bugs.webkit.org/show_bug.cgi?id=152081
1484         <rdar://problem/23819694>
1485
1486         Reviewed by Alexey Proskuryakov.
1487
1488 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1489
1490         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1491         https://bugs.webkit.org/show_bug.cgi?id=144262
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         Added new unit test to check the additional scenarios we now
1496         handle for custom URI schemes.
1497
1498         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1499         (generateHTMLContent): New helper function to generate big enough content.
1500         (testWebContextURIScheme): New unit test.
1501
1502 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1503
1504         [EFL] Fix unhandled web process message when launching MiniBrowser
1505         https://bugs.webkit.org/show_bug.cgi?id=152048
1506
1507         Reviewed by Gyuyoung Kim.
1508
1509         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1510         (TestWebKitAPI::TEST):
1511
1512 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         [GTK] Add API to handle beforeunload events
1515         https://bugs.webkit.org/show_bug.cgi?id=139090
1516
1517         Reviewed by Gustavo Noronha Silva.
1518
1519         * MiniBrowser/gtk/BrowserWindow.c:
1520         (browserWindowConstructed):
1521         (browserWindowDeleteEvent):
1522         (browser_window_class_init):
1523         Handle delete-event to prevent the window from being closed when
1524         the page has beforeunload handlers. Use
1525         webkit_web_view_try_close() when the window is requested to be
1526         closed.
1527         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1528         (testWebViewJavaScriptDialogs):
1529         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1530         script dialog type.
1531
1532 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1533
1534         Refactored initialization code in LoadTrackingTest.
1535
1536         Rubber-stamped by Carlos Garcia Campos.
1537
1538         Small refactoring to make sure that the state of a LoadTrackingTest
1539         gets properly reset before loading new web content.
1540
1541         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1542         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1543         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1544         functions and reset the remaining local variables.
1545         (LoadTrackingTest::loadURI): Call reset();
1546         (LoadTrackingTest::loadHtml): Ditto.
1547         (LoadTrackingTest::loadPlainText): Ditto.
1548         (LoadTrackingTest::loadBytes): Ditto.
1549         (LoadTrackingTest::loadRequest): Ditto.
1550         (LoadTrackingTest::reload): Ditto.
1551         (LoadTrackingTest::goBack): Ditto.
1552         (LoadTrackingTest::goForward): Ditto.
1553
1554 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1555
1556         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1557         https://bugs.webkit.org/show_bug.cgi?id=151942
1558
1559         Reviewed by Darin Adler.
1560
1561         * MiniBrowser/efl/main.c:
1562         (window_create): Enable offline web application cache feature on MiniBrowser.
1563         (elm_main):
1564
1565 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1566
1567         https://bugs.webkit.org/show_bug.cgi?id=151243
1568         <rdar://problem/22955197>
1569
1570         Reviewed by Alexey Proskuryakov.
1571
1572         * LayoutTestRelay/LayoutTestRelay/main.m:
1573         (getTestingSimDevice): Use separate testing device for each worker.
1574         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1575         (Manager.run): Perform cleanup even if setup fails.
1576         * Scripts/webkitpy/port/ios.py:
1577         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1578         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1579         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1580         (IOSSimulatorPort._quit_ios_simulator): Same
1581         (IOSSimulatorPort.clean_up_test_run): Same
1582         (IOSSimulatorPort.check_sys_deps): Same
1583         (IOSSimulatorPort.testing_device): Same
1584         (IOSSimulatorPort.reset_preferences): Same
1585         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1586         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1587         * Scripts/webkitpy/xcode/simulator.py:
1588         (Device.delete): Delete the simulator device.
1589         (Simulator.delete_device): Same
1590         (Simulator.wait_until_device_is_booted): Wait for device booting.
1591
1592 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1593
1594         [EFL] Add API to provide preferences before creating ewk_view
1595         https://bugs.webkit.org/show_bug.cgi?id=151587
1596
1597         Reviewed by Gyuyoung Kim.
1598
1599         * MiniBrowser/efl/main.c:
1600         (on_key_down):
1601         (quit):
1602         (window_create):
1603         Moved settings related code to configuration() not to update settings
1604         whenever ewk_view is created.
1605         (configuration):
1606         (elm_main):
1607
1608 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1609
1610         Unreviewed. Fix GTK+ API tests after r193639.
1611
1612         The new jhbuild version needs some more variables ot be present in
1613         the builtin dict, even if they are set to None.
1614
1615         * jhbuild/jhbuildutils.py:
1616         (enter_jhbuild_environment_if_available):
1617
1618 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1619
1620         [GTK] Notify WebCore when notification is clicked
1621         https://bugs.webkit.org/show_bug.cgi?id=151951
1622
1623         Reviewed by Carlos Garcia Campos.
1624
1625         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1626         (testWebViewNotification): test the new API.
1627
1628 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1629
1630         'jhbuild build' should fail immediately when building any module fails
1631         https://bugs.webkit.org/show_bug.cgi?id=145697
1632
1633         Reviewed by Carlos Garcia Campos.
1634
1635         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1636         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1637         Everything is placed under lib instead of lib64 now.
1638         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1639         --exit-on-error when running 'jhbuild build'.
1640         * jhbuild/jhbuildrc_common.py:
1641         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1642         jhbuild should be able to handle these for us without breaking things....
1643
1644 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1645
1646         Add support to import w3c tests from a repository with a different root that the main repo dir
1647         https://bugs.webkit.org/show_bug.cgi?id=151751
1648
1649         Reviewed by Ryosuke Niwa and Youenn Fablet.
1650
1651         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1652         in a different directory than the repository root.
1653
1654         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1655         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1656         requires having the copy_path lists including tuples of origin and destination directories.
1657
1658         * Scripts/webkitpy/w3c/test_downloader.py:
1659         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1660         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1661         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1662         (TestImporterTest.test_tests_directory): Test.
1663
1664 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1665
1666         Mock TestRepositories in W3C importer tests
1667         https://bugs.webkit.org/show_bug.cgi?id=151938
1668
1669         Reviewed by Youenn Fablet.
1670
1671         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1672         is because the test repository method reading the file was using the filesystem directly instead of taking the
1673         host one. This patch changes that.
1674
1675         * Scripts/webkitpy/w3c/test_downloader.py:
1676         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1677         default one.
1678         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1679         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1680         (TestImporterTest.test_harnesslinks_conversion):
1681         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1682
1683 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1684
1685         TestNetscapePlugIn: Address review comment on 193607
1686         <http://webkit.org/b/151881>
1687
1688         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1689         (testSetStatus): Initializing std::unique_ptr<char[]> with
1690         nullptr is redundant.
1691
1692 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1693
1694         [GTK] Add webkit_uri_request_get_http_method
1695         https://bugs.webkit.org/show_bug.cgi?id=151601
1696
1697         Reviewed by Martin Robinson.
1698
1699         Add test case to check HTTP method of WebKitURIRequest.
1700
1701         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1702         (testURIRequestHTTPMethod):
1703         (serverCallback):
1704         (beforeAll):
1705         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1706         (sendRequestCallback):
1707
1708 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1709
1710         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1711         https://bugs.webkit.org/show_bug.cgi?id=79918
1712
1713         Reviewed by Gustavo Noronha Silva.
1714
1715         Add unit tests to check the different console messages.
1716
1717         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1718         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1719         (ConsoleMessageTest::ConsoleMessage::operator==):
1720         (ConsoleMessageTest::consoleMessageReceivedCallback):
1721         (ConsoleMessageTest::ConsoleMessageTest):
1722         (ConsoleMessageTest::~ConsoleMessageTest):
1723         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1724         (testWebKitConsoleMessageConsoleAPI):
1725         (testWebKitConsoleMessageJavaScriptException):
1726         (testWebKitConsoleMessageNetworkError):
1727         (testWebKitConsoleMessageSecurityError):
1728         (beforeAll):
1729         (afterAll):
1730         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1731         (consoleMessageSentCallback):
1732         (pageCreatedCallback):
1733
1734 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1735
1736         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1737         https://bugs.webkit.org/show_bug.cgi?id=151934
1738
1739         Reviewed by Csaba Osztrogonác.
1740
1741         * MiniBrowser/efl/main.c:
1742         (on_window_deletion): Revert the changes of r192767.
1743
1744 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1745
1746         [GTK] update-webkitgtk-libs cannot build mesa
1747         https://bugs.webkit.org/show_bug.cgi?id=151535
1748
1749         Reviewed by Martin Robinson.
1750
1751         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1752         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1753         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1754         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1755         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1756         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1757
1758         * gtk/jhbuild.modules:
1759
1760 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1761
1762         [GTK][Mac] libWebExtensionTest link error
1763         https://bugs.webkit.org/show_bug.cgi?id=150802
1764
1765         Reviewed by Carlos Garcia Campos.
1766
1767         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1768
1769 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1770
1771         TestNetscapePlugIn: Fix leaks found by static analyzer
1772         <http://webkit.org/b/151881>
1773
1774         Reviewed by Darin Adler.
1775
1776         Fixes the following leaks found by the static analyzer:
1777             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1778                     return false;
1779                            ^~~~~
1780             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1781                     return false;
1782                            ^~~~~
1783             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1784                     return false;
1785                            ^~~~~
1786
1787         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1788         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1789         early return if allocation fails.
1790         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1791         Make sure to call fclose() on filehandle, even for an early
1792         return.
1793         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1794
1795 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1796
1797         prepare-ChangeLog: Fix some warning messages when using svn
1798         <http://webkit.org/b/151914>
1799
1800         Reviewed by Daniel Bates.
1801
1802         * Scripts/prepare-ChangeLog:
1803         (generateFunctionLists): Simplify logic so that we never call
1804         normalizePath() with an undefined value.
1805         (attributeCommand): Quote $subPath for the shell so that we
1806         don't try to run "svn propget" on invalid paths.
1807
1808 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1809
1810         TestNetscapePlugIn: Fix remaining static analyzer warnings
1811         <http://webkit.org/b/151888>
1812
1813         Reviewed by Alexey Proskuryakov.
1814
1815         Fixes the following static analyzer warnings:
1816             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1817                     CRASH();
1818                     ^~~~~~~
1819             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1820                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1821                 ^~~~~~~~~~~~~~~~
1822             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1823                 return obj->pluginTest->NPP_SetWindow(window);
1824                        ^~~~~~~~~~~~~~~
1825             2 warnings generated.
1826
1827         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1828         (CRASH): Use __builtin_trap() for gcc/clang.
1829         (NPP_SetWindow): Add early return if obj is nullptr.
1830
1831 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1832
1833         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1834         https://bugs.webkit.org/show_bug.cgi?id=151797
1835
1836         Reviewed by Martin Robinson.
1837
1838         Since we switched to use the network process to run the unit tests
1839         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1840         sometimes passes. We are now also getting the notification for the
1841         css image. Since we wait for 3 resources, sometimes the css image
1842         is loaded before and then checkResourceData is called for it, but
1843         not handled. When the css image is the last one loaded the test
1844         passes. So, we just need to wait for the 4 resources.
1845
1846         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1847         (testWebResourceGetData):
1848
1849 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1850
1851         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1852         <http://webkit.org/b/151845>
1853
1854         Reviewed by Simon Fraser.
1855
1856         Fixes the following static analyzer warning:
1857             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1858                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1859                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1860
1861         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1862         (createBitmapContext): Free 'buffer' after using it in logging
1863         to fix the use-after-free.  Assign a value of nullptr to buffer
1864         so we don't return with it set to a freed address.
1865
1866 2015-12-03  Jer Noble  <jer.noble@apple.com>
1867
1868         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1869         https://bugs.webkit.org/show_bug.cgi?id=151830
1870
1871         Reviewed by Anders Carlsson.
1872
1873         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1874
1875         * DumpRenderTree/mac/DumpRenderTree.mm:
1876         (resetWebPreferencesToConsistentValues):
1877         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1878         (WTR::initializeWebViewConfiguration):
1879
1880 2015-12-03  Anders Carlsson  <andersca@apple.com>
1881
1882         Remove Objective-C GC support
1883         https://bugs.webkit.org/show_bug.cgi?id=151819
1884         rdar://problem/23746991
1885
1886         Reviewed by Dan Bernstein.
1887
1888         * asan/asan.xcconfig:
1889
1890 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1891
1892         Allow nil for unspecified benchmark pathes
1893         https://bugs.webkit.org/show_bug.cgi?id=151784
1894
1895         Reviewed by Filip Pizlo.
1896
1897         `Pathname.new(nil)` will raise an error.
1898         Only generate Pathname if the benchmark path is specified.
1899
1900         * Scripts/run-jsc-benchmarks:
1901
1902 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1903
1904         [Win] Run non-http tests without Cygwin
1905         https://bugs.webkit.org/show_bug.cgi?id=151721
1906
1907         Reviewed by Andy Estes.
1908
1909         Support native 32-bit and 64-bit Python (and Perl) builds
1910         for running tests:
1911
1912         1. Use "startswith('win')", rather than "== 'win32'" to support
1913         various Windows build types.
1914         2. Supply full path for some native Windows utilities, since the
1915         path environment does not always have the specified, and they are
1916         guaranteed to exist in those specific locations.
1917         3. Make sure native Windows Python test runs pass proper environment
1918         variables to run programs.
1919         4. Append 'exe' suffix when running Windows executables.
1920         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1921         command doesn't exist.
1922         
1923         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1924         the current Perl executable, rather than requiring a new path search.
1925         * Scripts/webkitpy/common/find_files_unittest.py:
1926         (TestWinNormalize.test_win): Use startswith('win').
1927         * Scripts/webkitpy/common/prettypatch_unittest.py:
1928         (test_pretty_diff_encodings): Ditto.
1929         * Scripts/webkitpy/common/system/executive.py:
1930         (Executive._should_close_fds): Ditto.
1931         (Executive.shell_command_for_script): Use startswith('win').
1932         (Executive.kill_process): Use full path to killall executable.
1933         (Executive.check_running_pid): Use startswith('win').
1934         (Executive.running_pids): Ditto.
1935         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1936         running under native Windows Python.
1937         (Executive._child_process_encoding): Use startswith('win').
1938         (Executive._should_encode_child_process_arguments): Ditto.
1939         (Executive.popen): Recognize proper script engine on Windows, since it
1940         does not support the shebang syntax.
1941         (Executive.run_in_parallel): Use startswith('win').
1942         * Scripts/webkitpy/common/system/executive_unittest.py:
1943         (never_ending_command): Ditto.
1944         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1945         (ExecutiveTest.serial_test_kill_process): Ditto.
1946         (ExecutiveTest.serial_test_kill_all): Ditto.
1947         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1948         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1949         (main): Ditto.
1950         * Scripts/webkitpy/common/system/file_lock.py:
1951         (FileLock._create_lock): Ditto.
1952         (FileLock._remove_lock): Ditto.
1953         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1954         (RealFileSystemTest.test_chdir): Ditto.
1955         (RealFileSystemTest.test_chdir__notexists): Ditto.
1956         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1957         * Scripts/webkitpy/common/system/path_unittest.py:
1958         (AbspathTest.test_abspath_to_uri_win): Ditto.
1959         * Scripts/webkitpy/common/system/platforminfo.py:
1960         (PlatformInfo._determine_os_name): Ditto.
1961         * Scripts/webkitpy/common/system/user.py: Ditto.
1962         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1963         (ManagerTest.integration_test_needs_servers): Ditto.
1964         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1965         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1966         driver letters.
1967         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1968         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1969         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1970         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1971         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1972         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1973         (TestHttpServer.test_start_cmd): Ditto.
1974         * Scripts/webkitpy/port/base.py:
1975         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1976         and 'SYSTEMROOT' in environment passed to test runners.
1977         (Port._apache_config_file_name_for_platform): Use startswith('win').
1978         (Port._build_path): Ditto.
1979         (Port._path_to_driver): Include 'exe' suffix when running under native
1980         Windows.
1981         * Scripts/webkitpy/port/driver.py:
1982         (Driver._setup_environ_for_driver): Explicitly make some environment
1983         variables strings.
1984         * Scripts/webkitpy/port/server_process.py:
1985         (ServerProcess.__init__): Use startswith('win').
1986         * Scripts/webkitpy/port/win.py:
1987         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1988         registry key formats.
1989         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1990         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1991         and regtool on Cygwin.
1992         (WinPort.write_registry_value): Ditto.
1993         (WinPort.setup_crash_log_saving): Ditto.
1994         (WinPort.restore_crash_log_saving): Ditto.
1995         (WinPort.prevent_error_dialogs): Ditto.
1996         (WinPort.allow_error_dialogs): Ditto.
1997         (WinPort.find_system_pid): Revise to use Windows management
1998         infrastructure on native Windows, continue using 'ps' on Cygwin.
1999         (WinPort.read_registry_string): Deleted.
2000         (WinPort.write_registry_string): Deleted.
2001         * Scripts/webkitpy/test/main.py:
2002         (main): Use startswith('win').
2003         (Tester._parse_args): Ditto.
2004
2005 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2006
2007         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2008         https://bugs.webkit.org/show_bug.cgi?id=150792
2009
2010         Reviewed by Saam Barati.
2011
2012         * Scripts/webkitperl/FeatureList.pm:
2013
2014 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2015
2016         Unreviewed, rolling out r192914.
2017         https://bugs.webkit.org/show_bug.cgi?id=151734
2018
2019         JSC tests for this change are failing on 32 and 64-bit bots
2020         (Requested by ryanhaddad on #webkit).
2021
2022         Reverted changeset:
2023
2024         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2025         enable this feature"
2026         https://bugs.webkit.org/show_bug.cgi?id=150792
2027         http://trac.webkit.org/changeset/192914
2028
2029 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2030
2031         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2032         <http://webkit.org/b/151726>
2033
2034         Reviewed by Simon Fraser.
2035
2036         * WebKitTestRunner/mac/EventSenderProxy.mm:
2037         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2038         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2039
2040 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2041
2042         Give String and AtomicString an existingHash() function
2043         https://bugs.webkit.org/show_bug.cgi?id=151717
2044
2045         Reviewed by Andreas Kling.
2046
2047         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2048         (TestWebKitAPI::TEST):
2049         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2050         (TestWebKitAPI::TEST):
2051
2052 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2053
2054         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2055         https://bugs.webkit.org/show_bug.cgi?id=150792
2056
2057         Reviewed by Saam Barati.
2058
2059         * Scripts/webkitperl/FeatureList.pm:
2060
2061 2015-12-01  Sam Weinig  <sam@webkit.org>
2062
2063         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2064         <rdar://problem/23320863>
2065         https://bugs.webkit.org/show_bug.cgi?id=151708
2066
2067         Reviewed by Anders Carlsson.
2068
2069         * WebKitTestRunner/TestController.cpp:
2070         (WTR::TestController::createOtherPage):
2071         (WTR::TestController::createWebViewWithOptions):
2072         Update for new WKPageUIClient.
2073
2074 2015-12-01  Anders Carlsson  <andersca@apple.com>
2075
2076         Remove WebKit2.framework
2077         https://bugs.webkit.org/show_bug.cgi?id=151715
2078
2079         Reviewed by Dan Bernstein.
2080
2081         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2082         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2083         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2084         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2085         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2086         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2087         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2088
2089 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2090
2091         Unreviewed common typo fix "occurance" => "occurrence".
2092
2093         * Scripts/webkitpy/tool/commands/queries.py:
2094         (FindFlakyTests._print_statistics):
2095
2096 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2097
2098         Make ProcessModel always MultipleSecondaryProcesses
2099         https://bugs.webkit.org/show_bug.cgi?id=151662
2100
2101         Reviewed by Antti Koivisto.
2102
2103         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2104         (TestWebKitAPI::TEST):
2105         * WebKitTestRunner/TestController.cpp:
2106         (WTR::TestController::generatePageConfiguration):
2107
2108 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2109
2110         Make usesNetworkProcess always true
2111         https://bugs.webkit.org/show_bug.cgi?id=151580
2112
2113         Reviewed by Darin Adler.
2114
2115         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2116         (TestWebKitAPI::TEST):
2117         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2118         (TestWebKitAPI::TEST):
2119         * WebKitTestRunner/TestController.cpp:
2120         (WTR::TestController::generatePageConfiguration):
2121
2122 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2125
2126         Add a way to skip unit tests only for Debug or Release builds and
2127         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2128
2129         * Scripts/run-gtk-tests:
2130         (SkippedTest):
2131         (SkippedTest.__init__):
2132         (SkippedTest.__str__):
2133         (SkippedTest.skip_entire_suite):
2134         (SkippedTest.skip_for_build_type):
2135         (TestRunner):
2136         (TestRunner.__init__):
2137
2138 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2139
2140         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2141
2142         It's an assert hit because we are reloading a view loaded with
2143         HTML data which is not supported. Use loadURI instead.
2144
2145         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2146         (testWebViewCustomCharset):
2147
2148 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2149
2150         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2151         https://bugs.webkit.org/show_bug.cgi?id=151633
2152
2153         Reviewed by Csaba Osztrogonác.
2154
2155         * TestWebKitAPI/PlatformGTK.cmake:
2156         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2157
2158 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2159
2160         [GTK] Remove the remaining uses of GMainLoopSource
2161         https://bugs.webkit.org/show_bug.cgi?id=151632
2162
2163         Reviewed by Žan Doberšek.
2164
2165         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2166         (testWebViewSyncRequestOnMaxConns):
2167         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2169         (WTR::TestRunner::TestRunner):
2170         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2171         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2172         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2173         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2174         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2175         (WTR::timeoutSource):
2176         (WTR::TestController::notifyDone):
2177         (WTR::TestController::platformRunUntil):
2178
2179 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2180
2181         [cmake] Add testb3 to the build system
2182         https://bugs.webkit.org/show_bug.cgi?id=151619
2183
2184         Reviewed by Gyuyoung Kim.
2185
2186         * Scripts/build-jsc:
2187
2188 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2189
2190         [jhbuild] Fix pixman build with clang
2191         https://bugs.webkit.org/show_bug.cgi?id=151441
2192
2193         Reviewed by Carlos Garcia Campos.
2194
2195         * efl/jhbuild.modules:
2196         * gtk/jhbuild.modules:
2197
2198 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2199
2200         Extract prependToEnvironmentVariableList
2201         <http://webkit.org/b/151536>
2202
2203         Reviewed by Daniel Bates.
2204
2205         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2206                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2207
2208         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2209         and prependToEnvironmentVariableList.
2210         (appendToEnvironmentVariableList): Simplify variable name.
2211         Switch to use $Config{path_sep}.
2212         (prependToEnvironmentVariableList): Add new method.
2213         (setupMacWebKitEnvironment): Switch to use
2214         prependToEnvironmentVariableList().
2215         (setupIOSWebKitEnvironment): Ditto.
2216
2217         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2218         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2219
2220 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2221
2222         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2223         https://bugs.webkit.org/show_bug.cgi?id=151567
2224
2225         Reviewed by Darin Adler.
2226
2227         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2228         (on_window_deletion):
2229
2230 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         [GTK] Use the network process unconditionally
2233         https://bugs.webkit.org/show_bug.cgi?id=151541
2234
2235         Reviewed by Alex Christensen.
2236
2237         Fix TestInspectorServer test. Do not assume we already have the
2238         title we want when the page has been loaded, since the title is
2239         changed afterwards. So, check if the title has already been set,
2240         and if not wait for it.
2241
2242         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2243         (openRemoteDebuggingSession):
2244
2245 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2246
2247         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2248         https://bugs.webkit.org/show_bug.cgi?id=151532
2249
2250         Reviewed by Benjamin Poulain.
2251
2252         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2253         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2254         (TestWebKitAPI::TEST):
2255         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2256         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2257         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2258         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2259         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2260         so it was calling a function on a test object that had gone out of scope.
2261         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2262         but that will become the default soon and that call will be removed.
2263
2264 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2265
2266         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2267         <http://webkit.org/b/151542>
2268
2269         Reviewed by Daniel Bates.
2270
2271         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2272         (base_url): Use the Port object (already passed in) to give us
2273         the path to the LayoutTests directory, which already checks for a
2274         --layout-tests-directory command-line switch.
2275         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2276         argument since we can get this from the Port object already
2277         passed in via Port.results_directory().  Also switch to use
2278         Port.layout_tests_dir() to get the LayoutTests directory.
2279
2280         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2281         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2282         Add test case for custom LayoutTests directory.
2283         (TestWebPlatformTestServer.test_previously_spawned_instance):
2284         Update Port object to set mock results directory as if it was
2285         set on the command-line.  Remove unneeded argument from
2286         WebPlatformTestServer constructor.
2287         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2288
2289         * Scripts/webkitpy/port/base.py:
2290         (Port.to.start_web_platform_test_server): Remove unneeded
2291         argument from WebPlatformTestServer constuctor.
2292
2293 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         [GTK] Some unit tests fail when using the network process
2296         https://bugs.webkit.org/show_bug.cgi?id=151490
2297
2298         Reviewed by Martin Robinson.
2299
2300         Run the soup server in a separate thread in TestResources test to
2301         avoid deadlocks.
2302
2303         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2304         /webkit2/WebKitWebResource/get-data when using the network process.
2305
2306         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2307         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2308         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2309         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2310         present, create a WorkQueue to run the server.
2311         (WebKitTestServer::run): Run the server in the work queue if it
2312         has been created.
2313         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2314         type into server options as flags.
2315
2316 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2317
2318         [GTK] ImageDiff should normalize the diff image
2319         https://bugs.webkit.org/show_bug.cgi?id=151261
2320
2321         Reviewed by Sergio Villar Senin.
2322
2323         * ImageDiff/gtk/ImageDiff.cpp:
2324         (readPixbufFromStdin): Fix memory leak.
2325         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2326         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2327
2328 == Rolled over to ChangeLog-2015-11-21 ==