a0b497561ff147935d50ecdcc602d12639627435
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2
3         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
4         https://bugs.webkit.org/show_bug.cgi?id=106682
5
6         Reviewed by Chris Fleizach.
7
8         Modify Chromium's DRT implementation of intValue to return a
9         different value depending on the role.
10
11         There are actually platform-specific differences in what should
12         be returned in the "value" of an object, so Chromium normally keeps
13         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
14         but this is a fine simplification to make cross-platform tests easier.
15
16         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
17         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
18
19 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
20
21         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
22         https://bugs.webkit.org/show_bug.cgi?id=106785
23
24         Reviewed by Adam Barth.
25
26         * DumpRenderTree/chromium/DRTTestRunner.cpp:
27         (DRTTestRunner::DRTTestRunner):
28         (DRTTestRunner::reset):
29         * DumpRenderTree/chromium/DRTTestRunner.h:
30         (DRTTestRunner):
31         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
32         (WebTestProxyBase):
33         (WebTestRunner::WebTestProxy::setStatusText):
34         (WebTestRunner::WebTestProxy::didStopLoading):
35         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
36         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
37         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
38         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
39         (WebTestRunner::TestRunner::TestRunner):
40         (WebTestRunner::TestRunner::reset):
41         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
42         (WebTestRunner):
43         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
44         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
45         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
46         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
47         (TestRunner):
48         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
49         (WebTestRunner::WebTestProxyBase::setStatusText):
50         (WebTestRunner):
51         (WebTestRunner::WebTestProxyBase::didStopLoading):
52         * DumpRenderTree/chromium/WebViewHost.cpp:
53         (WebViewHost::didStopLoading):
54         * DumpRenderTree/chromium/WebViewHost.h:
55         (WebViewHost):
56
57 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
58
59         Web Inspector: devtools front-end doesn't have focus in TestShell
60         https://bugs.webkit.org/show_bug.cgi?id=106778
61
62         Reviewed by Pavel Feldman.
63
64         Focus devTools window after loadURL method.
65
66         * DumpRenderTree/chromium/TestShell.cpp:
67         (TestShell::runFileTest):
68
69 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
70
71         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
72         https://bugs.webkit.org/show_bug.cgi?id=106573
73
74         Reviewed by Philippe Normand.
75
76         Similarly to what's been described in bug 106569, we're building
77         from release tarballs, so there's no reason to regenerate the
78         autoconf-related stuff with autogen.sh, especially since we might
79         run into trouble with automake 1.13 and deprecated macros.
80
81         * efl/jhbuild.modules:
82
83 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
84
85         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
86         https://bugs.webkit.org/show_bug.cgi?id=104909
87
88         Reviewed by Simon Hausmann.
89
90         To be able to build redistribuable binary packages, Qt's configure switches
91         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
92         dynamically link to optional system libraries.
93         QtWebKit is doing its own configure checks for those libraries, thus adding a
94         runtime dependency that might not be fulfilled if the packager's machine had
95         those libraries while the user's machine won't.
96
97         Since in most cases where WebKit will want to use those system libraries, Qt will
98         also be using them, remove these configure tests from WebKit.
99
100         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
101         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
102         * qmake/config.tests/libpng/libpng.cpp: Removed.
103         * qmake/config.tests/libpng/libpng.pro: Removed.
104         * qmake/mkspecs/features/features.prf:
105
106 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
107
108         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
109         https://bugs.webkit.org/show_bug.cgi?id=106574
110
111         Reviewed by Laszlo Gombos.
112
113         Rely on a more recent stable release, which includes support for
114         Lua 5.2 in Edje and other assorted minor fixes.
115
116         While here, also use the "configure" script to build the libraries
117         instead of relying on autogen.sh, which is not really needed with
118         a release tarball and may have problems with automake 1.13.
119
120         * efl/jhbuild.modules:
121
122 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
123
124         Web Inspector: fix DRT to deliver simulated events to devtools front-end
125         https://bugs.webkit.org/show_bug.cgi?id=106650
126
127         Reviewed by Pavel Feldman.
128
129         Add separated m_devToolsTestInterfaces object to testShell which is
130         bind to devTools webview.
131
132         * DumpRenderTree/chromium/TestShell.cpp:
133         (TestShell::initialize):
134         (TestShell::createMainWindow):
135         (TestShell::~TestShell):
136         (TestShell::showDevTools):
137         (TestShell::resetTestController):
138         (TestShell::bindJSObjectsToWindow):
139         (TestShell::createNewWindow):
140         * DumpRenderTree/chromium/TestShell.h:
141         (TestShell):
142
143 2013-01-14  Alan Cutter  <alancutter@chromium.org>
144
145         Sheriffbot command aliases need test cases
146         https://bugs.webkit.org/show_bug.cgi?id=106754
147
148         Reviewed by Eric Seidel.
149
150         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
151         (SheriffBotTest.test_command_aliases):
152
153 2013-01-13  Alan Cutter  <alancutter@chromium.org>
154
155         Allow users to misspell the "sheriffs" command in sheriffbot
156         https://bugs.webkit.org/show_bug.cgi?id=106628
157
158         Reviewed by Steve Block.
159
160         * Scripts/webkitpy/tool/bot/irc_command.py:
161
162 2013-01-13  Alan Cutter  <alancutter@chromium.org>
163
164         Make "gardeners" an alias for "sheriffs" in sherrifbot
165         https://bugs.webkit.org/show_bug.cgi?id=106627
166
167         Reviewed by Eric Seidel.
168
169         * Scripts/webkitpy/tool/bot/irc_command.py:
170
171 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
172
173         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
174         https://bugs.webkit.org/show_bug.cgi?id=105380
175
176         Reviewed by Eric Seidel.
177
178         Fix a regression introduced in r137692 where we were double-encoding
179         the arguments to popen(); this was only an issue on windows, where
180         we would try to encode something to mbcs, then try to encode it
181         to unicode as if the input as ascii.
182
183         * Scripts/webkitpy/common/system/executive.py:
184         (Executive.run_command):
185
186 2013-01-13  Alan Cutter  <alancutter@chromium.org>
187
188         State who told sheriffbot to roll the Chromium deps and to what revision
189         https://bugs.webkit.org/show_bug.cgi?id=106626
190
191         Reviewed by Eric Seidel.
192
193         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
194
195         * Scripts/webkitpy/tool/bot/irc_command.py:
196         (RollChromiumDEPS._expand_irc_nickname):
197         (RollChromiumDEPS.execute):
198         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
199         (IRCCommandTest.test_roll_chromium_deps):
200         * Scripts/webkitpy/tool/bot/sheriff.py:
201         (Sheriff.post_chromium_deps_roll):
202         * Scripts/webkitpy/tool/commands/roll.py:
203         (RollChromiumDEPS._prepare_state):
204         (PostChromiumDEPSRoll):
205         (PostChromiumDEPSRoll._prepare_state):
206         * Scripts/webkitpy/tool/commands/roll_unittest.py:
207         (PostRollCommandsTest.test_prepare_state):
208         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
209         (PrepareChangeLogForDEPSRoll.run):
210
211 2013-01-13  Alan Cutter  <alancutter@chromium.org>
212
213         Add Alan Cutter as contributor
214         https://bugs.webkit.org/show_bug.cgi?id=106747
215
216         Reviewed by Eric Seidel.
217
218         * Scripts/webkitpy/common/config/committers.py:
219
220 2013-01-13  Jonathan Liu  <net147@gmail.com>
221
222         Fix CONFIG missing link_pkgconfig on Windows
223         https://bugs.webkit.org/show_bug.cgi?id=106647
224
225         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
226         properly on Windows because they are added to PKGCONFIG but
227         CONFIG does not contain link_pkgconfig.
228
229         This is because link_pkgconfig is added in unix/default_pre.prf
230         which is only used for UNIX platforms. To fix this, move it to
231         the general default_pre.prf.
232
233         Reviewed by Simon Hausmann.
234
235         * qmake/mkspecs/features/default_pre.prf:
236         * qmake/mkspecs/features/unix/default_pre.prf:
237
238 2013-01-12  Nico Weber  <thakis@chromium.org>
239
240         nrwt/chromium: Don't prefer chromium over webkit build directories
241         https://bugs.webkit.org/show_bug.cgi?id=105597
242
243         Reviewed by Dirk Pranke.
244
245         Rely on the new timestamp logic instead. Requested by dpranke in
246         https://bugs.webkit.org/show_bug.cgi?id=105498
247
248         * Scripts/webkitpy/layout_tests/port/chromium.py:
249         (ChromiumPort._static_build_path):
250         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
251         (ChromiumLinuxPortTest.test_build_path):
252         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
253         (ChromiumMacPortTest.test_build_path):
254         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
255         (ChromiumWinTest.test_build_path):
256
257 2013-01-12  Nico Weber  <thakis@chromium.org>
258
259         Use ninja by default on Linux for build-webkit --chromium, bot edition
260         https://bugs.webkit.org/show_bug.cgi?id=104434
261
262         Reviewed by Eric Seidel.
263
264         r139557 changed update-webkit to pick ninja by default on linux, but
265         the bots run update-webkit-chromium directly so they didn't see this.
266         Move the default for ninja into update-webkit-chromium so that it's
267         picked up by the bots, and let update-webkit forward non-default
268         options to there.
269
270         This way, the default is in one place only and both developers (who
271         usually use update-webkit which then shells out to
272         updat-webkit-chromium) and bots (which use update-webkit-chromium
273         directly) see the same behavior.
274
275         * Scripts/update-webkit:
276         * Scripts/update-webkit-chromium:
277
278 2013-01-12  Nico Weber  <thakis@chromium.org>
279
280         Make ninja the default build system on Linux for build-webkit --chromium
281         https://bugs.webkit.org/show_bug.cgi?id=104434
282
283         Reviewed by Eric Seidel.
284
285         * Scripts/update-webkit:
286
287 2013-01-12  Alan Cutter  <alancutter@chromium.org>
288
289         Migrate the remaining bots in EC2 to Google Compute Engine
290         https://bugs.webkit.org/show_bug.cgi?id=106005
291
292         Reviewed by Eric Seidel.
293
294         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
295
296         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
297         * EWSTools/boot.sh:
298         * EWSTools/build-repo.sh:
299         * EWSTools/start-queue.sh:
300
301 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
302
303         [chromium] move inspector related methods to TestRunner library
304         https://bugs.webkit.org/show_bug.cgi?id=106654
305
306         Reviewed by Adam Barth.
307
308         * DumpRenderTree/chromium/DRTTestRunner.cpp:
309         (DRTTestRunner::DRTTestRunner):
310         * DumpRenderTree/chromium/DRTTestRunner.h:
311         (DRTTestRunner):
312         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
313         (WebTestRunner::WebTestDelegate::showDevTools):
314         (WebTestRunner::WebTestDelegate::closeDevTools):
315         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
316         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
317         (WebTestRunner::TestRunner::TestRunner):
318         (WebTestRunner::TestRunner::showWebInspector):
319         (WebTestRunner):
320         (WebTestRunner::TestRunner::closeWebInspector):
321         (WebTestRunner::TestRunner::evaluateInWebInspector):
322         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
323         (TestRunner):
324         * DumpRenderTree/chromium/WebViewHost.cpp:
325         (WebViewHost::showDevTools):
326         (WebViewHost::closeDevTools):
327         (WebViewHost::evaluateInWebInspector):
328         * DumpRenderTree/chromium/WebViewHost.h:
329         (WebViewHost):
330
331 2013-01-11  Julie Parent  <jparent@chromium.org>
332
333         Builder should not be a valid parameter for stats dashboard
334         https://bugs.webkit.org/show_bug.cgi?id=106698
335
336         Reviewed by Dirk Pranke.
337         
338         Since builder is a dashboard specific parameter, dashboard_base
339         should not be handling it in handleValidHashParameterWrapper, rather,
340         each specific dashboard should in its handleValidHashParameter function.
341     
342         Note that the FIXME in dashboard_base about this was actually wrong -
343         we don't want to move it to g_crossDashboardState, because it isn't
344         actually cross dashboard state.
345         
346         In fact, flakiness and treemap have the code in 
347         handleValidHashParameter, but it is currently dead code because 
348         dashboard_base gets to it first.
349         
350         Added the proper handling to timeline_explorer, since builder is
351         valid there.
352
353         * TestResultServer/static-dashboards/dashboard_base.js:
354         * TestResultServer/static-dashboards/timeline_explorer.html:
355
356 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
357
358         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
359         https://bugs.webkit.org/show_bug.cgi?id=106688
360
361         Reviewed by Eric Seidel.
362
363         Update the regular expression used to strip the garbage at the beginning.
364
365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
366         (RunWebKitTests.nrwt_log_message_regexp):
367
368 2013-01-11  Pratik Solanki  <psolanki@apple.com>
369
370         TestRunner leaks when running tests
371         https://bugs.webkit.org/show_bug.cgi?id=106683
372
373         Reviewed by Simon Fraser.
374
375         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
376         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
377         tests.
378
379         * DumpRenderTree/TestRunner.cpp:
380         (TestRunner::makeWindowObject):
381
382 2013-01-11  Julie Parent  <jparent@chromium.org>
383
384         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
385         https://bugs.webkit.org/show_bug.cgi?id=106247
386
387         Old code nulled out the loader instance when it completed loading and
388         then later used the fact that it was null to determine if it had loaded
389         or not.  This is not only unintuitive, but it also prevents using the
390         loader object later on.
391         
392         Added new method, used it, added unit test for it.
393         
394         Reviewed by Dirk Pranke.
395
396         * TestResultServer/static-dashboards/dashboard_base.js:
397         (resourceLoadingComplete):
398         (handleLocationChange):
399         * TestResultServer/static-dashboards/loader.js:
400         (.):
401         * TestResultServer/static-dashboards/loader_unittests.js:
402
403 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
404
405         Try CRLF to LF change in r139407 again.
406
407         * BuildSlaveSupport/delete-stale-build-files:
408         (main):
409         (webkitBuildDirectory):
410         * BuildSlaveSupport/kill-old-processes:
411         (main):
412
413 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
414
415         [GTK] Disable the unit tests timeout when running from make check
416         https://bugs.webkit.org/show_bug.cgi?id=106670
417
418         Reviewed by Philippe Normand.
419
420         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
421
422 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
423
424         Yet another unreviewed fix after r139431.
425
426         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
427         the correct order.
428
429 2013-01-11  Dan Carney  <dcarney@google.com>
430
431         [chromium] move some whitespace and resize related methods to TestRunner library
432         https://bugs.webkit.org/show_bug.cgi?id=106655
433
434         Reviewed by Jochen Eisinger.
435
436         * DumpRenderTree/chromium/DRTTestRunner.cpp:
437         (DRTTestRunner::DRTTestRunner):
438         * DumpRenderTree/chromium/DRTTestRunner.h:
439         (DRTTestRunner):
440         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
441         (WebKit):
442         (WebTestRunner::WebTestDelegate::setClientWindowRect):
443         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
444         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
445         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
446         (WebTestRunner::TestRunner::TestRunner):
447         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
448         (WebTestRunner):
449         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
450         (WebTestRunner::TestRunner::enableAutoResizeMode):
451         (WebTestRunner::TestRunner::disableAutoResizeMode):
452         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
453         (TestRunner):
454         * DumpRenderTree/chromium/WebViewHost.cpp:
455         (WebViewHost::setClientWindowRect):
456         * DumpRenderTree/chromium/WebViewHost.h:
457         (WebViewHost):
458
459 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
460
461         Unreviewed. Update my e-mail addresses.
462
463         * Scripts/webkitpy/common/config/committers.py:
464
465 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
466
467         Another unreviewed fix after r139431.
468
469         In a way, this is also a generic bug fix, since previously isEfl()
470         would fail when called from run-efl-tests and we thus did not use
471         jhbuild to run our tests. This now resulted in us calling
472         "jhbuild-wrapper run" without specifying a platform.
473
474         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
475         to work.
476
477 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
478
479         [Qt][WK1] Web Audio support
480         https://bugs.webkit.org/show_bug.cgi?id=106651
481
482         Reviewed by Jocelyn Turcotte.
483
484         Implements support for dumping audio data in DumpRenderTree.
485
486         Adds WebAudio to toggleable features in QtTestBrowser.
487
488         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
489         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
490
491         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
492         (WebCore::DumpRenderTree::dump):
493         * DumpRenderTree/qt/TestRunnerQt.cpp:
494         (TestRunner::reset):
495         (TestRunner::overridePreference):
496         (TestRunner::setAudioData):
497         * DumpRenderTree/qt/TestRunnerQt.h:
498         (TestRunner::shouldDumpAsAudio):
499         (TestRunner::audioData):
500         (TestRunner):
501         * QtTestBrowser/launcherwindow.cpp:
502         (LauncherWindow::applyPrefs):
503         (LauncherWindow::createChrome):
504         (LauncherWindow::toggleWebAudio):
505         * QtTestBrowser/launcherwindow.h:
506         (WindowOptions::WindowOptions):
507         (WindowOptions):
508         (LauncherWindow):
509         * qmake/mkspecs/features/features.prf:
510         * qmake/mkspecs/features/features.pri:
511
512 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
513
514         Unreviewed jhbuild-related fix after r139431.
515
516         * Scripts/webkitpy/layout_tests/port/efl.py:
517         (EflPort.__init__): Pass a string to set_option_default(), since
518         shlex.split() will be called on it later.
519
520 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
521
522         Unreviewed typo fixes after r139431.
523
524         * Scripts/run-javascriptcore-tests:
525
526 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
527
528         [jhbuild] Remove the "run-with-jhbuild" scripts.
529         https://bugs.webkit.org/show_bug.cgi?id=106572
530
531         Reviewed by Martin Robinson.
532
533         Both ports which use jhbuild were mostly duplicating the
534         `run-with-jhbuild' script in their own directories for no clear reason.
535
536         The script itself was just a thin wrapper around the `jhbuild-wrapper',
537         so just start using that directly and get rid of a useless middle man.
538
539         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
540         instead.
541
542         * Scripts/run-javascriptcore-tests:
543         * Scripts/run-launcher:
544         * Scripts/webkitdirs.pm:
545         (runAutogenForAutotoolsProjectIfNecessary):
546         (buildAutotoolsProject):
547         (jhbuildWrapperPrefixIfNeeded):
548         (generateBuildSystemFromCMakeProject):
549         (buildCMakeGeneratedProject):
550         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
551         (run):
552         * Scripts/webkitpy/layout_tests/port/efl.py:
553         (EflPort.__init__):
554         (EflPort._image_diff_command):
555         * efl/run-with-jhbuild: Removed.
556         * gtk/run-with-jhbuild: Removed.
557
558 2013-01-11  Alan Cutter  <alancutter@chromium.org>
559
560         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
561         https://bugs.webkit.org/show_bug.cgi?id=106636
562
563         Reviewed by Adam Barth.
564
565         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
566
567         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
568         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
569         * EWSTools/screen-config:
570         * EWSTools/start-queue.sh:
571
572 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
573
574         kill-old-processes and delete-stale-build-files use CRLF linebreaks
575         https://bugs.webkit.org/show_bug.cgi?id=106622
576
577         Reviewed by Simon Fraser.
578
579         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
580         Also escape clang\+\+ correctly in kill-old-processes.
581
582         * BuildSlaveSupport/delete-stale-build-files:
583         * BuildSlaveSupport/kill-old-processes:
584
585 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
586
587         Build fix after r139357. It was missing a comma.
588
589         * QueueStatusServer/model/queues.py:
590         (Queue):
591
592 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
593
594         Fixing AuthenticationError when running test-webkitpy as a non-committer.
595         https://bugs.webkit.org/show_bug.cgi?id=106420
596
597         Reviewed by Eric Seidel.
598
599         * Scripts/webkitpy/common/checkout/scm/git.py:
600         (Git.push_local_commits_to_server):
601         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
602         * Scripts/webkitpy/common/checkout/scm/svn.py:
603         (SVNRepository):
604         (SVNRepository.has_authorization_for_realm):
605
606 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
607
608         [EFL][jhbuild] Use tarballs for gstreamer instead of git
609         https://bugs.webkit.org/show_bug.cgi?id=106552
610
611         Reviewed by Laszlo Gombos.
612
613         Use tarballs for gstreamer instead of git in EFL's jhbuild
614         to work around intermittent network issues on our build
615         bots. Tarballs are fully cached and require no network
616         operation if their checksum matches.
617
618         * efl/jhbuild.modules:
619
620 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
621
622         Add Mac WK2 EWS bots
623         https://bugs.webkit.org/show_bug.cgi?id=106590
624
625         Reviewed by Adam Barth.
626
627         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
628         Also add a deprecated MacWK2Port class.
629
630         * QueueStatusServer/model/queues.py:
631         (Queue):
632         * Scripts/webkitpy/common/config/ports.py:
633         (DeprecatedPort.port):
634         (MacWK2Port):
635         (MacWK2Port.run_webkit_tests_command):
636         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
637         (MacEWS):
638         (MacWK2EWS):
639         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
640         (_test_ewses):
641
642 2013-01-10  Dan Carney  <dcarney@google.com>
643
644         [chromium] move webpermissionclient related methods to TestRunner library
645         https://bugs.webkit.org/show_bug.cgi?id=106548
646
647         Reviewed by Jochen Eisinger.
648
649         * DumpRenderTree/DumpRenderTree.gypi:
650         * DumpRenderTree/chromium/DRTTestRunner.cpp:
651         (DRTTestRunner::DRTTestRunner):
652         (DRTTestRunner::reset):
653         * DumpRenderTree/chromium/DRTTestRunner.h:
654         (DRTTestRunner):
655         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
656         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
657         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
658         (WebKit):
659         (WebTestRunner::WebTestRunner::webPermissions):
660         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
661         (WebTestRunner::TestRunner::TestRunner):
662         (WebTestRunner::TestRunner::setDelegate):
663         (WebTestRunner):
664         (WebTestRunner::TestRunner::reset):
665         (WebTestRunner::TestRunner::webPermissions):
666         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
667         (WebTestRunner::TestRunner::setImagesAllowed):
668         (WebTestRunner::TestRunner::setScriptsAllowed):
669         (WebTestRunner::TestRunner::setStorageAllowed):
670         (WebTestRunner::TestRunner::setPluginsAllowed):
671         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
672         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
673         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
674         (WebTestRunner):
675         (TestRunner):
676         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
677         (WebTestRunner):
678         (WebTestRunner::WebPermissions::WebPermissions):
679         (WebTestRunner::WebPermissions::~WebPermissions):
680         (WebTestRunner::WebPermissions::allowImage):
681         (WebTestRunner::WebPermissions::allowScriptFromSource):
682         (WebTestRunner::WebPermissions::allowStorage):
683         (WebTestRunner::WebPermissions::allowPlugins):
684         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
685         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
686         (WebTestRunner::WebPermissions::setImagesAllowed):
687         (WebTestRunner::WebPermissions::setScriptsAllowed):
688         (WebTestRunner::WebPermissions::setStorageAllowed):
689         (WebTestRunner::WebPermissions::setPluginsAllowed):
690         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
691         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
692         (WebTestRunner::WebPermissions::setDelegate):
693         (WebTestRunner::WebPermissions::setDumpCallbacks):
694         (WebTestRunner::WebPermissions::reset):
695         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
696         (WebTestRunner):
697         (WebPermissions):
698         * DumpRenderTree/chromium/TestShell.cpp:
699         (TestShell::initialize):
700         (TestShell::resetTestController):
701         (TestShell::createNewWindow):
702         * DumpRenderTree/chromium/TestShell.h:
703         (TestShell):
704         * DumpRenderTree/chromium/WebViewHost.cpp:
705         (WebViewHost::normalizeLayoutTestURL):
706         * DumpRenderTree/chromium/WebViewHost.h:
707         (WebViewHost):
708
709 2013-01-10  Alan Cutter  <alancutter@chromium.org>
710
711         Split EWS tool cold-boot.sh into modular components
712         https://bugs.webkit.org/show_bug.cgi?id=106527
713
714         Reviewed by Adam Barth.
715
716         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
717         Updated GCE bot build scripts to match.
718         Unable to test scripts directly as they depend on being in the repository to work!
719
720         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
721         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
722         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
723         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
724         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
725
726 2013-01-10  Julie Parent  <jparent@chromium.org>
727
728         Dashboard Cleanup: Do not generate the page if we are about to reload.
729         https://bugs.webkit.org/show_bug.cgi?id=106584
730
731         Reviewed by Dirk Pranke.
732
733         Move the logic to determine if we should generate the page into
734         parseParameters() since that is where we have the knowledge to
735         determine it, and return that value to handleLocationChange, 
736         rather than passing the changed parameters back to handleLocationChange
737         and having it make the decision.
738         
739         This is logically equivalent, save one case: when we are about to do
740         a reload, we know that there is no reason to generate the page.  Old
741         code was causing an extra page generation in this case.
742         
743         * TestResultServer/static-dashboards/dashboard_base.js:
744         (parseParameters):
745         (handleLocationChange):
746
747 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
748
749         [jhbuild] Use the "configure" script to build glib
750         https://bugs.webkit.org/show_bug.cgi?id=106569
751
752         Reviewed by Martin Robinson.
753
754         So far both EFL and GTK have been using autogen.sh to build glib.
755         While that does work most of the time, it's not really needed since
756         we are downloading and building stable releases from tarballs.
757         Additionally, autogen.sh fails to work with automake 1.13 due to the
758         usage of some macros that have been removed (this has already been
759         fixed in glib master).
760
761         * efl/jhbuild.modules:
762         * gtk/jhbuild.modules:
763
764 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
765
766         Changing tests to be consistent and use self.scm rather then recreating the scm object.
767         (Missed a couple)
768         https://bugs.webkit.org/show_bug.cgi?id=106536
769
770         Reviewed by Eric Seidel.
771
772         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
773
774 2013-01-10  Tony Chang  <tony@chromium.org>
775
776         Speed up supplemental dependency computation
777         https://bugs.webkit.org/show_bug.cgi?id=106503
778
779         Reviewed by Adam Barth.
780
781         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
782
783         * WebKitTestRunner/CMakeLists.txt:
784
785 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
786
787         Remove the ENABLE_ANIMATION_API feature define occurences
788         https://bugs.webkit.org/show_bug.cgi?id=106544
789
790         Reviewed by Simon Fraser.
791
792         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
793         feature define handling still lingers in various build systems and configurations
794         but is of no use, so it should be removed.
795
796         * Scripts/webkitperl/FeatureList.pm:
797         * qmake/mkspecs/features/features.pri:
798
799 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
800
801         [GTK] Add support for loading web process extensions
802         https://bugs.webkit.org/show_bug.cgi?id=105631
803
804         Reviewed by Gustavo Noronha Silva.
805
806         * MiniBrowser/gtk/GNUmakefile.am:
807         * MiniBrowser/gtk/main.c:
808         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
809         bundle lib from build dir.
810         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
811         located in WebProcess/InjectedBundle/API/gtk.
812         * gtk/generate-gtkdoc:
813         (get_webkit2_options): Scan also files in
814         WebProcess/InjectedBundle/API/gtk to generate API docs.
815         (get_webkit2_options.injected_bundle_src_path): Helper function to
816         build paths in WebProcess/InjectedBundle/API/gtk.
817
818 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
819
820         [EFL][WK2] Writing immediately to created windows (open) fails
821         https://bugs.webkit.org/show_bug.cgi?id=105276
822
823         Reviewed by Kenneth Rohde Christiansen.
824
825         Do not reset 'about:blank' url for the new pages in mini browser.
826
827         * MiniBrowser/efl/main.c:
828         (window_create):
829
830 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
831
832         Changing tests to be consistent and use self.scm rather then recreating the scm object.
833         https://bugs.webkit.org/show_bug.cgi?id=106536
834
835         Reviewed by Eric Seidel.
836
837         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
838
839 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
840
841         Converting to unittest2 so we can use assertItemsEqual, making tests
842         not dependent on order of items.
843         https://bugs.webkit.org/show_bug.cgi?id=106532
844
845         Before:
846         Ran 1733 tests in 38.385s
847         FAILED (failures=1, errors=22)
848
849         After:
850         Ran 1733 tests in 32.298s
851         FAILED (failures=0, errors=22)
852
853         Reviewed by Eric Seidel.
854
855         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
856         * Scripts/webkitpy/thirdparty/__init__.py:
857         (AutoinstallImportHook._install_unittest2):
858
859 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
860
861         [EFL] Add gstreamer 1.0.5 to jhbuild
862         https://bugs.webkit.org/show_bug.cgi?id=106178
863
864         Reviewed by Laszlo Gombos.
865
866         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
867
868         * efl/jhbuild.modules:
869
870 2013-01-09  Alan Cutter  <alancutter@chromium.org>
871
872         Updated parameters in GCE build scripts so they now work.
873         https://bugs.webkit.org/show_bug.cgi?id=106523
874
875         Reviewed by Adam Barth.
876
877         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
878         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
879         * EWSTools/cold-boot.sh:
880
881 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
882
883         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
884         https://bugs.webkit.org/show_bug.cgi?id=106520
885
886         Reviewed by James Robinson.
887
888         Part of a larger refactoring series. See tracking bug 82948.
889
890         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
891         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
892
893 2013-01-09  Julie Parent  <jparent@chromium.org>
894
895         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
896         https://bugs.webkit.org/show_bug.cgi?id=106514
897
898         This is old code, as these can no longer get out of sync.
899         permmaLinkURLHash is generated from currentState, which is set only
900         from the location.  The commment about how these can get out of sync
901         refers to a function that no longer exists.
902         
903         Reviewed by Dirk Pranke.
904
905         * TestResultServer/static-dashboards/dashboard_base.js:
906         (handleLocationChange):
907
908 2013-01-09  Julie Parent  <jparent@chromium.org>
909
910         Dashboard Cleanup: Reload the page as soon as we know we need to.
911         https://bugs.webkit.org/show_bug.cgi?id=106515
912
913         No need to continue parsing all of the data once we know that
914         we need to do a reload.
915         
916         Reviewed by Dirk Pranke.
917
918         * TestResultServer/static-dashboards/dashboard_base.js:
919         (parseParameters):
920
921 2013-01-09  Eric Seidel  <eric@webkit.org>
922
923         run-perf-tests --chromium-android --profile should show symbols for the kernel
924         https://bugs.webkit.org/show_bug.cgi?id=106498
925
926         Reviewed by Adam Barth.
927
928         Turns out this was easy, once I finally read the output from "perf report".
929         It appears there may be a bug in "perf record" on android, as it complains
930         about not being able to read from /proc/kallsyms even when
931         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
932         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
933         but rather just flip it to 0 long enough to grab the /proc/kallsyms
934         and then flip it back to whatever the device had.
935
936         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
937         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
938         to symbol names.  Its world-readable, but will return all 0s if you
939         don't have permission to see the kernel symbols.  kptr_restrict
940         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
941         1 is only a specific group, and 2 is "no one, not even root".
942         By default kptr_restrict is 2 on Android it seems.
943         More kptr_restrict docs: http://lwn.net/Articles/420403/
944
945         I also took this opportunity to clean up how the perf record command
946         was built for use/display in AndroidPerf.profile_after_exit and
947         change to always using long-form names for the arguments (to hopefully help readability).
948
949         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
950         (AndroidPerf.__init__):
951         (profile_after_exit):
952         (ChromiumAndroidDriver.__init__):
953         (ChromiumAndroidDriver._update_kallsyms_cache):
954         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
955
956 2013-01-09  Julie Parent  <jparent@chromium.org>
957
958         Dashboard cleanup: remove dead code.
959         https://bugs.webkit.org/show_bug.cgi?id=106509
960
961         Reviewed by Dirk Pranke.
962
963         * TestResultServer/static-dashboards/dashboard_base.js:
964         (parseParameters):
965
966 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
967
968         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
969         https://bugs.webkit.org/show_bug.cgi?id=105638
970
971         Reviewed by Martin Robinson.
972
973         The test was failing for two reasons:
974         - AccessibilityRenderObject::correspondingLabelForControlElement() was
975           not ignoring the ARIA labelled-by property
976         - AccessibilityController::accessibleElementById() was not implemented
977
978         Because getting an element by ID cannot be done in the UIProcess, the
979         decision was made to expose the element's ID as an accessible attribute
980         of the object.
981
982         In addition, fixing the bug in AccessibilityRenderObject made it possible
983         to eliminate the Gtk platform-specific expectations for another test.
984
985         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
986         (childElementById): Added. Walks the tree looking for the AtkObject
987         Attribute which exposes the HTML element's ID.
988         (AccessibilityController::accessibleElementById): Implemented.
989         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
990         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
991         when there is no title, as is done with the Mac port.
992         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
993         (WTR):
994         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
995         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
996         Attribute which exposes the HTML element's ID.
997         (WTR):
998         (WTR::AccessibilityController::accessibleElementById): Implemented.
999         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1000         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1001         even when there is no title, as is done with the Mac port.
1002
1003 2013-01-09  Gregg Tavares  <gman@google.com>
1004
1005         Add Gregg Tavares as a committer
1006         https://bugs.webkit.org/show_bug.cgi?id=106492
1007
1008         Unreviewed.
1009
1010         * Scripts/webkitpy/common/config/committers.py:
1011
1012 2013-01-09  Roger Fong  <roger_fong@apple.com>
1013
1014         Enable seamless iFrames for Windows DRT.
1015         https://bugs.webkit.org/show_bug.cgi?id=106468.
1016
1017         Rubberstamped by Timothy Horton.
1018
1019         * DumpRenderTree/win/DumpRenderTree.cpp:
1020         (resetDefaultsToConsistentValues):
1021
1022 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1023
1024         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1025         https://bugs.webkit.org/show_bug.cgi?id=93979
1026
1027         Reviewed by Benjamin Poulain.
1028
1029         Implement eventSender.scheduleAsynchronousKeyDown() in
1030         WebKitTestRunner.
1031
1032         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1033         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1034         (WTR::createKeyDownMessageBody):
1035         (WTR::EventSendingController::keyDown):
1036         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1037         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1038         (EventSendingController):
1039         * WebKitTestRunner/TestController.cpp:
1040         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1041         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1042         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1043         * WebKitTestRunner/TestController.h:
1044         (TestController):
1045
1046 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1047
1048         [chromium] move resource load callback dumping to TestRunner library
1049         https://bugs.webkit.org/show_bug.cgi?id=106449
1050
1051         Reviewed by Adam Barth.
1052
1053         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1054         (DRTTestRunner::DRTTestRunner):
1055         (DRTTestRunner::reset):
1056         * DumpRenderTree/chromium/DRTTestRunner.h:
1057         (DRTTestRunner):
1058         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1059         (WebKit):
1060         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1061         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1062         (WebKit):
1063         (WebTestProxyBase):
1064         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1065         (WebTestRunner::WebTestProxy::willRequestResource):
1066         (WebTestRunner::WebTestProxy::willSendRequest):
1067         (WebTestRunner::WebTestProxy::didReceiveResponse):
1068         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1069         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1070         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1071         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1072         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1073         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1074         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1075         (WebTestRunner::TestRunner::TestRunner):
1076         (WebTestRunner::TestRunner::reset):
1077         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1078         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1079         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1080         (WebTestRunner):
1081         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1082         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1083         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1084         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1085         (TestRunner):
1086         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1087         (WebTestRunner::WebTestProxyBase::reset):
1088         (WebTestRunner):
1089         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1090         (WebTestRunner::WebTestProxyBase::willRequestResource):
1091         (WebTestRunner::WebTestProxyBase::willSendRequest):
1092         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1093         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1094         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1095         * DumpRenderTree/chromium/WebViewHost.cpp:
1096         (WebViewHost::willSendRequest):
1097         (WebViewHost::makeURLErrorDescription):
1098         (WebViewHost::reset):
1099         * DumpRenderTree/chromium/WebViewHost.h:
1100         (WebViewHost):
1101
1102 2013-01-09  Dan Carney  <dcarney@google.com>
1103
1104         [chromium] move dumpcreateview methods to testrunner library
1105         https://bugs.webkit.org/show_bug.cgi?id=106434
1106
1107         Reviewed by Adam Barth.
1108
1109         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1110         (DRTTestRunner::DRTTestRunner):
1111         (DRTTestRunner::reset):
1112         * DumpRenderTree/chromium/DRTTestRunner.h:
1113         (DRTTestRunner):
1114         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1115         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1116         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1117         (WebTestRunner::TestRunner::TestRunner):
1118         (WebTestRunner::TestRunner::reset):
1119         (WebTestRunner::TestRunner::shouldDumpCreateView):
1120         (WebTestRunner):
1121         (WebTestRunner::TestRunner::dumpCreateView):
1122         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1123         (TestRunner):
1124
1125 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1126
1127         webkitpy cleanup: Merge additional_comment_text into comment_text
1128         https://bugs.webkit.org/show_bug.cgi?id=106421
1129
1130         Reviewed by Adam Barth.
1131
1132         * Scripts/webkitpy/common/config/committervalidator.py:
1133         (CommitterValidator.reject_patch_from_commit_queue):
1134         (CommitterValidator.reject_patch_from_review_queue):
1135         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1136         (Bugzilla.set_flag_on_attachment):
1137         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1138         (MockBugzilla.set_flag_on_attachment):
1139         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1140         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1141         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1142         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1143
1144 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1145
1146         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
1147         https://bugs.webkit.org/show_bug.cgi?id=106464
1148
1149         Reviewed by Martin Robinson.
1150
1151         Current version in jhbuild.modules (2.26.0) is giving trouble to
1152         when trying to build WebKitGTK from scratch, due to a segmentation
1153         fault error in gdk-pixbuf-query-loader during the 'make'
1154         phase. Raising the version to 2.26.5 fixes this issue.
1155
1156         * gtk/jhbuild.modules: Version raised, checksums updated.
1157
1158 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
1159
1160         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
1161         https://bugs.webkit.org/show_bug.cgi?id=90968.
1162
1163         Reviewed by Csaba Osztrogonác.
1164
1165         Added functionality in DRT and WTR to use any timeout value while running
1166         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
1167         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
1168         to indicate whether the current port supports setting timeout value
1169         per test (it's False by default; I enabled it only on Qt).
1170         Also corrected a typo in driver.py
1171
1172         * DumpRenderTree/DumpRenderTree.h:
1173         (TestCommand::TestCommand):
1174         (TestCommand):
1175         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1176         (parseInputLine):
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::DumpRenderTree::processLine):
1179         * Scripts/webkitpy/layout_tests/port/base.py:
1180         (Port.supports_per_test_timeout):
1181         * Scripts/webkitpy/layout_tests/port/driver.py:
1182         (Driver.run_test):
1183         (Driver._command_from_driver_input):
1184         * Scripts/webkitpy/layout_tests/port/qt.py:
1185         (QtPort.supports_per_test_timeout):
1186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1187         (WTR::InjectedBundle::InjectedBundle):
1188         (WTR::InjectedBundle::didReceiveMessage):
1189         (WTR::InjectedBundle::beginTesting):
1190         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1192         (WTR::TestRunner::setCustomTimeout):
1193         (WTR):
1194         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1195         (TestRunner):
1196         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
1197         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1198         * WebKitTestRunner/TestController.cpp:
1199         (WTR::TestController::TestController):
1200         (WTR::TestController::getCustomTimeout):
1201         (WTR):
1202         (WTR::TestCommand::TestCommand):
1203         (TestCommand):
1204         (WTR::parseInputLine):
1205         (WTR::TestController::runTest):
1206         (WTR::TestController::runUntil):
1207         * WebKitTestRunner/TestController.h:
1208         (TestController):
1209         * WebKitTestRunner/TestInvocation.cpp:
1210         (WTR::TestInvocation::TestInvocation):
1211         (WTR::TestInvocation::setCustomTimeout):
1212         (WTR):
1213         (WTR::TestInvocation::invoke):
1214         * WebKitTestRunner/TestInvocation.h:
1215         (TestInvocation):
1216
1217 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1218
1219         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
1220         https://bugs.webkit.org/show_bug.cgi?id=106290
1221
1222         Reviewed by Martin Robinson.
1223
1224         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
1225         the macro isn't enabled.
1226
1227         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1228
1229 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
1230
1231         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
1232         https://bugs.webkit.org/show_bug.cgi?id=103653
1233
1234         Reviewed by Anders Carlsson.
1235
1236         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
1237         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
1238         client callback.
1239
1240         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
1241         methods to the JavaScript API.
1242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1243         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
1244         (WTR::TestRunner::setAuthenticationUsername): Ditto.
1245         (WTR::TestRunner::setAuthenticationPassword): Ditto.
1246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1247         (TestRunner): Added new declarations for the above.
1248         * WebKitTestRunner/TestController.cpp:
1249         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
1250         callback.
1251         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
1252         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
1253         the authentication information passed from the InjectedBundle.
1254         * WebKitTestRunner/TestController.h:
1255         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
1256         to communicate with the TestController.
1257         (WTR::TestController::setAuthenticationUsername): Ditto.
1258         (WTR::TestController::setAuthenticationPassword): Ditto.
1259         (TestController):
1260         * WebKitTestRunner/TestInvocation.cpp:
1261         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
1262         information from the InjectedBundle.
1263         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
1264         text to the TestInvocation text output.
1265         * WebKitTestRunner/TestInvocation.h:
1266         (TestInvocation): Added declaration for new method.
1267
1268 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
1269
1270         Add myself as a watcher for Web Geolocation
1271
1272         Unreviewed.
1273
1274         * Scripts/webkitpy/common/config/watchlist:
1275
1276 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1277
1278         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
1279         https://bugs.webkit.org/show_bug.cgi?id=106364
1280
1281         Reviewed by Eric Seidel.
1282
1283         When the setup_test_run method is called on the subclasses of the base Port
1284         interface, the parent method should also be called via super(), despite the
1285         parent method not doing anything at the moment.
1286
1287         The according calls to super() are required in the ChromiumPort, EflPort
1288         and GtkPort implementations.
1289
1290         * Scripts/webkitpy/layout_tests/port/chromium.py:
1291         (ChromiumPort.setup_test_run):
1292         * Scripts/webkitpy/layout_tests/port/efl.py:
1293         (EflPort.setup_test_run):
1294         * Scripts/webkitpy/layout_tests/port/gtk.py:
1295         (GtkPort.setup_test_run):
1296
1297 2013-01-08  Julie Parent  <jparent@chromium.org>
1298
1299         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
1300         https://bugs.webkit.org/show_bug.cgi?id=106356
1301
1302         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
1303         dashboard_base, assigned by Loader, and used only by dashboard_base to
1304         create error messages.  Moved the variables to be privates on the Loader
1305         object, moved error message creation to _getLoadingErrorMessages on the
1306         Loader object, and now pass the errors back to dashboard base via the
1307         resourceLoadingComplete callback.
1308         
1309         Also removed the now unused clearError function, it was only being used
1310         by unit tests to clean up global state.
1311         
1312         Reviewed by Dirk Pranke.
1313
1314         * TestResultServer/static-dashboards/dashboard_base.js:
1315         (resourceLoadingComplete):
1316         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1317         * TestResultServer/static-dashboards/loader.js:
1318         (.):
1319         * TestResultServer/static-dashboards/loader_unittests.js:
1320
1321 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1322
1323         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
1324         https://bugs.webkit.org/show_bug.cgi?id=106354
1325
1326         Reviewed by Eric Seidel.
1327
1328         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
1329         instead of those two inheriting from it. Also add a mock object of the
1330         sanitizer that's used in unit tests.
1331
1332         * Scripts/webkitpy/layout_tests/port/efl.py:
1333         (EflPort):
1334         (EflPort.__init__):
1335         (EflPort.setup_test_run):
1336         (EflPort.clean_up_test_run):
1337         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
1338         importing order.
1339         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1340         * Scripts/webkitpy/layout_tests/port/gtk.py:
1341         (GtkPort):
1342         (GtkPort.__init__):
1343         (GtkPort.setup_test_run):
1344         (GtkPort.clean_up_test_run):
1345         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
1346         importing order.
1347         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1348         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
1349         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
1350         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
1351         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
1352         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
1353         (PulseAudioSanitizerMock.unload_pulseaudio_module):
1354         (PulseAudioSanitizerMock.restore_pulseaudio_module):
1355
1356 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
1357
1358         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
1359         https://bugs.webkit.org/show_bug.cgi?id=106324
1360
1361         Reviewed by Adam Barth.
1362
1363         Since the frame load callbacks are part of the WebFrameClient, the
1364         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
1365         methods.
1366
1367         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1368         (DRTTestRunner::DRTTestRunner):
1369         (DRTTestRunner::reset):
1370         * DumpRenderTree/chromium/DRTTestRunner.h:
1371         (DRTTestRunner):
1372         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1373         (WebTestInterfaces):
1374         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1375         (WebKit):
1376         (WebTestProxyBase):
1377         (WebTestRunner):
1378         (WebTestRunner::WebTestProxy::WebTestProxy):
1379         (WebTestProxy):
1380         (WebTestRunner::WebTestProxy::didInvalidateRect):
1381         (WebTestRunner::WebTestProxy::didScrollRect):
1382         (WebTestRunner::WebTestProxy::scheduleComposite):
1383         (WebTestRunner::WebTestProxy::scheduleAnimation):
1384         (WebTestRunner::WebTestProxy::setWindowRect):
1385         (WebTestRunner::WebTestProxy::show):
1386         (WebTestRunner::WebTestProxy::didAutoResize):
1387         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
1388         (WebTestRunner::WebTestProxy::startDragging):
1389         (WebTestRunner::WebTestProxy::shouldBeginEditing):
1390         (WebTestRunner::WebTestProxy::shouldEndEditing):
1391         (WebTestRunner::WebTestProxy::shouldInsertNode):
1392         (WebTestRunner::WebTestProxy::shouldInsertText):
1393         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
1394         (WebTestRunner::WebTestProxy::shouldDeleteRange):
1395         (WebTestRunner::WebTestProxy::shouldApplyStyle):
1396         (WebTestRunner::WebTestProxy::didBeginEditing):
1397         (WebTestRunner::WebTestProxy::didChangeSelection):
1398         (WebTestRunner::WebTestProxy::didChangeContents):
1399         (WebTestRunner::WebTestProxy::didEndEditing):
1400         (WebTestRunner::WebTestProxy::registerIntentService):
1401         (WebTestRunner::WebTestProxy::dispatchIntent):
1402         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
1403         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
1404         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
1405         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
1406         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
1407         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
1408         (WebTestRunner::WebTestProxy::didReceiveTitle):
1409         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
1410         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
1411         (WebTestRunner::WebTestProxy::didFailLoad):
1412         (WebTestRunner::WebTestProxy::didFinishLoad):
1413         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1414         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1415         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1416         (WebTestRunner::WebTestProxy::didDetectXSS):
1417         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1418         (WebTestRunner::WebTestRunner::setTestIsRunning):
1419         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1420         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1421         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1422         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1423         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1424         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1425         (WebTestRunner::TestRunner::TestRunner):
1426         (WebTestRunner::TestRunner::reset):
1427         (WebTestRunner::TestRunner::setTestIsRunning):
1428         (WebTestRunner):
1429         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1430         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1431         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1432         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1433         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1434         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1435         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1436         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1437         (WebTestRunner::TestRunner::dumpTitleChanges):
1438         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1439         (TestRunner):
1440         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1441         (WebTestInterfaces::Internal):
1442         (WebTestRunner::WebTestInterfaces::Internal::webView):
1443         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1444         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1445         (WebTestRunner):
1446         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1447         (WebTestRunner::WebTestInterfaces::setWebView):
1448         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1449         (WebTestRunner::WebTestInterfaces::webView):
1450         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1451         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1452         (WebTestRunner):
1453         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1454         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1455         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1456         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1457         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1458         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1459         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1460         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1461         (WebTestRunner::WebTestProxyBase::didFailLoad):
1462         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1463         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1464         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1465         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1466         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1467         * DumpRenderTree/chromium/TestShell.cpp:
1468         (TestShell::runFileTest):
1469         (TestShell::testFinished):
1470         * DumpRenderTree/chromium/TestShell.h:
1471         (TestShell):
1472         * DumpRenderTree/chromium/WebViewHost.cpp:
1473         (WebViewHost::didStartProvisionalLoad):
1474         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1475         (WebViewHost::didFailProvisionalLoad):
1476         (WebViewHost::didCommitProvisionalLoad):
1477         (WebViewHost::didReceiveTitle):
1478         (WebViewHost::didFailLoad):
1479         (WebViewHost::didFinishLoad):
1480         * DumpRenderTree/chromium/WebViewHost.h:
1481         (WebViewHost):
1482
1483 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1484
1485         [GTK] Lower the default timeout value for WebKitTestRunner
1486         https://bugs.webkit.org/show_bug.cgi?id=106353
1487
1488         Reviewed by Dirk Pranke.
1489
1490         The default timeout value for WebKitTestRunner should be lowered.
1491         The current value (80 seconds) is irrational and just leads to producing
1492         text failures for layout tests that genuinely time out. This just leads
1493         to more deviation from the GTK WK1 port in terms of test expectations.
1494
1495         The value used is the same as when running the DumpRenderTree, that's
1496         6 seconds in release builds and 12 seconds in debug builds.
1497
1498         * Scripts/webkitpy/layout_tests/port/gtk.py:
1499         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1500         (GtkPortTest.test_default_timeout_ms):
1501
1502 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1503
1504         test-webkitpy shows failure output on my linux box
1505         https://bugs.webkit.org/show_bug.cgi?id=101261
1506
1507         Reviewed by Eric Seidel.
1508
1509         Mock out the PulseAudioSanitizer methods when creating testing instances
1510         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1511         PulseAudio output when the sanitizer was trying to unload modules which
1512         were already unloaded by another unit test that was being run in parallel.
1513
1514         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1515         (EflPortTest):
1516         (EflPortTest.make_port):
1517         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1518         (GtkPortTest):
1519         (GtkPortTest.make_port):
1520
1521 2013-01-08  Julie Parent  <jparent@chromium.org>
1522
1523         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1524         https://bugs.webkit.org/show_bug.cgi?id=106254
1525
1526         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1527         only to figure out if we should call addBuilderLoadErrors during
1528         handleLocationChange, which was called when the loader completed and on
1529         any hash change, but we only ever wanted to call addBuilderLoadErrors
1530         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1531         resourceLoadingComplete rather than handleLocationChange, so now we
1532         only call it when we want to, and the check can go away completely.
1533
1534         Reviewed by Dirk Pranke.
1535
1536         * TestResultServer/static-dashboards/dashboard_base.js:
1537         (addBuilderLoadErrors):
1538         (resourceLoadingComplete):
1539         (handleLocationChange):
1540         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1541
1542 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1543
1544         Add aboxhall@chromium.org to accessibility watchlist.
1545
1546         Unreviewed.
1547
1548         * Scripts/webkitpy/common/config/watchlist:
1549
1550 2013-01-08  Dan Winship  <danw@gnome.org>
1551
1552         Add Apache 2.4 support for Fedora 18
1553         https://bugs.webkit.org/show_bug.cgi?id=104478
1554
1555         Reviewed by Martin Robinson.
1556
1557         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1558         need a separate config.
1559
1560         * Scripts/webkitpy/layout_tests/port/base.py:
1561         (Port._apache_version):
1562         (Port._apache_config_file_name_for_platform):
1563         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1564         * Scripts/run-webkit-httpd:
1565         * Scripts/webkitperl/httpd.pm:
1566         (getApacheVersion):
1567         (getDefaultConfigForTestDirectory):
1568         (getHTTPDConfigPathForTestDirectory):
1569
1570 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1571
1572         Make the override-feature-defines script compatible with Python v3
1573         https://bugs.webkit.org/show_bug.cgi?id=105742
1574
1575         Reviewed by Martin Robinson.
1576
1577         Instead of printing output through a statement, use the print function and format
1578         the output using the str.format method. This makes the script runnable with Python v3.
1579
1580         * gtk/override-feature-defines:
1581         (adjust_feature_defines_makefile):
1582
1583 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1584
1585         [Qt] Fix libxml2 config test
1586         https://bugs.webkit.org/show_bug.cgi?id=106317
1587
1588         Reviewed by Simon Hausmann.
1589
1590         Don't assume standard include/libxml2, libxml-2.0.pc should know
1591         where it's headers are.
1592
1593         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1594
1595 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1596
1597         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1598         https://bugs.webkit.org/show_bug.cgi?id=106195
1599
1600         Reviewed by Philippe Normand.
1601
1602         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1603         to make the Python code compatible with Python 3. This includes modifying
1604         print statements, exception handling, dictionary iteration and
1605         byte-sequence-to-string conversion.
1606
1607         * gtk/common.py:
1608         (get_build_path):
1609         (pkg_config_file_variable):
1610         (gtk_version_of_pkg_config_file):
1611         * gtk/generate-gtkdoc:
1612         (print_missing_api):
1613         * gtk/gtkdoc.py:
1614         (GTKDoc.__init__):
1615         (GTKDoc._run_command):
1616
1617 2013-01-02  Steve Block  <steveblock@chromium.org>
1618
1619         Add chromium.org email address for Steve Block.
1620
1621         Unreviewed.
1622
1623         * Scripts/webkitpy/common/config/committers.py:
1624
1625 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1626
1627         Rationalize closure call heuristics and profiling
1628         https://bugs.webkit.org/show_bug.cgi?id=106270
1629
1630         Reviewed by Oliver Hunt.
1631         
1632         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1633         all generated code ('display *' or 'd *').
1634
1635         * Scripts/display-profiler-output:
1636
1637 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1638
1639         Sorted more xcodeproj files.
1640
1641         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1643         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1644
1645 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1646
1647         Sorted xcodeproj files.
1648
1649         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1650         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1651
1652 2013-01-07  Dan Bernstein  <mitz@apple.com>
1653
1654         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1655         https://bugs.webkit.org/show_bug.cgi?id=106261
1656
1657         Reviewed by Simon Fraser.
1658
1659         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1660
1661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1662         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1663         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1664         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1665         (TestWebKitAPI):
1666         (TestWebKitAPI::TEST):
1667
1668 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1669
1670         Add the Apple MountainLion bots to garden-o-matic.
1671         Eventually, we really should move away from hardcoding
1672         the list of bots.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1675
1676 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1677
1678         [chromium] move web audio related methods to testrunner library
1679         https://bugs.webkit.org/show_bug.cgi?id=106211
1680
1681         Reviewed by Adam Barth.
1682
1683         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1684         (DRTTestRunner::DRTTestRunner):
1685         (DRTTestRunner::reset):
1686         * DumpRenderTree/chromium/DRTTestRunner.h:
1687         (DRTTestRunner):
1688         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1689         (WebKit):
1690         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1691         (WebTestRunner::WebTestRunner::audioData):
1692         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1693         (WebTestRunner::TestRunner::TestRunner):
1694         (WebTestRunner::TestRunner::reset):
1695         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1696         (WebTestRunner):
1697         (WebTestRunner::TestRunner::audioData):
1698         (WebTestRunner::TestRunner::setAudioData):
1699         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1700         (TestRunner):
1701         * DumpRenderTree/chromium/TestShell.cpp:
1702         (TestShell::dump):
1703
1704 2013-01-07  Mike West  <mkwst@chromium.org>
1705
1706         Make the IFRAME_SEAMLESS flag runtime-enabled.
1707         https://bugs.webkit.org/show_bug.cgi?id=106213
1708
1709         Reviewed by Ojan Vafai.
1710
1711         * DumpRenderTree/chromium/TestShell.cpp:
1712         (TestShell::TestShell):
1713         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1714         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1715         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1716         (resetDefaultsToConsistentValues):
1717         * DumpRenderTree/mac/DumpRenderTree.mm:
1718         (resetDefaultsToConsistentValues):
1719         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1720         (WebCore::WebPage::resetSettings):
1721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1722         (WTR::InjectedBundle::beginTesting):
1723             Ensure that seamless IFrames are enabled for layout tests in each of
1724             the ports that support seamless IFrames.
1725
1726 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1727
1728         [chromium] move dumpAsText and friends to the TestRunner library
1729         https://bugs.webkit.org/show_bug.cgi?id=106222
1730
1731         Reviewed by Adam Barth.
1732
1733         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1734
1735         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1736         (DRTTestRunner::DRTTestRunner):
1737         (DRTTestRunner::reset):
1738         * DumpRenderTree/chromium/DRTTestRunner.h:
1739         (DRTTestRunner):
1740         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1741         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1742         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1743         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1744         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1745         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1746         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1747         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1748         (WebTestRunner::TestRunner::TestRunner):
1749         (WebTestRunner::TestRunner::reset):
1750         (WebTestRunner::TestRunner::shouldDumpAsText):
1751         (WebTestRunner):
1752         (WebTestRunner::TestRunner::setShouldDumpAsText):
1753         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1754         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1755         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1756         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1757         (WebTestRunner::TestRunner::dumpAsText):
1758         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1759         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1760         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1761         (TestRunner):
1762
1763 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1764
1765         Build fix attempt after r138810.
1766
1767         Apparently python 2.6 is really bad at floating point computation.
1768
1769         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1770         (MainTest.test_run_memory_test):
1771
1772 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1773
1774         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1775         https://bugs.webkit.org/show_bug.cgi?id=106172
1776
1777         Reviewed by Tony Chang.
1778
1779         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1780         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1781         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1782         test on perf-o-matic and perf. test's results page.
1783
1784         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1785
1786         * Scripts/webkitpy/performance_tests/perftest.py:
1787         (PerfTestMetric): Added.
1788         (PerfTestMetric.__init__): Added.
1789         (PerfTestMetric.metric): Added.
1790         (PerfTestMetric.has_values): Added.
1791         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1792         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1793         conversions to be done on the client side (perf-o-matic and results page).
1794         (PerfTestMetric.append): Added.
1795         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1796         a result for this metric.
1797         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1798         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1799
1800         (PerfTest._create_driver): Extracted from PerfTest.run.
1801         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1802         as needed.
1803         (PerfTest._run_with_driver):
1804         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1805         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1806         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1807
1808         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1809         from other perf tests, there isn't much point in sharing the code here.
1810
1811         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1812         statistics for the measured values.
1813
1814         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1815         (TestPerfTestMetric): Added.
1816         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1817         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1818         (TestPerfTestMetric.test_has_values): Added.
1819         (TestPerfTestMetric.test_append): Added.
1820         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1821         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1822
1823         (TestPerfTest._assert_results_are_correct): Updated as needed.
1824         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1825         in PerfTest.run now after generating the results dictionary.
1826         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1827
1828 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1829
1830         Support size_t multiplication and division operators on LayoutUnit
1831         https://bugs.webkit.org/show_bug.cgi?id=83848
1832
1833         Reviewed by Emil A Eklund.
1834
1835         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1836         Added some simple tests for the new operators using size_t.
1837
1838 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1839
1840         [Qt] run-webkit-tests cleanup for parallel NRWT
1841         https://bugs.webkit.org/show_bug.cgi?id=106220
1842
1843         Reviewed by Dirk Pranke.
1844
1845         * Scripts/run-webkit-tests:
1846         (useNewRunWebKitTests):
1847         * Scripts/webkitpy/layout_tests/port/qt.py:
1848         (QtPort):
1849         (QtPort.default_child_processes):
1850
1851 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1852
1853         Create a GStreamerAudio watchlist and add myself to it.
1854
1855         Unreviewed.
1856
1857         * Scripts/webkitpy/common/config/watchlist:
1858
1859 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1860
1861         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1862         Also removed the empty mac directory.
1863
1864         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1865         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1866         * BuildSlaveSupport/mac: Removed.
1867         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1868
1869 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1870
1871         Add a script to delete stale zero-byte build files
1872         https://bugs.webkit.org/show_bug.cgi?id=106131
1873
1874         Reviewed by Tony Chang.
1875
1876         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1879         (DeleteStaleBuildFiles): Added.
1880         (Factory.__init__): Add DeleteStaleBuildFiles step.
1881         * BuildSlaveSupport/delete-stale-build-files: Added.
1882         (main): Delete zero-byte files except ones intentionally generated by our build process.
1883         (webkitBuildDirectory): Copied from build-product-archive.
1884
1885 2013-01-04  Michael Pruett  <michael@68k.org>
1886
1887         [GTK] Fix build error on GTK due to r138836
1888         https://bugs.webkit.org/show_bug.cgi?id=106154
1889
1890         Reviewed by Kentaro Hara.
1891
1892         * GNUmakefile.am:
1893
1894 2013-01-04  Dan Bernstein  <mitz@apple.com>
1895
1896         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1897         https://bugs.webkit.org/show_bug.cgi?id=106121
1898
1899         Reviewed by Adele Peterson.
1900
1901         Added test for -[DOMTHMLTableCellElement _cellAbove].
1902
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1905         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1906         (TestWebKitAPI):
1907         (TestWebKitAPI::expectCellAboveCell):
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1910
1911 2013-01-04  Eric Seidel  <eric@webkit.org>
1912
1913         FlakyTestReporter should be re-enabled and taught how to post patches
1914         https://bugs.webkit.org/show_bug.cgi?id=103839
1915
1916         Reviewed by Adam Barth.
1917
1918         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1919         It also adds a real Port object to the EWS and CommitQueue objects
1920         using a new PatchProcessingQueue superclass.
1921         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1922         but works for this purpose.
1923         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1924         to resolve a FIXME.
1925
1926         This required some hacks/shiming between the non-specific "old"
1927         port names which the EWS system is currently using, and the new
1928         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1929
1930         Hopefully this will fix the flaky test reporter and results uploading.
1931         Certainly it's another small step towards getting rid of the old ports.py
1932         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1933
1934         Now that DeprecatedPort is no longer used for the results directory
1935         I removed all the explicit results-dir code which webkit-patch was using
1936         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1937
1938         * Scripts/webkitpy/common/config/ports.py:
1939         (DeprecatedPort.run_perl_unittests_command):
1940         * Scripts/webkitpy/common/config/ports_mock.py:
1941         (MockPort.name):
1942         * Scripts/webkitpy/common/system/outputcapture.py:
1943         (OutputCapture.assert_outputs):
1944         * Scripts/webkitpy/layout_tests/port/apple.py:
1945         (ApplePort.determine_full_port_name):
1946         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1947         (LayoutTestResultsReader.__init__):
1948         (LayoutTestResultsReader):
1949         (LayoutTestResultsReader._read_file_contents):
1950         (LayoutTestResultsReader._create_layout_test_results):
1951         (LayoutTestResultsReader._create_unit_test_results):
1952         (LayoutTestResultsReader.results):
1953         (LayoutTestResultsReader.archive):
1954         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1955         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1956         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1957         (test_missing_unit_test_results_path):
1958         (test_layout_test_results):
1959         (test_archive_last_layout_test_results):
1960         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1961         (AbstractEarlyWarningSystem):
1962         (AbstractEarlyWarningSystem.__init__):
1963         (AbstractEarlyWarningSystem.begin_work_queue):
1964         (AbstractEarlyWarningSystem.run_command):
1965         * Scripts/webkitpy/tool/commands/queues.py:
1966         (AbstractPatchQueue.work_item_log_path):
1967         (PatchProcessingQueue):
1968         (PatchProcessingQueue._new_port_name_from_old):
1969         (PatchProcessingQueue.begin_work_queue):
1970         (PatchProcessingQueue._upload_results_archive_for_patch):
1971         (CommitQueue):
1972         (CommitQueue.begin_work_queue):
1973         (CommitQueue.run_command):
1974         (AbstractReviewQueue):
1975         (AbstractReviewQueue.__init__):
1976         (AbstractReviewQueue.begin_work_queue):
1977         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1978         (AbstractPatchQueueTest.test_next_patch):
1979         (PatchProcessingQueueTest):
1980         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1981         * Scripts/webkitpy/tool/steps/runtests.py:
1982         (RunTests.run):
1983         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1984
1985 2013-01-04  Dana Jansens  <danakj@chromium.org>
1986
1987         [chromium] Remove lost-compositor-context layout tests
1988         https://bugs.webkit.org/show_bug.cgi?id=106089
1989
1990         Reviewed by James Robinson.
1991
1992         Remove the loseCompositorContext() test function.
1993
1994         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1995         (WebTestRunner::TestRunner::TestRunner):
1996         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1997         (TestRunner):
1998
1999 2013-01-04  Adam Klein  <adamk@chromium.org>
2000
2001         Remove ENABLE_MUTATION_OBSERVERS #define
2002         https://bugs.webkit.org/show_bug.cgi?id=105459
2003
2004         Reviewed by Ryosuke Niwa.
2005
2006         * Scripts/webkitperl/FeatureList.pm:
2007         * qmake/mkspecs/features/features.pri:
2008
2009 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2010
2011         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2012         https://bugs.webkit.org/show_bug.cgi?id=106078
2013
2014         Reviewed by Tony Chang.
2015
2016         This patch updates values for individual iterations in dummy performance tests used in
2017         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2018         statistics such as stdev and median reported in those tests. This change is required
2019         to resolve the bug 97510.
2020
2021         This patch also refactors integration tests by extracting *TestData classes that
2022         centralizes the definitions of each dummy performance test's text (DRT output),
2023         runner output, and parsed results (JSON) so that we may share more data between
2024         python tests.
2025
2026         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2027         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2028         Use self.assertAlmostEqual when comparing the standard deviation.
2029         (MainTest.test_parse_output):
2030         (test_parse_output_with_failing_line):
2031         (test_parse_output_with_description): Use _assert_results_are_correct.
2032         (test_parse_output_with_subtests): Ditto.
2033
2034         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2035         (InspectorPassTestData): Extracted from tests below.
2036         (EventTargetWrapperTestData): Ditto.
2037         (SomeParserTestData): Ditto.
2038         (MemoryTestData): Ditto.
2039         (TestDriver.run_test): Moved test definitions out of the method.
2040         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2041         (MainTest._load_output_json): Extracted from create_runner.
2042         (MainTest.create_runner):
2043         (MainTest.test_run_test_set_for_parser_tests):
2044         (MainTest.test_run_memory_test):
2045         (MainTest._test_run_with_json_output):
2046         (MainTest.test_run_with_json_output):
2047         (MainTest.test_run_with_description):
2048         (MainTest.test_run_generates_json_by_default):
2049         (MainTest.test_run_merges_output_by_default):
2050         (MainTest.test_run_respects_reset_results):
2051         (MainTest.test_run_generates_and_show_results_page):
2052         (MainTest.test_run_with_slave_config_json):
2053         (MainTest.test_run_with_multiple_repositories):
2054
2055 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2056
2057         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2058         https://bugs.webkit.org/show_bug.cgi?id=106045
2059
2060         Reviewed by Carlos Garcia Campos.
2061
2062         Update test results to confirm that compositions without preedits do not trigger
2063         a composition confirmation.
2064
2065         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2066         (TestWebKitAPI::verifyCanceledComposition):
2067
2068 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2069
2070         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2071         https://bugs.webkit.org/show_bug.cgi?id=105958
2072
2073         Reviewed by Alexey Proskuryakov.
2074
2075         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2076
2077         * WebKitTestRunner/mac/EventSenderProxy.mm:
2078         (KeyMappingEntry):
2079         (WTR):
2080         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2081
2082 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2083
2084         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2085         https://bugs.webkit.org/show_bug.cgi?id=106073
2086
2087         Reviewed by Ryosuke Niwa.
2088
2089         Check that the element being compared to is not nil. 
2090         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2091         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2092         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2093         sometimes before on parallel WebKitTestRunner runs.
2094
2095         * DumpRenderTree/AccessibilityUIElement.cpp:
2096         (AccessibilityUIElement::isEqual):
2097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2098         (WTR::AccessibilityUIElement::isEqual):
2099
2100 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2101
2102         Downloads can be flaky, so try downloading multiple times.
2103         https://bugs.webkit.org/show_bug.cgi?id=105976
2104
2105         Reviewed by Eric Seidel.
2106
2107         * Scripts/webkitpy/common/system/autoinstall.py:
2108         (AutoInstaller._download_to_stream):
2109
2110 2013-01-03  Eric Seidel  <eric@webkit.org>
2111
2112         Rename Tool.port to deprecated_port in preparation for removing more callers
2113         https://bugs.webkit.org/show_bug.cgi?id=106076
2114
2115         Reviewed by Ryosuke Niwa.
2116
2117         This resolves a long-standing FIXME to rename this method. :)
2118
2119         * Scripts/webkitpy/tool/bot/botinfo.py:
2120         (BotInfo.summary_text):
2121         * Scripts/webkitpy/tool/bot/irc_command.py:
2122         (Rollout._update_working_copy):
2123         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2124         (LayoutTestResultsReader._create_layout_test_results):
2125         (LayoutTestResultsReader._create_unit_test_results):
2126         (LayoutTestResultsReader._results_directory):
2127         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2128         (test_missing_unit_test_results_path):
2129         * Scripts/webkitpy/tool/main.py:
2130         (WebKitPatch.deprecated_port):
2131         * Scripts/webkitpy/tool/mocktool.py:
2132         (MockTool.deprecated_port):
2133         * Scripts/webkitpy/tool/steps/build.py:
2134         (Build.build):
2135         * Scripts/webkitpy/tool/steps/checkstyle.py:
2136         (CheckStyle.run):
2137         * Scripts/webkitpy/tool/steps/commit.py:
2138         (Commit._check_test_expectations):
2139         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2140         (PrepareChangeLog.run):
2141         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2142         (PrepareChangeLogForDEPSRoll.run):
2143         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2144         (PrepareChangeLogForRevert.run):
2145         * Scripts/webkitpy/tool/steps/runtests.py:
2146         (RunTests.run):
2147         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2148         (StepsTest.test_runtests_args):
2149         * Scripts/webkitpy/tool/steps/update.py:
2150         (Update._update_command):
2151
2152 2013-01-03  Eric Seidel  <eric@webkit.org>
2153
2154         Add myself to the webkitpy watchlist.
2155
2156         Unreviewed.
2157
2158         * Scripts/webkitpy/common/config/watchlist:
2159
2160 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2161
2162         Cleanup perftest* tests and add a test for computing statistics
2163         https://bugs.webkit.org/show_bug.cgi?id=105685
2164
2165         Reviewed by Eric Seidel.
2166
2167         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
2168         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
2169
2170         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
2171
2172         * Scripts/webkitpy/performance_tests/perftest.py:
2173         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
2174         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
2175         accurate result for the mean.
2176         (PageLoadingPerfTest.run_single):
2177         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2178         (MainTest.test_compute_statistics):
2179         (MainTest.test_compute_statistics.compute_statistics): Added.
2180         (TestPageLoadingPerfTest.test_run): floatify values.
2181         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
2182         correctly recognizes them as integers.
2183
2184         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
2185         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
2186         (TestDriver): Moved out of MainTest.
2187         (MainTest): Got rid of assertWritten and all unit tests.
2188         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
2189         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2190         (MainTest.test_run_test_set_for_parser_tests):
2191         (MainTest.test_run_memory_test):
2192         (MainTest._test_run_with_json_output):
2193         (MainTest.test_run_generates_json_by_default):
2194         (MainTest.test_run_merges_output_by_default):
2195         (MainTest.test_run_respects_reset_results):
2196         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
2197         parsing output JSON files. Just verify that the output path is correct instead.
2198         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2199         (MainTest): Removed all integration tests.
2200         (MainTest.create_runner): Simplified.
2201
2202 2013-01-03  Julie Parent  <jparent@chromium.org>
2203
2204         Dashboard cleanup: remove usage of global g_defaultBuilderName
2205         https://bugs.webkit.org/show_bug.cgi?id=106043
2206
2207         Use now public defaultBuilder() from the BuilderGroup, rather
2208         than global variable.
2209
2210         Also eliminates the setup() and initBuilders() functions since we
2211         no longer need to track the global.
2212
2213         Reviewed by Adam Barth.
2214
2215         * TestResultServer/static-dashboards/builders.js:
2216         (BuilderGroup.prototype.defaultBuilder):
2217         (BuilderGroup.prototype.master):
2218         * TestResultServer/static-dashboards/dashboard_base.js:
2219         (parseParameters):
2220         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2221         (updateDefaultBuilderState):
2222         * TestResultServer/static-dashboards/loader.js:
2223         (.):
2224         * TestResultServer/static-dashboards/loader_unittests.js:
2225
2226 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2227
2228         Disable an intermittently failing unit test for now.
2229         The failure is tracked by the bug 106051.
2230
2231         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2232         (TestWebKitAPI::TEST):
2233
2234 2013-01-03  Dan Bernstein  <mitz@apple.com>
2235
2236         No way to obtain a DOMNode given a JS wrapper for a Node
2237         https://bugs.webkit.org/show_bug.cgi?id=106033
2238
2239         Added a test for +[DOMNode _nodeFromJSWrapper:].
2240
2241         Reviewed by Sam Weinig.
2242
2243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2244         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
2245         (TestWebKitAPI):
2246         (TestWebKitAPI::TEST):
2247
2248 2013-01-03  Emil A Eklund  <eae@chromium.org>
2249
2250         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
2251         https://bugs.webkit.org/show_bug.cgi?id=105961
2252
2253         Reviewed by Levi Weintraub.
2254         
2255         Add tests for LayoutUnit::ceil and floor.
2256
2257         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2258         (TestWebKitAPI::TEST):
2259         (TestWebKitAPI):
2260
2261 2013-01-03  Julie Parent  <jparent@chromium.org>
2262
2263         Add unit test for default builder for the dashboards.
2264         https://bugs.webkit.org/show_bug.cgi?id=105972
2265
2266         Reviewed by Dirk Pranke.
2267
2268         * TestResultServer/static-dashboards/loader_unittests.js:
2269
2270 2013-01-03  Tony Chang  <tony@chromium.org>
2271
2272         Generate internal.settings from Settings.in
2273         https://bugs.webkit.org/show_bug.cgi?id=104740
2274
2275         Reviewed by Adam Barth.
2276
2277         * GNUmakefile.am: Compile new generated files on GTK+.
2278         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2279         with both extra_sources and add_output_to_sources=false will still
2280         compile the files in extra_sources. This makes it possible to compile
2281         InternalSettingsGenerated.cpp and not be confused by
2282         InternalSettingsGenerated.idl.
2283
2284 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
2285
2286         [style] WebIDL-reflecting uppercase enums reported as style violation
2287         https://bugs.webkit.org/show_bug.cgi?id=105832
2288
2289         Reviewed by Tony Chang.
2290
2291         Recognize the enum as WebIDL-reflecting one if there's a comment present that
2292         indicates this. In enums spanning over multiple lines, the comment is expected
2293         on the first line. In enums placed in one line, the comment is expected at the
2294         end of that line.
2295
2296         WebIDL-reflecting enum values are required to be written in uppercase and as such
2297         violate the common rule of these values being written in InterCaps. Annotating
2298         enums this way makes it possible to avoid false style violation reports.
2299
2300         The comment is of form '// Web(?:Kit)?IDL enum'.
2301
2302         * Scripts/webkitpy/style/checkers/cpp.py:
2303         (_EnumState.__init__):
2304         (_EnumState.process_clean_line):
2305         (check_enum_casing):
2306         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2307         (NoNonVirtualDestructorsTest.test_enum_casing):
2308
2309 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2310
2311         Adding favicon.ico to the garden-o-matic.
2312         https://bugs.webkit.org/show_bug.cgi?id=105982
2313
2314         Reviewed by Adam Barth.
2315
2316         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
2318
2319 2013-01-03  Jonathan Liu  <net147@gmail.com>
2320
2321         [Qt] Fix library linking order
2322         https://bugs.webkit.org/show_bug.cgi?id=105818
2323
2324         Some Qt libraries are linked before the private static libraries
2325         that depend on them which results in QtWebKit failing to link.
2326
2327         Copy Qt module dependencies from QT to QT_PRIVATE when creating
2328         module to ensure the Qt libraries are linked after the private
2329         static libraries that depend on them.
2330
2331         Reviewed by Tor Arne Vestbø.
2332
2333         * qmake/mkspecs/features/default_post.prf:
2334
2335 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
2336
2337         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
2338         https://bugs.webkit.org/show_bug.cgi?id=102209
2339
2340         Reviewed by Gyuyoung Kim.
2341
2342         Set tooltip on the elm_window instead of ewk_view, and add delay to
2343         show the tooltip window.
2344
2345         Setting tooltip on the ewk_view makes elementary error message because
2346         ewk_view is not an elementary widget. To remove the error message,
2347         tooltip should be set on the elm_window.
2348
2349         Most browsers show the tooltip after a mouse pointer stays on an
2350         element object that has tooltip text.
2351         But elm_tooltip widget itself doesn't have delay or handle mouse
2352         events to show/hide.
2353
2354         So additional codes are added to show/hide tooltip widget along with
2355         mouse events.
2356           1) When a mouse pointer stays for a second on an element which has
2357              tooltip text, then tooltip widget is displayed.
2358           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
2359              widget.
2360
2361         * MiniBrowser/efl/main.c:
2362         (_Tooltip_Information):
2363         (_Browser_Window):
2364         (on_tooltip_show):
2365         (window_tooltip_hide):
2366         (window_tooltip_update):
2367         (on_mouse_in):
2368         (on_mouse_move):
2369         (on_mouse_out):
2370         (window_free):
2371         (on_tooltip_text_set):
2372         (on_tooltip_text_unset):
2373         (window_create):
2374
2375 2013-01-02  Tony Chang  <tony@chromium.org>
2376
2377         Unreviewed, rolling out r138661.
2378         http://trac.webkit.org/changeset/138661
2379         https://bugs.webkit.org/show_bug.cgi?id=104740
2380
2381         Compile problems on EFL
2382
2383         * GNUmakefile.am:
2384         * qmake/mkspecs/features/default_post.prf:
2385
2386 2013-01-02  Tony Chang  <tony@chromium.org>
2387
2388         Generate internal.settings from Settings.in
2389         https://bugs.webkit.org/show_bug.cgi?id=104740
2390
2391         Reviewed by Adam Barth.
2392
2393         * GNUmakefile.am: Compile new generated files on GTK+.
2394         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2395         with both extra_sources and add_output_to_sources=false will still
2396         compile the files in extra_sources. This makes it possible to compile
2397         InternalSettingsGenerated.cpp and not be confused by
2398         InternalSettingsGenerated.idl.
2399
2400 2013-01-02  Adam Barth  <abarth@webkit.org>
2401
2402         Remove old-run-webkit-tests support from webkitpy
2403         https://bugs.webkit.org/show_bug.cgi?id=105619
2404
2405         Reviewed by Eric Seidel.
2406
2407         This patch removes support for webkitpy parsing the
2408         old-run-webkit-tests results format. There doesn't seem to be any
2409         reason to keep this code around anymore now that most bots have
2410         switched to new-run-webkit-tests.
2411
2412         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2413         (Builder.fetch_layout_test_results):
2414         * Scripts/webkitpy/common/net/layouttestresults.py:
2415         (path_for_layout_test):
2416         (LayoutTestResults.results_from_string):
2417         (LayoutTestResults):
2418         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2419         (LayoutTestResultsTest.test_results_from_string):
2420         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2421         (test_flaky_test_failure):
2422         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2423         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2424         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2425         (PatchAnalysisTask._test_patch):
2426         * Scripts/webkitpy/tool/commands/queuestest.py:
2427         (QueuesTest.assert_queue_outputs):
2428
2429 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2430
2431         [Qt][WK2] Add simple UI to find text from page
2432         https://bugs.webkit.org/show_bug.cgi?id=96481
2433
2434         Reviewed by Jocelyn Turcotte.
2435
2436         Find bar that slides between navigation bar and WebView.
2437
2438         * MiniBrowser/qt/BrowserWindow.cpp:
2439         (BrowserWindow::toggleFind):
2440         * MiniBrowser/qt/BrowserWindow.h:
2441         (BrowserWindow):
2442         * MiniBrowser/qt/MiniBrowser.qrc:
2443         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2444         (MiniBrowserApplication::notify):
2445         * MiniBrowser/qt/icons/find.png: Added.
2446         * MiniBrowser/qt/qml/BrowserWindow.qml:
2447
2448 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2449
2450         Regression(r138603): Caused 2 webkitpy tests to fail
2451         https://bugs.webkit.org/show_bug.cgi?id=105913
2452
2453         Reviewed by Kentaro Hara.
2454
2455         Fix 2 webkitpy tests that started to fail after
2456         r138603.
2457
2458         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2459         (IRCCommandTest._sheriff_test_data_url): Make sure the
2460         returned test file URL is valid no matter what the
2461         current working directory is.
2462         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2463         (IRCBotTest.test_help): Add "sheriffs" command to the
2464         list of available commands.
2465
2466 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2467
2468         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2469         https://bugs.webkit.org/show_bug.cgi?id=105897
2470
2471         Reviewed by Alexey Proskuryakov.
2472
2473         Dump in WebKitTestRunner the message that is expected by layout tests
2474         when the missing plugin button is clicked.
2475
2476         * WebKitTestRunner/TestController.cpp:
2477         (WTR::TestController::createWebViewWithOptions):
2478         (WTR::TestController::unavailablePluginButtonClicked):
2479         (WTR):
2480         * WebKitTestRunner/TestController.h:
2481         (TestController):
2482
2483 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2484
2485         [EFL] Enable MHTML feature
2486         https://bugs.webkit.org/show_bug.cgi?id=105815
2487
2488         Reviewed by Laszlo Gombos.
2489
2490         Enable MHTML feature for EFL port by default.
2491
2492         * Scripts/webkitperl/FeatureList.pm:
2493
2494 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2495
2496         sheriff-bot should know who the gardeners/sheriffs are
2497         https://bugs.webkit.org/show_bug.cgi?id=105698
2498
2499         Reviewed by Eric Seidel.
2500
2501         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2502
2503         * Scripts/webkitpy/tool/bot/irc_command.py:
2504         (Current):
2505         (Current._retrieve_webkit_sheriffs):
2506         (Current.execute):
2507         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2508         (IRCCommandTest.test_current):
2509         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2510         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2511         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2512         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2513         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2514
2515 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2516
2517         [GTK] Move ImageDiff to the Tools directory root
2518         https://bugs.webkit.org/show_bug.cgi?id=105421
2519
2520         Reviewed by Kenneth Rohde Christiansen.
2521
2522         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2523         * GNUmakefile.am:
2524         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2525
2526 2012-12-30  Mike West  <mkwst@chromium.org>
2527
2528         Add myself to watchlists for CSP and console logs.
2529         https://bugs.webkit.org/show_bug.cgi?id=105874
2530
2531         Reviewed by Dirk Pranke.
2532
2533         Because I really, really, really need more email.
2534
2535         * Scripts/webkitpy/common/config/committers.py:
2536             Add mkwst+watchlist@chromium.org as a contributor.
2537         * Scripts/webkitpy/common/config/watchlist:
2538             Create watchlist categories for 1) the various mechanisms used to
2539             generate console messages, and 2) CSP usage and files.
2540
2541 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2542
2543         [EFL] Enable TEMPLATE_ELEMENT feature
2544         https://bugs.webkit.org/show_bug.cgi?id=105865
2545         
2546         Reviewed by Laszlo Gombos.
2547
2548         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2549
2550 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2551
2552         Unreviewed GTK gardening of the unit tests.
2553
2554         Skip the TestInspectorServer unit test that's timing out completely.
2555
2556         * Scripts/run-gtk-tests:
2557         (TestRunner):
2558
2559 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2560
2561         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2562         https://bugs.webkit.org/show_bug.cgi?id=105855
2563
2564         Reviewed by Vsevolod Vlasov.
2565
2566         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2567         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2568
2569         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2570         (ReportMemoryUsageVisitor):
2571         (clang::AddMemberCallVisitor::VisitCallExpr):
2572         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2573         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2574
2575 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2576
2577         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2578         https://bugs.webkit.org/show_bug.cgi?id=105852
2579
2580         Reviewed by Alexander Pavlov.
2581
2582         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2583         (clang):
2584         (AddMemberCallVisitor):
2585         (ReportMemoryUsageVisitor):
2586         (clang::ReportMemoryUsageAction::ParseArgs):
2587         (clang::AddMemberCallVisitor::VisitCallExpr):
2588         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2589         (clang::ReportMemoryUsageVisitor::emitWarning):
2590         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2591         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2592         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2593
2594 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2595
2596         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2597         https://bugs.webkit.org/show_bug.cgi?id=105835
2598
2599         Reviewed by Dirk Pranke.
2600
2601         The BeautifulSoup module is a third-party import and as such we don't have much control
2602         over its testing. Because of that it should be omitted from code coverage checking.
2603
2604         * Scripts/webkitpy/test/main.py:
2605         (Tester._run_tests):
2606
2607 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2608
2609         [GTK][WK2] Add support for IME Composition
2610         https://bugs.webkit.org/show_bug.cgi?id=65093
2611
2612         Reviewed by Carlos Garcia Campos.
2613
2614         Update unit tests for GtkInputMethodFilter to note whether or not an event
2615         was a fake event synthesized for composition purposes. This is now used
2616         for WebKit2.
2617
2618         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2619         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2620         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2621         (TestWebKitAPI::TEST):
2622         * gtk/generate-gtkdoc:
2623         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2624         generation.
2625
2626 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2627
2628         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2629         https://bugs.webkit.org/show_bug.cgi?id=105800
2630
2631         Reviewed by Yury Semikhatsky.
2632
2633         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2634         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2635         (clang):
2636
2637 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2638
2639         Create a GTK build system watchlist and add myself to it
2640         https://bugs.webkit.org/show_bug.cgi?id=105769
2641
2642         Reviewed by Dirk Pranke.
2643
2644         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2645         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2646         omitted on purpose due to relatively high change rate they are exposed to.
2647
2648         The new watchlist would be of use to me as the GTK build system recently went
2649         through a series of changes that included a changed policy on adding configuration
2650         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2651         mailing list about this change will be published later, but I'd also like to be
2652         notified of any pending changes to these files just so I can check the changes are
2653         in compliance with the new policy.
2654
2655         * Scripts/webkitpy/common/config/watchlist:
2656
2657 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2658
2659         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2660         As example ..../DevTools/src/third_party/WebKit
2661
2662         * Scripts/webkitpy/common/webkit_finder.py:
2663         (WebKitFinder.webkit_base):
2664
2665 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2666
2667         [EFL][WK2] Refactor snapshot taking code
2668         https://bugs.webkit.org/show_bug.cgi?id=105687
2669
2670         Reviewed by Kenneth Rohde Christiansen.
2671
2672         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2673         since the function was renamed to follow naming style.
2674
2675         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2676         (WTR::PlatformWebView::windowSnapshotImage):
2677
2678 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2679
2680         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2681         https://bugs.webkit.org/show_bug.cgi?id=105725
2682
2683         Reviewed by Yury Semikhatsky.
2684
2685         MemberType value names were adjusted according to Style Guide.
2686         Existing tests were extended with link type validation.
2687
2688         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2689
2690 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2691
2692         [BlackBerry] DRT - Crashed when running pixels tests
2693         https://bugs.webkit.org/show_bug.cgi?id=105711
2694
2695         RIM PR 270003
2696
2697         Reviewed by George Staikos.
2698
2699         Calling window->post() here will result in buffer swapping which is
2700         only allowed in UI thread now, and I found we don't need to call it
2701         for GL renderer.
2702
2703         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2704         (createBitmapContextFromWebView):
2705
2706 2012-12-22  Dan Winship  <danw@gnome.org>
2707
2708         Add a patch to fix libxml2 2.9.0 regression
2709         https://bugs.webkit.org/show_bug.cgi?id=104494
2710
2711         Reviewed by Martin Robinson.
2712
2713         * gtk/jhbuild.modules:
2714         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2715
2716 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2717
2718         Unreviewed update of status to reviewer.
2719
2720         * Scripts/webkitpy/common/config/committers.py:
2721
2722 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2723
2724         [GTK][jhbuild] Bump GStreamer to 1.0.4
2725         https://bugs.webkit.org/show_bug.cgi?id=105640
2726
2727         Reviewed by Martin Robinson.
2728
2729         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2730
2731 2012-12-21  Nico Weber  <thakis@chromium.org>
2732
2733         chromium: webkit-build-directory doesn't handle ninja output dirs
2734         https://bugs.webkit.org/show_bug.cgi?id=105671
2735
2736         Reviewed by Daniel Bates.
2737
2738         Teach webkit-build-directory to detect the ninja build directory.
2739
2740         * Scripts/webkitdirs.pm:
2741         (determineBaseProductDir):
2742         (determineIsChromiumNinja):
2743
2744 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2745
2746         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2747         https://bugs.webkit.org/show_bug.cgi?id=95477
2748
2749         Reviewed by Sam Weinig.
2750
2751         Co-authored by Jia Pu.
2752
2753         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2754         we can have consistent autocorrection behavior when running tests.
2755
2756         * DumpRenderTree/mac/DumpRenderTree.mm:
2757         (resetDefaultsToConsistentValues):
2758         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2759         (WTR::InjectedBundle::platformInitialize):
2760
2761 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2762
2763         [GTK] Add WebKit1-specific TestExpectations file
2764         https://bugs.webkit.org/show_bug.cgi?id=97562
2765
2766         Reviewed by Dirk Pranke.
2767
2768         Implement the expectations_files method inside the GtkPort class that
2769         returns the list of the TestExpectations files the current test configuration
2770         requires. The method is implemented in a similar way as on the EFL port.
2771         A unit test is also added.
2772
2773         * Scripts/webkitpy/layout_tests/port/gtk.py:
2774         (GtkPort._search_paths):
2775         (GtkPort):
2776         (GtkPort.expectations_files):
2777         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2778         (GtkPortTest.test_expectations_files):
2779
2780 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2781
2782         [EFL] Enable feature option for the CSS sticky position
2783         https://bugs.webkit.org/show_bug.cgi?id=105630
2784
2785         Reviewed by Kenneth Rohde Christiansen.
2786
2787         Enable CSS sticky position feature by default for the
2788         EFL port. This feature option was added in r138252.
2789
2790         No new tests. Existing layout tests pass.
2791
2792         * Scripts/webkitperl/FeatureList.pm:
2793
2794 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2795
2796         [WK2] REGRESSION(r138232): It made 4 tests timeout
2797         https://bugs.webkit.org/show_bug.cgi?id=105623
2798
2799         Reviewed by Kenneth Rohde Christiansen.
2800
2801         r138232 changed functionality so that empty text output
2802         no longer leads to a dump() call, which leads to a timeout.
2803         Instead do a text dump if there is text output or if there
2804         is no audio output.
2805
2806         * WebKitTestRunner/TestInvocation.cpp:
2807         (WTR::TestInvocation::dumpResults):
2808
2809 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2810
2811         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2812         https://bugs.webkit.org/show_bug.cgi?id=105309
2813
2814         On Windows the library name is Qt5WebKitWidgets as well.
2815         So r138136 should not have adjusted the library name for Windows.
2816
2817         Reviewed by Simon Hausmann.
2818
2819         * Scripts/webkitdirs.pm:
2820         (builtDylibPathForName):
2821
2822 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2823
2824         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2825         https://bugs.webkit.org/show_bug.cgi?id=105424
2826
2827         This change will allow us to run a very specific
2828         subset of the available LayoutTests on a mac buildbot.
2829         The new baseline search path for mac will look as follows:
2830         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2831
2832         Reviewed by Dirk Pranke.
2833
2834         * Scripts/webkitpy/layout_tests/port/qt.py:
2835         (QtPort._search_paths):
2836         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2837         (QtPortTest):
2838
2839 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2840
2841         [EFL] Build break with latest EFL libraries.
2842         https://bugs.webkit.org/show_bug.cgi?id=104827
2843
2844         Reviewed by Laszlo Gombos.
2845
2846         The eo EFL package is introduced and evas and ecore use it since 1.8.
2847         While introducing Eo, EFL changed several structures of Evas and Ecore
2848         from own specific class to Eo.
2849
2850         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2851         Ecore_Timer to build with latest EFL libraries.
2852
2853         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2854         * EWebLauncher/CMakeLists.txt: Ditto.
2855         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2856         * ImageDiff/PlatformEfl.cmake: Ditto.
2857         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2858         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2859         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2860         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2861         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2862
2863 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2864
2865         TestExpectation fallback is broken
2866         https://bugs.webkit.org/show_bug.cgi?id=105583
2867
2868         Reviewed by Ryosuke Niwa.
2869
2870         When I added support for the -wk2 in port names, it looks
2871         like I broke the way we computed the list of TestExpectations
2872         files so that the implementation-version directory was left out :(.
2873         Fixed and cleaned up the tests.
2874
2875         * Scripts/webkitpy/layout_tests/port/base.py:
2876         (Port.expectations_files):
2877         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2878         (TestWebKitPort.__init__):
2879         (PortTestCase.test_skipped_directories_for_symbols):
2880         (test_skipped_directories_for_features):
2881         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2882         (test_skipped_tests_for_unsupported_features_empty_test_list):
2883         (test_skipped_layout_tests):
2884         (test_expectations_files):
2885
2886 2012-12-20  Anders Carlsson  <andersca@apple.com>
2887
2888         Don't include WebKit2 headers when building TestWebKitAPI on windows
2889         https://bugs.webkit.org/show_bug.cgi?id=105582
2890
2891         Reviewed by Tim Horton.
2892
2893         * TestWebKitAPI/config.h:
2894         * TestWebKitAPI/win/main.cpp:
2895
2896 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2897
2898         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2899         https://bugs.webkit.org/show_bug.cgi?id=105370
2900
2901         Reviewed by Simon Fraser.
2902
2903         Re-enable the test.
2904
2905         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2906         (TestWebKitAPI::TEST):
2907
2908 2012-12-20  Nico Weber  <thakis@chromium.org>
2909
2910         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2911         https://bugs.webkit.org/show_bug.cgi?id=105498
2912
2913         Reviewed by Dirk Pranke.
2914
2915         Use the newest binary available rather than an than always picking one
2916         build directory over another based on iteration order.
2917
2918         * Scripts/webkitpy/layout_tests/port/chromium.py:
2919         (ChromiumPort._static_build_path):
2920         Check for timestamps.
2921         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2922         (ChromiumMacPortTest.test_build_path_timestamps):
2923         Test that out / xcodebuild selection happens based on timestamps
2924         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2925         (ChromiumWinPortTest.test_build_path_timestamps):
2926         Test that out / build selection happens based on timestamps
2927
2928 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2929
2930         Lots of sticky tests failing in WK2
2931         https://bugs.webkit.org/show_bug.cgi?id=105464
2932
2933         Reviewed by Beth Dakin.
2934
2935         WebKitTestRunner had a race between snapshotting in the UI process,
2936         and resettting after the test in the web process. InjectedBundle::done()
2937         was a bad place to call page()->resetAfterTest(), because of this race;
2938         it could reset the scroll position before the UI snapshot had been obtained.
2939         
2940         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2941         for the "Reset" message which will come in before the next test.
2942
2943         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2944         (WTR::InjectedBundle::didReceiveMessage):
2945         (WTR::InjectedBundle::done):
2946
2947 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2948
2949         DFG speculation checks that take JumpList should consolidate OSRExits
2950         https://bugs.webkit.org/show_bug.cgi?id=105401
2951
2952         Reviewed by Oliver Hunt.
2953
2954         Update the profiler to understand that an OSR exit may have multiple
2955         candidate exit sites.
2956
2957         * Scripts/display-profiler-output:
2958
2959 2012-12-20  Eric Seidel  <eric@webkit.org>
2960
2961         EWSes do not need to dump build/test logs when things pass
2962         https://bugs.webkit.org/show_bug.cgi?id=105402
2963
2964         Reviewed by Dirk Pranke.
2965
2966         When we were first writing the commit-queue and EWS system
2967         and running them locally, we thought it was important to see the
2968         build/test output as it happened.  Now these queues have been running
2969         for years, and we don't use this feature anymore.  So this patch
2970         makes us stop tee-ing the output directly to stdout, and instead
2971         only print any output from commands when they fail.
2972
2973         I also added some logging when we execute each command
2974         since we are no longer printing the command output itself.
2975         This should make it much easier to see errors with the EWS
2976         system itself, now that all the passing-build output is removed.
2977
2978         This required updating a zillion unittests, since we have a bunch of
2979         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2980         already approximating this behavior by using a "logging" Executive.
2981         I disabled logging in those cases to avoid redundant logging in those tests.
2982
2983         * Scripts/webkitpy/common/system/executive.py:
2984         (Executive.command_for_printing):
2985         (Executive.run_command):
2986         * Scripts/webkitpy/common/system/executive_mock.py:
2987         (MockExecutive.command_for_printing):
2988         (MockExecutive.run_command):
2989         * Scripts/webkitpy/common/system/executive_unittest.py:
2990         (ExecutiveTest.test_auto_stringify_args):
2991         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2992         (EarlyWarningSytemTest._default_expected_logs):
2993         (_test_ews):
2994         (_test_ewses):
2995         * Scripts/webkitpy/tool/commands/queues.py:
2996         (AbstractQueue.run_webkit_patch):
2997         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2998         (AbstractQueueTest._assert_run_webkit_patch):
2999         (CommitQueueTest.test_commit_queue):
3000         (test_rollout):
3001         (test_rollout_lands):
3002         (test_manual_reject_during_processing):
3003         (StyleQueueTest.test_style_queue_with_style_exception):
3004         (test_style_queue_with_watch_list_exception):
3005
3006 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
3007
3008         AX: support clickPoint in DRT for chromium
3009         https://bugs.webkit.org/show_bug.cgi?id=97359
3010
3011         Reviewed by Chris Fleizach.
3012
3013         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3014         several more tests can pass.
3015
3016         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3017         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3018         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3019         (WebTestRunner):
3020         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3021         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3022         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3023         (AccessibilityUIElement):
3024
3025 2012-12-20  Dan Bernstein  <mitz@apple.com>
3026
3027         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
3028         https://bugs.webkit.org/show_bug.cgi?id=99268
3029
3030         Reviewed by Alexey Proskuryakov.
3031
3032         * Scripts/prepare-ChangeLog:
3033         (generateNewChangeLogs): Removed the "Additional information of the change" line.
3034
3035 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3036
3037         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
3038
3039         * Scripts/run-gtk-tests:
3040         (TestRunner):
3041
3042 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3043
3044         [Qt] Move ImageDiff to the Tools directory root
3045         https://bugs.webkit.org/show_bug.cgi?id=105420
3046
3047         Reviewed by Tor Arne Vestbø.
3048
3049         Moved ImageDiff from outside DumpRenderTree because it is also a
3050         dependency when running pixel tests for WebKit2.
3051
3052         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
3053         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
3054         * Tools.pro:
3055
3056 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
3057
3058         [GTK] Remove the --enable-unstable-features configuration option
3059         https://bugs.webkit.org/show_bug.cgi?id=105327
3060
3061         Reviewed by Martin Robinson.
3062
3063         Add a missing feature option for the CSS sticky position feature.
3064
3065         * Scripts/webkitperl/FeatureList.pm:
3066
3067 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3068
3069         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
3070
3071         * Scripts/run-gtk-tests:
3072         (TestRunner):
3073
3074 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3075
3076         [EFL] MiniBrowser does not play Infinite Gangnam Style
3077         https://bugs.webkit.org/show_bug.cgi?id=103531
3078
3079         Reviewed by Kenneth Rohde Christiansen.
3080
3081         For EFL we would like this feature to be built by default.
3082
3083         * Scripts/webkitperl/FeatureList.pm:
3084
3085 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
3086
3087         [Qt] EWS bots should call qmake always
3088         https://bugs.webkit.org/show_bug.cgi?id=90049
3089
3090         Reviewed by Simon Hausmann.
3091
3092         * Scripts/webkitdirs.pm:
3093         (buildQMakeProjects):
3094
3095 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
3096
3097         [chromium] fix stray printf in TestRunner's WebTestProxy
3098         https://bugs.webkit.org/show_bug.cgi?id=105515
3099
3100         Reviewed by Ryosuke Niwa.
3101
3102         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3103         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3104
3105 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3106
3107         [WK2] WebAudio WKTR support
3108         https://bugs.webkit.org/show_bug.cgi?id=95084
3109
3110         Reviewed by Kenneth Rohde Christiansen.
3111
3112         Implementing audio data dump support for WebKitTestRunner,
3113         by adding the API to the IDL, enabling IPC for transferring
3114         the audio data as bytebuffer and dumping it according
3115         to run-webkit-tests script's expectations.
3116         This enables audio testing on WebKit2 ports.
3117         Based on initial wip-patch from Philippe Normand - thanks.
3118
3119         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
3120         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
3121         (WTR::TestRunner::setAudioData):
3122         (WTR):
3123         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
3124         (TestRunner):
3125         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
3126         (WTR::InjectedBundle::done):
3127         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
3128         (WTR::InjectedBundle::setAudioResult):
3129         (InjectedBundle):
3130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3131         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
3132         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
3133         (WTR::TestInvocation::dumpResults):
3134         (WTR):
3135         (WTR::TestInvocation::dumpAudio):
3136         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
3137         * WebKitTestRunner/TestInvocation.h:
3138         (TestInvocation):
3139
3140 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
3141
3142         [GTK] Count failed and timed out tests separately
3143         https://bugs.webkit.org/show_bug.cgi?id=105448
3144
3145         Reviewed by Carlos Garcia Campos.
3146
3147         Display the number of tests that fail, time out and are skipped
3148         separately in the buildbot page.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3151         (RunGtkAPITests.commandComplete):
3152         (RunGtkAPITests.evaluateCommand):
3153         (RunGtkAPITests.getText2):
3154         * Scripts/run-gtk-tests:
3155         (TestRunner.run_tests):
3156
3157 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         PerfTest.parse_output does too much
3160         https://bugs.webkit.org/show_bug.cgi?id=105391
3161
3162         Reviewed by Tony Chang.
3163
3164         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
3165         Also moved the code to output test results into PerfTest._run_with_driver.
3166
3167         * Scripts/webkitpy/performance_tests/perftest.py:
3168         (PerfTest.__init__): Added _description.
3169         (PerfTest.description): Added.
3170         (PerfTest._run_with_driver): Moved the code to output test description and test results.
3171         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
3172         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
3173         respectively. Also removed the code that allowed some tests to omit values since all tests report each
3174         iteration now since r136492.
3175         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
3176         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
3177         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
3178         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
3179         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
3180         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
3181         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3182         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
3183         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
3184         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
3185         so that it's not string-concatenated with the next line.
3186         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
3187         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
3188
3189 2012-12-19  Alexis Menard  <alexis@webkit.org>
3190
3191         Implement CSS parsing for CSS transitions unprefixed.
3192         https://bugs.webkit.org/show_bug.cgi?id=104804
3193
3194         Reviewed by Dean Jackson.
3195
3196         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
3197         to cover the work of unprefixing Transforms, Animations and 
3198         Transitions. It will let the possibility of each ports to turn it off 
3199         in their release branches until we're confident that these CSS 
3200         properties are ready to be unprefixed.
3201
3202         * Scripts/webkitperl/FeatureList.pm:
3203         * qmake/mkspecs/features/features.pri:
3204
3205 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
3206
3207         2 clampTo unit tests are failing
3208         https://bugs.webkit.org/show_bug.cgi?id=105253
3209
3210         Reviewed by Emil A Eklund.
3211
3212         Removed clampToUnsigned as it was actually testing exactly what
3213         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
3214         to precision loss (fix suggested by Emil).
3215
3216         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3217
3218 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3219
3220         [EFL] Move ImageDiff to the Tools directory root
3221         https://bugs.webkit.org/show_bug.cgi?id=105305
3222
3223         Reviewed by Laszlo Gombos.
3224
3225         We previously moved this directory from the DRT directory to
3226         efl/ImageDiff. The major reason for doing so was because ImageDiff does
3227         not depend on DumpRenderTree but for legacy reasons was living inside the
3228         DRT folder, even though it is needed when running pixel tests for WK2.
3229
3230         Now we are moving to Tool directory root as other ports agreed to do the same.
3231
3232         * CMakeLists.txt:
3233         * ImageDiff/CMakeLists.txt: Added.
3234         * ImageDiff/PlatformEfl.cmake: Added.
3235         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
3236         * efl/ImageDiff/CMakeLists.txt: Removed.
3237
3238 2012-12-19  Zeno Albisser  <zeno@webkit.org>
3239
3240         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
3241         https://bugs.webkit.org/show_bug.cgi?id=105309
3242
3243         The version number is only used as a part
3244         of the library name on Linux.
3245
3246         Reviewed by Kenneth Rohde Christiansen.
3247
3248         * Scripts/webkitdirs.pm:
3249         (builtDylibPathForName):
3250
3251 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
3252
3253         [GTK] Tests that time out are not considered as failures.
3254         https://bugs.webkit.org/show_bug.cgi?id=105318
3255
3256         Reviewed by Martin Robinson.
3257
3258         Fix parsing of the GTK API tests log files.
3259
3260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3261         (RunGtkAPITests.commandComplete):
3262
3263 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
3264
3265         Unreviewed, rolling out r138061.
3266         https://bugs.webkit.org/show_bug.cgi?id=105396
3267
3268         Original patch:
3269         http://trac.webkit.org/changeset/138061
3270         https://bugs.webkit.org/show_bug.cgi?id=97359
3271
3272         It is crashing on Debug bots
3273
3274         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3275         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3276         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3277         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3278         (AccessibilityUIElement):
3279
3280 2012-12-18  Alice Liu  <alice.liu@apple.com>
3281
3282         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
3283         Add SPI to WebKit1 WebFrame for hit testing
3284
3285         Reviewed by Dan Bernstein.
3286
3287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
3288         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
3289         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
3290         Then hit-tests at three points, expecting to hit the two divs and body element. 
3291
3292 2012-12-18  Alice Liu  <alice.liu@apple.com>
3293
3294         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
3295         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
3296
3297         Reviewed by Anders Carlsson.
3298
3299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
3300         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
3301         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
3302         Loads html with a single div element. In an isolated world, creates a property on that node.
3303         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
3304             - Existence of the isolated property in the isolated world.
3305             - Existence of the standard property in the standard world.
3306             - Non-existence of the isolated property in the standard world.
3307             - Non-existence of the standard property in the isolated world.
3308
3309 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
3310
3311         Disable the SimplifyMarkup API test, wich asserts in debug builds.
3312         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
3313         
3314         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3315         (TestWebKitAPI::TEST):
3316
3317 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
3318
3319         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
3320         https://bugs.webkit.org/show_bug.cgi?id=104279
3321
3322         Reviewed by David Kilzer.
3323
3324         Add a build phase script that checks a framework's header files for
3325         Platform.h and Compiler.h macros. Also add some tests for the script.
3326
3327         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
3328         Script to be used in build phases to check for inappropriate macros in headers.
3329
3330         * Scripts/test-webkitruby: Added.
3331         Script that can be used to run all webkitruby tests.
3332
3333         * Scripts/test-webkit-scripts:
3334         Also run the ruby tests.
3335
3336         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
3337         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
3338         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
3339         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
3340         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
3341         Tests for the new script.
3342
3343 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
3344
3345         AX: support clickPoint in DRT for chromium
3346         https://bugs.webkit.org/show_bug.cgi?id=97359
3347
3348         Reviewed by Chris Fleizach.
3349
3350         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3351         several more tests can pass.
3352
3353         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3354         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3355         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3356         (WebTestRunner):
3357         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3358         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3359         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3360         (AccessibilityUIElement):
3361
3362 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3363
3364         Build fix after r138045.
3365
3366         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3367         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
3368         is not explicitly specified. The condition was backwards but never matched so we
3369         always ran the test regardless of whether it's listed in the skipped list or not.
3370         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3371         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
3372
3373 2012-12-18  Emil A Eklund  <eae@chromium.org>
3374
3375         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
3376         https://bugs.webkit.org/show_bug.cgi?id=105332
3377         
3378         Reviewed by Levi Weintraub.
3379         
3380         Create new test suite for LayoutUnit tests as the KURL tests are
3381         of the incompatible TEST_F type.
3382
3383         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3384         (TestWebKitAPI):
3385         (TestWebKitAPI::TEST_F):
3386
3387 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3388
3389         Running a skipped test with run-perf-tests could alert the user
3390         https://bugs.webkit.org/show_bug.cgi?id=105219
3391
3392         Reviewed by Eric Seidel.
3393
3394         Force run skipped performance tests explicitly specified in the command line.
3395         Also warn the user when the specified paths don't exist.
3396
3397         * Scripts/webkitpy/layout_tests/port/base.py:
3398         (Port.relative_test_filename):
3399         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3400         (PerfTestsRunner._parse_args):
3401         (PerfTestsRunner._collect_tests):
3402         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3403         (test_collect_tests_with_skipped_list_and_files):
3404
3405 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
3406
3407         Chrome Android java output is too verbose
3408         https://bugs.webkit.org/show_bug.cgi?id=105247
3409
3410         Reviewed by Tony Chang.
3411
3412         Pass -quiet to ant to suppress extraneous output.
3413
3414         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3415         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3416
3417 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3418
3419         Consider removing --pause-before-testing option
3420         https://bugs.webkit.org/show_bug.cgi?id=105248
3421
3422         Reviewed by Eric Seidel.
3423
3424         Remove --pause-before-testing option.
3425
3426         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3427         (DriverProxy.start): Removed.
3428         * Scripts/webkitpy/performance_tests/perftest.py:
3429         (PerfTest.__init__):
3430         (PerfTest.test_path): Renamed from path_or_url.
3431         (PerfTest.run):
3432         (PerfTest): Removed "driver" argument.
3433         (PerfTest._run_with_driver):
3434         (PerfTest.run_single):
3435         (ChromiumStylePerfTest.__init__):
3436         (PageLoadingPerfTest.__init__):
3437         (PageLoadingPerfTest.run_single):
3438         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3439         (ReplayPerfTest.__init__):
3440         (ReplayPerfTest.prepare):
3441         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3442         (TestPageLoadingPerfTest.test_run):
3443         (TestPageLoadingPerfTest.test_run_with_memory_output):
3444         (TestPageLoadingPerfTest.test_run_with_bad_output):
3445         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3446         (PerfTestsRunner._parse_args):
3447         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3448         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3449         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3450         (run_test):
3451         (test_run_test_pause_before_testing): Removed.
3452
3453 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3454
3455         [GTK] Tests that time out are not considered as failures.
3456         https://bugs.webkit.org/show_bug.cgi?id=105318
3457
3458         Reviewed by Martin Robinson.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3461         (RunGtkAPITests.commandComplete):
3462         Consider log lines that end with TIMEOUT as errors.
3463
3464         * Scripts/run-gtk-tests:
3465         (TestRunner.run_tests):
3466         Consider timeouts as failures when returning the number of failed
3467         tests.
3468
3469 2012-12-18  Pravin D  <pravin.d@samsung.com>
3470
3471         Unreviewed, adding secondary email.
3472
3473         * Scripts/webkitpy/common/config/committers.py:
3474
3475 2012-12-18  Pravin D  <pravin.d@samsung.com>
3476
3477         Unreviewed, promoting myself to committer's list.
3478
3479         * Scripts/webkitpy/common/config/committers.py:
3480
3481 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3482
3483         [EFL] ImageDiff does not build on WebKit2 only builds
3484         https://bugs.webkit.org/show_bug.cgi?id=105288
3485
3486         Reviewed by Kenneth Rohde Christiansen.
3487
3488         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3489         the folder with things which are EFL-specific.
3490
3491         ImageDiff will be built by default now regardless of WebKit API flavor
3492         you choose.
3493
3494         * CMakeLists.txt:
3495         * DumpRenderTree/efl/CMakeLists.txt:
3496         * efl/ImageDiff/CMakeLists.txt: Added.
3497         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3498
3499 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3500
3501         [EFL][WK2] When creating new windows, use the opener's context
3502         https://bugs.webkit.org/show_bug.cgi?id=105283
3503
3504         Reviewed by Laszlo Gombos.
3505
3506         Use the context of the opener if exists.
3507
3508         * MiniBrowser/efl/main.c:
3509         (on_key_down):
3510         (on_window_create):
3511         (window_create):
3512         (elm_main):
3513
3514 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3515
3516         [EFL][WK2] Gardening of TestWebKitAPI tests
3517         https://bugs.webkit.org/show_bug.cgi?id=105268
3518
3519         Reviewed by Kenneth Rohde Christiansen.
3520
3521         Some tests were marked as failing but are passing and the newly added
3522         LayoutUnit should have it's own binary because it conflicts with the
3523         fixture used by KURL and is failing on the bots because of that.
3524
3525         * TestWebKitAPI/CMakeLists.txt:
3526         * TestWebKitAPI/PlatformEfl.cmake:
3527
3528 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3529
3530         [chromium] move webintent related methods to TestRunner library
3531         https://bugs.webkit.org/show_bug.cgi?id=105164
3532
3533         Reviewed by Darin Fisher.
3534
3535         Also deleted the unused deliveredIntentFailure and
3536         deliveredIntentResult methods.
3537
3538         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3539         (DRTTestRunner::DRTTestRunner):
3540         * DumpRenderTree/chromium/DRTTestRunner.h:
3541         (DRTTestRunner):
3542         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3543         (WebKit):
3544         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3545         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3546         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3547         (WebKit):
3548         (WebTestProxyBase):
3549         (WebTestRunner::WebTestProxy::registerIntentService):
3550         (WebTestRunner::WebTestProxy::dispatchIntent):
3551         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3552         (WebTestRunner::TestRunner::TestRunner):
3553         (WebTestRunner::TestRunner::sendWebIntentResponse):
3554         (WebTestRunner):
3555         (WebTestRunner::TestRunner::deliverWebIntent):
3556         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3557         (TestRunner):
3558         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3559         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3560         (WebTestRunner::WebTestProxyBase::registerIntentService):
3561         (WebTestRunner):
3562         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3563         * DumpRenderTree/chromium/WebViewHost.cpp:
3564         (WebViewHost::setCurrentWebIntentRequest):
3565         (WebViewHost::currentWebIntentRequest):
3566         * DumpRenderTree/chromium/WebViewHost.h:
3567         (WebKit):
3568         (WebViewHost):
3569
3570 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3571
3572         [chromium] move editing callback dumping to the WebTestProxy
3573         https://bugs.webkit.org/show_bug.cgi?id=105013
3574
3575         Reviewed by Darin Fisher.
3576
3577         To decide whether or not to dump the editing callbacks, the WebTestProxy
3578         needs to query the TestRunner. For this purpose, I introduce a
3579         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3580         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3581         an interface, and it is not owned by the WebTestInterfaces, but the
3582         embedder of the TestRunner library must provide it. This will change
3583         once all TestRunner methods are in the library.
3584
3585         * DumpRenderTree/DumpRenderTree.gypi:
3586         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3587         (DRTTestRunner::DRTTestRunner):
3588         (DRTTestRunner::reset):
3589         * DumpRenderTree/chromium/DRTTestRunner.h:
3590         (DRTTestRunner):
3591         (DRTTestRunner::taskList):
3592         (DRTTestRunner::WorkQueue::taskList):
3593         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3594         (WebTestRunner):
3595         (WebTestInterfaces):
3596         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3597         (WebKit):
3598         (WebTestRunner):
3599         (WebTestProxyBase):
3600         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3601         (WebTestRunner::WebTestProxy::shouldEndEditing):
3602         (WebTestRunner::WebTestProxy::shouldInsertNode):
3603         (WebTestRunner::WebTestProxy::shouldInsertText):
3604         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3605         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3606         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3607         (WebTestRunner::WebTestProxy::didBeginEditing):
3608         (WebTestRunner::WebTestProxy::didChangeSelection):
3609         (WebTestRunner::WebTestProxy::didChangeContents):
3610         (WebTestRunner::WebTestProxy::didEndEditing):
3611         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3612         (WebTestRunner):
3613         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3614         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3615         (WebTestRunner::TestRunner::TestRunner):
3616         (WebTestRunner::TestRunner::~TestRunner):
3617         (WebTestRunner):
3618         (WebTestRunner::TestRunner::reset):
3619         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3620         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3621         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3622         (TestRunner):
3623         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3624         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3625         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3626         (WebTestInterfaces::Internal):
3627         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3628         (WebTestRunner::WebTestInterfaces::testRunner):
3629         (WebTestRunner):
3630         (WebTestRunner::WebTestInterfaces::setTestRunner):
3631         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3632         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3633         (WebTestRunner):
3634         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3635         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3636         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3637         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3638         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3639         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3640         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3641         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3642         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3643         (WebTestRunner::WebTestProxyBase::didChangeContents):
3644         (WebTestRunner::WebTestProxyBase::didEndEditing):
3645         * DumpRenderTree/chromium/TestShell.cpp:
3646         (TestShell::initialize):
3647         (TestShell::createNewWindow):
3648         * DumpRenderTree/chromium/WebViewHost.cpp:
3649         (WebViewHost::shouldBeginEditing):
3650         (WebViewHost::shouldEndEditing):
3651         (WebViewHost::shouldInsertNode):
3652         (WebViewHost::shouldInsertText):
3653         (WebViewHost::shouldChangeSelectedRange):
3654         (WebViewHost::shouldDeleteRange):
3655         (WebViewHost::shouldApplyStyle):
3656         * DumpRenderTree/chromium/WebViewHost.h:
3657         (WebViewHost):
3658
3659 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3660
3661         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3662         https://bugs.webkit.org/show_bug.cgi?id=105154
3663
3664         Reviewed by Tony Chang.
3665
3666         If the settings are modified directly, the embedder can't keep track of
3667         them and might accidentially override the changed settings.
3668
3669         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3670         (WebPreferences):
3671         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3672         (WebTestRunner::TestRunner::TestRunner):
3673         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3674         (WebTestRunner):
3675         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3676         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3677         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3678         (TestRunner):
3679         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3680         (WebTestRunner::WebPreferences::reset):
3681         (WebTestRunner::WebPreferences::applyTo):
3682
3683 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3684
3685         Unreviewed unit test skipping.
3686
3687         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3688
3689         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3690         (TestWebKitAPI):
3691         (TestWebKitAPI::TEST):
3692
3693 2012-12-17  Dean Jackson  <dino@apple.com>
3694
3695         Unreviewed. Add Silvia Pfeiffer to contributor list.
3696
3697         * Scripts/webkitpy/common/config/committers.py:
3698
3699 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3700
3701         build.webkit.org - add more google windows bots
3702         https://bugs.webkit.org/show_bug.cgi?id=105225
3703
3704         Reviewed by Eric Seidel.
3705
3706         Adds two more windows bots (google-windows-3, a builder, and
3707         google-windows-4, a tester) for the Chromium configs.
3708
3709         * BuildSlaveSupport/build.webkit.org-config/config.json:
3710
3711 2012-12-17  Eric Seidel  <eric@webkit.org>
3712
3713         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3714         https://bugs.webkit.org/show_bug.cgi?id=105217
3715
3716         Reviewed by Dirk Pranke.
3717
3718         Previously --profile would fail strangely if find_unused_filename returned None
3719         (which would happen as soon as we had 100 report files).
3720         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3721         I also made some minor cleanups to the output of perf, and tried to make the
3722         commands more self-documenting by using long-names for args.
3723
3724         * Scripts/webkitpy/common/system/profiler.py:
3725         (SingleFileOutputProfiler.__init__):
3726         (Perf.attach_to_pid):
3727         (Perf.profile_after_exit):
3728
3729 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3730
3731         Unreviewed, rolling out r137198.
3732         http://trac.webkit.org/changeset/137198
3733         https://bugs.webkit.org/show_bug.cgi?id=105212
3734
3735         This patch is causing API behavior compatibility problems
3736         (Requested by zdobersek on #webkit).
3737
3738         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3739         (willSendRequestCallback):
3740
3741 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3742
3743         Unreviewed. Adding myself to committers list.
3744
3745         * Scripts/webkitpy/common/config/committers.py:
3746
3747 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3748
3749         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3750         https://bugs.webkit.org/show_bug.cgi?id=105078
3751
3752         Reviewed by Ojan Vafai.
3753
3754         This patch reorders functions so that run_webkit_tests can be
3755         understood in a top-down matter better, and to make things slightly
3756         more sensible when I merge manager.py into it.
3757
3758         Also, this adds tests for the actual main() routine, which had several
3759         bugs get through testing a week or two ago.
3760
3761         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3762         (main):
3763         (parse_args):
3764         (_set_up_derived_options):
3765         (run):
3766         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3767         (RunTest):
3768         (RunTest.test_no_http_tests):
3769         (PortTest.disabled_test_mac_lion):
3770         (MainTest):
3771         (MainTest.test_exception_handling):
3772         (MainTest.test_exception_handling.interrupting_run):
3773         (MainTest.test_exception_handling.successful_run):
3774         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3775         (MainTest.test_exception_handling.exception_raising_run):
3776
3777 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3778
3779         webkitpy: move --lint-test-files code into its own module
3780         https://bugs.webkit.org/show_bug.cgi?id=105077
3781
3782         Reviewed by Eric Seidel.
3783
3784         It really didn't need to be in run_webkit_tests.py anymore.
3785         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3786         rwt --lint-test-files is still supported for backwards compatibility
3787         for now.
3788
3789         * Scripts/lint-test-expectations: Added.
3790         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3791         (lint):
3792         (main):
3793         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3794         (FakePort):
3795         (FakePort.__init__):
3796         (FakePort.test_configuration):
3797         (FakePort.expectations_dict):
3798         (FakePort.skipped_layout_tests):
3799         (FakePort.all_test_configurations):
3800         (FakePort.configuration_specifier_macros):
3801         (FakePort.get_option):
3802         (FakeFactory):
3803         (FakeFactory.__init__):
3804         (FakeFactory.get):
3805         (FakeFactory.all_port_names):
3806         (LintTest):
3807         (LintTest.test_all_configurations):
3808         (LintTest.test_lint_test_files):
3809         (LintTest.test_lint_test_files__errors):
3810         (MainTest):
3811         (MainTest.test_success):
3812         (MainTest.test_success.interrupting_lint):
3813         (MainTest.test_success.successful_lint):
3814         (MainTest.test_success.exception_raising_lint):
3815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3816         (main):
3817         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3818         (StreamTestingMixin.assertNotEmpty):
3819
3820 2012-12-17  Adam Klein  <adamk@chromium.org>
3821
3822         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3823         https://bugs.webkit.org/show_bug.cgi?id=105072
3824
3825         Reviewed by Laszlo Gombos.
3826
3827         * Scripts/webkitperl/FeatureList.pm:
3828
3829 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3830
3831         Add some unit testing for WTF::clampTo* functions
3832         https://bugs.webkit.org/show_bug.cgi?id=105060
3833
3834         Reviewed by Emil A Eklund.
3835
3836         The new tests are targeted at clamping to int / unsigned and float as those are
3837         the one explicitely exposed through more dedicated functions (like clampToInteger,
3838         clampToPositiveInteger and clampToFloat).
3839
3840         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3841
3842 2012-12-17  Eric Seidel  <eric@webkit.org>
3843
3844         rpt --profile --chromium-android throws exception
3845         https://bugs.webkit.org/show_bug.cgi?id=105061
3846
3847         Reviewed by Daniel Bates.
3848
3849         Somehow popen(args) got turned into popen(*args) at some point,
3850         which caused my new stringify code to fail when args was passed by name.
3851         Fixed and tested.
3852
3853         * Scripts/webkitpy/common/system/executive.py:
3854         (Executive._stringify_args):
3855         (Executive):
3856         (Executive.popen):
3857         * Scripts/webkitpy/common/system/executive_unittest.py:
3858         (ExecutiveTest.test_popen_args):
3859
3860 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3861
3862         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3863         https://bugs.webkit.org/show_bug.cgi?id=105054
3864
3865         Reviewed by Jochen Eisinger.
3866
3867         Part of a refactoring series; see tracking bug 82948.
3868
3869         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3870         (NotificationPresenter::show):
3871         * DumpRenderTree/chromium/Task.cpp:
3872         (postTask):
3873         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3874
3875 2012-12-17  Emil A Eklund  <eae@chromium.org>
3876
3877         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3878         https://bugs.webkit.org/show_bug.cgi?id=104955
3879
3880         Reviewed by Julien Chaffraix.
3881
3882         Add tests for LayoutUnit.
3883
3884         * TestWebKitAPI/CMakeLists.txt:
3885         * TestWebKitAPI/ForwardingHeaders: Added.
3886         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3887         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3888         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3889         * TestWebKitAPI/TestWebKitAPI.gypi:
3890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3891         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3892         (TestWebKitAPI):
3893         (TestWebKitAPI::TEST):
3894         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3895
3896 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3897
3898         [chromium] removed unused preferences from testRunner.overridePreference
3899         https://bugs.webkit.org/show_bug.cgi?id=105169
3900
3901         Reviewed by Tony Chang.
3902
3903         Most notably this removes the code related to font family maps which is
3904         now handled via window.internals.settings
3905
3906         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3907         (WebPreferences):
3908         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3909         (WebTestRunner::TestRunner::overridePreference):
3910         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3911         (TestRunner):
3912         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3913         (WebTestRunner::WebPreferences::applyTo):
3914
3915 2012-12-17  James Robinson  <jamesr@chromium.org>
3916
3917         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3918         https://bugs.webkit.org/show_bug.cgi?id=105071
3919
3920         Reviewed by Adrienne Walker.
3921
3922         Update WebViewHost for the new WebWidgetClient interface.
3923
3924         * DumpRenderTree/chromium/WebViewHost.cpp:
3925         (WebViewHost::initializeLayerTreeView):
3926         (WebViewHost::layerTreeView):
3927         (WebViewHost::~WebViewHost):
3928         * DumpRenderTree/chromium/WebViewHost.h:
3929         (WebViewHost):
3930
3931 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3932
3933         [EFL][WK2] window_create doesn't receive the url
3934         https://bugs.webkit.org/show_bug.cgi?id=105184
3935
3936         Reviewed by Alexis Menard.
3937
3938         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3939         (on_window_create):
3940
3941 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3942
3943         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3944         https://bugs.webkit.org/show_bug.cgi?id=105026
3945
3946         Reviewed by Yury Semikhatsky.
3947
3948         Old SFINAE test was replaced with new one based on this article:
3949         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3950
3951         New test which covers this problem was added.
3952
3953         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3954
3955 2012-12-17  Anthony Scian  <ascian@rim.com>
3956
3957         [Blackberry] Static code analysis warning fixes
3958         https://bugs.webkit.org/show_bug.cgi?id=105129
3959
3960         Reviewed by Rob Buis.
3961
3962         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3963
3964         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3965         (BlackBerry::WebKit::createFile):
3966         (BlackBerry::WebKit::DumpRenderTree::runTest):
3967
3968 2012-12-17  John Mellor  <johnme@chromium.org>
3969
3970         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3971         https://bugs.webkit.org/show_bug.cgi?id=105025
3972
3973         Unreviewed. Adds two contributors to committers.py.
3974         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3975
3976         * Scripts/webkitpy/common/config/committers.py:
3977
3978 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3979
3980         Unreviewed, add myself to committers.py.
3981
3982         * Scripts/webkitpy/common/config/committers.py:
3983
3984 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3985
3986         [Qt] remove some unnecessary CONFIG additions
3987
3988         Reviewed by Simon Hausmann.
3989
3990         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3991         default_pre.prf.
3992
3993         * qmake/mkspecs/features/default_post.prf:
3994
3995 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3996
3997         Unreviewed, rolling out r137892.
3998         http://trac.webkit.org/changeset/137892
3999         https://bugs.webkit.org/show_bug.cgi?id=105026
4000
4001         it broke compilation on windows
4002
4003         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4004
4005 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
4006
4007         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
4008         https://bugs.webkit.org/show_bug.cgi?id=105026
4009
4010         Reviewed by Yury Semikhatsky.
4011
4012         Old SFINAE test was replaced with new one based on this article:
4013         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
4014
4015         New test which covers this problem was added.
4016
4017         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4018
4019 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
4020
4021         [Qt] rely on automatic output directory setup
4022
4023         Reviewed by Simon Hausmann.
4024
4025         Now being a proper qt module (by virtue of having load(qt_build_config)
4026         in .qmake.conf), webkit gets the path setup goodies for free.
4027
4028         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
4029         at the same time, instead of the debug and release version ending up in different
4030         directories as they should.
4031
4032         * qmake/mkspecs/features/default_pre.prf:
4033
4034 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
4035
4036         [BlackBerry] Need to re-enable video track
4037         https://bugs.webkit.org/show_bug.cgi?id=105155
4038
4039         Reviewed by George Staikos.
4040
4041         Just enable Video Track for BlackBerry.
4042
4043         * Scripts/webkitperl/FeatureList.pm:
4044
4045 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
4046
4047         Unreviewed. Added myself to committers.py
4048
4049         * Scripts/webkitpy/common/config/committers.py:
4050
4051 2012-12-17  Jonathan Liu  <net147@gmail.com>
4052
4053         Fix linking of libraries with -Wl,-whole-archive
4054         https://bugs.webkit.org/show_bug.cgi?id=104436
4055
4056         Reviewed by Simon Hausmann.
4057
4058         If there is more than one library in LIBS linked with
4059         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
4060         merge the duplicate flags in LIBS which causes linking to fail.
4061
4062         Add no_smart_library_merge to CONFIG to prevent the duplicate
4063         flags from being removed when using -Wl,-whole-archive.
4064
4065         * qmake/mkspecs/features/functions.prf:
4066
4067 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
4068
4069         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
4070         https://bugs.webkit.org/show_bug.cgi?id=105143
4071         RIM PR 171941
4072
4073         Reviewed by Rob Buis.
4074         Internally reviewed by George Staikos.
4075
4076         Adapt to new method names and encapsulation of TouchPoint data members.
4077
4078         * DumpRenderTree/blackberry/EventSender.cpp:
4079         (addTouchPointCallback):
4080         (updateTouchPointCallback):
4081         (touchEndCallback):
4082         (releaseTouchPointCallback):
4083         (sendTouchEvent):
4084
4085 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
4086
4087         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
4088         https://bugs.webkit.org/show_bug.cgi?id=105148
4089
4090         Reviewed by Filip Pizlo.
4091
4092         Usage examples:
4093         
4094         $ sampstat --help
4095         Usage: sampstat [options] [FILES]
4096           Compute the mean and 95% confidence interval of a sample set.
4097           Standard input or files must contain two or more decimal numbers, one per line.
4098         
4099         Options:
4100           -h, --help            show this help message and exit
4101           -u UNIT, --unit=UNIT  assume values are in units of UNIT
4102           -v, --verbose         print all values (with units)
4103         
4104         $ sampstat -u MB memresults.txt
4105         2356.90 MB +/- 101.34 MB (4.3%)
4106         
4107         $ sampstat -v -u MB memresults.txt
4108               2318.21 MB
4109               2399.56 MB
4110               2352.93 MB
4111         ----------------
4112         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
4113         
4114
4115         * Scripts/sampstat: Added.
4116         (sum): Helper function to compute the sum of a list.
4117         (arithmeticMean): Compute the meam of a list.
4118         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
4119         (standardError): Compute the sample standard error.
4120         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval. 
4121         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
4122
4123 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
4124
4125         [BlackBerry] Pass key modifiers with touch and mouse events
4126         https://bugs.webkit.org/show_bug.cgi?id=105108
4127
4128         Reviewed by Rob Buis.
4129
4130         Update DRT to new api.
4131
4132         Internally reviewed by Gen Mak.
4133
4134         * DumpRenderTree/blackberry/EventSender.cpp:
4135         (mouseDownCallback):
4136         (mouseUpCallback):
4137         (mouseMoveToCallback):
4138
4139 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
4140
4141         Stop the XvfbDriver before proceeding with its starting setup
4142         https://bugs.webkit.org/show_bug.cgi?id=105006
4143
4144         Reviewed by Philippe Normand.
4145
4146         Just as with the base Driver implementation, stop the XvfbDriver
4147         before proceeding with setting up lock files and a new Xvfb instance.
4148         This forces any driver or Xvfb instances that are currently under
4149         the driver's control to be closed/killed and cleaned up after.
4150
4151         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
4152         (XvfbDriver._start):
4153
4154 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
4155
4156         webkitpy: make port_name a required parameter to the non-test ports
4157         https://bugs.webkit.org/show_bug.cgi?id=105057
4158
4159         Reviewed by Eric Seidel.
4160
4161         This is just minor code cleanup along the path to making Port
4162         constructors simpler and pushing more logic into the port factory.
4163
4164         * Scripts/webkitpy/layout_tests/port/base.py:
4165         (Port.__init__):
4166         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4167         (PortTest.make_port):
4168         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4169         (TestWebKitPort.__init__):
4170         * Scripts/webkitpy/layout_tests/port/test.py:
4171         (TestPort):
4172         (TestPort.determine_full_port_name):
4173         (TestPort.__init__):
4174         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
4175         (XvfbDriverTest.make_driver):
4176         (XvfbDriverTest.test_stop):
4177
4178 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
4179
4180         garden-o-matic doesn't know about reftests
4181         https://bugs.webkit.org/show_bug.cgi?id=101976
4182
4183         Reviewed by Eric Seidel.
4184
4185         Attempt to make garden-o-matic properly aware of reftests again.
4186
4187         This is re-landing r137407 with a change to
4188         rebaselineWithStatusUpdates() to actually pass the filtered
4189         failureInofLost to checkout.rebaseline().
4190
4191         Unfortunately, the testing coverage for this whole module is almost
4192         non-existent, and it's not obvious that there's a good way to
4193         stub out checkout.rebaseline() to test that the right thing
4194         happens. I verified the change manually.
4195
4196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4197         (.):
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4199         (.):
4200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
4201
4202 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4203
4204         "Running 1 DumpRenderTree over X shards" is not a helpful output
4205         https://bugs.webkit.org/show_bug.cgi?id=104858
4206
4207         Reviewed by Dirk Pranke.
4208
4209         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
4210         contributors who typically don't have much experience on distributed computations and databases.
4211         So only print this message out in the debug mode.
4212
4213         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4214         * Scripts/webkitpy/layout_tests/views/printing.py:
4215         (Printer.print_workers_and_shards):
4216
4217 2012-12-13  Eric Seidel  <eric@webkit.org>
4218
4219         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
4220         https://bugs.webkit.org/show_bug.cgi?id=104891
4221
4222         Reviewed by Ryosuke Niwa.
4223
4224         I also implemented a very simple "Sample" Profiler using
4225         Mac OS X's /usr/bin/sample command line tool.
4226
4227         The real reason for this abstraction is to make it easy
4228         to support both perf and pprof on linux which seem to
4229         be about equally popular among those I ask in the Chrome team.
4230
4231         * Scripts/webkitpy/common/system/profiler.py:
4232         (ProfilerFactory.create_profiler):
4233         (ProfilerFactory):
4234         (ProfilerFactory.available_profilers_by_name):
4235         (ProfilerFactory.default_profiler_name):
4236         (Sample):
4237         (Sample.__init__):
4238         (Sample.attach_to_pid):
4239         (Sample.profile_after_exit):
4240         (IProfiler.attach_to_pid):
4241         * Scripts/webkitpy/layout_tests/port/driver.py:
4242         (Driver.__init__):
4243         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4244         (PerfTestsRunner._parse_args):
4245
4246 2012-12-13  Eric Seidel  <eric@webkit.org>
4247
4248         Unreviewed, fixing typo in python unittest.
4249
4250         I changed the default profiler on linux from pprof to perf in
4251         bug 104971.  I failed to update the unittest results at that time.
4252
4253         * Scripts/webkitpy/common/system/profiler_unittest.py:
4254         (ProfilerFactoryTest.test_basic):
4255
4256 2012-12-13  Ian Vollick  <vollick@chromium.org>
4257
4258         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
4259         https://bugs.webkit.org/show_bug.cgi?id=104911
4260
4261         Reviewed by Dirk Pranke.
4262
4263         Adds two virtual tests suites to run the tests in
4264         compositing/overflow/ and scrollbars/ with the flag
4265         --enable-accelerated-overflow-scroll, which I've also plumbed through
4266         in the usual way.
4267
4268         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4269         (main):
4270         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
4271         (WebPreferences):
4272         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4273         (WebTestRunner::WebPreferences::reset):
4274         (WebTestRunner::WebPreferences::applyTo):
4275         * DumpRenderTree/chromium/TestShell.cpp:
4276         (TestShell::TestShell):
4277         (TestShell::resetWebSettings):
4278         * DumpRenderTree/chromium/TestShell.h:
4279         (TestShell::setAcceleratedCompositingForOverflowScrollEnabled):
4280         (TestShell):
4281         * Scripts/webkitpy/layout_tests/port/chromium.py:
4282         (ChromiumPort.virtual_test_suites):
4283
4284 2012-12-13  Eric Seidel  <eric@webkit.org>
4285
4286         Use 'perf' to profile on linux instead of google-pprof by default
4287         https://bugs.webkit.org/show_bug.cgi?id=104971
4288
4289         Reviewed by Dirk Pranke.
4290
4291         This makes Chromium Linux match Chromium Android and use the perf
4292         tool by default.  Once https://bugs.webkit.org/show_bug.cgi?id=104891
4293         lands it will be possible to use pprof again on Linux.
4294
4295         This is slightly more advanced than the AndroidPerf profiler as
4296         instead of using a timeout on "perf record" I instead watch