Make a builder group support+expect multiple loads.
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-04  Chase Phillips  <cmp@google.com>
2
3         Make a builder group support+expect multiple loads.
4         https://bugs.webkit.org/show_bug.cgi?id=88260
5
6         Change BuilderGroup to allow expecting multiple
7         loads.  This allows merging results for a given set
8         of builders into one group.
9
10         Add a test that verifies that the group count
11         increments correctly based on successful and failed
12         list loads.
13
14         Reviewed by Ojan Vafai.
15
16         * TestResultServer/static-dashboards/builders.js:
17         (BuilderGroup):
18         (BuilderGroup.prototype.setbuilder):
19         (BuilderGroup.prototype.append):
20         (BuilderGroup.prototype.loaded):
21         (requestBuilderList.xhr.onload):
22         (requestBuilderList.xhr.onerror):
23         (onErrorLoadingBuilderList):
24         (loadBuildersList):
25         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
26         (test):
27         * TestResultServer/static-dashboards/run-unittests.html:
28
29 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
30
31         Python test fix attempt for Chromium Windows.
32
33         * Scripts/webkitpy/layout_tests/port/driver.py:
34         (Driver.uri_to_test):
35
36 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
37
38         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
39         https://bugs.webkit.org/show_bug.cgi?id=88243
40
41         Reviewed by Adam Barth.
42
43         * qmake/mkspecs/features/features.prf:
44
45 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
46
47         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
48         https://bugs.webkit.org/show_bug.cgi?id=88280
49
50         Unreviewed, build fix.
51
52         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
53         (TestServerProcess.test_basic):
54
55 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
56
57         test-webkitpy is hanging under cygwin
58         https://bugs.webkit.org/show_bug.cgi?id=88269
59
60         Reviewed by Ryosuke Niwa.
61
62         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
63         so we need to skip any tests that use it.
64
65         * Scripts/webkitpy/common/system/executive.py:
66         (Executive.run_in_parallel):
67         * Scripts/webkitpy/common/system/executive_unittest.py:
68         (ExecutiveTest.test_run_in_parallel):
69
70 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
71
72         test-webkitpy is failing on win32 after r115054
73         https://bugs.webkit.org/show_bug.cgi?id=88264
74
75         Reviewed by Ryosuke Niwa.
76
77         The failing http_server test was improperly suppressed (the
78         tuple was missing a comma, and so wasn't a tuple at all, just a
79         string) and so we were skipping *all* tests on win32. The right
80         way to skip a single test is to disable it inside the test
81         itself.
82
83         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
84         (TestHttpServer.test_start_cmd):
85         * Scripts/webkitpy/test/test_finder.py:
86         (TestFinder._default_names):
87         * Scripts/webkitpy/test/main.py:
88         (Tester.run): Add error message if we don't find any tests to run.
89         * Scripts/webkitpy/test/main_unittest.py:
90             
91
92 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
93
94         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
95         https://bugs.webkit.org/show_bug.cgi?id=88215
96
97         Reviewed by Martin Robinson.
98
99         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
100         for newly allocated strings.
101
102         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
103         (attributeSetToString):
104         (AccessibilityUIElement::allAttributes):
105
106 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
107
108         [GTK] Memory leaks in DumpRenderTree.cpp
109         https://bugs.webkit.org/show_bug.cgi?id=88213
110
111         Reviewed by Martin Robinson.
112
113         Fixed memory leaks in DumpRenderTree.
114
115         * DumpRenderTree/gtk/DumpRenderTree.cpp:
116         (appendString): Accepts const gchar* as the second argument.
117         (dumpFramesAsText): Free the string returned by g_strdup_printf().
118         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
119
120 2012-06-04  David Dorwin  <ddorwin@chromium.org>
121
122         Enable Chromium media player to instantiate a plugin
123         https://bugs.webkit.org/show_bug.cgi?id=87399
124
125         Reviewed by Kent Tamura.
126
127         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
128
129         * DumpRenderTree/chromium/WebViewHost.cpp:
130         (WebViewHost::createPopupMenu):
131
132 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
133
134         [GTK][WK2] Implement geolocation provider for the GTK port
135         https://bugs.webkit.org/show_bug.cgi?id=83877
136
137         Reviewed by Carlos Garcia Campos.
138
139         * gtk/generate-gtkdoc:
140         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
141
142 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
143
144         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
145         https://bugs.webkit.org/show_bug.cgi?id=87668
146
147         Reviewed by Ryosuke Niwa.
148
149         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
150         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
151         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
152
153         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
154         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
155
156 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
157
158         [EFL] Refactor ewk_view_context_paint code.
159         https://bugs.webkit.org/show_bug.cgi?id=85588
160
161         Reviewed by Hajime Morita.
162
163         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
164
165 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
166
167         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
168         https://bugs.webkit.org/show_bug.cgi?id=87869
169
170         Reviewed by Andreas Kling.
171
172         Replace %lld by PRId64 macro to print an int64_t value and silent a
173         compilation warning on 64-Bit.
174
175         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
176         (onExceededApplicationCacheQuota):
177
178 2012-06-03  Varun Jain  <varunjain@google.com>
179
180         [chromium] Add new gesture type (two finger tap) that triggers context menu.
181         https://bugs.webkit.org/show_bug.cgi?id=88173
182
183         Reviewed by Adam Barth.
184
185         * DumpRenderTree/chromium/EventSender.cpp:
186         (EventSender::EventSender):
187         (EventSender::gestureTwoFingerTap):
188         (EventSender::gestureEvent):
189         * DumpRenderTree/chromium/EventSender.h:
190         (EventSender):
191
192 2012-06-02  Zeno Albisser  <zeno@webkit.org>
193
194         Fix and enable WebGL for WebKit2 on Qt.
195         https://bugs.webkit.org/show_bug.cgi?id=86214
196
197         Enable WebGL by default for Qt MiniBrowser.
198
199         Reviewed by Noam Rosenthal.
200
201         * MiniBrowser/qt/qml/BrowserWindow.qml:
202
203 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
204
205         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
206         https://bugs.webkit.org/show_bug.cgi?id=88164
207
208         Reviewed by Kentaro Hara.
209
210         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
211         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
212
213         * Scripts/VCSUtils.pm:
214         (adjustPathForRecentRenamings):
215         (fixChangeLogPatch):
216
217 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
218
219         Rename test_expectations.txt to TestExpectations
220         https://bugs.webkit.org/show_bug.cgi?id=86690
221
222         Reviewed by Dirk Pranke.
223
224         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
225         We can the code to read test_expectations.txt once we've successfully transitioned.
226
227         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
228         (TestExpectationParser._check_path_does_not_exist):
229         (TestExpectationParser._tokenize):
230         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
231         * Scripts/webkitpy/layout_tests/port/base.py:
232         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
233         test_expectations.txt if one exists and the path to TestExpectations otherwise.
234         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
235         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
236         virtual.
237         * Scripts/webkitpy/layout_tests/port/chromium.py:
238         (ChromiumPort.path_from_chromium_base):
239         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
240         (ChromiumAndroidPort.test_expectations):
241         * Scripts/webkitpy/layout_tests/port/test.py:
242         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
243         (TestPort.__init__):
244         * Scripts/webkitpy/layout_tests/port/webkit.py:
245         (WebKitPort.baseline_search_path):
246         (WebKitPort.test_expectations):
247         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
248         tests to base as a follow up.
249         (WebKitPortTest.test_path_to_test_expectations_file):
250         (test_test_expectations):
251         (test_legacy_test_expectations):
252         * Scripts/webkitpy/style/checker.py:
253         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
254         with one for TestExpectations.
255         * Scripts/webkitpy/style/checkers/test_expectations.py:
256         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
257         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
258         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
259         test_expectations.txt.
260         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
261         (TestExpectationsTestCase.assert_lines_lint):
262         * Scripts/webkitpy/tool/commands/queries.py:
263         (PrintExpectations.__init__):
264         * Scripts/webkitpy/tool/commands/rebaseline.py:
265         (RebaselineExpectations):
266         * Scripts/webkitpy/tool/steps/commit.py:
267         (Commit._check_test_expectations):
268         * Scripts/webkitpy/tool/steps/commit_unittest.py:
269         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
270         (CommitTest.test_check_test_expectations): For TestExpectations.
271         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
272         * TestResultServer/static-dashboards/dashboard_base.js:
273         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
274         Error only when neither exists.
275         * TestResultServer/static-dashboards/flakiness_dashboard.js:
276         (processMissingAndExtraExpectations):
277         (htmlForTestsWithExpectationsButNoFailures):
278         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
279
280 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
281
282         Remove dependency from ImageDiff to WTF
283         https://bugs.webkit.org/show_bug.cgi?id=88147
284
285         Reviewed by Adam Barth.
286
287         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
288
289 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
290
291         NRWT seems to leak (more?) temp dirs
292         https://bugs.webkit.org/show_bug.cgi?id=88126
293
294         Re-land r119297 with chromium fix (weren't calling the
295         super() method if not in --test-shell mode in start().
296         Add unit tests to chromium_unittest as well to check.
297
298         * Scripts/webkitpy/layout_tests/port/chromium.py:
299         (ChromiumDriver.start):
300         * Scripts/webkitpy/layout_tests/port/webkit.py:
301         (WebKitDriver.__del__):
302         (WebKitDriver._start):
303         (WebKitDriver.run_test):
304         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
305         (WebKitDriverTest.test_check_for_driver_crash):
306         (WebKitDriverTest.test_stop_cleans_up_properly):
307         (WebKitDriverTest):
308         (WebKitDriverTest.test_two_starts_cleans_up_properly):
309         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
310         (ChromiumDriverTest.test_stop_cleans_up_properly):
311         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
312
313 2012-06-01  Tim Horton  <timothy_horton@apple.com>
314
315         Lots of "failed download-built-product" on Apple bots
316         https://bugs.webkit.org/show_bug.cgi?id=88158
317
318         Reviewed by Jessie Berlin.
319         
320         Disable mergeRequests on all Apple builders. This is a speculative fix.
321
322         * BuildSlaveSupport/build.webkit.org-config/config.json:
323
324 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
325
326         Unreviewed, rolling out r119297.
327         http://trac.webkit.org/changeset/119297
328         https://bugs.webkit.org/show_bug.cgi?id=88156
329
330         May have broken Chromium bots (Requested by rniwa on #webkit).
331
332         * Scripts/webkitpy/layout_tests/port/webkit.py:
333         (WebKitDriver.__del__):
334         (WebKitDriver.run_test):
335         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
336         (WebKitDriverTest.test_check_for_driver_crash):
337         (WebKitDriverTest.test_stop_cleans_up_properly):
338
339 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
340
341         nrwt seems to leak tmpdirs
342         https://bugs.webkit.org/show_bug.cgi?id=88126
343
344         Reviewed by Ojan Vafai.
345
346         Fix leak possibly introduced in r118979 - we now will
347         make sure we clean up any stale temp directories during the
348         start routine and attempt to clean up again in __del__. It
349         turns out that asserting in __del__ logs a message but is
350         caught by the runtime, so it's mostly useless.
351
352         * Scripts/webkitpy/layout_tests/port/webkit.py:
353         (WebKitDriver.__del__):
354         (WebKitDriver._start):
355         (WebKitDriver.run_test):
356         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
357         (WebKitDriverTest.test_check_for_driver_crash):
358         (WebKitDriverTest.test_stop_cleans_up_properly):
359         (WebKitDriverTest):
360         (WebKitDriverTest.test_two_starts_cleans_up_properly):
361
362 2012-06-01  Michael Saboff  <msaboff@apple.com>
363
364         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
365         https://bugs.webkit.org/show_bug.cgi?id=88109
366
367         Reviewed by Geoffrey Garen.
368
369         Additional test case.
370
371         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
372         (TestWebKitAPI::TEST):
373
374 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
375
376         [Qt] Use -Werror only in developer builds
377
378         Rubber-stamped by Tor Arne Vestbø.
379
380         In production builds -Werror with custom toolchains and wierd system
381         headers, -Werror is of no use and just creates confusion. So use it
382         only if Qt is configured with -developer-build.
383
384         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
385         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
386         only if qt_developer_build is set.
387
388 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
389
390         [watchlist] Add myself to loader and v8 bindings changes
391         https://bugs.webkit.org/show_bug.cgi?id=88112
392
393         Reviewed by Adam Barth.
394
395         * Scripts/webkitpy/common/config/watchlist:
396
397 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
398
399         Adding Jacky Jiang to committers.py
400         https://bugs.webkit.org/show_bug.cgi?id=88122
401
402         Reviewed by Rob Buis.
403
404         Adding myself to committers.py as a Committer.
405
406         * Scripts/webkitpy/common/config/committers.py:
407
408 2012-06-01  Jessie Berlin  <jberlin@apple.com>
409
410         Fix Windows build.
411
412         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
413
414 2012-06-01  Jessie Berlin  <jberlin@apple.com>
415
416         Windows WK2 MouseMoveAfterCrash API test failing
417         https://bugs.webkit.org/show_bug.cgi?id=69982
418
419         Disable the test on Windows to get the bots greener.
420
421         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
422         (TestWebKitAPI::TEST):
423
424 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
425
426         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
427         https://bugs.webkit.org/show_bug.cgi?id=86866
428
429         Reviewed by Adam Barth.
430
431         Catch new "intent,service,register" signal on the frame and print out
432         information about the Web Intent service in EFL's DumpRenderTree.
433
434         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
435         (DumpRenderTreeChrome::createView):
436         (DumpRenderTreeChrome::onFrameCreated):
437         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
438         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
439         (DumpRenderTreeChrome):
440
441 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
442
443         The ChangeLog parser cannot handle reviewers with initials in their name
444         https://bugs.webkit.org/show_bug.cgi?id=87864
445
446         Reviewed by Ryosuke Niwa.
447
448         Add support in the ChangeLog parser for reviewer names that have
449         initials in them.
450
451         * Scripts/webkitpy/common/checkout/changelog.py:
452         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
453         in the replacement string. This allows for matching the word characters before a
454         period, without totally throwing them away.
455         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
456         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
457         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
458
459 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
460
461         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
462         https://bugs.webkit.org/show_bug.cgi?id=86865
463
464         Reviewed by Adam Barth.
465
466         Add deliverWebIntent method to LayoutTestController and provide
467         implementation for EFL port.
468
469         * DumpRenderTree/LayoutTestController.cpp:
470         (deliverWebIntentCallback):
471         (LayoutTestController::staticFunctions):
472         * DumpRenderTree/LayoutTestController.h:
473         (LayoutTestController):
474         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
475         (LayoutTestController::deliverWebIntent):
476         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
477         (LayoutTestController::deliverWebIntent):
478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
479         (LayoutTestController::deliverWebIntent):
480         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
481         (LayoutTestController::deliverWebIntent):
482         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
483         (LayoutTestController::deliverWebIntent):
484         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
485         (LayoutTestController::deliverWebIntent):
486
487 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
488
489         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
490
491         Reviewed by Simon Hausmann.
492
493         * Tools.pro:
494
495 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
496
497         Add public page loading performance tests using web-page-replay
498         https://bugs.webkit.org/show_bug.cgi?id=84008
499
500         Reviewed by Dirk Pranke.
501
502         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
503         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
504         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
505
506         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
507         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
508         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
509         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
510
511         * Scripts/webkitpy/layout_tests/port/driver.py:
512         (Driver.is_external_http_test): Added.
513         * Scripts/webkitpy/layout_tests/port/webkit.py:
514         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
515         * Scripts/webkitpy/performance_tests/perftest.py:
516         (PerfTest.__init__): Takes port.
517         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
518         (PerfTest):
519         (PerfTest.run): Calls run_single.
520         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
521         (ChromiumStylePerfTest.__init__):
522         (PageLoadingPerfTest.__init__):
523         (PageLoadingPerfTest.run):
524         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
525         (ReplayServer.__init__):
526         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
527         but it caused a dead lock on some web pages.
528         (ReplayServer.stop):
529         (ReplayServer.__del__):
530         (ReplayPerfTest):
531         (ReplayPerfTest.__init__):
532         (ReplayPerfTest._start_replay_server):
533         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
534         The subsequent runs of the same test will just use test.wpr.
535         (ReplayPerfTest.run_single):
536         (PerfTestFactory):
537         (PerfTestFactory.create_perf_test):
538         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
539         (MainTest.test_parse_output):
540         (MainTest.test_parse_output_with_failing_line):
541         (TestPageLoadingPerfTest.test_run):
542         (TestPageLoadingPerfTest.test_run_with_bad_output):
543         (TestReplayPerfTest):
544         (TestReplayPerfTest.ReplayTestPort):
545         (TestReplayPerfTest.ReplayTestPort.__init__):
546         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
547         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
548         (TestReplayPerfTest.ReplayTestPort._driver_class):
549         (TestReplayPerfTest.MockReplayServer):
550         (TestReplayPerfTest.MockReplayServer.__init__):
551         (TestReplayPerfTest.MockReplayServer.stop):
552         (TestReplayPerfTest._add_file):
553         (TestReplayPerfTest._setup_test):
554         (TestReplayPerfTest.test_run_single):
555         (TestReplayPerfTest.test_run_single.run_test):
556         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
557         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
558         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
559         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
560         (TestReplayPerfTest.test_prepare):
561         (TestReplayPerfTest.test_prepare.run_test):
562         (TestReplayPerfTest.test_prepare_calls_run_single):
563         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
564         (TestPerfTestFactory.test_regular_test):
565         (TestPerfTestFactory.test_inspector_test):
566         (TestPerfTestFactory.test_page_loading_test):
567         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
568         (PerfTestsRunner):
569         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
570         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
571         (PerfTestsRunner._collect_tests._is_test_file):
572         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
573         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
574         (create_runner):
575         (run_test):
576         (_tests_for_runner):
577         (test_run_test_set):
578         (test_run_test_set_kills_drt_per_run):
579         (test_run_test_pause_before_testing):
580         (test_run_test_set_for_parser_tests):
581         (test_run_test_set_with_json_output):
582         (test_run_test_set_with_json_source):
583         (test_run_test_set_with_multiple_repositories):
584         (test_run_with_upload_json):
585         (test_upload_json):
586         (test_upload_json.MockFileUploader.upload_single_text_file):
587         (_add_file):
588         (test_collect_tests):
589         (test_collect_tests_with_multile_files):
590         (test_collect_tests_with_multile_files.add_file):
591         (test_collect_tests_with_skipped_list):
592         (test_collect_tests_with_page_load_svg):
593         (test_collect_tests_should_ignore_replay_tests_by_default):
594         (test_collect_tests_with_replay_tests):
595         (test_parse_args):
596         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
597         (AutoinstallImportHook.find_module):
598         (AutoinstallImportHook._install_webpagereplay):
599
600 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
601
602         Support building the Android port of chromium with Ninja
603         https://bugs.webkit.org/show_bug.cgi?id=87545
604
605         Reviewed by Adam Barth.
606
607         Ensures that shared libraries are looked up in a generator-agnostic
608         way and that output is placed in the correct directory.
609
610         Depends on http://codereview.chromium.org/10386188/
611
612         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
613
614 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
615
616         [Chromium] Chromium DRT should be able to load external resources
617         https://bugs.webkit.org/show_bug.cgi?id=87893
618
619         Reviewed by Dirk Pranke.
620
621         Allow external resources to be loaded when the main frame's URL is also an external resource.
622         This change is analogous to r118231 for Mac port.
623
624         * DumpRenderTree/chromium/WebViewHost.cpp:
625         (blockRequest):
626         (isLocalhost):
627         (hostIsUsedBySomeTestsToGenerateError):
628         (WebViewHost::willSendRequest):
629
630 2012-05-31  Anders Carlsson  <andersca@apple.com>
631
632         Build fixes.
633
634         Disable the C++11 extensions warning.
635
636         * DumpRenderTree/mac/Configurations/Base.xcconfig:
637         * TestWebKitAPI/Configurations/Base.xcconfig:
638         * WebKitTestRunner/Configurations/Base.xcconfig:
639
640 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
641
642         [WK2] window.internals settings are not reset between tests
643         https://bugs.webkit.org/show_bug.cgi?id=87783
644
645         Reviewed by Mihai Parparita.
646
647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
648         (WTR::InjectedBundle::done): Call resetAfterTest().
649
650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
651         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
652         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
653         This needs to be done after a tets, because the code assumes that there is an object
654         with this name in global scope.
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
657
658 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
659
660         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
661         https://bugs.webkit.org/show_bug.cgi?id=85006
662
663         Reviewed by Tor Arne Vestbø.
664
665         Added navigation_policy_decision implementation for DumpRenderTreeView.
666         Added LayoutTestController::setCustomPolicyDelegate implementation.
667         Modified LayoutTestController::waitForPolicyDelegate.
668
669         * DumpRenderTree/efl/DumpRenderTree.cpp:
670         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
671         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
672         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
673         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
674         (navigationTypeToString): aux function
675         (onNavigationPolicyDecision): navigation_policy_decision implementation
676         (drtViewAdd):
677         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
678         (LayoutTestController::setCustomPolicyDelegate):
679         (LayoutTestController::waitForPolicyDelegate):
680
681 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
682
683         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
684         https://bugs.webkit.org/show_bug.cgi?id=86195
685
686         Reviewed by Gustavo Noronha Silva.
687
688         Implement clearApplicationCacheForOrigin in EFL
689         LayoutTestController.
690
691         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
692         (LayoutTestController::clearApplicationCacheForOrigin):
693
694 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
695
696         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
697         https://bugs.webkit.org/show_bug.cgi?id=87955
698
699         Reviewed by Simon Hausmann.
700
701         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
702         * DumpRenderTree/qt/EventSenderQt.cpp:
703         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
704         * DumpRenderTree/qt/main.cpp:
705         * QtTestBrowser/cookiejar.cpp:
706         * QtTestBrowser/launcherwindow.cpp:
707         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
708         * qmake/mkspecs/features/default_post.prf:
709
710 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
711
712         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
713
714         Rubber-stamped by Kenneth Rohde Christiansen.
715
716         * qmake/config.tests/libpng/libpng.pro:
717
718 2012-05-30  Peter Beverloo  <peter@chromium.org>
719
720         [Chromium] Automatically install 64-bit linker for Android
721         https://bugs.webkit.org/show_bug.cgi?id=79780
722
723         Reviewed by Adam Barth.
724
725         Change the update-webkit-chromium script to check whether the 64-bit
726         linker needs to be installed as part of the update process. The actual
727         code for doing these checks and "installing" it has been added to the
728         webkitdirs.pm script.
729
730         The linker itself is part of the third_party/aosp repository, which
731         will be pulled in through the DEPS change.
732
733         * Scripts/update-webkit-chromium:
734         * Scripts/webkitdirs.pm:
735         (chromiumInstall64BitAndroidLinkerIfNeeded):
736         (chromiumReplaceAndroidLinkerIfNeeded):
737
738 2012-05-30  Stephanie Lewis  <slewis@apple.com>
739
740         https://bugs.webkit.org/show_bug.cgi?id=87803
741         Layout tests often fail trying to stat nonexistent logs 
742
743         Reviewed by Dirk Pranke.
744
745         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
746         try/catch block around accessing the logs as a precaution.
747
748         * Scripts/webkitpy/common/system/crashlogs.py:
749         (CrashLogs._find_newest_log_darwin):
750
751 2012-05-30  Gavin Peters  <gavinp@chromium.org>
752
753         Add a LayoutTest for prerender remove after stop.
754         https://bugs.webkit.org/show_bug.cgi?id=87860
755
756         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
757         can be tested by LayoutTests now.
758
759         Reviewed by Adam Barth.
760
761         * DumpRenderTree/DumpRenderTree.gypi:
762         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
763         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
764         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
765         (MockWebPrerenderingSupport::add):
766         (MockWebPrerenderingSupport::cancel):
767         (MockWebPrerenderingSupport::abandon):
768         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
769         (MockWebPrerenderingSupport):
770         * DumpRenderTree/chromium/TestShell.cpp:
771         (TestShell::initialize):
772         * DumpRenderTree/chromium/TestShell.h:
773         (TestShell):
774         * DumpRenderTree/chromium/WebViewHost.cpp:
775         (WebViewHost::willAddPrerender):
776         (WebViewHost::setWebWidget):
777         * DumpRenderTree/chromium/WebViewHost.h:
778         (WebViewHost):
779
780 2012-05-30  Stephanie Lewis  <slewis@apple.com>
781
782         https://bugs.webkit.org/show_bug.cgi?id=87717
783         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
784
785         Reviewed by Dirk Pranke.
786
787         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
788         If there isn't a crash log found for the process add a message saying
789         the process was unresponsive.
790
791         * Scripts/webkitpy/layout_tests/port/webkit.py:
792         (WebKitDriver.__init__):
793         (WebKitDriver._check_for_driver_crash):
794         (WebKitDriver.run_test):
795         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
796         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
797         (WebKitDriverTest):
798         (WebKitDriverTest.test_check_for_driver_crash):
799         * WebKitTestRunner/TestController.cpp:
800         (WTR):
801         (WTR::TestController::runTest):
802
803 2012-05-30  Stephanie Lewis  <slewis@apple.com>
804
805         https://bugs.webkit.org/show_bug.cgi?id=87714
806         Mac crash logs can take a really long time to be written out.
807
808         Reviewed by Dirk Pranke.
809
810         Make a second pass looking for crash logs after the tests have completed running.
811
812         * Scripts/webkitpy/layout_tests/controllers/manager.py:
813         (use_trac_links_in_results_html):
814         (Manager.run):
815         * Scripts/webkitpy/layout_tests/port/base.py:
816         (Port.repository_paths):
817         (Port.look_for_new_crash_logs):
818         * Scripts/webkitpy/layout_tests/port/mac.py:
819         (MacPort.look_for_new_crash_logs):
820         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
821         (test_get_crash_log):
822         (test_look_for_new_crash_logs):
823         (test_look_for_new_crash_logs.fake_time_cb):
824
825 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
826
827         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
828
829         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
830         (LayoutWebViewEventHandler::OnAlertEvent):
831         (LayoutWebViewEventHandler::OnConfirmEvent):
832         (LayoutWebViewEventHandler):
833         (LayoutWebViewEventHandler::OnPromptEvent):
834         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
835         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
836
837 2012-05-30  Ojan Vafai  <ojan@chromium.org>
838
839         Only give lint errors for -expected.png png files that lack a checksum
840         https://bugs.webkit.org/show_bug.cgi?id=87875
841
842         Reviewed by Tony Chang.
843
844         We have other pngs in the tree, e.g. for the inspector, that legitimately
845         lack a checksum.
846
847         * Scripts/webkitpy/style/checkers/png.py:
848         (PNGChecker.check):
849         * Scripts/webkitpy/style/checkers/png_unittest.py:
850         (PNGCheckerTest.test_check):
851
852 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
853
854         nrwt: seems to leak temp dirs
855         https://bugs.webkit.org/show_bug.cgi?id=87795
856
857         Reviewed by Ojan Vafai.
858
859         There appears to be a bug where the chromium bots are creating
860         temporary directories and not cleaning them up that started
861         after the switch to WebKitDriver. It's possible that __del__
862         wasn't getting called in a timely manner (or at all), and it's
863         generally bad style to rely on __del__ being called, so this
864         code changes things so that we create a temp dir in
865         driver.start() and remove it in driver.stop(). We could be
866         paranoid and leave the __del__ code in, but there doesn't seem
867         to be much advantage to it. If there are bugs that result in
868         drivers being started but not stopped, we have other problems.
869
870         * Scripts/webkitpy/common/system/filesystem_mock.py:
871         (MockFileSystem.__init__):
872         (MockFileSystem._mktemp):
873         (MockFileSystem.mkdtemp):
874         * Scripts/webkitpy/layout_tests/port/webkit.py:
875         (WebKitDriver.__init__):
876         (WebKitDriver._start):
877         (WebKitDriver.stop):
878         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
879         (WebKitDriverTest.test_check_for_driver_crash):
880         (WebKitDriverTest):
881         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
882         (WebKitDriverTest.test_stop_cleans_up_properly):
883
884 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
885
886         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
887         https://bugs.webkit.org/show_bug.cgi?id=86841
888
889         Reviewed by Adam Barth.
890
891         Print the number of MessagePorts for each new intent in EFL's DRT.
892         This output is expected by several Web Intents test cases.
893
894         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
895         (DumpRenderTreeChrome::onFrameIntentNew):
896
897 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
898
899         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
900
901         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
902
903 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
904
905         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
906         https://bugs.webkit.org/show_bug.cgi?id=87829
907
908         Reviewed by Adam Barth.
909
910         EFL's LayoutTestController now makes uses of the new helper method in
911         DumpRenderTreeSupportEfl in order to send the intent response. This is
912         now needed because the Ewk_Intent_Request postResult / postFailure
913         methods were made private.
914
915         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
916         (LayoutTestController::sendWebIntentResponse):
917
918 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
919
920         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
921         https://bugs.webkit.org/show_bug.cgi?id=86296
922
923         Reviewed by Tony Chang.
924
925         * DumpRenderTree/win/DRTDataObject.cpp: Added.
926         (cfHDropFormat):
927         (cfFileNameWFormat):
928         (cfUrlWFormat):
929         (WCEnumFormatEtc):
930         (WCEnumFormatEtc::WCEnumFormatEtc):
931         (WCEnumFormatEtc::QueryInterface):
932         (WCEnumFormatEtc::AddRef):
933         (WCEnumFormatEtc::Release):
934         (WCEnumFormatEtc::Next):
935         (WCEnumFormatEtc::Skip):
936         (WCEnumFormatEtc::Reset):
937         (WCEnumFormatEtc::Clone):
938         (DRTDataObject::createInstance):
939         (DRTDataObject::DRTDataObject):
940         (DRTDataObject::~DRTDataObject):
941         (DRTDataObject::QueryInterface):
942         (DRTDataObject::AddRef):
943         (DRTDataObject::Release):
944         (DRTDataObject::GetData):
945         (DRTDataObject::GetDataHere):
946         (DRTDataObject::QueryGetData):
947         (DRTDataObject::GetCanonicalFormatEtc):
948         (DRTDataObject::SetData):
949         (DRTDataObject::CopyMedium):
950         (DRTDataObject::EnumFormatEtc):
951         (DRTDataObject::DAdvise):
952         (DRTDataObject::DUnadvise):
953         (DRTDataObject::EnumDAdvise):
954         (DRTDataObject::clearData):
955         * DumpRenderTree/win/DRTDataObject.h: Added.
956         (DRTDataObject):
957         * DumpRenderTree/win/DRTDropSource.cpp: Added.
958         (DRTDropSource::DRTDropSource):
959         (DRTDropSource::~DRTDropSource):
960         (DRTDropSource::QueryInterface):
961         (DRTDropSource::AddRef):
962         (DRTDropSource::Release):
963         (DRTDropSource::createInstance):
964         (DRTDropSource::QueryContinueDrag):
965         (DRTDropSource::GiveFeedback):
966         * DumpRenderTree/win/DRTDropSource.h: Added.
967         (DRTDropSource):
968         * DumpRenderTree/win/DumpRenderTree.vcproj:
969         * DumpRenderTree/win/EventSender.cpp:
970         (beginDragWithFilesCallback):
971
972 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
973
974         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
975         https://bugs.webkit.org/show_bug.cgi?id=58593
976
977         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
978         to WebKitTestRunner's LayoutTestController. The flag is modified via the
979         public C API of the WebProcess.
980
981         Reviewed by Darin Adler.
982
983         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
985         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
986         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
987         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
988
989 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
990
991         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
992         https://bugs.webkit.org/show_bug.cgi?id=87848
993
994         Reviewed by Csaba Osztrogonác.
995
996         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
997         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
998         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
999
1000         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1001         (DumpRenderTreeChrome::extraViews):
1002         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1003         (DumpRenderTreeChrome):
1004
1005 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1006
1007         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1008         https://bugs.webkit.org/show_bug.cgi?id=87833
1009
1010         Reviewed by Tor Arne Vestbø.
1011
1012         Print "postProgressFinishedNotification" message if frame load finished 
1013         to unskip http/tests/loading/progress-finished-callback.html.
1014
1015         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1016         (DumpRenderTreeChrome::onFrameLoadFinished):
1017
1018 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1019
1020         [EFL][WK2] Fix WebKit2-EFL build
1021         https://bugs.webkit.org/show_bug.cgi?id=83693
1022
1023         Reviewed by Carlos Garcia Campos.
1024
1025         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1026
1027 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1028
1029         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1030         (They only used to check for Skipped in platform/qt-5.0-wk1)
1031         https://bugs.webkit.org/show_bug.cgi?id=87376
1032
1033         Reviewed by Csaba Osztrogonác.
1034
1035         * Scripts/old-run-webkit-tests:
1036         (buildPlatformResultHierarchy):
1037         * Scripts/webkitpy/layout_tests/port/qt.py:
1038         (QtPort.baseline_search_path):
1039
1040 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1041
1042         Add a linter error for pngs that lack an embedded checksum
1043         https://bugs.webkit.org/show_bug.cgi?id=87793
1044
1045         Reviewed by Dirk Pranke.
1046
1047         * Scripts/read-checksum-from-png:
1048         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1049         (read_checksum):
1050         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1051         (ReadChecksumFromPngTest):
1052         (ReadChecksumFromPngTest.test_read_checksum):
1053         * Scripts/webkitpy/layout_tests/port/base.py:
1054         * Scripts/webkitpy/style/checkers/png.py:
1055         (PNGChecker.check):
1056         * Scripts/webkitpy/style/checkers/png_unittest.py:
1057         (PNGCheckerTest.test_check):
1058
1059 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1060
1061         https://bugs.webkit.org/show_bug.cgi?id=87720
1062         WebProcess is often killed due to being unresponsive on the bots
1063
1064         Reviewed by Alexey Proskuryakov.
1065
1066         Blind attempt to improve flakiness on the bots by reducing the number
1067         of crashes due to an unresponsive process.  This helped on my personal machine
1068         under stress conditions.  I don't have enough cores to hit the problem
1069         under normal conditions.
1070
1071         * WebKitTestRunner/TestController.cpp:
1072         (WTR):
1073
1074 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1075
1076         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1077         https://bugs.webkit.org/show_bug.cgi?id=87779
1078
1079         Reviewed by Eric Seidel.
1080
1081         Update output to match the names in scm.py as per
1082         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1083
1084         * Scripts/webkitpy/tool/commands/rebaseline.py:
1085         (RebaselineTest.execute):
1086         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1087         (test_rebaseline_test_and_print_scm_changes):
1088         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1089         (GardeningServerTest.test_rebaselineall):
1090
1091 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1092
1093         https://bugs.webkit.org/show_bug.cgi?id=87711
1094
1095         Reviewed by Jessie Berlin.
1096
1097         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1098         are better maintained.
1099
1100         * BuildSlaveSupport/build.webkit.org-config/config.json:
1101
1102 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1103
1104         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1105         https://bugs.webkit.org/show_bug.cgi?id=87538
1106
1107         Reviewed by Ojan Vafai.
1108
1109         Invoking git and svn on one file at a time is kinda slow. We
1110         should batch the add and rm operations together.
1111
1112         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1113         (BaselineOptimizer._move_baselines):
1114
1115 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1116
1117         garden-o-matic should rebaseline baselines in parallel
1118         https://bugs.webkit.org/show_bug.cgi?id=87451
1119
1120         Reviewed by Ojan Vafai.
1121                                                                                
1122         This modifies garden-o-matic so that we will fetch all                  
1123         of the baselines in parallel from the bots, and then                    
1124         optimize the baselines serially (since that should be fairly            
1125         quick and we get into trouble if we optimize in parallel due            
1126         to concurrent access to the source control system).                     
1127
1128         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1129         so that the files that need to be modified in the SCM are returned to 
1130         garden-o-matic rather than actually added or removed. This is done so that
1131         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1132         concurrently). In order to safely return the files (as a JSON dict) I
1133         needed to shift all of the logging in rebaseline-test to use the logging
1134         module (and hence log to stderr).
1135
1136         I also had to stub out a line in chromium.py that would get confused if
1137         the skia overrides file didn't exist in a mock checkout.
1138
1139         * Scripts/webkitpy/common/system/executive.py:
1140         (Executive.popen):
1141         (Executive):
1142         (Executive.run_in_parallel):
1143         (_run_command_thunk):
1144         * Scripts/webkitpy/common/system/executive_mock.py:
1145         (MockExecutive.run_in_parallel):
1146         * Scripts/webkitpy/common/system/executive_unittest.py:
1147         (ExecutiveTest.test_run_in_parallel):
1148         * Scripts/webkitpy/layout_tests/port/chromium.py:
1149         (ChromiumPort._expectations_file_contents):
1150         * Scripts/webkitpy/tool/commands/rebaseline.py:
1151         (AbstractRebaseliningCommand.__init__):
1152         (RebaselineTest.__init__):
1153         (RebaselineTest._copy_existing_baseline):
1154         (RebaselineTest._save_baseline):
1155         (RebaselineTest):
1156         (RebaselineTest._add_to_scm):
1157         (RebaselineTest._rebaseline_test):
1158         (RebaselineTest.execute):
1159         (RebaselineExpectations._rebaseline_port):
1160         (RebaselineExpectations.execute):
1161         (Rebaseline._builder_to_pull_from):
1162         (Rebaseline.execute):
1163         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1164         (test_rebaseline_updates_expectations_file):
1165         (test_rebaseline_test):
1166         (test_rebaseline_test_and_print_scm_changes):
1167         (test_rebaseline_and_copy_test):
1168         (test_rebaseline_and_copy_test_no_existing_result):
1169         (test_rebaseline_and_copy_test_with_lion_result):
1170         (test_rebaseline_and_copy_no_overwrite_test):
1171         (test_rebaseline_expectations):
1172         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1173         (GardeningHTTPRequestHandler._rebaseline_commands):
1174         (GardeningHTTPRequestHandler):
1175         (GardeningHTTPRequestHandler._files_to_add):
1176         (GardeningHTTPRequestHandler._optimize_baselines):
1177         (GardeningHTTPRequestHandler.rebaselineall):
1178         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1179         (GardeningServerTest._post_to_path):
1180         (GardeningServerTest.test_rebaselineall):
1181         (GardeningServerTest.test_rebaselineall.run_command):
1182
1183 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1184
1185         Fix the type of dispatch_time() offset
1186
1187         Rubber-stamped by Joseph Pecoraro.
1188
1189         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1190
1191         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1192         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1193
1194 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1195
1196         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1197
1198         [BlackBerry] OpenGL content is not rendered on simulator
1199         https://bugs.webkit.org/show_bug.cgi?id=87721
1200
1201         Reviewed by George Staikos.
1202
1203         Fixed by enabling GLES2 support in simulator builds.
1204
1205         To experiment with building without OpenGL support, you can set the
1206         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1207
1208         PR #150695
1209
1210         * Scripts/webkitdirs.pm:
1211         (blackberryCMakeArguments):
1212
1213 2012-05-29  David Barr  <davidbarr@chromium.org>
1214
1215         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1216         https://bugs.webkit.org/show_bug.cgi?id=87685
1217
1218         Reviewed by Eric Seidel.
1219
1220         Add a configuration option for CSS image-resolution support, disabling it by default.
1221
1222         * Scripts/webkitperl/FeatureList.pm:
1223         * qmake/mkspecs/features/features.pri:
1224
1225 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1226
1227         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1228
1229         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1230             valid for C++/ObjC++ but not for C [enabled by default]"
1231
1232         Reviewed by Simon Hausmann.
1233
1234         * qmake/mkspecs/features/unix/default_post.prf:
1235
1236 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1237
1238         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=87133
1241
1242         We now base64-encode the page url in the image-provider url, so that any
1243         normalization done by QUrl will not mess up the page-url. The logic of
1244         creating and parsing the provider-url has been moved into the image
1245         provider, to keep it in one place.
1246
1247         We were also releasing icons (even ones we hadn't retained), which we can't
1248         do since we don't know when the icon url is no longer in use.
1249
1250         Reviewed-by Simon Hausmann.
1251
1252         * MiniBrowser/qt/icons/favicon.png:
1253         * MiniBrowser/qt/qml/BrowserWindow.qml:
1254
1255 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1256
1257         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1258         https://bugs.webkit.org/show_bug.cgi?id=87654
1259
1260         Reviewed by Csaba Osztrogonác.
1261
1262         Event sender provides strings for all the key events.
1263         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1264         a key event has empty string.
1265
1266         * DumpRenderTree/efl/EventSender.cpp:
1267         (KeyEventInfo::KeyEventInfo):
1268         (keyPadNameFromJSValue):
1269         (keyNameFromJSValue):
1270
1271 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1272
1273         [Qt] Cancel potential url-edit when going back/forward
1274
1275         Reviewed by Kenneth Rohde Christiansen.
1276
1277         * MiniBrowser/qt/qml/BrowserWindow.qml:
1278
1279 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1280
1281         [EFL] Compilation warning in DumpRenderTreeView.cpp
1282         https://bugs.webkit.org/show_bug.cgi?id=87636
1283
1284         Reviewed by Filip Pizlo.
1285
1286         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1287         specifier in printf. Also fix the return type for
1288         onExceededApplicationCacheQuota callback.
1289
1290         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1291         (onExceededApplicationCacheQuota):
1292
1293 2012-05-29  Hironori Bono  <hbono@chromium.org>
1294
1295         Adding Hironori Bono to committers.py.
1296         https://bugs.webkit.org/show_bug.cgi?id=87697
1297
1298         * Scripts/webkitpy/common/config/committers.py:
1299
1300 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1301
1302         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1303         https://bugs.webkit.org/show_bug.cgi?id=80135
1304
1305         Reviewed by Rob Buis.
1306
1307         Implemented interface function didReceiveAuthenticationChallenge in class
1308         DumpRenderTree.
1309
1310         Resubmit the patch reverted by r115104 after the digest infinite loop
1311         issue for BlackBerry porting get identified and fixed.
1312
1313         Internally reviewed by Joe Mason <jmason@rim.com>
1314
1315         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1316         (drtCredentialDescription):
1317         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1318         (WebKit):
1319         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1320         (WebCore):
1321         (DumpRenderTree):
1322
1323 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1324
1325         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1326         https://bugs.webkit.org/show_bug.cgi?id=42328
1327
1328         Reviewed by Eric Seidel.
1329
1330         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1331         move to windows.internals.settings.
1332
1333         * DumpRenderTree/LayoutTestController.cpp:
1334         (LayoutTestController::staticFunctions):
1335         * DumpRenderTree/LayoutTestController.h:
1336         (LayoutTestController):
1337         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1338         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1339         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1340         (DRTDevToolsAgent):
1341         * DumpRenderTree/chromium/LayoutTestController.cpp:
1342         (LayoutTestController::LayoutTestController):
1343         * DumpRenderTree/chromium/LayoutTestController.h:
1344         (LayoutTestController):
1345         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1346         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1347         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1349         * DumpRenderTree/mac/DumpRenderTree.mm:
1350         (resetWebViewToConsistentStateBeforeTesting):
1351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1352         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1353         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1354         (LayoutTestController):
1355         * DumpRenderTree/win/DumpRenderTree.cpp:
1356         (resetWebViewToConsistentStateBeforeTesting):
1357         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1358         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1359         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1360         (LayoutTestController):
1361
1362 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1363
1364         Move allowRoundingHacks to Internals interface
1365         https://bugs.webkit.org/show_bug.cgi?id=87328
1366
1367         Reviewed by Hajime Morita.
1368
1369         Remove allowRoundingHacks functions, because it is able to work in the
1370         cross-port way through the Internals interface.
1371
1372         * DumpRenderTree/LayoutTestController.cpp:
1373         (LayoutTestController::staticFunctions):
1374         * DumpRenderTree/LayoutTestController.h:
1375         (LayoutTestController):
1376         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1377         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1380         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1382
1383 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1384
1385         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1386         https://bugs.webkit.org/show_bug.cgi?id=87616
1387
1388         Reviewed by Hajime Morita.
1389
1390         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1391         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1392         Patch just adds a #ifndef / #define check.
1393
1394         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1395         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1396
1397 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1398
1399         [EFL] Enable blob support for the EFL port
1400         https://bugs.webkit.org/show_bug.cgi?id=85363
1401
1402         Reviewed by Hajime Morita.
1403
1404         Enable Blob support by default for the EFL port.
1405
1406         * Scripts/webkitperl/FeatureList.pm:
1407
1408 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1409
1410         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1411         https://bugs.webkit.org/show_bug.cgi?id=87582
1412
1413         Reviewed by Darin Adler.
1414
1415         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1416         possible to test pages in a similar way as they are loaded in Browsers.
1417
1418         * DumpRenderTree/LayoutTestController.cpp:
1419         (LayoutTestController::LayoutTestController):
1420         (setUseDeferredFrameLoadingCallback):
1421         (LayoutTestController::staticFunctions):
1422         * DumpRenderTree/LayoutTestController.h:
1423         (LayoutTestController::useDeferredFrameLoading):
1424         (LayoutTestController::setUseDeferredFrameLoading):
1425         (LayoutTestController):
1426         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1427         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1428
1429 2012-05-27  David Barton  <dbarton@mathscribe.com>
1430
1431         [watchlist] Improve MathML rule
1432         https://bugs.webkit.org/show_bug.cgi?id=87592
1433
1434         Reviewed by Adam Barth.
1435
1436         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1437         but if this changed the rule would be slow. We protect against this, clarify the rule,
1438         and make it more similar to existing rules.
1439
1440         * Scripts/webkitpy/common/config/watchlist:
1441
1442 2012-05-27  David Barton  <dbarton@mathscribe.com>
1443
1444         [watchlist] Add myself & a rule for MathML
1445         https://bugs.webkit.org/show_bug.cgi?id=87586
1446
1447         Reviewed by Adam Barth.
1448
1449         * Scripts/webkitpy/common/config/watchlist:
1450
1451 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1452
1453         Use xcrun to find path to nm for Mac port
1454         <http://webkit.org/b/87588>
1455
1456         Reviewed by Dan Bernstein.
1457
1458         * Scripts/webkitpy/layout_tests/port/mac.py:
1459         (MacPort.nm_command): Add. Tries to find a path for the nm
1460         command using xcrun.  Falls back to returning 'nm'.
1461         * Scripts/webkitpy/layout_tests/port/webkit.py:
1462         (WebKitPort.nm_command): Add. Returns 'nm'.
1463         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1464
1465 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1466
1467         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1468
1469         Reviewed by Eric Seidel.
1470
1471         * DumpRenderTree/win/DumpRenderTree.vcproj:
1472         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1473         (FrameLoadDelegate::FrameLoadDelegate):
1474         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1475         * DumpRenderTree/win/FrameLoadDelegate.h:
1476         (FrameLoadDelegate):
1477         * DumpRenderTree/win/TextInputController.cpp: Added.
1478         (setMarkedTextCallback):
1479         (hasMarkedTextCallback):
1480         (unmarkTextCallback):
1481         (markedRangeCallback):
1482         (insertTextCallback):
1483         (firstRectForCharacterRangeCallback):
1484         (selectedRangeCallback):
1485         (TextInputController::makeWindowObject):
1486         (TextInputController::getJSClass):
1487         (TextInputController::staticValues):
1488         (TextInputController::staticFunctions):
1489         * DumpRenderTree/win/TextInputController.h: Added.
1490         (TextInputController):
1491         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1492         (TextInputController::setMarkedText):
1493         (TextInputController::hasMarkedText):
1494         (TextInputController::unmarkText):
1495         (TextInputController::markedRange):
1496         (TextInputController::insertText):
1497         (TextInputController::firstRectForCharacterRange):
1498         (TextInputController::selectedRange):
1499
1500 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1501
1502         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1503         https://bugs.webkit.org/show_bug.cgi?id=87528
1504
1505         Reviewed by Ojan Vafai.
1506
1507         launching git or svn for individual files can be slow; this
1508         change will hand multiple paths at once to git and svn so they
1509         can be added in a batch.
1510
1511         * Scripts/webkitpy/common/checkout/scm/git.py:
1512         (Git.add_list):
1513         (Git.delete_list):
1514         * Scripts/webkitpy/common/checkout/scm/scm.py:
1515         (SCM.add):
1516         (SCM):
1517         (SCM.add_list):
1518         (SCM.delete):
1519         (SCM.delete_list):
1520         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1521         (MockSCM.add):
1522         (MockSCM):
1523         (MockSCM.add_list):
1524         (MockSCM.delete):
1525         (MockSCM.delete_list):
1526         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1527         (_shared_test_exists):
1528         (_shared_test_added_files):
1529         (_test_delete_list):
1530         * Scripts/webkitpy/common/checkout/scm/svn.py:
1531         (SVN.add_list):
1532         (SVN.delete_list):
1533
1534 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1535
1536         [NRWT] Add unit testing for perf tests on locked shards
1537         https://bugs.webkit.org/show_bug.cgi?id=87489
1538
1539         Reviewed by Dirk Pranke.
1540
1541         Adding utests that makes sure that perf tests are running in locked
1542         shards and by passing --no-http won't break NRWT (r118421).
1543
1544         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1545         (ShardingTests):
1546         (ShardingTests.test_shard_by_dir):
1547         (ShardingTests.test_shard_every_file):
1548         (ShardingTests.test_shard_in_two):
1549         (ShardingTests.test_multiple_locked_shards):
1550         (LockCheckingManager):
1551         (LockCheckingManager.__init__):
1552         (LockCheckingManager.handle_finished_list):
1553         (ManagerTest.test_http_locking):
1554         (ManagerTest):
1555         (ManagerTest.test_perf_locking):
1556         * Scripts/webkitpy/layout_tests/port/test.py:
1557
1558 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1559
1560         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1561         https://bugs.webkit.org/show_bug.cgi?id=87511
1562
1563         Reviewed by Alexey Proskuryakov.
1564
1565         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1566
1567         * DumpRenderTree/win/EventSender.cpp:
1568         (keyDownCallback):
1569
1570 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1571
1572         Adding Ken Buchanan to committers.py
1573         https://bugs.webkit.org/show_bug.cgi?id=87443
1574
1575         Unreviewed.
1576
1577         Adding self to committers.py as a Committer.
1578
1579         * Scripts/webkitpy/common/config/committers.py:
1580
1581 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1582
1583         [Qt] Buildfix for newer Qt5
1584         https://bugs.webkit.org/show_bug.cgi?id=87257
1585
1586         Reviewed by Simon Hausmann.
1587
1588         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
1589
1590 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1591
1592         [Qt] Unreviewed fix after r118484.
1593
1594         Enable CSS_EXCLUSIONS and CSS_REGIONS.
1595         They were enabled uncoditinally before r118484.
1596
1597         * qmake/mkspecs/features/features.pri:
1598
1599 2012-05-24  Tim Horton  <timothy_horton@apple.com>
1600
1601         Add feature defines for web-facing parts of CSS Regions and Exclusions
1602         https://bugs.webkit.org/show_bug.cgi?id=87442
1603         <rdar://problem/10887709>
1604
1605         Reviewed by Dan Bernstein.
1606
1607         * Scripts/webkitperl/FeatureList.pm:
1608
1609 2012-05-24  Hironori Bono  <hbono@chromium.org>
1610
1611         Enable grammar checking on Chromium when we paste text (Take 2)
1612         https://bugs.webkit.org/show_bug.cgi?id=74393
1613
1614         Reviewed by Ryosuke Niwa.
1615
1616         This change enables grammar checking on Chromium and implements a mock grammar
1617         checker to fix a failing test.
1618
1619         * DumpRenderTree/DumpRenderTree.gypi:
1620         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1621         (MockGrammarCheck::checkGrammarOfString):
1622         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1623         (WebKit):
1624         (MockGrammarCheck):
1625         * DumpRenderTree/chromium/WebViewHost.cpp:
1626         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1627
1628 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1629
1630         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
1631         https://bugs.webkit.org/show_bug.cgi?id=86842
1632
1633         Reviewed by Antonio Gomes.
1634
1635         Add support for overriding the application cache support preference
1636         through EFL's LayoutTestController.
1637
1638         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1639         (LayoutTestController::overridePreference):
1640
1641 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1642
1643         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
1644         https://bugs.webkit.org/show_bug.cgi?id=85209
1645
1646         Reviewed by Antonio Gomes.
1647
1648         Set developer extras setting called twice on the test startup. Hence, removing
1649         an unnecessary extra call which set wrong value. 
1650
1651         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1652         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1653
1654 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1655
1656         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1657         https://bugs.webkit.org/show_bug.cgi?id=86916
1658
1659         Reviewed by Adam Barth.
1660
1661         Note that if release and debug are failing differently, debug
1662         will be ignored ...
1663
1664         Note: also change the use of a fake port name from
1665         "mock-port-name" to "test-mac-leopard" to make it more friendly
1666         to the port factory ("mock" actually is a real port).
1667
1668         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1669         (GardeningHTTPRequestHandler._builders_to_fetch_from):
1670         (GardeningHTTPRequestHandler.rebaselineall):
1671         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1672         (GardeningServerTest.test_rebaselineall):
1673         (GardeningServerTest.test_rebaseline_new_port):
1674
1675 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1676
1677         nrwt: fix baseline search path for official chrome builders
1678         https://bugs.webkit.org/show_bug.cgi?id=87432
1679
1680         Reviewed by Tony Chang.
1681
1682         The official chrome builders need to use the win7 and SL
1683         baseline paths, not the XP and Leopard paths. Linux is correct.
1684
1685         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1686         (GoogleChromeMacPort.determine_full_port_name):
1687         (GoogleChromeWinPort.determine_full_port_name):
1688         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1689         (TestGoogleChromePort._verify_baseline_search_path_startswith):
1690         (TestGoogleChromePort.test_get_google_chrome_port):
1691
1692 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1693
1694         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
1695         https://bugs.webkit.org/show_bug.cgi?id=86800
1696
1697         Reviewed by Dirk Pranke.
1698
1699         Don't launch a HTTP server with lock based only on the existence of
1700         locked shards since we now run perf on locked shards too.
1701
1702         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1703         (Manager._run_tests):
1704
1705 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
1706
1707         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1708         https://bugs.webkit.org/show_bug.cgi?id=87128
1709
1710         Reviewed by Dirk Pranke.
1711
1712         * Scripts/webkitpy/layout_tests/port/base.py:
1713         (Port.driver_name):
1714         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1715         (ChromiumLinuxPort._path_to_driver):
1716         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1717         (ChromiumPortTest.test_driver_name_option):
1718         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1719         (ChromiumWinPort._path_to_driver):
1720         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1721         (parse_args):
1722
1723 2012-05-24  John Mellor  <johnme@chromium.org>
1724
1725         Font Boosting: Add compile flag and runtime setting
1726         https://bugs.webkit.org/show_bug.cgi?id=87394
1727
1728         Reviewed by Adam Barth.
1729
1730         Add ENABLE_FONT_BOOSTING.
1731
1732         * Scripts/webkitperl/FeatureList.pm:
1733         * qmake/mkspecs/features/features.pri:
1734
1735 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1736
1737         [EFL] [DRT] keyboard-related tests do not pass
1738         https://bugs.webkit.org/show_bug.cgi?id=85369
1739
1740         Reviewed by Gustavo Noronha Silva.
1741
1742         Add SHIFT modifier for capital letters as VK_ 
1743         codes do not distinguish between lows and caps and also to be consistent
1744         with other ports which send caps as lowercase letters with the shift key down.
1745
1746         * DumpRenderTree/efl/EventSender.cpp:
1747         (keyNameFromJSValue): 
1748
1749 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
1750
1751         [WK2] Let the client give local files universal access on a case by case basis
1752         https://bugs.webkit.org/show_bug.cgi?id=87174
1753         <rdar://problem/11024330>
1754
1755         Reviewed by Maciej Stachowiak.
1756
1757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
1758         Added initialization of a new structure member to prevent build failure.
1759
1760 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
1761
1762         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
1763         https://bugs.webkit.org/show_bug.cgi?id=87203
1764
1765         Reviewed by Andreas Kling.
1766
1767         Add the required changes to make
1768         fast/events/keydown-leftright-keys.html pass after r118001.
1769
1770         * DumpRenderTree/efl/EventSender.cpp:
1771         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
1772         into the proper X11 keysym definitions.
1773
1774 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1775
1776         Unreviewed, rolling out r118352.
1777         http://trac.webkit.org/changeset/118352
1778         https://bugs.webkit.org/show_bug.cgi?id=87390
1779
1780         Caused 6 editing/spelling tests crash/fail on chromium in
1781         debug. (Requested by vsevik on #webkit).
1782
1783         * DumpRenderTree/DumpRenderTree.gypi:
1784         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
1785         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
1786         * DumpRenderTree/chromium/WebViewHost.cpp:
1787         (WebViewHost::finishLastTextCheck):
1788
1789 2012-05-24  Peter Beverloo  <peter@chromium.org>
1790
1791         Add John Mellor as a contributor
1792         https://bugs.webkit.org/show_bug.cgi?id=87389
1793
1794         Reviewed by Kenneth Rohde Christiansen.
1795
1796         John will be working on Font Boosting and is very involved with various
1797         web-facing subjects of Chrome for Android, such as viewport.
1798
1799         * Scripts/webkitpy/common/config/committers.py:
1800
1801 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1802
1803         [EFL][DRT] LayoutTestController's setCacheModel() implementation
1804         https://bugs.webkit.org/show_bug.cgi?id=86840
1805
1806         Reviewed by Csaba Osztrogonác.
1807
1808         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1809         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
1810         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1811         (LayoutTestController::setCacheModel): Implementation added.
1812
1813 2012-05-24  Hironori Bono  <hbono@chromium.org>
1814
1815         Enable grammar checking on Chromium when we paste text.
1816         https://bugs.webkit.org/show_bug.cgi?id=74393
1817
1818         Reviewed by Hajime Morita.
1819
1820         This change enables grammar checking on Chromium and implements a mock grammar
1821         checker to fix a failing test.
1822
1823         * DumpRenderTree/DumpRenderTree.gypi:
1824         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1825         (MockGrammarCheck::checkGrammarOfString):
1826         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1827         (WebKit):
1828         (MockGrammarCheck):
1829         * DumpRenderTree/chromium/WebViewHost.cpp:
1830         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1831
1832 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1833
1834         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
1835
1836         * qmake/mkspecs/features/features.pri:
1837
1838 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1839
1840         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
1841         https://bugs.webkit.org/show_bug.cgi?id=86867
1842
1843         Reviewed by Adam Barth.
1844
1845         Add implementation for sendWebIntentResponse() in EFL's
1846         LayoutTestController and add empty implementation for other ports.
1847
1848         * DumpRenderTree/LayoutTestController.cpp:
1849         (sendWebIntentResponseCallback):
1850         (LayoutTestController::staticFunctions):
1851         * DumpRenderTree/LayoutTestController.h:
1852         (LayoutTestController):
1853         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1854         (LayoutTestController::sendWebIntentResponse):
1855         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1856         (DumpRenderTreeChrome::currentIntentRequest):
1857         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1858         (DumpRenderTreeChrome::onFrameIntentNew):
1859         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1860         (DumpRenderTreeChrome):
1861         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1862         (LayoutTestController::sendWebIntentResponse):
1863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1864         (LayoutTestController::sendWebIntentResponse):
1865         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1866         (LayoutTestController::sendWebIntentResponse):
1867         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1868         (LayoutTestController::sendWebIntentResponse):
1869         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1870         (LayoutTestController::sendWebIntentResponse):
1871
1872 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1873
1874         [EFL] The EFL port has no support for title directionality
1875         https://bugs.webkit.org/show_bug.cgi?id=86462
1876
1877         Reviewed by Gustavo Noronha Silva.
1878
1879         Update "title,changed" signal handlers in DRT and EWebLauncher to
1880         reflect the change from const char* to Ewk_Text_With_Direction* type
1881         for the title.
1882
1883         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1884         (DumpRenderTreeChrome::onTitleChanged):
1885         * EWebLauncher/main.c:
1886         (title_set):
1887         (on_title_changed):
1888         (on_key_down):
1889
1890 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1891
1892         Change EFL debug build name with more detail one
1893         https://bugs.webkit.org/show_bug.cgi?id=87254
1894
1895         Reviewed by Ryosuke Niwa.
1896
1897         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
1898         In addition, remove efl-linux-debug triggerable since nobody uses it.
1899
1900         * BuildSlaveSupport/build.webkit.org-config/config.json:
1901
1902 2012-05-23  Kangil Han  <kangil.han@samsung.com>
1903
1904         [EFL][DRT] Fix WebCore library path and rebaseline result
1905         https://bugs.webkit.org/show_bug.cgi?id=86355
1906
1907         Reviewed by Dirk Pranke.
1908
1909         Currently EFL DRT uses wrong WebCore library path when running DRT.
1910         Therefore, this patch adjusted the path correctly.
1911
1912         * Scripts/webkitpy/layout_tests/port/efl.py:
1913         (EflPort._path_to_webcore_library):
1914
1915 2012-05-23  Ojan Vafai  <ojan@chromium.org>
1916
1917         add back the ability to disable flexbox
1918         https://bugs.webkit.org/show_bug.cgi?id=87147
1919
1920         Reviewed by Tony Chang.
1921
1922         * Scripts/webkitperl/FeatureList.pm:
1923
1924 2012-05-23  Tony Chang  <tony@chromium.org>
1925
1926         Remove the Chromium Grid Layout bot from the waterfall
1927         https://bugs.webkit.org/show_bug.cgi?id=87311
1928
1929         Reviewed by Ryosuke Niwa.
1930
1931         I removed the compiler define in r117613, so we don't need a separate
1932         bot to compile/test this code.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/config.json:
1935
1936 2012-05-23  Ian Vollick  <vollick@chromium.org>
1937
1938         Add vollick to list of contributors.
1939         https://bugs.webkit.org/show_bug.cgi?id=87305
1940
1941         Reviewed by Adam Barth.
1942
1943         * Scripts/webkitpy/common/config/committers.py:
1944
1945 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
1946
1947         [Chromium-Android] Fix chromium_android_unittest
1948         https://bugs.webkit.org/show_bug.cgi?id=87196
1949
1950         Reviewed by Tony Chang.
1951
1952         Update unit tests after ChromiumAndroidPort supported apk based
1953         DumpRenderTree.
1954
1955         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1956         (ChromiumAndroidPortTest):
1957         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
1958         (ChromiumAndroidPortTest.test_get_last_stacktrace):
1959         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
1960         (ChromiumAndroidDriverTest):
1961         (ChromiumAndroidDriverTest.setUp):
1962         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
1963         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
1964
1965 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1966
1967         [watchlist] Add myself and create a watch rule to catch Attribute related patches
1968         https://bugs.webkit.org/show_bug.cgi?id=87303
1969
1970         Reviewed by Alexis Menard.
1971
1972         * Scripts/webkitpy/common/config/watchlist:
1973
1974 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
1975
1976         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1977         https://bugs.webkit.org/show_bug.cgi?id=86916
1978
1979         Reviewed by Adam Barth.
1980
1981         This change pushes all of the logic for rebaselining a cluster
1982         of failures (a list of tests failing a list of suffixes on a
1983         list of bots) onto the server, so there is a single call from
1984         the web page; we will then be able to optimize the performance
1985         of the rebaselining better.
1986
1987         Also remove the 'optimizebaseline' entry point on garden-o-matic
1988         (and the client-side call) since we don't need it any more.
1989
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1992         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1993         (GardeningHTTPRequestHandler.rebaselineall):
1994         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1995
1996 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1997
1998         Mac DRT should be able to load external URLs for replay performance tests
1999         https://bugs.webkit.org/show_bug.cgi?id=86191
2000
2001         Reviewed by Alexey Proskuryakov.
2002
2003         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2004         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2005         "DumpRenderTree http://localhost:8000/".
2006
2007         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2008         (isLocalhost):
2009         (hostIsUsedBySomeTestsToGenerateError):
2010         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2011
2012 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2013
2014         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2015         debug symbols for easier debugging.
2016         https://bugs.webkit.org/show_bug.cgi?id=87151
2017
2018         Reviewed by Kevin Ollivier.
2019
2020         * waf/build/settings.py:
2021         (common_configure):
2022
2023 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2024
2025         Unreviewed. Move myself to reviewers.
2026
2027         * Scripts/webkitpy/common/config/committers.py:
2028
2029 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2030
2031         [EFL] Implements the registerProtocolHandler method and option.
2032         https://bugs.webkit.org/show_bug.cgi?id=73638
2033
2034         Reviewed by Andreas Kling.
2035
2036         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2037
2038 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2039
2040         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2041         https://bugs.webkit.org/show_bug.cgi?id=87221
2042
2043         Reviewed by Martin Robinson.
2044
2045         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2046         rightShift key names into proper GDK key symbols.
2047
2048         * DumpRenderTree/gtk/EventSender.cpp:
2049         (createKeyPressEvent):
2050
2051 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2052
2053         [Qt] Make the web view's url property follow the active url
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=77554
2056
2057         Update  the location bar in the minibrowser to behave
2058         a bit more like normal browsers in terms of when the url will change
2059         and how active focus is handled.
2060
2061         Reviewed by Simon Hausmann.
2062
2063         * MiniBrowser/qt/qml/BrowserWindow.qml:
2064
2065 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2066
2067         [Qt] Remove references to $$QT_SOURCE_TREE
2068
2069         With a modularized Qt, it's ambigious. What we really want is qtbase,
2070         which qtcore is a proxy for (we assume it will always live in qtbase).
2071
2072         Reviewed by Tor Arne Vestbø.
2073
2074         * DumpRenderTree/qt/DumpRenderTree.pro:
2075
2076 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2077
2078         [Qt] Fix qmake conditional for c++-11 compat warnings
2079
2080         Reviewed by Tor Arne Vestbø.
2081
2082         * qmake/mkspecs/features/unix/default_post.prf:
2083
2084 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2085
2086         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2087         https://bugs.webkit.org/show_bug.cgi?id=85956
2088
2089         Reviewed by Gustavo Noronha Silva.
2090
2091         Catch new "load,provisional,failed" signal and print
2092         didFailProvisionalLoadWithError messages when LayoutTestController's
2093         dumpFrameLoadCallbacks() returns true. Also make sure the
2094         didFailLoadWithError message is not printed in case of provisional
2095         load failure.
2096
2097         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2098         (DumpRenderTreeChrome::createView):
2099         (DumpRenderTreeChrome::onFrameCreated):
2100         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2101         (DumpRenderTreeChrome::onFrameLoadError):
2102         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2103         (DumpRenderTreeChrome):
2104
2105 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2106
2107         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2108         https://bugs.webkit.org/show_bug.cgi?id=86366
2109
2110         Reviewed by Antonio Gomes.
2111
2112         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2113
2114         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2115         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2116
2117 2012-05-22  Darin Adler  <darin@apple.com>
2118
2119         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2120         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2121
2122 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2123
2124         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2125         https://bugs.webkit.org/show_bug.cgi?id=86922
2126
2127         Because we have new platformInit() in TestShellAndroid.cpp, and
2128         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2129         is split into TestShellPosix.cpp and TestShellX11.cpp.
2130
2131         Reviewed by Kent Tamura.
2132
2133         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2134         * DumpRenderTree/DumpRenderTree.gypi:
2135         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2136         (platformInit):
2137         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2138         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2139         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2140         (AlarmHandler):
2141         (TestShell::waitTestFinished):
2142         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2143         (openStartupDialog): from TestShellGtk.cpp
2144         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2145         (setupFontconfig):
2146         (platformInit):
2147
2148 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2149
2150         [EFL][DRT] Implement touch event
2151         https://bugs.webkit.org/show_bug.cgi?id=86720
2152
2153         Reviewed by Hajime Morita.
2154
2155         Currently EFL DRT doesn't support touch event.
2156         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2157
2158         * DumpRenderTree/efl/EventSender.cpp:
2159         (TouchEventInfo::TouchEventInfo):
2160         (TouchEventInfo):
2161         (touchPointList):
2162         (sendTouchEvent):
2163         (addTouchPointCallback):
2164         (touchStartCallback):
2165         (updateTouchPointCallback):
2166         (touchMoveCallback):
2167         (cancelTouchPointCallback):
2168         (touchCancelCallback):
2169         (releaseTouchPointCallback):
2170         (touchEndCallback):
2171         (clearTouchPointsCallback):
2172         (setTouchModifierCallback):
2173         * Scripts/webkitperl/FeatureList.pm:
2174
2175 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2176
2177         [Chromium-Android] Fix chromium_android_unittest
2178         https://bugs.webkit.org/show_bug.cgi?id=87196
2179
2180         Not reviewed.
2181         Temporarily disable chromium_android_unittest.
2182
2183         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2184         (ChromiumAndroidPortTest):
2185         (ChromiumAndroidDriverTest):
2186
2187 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2188
2189         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2190         https://bugs.webkit.org/show_bug.cgi?id=64313
2191
2192         Reviewed by Jon Honeycutt.
2193
2194         Add it.
2195
2196         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2197         Make sure to generate the binding.
2198
2199         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2200         (WTR::LayoutTestController::setDefersLoading):
2201         Call WKBundlePageSetDefersLoading.
2202         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2203
2204 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2205
2206         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2207         https://bugs.webkit.org/show_bug.cgi?id=86923
2208
2209         chromium_android.py is modified to support running DumpRenderTree as
2210         an apk, so that we can run the tests (e.g. video) requiring features
2211         implemented in Java on Android.
2212
2213         Reviewed by Adam Barth.
2214
2215         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2216         (ChromiumAndroidPort.__init__):
2217         (ChromiumAndroidPort.default_child_processes):
2218         (ChromiumAndroidPort.check_wdiff):
2219         (ChromiumAndroidPort.check_build):
2220         (ChromiumAndroidPort.start_helper):
2221         (ChromiumAndroidPort.skipped_layout_tests):
2222         (ChromiumAndroidPort):
2223         (ChromiumAndroidPort._path_to_driver):
2224         (ChromiumAndroidPort._get_crash_log):
2225         (ChromiumAndroidPort._push_executable):
2226         (ChromiumAndroidPort._run_adb_command):
2227         (ChromiumAndroidPort._get_last_stacktrace):
2228         (ChromiumAndroidPort._get_logcat):
2229         (ChromiumAndroidPort._setup_performance):
2230         (ChromiumAndroidDriver):
2231         (ChromiumAndroidDriver.__init__):
2232         (ChromiumAndroidDriver._command_wrapper):
2233         (ChromiumAndroidDriver.cmd_line):
2234         (ChromiumAndroidDriver._file_exists_on_device):
2235         (ChromiumAndroidDriver._deadlock_detector):
2236         (ChromiumAndroidDriver._start):
2237         (ChromiumAndroidDriver.run_test):
2238         (ChromiumAndroidDriver.stop):
2239         (ChromiumAndroidDriver._write_command_and_read_line):
2240         (ChromiumAndroidDriver._output_image):
2241         (ChromiumAndroidDriver._get_stderr):
2242
2243 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2244
2245         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2246
2247         Unreviewed gardening.
2248
2249         * Scripts/webkitpy/layout_tests/port/base.py:
2250         (Port.driver_name):
2251         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2252         (ChromiumLinuxPort._path_to_driver):
2253         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2254         (ChromiumPortTest.test_overrides_and_builder_names):
2255         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2256         (ChromiumWinPort._path_to_driver):
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258         (parse_args):
2259
2260 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2261
2262         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2263         https://bugs.webkit.org/show_bug.cgi?id=87176
2264
2265         Reviewed by Tony Chang.
2266
2267         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2268         * DumpRenderTree/DumpRenderTree.gypi:
2269
2270 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2271
2272         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2273         https://bugs.webkit.org/show_bug.cgi?id=87128
2274
2275         Reviewed by Dirk Pranke.
2276
2277         * Scripts/webkitpy/layout_tests/port/base.py:
2278         (Port.driver_name):
2279         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2280         (ChromiumLinuxPort._path_to_driver):
2281         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2282         (ChromiumPortTest.test_driver_name_option):
2283         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2284         (ChromiumWinPort._path_to_driver):
2285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2286         (parse_args):
2287
2288 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2289
2290         WTR fix after r118001.
2291
2292         Rubber-stamped by Alexey Proskuryakov.
2293
2294         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2295
2296         * WebKitTestRunner/mac/EventSenderProxy.mm:
2297         (WTR::EventSenderProxy::keyDown):
2298
2299 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2300
2301         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2302         https://bugs.webkit.org/show_bug.cgi?id=86684
2303
2304         Reviewed by Darin Fisher.
2305
2306         * DumpRenderTree/chromium/LayoutTestController.cpp:
2307         (LayoutTestController::numberOfPages):
2308         * DumpRenderTree/chromium/WebViewHost.cpp:
2309         (WebViewHost::printPage):
2310
2311 == Rolled over to ChangeLog-2012-05-22 ==