Add --instruments option to sunspider to profile with Instruments
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2
3         Add --instruments option to sunspider to profile with Instruments
4         https://bugs.webkit.org/show_bug.cgi?id=80783
5
6         Reviewed by Filip Pizlo.
7
8         * Scripts/run-sunspider:
9
10 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
11
12         [Qt] [WK2] Support threaded renderer in WK2
13         https://bugs.webkit.org/show_bug.cgi?id=76661
14
15         Remove disabling of threaded rendering.
16
17         Reviewed by Noam Rosenthal.
18
19         * MiniBrowser/qt/main.cpp:
20         (main):
21
22 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
23
24         [WK2] run-perf-tests should be able to run with WTR
25         https://bugs.webkit.org/show_bug.cgi?id=80042
26
27         Reviewed by Martin Robinson.
28
29         Add an option to PerfTestRunner to use WebKitTestRunner instead of
30         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
31         to avoid timing out when running performance tests.
32
33         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
34         (PerfTestsRunner._parse_args):
35         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
36         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
37         to true.
38         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
39         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
40         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
41         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
42         publicly accessible.
43         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
44         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
45         is required.
46         * WebKitTestRunner/TestController.cpp:
47         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
48         to true.
49         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
50         if '--no-timeout' option is present.
51         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
52         value, or -1.0 if timeout should not occur.
53         * WebKitTestRunner/TestController.h:
54         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
55         publicly accessible.
56         * WebKitTestRunner/TestInvocation.cpp:
57         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
58         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
59         Waiting for final message should not time out if not necessary.
60         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
61         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
62         * WebKitTestRunner/qt/TestControllerQt.cpp:
63         (WTR::TestController::platformRunUntil): Ditto.
64         * WebKitTestRunner/mac/TestControllerMac.mm:
65         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
66         is missing.
67         * WebKitTestRunner/win/TestControllerWin.cpp:
68         (WTR::TestController::platformRunUntil): Ditto.
69
70 2012-03-09  Jon Lee  <jonlee@apple.com>
71
72         Rename NotificationPresenter to NotificationClient
73         https://bugs.webkit.org/show_bug.cgi?id=80488
74         <rdar://problem/10965558>
75
76         Reviewed by Kentaro Hara.
77
78         Refactor to use renamed WebCore::NotificationClient.
79         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
80         (DRTDesktopNotificationPresenter::checkNotificationPermission):
81
82 2012-03-07  James Robinson  <jamesr@chromium.org>
83
84         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
85         https://bugs.webkit.org/show_bug.cgi?id=80523
86
87         Reviewed by Darin Fisher.
88
89         * DumpRenderTree/chromium/WebViewHost.cpp:
90         (WebViewHost::createGraphicsContext3D):
91         * DumpRenderTree/chromium/WebViewHost.h:
92         (WebViewHost):
93
94 2012-03-09  Eric Seidel  <eric@webkit.org>
95
96         build-webkit should build Source/WTF on Mac
97         https://bugs.webkit.org/show_bug.cgi?id=80728
98
99         Reviewed by Adam Barth.
100
101         We'll add other ports to this list in future commits.
102
103         * Scripts/build-webkit:
104
105 2012-03-09  Jon Lee  <jonlee@apple.com>
106
107         Add support for ENABLE(LEGACY_NOTIFICATIONS)
108         https://bugs.webkit.org/show_bug.cgi?id=80497
109
110         Reviewed by Adam Barth.
111
112         Prep for b80472: Update API for Web Notifications
113         * Scripts/build-webkit:
114         * qmake/mkspecs/features/features.prf:
115
116 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
117
118         Bash scripts should support LF endings only
119         https://bugs.webkit.org/show_bug.cgi?id=79509
120
121         Reviewed by David Kilzer.
122
123         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
124         * EWSTools/start-queue.sh: Added property svn:eol-style.
125         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
126         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
127         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
128         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
129
130 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
131
132         [BUILD] use detected python to run generate-gtkdoc
133         https://bugs.webkit.org/show_bug.cgi?id=80695
134
135         Reviewed by Gustavo Noronha Silva.
136
137         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
138
139 2012-03-09  Nat Duca  <nduca@chromium.org>
140
141         Make check-webkit-style complain about "no new tests" lines in changelogs
142         https://bugs.webkit.org/show_bug.cgi?id=80582
143
144         Reviewed by David Levin.
145
146         * Scripts/webkitpy/style/checkers/changelog.py:
147         (ChangeLogChecker.check_entry):
148         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
149         (ChangeLogCheckerTest.test_no_new_tests):
150
151 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
152
153         Unreviewed, rolling out r110250.
154         http://trac.webkit.org/changeset/110250
155         https://bugs.webkit.org/show_bug.cgi?id=80682
156
157         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
158         qt-linux at all. (Requested by Ossy on #webkit).
159
160         * Scripts/old-run-webkit-tests:
161         * Scripts/webkitpy/layout_tests/port/qt.py:
162         (QtPort):
163         (QtPort.determine_full_port_name):
164         (QtPort.baseline_search_path):
165         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
166         (QtPortTest):
167         (QtPortTest._assert_search_path):
168         (QtPortTest.test_baseline_search_path):
169
170 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
171
172         [Qt] Use Qt's module system for install rules and depending on QtWebKit
173
174         Instead of rolling our own install rules we now use the same approach as
175         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
176
177         This ensures that we follow the same semantics as the rest of Qt on
178         what sort of config options are enabled by default (create_cmake eg.).
179         It also allows us to use QT += webkit instead of the workaround we had
180         with CONFIG += qtwebkit.
181
182         We do however force Qt to always treat our build as a non-developer build,
183         so the libraries will end up in the WebKit lib directory instead of the
184         qtbase directory (as with a normal developer-build). This allows us to
185         keep the webkit-build self-contained. If Qt is a developer build we still
186         copy the module file manually to Qt, so that you don't have to install
187         WebKit to make it available.
188
189         For non-developer builds of Qt, it is still possible to use the built
190         WebKit libraries without having to install them, by having the variable
191         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
192         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
193
194         https://bugs.webkit.org/show_bug.cgi?id=80590
195
196         Reviewed by Simon Hausmann.
197
198         * DumpRenderTree/qt/DumpRenderTree.pro:
199         * MiniBrowser/qt/BrowserWindow.cpp:
200         * MiniBrowser/qt/MiniBrowser.pro:
201         * MiniBrowser/qt/MiniBrowserApplication.cpp:
202         * MiniBrowser/qt/UrlLoader.cpp:
203         * QtTestBrowser/QtTestBrowser.pro:
204         * Tools.pro:
205         * WebKitTestRunner/InjectedBundle/Target.pri:
206         * WebKitTestRunner/Target.pri:
207         * qmake/mkspecs/features/default_post.prf:
208         * qmake/mkspecs/features/default_pre.prf:
209         * qmake/mkspecs/features/functions.prf:
210         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
211         * qmake/mkspecs/features/qtwebkit.prf:
212         * qmake/mkspecs/features/rpath.prf:
213         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
214         * qmake/qt_webkit.pri: Added.
215
216 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
217
218         Unreviewed. Update my email.
219
220         * Scripts/webkitpy/common/config/committers.py:
221
222 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
223
224         Recent changes to chromium.py etc. broke chromium_android.py
225         https://bugs.webkit.org/show_bug.cgi?id=80623
226
227         Reviewed by Dirk Pranke.
228
229         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
230         (ChromiumAndroidDriver.__init__):
231         (ChromiumAndroidDriver._start):
232
233 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
234
235         [Chromium] Exception running reftest with --no-pixel-tests
236         https://bugs.webkit.org/show_bug.cgi?id=80642
237
238         Reviewed by Dirk Pranke.
239
240         * Scripts/webkitpy/layout_tests/port/chromium.py:
241         (ChromiumDriver.__init__):
242         (ChromiumDriver._wrapper_options):
243
244 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
245
246         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
247         https://bugs.webkit.org/show_bug.cgi?id=72489
248
249         Reviewed by Dirk Pranke.
250
251         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
252         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
253         --platform will override the platform name and then we'll use it.
254
255         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
256         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
257         override it in the end.
258
259         * Scripts/old-run-webkit-tests:
260         * Scripts/webkitpy/layout_tests/port/qt.py:
261         (QtPort):
262         (QtPort.determine_full_port_name):
263         (QtPort.baseline_search_path):
264         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
265         (QtPortTest):
266         (QtPortTest._assert_search_path):
267         (QtPortTest.test_baseline_search_path):
268
269 2012-03-08  Beth Dakin  <bdakin@apple.com>
270
271         https://bugs.webkit.org/show_bug.cgi?id=80463
272         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
273         -and corresponding-
274         <rdar://problem/10970221>
275
276         Reviewed by Dan Bernstein.
277
278         New test!
279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
280         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
281         (TestWebKitAPI):
282         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
283         (TestWebKitAPI::setPageLoaderClient):
284         (TestWebKitAPI::TEST):
285         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
286         (TestWebKitAPI):
287         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
288         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
289         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
290         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
291
292 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
293
294         [Qt] Prospective Windows build fix
295
296         Don't assume that windows-builds will always run inside a cmd.exe shell.
297
298         * qmake/mkspecs/features/default_pre.prf:
299
300 2012-03-08  Dan Bernstein  <mitz@apple.com>
301
302         <rdar://problem/10981173> Dashboard regions should not be in device space
303
304         Reviewed by John Sullivan.
305
306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
307         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
308         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
309         (TestWebKitAPI):
310         (TestWebKitAPI::TEST):
311
312 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
313
314         webkit-patch works oddly on local Git branches
315         https://bugs.webkit.org/show_bug.cgi?id=76958
316
317         Reviewed by Ojan Vafai.
318
319         This change makes the '-g' flag to webkit-patch behave a
320         little more consistently with git. The 'HEAD..' syntax
321         is changed to 'HEAD....' (four dots), so as to not
322         collide with the underlying git syntax. We also generalize
323         the syntax to support any refname, so 'foo....' means
324         diff against foo and include working copy changes.
325
326         This change also adds the 'UPSTREAM' shortcut to identify
327         whatever the current upstream/tracking branch is; this is
328         useful if you have multiple local branches stacked up.
329
330         * Scripts/webkitpy/common/checkout/scm/git.py:
331         (Git._branch_from_ref):
332         (Git):
333         (Git._current_branch):
334         (Git._upstream_branch):
335         (Git.merge_base):
336         (Git._commit_on_branch):
337         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
338         (GitSVNTest._second_local_commit):
339         (GitSVNTest._two_local_commits):
340         (GitSVNTest.test_commit_with_message_git_commit_range):
341         (GitSVNTest.test_upstream_branch):
342         (GitSVNTest.test_create_patch_working_copy_only):
343         (GitSVNTest.test_changed_files_local_plus_working_copy):
344         (GitSVNTest.test_changed_files_working_copy_only):
345         (GitSVNTest.test_changed_files_upstream):
346         * Scripts/webkitpy/tool/steps/options.py:
347         (Options):
348
349 2012-03-08  John Sullivan  <sullivan@apple.com>
350
351         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
352
353         Reviewed by Eric Carlson.
354
355         * Scripts/extract-localizable-strings:
356         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
357         with NSLocalized. Also improved an error message to include the troublesome token.
358
359 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
360
361         Unreviewed, rolling out r110115.
362         http://trac.webkit.org/changeset/110115
363         https://bugs.webkit.org/show_bug.cgi?id=80581
364
365         broke test-webkitpy (Requested by philn-tp on #webkit).
366
367         * Scripts/old-run-webkit-tests:
368         * Scripts/webkitpy/layout_tests/port/qt.py:
369         (QtPort):
370         (QtPort.determine_full_port_name):
371         (QtPort.baseline_search_path):
372
373 2012-03-08  Kentaro Hara  <haraken@chromium.org>
374
375         Unreviewed. Added myself to watchlist.
376
377         * Scripts/webkitpy/common/config/watchlist:
378
379 2012-03-07  Jessie Berlin  <jberlin@apple.com>
380
381         Clean Windows build fails after r110033
382         https://bugs.webkit.org/show_bug.cgi?id=80553
383
384         Rubber-stamped by Jon Honeycutt and Eric Seidel.
385
386         Add the new JavaScriptCore include directory to some more vsprops files.
387
388         * DumpRenderTree/win/ImageDiffCommon.vsprops:
389         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
390         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
391
392 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
393
394         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
395         https://bugs.webkit.org/show_bug.cgi?id=72489
396
397         Reviewed by Dirk Pranke.
398
399         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
400         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
401         --platform will override the platform name and then we'll use it.
402
403         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
404         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
405         override it in the end.
406
407         * Scripts/old-run-webkit-tests:
408         * Scripts/webkitpy/layout_tests/port/qt.py:
409         (QtPort):
410         (QtPort.determine_full_port_name):
411         (QtPort.baseline_search_path):
412
413 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
414
415         [Qt][WK2] MiniBrowser on desktop does not react to click events
416         https://bugs.webkit.org/show_bug.cgi?id=80314
417
418         Reviewed by Kenneth Rohde Christiansen.
419
420         Do not enable touch mocking on desktop mode.
421
422         * MiniBrowser/qt/MiniBrowserApplication.cpp:
423         (MiniBrowserApplication::handleUserOptions):
424
425 2012-03-07  Ojan Vafai  <ojan@chromium.org>
426
427         Automatically move to the next test after rebaseline in the results view
428         https://bugs.webkit.org/show_bug.cgi?id=80527
429
430         Reviewed by Dimitri Glazkov.
431
432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
434
435 2012-03-07  Ojan Vafai  <ojan@chromium.org>
436
437         garden-o-matic rebaseline is broken for ports that don't have a fallback port
438         https://bugs.webkit.org/show_bug.cgi?id=80526
439
440         Reviewed by Adam Barth.
441
442         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
443         since there is no "None" port.
444
445         * Scripts/webkitpy/tool/servers/gardeningserver.py:
446         (GardeningHTTPRequestHandler.rebaseline):
447         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
448         (GardeningServerTest.test_rebaseline):
449
450 2012-03-07  James Robinson  <jamesr@chromium.org>
451
452         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
453         https://bugs.webkit.org/show_bug.cgi?id=80521
454
455         Reviewed by Kenneth Russell.
456
457         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
458         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
459         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
460
461         Covered by platform/chromium/compositing/plugins/*
462
463         * DumpRenderTree/chromium/TestWebPlugin.cpp:
464         (TestWebPlugin::TestWebPlugin):
465         (TestWebPlugin::initialize):
466         (TestWebPlugin::updateGeometry):
467         (TestWebPlugin::initScene):
468         (TestWebPlugin::destroyScene):
469         * DumpRenderTree/chromium/TestWebPlugin.h:
470         (TestWebPlugin):
471         * DumpRenderTree/chromium/WebViewHost.cpp:
472         (WebViewHost::createPlugin):
473
474 2012-03-07  Philippe Normand  <pnormand@igalia.com>
475
476         [GTK] remove webkitpy dependency in run-gtk-tests
477         https://bugs.webkit.org/show_bug.cgi?id=80500
478
479         Reviewed by Martin Robinson.
480
481         Replace Executive calls with bare subprocess calls.
482
483         * Scripts/run-gtk-tests:
484         (TestRunner):
485         (TestRunner._lookup_atspi2_binary):
486         (TestRunner.run):
487         (TestRunner.run.run_for_real):
488
489 2012-03-07  Philippe Normand  <pnormand@igalia.com>
490
491         Unreviewed, GTK build fix after r110059.
492
493         * Scripts/run-gtk-tests:
494         (TestRunner._check_if_tests_have_timed_out):
495         (TestRunner.run.run_tests):
496         (TestRunner):
497
498 2012-03-07  Philippe Normand  <pnormand@igalia.com>
499
500         [GTK] race condition in run-gtk-tests
501         https://bugs.webkit.org/show_bug.cgi?id=80495
502
503         Reviewed by Martin Robinson.
504
505         Refactored the script to wait the a11y dbus service becomes
506         available before starting the tests.
507
508         * Scripts/run-gtk-tests:
509         (TestRunner._lookup_atspi2_binary):
510         (TestRunner):
511         (TestRunner._wait_dbus_service_and_run):
512         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
513         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
514         (TestRunner.run):
515         (TestRunner.run.bailout):
516         (TestRunner.run.run_for_real):
517
518 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
519
520         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
521         https://bugs.webkit.org/show_bug.cgi?id=80425
522
523         Reviewed by Simon Hausmann.
524
525         Set startScreenPos in mock touch point
526
527         * MiniBrowser/qt/MiniBrowserApplication.cpp:
528         (MiniBrowserApplication::notify):
529         * MiniBrowser/qt/MiniBrowserApplication.h:
530         (MiniBrowserApplication):
531
532 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
533
534         [Qt] Windows build fix.
535
536         Reviewed by Tor Arne Vestbø.
537
538         Pass the -j parameter only to "make", not "nmake".
539
540         * Scripts/webkitdirs.pm:
541         (buildQMakeProjects):
542
543 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
544
545         [Qt] Fix compilation without QtQuick1
546         https://bugs.webkit.org/show_bug.cgi?id=80503
547
548         Reviewed by Tor Arne Vestbø.
549
550         Introduce HAVE_QQUICK1 as feature and added haveQtModule
551         as convenience function.
552
553         * qmake/mkspecs/features/features.prf:
554         * qmake/mkspecs/features/functions.prf:
555
556 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
557
558         [Qt] Add qmake config tests for JPEG and PNG library
559         https://bugs.webkit.org/show_bug.cgi?id=80398
560
561         Add JPEG and PNG library tests to config.tests and
562         add error() abort to WebCore.pri if tests don't work.
563
564         Reviewed by Tor Arne Vestbø.
565
566         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
567         (main):
568         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
569         * qmake/config.tests/libpng/libpng.cpp: Added.
570         (main):
571         * qmake/config.tests/libpng/libpng.pro: Added.
572         * qmake/sync.profile:
573
574 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
575
576         [EFL] Build warning: Fix warn_unused_result warnings.
577         https://bugs.webkit.org/show_bug.cgi?id=79194
578
579         Reviewed by Filip Pizlo.
580
581         Fixed build warning which is getting generated when not using return
582         value of a fuction, especially declared with warn_unused_result
583         attribute.
584
585         * DumpRenderTree/efl/ImageDiff.cpp:
586         (printImage):
587
588 2012-03-07  Kangil Han  <kangil.han@samsung.com>
589
590         [DRT] Remove PlainTextController implementations.
591         https://bugs.webkit.org/show_bug.cgi?id=79959
592
593         Reviewed by Hajime Morita.
594
595         PlainTextController usages in existing tests have been
596         replaced by internals API by bug 78570.
597         So this patch will remove PlainTextController implementations
598         to avoid further usage in new tests.
599
600         * DumpRenderTree/DumpRenderTree.gypi:
601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
602         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
603         * DumpRenderTree/chromium/PlainTextController.h: Removed.
604         * DumpRenderTree/chromium/TestShell.cpp:
605         (TestShell::TestShell):
606         (TestShell::bindJSObjectsToWindow):
607         * DumpRenderTree/chromium/TestShell.h:
608         (TestShell):
609         * DumpRenderTree/gtk/DumpRenderTree.cpp:
610         (webViewWindowObjectCleared):
611         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
612         * DumpRenderTree/gtk/PlainTextController.h: Removed.
613         * DumpRenderTree/mac/FrameLoadDelegate.mm:
614         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
615         * DumpRenderTree/mac/PlainTextController.h: Removed.
616         * DumpRenderTree/mac/PlainTextController.mm: Removed.
617         * DumpRenderTree/qt/DumpRenderTree.pro:
618         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
619         (WebCore::DumpRenderTree::DumpRenderTree):
620         (WebCore::DumpRenderTree::initJSObjects):
621         * DumpRenderTree/qt/DumpRenderTreeQt.h:
622         (DumpRenderTree):
623         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
624         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
625         * GNUmakefile.am:
626
627 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
628
629         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
630         https://bugs.webkit.org/show_bug.cgi?id=80137
631
632         Reviewed by Eric Seidel.
633
634         Adds implementation LayoutTestController's setPopupBlockingEnabled.
635         To pass popup-blocking-click-in-iframe.html EventSender should not
636         repeat click events in idler's function. EventSender allows to
637         asynchronously send click event through ecore_idler_add.
638         This event will be called repeatedly as long as it return true.
639         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
640
641         * DumpRenderTree/efl/EventSender.cpp:
642         (sendMouseEvent): Changed return value from bool to void because it always returns true.
643         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
644         (mouseDownCallback): Remove unnecessary checking of return value.
645         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
646         (LayoutTestController::setPopupBlockingEnabled):
647
648 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
649
650         rebaseline_chromium_webkit_tests is obsolete and should be removed
651         https://bugs.webkit.org/show_bug.cgi?id=80347
652
653         Reviewed by Tony Chang.
654
655         * Scripts/rebaseline-chromium-webkit-tests: Removed.
656         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
657         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
658
659 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
660
661         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
662         https://bugs.webkit.org/show_bug.cgi?id=80468
663
664         Unreviewed, build fix.
665
666         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
667
668         * Scripts/webkitpy/layout_tests/servers/http_server.py:
669         (Lighttpd._prepare_config):
670
671 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
672
673         remove chromium_gpu ports
674         https://bugs.webkit.org/show_bug.cgi?id=80345
675
676         Reviewed by Ojan Vafai.
677
678         This change leaves in the 'graphics_type' distinction in the
679         test_expectations; removing that will require more updates and a
680         pass over test_expectations.txt, so I'm separating that out.
681
682         * Scripts/webkitpy/layout_tests/port/builders.py:
683         * Scripts/webkitpy/layout_tests/port/chromium.py:
684         (ChromiumPort):
685         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
686         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
687         * Scripts/webkitpy/layout_tests/port/factory.py:
688         (PortFactory):
689         (PortFactory.get):
690         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
691         (FactoryTest.test_qt):
692         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
693         (TestRebaseline.test_rebaseline_expectations):
694
695 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
696
697         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
698         https://bugs.webkit.org/show_bug.cgi?id=80282
699
700         Reviewed by Antonio Gomes.
701
702         Remove transitive library dependencies; they are especially
703         dangerous when one ends up linking against WTF, JSC and then WTF
704         again, since some symbols will not be defined.
705
706         Passing --no-copy-dt-needed-entries and --as-needed to the linker
707         (which some recent Linux distros do by default) makes the issue
708         even more evident.
709
710         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
711         as the other libraries have the needed symbols. Explicitly link
712         against fontconfig.
713
714 2012-03-06  Dean Jackson  <dino@apple.com>
715
716         filter-build-webkit needs more filters
717         https://bugs.webkit.org/show_bug.cgi?id=80440
718
719         Reviewed by Joseph Pecoraro.
720
721         Added as many missing filters as I could find for Apple
722         builds. Plus a few minor style updates.
723
724         * Scripts/filter-build-webkit:
725         (printLine):
726
727 2012-03-06  Ojan Vafai  <ojan@chromium.org>
728
729         Copying old baselines throws an error if the new directory doesn't exist
730         https://bugs.webkit.org/show_bug.cgi?id=80443
731
732         Reviewed by Adam Barth.
733
734         Existing tests cover the new code with the fix to filesystem_mock.
735
736         * Scripts/webkitpy/common/system/filesystem_mock.py:
737         (MockFileSystem.copyfile):
738         Fix the mock to better match python's copyfile semantics.
739
740         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
741         (Rebaseliner._create_html_baseline_files):
742         * Scripts/webkitpy/tool/commands/rebaseline.py:
743         (RebaselineTest._copy_existing_baseline):
744
745 2012-03-05  Ojan Vafai  <ojan@chromium.org>
746
747         Add a mechanism to rebaseline new ports
748         https://bugs.webkit.org/show_bug.cgi?id=80355
749
750         Reviewed by Adam Barth.
751
752         For a test that's only failing on a new port, we want
753         to first copy the existing result into the location for the
754         port it's replacing in order to not break that port.
755
756         For example, bringing up the chromium-lion port, if we just
757         stick the results in the chromium-mac directory, the snow leopard
758         will start failing. Instead, we first copy the existing result
759         to the chromium-mac-snowleopard directory.
760
761         * Scripts/webkitpy/layout_tests/port/builders.py:
762         (builder_path_for_port_name):
763         (fallback_port_name_for_new_port):
764         * Scripts/webkitpy/tool/commands/rebaseline.py:
765         (RebaselineTest):
766         (RebaselineTest._copy_existing_baseline):
767         (RebaselineTest._rebaseline_test):
768         (RebaselineTest.execute):
769         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
770         (TestRebaseline.test_rebaseline_test):
771         (TestRebaseline):
772         (TestRebaseline.test_rebaseline_and_copy_test):
773         (test_rebaseline_and_copy_test_no_existing_result):
774         (test_rebaseline_and_copy_test_with_lion_result):
775         (test_rebaseline_and_copy_no_overwrite_test):
776         * Scripts/webkitpy/tool/servers/gardeningserver.py:
777         (GardeningHTTPRequestHandler.rebaseline):
778         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
779         (GardeningServerTest.test_rebaseline):
780         (GardeningServerTest):
781         (GardeningServerTest.test_rebaseline_new_port):
782
783 2012-03-06  Beth Dakin  <bdakin@apple.com>
784
785         https://bugs.webkit.org/show_bug.cgi?id=80351
786         InlineTextBox is using the wrong origin when calling 
787         addRelevantRepaintedObject
788         -and corresponding-
789         <rdar://problem/10970221>
790
791         Reviewed by Sam Weinig.
792
793         This test has actually been broken since revision 109273. This change makes 
794         the test pass again, and it makes it specifically exercise the fix for this 
795         bug.
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
798         (TestWebKitAPI::TEST):
799
800         Adjust comments in the other tests to reflect the API changes from 109273.
801         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
802         (TestWebKitAPI::TEST):
803         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
804         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
805         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
806         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
807         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
808         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
809         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
810
811 2012-03-06  Hans Wennborg  <hans@chromium.org>
812
813         Speech JavaScript API: add SpeechRecognitionError
814         https://bugs.webkit.org/show_bug.cgi?id=80410
815
816         Chromium: enable the runtime flag for scripted speech so we can run
817         the layout tests for it.
818
819         Reviewed by Adam Barth.
820
821         * DumpRenderTree/chromium/TestShell.cpp:
822         (TestShell::TestShell):
823
824 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
825
826         Enable universal newlines in chromium android layout test runner
827         https://bugs.webkit.org/show_bug.cgi?id=80418
828
829         Reviewed by Adam Barth.
830
831         The Chromium Android layout test runner uses the 'adb' program to
832         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
833         output lines from the test runner, while the test expectation files are
834         written with LF ('\n') delimiters. This causes the results to have
835         spurious whitespace differences, making them more difficult to
836         interpret.
837
838         The fix is to enable universal newlines for the DumpRenderTree pipe,
839         causing the output to only contain LF newlines like on other platforms.
840
841         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
842         (ChromiumAndroidDriver._start):
843
844 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
845
846         [Qt] Revert r109900, it was completly busted
847
848         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
849
850         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
851         of manual define checks.
852
853         Reviewed by Ossy.
854
855         * DumpRenderTree/qt/DumpRenderTree.pro:
856         * QtTestBrowser/QtTestBrowser.pro:
857         * WebKitTestRunner/InjectedBundle/Target.pri:
858         * qmake/mkspecs/features/features.prf:
859
860 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
861
862         [Qt] Use config test to determine if the compiler supports -MD
863
864         We used to assume that unix systems building against Qt5 would have
865         a compiler that supported -MD. Although this was usually the case,
866         we failed to take into account broken tools for distributed builds
867         (e.g. teambuilder or icecream) which would end up producing .d files
868         in the root of the build dir instead of along-side the object file.
869
870         Now that we use a config-test to determine the support, we'll capture
871         those cases, unless distributed builds are enabled after the initial
872         build-webkit run.
873
874         Reviewed by Csaba Osztrogonác.
875
876         * Tools.pro:
877         * qmake/config.tests/gccdepends/empty.cpp: Added.
878         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
879         * qmake/mkspecs/features/default_pre.prf:
880         * qmake/mkspecs/features/features.prf:
881         * qmake/mkspecs/features/unix/default_pre.prf:
882         * qmake/sync.profile:
883
884 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
885
886         REGRESSION(r109294): It broke the unittest of master.cfg
887         https://bugs.webkit.org/show_bug.cgi?id=80253
888
889         Reviewed by Tor Arne Vestbø.
890
891         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
892         (BuildBotConfigLoader._create_mock_passwords_dict):
893         (BuildBotConfigLoader._mock_open):
894         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
895         (BuildBotConfigLoader.load_config):
896
897 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
898
899         Qt API test buildstep throws exception after buildmaster update
900         https://bugs.webkit.org/show_bug.cgi?id=80249
901
902         This patch based on Peter Gal's work.
903
904         Reviewed by Csaba Osztrogonác.
905
906         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
907         (RunQtAPITests):
908         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
909
910 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
911
912         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
913
914         Reviewed by Simon Hausmann.
915         Reviewed by Ossy.
916
917         * DumpRenderTree/qt/DumpRenderTree.pro:
918         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
919         (WebKit::initializeTestFonts):
920         * QtTestBrowser/QtTestBrowser.pro:
921         * WebKitTestRunner/InjectedBundle/Target.pri:
922         * qmake/mkspecs/features/features.prf:
923
924 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
925
926         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
927
928         Reviewed by Ossy.
929
930         * qmake/mkspecs/features/default_post.prf:
931
932 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
933
934         [Qt] Make sure clean builds are followed by make qmake && make if needed
935
936         On non-GNUmake systems we have to run make qmake so that the generated
937         sources are generated before we run qmake on the target pro files. This
938         is achieved by using the 'incremental' target.
939
940         Reviewed by Ossy.
941
942         * Scripts/webkitdirs.pm:
943         (buildQMakeProjects):
944
945 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
946
947         DumpRenderTree should support preciseTime()
948         https://bugs.webkit.org/show_bug.cgi?id=80397
949
950         Reviewed by Gavin Barraclough.
951
952         * DumpRenderTree/LayoutTestController.cpp:
953         (preciseTimeCallback):
954         (LayoutTestController::staticFunctions):
955
956 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
957
958         Unreviewed, rolling out r109887.
959         http://trac.webkit.org/changeset/109887
960         https://bugs.webkit.org/show_bug.cgi?id=80402
961
962         It broke the build (Requested by Ossy on #webkit).
963
964         * DumpRenderTree/qt/DumpRenderTree.pro:
965         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
966         (WebKit::initializeTestFonts):
967         * QtTestBrowser/QtTestBrowser.pro:
968         * WebKitTestRunner/InjectedBundle/Target.pri:
969         * qmake/mkspecs/features/features.prf:
970
971 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
972
973         Unreviewed, rolling out r109837.
974         http://trac.webkit.org/changeset/109837
975         https://bugs.webkit.org/show_bug.cgi?id=80399
976
977         breaks Mac Productions builds, too late to try and fix it
978         tonight (Requested by eseidel on #webkit).
979
980         * Scripts/build-webkit:
981
982 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
983
984         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
985
986         Reviewed by Simon Hausmann.
987
988         * DumpRenderTree/qt/DumpRenderTree.pro:
989         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
990         (WebKit::initializeTestFonts):
991         * QtTestBrowser/QtTestBrowser.pro:
992         * WebKitTestRunner/InjectedBundle/Target.pri:
993         * qmake/mkspecs/features/features.prf:
994
995 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
996
997         [Qt] Create EWS to build WebKit2
998         https://bugs.webkit.org/show_bug.cgi?id=80277
999
1000         Reviewed by Csaba Osztrogonác.
1001
1002         * QueueStatusServer/model/queues.py:
1003         (Queue):
1004         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1005         (QtWK2EWS):
1006         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1007         (EarlyWarningSytemTest.test_builder_ewses):
1008
1009 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1010
1011         Unreviewed, rolling out r109733.
1012         http://trac.webkit.org/changeset/109733
1013         https://bugs.webkit.org/show_bug.cgi?id=80378
1014
1015         It broke Qt5 build system (Requested by Ossy on #webkit).
1016
1017         * Tools.pro:
1018         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1019         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1020         * qmake/mkspecs/features/default_pre.prf:
1021         * qmake/mkspecs/features/features.prf:
1022         * qmake/mkspecs/features/unix/default_pre.prf:
1023         * qmake/sync.profile:
1024
1025 2012-03-05  Eric Seidel  <eric@webkit.org>
1026
1027         Update JavaScriptCore files to use fully-qualified WTF include path
1028         https://bugs.webkit.org/show_bug.cgi?id=79960
1029
1030         Reviewed by Adam Barth.
1031
1032         Build WTF/WTF.xcodeproj by default on Mac.
1033
1034         * Scripts/build-webkit:
1035
1036 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1037
1038         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
1039         https://bugs.webkit.org/show_bug.cgi?id=69590
1040
1041         Reviewed by Ryosuke Niwa.
1042
1043         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
1044         to skip the 'optimize-expectations' step.
1045
1046         * Scripts/webkitpy/tool/commands/rebaseline.py:
1047         (RebaselineExpectations.__init__):
1048         (RebaselineExpectations.execute):
1049         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1050
1051 2012-03-05  Kent Tamura  <tkent@chromium.org>
1052
1053         [Chromium] Add new popup type: PagePopup
1054         https://bugs.webkit.org/show_bug.cgi?id=80106
1055
1056         Reviewed by Darin Fisher.
1057
1058         * DumpRenderTree/chromium/WebViewHost.cpp:
1059         (WebViewHost::createPopupMenu):
1060
1061 2012-03-05  Jessie Berlin  <jberlin@apple.com>
1062
1063         Add myself as a reviewer.
1064
1065         * Scripts/webkitpy/common/config/committers.py:
1066         Also, add my IRC nick so it is easier to find and yell at me.
1067
1068 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
1069
1070         Correctly compute the positions of GestureScroll* events on
1071         Chromium.
1072         https://bugs.webkit.org/show_bug.cgi?id=80075
1073
1074         Reviewed by Adam Barth.
1075
1076         * DumpRenderTree/chromium/EventSender.cpp:
1077         (EventSender::reset):
1078         (EventSender::gestureEvent):
1079         * DumpRenderTree/chromium/EventSender.h:
1080         (EventSender):
1081
1082 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1083
1084         flakiness dashboard doesn't display baselines for virtual tests correctly
1085         https://bugs.webkit.org/show_bug.cgi?id=80341
1086
1087         Reviewed by Ojan Vafai.
1088
1089         If the test is part of a virtual test suite, we need to look for
1090         baselines in the underlying fallback path for the actual test
1091         being run, as well as baselines for the virtual version.
1092
1093         This patch adds code to handle both branches and also pulls the
1094         mapping of the test suites up into a constant.
1095
1096         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1097         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1098         (testLookupVirtualTestSuite):
1099         (testBaseTest):
1100
1101 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1102
1103         Unreviewed, rolling out r109760.
1104         http://trac.webkit.org/changeset/109760
1105         https://bugs.webkit.org/show_bug.cgi?id=80320
1106
1107         Caused many GTK+ tests to crash (Requested by mrobinson on
1108         #webkit).
1109
1110         * gtk/jhbuild.modules:
1111
1112 2012-03-05  Charlie Reis  <creis@chromium.org>
1113
1114         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
1115         https://bugs.webkit.org/show_bug.cgi?id=80057
1116
1117         Reviewed by Darin Fisher.
1118
1119         * DumpRenderTree/chromium/WebViewHost.cpp:
1120         (WebViewHost::createView):
1121         * DumpRenderTree/chromium/WebViewHost.h:
1122         (WebViewHost):
1123
1124 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
1125
1126         [soup] Crash while loading http://www.jusco.cn
1127         https://bugs.webkit.org/show_bug.cgi?id=68238
1128
1129         Reviewed by Philippe Normand.
1130
1131         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
1132         in the jhbuild file.
1133
1134 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1135
1136         Unreviewed, rolling out r109748.
1137         http://trac.webkit.org/changeset/109748
1138         https://bugs.webkit.org/show_bug.cgi?id=80296
1139
1140         Made some tests crash, will fix and recommit (Requested by
1141         noamr on #webkit).
1142
1143         * MiniBrowser/qt/main.cpp:
1144         (main):
1145
1146 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
1147
1148         [GTK] plugins/netscape-plugin-page-cache-works.html fails
1149         https://bugs.webkit.org/show_bug.cgi?id=74409
1150
1151         Reviewed by Martin Robinson.
1152
1153         Add support for overriding the page-cache-for-plugins preference
1154         through DumpRenderTreeSupport.
1155
1156         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1157         (booleanFromValue): A helper function to convert a string to boolean.
1158         (LayoutTestController::overridePreference):
1159
1160 2012-03-05  Rob Buis  <rbuis@rim.com>
1161
1162         [BlackBerry] Update Tools/DumpRenderTree
1163         https://bugs.webkit.org/show_bug.cgi?id=80287
1164
1165         Reviewed by Antonio Gomes.
1166
1167         Update so we are sure we can build our implementation of DRT.
1168
1169         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
1170         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
1171         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
1172         (AccessibilityController::addNotificationListener): add missing hook.
1173         (AccessibilityController::removeNotificationListener): add missing hook.
1174         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1175         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
1176         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1177         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
1178         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
1179
1180 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
1181
1182         [Qt] [WK2] Support threaded renderer in WK2
1183         https://bugs.webkit.org/show_bug.cgi?id=76661
1184
1185         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
1186
1187         Reviewed by Kenneth Rohde Christiansen.
1188
1189         * MiniBrowser/qt/main.cpp:
1190         (main):
1191
1192 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1193
1194         Unreviewed. Add myself to committer list.
1195
1196         * Scripts/webkitpy/common/config/committers.py:
1197
1198 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1199
1200         [Qt] Use config test to determine if the compiler supports -MD
1201
1202         We used to assume that unix systems building against Qt5 would have
1203         a compiler that supported -MD. Although this was usually the case,
1204         we failed to take into account broken tools for distributed builds
1205         (e.g. teambuilder or icecream) which would end up producing .d files
1206         in the root of the build dir instead of along-side the object file.
1207
1208         Now that we use a config-test to determine the support, we'll capture
1209         those cases, unless distributed builds are enabled after the initial
1210         build-webkit run.
1211
1212         Reviewed by Csaba Osztrogonác.
1213
1214         * Tools.pro:
1215         * qmake/config.tests/gccdepends/empty.cpp: Added.
1216         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1217         * qmake/mkspecs/features/default_pre.prf:
1218         * qmake/mkspecs/features/features.prf:
1219         * qmake/mkspecs/features/unix/default_pre.prf:
1220         * qmake/sync.profile:
1221
1222 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1223
1224         Qt API test buildstep throws exception after buildmaster update
1225         https://bugs.webkit.org/show_bug.cgi?id=80249
1226
1227         Reviewed by Zoltan Herczeg.
1228
1229         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
1230         (BuildAndTestFactory.__init__):
1231
1232 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1233
1234         [GTK] Unit tests are noisy when run under jhbuild
1235         https://bugs.webkit.org/show_bug.cgi?id=80241
1236
1237         Reviewed by Philippe Normand.
1238
1239         Force the 'memory' backend in GSettings so that each unit
1240         test doesn't produce a warning when it's forced to fall back
1241         to the 'memory' backend.
1242
1243         * Scripts/run-gtk-tests:
1244         (TestRunner.run): Force the 'memory' backend.
1245
1246 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1247
1248         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
1249         https://bugs.webkit.org/show_bug.cgi?id=80235
1250
1251         Reviewed by Philippe Normand.
1252
1253         * Scripts/run-gtk-tests:
1254         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
1255         inspector resources path determination is shared by all tests.
1256
1257 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1258
1259         [GTK] REGRESSION: r108278 broke some tests that expect focus
1260         https://bugs.webkit.org/show_bug.cgi?id=79084
1261
1262         Reviewed by Philippe Normand.
1263
1264         Grab focus when dumping test results and also when sending
1265         events. During the course of testing, the WebView may lose
1266         focus and this seems to snap it back when tests demand it.
1267
1268         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1269         (dump): Grab focus.
1270         * DumpRenderTree/gtk/EventSender.cpp:
1271         (dispatchEvent): Ditto.
1272
1273 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
1274
1275         Unreviewed, Add myself to committer list.
1276         https://bugs.webkit.org/show_bug.cgi?id=80232
1277
1278         * Scripts/webkitpy/common/config/committers.py:
1279
1280 2012-03-04  Anders Carlsson  <andersca@apple.com>
1281
1282         Newer versions of clang fail to compile WebKit.
1283
1284         Fix build.
1285
1286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1287         (descriptionOfValue):
1288         (AccessibilityUIElement::rowIndexRange):
1289         (AccessibilityUIElement::columnIndexRange):
1290         (AccessibilityUIElement::selectedTextRange):
1291         * DumpRenderTree/mac/EditingDelegate.mm:
1292         (-[DOMRange dump]):
1293         * DumpRenderTree/mac/PolicyDelegate.mm:
1294         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
1295         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1296         (-[NSError _drt_descriptionSuitableForTestResult]):
1297         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1298         (WTR::descriptionOfValue):
1299         (WTR::AccessibilityUIElement::rowIndexRange):
1300         (WTR::AccessibilityUIElement::columnIndexRange):
1301         (WTR::AccessibilityUIElement::selectedTextRange):
1302
1303 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
1304
1305         [Qt] Fix static_libs_as_shared build
1306         https://bugs.webkit.org/show_bug.cgi?id=80214
1307
1308         Reviewed by Tor Arne Vestbø.
1309
1310         * WebKitTestRunner/qt/main.cpp:
1311         (main): Set the correct environment variable for choosing the theme in the
1312         web process.
1313
1314 2012-03-03  Hans Wennborg  <hans@chromium.org>
1315
1316         Implement Speech JavaScript API
1317         https://bugs.webkit.org/show_bug.cgi?id=80019
1318
1319         Reviewed by Adam Barth.
1320
1321         Add ENABLE_SCRIPTED_SPEECH.
1322
1323         * Scripts/build-webkit:
1324         * qmake/mkspecs/features/features.prf:
1325
1326 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
1327
1328         Fix commit queue, remove duplicate entry.
1329
1330         * Scripts/webkitpy/common/config/committers.py:
1331
1332 2012-03-02  Stephen Chenney  <schenney@chromium.org>
1333
1334         Unreviewed, add myself as a committer
1335
1336         * Scripts/webkitpy/common/config/committers.py:
1337
1338 2012-03-02  Ojan Vafai  <ojan@chromium.org>
1339
1340         Add the Chromium Lion canary bot to the flakiness dashboard.
1341         * TestResultServer/static-dashboards/builders.js:
1342
1343 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
1344
1345         links for virtual tests are broken in the flakiness dashboard
1346         https://bugs.webkit.org/show_bug.cgi?id=80180
1347
1348         Reviewed by Ojan Vafai.
1349
1350         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1351         (linkHTMLToOpenWindow):
1352         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1353         (testLinkHTMLToOpenWindow): added.
1354
1355 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1356
1357         [GTK] security/block-test.html baselines differ from mac
1358         https://bugs.webkit.org/show_bug.cgi?id=78343
1359
1360         Reviewed by Martin Robinson.
1361
1362         Improved the FrameLoader error heuristics to match mac behavior a
1363         bit more.
1364
1365         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1366         (pathFromSoupURI): Handle ftp urls the same as http urls.
1367         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
1368
1369 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1370
1371         [Qt][WK2] Fix typo in patch committed in r109575
1372
1373         Unreviewed typo fix.
1374
1375         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1376         (MiniBrowserApplication::notify): Cache the position
1377         in floating point coordinates.
1378
1379 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1380
1381         [Qt][WK2] Infinite loop on history navigation, when panning
1382         https://bugs.webkit.org/show_bug.cgi?id=79119
1383
1384         Reviewed by Simon Hausmann.
1385
1386         Make the touch mocking more robust by creating touch events
1387         directly and sending them synchronously to the browser window.
1388         If the sent touch event was not accepted we propagate the
1389         original mouse event to its target.
1390         This way we make sure we only send either a touch or a mouse
1391         event and do not end up in an infinite loop between our mocking
1392         code and the Qt5 automatic mouse event synthesizing.
1393
1394         * MiniBrowser/qt/BrowserWindow.cpp:
1395         (BrowserWindow::updateVisualMockTouchPoints):
1396         * MiniBrowser/qt/BrowserWindow.h:
1397         (BrowserWindow):
1398         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1399         (touchRectForPosition):
1400         (MiniBrowserApplication::notify):
1401         (MiniBrowserApplication::sendTouchEvent):
1402         * MiniBrowser/qt/MiniBrowserApplication.h:
1403         (MiniBrowserApplication):
1404
1405 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1406
1407         [Qt] Use 'all' as default target when debug_and_release is in effect
1408
1409         When debug_and_release is enabled, in combination with build_all,
1410         qmake will generate an aggregate makefile that calls make on both
1411         the debug and the release makefiles, but with the 'all' target.
1412
1413         In this case we can't use 'first' as the default target, as the
1414         extra targets would then not be run, so we append extra targets
1415         to 'all' instead.
1416
1417         Reviewed by Simon Hausmann.
1418
1419         * qmake/mkspecs/features/default_post.prf:
1420
1421 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1422
1423         [Qt] Make sure activeBuildConfig() returns the right config
1424
1425         Using isActiveConfig fails, as that only checks if the given
1426         argument is in CONFIG, not the order.
1427
1428         Reviewed by Simon Hausmann.
1429
1430         * qmake/mkspecs/features/functions.prf:
1431
1432 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1433
1434         [Qt] Fix tests run with WTR not using QStyle theme
1435         https://bugs.webkit.org/show_bug.cgi?id=80147
1436
1437         Reviewed by Csaba Osztrogonác.
1438
1439         * WebKitTestRunner/qt/main.cpp:
1440         (main): Set environment variable for web process to use QStyle theme.
1441
1442 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1443
1444         Unreviewed, remove debug print call.
1445
1446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1447         (descriptionSuitableForTestResult):
1448
1449 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1450
1451         Updated EventSender to send complete gesture events.
1452         https://bugs.webkit.org/show_bug.cgi?id=80075
1453
1454         Reviewed by Adam Barth.
1455
1456         * DumpRenderTree/chromium/EventSender.cpp:
1457         (EventSender::gestureEvent): set additional parameters in sent events.
1458
1459 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1460
1461         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1462         https://bugs.webkit.org/show_bug.cgi?id=80033
1463
1464         Reviewed by Gustavo Noronha Silva.
1465
1466         GCC 4.7 no longer includes unistd.h from most of the standard C++
1467         header files, so we need to explicitly include it for getcwd().
1468
1469         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1470         not only on Mac, but on all Unix platforms.
1471
1472 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1473
1474         Actually look at the args in driver_input :(.
1475
1476         Unreviewed, build fix.
1477
1478         * Scripts/webkitpy/layout_tests/port/chromium.py:
1479         (ChromiumDriver.run_test):
1480
1481 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1482
1483         Fix typo in flag used to run gpu virtual suites.
1484
1485         Unreviewed, build fix.
1486
1487         * Scripts/webkitpy/layout_tests/port/chromium.py:
1488         (ChromiumPort.virtual_test_suites):
1489
1490 2012-03-01  Adam Barth  <abarth@webkit.org>
1491
1492         Unreviewed, rolling out r109317.
1493         http://trac.webkit.org/changeset/109317
1494
1495         Let's try watchlists again now that we're using a pure git
1496         working copy
1497
1498         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1499         (StyleQueueTask.run):
1500         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1501
1502 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1503
1504         webkitpy: test_run_test_pause_before_testing is failing after r109482
1505         https://bugs.webkit.org/show_bug.cgi?id=80084
1506
1507         Unreviewed, build fix.
1508
1509         Fixes the test string compare to ignore the time spent running
1510         the tests.
1511
1512         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1513         (test_run_test_pause_before_testing):
1514
1515 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1516
1517         nrwt: virtual tests aren't being run
1518         https://bugs.webkit.org/show_bug.cgi?id=80083
1519
1520         Reviewed by Eric Seidel.
1521
1522         If we tried to run all of the tests by default (and
1523         didn't specify any paths), the virtual tests weren't
1524         picked up.
1525
1526         * Scripts/webkitpy/layout_tests/port/base.py:
1527         (Port._virtual_tests):
1528         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1529         (PortTest.test_tests):
1530         * Scripts/webkitpy/layout_tests/port/test.py:
1531         (TestPort.virtual_test_suites):
1532
1533 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1534
1535         run-perf-tests should report the test runtime
1536         https://bugs.webkit.org/show_bug.cgi?id=80078
1537
1538         Reviewed by Hajime Morita.
1539
1540         Record and output the aggreated test run time.
1541
1542         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1543         (PerfTestsRunner._run_single_test):
1544
1545 2012-03-01  Michael Nordman  <michaeln@google.com>
1546
1547         [chromium] Use webkit_support to create session storage namespaces in DRT.
1548         https://bugs.webkit.org/show_bug.cgi?id=79933
1549
1550         Reviewed by Tony Chang.
1551
1552         * DumpRenderTree/chromium/WebViewHost.cpp:
1553         (WebViewHost::createSessionStorageNamespace):
1554
1555 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1556
1557         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1558         https://bugs.webkit.org/show_bug.cgi?id=80048
1559
1560         Reviewed by Adam Barth.
1561
1562         * Scripts/webkitpy/layout_tests/port/base.py:
1563         (Port.test_isfile):
1564         (Port.test_isdir):
1565         (Port):
1566         (Port.test_exists):
1567         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1568         (PortTest.test_test_exists):
1569         (PortTest):
1570         (PortTest.test_test_isfile):
1571         (PortTest.test_test_isdir):
1572         * Scripts/webkitpy/layout_tests/port/test.py:
1573         (TestPort.virtual_test_suites):
1574         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1575         (MainTest.test_virtual):
1576
1577 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1578
1579         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1580         https://bugs.webkit.org/show_bug.cgi?id=80031
1581
1582         Reviewed by Gustavo Noronha Silva.
1583
1584         Only build the libTestRunnerInjectedBundle.la convenience library when
1585         ENABLE_WEBKIT2 is defined.
1586
1587         * WebKitTestRunner/GNUmakefile.am:
1588
1589 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1590
1591         Unreviewed, second attempt to fix GTK NRWT after r109242.
1592
1593         * Scripts/webkitpy/layout_tests/port/gtk.py:
1594         (GtkDriver._start):
1595
1596 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1597
1598         Unreviewed, GTK NRWT build fix attempt after r109242.
1599
1600         * Scripts/webkitpy/layout_tests/port/gtk.py:
1601         (GtkDriver._start):
1602
1603 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1604
1605         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1606         https://bugs.webkit.org/show_bug.cgi?id=80008
1607
1608         Reviewed by Adam Barth.
1609
1610         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1611         to "preprocess-idls.pl". This patch renames it.
1612
1613         Test: Confirm that run-bindings-tests runs.
1614
1615         * Scripts/webkitpy/bindings/main.py:
1616         (BindingsTests.generate_supplemental_dependency):
1617
1618 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1619
1620         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1621         https://bugs.webkit.org/show_bug.cgi?id=78047
1622
1623         Reviewed by Kenneth Rohde Christiansen.
1624
1625         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1626         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1627         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1628         the event handlers directly, and with the removal of our own dispatching we need to go through
1629         that code path.
1630
1631         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1632         (WTR::PlatformWebView::sendEvent):
1633         (WTR::PlatformWebView::postEvent):
1634
1635 2012-02-29  Adam Barth  <abarth@webkit.org>
1636
1637         Disable watchlist.  It's been spamming CCs.
1638
1639         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1640         (StyleQueueTask.run):
1641         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1642
1643 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1644
1645         need to clone the gpu baselines and expectations into the new "virtual" dir
1646         https://bugs.webkit.org/show_bug.cgi?id=79956
1647
1648         Reviewed by Adam Barth.
1649
1650         * Scripts/webkitpy/layout_tests/port/chromium.py:
1651         (ChromiumPort.virtual_test_suites):
1652
1653 2012-02-29  Mark Rowe  <mrowe@apple.com>
1654
1655         Switch to using json rather than simplejson now that the master is using Python 2.7.
1656
1657         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1658         (loadBuilderConfig):
1659
1660 2012-02-29  David Levin  <levin@chromium.org>
1661
1662         [chromium] Add the ability to turn off autoresize.
1663         https://bugs.webkit.org/show_bug.cgi?id=77452
1664
1665         Reviewed by Darin Fisher.
1666
1667         * DumpRenderTree/chromium/LayoutTestController.cpp:
1668         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1669         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1670         (LayoutTestController::disableAutoResizeMode):  Ditto.
1671         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1672
1673 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1674
1675         nrwt: make --print trace work with virtual tests
1676         https://bugs.webkit.org/show_bug.cgi?id=79952
1677
1678         Reviewed by Adam Barth.
1679
1680         * Scripts/webkitpy/layout_tests/views/printing.py:
1681         (Printer._print_test_trace):
1682         (Printer._print_baseline):
1683
1684 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1685
1686         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1687         https://bugs.webkit.org/show_bug.cgi?id=79849
1688
1689         Reviewed by Beth Dakin.
1690
1691         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1692         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1693
1694 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1695
1696         Removed unused Apple buildslaves from the master configuration
1697         https://bugs.webkit.org/show_bug.cgi?id=79925
1698
1699         Reviewed by Stephanie Lewis.
1700
1701         * BuildSlaveSupport/build.webkit.org-config/config.json:
1702
1703 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1704
1705         nrwt: implement simple 'virtual test suite' support
1706         https://bugs.webkit.org/show_bug.cgi?id=79737
1707
1708         Reviewed by Adam Barth.
1709
1710         Add very basic support for 'virtual test suites' to NRWT:
1711         a virtual suite is a directory that may contain new baselines,
1712         contains a pointer to a "base" directory of tests, and an
1713         optional list of command line arguments to pass to DRT;
1714         it gives us a way to run all of the tests in a given directory
1715         multiple times with multiple (potentially differing) sets of
1716         results and baselines.
1717
1718         This patch implements the support needed for this feature, and
1719         some basic tests, but no actual port will use the feature yet.
1720
1721         This is probably the simplest implementation possible - the
1722         list of virtual suites will be hard-coded into the port's
1723         implementation. One can imagine a more data-driven approach
1724         where the suite instructions are stored in a manifest file
1725         either in LayoutTests (all suites in one file), or per-port,
1726         or per-directory. If this feature ends up being useful we
1727         should probably add something like that so people don't have
1728         to hunt around in the code to add suites.
1729
1730         * Scripts/webkitpy/layout_tests/port/base.py:
1731         (Port.__init__):
1732         (Port.expected_filename):
1733         (Port.tests):
1734         (Port):
1735         (Port._real_tests):
1736         (Port._driver_class):
1737         (Port.virtual_test_suites):
1738         (Port.virtual_suite):
1739         (Port.virtual_suite.VirtualTestSuite):
1740         (Port.virtual_suite.VirtualTestSuite.__init__):
1741         (Port.virtual_suite.VirtualTestSuite.__repr__):
1742         (Port.populated_virtual_test_suites):
1743         (Port._virtual_tests):
1744         (Port.lookup_virtual_test_base):
1745         (Port.lookup_virtual_test_args):
1746         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1747         (PortTest.test_find_with_skipped_directories):
1748         * Scripts/webkitpy/layout_tests/port/driver.py:
1749         (DriverInput.__init__):
1750         (DriverProxy.run_test):
1751         * Scripts/webkitpy/layout_tests/port/test.py:
1752         (TestPort.virtual_test_suites):
1753         (TestDriver.run_test):
1754         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1755         (MainTest.test_all):
1756         (MainTest.test_virtual):
1757
1758 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1759
1760         nrwt: support more than two drivers in DriverProxy
1761         https://bugs.webkit.org/show_bug.cgi?id=79736
1762
1763         Reviewed by Adam Barth.
1764
1765         Now that we can support per-test command lines for
1766         Drivers, modify DriverProxy to keep a map of running
1767         drivers for each needed command-line; this will allow
1768         us to transparently maintain a pool of appropriately
1769         configured DRTs without having to constantly start and stop
1770         them.
1771
1772         Note that this potentially raises a garbage collection
1773         problem - the number of running DRTs will grow with the
1774         number of different sets of command line args. For now
1775         this is no worse than the current code - if you're running
1776         with pixel tests, you will only need one DRT per worker,
1777         and if you aren't, you'll need two (one for text-only tests,
1778         and one for reftests).
1779
1780         An alternative would be to only ever have one running driver,
1781         and restart the driver as the command line changes, but this
1782         might (?) slow down execution in the text-only case - we
1783         should benchmark this because it would be simpler and possibly
1784         allow us to eliminate DriverProxy altogether.
1785
1786         * Scripts/webkitpy/layout_tests/port/driver.py:
1787         (DriverProxy.__init__):
1788         (DriverProxy):
1789         (DriverProxy._make_driver):
1790         (DriverProxy.run_test):
1791         (DriverProxy.has_crashed):
1792         (DriverProxy.stop):
1793         (DriverProxy.cmd_line):
1794         (DriverProxy._cmd_line_as_key):
1795
1796 2012-02-29  Adrienne Walker  <enne@google.com>
1797
1798         Unreviewed, add myself as a reviewer
1799
1800         * Scripts/webkitpy/common/config/committers.py:
1801
1802 2012-02-29  Greg Billock  <gbillock@google.com>
1803
1804         Add more tests for web intents
1805         https://bugs.webkit.org/show_bug.cgi?id=79527
1806
1807         Reviewed by Adam Barth.
1808
1809         * DumpRenderTree/chromium/LayoutTestController.cpp:
1810         (LayoutTestController::LayoutTestController):
1811         (LayoutTestController::sendWebIntentResponse):
1812         * DumpRenderTree/chromium/LayoutTestController.h:
1813         (LayoutTestController):
1814         * DumpRenderTree/chromium/WebViewHost.h:
1815         (WebViewHost):
1816         (WebViewHost::currentIntentRequest):
1817
1818 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1819
1820         nrwt: port/Driver needs to support per-test command line args
1821         https://bugs.webkit.org/show_bug.cgi?id=79733
1822
1823         Reviewed by Adam Barth.
1824
1825         As part of removing the 'gpu' configurations and adding support
1826         for 'virtual test suites', the Driver classes need to support
1827         per-test command lines (since different tests will need to be
1828         run with different command line options).
1829
1830         The per-test args are not yet used, so this change should have
1831         no visible effects and need no additional testing.
1832
1833         * Scripts/webkitpy/layout_tests/port/base.py:
1834         (Port.driver_cmd_line):
1835         * Scripts/webkitpy/layout_tests/port/chromium.py:
1836         (ChromiumDriver.cmd_line):
1837         (ChromiumDriver._start):
1838         (ChromiumDriver.start):
1839         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1840         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
1841         (ChromiumDriverTest):
1842         (ChromiumDriverTest.test_two_drivers):
1843         * Scripts/webkitpy/layout_tests/port/driver.py:
1844         (Driver.cmd_line):
1845         (DriverProxy.__init__):
1846         (DriverProxy.start):
1847         (DriverProxy.cmd_line):
1848         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1849         (DriverTest.test_virtual_driver_methods):
1850         * Scripts/webkitpy/layout_tests/port/gtk.py:
1851         (GtkDriver.cmd_line):
1852         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1853         * Scripts/webkitpy/layout_tests/port/test.py:
1854         (TestPort._path_to_driver):
1855         (TestDriver.cmd_line):
1856         (TestDriver.start):
1857         * Scripts/webkitpy/layout_tests/port/webkit.py:
1858         (WebKitDriver.cmd_line):
1859         (WebKitDriver._start):
1860         (WebKitDriver.run_test):
1861         (WebKitDriver.start):
1862         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1863         (WebKitDriverTest.test_no_timeout):
1864         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1865         (PerfTestsRunner._run_tests_set):
1866         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1867         (test_run_test_pause_before_testing):
1868
1869 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1870
1871         perftestsrunner can call printer.write() after printer.cleanup()
1872         https://bugs.webkit.org/show_bug.cgi?id=79872
1873
1874         Reviewed by Ryosuke Niwa.
1875
1876         This patch fixes a unittest that was incorrectly calling
1877         PerfTestsRunner.run() twice (which led to a weird state in the
1878         printer object).
1879
1880         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1881         (MainTest.test_run_with_upload_json):
1882
1883 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
1884
1885         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1886         https://bugs.webkit.org/show_bug.cgi?id=76546
1887
1888         Reviewed by Simon Hausmann.
1889
1890         Revert the workaround introduced in r107868 and reintroduce
1891         the qml binding so we can test the code path that we are more
1892         interested in. The reason that it did not work before is that
1893         we don't have an active platform window which we now workaround
1894         by propagating the resize through QWindowSystemInterface.
1895
1896         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1897         (WTR::WrapperWindow::handleStatusChanged):
1898         (WTR::PlatformWebView::resizeTo):
1899
1900 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
1901
1902         [GTK] Small fix for cross compilation to not generate gtkdoc.
1903
1904         Rubber-stamped by Csaba Osztrogonác.
1905
1906         * Scripts/webkitdirs.pm:
1907         (isCrossCompilation):
1908
1909 2012-02-28  Lucas Forschler  <lforschler@apple.com>
1910
1911         Fix a typo in config.json
1912         linx -> linux
1913         
1914         * BuildSlaveSupport/build.webkit.org-config/config.json:
1915
1916 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1917
1918         [Qt] Allow read/write to the WebView.url property
1919         https://bugs.webkit.org/show_bug.cgi?id=77554
1920
1921         Reviewed by Tor Arne Vestbø.
1922
1923         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
1924
1925         * MiniBrowser/qt/qml/BrowserWindow.qml:
1926
1927 2012-02-28  Dan Winship  <danw@gnome.org>
1928
1929         [GTK] make tests explicitly request GSettingsBackendMemory
1930         https://bugs.webkit.org/show_bug.cgi?id=79788
1931
1932         Reviewed by Martin Robinson.
1933
1934         Explicitly request the fallback memory-based GSettings backend; if
1935         other backends are available then we don't want to use them,
1936         because they would make tests depend on the user's preferences.
1937         And if other backends aren't available, we don't need glib to
1938         print a warning about that fact.
1939
1940         * Scripts/webkitpy/layout_tests/port/gtk.py:
1941         (GtkPort.setup_environ_for_server):
1942
1943 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1944
1945         Unreviewed, rolling out r109110.
1946         http://trac.webkit.org/changeset/109110
1947         https://bugs.webkit.org/show_bug.cgi?id=79806
1948
1949         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
1950         (Requested by aroben on #webkit).
1951
1952         * Scripts/webkitpy/common/checkout/changelog.py:
1953         (parse_bug_id):
1954         (parse_bug_id_from_changelog):
1955         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1956         * Scripts/webkitpy/common/config/urls.py:
1957
1958 2012-02-28  Adam Roben  <aroben@webkit.org>
1959
1960         Add my new email address
1961
1962         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
1963
1964         Reviewed by Anders Carlsson.
1965
1966         * Scripts/webkitpy/common/config/committers.py:
1967
1968 2012-02-28  Adam Roben  <aroben@apple.com>
1969
1970         Teach webkitpy about wkb.ug URLs
1971
1972         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
1973         use wkb.ug URLs
1974
1975         Reviewed by Anders Carlsson.
1976
1977         * Scripts/webkitpy/common/checkout/changelog.py:
1978         (parse_bug_id):
1979         (parse_bug_id_from_changelog):
1980         Fall back to the tiny URL format if neither the short nor long URL formats work.
1981
1982         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1983         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
1984
1985         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
1986         wkb.ug URLs.
1987
1988 2012-02-28  János Badics  <dicska@gmail.com>
1989
1990         [Qt] build-webkit does not detect the number of CPUs
1991         https://bugs.webkit.org/show_bug.cgi?id=76445
1992
1993         Based on Seo Sanghyeon's work (modification:
1994         Automatically determine the number of CPUs for make
1995         only if -j make argument haven't already been specified.)
1996
1997         Reviewed by Csaba Osztrogonác.
1998
1999         * Scripts/webkitdirs.pm:
2000         (buildQMakeProjects):
2001
2002 2012-02-28  Kent Tamura  <tkent@chromium.org>
2003
2004         Update a pattern for forms files of watchlist
2005         https://bugs.webkit.org/show_bug.cgi?id=79767
2006
2007         Reviewed by Kentaro Hara.
2008
2009         * Scripts/webkitpy/common/config/watchlist:
2010         Catches the following files with the "Forms" pattern.
2011         - HTMLDatListElement.*
2012         - HTMLKeygenElement.*
2013         - HTMLLegendElement.*
2014         - HTMLOutputElement.*
2015         - FormAssociatedElement.*
2016         - SliderThumbElement.*
2017         - TextControlInnerElements.*
2018         - RenderFileUploadControl.*
2019
2020 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2021
2022         Unreviewed, rolling out r109041.
2023         http://trac.webkit.org/changeset/109041
2024         https://bugs.webkit.org/show_bug.cgi?id=79741
2025
2026         Broke Chromium Win build (Requested by bashi on #webkit).
2027
2028         * DumpRenderTree/chromium/LayoutTestController.cpp:
2029         (LayoutTestController::LayoutTestController):
2030         * DumpRenderTree/chromium/LayoutTestController.h:
2031         (LayoutTestController):
2032         * DumpRenderTree/chromium/WebViewHost.h:
2033
2034 2012-02-27  James Robinson  <jamesr@chromium.org>
2035
2036         [chromium] Remove media tests from ChromiumGpu configurations
2037         https://bugs.webkit.org/show_bug.cgi?id=79720
2038
2039         Reviewed by Adam Barth.
2040
2041         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
2042         composited playback path via tests in the compositing/ directory.
2043
2044         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2045         (_default_tests_paths):
2046         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2047         (ChromiumGpuTest.test_default_tests_paths):
2048         (ChromiumGpuTest.test_test_files):
2049
2050 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
2051
2052         nrwt: log multiline stderr/crash output properly
2053         https://bugs.webkit.org/show_bug.cgi?id=79722
2054
2055         Reviewed by Adam Barth.
2056
2057         This cleans up some nits in the log output to make things
2058         slightly easier to read (every line gets timestamped, etc.).
2059
2060         Also tweaks the log message for pixel hash mismatches.
2061
2062         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2063         (SingleTestRunner._handle_error):
2064         (SingleTestRunner._compare_image):
2065
2066 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2067
2068         Touch the master.cfg to force a reconfig.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2071         (BuildAndTestLeaksFactory):
2072         (NewBuildAndTestFactory):
2073
2074 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
2075
2076         [BlackBerry] Upstream BlackBerry API web page related files
2077         https://bugs.webkit.org/show_bug.cgi?id=74380
2078
2079         Reviewed by Antonio Gomes.
2080
2081         Adapt to the removing of WebPage::mainFrame(), use
2082         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
2083
2084         No new tests as this patch doesn't change behavior.
2085
2086         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2087         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2088         (BlackBerry::WebKit::DumpRenderTree::runTests):
2089
2090 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2091
2092         Add Windows and Linux Chromium perf bots
2093         https://bugs.webkit.org/show_bug.cgi?id=79418
2094
2095         Reviewed by Tony Chang.
2096
2097         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
2098         the dedicated perf bot slave (uses the same hardware).
2099
2100         * BuildSlaveSupport/build.webkit.org-config/config.json:
2101
2102 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2103
2104         Undefined variable 'current' when running chromium_android.py
2105         https://bugs.webkit.org/show_bug.cgi?id=79696
2106
2107         Reviewed by Adam Barth.
2108
2109         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2110         (ChromiumAndroidDriver._read_prompt):
2111
2112 2012-02-27  Greg Billock  <gbillock@google.com>
2113
2114         Add more tests for web intents
2115         https://bugs.webkit.org/show_bug.cgi?id=79527
2116
2117         Reviewed by Adam Barth.
2118
2119         * DumpRenderTree/chromium/LayoutTestController.cpp:
2120         (LayoutTestController::LayoutTestController):
2121         (LayoutTestController::sendWebIntentResponse):
2122         * DumpRenderTree/chromium/LayoutTestController.h:
2123         (LayoutTestController):
2124         * DumpRenderTree/chromium/WebViewHost.h:
2125         (WebViewHost):
2126         (WebViewHost::currentIntentRequest):
2127
2128 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2129
2130         Chromium-Android layout test script: the adb shell prompt is not always '# '
2131         https://bugs.webkit.org/show_bug.cgi?id=79506
2132
2133         Reviewed by Adam Barth.
2134
2135         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2136         (ChromiumAndroidDriver._start):
2137         (ChromiumAndroidDriver._read_prompt):
2138
2139 2012-02-27  Dan Bernstein  <mitz@apple.com>
2140
2141         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
2142         https://bugs.webkit.org/show_bug.cgi?id=79607
2143
2144         Reviewed by Adele Peterson.
2145
2146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2147         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
2148         (TestWebKitAPI::AcceptsFirstMouse::url):
2149         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
2150         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2151         (TestWebKitAPI::TEST_F):
2152         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
2153
2154 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2155
2156         Unreviewed. Fix make distcheck.
2157
2158         * GNUmakefile.am: Fix typo.
2159
2160 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2161
2162         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
2163
2164         Reviewed by Kenneth Rohde Christiansen..
2165
2166         * qmake/mkspecs/features/features.prf:
2167
2168 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
2169
2170         Add a ChromiumGpuAndroid port.
2171         https://bugs.webkit.org/show_bug.cgi?id=79628
2172
2173         Reviewed by Adam Barth.
2174
2175         Android does have a gpu port, so revert r107697.
2176
2177         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2178         (ChromiumAndroidPort.__init__):
2179         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2180         (ChromiumGpuAndroidPort):
2181         (ChromiumGpuAndroidPort.__init__):
2182         (ChromiumGpuAndroidPort.baseline_search_path):
2183         (ChromiumGpuAndroidPort.default_child_processes):
2184         (ChromiumGpuAndroidPort.tests):
2185         * Scripts/webkitpy/layout_tests/port/factory.py:
2186         (PortFactory):
2187
2188 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2189
2190         Change Build bot with BuildAndTest bot for EFL port.
2191         https://bugs.webkit.org/show_bug.cgi?id=77518
2192
2193         Reviewed by Ryosuke Niwa.
2194
2195         EFL build bot starts to support layout test.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/config.json:
2198         * BuildSlaveSupport/built-product-archive:
2199         (archiveBuiltProduct):
2200         (extractBuiltProduct):
2201         * BuildSlaveSupport/test-result-archive:
2202         (archiveTestResults):
2203         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
2204         (generateBuildSystemFromCMakeProject):
2205
2206 2012-02-24  Darin Fisher  <darin@chromium.org>
2207
2208         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
2209
2210         Reviewed by James Robinson.
2211
2212         * Scripts/webkitpy/common/config/watchlist:
2213
2214 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2215
2216         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
2217         https://bugs.webkit.org/show_bug.cgi?id=79258
2218
2219         Reviewed by Ryosuke Niwa.
2220
2221         Split the fuzzy matching into separate functions so that they
2222         can be sharded and run in parallel.
2223
2224         Also, fix a bug in the svn_blame_regexp that was causing us
2225         to require ChangeLog lines to have at least one space after the
2226         author, making the code require trailing whitespace in the
2227         changelog in some places (this was making my life harder because
2228         I have my text editor set to strip trailing whitespace in python
2229         files, and that was causing test_parse_log_entries_from_changelog() to fail
2230         when the whitespace on line 275 was removed).
2231
2232         * Scripts/webkitpy/common/checkout/changelog.py:
2233         (ChangeLog):
2234         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2235         (test_fuzzy_reviewer_match__none):
2236         (test_fuzzy_reviewer_match_adam_barth):
2237         (test_fuzzy_reviewer_match_darin_adler_et_al):
2238         (test_fuzzy_reviewer_match_dimitri_glazkov):
2239         (test_fuzzy_reviewer_match_george_staikos):
2240         (test_fuzzy_reviewer_match_mark_rowe):
2241
2242 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2243
2244         webkitpy: committers_unittest fuzzy matching is really slow
2245         https://bugs.webkit.org/show_bug.cgi?id=79179
2246
2247         Reviewed by Ryosuke Niwa.
2248
2249         Break the fuzzy matching tests into individual routines for
2250         each contributor so that the intent is a little clearer, so
2251         that it's easier to test individual names (and identify
2252         duplicate tests), and so that we can eventually run
2253         them in parallel.
2254
2255         Also, mark most of them as 'integration' tests so that they
2256         can be skipped if we want to go fast (we leave a few as
2257         regular tests for functional coverage).
2258
2259         * Scripts/webkitpy/common/config/committers_unittest.py:
2260         (CommittersTest):
2261         (CommittersTest.test_contributors_by_fuzzy_match):
2262         (CommittersTest.integration_test_contributors__none):
2263         (CommittersTest.integration_test_contributors__none_2):
2264         (CommittersTest.integration_test_contributors__none_3):
2265         (CommittersTest.integration_test_contributors_ada_chan):
2266         (CommittersTest.integration_test_contributors_adele_peterson):
2267         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
2268         (CommittersTest.integration_test_contributors_alice_liu):
2269         (CommittersTest.integration_test_contributors_alp_toker):
2270         (CommittersTest.integration_test_contributors_anders_carlsson):
2271         (CommittersTest.integration_test_contributors_antti_koivisto):
2272         (CommittersTest.integration_test_contributors_beth_dakin):
2273         (CommittersTest.integration_test_contributors_brady_eidson):
2274         (CommittersTest.integration_test_contributors_cameron_zwarich):
2275         (CommittersTest.integration_test_contributors_chris_blumenberg):
2276         (CommittersTest.integration_test_contributors_dan_bernstein):
2277         (CommittersTest.integration_test_contributors_dan_bernstein_2):
2278         (CommittersTest.integration_test_contributors_darin_adler):
2279         (CommittersTest.integration_test_contributors_david_harrison):
2280         (CommittersTest.integration_test_contributors_david_harrison_2):
2281         (CommittersTest.integration_test_contributors_david_hyatt):
2282         (CommittersTest.integration_test_contributors_david_kilzer):
2283         (CommittersTest.integration_test_contributors_don_melton):
2284         (CommittersTest.integration_test_contributors_eric_seidel):
2285         (CommittersTest.integration_test_contributors_geoffrey_garen):
2286         (CommittersTest.integration_test_contributors_greg_bolsinga):
2287         (CommittersTest.integration_test_contributors_holger_freyther):
2288         (CommittersTest.integration_test_contributors_jon_sullivan):
2289         (CommittersTest.integration_test_contributors_jon_honeycutt):
2290         (CommittersTest.integration_test_contributors_joseph_pecoraro):
2291         (CommittersTest.integration_test_contributors_ken_kocienda):
2292         (CommittersTest.integration_test_contributors_kenneth_russell):
2293         (CommittersTest.integration_test_contributors_kevin_decker):
2294         (CommittersTest.integration_test_contributors_kevin_mccullough):
2295         (CommittersTest.integration_test_contributors_lars_knoll):
2296         (CommittersTest.integration_test_contributors_lars_weintraub):
2297         (CommittersTest.integration_test_contributors_maciej_stachowiak):
2298         (CommittersTest.integration_test_contributors_mark_rowe):
2299         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
2300         (CommittersTest.integration_test_contributors_oliver_hunt):
2301         (CommittersTest.integration_test_contributors_rniwa):
2302         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
2303         (CommittersTest.integration_test_contributors_steve_falkenburg):
2304         (CommittersTest.integration_test_contributors_sam_weinig):
2305         (CommittersTest.integration_test_contributors_tim_omernick):
2306         (CommittersTest.integration_test_contributors_timothy_hatcher):
2307         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
2308         (CommittersTest.integration_test_contributors_vicki_murley):
2309         (CommittersTest.integration_test_contributors_zack_rusin):
2310
2311 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2312
2313         webkitpy: should autoinstall coverage
2314         https://bugs.webkit.org/show_bug.cgi?id=79535
2315
2316         Reviewed by Eric Seidel.
2317
2318         We should automatically print the coverage report after the run, too.
2319
2320         * Scripts/webkitpy/test/main.py:
2321         (Tester._run_tests):
2322         * Scripts/webkitpy/thirdparty/__init__.py:
2323         (AutoinstallImportHook.find_module):
2324         (AutoinstallImportHook._install_coverage):
2325
2326 2012-02-24  Pablo Flouret  <pablof@motorola.com>
2327
2328         Fix copypasta in build-webkit's --vibration option description
2329         https://bugs.webkit.org/show_bug.cgi?id=79528
2330
2331         Reviewed by Andreas Kling.
2332
2333         * Scripts/build-webkit:
2334
2335 2012-02-24  Antonio Gomes  <agomes@rim.com>
2336
2337         Adding myself to ScrollingCoordinator watchlist
2338         https://bugs.webkit.org/show_bug.cgi?id=79525
2339
2340         Reviewed by Rob Buis.
2341
2342         * Scripts/webkitpy/common/config/watchlist:
2343
2344 2012-02-24  Darin Fisher  <darin@chromium.org>
2345
2346         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
2347
2348         Reviewed by Adam Barth.
2349
2350         * Scripts/webkitpy/common/config/watchlist:
2351
2352 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2353
2354         webkitpy: config_unittest is sensitive to other tests that might've already run
2355         https://bugs.webkit.org/show_bug.cgi?id=79382
2356
2357         Reviewed by Adam Barth.
2358
2359         If another test runs prior to config_unittest and pokes the
2360         cached configuration, the first test in config_unittest might
2361         fail; the tearDown() will then allow subsequent tests to pass.
2362         Clearing the configuration prior to each test makes things
2363         slightly slower but safer.
2364
2365         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2366         (ConfigTest.setUp):
2367
2368 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2369
2370         Use xcrun to find compiler paths for Generate Derived Sources build phase script
2371         <http://webkit.org/b/79512>
2372
2373         Reviewed by Dan Bernstein.
2374
2375         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2376         (Generate Derived Sources): Use xcrun to find the path to the
2377         compiler since that works on both iOS and OS X.
2378
2379 2012-02-24  James Robinson  <jamesr@chromium.org>
2380
2381         Create a watchlist for ScrollingCoordinator changes
2382         https://bugs.webkit.org/show_bug.cgi?id=79511
2383
2384         Reviewed by Anders Carlsson.
2385
2386         * Scripts/webkitpy/common/config/watchlist:
2387
2388 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2389
2390         [EFL][DRT] Implement setValueForUser and setAutofilled.
2391         https://bugs.webkit.org/show_bug.cgi?id=79237
2392
2393         Reviewed by Andreas Kling.
2394
2395         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2396         Those implementations are related with input fields and allow to pass following tests:
2397         fast/forms/onchange-setvalueforuser.html
2398         fast/forms/input-autofilled.html
2399         fast/forms/reset-autofilled.html
2400
2401         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2402         (LayoutTestController::setValueForUser):
2403         (LayoutTestController::setAutofilled):
2404
2405 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2406
2407         [Qt] Allow to use WebCore imagedecoders
2408         https://bugs.webkit.org/show_bug.cgi?id=32410
2409
2410         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2411
2412         Reviewed by Simon Hausmann.
2413
2414         * qmake/mkspecs/features/features.prf:
2415
2416 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2417
2418         [Qt] Add Qt5 way to force 96 DPI for tests
2419         https://bugs.webkit.org/show_bug.cgi?id=79364
2420
2421         Reviewed by Simon Hausmann.
2422
2423         * DumpRenderTree/qt/main.cpp:
2424         (main):
2425         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2426         (WTR::activateFonts):
2427
2428 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2429
2430         [GTK] MiniBrowser should reload the view then the reload button is clicked
2431         https://bugs.webkit.org/show_bug.cgi?id=79472
2432
2433         Reviewed by Philippe Normand.
2434
2435         * MiniBrowser/gtk/BrowserWindow.c:
2436         (reloadCallback): Call webkit_web_view_reload().
2437         (browser_window_init): Connect reload item clicked even to
2438         reloadCallback instead of activateUriEntryCallback.
2439
2440 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2441
2442         Add performance tests for DOM attribute getters and setters
2443         https://bugs.webkit.org/show_bug.cgi?id=79208
2444
2445         Reviewed by Ryosuke Niwa.
2446
2447         We want to allow perf tests to output info messages
2448         that do not affect the test results. To accomplish this,
2449         this patch modifies perftestsrunner.py so that it ignores
2450         a line that starts from "Info:".
2451
2452         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2453         (PerfTestsRunner):
2454
2455 2012-02-24  Andrew Lo  <anlo@rim.com>
2456
2457         [BlackBerry] Enable requestAnimationFrame
2458         https://bugs.webkit.org/show_bug.cgi?id=79408
2459
2460         Enable requestAnimationFrame for BlackBerry.
2461
2462         Reviewed by Rob Buis.
2463
2464         * Scripts/build-webkit:
2465
2466 2012-02-24  Adam Barth  <abarth@webkit.org>
2467
2468         style-queue tries to apply the patch twice
2469         https://bugs.webkit.org/show_bug.cgi?id=79459
2470
2471         Reviewed by Eric Seidel.
2472
2473         Previously, we applied the patch using both apply-patch and
2474         check-style.  This patch introduces a check-style-local to mirror the
2475         apply-watchlist-local, which operates on the current working diff.
2476
2477         This patch also cleans up some other bugs I found by running the queue
2478         locally for a while.  The queue still prints out a slightly
2479         less-than-ideal message on the bugs when it find an error, but it's ok
2480         for now.  We'll need to iterate a bit.
2481
2482         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2483         (StyleQueueTask.validate):
2484         (StyleQueueTask._check_style):
2485         * Scripts/webkitpy/tool/commands/download.py:
2486         (CheckStyleLocal):
2487         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2488         (EarlyWarningSytemTest._default_expected_stderr):
2489         (EarlyWarningSytemTest._test_testing_ews):
2490         * Scripts/webkitpy/tool/commands/queues.py:
2491         (AbstractReviewQueue.handle_script_error):
2492         (StyleQueue.review_patch):
2493         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2494         * Scripts/webkitpy/tool/commands/queuestest.py:
2495         (QueuesTest.assert_queue_outputs):
2496
2497 2012-02-23  Adam Barth  <abarth@webkit.org>
2498
2499         should_proceed_with_work_item is unused and can be removed
2500         https://bugs.webkit.org/show_bug.cgi?id=79416
2501
2502         Reviewed by Eric Seidel.
2503
2504         We used to use this function to check whether the tree is red.  Now, we
2505         don't use external measures of whether to proceed with work items.
2506         Instead, we analyze them with the idea in mind that the tree might be
2507         red.
2508
2509         * Scripts/webkitpy/tool/bot/queueengine.py:
2510         (QueueEngineDelegate.next_work_item):
2511         (QueueEngine.run):
2512         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2513         (LoggingDelegate):
2514         (LoggingDelegate.next_work_item):
2515         (RaisingDelegate.process_work_item):
2516         (QueueEngineTest.test_terminating_error):
2517         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2518         (AbstractEarlyWarningSystem.__init__):
2519         * Scripts/webkitpy/tool/commands/queues.py:
2520         (AbstractQueue.next_work_item):
2521         (FeederQueue.next_work_item):
2522         (CommitQueue.next_work_item):
2523         (AbstractReviewQueue.next_work_item):
2524         (StyleQueue.__init__):
2525         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2526         (FeederQueueTest.test_feeder_queue):
2527         (CommitQueueTest.test_commit_queue):
2528         (test_commit_queue_failure):
2529         (test_commit_queue_failure_with_failing_tests):
2530         (test_rollout):
2531         (test_rollout_lands):
2532         (StyleQueueTest.test_style_queue_with_style_exception):
2533         (test_style_queue_with_watch_list_exception):
2534         * Scripts/webkitpy/tool/commands/queuestest.py:
2535         (QueuesTest.assert_queue_outputs):
2536         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2537         (SheriffBot.next_work_item):
2538
2539 2012-02-23  Adrienne Walker  <enne@google.com>
2540
2541         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2542
2543         * Scripts/webkitpy/common/config/committers.py:
2544
2545 2012-02-23  Adam Barth  <abarth@webkit.org>
2546
2547         style-queue logs bogus messages to the QueueStatusServer
2548         https://bugs.webkit.org/show_bug.cgi?id=79424
2549
2550         Reviewed by Eric Seidel.
2551
2552         Copy/paste error.
2553
2554         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2555         (StyleQueueTask._check_style):
2556         (StyleQueueTask._apply_watch_list):
2557         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2558
2559 2012-02-23  Eric Seidel  <eric@webkit.org>
2560
2561         Use self._filesystem in more places in the SCM classes
2562         https://bugs.webkit.org/show_bug.cgi?id=79415
2563
2564         Reviewed by Adam Barth.
2565
2566         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2567         (SCMDetectorTest.test_detect_scm_system):
2568         * Scripts/webkitpy/common/checkout/scm/git.py:
2569         (Git.find_checkout_root):
2570         (Git.to_object_name):
2571         * Scripts/webkitpy/common/checkout/scm/scm.py:
2572         (SCM.__init__):
2573         (SCM.in_working_directory):
2574         * Scripts/webkitpy/common/checkout/scm/svn.py:
2575         (SVN.find_uuid):
2576         (SVN.find_checkout_root):
2577
2578 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2579
2580         Unreviewed, rolling out r108685.
2581         http://trac.webkit.org/changeset/108685
2582         https://bugs.webkit.org/show_bug.cgi?id=79414
2583
2584         Broke Chromium builds (Requested by enne on #webkit).
2585
2586         * qmake/mkspecs/features/features.prf:
2587
2588 2012-02-23  Adam Barth  <abarth@webkit.org>
2589
2590         style-queue shouldn't spam bugs if it fails to update its working copy
2591         https://bugs.webkit.org/show_bug.cgi?id=79412
2592
2593         Reviewed by Eric Seidel.
2594
2595         This patch moves style-queue over to the new PatchAnalysisTask
2596         infrastructure, which is smarter about retrying patches when update
2597         fails.
2598
2599         * Scripts/webkitpy/common/system/executive_mock.py:
2600         (MockExecutive.run_and_throw_if_fail):
2601         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2602         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2603         (UnableToApplyPatch):
2604         (UnableToApplyPatch.__init__):
2605         (PatchAnalysisTask.__init__):
2606         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2607         (StyleQueueTaskDelegate):
2608         (StyleQueueTaskDelegate.parent_command):
2609         (StyleQueueTask):
2610         (StyleQueueTask.validate):
2611         (StyleQueueTask._check_style):
2612         (StyleQueueTask._apply_watch_list):
2613         (StyleQueueTask.run):
2614         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2615         * Scripts/webkitpy/tool/commands/queues.py:
2616         (StyleQueue):
2617         (StyleQueue.should_proceed_with_work_item):
2618         (StyleQueue.review_patch):
2619         (StyleQueue.run_command):
2620         (StyleQueue.command_passed):
2621         (StyleQueue.command_failed):
2622         (StyleQueue.expected_failures):
2623         (StyleQueue.refetch_patch):
2624         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2625         (StyleQueueTest.test_style_queue_with_style_exception):
2626         (test_style_queue_with_watch_list_exception):
2627
2628 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2629
2630         [Qt] Allow to use WebCore imagedecoders
2631         https://bugs.webkit.org/show_bug.cgi?id=32410
2632
2633         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2634
2635         Reviewed by Simon Hausmann.
2636
2637         * qmake/mkspecs/features/features.prf:
2638
2639 2012-02-23  Eric Seidel  <eric@webkit.org>
2640
2641         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2642         https://bugs.webkit.org/show_bug.cgi?id=79405
2643
2644         Reviewed by Adam Barth.
2645
2646         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2647         (SCMDetectorTest):
2648         (SCMDetectorTest.test_find_checkout_root):
2649         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2650         (SVNTestRepository.tear_down):
2651
2652 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2653
2654         [Qt][WK2] Implement proxy authentication dialog.
2655         https://bugs.webkit.org/show_bug.cgi?id=79350
2656
2657         Reviewed by Simon Hausmann.
2658
2659         * MiniBrowser/qt/MiniBrowser.qrc:
2660         * MiniBrowser/qt/qml/BrowserWindow.qml:
2661         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2662
2663 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2664
2665         [wx] Build fix, add recently added source dirs.
2666
2667         * waf/build/settings.py:
2668
2669 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2670
2671         [Qt] Add support for touch cancellation
2672         https://bugs.webkit.org/show_bug.cgi?id=79348
2673
2674         Reviewed by Kenneth Rohde Christiansen.
2675
2676         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2677         and WK2 WTR.
2678
2679         * DumpRenderTree/qt/EventSenderQt.cpp:
2680         (EventSender::touchCancel):
2681         (EventSender::cancelTouchPoint):
2682         * DumpRenderTree/qt/EventSenderQt.h:
2683         (EventSender):
2684         * WebKitTestRunner/EventSenderProxy.h:
2685         (EventSenderProxy):
2686         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2687         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2688         (WTR::EventSendingController::touchCancel):
2689         (WTR):
2690         (WTR::EventSendingController::cancelTouchPoint):
2691         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2692         (EventSendingController):
2693         * WebKitTestRunner/TestController.cpp:
2694         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2695         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2696         (WTR::EventSenderProxy::touchCancel):
2697         (WTR):
2698         (WTR::EventSenderProxy::cancelTouchPoint):
2699
2700 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2701
2702         Unreviewed, rolling out r108626.
2703         http://trac.webkit.org/changeset/108626
2704         https://bugs.webkit.org/show_bug.cgi?id=79370
2705
2706         broke qt-wk2 bot, somehow the workaround does not work on the
2707         bot (Requested by Ossy on #webkit).
2708
2709         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2710         (WTR::WrapperWindow::handleStatusChanged):
2711         (WTR::PlatformWebView::resizeTo):
2712
2713 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2714
2715         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2716         https://bugs.webkit.org/show_bug.cgi?id=78481
2717
2718         Reviewed by Gustavo Noronha Silva.
2719
2720         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2721         to create gdk press key event.
2722         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2723         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2724
2725         * DumpRenderTree/gtk/EventSender.cpp:
2726         (scheduleAsynchronousClickCallback):
2727         (createKeyPressEvent):
2728         (sendKeyDown):
2729         (keyDownCallback):
2730         (sendAsynchronousKeyDown):
2731         (scheduleAsynchronousKeyDownCallback):
2732
2733 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2734
2735         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2736         https://bugs.webkit.org/show_bug.cgi?id=76546
2737
2738         Reviewed by Simon Hausmann.
2739
2740         Co-authored with Simon Hausmann.
2741
2742         Revert the workaround introduced in r107868 and reintroduce
2743         the qml binding so we can test the code path that we are more
2744         interested in. The reason that it did not work before is that
2745         we don't have an active platform window which we now workaround
2746         by propagating the resize through QWindowSystemInterface.
2747
2748         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2749         (WTR::WrapperWindow::handleStatusChanged):
2750         (WTR::PlatformWebView::resizeTo):
2751
2752 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2753
2754         Unreviewed, rolling out r108577.
2755         http://trac.webkit.org/changeset/108577
2756         https://bugs.webkit.org/show_bug.cgi?id=79359
2757
2758         It doesn't work as expected (Requested by Ossy on #webkit).
2759
2760         * DumpRenderTree/qt/EventSenderQt.cpp:
2761         (EventSender::postEvent):
2762         * DumpRenderTree/qt/EventSenderQt.h:
2763         (EventSender):
2764
2765 2012-02-23  Philippe Normand  <pnormand@igalia.com>
2766
2767         [GTK] FullScreen signals
2768         https://bugs.webkit.org/show_bug.cgi?id=76181
2769
2770         Reviewed by Martin Robinson.
2771
2772         Use the two new entering/leaving fullscreen signals to hide/show
2773         the tool bar, the status bar and ask the user's permission before
2774         entering fullscreen.
2775
2776         * GtkLauncher/main.c:
2777         (webViewFullscreenMessageWindowClose):
2778         (webViewWindowStateEvent):
2779         (hide_widget):
2780         (show_widget):
2781         (webViewEnteringFullScreen):
2782         (webViewLeavingFullScreen):
2783         (createBrowser):
2784         (createWindow):
2785
2786 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
2787
2788         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
2789         https://bugs.webkit.org/show_bug.cgi?id=79076
2790
2791         Reviewed by Andreas Kling.
2792
2793         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
2794         (builtDylibPathForName):
2795
2796 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2797
2798         [Qt] Add eventSender.gestureTap
2799         https://bugs.webkit.org/show_bug.cgi?id=66173
2800
2801         Reviewed by Kenneth Rohde Christiansen.
2802
2803         * DumpRenderTree/qt/EventSenderQt.cpp:
2804         (EventSender::gestureTap):
2805         * DumpRenderTree/qt/EventSenderQt.h:
2806
2807 2012-02-22  Brady Eidson  <beidson@apple.com>
2808
2809         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
2810         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
2811
2812         Reviewed by Anders Carlsson.
2813
2814         Update our tools to the new form of the PageLoadClient.
2815
2816         * MiniBrowser/mac/BrowserWindowController.m:
2817         (-[BrowserWindowController awakeFromNib]): 
2818
2819         * WebKitTestRunner/TestController.cpp:
2820         (WTR::TestController::initialize):
2821
2822 2012-02-22  Daniel Bates  <dbates@webkit.org>
2823
2824         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
2825         https://bugs.webkit.org/show_bug.cgi?id=79277
2826
2827         Reviewed by Adam Barth.
2828
2829         Pass command line argument no-saved-state to run-safari to disable Safari
2830         state restoration for the session on OS 10.7.
2831
2832         * Scripts/webkitpy/layout_tests/port/mac.py:
2833         (MacPort.show_results_html_file):
2834         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2835         (test_show_results_html_file):
2836
2837 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
2838
2839         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
2840         https://bugs.webkit.org/show_bug.cgi?id=77759
2841
2842         Reviewed by Tony Chang.
2843
2844         Fixes build with gcc 4.7.
2845
2846         r100432 added the include only for ANDROID; this changes the ifdef to
2847         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
2848         longer implicitly includes unistd.h from standard headers and other
2849         unix platforms are likely to get gcc 4.7 as well in the future.
2850
2851         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2852
2853 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2854
2855         Unreviewed, rolling out r108522.
2856         http://trac.webkit.org/changeset/108522
2857         https://bugs.webkit.org/show_bug.cgi?id=76181
2858
2859         Broke 4 fullscreen tests on GTK.
2860
2861         * GtkLauncher/main.c:
2862         (createBrowser):
2863         (createWindow):
2864
2865 2012-02-20  Philippe Normand  <pnormand@igalia.com>
2866
2867         [GTK] FullScreen signals
2868         https://bugs.webkit.org/show_bug.cgi?id=76181
2869
2870         Reviewed by Martin Robinson.
2871
2872         Use the two new entering/leaving fullscreen signals to hide/show
2873         the tool bar, the status bar and ask the user's permission before
2874         entering fullscreen.
2875
2876         * GtkLauncher/main.c:
2877         (webViewFullscreenMessageWindowClose):
2878         (webViewWindowStateEvent):
2879         (hide_widget):
2880         (show_widget):
2881         (webViewEnteringFullScreen):
2882         (webViewLeavingFullScreen):
2883         (createBrowser):
2884         (createWindow):
2885
2886 2012-02-22  Rob Flack  <flackr@chromium.org>
2887
2888         Update Linux ChromiumOS builders in flakiness dashboard.
2889         https://bugs.webkit.org/show_bug.cgi?id=79238
2890
2891         Reviewed by Ojan Vafai.
2892
2893         * TestResultServer/static-dashboards/builders.js:
2894
2895 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2896
2897         webkitpy: test_function_length_check_definition_huge_lines is slow
2898         https://bugs.webkit.org/show_bug.cgi?id=79185
2899
2900         Reviewed by Adam Barth.
2901
2902         This test takes ~3 seconds to run, apparently because we're
2903         running a test on a 10,000 line function :). Dropping the
2904         function length to 640 still exercises the code path and
2905         provides a 10x speedup.
2906
2907         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2908         (CppStyleTest):
2909         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
2910
2911 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2912
2913         webkitpy: speed up FileLockTest.test_lock_lifecycle
2914         https://bugs.webkit.org/show_bug.cgi?id=79189
2915
2916         Reviewed by Adam Barth.
2917
2918         The unit test had a second lock trying to acquire a
2919         lock already held, and a hard-coded timeout of one second.
2920         I have changed the timeouts to a tenth of a second (which
2921         is probably still fine) and changed the hard-spin on
2922         the lock to a slow-spin every hundredth of a second.
2923
2924         * Scripts/webkitpy/common/system/file_lock.py:
2925         (FileLock.acquire_lock):
2926         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2927         (FileLockTest.setUp):
2928         (FileLockTest.test_stuck_lock):
2929
2930 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
2931
2932         build-webkit should use environment variable at number of CPU
2933         detection on all platform
2934         https://bugs.webkit.org/show_bug.cgi?id=79227
2935
2936         Reviewed by Martin Robinson.
2937
2938         * Scripts/webkitdirs.pm:
2939         (determineNumberOfCPUs):
2940
2941 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
2942
2943         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
2944         https://bugs.webkit.org/show_bug.cgi?id=78960
2945
2946         Reviewed by Csaba Osztrogonác.
2947
2948         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2949         (LayoutTestController::overridePreference):
2950
2951 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
2952
2953         [chromium] Build WebKit with MEDIA_STREAM disabled.
2954         https://bugs.webkit.org/show_bug.cgi?id=79214
2955
2956         Reviewed by Kent Tamura.
2957
2958         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2959         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2960         * DumpRenderTree/chromium/WebViewHost.cpp:
2961         (WebViewHost::createMediaPlayer):
2962         * DumpRenderTree/chromium/WebViewHost.h:
2963         (WebViewHost):
2964
2965 2012-02-22  Zeno Albisser  <zeno@webkit.org>
2966
2967         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
2968         https://bugs.webkit.org/show_bug.cgi?id=79124
2969
2970         WebKitTestRunnerPrefix.h should also be included
2971         when building with clang.
2972
2973         Reviewed by Kenneth Rohde Christiansen.
2974
2975         * WebKitTestRunner/Target.pri:
2976
2977 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
2978
2979         <style scoped>: Add runtime-flag
2980         https://bugs.webkit.org/show_bug.cgi?id=79074
2981
2982         Enable the runtime-flag for DRT. 
2983
2984         Reviewed by Dimitri Glazkov.
2985
2986         * DumpRenderTree/chromium/TestShell.cpp:
2987         (TestShell::TestShell):
2988
2989 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2990
2991         Unreviewed, rolling out r107351.
2992         http://trac.webkit.org/changeset/107351
2993         https://bugs.webkit.org/show_bug.cgi?id=53600
2994
2995         Several issues introduced in WebKitGTK+ API
2996
2997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2998         (createWebView):
2999         * GtkLauncher/main.c:
3000         (createWebViewCb):
3001         (createBrowser):
3002         (createWindow):
3003         (main):
3004
3005 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
3006
3007         JSC should be a triple-tier VM
3008         https://bugs.webkit.org/show_bug.cgi?id=75812
3009         <rdar://problem/10079694>
3010
3011         Reviewed by Gavin Barraclough.
3012
3013         Changed EFL's build system to include a new directory in JavaScriptCore.
3014
3015         * DumpRenderTree/efl/CMakeLists.txt:
3016
3017 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
3018
3019         [chromium] Fix image drag out on Chromium
3020         https://bugs.webkit.org/show_bug.cgi?id=79158
3021
3022         Reviewed by Tony Chang.
3023
3024         * DumpRenderTree/chromium/EventSender.cpp:
3025         (EventSender::dumpFilenameBeingDragged):
3026         (EventSender::beginDragWithFiles):
3027         * DumpRenderTree/chromium/WebViewHost.cpp:
3028         (addDRTFakeFileToDataObject):
3029
3030 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3031
3032         webkitpy: speed up hot filesystem_mock functions
3033         https://bugs.webkit.org/show_bug.cgi?id=79159
3034
3035         Reviewed by Adam Barth.
3036
3037         Profiling run_webkit_tests_integrationtest.py revealed that
3038         isdir(), normpath(), and join() are called a lot and were very
3039         slow.This patch speeds them up substantially, shaving 20 seconds
3040         off of the execution time.
3041
3042         * Scripts/webkitpy/common/system/filesystem_mock.py:
3043         (MockFileSystem.isdir):
3044         (MockFileSystem._slow_but_correct_join):
3045         (MockFileSystem.join):
3046         (MockFileSystem.listdir):
3047         (MockFileSystem._slow_but_correct_normpath):
3048         (MockFileSystem.normpath):
3049         (MockFileSystem.write_binary_file):
3050         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3051         (MockFileSystemTest.quick_check):
3052         (MockFileSystemTest):
3053         (MockFileSystemTest.test_join):
3054         (MockFileSystemTest.test_normpath):
3055         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3056         (get_test_config): Call write_binary_file() instead of updating
3057           filesystem.files directly, so that we create directories as
3058           needed.
3059
3060 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3061
3062         nrwt: make the delay between starting workers configurable per-port
3063         https://bugs.webkit.org/show_bug.cgi?id=79148
3064
3065         Reviewed by Eric Seidel.
3066
3067         Because of bug 79147, we have to sleep a bit in between starting
3068         DRTs; however, doing so across the board slows down the Test
3069         port. Making this configurable shaves 10 seconds off of
3070         run_webkit_tests_integrationtest.py
3071         
3072         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3073         (Manager._run_tests):
3074         * Scripts/webkitpy/layout_tests/port/base.py:
3075         (Port.worker_startup_delay_secs):
3076         * Scripts/webkitpy/layout_tests/port/test.py:
3077         (TestPort.worker_startup_delay_secs):
3078
3079 2012-02-21  Jon Lee  <jonlee@apple.com>
3080
3081         Bring notifications support to WK1 mac
3082         https://bugs.webkit.org/show_bug.cgi?id=78783
3083         <rdar://problem/10610578>
3084
3085         Reviewed by Anders Carlsson.
3086
3087         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
3088         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3089         (-[UIDelegate timerFired]):
3090
3091 2012-02-21  Kentaro Hara  <haraken@chromium.org>
3092
3093         Enable the IDL attribute checker in run-bindings-tests
3094         https://bugs.webkit.org/show_bug.cgi?id=79091
3095
3096         Reviewed by Adam Barth.
3097
3098         We have enabled the IDL attribute checker in Chromium in r108322.
3099         This patch enables the IDL attribute checker in run-bindings-tests.
3100
3101         No tests. I manually checked that [Custommm], [CallWith=],
3102         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
3103         run-bindings-tests failures.
3104
3105         * Scripts/webkitpy/bindings/main.py:
3106         (BindingsTests.generate_supplemental_dependency):
3107
3108 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
3109
3110         Add rafaelw as a committer.
3111
3112         Unreviewed.
3113
3114         * Scripts/webkitpy/common/config/committers.py:
3115
3116 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3117
3118         webkitpy: update names after deleting message_broker
3119         https://bugs.webkit.org/show_bug.cgi?id=79000
3120
3121         Reviewed by Eric Seidel.
3122
3123         Part 3 of 3 in deleting message_broker.py; this change just
3124         adjusts the names for the newly merged symbols so that they are
3125         private as appropriate.
3126
3127         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3128         (get):
3129         (_Broker):
3130         (_BrokerConnection):
3131         (_BrokerConnection.__init__):
3132         (AbstractWorker.__init__):
3133         (_ManagerConnection):
3134         (_ManagerConnection.__init__):
3135         (_WorkerConnection):
3136         (_WorkerConnection.__init__):
3137
3138 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3139
3140         webkitpy: merge message_broker.py into manager_worker_broker.py
3141         https://bugs.webkit.org/show_bug.cgi?id=78999
3142
3143         Reviewed by Tony Chang.
3144
3145         This is pretty much a straight cut-and-paste of one file into
3146         another (broken up so that docstrings and imports are in the
3147         right place).
3148
3149         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3150         (BrokerClient):
3151         (BrokerClient.is_done):
3152         (BrokerClient.name):
3153         (Broker):
3154         (Broker.__init__):
3155         (Broker.add_topic):
3156         (Broker._get_queue_for_topic):
3157         (Broker.post_message):
3158         (Broker.run_message_loop):
3159         (Broker.run_all_pending):
3160         (Broker._run_loop):
3161         (Broker._dispatch_message):
3162         (_Message):
3163         (_Message.loads):
3164         (_Message.__init__):
3165         (_Message.dumps):
3166         (_Message.__repr__):
3167         (BrokerConnection):
3168         (BrokerConnection.__init__):
3169         (BrokerConnection.run_message_loop):
3170         (BrokerConnection.post_message):
3171         (BrokerConnection.raise_exception):
3172         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
3173
3174 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3175
3176         webkitpy: prepare to delete message_broker.py
3177         https://bugs.webkit.org/show_bug.cgi?id=78997
3178
3179         Reviewed by Eric Seidel.
3180
3181         This is part 1 of 3 changes to fix bug 78187. This change
3182         prepares the code for merging message_broker.py into
3183         manager_worker_broker.py; the tests in message_broker_unittest
3184         are merged into manager_worker_broker_unittest, the symbols
3185         needed by the tests are exported from manager_worker_broker.py,
3186         and manager_worker_broker itself is updated to refer to the
3187         symbols directly (without the module prefix).
3188
3189         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3190         (get):
3191         (AbstractWorker):
3192         (AbstractWorker.__init__):
3193         (_ManagerConnection):
3194         (_ManagerConnection.__init__):
3195         (_WorkerConnection):
3196         (_WorkerConnection.__init__):
3197         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3198         (InterfaceTest.test_brokerclient_is_abstract):
3199         (InterfaceTest.test_brokerclient_is_abstract.methods):
3200         (MessageTest):
3201         (MessageTest.test__no_body):
3202         (MessageTest.test__body):
3203         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
3204
3205 2012-02-21  Sam Weinig  <sam@webkit.org>
3206
3207         Attempt to fix the Snow Leopard build.
3208
3209         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3210         * MiniBrowser/Configurations/Base.xcconfig:
3211         * TestWebKitAPI/Configurations/Base.xcconfig:
3212         * WebKitTestRunner/Configurations/Base.xcconfig:
3213
3214 2012-02-21  Sam Weinig  <sam@webkit.org>
3215
3216         Use libc++ when building with Clang on Mac
3217         https://bugs.webkit.org/show_bug.cgi?id=78981
3218
3219         Reviewed by Dan Bernstein.
3220
3221         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3222         * MiniBrowser/Configurations/Base.xcconfig:
3223         * TestWebKitAPI/Configurations/Base.xcconfig:
3224         * WebKitTestRunner/Configurations/Base.xcconfig:
3225
3226 2012-02-21  Adam Roben  <aroben@apple.com>
3227
3228         Roll out r108309, r108323, and r108326
3229
3230         They broke the 32-bit Lion build.
3231
3232         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
3233
3234         * DumpRenderTree/efl/CMakeLists.txt:
3235
3236 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3237
3238         [Qt][WK2] Get rid of the dependency to QtWidgets
3239         https://bugs.webkit.org/show_bug.cgi?id=76276
3240
3241         Reviewed by Simon Hausmann.
3242
3243         * MiniBrowser/qt/MiniBrowser.pro:
3244         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3245         (MiniBrowserApplication::MiniBrowserApplication):
3246         (MiniBrowserApplication::notify):
3247         (MiniBrowserApplication::sendTouchEvent):
3248         * MiniBrowser/qt/MiniBrowserApplication.h:
3249         (MiniBrowserApplication):
3250         * QtTestBrowser/locationedit.h:
3251         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3252         (WTR::activateFonts):
3253         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3254
3255 2012-02-20  Adam Barth  <abarth@webkit.org>
3256
3257         mastercfg_unittest.py fails without simplejson
3258         https://bugs.webkit.org/show_bug.cgi?id=79070
3259
3260         Reviewed by Csaba Osztrogonác.
3261
3262         Now that we require Python 2.6 (and higher) we can import json rather
3263         than simplejson.  We still need to use the simplejson name because
3264         that's what the master.cfg script expects.
3265
3266         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3267         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3268
3269 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3270
3271         JSC should be a triple-tier VM
3272         https://bugs.webkit.org/show_bug.cgi?id=75812
3273         <rdar://problem/10079694>
3274
3275         Reviewed by Gavin Barraclough.
3276
3277         Changed EFL's build system to include a new directory in JavaScriptCore.
3278
3279         * DumpRenderTree/efl/CMakeLists.txt:
3280
3281 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
3282
3283         Update pywebsocket to 0.7.2
3284         https://bugs.webkit.org/show_bug.cgi?id=79066
3285
3286         This version includes vendor-prefixed deflate-frame extension support.
3287
3288         Reviewed by Kent Tamura.
3289
3290         * Scripts/webkitpy/thirdparty/__init__.py:
3291         (AutoinstallImportHook._install_pywebsocket):
3292
3293 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3294
3295         [UNIX] Plugin information fields are not interpreted as UTF-8
3296         https://bugs.webkit.org/show_bug.cgi?id=78635
3297
3298         Reviewed by Gustavo Noronha Silva.
3299
3300         Interpret plugin metadata as UTF8 aways. This matches the behavior
3301         of Chromium and the Totem plugin.
3302
3303         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3304         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
3305
3306 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3307
3308         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
3309         https://bugs.webkit.org/show_bug.cgi?id=78935
3310
3311         Reviewed by Gustavo Noronha Silva.
3312
3313         Move the TestNetscapePlugin headers to a more appropriate directory and update
3314         the build files to match.
3315
3316         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
3317         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
3318         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
3319         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
3320         * GNUmakefile.am: Ditto.
3321
3322 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
3323
3324         Add a new API for the Vibration API(W3C).
3325         https://bugs.webkit.org/show_bug.cgi?id=72010
3326
3327         Reviewed by Hajime Morita.
3328
3329         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
3330
3331 2012-02-20  János Badics  <dicska@gmail.com>
3332
3333         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
3334         https://bugs.webkit.org/show_bug.cgi?id=71816
3335
3336         RunQtAPITests will notify if a timeout occurs during testing.
3337         Added unittest to the master.cfg
3338
3339         Reviewed by Csaba Osztrogonác.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3342         (RunQtAPITests.evaluateCommand):
3343         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3344         (RunQtAPITestsTest):
3345         (RunQtAPITestsTest.assertResults):
3346         (RunQtAPITestsTest.test_timeout):
3347         (test_success):
3348         (test_failure):
3349         (test_timeout_and_failure):
3350
3351 2012-02-20  Andy Wingo  <wingo@igalia.com>
3352
3353         Add wingo as a committer.
3354
3355         Unreviewed.
3356
3357         * Scripts/webkitpy/common/config/committers.py: Add myself to the
3358         committers list.
3359
3360 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
3361
3362         [chromium] check that we're not running multiple modal dialogs at the same time
3363         https://bugs.webkit.org/show_bug.cgi?id=78486
3364
3365         Reviewed by Kent Tamura.
3366
3367         * DumpRenderTree/chromium/TestShell.cpp:
3368         (TestShell::TestShell):
3369         * DumpRenderTree/chromium/TestShell.h:
3370         (TestShell::setIsDisplayingModalDialog):
3371         (TestShell::isDisplayingModalDialog):
3372         (TestShell):
3373         * DumpRenderTree/chromium/WebViewHost.cpp:
3374         (WebViewHost::runModal):
3375
3376 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3377
3378         Fix WebKit2GTK+ for 'make distcheck'.
3379
3380         Instead of conditionally including WebKit2 GNUmakefiles, always
3381         include them and conditionally activate the final targets.
3382
3383         * MiniBrowser/gtk/GNUmakefile.am:
3384         * WebKitTestRunner/GNUmakefile.am:
3385
3386 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3387
3388         Enable video option for EFL port in build-webkit.
3389         https://bugs.webkit.org/show_bug.cgi?id=79006
3390
3391         Reviewed by Daniel Bates.
3392
3393         * Scripts/build-webkit:
3394
3395 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3396
3397         [EFL] Use modifier keys to execute pre-rendering.
3398         https://bugs.webkit.org/show_bug.cgi?id=77933
3399
3400         Reviewed by Chang Shu.
3401
3402         Use modifier key to execute pre-rendering instead of using reserved function keys.
3403
3404         * EWebLauncher/main.c:
3405         (on_key_down):
3406
3407 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3408
3409         Fix one more dangling reference to worker_connection.name, delete unused code.
3410
3411         Unreviewed, build fix.
3412
3413         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3414         (Manager.update):
3415         (_WorkerState.__init__):
3416
3417 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3418
3419         Add a change that should've been in r108005.
3420
3421         Unreviewed, build fix.
3422
3423         In the refactoring/cleanup in r108005 I should've changed the
3424         implementation of WorkerConnection to make it match BrokerClient
3425         (and everything else) so that objects had a name() method
3426         instead of a name property.
3427
3428         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3429         (Manager._run_tests):
3430         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3431         (_WorkerConnection.__init__):
3432         (_WorkerConnection.name):
3433         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3434         (_TestWorker.__init__):
3435         (_TestsMixin.name):
3436         (_TestsMixin.test_name):
3437         (_TestsMixin.test_cancel):
3438         (_TestsMixin.test_unknown_message):
3439
3440 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3441
3442         webkitpy: remove webkitpy.common.array_stream
3443         https://bugs.webkit.org/show_bug.cgi?id=78952
3444
3445         Reviewed by Eric Seidel.
3446
3447         Turns out array_stream didn't really do anything that StringIO
3448         didn't do (at least as of Python 2.6). This change removes it
3449         and updates all of the callers. Where possible, I changed the
3450         test assertions in order to capture the intent more clearly,
3451         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3452         we have self.assertContainsLine(stream, 'foo'), and instead of
3453         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3454         the latter isn't that much more readable, but StringIO doesn't
3455         export an empty() method.
3456
3457         * Scripts/webkitpy/common/array_stream.py: Removed.
3458         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3459         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3460         (passing_run):
3461         (run_and_capture):
3462         (StreamTestingMixin):
3463         (StreamTestingMixin.assertContains):
3464         (StreamTestingMixin.assertContainsLine):
3465         (StreamTestingMixin.assertEmpty):
3466         (StreamTestingMixin.assertNotEmpty):
3467         (LintTest):
3468         (LintTest.test_lint_test_files):
3469         (LintTest.test_lint_test_files__errors):
3470         (MainTest):
3471         (MainTest.test_child_process_1):
3472         (MainTest.test_child_processes_2):
3473         (MainTest.test_child_processes_min):
3474         (MainTest.test_help_printing):
3475         (MainTest.test_hung_thread):
3476         (MainTest.test_no_tests_found):
3477         (MainTest.test_no_tests_found_2):
3478         (MainTest.test_repeat_each_iterations_num_tests):
3479         (MainTest.test_test_list):
3480         (MainTest.test_unexpected_failures):
3481         (MainTest.test_worker_model__inline_with_child_processes):
3482         (MainTest.test_additional_platform_directory):
3483         (RebaselineTest):
3484         (RebaselineTest.assertBaselines):
3485         (RebaselineTest.test_reset_results):
3486         (RebaselineTest.test_missing_results):
3487         (RebaselineTest.test_new_baseline):
3488         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3489         (MeteredStream.update):
3490         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3491         (TestMeteredStream.test_regular):
3492         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3493         (TestUtilityFunctions.assertEmpty):
3494         (TestUtilityFunctions):
3495         (TestUtilityFunctions.assertNotEmpty):
3496         (TestUtilityFunctions.assertWritten):
3497         (TestUtilityFunctions.test_configure_logging):
3498         (Testprinter.assertEmpty):
3499         (Testprinter):
3500         (Testprinter.assertNotEmpty):
3501         (Testprinter.assertWritten):
3502         (Testprinter.reset):
3503         (Testprinter.get_printer):
3504         (Testprinter.test_help_printer):
3505         (Testprinter.do_switch_tests.do_helper):
3506         (Testprinter.test_print_one_line_summary):
3507         (Testprinter.test_print_test_result):
3508         (Testprinter.test_print_progress):
3509         (Testprinter.test_write_nothing):
3510         (Testprinter.test_write_misc):
3511         (Testprinter.test_write_everything):
3512         (Testprinter.test_write_verbose):
3513         (Testprinter.test_print_unexpected_results):
3514         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3515         (MainTest.assertWritten):
3516         (create_runner):
3517         (test_run_test_set):
3518         (test_run_test_set_kills_drt_per_run):
3519         (test_run_test_set_for_parser_tests):
3520         (test_run_test_set_with_json_output):
3521         (test_run_test_set_with_json_source):
3522         (test_run_test_set_with_multiple_repositories):
3523         (test_upload_json):
3524
3525 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3526
3527         [wx] Add the WebCore/page/scrolling directory to the build dirs.
3528
3529         * waf/build/settings.py:
3530
3531 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3532
3533         [wx] Unreviewed build fix. Don't error out or hang if we have
3534         downloaded dependencies but server update check fails.
3535
3536         * waf/build/build_utils.py:
3537         (download_if_newer):
3538
3539 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3540
3541         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
3542         https://bugs.webkit.org/show_bug.cgi?id=69444
3543
3544         Reviewed by Tony Chang.
3545
3546         Currently if a test's image checksum doesn't match the checksum
3547         in the baseline, but the images themselves match according to
3548         ImageDiff, new-run-webkit-tests ignores the problem. This is
3549         probably bad, but it's not yet clear what the right thing to do
3550         is. This patch will log a warning to stderr, at least (but the
3551         test will still pass).
3552
3553         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3554         (SingleTestRunner._compare_image):
3555         (SingleTestRunner._run_reftest):
3556         * Scripts/webkitpy/layout_tests/port/test.py:
3557         (unit_test_list):
3558         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3559
3560 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3561
3562         NRWT does not report failure for a skipped test
3563         https://bugs.webkit.org/show_bug.cgi?id=78750
3564
3565         Reviewed by Eric Seidel.
3566
3567         If a test is listed in a Skipped file and you run it anyway
3568         with --force, and the test fails, currently NRWT will print
3569         "test ran as expected"; this is confusing, because you probably
3570         expect the test to fail and yet this might lead you to think the
3571         test passed. This patch changes the expected behavior to "PASS",
3572         so tests that fail will be reported.
3573
3574         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3575         (result_was_expected):
3576         (TestExpectationParser):
3577         (TestExpectationParser.expectation_for_skipped_test):
3578         (TestExpectations):
3579         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3580         (test_add_skipped_tests):
3581         * Scripts/webkitpy/layout_tests/port/test.py:
3582         (unit_test_list): Add some tests that are expected to be in a Skipped file.
3583         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
3584
3585 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3586
3587         webkitpy: fix test code after bug 78181
3588         https://bugs.webkit.org/show_bug.cgi?id=78870
3589
3590         Reviewed by Adam Barth.
3591
3592         I forgot to update the test code as per Tony's suggestion in
3593         bug 78181 (r108005). This change does that, and in doing so
3594         it revealed a subtle bug in _InlineWorkerConnection.run() that
3595         I am fixing as part of this (_alive would not be cleared if an
3596         exception was thrown).
3597
3598         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3599         (_InlineWorkerConnection.run):
3600         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3601         (_TestWorker.__init__):
3602         (_TestWorker.handle_stop):
3603         (_TestWorker.handle_test):
3604         (_TestWorker.run):
3605         (_TestsMixin.handle_exception):
3606         (_TestsMixin.test_unknown_message):
3607
3608 2012-02-17  Adam Roben  <aroben@apple.com>
3609
3610         Mac build fix after r108119
3611
3612         * DumpRenderTree/mac/DumpRenderTree.mm:
3613         (runThread):
3614         (runPthread):
3615         (testThreadIdentifierMap):
3616         Updated to match current WTF threading APIs.
3617
3618 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3619
3620         revert r107147 - breaks webkit-patch on Mac SL
3621         https://bugs.webkit.org/show_bug.cgi?id=78866
3622
3623         Reviewed by Adam Barth.
3624
3625         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
3626         which is the version that ships on Mac SL. Reverting this
3627         change until we no longer have to worry about that version.
3628
3629         * Scripts/webkitpy/common/system/autoinstall.py:
3630         (AutoInstaller):
3631         (AutoInstaller._extract_all): Added a comment about SL.
3632         (AutoInstaller._unzip):
3633
3634 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
3635
3636         CSS regions enabled by default
3637         https://bugs.webkit.org/show_bug.cgi?id=78525
3638
3639         Reviewed by David Hyatt.
3640
3641         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3642         CSSRegions are still enabled by default.
3643         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3644
3645         * DumpRenderTree/chromium/LayoutTestController.cpp:
3646         (LayoutTestController::overridePreference):
3647         * DumpRenderTree/chromium/WebPreferences.cpp:
3648         (WebPreferences::reset):
3649         (WebPreferences::applyTo):
3650         * DumpRenderTree/chromium/WebPreferences.h:
3651         (WebPreferences):
3652         * DumpRenderTree/mac/DumpRenderTree.mm:
3653         (resetDefaultsToConsistentValues):
3654
3655 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
3656
3657         Some API tests erroneously use = instead of == (causing build failures)
3658         https://bugs.webkit.org/show_bug.cgi?id=78915
3659
3660         Reviewed by Sam Weinig.
3661
3662         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3663         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
3664         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
3665
3666 2012-02-17  Peter Beverloo  <peter@chromium.org>
3667
3668         [Chromium] Include TestShellLinux.cpp in the build for Android
3669         https://bugs.webkit.org/show_bug.cgi?id=78865
3670
3671         Reviewed by Eric Seidel.
3672
3673         Android will be re-using the TestShellLinux.cpp file. I already
3674         added this r104033, but it seems to have gotten lost in the
3675         recent refactorings.
3676
3677         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3678
3679 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3680
3681         Unreviewed, disable video build on EFL until it can be
3682         supported by EFL build bot.
3683
3684         * Scripts/build-webkit:
3685
3686 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3687
3688         [GTK] Implement zoom in/out in MiniBrowser
3689         https://bugs.webkit.org/show_bug.cgi?id=75253
3690
3691         Reviewed by Gustavo Noronha Silva.
3692
3693         * MiniBrowser/gtk/BrowserWindow.c:
3694         (browserWindowCanZoomIn):
3695         (browserWindowCanZoomOut):
3696         (browserWindowUpdateZoomActions):
3697         (webViewZoomLevelChanged):
3698         (zoomInCallback):
3699         (zoomOutCallback):
3700         (browser_window_init):
3701         (browserWindowConstructed):
3702
3703 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
3704
3705         layoutTestController.display() is flaky for SVG tests
3706         https://bugs.webkit.org/show_bug.cgi?id=78021
3707
3708         Reviewed by Adam Roben.
3709
3710         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
3711         Size the web view before running the test, not when dumping.
3712         All platforms handle this correctly now.
3713
3714         * DumpRenderTree/win/DumpRenderTree.cpp:
3715         (dump):
3716         (sizeWebViewForCurrentTest):
3717         (runTest):
3718
3719 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3720
3721         [GTK] Make install is broken when building without --enable-gtk-doc