Assert in WebPageProxy::suspendCurrentPageIfPossible()
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Chris Dumez  <cdumez@apple.com>
2
3         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4         https://bugs.webkit.org/show_bug.cgi?id=195506
5         <rdar://problem/48733477>
6
7         Reviewed by Alex Christensen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2019-03-11  Shawn Roberts  <sroberts@apple.com>
14
15         Adding myself to contributors.json
16
17         Unreviewed, addming myself to contributors.json .
18
19         * Scripts/webkitpy/common/config/contributors.json:
20
21 2019-03-11  Alex Christensen  <achristensen@webkit.org>
22
23         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
24         https://bugs.webkit.org/show_bug.cgi?id=195511
25         <rdar://problem/44873269>
26
27         Reviewed by Darin Adler.
28
29         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
30         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
31         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
32         (TEST_F):
33
34 2019-03-11  Chris Dumez  <cdumez@apple.com>
35
36         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
37         https://bugs.webkit.org/show_bug.cgi?id=195561
38
39         Reviewed by Youenn Fablet.
40
41         Make sure the JS in the test requests for permission to receive device orientation events.
42
43         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
44
45 2019-03-11  Youenn Fablet  <youenn@apple.com>
46
47         Allow storage quota increase by default in WTR
48         https://bugs.webkit.org/show_bug.cgi?id=195541
49
50         Reviewed by Geoffrey Garen.
51
52         Allow storage quota increase by default in WTR.
53         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
54         Use this for tests that explicitly need cache increase.
55
56         Instead of increasing quota by 2, make sure the next request is
57         granted by adding all given parameters.
58
59         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
60         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
61         (WTR::TestRunner::setAllowStorageQuotaIncrease):
62         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
63         * WebKitTestRunner/InjectedBundle/TestRunner.h:
64         * WebKitTestRunner/TestController.cpp:
65         (WTR::TestController::setAllowStorageQuotaIncrease):
66         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
67         * WebKitTestRunner/TestController.h:
68         * WebKitTestRunner/TestInvocation.cpp:
69         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
70         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
71         (WTR::TestController::cocoaResetStateToConsistentValues):
72         (WTR::TestController::setAllowStorageQuotaIncrease):
73         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
74         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
75         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
76
77 2019-03-11  Xan Lopez  <xan@igalia.com>
78
79         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
80         https://bugs.webkit.org/show_bug.cgi?id=194147
81
82         Reviewed by Michael Saboff.
83
84         To make --32-bit work correctly on Linux/64bit we need to:
85
86         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
87         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
88         unfortunately CMake only allows us to do this during
89         crosscompilation, which is overkill here.
90         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
91         pkg-config detection module uses the x86 .pc files instead of the
92         x86_64 ones.
93         - Set the -m32 flags for the compiler.
94
95         * Scripts/webkitdirs.pm:
96         (generateBuildSystemFromCMakeProject):
97
98 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
99
100         Add MotionMark-1.1 plan file for run-benchmark script.
101         https://bugs.webkit.org/show_bug.cgi?id=195481
102
103         Rubber-stamped by Darin Adler.
104
105         Run-benchmark script should support MontionMark-1.1.
106
107         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
108
109 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
110
111         [ews-app] Add support for submit-to-ews url
112         https://bugs.webkit.org/show_bug.cgi?id=195477
113
114         Reviewed by Lucas Forschler.
115
116         * BuildSlaveSupport/ews-app/ews/fetcher.py:
117         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
118         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
119         * BuildSlaveSupport/ews-app/ews/urls.py:
120         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
121
122 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
123
124         Unreviewed, rolling out r242688, r242643, r242624.
125
126         Caused multiple layout test failures and crashes on iOS and macOS.
127
128         Reverted changeset:
129
130         "requestAnimationFrame should execute before the next frame"
131         https://bugs.webkit.org/show_bug.cgi?id=177484
132         https://trac.webkit.org/changeset/242624/webkit
133
134         * Tracing/SystemTracePoints.plist:
135
136 2019-03-11  John Wilander  <wilander@apple.com>
137
138         Resource Load Statistics: Make it possible exclude localhost from classification
139         https://bugs.webkit.org/show_bug.cgi?id=195474
140         <rdar://problem/47520577>
141
142         Reviewed by Brent Fulgham.
143
144         This patch allows for localhost to be excluded from classification and
145         treatment as a prevalent resource.
146
147         The WebKit Tools change adds a new function called
148         testRunner.setStatisticsIsRunningTest() which can be used to control this
149         behavior.
150
151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
153         (WTR::TestRunner::setStatisticsIsRunningTest):
154         * WebKitTestRunner/InjectedBundle/TestRunner.h:
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::TestController::setStatisticsIsRunningTest):
157         * WebKitTestRunner/TestController.h:
158         * WebKitTestRunner/TestInvocation.cpp:
159         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
160
161 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-build] Disable waterfall and console view for ews-build.webkit.org
164         https://bugs.webkit.org/show_bug.cgi?id=195560
165
166         Reviewed by Lucas Forschler.
167
168         * BuildSlaveSupport/ews-build/master.cfg:
169
170 2019-03-11  Alex Christensen  <achristensen@webkit.org>
171
172         Unreviewed, rolling out r242698.
173
174         API test crashes on bots.
175
176         Reverted changeset:
177
178         "Add a WKContentRuleList variant that uses copied memory
179         instead of mmap'd shared memory for class A containerized
180         apps"
181         https://bugs.webkit.org/show_bug.cgi?id=195511
182         https://trac.webkit.org/changeset/242698
183
184 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
185
186         [WPE] Enable web process sandbox
187         https://bugs.webkit.org/show_bug.cgi?id=195169
188
189         Reviewed by Daniel Bates.
190
191         * wpe/install-dependencies:
192         * wpe/jhbuild.modules:
193
194 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
195
196         [ews-app] Use port 17000 for worker communication
197         https://bugs.webkit.org/show_bug.cgi?id=195558
198
199         Reviewed by Lucas Forschler.
200
201         * BuildSlaveSupport/ews-build/master.cfg:
202
203 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
204
205         [ews-build] unit-tests fail when passwords.json is missing
206         https://bugs.webkit.org/show_bug.cgi?id=195557
207
208         Reviewed by Lucas Forschler.
209
210         * BuildSlaveSupport/ews-build/loadConfig.py:
211         (loadBuilderConfig):
212         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
213         (ConfigDotJSONTest.test_configuration):
214         * BuildSlaveSupport/ews-build/master.cfg:
215
216 2019-03-11  Truitt Savell  <tsavell@apple.com>
217
218         Unreviewed, rolling out r242702.
219
220         Broke High Sierra builders.
221
222         Reverted changeset:
223
224         "Add utility function to allow easy reverse range-based
225         iteration of a container"
226         https://bugs.webkit.org/show_bug.cgi?id=195542
227         https://trac.webkit.org/changeset/242702
228
229 2019-03-11  Sam Weinig  <sam@webkit.org>
230
231         Add utility function to allow easy reverse range-based iteration of a container
232         https://bugs.webkit.org/show_bug.cgi?id=195542
233
234         Reviewed by Antti Koivisto.
235
236         * TestWebKitAPI/CMakeLists.txt:
237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
238         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
239         (TestWebKitAPI::TEST):
240         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
241
242 2019-03-10  Alex Christensen  <achristensen@webkit.org>
243
244         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
245         https://bugs.webkit.org/show_bug.cgi?id=195511
246         <rdar://problem/44873269>
247
248         Reviewed by Darin Adler.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
251         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
252         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
253         (TEST_F):
254
255 2019-03-10  Tim Horton  <timothy_horton@apple.com>
256
257         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
258         https://bugs.webkit.org/show_bug.cgi?id=195499
259
260         Reviewed by Darin Adler.
261
262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
263         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
264         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
265         (-[WKWebView synchronouslyFocusTextInputContext:]):
266         (applyStyle):
267         (applyIframe):
268         (TEST):
269         Add some tests for this SPI.
270
271 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
272
273         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
274         https://bugs.webkit.org/show_bug.cgi?id=181151
275
276         Reviewed by Don Olmstead.
277
278         * TestWebKitAPI/CMakeLists.txt:
279         * TestWebKitAPI/PlatformWin.cmake:
280         Enable TestWTF RunLoop tests in all platforms.
281
282         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
283         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
284         (TestWebKitAPI::DerivedOneShotTimer::fired):
285         (TestWebKitAPI::TEST):
286         Only a few platforms support nested RunLoop.
287
288         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
289         (TestWebKitAPI::DerivedRepeatingTimer::fired):
290
291 2019-03-10  David Quesada  <david_quesada@apple.com>
292
293         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
294         https://bugs.webkit.org/show_bug.cgi?id=152480
295
296         Reviewed by Chris Dumez.
297
298         Add a unit test based on Daniel Bates's test case that starts a download, ensures
299         there are no additional references to the process pool besides the one held by
300         the download, waits for the download to finish (in the sense that the
301         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
302         measure, also check that the process pool has been deallocated at the end of the
303         test. The test wouldn't be meaningful if the process pool were still alive.
304
305         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
306         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
307         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
308             The download will be canceled because the delegate does not implement the
309             method to decide the download's destination, so this is where we know the
310             DownloadProxyMap is done with the DownloadProxy.
311         (TEST):
312
313 2019-03-08  Chris Dumez  <cdumez@apple.com>
314
315         Add support for Device Orientation / Motion permission API
316         https://bugs.webkit.org/show_bug.cgi?id=195329
317         <rdar://problem/47645367>
318
319         Reviewed by Geoffrey Garen.
320
321         Add test infrastructure to help test the Device Orientation / Motion permission API.
322
323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
325         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
329         (WTR::TestController::createWebViewWithOptions):
330         (WTR::TestController::resetStateToConsistentValues):
331         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
332         * WebKitTestRunner/TestController.h:
333         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
334         * WebKitTestRunner/TestInvocation.cpp:
335         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
336
337 2019-03-08  Saam barati  <sbarati@apple.com>
338
339         Add a compare-results script to compare benchmark results
340         https://bugs.webkit.org/show_bug.cgi?id=195486
341         <rdar://problem/48723397>
342
343         Reviewed by Geoffrey Garen.
344
345         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
346         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
347         to extend it to learn about our other benchmarks.
348
349         * Scripts/compare-results: Added.
350         (readJSONFile):
351         (detectJetStream2):
352         (JetStream2Results):
353         (detectSpeedometer2):
354         (Speedometer2Results):
355         (detectPLT5):
356         (PLT5Results):
357         (detectBenchmark):
358         (biggerIsBetter):
359         (ttest):
360         (getOptions):
361         (main):
362
363 2019-03-08  Stephanie Lewis  <slewis@apple.com>
364
365         Ensure old tab state is cleared between iterations of run-benchmark
366         https://bugs.webkit.org/show_bug.cgi?id=195393
367         <rdar://problem/46885583>
368
369         Reviewed by Dewei Zhu.
370
371         a) ensure the default to restore state is not set
372         b) terminate Safari correctly
373         c) Set the system default to ignore Persistent State in Safari
374
375         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
376         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
377         (OSXBrowserDriver.prepare_env): 
378         (OSXBrowserDriver.restore_env):
379         (OSXBrowserDriver.close_browsers):
380         (OSXBrowserDriver._terminate_processes):
381         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
382         (OSXChromeDriver):
383         (OSXChromeCanaryDriver):
384         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
385         (OSXFirefoxDriver):
386         (OSXFirefoxNightlyDriver):
387         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
388         (OSXSafariDriver):
389         (OSXSafariDriver.prepare_env):
390
391 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
392
393         [GTK] Several InputMethodFilter tests are failing
394         https://bugs.webkit.org/show_bug.cgi?id=195408
395
396         Reviewed by Carlos Garcia Campos.
397
398         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
399         Regressed in r241751.
400         Hexadecimal values of keycodes are expressed now in upper letters.
401         Composited characters should be cast to UTF8 strings.
402
403         (TestWebKitAPI::TEST):
404
405 2019-03-07  Tomas Popela  <tpopela@redhat.com>
406
407         [GTK] Make Tools/gtkdoc python3 compatible
408         https://bugs.webkit.org/show_bug.cgi?id=195359
409
410         Reviewed by Carlos Garcia Campos.
411
412         * gtkdoc/generate-gtkdoc:
413         ConfigParser was reworked in Python 3.2 so we have adapt the code to
414         work with Python 2 and 3.
415         (get_gtkdoc_module_paths):
416         The iteritems() was removed in Python 3, so let's use items() that's
417         available in Python 2 and 3.
418         (get_generator_for_config):
419         * gtkdoc/gtkdoc.py:
420         (GTKDoc._run_command):
421         The sys.stdout.write() is expecting str in Python 3 and not bytes
422         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
423         for passing the bytes there.
424
425 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
426
427         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
428         https://bugs.webkit.org/show_bug.cgi?id=195346
429         <rdar://problem/48667048>
430
431         Unreviewed build fix for clang-cl.
432
433         * DumpRenderTree/win/DumpRenderTree.cpp:
434         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
435
436 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
437
438         requestAnimationFrame should execute before the next frame
439         https://bugs.webkit.org/show_bug.cgi?id=177484
440
441         Reviewed by Simon Fraser.
442
443         Add trace points for the page RenderingUpdate.
444
445         * Tracing/SystemTracePoints.plist:
446
447 2019-03-07  Zalan Bujtas  <zalan@apple.com>
448
449         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
450         https://bugs.webkit.org/show_bug.cgi?id=195353
451         <rdar://problem/48626394>
452
453         Reviewed by Simon Fraser.
454
455         * WebKitTestRunner/ios/TestControllerIOS.mm:
456         (WTR::TestController::platformResetPreferencesToConsistentValues):
457
458 2019-03-07  John Wilander  <wilander@apple.com>
459
460         Resource Load Statistics: Make it possible to purge only script-accessible cookies
461         https://bugs.webkit.org/show_bug.cgi?id=195383
462         <rdar://problem/48570136>
463
464         Reviewed by Brent Fulgham.
465
466         This patch adds test infrastructure to purge only script-accessible cookies,
467         including a new testRunner function called statisticsDeleteCookiesForHost().git a
468
469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
471         (WTR::TestRunner::statisticsDeleteCookiesForHost):
472         * WebKitTestRunner/InjectedBundle/TestRunner.h:
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::statisticsDeleteCookiesForHost):
475         * WebKitTestRunner/TestController.h:
476         * WebKitTestRunner/TestInvocation.cpp:
477         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
478
479 2019-03-07  Commit Queue  <commit-queue@webkit.org>
480
481         Unreviewed, rolling out r242354.
482         https://bugs.webkit.org/show_bug.cgi?id=195402
483
484         breaks layout tests in all configurations (Requested by
485         zdobersek on #webkit).
486
487         Reverted changeset:
488
489         "[WPE] Enable web process sandbox"
490         https://bugs.webkit.org/show_bug.cgi?id=195169
491         https://trac.webkit.org/changeset/242354
492
493 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
494
495         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
496         https://bugs.webkit.org/show_bug.cgi?id=195346
497
498         Reviewed by Fujii Hironori.
499
500         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
501         (TestWebKitAPI::TEST):
502         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
503
504         * DumpRenderTree/win/DumpRenderTree.cpp:
505         (findFontFallback):
506         (addFontFallbackIfPresent):
507         (removeFontFallbackIfPresent):
508         (main):
509         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
510         (TestWebKitAPI::Util::moduleDirectory):
511         (TestWebKitAPI::Util::createInjectedBundlePath):
512         Use wchar helpers as needed.
513
514 2019-03-06  Rob Buis  <rbuis@igalia.com>
515
516         Consider supporting the `referrerpolicy` attribute.
517         https://bugs.webkit.org/show_bug.cgi?id=179053
518
519         Reviewed by Darin Adler.
520
521         Add a runtime flag for referrerpolicy attribute.
522
523         * DumpRenderTree/mac/DumpRenderTree.mm:
524         (enableExperimentalFeatures):
525
526 2019-03-05  Daniel Bates  <dabates@apple.com>
527
528         Update expected API test result following r242379
529         (https://bugs.webkit.org/show_bug.cgi?id=195125)
530
531         Update expected x-coordinate of selection rect now that the left padding of
532         a textarea is sized in ems (so dependent on the font size) just like the left
533         padding of a text field.
534
535         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
536         (TestWebKitAPI::TEST):
537
538 2019-03-05  David Quesada  <david_quesada@apple.com>
539
540         [WK2] It should be possible to follow links with 'download' attributes
541         https://bugs.webkit.org/show_bug.cgi?id=195145
542         rdar://problem/48462642
543
544         Reviewed by Alex Christensen.
545
546         Add a unit test to verify that activating links with 'download' attributes now
547         navigates to the linked resource, rather than starts downloading it. Add another
548         to verify that it is still possible to explicitly download the link via the
549         'Download' navigation action policy.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
552         (-[DownloadAttributeTestDelegate init]):
553         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
554         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
555         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
556         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
557         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
558         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
559         (TEST):
560         * WebKitTestRunner/TestController.cpp:
561         (WTR::TestController::decidePolicyForNavigationAction):
562         * WebKitTestRunner/TestController.h:
563
564 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
565
566         [Curl] Implement Cookie Accept Policy.
567         https://bugs.webkit.org/show_bug.cgi?id=191645
568
569         Reviewed by Fujii Hironori.
570
571         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
572         (TestWebKitAPI::Curl::TEST_F):
573
574 2019-03-05  Youenn Fablet  <youenn@apple.com>
575
576         Rename requestCacheStorageSpace to requestStorageSpace
577         https://bugs.webkit.org/show_bug.cgi?id=195282
578
579         Reviewed by Chris Dumez.
580
581         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
582         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
583         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
584
585 2019-03-05  Brady Eidson  <beidson@apple.com>
586
587         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
588         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
589
590         Reviewed by Tim Horton.
591
592         Loading a file: URL into a WKWebView and then loading another file: url from a completely
593         different directory into that same WKWebView should work.
594
595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
596         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
597
598 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
599
600         Add WeakHashSet
601         https://bugs.webkit.org/show_bug.cgi?id=195152
602
603         Reviewed by Antti Koivisto.
604
605         Added tests for WeakHashSet.
606
607         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
608         (TestWebKitAPI::Base::Base): Moved.
609         (TestWebKitAPI::Derived::foo): Moved.
610         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
611         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
612         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
613         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
614
615 2019-03-04  Chris Dumez  <cdumez@apple.com>
616
617         Do not share WebProcesses between private and regular sessions
618         https://bugs.webkit.org/show_bug.cgi?id=195189
619         <rdar://problem/48421064>
620
621         Reviewed by Alex Christensen.
622
623         Add API test coverage.
624
625         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
626         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
627
628 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
629
630         [WPE] Enable web process sandbox
631         https://bugs.webkit.org/show_bug.cgi?id=195169
632
633         Reviewed by Daniel Bates.
634
635         * wpe/install-dependencies:
636         * wpe/jhbuild.modules:
637
638 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
639
640         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
641         https://bugs.webkit.org/show_bug.cgi?id=195206
642
643         Reviewed by Žan Doberšek.
644
645         Add a new test case.
646
647         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
648         (testJSCClass):
649
650 2019-03-04  Charlie Turner  <cturner@igalia.com>
651
652         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
653         https://bugs.webkit.org/show_bug.cgi?id=194898
654
655         Reviewed by Žan Doberšek.
656
657         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
658         a GCC extension that permits arithmetic on void* pointer. Inline
659         the macro until this issue is fixed upstream.
660
661 2019-03-03  Tim Horton  <timothy_horton@apple.com>
662
663         Rid the world of WK_API_ENABLED
664         https://bugs.webkit.org/show_bug.cgi?id=195263
665
666         Reviewed by Dan Bernstein.
667
668         List of changed files elided because it's useless.
669
670 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
671
672         Unreviewed follow-up to r242292.
673
674         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
675
676         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
677         (TestWebKitAPI::testStrip): Renamed from strip.
678         (TestWebKitAPI::TEST):
679
680 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
681
682         Unreviewed, remove accidentally-committed URLHelpers.cpp test
683
684         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
685         and bug #194272 for details.
686
687         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
688
689 2019-03-03  Tim Horton  <timothy_horton@apple.com>
690
691         Remove some more unused 32-bit code
692         https://bugs.webkit.org/show_bug.cgi?id=195255
693
694         Reviewed by Darin Adler.
695
696         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
697         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
698         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
699         (NPP_New):
700         (NPP_HandleEvent):
701         (handleEventCarbon): Deleted.
702
703 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
704
705         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
706
707         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
708         (TestWebKitAPI::TEST):
709
710 2019-03-01  Darin Adler  <darin@apple.com>
711
712         Finish removing String::format
713         https://bugs.webkit.org/show_bug.cgi?id=194893
714
715         Reviewed by Daniel Bates.
716 '
717         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
718
719 2019-03-01  Alex Christensen  <achristensen@webkit.org>
720
721         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
722         https://bugs.webkit.org/show_bug.cgi?id=195229
723         <rdar://problem/48520362>
724
725         Reviewed by Chris Dumez.
726
727         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
728         (TEST):
729
730 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
731
732         Add a system trace scope for event region building
733         https://bugs.webkit.org/show_bug.cgi?id=195226
734
735         Reviewed by Jon Lee.
736
737         This trace scope measures the time spend converting element rects into Region objects,
738         which can be large on some pages.
739
740         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
741
742         * Tracing/SystemTracePoints.plist:
743
744 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
745
746         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
747         https://bugs.webkit.org/show_bug.cgi?id=194612
748
749         Reviewed by Alex Christensen.
750
751         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
752         Just test the new string-processing function and don't touch the actual environment.
753         (Test cases are all as before, but based on operator== instead of strcmp.)
754
755 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
756
757         [ews-app] Update primary keys for handling multiple Buildbot instances
758         https://bugs.webkit.org/show_bug.cgi?id=195120
759
760         Reviewed by Stephanie Lewis.
761
762         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
763         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
764         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
765
766         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
767         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
768         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
769         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
770         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
771         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
772
773 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
774
775         [WinCairo] Enable service worker
776         https://bugs.webkit.org/show_bug.cgi?id=188318
777
778         Reviewed by Youenn Fablet.
779
780         * DumpRenderTree/DumpRenderTreePrefix.h:
781         * TestWebKitAPI/PlatformWin.cmake:
782         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
783         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
784         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
785
786 2019-03-01  Justin Fan  <justin_fan@apple.com>
787
788         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
789         https://bugs.webkit.org/show_bug.cgi?id=195191
790
791         Rubber-stamped by Dean Jackson.
792
793         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
794
795         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
796
797 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
798
799         Unreviewed, fix lldb webkitpy tests
800         https://bugs.webkit.org/show_bug.cgi?id=194375
801
802         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
803
804         * lldb/lldb_webkit.py:
805         (WTFStringImplProvider.is_8bit):
806
807 2019-02-28  David Quesada  <david_quesada@apple.com>
808
809         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
810         https://bugs.webkit.org/show_bug.cgi?id=195121
811         rdar://problem/48450302
812
813         Reviewed by Alex Christensen.
814
815         Add API tests for -WKNavigationAction._shouldPerformDownload in various
816         configurations where the 'download' attribute is absent, blank, or populated
817         with a filename, and where the anchor element is same-origin or cross-origin
818         (meaning the 'download' attribute shouldn't be honored).
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
822         (-[NavigationActionTestDelegate init]):
823         (-[NavigationActionTestDelegate navigationAction]):
824         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
825         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
826         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
827         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
828         (TEST):
829
830 2019-02-28  Antoine Quint  <graouts@apple.com>
831
832         Enable the Pointer Events runtime flag by default
833         https://bugs.webkit.org/show_bug.cgi?id=195156
834
835         Reviewed by Dean Jackson.
836
837         * DumpRenderTree/mac/DumpRenderTree.mm:
838         (enableExperimentalFeatures):
839
840 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
841
842         Several PasteImage API tests are flaky
843         https://bugs.webkit.org/show_bug.cgi?id=195160
844
845         Reviewed by Tim Horton.
846
847         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
848         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
849         listening for a "load" event after image load is already complete.
850
851         To address this, make these tests first register a "load" event handler, then run script to insert an image
852         element into the document, and finally wait until the load event is observed before checking image size.
853
854         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
855
856 2019-02-28  Chris Dumez  <cdumez@apple.com>
857
858         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
859         https://bugs.webkit.org/show_bug.cgi?id=195107
860
861         Reviewed by Alex Christensen.
862
863         Give some time for the zoom level to get restored.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
866
867 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
868
869         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
870         https://bugs.webkit.org/show_bug.cgi?id=194958
871
872         Reviewed by Geoffrey Garen.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
875         (TEST):
876
877 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
878
879         [ews-app] Update method to save build to handle builder_display_name
880         https://bugs.webkit.org/show_bug.cgi?id=195047
881
882         Reviewed by Dewei Zhu.
883
884         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
885         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
886
887 2019-02-28  Justin Fan  <justin_fan@apple.com>
888
889         [Web GPU] Enable Web GPU only on 64-bit
890         https://bugs.webkit.org/show_bug.cgi?id=195139
891
892         Because Metal is only supported on 64 bit apps.
893
894         Unreviewed build fix.
895
896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
897
898 2019-02-27  Youenn Fablet  <youenn@apple.com>
899
900         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
901         https://bugs.webkit.org/show_bug.cgi?id=194959
902
903         Reviewed by Chris Dumez.
904
905         Spin loop until getting the condition to remove flakiness.
906
907         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
908
909 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
910
911         [ews-build] Buildbot should include builder_display_name in the build events
912         https://bugs.webkit.org/show_bug.cgi?id=195045
913
914         Reviewed by Dewei Zhu.
915
916         * BuildSlaveSupport/ews-build/events.py:
917         (Events.buildStarted): Included builder_display_name in event data. Also renamed
918         buildername to builder_name to be consistent in naming style.
919         (Events.buildFinished): Ditto.
920
921 2019-02-27  Chris Dumez  <cdumez@apple.com>
922
923         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
924         https://bugs.webkit.org/show_bug.cgi?id=194480
925
926         Reviewed by Brady Eidson.
927
928         Update existing API test to make it more likely to reproduce the issue.
929
930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
931
932 2019-02-27  Brady Eidson  <beidson@apple.com>
933
934         Universal links from Google search results pages don't open the app.
935         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
936
937         Reviewed by Geoffrey Garen.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
940         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
941         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
942         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
943
944 2019-02-27  Chris Dumez  <cdumez@apple.com>
945
946         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
947         https://bugs.webkit.org/show_bug.cgi?id=195102
948
949         Reviewed by Geoffrey Garen.
950
951         If the number of processes is not yet what we expect, wait a bit and check again to give
952         processes some time to exit.
953
954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
955
956 2019-02-27  Chris Dumez  <cdumez@apple.com>
957
958         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
959         https://bugs.webkit.org/show_bug.cgi?id=194545
960
961         Reviewed by Brady Eidson.
962
963         Make sure the test navigates forward and then back only once. Previously, navigating
964         back would trigger a navigation again in a timer.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
967
968 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
969
970         High Sierra Debug JSC test queue should use faster hardware
971         https://bugs.webkit.org/show_bug.cgi?id=194603
972
973         Rubber-stamped by Alexey Proskuryakov.
974
975         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
976
977         * BuildSlaveSupport/build.webkit.org-config/config.json:
978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
979         (BubbleQueueServer):
980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
981         (WebKitBuildbot):
982         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
983         * QueueStatusServer/config/queues.py:
984         * Scripts/webkitpy/common/config/ews.json:
985         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
986         (test_ews_name):
987
988 2019-02-27  John Wilander  <wilander@apple.com>
989
990         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
991         https://bugs.webkit.org/show_bug.cgi?id=195071
992         <rdar://problem/48417690>
993
994         Reviewed by Alex Christensen and Brent Fulgham.
995
996         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
997         (TestWebKitAPI::createURL):
998             Convenience function.
999         (TestWebKitAPI::TEST):
1000             WebCore::AdClickAttribution now takes a URL when creating Source and
1001             Destination.
1002         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1003         (TestWebKitAPI::TEST):
1004             WebCore::AdClickAttribution now takes a URL when creating Source and
1005             Destination.
1006
1007 2019-02-27  Antoine Quint  <graouts@apple.com>
1008
1009         Support Pointer Events on macOS
1010         https://bugs.webkit.org/show_bug.cgi?id=195008
1011         <rdar://problem/47454419>
1012
1013         Reviewed by Dean Jackson.
1014
1015         * DumpRenderTree/mac/DumpRenderTree.mm:
1016         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1017         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1018
1019 2019-02-26  Mark Lam  <mark.lam@apple.com>
1020
1021         Remove remaining poisoning code.
1022         https://bugs.webkit.org/show_bug.cgi?id=194138
1023
1024         Reviewed by Saam Barati.
1025
1026         * TestWebKitAPI/CMakeLists.txt:
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1029         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1030         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1031         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1032         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1033         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1034
1035 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1036
1037         Move ephemeral local storage from WebProcess to UIProcess
1038         https://bugs.webkit.org/show_bug.cgi?id=195074
1039         <rdar://problem/47937975>
1040
1041         Reviewed by Geoff Garen.
1042
1043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1044
1045 2019-02-20  Jer Noble  <jer.noble@apple.com>
1046
1047         [Cocoa] Media elements will restart network buffering just before suspending
1048         https://bugs.webkit.org/show_bug.cgi?id=193691
1049
1050         Reviewed by Eric Carlson.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1054         (TEST):
1055
1056 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1057
1058         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1059         https://bugs.webkit.org/show_bug.cgi?id=191652
1060
1061         Reviewed by Alex Christensen.
1062
1063         Fix WinCairo MiniBrowser behavior of authentication dialog.
1064
1065         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1066         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1067
1068 2019-02-26  Youenn Fablet  <youenn@apple.com>
1069
1070         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1071         https://bugs.webkit.org/show_bug.cgi?id=195028
1072         <rdar://problem/48243733>
1073
1074         Reviewed by Eric Carlson.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1077
1078 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1079
1080         [WPE] Add API for webview background color configuration
1081         https://bugs.webkit.org/show_bug.cgi?id=192305
1082
1083         Reviewed by Michael Catanzaro.
1084
1085         * MiniBrowser/wpe/main.cpp:
1086         (main): Add a new option to configure the webview background
1087         color. Example: --bg-color=transparent.
1088         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1089         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1090         (beforeAll): Ditto.
1091
1092 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1093
1094         scalableNativeWebpageParameters() is not preserved on new page navigation.
1095         https://bugs.webkit.org/show_bug.cgi?id=194892
1096         <rdar://problem/47538280>
1097
1098         Reviewed by Wenson Hsieh.
1099         
1100         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1101
1102         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1103         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1104         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1105         (WTR::UIScriptController::allowsViewportShrinkToFit):
1106         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1107         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1108         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1109         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1110         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1111         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1112
1113 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1114
1115         [ews-app] Add model for handling multiple Buildbot instances
1116         https://bugs.webkit.org/show_bug.cgi?id=194863
1117
1118         Reviewed by Stephanie Lewis.
1119
1120         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1121
1122 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1123
1124         [ews-app] Remove BuilderMapping table
1125         https://bugs.webkit.org/show_bug.cgi?id=194961
1126
1127         Reviewed by Stephanie Lewis.
1128
1129         Store builder name directly in build table, instead of having a separate
1130         table for it.
1131
1132         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1133         * BuildSlaveSupport/ews-app/ews/models/build.py:
1134         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1136
1137 2019-02-25  John Wilander  <wilander@apple.com>
1138
1139         Introduce and adopt new class RegistrableDomain for eTLD+1
1140         https://bugs.webkit.org/show_bug.cgi?id=194791
1141         <rdar://problem/48179240>
1142
1143         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1144
1145         This patch adds an API test and replaces two instances of
1146         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1147
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1150         (TestWebKitAPI::TEST):
1151             Changed two strings to make sure the registrable domains are still considered
1152             invalid and pass the test.
1153         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1154         (TestWebKitAPI::TEST):
1155         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1156         (WTR::InjectedBundle::didReceiveMessageToPage):
1157
1158 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1159
1160         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1161         https://bugs.webkit.org/show_bug.cgi?id=195001
1162
1163         Reviewed by Carlos Garcia Campos.
1164
1165         API version 1.0 always includes the functionality previously guarded with
1166         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1167         unconditionally.
1168
1169         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1170         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1171         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1172         (WebViewTest::showInWindow): Ditto.
1173         (WebViewTest::hideView): Ditto.
1174         * wpe/backends/HeadlessViewBackend.cpp:
1175         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1176         * wpe/backends/ViewBackend.cpp:
1177         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1178         * wpe/backends/WindowViewBackend.cpp:
1179         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1180         WPE_BACKEND_CHECK_VERSION().
1181         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1182
1183 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1184
1185         [Flatpak] Add support for flatpak > 1.1.2
1186         https://bugs.webkit.org/show_bug.cgi?id=194088
1187
1188         Flatpak 1.2 is now out so we need to support that
1189         version now.
1190
1191         Reviewed by Michael Catanzaro.
1192
1193         * flatpak/flatpakutils.py:
1194         (check_flatpak):
1195         (FlatpakPackages.__init__):
1196         (FlatpakPackages.__detect_packages):
1197         (FlatpakPackages.__detect_packages.in):
1198         (FlatpakRepos.update):
1199
1200 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1201
1202         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1203         https://bugs.webkit.org/show_bug.cgi?id=194998
1204
1205         Reviewed by Carlos Garcia Campos.
1206
1207         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1208         to a Git checkout and using the latest commit containing various fixes
1209         and improvements.
1210
1211 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1212
1213         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1214         https://bugs.webkit.org/show_bug.cgi?id=194981
1215
1216         Reviewed by Žan Doberšek.
1217
1218         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1219         (TestWebKitAPI::TEST):
1220
1221 2019-02-23  Keith Miller  <keith_miller@apple.com>
1222
1223         Add new mac target numbers
1224         https://bugs.webkit.org/show_bug.cgi?id=194955
1225
1226         Reviewed by Tim Horton.
1227
1228         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1229         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1230         * MiniBrowser/Configurations/Base.xcconfig:
1231         * TestWebKitAPI/Configurations/Base.xcconfig:
1232         * WebKitTestRunner/Configurations/Base.xcconfig:
1233
1234 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1235
1236         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1237         https://bugs.webkit.org/show_bug.cgi?id=194846
1238
1239         Reviewed by Don Olmstead.
1240
1241         Added _search_paths() and _port_specific_expectations_files() for
1242         WinCairoPort.
1243
1244         * Scripts/webkitpy/port/win.py:
1245         (WinCairoPort.default_baseline_search_path):
1246         (WinCairoPort):
1247         (WinCairoPort._port_specific_expectations_files):
1248         (WinCairoPort._search_paths):
1249
1250 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1251
1252         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1253         https://bugs.webkit.org/show_bug.cgi?id=194963
1254
1255         Reviewed by Dean Jackson.
1256
1257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1258         Do a `contains` check instead of `equals`, because in debug builds we
1259         put the GraphicsLayer pointer in a prefix.
1260
1261 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1262
1263         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1264         https://bugs.webkit.org/show_bug.cgi?id=194873
1265         <rdar://problem/46701974>
1266
1267         Reviewed by Tim Horton.
1268
1269         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1270
1271         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1272         (WTR::UIScriptController::menuRect const):
1273         (WTR::UIScriptController::isShowingMenu const):
1274         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1275         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1276         (WTR::UIScriptController::menuRect const):
1277
1278         Add a function to query the bounds of the callout menu in content coordinates.
1279
1280         (WTR::UIScriptController::isShowingMenu const):
1281
1282         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1283
1284         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1285         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1286         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1287         (WTR::UIScriptController::rectForMenuAction const):
1288         (WTR::UIScriptController::menuRect const):
1289         (WTR::UIScriptController::isShowingMenu const):
1290         (WTR::findViewInHierarchyOfType): Deleted.
1291
1292 2019-02-22  Chris Dumez  <cdumez@apple.com>
1293
1294         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1295         https://bugs.webkit.org/show_bug.cgi?id=194954
1296         <rdar://problem/48127957>
1297
1298         Reviewed by Alex Christensen.
1299
1300         Add API test coverage.
1301
1302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1303         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1304         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1305         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1306
1307 2019-02-22  Chris Dumez  <cdumez@apple.com>
1308
1309         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1310         https://bugs.webkit.org/show_bug.cgi?id=194924
1311         <rdar://problem/48216125>
1312
1313         Reviewed by Geoffrey Garen.
1314
1315         Add API test coverage.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1318
1319 2019-02-22  Chris Dumez  <cdumez@apple.com>
1320
1321         Unreviewed, disable API test added in r241928 on iOS.
1322
1323         The cache is not enabled on devices with less than 3GB of RAM.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1326
1327 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1328
1329         Hardcode Visual Viewports on everywhere except iOS WK1
1330         https://bugs.webkit.org/show_bug.cgi?id=194928
1331
1332         Reviewed by Zalan Bujtas.
1333
1334         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1335         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1336         set it to false. The setting has shipped for several years and there's no need to turn
1337         it off now.
1338
1339         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1340         Visual Viewports are not enabled.
1341         
1342         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1343         that only runs in WK2
1344
1345         * MiniBrowser/mac/SettingsController.h:
1346         * MiniBrowser/mac/SettingsController.m:
1347         (-[SettingsController init]):
1348         (-[SettingsController _populateMenu]):
1349         (-[SettingsController validateMenuItem:]):
1350         (-[SettingsController visualViewportEnabled]): Deleted.
1351         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1352         * MiniBrowser/mac/WK1BrowserWindowController.m:
1353         (-[WK1BrowserWindowController didChangeSettings]):
1354         * MiniBrowser/mac/WK2BrowserWindowController.m:
1355         (-[WK2BrowserWindowController didChangeSettings]):
1356
1357 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1358
1359         Discard cached processes when clearing website data store
1360         https://bugs.webkit.org/show_bug.cgi?id=194894
1361
1362         Reviewed by Chris Dumez.
1363
1364         Added a test case.
1365
1366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1367         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1368
1369 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1370
1371         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1372         https://bugs.webkit.org/show_bug.cgi?id=194914
1373         <rdar://problem/47586889>
1374
1375         Reviewed by Geoffrey Garen.
1376
1377         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1378         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1379         (TEST):
1380         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1381
1382 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1383
1384         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1385         <https://webkit.org/b/194761>
1386
1387         Reviewed by Myles Maxfield.
1388
1389         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1390         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1391         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1392         to use ARC-compliant cast.
1393         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1394         ARC-compliant cast.
1395         (WTR::installFakeHelvetica): Log `error` to console if
1396         CTFontManagerRegisterFontsForURL() fails, but only on supported
1397         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1398         Call CFRelease() on `error` to fix the leak.  Update to use
1399         ARC-compliant cast.
1400         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1401         cast.
1402
1403 2019-02-21  Chris Dumez  <cdumez@apple.com>
1404
1405         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1406         https://bugs.webkit.org/show_bug.cgi?id=194481
1407
1408         Reviewed by Alex Christensen.
1409
1410         Give the processes a chance to shutdown and wait until we reached the expected number
1411         of processes.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1414
1415 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1416
1417         Fix the macOS build
1418
1419         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1420
1421 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1422
1423         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1424
1425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1426         I am a backwards.
1427
1428 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1429
1430         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1433         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1434         We could force on UI-side compositing, but I feel like the test might be more
1435         valuable exercising the normal path on each platform (though the original
1436         bug was also UI-side specific). Though we can't validate that the overlay
1437         layer was installed successfully, there are layout tests that do that.
1438
1439 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1440
1441         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1442         https://bugs.webkit.org/show_bug.cgi?id=194845
1443         <rdar://problem/47944579>
1444
1445         Reviewed by Antti Koivisto.
1446
1447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1449
1450 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1451
1452         [LFC][Floats] Add support for placing formatting roots in-between floats.
1453         https://bugs.webkit.org/show_bug.cgi?id=194902
1454
1455         Reviewed by Antti Koivisto.
1456
1457         * LayoutReloaded/misc/LFC-passing-tests.txt:
1458
1459 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1460
1461         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1462         https://bugs.webkit.org/show_bug.cgi?id=194901
1463
1464         Unreviewed build fix.
1465
1466         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1467         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1468         WPEBackend-fdo-0.1 as library name.
1469
1470 2019-02-21  Rob Buis  <rbuis@igalia.com>
1471
1472         Update MIME type parser
1473         https://bugs.webkit.org/show_bug.cgi?id=180526
1474
1475         Reviewed by Darin Adler.
1476
1477         Add tests involving leading and trailing whitespace, non-token
1478         characters and quoted strings.
1479
1480         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1481         (TestWebKitAPI::TEST):
1482
1483 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1484
1485         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1486         https://bugs.webkit.org/show_bug.cgi?id=194884
1487
1488         Reviewed by Michael Catanzaro.
1489
1490         * PlatformWin.cmake:
1491
1492 2019-02-20  Chris Dumez  <cdumez@apple.com>
1493
1494         Add API test for <rdar://problem/47471222>
1495         https://bugs.webkit.org/show_bug.cgi?id=194847
1496
1497         Reviewed by Alex Christensen.
1498
1499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1500
1501 2019-02-20  Chris Dumez  <cdumez@apple.com>
1502
1503         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1504         https://bugs.webkit.org/show_bug.cgi?id=194872
1505         <rdar://problem/47924500>
1506
1507         Reviewed by Alex Christensen.
1508
1509         Add API test coverage.
1510
1511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1512
1513 2019-02-20  Jer Noble  <jer.noble@apple.com>
1514
1515         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1516         https://bugs.webkit.org/show_bug.cgi?id=191332
1517
1518         Reviewed by Dean Jackson.
1519
1520         * Scripts/git-is-in-range: Added.
1521
1522 2019-02-20  Andy Estes  <aestes@apple.com>
1523
1524         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1525         https://bugs.webkit.org/show_bug.cgi?id=194869
1526
1527         Rubber-stamped by Jer Noble.
1528
1529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1530         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1531         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1532         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1534         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1535
1536 2019-02-20  Chris Dumez  <cdumez@apple.com>
1537
1538         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1539         https://bugs.webkit.org/show_bug.cgi?id=194857
1540         <rdar://problem/47759323>
1541
1542         Reviewed by Alex Christensen.
1543
1544         Add API test coverage.
1545
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1547
1548 2019-02-20  Chris Dumez  <cdumez@apple.com>
1549
1550         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1551         https://bugs.webkit.org/show_bug.cgi?id=194829
1552         <rdar://problem/47889906>
1553
1554         Reviewed by Alexey Proskuryakov.
1555
1556         Every time the TestOptions were changing we were creating both a new Web view and
1557         a new WKContext, which would start a new Network process. In most cases, we only
1558         need to contruct a new Web view and we do can keep reusing the same WKContext.
1559         This patch implements this optimization and thus avoids spinning a lot of new
1560         Network processes while running the layout tests.
1561
1562         * WebKitTestRunner/TestController.cpp:
1563         (WTR::TestController::generateContextConfiguration const):
1564         (WTR::TestController::generatePageConfiguration):
1565         (WTR::TestController::createWebViewWithOptions):
1566         (WTR::TestController::resetPreferencesToConsistentValues):
1567         (WTR::updateTestOptionsFromTestHeader):
1568         * WebKitTestRunner/TestController.h:
1569         * WebKitTestRunner/TestOptions.h:
1570         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1571         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1572         (WTR::TestOptions::hasSameInitializationOptions const):
1573         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1574         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1575         (WTR::TestController::platformAddTestOptions const):
1576
1577 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1578
1579         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1580         https://bugs.webkit.org/show_bug.cgi?id=167941
1581
1582         Reviewed by Carlos Garcia Campos.
1583
1584         * MiniBrowser/gtk/main.c:
1585         (filterSavedCallback): Added.
1586         (main): Support loading a JSON rule set file for content filtering.
1587         * MiniBrowser/wpe/main.cpp:
1588         (filterSavedCallback): Added.
1589         (main): Support loading a JSON rule set file for content filtering.
1590         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1591         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1592         (WTF::derefGPtr): Ditto.
1593         (testEmptyStore):
1594         (testSaveInvalidFilter):
1595         (testSaveLoadFilter):
1596         (testSavedFilterIdentifierMatch):
1597         (testRemoveFilter):
1598         (testSaveMultipleFilters):
1599         (testSaveFilterFromFile):
1600         (testFilterPersistence):
1601         (beforeAll):
1602         (afterAll):
1603         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1604         (removeOldInjectedContentAndResetLists): Also reset content filters.
1605         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1606         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1607         the element affected by the style sheet.
1608         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1609         and returns it to be used by tests.
1610         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1611         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1612         (serverCallback): Add support for serving a CSS style sheet for testing.
1613         (beforeAll): Add call to testUserContentManagerContentFilter().
1614         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1615
1616 2019-02-19  Keith Rollin  <krollin@apple.com>
1617
1618         Add timing information to build output
1619         https://bugs.webkit.org/show_bug.cgi?id=194839
1620         <rdar://problem/48219609>
1621
1622         Reviewed by Alexey Proskuryakov.
1623
1624         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1625         emit each project's build time to its output. E.g.,
1626
1627             ** BUILD SUCCEEDED ** [0.132 sec]
1628
1629         * Scripts/webkitdirs.pm:
1630         (XcodeOptions):
1631
1632 2019-02-19  Truitt Savell  <tsavell@apple.com>
1633
1634         Unreviewed, rolling out r241784.
1635
1636         Broke all OpenSource builds.
1637
1638         Reverted changeset:
1639
1640         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1641         instances view"
1642         https://bugs.webkit.org/show_bug.cgi?id=172848
1643         https://trac.webkit.org/changeset/241784
1644
1645 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1646
1647         [LFC][Floats] Remove redundant intersecting logic
1648         https://bugs.webkit.org/show_bug.cgi?id=194804
1649
1650         Reviewed by Antti Koivisto.
1651
1652         * LayoutReloaded/misc/LFC-passing-tests.txt:
1653
1654 2019-02-19  Dean Jackson  <dino@apple.com>
1655
1656         Clean-up output from generate-xcfilelists so it can be filtered
1657         https://bugs.webkit.org/show_bug.cgi?id=194795
1658
1659         Reviewed by Joseph Pecoraro (and Keith Rollin).
1660
1661         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1662         make a slight tweak to filter-build-webkit so such lines are marked
1663         as plain.
1664
1665         * Scripts/filter-build-webkit:
1666         * Scripts/generate-xcfilelists:
1667
1668 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1669
1670         pytest is not correctly auto-installed
1671         https://bugs.webkit.org/show_bug.cgi?id=194707
1672
1673         Reviewed by Carlos Garcia Campos.
1674
1675         * Scripts/webkitpy/thirdparty/__init__.py:
1676         (AutoinstallImportHook._install_pytest):
1677
1678 2019-02-18  Chris Dumez  <cdumez@apple.com>
1679
1680         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1681         https://bugs.webkit.org/show_bug.cgi?id=194797
1682         <rdar://problem/48055151>
1683
1684         Reviewed by Geoffrey Garen.
1685
1686         Add API test coverage.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1689
1690 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1691
1692         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1693         https://bugs.webkit.org/show_bug.cgi?id=194670
1694         <rdar://problem/39066529>
1695
1696         Reviewed by Tim Horton.
1697
1698         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1699         pasted in an editable area as attachment elements.
1700
1701         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1702         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1703         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1704         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1705         (TestWebKitAPI::TEST):
1706         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1707         (WTR::InjectedBundlePage::InjectedBundlePage):
1708
1709 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1710
1711         Fix API test after r241728
1712        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1713
1714         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1715         (TEST):
1716         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1717
1718 2019-02-18  Daniel Bates  <dabates@apple.com>
1719
1720         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1721         https://bugs.webkit.org/show_bug.cgi?id=192824
1722         <rdar://problem/47100332>
1723
1724         Reviewed by Wenson Hsieh.
1725
1726         Fix a bug where the wrong usage code was used for F13 thru F24.
1727
1728         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1729         (keyCodeForDOMFunctionKey):
1730
1731 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1732
1733         Bytecode cache should a have a boot-specific validation
1734         https://bugs.webkit.org/show_bug.cgi?id=194769
1735         <rdar://problem/48149509>
1736
1737         Reviewed by Keith Miller.
1738
1739         Add test for WTF::bootSessionUUIDString()
1740
1741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1742         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1743         (TEST):
1744
1745 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1746
1747         Disable safe browsing in WKWebView and remove its WKPreferences API
1748         https://bugs.webkit.org/show_bug.cgi?id=194723
1749         <rdar://problem/48122993>
1750
1751         Reviewed by Geoffrey Garen.
1752
1753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1754         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1755         (TEST):
1756         (safeBrowsingView):
1757         Make tests use SPI instead of API.
1758
1759 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1760
1761         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1762         https://bugs.webkit.org/show_bug.cgi?id=194586
1763
1764         Reviewed by Ross Kirsling.
1765
1766         * DumpRenderTree/win/DumpRenderTree.cpp:
1767         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1768         * Scripts/webkitpy/port/driver.py:
1769         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1770
1771 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1772
1773         Unreviewed, rolling out r241620.
1774
1775         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1776         (Requested by ddkilzer on #webkit.)
1777
1778         Reverted changeset:
1779
1780         "[WTF] Add environment variable helpers"
1781         https://bugs.webkit.org/show_bug.cgi?id=192405
1782         https://trac.webkit.org/changeset/241620
1783
1784 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1785
1786         [LFC] RenderImage's default intrinsic size is 0.
1787         https://bugs.webkit.org/show_bug.cgi?id=194745
1788
1789         Reviewed by Antti Koivisto.
1790
1791         * LayoutReloaded/misc/LFC-passing-tests.txt:
1792
1793 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1794
1795         [LFC][BFC] Add support for block replaced intrinsic width.
1796         https://bugs.webkit.org/show_bug.cgi?id=194705
1797
1798         Reviewed by Simon Fraser.
1799
1800         * LayoutReloaded/misc/LFC-passing-tests.txt:
1801
1802 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1803
1804         [LFC] Apply min/max width constraints to preferred width computation
1805         https://bugs.webkit.org/show_bug.cgi?id=194739
1806
1807         Reviewed by Simon Fraser.
1808
1809         * LayoutReloaded/misc/LFC-passing-tests.txt:
1810
1811 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1812
1813         [WTF] Add environment variable helpers
1814         https://bugs.webkit.org/show_bug.cgi?id=192405
1815
1816         Reviewed by Michael Catanzaro.
1817
1818         * DumpRenderTree/mac/DumpRenderTree.mm:
1819         (libraryPathForDumpRenderTree):
1820         * DumpRenderTree/win/DumpRenderTree.cpp:
1821         (libraryPathForDumpRenderTree):
1822         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1823         (setUpIOSLayoutTestCommunication):
1824         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1825         (beforeAll):
1826         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1827         (main):
1828         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1829         (WebKitTestBus::run):
1830         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1831         (WTR::getOutputDir):
1832         (WTR::initializeFontConfigSetting):
1833         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1834         (WTR::InjectedBundle::platformInitialize):
1835         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1836         (WTR::topLevelPath):
1837         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1838         (WTR::topLevelPath):
1839         (WTR::getOutputDir):
1840         (WTR::activateFonts):
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::libraryPathForTesting):
1843         (WTR::TestController::generateContextConfiguration const):
1844         (WTR::TestController::generatePageConfiguration):
1845         (WTR::TestController::decideDestinationWithSuggestedFilename):
1846         (WTR::TestController::platformAdjustContext):
1847         * WebKitTestRunner/TestController.h:
1848         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1849         (WTR::TestController::cocoaPlatformInitialize):
1850         (WTR::TestController::platformAdjustContext):
1851         * WebKitTestRunner/gtk/main.cpp:
1852         (main):
1853         * WebKitTestRunner/mac/TestControllerMac.mm:
1854         (WTR::TestController::configureContentExtensionForTest):
1855         * WebKitTestRunner/wpe/main.cpp:
1856         (main):
1857         Utilize WTF::Environment where possible.
1858
1859 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1860
1861         [iOS] WKWebView callout bar is missing Change Writing Direction item
1862         https://bugs.webkit.org/show_bug.cgi?id=190015
1863         <rdar://problem/44810366>
1864
1865         Reviewed by Tim Horton.
1866
1867         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1868         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1869
1870         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1871         (TestWebKitAPI::TEST):
1872
1873 2019-02-15  Chris Dumez  <cdumez@apple.com>
1874
1875         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1876         https://bugs.webkit.org/show_bug.cgi?id=194717
1877         <rdar://problem/47884404>
1878
1879         Reviewed by Brady Eidson.
1880
1881         Add API test coverage.
1882
1883         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1884
1885 2019-02-15  Youenn Fablet  <youenn@apple.com>
1886
1887         Make navigator.mediaDevices SecureContext
1888         https://bugs.webkit.org/show_bug.cgi?id=194666
1889
1890         Reviewed by Eric Carlson.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1893         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1894         (TEST_F):
1895
1896 2019-02-15  Brian Burg  <bburg@apple.com>
1897
1898         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1899         https://bugs.webkit.org/show_bug.cgi?id=194411
1900         <rdar://problem/47787614>
1901
1902         Reviewed by Joseph Pecoraro.
1903
1904         Remove unnecessary soft linking macro usage.
1905
1906         * DumpRenderTree/mac/TestRunnerMac.mm:
1907         (TestRunner::inspectorTestStubURL):
1908         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1909         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1910         (WTR::TestRunner::inspectorTestStubURL):
1911
1912 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1913
1914         Unreviewed, rolling out r241559 and r241566.
1915         https://bugs.webkit.org/show_bug.cgi?id=194710
1916
1917         Causes layout test crashes under GuardMalloc (Requested by
1918         ryanhaddad on #webkit).
1919
1920         Reverted changesets:
1921
1922         "[WTF] Add environment variable helpers"
1923         https://bugs.webkit.org/show_bug.cgi?id=192405
1924         https://trac.webkit.org/changeset/241559
1925
1926         "Unreviewed build fix for WinCairo Debug after r241559."
1927         https://trac.webkit.org/changeset/241566
1928
1929 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1930
1931         [LFC] Out-of-flow box is never a float box
1932         https://bugs.webkit.org/show_bug.cgi?id=194704
1933
1934         Reviewed by Antti Koivisto.
1935
1936         * LayoutReloaded/misc/LFC-passing-tests.txt:
1937
1938 2019-02-10  Darin Adler  <darin@apple.com>
1939
1940         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1941         https://bugs.webkit.org/show_bug.cgi?id=194487
1942
1943         Reviewed by Daniel Bates.
1944
1945         * DumpRenderTree/win/DumpRenderTree.cpp:
1946         (applicationId): Use makeString instead of String::format.
1947         (main): Ditto.
1948         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1949         (TestWebKitAPI::Util::createURLForResource): Ditto.
1950         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1951         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1952
1953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1954         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1955         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1956         (WTR::createStringWithAttributes): Use appendLiteral.
1957         (WTR::AccessibilityUIElement::helpText const): Ditto.
1958         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1959         directly instead of using String::format.
1960         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1961         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1962
1963 2019-02-15  Truitt Savell  <tsavell@apple.com>
1964
1965         Unreviewed, rolling out r241564.
1966
1967         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1968
1969         Reverted changeset:
1970
1971         "[Mac] WebInspectorUI.framework does not need to be soft-
1972         linked anymore"
1973         https://bugs.webkit.org/show_bug.cgi?id=194411
1974         https://trac.webkit.org/changeset/241564
1975
1976 2019-02-15  Saam barati  <sbarati@apple.com>
1977
1978         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1979         https://bugs.webkit.org/show_bug.cgi?id=194036
1980
1981         Reviewed by Yusuke Suzuki.
1982
1983         * Scripts/run-jsc-stress-tests:
1984
1985 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1986
1987         Fix the build.
1988
1989         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1990         (WTR::UIScriptController::drawSquareInEditableImage):
1991         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1992         (TestWebKitAPI::drawSquareInEditableImage):
1993
1994 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1995
1996         Fix the build.
1997
1998         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1999         (WTR::UIScriptController::drawSquareInEditableImage):
2000         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2001         (TestWebKitAPI::drawSquareInEditableImage):
2002
2003 2019-02-14  Brian Burg  <bburg@apple.com>
2004
2005         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2006         https://bugs.webkit.org/show_bug.cgi?id=194411
2007         <rdar://problem/47787614>
2008
2009         Reviewed by Joseph Pecoraro.
2010
2011         Remove unnecessary soft linking macro usage.
2012
2013         * DumpRenderTree/mac/TestRunnerMac.mm:
2014         (TestRunner::inspectorTestStubURL):
2015         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2016         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2017         (WTR::TestRunner::inspectorTestStubURL):
2018
2019 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2020
2021         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2022         https://bugs.webkit.org/show_bug.cgi?id=194599
2023
2024         Reviewed by Lucas Forschler.
2025
2026         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2027         (StatusBubble._build_bubble):
2028
2029 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews-app] Set Foreign Key in Django build model
2032         https://bugs.webkit.org/show_bug.cgi?id=194667
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/ews-app/ews/models/build.py:
2037         (Build):
2038
2039 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2040
2041         [WTF] Add environment variable helpers
2042         https://bugs.webkit.org/show_bug.cgi?id=192405
2043
2044         Reviewed by Michael Catanzaro.
2045
2046         * DumpRenderTree/mac/DumpRenderTree.mm:
2047         (libraryPathForDumpRenderTree):
2048         * DumpRenderTree/win/DumpRenderTree.cpp:
2049         (libraryPathForDumpRenderTree):
2050         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2051         (setUpIOSLayoutTestCommunication):
2052         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2053         (TestWebKitAPI::strip):
2054         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2055         (beforeAll):
2056         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2057         (main):
2058         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2059         (WebKitTestBus::run):
2060         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2061         (WTR::getOutputDir):
2062         (WTR::initializeFontConfigSetting):
2063         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2064         (WTR::InjectedBundle::platformInitialize):
2065         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2066         (WTR::topLevelPath):
2067         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2068         (WTR::topLevelPath):
2069         (WTR::getOutputDir):
2070         (WTR::activateFonts):
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::libraryPathForTesting):
2073         (WTR::TestController::generateContextConfiguration const):
2074         (WTR::TestController::generatePageConfiguration):
2075         (WTR::TestController::decideDestinationWithSuggestedFilename):
2076         (WTR::TestController::platformAdjustContext):
2077         * WebKitTestRunner/TestController.h:
2078         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2079         (WTR::TestController::cocoaPlatformInitialize):
2080         (WTR::TestController::platformAdjustContext):
2081         * WebKitTestRunner/gtk/main.cpp:
2082         (main):
2083         * WebKitTestRunner/mac/TestControllerMac.mm:
2084         (WTR::TestController::configureContentExtensionForTest):
2085         * WebKitTestRunner/wpe/main.cpp:
2086         (main):
2087         Utilize WTF::Environment where possible.
2088
2089 2019-02-14  Chris Dumez  <cdumez@apple.com>
2090
2091         [PSON] Introduce a WebContent Process cache
2092         https://bugs.webkit.org/show_bug.cgi?id=194594
2093         <rdar://problem/46793397>
2094
2095         Reviewed by Geoff Garen.
2096
2097         Update API tests to turn on the WebContent Process cache.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2100
2101 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2102
2103         Unreviewed, build fix after r241480
2104
2105         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2106         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2107         (-[DragAndDropSimulator initWithWebView:]):
2108
2109 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2110
2111         AX: ARIA Reflection was disabled in error
2112         https://bugs.webkit.org/show_bug.cgi?id=194647
2113         <rdar://problem/48068336>
2114
2115         Reviewed by Ryosuke Niwa.
2116
2117         Remove test override now that this feature should be enabled by default.
2118
2119         * WebKitTestRunner/TestController.cpp:
2120         (WTR::TestController::resetPreferencesToConsistentValues):
2121
2122 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2123
2124         Unreviewed, rolling out r241486.
2125         https://bugs.webkit.org/show_bug.cgi?id=194655
2126
2127         causing API failures in builds (Requested by ShawnRoberts on
2128         #webkit).
2129
2130         Reverted changeset:
2131
2132         "[Cocoa] Media elements will restart network buffering just
2133         before suspending"
2134         https://bugs.webkit.org/show_bug.cgi?id=193691
2135         https://trac.webkit.org/changeset/241486
2136
2137 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2138
2139         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2140         https://bugs.webkit.org/show_bug.cgi?id=194622
2141
2142         Reviewed by Antti Koivisto.
2143
2144         * LayoutReloaded/misc/LFC-passing-tests.txt:
2145
2146 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2147
2148         [LFC] Shrink-to-fit-width should be constrained by min/max width
2149         https://bugs.webkit.org/show_bug.cgi?id=194653
2150
2151         Reviewed by Antti Koivisto.
2152
2153         * LayoutReloaded/misc/LFC-passing-tests.txt:
2154
2155 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2156
2157         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2158         https://bugs.webkit.org/show_bug.cgi?id=194641
2159
2160         Reviewed by Geoffrey Garen.
2161
2162         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2163         so that the test would fail without this fix.
2164
2165         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2166         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2167
2168 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2169
2170         [ews-app] Change log level for a log statement
2171
2172         Unreviewed minor fix.
2173
2174         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2175         (Patch.save_patch):
2176
2177 2019-02-13  Jer Noble  <jer.noble@apple.com>
2178
2179         [Cocoa] Media elements will restart network buffering just before suspending
2180         https://bugs.webkit.org/show_bug.cgi?id=193691
2181
2182         Reviewed by Eric Carlson.
2183
2184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2186         (TEST):
2187
2188 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2189
2190         [ews-app] Fetch builder id to name mapping
2191         https://bugs.webkit.org/show_bug.cgi?id=194355
2192
2193         Reviewed by Lucas Forschler.
2194
2195         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2196         (Buildbot.get_builder_id_to_name_mapping):
2197         (Buildbot._get_display_name_from_builder_name):
2198
2199 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2200
2201         Further restricting webarchive loads
2202         https://bugs.webkit.org/show_bug.cgi?id=194567
2203         <rdar://problem/47610130>
2204
2205         Reviewed by Youenn Fablet.
2206
2207         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2208         navigations on drop.
2209
2210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2211         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2212         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2213         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2214         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2215         (TestWebKitAPI::TEST):
2216         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2217         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2218         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2219         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2220         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2221         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2222         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2223
2224 2019-02-13  John Wilander  <wilander@apple.com>
2225
2226         Store Ad Click Attribution requests in the network process
2227         https://bugs.webkit.org/show_bug.cgi?id=194510
2228         <rdar://problem/47650118>
2229
2230         Reviewed by Alex Christensen and Daniel Bates.
2231
2232         This patch adds two TestRunner functions:
2233         - dumpAdClickAttribution()
2234         - clearAdClickAttribution()
2235
2236         They call into the network process to dump and clear Ad Click
2237         Attribution state, respectively.
2238
2239         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2240         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2241         (WTR::TestRunner::dumpAdClickAttribution):
2242         (WTR::TestRunner::clearAdClickAttribution):
2243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::resetStateToConsistentValues):
2246         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2247         (WTR::adClickAttributionStringResultCallback):
2248         (WTR::TestController::dumpAdClickAttribution):
2249         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2250         (WTR::adClickAttributionVoidCallback):
2251         (WTR::TestController::clearAdClickAttribution):
2252         * WebKitTestRunner/TestController.h:
2253         * WebKitTestRunner/TestInvocation.cpp:
2254         (WTR::TestInvocation::dumpResults):
2255         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2256         (WTR::TestInvocation::dumpAdClickAttribution):
2257         * WebKitTestRunner/TestInvocation.h:
2258
2259 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2260
2261         [ews-app] Generate status-bubble
2262         https://bugs.webkit.org/show_bug.cgi?id=194572
2263
2264         Reviewed by Lucas Forschler.
2265
2266         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2267         (StatusBubble._build_bubble):
2268         (StatusBubble._should_show_bubble_for):
2269         (StatusBubble._build_bubbles_for_patch):
2270
2271 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2272
2273         [ews-app] Add status bubble html template
2274         https://bugs.webkit.org/show_bug.cgi?id=194571
2275
2276         Reviewed by Lucas Forschler.
2277
2278         * BuildSlaveSupport/ews-app/ews/templates: Added.
2279         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2280
2281 2019-02-12  Chris Dumez  <cdumez@apple.com>
2282
2283         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2284         https://bugs.webkit.org/show_bug.cgi?id=194568
2285         <rdar://problem/47944490>
2286
2287         Reviewed by Ryosuke Niwa.
2288
2289         Add API test coverage.
2290
2291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2292         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2293
2294 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2295
2296         webkitpy: Remove bug_dummy from parsed test expectations
2297         https://bugs.webkit.org/show_bug.cgi?id=194562
2298         <rdar://problem/47853999>
2299
2300         Reviewed by Lucas Forschler.
2301
2302         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2303         (TestExpectationParser):
2304         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2305         skipped tests.
2306         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2307
2308 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-app] Add method to fetch patch
2311         https://bugs.webkit.org/show_bug.cgi?id=194518
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2316         (Patch.get_patch):
2317
2318 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2319
2320         [LFC] Expand tests coverage (60 new tests -> 860)
2321
2322         Unreviewed test gardening (run-singly, --child-processes=1).
2323
2324         * LayoutReloaded/misc/LFC-passing-tests.txt:
2325
2326 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2327
2328         Allow pages to trigger programmatic paste from script on iOS
2329         https://bugs.webkit.org/show_bug.cgi?id=194271
2330         <rdar://problem/47808810>
2331
2332         Reviewed by Tim Horton.
2333
2334         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2335
2336         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2337         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2338         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2339         (WTR::UIScriptController::rectForMenuAction const):
2340
2341         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2342         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2343         for when the menu is shown or hidden.
2344
2345         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2346         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2347         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2348         (WTR::UIScriptController::setDidShowMenuCallback):
2349         (WTR::UIScriptController::didShowMenuCallback const):
2350         (WTR::UIScriptController::setDidHideMenuCallback):
2351         (WTR::UIScriptController::didHideMenuCallback const):
2352         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2353         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2354         (WTR::UIScriptController::rectForMenuAction const):
2355         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2356         * WebKitTestRunner/TestController.cpp:
2357         (WTR::TestController::resetPreferencesToConsistentValues):
2358         (WTR::updateTestOptionsFromTestHeader):
2359         * WebKitTestRunner/TestOptions.h:
2360
2361         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2362         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2363
2364         (WTR::TestOptions::hasSameInitializationOptions const):
2365         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2366         (WTR::UIScriptController::calendarType const):
2367         (WTR::UIScriptController::platformUndoManager const):
2368         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2369         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2370         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2371         (-[TestRunnerWKWebView dealloc]):
2372         (-[TestRunnerWKWebView _didShowMenu]):
2373         (-[TestRunnerWKWebView _didHideMenu]):
2374
2375         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2376
2377         * WebKitTestRunner/ios/TestControllerIOS.mm:
2378         (WTR::handleMenuWillHideNotification):
2379         (WTR::handleMenuDidHideNotification):
2380         (WTR::TestController::platformInitialize):
2381         (WTR::TestController::platformDestroy):
2382         (WTR::TestController::platformResetStateToConsistentValues):
2383
2384         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2385         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2386
2387         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2388         (WTR::forEachViewInHierarchy):
2389         (WTR::findViewInHierarchyOfType):
2390
2391         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2392         functions that dig through a given view's hierarchy in search of a view of a given class.
2393
2394         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2395         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2396         (WTR::UIScriptController::selectionCaretViewRect const):
2397         (WTR::UIScriptController::selectionRangeViewRects const):
2398         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2399         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2400
2401         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2402
2403         (WTR::UIScriptController::rectForMenuAction const):
2404
2405         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2406         callout bar) whose label matches the given string.
2407
2408         (WTR::UIScriptController::platformContentView const):
2409
2410         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2411         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2412         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2413
2414         (WTR::UIScriptController::platformUndoManager const): Deleted.
2415         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2416         (WTR::UIScriptController::platformContentView const):
2417         (WTR::UIScriptController::platformUndoManager const): Deleted.
2418
2419 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2420
2421         webkitpy: No option to only show unexpected failures in results.html for iPad
2422         https://bugs.webkit.org/show_bug.cgi?id=194554
2423         <rdar://problem/47922442>
2424
2425         Rubber-stamped by Aakash Jain.
2426
2427         Just because a TestExpecations file does not exist for a specific platform does not mean that
2428         TestExpecations are not being used, given that platforms inherit test expectations.
2429
2430         * Scripts/webkitpy/port/base.py:
2431         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2432         * Scripts/webkitpy/port/base_unittest.py:
2433         (PortTest.test_uses_test_expectations_file):
2434
2435 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2436
2437         Remove setDefersLoading infrastructure from WebKit2
2438         https://bugs.webkit.org/show_bug.cgi?id=194506
2439
2440         Reviewed by Brady Eidson.
2441
2442         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2444         (WTR::TestRunner::setDefersLoading): Deleted.
2445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2446
2447 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2448
2449         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2450         https://bugs.webkit.org/show_bug.cgi?id=194522
2451         <rdar://problem/47789393>
2452
2453         Reviewed by Chris Dumez.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2457         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2458         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2459
2460 2019-02-12  Andy Estes  <aestes@apple.com>
2461
2462         [iOSMac] Enable Parental Controls Content Filtering
2463         https://bugs.webkit.org/show_bug.cgi?id=194521
2464         <rdar://39732376>
2465
2466         Reviewed by Tim Horton.
2467
2468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2469
2470 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2471
2472         [LFC][IFC] Add intrinsic width support for float boxes.
2473         https://bugs.webkit.org/show_bug.cgi?id=194528
2474
2475         Reviewed by Antti Koivisto.
2476
2477         Expand tests coverage (2 new tests -> 800).
2478         (This is the correct test ordering --runs-singly --child-processes=1)
2479
2480         * LayoutReloaded/misc/LFC-passing-tests.txt:
2481
2482 2019-02-12  Rob Buis  <rbuis@igalia.com>
2483
2484         Implement serializing in MIME type parser
2485         https://bugs.webkit.org/show_bug.cgi?id=193909
2486
2487         Reviewed by Darin Adler.
2488
2489         Add various tests involving upper case, non-ASCII, control/null characters,
2490         various HTTP whitespace, single quotes and an unpaired surrogate.
2491
2492         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2493         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2494         (TestWebKitAPI::serializeIfValid):
2495         (TestWebKitAPI::TEST):
2496
2497 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2498
2499         [Cocoa] Ask platform for generic font family mappings
2500         https://bugs.webkit.org/show_bug.cgi?id=187723
2501         <rdar://problem/41892438>
2502
2503         Reviewed by Brent Fulgham.
2504
2505         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2506
2507         * DumpRenderTree/mac/DumpRenderTree.mm:
2508         (allowedFontFamilySet):
2509         * WebKitTestRunner/mac/TestControllerMac.mm:
2510         (WTR::allowedFontFamilySet):
2511
2512 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2513
2514         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2515         https://bugs.webkit.org/show_bug.cgi?id=193622
2516
2517         Reviewed by Michael Catanzaro.
2518
2519         This adds support for loading content extension rule sets from the JSON files which
2520         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2521         of WKTR for this could be removed, but that is left for a follow-up patch with
2522         cleanups.
2523
2524         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2525         * WebKitTestRunner/TestController.cpp:
2526         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2527         avoid having the null-terminator copied into the result.
2528         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2529         part of the preparations to run a test.
2530         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2531         (WTR::contentExtensionStoreCallback): Added.
2532         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2533         used for content extensions test.
2534         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2535         extensions and compiling the JSON rule set for tests involving content extensions.
2536         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2537         testing and disables content extensions.
2538         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2539         resetContentExtensions().
2540         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2541         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2542         configureContentExtensionForTest(), and userContentController().
2543
2544 2019-02-11  Daniel Bates  <dabates@apple.com>
2545
2546         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2547         https://bugs.webkit.org/show_bug.cgi?id=191446
2548         <rdar://problem/45929460>
2549
2550         Reviewed by Tim Horton.
2551
2552         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2553
2554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2555         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2556         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2557         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2559         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2560         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2561         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2562         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2563         (WTR::arrayLength):
2564         (WTR::parseModifierArray):
2565         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2566         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2567         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2568         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2569
2570 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2571
2572         Unreviewed, rolling out r241272 and r241276.
2573         https://bugs.webkit.org/show_bug.cgi?id=194514
2574
2575         Broke the Apple Internal build and the fix requires human
2576         intervention :( (Requested by dydz on #webkit).
2577
2578         Reverted changesets:
2579
2580         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2581         https://bugs.webkit.org/show_bug.cgi?id=191446
2582         https://trac.webkit.org/changeset/241272
2583
2584         "Fix internal iOS build after r241272"
2585         https://bugs.webkit.org/show_bug.cgi?id=191446
2586         https://trac.webkit.org/changeset/241276
2587
2588 2019-02-11  Truitt Savell  <tsavell@apple.com>
2589
2590         Unreviewed, rolling out r241269.
2591
2592         Caused 5 layout tests crashes on Mac WK1
2593
2594         Reverted changeset:
2595
2596         "DumpRenderTree should report unknown options"
2597         https://bugs.webkit.org/show_bug.cgi?id=191303
2598         https://trac.webkit.org/changeset/241269
2599
2600 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2601
2602         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2603         https://bugs.webkit.org/show_bug.cgi?id=194313
2604
2605         Reviewed by Tim Horton.
2606
2607         Add a helper to determine whether the web view is presenting modal UI.
2608
2609         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2610         (WTR::UIScriptController::isPresentingModally const):
2611         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2612         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2613         (WTR::UIScriptController::isPresentingModally const):
2614         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2615         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2616         (WTR::UIScriptController::calendarType const): Deleted.
2617         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2618         (WTR::UIScriptController::isPresentingModally const):
2619         (WTR::UIScriptController::calendarType const):
2620         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2621         (WTR::UIScriptController::calendarType const):
2622
2623 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2624
2625         GCHeapInspector: Show the retained sizes in more places
2626         https://bugs.webkit.org/show_bug.cgi?id=194464
2627
2628         Reviewed by Simon Fraser.
2629
2630         * GCHeapInspector/gc-heap-inspector.html:
2631         * GCHeapInspector/script/interface.js:
2632         (HeapInspectorUtils.humanReadableSize):
2633         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2634         (HeapInspectorUtils.spanForNode.span.span):
2635         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2636         (HeapSnapshotInspector.prototype.buildRoots):
2637
2638 2019-02-11  Daniel Bates  <dabates@apple.com>
2639
2640         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2641         https://bugs.webkit.org/show_bug.cgi?id=191446
2642         <rdar://problem/45929460>
2643
2644         Reviewed by Tim Horton.
2645
2646         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2647
2648         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2649         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2650         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2651         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2652         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2653         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2654         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2655         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2656         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2657         (WTR::arrayLength):
2658         (WTR::parseModifierArray):
2659         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2660         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2661         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2662         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2663
2664 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2665
2666         DumpRenderTree should report unknown options
2667         https://bugs.webkit.org/show_bug.cgi?id=191303
2668
2669         Reviewed by Frédéric Wang.
2670
2671         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2672         to report unknown options.
2673         Added and assigned test options which are currently used in tests.
2674
2675         * DumpRenderTree/TestOptions.cpp:
2676         (TestOptions::TestOptions):
2677
2678 2019-02-11  Truitt Savell  <tsavell@apple.com>
2679
2680         Unreviewed, rolling out r241229.
2681
2682         Revision broke internal builds for watchOS.
2683
2684         Reverted changeset:
2685
2686         "[Cocoa] Ask platform for generic font family mappings"
2687         https://bugs.webkit.org/show_bug.cgi?id=187723
2688         https://trac.webkit.org/changeset/241229
2689
2690 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2691
2692         [WinCairo][MiniBrowser] Basic authentication always fails.
2693         https://bugs.webkit.org/show_bug.cgi?id=194496
2694
2695         Reviewed by Don Olmstead.
2696
2697         * MiniBrowser/win/DialogHelper.h:
2698         (Dialog::getText):
2699
2700 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2701
2702         [GStreamer] GstMappedBuffer testsuite build fails
2703         https://bugs.webkit.org/show_bug.cgi?id=194495
2704
2705         Reviewed by Carlos Garcia Campos.
2706
2707         Fix the build by explicitely adding the gstreamer1.0-audio include
2708         directories to the include path.
2709
2710         * TestWebKitAPI/PlatformGTK.cmake:
2711         * TestWebKitAPI/PlatformWPE.cmake:
2712
2713 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2714
2715         [GTK][WPE] Add enable-javascript-markup setting
2716         https://bugs.webkit.org/show_bug.cgi?id=193439
2717
2718         Reviewed by Michael Catanzaro.
2719
2720         Add test cases to check the new setting.
2721
2722         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2723         (testWebKitSettings):
2724         (testWebKitSettingsJavaScriptMarkup):
2725         (beforeAll):
2726
2727 2019-02-10  Darin Adler  <darin@apple.com>
2728
2729         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2730         https://bugs.webkit.org/show_bug.cgi?id=194485
2731
2732         Reviewed by Daniel Bates.
2733
2734         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2735
2736 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2737
2738         Add more tests for clampTo<>()
2739         https://bugs.webkit.org/show_bug.cgi?id=194462
2740
2741         Reviewed by Geoffrey Garen.
2742
2743         Darin suggested to test the very last floating point number
2744         at the boundaries when truncating to integer.
2745         I added test for max/min and max-1/min-1.
2746
2747         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2748         (TestWebKitAPI::TEST):
2749
2750 2019-02-09  Darin Adler  <darin@apple.com>
2751
2752         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2753         https://bugs.webkit.org/show_bug.cgi?id=194021
2754
2755         Reviewed by Geoffrey Garen.
2756
2757         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2758         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2759         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2760
2761 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2762
2763         [LFC][IFC] Add intrinsic width support for basic inline containers
2764         https://bugs.webkit.org/show_bug.cgi?id=194473
2765
2766         Reviewed by Antti Koivisto.
2767
2768         Expand tests coverage (11 new tests -> 798)
2769
2770         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2771
2772 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2773
2774         Fix MiniBrowser's entitlements
2775         https://bugs.webkit.org/show_bug.cgi?id=192431
2776
2777         Reviewed by Joseph Pecoraro.
2778
2779         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2780         files, making it impossible to load any extension.
2781
2782         * MiniBrowser/MiniBrowser.entitlements:
2783
2784 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2785
2786         [Cocoa] Ask platform for generic font family mappings
2787         https://bugs.webkit.org/show_bug.cgi?id=187723
2788         <rdar://problem/41892438>
2789
2790         Reviewed by Brent Fulgham.
2791
2792         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2793
2794         * DumpRenderTree/mac/DumpRenderTree.mm:
2795         (allowedFontFamilySet):
2796         * WebKitTestRunner/mac/TestControllerMac.mm:
2797         (WTR::allowedFontFamilySet):
2798
2799 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2800
2801         [GTK] Implement back/forward touchpad gesture
2802         https://bugs.webkit.org/show_bug.cgi?id=193919
2803
2804         Reviewed by Michael Catanzaro.
2805
2806         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2807         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2808
2809 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2810
2811         Add SPI to use networking daemon instead of XPC service
2812         https://bugs.webkit.org/show_bug.cgi?id=194427
2813
2814         Reviewed by Geoffrey Garen
2815
2816         * MiniBrowser/MiniBrowser.entitlements:
2817
2818 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2819
2820         [ews-build] Ensure that every builder in config.json has short name
2821         https://bugs.webkit.org/show_bug.cgi?id=194461
2822
2823         Reviewed by Lucas Forschler.
2824
2825         * BuildSlaveSupport/ews-build/loadConfig.py:
2826         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2827
2828 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2829
2830         [ews-build] Add short name to config.json
2831         https://bugs.webkit.org/show_bug.cgi?id=194456
2832
2833         Reviewed by Lucas Forschler.
2834
2835         * BuildSlaveSupport/ews-build/config.json: Added short name.
2836         * BuildSlaveSupport/ews-build/loadConfig.py:
2837         (loadBuilderConfig): Set the short name as the builder description.
2838
2839 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2840
2841         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2842         https://bugs.webkit.org/show_bug.cgi?id=194418
2843
2844         Reviewed by Lucas Forschler.
2845
2846         Do not include errors trying when finding crashlogs at the end of
2847         a run-webkit-tests run since we don't process those errors.
2848
2849         * Scripts/webkitpy/port/darwin.py:
2850         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2851         * Scripts/webkitpy/port/ios_device.py:
2852         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2853         * Scripts/webkitpy/port/watch_device.py:
2854         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2855
2856 2019-02-08  Beth Dakin  <bdakin@apple.com>
2857
2858         Add afterScreenUpdates to WKSnapshotConfiguration
2859         https://bugs.webkit.org/show_bug.cgi?id=194362
2860         -and corresponding-
2861         <rdar://problem/40655528> Please add an "after screen updates" property to 
2862         WKSnapshotConfiguration (to solve blank snapshots)
2863
2864         Reviewed by Tim Horton.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2867         (TEST):
2868
2869 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2870
2871         clampTo(): do not convert the input to double when dealing with integers
2872         https://bugs.webkit.org/show_bug.cgi?id=194263
2873         <rdar://problem/47692312>
2874
2875         Reviewed by Darin Adler.
2876
2877         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2878         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2879         (TestWebKitAPI::testClampFloatingPointToInteger):
2880         (TestWebKitAPI::testClampSameSignIntegers):
2881         (TestWebKitAPI::testClampUnsignedToSigned):
2882         (TestWebKitAPI::testClampSignedToUnsigned):
2883
2884 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2885
2886         webkitpy: Respect --dedicated-simulators flag
2887         https://bugs.webkit.org/show_bug.cgi?id=194416
2888         <rdar://problem/47894722>
2889
2890         Reviewed by Lucas Forschler.
2891
2892         * Scripts/webkitpy/port/device_port.py:
2893         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2894         available devices can be safely ignored.
2895
2896 2019-02-07  Keith Rollin  <krollin@apple.com>
2897
2898         Remove extra copy of 100x100-red.tga
2899         https://bugs.webkit.org/show_bug.cgi?id=194371
2900         <rdar://problem/47873465>
2901
2902         Reviewed by Said Abou-Hallawa.
2903
2904         In order to help it pass its tests, Bug 194190 added a second copy of
2905         the file 100x100-red.tga. However, it turns out that this additional
2906         file wasn't actually needed, and that that sole previous copy was
2907         sufficient. At the same time, this second copy -- which was copied to
2908         the same location in the build output as the first copy -- now caused
2909         XCBuild to complain because there were two production rules for the
2910         same output file. Address this by removing the newly-added extra copy.
2911
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2914
2915 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2916
2917         Deprecate WKBundlePageSetDefersLoading
2918         https://bugs.webkit.org/show_bug.cgi?id=191394
2919
2920         Reviewed by Dean Jackson.
2921
2922         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2923         (WTR::TestRunner::setDefersLoading):
2924
2925 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2926
2927         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2928         https://bugs.webkit.org/show_bug.cgi?id=194391
2929
2930         Reviewed by Antti Koivisto.
2931
2932         * LayoutReloaded/misc/LFC-passing-tests.txt:
2933
2934 2019-02-06  Keith Rollin  <krollin@apple.com>
2935
2936         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2937         https://bugs.webkit.org/show_bug.cgi?id=193975
2938         <rdar://problem/47643306>
2939
2940         Reviewed by Tim Horton.
2941
2942         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2943         the Info.plist file into the bundle. This step is not necessary as the
2944         implicit "bundle up all the build products into a framework" build
2945         phase does this already. Having the Copy Bundle Resources phase do
2946         this causes a conflict under XCBuild, which objects to two build
2947         phases producing the same file (Info.plist). Address this by removing
2948         Info.plist from the Copy Bundle Resources phase.
2949
2950         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2951
2952 2019-02-06  Keith Rollin  <krollin@apple.com>
2953
2954         Really enable the automatic checking and regenerations of .xcfilelists during builds
2955         https://bugs.webkit.org/show_bug.cgi?id=194357
2956         <rdar://problem/47861231>
2957
2958         Reviewed by Chris Dumez.
2959
2960         Bug 194124 was supposed to enable the automatic checking and
2961         regenerating of .xcfilelist files during the build. While related
2962         changes were included in that patch, the change to actually enable the
2963         operation somehow was omitted. This patch actually enables the
2964         operation. The check-xcfilelist.sh scripts now check
2965         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2966         from the checking.
2967
2968         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2969         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2970
2971 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2972
2973         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2974         <https://webkit.org/b/194286>
2975         <rdar://problem/47815558>
2976
2977         Reviewed by Alexey Proskuryakov.
2978
2979         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2980         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2981         WKRetainPtr<> to avoid leaking the WKDataRef.
2982
2983 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2984
2985         Unreviewed, fix a typo
2986
2987         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2988
2989 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2990
2991         [GTK][WPE] force libpsl build to use ICU in jhbuild
2992         https://bugs.webkit.org/show_bug.cgi?id=194288
2993
2994         Reviewed by Carlos Garcia Campos.
2995
2996         * gtk/jhbuild.modules:
2997         Require ICU for libpsl build in jhbuild, like done in WPE.
2998
2999 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3000
3001         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3002         https://bugs.webkit.org/show_bug.cgi?id=194209
3003
3004         Reviewed by Carlos Garcia Campos.
3005
3006         Enhance TestCookieManager to ensure this doesn't happen again.
3007
3008         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3009         (testCookieManagerPersistentStorage):
3010         (beforeAll):
3011
3012 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3013
3014         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3015         https://bugs.webkit.org/show_bug.cgi?id=194324
3016
3017         Reviewed by Andy Estes.
3018
3019         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3020         part of the name is already implicit, since this is in testing code in TestOptions.
3021
3022         * WebKitTestRunner/TestController.cpp:
3023         (WTR::TestController::generateContextConfiguration const):
3024         (WTR::updateTestOptionsFromTestHeader):
3025         * WebKitTestRunner/TestOptions.h:
3026         (WTR::TestOptions::hasSameInitializationOptions const):
3027
3028 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-build] Allow * as platform for builders and workers
3031         https://bugs.webkit.org/show_bug.cgi?id=188533
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-build/loadConfig.py:
3036         (checkWorkersAndBuildersForConsistency):
3037
3038 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3039
3040         [ews-build] Add few bots to config.json
3041         https://bugs.webkit.org/show_bug.cgi?id=194304
3042
3043         Reviewed by Lucas Forschler.
3044
3045         * BuildSlaveSupport/ews-build/config.json:
3046
3047 2019-02-05  Keith Rollin  <krollin@apple.com>
3048
3049         Enable the automatic checking and regenerations of .xcfilelists during builds
3050         https://bugs.webkit.org/show_bug.cgi?id=194124
3051         <rdar://problem/47721277>
3052
3053         Reviewed by Tim Horton.
3054
3055         Bug 193790 add a facility for checking -- during build time -- that
3056         any needed .xcfilelist files are up-to-date and for updating them if
3057         they are not. This facility was initially opt-in by setting
3058         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3059         the process seemed robust. Its now time to enable this facility and
3060         make it opt-out. If there is a need to disable this facility, set and
3061         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3062         running `make` or `build-webkit`, or before running Xcode from the
3063         command line.
3064
3065         Additionally, remove the step that generates a list of source files
3066         going into the UnifiedSources build step. It's only necessarily to
3067         specify Sources.txt and SourcesCocoa.txt as inputs.
3068
3069         * Scripts/generate-xcfilelists:
3070
3071 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3072
3073         [GTK][WPE] force libpsl build to use ICU in jhbuild
3074         https://bugs.webkit.org/show_bug.cgi?id=194288
3075
3076         Reviewed by Philippe Normand.
3077
3078         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3079         This can cause build failures if libidn is detected but libunistring is not available.
3080
3081         Make sure that ICU is used for runtime and builtin PSL data.
3082
3083         * gtk/jhbuild.modules:
3084         * wpe/jhbuild.modules:
3085
3086 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3087
3088         [ews-app] Modified timestamp should be updated on updating data
3089         https://bugs.webkit.org/show_bug.cgi?id=194295
3090
3091         Reviewed by Lucas Forschler.
3092
3093         * BuildSlaveSupport/ews-app/ews/models/build.py:
3094         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3095         * BuildSlaveSupport/ews-app/ews/models/step.py:
3096
3097 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3098
3099         Unreviewed, rolling out r240742.
3100
3101         Causes crashes on iOS simulator.
3102
3103         Reverted changeset:
3104
3105         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3106         not focused in a content-editable element"
3107         https://bugs.webkit.org/show_bug.cgi?id=192824
3108         https://trac.webkit.org/changeset/240742
3109
3110 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3111
3112         run-webkit-tests emits message "...running None" when running tests
3113         https://bugs.webkit.org/show_bug.cgi?id=194133
3114         <rdar://problem/47724738>
3115
3116         Reviewed by Lucas Forschler.
3117
3118         * Scripts/webkitpy/xcode/device_type.py:
3119         (DeviceType.__str__): Use both version mapping tables and use just the variant
3120         name if no version name is available.
3121         * Scripts/webkitpy/xcode/device_type_unittest.py:
3122         (DeviceTypeTest):
3123         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3124         an associated named.
3125
3126 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3127
3128         [WPE] require python3-setuptools for meson build in jhbuild
3129         https://bugs.webkit.org/show_bug.cgi?id=194287
3130
3131         Reviewed by Philippe Normand.
3132
3133         python3-setuptools is needed to build meson in jhbuild.
3134         It is already required by the GTK port.
3135
3136         * wpe/install-dependencies:
3137
3138 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [ews-app] Add method to save BuilderMapping to database
3141         https://bugs.webkit.org/show_bug.cgi?id=194264
3142
3143         Reviewed by Lucas Forschler.
3144
3145         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3146         (BuilderMapping.__str__):
3147         (BuilderMapping):
3148         (BuilderMapping.save_mapping):
3149         (BuilderMapping.update_mapping):
3150         (BuilderMapping.get_existing_mapping):
3151         (BuilderMapping.is_valid_mapping):
3152
3153 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3154
3155         [ews-app] Add timestamp fields for BuilderMappings
3156         https://bugs.webkit.org/show_bug.cgi?id=194266
3157
3158         Reviewed by Lucas Forschler.
3159
3160         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3161         (BuilderMapping):
3162
3163 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3164
3165         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3166         https://bugs.webkit.org/show_bug.cgi?id=174816
3167
3168         Reviewed by Michael Catanzaro.
3169
3170         Add tests for webkit_uri_for_display().
3171
3172         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3173         (testURIForDisplayUnaffected):
3174         (testURIForDisplayAffected):
3175         (beforeAll):
3176         (afterAll):
3177         * TestWebKitAPI/glib/CMakeLists.txt:
3178
3179 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3180
3181         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3182         https://bugs.webkit.org/show_bug.cgi?id=194158
3183         <rdar://problem/47737268>
3184
3185         Rubber-stamped by Aakash Jain.
3186
3187         * Scripts/webkitpy/port/device_port.py:
3188         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3189
3190 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3191
3192         [CG] Enable setAdditionalSupportedImageTypes for WK1
3193         https://bugs.webkit.org/show_bug.cgi?id=194190
3194
3195         Reviewed by Tim Horton.
3196
3197         Add a test similar to the one under WebKit Cocoa but make it create a
3198         WebView instead of a WKWebView.
3199
3200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3201         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3202         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3203         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3204         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3205         (TestWebKitAPI::runTest):
3206         (TestWebKitAPI::TEST):
3207
3208 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3209
3210         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3211         https://bugs.webkit.org/show_bug.cgi?id=194168
3212
3213         Reviewed by Simon Fraser.
3214
3215         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3216
3217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3218         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3219         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3220         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3221         (TEST):
3222         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3223         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3224
3225 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3226
3227         REGRESSION (r237269): webkit-patch what-broke is broken 
3228         https://bugs.webkit.org/show_bug.cgi?id=193025
3229
3230         Reviewed by Aakash Jain.
3231
3232         * Scripts/webkitpy/common/host.py:
3233         (Host.buildbot):
3234         (Host.bugzilla): Renamed to 'buildbot'.
3235
3236 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3237
3238         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3239         https://bugs.webkit.org/show_bug.cgi?id=194207
3240
3241         Reviewed by Tim Horton.
3242
3243         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3244         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3245         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3246         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3247         start and delete forwards to remove the original attachment.
3248
3249         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3250         (TestWebKitAPI::TEST):
3251
3252 2019-02-04  Youenn Fablet  <youenn@apple.com>
3253
3254         Capture state should be managed consistently when doing process swapping
3255         https://bugs.webkit.org/show_bug.cgi?id=194122
3256         <rdar://problem/47609293>
3257
3258         Reviewed by Eric Carlson.
3259
3260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3261         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3262         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3263         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3266         (WTR::TestRunner::isDoingMediaCapture const):
3267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3268         * WebKitTestRunner/TestController.cpp:
3269         (WTR::TestController::isDoingMediaCapture const):
3270         * WebKitTestRunner/TestController.h:
3271         * WebKitTestRunner/TestInvocation.cpp:
3272         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3273         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3274         (WTR::TestController::isDoingMediaCapture const):
3275
3276 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3277
3278         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3279         https://bugs.webkit.org/show_bug.cgi?id=194142
3280
3281         Reviewed by Ross Kirsling.
3282
3283         There three 'separator' variables in TestController.cpp. Renamed
3284         it 'pathSeparator', and unified them.
3285
3286         * WebKitTestRunner/TestController.cpp:
3287         (WTR::TestController::generateContextConfiguration const):
3288         (WTR::createTestURL):
3289         (WTR::TestController::platformAdjustContext):
3290
3291 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3292
3293         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3294         https://bugs.webkit.org/show_bug.cgi?id=194198
3295
3296         Reviewed by Antti Koivisto.
3297
3298         No need to set the banner heights on navigation now, since Page stores them.
3299
3300         * MiniBrowser/mac/WK2BrowserWindowController.m:
3301         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3302
3303 2019-02-03  John Wilander  <wilander@apple.com>
3304
3305         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3306         https://bugs.webkit.org/show_bug.cgi?id=194104
3307         <rdar://problem/47649991>
3308
3309         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3310
3311         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3312         (TestWebKitAPI::TEST):
3313             Changed numeric types from unsigned short to uint32_t.
3314
3315 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3316
3317         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3318         <https://webkit.org/b/194178>
3319         <rdar://problem/47753473>
3320
3321         Reviewed by Alexey Proskuryakov.
3322
3323         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3324         (WTR::uninstallFakeHelvetica): Pass nullptr into
3325         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3326
3327 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3328
3329         [LFC] Initialize ICB's style with fixed width/height.
3330         https://bugs.webkit.org/show_bug.cgi?id=194188
3331
3332         Reviewed by Antti Koivisto.
3333
3334         * LayoutReloaded/misc/LFC-passing-tests.txt:
3335
3336 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3337
3338         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3339         https://bugs.webkit.org/show_bug.cgi?id=194185
3340
3341         Reviewed by Antti Koivisto.
3342
3343         * LayoutReloaded/misc/LFC-passing-tests.txt:
3344
3345 2018-12-16  Darin Adler  <darin@apple.com>
3346
3347         Convert additional String::format clients to alternative approaches
3348         https://bugs.webkit.org/show_bug.cgi?id=192746
3349
3350         Reviewed by Alexey Proskuryakov.
3351
3352         * WebKitTestRunner/TestController.cpp:
3353         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3354         as an intermediate in code that ultimately constructs a WTF::String.
3355         (WTR::userMediaOriginHash): Use makeString.
3356         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3357         (WTR::TestController::didPerformClientRedirect): Ditto.
3358         (WTR::TestController::didPerformServerRedirect): Ditto.
3359         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3360
3361 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3362
3363         [ews-build] Add unit test to verify builder keys
3364         https://bugs.webkit.org/show_bug.cgi?id=194152
3365
3366         Reviewed by Lucas Forschler.
3367
3368         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3369         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3370
3371 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3372
3373         [LFC] Expand tests coverage (12 new tests -> 787)
3374
3375         Unreviewed test gardening.
3376
3377         * LayoutReloaded/misc/LFC-passing-tests.txt:
3378
3379 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3380
3381         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3382         https://bugs.webkit.org/show_bug.cgi?id=194163
3383
3384         Reviewed by Simon Fraser.
3385
3386         775
3387
3388         * LayoutReloaded/misc/LFC-passing-tests.txt:
3389
3390 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3391
3392         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3393         https://bugs.webkit.org/show_bug.cgi?id=194140
3394         <rdar://problem/47728098>
3395
3396         Reviewed by Tim Horton.
3397
3398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3400         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3401
3402         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3403         test to induce an IPC deadlock when presenting a modal alert during touch start.
3404
3405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3406         * WebKitTestRunner/TestController.cpp:
3407         (WTR::runJavaScriptAlert):
3408
3409         Add a client callback function for running JavaScript alerts.
3410
3411         (WTR::TestController::createOtherPage):
3412         (WTR::TestController::generateContextConfiguration const):
3413
3414         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3415         the fix in this patch.
3416
3417         (WTR::TestController::createWebViewWithOptions):
3418
3419         Plumb TestOptions to generateContextConfiguration.
3420
3421         (WTR::TestController::resetPreferencesToConsistentValues):
3422         (WTR::TestController::resetStateToConsistentValues):
3423         (WTR::updateTestOptionsFromTestHeader):
3424         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3425         (WTR::TestController::handleJavaScriptAlert):
3426         * WebKitTestRunner/TestController.h:
3427         * WebKitTestRunner/TestInvocation.cpp:
3428         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3429         * WebKitTestRunner/TestOptions.h:
3430         (WTR::TestOptions::hasSameInitializationOptions const):
3431
3432 2019-02-01  Chris Dumez  <cdumez@apple.com>
3433
3434         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3435         https://bugs.webkit.org/show_bug.cgi?id=193740
3436         <rdar://problem/47527267>
3437
3438         Reviewed by Alex Christensen.
3439
3440         Add API test coverage.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3443
3444 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3445
3446         [ews-app] Add display name field to BuilderMapping model
3447         https://bugs.webkit.org/show_bug.cgi?id=194153
3448
3449         Reviewed by Lucas Forschler.
3450
3451         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3452         (BuilderMapping):
3453
3454 2019-02-01  Youenn Fablet  <youenn@apple.com>
3455
3456         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3457         https://bugs.webkit.org/show_bug.cgi?id=194155
3458
3459         Reviewed by Eric Carlson.
3460
3461         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3462         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3463         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3464
3465 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3466
3467         [LFC] Adjust replaced element's intrinsic ratio
3468         https://bugs.webkit.org/show_bug.cgi?id=194154
3469
3470         Reviewed by Antti Koivisto.
3471
3472         761
3473
3474         * LayoutReloaded/misc/LFC-passing-tests.txt:
3475
3476 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3477
3478         [WPE] Show test results in minibrowser
3479         https://bugs.webkit.org/show_bug.cgi?id=194150
3480
3481         Reviewed by Žan Doberšek.
3482
3483         * Scripts/webkitpy/port/wpe.py:
3484         (WPEPort.show_results_html_file):
3485
3486 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3487
3488         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3489         https://bugs.webkit.org/show_bug.cgi?id=194151
3490
3491         Reviewed by Žan Doberšek.
3492
3493         ALT + <- go back
3494         ALT + -> go forward
3495
3496         * MiniBrowser/wpe/main.cpp:
3497         (main):
3498
3499 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3500
3501         [LFC] Set intrinsic size on Layout::Replaced
3502         https://bugs.webkit.org/show_bug.cgi?id=194139
3503
3504         Reviewed by Antti Koivisto.
3505
3506         744
3507
3508         * LayoutReloaded/misc/LFC-passing-tests.txt:
3509
3510 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3511
3512         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3513         https://bugs.webkit.org/show_bug.cgi?id=194146
3514
3515         Reviewed by Xabier Rodriguez-Calvar.
3516
3517         It allows to open relative paths.
3518
3519         * MiniBrowser/wpe/main.cpp:
3520         (main):
3521
3522 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3523
3524         Update flakiness dashboard configuration after recent queue changes
3525         https://bugs.webkit.org/show_bug.cgi?id=194127
3526
3527         Rubber-stamped by Aakash Jain.
3528
3529         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3530
3531         * TestResultServer/static-dashboards/builders.jsonp:
3532
3533 2019-01-31  Youenn Fablet  <youenn@apple.com>
3534
3535         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3536         https://bugs.webkit.org/show_bug.cgi?id=194106
3537         <rdar://problem/47676333>
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3542         (TestWebKitAPI::didFinishNavigation):
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3545
3546 2019-01-31  Chris Dumez  <cdumez@apple.com>
3547
3548         Page zoom level is lost after a process swap or a crash
3549         https://bugs.webkit.org/show_bug.cgi?id=194105
3550         <rdar://problem/47610781>
3551
3552         Reviewed by Alex Christensen.
3553
3554         Add API test coverage.
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3557         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3558
3559 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3560
3561         Revert r238819 which is unneeded and caused a performance regression.
3562         https://bugs.webkit.org/show_bug.cgi?id=192272
3563         <rdar://problem/46664625>
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3566         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3567         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3568
3569 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3570
3571         Formalize WebKitAdditions mechanism of LoadOptimizer
3572         https://bugs.webkit.org/show_bug.cgi?id=193886
3573         <rdar://problem/47696809>
3574
3575         Reviewed by Brent Fulgham.
3576
3577         * MiniBrowser/MiniBrowser.entitlements:
3578         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3579
3580 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3581
3582         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3583         https://bugs.webkit.org/show_bug.cgi?id=194090
3584
3585         Reviewed by Antti Koivisto.
3586
3587         * LayoutReloaded/misc/LFC-passing-tests.txt:
3588
3589 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3590
3591         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3592         https://bugs.webkit.org/show_bug.cgi?id=194074
3593
3594         Reviewed by Antti Koivisto.
3595
3596         * LayoutReloaded/misc/LFC-passing-tests.txt:
3597
3598 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3599
3600         [LFC][BFC] Add support for block level replaced box.
3601         https://bugs.webkit.org/show_bug.cgi?id=194071
3602
3603         Reviewed by Antti Koivisto.
3604
3605         * LayoutReloaded/misc/LFC-passing-tests.txt:
3606
3607 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3608
3609         Fix WebKitTestRunner's testPath with Windows full paths
3610         https://bugs.webkit.org/show_bug.cgi?id=194012
3611
3612         Reviewed by Alex Christensen.
3613
3614         updateTestOptionsFromTestHeader failed to open test files because
3615         testPath returned wrong file paths. It returned a path "/C:/..."
3616         if a URL "file:///C:/..." was given.
3617
3618         * WebKitTestRunner/TestController.cpp:
3619         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3620
3621 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3622
3623         [WPE] Bump font related dependencies to match the GTK+ port
3624         https://bugs.webkit.org/show_bug.cgi?id=194017
3625
3626         Reviewed by Žan Doberšek.
3627
3628         * wpe/jhbuild.modules:
3629         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3630         * wpe/patches/icudata-stdlibs.patch: Added.
3631
3632 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3633
3634         Enable swipe tests on iOS
3635         https://bugs.webkit.org/show_bug.cgi?id=194076
3636
3637         Reviewed by Geoffrey Garen.
3638
3639         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3640         it causes a debug assertion failure in runUIScript.
3641
3642         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3643         (WTR::UIScriptController::beginBackSwipe):
3644         (WTR::UIScriptController::completeBackSwipe):
3645
3646 2019-01-30  Keith Rollin  <krollin@apple.com>
3647
3648         Use correct printf format specifier
3649         https://bugs.webkit.org/show_bug.cgi?id=194062
3650         <rdar://problem/47686167>
3651
3652         Reviewed by Alexey Proskuryakov.
3653
3654         LayoutTestSpellChecker.mm is trying to format a variable of type
3655         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3656         actually an unsigned long long. Fix this by formatting with %llu.
3657
3658         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3659         (-[LayoutTestTextCheckingResult description]):
3660
3661 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3662
3663         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3664         https://bugs.webkit.org/show_bug.cgi?id=193979
3665
3666         Reviewed by Wenson Hsieh.
3667
3668         Fix the test for iOS. Make the test work with iOS UA string.
3669
3670         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3671
3672 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3673
3674         Replace High Sierra LLINT CLoop bot due to hardware failure
3675         https://bugs.webkit.org/show_bug.cgi?id=194066
3676
3677         Reviewed by Aakash Jain.
3678
3679         * BuildSlaveSupport/build.webkit.org-config/config.json:
3680
3681 2019-01-30  Keith Rollin  <krollin@apple.com>
3682
3683         [NSDragItem init] is unavailable
3684         https://bugs.webkit.org/show_bug.cgi?id=194059
3685         <rdar://problem/47685715>
3686
3687         Reviewed by Wenson Hsieh.
3688
3689         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3690         DumpRenderTree and TestWebKitAPI, which both try to create an
3691         NSDragItem in a manner that invokes this method. Address this by using
3692         -initWithPasteboardWriter instead.
3693
3694         Note that the parameter passed to initWithPasteboardWriter is likely
3695         incorrect. In both cases, the object passed does not conform to
3696         NSPasteboardWriting. However, with this fix, we're no worse off than
3697         before, and can now perform builds with newer compilers and SDKs until
3698         a real fix can be crafted. That work is tracked in
3699         https://bugs.webkit.org/show_bug.cgi?id=194060
3700
3701         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3702         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3703         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3704         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3705
3706 2019-01-30  Daniel Bates  <dabates@apple.com>
3707
3708         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3709         https://bugs.webkit.org/show_bug.cgi?id=192824
3710         <rdar://problem/47100332>
3711