Replace PassRef with Ref/Ref&& across the board.
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-14  Andreas Kling  <akling@apple.com>
2
3         Replace PassRef with Ref/Ref&& across the board.
4         <https://webkit.org/b/139587>
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Tests/WTF/Ref.cpp:
9         (TestWebKitAPI::passWithRef):
10         (TestWebKitAPI::TEST):
11         (TestWebKitAPI::passWithPassRef): Deleted.
12         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
15         (TestWebKitAPI::TEST):
16         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
17         (TestWebKitAPI::createTestValue):
18
19 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
20
21         [EFL] MiniBrowser's window_create may return NULL
22         https://bugs.webkit.org/show_bug.cgi?id=139585
23
24         Reviewed by Gyuyoung Kim.
25
26         Move NULL checking before using object which window_create
27         returns.
28
29         * MiniBrowser/efl/main.c:
30         (elm_main):
31
32 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
33
34         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
35         https://bugs.webkit.org/show_bug.cgi?id=73030
36
37         Reviewed by Anders Carlsson.
38
39         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
40         database to empty to avoid having it fetch default favicons at random times.
41         DumpRenderTree also disables it, and also it has a way for tests to temporarily
42         enable it.
43
44 2014-12-12  Lucas Forschler  <lforschler@apple.com>
45
46         Update Apple owned build slaves after infrastructure update.
47         
48         Reviewed by Ryosuke Niwa.
49
50         * BuildSlaveSupport/build.webkit.org-config/config.json:
51
52 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
53
54         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
55         https://bugs.webkit.org/show_bug.cgi?id=139537
56
57         Reviewed by Carlos Garcia Campos.
58
59         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
60         of get_dependencies_path().
61         * jhbuild/jhbuildutils.py:
62         (get_dependencies_path): Fix the function to return the new
63         dependencies path: DependenciesPORT.
64         (enter_jhbuild_environment_if_available): Pass the port name
65         when invoking get_dependencies_path().
66
67 2014-12-10  Lucas Forschler  <lforschler@apple.com>
68
69         Update Apple owned build slaves.
70         
71         Rubber-stamped by Dana Burkart.
72         
73         * BuildSlaveSupport/build.webkit.org-config/config.json:
74
75 2014-12-10  Daniel Bates  <dabates@apple.com>
76
77         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
78         timeout instead of test failure
79         https://bugs.webkit.org/show_bug.cgi?id=139525
80
81         Reviewed by Zalan Bujtas.
82
83         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
84         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
85         output.
86
87         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
88         for the WebThread to spin its run loop before dumping its output. A test that
89         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
90         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
91         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
92         because run-webkit-tests may terminate a DumpRenderTree.app process when it
93         exceeds its process time limit (defaults to 35ms) regardless of whether such
94         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
95
96         * Scripts/webkitpy/port/ios.py:
97         (IOSSimulatorPort.default_timeout_ms):
98
99 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
100
101         [GTK][WK2] Add HTML5 Notifications support
102         https://bugs.webkit.org/show_bug.cgi?id=61140
103
104         Reviewed by Carlos Garcia Campos.
105
106         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
107         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
108         (testWebViewNotification):
109         (beforeAll):
110         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
111         (permissionRequestDialogCallback):
112         (webViewDecidePermissionRequest):
113         (geolocationRequestDialogCallback): Deleted.
114
115 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
116
117         Fix webkitpy test expectation
118
119         Not sure what I messed up, but TOTAL_SKIPS was not right.
120
121         * Scripts/webkitpy/port/test.py:
122
123 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
124
125         Remove virtual test support from webkitpy
126         https://bugs.webkit.org/show_bug.cgi?id=139427
127
128         Reviewed by Alexey Proskuryakov.
129
130         It seems that the only concrete client of virtual tests is the unit tests :D
131
132         This patch tries to clean as much useless code as possible.
133
134         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
135         (RunTest.test_tolerance):
136         (RunTest.test_virtual): Deleted.
137         * Scripts/webkitpy/layout_tests/views/printing.py:
138         (Printer._print_test_trace):
139         * Scripts/webkitpy/port/base.py:
140         (Port.expected_filename):
141         (Port.tests):
142         (Port.test_isfile):
143         (Port.test_isdir):
144         (Port.sample_process):
145         (Port.find_system_pid):
146         (Port.test_expectations_file_position):
147         (Port.virtual_test_suites): Deleted.
148         (Port): Deleted.
149         (Port.populated_virtual_test_suites): Deleted.
150         (Port._virtual_tests): Deleted.
151         (Port.lookup_virtual_test_base): Deleted.
152         (Port.lookup_virtual_test_args): Deleted.
153         (VirtualTestSuite): Deleted.
154         (VirtualTestSuite.__init__): Deleted.
155         (VirtualTestSuite.__repr__): Deleted.
156         * Scripts/webkitpy/port/base_unittest.py:
157         (PortTest.test_test_exists):
158         (PortTest.test_test_isfile):
159         (PortTest.test_test_isdir):
160         (PortTest.test_tests):
161         * Scripts/webkitpy/port/driver.py:
162         (DriverProxy.run_test): Deleted.
163         * Scripts/webkitpy/port/test.py:
164         (TestPort._skipped_tests_for_unsupported_features):
165         (TestPort.all_baseline_variants):
166         (TestPort.virtual_test_suites): Deleted.
167         * Scripts/webkitpy/tool/commands/queries.py:
168         (PrintBaselines.__init__):
169         (PrintBaselines.execute):
170         * Scripts/webkitpy/tool/commands/queries_unittest.py:
171         (PrintBaselinesTest.test_basic):
172         (PrintBaselinesTest.test_multiple):
173         (PrintBaselinesTest.test_csv):
174
175 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
176
177         Blink Merge: Remove 'http_lock' code from webkitpy
178         https://bugs.webkit.org/show_bug.cgi?id=136722
179
180         Reviewed by Alexey Proskuryakov.
181
182         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
183         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
184
185         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
186         (LayoutTestRunner.__init__):
187         (LayoutTestRunner.run_tests):
188         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
189         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
190         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
191         (FakePrinter.flush):
192         (LayoutTestRunnerTests._runner):
193         (LayoutTestRunnerTests._run_tests):
194         (LayoutTestRunnerTests.test_servers_started):
195         (LockCheckingRunner): Deleted.
196         (LockCheckingRunner.__init__): Deleted.
197         (LockCheckingRunner.handle_finished_list): Deleted.
198         (LayoutTestRunnerTests.test_http_locking): Deleted.
199         * Scripts/webkitpy/port/base.py:
200         (Port.__init__):
201         (Port.to.http_server_supports_ipv6):
202         (Port.to.stop_websocket_server):
203         (Port.to.acquire_http_lock): Deleted.
204         (Port.to.release_http_lock): Deleted.
205         * Scripts/webkitpy/port/http_lock.py: Removed.
206         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
207         * Scripts/webkitpy/port/ios.py:
208         (IOSSimulatorPort.show_results_html_file):
209         (IOSSimulatorPort.acquire_http_lock): Deleted.
210         (IOSSimulatorPort): Deleted.
211         (IOSSimulatorPort.release_http_lock): Deleted.
212         * Scripts/webkitpy/port/mac.py:
213         (MacPort.show_results_html_file):
214         (MacPort): Deleted.
215         (MacPort.acquire_http_lock): Deleted.
216         (MacPort.release_http_lock): Deleted.
217         * Scripts/webkitpy/port/mock_drt.py:
218         (MockDRTPort.start_websocket_server):
219         (MockDRTPort.stop_websocket_server):
220         (MockDRTPort.acquire_http_lock): Deleted.
221         (MockDRTPort.release_http_lock): Deleted.
222         * Scripts/webkitpy/port/mock_drt_unittest.py:
223         (MockDRTPortTest.test_uses_apache):
224         (MockDRTPortTest.integration_test_http_lock): Deleted.
225         * Scripts/webkitpy/port/port_testcase.py:
226         (PortTestCase.assert_servers_are_up):
227         (PortTestCase.integration_test_http_lock): Deleted.
228         * Scripts/webkitpy/port/test.py:
229         (TestPort.start_websocket_server):
230         (TestPort.stop_websocket_server):
231         (TestPort.acquire_http_lock): Deleted.
232         (TestPort.release_http_lock): Deleted.
233
234 2014-12-09  Alberto Garcia  <berto@igalia.com>
235
236         convertToUTF8String converts null string to empty string
237         https://bugs.webkit.org/show_bug.cgi?id=133904
238
239         Reviewed by Carlos Garcia Campos.
240
241         Test that trying to get the value of a non-existent attribute
242         returns 0 instead of an empty string.
243
244         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
245         (WebKitDOMNodeTest::testInsertion):
246
247 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
248
249         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
250         https://bugs.webkit.org/show_bug.cgi?id=139070
251
252         Reviewed by Carlos Garcia Campos.
253
254         * gtk/jhbuild.modules:
255
256 2014-12-08  Tim Horton  <timothy_horton@apple.com>
257
258         Add action menu tests
259         https://bugs.webkit.org/show_bug.cgi?id=139156
260
261         Reviewed by Dean Jackson.
262
263         * TestWebKitAPI/PlatformWebView.h:
264         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
265         (TestWebKitAPI::PlatformWebView::PlatformWebView):
266         Add a mechanism allowing tests to provide their own WKView subclass.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
270         Add a file with lots of menu targets.
271
272         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
273         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
274         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
275         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
276         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
277
278         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
279
280         (TestWebKitAPI::didFinishLoadForFrameCallback):
281         (TestWebKitAPI::didFinishDownloadCallback):
282         (TestWebKitAPI::didCreateDownloadDestinationCallback):
283         Watch downloads and ensure that they match the content we expect.
284
285         (TestWebKitAPI::watchPasteboardForString):
286         (TestWebKitAPI::watchPasteboardForImage):
287         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
288         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
289         (TestWebKitAPI::javaScriptStringCallback):
290         (TestWebKitAPI::javaScriptBoolCallback):
291         (TestWebKitAPI::callJavaScriptReturningString):
292         (TestWebKitAPI::callJavaScriptReturningBool):
293         (TestWebKitAPI::watchEditableAreaForString):
294         (TestWebKitAPI::waitForVideoReady):
295         (TestWebKitAPI::retrieveSelection):
296         (TestWebKitAPI::retrieveSelectionInElement):
297         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
298         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
299         Add many helpers for testing, especially to make asynchronous things synchronous.
300
301         (TestWebKitAPI::windowPointForTarget):
302         (TestWebKitAPI::inset8):
303         Hard-code points in action-menu-targets.html for hit testing.
304
305         (TestWebKitAPI::TEST):
306         Add a suite of tests for WebKit2 action menus.
307
308         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
309         (TestWebKitAPI::createActionContextForPhoneNumber):
310         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
311         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
312         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
313         (TestWebKitAPI::ActionMenuTest::drawRect):
314         (TestWebKitAPI::ActionMenuTest::didCreatePage):
315         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
316         so that we can test that infrastructure.
317
318 2014-12-08  Philippe Normand  <pnormand@igalia.com>
319
320         [GTK] UserMedia Permission Request API
321         https://bugs.webkit.org/show_bug.cgi?id=136449
322
323         Reviewed by Carlos Garcia Campos.
324
325         The GTK version of the MiniBrowser has gained UserMedia permission
326         request support.
327
328         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
329         requires user permission to access audio/video devices.
330         (permissionRequestDialogCallback):
331         (webViewDecidePermissionRequest):
332         (geolocationRequestDialogCallback): Deleted.
333
334 2014-12-08  Anders Carlsson  <andersca@apple.com>
335
336         Add a stubbed out method for clearing out the website data store
337         https://bugs.webkit.org/show_bug.cgi?id=139404
338
339         Reviewed by Antti Koivisto.
340
341         Add a debug menu item for testing clearing of website data.
342
343         * MiniBrowser/mac/MainMenu.xib:
344         * MiniBrowser/mac/WK2BrowserWindowController.m:
345         (-[WK2BrowserWindowController clearWebsiteData:]):
346
347 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
348
349         Update style checker to deal with "const override"
350         https://bugs.webkit.org/show_bug.cgi?id=139371
351
352         Reviewed by Csaba Osztrogonác.
353
354         check-webkit-style shouldn't complain about an open brace to start a
355         line after a function definition with const override.
356
357         * Scripts/webkitpy/style/checkers/cpp.py:
358         (check_braces):
359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
360         (CppStyleTest.test_brace_at_begin_of_line):
361
362 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
363
364         [GTK] Fix GObject DOM bindings API break tests after r176920
365         https://bugs.webkit.org/show_bug.cgi?id=139368
366
367         Reviewed by Gustavo Noronha Silva.
368
369         Remove the @version from the symbol name before comparing.
370
371         * gtk/check-for-webkitdom-api-breaks:
372         (read_expected_api):
373
374 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
375
376         Remove the option to automatically update the GObject DOM bindings symbols file
377         https://bugs.webkit.org/show_bug.cgi?id=139366
378
379         Reviewed by Martin Robinson.
380
381         It's currently broken, because symbols now need to be in a
382         specific order. Now that the symbols file only contains stable
383         API, it's not a problem to manually update it every time new API
384         is added.
385
386         * gtk/check-for-webkitdom-api-breaks:
387         (read_expected_api):
388         (check_api):
389         (write_expected_api): Deleted.
390
391 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
392
393         [GTK] Use GMainLoopSource in WebKitTestRunner
394         https://bugs.webkit.org/show_bug.cgi?id=138831
395
396         Reviewed by Sergio Villar Senin.
397
398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
399         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
400         (WTR::TestRunner::platformInitialize):
401         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
402         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
403         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
404         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
405         (WTR::TestController::notifyDone):
406         (WTR::TestController::platformRunUntil):
407         (WTR::cancelTimeout): Deleted.
408
409 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
410
411         [GTK] Missing API detected in GObject DOM bindings after r176630
412         https://bugs.webkit.org/show_bug.cgi?id=139201
413
414         Reviewed by Gustavo Noronha Silva.
415
416         Handle deprecated symbols again when generating the GObject DOM
417         bindings documentation.
418
419         * gtk/webkitdom.py:
420         (WebKitDOMDocGenerator):
421         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
422         (WebKitDOMDocGenerator.generate):
423         (WebKitDOMDocGeneratorSections.__init__):
424         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
425         (WebKitDOMDocGeneratorSections.write_section):
426
427 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
428
429         [EFL][jhbuild] Fix libsoup build with clang
430         https://bugs.webkit.org/show_bug.cgi?id=139088
431
432         Reviewed by Gyuyoung Kim.
433
434         * efl/jhbuild.modules:
435         * efl/patches/soup-clang-warning-fix1.patch: Added.
436         * efl/patches/soup-clang-warning-fix2.patch: Added.
437
438 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
439
440         [Mac] DumpRenderTree sets storage directory incorrectly
441         https://bugs.webkit.org/show_bug.cgi?id=139347
442
443         Reviewed by Dan Bernstein.
444
445         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
446         Don't use user defaults to pass per-instance paths, as user defaults are shared
447         across all instances.
448
449 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
450
451         AX: I cannot activate links on the mobile version of news.google.com
452         https://bugs.webkit.org/show_bug.cgi?id=139330
453
454         Reviewed by Simon Fraser.
455
456         Implement press for iOS.
457
458         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
459         (AccessibilityUIElement::press):
460
461 2014-12-05  Daniel Bates  <dabates@apple.com>
462
463         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
464         https://bugs.webkit.org/show_bug.cgi?id=139326
465
466         Reviewed by Anders Carlsson.
467
468         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
469         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
470         using the same scale factor as used in WebKit.
471
472         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
473         (createBitmapContextFromWebView):
474
475 2014-12-05  Anders Carlsson  <andersca@apple.com>
476
477         REGRESSION (r176677): All tests crash on Windows
478         https://bugs.webkit.org/show_bug.cgi?id=139321
479
480         Reviewed by Alexey Proskuryakov.
481
482         * DumpRenderTree/win/DumpRenderTree.cpp:
483         (runTest):
484         Don't call CFRelease on the url while we have an outstanding pointer to its string,
485         and use the right number of bytes when allocating the testURL buffer.
486
487 2014-12-05  Daniel Bates  <dabates@apple.com>
488
489         [iOS] DumpRenderTree produces many reference test mismatches
490         https://bugs.webkit.org/show_bug.cgi?id=139314
491
492         Reviewed by Simon Fraser.
493
494         Fixes an issue where the scale factor used to render the snapshot taken by
495         DumpRenderTree may differ from the device scale factor. In particular, the
496         scale factor used to render a snapshot of a test may differ from the scale
497         factor used to render the snapshot of its expected result.
498
499         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
500         snapshot the UIWebBrowserView. This SPI always render using a scale factor
501         of one when the backing store for the LegacyTileLayer objects were out-of-
502         date regardless of the device scale factor. Instead we should use UIImage
503         and CALayer API to perform the snapshot with respect to the device scale
504         factor.
505
506         Additionally write iOS pixel dump support logic in terms of existing
507         DumpRenderTree abstractions so as to support generating and comparing
508         pixel dump checksums as well as make the iOS code more consistent with
509         the logic used by other ports.
510
511         * DumpRenderTree/PixelDumpSupport.cpp:
512         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
513         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
514         (BitmapContext::createFromUIImage): Added.
515         (BitmapContext::pixelData): Added.
516         (BitmapContext::BitmapContext): Added.
517         (computeMD5HashStringForBitmapContext): Added.
518         (dumpBitmap): Added.
519         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
520         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
521
522 2014-12-05  Anders Carlsson  <andersca@apple.com>
523
524         Give all web pages a website data store
525         https://bugs.webkit.org/show_bug.cgi?id=139317
526
527         Reviewed by Tim Horton.
528
529         * MiniBrowser/mac/AppDelegate.m:
530         (-[BrowserAppDelegate newPrivateWindow:]):
531         Don't release the controller - it's implicitly retained by the window.
532
533 2014-12-05  Daniel Bates  <dabates@apple.com>
534
535         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
536         https://bugs.webkit.org/show_bug.cgi?id=137581
537         <rdar://problem/18642906>
538
539         Reviewed by Simon Fraser.
540
541         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
542         of the test that proceeded the currently running test.
543
544         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
545         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
546         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
547         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
548
549 2014-12-05  Jer Noble  <jer.noble@apple.com>
550
551         [WTF] MediaTime should support round-tripping from and to doubles.
552         https://bugs.webkit.org/show_bug.cgi?id=139248
553
554         Reviewed by Eric Carlson.
555
556         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
557         the MediaTimes after this change.
558
559         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
560         (WTF::operator<<):
561         (TestWebKitAPI::TEST):
562         * lldb/lldb_webkit.py:
563         (WTFMediaTime_SummaryProvider):
564         (WTFMediaTimeProvider.timeValueAsDouble):
565         (WTFMediaTimeProvider.isIndefinite):
566         (WTFMediaTimeProvider):
567         (WTFMediaTimeProvider.hasDoubleValue):
568
569 2014-12-05  Anders Carlsson  <andersca@apple.com>
570
571         Add a private browsing mode to MiniBrowser
572         https://bugs.webkit.org/show_bug.cgi?id=139308
573
574         Reviewed by Sam Weinig.
575
576         * MiniBrowser/mac/AppDelegate.m:
577         (defaultConfiguration):
578         (-[BrowserAppDelegate newWindow:]):
579         (-[BrowserAppDelegate newPrivateWindow:]):
580         * MiniBrowser/mac/MainMenu.xib:
581         * MiniBrowser/mac/WK2BrowserWindowController.h:
582         * MiniBrowser/mac/WK2BrowserWindowController.m:
583         (-[WK2BrowserWindowController awakeFromNib]):
584         (-[WK2BrowserWindowController initWithConfiguration:]):
585         (-[WK2BrowserWindowController dealloc]):
586         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
587
588 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
589
590         Run http tests parallel
591         https://bugs.webkit.org/show_bug.cgi?id=138958
592
593         Reviewed by Daniel Bates.
594
595         Remove the concept of "locked shard". Now http tests are just like any other tests.
596         We start HTTP and WebSocket servers at the start if we need them, and terminate them
597         when done with all the tests (not when the last http test runs, which is unnecessarily
598         unpredictable).
599
600         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
601         patch, they used to take over 15 minutes.
602
603         As part of the fix, we no longer pass the number of servers to Apache. I don't
604         think that these parameters did what we wanted them to do; Apache handles the load
605         just fine without them.
606
607         The change applies to all platforms. I fixed everything I could find on Mac, and
608         Ossy told me that he's been running http tests in parallel for a long time. If
609         there is increased instability for some ports, it will need to be fixed - there is
610         generally nothing special about http tests at this point, and most code is
611         cross-platform in WebKit2.
612
613         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
614         (LayoutTestRunner.__init__):
615         (LayoutTestRunner.run_tests):
616         (LayoutTestRunner.start_servers_with_lock):
617         (LayoutTestRunner._handle_started_test):
618         (Worker.handle):
619         (Sharder.__init__):
620         (Sharder.shard_tests):
621         (Sharder._shard_every_file):
622         (Sharder._shard_by_directory):
623         (LayoutTestRunner._handle_finished_test_list): Deleted.
624         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
625         (Sharder._shard_in_two): Deleted.
626         (Sharder): Deleted.
627         (Sharder._resize_shards): Deleted.
628         (Sharder._resize_shards.divide_and_round_up): Deleted.
629         (Sharder._resize_shards.extract_and_flatten): Deleted.
630         (Sharder._resize_shards.split_at): Deleted.
631         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
632         (FakePrinter.print_workers_and_shards):
633         (LayoutTestRunnerTests.test_servers_started.start_http_server):
634         (LayoutTestRunnerTests.test_servers_started):
635         (SharderTests.get_shards):
636         (SharderTests.test_shard_by_dir):
637         (SharderTests.test_shard_every_file):
638         (SharderTests): Deleted.
639         (SharderTests.test_shard_in_two): Deleted.
640         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
641         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
642         (SharderTests.test_multiple_locked_shards): Deleted.
643         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
644         (ManagerTest.test_needs_servers.get_manager):
645         (ManagerTest.integration_test_needs_servers.get_manager):
646         (ManagerTest.test_look_for_new_crash_logs.get_manager):
647         (ManagerTest):
648         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
649         (_set_up_derived_options):
650         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
651         (RunTest.test_batch_size):
652         (RunTest.test_max_locked_shards): Deleted.
653         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
654         (LayoutTestApacheHttpd.__init__):
655         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
656         (TestLayoutTestApacheHttpd.test_start_cmd):
657         * Scripts/webkitpy/layout_tests/servers/http_server.py:
658         (Lighttpd.__init__):
659         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
660         (HttpServerBase.__init__):
661         * Scripts/webkitpy/layout_tests/views/printing.py:
662         (Printer.print_workers_and_shards):
663         * Scripts/webkitpy/port/base.py:
664         (Port.default_child_processes):
665         (Port.to.start_http_server):
666         (Port.default_max_locked_shards): Deleted.
667         * Scripts/webkitpy/port/port_testcase.py:
668         (PortTestCase.make_port):
669         (PortTestCase.test_default_max_locked_shards): Deleted.
670         * Scripts/webkitpy/port/test.py:
671         (TestPort.start_http_server):
672
673 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
674
675         Don't lock perf tests in run-webkit-tests
676         https://bugs.webkit.org/show_bug.cgi?id=139264
677
678         Reviewed by Daniel Bates.
679
680         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
681         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
683         * Scripts/webkitpy/layout_tests/models/test_input.py:
684         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
685
686 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
687
688         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
689         https://bugs.webkit.org/show_bug.cgi?id=139243
690
691         Reviewed by Anders Carlsson.
692
693         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
694         chance to allow untrusted certificates.
695
696         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
697         Set up more client objects for secondary windows. We may be able to share some of the
698         code with main view creation function, but it's not exactly the same (notably, we
699         do not focus a secondary window when it's done loading).
700
701 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
702
703         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
704         https://bugs.webkit.org/show_bug.cgi?id=139071
705
706         Reviewed by Chris Fleizach.
707
708         Add string value for ATK_ROLE_STATIC in roleToString.
709
710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
711
712 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
713
714         check-webkit-style is confused by ternary expression inside first member initializer
715         https://bugs.webkit.org/show_bug.cgi?id=136442
716
717         Reviewed by Csaba Osztrogonác.
718
719         * Scripts/webkitpy/style/checkers/cpp.py:
720         (check_member_initialization_list):
721
722 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
723
724         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
725         https://bugs.webkit.org/show_bug.cgi?id=139220
726
727         Reviewed by Philippe Normand.
728
729         * gtk/jhbuild.modules:
730         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
731
732 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
733
734         Remove unused JSC runtime options
735         https://bugs.webkit.org/show_bug.cgi?id=133070
736
737         Reviewed by Csaba Osztrogonác.
738
739         * Scripts/run-jsc-stress-tests:
740
741 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
742
743         [EFL] Add subtle crypto to the build system
744         https://bugs.webkit.org/show_bug.cgi?id=138612
745
746         Reviewed by Csaba Osztrogonác.
747
748         * Scripts/webkitperl/FeatureList.pm:
749
750 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
751
752         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
753         https://bugs.webkit.org/show_bug.cgi?id=139005
754
755         Reviewed by Chris Fleizach.
756
757         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
758         Add mapping for ATK_ROLE_CAPTION to roleToString
759
760 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
761
762         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
763         https://bugs.webkit.org/show_bug.cgi?id=139149
764
765         Reviewed by Anders Carlsson.
766
767         WebKit2 already cleared application caches between runs (although it wasn't entirely
768         effective without WebCore changes in this patch).
769
770         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
771
772         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
773         function is not implemented on Windows, see below).
774
775         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
776         Ameded a FIXME.
777
778 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
779
780         Generalize PageActivityAssertionToken
781         https://bugs.webkit.org/show_bug.cgi?id=139106
782
783         Reviewed by Sam Weinig.
784
785         Add an API test for WTF::RefCounter.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
789         (TestWebKitAPI::TEST):
790             - added RefCounter test.
791
792 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
793
794         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
795         https://bugs.webkit.org/show_bug.cgi?id=139174
796
797         Reviewed by Simon Fraser.
798
799         * DumpRenderTree/TestRunner.cpp:
800         * DumpRenderTree/TestRunner.h:
801         Renamed testPathOrURL to testURL, because this variable always contains a URL.
802
803         * DumpRenderTree/mac/DumpRenderTree.mm:
804         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
805         (testPathFromURL): Moved from FrameLoadDelegate.mm.
806         (runTest): Set crash reporter information here, as we know the exact test URL.
807
808         * DumpRenderTree/mac/FrameLoadDelegate.mm:
809         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
810         reporter information here.
811
812         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
813         * DumpRenderTree/mac/TestRunnerMac.mm:
814         Updated for testPathOrURL renaming.
815
816         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
817         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
818         test URL until load starts, so save it into TestRunner now. A new TestRunner object
819         is created for each test.
820
821         * WebKitTestRunner/InjectedBundle/TestRunner.h:
822         (WTR::TestRunner::testURL):
823         (WTR::TestRunner::setTestURL):
824         Make TestRunner know the test name. For now, it's good enough to have it once load
825         starts, but if we ever need it earlier, we can send it with BeginTest message.
826
827         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
828         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
829         Use test URL, not currently loading URL for CrashReporter.
830
831         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
832         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
833         (WebKit1 already had it right).
834
835         * DumpRenderTree/win/DumpRenderTree.cpp:
836         (sizeWebViewForCurrentTest):
837         (runTest):
838         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
839         (ResourceLoadDelegate::willSendRequest):
840         Changed Windows DumpRenderTree to also use URL in TestRunner.
841
842 2014-12-02  Daniel Bates  <dabates@apple.com>
843
844         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
845         https://bugs.webkit.org/show_bug.cgi?id=139143
846
847         Reviewed by David Kilzer.
848
849         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
850         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
851         crashes. Run-webkit-tests will record as crashing the test associated with the
852         DumpRenderTree instance that wrote that string.
853
854         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
855         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
856         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
857         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
858         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
859         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
860         about a crash.
861
862         Additionally, update the crash message format written to standard error when LayoutTestRelay
863         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
864         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
865         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
866         when they crash in their test machinery logic/UI process code.
867
868         * DumpRenderTree/mac/DumpRenderTree.mm:
869         (writeCrashedMessageOnFatalError): Added.
870         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
871         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
872         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
873         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
874         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
875         the crash logs for WebKitTestRunner/DumpRenderTree.app.
876         * Scripts/webkitpy/port/driver.py:
877         (Driver.__init__): Update comment.
878         (Driver._check_for_driver_crash): Ditto.
879         * Scripts/webkitpy/port/ios.py:
880         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
881         regular expression. This constant is used as an optimization to avoid compiling the same
882         regular expression across invocations of _get_crash_log().
883         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
884         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
885         closer to where they are used.
886
887 2014-12-01  Anders Carlsson  <andersca@apple.com>
888
889         Remove WKBundleRemoveAllVisitedLinks
890         https://bugs.webkit.org/show_bug.cgi?id=139163
891
892         Reviewed by Sam Weinig.
893
894         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
895
896         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
897         (WTR::InjectedBundle::beginTesting):
898         * WebKitTestRunner/TestInvocation.cpp:
899         (WTR::TestInvocation::invoke):
900
901 2014-12-02  Anders Carlsson  <andersca@apple.com>
902
903         Fix Windows build.
904
905         * DumpRenderTree/win/DumpRenderTree.cpp:
906         (setAlwaysAcceptCookies):
907
908 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
909
910         [EFL] Remove edbus dependency from jhbuild
911         https://bugs.webkit.org/show_bug.cgi?id=139130
912
913         Reviewed by Gyuyoung Kim.
914
915         After http://trac.webkit.org/changeset/176555 we
916         don't need it anymore.
917
918         * efl/jhbuild.modules:
919
920 2014-12-02  Philippe Normand  <pnormand@igalia.com>
921
922         [jhbuild] wrong Dependencies path
923         https://bugs.webkit.org/show_bug.cgi?id=139176
924
925         Reviewed by Martin Robinson.
926
927         * Scripts/webkitpy/port/base.py:
928         (Port._should_use_jhbuild):
929
930 2014-12-02  Philippe Normand  <pnormand@igalia.com>
931
932         [GStreamer] Bump internal jhbuild versions to 1.4.4
933         https://bugs.webkit.org/show_bug.cgi?id=138866
934
935         Reviewed by Carlos Garcia Campos.
936
937         * gtk/jhbuild.modules:
938         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
939         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
940         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
941
942 2014-12-01  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r176566.
945         https://bugs.webkit.org/show_bug.cgi?id=139124
946
947         It broke the GTK performance tests. (Requested by clopez on
948         #webkit).
949
950         Reverted changeset:
951
952         "[GTK] Use GMainLoopSource in WebKitTestRunner"
953         https://bugs.webkit.org/show_bug.cgi?id=138831
954         http://trac.webkit.org/changeset/176566
955
956 2014-11-29  Anders Carlsson  <andersca@apple.com>
957
958         Crash when calling WKPageClose on the originated page from within createNewPage callback
959         https://bugs.webkit.org/show_bug.cgi?id=139099
960         <rdar://problem/19052564>
961
962         Reviewed by Sam Weinig.
963
964         Add a test.
965
966         * TestWebKitAPI/PlatformWebView.h:
967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
968         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
969         (TestWebKitAPI::runJavaScriptAlert):
970         (TestWebKitAPI::createNewPage):
971         (TestWebKitAPI::TEST):
972         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
973         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
974         (TestWebKitAPI::PlatformWebView::PlatformWebView):
975
976 2014-11-28  Commit Queue  <commit-queue@webkit.org>
977
978         Unreviewed, rolling out r176564.
979         https://bugs.webkit.org/show_bug.cgi?id=139093
980
981         massive failures on release test bot (Requested by philn on
982         #webkit).
983
984         Reverted changeset:
985
986         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
987         https://bugs.webkit.org/show_bug.cgi?id=138866
988         http://trac.webkit.org/changeset/176564
989
990 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
991
992         [GTK] Use GMainLoopSource in WebKitTestRunner
993         https://bugs.webkit.org/show_bug.cgi?id=138831
994
995         Reviewed by Sergio Villar Senin.
996
997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
998         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
999         (WTR::TestRunner::platformInitialize):
1000         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1001         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1002         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1003         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1004         (WTR::TestController::notifyDone):
1005         (WTR::TestController::platformRunUntil):
1006         (WTR::cancelTimeout): Deleted.
1007
1008 2014-11-24  Philippe Normand  <pnormand@igalia.com>
1009
1010         [GStreamer] Bump internal jhbuild versions to 1.4.4
1011         https://bugs.webkit.org/show_bug.cgi?id=138866
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         * gtk/jhbuild.modules:
1016         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1017         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1018         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1019
1020 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1021
1022         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
1023         https://bugs.webkit.org/show_bug.cgi?id=138834
1024
1025         Reviewed by Sergio Villar Senin.
1026
1027         It makes everyting simpler and the tests run faster too, since we
1028         don't need to spawn the private bus and wait until the DBus name
1029         is registered. The web extension registers a new JavaSCript class
1030         with a status method to run the tests, similar to the DBus
1031         method. In the UI process side, tests use webkit_web_view_run_java_script()
1032         instead of sending a DBus message.
1033
1034         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1035         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1036         (WebKitDOMNodeFilterTest::create):
1037         (WebKitDOMNodeFilterTest::testTreeWalker):
1038         (WebKitDOMNodeFilterTest::testNodeIterator):
1039         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
1040         (WebKitDOMNodeFilterTest::runTest): Deleted.
1041         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1042         (WebKitDOMNodeTest::create):
1043         (WebKitDOMNodeTest::testHierarchyNavigation):
1044         (WebKitDOMNodeTest::testInsertion):
1045         (WebKitDOMNodeTest::testTagNames):
1046         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
1047         (WebKitDOMNodeTest::runTest): Deleted.
1048         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1049         (WebKitDOMXPathNSResolverTest::create):
1050         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1051         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1052         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
1053         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
1054         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1055         (WebKitFrameTest::create):
1056         (WebKitFrameTest::testMainFrame):
1057         (WebKitFrameTest::testURI):
1058         (WebKitFrameTest::testJavaScriptContext):
1059         (WebKitFrameTest::webPageFromArgs): Deleted.
1060         (WebKitFrameTest::runTest): Deleted.
1061         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1062         (testWebKitDOMNodeHierarchyNavigation):
1063         (testWebKitDOMNodeInsertion):
1064         (testWebKitDOMNodeTagNames):
1065         (beforeAll):
1066         (afterAll):
1067         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1068         (runTest):
1069         (beforeAll):
1070         (afterAll):
1071         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1072         (testWebKitDOMXPathNSResolverNative):
1073         (testWebKitDOMXPathNSResolverCustom):
1074         (beforeAll):
1075         (afterAll):
1076         (runTest): Deleted.
1077         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1078         (webkitFrameTestRun):
1079         (beforeAll):
1080         (afterAll):
1081         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1082         (testsMap):
1083         (WebProcessTest::add):
1084         (WebProcessTest::create):
1085         (runTest):
1086         (windowObjectClearedCallback):
1087         (webkit_web_extension_initialize):
1088         (methodCallCallback): Deleted.
1089         (webkit_web_extension_initialize_with_user_data): Deleted.
1090         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1091         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
1092         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
1093         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1094         (WebViewTest::runWebProcessTest):
1095         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1096
1097 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
1098
1099         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
1100         https://bugs.webkit.org/show_bug.cgi?id=139086
1101
1102         Reviewed by Gyuyoung Kim.
1103
1104         * efl/jhbuild.modules:
1105         * efl/patches/libseccomp-pick-up-CC.patch: Added.
1106
1107 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
1108
1109         [EFL] Add warning if CMake version is too old for building with ninja.
1110         https://bugs.webkit.org/show_bug.cgi?id=139055
1111
1112         Reviewed by Gyuyoung Kim.
1113
1114         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
1115         that version in their repositories.
1116
1117         * efl/install-dependencies:
1118
1119 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
1120
1121         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
1122         https://bugs.webkit.org/show_bug.cgi?id=139044
1123
1124         Reviewed by Chris Fleizach.
1125
1126         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
1127         The proposed solution will enable the use of this method for the object table.
1128         Existing test shows the result.
1129
1130         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1131         (WTR::AccessibilityUIElement::columnHeaders):
1132
1133 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
1134
1135         [EFL] Remove E_Dbus dependency
1136         https://bugs.webkit.org/show_bug.cgi?id=136355
1137
1138         Reviewed by Gyuyoung Kim.
1139
1140         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
1141
1142 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1143
1144         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
1145         https://bugs.webkit.org/show_bug.cgi?id=139047
1146
1147         Reviewed by Carlos Garcia Campos.
1148
1149         * efl/jhbuild.modules:
1150         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
1151         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
1152         * gtk/jhbuild-optional.modules:
1153         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
1154         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
1155
1156 2014-11-25  Tanay C  <tanay.c@samsung.com>
1157
1158         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
1159         https://bugs.webkit.org/show_bug.cgi?id=138090
1160
1161         Reviewed by Carlos Garcia Campos.
1162
1163         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
1164         (browserWindowZoomIn): Added.
1165         (browserWindowZoomOut): Added.
1166         (scrollEventCallback): Added.
1167         (zoomInCallback): Modified.
1168         (zoomOutCallback): Modified.
1169         (browserWindowConstructed): Modified.
1170
1171 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1172
1173         [EFL] REGRESSION(r176514): It made performance tests fail
1174         https://bugs.webkit.org/show_bug.cgi?id=139037
1175
1176         Reviewed by Gyuyoung Kim.
1177
1178         * Scripts/webkitpy/port/efl.py:
1179         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
1180         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
1181         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
1182
1183 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1184
1185         [GTK] update-webkitgtk-libs fails to build fontconfig
1186         https://bugs.webkit.org/show_bug.cgi?id=139032
1187
1188         Reviewed by Martin Robinson.
1189
1190         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
1191         fontconfig will try to generate documentation and fail.
1192
1193         * gtk/install-dependencies:
1194
1195 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1196
1197         Unreviewed. Fix GTK+ make distcheck.
1198
1199         * gtk/manifest.txt: Remove deleted files.
1200
1201 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
1202
1203         [EFL] Utilize Eail library to support accessibility in EFL
1204         https://bugs.webkit.org/show_bug.cgi?id=137742
1205
1206         Reviewed by Gyuyoung Kim.
1207
1208         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
1209
1210         * efl/jhbuild-optional.modules: Added.
1211         * efl/jhbuild.modules:
1212
1213 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
1216         https://bugs.webkit.org/show_bug.cgi?id=139023
1217
1218         Reviewed by Sergio Villar Senin.
1219
1220         Rename WebKitWebView/default-context as WebKitWebView/web-context
1221         and check we are always using the right context for new web views.
1222
1223         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1224         (testWebViewWebContext):
1225         (beforeAll):
1226         (testWebViewDefaultContext): Deleted.
1227
1228 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1229
1230         [GTK] Add API to override the default local storage directory
1231         https://bugs.webkit.org/show_bug.cgi?id=138828
1232
1233         Reviewed by Gustavo Noronha Silva.
1234
1235         Add test to check that the local storage directory is created at
1236         the path given on construction.
1237
1238         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1239         (testWebContextConfiguration):
1240         (beforeAll):
1241         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1242         (Test::Test):
1243         (Test::~Test): Deleted.
1244
1245 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1246
1247         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1248         https://bugs.webkit.org/show_bug.cgi?id=138981
1249
1250         Reviewed by Simon Fraser.
1251
1252         * MiniBrowser/mac/SettingsController.h:
1253         * MiniBrowser/mac/SettingsController.m:
1254         (-[SettingsController _populateMenu]):
1255         (-[SettingsController validateMenuItem:]):
1256         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
1257         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
1258         * MiniBrowser/mac/WK1BrowserWindowController.m:
1259         (-[WK1BrowserWindowController didChangeSettings]):
1260         * MiniBrowser/mac/WK2BrowserWindowController.m:
1261         (-[WK2BrowserWindowController didChangeSettings]):
1262
1263 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
1264
1265         Remove http lock code from webkitperl
1266         https://bugs.webkit.org/show_bug.cgi?id=138959
1267
1268         Reviewed by Alexey Proskuryakov.
1269
1270         * Scripts/webkitperl/httpd.pm:
1271         (cleanUp):
1272         (extractLockNumber): Deleted.
1273         (getLockFiles): Deleted.
1274         (getNextAvailableLockNumber): Deleted.
1275         (getLockNumberForCurrentRunning): Deleted.
1276         (waitForHTTPDLock): Deleted.
1277         (scheduleHttpTesting): Deleted.
1278         (getWaitTime): Deleted.
1279
1280 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
1281
1282         [EFL] The option value of fixed layout is false in MiniBrowser
1283         https://bugs.webkit.org/show_bug.cgi?id=138830
1284
1285         Reviewed by Gyuyoung Kim.
1286
1287         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
1288
1289         * MiniBrowser/efl/main.c:
1290
1291 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
1292
1293         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
1294         https://bugs.webkit.org/show_bug.cgi?id=138871
1295
1296         Reviewed by Carlos Garcia Campos.
1297
1298         Add a test case for the convenience API for posting user messages
1299         added to the DOM bindings.
1300
1301         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1302         (testUserContentManagerMessageFromConvenienceDOMBindings):
1303         (beforeAll):
1304         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1305         (documentLoadedCallback):
1306
1307 2014-11-19  Dana Burkart  <dburkart@apple.com>
1308
1309         Work around the fact that different masters may have different names for their codebases.
1310         https://bugs.webkit.org/show_bug.cgi?id=138878
1311
1312         Reviewed by Mark Rowe.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1315         (parseRevisionProperty): Changed.
1316         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
1317         opensource / internal codebase naming convention.
1318
1319 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
1320
1321         AX: Screen braille input doesn't work on forms.
1322         https://bugs.webkit.org/show_bug.cgi?id=138804
1323
1324         Unreviewed build fix.
1325
1326         * DumpRenderTree/AccessibilityUIElement.cpp:
1327         (AccessibilityUIElement::setValue):
1328
1329 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
1330
1331         AX: Screen braille input doesn't work on forms.
1332         https://bugs.webkit.org/show_bug.cgi?id=138804
1333
1334         Reviewed by Mario Sanchez Prada.
1335
1336         Add a method to setValue through the AX API in DRT.
1337
1338         * DumpRenderTree/AccessibilityUIElement.cpp:
1339         (setValueCallback):
1340         (AccessibilityUIElement::getJSClass):
1341         * DumpRenderTree/AccessibilityUIElement.h:
1342         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1343         (AccessibilityUIElement::setValue):
1344         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1345         (AccessibilityUIElement::setValue):
1346
1347 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
1348
1349         Remove the WinCairo buildbot
1350         https://bugs.webkit.org/show_bug.cgi?id=138805
1351
1352         Reviewed by Alex Christensen.
1353
1354         * BuildSlaveSupport/build.webkit.org-config/config.json:
1355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1356         (appendCustomBuildFlags):
1357         * BuildSlaveSupport/test-result-archive:
1358         (archiveTestResults):
1359
1360 2014-11-18  Daniel Bates  <dabates@apple.com>
1361
1362         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1363         SPI are not available in public SDK
1364         https://bugs.webkit.org/show_bug.cgi?id=138802
1365
1366         Reviewed by David Kilzer.
1367
1368         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1369
1370         * DumpRenderTree/mac/CheckedMalloc.cpp:
1371
1372 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1373
1374         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
1375
1376         Forgot to fix this test before landing.
1377
1378         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1379         (testWebViewDefaultContext):
1380
1381 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1382
1383         [GTK] Add API to create a WebKitWebContext
1384         https://bugs.webkit.org/show_bug.cgi?id=138826
1385
1386         Reviewed by Gustavo Noronha Silva.
1387
1388         Use a different WebKitWebContext for every test to ensure test
1389         cases are independent to each other. Tests using DBus to
1390         communicate with the injected bundle extension now use a unique
1391         name for the well known DBus name.
1392
1393         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1394         (beforeAll): Remove comment about the order of the tests and
1395         move the success test before the failed one now that tests don't
1396         depend on each others.
1397         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1398         (beforeAll): Remove call to set the web extensions directory,
1399         since this is now done for all test in the Test constructor.
1400         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1401         (beforeAll): Do not create a temporary directory, a temporary data
1402         directory is now created for all tests.
1403         (afterAll):
1404         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1405         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
1406         to the web process test runner.
1407         (testWebKitDOMNodeInsertion): Ditto.
1408         (testWebKitDOMNodeTagNames): Ditto.
1409         (beforeAll): Remove call to set the web extensions directory.
1410         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1411         (runTest): Pass the web extension ID to the web process test runner.
1412         (beforeAll): Remove call to set the web extensions directory.
1413         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1414         (runTest): Pass the web extension ID to the web process test runner.
1415         (beforeAll): Remove call to set the web extensions directory.
1416         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1417         (createFileAtDestination): Use Test::dataDirectory() as base dir
1418         for temporary files.
1419         (beforeAll): Do not create a temporary directory.
1420         (afterAll):
1421         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1422         (webkitFrameTestRun): Pass the web extension ID to the web process
1423         test runner.
1424         (beforeAll): Remove call to set the web extensions directory.
1425         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1426         (beforeAll): Remove call to set the web extensions directory.
1427         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1428         (testProcessPerWebView): Use local member instead of global variable.
1429         (testMultiprocessWebViewCreateReadyClose): Ditto.
1430         (beforeAll): Do not connect to initialize-web-extensions, Test now
1431         connects to the signal for all tests and calls a virtual method
1432         that test can override.
1433         (afterAll):
1434         (initializeWebExtensions): Deleted.
1435         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1436         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
1437         for temporary files.
1438         (beforeAll): Do not create a temporary directory.
1439         (afterAll):
1440         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1441         (beforeAll): Remove call to set the web extensions directory.
1442         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1443         (beforeAll): Remove comment about the tests order.
1444         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1445         (testWebExtensionGetTitle): Build the DBus service name using the
1446         web extension ID.
1447         (testDocumentLoadedSignal): Ditto.
1448         (testWebKitWebViewProcessCrashed): Ditto.
1449         (testWebExtensionIsolatedWorld): Ditto.
1450         (beforeAll): Remove initialization-user-data test, since now all
1451         tests are passing user data to the web extension.
1452         (testWebExtensionInitializationUserData): Deleted.
1453         (initializeWebExtensions): Deleted.
1454         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1455         (testSetDirectory): Use the web context member inherited from Test.
1456         (testClearDatabase): Ditto.
1457         (testGetFaviconURI): Ditto.
1458         (beforeAll): Do not create a temporary directory.
1459         (afterAll):
1460         (webkitFaviconDatabaseFinalizedCallback): Deleted.
1461         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1462         (UserContentManagerTest::UserContentManagerTest):
1463         (beforeAll): Remove call to set the web extensions directory.
1464         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1465         (testWebContextDefault): Check also that a newly create web
1466         context is not the default web context.
1467         (testWebContextSpellChecker): Use the web context member inherited
1468         from Test.
1469         (testWebContextLanguages): Ditto.
1470         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1471         (methodCallCallback): Remove GetInitializationUserData method.
1472         (webkit_web_extension_initialize_with_user_data): Always create
1473         the DBus name using the user data provided.
1474         (makeBusName): Deleted.
1475         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1476         (webkit_web_extension_initialize_with_user_data): Create the DBus
1477         name using the user data provided.
1478         (webkit_web_extension_initialize): Deleted.
1479         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1480         (Test::dataDirectory): Return the temporary data directory.
1481         (removeNonEmptyDirectory): Also remove directories recursively.
1482         (main): Remove the disk cache directory initialization, since this
1483         is now done in the Test constructor.
1484         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1485         (Test::initializeWebExtensionsCallback): Call the virtual method
1486         initializeWebExtensions()
1487         (Test::Test): Create a new WebKitWebContext and initialize it.
1488         (Test::~Test): Disconnect initialize-web-extensions signal.
1489         (Test::initializeWebExtensions): Set the web extensions directory
1490         and user data.
1491         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1492         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
1493         (WebProcessTestRunner::runTest): Build the DBus proxy using a
1494         unique name created with the Test web extension ID.
1495         (WebProcessTestRunner::proxy): Deleted.
1496         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
1497         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1498         (WebViewTest::WebViewTest): Create the web view with the Test web
1499         context.
1500         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
1501         content manager parameter to the constructor.
1502
1503 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
1504
1505         [GTK] Mesa build fails over llvm-3.5
1506         https://bugs.webkit.org/show_bug.cgi?id=138825
1507
1508         Reviewed by Gustavo Noronha Silva.
1509
1510         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
1511
1512         * gtk/jhbuild.modules:
1513         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
1514
1515 2014-11-17  Daniel Bates  <dabates@apple.com>
1516
1517         Unreviewed, rolling out r176232.
1518
1519         Broke the Mac build. Will investigate offline.
1520
1521         Reverted changeset:
1522
1523         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1524         MobileGestalt"
1525         https://bugs.webkit.org/show_bug.cgi?id=138802
1526         http://trac.webkit.org/changeset/176232
1527
1528 2014-11-17  Daniel Bates  <dabates@apple.com>
1529
1530         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1531         SPI are not available in public SDK
1532         https://bugs.webkit.org/show_bug.cgi?id=138802
1533
1534         Reviewed by David Kilzer.
1535
1536         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1537
1538         * DumpRenderTree/mac/CheckedMalloc.cpp:
1539
1540 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
1541
1542         Having 30+ flaky failures breaks EWS
1543         https://bugs.webkit.org/show_bug.cgi?id=138743
1544
1545         Reviewed by Alexey Proskuryakov.
1546
1547         Adds tests to ensure that the problem has been solved.
1548         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1549         (test_first_failure_limit):
1550         (test_first_failure_limit_with_some_tree_redness):
1551         (test_second_failure_limit):
1552         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
1553         (test_first_and_second_failure_limit):
1554         (test_first_and_clean_failure_limit):
1555         (test_first_second_and_clean_failure_limit):
1556         (test_very_red_tree_retry): Deleted.
1557         Really this was renamed to test_first_second_and_clean_failure_limit.
1558         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1559         Makes the appropriate changes to PatchAnalysisTask to make sure that
1560         even when the first test run hits the failure limit, it will still try
1561         a second run.
1562         (PatchAnalysisTask._results_failed_different_tests):
1563         (PatchAnalysisTask._test_patch):
1564         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
1565
1566 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
1567
1568         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1569         https://bugs.webkit.org/show_bug.cgi?id=136018
1570
1571         Reviewed by Carlos Garcia Campos.
1572
1573         It is possible that the order of -L arguments in the output of
1574         pkg-config is wrong, which causes the linker to find the wrong
1575         version (usually older version) of libraries when running
1576         gtkdoc-scangobj.
1577
1578         * gtk/gtkdoc.py:
1579         (GTKDoc._run_gtkdoc_scangobj):
1580
1581 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1582
1583         Bump EFL version to 1.12.0
1584         https://bugs.webkit.org/show_bug.cgi?id=138733
1585
1586         Reviewed by Gyuyoung Kim.
1587
1588         * efl/jhbuild.modules:
1589
1590 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1591
1592         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1593         https://bugs.webkit.org/show_bug.cgi?id=138771
1594
1595         Reviewed by Chris Fleizach.
1596
1597         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1598
1599         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1600
1601 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1602
1603         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1604         https://bugs.webkit.org/show_bug.cgi?id=138767
1605
1606         Reviewed by Chris Fleizach.
1607
1608         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1609
1610         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1611
1612 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1613
1614         Add shortcut macros to Mac TestExpectations
1615         https://bugs.webkit.org/show_bug.cgi?id=138729
1616
1617         Reviewed by Simon Fraser.
1618
1619         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1620         Add version macros for current OS versions.
1621
1622 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1623
1624         https://bugs.webkit.org/show_bug.cgi?id=138628
1625         A patch that doesn't apply is stuck in commit queue
1626
1627         Rubber-stamped by David Kilzer.
1628
1629         This also hopefully fixes other issues:
1630         - a patch that has cq+ flag set by a non-committer kills commit queue;
1631         - EWS never reports failing tests, and keeps spinning instead.
1632
1633         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1634         (Bugzilla.set_flag_on_attachment):
1635         (Bugzilla.obsolete_attachment):
1636         Apply the fix from r174797 to more places.
1637
1638 2014-11-13  Dan Bernstein  <mitz@apple.com>
1639
1640         Policy client not called for navigations through the page cache
1641         https://bugs.webkit.org/show_bug.cgi?id=138703
1642
1643         Reviewed by Alexey Proskuryakov.
1644
1645         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1646         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1647         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1648
1649 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1650
1651         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1652         https://bugs.webkit.org/show_bug.cgi?id=137867
1653
1654         Reviewed by Chris Fleizach.
1655
1656         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1657         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1658         able to test for the presence of ATK_ROLE_INVALID.
1659
1660         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1661         (WTR::AccessibilityUIElement::role):
1662
1663 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1664
1665         Update the "combineModules" script to handel more LLVM metadata.
1666         https://bugs.webkit.org/show_bug.cgi?id=138514
1667
1668         Reviewed by Filip Pizlo.
1669
1670         * ReducedFTL/combineModules.rb:
1671
1672 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1673
1674         Allow constructing a base PassRef with a derived Ref
1675         https://bugs.webkit.org/show_bug.cgi?id=138701
1676
1677         Reviewed by Andreas Kling
1678
1679         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1680         (TestWebKitAPI::passWithPassRef):
1681         (TestWebKitAPI::passWithPassRefPtr):
1682         (TestWebKitAPI::TEST):
1683
1684 2014-11-05  Ada Chan  <adachan@apple.com>
1685
1686         Implement new plug-in API for muting plug-ins
1687         https://bugs.webkit.org/show_bug.cgi?id=138105
1688
1689         Reviewed by Anders Carlsson.
1690
1691         Add a new plug-in test for the mute API.
1692
1693         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1694         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1695         (SetMuted::SetMuted):
1696         (SetMuted::isMuted):
1697         (SetMuted::cachedIsMuted):
1698         (SetMuted::ScriptableObject::hasProperty):
1699         (SetMuted::ScriptableObject::getProperty):
1700         (SetMuted::ScriptableObject::pluginTest):
1701         (SetMuted::NPP_New):
1702         (SetMuted::NPP_GetValue):
1703         (SetMuted::NPP_SetValue):
1704
1705 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1706
1707         Unreviewed, GTK gardening.
1708
1709         * Scripts/run-gtk-tests:
1710         (TestRunner): Skip the UserMediaBasic test because it depends on
1711         constraints validation which is going to be fixed in bug #136449.
1712
1713 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1714
1715         [GTK] Expose user script messages to GObject DOM bindings
1716         https://bugs.webkit.org/show_bug.cgi?id=138411
1717
1718         Reviewed by Philippe Normand.
1719
1720         Add a test case to check that user script messages sent using the
1721         DOM bindings API are also received in the UI process.
1722
1723         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1724         (UserScriptMessageTest::waitUntilMessageReceived):
1725         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1726         (testUserContentManagerScriptMessageFromDOMBindings):
1727         (beforeAll):
1728         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1729         (documentLoadedCallback):
1730
1731 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1732
1733         Unreviewed. Fix GTK+ clean build after r175930.
1734
1735         Partial rollout of r175930 to not build the new unit test that
1736         broke clean builds in GTK+ port.
1737
1738         * TestWebKitAPI/PlatformGTK.cmake:
1739
1740 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1741
1742         [WK2] UserMediaClient support
1743         https://bugs.webkit.org/show_bug.cgi?id=123158
1744
1745         Reviewed by Benjamin Poulain.
1746
1747         Simple API test for the UserMedia permission request API. The
1748         required test infrastructure is also added, inspired by the
1749         Geolocation infrastructure.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1752         Permission request.
1753         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1754         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1755         (TestWebKitAPI::TEST):
1756         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1757         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1758         helper method to set the permission request result without user interaction.
1759         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1760         (WTR::InjectedBundle::setUserMediaPermission):
1761         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1763         (WTR::TestRunner::setUserMediaPermission):
1764         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1765         * WebKitTestRunner/TestController.cpp:
1766         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1767         request handler.
1768         (WTR::TestController::createOtherPage): Enable the new UserMedia
1769         permission request handler.
1770         (WTR::TestController::createWebViewWithOptions): Ditto.
1771         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1772         MediaStream support, this is needed for getUserMedia.
1773         (WTR::TestController::resetStateToConsistentValues): clear
1774         UserMedia permissions list and flags.
1775         (WTR::TestController::setUserMediaPermission): Set permission
1776         request result and distpatch it.
1777         (WTR::TestController::handleUserMediaPermissionRequest): Save
1778         request and dispatch it.
1779         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1780         Dispatch cached permission requests.
1781         * WebKitTestRunner/TestController.h:
1782         * WebKitTestRunner/TestInvocation.cpp:
1783         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1784
1785 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1786
1787         webkit-patch --suggest-reviewers is broken with newer versions of git
1788         <http://webkit.org/b/138627>
1789
1790         Reviewed by Michael Saboff with feedback from Daniel Bates.
1791
1792         * Scripts/webkitpy/common/checkout/scm/git.py:
1793         (Git._changes_files_for_commit): Strip blank lines instead of
1794         assuming there is always a blank line at the beginning of the
1795         list.
1796
1797 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1798
1799         DRT and WKTR touch disk cache
1800         https://bugs.webkit.org/show_bug.cgi?id=138622
1801
1802         Reviewed by Geoffrey Garen.
1803
1804         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1805         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1806         because this function uses the shared cache.
1807
1808         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1809         Create an empty shared cache to prevent a default one from being created on disk.
1810
1811 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1812
1813         [CSS Grid Layout] Limit the size of explicit/implicit grid
1814         https://bugs.webkit.org/show_bug.cgi?id=136217
1815
1816         Reviewed by Andreas Kling.
1817
1818         Added a new unit test for the CSS parser. Right now it only checks
1819         that we properly clamp the maximum number of tracks on a grid to a
1820         maximum of 1 million.
1821
1822         * TestWebKitAPI/CMakeLists.txt:
1823         * TestWebKitAPI/PlatformEfl.cmake:
1824         * TestWebKitAPI/PlatformGTK.cmake:
1825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1826         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1827         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1828         (TestWebKitAPI::TEST): Added a
1829         CSSPropertyParserTest.GridTrackLimits test case.
1830
1831 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1832
1833         webkitpy test fix after r175867
1834         https://bugs.webkit.org/show_bug.cgi?id=138607
1835
1836         Reviewed by Philippe Normand.
1837
1838         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1839         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1840
1841 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1842
1843         webkitpy: demangle C++ symbols from crash log stderr
1844         https://bugs.webkit.org/show_bug.cgi?id=138565
1845
1846         Reviewed by Alexey Proskuryakov.
1847
1848         * Scripts/webkitpy/port/linux_get_crash_log.py:
1849         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1850         with c++filt.
1851
1852 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1853
1854         [GTK] fix up the GDB backtrace report tool
1855         https://bugs.webkit.org/show_bug.cgi?id=138564
1856
1857         Reviewed by Carlos Garcia Campos.
1858
1859         * Scripts/webkitpy/port/gtk.py:
1860         (GtkPort._get_crash_log): Match the process name reported by the
1861         driver with the GTK port WebProcess executable filename.
1862         * Scripts/webkitpy/port/linux_get_crash_log.py:
1863         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1864         program.
1865         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1866         pattern to workaround the 16 characters size limit of %e.
1867
1868 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1869
1870         Unreviewed, moved myself to the list of committers.
1871
1872         * Scripts/webkitpy/common/config/contributors.json:
1873
1874 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1875
1876         [EFL] Fix the test font path after r175555.
1877
1878         Reviewed by Csaba Osztrogonác.
1879
1880         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1881
1882 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1883
1884         Fix the exception fuzz helper to generate targets in the correct range
1885         https://bugs.webkit.org/show_bug.cgi?id=138544
1886
1887         Reviewed by Filip Pizlo.
1888
1889         Currently, the script generates exception fuzz targets in the range of
1890         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1891         always outside of the outermost try block of the tests, which therefore
1892         prints unexpected output and results in false failures when fired at.
1893         Additionally, target $checkCount is never generated.
1894
1895         This patch fixes the script to generate targets in the range of
1896         2..$checkCount.
1897
1898         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1899
1900 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1901
1902         make-passwords-json.py should generarate everything needed for testing
1903         https://bugs.webkit.org/show_bug.cgi?id=138503
1904
1905         Reviewed by Ryosuke Niwa.
1906
1907         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1908         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1909         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1910         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1911         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1912         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1913         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1914
1915 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1916
1917         [GTK] generate-gtkdoc should ignore invalid files
1918         https://bugs.webkit.org/show_bug.cgi?id=138542
1919
1920         Reviewed by Darin Adler.
1921
1922         * gtk/generate-gtkdoc:
1923         (files_to_ignore.file_should_be_ignored): Return True to ignore
1924         invalid files.
1925
1926 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1927
1928         Delete cookies between tests
1929         https://bugs.webkit.org/show_bug.cgi?id=138528
1930
1931         Reviewed by Sam Weinig.
1932
1933         * DumpRenderTree/mac/DumpRenderTree.mm:
1934         (resetWebPreferencesToConsistentValues):
1935         * WebKitTestRunner/TestController.cpp:
1936         (WTR::TestController::resetPreferencesToConsistentValues):
1937         Do it.
1938
1939         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1940         (WTR::InjectedBundle::beginTesting):
1941         Added a FIXME.
1942
1943 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1944
1945         [GTK] Run layout tests using the network process
1946         https://bugs.webkit.org/show_bug.cgi?id=138428
1947
1948         Reviewed by Martin Robinson.
1949
1950         Shared secondary process is the default in the GTK+ port, but we
1951         should run the tests using the network process to ensure
1952         everything works with the network process. In the future, the
1953         shared secondary process model might be a special case of multiple
1954         processes with 1 as maximum number of processes, but always using
1955         the network process.
1956
1957         * WebKitTestRunner/TestController.cpp:
1958         (WTR::TestController::initialize):
1959
1960 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         [GTK] Allow to create a view with a related page in WTR
1963         https://bugs.webkit.org/show_bug.cgi?id=138501
1964
1965         Reviewed by Martin Robinson.
1966
1967         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1968         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1969         related page to WKViewCreate.
1970         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1971         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1972         page to WKViewCreate.
1973
1974 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1975
1976         WTR crashes after running a test when NetworkProcess enabled
1977         https://bugs.webkit.org/show_bug.cgi?id=138500
1978
1979         Reviewed by Alexey Proskuryakov.
1980
1981         WebNotificationProvider destructor is calling
1982         WKNotificationManagerSetProvider, but m_notificationManager is
1983         null because removeNotificationManager was already called.
1984
1985         * WebKitTestRunner/WebNotificationProvider.cpp:
1986         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1987         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1988
1989 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1990
1991         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1992         regarding incorrect call to PatchAnalysisTask.report_failure
1993         https://bugs.webkit.org/show_bug.cgi?id=138229
1994
1995         Reviewed by Daniel Bates.
1996
1997         * Scripts/webkitpy/common/net/layouttestresults.py:
1998         Makes sure test_results returns a list.
1999         (LayoutTestResults.test_results):
2000         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2001         Makes unit tests also check to make sure
2002         task.results_from_patch_test_run() and
2003         task.results_from_test_run_without_patch return instances of
2004         LayoutTestResults.
2005         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2006         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2007         Condenses duplicate code into _should_defer_patch_or_throw, and
2008         removes the now-unused _clean_tree_results member.
2009         (PatchAnalysisTask.__init__):
2010         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2011         (PatchAnalysisTask._should_defer_patch_or_throw):
2012         (PatchAnalysisTask._test_patch):
2013         (PatchAnalysisTask.results_from_patch_test_run):
2014         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
2015         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2016         Removes needless call to results_from_test_run_without_patch
2017         (AbstractEarlyWarningSystem._failing_tests_message):
2018         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2019         Changes order of test failure messages to be in the order that they
2020         appear.
2021         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2022         * Scripts/webkitpy/tool/commands/queues.py:
2023         Removes needless call to results_from_test_run_without_patch.
2024         (CommitQueue._failing_tests_message):
2025         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2026         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
2027
2028 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
2029
2030         Unreviewed. Reorder my e-mail addresses in contributors.json
2031
2032         * Scripts/webkitpy/common/config/contributors.json:
2033
2034 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
2035
2036         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
2037         https://bugs.webkit.org/show_bug.cgi?id=138475
2038
2039         Reviewed by Ryosuke Niwa.
2040
2041         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
2042         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
2043         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
2044         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
2045
2046         * Scripts/webkitpy/common/checkout/scm/git.py:
2047         (Git._run_git_svn_find_rev):
2048         Add comment mentioning that svn_revisions need to begin with 'r'.
2049         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
2050         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
2051         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
2052
2053 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         [GTK] Add context menu API to Web Process Extensions
2056         https://bugs.webkit.org/show_bug.cgi?id=138311
2057
2058         Reviewed by Gustavo Noronha Silva.
2059
2060         Add tests cases for WebKitWebPage::context-menu signal.
2061
2062         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2063         (testContextMenuWebExtensionMenu):
2064         (testContextMenuWebExtensionNode):
2065         (beforeAll):
2066         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2067         (serializeContextMenu):
2068         (serializeNode):
2069         (contextMenuCallback):
2070         (pageCreatedCallback):
2071
2072 2014-11-06  Commit Queue  <commit-queue@webkit.org>
2073
2074         Unreviewed, rolling out r175690.
2075         https://bugs.webkit.org/show_bug.cgi?id=138460
2076
2077         We are not ready to run layout tests using the network process
2078         yet (Requested by KaL on #webkit).
2079
2080         Reverted changeset:
2081
2082         "[GTK] Run layout tests using the network process"
2083         https://bugs.webkit.org/show_bug.cgi?id=138428
2084         http://trac.webkit.org/changeset/175690
2085
2086 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2087
2088         [GTK] Run layout tests using the network process
2089         https://bugs.webkit.org/show_bug.cgi?id=138428
2090
2091         Reviewed by Martin Robinson.
2092
2093         Shared secondary process is the default in the GTK+ port, but we
2094         should run the tests using the network process to ensure
2095         everything works with the network process. In the future, the
2096         shared secondary process model might be a special case of multiple
2097         processes with 1 as maximum number of processes, but always using
2098         the network process.
2099
2100         * WebKitTestRunner/TestController.cpp:
2101         (WTR::TestController::initialize):
2102
2103 2014-11-05  Dan Bernstein  <mitz@apple.com>
2104
2105         Remove the unused deletion UI feature
2106         https://bugs.webkit.org/show_bug.cgi?id=138442
2107
2108         Rubber-stamped by Alexey Proskuryakov.
2109
2110         * DumpRenderTree/mac/EditingDelegate.mm:
2111         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
2112         delegate method that’s been removed.
2113
2114 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
2115
2116         fast/dom/remove-body-during-body-replacement2.html fails on WK2
2117         https://bugs.webkit.org/show_bug.cgi?id=138334
2118
2119         Reviewed by Anders Carlsson.
2120
2121         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
2122         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
2123         -makeFirstResponder calls, which may or may not be needed for other reasons, but
2124         it also needs to reset internal focus explicitly.
2125
2126         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
2127         WebKit behavior appears wrong, but it matches Firefox.
2128
2129         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2130         (WTR::InjectedBundlePage::resetAfterTest):
2131
2132 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
2135         https://bugs.webkit.org/show_bug.cgi?id=137862
2136
2137         Reviewed by Gustavo Noronha Silva.
2138
2139         Add a test case to check that WebKitWebResource::failed-with-tls-errors
2140         is emitted when a subresource load fails due to TLS errors.
2141
2142         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2143         (TLSSubresourceTest::resourceLoadStartedCallback):
2144         (TLSSubresourceTest::TLSSubresourceTest):
2145         (TLSSubresourceTest::subresourceFailedCallback):
2146         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
2147         (TLSSubresourceTest::subresourceLoadStarted):
2148         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
2149         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
2150         (testSubresourceLoadFailedWithTLSErrors):
2151         (httpsServerCallback):
2152         (httpServerCallback):
2153         (beforeAll):
2154
2155 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
2156
2157         Build fix for some compiler versions.
2158
2159         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
2160         unhappy because this is a getter, and these shouldn't have side effects.
2161
2162 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2163
2164         Add a method for performing cherrypick-merges.
2165         https://bugs.webkit.org/show_bug.cgi?id=138375
2166
2167         Reviewed by Ryosuke Niwa.
2168
2169         Adds support for cherrypick-merges.
2170
2171         * Scripts/webkitpy/common/checkout/scm/git.py:
2172         (Git.cherrypick_merge): Added.
2173
2174 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2175
2176         Add a way to ascertain the SVN URL associated with a Git branch.
2177         https://bugs.webkit.org/show_bug.cgi?id=138374
2178
2179         Reviewed by Ryosuke Niwa.
2180
2181         The svn_url method returns the SVN URL associated with the current Git branch.
2182
2183         * Scripts/webkitpy/common/checkout/scm/git.py:
2184         (Git.svn_url): Added.
2185
2186 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2187
2188         Add the ability to search for modifications that are staged for commit.
2189         https://bugs.webkit.org/show_bug.cgi?id=138373
2190
2191         Reviewed by Ryosuke Niwa and Daniel Bates.
2192
2193         This makes is easy to do identify files that require merge post-processing,
2194         in addition to stand-alone utility.
2195
2196         * Scripts/webkitpy/common/checkout/scm/git.py:
2197         (Git.modifications_staged_for_commit): Added.
2198
2199 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2200
2201         Add a branch keyword argument to _run_git_svn_find_rev.
2202         https://bugs.webkit.org/show_bug.cgi?id=138372
2203
2204         Reviewed by Ryosuke Niwa.
2205
2206         The addition of this keyword argument allows clients to determine the Git hash
2207         of commits made on an SVN branch, provided that branch has been fetched locally.
2208
2209         * Scripts/webkitpy/common/checkout/scm/git.py:
2210         (Git._run_git_svn_find_rev):
2211         Add a branch keyword argument that is added to the end of the command, if present.
2212
2213 2014-11-04  Chris Dumez  <cdumez@apple.com>
2214
2215         Add ptr() method to Ref class
2216         https://bugs.webkit.org/show_bug.cgi?id=138361
2217
2218         Reviewed by Darin Adler.
2219
2220         Use the new Ref::ptr() method.
2221
2222         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2223         (TestWebKitAPI::TEST):
2224
2225 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2226
2227         [jhbuild] Make it possible to build GTK/EFL in same repository
2228         https://bugs.webkit.org/show_bug.cgi?id=137448
2229
2230         Reviewed by Martin Robinson.
2231
2232         * Scripts/webkitdirs.pm:
2233         (getJhbuildPath):
2234         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
2235         (getPlatformFontsPath):
2236         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2237         (WTR::getFontsPath):
2238         * jhbuild/jhbuild-wrapper:
2239         (determine_platform):
2240         (install_jhbuild):
2241         * jhbuild/jhbuildrc_common.py:
2242         (init):
2243
2244 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2245
2246         [EFL] Bump LLVM to version 3.5.0
2247         https://bugs.webkit.org/show_bug.cgi?id=138312
2248
2249         Reviewed by Csaba Osztrogonác.
2250
2251         * efl/jhbuild.modules:
2252         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
2253         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
2254
2255 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
2256
2257         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
2258         https://bugs.webkit.org/show_bug.cgi?id=138257
2259
2260         Reviewed by Tim Horton.
2261         
2262         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
2263         the user to toggle region page overlays on and off. Two overlays are available,
2264         for the non-fast scrollable region, and the region of element with wheel
2265         event handlers.
2266
2267         * MiniBrowser/mac/SettingsController.h:
2268         * MiniBrowser/mac/SettingsController.m:
2269         (-[SettingsController _populateMenu]):
2270         (-[SettingsController validateMenuItem:]):
2271         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
2272         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
2273         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
2274         (-[SettingsController toggleDebugOverlay:]):
2275         (-[SettingsController debugOverlayVisible:]):
2276         * MiniBrowser/mac/WK2BrowserWindowController.m:
2277         (-[WK2BrowserWindowController didChangeSettings]):
2278
2279 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
2280
2281         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
2282         https://bugs.webkit.org/show_bug.cgi?id=138323
2283
2284         Reviewed by Zalan Bujtas.
2285
2286         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
2287
2288 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2289
2290         [ninja] Don't remove response files for verbose builds
2291         https://bugs.webkit.org/show_bug.cgi?id=137816
2292
2293         Reviewed by Csaba Osztrogonác.
2294
2295         * Scripts/webkitdirs.pm:
2296         (determineNinjaVersion):
2297         (buildCMakeGeneratedProject):
2298
2299 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
2300
2301         [GTK] Fix the build of FTL JIT
2302         https://bugs.webkit.org/show_bug.cgi?id=138298
2303
2304         Reviewed by Carlos Garcia Campos.
2305
2306         * gtk/jhbuild-optional.modules:
2307         Bump up LLVM version to 3.5.0 release and apply patches.
2308         * gtk/patches/llvm-elf-add-stackmaps.patch:
2309         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
2310         trunk.
2311         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
2312         Added. Ensures that PC-relative relocations in EH frames are not
2313         truncated to 32 bits on x86_64.
2314
2315 2014-10-31  Michael Saboff  <msaboff@apple.com>
2316
2317         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
2318         https://bugs.webkit.org/show_bug.cgi?id=138268
2319
2320         Reviewed by Andreas Kling.
2321
2322         Added a --arch and --os option to set or override the values that are
2323         normally computed based on examining the JavaScriptCore we want to test.
2324
2325         * Scripts/run-jsc-stress-tests:
2326
2327 2014-10-31  Dan Bernstein  <mitz@apple.com>
2328
2329         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
2330         https://bugs.webkit.org/show_bug.cgi?id=138259
2331
2332         Reviewed by Geoff Garen.
2333
2334         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
2335         going to be empty to silence the warning.
2336
2337 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
2338
2339         [GTK] Support script message handlers WebKitUserContentManager
2340         https://bugs.webkit.org/show_bug.cgi?id=133730
2341
2342         Reviewed by Carlos Garcia Campos.
2343
2344         Support user script message handlers in WebKitUserContentManager.
2345         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
2346         an option is added to the CMake build files. The option is disabled
2347         globally by default, and the WebKitGTK port enables it. On the API
2348         level, two new methods to register and unregister names are provided
2349         in the "window.webkit" namespace, and on message reception the
2350         "WebKitUserContentManager::script-message-received" signal is
2351         emitted, using the registered names as signal detail.
2352
2353         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2354         Add test case for user script message handlers.
2355         (scriptMessageReceived):
2356         (testUserContentManagerScriptMessageReceived):
2357         (beforeAll):
2358
2359 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2360
2361         bisect-builds should support WebKit clients other than Safari
2362         https://bugs.webkit.org/show_bug.cgi?id=138225
2363
2364         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
2365
2366         The -a / --application optional argument allows the user to specify which application (or application bundle)
2367         should be run against the WebKit nightly builds.
2368
2369         Reviewed by David Kilzer.
2370
2371         * Scripts/bisect-builds:
2372         Swap out $safariPath for the more general $applicationPath
2373         Leave --safari-path as a commandline option for backwards compatibility
2374         (mountAndRunNightly):
2375         Use File::Spec->cat correctly (one directory per argument)
2376         Use open --wait-apps instead of running the target application directly
2377
2378 2014-10-30  Dana Burkart  <dburkart@apple.com>
2379
2380         <rdar://problem/18821260> Perpare for the mysterious future
2381
2382         Reviewed by Lucas Forschler.
2383
2384         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2385         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2386         * LayoutTestRelay/Configurations/Base.xcconfig:
2387         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2388         * MiniBrowser/Configurations/Base.xcconfig:
2389         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2390         * TestWebKitAPI/Configurations/Base.xcconfig:
2391         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2392         * WebKitLauncher/Configurations/Base.xcconfig:
2393         * WebKitTestRunner/Configurations/Base.xcconfig:
2394         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2395
2396 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2397
2398         Update safariVersion to safariVersionString
2399         https://bugs.webkit.org/show_bug.cgi?id=138193
2400
2401         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
2402         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
2403
2404         Rubber-stamped by David Kilzer.
2405
2406         * Scripts/bisect-builds:
2407         (makeNightlyList):
2408         Compare safariVersionString to a string literal, instead of safariVersion.
2409
2410 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
2411
2412         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
2413         https://bugs.webkit.org/show_bug.cgi?id=137775
2414
2415         Reviewed by Carlos Garcia Campos.
2416
2417         * MiniBrowser/gtk/BrowserWindow.c:
2418         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
2419         (browser_window_init):
2420
2421 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
2422
2423         CommitQueue and EWS should reject any patches that result in consistent test
2424         failures that aren't present on the tree.
2425         https://bugs.webkit.org/show_bug.cgi?id=138184
2426
2427         Reviewed by Alexey Proskuryakov.
2428
2429         * Scripts/webkitpy/layout_tests/models/test_results.py:
2430         Adds a simple hashing function to allow for set operations to handle
2431         TestResult objects properly.
2432         (TestResult.__hash__):
2433         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2434         Adds one unit test, and modifies others to agree with the notion that
2435         patches that introduce new test failures (but also have flakyness)
2436         should be rejected rather than spin.
2437         (MockCommitQueue.report_flaky_tests):
2438         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2439         (test_double_flaky_test_failure):
2440         (test_two_flaky_tests):
2441         (test_very_flaky_patch):
2442         (test_very_flaky_patch_with_some_tree_redness):
2443         (test_different_test_failures):
2444         (test_different_test_failures_with_some_tree_redness):
2445         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
2446         (test_mildly_flaky_patch):
2447         (test_mildly_flaky_patch_with_some_tree_redness):
2448         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2449         Makes PatchAnalysisTask reject said patches.
2450         (PatchAnalysisTask._test_patch):
2451
2452 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2453
2454         WinCairoRequirements.zip cannot be downloaded from dropbox
2455         https://bugs.webkit.org/show_bug.cgi?id=138113
2456
2457         Reviewed by Alexey Proskuryakov.
2458
2459         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
2460
2461 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
2462
2463         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
2464         https://bugs.webkit.org/show_bug.cgi?id=138193
2465
2466         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
2467         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
2468
2469         It also does a bit of refactoring, including distinguishing between versions and version strings and
2470         saving versions to local variables instead of using eval in each conditional.
2471
2472         Reviewed by David Kilzer.
2473
2474         * Scripts/bisect-builds:
2475         (makeNightlyList):
2476         Restrict the set of nightlies to r174650 and above when running Yosemite.
2477         Restrict the set of nightlies to r157846 and above when running Mavericks.
2478         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
2479
2480 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2481
2482         [EFL] build-webkit should try harder to avoid re-running cmake
2483         https://bugs.webkit.org/show_bug.cgi?id=137949
2484
2485         Reviewed by Martin Robinson.
2486
2487         * Scripts/webkitdirs.pm:
2488         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
2489         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
2490
2491 2014-10-28  Daniel Bates  <dabates@apple.com>
2492
2493         Unify logic in RunTests.run() to run the Python unit tests
2494         https://bugs.webkit.org/show_bug.cgi?id=138160
2495
2496         Reviewed by Martin Robinson.
2497
2498         Unify the interactive and non-interactive code path for running the Python unit tests
2499         in step RunTests so as to remove duplicate code to compute the the path to the script
2500         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
2501
2502         No new tests since no functionality was changed.
2503
2504         * Scripts/webkitpy/port/base.py:
2505         (Port.python_unittest_results_directory):
2506         * Scripts/webkitpy/tool/steps/runtests.py:
2507         (RunTests.run):
2508
2509 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
2510
2511         Make runtest.py call test-webkitpy with the --json flag when in
2512         non-interactive mode.
2513         https://bugs.webkit.org/show_bug.cgi?id=137667
2514
2515         Reviewed by Daniel Bates.
2516
2517         * Scripts/webkitpy/port/base.py:
2518         Adds the python_unittest_results_directory method.
2519         (Port.python_unittest_results_directory):
2520         * Scripts/webkitpy/tool/steps/runtests.py:
2521         Changes RunTests to call test-webkitpy with the --json flag if the
2522         --non-interactive flag is set.
2523         (RunTests):
2524         (RunTests.run):
2525
2526 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
2527
2528         import-w3c-tests should use re.escape() wherever it's handling file paths
2529         https://bugs.webkit.org/show_bug.cgi?id=137934
2530
2531         This patch adds re.escape() to a few places where we're doing string
2532         conversions. This prevents errors when attribute values coincidentally
2533         have character sequences that can be interpreted as regular expressions.
2534
2535         Reviewed by Bem Jones-Bey.
2536
2537         * Scripts/webkitpy/w3c/test_converter.py:
2538         (_W3CTestConverter.convert_attributes_if_needed):
2539
2540 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2541
2542         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
2543         https://bugs.webkit.org/show_bug.cgi?id=138130
2544
2545         Reviewed by Csaba Osztrogonác.
2546
2547         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2548
2549 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
2550
2551         Fix link to Arch Linux Wiki
2552         https://bugs.webkit.org/show_bug.cgi?id=138010
2553
2554         Reviewed by Benjamin Poulain.
2555
2556         * gtk/install-dependencies:
2557
2558 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
2559
2560         Test regressions are not detected when image result is missing
2561         https://bugs.webkit.org/show_bug.cgi?id=138070
2562
2563         Reviewed by Simon Fraser.
2564
2565         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2566         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2567         Count these as regressions, not as flaky tests.
2568
2569         * Scripts/webkitpy/port/test.py:
2570         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2571         Test it.
2572
2573 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2574
2575         Add Conrad Shultz to the contributors list.
2576
2577         * Scripts/webkitpy/common/config/contributors.json:
2578
2579 2014-10-24  Dan Bernstein  <mitz@apple.com>
2580
2581         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2582         https://bugs.webkit.org/show_bug.cgi?id=138046
2583
2584         Reviewed by Alexey Proskuryakov.
2585
2586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2587         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2588         401. Otherwise, we’ll retry normally in 45 seconds.
2589
2590 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2591
2592         [GTK] Implement is_selected method on WebKitHitTestResult
2593         https://bugs.webkit.org/show_bug.cgi?id=137110
2594
2595         Reviewed by Tim Horton.
2596
2597         Add tests for new context SELECTION on WebKitHitTestResult.
2598
2599         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2600         (testContextMenuDefaultMenu):
2601         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2602         (testWebViewMouseTarget):
2603
2604 2014-10-23  Roger Fong  <roger_fong@apple.com>
2605
2606         [Win] Skip failing JSC tests following r175078
2607         https://bugs.webkit.org/show_bug.cgi?id=130967.
2608
2609         * Scripts/run-javascriptcore-tests:
2610
2611 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2612
2613         commitqueuetask_unittest.py should be made more concise.
2614         https://bugs.webkit.org/show_bug.cgi?id=137985
2615
2616         Reviewed by Alexey Proskuryakov.
2617
2618         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2619         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2620         (MockCommitQueue.__init__):
2621         (MockCommitQueue.report_flaky_tests):
2622         (MockCommitQueue):
2623         (MockCommitQueue.get_reported_flaky_tests):
2624         (MockSimpleTestPlanCommitQueue.__init__):
2625         (MockSimpleTestPlanCommitQueue.run_command):
2626         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2627         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2628         (test_land_failure):
2629         (test_failed_archive):
2630         (test_double_flaky_test_failure):
2631         (test_test_failure):
2632         (test_red_test_failure):
2633         (test_very_red_tree_retry):
2634         (test_red_tree_patch_rejection):
2635         (test_one_flaky_test):
2636         (test_tree_more_red_than_patch):
2637         (MockCommitQueue.test_results): Deleted.
2638         (test_simple_flaky_test_failure): Deleted.
2639         (_expect_validate): Deleted.
2640         (_expect_validate.MockDelegate): Deleted.
2641         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2642         (_expect_validate.MockDelegate.expected_failures): Deleted.
2643         (_mock_patch): Deleted.
2644         (test_validate): Deleted.
2645         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2646         Fixes a bug that slipped through the cracks prior to this change.
2647         (PatchAnalysisTask._test_patch):
2648
2649 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2650
2651         Flakiness dashboard should support OS X Yosemite
2652         https://bugs.webkit.org/show_bug.cgi?id=137986
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         * TestResultServer/app.yaml:
2657         * TestResultServer/static-dashboards/builders.jsonp:
2658         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2659
2660 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2661
2662         commitqueuetask should include more tests to ensure that the behavior
2663         of PatchAnalysisTask._test_patch() is well defined
2664         https://bugs.webkit.org/show_bug.cgi?id=137977
2665
2666         Reviewed by Alexey Proskuryakov.
2667
2668         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2669         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2670         and more readable to define tests that are meant to test the behaviour
2671         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2672         (FailingTestCommitQueue.test_results):
2673         (PatchAnalysisResult):
2674         (MockSimpleTestPlanCommitQueue):
2675         (MockSimpleTestPlanCommitQueue.__init__):
2676         (MockSimpleTestPlanCommitQueue.run_command):
2677         (MockSimpleTestPlanCommitQueue._mock_test_result):
2678         (MockSimpleTestPlanCommitQueue.test_results):
2679         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2680         (test_flaky_test_failure):
2681         (test_failed_archive):
2682         (test_two_flaky_tests):
2683         (test_one_flaky_test):
2684         (test_very_flaky_patch):
2685         (test_very_flaky_patch_with_some_tree_redness):
2686         (test_different_test_failures):
2687         (test_different_test_failures_with_some_tree_redness):
2688         (test_mildly_flaky_patch):
2689         (test_mildly_flaky_patch_with_some_tree_redness):
2690         (test_tree_more_red_than_patch):
2691
2692 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2693
2694         PatchAnalysisTask._test_patch() needs refactoring
2695         https://bugs.webkit.org/show_bug.cgi?id=137904
2696
2697         Reviewed by Alexey Proskuryakov.
2698
2699         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2700         Fixes several small bugs, and makes minor changes to accomodate the
2701         changes in PatchAnalysisTask.
2702         (MockCommitQueue.refetch_patch):
2703         (MockCommitQueue.test_results):
2704         (test_flaky_test_failure):
2705         (test_failed_archive):
2706         (test_very_red_tree_retry):
2707         (_expect_validate.MockDelegate.refetch_patch):
2708         (MockCommitQueue.expected_failures): Deleted.
2709         (_expect_validate.MockDelegate.expected_failures): Deleted.
2710         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2711         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2712         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2713         Removes the unexpected_failures member, adds the _clean_tree_results
2714         member, adds a helper function for _test_patch, and refactors
2715         _test_patch to be more readable.
2716         (PatchAnalysisTask.__init__):
2717         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2718         (PatchAnalysisTask._test_patch):
2719         (PatchAnalysisTask.results_from_test_run_without_patch):
2720         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2721         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2722         (AbstractEarlyWarningSystem.begin_work_queue):
2723         (AbstractEarlyWarningSystem._failing_tests_message):
2724         (AbstractEarlyWarningSystem.command_failed):
2725         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2726         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2727         Makes changes to accomodate the changes made to PatchAnalysisTask.
2728         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2729         * Scripts/webkitpy/tool/commands/perfalizer.py:
2730         Removes Perfalizer's dependancy on ExpectedFailures. 
2731         (PerfalizerTask.refetch_patch):
2732         (PerfalizerTask.expected_failures): Deleted.
2733         * Scripts/webkitpy/tool/commands/queues.py:
2734         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2735         initializer to allow for mock injection.
2736         (CommitQueue.__init__):
2737         (CommitQueue.begin_work_queue):
2738         (CommitQueue.process_work_item):
2739         (CommitQueue._failing_tests_message):
2740         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2741         Removes dependancy on ExpectedFailures, and instead uses mock
2742         injection.
2743         (MockCommitQueueTask):
2744         (MockCommitQueueTask.results_from_patch_test_run):
2745         (MockCommitQueueTask.results_from_test_run_without_patch):
2746         (mock_run_webkit_patch):
2747
2748 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2749
2750         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2751         https://bugs.webkit.org/show_bug.cgi?id=136736
2752
2753         Reviewed by Gyuyoung Kim.
2754
2755         * MiniBrowser/efl/main.c:
2756         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2757         (window_create):
2758
2759 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2762         https://bugs.webkit.org/show_bug.cgi?id=137884
2763
2764         Reviewed by Gustavo Noronha Silva.
2765
2766         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2767         and adapt it to use the new InputMethodFilter WebKit class. Instead
2768         of having virtual methods just for testing, it has a testing mode
2769         that logs the events.
2770
2771         * TestWebKitAPI/PlatformGTK.cmake:
2772         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2773         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2774         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2775         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2776         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2777         (TestWebKitAPI::TEST):
2778         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2779         (TestWebKitAPI::temporaryResetOverride):
2780         (TestWebKitAPI::verifyCanceledComposition):
2781
2782 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2783
2784         build.webkit.org/dashboard: Cannot click on green tester bubbles
2785         https://bugs.webkit.org/show_bug.cgi?id=137909
2786
2787         Reviewed by Darin Adler.
2788
2789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2790         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2791
2792 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2793
2794         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2795         https://bugs.webkit.org/show_bug.cgi?id=137932
2796
2797         Reviewed by Simon Fraser.
2798
2799         This is the first step in moving over to native Windows rendering for our layout tests.
2800         Once this change lands, approximately 300 tests will start failing on Windows. I will
2801         rebaseline these changes against our test hardware and update this bug with the
2802         commits related to that work.
2803
2804         * DumpRenderTree/win/DumpRenderTree.cpp:
2805         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2806         we use native Windows drawing style.
2807
2808 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2809
2810         Fix FTL Native Inlining for EFL
2811         https://bugs.webkit.org/show_bug.cgi?id=137774
2812
2813         Reviewed by Michael Saboff.
2814
2815         Added Clang as an optional module to jhbuild.
2816
2817         * efl/jhbuild.modules:
2818
2819 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2820
2821         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2822         https://bugs.webkit.org/show_bug.cgi?id=137832
2823
2824         Reviewed by Carlos Garcia Campos.
2825
2826         Ensure each test sets the TLS errors policy that it really needs.
2827         Have each test except testTLSErrorsPolicy stash and restore the original
2828         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2829         default policy.
2830
2831         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2832         (testSSL):
2833         (testInsecureContent):
2834         (testTLSErrorsPolicy):
2835         (testTLSErrorsRedirect):
2836         (testTLSErrorsHTTPAuth):
2837         (testLoadFailedWithTLSErrors):
2838         (beforeAll):
2839
2840 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2841
2842         Unreviewed. Unskip inspector server unit tests.
2843
2844         They should pass now.
2845
2846         * Scripts/run-gtk-tests:
2847         (TestRunner):
2848
2849 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2850
2851         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2852         https://bugs.webkit.org/show_bug.cgi?id=132044
2853
2854         Reviewed by Brian Burg.
2855
2856         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2857         (openRemoteDebuggingSession): Remove trailing slash when
2858         concatenating base inspector URL with the page, because the
2859         inspector returns the relative paths with a leading slash.
2860
2861 2014-10-20  Tanay C  <tanay.c@samsung.com>
2862
2863         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2864         https://bugs.webkit.org/show_bug.cgi?id=137023
2865
2866         Reviewed by Gyuyoung Kim.
2867
2868         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2869         (search_box_show): Modified.
2870         (search_box_hide): Modified.
2871         (on_search_field_activated): Modified.
2872         (on_search_backward_button_clicked): Modified.
2873         (on_search_forward_button_clicked): Modified.
2874         (on_search_case_option_changed): Added.
2875         (on_search_word_start_option_changed): Added.
2876         (window_create): Modified.
2877
2878 2014-10-20  Tanay C  <tanay.c@samsung.com>
2879
2880         [GTK][Minibrowser] Escape key does not hide the search box
2881         https://bugs.webkit.org/show_bug.cgi?id=137734
2882
2883         Reviewed by Philippe Normand.
2884
2885         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2886         (stopPageLoad): Modified.
2887
2888 2014-10-18  Antti Koivisto  <antti@apple.com>
2889
2890         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2891         https://bugs.webkit.org/show_bug.cgi?id=137855
2892
2893         Reviewed by Dan Bernstein.
2894
2895         Test and warn if the dumped response mime type differs from the platform response mime type.
2896
2897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2898         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2899         (WTR::InjectedBundlePage::platformResponseMimeType):
2900         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2901         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2902         (WTR::InjectedBundlePage::platformResponseMimeType):
2903
2904 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2905
2906         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2907         https://bugs.webkit.org/show_bug.cgi?id=137835
2908
2909         Reviewed by Andreas Kling.
2910
2911         * Scripts/run-inspector-perf-tests.py: Removed.
2912         This script is stale, as PerformanceTests/inspector no longer exists.
2913
2914 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2915
2916         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2917
2918         * Scripts/webkitpy/port/ios.py:
2919         (IOSSimulatorPort.default_baseline_search_path):
2920
2921 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2922
2923         [iOS] Simplify test fallback paths for iOS Simulator testing
2924         https://bugs.webkit.org/show_bug.cgi?id=137830
2925
2926         Reviewed by Zalan Bujtas.
2927         
2928         Make the fallback paths be:
2929             ios-simulator -> generic
2930             ios-simulator-wk2->ios-simulator -> generic
2931         
2932         so don't include mac in the fallback path. Also remove the
2933         version handling for simplicity.
2934
2935         * Scripts/webkitpy/port/ios.py:
2936         (IOSSimulatorPort):
2937         (IOSSimulatorPort.default_baseline_search_path):
2938
2939 2014-10-17  Dana Burkart  <dburkart@apple.com>
2940
2941         Fix typos in the dashboard config file.
2942
2943         Unreviewed.
2944
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2946         (WebKitBuildbot):
2947
2948 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2949
2950         [Win] Allow WinLauncher to specify Custom User Agent strings
2951         https://bugs.webkit.org/show_bug.cgi?id=137828
2952
2953         Reviewed by Dean Jackson.
2954
2955         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2956         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2957         and set the user agent strings.
2958         * WinLauncher/WinLauncher.h:
2959         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2960         resources and dialog for setting custom User Agent strings.
2961         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2962
2963 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2964
2965         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2966         https://bugs.webkit.org/show_bug.cgi?id=137806
2967
2968         Reviewed by Sam Weinig.
2969
2970         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2971         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2972         to disable font autosizing.
2973         
2974         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2975         test controller to set platform-specific prefs.
2976
2977         * WebKitTestRunner/TestController.cpp:
2978         (WTR::TestController::resetPreferencesToConsistentValues):
2979         (WTR::TestController::platformResetPreferencesToConsistentValues):
2980         * WebKitTestRunner/TestController.h:
2981         * WebKitTestRunner/ios/TestControllerIOS.mm:
2982         (WTR::TestController::platformResetPreferencesToConsistentValues):
2983         * WebKitTestRunner/mac/TestControllerMac.mm:
2984         (WTR::TestController::platformResetPreferencesToConsistentValues):
2985
2986 2014-10-16  Dan Bernstein  <mitz@apple.com>
2987
2988         OSObjectPtr is missing leakRef()
2989         https://bugs.webkit.org/show_bug.cgi?id=137798
2990
2991         Reviewed by Sam Weinig.
2992
2993         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2994         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2995
2996 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2997
2998         Update target platform to remove Leopard, Snow Leopard, Lion.
2999         Add Yosemite. 
3000         
3001         Unreviewed.
3002
3003         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3004         (_should_file_trigger_build):
3005
3006 2014-10-16  David Kilzer  <ddkilzer@apple.com>
3007
3008         commit-queue: fails to replace OO-PS! with reviewer name
3009         <http://webkit.org/b/137795>
3010
3011         Reviewed by Alexey Proskuryakov.
3012
3013         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3014         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
3015         email addresses to unauthenticated page loads, so we must always
3016         authenticate before getting bug data so we get full email
3017         addresses.
3018
3019 2014-10-16  David Kilzer  <ddkilzer@apple.com>
3020
3021         commit-queue: fails to close bugs after successfully landing patches
3022         <http://webkit.org/b/137794>
3023
3024         Reviewed by Alexey Proskuryakov.
3025
3026         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3027         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
3028         tell Mechanize to use the second <textarea> on the page with
3029         name="comment".
3030
3031 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
3032
3033         [Win] Update DRT to match Mac Logic
3034         https://bugs.webkit.org/show_bug.cgi?id=137787
3035
3036         Reviewed by Dean Jackson.
3037
3038         * DumpRenderTree/win/DumpRenderTree.cpp:
3039         (initialize): 0 -> nullptr
3040         (runTest): Initialize MSG structure before using.
3041         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
3042         Also, cleanly shut down COM when exiting.
3043         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3044         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
3045         header and add printf to match Mac.
3046         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
3047         * DumpRenderTree/win/FrameLoadDelegate.h:
3048         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
3049         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
3050         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3051         (isLocalhost): Added.
3052         (hostIsUsedBySomeTestsToGenerateError): Added.
3053         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
3054         of certain error and redirect host names.
3055         * DumpRenderTree/win/UIDelegate.cpp:
3056         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
3057         anything should be output to the console. This modifies behavior to match the Mac.
3058         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3059         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3060         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3061         (UIDelegate::webViewAddMessageToConsole): Ditto.
3062         * WinLauncher/PageLoadTestClient.cpp:
3063         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
3064         added last week.
3065
3066 2014-10-16  Commit Queue  <commit-queue@webkit.org>
3067
3068         Unreviewed, rolling out r174754.
3069         https://bugs.webkit.org/show_bug.cgi?id=137789
3070
3071         Speculative fix for Windows test was ineffective. (Requested
3072         by rfong on #webkit).
3073
3074         Reverted changeset:
3075
3076         "[Windows] Add some more logging to debug Windows test
3077         issues."
3078         http://trac.webkit.org/changeset/174754
3079
3080 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3081
3082         Unreviewed, add myself to CoordinatedGraphics watchers.
3083
3084         * Scripts/webkitpy/common/config/watchlist:
3085
3086 2014-10-15  Roger Fong  <roger_fong@apple.com>
3087
3088         [Windows] Speculative Windows test fix.
3089
3090         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
3091
3092 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
3093
3094         import-w3c-test rewrites relative src paths in ref files incorrectly
3095         https://bugs.webkit.org/show_bug.cgi?id=137586
3096
3097         This patch fixes a bug in test_converter.py where src paths were getting 
3098         rewritten as ../../some-path instead of <script src="../../some-path>". 
3099         It also adds support for rewriting src paths in style  elements, which was 
3100         missing before and it adds tests for this case.
3101
3102         Reviewed by Bem Jones-Bey.
3103
3104         * Scripts/webkitpy/w3c/test_converter.py:
3105         (_W3CTestConverter.convert_attributes_if_needed):
3106         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3107         (test_convert_attributes_if_needed):
3108         (verify_reference_relative_paths):
3109
3110 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
3111
3112         Add --json flag to test-webkitpy to emit JSON formatted test results
3113         to stdout
3114         https://bugs.webkit.org/show_bug.cgi?id=137353
3115
3116         Reviewed by Daniel Bates.
3117
3118         * Scripts/webkitpy/port/server_process_unittest.py:
3119         Adds the read method to MockFile to allow the stdout of test_webkitpy
3120         to be redirected without causing erroneous test failures.
3121         In particular,
3122         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
3123         and
3124         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
3125         because when redirecting to a file, the
3126         _wait_for_data_and_update_buffers_using_select method in 
3127         server_process.py will find that there is a read file descriptor in
3128         its call to select.select, which eventually leads to it calling read()
3129         on the MockFile object.
3130         (MockFile.read):
3131         * Scripts/webkitpy/test/main.py:
3132         Adds the _print_results_as_json method and the --json flag which
3133         determines whether _print_results_as_json will get called.
3134         (Tester._parse_args):
3135         (Tester._print_results_as_json):
3136         (Tester._print_results_as_json.result_dict_from_tuple):
3137         (Tester._run_tests):
3138
3139 2014-10-13  David Farler  <dfarler@apple.com>
3140
3141         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
3142         https://bugs.webkit.org/show_bug.cgi?id=137662
3143
3144         Reviewed by Darin Adler.
3145
3146         The layout test harness can close LayoutTestRelay's subprocess
3147         stdout and stderr in the case of a timeout or if a run is
3148         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
3149         finds that no one is listening to its stdout/stderr (broken
3150         pipe), then just exit(1), there is nothing to report.
3151
3152         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3153         (-[LTRelayController didReceiveStdoutData:]):
3154         Add @try/@catch for NSFileHandleOperationException.
3155         (-[LTRelayController didReceiveStderrData:]):
3156         Add @try/@catch for NSFileHandleOperationException.
3157
3158 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
3159
3160         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
3161         https://bugs.webkit.org/show_bug.cgi?id=137060
3162
3163         Reviewed by Philippe Normand.
3164
3165         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
3166
3167         * MiniBrowser/gtk/BrowserWindow.c:
3168         (zoomInCallback):
3169         (zoomOutCallback):
3170         (defaultZoomCallback): Callback for default zoom keyboard support.
3171         (browser_window_init):
3172
3173 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
3174
3175         [Mac] DRT stderr logging after the test completes gets attributed to the next test
3176
3177         Reviewed by Alexey Proskuryakov.
3178         
3179         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
3180         logging to stderr to get associated with the next test.
3181         
3182         Fix by logging #EOF to stderr later, after we've completely finished with this test.
3183
3184         * DumpRenderTree/mac/DumpRenderTree.mm:
3185         (dumpTestResults):
3186         (runTest):
3187
3188 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
3189
3190         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
3191
3192         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
3193
3194 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
3195
3196         [cmake] Fix the make build after r174683
3197         https://bugs.webkit.org/show_bug.cgi?id=137703
3198
3199         Reviewed by Martin Robinson.
3200
3201         * Scripts/webkitdirs.pm:
3202         (buildCMakeGeneratedProject):
3203
3204 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3205
3206         Adding myself to the watchlist to CachedFont
3207
3208         Unreviewed.
3209
3210         * Scripts/webkitpy/common/config/watchlist:
3211
3212 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3213
3214         [EFL][GTK] Make it possible to get verbose output with ninja
3215         https://bugs.webkit.org/show_bug.cgi?id=137606
3216
3217         Reviewed by Csaba Osztrogonác.
3218
3219         * Scripts/webkitdirs.pm:
3220         (buildCMakeGeneratedProject):
3221
3222 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3223
3224         [EFL] Make it possible to use ninja for EFL build too
3225         https://bugs.webkit.org/show_bug.cgi?id=137605
3226
3227         Reviewed by Csaba Osztrogonác.
3228
3229         * Scripts/webkitdirs.pm:
3230         (generateBuildSystemFromCMakeProject):
3231         * efl/install-dependencies:
3232
3233 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
3234
3235         [GTK] Minibrowser : Add home buton and keyboard support for home page load
3236         https://bugs.webkit.org/show_bug.cgi?id=137486
3237
3238         Reviewed by Philippe Normand.
3239
3240         * MiniBrowser/gtk/BrowserWindow.c:
3241         (loadHomePage): Callback for home page load.
3242         (browser_window_init):
3243         * MiniBrowser/gtk/BrowserWindow.h:
3244         * MiniBrowser/gtk/main.c:
3245         (main):
3246
3247 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
3248
3249         import-w3c-tests doesn't prefix property values
3250         https://bugs.webkit.org/show_bug.cgi?id=137600
3251
3252         Reviewed by Bem Jones-Bey.
3253
3254         Some property values are prefixed in WebKit. Modified the W3C import
3255         script in order to prefix property values and not only properties.
3256         The patch re-uses most of the already existent logic to prefix
3257         properties.
3258
3259         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
3260         from CSSValueKeywords.in and adapt converter to modify both properties
3261         and property values.
3262         (convert_for_webkit):
3263         (_W3CTestConverter.__init__):
3264         (_W3CTestConverter.output):
3265         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
3266         (_W3CTestConverter):
3267         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
3268         (_W3CTestConverter.add_webkit_prefix_following_regex):
3269         (_W3CTestConverter.convert_reference_relpaths):
3270         (_W3CTestConverter.convert_style_data):
3271         (_W3CTestConverter.convert_attributes_if_needed):
3272         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
3273         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
3274         include checks for property values too.
3275         (W3CTestConverterTest.test_read_prefixed_property_list):
3276         (verify_no_conversion_happened):
3277         (verify_prefixed_properties):
3278         (verify_prefixed_property_values):
3279         (generate_test_content_properties_and_values):
3280         (generate_test_content):
3281         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
3282         prefixed property values and inform about them.
3283         (TestImporter.import_tests):
3284         (TestImporter.write_import_log):
3285
3286 2014-10-13  Jer Noble  <jer.noble@apple.com>
3287
3288         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3289         https://bugs.webkit.org/show_bug.cgi?id=137533
3290
3291         Reviewed by Andy Estes.
3292
3293         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
3294
3295         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3296         (TestWebKitAPI::isMSEEnabledCallback):
3297         (TestWebKitAPI::TEST):
3298
3299 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
3300
3301         [Win] Implement a page load profiling tool
3302         https://bugs.webkit.org/show_bug.cgi?id=137673
3303
3304         Reviewed by Dean Jackson.
3305
3306         Add a tool to capture and summarize page load statistics.
3307
3308         * WinLauncher/Common.cpp:
3309         (parseCommandLine): Move from WinMain.cpp so that it can
3310         be shared with internal tools.
3311         * WinLauncher/PageLoadTestClient.cpp: Added.
3312         (PageLoadTestClient::PageLoadTestClient):
3313         (PageLoadTestClient::pageLoadStartedAtTime):
3314         (PageLoadTestClient::didStartProvisionalLoad):
3315         (PageLoadTestClient::didCommitLoad):
3316         (PageLoadTestClient::didFirstLayoutForMainFrame):
3317         (PageLoadTestClient::didHandleOnLoadEvents):
3318         (PageLoadTestClient::didFinishLoad):
3319         (PageLoadTestClient::didFailLoad):
3320         (PageLoadTestClient::didInitiateResourceLoad):
3321         (PageLoadTestClient::didEndResourceLoad):
3322         (PageLoadTestClient::pageLoadEndedAtTime):
3323         (PageLoadTestClient::endPageLoad):
3324         (PageLoadTestClient::clearPageLoadState):
3325         (PageLoadTestClient::shouldConsiderPageLoadEnded):
3326         (PageLoadTestClient::maybeEndPageLoadSoon):
3327         (PageLoadTestClient::setPageURL):
3328         (PageLoadTestClient::dumpRunStatistics):
3329         * WinLauncher/PrintWebUIDelegate.cpp:
3330         (PrintWebUIDelegate::createWebViewWithRequest): Handle
3331         nullptr URL properly.
3332         * WinLauncher/ResourceLoadDelegate.cpp: Added.
3333         (ResourceLoadDelegate::QueryInterface):
3334         (ResourceLoadDelegate::AddRef):
3335         (ResourceLoadDelegate::Release):
3336         (ResourceLoadDelegate::identifierForInitialRequest):
3337         (ResourceLoadDelegate::willSendRequest):
3338         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3339         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
3340         (ResourceLoadDelegate::didReceiveResponse):
3341         (ResourceLoadDelegate::didReceiveContentLength):
3342         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3343         (ResourceLoadDelegate::didFailLoadingWithError):
3344         (ResourceLoadDelegate::plugInFailedWithError):
3345         * WinLauncher/ResourceLoadDelegate.h: Added.
3346         (ResourceLoadDelegate::ResourceLoadDelegate):
3347         * WinLauncher/WinLauncher.cpp:
3348         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
3349         page loading statistics.
3350         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
3351         and set private load delegate state.
3352         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
3353         that sets the view's resource load delegate.
3354         (WinLauncher::loadURL): If no URL is passed, load the test document.
3355         * WinLauncher/WinLauncher.h:
3356         (WinLauncher::pageLoadTestClient):
3357         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
3358         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
3359         * WinLauncher/WinLauncherWebHost.cpp:
3360         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
3361         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
3362         it could be used from other source files.
3363         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
3364         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
3365         (WinLauncherWebHost::didFailLoadWithError): Ditto.
3366         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
3367         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
3368         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
3369         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3370         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
3371         * WinLauncher/WinLauncherWebHost.h:
3372         * WinLauncher/WinMain.cpp:
3373         (wWinMain): Create and use new delegates for gathering page load data.
3374         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
3375
3376 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3377
3378         Improve the test image diffs page
3379         https://bugs.webkit.org/show_bug.cgi?id=137674
3380
3381         Reviewed by Alexey Proskuryakov.
3382         
3383         Don't treat the input file as a format string, otherwise we have to escape special
3384         characters. Just do a couple of replaces.
3385
3386         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3387         (TestResultWriter.write_image_diff_files):
3388
3389 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3390
3391         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
3392         https://bugs.webkit.org/show_bug.cgi?id=137659
3393
3394         Reviewed by Martin Robinson.
3395
3396         * Scripts/webkitpy/port/xvfbdriver.py:
3397         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
3398
3399 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
3400
3401         Add more detailed wait time information to EWS metrics
3402         https://bugs.webkit.org/show_bug.cgi?id=137649
3403
3404         Reviewed by Daniel Bates.
3405
3406         Added average and worst time (we used to only have median), and also a percentage
3407         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
3408
3409         There is always some wait due to the polling nature of the queues, which is well understood
3410         and doesn't need to be measured. What needs to be measured is whether there is enough
3411         bot machines to process patches as soon as they are submitted.
3412
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3414         (Analyzer.prototype._analyzeBubblePerformance):
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3416         (MetricsBubbleView.prototype._update):
3417
3418 2014-10-11  Jer Noble  <jer.noble@apple.com>
3419
3420         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3421         https://bugs.webkit.org/show_bug.cgi?id=137533
3422
3423         Reviewed by Darin Adler.
3424
3425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3426         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3427         (TestWebKitAPI::TEST):
3428         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
3429         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
3430
3431 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3432
3433         iOS DRT snapshots are limited to the page visible area
3434         https://bugs.webkit.org/show_bug.cgi?id=137650
3435
3436         Reviewed by Daniel Bates.
3437         
3438         LegacyTileCache drawing was limited to the window's visible area, found by
3439         crawling up the layer hierarchy to the root layer. This caused test snapshots to
3440         be missing non-composited content outside the iPhone visible area, which hinders
3441         testing.
3442         
3443         Fix by adding a test-only mode where the window visible area is the entire window.
3444         
3445         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3446         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
3447         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3448         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
3449         for the DRT window.
3450         
3451
3452 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
3453
3454         Page not fully rendered in iOS DRT snapshots
3455         https://bugs.webkit.org/show_bug.cgi?id=137638
3456
3457         Reviewed by Tim Horton.
3458         
3459         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
3460         to ensure that the page has laid out and is rendered by the time we take
3461         the snapshot.
3462
3463         * DumpRenderTree/mac/DumpRenderTree.mm:
3464         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
3465         (-[DumpRenderTree _webThreadInvoked]): Moved.
3466         (-[DumpRenderTree _waitForWebThreadThenDump]):
3467         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
3468         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
3469         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
3470         relies on dispatch_async too, and the inner block won't complete until the outer block
3471         has completed.
3472         (dumpTestResults): Move the guts of dump() here.
3473         (runTest): Whitespace.
3474
3475 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
3476
3477         Adding svn:ignore so that .pyc files don't show up as new.
3478
3479         * Scripts/webkitpy/xcode: Added property svn:ignore.
3480
3481 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
3482
3483         [EFL] Introduce EWebKit_Extension
3484         https://bugs.webkit.org/show_bug.cgi?id=134921
3485
3486         Reviewed by Gyuyoung Kim.
3487
3488         * MiniBrowser/efl/main.c: Added x option to test extension path.
3489         (window_create):
3490         (elm_main):
3491         * Scripts/webkitpy/common/config/watchlist:
3492         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3493         * Scripts/webkitpy/style/checker.py:
3494         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3495
3496 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
3497
3498         After r174628 we send the test process a SIGTERM before the SIGKILL.
3499
3500         * Scripts/webkitpy/common/system/executive_unittest.py:
3501         (ExecutiveTest.serial_test_kill_process):
3502
3503 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
3504
3505         [EFL] Enable WebP support.
3506         https://bugs.webkit.org/show_bug.cgi?id=136156
3507
3508         Reviewed by Gyuyoung Kim.
3509
3510         Include libwebp-dev package to support WebP for WK2 Efl.
3511
3512         * efl/install-dependencies:
3513
3514 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3515
3516         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
3517         https://bugs.webkit.org/show_bug.cgi?id=137485
3518
3519         Reviewed by Sergio Villar Senin.
3520
3521         Update GMainLoopSource tests. Most of the tests are now run twice,
3522         first with a GMainLoopSource and then with a
3523         GThreadSafeMainLoopSource, since both should have the same
3524         behaviour. The threading test uses GThreadSafeMainLoopSource and
3525         the delete on destroy test uses GMainLoopSource. The tests
3526         themselves haven't changed, since there's no change in behaviour.
3527
3528         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3529         (TestWebKitAPI::GMainLoopSourceTest::source):
3530         (TestWebKitAPI::basicRescheduling):
3531         (TestWebKitAPI::TEST):
3532         (TestWebKitAPI::reentrantRescheduling):
3533         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3534         (TestWebKitAPI::basicDestroyCallbacks):
3535         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3536         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3537
3538 2014-10-10  Dana Burkart  <dburkart@apple.com>
3539
3540         Fix fat-fingered function name in git-add-reviewer.
3541
3542         Unreviewed.
3543
3544         * Scripts/git-add-reviewer:
3545         (getConfigValue):
3546
3547 2014-10-10  David Farler  <dfarler@apple.com>
3548
3549         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
3550         https://bugs.webkit.org/show_bug.cgi?id=137528
3551
3552         Reviewed by Simon Fraser.
3553
3554         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
3555         and SIGKILL the paired simulator app before exiting cleanly.
3556
3557         webkitpy only uses SIGKILL to kill processes which you cannot
3558         catch. Send SIGTERM to the process and give it chance to do
3559         its thing before sending SIGKILL. Sending a SIGKILL to an already
3560         dead PID is safe.
3561
3562         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3563         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3564         (-[LTRelayController finish]):
3565         * LayoutTestRelay/LayoutTestRelay/main.m:
3566         (receivedSignal):
3567         (main):
3568
3569 2014-10-10  David Farler  <dfarler@apple.com>
3570
3571         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3572         https://bugs.webkit.org/show_bug.cgi?id=137527
3573
3574         Reviewed by Simon Fraser.
3575
3576         NSFileHandle doesn't notify of EOF in its readability handler.
3577         Use a dispatch_source_t and an event handler that is called when reading is possible.
3578         In the handler block, do a run-of-the-mill read(2) from standard input and
3579         detect EOF in the usual way by checking that zero bytes were read.
3580
3581         Once an EOF is received, the FIFOs are disconnected, the simulator app
3582         is killed, and the relay exits with status 0.
3583
3584         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3585         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3586         (-[LTRelayController didDisconnect]):
3587         (-[LTRelayController didConnect]):
3588         (-[LTRelayController launchApp]):
3589         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3590         confusion with this new dispatch source, called "standardInputDispatchSource".
3591         (-[LTRelayController finish]): Added.
3592         (-[LTRelayController readFileHandle:]): Deleted.
3593
3594 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3595
3596         [EFL] Crash on facebook.com
3597         https://bugs.webkit.org/show_bug.cgi?id=137562
3598
3599         Reviewed by Chris Dumez.
3600
3601         Crash occurs on the facebook.com when the webview is resized
3602         after the <select> item is clicked but no item is chosen.
3603         This crash is just caused by the reference of invalidated variable.
3604         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3605         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3606         on MiniBrowser is called.
3607         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3608
3609         * MiniBrowser/efl/main.c:
3610         (on_popup_menu_hide):
3611
3612 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3613
3614         A small wording change for clarity.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3617         (MetricsBubbleView.prototype._update):
3618
3619 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3620
3621         Dashboard metrics page should have EWS statistics
3622         https://bugs.webkit.org/show_bug.cgi?id=137626
3623
3624         Reviewed by Ryosuke Niwa.
3625
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3627         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3628
3629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3630         (BubbleQueueServer): Re-ordered queues to match bubble order.
3631         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3632         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3633