Force GC between PageLoad tests.
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-03  Philip Rogers  <pdr@google.com>
2
3         Force GC between PageLoad tests.
4         https://bugs.webkit.org/show_bug.cgi?id=98203
5
6         Reviewed by Ryosuke Niwa.
7
8         Previously, our PageLoad PerfTests had multi-modal distributions,
9         typically with a small cluster at 1-2x the median. This turned out
10         to be caused by not garbage collecting between tests!
11
12         This patch adds a new file, force-gc.html, and loads this file between
13         PageLoad tests to force a GC. I manually verified that this cleans up
14         our perf test outliers.
15
16         * Scripts/webkitpy/performance_tests/perftest.py:
17         (PageLoadingPerfTest.__init__):
18         (PageLoadingPerfTest):
19         (PageLoadingPerfTest.run_single):
20
21             This function now loads two pages: one to force a gc and
22             then the test to run.
23
24         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
25
26             Modified several existing tests to show that the force-gc file
27             is loaded.
28
29         (MockPort):
30         (MockPort.__init__):
31         (MockPort.perf_tests_dir):
32         (TestPageLoadingPerfTest.MockDriver.__init__):
33         (TestPageLoadingPerfTest.MockDriver.run_test):
34         (TestPageLoadingPerfTest.test_run):
35         (TestPageLoadingPerfTest.test_run_with_bad_output):
36         (TestReplayPerfTest.ReplayTestPort):
37         (TestReplayPerfTest.ReplayTestPort.__init__):
38         (TestReplayPerfTest.test_run_single.run_test):
39         (TestReplayPerfTest.test_run_single):
40         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
41         (TestPerfTestFactory.test_regular_test):
42         (TestPerfTestFactory.test_inspector_test):
43         (TestPerfTestFactory.test_page_loading_test):
44
45 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
46
47         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
48         https://bugs.webkit.org/show_bug.cgi?id=98231
49
50         Reviewed by Gyuyoung Kim.
51
52         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
53         Call ecore_evas_new() instead of ecore_evas_buffer_new()
54         in EFL's DumpRenderTree and WebKitTestRunner.
55         It is safe to do this now that we are using XvfbDriver
56         for the layout tests.
57
58         * DumpRenderTree/efl/DumpRenderTree.cpp:
59         (parseCommandLineOptions):
60         (initEcoreEvas):
61         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
62         (WTR::initEcoreEvas):
63         * WebKitTestRunner/efl/main.cpp:
64         (main):
65
66 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
67
68         run-webkit-tests tests on win32 after r127302
69         https://bugs.webkit.org/show_bug.cgi?id=98323
70
71         Reviewed by Eric Seidel.
72
73         run-webkit-tests tests on win32 after r127302
74         https://bugs.webkit.org/show_bug.cgi?id=98323
75
76         Reviewed by Eric Seidel.
77
78         Looks like when we converted the json-building logic to use scm
79         to try and get the svn revision, we missed a win32-ism and
80         didn't check to make sure had initialized the scm subsystem.
81
82         This change fixes that and renames _initialize_scm to be a public method.
83
84         * Scripts/webkitpy/common/host.py:
85         (Host.initialize_scm):
86         * Scripts/webkitpy/common/host_mock.py:
87         (MockHost.__init__):
88         (MockHost.initialize_scm):
89         * Scripts/webkitpy/layout_tests/controllers/manager.py:
90         (summarize_results):
91         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
92         (JSONResultsGeneratorBase.get_json):
93         (JSONResultsGeneratorBase._get_result_char):
94         (JSONResultsGeneratorBase._get_svn_revision):
95         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
96         (PerfTestsRunner.__init__):
97         * Scripts/webkitpy/style/checkers/test_expectations.py:
98         (TestExpectationsChecker.__init__):
99         * Scripts/webkitpy/style/main.py:
100         (CheckWebKitStyle.main):
101         * Scripts/webkitpy/tool/main.py:
102         (WebKitPatch.handle_global_options):
103         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
104         (get_test_baselines):
105
106 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
107
108         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
109         https://bugs.webkit.org/show_bug.cgi?id=98310
110
111         Reviewed by Martin Robinson.
112
113         Make MiniBrowser/GtkLauncher define the path to the inspector
114         resources by setting the WEBKIT_INSPECTOR_PATH environment
115         variable pointing to the copy of the inspector resources in
116         the build directory. If the environment variable is already
117         defined, its value is not overwritten. The path is derived
118         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
119
120         * GNUmakefile.am:
121         * GtkLauncher/main.c:
122         (main):
123         * MiniBrowser/gtk/main.c:
124         (main):
125
126 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
127
128         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
129         https://bugs.webkit.org/show_bug.cgi?id=97608
130
131         Reviewed by Sam Weinig.
132
133         The test fast/dom/Geolocation/window-close-crash.html was crashing because
134         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
135         the page was created, the void* clientInfo can either be a PlatformWebView or
136         a TestController.
137
138         Using the global TestController fixes the issue.
139
140         * WebKitTestRunner/GeolocationProviderMock.cpp:
141         (WTR::GeolocationProviderMock::setPosition):
142         (WTR::GeolocationProviderMock::setPositionUnavailableError):
143         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
144         to clear the error and vice versa.
145         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
146
147         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
148         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
149         Some tests expect the position/error cant be sent multiple time,
150         just keep the position after sending.
151
152         * WebKitTestRunner/TestController.cpp:
153         (WTR::decidePolicyForGeolocationPermissionRequest):
154         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
155         * WebKitTestRunner/TestController.h:
156         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
157         client would have to do.
158
159 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
160
161         [BlackBerry] Implementing the NetworkInfo API for BB port
162         https://bugs.webkit.org/show_bug.cgi?id=98273
163
164         Reviewed by Rob Buis.
165
166         Enabling NetworkInfo API for the BlackBerry port.
167
168         * Scripts/webkitperl/FeatureList.pm:
169
170 2012-10-03  Anders Carlsson  <andersca@apple.com>
171
172         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
173         https://bugs.webkit.org/show_bug.cgi?id=98291
174
175         Reviewed by Andreas Kling.
176
177         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
178         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
179         when trying to access the children of an element that didn't have any children. Fix this by adding
180         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
181
182         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
183         (findAccessibleObjectById):
184
185 2012-10-03  Ojan Vafai  <ojan@chromium.org>
186
187         Make partytime work when loading garden-o-matic from trac.webkit.org
188         https://bugs.webkit.org/show_bug.cgi?id=98283
189
190         Reviewed by Adam Barth.
191
192         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
194
195 2012-10-03  Roger Fong  <roger_fong@apple.com>
196
197         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
198         https://bugs.webkit.org/show_bug.cgi?id=98288
199
200         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
201         (ChromiumAndroidDriverTest.test_command_from_driver_input):
202
203 2012-10-03  Ojan Vafai  <ojan@chromium.org>
204
205         Get rid of warning about non-existant platform name when loading garden-o-matic
206         https://bugs.webkit.org/show_bug.cgi?id=98282
207
208         Reviewed by Adam Barth.
209
210         If you loaded without a platform query parameter we'd return "null" as the platform name
211         instead of null.
212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
214
215 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
216
217         [Qt] Enable mock scrollbars
218         https://bugs.webkit.org/show_bug.cgi?id=98011
219
220         Reviewed by Csaba Osztrogonác.
221
222         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
223
224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
225         (WebCore::DumpRenderTree::DumpRenderTree):
226         * WebKitTestRunner/TestController.cpp:
227         (WTR::TestController::resetStateToConsistentValues):
228
229 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
230
231         [GTK] [WK2] Add favicon support to the MiniBrowser
232         https://bugs.webkit.org/show_bug.cgi?id=98063
233
234         Reviewed by Carlos Garcia Campos.
235
236         Set the icon in the URI text entry using the favicon property of
237         the WebKitWebView.
238
239         * MiniBrowser/gtk/BrowserWindow.c:
240         (_BrowserWindow):
241         (updateUriEntryIcon):
242         (uriEntryTextChanged):
243         (faviconChanged):
244         (browserWindowFinalize):
245         (browser_window_init):
246         (browserWindowConstructed):
247
248 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
249
250         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
251         https://bugs.webkit.org/show_bug.cgi?id=98200
252
253         Reviewed by Csaba Osztrogonác.
254
255         * DumpRenderTree/qt/TestRunnerQt.cpp:
256         (TestRunner::overridePreference):
257
258 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
259
260         [Qt][WRT] Fix build error with MSVC on Windows.
261         https://bugs.webkit.org/show_bug.cgi?id=97697
262
263         Reviewed by Simon Hausmann.
264
265         WTR build is failing when WebKit directory is located on a longer path.
266         This seems to caused by source files that has the same name in
267         WTR and DRT directories. The solution is removing referencies 
268         from Target.pri to DRT directory and adding an alternate version of
269         the required files to WTR. Those files simply include the real ones from DRT.
270
271         * WebKitTestRunner/InjectedBundle/Target.pri:
272         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
273         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
274
275 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
276
277         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
278         https://bugs.webkit.org/show_bug.cgi?id=98238
279
280         Reviewed by Csaba Osztrogonác.
281
282         Reset AlwaysAcceptCookies setting between tests to avoid
283         flakiness due to TestRunner.setAlwaysAcceptCookies().
284
285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
286         (WTR::InjectedBundle::beginTesting):
287
288 2012-10-03  Harald Alvestrand  <hta@google.com>
289
290         Add data passing to the GetStats interface of RTCPeerConnection
291         https://bugs.webkit.org/show_bug.cgi?id=98003
292
293         Reviewed by Adam Barth.
294
295         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
296         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
297         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
298         (MockWebRTCPeerConnectionHandler::addStream):
299         (MockWebRTCPeerConnectionHandler::removeStream):
300         (MockWebRTCPeerConnectionHandler::getStats):
301         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
302         (MockWebRTCPeerConnectionHandler):
303
304 == Rolled over to ChangeLog-2012-10-02 ==