[Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
4         https://bugs.webkit.org/show_bug.cgi?id=143321
5
6         Reviewed by Alexey Proskuryakov.
7
8         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
9
10 2015-04-01  Enrica Casucci  <enrica@apple.com>
11
12         Injected bundle messages should be at the page level.
13         https://bugs.webkit.org/show_bug.cgi?id=143283
14
15         Reviewed by Alexey Proskuryakov.
16
17         Updating WebKitTestRunner to use the new page level messaging.
18         The author of this patch is Tim Horton, I just finished it.
19
20         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
21         (WTR::EventSendingController::mouseDown):
22         (WTR::EventSendingController::mouseUp):
23         (WTR::EventSendingController::mouseMoveTo):
24         (WTR::EventSendingController::leapForward):
25         (WTR::EventSendingController::scheduleAsynchronousClick):
26         (WTR::EventSendingController::keyDown):
27         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
28         (WTR::EventSendingController::mouseScrollBy):
29         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
30         (WTR::EventSendingController::continuousMouseScrollBy):
31         (WTR::EventSendingController::addTouchPoint):
32         (WTR::EventSendingController::updateTouchPoint):
33         (WTR::EventSendingController::setTouchModifier):
34         (WTR::EventSendingController::setTouchPointRadius):
35         (WTR::EventSendingController::touchStart):
36         (WTR::EventSendingController::touchMove):
37         (WTR::EventSendingController::touchEnd):
38         (WTR::EventSendingController::touchCancel):
39         (WTR::EventSendingController::clearTouchPoints):
40         (WTR::EventSendingController::releaseTouchPoint):
41         (WTR::EventSendingController::cancelTouchPoint):
42         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
43         (WTR::InjectedBundle::didReceiveMessage):
44         (WTR::InjectedBundle::didReceiveMessageToPage):
45         (WTR::InjectedBundle::done):
46         (WTR::InjectedBundle::outputText):
47         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
48         (WTR::InjectedBundle::postAddChromeInputField):
49         (WTR::InjectedBundle::postRemoveChromeInputField):
50         (WTR::InjectedBundle::postFocusWebView):
51         (WTR::InjectedBundle::postSetBackingScaleFactor):
52         (WTR::InjectedBundle::postSetWindowIsKey):
53         (WTR::InjectedBundle::postSimulateWebNotificationClick):
54         (WTR::InjectedBundle::postSetAddsVisitedLinks):
55         (WTR::InjectedBundle::setGeolocationPermission):
56         (WTR::InjectedBundle::setMockGeolocationPosition):
57         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
58         (WTR::InjectedBundle::setUserMediaPermission):
59         (WTR::InjectedBundle::setCustomPolicyDelegate):
60         (WTR::InjectedBundle::setHidden):
61         (WTR::InjectedBundle::setCacheModel):
62         (WTR::InjectedBundle::shouldProcessWorkQueue):
63         (WTR::InjectedBundle::processWorkQueue):
64         (WTR::InjectedBundle::queueBackNavigation):
65         (WTR::InjectedBundle::queueForwardNavigation):
66         (WTR::InjectedBundle::queueLoad):
67         (WTR::InjectedBundle::queueLoadHTMLString):
68         (WTR::InjectedBundle::queueReload):
69         (WTR::InjectedBundle::queueLoadingScript):
70         (WTR::InjectedBundle::queueNonLoadingScript):
71         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
72         (WTR::TestRunner::setHandlesAuthenticationChallenges):
73         (WTR::TestRunner::setAuthenticationUsername):
74         (WTR::TestRunner::setAuthenticationPassword):
75         (WTR::TestRunner::secureEventInputIsEnabled):
76         (WTR::TestRunner::setBlockAllPlugins):
77         * WebKitTestRunner/TestController.cpp:
78         (WTR::TestController::createWebViewWithOptions):
79         (WTR::TestController::resetStateToConsistentValues):
80         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
81         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
82         * WebKitTestRunner/TestController.h:
83         * WebKitTestRunner/TestInvocation.cpp:
84         (WTR::TestInvocation::invoke):
85         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
86
87 2015-04-01  Commit Queue  <commit-queue@webkit.org>
88
89         Unreviewed, rolling out r182174 and r182177.
90         https://bugs.webkit.org/show_bug.cgi?id=143314
91
92         Try to correct EWS failures (Requested by bfulgham on
93         #webkit).
94
95         Reverted changesets:
96
97         "Python SCM should be able to retrieve untracked files"
98         https://bugs.webkit.org/show_bug.cgi?id=143135
99         http://trac.webkit.org/changeset/182174
100
101         "[buildbot] clean-build script should remove untracked files
102         and revert local changes too"
103         https://bugs.webkit.org/show_bug.cgi?id=142400
104         http://trac.webkit.org/changeset/182177
105
106 2015-04-01  Alex Christensen  <achristensen@webkit.org>
107
108         [Content Extensions] Properly handle regexes that match everything.
109         https://bugs.webkit.org/show_bug.cgi?id=143281
110
111         Reviewed by Benjamin Poulain.
112
113         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
114         (TestWebKitAPI::testRequest):
115         (TestWebKitAPI::makeBackend):
116         (TestWebKitAPI::TEST_F):
117         Removed duplicate code and added test.
118
119 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
120
121         Content Extensions: split the state machines to minimize prefix states
122         https://bugs.webkit.org/show_bug.cgi?id=143253
123
124         Reviewed by Alex Christensen.
125
126         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
127         (TestWebKitAPI::TEST_F):
128         (TestWebKitAPI::testPatternStatus):
129
130 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
131
132         Clean up Identifier factories to clarify the meaning of StringImpl*
133         https://bugs.webkit.org/show_bug.cgi?id=143146
134
135         Reviewed by Filip Pizlo.
136
137         Simple API tests for StringImpl are added.
138
139         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
140         (TestWebKitAPI::TEST):
141
142 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
143
144         [EFL] Add AArch64 builder and tester bot to build.webkit.org
145         https://bugs.webkit.org/show_bug.cgi?id=143092
146
147         Reviewed by Gyuyoung Kim.
148
149         * BuildSlaveSupport/build.webkit.org-config/config.json:
150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
151         (Factory.__init__):
152         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
153
154 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
155
156         [buildbot] clean-build script should remove untracked files and revert local changes too
157         https://bugs.webkit.org/show_bug.cgi?id=142400
158
159         Reviewed by Ryosuke Niwa.
160
161         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
162         A helper routine SCM.discard_untracked_files is added for that purpose.
163
164         * BuildSlaveSupport/clean-build:
165         (main): Making call to Scripts/clean-webkit
166         * Scripts/clean-webkit: Added.
167         (main): Revert changes and delete untracked files.
168         * Scripts/webkitpy/common/checkout/scm/scm.py:
169         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
170         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
171         (SCMTest._shared_test_discard_untracked_files):
172         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
173
174 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
175
176         Python SCM should be able to retrieve untracked files
177         https://bugs.webkit.org/show_bug.cgi?id=143135
178
179         Reviewed by Ryosuke Niwa.
180
181         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
182         Ignored files may be included or not in this list according boolean passed to the function.
183
184         * Scripts/webkitpy/common/checkout/scm/git.py:
185         (Git.untracked_files):
186         * Scripts/webkitpy/common/checkout/scm/scm.py:
187         (SCM.untracked_files):
188         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
189         (SCMTest._shared_test_untracked_files):
190         (test_untracked_files):
191         (GitSVNTest.test_untracked_files):
192         * Scripts/webkitpy/common/checkout/scm/svn.py:
193         (SVN.untracked_files):
194
195 2015-03-30  Alex Christensen  <achristensen@webkit.org>
196
197         [Content Extensions] Correctly handle regular expressions matching everything
198         https://bugs.webkit.org/show_bug.cgi?id=143235
199
200         Reviewed by Benjamin Poulain.
201
202         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
203         (TestWebKitAPI::checkCompilerError):
204         (TestWebKitAPI::TEST_F):
205         Test ContentExtensionErrors.
206
207 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
208
209         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
210         https://bugs.webkit.org/show_bug.cgi?id=143241
211         rdar://problem/20351297
212
213         Reviewed by Mark Lam.
214
215         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
216
217 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
218
219         [CMake][EFL] Remove redundant library link and include path
220         https://bugs.webkit.org/show_bug.cgi?id=143221
221
222         Reviewed by Csaba Osztrogonác.
223
224         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
225
226 2015-03-30  Sam Weinig  <sam@webkit.org>
227
228         [Content Extensions] Flesh out the UserContentExtensionStore
229         https://bugs.webkit.org/show_bug.cgi?id=143123
230
231         Reviewed by Benjamin Poulain.
232
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
235         Add tests for _WKUserContentExtensionStore.
236
237 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
238
239         Update install-dependencies Fedora packages after r181624
240         https://bugs.webkit.org/show_bug.cgi?id=143215
241
242         Add json-glib, libv4l, openssl and pulseaudio development packages to
243         the Fedora list providing we need them to build WebKit dependencies
244         for this distribution.
245
246         Reviewed by Philippe Normand.
247
248         * gtk/install-dependencies:
249
250 2015-03-30  Commit Queue  <commit-queue@webkit.org>
251
252         Unreviewed, rolling out r182119.
253         https://bugs.webkit.org/show_bug.cgi?id=143196
254
255         problem with syntax (Requested by youenn on #webkit).
256
257         Reverted changeset:
258
259         "[buildbot] clean-build script should remove untracked files
260         and revert local changes too"
261         https://bugs.webkit.org/show_bug.cgi?id=142400
262         http://trac.webkit.org/changeset/182119
263
264 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
265
266         Start the features.json files
267         https://bugs.webkit.org/show_bug.cgi?id=143207
268
269         Reviewed by Darin Adler.
270
271         I kept the style checking light. We'll have to figure
272         what is the best format for each field.
273
274         * Scripts/webkitpy/style/checker.py:
275         (CheckerDispatcher._create_checker):
276         * Scripts/webkitpy/style/checkers/jsonchecker.py:
277         (JSONContributorsChecker.check):
278         (JSONFeaturesChecker):
279         (JSONFeaturesChecker.check):
280
281 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
282
283         [buildbot] clean-build script should remove untracked files and revert local changes too
284         https://bugs.webkit.org/show_bug.cgi?id=142400
285
286         Reviewed by Ryosuke Niwa.
287
288         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
289
290         * BuildSlaveSupport/clean-build:
291         (main): Adding call to Tools/Scripts/clean-webkit.
292         * Scripts/clean-webkit: Added.
293         (main): Removes untracked and changed files.
294         * Scripts/webkitpy/common/checkout/scm/git.py:
295         (Git.untracked_files): Retrieves GIT untracked files.
296         * Scripts/webkitpy/common/checkout/scm/scm.py:
297         (SCM.untracked_files): Retrieves SVN untracked files.
298         (SCM):
299         (SCM.discard_untracked_files): Deletes untracked files/folders.
300         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
301         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
302         (test_untracked_files):
303         (GitSVNTest.test_untracked_files):
304         * Scripts/webkitpy/common/checkout/scm/svn.py:
305         (SVN.untracked_files):
306
307 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
308
309         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
310         https://bugs.webkit.org/show_bug.cgi?id=143138
311
312         Reviewed by Csaba Osztrogonác.
313
314         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
315         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
316
317         * ImageDiff/CMakeLists.txt:
318         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
319         * WebKitTestRunner/CMakeLists.txt: ditto.
320
321 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
322
323         Support building WTF on Windows without Cygwin
324         https://bugs.webkit.org/show_bug.cgi?id=143084
325
326         Reviewed by Brent Fulgham.
327
328         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
329         This patch also migrates to using File::Spec->catfile() for directory separators.
330
331         * Scripts/update-webkit-dependency:
332         (wanted):
333         * Scripts/update-webkit-support-libs:
334         (wanted):
335         (downloadExpectedVersionNumber):
336         (zipFileVersion):
337         (toUnixPath): Deleted.
338         * Scripts/webkitdirs.pm:
339         (determineSourceDir):
340         (windowsSourceSourceDir):
341         (windowsLibrariesDir):
342         (windowsOutputDir):
343         (checkInstalledTools):
344         (buildVisualStudioProject):
345
346 2015-03-27  Alex Christensen  <achristensen@webkit.org>
347
348         Fix WinCairo bot.
349         https://bugs.webkit.org/show_bug.cgi?id=143086
350
351         Reviewed by Brent Fulgham.
352
353         * Scripts/webkitdirs.pm:
354         (buildVisualStudioProject):
355         (runSvnUpdateAndResolveChangeLogs):
356         Use ActivePerl-friendly perl.
357
358 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
359
360         URTBF after r182059 to fix the EFL build.
361
362         * TestWebKitAPI/CMakeLists.txt:
363
364 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
365
366         Layout test results URL loads in WK1 but not WK2 minibrowser
367         https://bugs.webkit.org/show_bug.cgi?id=143117
368
369         Reviewed by Tim Horton.
370
371         * MiniBrowser/mac/WK2BrowserWindowController.m:
372         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
373         everything.
374         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
375
376 2015-03-26  Jer Noble  <jer.noble@apple.com>
377
378         Add --allowed-host support to run-webkit-tests
379         https://bugs.webkit.org/show_bug.cgi?id=142938
380
381         Reviewed by Brent Fulgham.
382
383         Accept --allowed-host arguments from run-webkit-tests and pass them through to
384         DumpRenderTree and WebKitTestRunner.
385
386         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
387         are placed in the wrong location. The argument is compared with each tests's path, and if a
388         relative path or a path with '..' was used, results are placed alongside the test. Take the
389         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
390
391         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
392         (parse_args):
393         * Scripts/webkitpy/port/base.py:
394         (Port.__init__):
395         (Port.allowed_hosts):
396         * Scripts/webkitpy/port/driver.py:
397         (Driver.cmd_line):
398
399 2015-03-26  Jer Noble  <jer.noble@apple.com>
400
401         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
402         https://bugs.webkit.org/show_bug.cgi?id=142931
403
404         Reviewed by Brent Fulgham.
405
406         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
407         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
408         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
409         runtime.
410
411         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
412         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
413
414         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
415         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
416         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
417         the top loading frame from the page, as we do elsewhere in this class.
418
419         * DumpRenderTree/TestRunner.h:
420         (TestRunner::allowedHosts):
421         (TestRunner::setAllowedHosts):
422         * DumpRenderTree/mac/DumpRenderTree.mm:
423         (initializeGlobalsFromCommandLineOptions):
424         (runTest):
425         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
426         (isAllowedHost):
427         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
428         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
429         (WTR::InjectedBundle::didReceiveMessage):
430         (WTR::InjectedBundle::isAllowedHost):
431         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
432         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
433         (WTR::isAllowedHost):
434         (WTR::InjectedBundlePage::willSendRequestForFrame):
435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
436         * WebKitTestRunner/Options.cpp:
437         (WTR::handleOptionAllowedHost):
438         (WTR::OptionsHandler::OptionsHandler):
439         * WebKitTestRunner/Options.h:
440         * WebKitTestRunner/TestController.cpp:
441         (WTR::TestController::initialize):
442         (WTR::TestController::resetStateToConsistentValues):
443         * WebKitTestRunner/TestController.h:
444
445 2015-03-26  Brady Eidson  <beidson@apple.com>
446
447         Apply ContentExtension actions after redirects.
448         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
449
450         Reviewed by Alex Christensen.
451
452         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
453         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
454           which is specifically interesting to a new test.
455
456 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
457
458         [EFL] Disable building libseccomp on AArch64
459         https://bugs.webkit.org/show_bug.cgi?id=143094
460
461         Reviewed by Gyuyoung Kim.
462
463         * efl/jhbuildrc:
464
465 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
466
467         [jhbuild] git should use only 1 thread for cloning jhbuild
468         https://bugs.webkit.org/show_bug.cgi?id=143095
469
470         Reviewed by Gyuyoung Kim.
471
472         * jhbuild/jhbuild-wrapper:
473         (clone_jhbuild):
474
475 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
476
477         Update prepare-ChangeLog to work with ES6 Class syntax
478         https://bugs.webkit.org/show_bug.cgi?id=143069
479
480         Reviewed by Timothy Hatcher.
481
482         * Scripts/prepare-ChangeLog:
483         (get_function_line_ranges_for_javascript):
484         Better handle ES6 Class syntax.
485
486         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
487         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
488         (BaseClass):
489         (DerivedClass):
490         (DerivedClass.staticMethod):
491         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
492         (DerivedClass.prototype.method):
493         (DerivedClass.prototype.get getter):
494         (namespace.MyClass):
495         (namespace.MyClass.staticMethod):
496         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
497         (namespace.MyClass.prototype.method):
498         (namespace.MyClass.prototype.get getter):
499         Proof!
500
501 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
502
503         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
504         https://bugs.webkit.org/show_bug.cgi?id=142993
505
506         Reviewed by Mark Lam.
507         
508         Bunch of support for testing executable allocation failure.
509
510         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
511         (fail):
512         * Scripts/run-javascriptcore-tests:
513         (runJSCStressTests):
514         * Scripts/run-jsc-stress-tests:
515
516 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
517
518         Fix Windows build from r181977.
519
520         Unreviewed.
521
522         * Scripts/update-webkit-dependency:
523
524 2015-03-25  Sam Weinig  <sam@webkit.org>
525
526         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
527
528         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
529         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
530
531 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
532
533         Migrate update-webkit for Windows to not require Cygwin
534         https://bugs.webkit.org/show_bug.cgi?id=143040
535
536         Reviewed by Brent Fulgham.
537
538         * Scripts/update-webkit-dependency:
539         (wanted):
540         (toUnixPath): Deleted.
541         * Scripts/webkitdirs.pm:
542         (fontExists):
543         (checkInstalledTools):
544         (setupAppleWinEnv):
545
546 2015-03-25  Sam Weinig  <sam@webkit.org>
547
548         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
549         https://bugs.webkit.org/show_bug.cgi?id=143059
550
551         Reviewed by Alex Christensen.
552
553         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
554         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
555         Update for new interface of compileRuleList().
556
557 2015-03-25  Alex Christensen  <achristensen@webkit.org>
558
559         [Content Extensions] Add multi-DFA compiling and interpreting.
560         https://bugs.webkit.org/show_bug.cgi?id=143010
561
562         Reviewed by Benjamin Poulain.
563
564         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
565         (TestWebKitAPI::testRequest):
566         (TestWebKitAPI::TEST_F):
567         Add some tests for ignore-previous-rules and large rulesets.
568
569 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
570
571         Mavericks WK1 still runs JSC tests
572         https://bugs.webkit.org/show_bug.cgi?id=143035
573
574         Reviewed by Csaba Osztrogonác.
575
576         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
577         with other bots.
578
579         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
580         accordingly.
581
582 2015-03-25  Commit Queue  <commit-queue@webkit.org>
583
584         Unreviewed, rolling out r181932.
585         https://bugs.webkit.org/show_bug.cgi?id=143041
586
587         The test fails most of the time on bots (Requested by ap on
588         #webkit).
589
590         Reverted changeset:
591
592         "[Content Extensions] Add multi-DFA compiling and
593         interpreting."
594         https://bugs.webkit.org/show_bug.cgi?id=143010
595         http://trac.webkit.org/changeset/181932
596
597 2015-03-24  Alex Christensen  <achristensen@webkit.org>
598
599         [Content Extensions] Add multi-DFA compiling and interpreting.
600         https://bugs.webkit.org/show_bug.cgi?id=143010
601
602         Reviewed by Benjamin Poulain.
603
604         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
605         (TestWebKitAPI::testRequest):
606         (TestWebKitAPI::TEST_F):
607         Add some tests for ignore-previous-rules and large rulesets.
608
609 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
610
611         Make URL filter patterns matching consistent and add a simple canonicalization step
612         https://bugs.webkit.org/show_bug.cgi?id=142998
613
614         Reviewed by Alex Christensen.
615
616         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
617
618 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
619
620         [EFL] Add OpenWebRTC in jhbuild
621         https://bugs.webkit.org/show_bug.cgi?id=142778
622
623         Reviewed by Gyuyoung Kim.
624
625         Original patch by Philippe Normand <pnormand@igalia.com>
626
627         * efl/install-dependencies: Dependencies for OpenWebRTC.
628         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
629         the openwebrtc gst plugins.
630
631 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
632
633         Regression(r181257): WTF_WorkQueue.Simple is flaky
634         https://bugs.webkit.org/show_bug.cgi?id=142560
635
636         Remove the check that the refCount has returned to one after the
637         individual tasks have completed. It's too nondeterministic when
638         the reference count will be reduced.
639
640         Reviewed by Alexey Proskuryakov
641
642         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
643         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
644
645 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
646
647         [CMake][EFL] Put failure API test excutables into failure directory
648         https://bugs.webkit.org/show_bug.cgi?id=142965
649
650         Reviewed by Csaba Osztrogonác.
651
652         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
653
654         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
655         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
656
657 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
658
659         CSS Selectors: fix attribute case-insensitive matching of Contain and List
660         https://bugs.webkit.org/show_bug.cgi?id=142932
661
662         Reviewed by Darin Adler.
663
664         Add tests for the new features and fix some existing tests using the 
665         stringFromUTF8() utility recently added by Dhi.
666
667         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
668         (TestWebKitAPI::stringFromUTF8):
669         * TestWebKitAPI/Tests/WTF/StringView.cpp:
670
671 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
672
673         [GTK] install-dependencies should install orc
674         https://bugs.webkit.org/show_bug.cgi?id=142955
675
676         Reviewed by Martin Robinson.
677
678         Install orc, needed by openwebrtc
679
680         * gtk/install-dependencies:
681
682 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
683
684         Detect when url filter pattern with groups match the empty string
685         https://bugs.webkit.org/show_bug.cgi?id=142930
686
687         Reviewed by Sam Weinig.
688
689         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
690
691 2015-03-22  Anders Carlsson  <andersca@apple.com>
692
693         _WKWebsiteDataStore should clear WebSQL databases
694         https://bugs.webkit.org/show_bug.cgi?id=142947
695
696         Reviewed by Sam Weinig.
697
698         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
699
700         * MiniBrowser/mac/WK2BrowserWindowController.m:
701         (-[WK2BrowserWindowController fetchWebsiteData:]):
702         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
703         (-[WK2BrowserWindowController clearWebsiteData:]):
704
705 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
706
707         GCTimer should know keep track of nested GC phases
708         https://bugs.webkit.org/show_bug.cgi?id=142675
709
710         Reviewed by Darin Adler.
711
712         Adds a tool to aid in parsing the GC phase timing output into a
713         tree-like structure based on the parent-child relationships
714         of nested GC phases.
715
716         * Scripts/parse-gc-phase-timings: Added.
717         (Timing):
718         (Timing.__init__):
719         (Timing.__unicode__):
720         (Timing.__str__):
721         (Timing.__repr__):
722         (parse_input):
723         (print_timing_node):
724         (print_timing_tree):
725         (link_parents):
726         (main):
727
728 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
729
730         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
731
732         * Scripts/webkitpy/common/config/ews.json:
733
734 2015-03-20  Philippe Normand  <pnormand@igalia.com>
735
736         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
737         https://bugs.webkit.org/show_bug.cgi?id=142867
738
739         Rubber-stamped by Csaba Osztrogon.
740
741         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
742         a fixed revision for the openwebrtc-gst-plugins.
743
744 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
745
746         Unreviewed build fix. Don't try to report stats for all benchmarks.
747         Just report the geometric mean of preferred means.
748
749         * Scripts/run-jsc-benchmarks:
750
751 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
752
753         run-jsc-benchmarks should only report preferred mean
754         https://bugs.webkit.org/show_bug.cgi?id=142874
755
756         Reviewed by Geoffrey Garen.
757
758         Just collect statistics for the preferred mean.
759
760         * Scripts/run-jsc-benchmarks:
761
762 2015-03-19  Alex Christensen  <achristensen@webkit.org>
763
764         [Content Extensions] Test regular expression parse failures.
765         https://bugs.webkit.org/show_bug.cgi?id=142872
766
767         Reviewed by Benjamin Poulain.
768
769         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
770         (TestWebKitAPI::testPatternStatus):
771         (TestWebKitAPI::TEST_F):
772         Added tests for each parsing status.
773
774 2015-03-19  Alex Christensen  <achristensen@webkit.org>
775
776         Fix API tests after r181754.
777
778         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
779         (TestWebKitAPI::testRequest):
780
781 2015-03-19  Brady Eidson  <beidson@apple.com>
782
783         Part of content extensions should apply css selectors
784         https://bugs.webkit.org/show_bug.cgi?id=142604
785
786         Reviewed by Alex Christensen.
787
788         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
789         (WebCore::ContentExtensions::operator<<):
790
791 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
792
793         [Win] Activate tests on EWS
794         https://bugs.webkit.org/show_bug.cgi?id=142850
795
796         Reviewed by Alexey Proskuryakov.
797
798         * Scripts/webkitpy/common/config/ews.json: Add me as
799         the EWS bot watcher, and activate tests.
800
801 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
802
803         [GTK] Fix inspector userinterface related incremental build issue
804         https://bugs.webkit.org/show_bug.cgi?id=142849
805
806         Reviewed by Carlos Garcia Campos.
807
808         * Scripts/webkitdirs.pm:
809         (shouldRemoveCMakeCache):
810
811 2015-03-18  Alex Christensen  <achristensen@webkit.org>
812
813         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
814         https://bugs.webkit.org/show_bug.cgi?id=142799
815
816         Reviewed by Brady Eidson.
817
818         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
819         (TestWebKitAPI::testPattern):
820         (TestWebKitAPI::TEST_F):
821         Start testing regex failures.
822
823 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
824
825         Fix StringView typos after r181525 and r181558
826         https://bugs.webkit.org/show_bug.cgi?id=142772
827
828         Reviewed by Darin Adler.
829
830         Add some tests in [1] to cover the StringView::startsWith, 
831         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
832         StringView::endsWithIgnoringASCIICase implementations.
833
834         * TestWebKitAPI/Tests/WTF/StringView.cpp:
835         (TestWebKitAPI::TEST):
836
837 2015-03-18  Dana Burkart  <dburkart@apple.com>
838
839         Remove extraneous import to fix the build.
840
841         Unreviewed.
842
843         * Scripts/webkitpy/port/driver.py:
844
845 2015-03-18  Dana Burkart  <dburkart@apple.com>
846
847         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
848         https://bugs.webkit.org/show_bug.cgi?id=142547
849
850         Reviewed by Alexey Proskuryakov.
851
852         * Scripts/webkitpy/port/driver.py:
853         (Driver._setup_environ_for_driver):
854
855 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
856
857         Tweak how AppleSystemFontOSSubversion default is added
858         https://bugs.webkit.org/show_bug.cgi?id=142835
859
860         Reviewed by Dan Bernstein.
861
862         * DumpRenderTree/mac/DumpRenderTree.mm:
863         (setDefaultsToConsistentValuesForTesting):
864
865 2015-03-18  Dan Bernstein  <mitz@apple.com>
866
867         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
868         https://bugs.webkit.org/show_bug.cgi?id=142815
869
870         Reviewed by Darin Adler.
871
872         * Scripts/prepare-ChangeLog:
873         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
874         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
875         keep consuming the quoted text until the matching quotation mark is reached. Emit the
876         warning only if a line ends without a backslash before the matching quotation mark was found.
877
878 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
879
880         Remove unused "preprocessor" parameter to sub-CodeGenerators
881         https://bugs.webkit.org/show_bug.cgi?id=142793
882
883         Reviewed by Darin Adler.
884
885         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
886         (new):
887
888 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
889
890         [EFL] Bump gstreamer version to 1.4.4
891         https://bugs.webkit.org/show_bug.cgi?id=142782
892
893         Reviewed by Philippe Normand.
894
895         * efl/jhbuild.modules:
896         * efl/patches/gst-libav.patch:
897         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
898         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
899
900 2015-03-17  Tim Horton  <timothy_horton@apple.com>
901
902         Fix the iOS build.
903
904         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
905         (WTR::InjectedBundle::platformInitialize):
906
907 2015-03-17  Dean Jackson  <dino@apple.com>
908
909         check-webkit-style should allow "bool a : 1"
910         https://bugs.webkit.org/show_bug.cgi?id=142794
911
912         Reviewed by Brent Fulgham.
913
914         We should allow member bitfields of the form:
915
916         bool m_var : 1;
917
918         It seems that Visual Studio 8 was the last compiler that
919         wasn't happy about not using unsigned here. We already have
920         about 500 cases (in WebCore) where people were ignoring this rule.
921
922         * Scripts/webkitpy/style/checkers/cpp.py:
923         (check_language): Allow "bool".
924         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
925         (CppStyleTest.test_enum_bitfields):
926         (CppStyleTest.test_plain_integral_bitfields):
927
928 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
929
930         Compile character ranges targeting the same state as range check in the bytecode
931         https://bugs.webkit.org/show_bug.cgi?id=142759
932
933         Reviewed by Alex Christensen.
934
935         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
936         (TestWebKitAPI::TEST_F):
937
938 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
939
940         W3C test parser and converter should use test importer host
941         https://bugs.webkit.org/show_bug.cgi?id=142729
942
943         Reviewed by Bem Jones-Bey.
944
945         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
946         This enables adding more TestImporter unit testing.
947         This patch also ensures that the git object instantiated by TestDownloader is using the
948         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
949
950         * Scripts/webkitpy/common/system/filesystem_mock.py:
951         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
952         * Scripts/webkitpy/w3c/test_downloader.py:
953         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
954         (TestDownloader.checkout_test_repository): Making use of the new git function.
955         * Scripts/webkitpy/w3c/test_importer.py:
956         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
957         (TestImporter.import_tests): Adding host as parameter to the converter.
958         * Scripts/webkitpy/w3c/test_importer_unittest.py:
959         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
960         (TestImporterTest):
961         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
962         * Scripts/webkitpy/w3c/test_parser.py:
963         (TestParser.__init__): Adding host as parameter constructor.
964
965 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
966
967         [GTK] WebKitDOM objects leaking
968         https://bugs.webkit.org/show_bug.cgi?id=118788
969
970         Reviewed by Darin Adler and Sergio Villar Senin.
971
972         Update DOMObjectCache unit test to check that DOM objects are also
973         released when new contents are loaded in the web view, and the old
974         document is detached from the frame.
975
976         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
977         (testWebKitDOMObjectCache):
978         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
979         (runTest):
980
981 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
982
983         W3C test importer default import folder should be LayoutTests/imported/w3c
984         https://bugs.webkit.org/show_bug.cgi?id=142728
985
986         Reviewed by Bem Jones-Bey.
987
988         * Scripts/webkitpy/w3c/test_importer.py:
989         (parse_args): Updating the default destination option value to 'imported/w3c'.
990
991 2015-03-17  Philippe Normand  <pnormand@igalia.com>
992
993         [GTK] basic OpenWebRTC build support
994         https://bugs.webkit.org/show_bug.cgi?id=142393
995
996         Reviewed by Carlos Garcia Campos.
997
998         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
999         is not the upstream OpenWebRTC repository. This temporary fork
1000         contains a few patches needed by WebKit for audio/video rendering.
1001
1002 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1003
1004         [CMake][EFL] Build test tools only for developer mode
1005         https://bugs.webkit.org/show_bug.cgi?id=142761
1006
1007         Reviewed by Csaba Osztrogonác.
1008
1009         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1010
1011         * CMakeLists.txt:
1012
1013 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1014
1015         Remove never used "useLayerOnTop" bindings generator argument
1016         https://bugs.webkit.org/show_bug.cgi?id=142773
1017
1018         Reviewed by Darin Adler.
1019
1020         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1021         (new):
1022
1023 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         Enable ES6 classes by default
1026         https://bugs.webkit.org/show_bug.cgi?id=142774
1027
1028         Reviewed by Gavin Barraclough.
1029
1030         * Scripts/webkitperl/FeatureList.pm:
1031
1032 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1033
1034         Fix webkitpy tests after r181585.
1035
1036         Looks like "me" cannot be anyone's email, it's a special case.
1037
1038         * Scripts/webkitpy/common/config/contributors.json:
1039
1040 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1041
1042         Add tolerance to WebAudio tests
1043         https://bugs.webkit.org/show_bug.cgi?id=142676
1044
1045         Reviewed by Tim Horton.
1046
1047         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1048
1049         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1050         (TestResultWriter.create_audio_diff_and_write_result):
1051         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1052         (FailureAudio.write_failure):
1053         * Scripts/webkitpy/port/base.py:
1054         (Port.do_audio_results_differ):
1055         Diff audio failures.
1056
1057         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1058         tests to use real parseable WAV data, and got rid of base64, which there didn't
1059         seem to have been any reason for.
1060
1061 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1062
1063         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1064         https://bugs.webkit.org/show_bug.cgi?id=142720
1065
1066         Reviewed by Myles C. Maxfield.
1067
1068         Activate system copies of Microsoft fonts for the current process, thus overriding
1069         any other ones that could be preferred by the system otherwise.
1070
1071         * DumpRenderTree/mac/DumpRenderTree.mm:
1072         (activateSystemCoreWebFonts):
1073         (adjustFonts):
1074         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1075         (WTR::activateSystemCoreWebFonts):
1076         (WTR::activateFonts):
1077
1078 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1079
1080         Created Streams API watchlist
1081         https://bugs.webkit.org/show_bug.cgi?id=142684
1082
1083         Reviewed by Benjamin Poulain.
1084
1085         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1086         watchlist and added Benjamin, Youenn and me to it.
1087
1088 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1089
1090         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1091         https://bugs.webkit.org/show_bug.cgi?id=142715
1092
1093         Reviewed by Brent Fulgham.
1094
1095         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1096         (TestWebKitAPI::TEST):
1097
1098 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1099
1100         Change the exact attribute matching to be ASCII case-insensitive
1101         https://bugs.webkit.org/show_bug.cgi?id=142609
1102
1103         Reviewed by Darin Adler.
1104
1105         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1106         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1107
1108 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1109
1110         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1111         https://bugs.webkit.org/show_bug.cgi?id=134764
1112
1113         Reviewed by Ryosuke Niwa.
1114
1115         TestDownloader is introduced to download W3C tests from the official
1116         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1117         and https://github.com/w3c/csswg-test.git).
1118         TestDownloader clones the repositories and checkouts revisions of the tests
1119         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1120
1121         Similarly to https://codereview.chromium.org/148173016,
1122         TestDownloader copies part of the files based on the rules
1123         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1124
1125         TestDownloader is used by TestImporter when no source directory is provided.
1126
1127         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1128         (TestDownloader):
1129         (TestDownloader.default_options):
1130         (TestDownloader.load_test_repositories):
1131         (TestDownloader.__init__):
1132         (TestDownloader.checkout_test_repository):
1133         (TestDownloader._init_paths_from_expectations):
1134         (TestDownloader._add_test_suite_paths):
1135         (TestDownloader._empty_directory):
1136         (TestDownloader.copy_tests):
1137         (TestDownloader.download_tests):
1138         * Scripts/webkitpy/w3c/test_importer.py:
1139         (main):
1140         (parse_args):
1141         (TestImporter.__init__):
1142         (TestImporter.do_import):
1143         (TestImporter.test_downloader):
1144         (TestImporter.find_importable_tests.should_keep_subdir):
1145         (TestImporter.should_convert_test_harness_links):
1146         (TestImporter.import_tests):
1147         (TestImporter.write_import_log):
1148
1149 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1150
1151         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1152         https://bugs.webkit.org/show_bug.cgi?id=142630
1153
1154         Reviewed by Tim Horton.
1155
1156         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1157         Removed an ifdef that disabled the fix on Mavericks.
1158
1159 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1160
1161         Remove isWK2 cruft from webkitdirs.pm after r170426
1162         https://bugs.webkit.org/show_bug.cgi?id=142618
1163
1164         Reviewed by Daniel Bates.
1165
1166         * Scripts/webkitdirs.pm:
1167         (isWK2): Deleted.
1168
1169 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1170
1171         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1172         https://bugs.webkit.org/show_bug.cgi?id=138687
1173
1174         Reviewed by Carlos Garcia Campos.
1175
1176         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1177         affect other processes.
1178
1179         The implementation is imperfect, because the change happens asynchronously, but I
1180         don't expect it to be a problem in practice.
1181
1182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1183         (WTR::InjectedBundle::beginTesting):
1184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1185         (WTR::TestRunner::setAlwaysAcceptCookies):
1186         * WebKitTestRunner/TestInvocation.cpp:
1187         (WTR::TestInvocation::invoke):
1188         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1189
1190 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1191
1192         [EFL] Enable building EFL 1.13 with NEON support
1193         https://bugs.webkit.org/show_bug.cgi?id=142619
1194
1195         Reviewed by Gyuyoung Kim.
1196
1197         * efl/jhbuild.modules:
1198
1199 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1200
1201         [Content Extensions] Add resource type and load type triggers.
1202         https://bugs.webkit.org/show_bug.cgi?id=142422
1203
1204         Reviewed by Benjamin Poulain.
1205
1206         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1207         (TestWebKitAPI::testRequest):
1208         (TestWebKitAPI::mainDocumentRequest):
1209         (TestWebKitAPI::TEST_F):
1210         (TestWebKitAPI::testURL): Deleted.
1211
1212 2015-03-10  Sam Weinig  <sam@webkit.org>
1213
1214         Allow adding a button in input elements for auto fill related functionality
1215         <rdar://problem/19782066>
1216         https://bugs.webkit.org/show_bug.cgi?id=142564
1217
1218         Reviewed by Anders Carlsson.
1219
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::createOtherPage):
1222         (WTR::TestController::createWebViewWithOptions):
1223         Update for new callback.
1224
1225 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1226
1227         Add basic support for BOL and EOL assertions to the URL Filter parser
1228         https://bugs.webkit.org/show_bug.cgi?id=142568
1229
1230         Reviewed by Alex Christensen.
1231
1232         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1233         (TestWebKitAPI::TEST_F):
1234
1235 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         [GTK] Add support for handling TLS errors to MiniBrowser
1238         https://bugs.webkit.org/show_bug.cgi?id=142576
1239
1240         Reviewed by Sergio Villar Senin.
1241
1242         It's useful for testing TLS errors handling itself, but also to
1243         allow ignoring TLS errors when testing.
1244
1245         * MiniBrowser/gtk/BrowserWindow.c:
1246         (webViewLoadFailedWithTLSerrors):
1247         (browserWindowConstructed):
1248
1249 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1250
1251         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1252         https://bugs.webkit.org/show_bug.cgi?id=142569
1253
1254         Reviewed by David Hyatt.
1255
1256         Test Optional::valueOrCompute().
1257
1258         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1259         (TestWebKitAPI::TEST):
1260
1261 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1262
1263         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1264         https://bugs.webkit.org/show_bug.cgi?id=126688
1265
1266         Reviewed by Gustavo Noronha Silva.
1267
1268         * CMakeLists.txt: Build testing tools only for developer builds,
1269         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1270         * MiniBrowser/gtk/CMakeLists.txt: Only add
1271         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1272         and add a rule to install the MiniBrowser.
1273         * MiniBrowser/gtk/main.c:
1274         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1275         builds.
1276
1277 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1278
1279         Add some DateMath tests to TestWebKitAPI
1280         https://bugs.webkit.org/show_bug.cgi?id=142565
1281
1282         Reviewed by Alexey Proskuryakov.
1283
1284         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1285         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1286         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1288         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1289
1290 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1291
1292         Regression(r181257): WTF_WorkQueue.Simple is flaky
1293         https://bugs.webkit.org/show_bug.cgi?id=142560
1294
1295         Unreviewed attempt to improve test stability.
1296
1297         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1298         the WorkQueue a little later to redue flakiness.
1299
1300 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1301
1302         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1303         https://bugs.webkit.org/show_bug.cgi?id=142555
1304
1305         Reviewed by Simon Fraser.
1306
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (setDefaultsToConsistentValuesForTesting):
1309         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1310         (WTR::InjectedBundle::platformInitialize):
1311
1312 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1313
1314         Use unsigned for HashSet size.
1315         https://bugs.webkit.org/show_bug.cgi?id=142518
1316
1317         Reviewed by Benjamin Poulain.
1318
1319         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1320         (TestWebKitAPI::TEST):
1321         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1322         (TestWebKitAPI::testInitialCapacity):
1323         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1324         (TestWebKitAPI::TEST):
1325
1326 2015-03-10  Daniel Bates  <dabates@apple.com>
1327
1328         [iOS] Add WebKitSystemInterface for iOS 8.2
1329         https://bugs.webkit.org/show_bug.cgi?id=142505
1330
1331         Rubber-stamped by Anders Carlsson.
1332
1333         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1334         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1335         copy-webkitlibraries-to-product-directory in r181286.
1336
1337         * Scripts/copy-webkitlibraries-to-product-directory:
1338
1339 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1340
1341         Extend URL filter's Term definition to support groups/subpatterns
1342         https://bugs.webkit.org/show_bug.cgi?id=142519
1343
1344         Reviewed by Alex Christensen.
1345
1346         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1347         (TestWebKitAPI::testURL):
1348
1349 2015-03-06  Jer Noble  <jer.noble@apple.com>
1350
1351         Add an option to run-webkit-tests to override the LayoutTests/ directory
1352         https://bugs.webkit.org/show_bug.cgi?id=142418
1353
1354         Reviewed by David Kilzer.
1355
1356         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1357         directory. The base port will parse the options during initialization and store the override
1358         location if present. layout_tests_dir() will return this overridden location if set.
1359
1360         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1361         (parse_args):
1362         * Scripts/webkitpy/port/base.py:
1363         (Port.__init__):
1364         (Port.layout_tests_dir):
1365
1366 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1367
1368         [CMake] Enable WorkQueue tests for CMake ports
1369         https://bugs.webkit.org/show_bug.cgi?id=142473
1370
1371         Reviewed by Darin Adler.
1372
1373         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1374         the list of source files.
1375         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1376         to the list of include directories for EFL.
1377
1378 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1379
1380         Attempt to fix timeouts on iOS Simulator layout tests
1381
1382         * Scripts/webkitpy/port/ios.py:
1383         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1384         Simulator end after the first 50 tests time out.  Some analysis
1385         this past weekend shows that the 'Booted' status in the output
1386         of `xcrun simctl list` is not sufficient (and watching the test
1387         run shows that SpringBoard hasn't fully started to the point
1388         where it's displaying icons on the home screen).  The workaround
1389         until we have a better fix is to add an arbitrary timeout to let
1390         SpringBoard finish launching.  In practice, 15 seconds is
1391         probably enough, but 30 seconds should nearly always work.
1392
1393 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1394
1395         Unreviewed. Add myself as a committer.
1396
1397         * Scripts/webkitpy/common/config/contributors.json:
1398
1399 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1400
1401         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1402
1403         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1404         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1405         an expectation that will fail if we hit the race condition.
1406         This test is inherently racy and will deadlock if the first job
1407         for queue2 takes the mutex lock before the second job for
1408         queue1.
1409
1410 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1411
1412         [Win] WTF::WorkQueue does not balance ref/deref properly
1413         https://bugs.webkit.org/show_bug.cgi?id=142471
1414
1415         Reviewed by Antti Koivisto.
1416
1417         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1418         (TestWebKitAPI::TEST): Check that the refcount is correct.
1419
1420 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1421
1422         Do not show passing test result on output of EFL layout test
1423         https://bugs.webkit.org/show_bug.cgi?id=142380
1424
1425         Reviewed by Darin Adler.
1426
1427         To show passing tests has caused inconvenience when we detect problem tests
1428         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1429         in order not to show passing tests in the output of EFL layout test.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1432         (RunWebKitTests.start):
1433
1434 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1435
1436         Unreviewed build fix.
1437
1438         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1439         (TestWebKitAPI::TEST): Remove two unused variables.
1440
1441 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1442
1443         Add some WorkQueue tests to TestWebKitAPI
1444         https://bugs.webkit.org/show_bug.cgi?id=142447
1445
1446         Reviewed by Sam Weinig.
1447
1448         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1449         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1451         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1452         (TestWebKitAPI::simpleTest):
1453         (TestWebKitAPI::longTest):
1454         (TestWebKitAPI::thirdTest):
1455         (TestWebKitAPI::finishedTests):
1456         (TestWebKitAPI::TEST):
1457         (TestWebKitAPI::longTest2):
1458
1459 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1460
1461         Remove willDestroyFrame in WKBundlePageLoaderClient
1462         https://bugs.webkit.org/show_bug.cgi?id=142389
1463
1464         Reviewed by Anders Carlsson.
1465
1466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1467         (WTR::InjectedBundlePage::InjectedBundlePage):
1468
1469 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1470
1471         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1472         https://bugs.webkit.org/show_bug.cgi?id=142433
1473
1474         Reviewed by Darin Adler.
1475
1476         Include more TestWebKitAPI tests when building for Windows. Also
1477         fix a build error in MetaAllocator.cpp caused by one of the
1478         Microsoft headers #defining 'small'.
1479
1480         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1481         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1482         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1483
1484 2015-03-06  Sam Weinig  <sam@webkit.org>
1485
1486         [Content Extensions] Move compiling of content extensions to the UIProcess
1487         https://bugs.webkit.org/show_bug.cgi?id=142402
1488
1489         Reviewed by Benjamin Poulain.
1490
1491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1492         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1493         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1494         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1495         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1496         (TestWebKitAPI::TEST_F):
1497         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1498         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1499         is now abstract).
1500
1501 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
1502
1503         [Win] Correct Windows build.
1504
1505         Rubberstamped by Michael Saboff
1506
1507         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1508         in the GOTO labels.
1509
1510 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1511
1512         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1513         https://bugs.webkit.org/show_bug.cgi?id=142385
1514
1515         Reviewed by Sergio Villar Senin.
1516
1517         Use stack allocated GMainLoopSources to make sure they are
1518         cancelled automatically if the test finishes before they have
1519         been processed.
1520
1521         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1522         (testWebViewSyncRequestOnMaxConns):
1523
1524 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1525
1526         Remove Mountain Lion libraries since ML isn't supported
1527         https://bugs.webkit.org/show_bug.cgi?id=142332
1528
1529         Reviewed by Darin Adler.
1530
1531         * Scripts/copy-webkitlibraries-to-product-directory:
1532
1533 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
1534
1535         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1536         https://bugs.webkit.org/show_bug.cgi?id=142083
1537
1538         Reviewed by Simon Fraser.
1539
1540         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1541
1542         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1543         (WebPlatformTestServer._copy_webkit_test_files):
1544
1545 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1546
1547         setup-git-clone fails due to the failure to download python-irclib-0.4.8
1548         https://bugs.webkit.org/show_bug.cgi?id=141946
1549
1550         Reviewed by Ryosuke Niwa.
1551
1552         Check in ircbot.py and irclib.py to avoid network problems in the future.
1553
1554         * Scripts/webkitpy/common/net/irc/ircbot.py:
1555         * Scripts/webkitpy/thirdparty/__init__.py:
1556         (AutoinstallImportHook.find_module):
1557         (AutoinstallImportHook._install_irc): Deleted.
1558         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1559         (ThirdpartyTest.test_imports):
1560         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1561         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1562         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1563
1564 2015-03-06  David Kilzer  <ddkilzer@apple.com>
1565
1566         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1567
1568         See also fix to config.json in r181097.
1569
1570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1571         (WebKitBuildbot): Add missing "WK2" to the names of the perf
1572         bots.
1573
1574 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1575
1576         run-jsc-stress-tests should determine the architecture from ELF binaries
1577         https://bugs.webkit.org/show_bug.cgi?id=142335
1578
1579         Reviewed by Darin Adler.
1580
1581         * Scripts/run-jsc-stress-tests:
1582
1583 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1584
1585         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1586         <http://webkit.org/b/142226>
1587
1588         Reviewed by Darin Adler.
1589
1590         * Scripts/webkitpy/port/ios.py:
1591         (IOSSimulatorPort.default_baseline_search_path): Switch the
1592         TestExpectations order of ios-simulator-wk2 from this:
1593           ios-simulator-wk2, wk2, ios-simulator
1594         To this:
1595           ios-simulator-wk2, ios-simualtor, wk2
1596
1597 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1598
1599         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1600         https://bugs.webkit.org/show_bug.cgi?id=142370
1601
1602         Reviewed by Dean Jackson.
1603
1604         * Scripts/webkitdirs.pm:
1605         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1606         logs, one for warnings, the other for errors.
1607         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1608         into the standard BuildOutput.htm document.
1609
1610 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1611
1612         Dashboard has trouble parsing iOS test output
1613         <http://webkit.org/b/142364>
1614
1615         Reviewed by Alex Christensen.
1616
1617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1618         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1619         Add fallback path to build a regex using 'matchString' so that
1620         it matches anywhere in the line.  In practice, 'matchString' is
1621         a prefix for the label following the number.
1622
1623 2015-03-05  Alex Christensen  <achristensen@webkit.org>
1624
1625         Fix linker warnings in TestWebKitAPI.
1626         https://bugs.webkit.org/show_bug.cgi?id=141912
1627
1628         Reviewed by David Kilzer.
1629
1630         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1631         Do not export TearDownTestCase or SetUpTestCase symbols.
1632
1633 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1634
1635         [Win] Unreviewed EWS fix.
1636
1637         * Scripts/webkitdirs.pm:
1638         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1639         the EWS output more usable.
1640
1641 2015-03-05  Chris Dumez  <cdumez@apple.com>
1642
1643         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1644         https://bugs.webkit.org/show_bug.cgi?id=142350
1645
1646         Reviewed by Michael Saboff and Benjamin Poulain.
1647
1648         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1649         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1650
1651         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1652         (TestWebKitAPI::TEST):
1653
1654 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1655
1656         [Win] Ensure build target directory exists when launching MSBuild
1657         https://bugs.webkit.org/show_bug.cgi?id=142360
1658
1659         Reviewed by Dean Jackson.
1660
1661         Create the build output directory (if it doesn't exist) before
1662         launching MSBuild so that it can immediately begin writing logs.
1663
1664         * Scripts/webkitdirs.pm:
1665         (buildVisualStudioProject):
1666
1667 2015-03-05  Chris Dumez  <cdumez@apple.com>
1668
1669         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1670         https://bugs.webkit.org/show_bug.cgi?id=142325
1671
1672         Reviewed by Csaba Osztrogonác.
1673
1674         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1675         As a result, "--webkit-test-runner / -2" parameters are replaced by
1676         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1677         than WebKitTestRunner.
1678
1679         * BuildSlaveSupport/build.webkit.org-config/config.json:
1680         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1681         (RunWebKit1Tests):
1682         (RunWebKit1Tests.start):
1683         (RunWebKit1LeakTests):
1684         (RunWebKit1LeakTests.start):
1685         (RunAndUploadPerfTestsWebKit1):
1686         (RunAndUploadPerfTestsWebKit1.start):
1687         (TestFactory):
1688         (TestWebKit1LeaksFactory):
1689         (TestWebKit1LeaksFactory.__init__):
1690         (TestWebKit1Factory):
1691         (TestWebKit1AllButJSCFactory):
1692         (TestAllButJSCFactory):
1693         (BuildAndPerfTestWebKit1Factory):
1694         (BuildAndPerfTestWebKit1Factory.__init__):
1695         (BuildAndPerfTestFactory):
1696         (BuildAndPerfTestFactory.__init__):
1697         (DownloadAndPerfTestWebKit1Factory):
1698         (DownloadAndPerfTestWebKit1Factory.__init__):
1699         (DownloadAndPerfTestFactory):
1700         (DownloadAndPerfTestFactory.__init__):
1701         (RunWebKitLeakTests): Deleted.
1702         (RunWebKitLeakTests.start): Deleted.
1703         (RunWebKit2Tests): Deleted.
1704         (RunWebKit2Tests.start): Deleted.
1705         (RunAndUploadPerfTestsWebKit2): Deleted.
1706         (RunAndUploadPerfTestsWebKit2.start): Deleted.
1707         (TestLeaksFactory): Deleted.
1708         (TestLeaksFactory.__init__): Deleted.
1709         (TestWebKit2Factory): Deleted.
1710         (TestWebKit2AndJSCFactory): Deleted.
1711         (BuildAndPerfTestWebKit2Factory): Deleted.
1712         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1713         (DownloadAndPerfTestWebKit2Factory): Deleted.
1714         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1715         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1716         (parse_args):
1717         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1718         (PerfTestsRunner._parse_args):
1719         * Scripts/webkitpy/port/port_testcase.py:
1720         (PortTestCase.test_build_driver):
1721
1722 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1723
1724         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1725         https://bugs.webkit.org/show_bug.cgi?id=140845
1726
1727         Reviewed by David Kilzer.
1728
1729         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1730         and generate suitable build commands to drive a full build from our
1731         existing solution files.
1732
1733         * Scripts/webkitdirs.pm:
1734         (msBuildInstallDir): Added.
1735         (determineConfigurationForVisualStudio): Revise to use MSBuild command
1736         line arguments to drive the build.
1737         (setupCygwinEnv): Warn user if MSBuild cannot be located.
1738         (buildVisualStudioProject): Revise to use MSBuild command line arguments
1739         to specify build architecture.
1740         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1741         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1742         bother looking for CoreUI or SafariTheme build logs.
1743
1744 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1745
1746         [buildbot] mastercfg_unittest.py should be runnable easily
1747         https://bugs.webkit.org/show_bug.cgi?id=142219
1748
1749         Reviewed by Chris Dumez.
1750
1751         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1752         the last Twisted version works together with this buildbot version.
1753
1754         * Scripts/webkitpy/common/system/autoinstall.py:
1755         (AutoInstaller): Added prepend_to_search_path argument to be able
1756         to prefer autoinstalled package to system package.
1757         (AutoInstaller.__init__):
1758         (AutoInstaller._set_up_target_dir):
1759         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1760         (AutoInstaller._prepare_package):
1761         (AutoInstaller._extract_targz): Renamed to _extract_tar.
1762         * Scripts/webkitpy/thirdparty/__init__.py:
1763         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1764
1765 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
1766
1767         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1768         https://bugs.webkit.org/show_bug.cgi?id=131162
1769
1770         Reviewed by Gyuyoung Kim.
1771
1772         * MiniBrowser/efl/main.c:
1773         (on_download_request):
1774         (on_download_finished):
1775         (on_download_failed):
1776         (window_create):
1777         Adapt download callbacks to new callback mechanism
1778
1779 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1780
1781         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1782
1783         In r180927 we updated the libsoup version used by the jhbuild. In
1784         this new version the sniffer uses image/x-icon instead of
1785         image/vnd.microsoft.icon for blank.ico resource.
1786
1787         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1788         (testWebResourceMimeType):
1789
1790 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1791
1792         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1793         https://bugs.webkit.org/show_bug.cgi?id=142244
1794
1795         Reviewed by Sergio Villar Senin.
1796
1797         Check that the SSL server doesn't process any request in case of
1798         TLS errors when the policy is set to FAIL.
1799
1800         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1801         (testTLSErrorsPolicy):
1802         (testTLSErrorsRedirect):
1803         (testTLSErrorsHTTPAuth):
1804         (testLoadFailedWithTLSErrors):
1805         (testSubresourceLoadFailedWithTLSErrors):
1806         (httpsServerCallback):
1807
1808 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
1809
1810         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1811         https://bugs.webkit.org/show_bug.cgi?id=141154
1812
1813         Reviewed by Jer Noble.
1814
1815         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1816
1817         For the sake of completeness WebKitTestRunner should specify temporary
1818         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1819
1820         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1821         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1822         to get data storage paths. Only Mac port has an actual implementation of it.
1823         However, WebKitTestRunner overrides them in favour of unique temporary dir
1824         which is taken from libraryPathForTesting().
1825
1826         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1827         is not implemented for EFL and GTK ports it returns an empty string.
1828         All default data folders besides MediaKeys are overridden in TestRunner
1829         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1830         env variable.
1831
1832         GTK port does not enable encrypted keys by default so
1833         WebMediaKeyStorageManager::initialize() code path is never triggered.
1834
1835         * WebKitTestRunner/TestController.cpp:
1836         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1837         WebKit ports.
1838
1839 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1840
1841         [buildbot] Add regression test to check which builder runs which tests
1842         https://bugs.webkit.org/show_bug.cgi?id=142166
1843
1844         Reviewed by Alexey Proskuryakov.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1847         (BuildStepsConstructorTest.createTest):
1848         (BuildStepsTest):
1849         (BuildStepsTest.generateTests):
1850         (BuildStepsTest.createTest):
1851         (BuildStepsTest.createTest.doTest):
1852         (BuildStepsTest.test_unnecessary_expected_results):
1853
1854 2015-03-04  Commit Queue  <commit-queue@webkit.org>
1855
1856         Unreviewed, rolling out r181054.
1857         https://bugs.webkit.org/show_bug.cgi?id=142320
1858
1859         Broke the api tests (Requested by sundiamonde on #webkit).
1860
1861         Reverted changeset:
1862
1863         "Fix linker warnings in TestWebKitAPI."
1864         https://bugs.webkit.org/show_bug.cgi?id=141912
1865         http://trac.webkit.org/changeset/181054
1866
1867 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1868
1869         Fix linker warnings in TestWebKitAPI.
1870         https://bugs.webkit.org/show_bug.cgi?id=141912
1871
1872         Reviewed by David Kilzer.
1873
1874         * TestWebKitAPI/Configurations/Base.xcconfig:
1875         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1876
1877 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
1878
1879         [Mac] Set SystemUIFontSelect in DRT and WKTR
1880         https://bugs.webkit.org/show_bug.cgi?id=142303
1881
1882         Reviewed by Myles C. Maxfield.
1883
1884         * DumpRenderTree/mac/DumpRenderTree.mm:
1885         (setDefaultsToConsistentValuesForTesting):
1886         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1887         (WTR::InjectedBundle::platformInitialize):
1888
1889 2015-03-04  Chris Dumez  <cdumez@apple.com>
1890
1891         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1892         https://bugs.webkit.org/show_bug.cgi?id=142314
1893         <rdar://problem/20046835>
1894
1895         Reviewed by Ryosuke Niwa.
1896
1897         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1898         to get WK2 code coverage.
1899
1900         * BuildSlaveSupport/build.webkit.org-config/config.json:
1901
1902 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1903
1904         Move content extensions test to properly named directory.
1905         https://bugs.webkit.org/show_bug.cgi?id=142299
1906
1907         Reviewed by Tim Horton.
1908
1909         * WebKitTestRunner/mac/TestControllerMac.mm:
1910         (WTR::TestController::platformConfigureViewForTest):
1911
1912 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1913
1914         W3C test importer should use filesystem instead of os.walk
1915         https://bugs.webkit.org/show_bug.cgi?id=142085
1916
1917         Reviewed by Bem Jones-Bey.
1918
1919         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1920         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1921         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1922
1923         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1924         Added a unit test to check that test importer is now black-box testable using a Mock system.
1925
1926         * Scripts/webkitpy/common/system/filesystem.py:
1927         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1928         (FileSystem.dirs_under.filter_all):
1929         * Scripts/webkitpy/common/system/filesystem_mock.py:
1930         (MockFileSystem.dirs_under):
1931         (MockFileSystem.dirs_under.filter_all):
1932         (MockFileSystem.getsize):
1933         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1934         (MockFileSystemTest.test_dirs_under):
1935         (MockFileSystemTest.test_dirs_under.filter_dir):
1936         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1937         (RealFileSystemTest.test_sep):
1938         (RealFileSystemTest):
1939         (RealFileSystemTest.test_dirs_under):
1940         (RealFileSystemTest.test_dirs_under.filter_this_dir):
1941         * Scripts/webkitpy/w3c/test_importer.py:
1942         (TestImporter.do_import):
1943         (TestImporter.find_importable_tests.should_keep_subdir):
1944         (TestImporter.find_importable_tests):
1945         (TestImporter.should_keep_subdir): Deleted.
1946         (TestImporter.should_skip_file): Deleted.
1947         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1948         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1949
1950 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
1951
1952         [WebEditingTester] Add support for the find and replace bar
1953         https://bugs.webkit.org/show_bug.cgi?id=142247
1954
1955         Reviewed by Enrica Casucci.
1956
1957         While it's not hooked up yet in WKWebView, adding support for the
1958         find bar to WebEditingTester will help us implement that functionality.
1959
1960         * WebEditingTester/AppDelegate.h:
1961         * WebEditingTester/AppDelegate.m:
1962         (-[WebEditingAppDelegate performTextFinderAction:]):
1963         * WebEditingTester/MainMenu.xib:
1964         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1965
1966         * WebEditingTester/WK2WebDocumentController.m:
1967         (-[WK2WebDocumentController awakeFromNib]):
1968         (-[WK2WebDocumentController performTextFinderAction:]):
1969         (-[WK2WebDocumentController findBarView]):
1970         (-[WK2WebDocumentController setFindBarView:]):
1971         (-[WK2WebDocumentController isFindBarVisible]):
1972         (-[WK2WebDocumentController setFindBarVisible:]):
1973         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1974         (-[WK2WebDocumentController layout]):
1975         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1976         pointing at the WKWebView (currently nothing will work, but the bar will
1977         show up). Install and uninstall the bar as needed.
1978
1979         * WebEditingTester/WebDocument.xib:
1980         Don't use a full-size content view. There's no need, and it makes find
1981         bar layout harder.
1982
1983         * WebEditingTester/WebDocumentController.h:
1984         * WebEditingTester/WebDocumentController.m:
1985         (-[WebDocumentController performTextFinderAction:]):
1986
1987 2015-03-03  Sam Weinig  <sam@webkit.org>
1988
1989         [Content Extensions] Split parsing and compiling of content extensions into their own files
1990         https://bugs.webkit.org/show_bug.cgi?id=142259
1991
1992         Reviewed by Anders Carlsson.
1993
1994         Add basic unit test for the content filter compiler.
1995
1996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1997         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1998         (WebCore::ContentExtensions::operator<<):
1999         (TestWebKitAPI::ContentFilterTest::SetUp):
2000         (TestWebKitAPI::TEST_F):
2001
2002 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2003
2004         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2005         https://bugs.webkit.org/show_bug.cgi?id=142230
2006
2007         Reviewed by Csaba Osztrogonác.
2008
2009         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2010         (TestFactory):
2011         (TestFactory.getProduct): Added
2012         (TestFactory.__init__): moved downloader to getProduct
2013         (BuildAndTestFactory):        
2014         (BuildAndTestFactory.getProduct): Added
2015         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2016         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2017
2018 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2019
2020         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2021         https://bugs.webkit.org/show_bug.cgi?id=142225
2022
2023         Reviewed by Carlos Garcia Campos.
2024
2025         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2026         (testWebViewWebContextLifetime):
2027         (beforeAll):
2028
2029 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2030
2031         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2032         <http://webkit.org/b/142243>
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::webProcessName):
2038         (WTR::TestController::networkProcessName):
2039         - Return the same process name on iOS and Mac because they both
2040           use the same process name for local engineering builds.
2041
2042 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2043
2044         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2045         <http://webkit.org/b/141872>
2046
2047         Reviewed by Alex Christensen.
2048
2049         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2050         semi-colons in various places and fix whitespace.
2051         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2052         constants.
2053         (_IncludeState.__init__): Add self._visited_soft_link_section
2054         boolean state variable.
2055         (_IncludeState.visited_soft_link_section): Getter for
2056         self._visited_soft_link_section.
2057         (_IncludeState.check_next_include_order): Update state machine
2058         for soft-link headers.  Add check that soft-link headers always
2059         appear last.
2060         (_classify_include): Add check for soft-link header type.
2061         (check_include_line): Return early if there is a soft-link
2062         header error.
2063
2064         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2065         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2066         including soft-link headers.
2067         (OrderOfIncludesTest.test_classify_include): Add test for
2068         _SOFT_LINK_HEADER type.
2069
2070 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2071
2072         build.webkit.org/dashboard: Don't repeatedly handle each test type
2073         https://bugs.webkit.org/show_bug.cgi?id=142211
2074
2075         Reviewed by Tim Horton and Matt Hanson.
2076
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2078         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2079         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2080         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2081         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2082         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2083         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2084         Removed functions that build a link to test step results. The buildbot provides
2085         these links in JSON.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2088         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2089         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2090         We can easily add them to the map as needed.
2091         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2092         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2093         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2094         and then build a BuildbotTestResults object, which was strange.
2095         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2096
2097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2098         Corrected an unrelated assertion that was buggy, and kept firing.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2101         (BuildbotTestResults):
2102         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2103         (BuildbotTestResults.prototype._parseResults):
2104         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2105         Moved the code for parsing JSON results for a single step here.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2108         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2109         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2110         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2111         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2112         (BuildbotTesterQueueView.prototype.update): Deleted.
2113         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2114         Updated for the new data structures. One behavior change is that we now display individual
2115         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2116         test failures, 3 platform api test failures".
2117
2118 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2119
2120         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2121         https://bugs.webkit.org/show_bug.cgi?id=142094
2122
2123         Reviewed by Csaba Osztrogonác.
2124
2125         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2126         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2127         (TestFactory):
2128         (TestFactory.__init__): Made running of JSC tests conditional.
2129         (TestAllButJSCFactory):
2130         (TestJSCFactory): Added.
2131         (TestJSCFactory.__init__):
2132         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2133
2134 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2135
2136         `build-webkit --help` is wrong about how to build for the iOS simulator
2137         <http://webkit.org/b/142223>
2138
2139         Reviewed by Csaba Osztrogonác.
2140
2141         * Scripts/build-webkit: Fix help.
2142
2143 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2144
2145         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2146
2147         * gtk/jhbuild.modules:
2148
2149 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2150
2151         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2152         https://bugs.webkit.org/show_bug.cgi?id=141508
2153
2154         Reviewed by Sergio Villar Senin.
2155
2156         Add a unit test to check that synchronous XHRs load even if the
2157         maximum connection limits are reached.
2158
2159         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2160         (testWebViewSyncRequestOnMaxConns):
2161         (serverCallback):
2162         (beforeAll):
2163         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2164
2165 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2166
2167         Update the name of ASan build step.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2170
2171 2015-03-02  Jer Noble  <jer.noble@apple.com>
2172
2173         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2174         https://bugs.webkit.org/show_bug.cgi?id=142121
2175
2176         Reviewed by Simon Fraser.
2177
2178         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2179         that the initial and final screen rects for the web content are as expected.
2180
2181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2182         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2183         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2184         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2185         (runJavaScriptAlert):
2186         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2187         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2188         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2189         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2190         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2191         (TestWebKitAPI::TEST_F):
2192
2193 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2194
2195         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2196
2197         Follow-up fix for:
2198
2199         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2200         <http://webkit.org/b/142145>
2201
2202         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2203         (-[LTRelayController _environmentVariables]): Fix think-o.
2204
2205 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2206
2207         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2208         <http://webkit.org/b/142145>
2209
2210         Reviewed by Simon Fraser.
2211
2212         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2213         (-[LTRelayController _environmentVariables]): Add.
2214         (-[LTRelayController launchApp]): Use -_environmentVariables.
2215
2216 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2217
2218         [iOS] Stop running webkit-build-directory on every layout test
2219
2220         This was originally fixed by David Farler for Bug 135409 in
2221         r172602.
2222
2223         * Scripts/webkitpy/port/ios.py:
2224         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2225         run webkit-build-directory every time it's called.
2226
2227 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2228
2229         W3C importer should use filesystem instead of shutil/host
2230         https://bugs.webkit.org/show_bug.cgi?id=142012
2231
2232         Reviewed by Bem Jones-Bey.
2233
2234         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2235
2236         * Scripts/webkitpy/w3c/test_importer.py:
2237         (main):
2238         (TestImporter.do_import):
2239         (TestImporter.find_importable_tests):
2240         (TestImporter.import_tests):
2241         (TestImporter.remove_deleted_files):
2242         (TestImporter.write_import_log):
2243
2244 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2245
2246         W3C test importer should use filesystem to read and write files
2247         https://bugs.webkit.org/show_bug.cgi?id=142084
2248
2249         Reviewed by Bem Jones-Bey.
2250
2251         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2252
2253         * Scripts/webkitpy/w3c/test_importer.py:
2254         (TestImporter.import_tests):
2255         (TestImporter.remove_deleted_files):
2256         (TestImporter.write_import_log):
2257
2258 2015-02-27  Sam Weinig  <sam@webkit.org>
2259
2260         Add WebKit2 SPI to create a DOM File object
2261         https://bugs.webkit.org/show_bug.cgi?id=142109
2262
2263         Reviewed by Tim Horton.
2264
2265         Add a test for WKBundleFileHandleRef.
2266
2267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2268         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2269         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2270         (TestWebKitAPI::didFinishLoadForFrame):
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2273         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2274         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2275
2276 2015-02-27  Michael Saboff  <msaboff@apple.com>
2277
2278         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2279         https://bugs.webkit.org/show_bug.cgi?id=142112
2280
2281         Reviewed by Filip Pizlo.
2282
2283         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2284         <someDir> as the library path.
2285
2286         * Scripts/run-jsc-benchmarks:
2287
2288 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2289
2290         [WinCairo] Unreviewed build fix.
2291
2292         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2293         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2294
2295 2015-02-27  Anders Carlsson  <andersca@apple.com>
2296
2297         Add infrastructure for handling website data in the network process
2298         https://bugs.webkit.org/show_bug.cgi?id=142092
2299
2300         Reviewed by Andreas Kling.
2301
2302         Add a menu item that will fetch all website data, delete the returned data records, and
2303         fetch all website data again so we can confirm that it's all empty.
2304
2305         * MiniBrowser/mac/WK2BrowserWindowController.m:
2306         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2307
2308 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2309
2310         [Win] Remove remaining SafariTheme cruft
2311         https://bugs.webkit.org/show_bug.cgi?id=142075
2312
2313         Reviewed by Anders Carlsson.
2314
2315         Remove reference to SafariTheme-switching preference.
2316
2317         * DumpRenderTree/win/DumpRenderTree.cpp:
2318         (resetWebPreferencesToConsistentValues):
2319         (prepareConsistentTestingEnvironment):
2320
2321 2015-02-26  Doug Russell  <d_russell@apple.com>
2322
2323         AX: Expose caret browsing preference to accessibility API
2324         https://bugs.webkit.org/show_bug.cgi?id=141862
2325
2326         Reviewed by Chris Fleizach.
2327
2328         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2329         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2330
2331         * DumpRenderTree/AccessibilityUIElement.cpp:
2332         (setBoolAttributeValueCallback):
2333         (selectedTextMarkerRangeCallback):
2334         (resetSelectedTextMarkerRangeCallback):
2335         (AccessibilityUIElement::setBoolAttributeValue):
2336         (AccessibilityUIElement::selectedTextMarkerRange):
2337         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2338         (AccessibilityUIElement::getJSClass):
2339         * DumpRenderTree/AccessibilityUIElement.h:
2340         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2341         (AccessibilityUIElement::setBoolAttributeValue):
2342         (AccessibilityUIElement::selectedTextMarkerRange):
2343         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2345         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2346         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2347         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2348         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2349         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2351         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2352         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2353         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2354
2355 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2356
2357         [Win] Remove WebKitExportGenerator project (and related)
2358         https://bugs.webkit.org/show_bug.cgi?id=142035
2359
2360         Reviewed by Dean Jackson.
2361
2362         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2363         build log from WebKitExportGenerator.
2364
2365 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         [EFL] Bump EFL version to 1.13.0
2368         https://bugs.webkit.org/show_bug.cgi?id=141708
2369
2370         Reviewed by Gyuyoung Kim.
2371
2372         * efl/jhbuild.modules:
2373
2374 2015-02-26  Sam Weinig  <sam@webkit.org>
2375
2376         Check in missing WebEditingTester.xcconfig file.
2377
2378         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2379
2380 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2381
2382         [webkitpy] Remove skipped file related crufts
2383         https://bugs.webkit.org/show_bug.cgi?id=142046
2384
2385         Reviewed by Ryosuke Niwa.
2386
2387         * Scripts/webkitpy/port/base.py:
2388         (Port.skipped_layout_tests):
2389         (Port._tests_from_skipped_file_contents): Deleted.
2390         (Port): Deleted.
2391         (Port._expectations_from_skipped_files): Deleted.
2392         * Scripts/webkitpy/port/mac_unittest.py:
2393         (MacTest.test_default_timeout_ms):
2394         (MacTest): Deleted.
2395         (test_tests_from_skipped_file_contents): Deleted.
2396
2397 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2398
2399         [Win] Unreviewed WinCairo build fix after r180653.
2400
2401         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2402
2403         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2404         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2405         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2406         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2407         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2408
2409 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2410
2411         [Win] Use WEBCORE_EXPORT instead of Definition file
2412         https://bugs.webkit.org/show_bug.cgi?id=141734
2413
2414         Reviewed by Alex Christensen.
2415
2416         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2417         Use a precompiled header so we can define our export macros properly.
2418         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2419         Visual studio automatic update stuff.
2420         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2421         Set up Precompiled Header use for project..
2422         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2423         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2424         declarations for building DumpRenderTree as a client of
2425         WebCore/WebKit.
2426
2427 2015-02-25  Mark Lam  <mark.lam@apple.com>
2428
2429         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2430         <https://webkit.org/b/141672>
2431
2432         Reviewed by Alexey Proskuryakov.
2433
2434         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2435         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2436         implementation that we can tell ASan to ignore.
2437
2438         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2439         which isn't effective for working around this issue. 
2440
2441         * asan/webkit-asan-ignore.txt:
2442
2443 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2444
2445         CodeBlock crashes when dumping op_push_name_scope
2446         https://bugs.webkit.org/show_bug.cgi?id=141953
2447
2448         Reviewed by Filip Pizlo.
2449
2450         * Scripts/run-jsc-stress-tests:
2451
2452 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2453
2454         W3C test importer should use argparse instead of optparse
2455         https://bugs.webkit.org/show_bug.cgi?id=142013
2456
2457         Reviewed by Bem Jones-Bey.
2458
2459         * Scripts/webkitpy/w3c/test_importer.py:
2460         (main): Updating according argparse.
2461         (parse_args): Moving from optparse to argparse.
2462
2463 2015-02-25  Brady Eidson  <beidson@apple.com>
2464
2465         Get rid of TestInvocation::pathOrURL
2466         https://bugs.webkit.org/show_bug.cgi?id=142021
2467
2468         Reviewed by Tim Horton.
2469
2470         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2471         but most code that uses it expected an absolute path.
2472
2473         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2474
2475         * WebKitTestRunner/TestController.cpp:
2476         (WTR::TestController::updateWebViewSizeForTest):
2477         (WTR::TestController::updateWindowScaleForTest):
2478         (WTR::shouldUseFixedLayout):
2479         (WTR::TestController::updateLayoutTypeForTest):
2480
2481         * WebKitTestRunner/TestInvocation.cpp:
2482         (WTR::TestInvocation::TestInvocation):
2483         (WTR::TestInvocation::urlContains):
2484         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2485         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2486         (WTR::TestInvocation::invoke):
2487         (WTR::shouldLogFrameLoadDelegates): Deleted.
2488         (WTR::shouldLogHistoryClientCallbacks): Deleted.
2489         * WebKitTestRunner/TestInvocation.h:
2490         (WTR::TestInvocation::pathOrURL): Deleted.
2491
2492         * WebKitTestRunner/ios/TestControllerIOS.mm:
2493         (WTR::shouldMakeViewportFlexible):
2494         (WTR::TestController::platformConfigureViewForTest):
2495
2496         * WebKitTestRunner/mac/TestControllerMac.mm:
2497         (WTR::shouldUseThreadedScrolling):
2498         (WTR::TestController::platformConfigureViewForTest):
2499
2500 2015-02-25  Brady Eidson  <beidson@apple.com>
2501
2502         Layout test support for user content filters
2503         https://bugs.webkit.org/show_bug.cgi?id=142018
2504
2505         Reviewed by Tim Horton.
2506
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2509
2510         * WebKitTestRunner/mac/TestControllerMac.mm:
2511         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2512           file before loading the test itself.
2513
2514 2015-02-24  Sam Weinig  <sam@webkit.org>
2515
2516         Convert WebEditingTester to use xcconfig files
2517         https://bugs.webkit.org/show_bug.cgi?id=141879
2518
2519         Reviewed by Darin Adler.
2520
2521         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2522
2523         * WebEditingTester/Configurations: Added.
2524         * WebEditingTester/Configurations/Base.xcconfig: Added.
2525         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2526         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2527
2528 2015-02-24  Andy Estes  <aestes@apple.com>
2529
2530         Teach MiniBrowser how to disable per-window web processes
2531         https://bugs.webkit.org/show_bug.cgi?id=141988
2532
2533         Reviewed by Darin Adler.
2534
2535         * MiniBrowser/mac/AppDelegate.m:
2536         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2537         * MiniBrowser/mac/SettingsController.h:
2538         * MiniBrowser/mac/SettingsController.m:
2539         (-[SettingsController _populateMenu]): Added a new Settings menu item.
2540         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2541         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2542         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2543
2544 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
2545
2546         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2547         https://bugs.webkit.org/show_bug.cgi?id=141889
2548
2549         Reviewed by Darin Adler.
2550
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2552
2553 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
2554
2555         REGRESSION(r179429): Can't type comments in Facebook
2556         https://bugs.webkit.org/show_bug.cgi?id=141859
2557
2558         Reviewed by Brent Fulgham.
2559
2560         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2561
2562         * DumpRenderTree/mac/DumpRenderTree.mm:
2563         (resetWebPreferencesToConsistentValues):
2564         * DumpRenderTree/win/DumpRenderTree.cpp:
2565         (resetWebPreferencesToConsistentValues):
2566         * WebKitTestRunner/TestController.cpp:
2567         (WTR::TestController::resetPreferencesToConsistentValues):
2568
2569 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2570
2571         Crash loading local file with WebPageProxy::loadAlternateHTMLString
2572         https://bugs.webkit.org/show_bug.cgi?id=141867
2573
2574         Reviewed by Anders Carlsson.
2575
2576         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2577         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2578         be shared with the new test.
2579         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2580         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2581         (testLoadAlternateHTMLForLocalPage):
2582         (beforeAll):
2583
2584 2015-02-24  David Kilzer  <ddkilzer@apple.com>
2585
2586         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2587         <http://webkit.org/b/141900>
2588
2589         Reviewed by Myles C. Maxfield.
2590
2591         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2592         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2593         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2594         - Rename to share code with iOS.
2595         - Add USE(APPKIT) around AppKit-specific headers and code.
2596         - Fix a check-webkit-style warning.
2597         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2598         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2599         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2600         - Remove ios/ActivateFontsIOS.mm.
2601         - Fix InjectedBundle/cocoa group to represent the directory on
2602           disk.  Includes a change to InjectedBundlePageCocoa.mm.
2603
2604 2015-02-23  Commit Queue  <commit-queue@webkit.org>
2605
2606         Unreviewed, rolling out r180547 and r180550.
2607         https://bugs.webkit.org/show_bug.cgi?id=141957
2608
2609         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2610
2611         Reverted changesets:
2612
2613         "REGRESSION(r179429): Can't type comments in Facebook"
2614         https://bugs.webkit.org/show_bug.cgi?id=141859
2615         http://trac.webkit.org/changeset/180547
2616
2617         "Constructor returning null should construct an object instead
2618         of null"
2619         https://bugs.webkit.org/show_bug.cgi?id=141640
2620         http://trac.webkit.org/changeset/180550
2621
2622 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2623
2624         REGRESSION(r179429): Can't type comments in Facebook
2625         https://bugs.webkit.org/show_bug.cgi?id=141859
2626
2627         Reviewed by Geoffrey Garen.
2628
2629         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2630
2631         * DumpRenderTree/mac/DumpRenderTree.mm:
2632         (resetWebPreferencesToConsistentValues):
2633         * WebKitTestRunner/TestController.cpp:
2634         (WTR::TestController::resetPreferencesToConsistentValues):
2635
2636 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
2637
2638         [EFL] fix eo errors
2639         https://bugs.webkit.org/show_bug.cgi?id=141909
2640
2641         Reviewed by Gyuyoung Kim.
2642
2643         Fix eo errors that occur whenever minibrowser is launched.
2644         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2645         - elm_obj_win_resize_object_add's first parameter should be elm_win
2646
2647         * MiniBrowser/efl/main.c:
2648         (window_create):
2649
2650 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2651
2652         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2653
2654         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2655         (TestWebKitAPI::TEST):
2656
2657 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2658
2659         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2660         https://bugs.webkit.org/show_bug.cgi?id=141935
2661
2662         Reviewed by Myles C. Maxfield.
2663
2664         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2665         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2666         tests for assigning from nullptr.
2667
2668 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2669
2670         WTF::WeakPtr should have a 'forget' method.
2671         https://bugs.webkit.org/show_bug.cgi?id=141923
2672
2673         Reviewed by Myles C. Maxfield.
2674
2675         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2676         (TestWebKitAPI::TEST): Added 'Forget' tests case.
2677
2678 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2679
2680         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2681         https://bugs.webkit.org/show_bug.cgi?id=141920
2682
2683         Reviewed by Tim Horton.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2686         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2687         Do the same thing as we do for regular green bubbles.
2688
2689 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2690
2691         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2692         https://bugs.webkit.org/show_bug.cgi?id=141925
2693
2694         Reviewed by Tim Horton.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2697         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2698
2699 2015-02-23  Anders Carlsson  <andersca@apple.com>
2700
2701         Add API for fetching website data records to _WKWebsiteDataStore
2702         https://bugs.webkit.org/show_bug.cgi?id=141926
2703
2704         Reviewed by Beth Dakin.
2705
2706         * MiniBrowser/mac/MainMenu.xib:
2707         * MiniBrowser/mac/WK2BrowserWindowController.m:
2708         (-[WK2BrowserWindowController fetchWebsiteData:]):
2709         Add menu item to fetch and dump website data.
2710
2711 2015-02-23  David Kilzer  <ddkilzer@apple.com>
2712
2713         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2714         <http://webkit.org/b/141884>
2715
2716         Reviewed by Alexey Proskuryakov.
2717
2718         * Scripts/webkitpy/port/leakdetector.py:
2719         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2720         snowleopard, lion and older leaks.  Add known leak for
2721         mavericks, but check Port.operating_system before calling
2722         Port.is_mavericks.
2723         * Scripts/webkitpy/port/mac.py:
2724         (MacPort.is_snowleopard): Delete.
2725         (MacPort.is_lion): Delete.
2726         (MacPort.is_mavericks): Add.
2727
2728 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2729
2730         build.webkit.org/dashboard should filter out commits to other branches
2731         https://bugs.webkit.org/show_bug.cgi?id=140362
2732
2733         Reviewed by Tim Horton.
2734
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2736         (BuildbotQueue):
2737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2738         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2739         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2740         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2741         (BuildbotQueueView.prototype.revisionContentForIteration):
2742         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2743         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2744         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2746         (Trac.prototype.get oldestRecordedRevisionNumber):
2747         (Trac.prototype.commitsOnBranch):
2748         (Trac.prototype._xmlTimelineURL):
2749         (Trac.prototype._convertCommitInfoElementToObject):
2750         (Trac.prototype._update):
2751         (Trac.prototype.startPeriodicUpdates):
2752         (Trac.prototype.loadMoreHistoricalData):
2753         (Trac.prototype.update): Deleted.
2754
2755 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2756
2757         Tests don't work on some bots: Failed to stop wptwk
2758         https://bugs.webkit.org/show_bug.cgi?id=141235
2759
2760         Reviewed by Ryosuke Niwa.
2761
2762         Logging of server subprocesses in launcher script.
2763         Killing of server subprocesses when stopping/before starting.
2764         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2765
2766         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2767         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
2768         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2769         (WebPlatformTestServer.__init__):
2770         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2771         (WebPlatformTestServer):
2772         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2773         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
2774         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2775         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2776         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2777         (TestWebPlatformTestServer):
2778         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2779
2780 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2781
2782         [WebEditingTester] Allow dropping HTML files on the app
2783         https://bugs.webkit.org/show_bug.cgi?id=141834
2784
2785         Reviewed by Simon Fraser.
2786
2787         * WebEditingTester/AppDelegate.m:
2788         (-[WebEditingAppDelegate openDocument:]):
2789         (-[WebEditingAppDelegate application:openFile:]):
2790         Implement application:openFile:, factoring file loading code out of openDocument.
2791
2792         * WebEditingTester/Info.plist:
2793         Register as an editor for HTML files.
2794
2795         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2796         Enrica is not an organization.
2797
2798 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2799
2800         [WebEditingTester] Expand "WK" to "WebKit" in a few places
2801         https://bugs.webkit.org/show_bug.cgi?id=141833
2802
2803         Reviewed by Anders Carlsson.
2804
2805         * WebEditingTester/AppDelegate.h:
2806         * WebEditingTester/AppDelegate.m:
2807         (-[WebEditingAppDelegate newEditor:]):
2808         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2809         (-[WebEditingAppDelegate validateMenuItem:]):
2810         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2811         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2812         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2813         (-[WebEditingAppDelegate showOperations:]): Deleted.
2814         * WebEditingTester/MainMenu.xib:
2815         The WK abbreviation is unnaturally grating in menu items for some reason.
2816
2817 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2818
2819         [WebEditingTester] Add a custom protocol for loading canned content
2820         https://bugs.webkit.org/show_bug.cgi?id=141830
2821
2822         Reviewed by Enrica Casucci.
2823
2824         Add a canned:// protocol handler, which can be used to emulate behaviors
2825         in WebKit client apps (like Mail) that use custom protocol handlers,
2826         which can have important effects on editing (mostly, the URLs are only
2827         valid inside of the client application, but not when copied/dragged out).
2828
2829         For now, we only support two canned files:
2830
2831             canned://dice is a PNG of dice (stolen from LayoutTests/)
2832             canned://text is the string "canned text" served as text/html
2833
2834         In the future we could support things like very large (generated) files,
2835         progressive loading, etc. to further simulate conditions in other apps.
2836
2837         * WebEditingTester/AppDelegate.m:
2838         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2839         Register the protocol with CFNetwork, and the scheme with WebKit2.
2840
2841         * WebEditingTester/Canned Content/dice.png: Added.
2842         * WebEditingTester/CannedContent.h: Added.
2843         * WebEditingTester/CannedContent.m: Added.
2844         (-[CannedContent initWithRequest:cachedResponse:client:]):
2845         (+[CannedContent canonicalRequestForRequest:]):
2846         (+[CannedContent canInitWithRequest:]):
2847         We only want to handle canned:// URLs.
2848
2849         (-[CannedContent startLoading]):
2850         For now, immediately load the two files we know about.
2851         Otherwise, immediately fail the load.
2852
2853         (-[CannedContent stopLoading]):
2854         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2855
2856 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2857
2858         [WebEditingTester] Implement an open panel
2859         https://bugs.webkit.org/show_bug.cgi?id=141829
2860
2861         Reviewed by Simon Fraser.
2862
2863         * WebEditingTester/AppDelegate.m:
2864         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2865         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2866         (-[WebEditingAppDelegate openDocument:]):
2867         Add an open panel (with radio buttons to pick which WebKit to open with).
2868         Loads the file as an HTML string.
2869
2870 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
2871
2872         [WebEditingTester] @properties, dot syntax, and remember the window position
2873         https://bugs.webkit.org/show_bug.cgi?id=141843
2874
2875         Reviewed by Tim Horton.
2876         
2877         Modernize a bit with more dot syntax, use @property for the web views,
2878         and give the main window an Autosave name so it remembers the widow position.
2879
2880         * WebEditingTester/WK1WebDocumentController.m:
2881         (-[WK1WebDocumentController awakeFromNib]):
2882         (-[WK1WebDocumentController loadHTMLString:]):
2883         * WebEditingTester/WK2WebDocumentController.m:
2884         (-[WK2WebDocumentController awakeFromNib]):
2885         * WebEditingTester/WebDocument.xib:
2886
2887 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2888
2889         [WebEditingTester] Hook up key equivalents for new window action
2890         https://bugs.webkit.org/show_bug.cgi?id=141828
2891
2892         Reviewed by Enrica Casucci.
2893
2894         * WebEditingTester/AppDelegate.h:
2895         * WebEditingTester/AppDelegate.m:
2896         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2897         (-[WebEditingAppDelegate newEditor:]):
2898         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2899         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2900         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2901         (defaultConfiguration): Deleted.
2902         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2903         Move WKWebViewConfiguration setup into WK2WebDocumentController.
2904         Remove unused application termination code.
2905         Update new-window menu item key equivalents when launching and when
2906         changing the use-WebKit2-by-default setting.
2907         Make WebDocumentController subclasses all initialized the same way,
2908         and use that to factor out alloc/init.
2909         Rename loadContent to loadHTMLString for future use.
2910
2911         * WebEditingTester/MainMenu.xib:
2912         Add default key equivalents.
2913         Cmd-N will always make the default kind of window (controlled by the pref).
2914         Cmd-Opt-N will always make the other kind.
2915         The menu items are configured as alternates so they only show up if you
2916         press alt (just like in MiniBrowser).
2917
2918         * WebEditingTester/WK1WebDocumentController.m:
2919         (-[WK1WebDocumentController loadHTMLString:]):
2920         (-[WK1WebDocumentController loadContent]): Deleted.
2921         * WebEditingTester/WK2WebDocumentController.h:
2922         * WebEditingTester/WK2WebDocumentController.m:
2923         (defaultConfiguration):
2924         (-[WK2WebDocumentController awakeFromNib]):
2925         (-[WK2WebDocumentController loadHTMLString:]):
2926         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2927         (-[WK2WebDocumentController dealloc]): Deleted.
2928         * WebEditingTester/WebDocumentController.h:
2929         * WebEditingTester/WebDocumentController.m:
2930         (-[WebDocumentController init]):
2931         (-[WebDocumentController initWithWindow:]):
2932         (+[WebDocumentController defaultEditingSource]):
2933         (-[WebDocumentController loadHTMLString:]):
2934         (-[WebDocumentController windowDidLoad]): Deleted.
2935         (-[WebDocumentController defaultEditingSource]): Deleted.
2936         (-[WebDocumentController applicationTerminating]): Deleted.
2937         (-[WebDocumentController loadContent]): Deleted.
2938
2939 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2940
2941         [WebEditingTester] ARC-ify WebEditingTester
2942         https://bugs.webkit.org/show_bug.cgi?id=141827
2943
2944         Reviewed by Sam Weinig.
2945
2946         * WebEditingTester/AppDelegate.m:
2947         (-[WebEditingAppDelegate showOperations:]):
2948         * WebEditingTester/EditingOperations.m:
2949         (editingOperations):
2950         * WebEditingTester/WK1WebDocumentController.m:
2951         (-[WK1WebDocumentController dealloc]): Deleted.
2952         * WebEditingTester/WK2WebDocumentController.m:
2953         (-[WK2WebDocumentController dealloc]): Deleted.
2954         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2955         Turn on ARC and remove a few retain/release/autorelease calls.
2956         We don't need to implement dealloc in either document controller
2957         because WebView and WKWebView's UIDelegate property does not hold a
2958         strong reference.
2959
2960 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2961
2962         [WebEditingTester] Factor out list of editing operations
2963         https://bugs.webkit.org/show_bug.cgi?id=141826
2964
2965         Reviewed by Sam Weinig.
2966
2967         * WebEditingTester/AppDelegate.m:
2968         (-[WebEditingAppDelegate showOperations:]):
2969         * WebEditingTester/EditingOperations.h: Added.
2970         * WebEditingTester/EditingOperations.m: Added.
2971         (editingOperations):
2972         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2973         Move EditingOperations array to its own file, and make it an NSArray
2974         instead of a C array. Adjust accordingly in showOperations:.
2975
2976 2015-02-20  Michael Saboff  <msaboff@apple.com>
2977
2978         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2979         https://bugs.webkit.org/show_bug.cgi?id=141676
2980
2981         Reviewed by Filip Pizlo.
2982
2983         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2984         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2985         large string expression that we want to eval.
2986
2987         * Scripts/run-jsc-stress-tests:
2988
2989 2015-02-19  Daniel Bates  <dabates@apple.com>
2990
2991         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2992         https://bugs.webkit.org/show_bug.cgi?id=141815
2993         <rdar://problem/19893933>
2994
2995         Reviewed by Simon Fraser.
2996
2997         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2998         was booted by iOS Simulator in a previous run of run-webkit-test.
2999
3000         * Scripts/webkitpy/port/ios.py:
3001         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3002         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3003         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3004
3005 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3006
3007         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3008         <http://webkit.org/b/141799>
3009
3010         Reviewed by Alex Christensen.
3011
3012         * Scripts/webkitpy/style/checkers/cpp.py:
3013         (_IncludeState.check_next_include_order): Don't emit a warning
3014         if the primary header exists and the source file name ends with
3015         "SoftLink.cpp".  Add 'filename' argument to method.
3016         (check_include_line): Pass in 'filename'.
3017
3018         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3019         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3020         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3021         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3022         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3023         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3024         - Add test filename arguments for calls to
3025           check_next_include_order().
3026         (OrderOfIncludesTest.test_primary_header): Add test for a file
3027         name ending in "SoftLink.cpp".
3028
3029 2015-02-18  Enrica Casucci  <enrica@apple.com>
3030
3031         Add new tool to test editable Webviews.
3032         https://bugs.webkit.org/show_bug.cgi?id=141772
3033
3034         Reviewed by Tim Horton.
3035
3036         Adding WebEditingTester, a Cocoa application to
3037         test WK1 and Wk2 views in editable mode.
3038
3039         * WebEditingTester: Added.
3040         * WebEditingTester/AppDelegate.h: Added.
3041         * WebEditingTester/AppDelegate.m: Added.
3042         (-[WebEditingAppDelegate init]):
3043         (defaultConfiguration):
3044         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3045         (-[WebEditingAppDelegate applicationWillTerminate:]):
3046         (-[WebEditingAppDelegate newEditor:]):
3047         (-[WebEditingAppDelegate showOperations:]):
3048         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3049         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3050         (-[WebEditingAppDelegate validateMenuItem:]):
3051         * WebEditingTester/Info.plist: Added.
3052         * WebEditingTester/MainMenu.xib: Added.
3053         * WebEditingTester/WK1WebDocumentController.h: Added.
3054         * WebEditingTester/WK1WebDocumentController.m: Added.
3055         (-[WK1WebDocumentController awakeFromNib]):
3056         (-[WK1WebDocumentController loadContent]):
3057         (-[WK1WebDocumentController dealloc]):
3058         (-[WK1WebDocumentController pasteAsMarkup:]):
3059         * WebEditingTester/WK2WebDocumentController.h: Added.
3060         * WebEditingTester/WK2WebDocumentController.m: Added.
3061         (-[WK2WebDocumentController initWithConfiguration:]):
3062         (-[WK2WebDocumentController pasteAsMarkup:]):
3063         (-[WK2WebDocumentController awakeFromNib]):
3064         (-[WK2WebDocumentController dealloc]):
3065         (-[WK2WebDocumentController loadContent]):
3066         * WebEditingTester/WebDocument.xib: Added.
3067         * WebEditingTester/WebDocumentController.h: Added.
3068         * WebEditingTester/WebDocumentController.m: Added.
3069         (-[WebDocumentController initWithWindow:]):
3070         (-[WebDocumentController windowDidLoad]):
3071         (-[WebDocumentController defaultEditingSource]):
3072         (-[WebDocumentController applicationTerminating]):
3073         (-[WebDocumentController loadContent]):
3074         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3075         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3076         * WebEditingTester/main.m: Added.
3077         (main):
3078
3079 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3080
3081         Run JSC tests on ARM EFL bots
3082         https://bugs.webkit.org/show_bug.cgi?id=141165
3083
3084         Reviewed by Alexey Proskuryakov.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/config.json:
3087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3088         (RunJavaScriptCoreTests.countFailures):
3089         (RunRemoteJavaScriptCoreTests):
3090         (RunRemoteJavaScriptCoreTests.start):
3091         (BuildAndRemoteJSCTestsFactory):
3092         (BuildAndRemoteJSCTestsFactory.__init__):
3093
3094 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3095
3096         Streamline unexported function build fixes
3097         https://bugs.webkit.org/show_bug.cgi?id=141761
3098
3099         Reviewed by Alex Christensen.
3100
3101         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3102         We don't need to ignore symbols that are not exported due to the .unexp file.
3103
3104 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3105
3106         Remove more references to WebCore.exp.in
3107         https://bugs.webkit.org/show_bug.cgi?id=141747
3108
3109         Reviewed by Alexey Proskuryakov.
3110
3111         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3112         (ShouldBuildTest):
3113
3114 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3115
3116         Windows test results should not fall back to mac-mountainlion after r180176
3117         https://bugs.webkit.org/show_bug.cgi?id=141719
3118
3119         Reviewed by Brent Fulgham.
3120
3121         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3122         (_should_file_trigger_build):
3123         * Scripts/webkitpy/port/win.py:
3124         (WinPort.default_baseline_search_path):
3125         * Scripts/webkitpy/port/win_unittest.py:
3126         (WinPortTest.test_baseline_search_path):
3127
3128 2015-02-17  Daniel Bates  <dabates@apple.com>
3129
3130         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3131         https://bugs.webkit.org/show_bug.cgi?id=141718
3132
3133         Reviewed by Alex Christensen.
3134
3135         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3136
3137         * Scripts/webkitpy/port/ios.py:
3138         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3139         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3140         appropriate action, say exit(3) before running any layout tests.
3141         * Scripts/webkitpy/xcode/simulator.py:
3142         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3143         with the specified UDID.
3144         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3145         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3146         boot and shut down the device, erasing the device between tries so as to restore the device
3147         to a known good state.
3148
3149 2015-02-17  Daniel Bates  <dabates@apple.com>
3150
3151         run_webkit_tests.py should not know about iOS Simulator details
3152         https://bugs.webkit.org/show_bug.cgi?id=141711
3153
3154         Reviewed by Alex Christensen.
3155
3156         Run_webkit_tests.py should only parse the iOS-specific command
3157         line options --runtime and --device-type. Let the port-specific
3158         logic in ios.py validate the parsed options and instantiate
3159         internal data structures.
3160
3161         Currently run_webkit_tests.py parses the iOS-specific command
3162         line options --runtime and --device-type, validates them, and
3163         instantiates internal data structures from the parsed strings.
3164         Instead the validation logic and instantiation of internal
3165         data structures should be handled by the iOS port object.
3166
3167         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3168         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3169         and instantiate internal data structures for them.
3170         * Scripts/webkitpy/port/driver.py:
3171         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3172         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3173         respectively.
3174         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3175         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3176         object from --runtime, if specified. Otherwise, instantiates a Runtime
3177         object for the latest installed iphonesimulator SDK version.
3178         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3179         object from --device-type, if specified. Otherwise, instantiates
3180         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3181         machine, respectively.
3182         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3183         runtime is available to use.
3184         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3185         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3186         * Scripts/webkitpy/xcode/simulator.py:
3187         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3188         with a runtime identifier for the specified iOS version.
3189
3190 2015-02-17  Dana Burkart  <dburkart@apple.com>
3191
3192         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3193         https://bugs.webkit.org/show_bug.cgi?id=141672
3194
3195         Reviewed by David Kilzer.
3196
3197         * asan/webkit-asan-ignore.txt:
3198
3199 2015-02-17  Alex Christensen  <achristensen@webkit.org>
3200
3201         Remove WebCore.exp.in and clean up.
3202         https://bugs.webkit.org/show_bug.cgi?id=141491
3203
3204         Reviewed by Andreas Kling.
3205
3206         * Scripts/sort-export-file: Removed.
3207         * Scripts/webkitpy/style/checker.py:
3208         (_all_categories):
3209         (FileType):
3210         (CheckerDispatcher._file_type):
3211         (CheckerDispatcher._create_checker):
3212         Don't check if the export files are sorted.
3213         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3214         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3215
3216 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3217
3218         Unreviewed. Fix GTK+ make distcheck.
3219
3220         Do not exclude bmalloc directory from the tarball.
3221
3222         * gtk/manifest.txt.in:
3223
3224 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3225
3226         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3227
3228         I forgot to add the return of a bool function.
3229
3230         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3231         (WebKitDOMNodeTest::testDOMCache):
3232
3233 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         [GTK] GObject DOM bindings object are cached forever
3236         https://bugs.webkit.org/show_bug.cgi?id=141558
3237
3238         Reviewed by Sergio Villar Senin.
3239
3240         Add checks for all DOM objects to ensure they are not leaked. Also
3241         add a dedicated test for the DOM Object Cache.
3242
3243         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3244         (WebKitDOMNodeFilterTest::testTreeWalker):
3245         (WebKitDOMNodeFilterTest::testNodeIterator):
3246         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3247         (WebKitDOMNodeTest::testHierarchyNavigation):
3248         (WebKitDOMNodeTest::testInsertion):
3249         (WebKitDOMNodeTest::testTagNames):
3250         (WebKitDOMNodeTest::testDOMCache):
3251         (registerTests):
3252         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3253         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3254         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3255         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3256         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3257         (testWebKitDOMObjectCache):
3258         (beforeAll):
3259         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3260         (documentLoadedCallback):
3261
3262 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3263
3264         [GTK] WebKitFrame objects are never released
3265         https://bugs.webkit.org/show_bug.cgi?id=141641
3266
3267         Reviewed by Martin Robinson.
3268
3269         Add a way to check GObjects leaks for WebProcess tests and check
3270         WebKitFrame objects are not leaked.
3271
3272         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3273         (WebKitFrameTest::testMainFrame):
3274         (WebKitFrameTest::testURI):
3275         (WebKitFrameTest::testJavaScriptContext):
3276         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3277         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3278         (runTest):
3279         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3280
3281 2015-02-16  Tim Horton  <timothy_horton@apple.com>
3282
3283         Fix the MiniBrowser build with newer clang
3284
3285         * MiniBrowser/mac/SettingsController.m:
3286         (-[SettingsController _toggleBooleanDefault:]):
3287         * MiniBrowser/mac/WK1BrowserWindowController.m:
3288         (-[WK1BrowserWindowController windowWillClose:]):
3289         * MiniBrowser/mac/WK2BrowserWindowController.m:
3290         (-[WK2BrowserWindowController windowWillClose:]):
3291         NSApp is id and clang gets confused about which -delegate we're talking about.
3292
3293 2015-02-16  Antti Koivisto  <antti@apple.com>
3294
3295         Develop/Disable Caches does not properly disable disk cache
3296         https://bugs.webkit.org/show_bug.cgi?id=141636
3297
3298         Reviewed by Anders Carlsson.
3299
3300         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3301         the network process too.
3302
3303         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3304
3305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3306         (WTR::InjectedBundle::beginTesting):
3307         (WTR::InjectedBundle::setCacheModel):
3308         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3310
3311             Forward to TestController.
3312
3313         (WTR::TestRunner::setCacheModel):
3314         * WebKitTestRunner/TestInvocation.cpp:
3315         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3316
3317 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
3318
3319         Unreviewed. Add myself as a committer.
3320
3321         * Scripts/webkitpy/common/config/contributors.json:
3322
3323 2015-02-15  David Kilzer  <ddkilzer@apple.com>
3324
3325         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3326         <http://webkit.org/b/141607>
3327
3328         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3329         externals in Source/WebCore/Configurations/WebCore.unexp when
3330         building with Xcode 5.x.
3331         (readXcode5SymbolsToIgnore): Add.
3332
3333 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
3334
3335         [EFL] fix Evas GL engine error.
3336         https://bugs.webkit.org/show_bug.cgi?id=141621
3337
3338         Reviewed by Gyuyoung Kim.
3339
3340         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3341
3342         * MiniBrowser/efl/main.c:
3343         (elm_main):
3344
3345 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
3346
3347         [buildbot] Enable run-api-tests on release Mac bots
3348         https://bugs.webkit.org/show_bug.cgi?id=141518
3349
3350         Reviewed by Darin Adler.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3353         (RunUnitTests):
3354         (BuildFactory.__init__):
3355         (TestFactory.__init__):
3356         (BuildAndTestFactory.__init__):
3357         (RunUnitTests.start): Deleted.
3358         (unitTestsSupported): Deleted.
3359
3360 2015-02-13  Anders Carlsson  <andersca@apple.com>
3361
3362         Add a move constructor and move assignment operator to Deque
3363         https://bugs.webkit.org/show_bug.cgi?id=141571
3364
3365         Reviewed by Andreas Kling.
3366
3367         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3368         (TestWebKitAPI::TEST):
3369
3370 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3371
3372         run-jsc-stress-tests --remote should skip profiler tests
3373         https://bugs.webkit.org/show_bug.cgi?id=141470
3374
3375         Reviewed by Filip Pizlo.
3376
3377         * Scripts/run-jsc-stress-tests:
3378
3379 2015-02-13  Anders Carlsson  <andersca@apple.com>
3380
3381         Add an initializer list constructor to Deque
3382         https://bugs.webkit.org/show_bug.cgi?id=141565
3383
3384         Reviewed by Andreas Kling.
3385
3386         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3387         (TestWebKitAPI::TEST):
3388
3389 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3390
3391         [buildbot] Remove buildJSCTool cruft from master.cfg
3392         https://bugs.webkit.org/show_bug.cgi?id=141513
3393
3394         Reviewed by Alexey Proskuryakov.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3397         (RunJavaScriptCoreTests):
3398         (RunJavaScriptCoreTests.start):
3399         (RunWebKitTests):
3400         (RunWebKitTests.start):
3401         (TestFactory.__init__):
3402         (TestLeaksFactory.__init__):
3403         (RunJavaScriptCoreTests.__init__): Deleted.
3404         (RunWebKitTests.__init__): Deleted.
3405
3406 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3407
3408         Unreviewed, remove empty directories.
3409
3410         * DumpRenderTree/gtk: Removed.
3411         * DumpRenderTree/gtk/fonts: Removed.
3412         * DumpRenderTree/unix: Removed.
3413         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3414         * GtkLauncher: Removed.
3415         * TestWebKitAPI/Tests/WebKitGtk: Removed.
3416         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3417         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3418         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3419
3420 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3421
3422         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3423         https://bugs.webkit.org/show_bug.cgi?id=141519
3424
3425         Reviewed by Alexey Proskuryakov.
3426
3427         * Scripts/build-webkittestrunner:
3428
3429 2015-02-12  Alex Christensen  <achristensen@webkit.org>
3430
3431         Removed empty directory.
3432
3433         * WinCELauncher: Removed.
3434
3435 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3436
3437         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
3438         https://bugs.webkit.org/show_bug.cgi?id=141202
3439
3440         Reviewed by Darin Adler.
3441
3442         * Scripts/run-jsc-stress-tests:
3443
3444 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
3445
3446         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
3447         https://bugs.webkit.org/show_bug.cgi?id=141517
3448
3449         Reviewed by Anders Carlsson.
3450
3451         We do not need to locate or use the DLL's that came with Safari, so stop
3452         failing when we cannot find them. Also remove some old Qt cruft from this
3453         script.
3454
3455         * BuildSlaveSupport/built-product-archive:
3456         (archiveBuiltProduct): 
3457         (extractBuiltProduct):
3458
3459 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
3460
3461         [Win] [64-bit] Work around MSVC2013 Runtime Bug
3462         https://bugs.webkit.org/show_bug.cgi?id=141498
3463         <rdar://problem/19803642>
3464
3465         Reviewed by Anders Carlsson.
3466
3467         Disable FMA3 instruction use in the MSVC math library to
3468         work around a VS2013 runtime crash. We can remove this
3469         workaround when we switch to VS2015.
3470
3471         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
3472         disable FMA3 support.
3473         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
3474         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
3475         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3476         * Scripts/webkitperl/httpd.pm: Ditto.
3477         * TestWebKitAPI/win/main.cpp: Ditto.
3478         * WinLauncher/Common.cpp: Ditto.
3479         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
3480
3481 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3482
3483         run-jsc-stress-tests should accept remote host config from JSON file
3484         https://bugs.webkit.org/show_bug.cgi?id=141509
3485
3486         Reviewed by Michael Saboff.
3487
3488         * Scripts/run-javascriptcore-tests:
3489         (runJSCStressTests):
3490         * Scripts/run-jsc-stress-tests:
3491
3492 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3493
3494         [GTK] Add API to allow overriding the default color chooser implementation
3495         https://bugs.webkit.org/show_bug.cgi?id=98935
3496
3497         Reviewed by Gustavo Noronha Silva.
3498
3499         Add a color chooser implementation for MiniBrowser using
3500         GtkPopover when the GTK+ version is recent enough.
3501         And a test case to check the new color chooser API.
3502
3503         * MiniBrowser/gtk/BrowserWindow.c:
3504         (colorChooserRGBAChanged):
3505         (popoverColorClosed):
3506         (colorChooserRequestFinished):
3507         (runColorChooserCallback):
3508         (browserWindowConstructed):
3509         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3510         (testWebViewColorChooserRequest):
3511         (beforeAll):
3512
3513 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3514
3515         Make run-jsc-stress-tests --remote work with make-based runner
3516         https://bugs.webkit.org/show_bug.cgi?id=141079
3517
3518         Reviewed by Darin Adler.
3519
3520         * Scripts/run-javascriptcore-tests:
3521         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
3522         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
3523         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
3524         to avoid code duplication.
3525
3526 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3527
3528         run-jsc-stress tests should detect the number of processors on the remote machine too
3529         https://bugs.webkit.org/show_bug.cgi?id=141196
3530
3531         Reviewed by Darin Adler.
3532
3533         * Scripts/run-javascriptcore-tests:
3534         (runJSCStressTests): Pass through the --child-processes argument.
3535         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
3536         to detect the number of local and remote processors with the same algorithm.
3537         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
3538         same as $numProcessors.
3539
3540 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3541
3542         run-jsc-stress-tests should pass JSC_timeout to remote hosts
3543         https://bugs.webkit.org/show_bug.cgi?id=141164
3544
3545         Reviewed by Darin Adler.
3546
3547         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
3548
3549         * Scripts/run-jsc-stress-tests:
3550
3551 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3552
3553         [GTK] Add default color chooser implementation using GtkColorChooserDialog
3554         https://bugs.webkit.org/show_bug.cgi?id=141392
3555
3556         Reviewed by Gustavo Noronha Silva.
3557
3558         Enable INPUT_TYPE_COLOR by default for GTK+ port.
3559
3560         * Scripts/webkitperl/FeatureList.pm:
3561
3562 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
3563
3564         run-jsc-stress-tests shell test runner should run tests in fixed order
3565         https://bugs.webkit.org/show_bug.cgi?id=141383
3566
3567         Reviewed by Darin Adler.
3568
3569         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3570
3571 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
3572
3573         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
3574         https://bugs.webkit.org/show_bug.cgi?id=140485
3575
3576         Reviewed by Anders Carlsson.
3577
3578         Implement takeFocus() as a way to set focus through accessibility wrappers.
3579
3580         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3581         (AccessibilityUIElement::takeFocus):
3582         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3583         (WTR::AccessibilityUIElement::takeFocus):
3584
3585 2015-02-08  Darin Adler  <darin@apple.com>
3586
3587         Remove the SVG instance tree
3588         https://bugs.webkit.org/show_bug.cgi?id=140602
3589
3590         Reviewed by Dean Jackson.
3591
3592         * Scripts/check-for-global-initializers: Removed special case for
3593         SVGElementInstance.o.
3594
3595 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3596
3597         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
3598         <http://webkit.org/b/141365>
3599
3600         Reviewed by Daniel Bates.
3601
3602         * Scripts/webkitpy/xcode/simulator.py:
3603         (Simulator): Add unavailable_version_re precompiled regex.
3604         (Simulator._parse_devices): Check for unavailable versions and
3605         ignore them if found when parsing the output of
3606         `xcrun simctl list`.
3607         * Scripts/webkitpy/xcode/simulator_unittest.py:
3608         (test_unavailable_devices): Add test with output from
3609         `xcrun simctl list` with unavailable runtimes that fails before
3610         the fix.
3611
3612 2015-02-07  Chris Dumez  <cdumez@apple.com>
3613
3614         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
3615         https://bugs.webkit.org/show_bug.cgi?id=141321
3616
3617         Reviewed by Darin Adler.
3618
3619         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
3620
3621 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3622
3623         [iOS] Make Simulator class testable
3624         <http://webkit.org/b/141358>
3625
3626         Rubber-stamped by Darin Adler.
3627
3628         * Scripts/webkitpy/common/system/platforminfo.py:
3629         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
3630         command to here from Simulator.refresh() in xcode/simulator.py
3631         so that the output of the command can be mocked.
3632
3633         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3634         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
3635         to None.
3636         (MockPlatformInfo.xcode_simctl_list): Add method that returns
3637         self.expected_xcode_simctl_list expectation.
3638
3639         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
3640         and license header.
3641         (Simulator.__init__): Add optional 'host' parameter to make it
3642         possible to pass in a mock object for testing.  Set self._host
3643         to 'host' parameter or create Host() object.
3644         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
3645         method.
3646
3647         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
3648         for current code.
3649         (SimulatorTest):
3650         (SimulatorTest.setUp):
3651         (SimulatorTest._set_expected_xcrun_simctl_list):
3652         (SimulatorTest.test_simulator_device_types):
3653         (test_invalid_device_types_header):
3654         (test_invalid_runtimes_header):
3655         (test_invalid_devices_header):
3656
3657 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
3658
3659         run-jsc-stress-tests --remote should use the default ssh port
3660         https://bugs.webkit.org/show_bug.cgi?id=141287
3661
3662         Reviewed by Darin Adler.
3663
3664         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
3665
3666 2015-02-06  Dana Burkart  <dburkart@apple.com>
3667
3668         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
3669         https://bugs.webkit.org/show_bug.cgi?id=141349
3670
3671         Reviewed by Alexey Proskuryakov.
3672
3673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3674         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3675         (BuildbotTesterQueueView.prototype.update):