[EFL] Add OpenWebRTC in jhbuild
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [EFL] Add OpenWebRTC in jhbuild
4         https://bugs.webkit.org/show_bug.cgi?id=142778
5
6         Reviewed by Gyuyoung Kim.
7
8         Original patch by Philippe Normand <pnormand@igalia.com>
9
10         * efl/install-dependencies: Dependencies for OpenWebRTC.
11         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
12         the openwebrtc gst plugins.
13
14 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
15
16         Regression(r181257): WTF_WorkQueue.Simple is flaky
17         https://bugs.webkit.org/show_bug.cgi?id=142560
18
19         Remove the check that the refCount has returned to one after the
20         individual tasks have completed. It's too nondeterministic when
21         the reference count will be reduced.
22
23         Reviewed by Alexey Proskuryakov
24
25         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
26         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
27
28 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
29
30         [CMake][EFL] Put failure API test excutables into failure directory
31         https://bugs.webkit.org/show_bug.cgi?id=142965
32
33         Reviewed by Csaba Osztrogonác.
34
35         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
36
37         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
38         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
39
40 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
41
42         CSS Selectors: fix attribute case-insensitive matching of Contain and List
43         https://bugs.webkit.org/show_bug.cgi?id=142932
44
45         Reviewed by Darin Adler.
46
47         Add tests for the new features and fix some existing tests using the 
48         stringFromUTF8() utility recently added by Dhi.
49
50         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
51         (TestWebKitAPI::stringFromUTF8):
52         * TestWebKitAPI/Tests/WTF/StringView.cpp:
53
54 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
55
56         [GTK] install-dependencies should install orc
57         https://bugs.webkit.org/show_bug.cgi?id=142955
58
59         Reviewed by Martin Robinson.
60
61         Install orc, needed by openwebrtc
62
63         * gtk/install-dependencies:
64
65 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
66
67         Detect when url filter pattern with groups match the empty string
68         https://bugs.webkit.org/show_bug.cgi?id=142930
69
70         Reviewed by Sam Weinig.
71
72         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
73
74 2015-03-22  Anders Carlsson  <andersca@apple.com>
75
76         _WKWebsiteDataStore should clear WebSQL databases
77         https://bugs.webkit.org/show_bug.cgi?id=142947
78
79         Reviewed by Sam Weinig.
80
81         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
82
83         * MiniBrowser/mac/WK2BrowserWindowController.m:
84         (-[WK2BrowserWindowController fetchWebsiteData:]):
85         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
86         (-[WK2BrowserWindowController clearWebsiteData:]):
87
88 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
89
90         GCTimer should know keep track of nested GC phases
91         https://bugs.webkit.org/show_bug.cgi?id=142675
92
93         Reviewed by Darin Adler.
94
95         Adds a tool to aid in parsing the GC phase timing output into a
96         tree-like structure based on the parent-child relationships
97         of nested GC phases.
98
99         * Scripts/parse-gc-phase-timings: Added.
100         (Timing):
101         (Timing.__init__):
102         (Timing.__unicode__):
103         (Timing.__str__):
104         (Timing.__repr__):
105         (parse_input):
106         (print_timing_node):
107         (print_timing_tree):
108         (link_parents):
109         (main):
110
111 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
112
113         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
114
115         * Scripts/webkitpy/common/config/ews.json:
116
117 2015-03-20  Philippe Normand  <pnormand@igalia.com>
118
119         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
120         https://bugs.webkit.org/show_bug.cgi?id=142867
121
122         Rubber-stamped by Csaba Osztrogon.
123
124         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
125         a fixed revision for the openwebrtc-gst-plugins.
126
127 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
128
129         Unreviewed build fix. Don't try to report stats for all benchmarks.
130         Just report the geometric mean of preferred means.
131
132         * Scripts/run-jsc-benchmarks:
133
134 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
135
136         run-jsc-benchmarks should only report preferred mean
137         https://bugs.webkit.org/show_bug.cgi?id=142874
138
139         Reviewed by Geoffrey Garen.
140
141         Just collect statistics for the preferred mean.
142
143         * Scripts/run-jsc-benchmarks:
144
145 2015-03-19  Alex Christensen  <achristensen@webkit.org>
146
147         [Content Extensions] Test regular expression parse failures.
148         https://bugs.webkit.org/show_bug.cgi?id=142872
149
150         Reviewed by Benjamin Poulain.
151
152         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
153         (TestWebKitAPI::testPatternStatus):
154         (TestWebKitAPI::TEST_F):
155         Added tests for each parsing status.
156
157 2015-03-19  Alex Christensen  <achristensen@webkit.org>
158
159         Fix API tests after r181754.
160
161         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
162         (TestWebKitAPI::testRequest):
163
164 2015-03-19  Brady Eidson  <beidson@apple.com>
165
166         Part of content extensions should apply css selectors
167         https://bugs.webkit.org/show_bug.cgi?id=142604
168
169         Reviewed by Alex Christensen.
170
171         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
172         (WebCore::ContentExtensions::operator<<):
173
174 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
175
176         [Win] Activate tests on EWS
177         https://bugs.webkit.org/show_bug.cgi?id=142850
178
179         Reviewed by Alexey Proskuryakov.
180
181         * Scripts/webkitpy/common/config/ews.json: Add me as
182         the EWS bot watcher, and activate tests.
183
184 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
185
186         [GTK] Fix inspector userinterface related incremental build issue
187         https://bugs.webkit.org/show_bug.cgi?id=142849
188
189         Reviewed by Carlos Garcia Campos.
190
191         * Scripts/webkitdirs.pm:
192         (shouldRemoveCMakeCache):
193
194 2015-03-18  Alex Christensen  <achristensen@webkit.org>
195
196         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
197         https://bugs.webkit.org/show_bug.cgi?id=142799
198
199         Reviewed by Brady Eidson.
200
201         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
202         (TestWebKitAPI::testPattern):
203         (TestWebKitAPI::TEST_F):
204         Start testing regex failures.
205
206 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
207
208         Fix StringView typos after r181525 and r181558
209         https://bugs.webkit.org/show_bug.cgi?id=142772
210
211         Reviewed by Darin Adler.
212
213         Add some tests in [1] to cover the StringView::startsWith, 
214         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
215         StringView::endsWithIgnoringASCIICase implementations.
216
217         * TestWebKitAPI/Tests/WTF/StringView.cpp:
218         (TestWebKitAPI::TEST):
219
220 2015-03-18  Dana Burkart  <dburkart@apple.com>
221
222         Remove extraneous import to fix the build.
223
224         Unreviewed.
225
226         * Scripts/webkitpy/port/driver.py:
227
228 2015-03-18  Dana Burkart  <dburkart@apple.com>
229
230         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
231         https://bugs.webkit.org/show_bug.cgi?id=142547
232
233         Reviewed by Alexey Proskuryakov.
234
235         * Scripts/webkitpy/port/driver.py:
236         (Driver._setup_environ_for_driver):
237
238 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
239
240         Tweak how AppleSystemFontOSSubversion default is added
241         https://bugs.webkit.org/show_bug.cgi?id=142835
242
243         Reviewed by Dan Bernstein.
244
245         * DumpRenderTree/mac/DumpRenderTree.mm:
246         (setDefaultsToConsistentValuesForTesting):
247
248 2015-03-18  Dan Bernstein  <mitz@apple.com>
249
250         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
251         https://bugs.webkit.org/show_bug.cgi?id=142815
252
253         Reviewed by Darin Adler.
254
255         * Scripts/prepare-ChangeLog:
256         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
257         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
258         keep consuming the quoted text until the matching quotation mark is reached. Emit the
259         warning only if a line ends without a backslash before the matching quotation mark was found.
260
261 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
262
263         Remove unused "preprocessor" parameter to sub-CodeGenerators
264         https://bugs.webkit.org/show_bug.cgi?id=142793
265
266         Reviewed by Darin Adler.
267
268         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
269         (new):
270
271 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
272
273         [EFL] Bump gstreamer version to 1.4.4
274         https://bugs.webkit.org/show_bug.cgi?id=142782
275
276         Reviewed by Philippe Normand.
277
278         * efl/jhbuild.modules:
279         * efl/patches/gst-libav.patch:
280         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
281         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
282
283 2015-03-17  Tim Horton  <timothy_horton@apple.com>
284
285         Fix the iOS build.
286
287         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
288         (WTR::InjectedBundle::platformInitialize):
289
290 2015-03-17  Dean Jackson  <dino@apple.com>
291
292         check-webkit-style should allow "bool a : 1"
293         https://bugs.webkit.org/show_bug.cgi?id=142794
294
295         Reviewed by Brent Fulgham.
296
297         We should allow member bitfields of the form:
298
299         bool m_var : 1;
300
301         It seems that Visual Studio 8 was the last compiler that
302         wasn't happy about not using unsigned here. We already have
303         about 500 cases (in WebCore) where people were ignoring this rule.
304
305         * Scripts/webkitpy/style/checkers/cpp.py:
306         (check_language): Allow "bool".
307         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
308         (CppStyleTest.test_enum_bitfields):
309         (CppStyleTest.test_plain_integral_bitfields):
310
311 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
312
313         Compile character ranges targeting the same state as range check in the bytecode
314         https://bugs.webkit.org/show_bug.cgi?id=142759
315
316         Reviewed by Alex Christensen.
317
318         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
319         (TestWebKitAPI::TEST_F):
320
321 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
322
323         W3C test parser and converter should use test importer host
324         https://bugs.webkit.org/show_bug.cgi?id=142729
325
326         Reviewed by Bem Jones-Bey.
327
328         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
329         This enables adding more TestImporter unit testing.
330         This patch also ensures that the git object instantiated by TestDownloader is using the
331         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
332
333         * Scripts/webkitpy/common/system/filesystem_mock.py:
334         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
335         * Scripts/webkitpy/w3c/test_downloader.py:
336         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
337         (TestDownloader.checkout_test_repository): Making use of the new git function.
338         * Scripts/webkitpy/w3c/test_importer.py:
339         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
340         (TestImporter.import_tests): Adding host as parameter to the converter.
341         * Scripts/webkitpy/w3c/test_importer_unittest.py:
342         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
343         (TestImporterTest):
344         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
345         * Scripts/webkitpy/w3c/test_parser.py:
346         (TestParser.__init__): Adding host as parameter constructor.
347
348 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
349
350         [GTK] WebKitDOM objects leaking
351         https://bugs.webkit.org/show_bug.cgi?id=118788
352
353         Reviewed by Darin Adler and Sergio Villar Senin.
354
355         Update DOMObjectCache unit test to check that DOM objects are also
356         released when new contents are loaded in the web view, and the old
357         document is detached from the frame.
358
359         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
360         (testWebKitDOMObjectCache):
361         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
362         (runTest):
363
364 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
365
366         W3C test importer default import folder should be LayoutTests/imported/w3c
367         https://bugs.webkit.org/show_bug.cgi?id=142728
368
369         Reviewed by Bem Jones-Bey.
370
371         * Scripts/webkitpy/w3c/test_importer.py:
372         (parse_args): Updating the default destination option value to 'imported/w3c'.
373
374 2015-03-17  Philippe Normand  <pnormand@igalia.com>
375
376         [GTK] basic OpenWebRTC build support
377         https://bugs.webkit.org/show_bug.cgi?id=142393
378
379         Reviewed by Carlos Garcia Campos.
380
381         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
382         is not the upstream OpenWebRTC repository. This temporary fork
383         contains a few patches needed by WebKit for audio/video rendering.
384
385 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
386
387         [CMake][EFL] Build test tools only for developer mode
388         https://bugs.webkit.org/show_bug.cgi?id=142761
389
390         Reviewed by Csaba Osztrogonác.
391
392         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
393
394         * CMakeLists.txt:
395
396 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
397
398         Remove never used "useLayerOnTop" bindings generator argument
399         https://bugs.webkit.org/show_bug.cgi?id=142773
400
401         Reviewed by Darin Adler.
402
403         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
404         (new):
405
406 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
407
408         Enable ES6 classes by default
409         https://bugs.webkit.org/show_bug.cgi?id=142774
410
411         Reviewed by Gavin Barraclough.
412
413         * Scripts/webkitperl/FeatureList.pm:
414
415 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
416
417         Fix webkitpy tests after r181585.
418
419         Looks like "me" cannot be anyone's email, it's a special case.
420
421         * Scripts/webkitpy/common/config/contributors.json:
422
423 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
424
425         Add tolerance to WebAudio tests
426         https://bugs.webkit.org/show_bug.cgi?id=142676
427
428         Reviewed by Tim Horton.
429
430         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
431
432         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
433         (TestResultWriter.create_audio_diff_and_write_result):
434         * Scripts/webkitpy/layout_tests/models/test_failures.py:
435         (FailureAudio.write_failure):
436         * Scripts/webkitpy/port/base.py:
437         (Port.do_audio_results_differ):
438         Diff audio failures.
439
440         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
441         tests to use real parseable WAV data, and got rid of base64, which there didn't
442         seem to have been any reason for.
443
444 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
445
446         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
447         https://bugs.webkit.org/show_bug.cgi?id=142720
448
449         Reviewed by Myles C. Maxfield.
450
451         Activate system copies of Microsoft fonts for the current process, thus overriding
452         any other ones that could be preferred by the system otherwise.
453
454         * DumpRenderTree/mac/DumpRenderTree.mm:
455         (activateSystemCoreWebFonts):
456         (adjustFonts):
457         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
458         (WTR::activateSystemCoreWebFonts):
459         (WTR::activateFonts):
460
461 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
462
463         Created Streams API watchlist
464         https://bugs.webkit.org/show_bug.cgi?id=142684
465
466         Reviewed by Benjamin Poulain.
467
468         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
469         watchlist and added Benjamin, Youenn and me to it.
470
471 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
472
473         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
474         https://bugs.webkit.org/show_bug.cgi?id=142715
475
476         Reviewed by Brent Fulgham.
477
478         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
479         (TestWebKitAPI::TEST):
480
481 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
482
483         Change the exact attribute matching to be ASCII case-insensitive
484         https://bugs.webkit.org/show_bug.cgi?id=142609
485
486         Reviewed by Darin Adler.
487
488         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
489         * TestWebKitAPI/Tests/WTF/StringView.cpp:
490
491 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
492
493         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
494         https://bugs.webkit.org/show_bug.cgi?id=134764
495
496         Reviewed by Ryosuke Niwa.
497
498         TestDownloader is introduced to download W3C tests from the official
499         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
500         and https://github.com/w3c/csswg-test.git).
501         TestDownloader clones the repositories and checkouts revisions of the tests
502         defined in LayoutTests/imported/w3c/resources/TestRepositories.
503
504         Similarly to https://codereview.chromium.org/148173016,
505         TestDownloader copies part of the files based on the rules
506         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
507
508         TestDownloader is used by TestImporter when no source directory is provided.
509
510         * Scripts/webkitpy/w3c/test_downloader.py: Added.
511         (TestDownloader):
512         (TestDownloader.default_options):
513         (TestDownloader.load_test_repositories):
514         (TestDownloader.__init__):
515         (TestDownloader.checkout_test_repository):
516         (TestDownloader._init_paths_from_expectations):
517         (TestDownloader._add_test_suite_paths):
518         (TestDownloader._empty_directory):
519         (TestDownloader.copy_tests):
520         (TestDownloader.download_tests):
521         * Scripts/webkitpy/w3c/test_importer.py:
522         (main):
523         (parse_args):
524         (TestImporter.__init__):
525         (TestImporter.do_import):
526         (TestImporter.test_downloader):
527         (TestImporter.find_importable_tests.should_keep_subdir):
528         (TestImporter.should_convert_test_harness_links):
529         (TestImporter.import_tests):
530         (TestImporter.write_import_log):
531
532 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
533
534         [Mavericks] Test snapshots are 1600x1200 on Retina devices
535         https://bugs.webkit.org/show_bug.cgi?id=142630
536
537         Reviewed by Tim Horton.
538
539         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
540         Removed an ifdef that disabled the fix on Mavericks.
541
542 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
543
544         Remove isWK2 cruft from webkitdirs.pm after r170426
545         https://bugs.webkit.org/show_bug.cgi?id=142618
546
547         Reviewed by Daniel Bates.
548
549         * Scripts/webkitdirs.pm:
550         (isWK2): Deleted.
551
552 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
553
554         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
555         https://bugs.webkit.org/show_bug.cgi?id=138687
556
557         Reviewed by Carlos Garcia Campos.
558
559         Always change cookie policy from UI process, as changing it from WebProcess doesn't
560         affect other processes.
561
562         The implementation is imperfect, because the change happens asynchronously, but I
563         don't expect it to be a problem in practice.
564
565         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
566         (WTR::InjectedBundle::beginTesting):
567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
568         (WTR::TestRunner::setAlwaysAcceptCookies):
569         * WebKitTestRunner/TestInvocation.cpp:
570         (WTR::TestInvocation::invoke):
571         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
572
573 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
574
575         [EFL] Enable building EFL 1.13 with NEON support
576         https://bugs.webkit.org/show_bug.cgi?id=142619
577
578         Reviewed by Gyuyoung Kim.
579
580         * efl/jhbuild.modules:
581
582 2015-03-11  Alex Christensen  <achristensen@webkit.org>
583
584         [Content Extensions] Add resource type and load type triggers.
585         https://bugs.webkit.org/show_bug.cgi?id=142422
586
587         Reviewed by Benjamin Poulain.
588
589         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
590         (TestWebKitAPI::testRequest):
591         (TestWebKitAPI::mainDocumentRequest):
592         (TestWebKitAPI::TEST_F):
593         (TestWebKitAPI::testURL): Deleted.
594
595 2015-03-10  Sam Weinig  <sam@webkit.org>
596
597         Allow adding a button in input elements for auto fill related functionality
598         <rdar://problem/19782066>
599         https://bugs.webkit.org/show_bug.cgi?id=142564
600
601         Reviewed by Anders Carlsson.
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::TestController::createOtherPage):
605         (WTR::TestController::createWebViewWithOptions):
606         Update for new callback.
607
608 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
609
610         Add basic support for BOL and EOL assertions to the URL Filter parser
611         https://bugs.webkit.org/show_bug.cgi?id=142568
612
613         Reviewed by Alex Christensen.
614
615         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
616         (TestWebKitAPI::TEST_F):
617
618 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         [GTK] Add support for handling TLS errors to MiniBrowser
621         https://bugs.webkit.org/show_bug.cgi?id=142576
622
623         Reviewed by Sergio Villar Senin.
624
625         It's useful for testing TLS errors handling itself, but also to
626         allow ignoring TLS errors when testing.
627
628         * MiniBrowser/gtk/BrowserWindow.c:
629         (webViewLoadFailedWithTLSerrors):
630         (browserWindowConstructed):
631
632 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
633
634         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
635         https://bugs.webkit.org/show_bug.cgi?id=142569
636
637         Reviewed by David Hyatt.
638
639         Test Optional::valueOrCompute().
640
641         * TestWebKitAPI/Tests/WTF/Optional.cpp:
642         (TestWebKitAPI::TEST):
643
644 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
645
646         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
647         https://bugs.webkit.org/show_bug.cgi?id=126688
648
649         Reviewed by Gustavo Noronha Silva.
650
651         * CMakeLists.txt: Build testing tools only for developer builds,
652         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
653         * MiniBrowser/gtk/CMakeLists.txt: Only add
654         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
655         and add a rule to install the MiniBrowser.
656         * MiniBrowser/gtk/main.c:
657         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
658         builds.
659
660 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
661
662         Add some DateMath tests to TestWebKitAPI
663         https://bugs.webkit.org/show_bug.cgi?id=142565
664
665         Reviewed by Alexey Proskuryakov.
666
667         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
668         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
669         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
671         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
672
673 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
674
675         Regression(r181257): WTF_WorkQueue.Simple is flaky
676         https://bugs.webkit.org/show_bug.cgi?id=142560
677
678         Unreviewed attempt to improve test stability.
679
680         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
681         the WorkQueue a little later to redue flakiness.
682
683 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
684
685         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
686         https://bugs.webkit.org/show_bug.cgi?id=142555
687
688         Reviewed by Simon Fraser.
689
690         * DumpRenderTree/mac/DumpRenderTree.mm:
691         (setDefaultsToConsistentValuesForTesting):
692         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
693         (WTR::InjectedBundle::platformInitialize):
694
695 2015-03-10  Alex Christensen  <achristensen@webkit.org>
696
697         Use unsigned for HashSet size.
698         https://bugs.webkit.org/show_bug.cgi?id=142518
699
700         Reviewed by Benjamin Poulain.
701
702         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
703         (TestWebKitAPI::TEST):
704         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
705         (TestWebKitAPI::testInitialCapacity):
706         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
707         (TestWebKitAPI::TEST):
708
709 2015-03-10  Daniel Bates  <dabates@apple.com>
710
711         [iOS] Add WebKitSystemInterface for iOS 8.2
712         https://bugs.webkit.org/show_bug.cgi?id=142505
713
714         Rubber-stamped by Anders Carlsson.
715
716         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
717         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
718         copy-webkitlibraries-to-product-directory in r181286.
719
720         * Scripts/copy-webkitlibraries-to-product-directory:
721
722 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
723
724         Extend URL filter's Term definition to support groups/subpatterns
725         https://bugs.webkit.org/show_bug.cgi?id=142519
726
727         Reviewed by Alex Christensen.
728
729         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
730         (TestWebKitAPI::testURL):
731
732 2015-03-06  Jer Noble  <jer.noble@apple.com>
733
734         Add an option to run-webkit-tests to override the LayoutTests/ directory
735         https://bugs.webkit.org/show_bug.cgi?id=142418
736
737         Reviewed by David Kilzer.
738
739         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
740         directory. The base port will parse the options during initialization and store the override
741         location if present. layout_tests_dir() will return this overridden location if set.
742
743         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
744         (parse_args):
745         * Scripts/webkitpy/port/base.py:
746         (Port.__init__):
747         (Port.layout_tests_dir):
748
749 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
750
751         [CMake] Enable WorkQueue tests for CMake ports
752         https://bugs.webkit.org/show_bug.cgi?id=142473
753
754         Reviewed by Darin Adler.
755
756         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
757         the list of source files.
758         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
759         to the list of include directories for EFL.
760
761 2015-03-09  David Kilzer  <ddkilzer@apple.com>
762
763         Attempt to fix timeouts on iOS Simulator layout tests
764
765         * Scripts/webkitpy/port/ios.py:
766         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
767         Simulator end after the first 50 tests time out.  Some analysis
768         this past weekend shows that the 'Booted' status in the output
769         of `xcrun simctl list` is not sufficient (and watching the test
770         run shows that SpringBoard hasn't fully started to the point
771         where it's displaying icons on the home screen).  The workaround
772         until we have a better fix is to add an arbitrary timeout to let
773         SpringBoard finish launching.  In practice, 15 seconds is
774         probably enough, but 30 seconds should nearly always work.
775
776 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
777
778         Unreviewed. Add myself as a committer.
779
780         * Scripts/webkitpy/common/config/contributors.json:
781
782 2015-03-09  David Kilzer  <ddkilzer@apple.com>
783
784         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
785
786         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
787         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
788         an expectation that will fail if we hit the race condition.
789         This test is inherently racy and will deadlock if the first job
790         for queue2 takes the mutex lock before the second job for
791         queue1.
792
793 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] WTF::WorkQueue does not balance ref/deref properly
796         https://bugs.webkit.org/show_bug.cgi?id=142471
797
798         Reviewed by Antti Koivisto.
799
800         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
801         (TestWebKitAPI::TEST): Check that the refcount is correct.
802
803 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
804
805         Do not show passing test result on output of EFL layout test
806         https://bugs.webkit.org/show_bug.cgi?id=142380
807
808         Reviewed by Darin Adler.
809
810         To show passing tests has caused inconvenience when we detect problem tests
811         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
812         in order not to show passing tests in the output of EFL layout test.
813
814         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
815         (RunWebKitTests.start):
816
817 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
818
819         Unreviewed build fix.
820
821         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
822         (TestWebKitAPI::TEST): Remove two unused variables.
823
824 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
825
826         Add some WorkQueue tests to TestWebKitAPI
827         https://bugs.webkit.org/show_bug.cgi?id=142447
828
829         Reviewed by Sam Weinig.
830
831         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
832         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
834         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
835         (TestWebKitAPI::simpleTest):
836         (TestWebKitAPI::longTest):
837         (TestWebKitAPI::thirdTest):
838         (TestWebKitAPI::finishedTests):
839         (TestWebKitAPI::TEST):
840         (TestWebKitAPI::longTest2):
841
842 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
843
844         Remove willDestroyFrame in WKBundlePageLoaderClient
845         https://bugs.webkit.org/show_bug.cgi?id=142389
846
847         Reviewed by Anders Carlsson.
848
849         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
850         (WTR::InjectedBundlePage::InjectedBundlePage):
851
852 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
853
854         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
855         https://bugs.webkit.org/show_bug.cgi?id=142433
856
857         Reviewed by Darin Adler.
858
859         Include more TestWebKitAPI tests when building for Windows. Also
860         fix a build error in MetaAllocator.cpp caused by one of the
861         Microsoft headers #defining 'small'.
862
863         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
864         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
865         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
866
867 2015-03-06  Sam Weinig  <sam@webkit.org>
868
869         [Content Extensions] Move compiling of content extensions to the UIProcess
870         https://bugs.webkit.org/show_bug.cgi?id=142402
871
872         Reviewed by Benjamin Poulain.
873
874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
875         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
876         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
877         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
878         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
879         (TestWebKitAPI::TEST_F):
880         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
881         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
882         is now abstract).
883
884 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
885
886         [Win] Correct Windows build.
887
888         Rubberstamped by Michael Saboff
889
890         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
891         in the GOTO labels.
892
893 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
894
895         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
896         https://bugs.webkit.org/show_bug.cgi?id=142385
897
898         Reviewed by Sergio Villar Senin.
899
900         Use stack allocated GMainLoopSources to make sure they are
901         cancelled automatically if the test finishes before they have
902         been processed.
903
904         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
905         (testWebViewSyncRequestOnMaxConns):
906
907 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
908
909         Remove Mountain Lion libraries since ML isn't supported
910         https://bugs.webkit.org/show_bug.cgi?id=142332
911
912         Reviewed by Darin Adler.
913
914         * Scripts/copy-webkitlibraries-to-product-directory:
915
916 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
917
918         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
919         https://bugs.webkit.org/show_bug.cgi?id=142083
920
921         Reviewed by Simon Fraser.
922
923         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
924
925         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
926         (WebPlatformTestServer._copy_webkit_test_files):
927
928 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
929
930         setup-git-clone fails due to the failure to download python-irclib-0.4.8
931         https://bugs.webkit.org/show_bug.cgi?id=141946
932
933         Reviewed by Ryosuke Niwa.
934
935         Check in ircbot.py and irclib.py to avoid network problems in the future.
936
937         * Scripts/webkitpy/common/net/irc/ircbot.py:
938         * Scripts/webkitpy/thirdparty/__init__.py:
939         (AutoinstallImportHook.find_module):
940         (AutoinstallImportHook._install_irc): Deleted.
941         * Scripts/webkitpy/thirdparty/__init___unittest.py:
942         (ThirdpartyTest.test_imports):
943         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
944         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
945         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
946
947 2015-03-06  David Kilzer  <ddkilzer@apple.com>
948
949         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
950
951         See also fix to config.json in r181097.
952
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
954         (WebKitBuildbot): Add missing "WK2" to the names of the perf
955         bots.
956
957 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
958
959         run-jsc-stress-tests should determine the architecture from ELF binaries
960         https://bugs.webkit.org/show_bug.cgi?id=142335
961
962         Reviewed by Darin Adler.
963
964         * Scripts/run-jsc-stress-tests:
965
966 2015-03-05  David Kilzer  <ddkilzer@apple.com>
967
968         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
969         <http://webkit.org/b/142226>
970
971         Reviewed by Darin Adler.
972
973         * Scripts/webkitpy/port/ios.py:
974         (IOSSimulatorPort.default_baseline_search_path): Switch the
975         TestExpectations order of ios-simulator-wk2 from this:
976           ios-simulator-wk2, wk2, ios-simulator
977         To this:
978           ios-simulator-wk2, ios-simualtor, wk2
979
980 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
981
982         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
983         https://bugs.webkit.org/show_bug.cgi?id=142370
984
985         Reviewed by Dean Jackson.
986
987         * Scripts/webkitdirs.pm:
988         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
989         logs, one for warnings, the other for errors.
990         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
991         into the standard BuildOutput.htm document.
992
993 2015-03-05  David Kilzer  <ddkilzer@apple.com>
994
995         Dashboard has trouble parsing iOS test output
996         <http://webkit.org/b/142364>
997
998         Reviewed by Alex Christensen.
999
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1001         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1002         Add fallback path to build a regex using 'matchString' so that
1003         it matches anywhere in the line.  In practice, 'matchString' is
1004         a prefix for the label following the number.
1005
1006 2015-03-05  Alex Christensen  <achristensen@webkit.org>
1007
1008         Fix linker warnings in TestWebKitAPI.
1009         https://bugs.webkit.org/show_bug.cgi?id=141912
1010
1011         Reviewed by David Kilzer.
1012
1013         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1014         Do not export TearDownTestCase or SetUpTestCase symbols.
1015
1016 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1017
1018         [Win] Unreviewed EWS fix.
1019
1020         * Scripts/webkitdirs.pm:
1021         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1022         the EWS output more usable.
1023
1024 2015-03-05  Chris Dumez  <cdumez@apple.com>
1025
1026         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1027         https://bugs.webkit.org/show_bug.cgi?id=142350
1028
1029         Reviewed by Michael Saboff and Benjamin Poulain.
1030
1031         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1032         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1033
1034         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1035         (TestWebKitAPI::TEST):
1036
1037 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1038
1039         [Win] Ensure build target directory exists when launching MSBuild
1040         https://bugs.webkit.org/show_bug.cgi?id=142360
1041
1042         Reviewed by Dean Jackson.
1043
1044         Create the build output directory (if it doesn't exist) before
1045         launching MSBuild so that it can immediately begin writing logs.
1046
1047         * Scripts/webkitdirs.pm:
1048         (buildVisualStudioProject):
1049
1050 2015-03-05  Chris Dumez  <cdumez@apple.com>
1051
1052         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1053         https://bugs.webkit.org/show_bug.cgi?id=142325
1054
1055         Reviewed by Csaba Osztrogonác.
1056
1057         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1058         As a result, "--webkit-test-runner / -2" parameters are replaced by
1059         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1060         than WebKitTestRunner.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/config.json:
1063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1064         (RunWebKit1Tests):
1065         (RunWebKit1Tests.start):
1066         (RunWebKit1LeakTests):
1067         (RunWebKit1LeakTests.start):
1068         (RunAndUploadPerfTestsWebKit1):
1069         (RunAndUploadPerfTestsWebKit1.start):
1070         (TestFactory):
1071         (TestWebKit1LeaksFactory):
1072         (TestWebKit1LeaksFactory.__init__):
1073         (TestWebKit1Factory):
1074         (TestWebKit1AllButJSCFactory):
1075         (TestAllButJSCFactory):
1076         (BuildAndPerfTestWebKit1Factory):
1077         (BuildAndPerfTestWebKit1Factory.__init__):
1078         (BuildAndPerfTestFactory):
1079         (BuildAndPerfTestFactory.__init__):
1080         (DownloadAndPerfTestWebKit1Factory):
1081         (DownloadAndPerfTestWebKit1Factory.__init__):
1082         (DownloadAndPerfTestFactory):
1083         (DownloadAndPerfTestFactory.__init__):
1084         (RunWebKitLeakTests): Deleted.
1085         (RunWebKitLeakTests.start): Deleted.
1086         (RunWebKit2Tests): Deleted.
1087         (RunWebKit2Tests.start): Deleted.
1088         (RunAndUploadPerfTestsWebKit2): Deleted.
1089         (RunAndUploadPerfTestsWebKit2.start): Deleted.
1090         (TestLeaksFactory): Deleted.
1091         (TestLeaksFactory.__init__): Deleted.
1092         (TestWebKit2Factory): Deleted.
1093         (TestWebKit2AndJSCFactory): Deleted.
1094         (BuildAndPerfTestWebKit2Factory): Deleted.
1095         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1096         (DownloadAndPerfTestWebKit2Factory): Deleted.
1097         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1099         (parse_args):
1100         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1101         (PerfTestsRunner._parse_args):
1102         * Scripts/webkitpy/port/port_testcase.py:
1103         (PortTestCase.test_build_driver):
1104
1105 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1106
1107         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1108         https://bugs.webkit.org/show_bug.cgi?id=140845
1109
1110         Reviewed by David Kilzer.
1111
1112         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1113         and generate suitable build commands to drive a full build from our
1114         existing solution files.
1115
1116         * Scripts/webkitdirs.pm:
1117         (msBuildInstallDir): Added.
1118         (determineConfigurationForVisualStudio): Revise to use MSBuild command
1119         line arguments to drive the build.
1120         (setupCygwinEnv): Warn user if MSBuild cannot be located.
1121         (buildVisualStudioProject): Revise to use MSBuild command line arguments
1122         to specify build architecture.
1123         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1124         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1125         bother looking for CoreUI or SafariTheme build logs.
1126
1127 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1128
1129         [buildbot] mastercfg_unittest.py should be runnable easily
1130         https://bugs.webkit.org/show_bug.cgi?id=142219
1131
1132         Reviewed by Chris Dumez.
1133
1134         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1135         the last Twisted version works together with this buildbot version.
1136
1137         * Scripts/webkitpy/common/system/autoinstall.py:
1138         (AutoInstaller): Added prepend_to_search_path argument to be able
1139         to prefer autoinstalled package to system package.
1140         (AutoInstaller.__init__):
1141         (AutoInstaller._set_up_target_dir):
1142         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1143         (AutoInstaller._prepare_package):
1144         (AutoInstaller._extract_targz): Renamed to _extract_tar.
1145         * Scripts/webkitpy/thirdparty/__init__.py:
1146         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1147
1148 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
1149
1150         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1151         https://bugs.webkit.org/show_bug.cgi?id=131162
1152
1153         Reviewed by Gyuyoung Kim.
1154
1155         * MiniBrowser/efl/main.c:
1156         (on_download_request):
1157         (on_download_finished):
1158         (on_download_failed):
1159         (window_create):
1160         Adapt download callbacks to new callback mechanism
1161
1162 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1163
1164         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1165
1166         In r180927 we updated the libsoup version used by the jhbuild. In
1167         this new version the sniffer uses image/x-icon instead of
1168         image/vnd.microsoft.icon for blank.ico resource.
1169
1170         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1171         (testWebResourceMimeType):
1172
1173 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1174
1175         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1176         https://bugs.webkit.org/show_bug.cgi?id=142244
1177
1178         Reviewed by Sergio Villar Senin.
1179
1180         Check that the SSL server doesn't process any request in case of
1181         TLS errors when the policy is set to FAIL.
1182
1183         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1184         (testTLSErrorsPolicy):
1185         (testTLSErrorsRedirect):
1186         (testTLSErrorsHTTPAuth):
1187         (testLoadFailedWithTLSErrors):
1188         (testSubresourceLoadFailedWithTLSErrors):
1189         (httpsServerCallback):
1190
1191 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
1192
1193         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1194         https://bugs.webkit.org/show_bug.cgi?id=141154
1195
1196         Reviewed by Jer Noble.
1197
1198         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1199
1200         For the sake of completeness WebKitTestRunner should specify temporary
1201         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1202
1203         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1204         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1205         to get data storage paths. Only Mac port has an actual implementation of it.
1206         However, WebKitTestRunner overrides them in favour of unique temporary dir
1207         which is taken from libraryPathForTesting().
1208
1209         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1210         is not implemented for EFL and GTK ports it returns an empty string.
1211         All default data folders besides MediaKeys are overridden in TestRunner
1212         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1213         env variable.
1214
1215         GTK port does not enable encrypted keys by default so
1216         WebMediaKeyStorageManager::initialize() code path is never triggered.
1217
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1220         WebKit ports.
1221
1222 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1223
1224         [buildbot] Add regression test to check which builder runs which tests
1225         https://bugs.webkit.org/show_bug.cgi?id=142166
1226
1227         Reviewed by Alexey Proskuryakov.
1228
1229         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1230         (BuildStepsConstructorTest.createTest):
1231         (BuildStepsTest):
1232         (BuildStepsTest.generateTests):
1233         (BuildStepsTest.createTest):
1234         (BuildStepsTest.createTest.doTest):
1235         (BuildStepsTest.test_unnecessary_expected_results):
1236
1237 2015-03-04  Commit Queue  <commit-queue@webkit.org>
1238
1239         Unreviewed, rolling out r181054.
1240         https://bugs.webkit.org/show_bug.cgi?id=142320
1241
1242         Broke the api tests (Requested by sundiamonde on #webkit).
1243
1244         Reverted changeset:
1245
1246         "Fix linker warnings in TestWebKitAPI."
1247         https://bugs.webkit.org/show_bug.cgi?id=141912
1248         http://trac.webkit.org/changeset/181054
1249
1250 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1251
1252         Fix linker warnings in TestWebKitAPI.
1253         https://bugs.webkit.org/show_bug.cgi?id=141912
1254
1255         Reviewed by David Kilzer.
1256
1257         * TestWebKitAPI/Configurations/Base.xcconfig:
1258         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1259
1260 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
1261
1262         [Mac] Set SystemUIFontSelect in DRT and WKTR
1263         https://bugs.webkit.org/show_bug.cgi?id=142303
1264
1265         Reviewed by Myles C. Maxfield.
1266
1267         * DumpRenderTree/mac/DumpRenderTree.mm:
1268         (setDefaultsToConsistentValuesForTesting):
1269         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1270         (WTR::InjectedBundle::platformInitialize):
1271
1272 2015-03-04  Chris Dumez  <cdumez@apple.com>
1273
1274         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1275         https://bugs.webkit.org/show_bug.cgi?id=142314
1276         <rdar://problem/20046835>
1277
1278         Reviewed by Ryosuke Niwa.
1279
1280         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1281         to get WK2 code coverage.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/config.json:
1284
1285 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1286
1287         Move content extensions test to properly named directory.
1288         https://bugs.webkit.org/show_bug.cgi?id=142299
1289
1290         Reviewed by Tim Horton.
1291
1292         * WebKitTestRunner/mac/TestControllerMac.mm:
1293         (WTR::TestController::platformConfigureViewForTest):
1294
1295 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1296
1297         W3C test importer should use filesystem instead of os.walk
1298         https://bugs.webkit.org/show_bug.cgi?id=142085
1299
1300         Reviewed by Bem Jones-Bey.
1301
1302         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1303         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1304         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1305
1306         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1307         Added a unit test to check that test importer is now black-box testable using a Mock system.
1308
1309         * Scripts/webkitpy/common/system/filesystem.py:
1310         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1311         (FileSystem.dirs_under.filter_all):
1312         * Scripts/webkitpy/common/system/filesystem_mock.py:
1313         (MockFileSystem.dirs_under):
1314         (MockFileSystem.dirs_under.filter_all):
1315         (MockFileSystem.getsize):
1316         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1317         (MockFileSystemTest.test_dirs_under):
1318         (MockFileSystemTest.test_dirs_under.filter_dir):
1319         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1320         (RealFileSystemTest.test_sep):
1321         (RealFileSystemTest):
1322         (RealFileSystemTest.test_dirs_under):
1323         (RealFileSystemTest.test_dirs_under.filter_this_dir):
1324         * Scripts/webkitpy/w3c/test_importer.py:
1325         (TestImporter.do_import):
1326         (TestImporter.find_importable_tests.should_keep_subdir):
1327         (TestImporter.find_importable_tests):
1328         (TestImporter.should_keep_subdir): Deleted.
1329         (TestImporter.should_skip_file): Deleted.
1330         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1331         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1332
1333 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
1334
1335         [WebEditingTester] Add support for the find and replace bar
1336         https://bugs.webkit.org/show_bug.cgi?id=142247
1337
1338         Reviewed by Enrica Casucci.
1339
1340         While it's not hooked up yet in WKWebView, adding support for the
1341         find bar to WebEditingTester will help us implement that functionality.
1342
1343         * WebEditingTester/AppDelegate.h:
1344         * WebEditingTester/AppDelegate.m:
1345         (-[WebEditingAppDelegate performTextFinderAction:]):
1346         * WebEditingTester/MainMenu.xib:
1347         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1348
1349         * WebEditingTester/WK2WebDocumentController.m:
1350         (-[WK2WebDocumentController awakeFromNib]):
1351         (-[WK2WebDocumentController performTextFinderAction:]):
1352         (-[WK2WebDocumentController findBarView]):
1353         (-[WK2WebDocumentController setFindBarView:]):
1354         (-[WK2WebDocumentController isFindBarVisible]):
1355         (-[WK2WebDocumentController setFindBarVisible:]):
1356         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1357         (-[WK2WebDocumentController layout]):
1358         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1359         pointing at the WKWebView (currently nothing will work, but the bar will
1360         show up). Install and uninstall the bar as needed.
1361
1362         * WebEditingTester/WebDocument.xib:
1363         Don't use a full-size content view. There's no need, and it makes find
1364         bar layout harder.
1365
1366         * WebEditingTester/WebDocumentController.h:
1367         * WebEditingTester/WebDocumentController.m:
1368         (-[WebDocumentController performTextFinderAction:]):
1369
1370 2015-03-03  Sam Weinig  <sam@webkit.org>
1371
1372         [Content Extensions] Split parsing and compiling of content extensions into their own files
1373         https://bugs.webkit.org/show_bug.cgi?id=142259
1374
1375         Reviewed by Anders Carlsson.
1376
1377         Add basic unit test for the content filter compiler.
1378
1379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1380         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1381         (WebCore::ContentExtensions::operator<<):
1382         (TestWebKitAPI::ContentFilterTest::SetUp):
1383         (TestWebKitAPI::TEST_F):
1384
1385 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1386
1387         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1388         https://bugs.webkit.org/show_bug.cgi?id=142230
1389
1390         Reviewed by Csaba Osztrogonác.
1391
1392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1393         (TestFactory):
1394         (TestFactory.getProduct): Added
1395         (TestFactory.__init__): moved downloader to getProduct
1396         (BuildAndTestFactory):        
1397         (BuildAndTestFactory.getProduct): Added
1398         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1399         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1400
1401 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1402
1403         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1404         https://bugs.webkit.org/show_bug.cgi?id=142225
1405
1406         Reviewed by Carlos Garcia Campos.
1407
1408         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1409         (testWebViewWebContextLifetime):
1410         (beforeAll):
1411
1412 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1413
1414         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1415         <http://webkit.org/b/142243>
1416
1417         Reviewed by Alexey Proskuryakov.
1418
1419         * WebKitTestRunner/TestController.cpp:
1420         (WTR::TestController::webProcessName):
1421         (WTR::TestController::networkProcessName):
1422         - Return the same process name on iOS and Mac because they both
1423           use the same process name for local engineering builds.
1424
1425 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1426
1427         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1428         <http://webkit.org/b/141872>
1429
1430         Reviewed by Alex Christensen.
1431
1432         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1433         semi-colons in various places and fix whitespace.
1434         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1435         constants.
1436         (_IncludeState.__init__): Add self._visited_soft_link_section
1437         boolean state variable.
1438         (_IncludeState.visited_soft_link_section): Getter for
1439         self._visited_soft_link_section.
1440         (_IncludeState.check_next_include_order): Update state machine
1441         for soft-link headers.  Add check that soft-link headers always
1442         appear last.
1443         (_classify_include): Add check for soft-link header type.
1444         (check_include_line): Return early if there is a soft-link
1445         header error.
1446
1447         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1448         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1449         including soft-link headers.
1450         (OrderOfIncludesTest.test_classify_include): Add test for
1451         _SOFT_LINK_HEADER type.
1452
1453 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1454
1455         build.webkit.org/dashboard: Don't repeatedly handle each test type
1456         https://bugs.webkit.org/show_bug.cgi?id=142211
1457
1458         Reviewed by Tim Horton and Matt Hanson.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1461         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1462         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1463         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1464         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1465         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1466         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1467         Removed functions that build a link to test step results. The buildbot provides
1468         these links in JSON.
1469
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1471         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1472         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1473         We can easily add them to the map as needed.
1474         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1475         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1476         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1477         and then build a BuildbotTestResults object, which was strange.
1478         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1479
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1481         Corrected an unrelated assertion that was buggy, and kept firing.
1482
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1484         (BuildbotTestResults):
1485         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1486         (BuildbotTestResults.prototype._parseResults):
1487         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1488         Moved the code for parsing JSON results for a single step here.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1491         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1492         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1493         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1494         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1495         (BuildbotTesterQueueView.prototype.update): Deleted.
1496         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1497         Updated for the new data structures. One behavior change is that we now display individual
1498         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1499         test failures, 3 platform api test failures".
1500
1501 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1502
1503         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1504         https://bugs.webkit.org/show_bug.cgi?id=142094
1505
1506         Reviewed by Csaba Osztrogonác.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1510         (TestFactory):
1511         (TestFactory.__init__): Made running of JSC tests conditional.
1512         (TestAllButJSCFactory):
1513         (TestJSCFactory): Added.
1514         (TestJSCFactory.__init__):
1515         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1516
1517 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1518
1519         `build-webkit --help` is wrong about how to build for the iOS simulator
1520         <http://webkit.org/b/142223>
1521
1522         Reviewed by Csaba Osztrogonác.
1523
1524         * Scripts/build-webkit: Fix help.
1525
1526 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1527
1528         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1529
1530         * gtk/jhbuild.modules:
1531
1532 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1533
1534         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1535         https://bugs.webkit.org/show_bug.cgi?id=141508
1536
1537         Reviewed by Sergio Villar Senin.
1538
1539         Add a unit test to check that synchronous XHRs load even if the
1540         maximum connection limits are reached.
1541
1542         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1543         (testWebViewSyncRequestOnMaxConns):
1544         (serverCallback):
1545         (beforeAll):
1546         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1547
1548 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
1549
1550         Update the name of ASan build step.
1551
1552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1553
1554 2015-03-02  Jer Noble  <jer.noble@apple.com>
1555
1556         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1557         https://bugs.webkit.org/show_bug.cgi?id=142121
1558
1559         Reviewed by Simon Fraser.
1560
1561         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1562         that the initial and final screen rects for the web content are as expected.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1566         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1567         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1568         (runJavaScriptAlert):
1569         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1570         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1571         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1572         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1573         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1574         (TestWebKitAPI::TEST_F):
1575
1576 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1577
1578         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1579
1580         Follow-up fix for:
1581
1582         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1583         <http://webkit.org/b/142145>
1584
1585         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1586         (-[LTRelayController _environmentVariables]): Fix think-o.
1587
1588 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1589
1590         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1591         <http://webkit.org/b/142145>
1592
1593         Reviewed by Simon Fraser.
1594
1595         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1596         (-[LTRelayController _environmentVariables]): Add.
1597         (-[LTRelayController launchApp]): Use -_environmentVariables.
1598
1599 2015-02-28  David Kilzer  <ddkilzer@apple.com>
1600
1601         [iOS] Stop running webkit-build-directory on every layout test
1602
1603         This was originally fixed by David Farler for Bug 135409 in
1604         r172602.
1605
1606         * Scripts/webkitpy/port/ios.py:
1607         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1608         run webkit-build-directory every time it's called.
1609
1610 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1611
1612         W3C importer should use filesystem instead of shutil/host
1613         https://bugs.webkit.org/show_bug.cgi?id=142012
1614
1615         Reviewed by Bem Jones-Bey.
1616
1617         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1618
1619         * Scripts/webkitpy/w3c/test_importer.py:
1620         (main):
1621         (TestImporter.do_import):
1622         (TestImporter.find_importable_tests):
1623         (TestImporter.import_tests):
1624         (TestImporter.remove_deleted_files):
1625         (TestImporter.write_import_log):
1626
1627 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1628
1629         W3C test importer should use filesystem to read and write files
1630         https://bugs.webkit.org/show_bug.cgi?id=142084
1631
1632         Reviewed by Bem Jones-Bey.
1633
1634         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1635
1636         * Scripts/webkitpy/w3c/test_importer.py:
1637         (TestImporter.import_tests):
1638         (TestImporter.remove_deleted_files):
1639         (TestImporter.write_import_log):
1640
1641 2015-02-27  Sam Weinig  <sam@webkit.org>
1642
1643         Add WebKit2 SPI to create a DOM File object
1644         https://bugs.webkit.org/show_bug.cgi?id=142109
1645
1646         Reviewed by Tim Horton.
1647
1648         Add a test for WKBundleFileHandleRef.
1649
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1652         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1653         (TestWebKitAPI::didFinishLoadForFrame):
1654         (TestWebKitAPI::TEST):
1655         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1656         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1657         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1658
1659 2015-02-27  Michael Saboff  <msaboff@apple.com>
1660
1661         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1662         https://bugs.webkit.org/show_bug.cgi?id=142112
1663
1664         Reviewed by Filip Pizlo.
1665
1666         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1667         <someDir> as the library path.
1668
1669         * Scripts/run-jsc-benchmarks:
1670
1671 2015-02-27  Alex Christensen  <achristensen@webkit.org>
1672
1673         [WinCairo] Unreviewed build fix.
1674
1675         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1676         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1677
1678 2015-02-27  Anders Carlsson  <andersca@apple.com>
1679
1680         Add infrastructure for handling website data in the network process
1681         https://bugs.webkit.org/show_bug.cgi?id=142092
1682
1683         Reviewed by Andreas Kling.
1684
1685         Add a menu item that will fetch all website data, delete the returned data records, and
1686         fetch all website data again so we can confirm that it's all empty.
1687
1688         * MiniBrowser/mac/WK2BrowserWindowController.m:
1689         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1690
1691 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1692
1693         [Win] Remove remaining SafariTheme cruft
1694         https://bugs.webkit.org/show_bug.cgi?id=142075
1695
1696         Reviewed by Anders Carlsson.
1697
1698         Remove reference to SafariTheme-switching preference.
1699
1700         * DumpRenderTree/win/DumpRenderTree.cpp:
1701         (resetWebPreferencesToConsistentValues):
1702         (prepareConsistentTestingEnvironment):
1703
1704 2015-02-26  Doug Russell  <d_russell@apple.com>
1705
1706         AX: Expose caret browsing preference to accessibility API
1707         https://bugs.webkit.org/show_bug.cgi?id=141862
1708
1709         Reviewed by Chris Fleizach.
1710
1711         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1712         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1713
1714         * DumpRenderTree/AccessibilityUIElement.cpp:
1715         (setBoolAttributeValueCallback):
1716         (selectedTextMarkerRangeCallback):
1717         (resetSelectedTextMarkerRangeCallback):
1718         (AccessibilityUIElement::setBoolAttributeValue):
1719         (AccessibilityUIElement::selectedTextMarkerRange):
1720         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1721         (AccessibilityUIElement::getJSClass):
1722         * DumpRenderTree/AccessibilityUIElement.h:
1723         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1724         (AccessibilityUIElement::setBoolAttributeValue):
1725         (AccessibilityUIElement::selectedTextMarkerRange):
1726         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1727         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1728         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1729         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1730         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1731         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1732         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1733         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1734         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1735         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1736         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1737
1738 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1739
1740         [Win] Remove WebKitExportGenerator project (and related)
1741         https://bugs.webkit.org/show_bug.cgi?id=142035
1742
1743         Reviewed by Dean Jackson.
1744
1745         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1746         build log from WebKitExportGenerator.
1747
1748 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1749
1750         [EFL] Bump EFL version to 1.13.0
1751         https://bugs.webkit.org/show_bug.cgi?id=141708
1752
1753         Reviewed by Gyuyoung Kim.
1754
1755         * efl/jhbuild.modules:
1756
1757 2015-02-26  Sam Weinig  <sam@webkit.org>
1758
1759         Check in missing WebEditingTester.xcconfig file.
1760
1761         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1762
1763 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1764
1765         [webkitpy] Remove skipped file related crufts
1766         https://bugs.webkit.org/show_bug.cgi?id=142046
1767
1768         Reviewed by Ryosuke Niwa.
1769
1770         * Scripts/webkitpy/port/base.py:
1771         (Port.skipped_layout_tests):
1772         (Port._tests_from_skipped_file_contents): Deleted.
1773         (Port): Deleted.
1774         (Port._expectations_from_skipped_files): Deleted.
1775         * Scripts/webkitpy/port/mac_unittest.py:
1776         (MacTest.test_default_timeout_ms):
1777         (MacTest): Deleted.
1778         (test_tests_from_skipped_file_contents): Deleted.
1779
1780 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1781
1782         [Win] Unreviewed WinCairo build fix after r180653.
1783
1784         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1785
1786         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1788         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1789         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1790         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1791
1792 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
1793
1794         [Win] Use WEBCORE_EXPORT instead of Definition file
1795         https://bugs.webkit.org/show_bug.cgi?id=141734
1796
1797         Reviewed by Alex Christensen.
1798
1799         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1800         Use a precompiled header so we can define our export macros properly.
1801         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1802         Visual studio automatic update stuff.
1803         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1804         Set up Precompiled Header use for project..
1805         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1806         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1807         declarations for building DumpRenderTree as a client of
1808         WebCore/WebKit.
1809
1810 2015-02-25  Mark Lam  <mark.lam@apple.com>
1811
1812         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1813         <https://webkit.org/b/141672>
1814
1815         Reviewed by Alexey Proskuryakov.
1816
1817         ASan does not like the fact that we memcpy the stack for GC scans.  So,
1818         we're working around this by using our own memcpy (asanUnsafeMemcpy)
1819         implementation that we can tell ASan to ignore.
1820
1821         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1822         which isn't effective for working around this issue. 
1823
1824         * asan/webkit-asan-ignore.txt:
1825
1826 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
1827
1828         CodeBlock crashes when dumping op_push_name_scope
1829         https://bugs.webkit.org/show_bug.cgi?id=141953
1830
1831         Reviewed by Filip Pizlo.
1832
1833         * Scripts/run-jsc-stress-tests:
1834
1835 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1836
1837         W3C test importer should use argparse instead of optparse
1838         https://bugs.webkit.org/show_bug.cgi?id=142013
1839
1840         Reviewed by Bem Jones-Bey.
1841
1842         * Scripts/webkitpy/w3c/test_importer.py:
1843         (main): Updating according argparse.
1844         (parse_args): Moving from optparse to argparse.
1845
1846 2015-02-25  Brady Eidson  <beidson@apple.com>
1847
1848         Get rid of TestInvocation::pathOrURL
1849         https://bugs.webkit.org/show_bug.cgi?id=142021
1850
1851         Reviewed by Tim Horton.
1852
1853         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1854         but most code that uses it expected an absolute path.
1855
1856         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1857
1858         * WebKitTestRunner/TestController.cpp:
1859         (WTR::TestController::updateWebViewSizeForTest):
1860         (WTR::TestController::updateWindowScaleForTest):
1861         (WTR::shouldUseFixedLayout):
1862         (WTR::TestController::updateLayoutTypeForTest):
1863
1864         * WebKitTestRunner/TestInvocation.cpp:
1865         (WTR::TestInvocation::TestInvocation):
1866         (WTR::TestInvocation::urlContains):
1867         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1868         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1869         (WTR::TestInvocation::invoke):
1870         (WTR::shouldLogFrameLoadDelegates): Deleted.
1871         (WTR::shouldLogHistoryClientCallbacks): Deleted.
1872         * WebKitTestRunner/TestInvocation.h:
1873         (WTR::TestInvocation::pathOrURL): Deleted.
1874
1875         * WebKitTestRunner/ios/TestControllerIOS.mm:
1876         (WTR::shouldMakeViewportFlexible):
1877         (WTR::TestController::platformConfigureViewForTest):
1878
1879         * WebKitTestRunner/mac/TestControllerMac.mm:
1880         (WTR::shouldUseThreadedScrolling):
1881         (WTR::TestController::platformConfigureViewForTest):
1882
1883 2015-02-25  Brady Eidson  <beidson@apple.com>
1884
1885         Layout test support for user content filters
1886         https://bugs.webkit.org/show_bug.cgi?id=142018
1887
1888         Reviewed by Tim Horton.
1889
1890         * WebKitTestRunner/TestController.cpp:
1891         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1892
1893         * WebKitTestRunner/mac/TestControllerMac.mm:
1894         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1895           file before loading the test itself.
1896
1897 2015-02-24  Sam Weinig  <sam@webkit.org>
1898
1899         Convert WebEditingTester to use xcconfig files
1900         https://bugs.webkit.org/show_bug.cgi?id=141879
1901
1902         Reviewed by Darin Adler.
1903
1904         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1905
1906         * WebEditingTester/Configurations: Added.
1907         * WebEditingTester/Configurations/Base.xcconfig: Added.
1908         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1909         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1910
1911 2015-02-24  Andy Estes  <aestes@apple.com>
1912
1913         Teach MiniBrowser how to disable per-window web processes
1914         https://bugs.webkit.org/show_bug.cgi?id=141988
1915
1916         Reviewed by Darin Adler.
1917
1918         * MiniBrowser/mac/AppDelegate.m:
1919         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1920         * MiniBrowser/mac/SettingsController.h:
1921         * MiniBrowser/mac/SettingsController.m:
1922         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1923         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1924         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1925         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1926
1927 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1928
1929         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1930         https://bugs.webkit.org/show_bug.cgi?id=141889
1931
1932         Reviewed by Darin Adler.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1935
1936 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1937
1938         REGRESSION(r179429): Can't type comments in Facebook
1939         https://bugs.webkit.org/show_bug.cgi?id=141859
1940
1941         Reviewed by Brent Fulgham.
1942
1943         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1944
1945         * DumpRenderTree/mac/DumpRenderTree.mm:
1946         (resetWebPreferencesToConsistentValues):
1947         * DumpRenderTree/win/DumpRenderTree.cpp:
1948         (resetWebPreferencesToConsistentValues):
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::resetPreferencesToConsistentValues):
1951
1952 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1953
1954         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1955         https://bugs.webkit.org/show_bug.cgi?id=141867
1956
1957         Reviewed by Anders Carlsson.
1958
1959         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1960         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1961         be shared with the new test.
1962         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1963         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1964         (testLoadAlternateHTMLForLocalPage):
1965         (beforeAll):
1966
1967 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1968
1969         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1970         <http://webkit.org/b/141900>
1971
1972         Reviewed by Myles C. Maxfield.
1973
1974         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1975         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1976         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1977         - Rename to share code with iOS.
1978         - Add USE(APPKIT) around AppKit-specific headers and code.
1979         - Fix a check-webkit-style warning.
1980         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1981         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1982         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1983         - Remove ios/ActivateFontsIOS.mm.
1984         - Fix InjectedBundle/cocoa group to represent the directory on
1985           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1986
1987 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1988
1989         Unreviewed, rolling out r180547 and r180550.
1990         https://bugs.webkit.org/show_bug.cgi?id=141957
1991
1992         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1993
1994         Reverted changesets:
1995
1996         "REGRESSION(r179429): Can't type comments in Facebook"
1997         https://bugs.webkit.org/show_bug.cgi?id=141859
1998         http://trac.webkit.org/changeset/180547
1999
2000         "Constructor returning null should construct an object instead
2001         of null"
2002         https://bugs.webkit.org/show_bug.cgi?id=141640
2003         http://trac.webkit.org/changeset/180550
2004
2005 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2006
2007         REGRESSION(r179429): Can't type comments in Facebook
2008         https://bugs.webkit.org/show_bug.cgi?id=141859
2009
2010         Reviewed by Geoffrey Garen.
2011
2012         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2013
2014         * DumpRenderTree/mac/DumpRenderTree.mm:
2015         (resetWebPreferencesToConsistentValues):
2016         * WebKitTestRunner/TestController.cpp:
2017         (WTR::TestController::resetPreferencesToConsistentValues):
2018
2019 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
2020
2021         [EFL] fix eo errors
2022         https://bugs.webkit.org/show_bug.cgi?id=141909
2023
2024         Reviewed by Gyuyoung Kim.
2025
2026         Fix eo errors that occur whenever minibrowser is launched.
2027         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2028         - elm_obj_win_resize_object_add's first parameter should be elm_win
2029
2030         * MiniBrowser/efl/main.c:
2031         (window_create):
2032
2033 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2034
2035         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2036
2037         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2038         (TestWebKitAPI::TEST):
2039
2040 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2041
2042         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2043         https://bugs.webkit.org/show_bug.cgi?id=141935
2044
2045         Reviewed by Myles C. Maxfield.
2046
2047         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2048         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2049         tests for assigning from nullptr.
2050
2051 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2052
2053         WTF::WeakPtr should have a 'forget' method.
2054         https://bugs.webkit.org/show_bug.cgi?id=141923
2055
2056         Reviewed by Myles C. Maxfield.
2057
2058         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2059         (TestWebKitAPI::TEST): Added 'Forget' tests case.
2060
2061 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2062
2063         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2064         https://bugs.webkit.org/show_bug.cgi?id=141920
2065
2066         Reviewed by Tim Horton.
2067
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2069         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2070         Do the same thing as we do for regular green bubbles.
2071
2072 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2073
2074         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2075         https://bugs.webkit.org/show_bug.cgi?id=141925
2076
2077         Reviewed by Tim Horton.
2078
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2080         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2081
2082 2015-02-23  Anders Carlsson  <andersca@apple.com>
2083
2084         Add API for fetching website data records to _WKWebsiteDataStore
2085         https://bugs.webkit.org/show_bug.cgi?id=141926
2086
2087         Reviewed by Beth Dakin.
2088
2089         * MiniBrowser/mac/MainMenu.xib:
2090         * MiniBrowser/mac/WK2BrowserWindowController.m:
2091         (-[WK2BrowserWindowController fetchWebsiteData:]):
2092         Add menu item to fetch and dump website data.
2093
2094 2015-02-23  David Kilzer  <ddkilzer@apple.com>
2095
2096         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2097         <http://webkit.org/b/141884>
2098
2099         Reviewed by Alexey Proskuryakov.
2100
2101         * Scripts/webkitpy/port/leakdetector.py:
2102         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2103         snowleopard, lion and older leaks.  Add known leak for
2104         mavericks, but check Port.operating_system before calling
2105         Port.is_mavericks.
2106         * Scripts/webkitpy/port/mac.py:
2107         (MacPort.is_snowleopard): Delete.
2108         (MacPort.is_lion): Delete.
2109         (MacPort.is_mavericks): Add.
2110
2111 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2112
2113         build.webkit.org/dashboard should filter out commits to other branches
2114         https://bugs.webkit.org/show_bug.cgi?id=140362
2115
2116         Reviewed by Tim Horton.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2119         (BuildbotQueue):
2120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2121         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2122         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2123         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2124         (BuildbotQueueView.prototype.revisionContentForIteration):
2125         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2126         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2127         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2129         (Trac.prototype.get oldestRecordedRevisionNumber):
2130         (Trac.prototype.commitsOnBranch):
2131         (Trac.prototype._xmlTimelineURL):
2132         (Trac.prototype._convertCommitInfoElementToObject):
2133         (Trac.prototype._update):
2134         (Trac.prototype.startPeriodicUpdates):
2135         (Trac.prototype.loadMoreHistoricalData):
2136         (Trac.prototype.update): Deleted.
2137
2138 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2139
2140         Tests don't work on some bots: Failed to stop wptwk
2141         https://bugs.webkit.org/show_bug.cgi?id=141235
2142
2143         Reviewed by Ryosuke Niwa.
2144
2145         Logging of server subprocesses in launcher script.
2146         Killing of server subprocesses when stopping/before starting.
2147         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2148
2149         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2150         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
2151         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2152         (WebPlatformTestServer.__init__):
2153         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2154         (WebPlatformTestServer):
2155         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2156         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
2157         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2158         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2159         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2160         (TestWebPlatformTestServer):
2161         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2162
2163 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2164
2165         [WebEditingTester] Allow dropping HTML files on the app
2166         https://bugs.webkit.org/show_bug.cgi?id=141834
2167
2168         Reviewed by Simon Fraser.
2169
2170         * WebEditingTester/AppDelegate.m:
2171         (-[WebEditingAppDelegate openDocument:]):
2172         (-[WebEditingAppDelegate application:openFile:]):
2173         Implement application:openFile:, factoring file loading code out of openDocument.
2174
2175         * WebEditingTester/Info.plist:
2176         Register as an editor for HTML files.
2177
2178         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2179         Enrica is not an organization.
2180
2181 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2182
2183         [WebEditingTester] Expand "WK" to "WebKit" in a few places
2184         https://bugs.webkit.org/show_bug.cgi?id=141833
2185
2186         Reviewed by Anders Carlsson.
2187
2188         * WebEditingTester/AppDelegate.h:
2189         * WebEditingTester/AppDelegate.m:
2190         (-[WebEditingAppDelegate newEditor:]):
2191         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2192         (-[WebEditingAppDelegate validateMenuItem:]):
2193         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2194         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2195         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2196         (-[WebEditingAppDelegate showOperations:]): Deleted.
2197         * WebEditingTester/MainMenu.xib:
2198         The WK abbreviation is unnaturally grating in menu items for some reason.
2199
2200 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2201
2202         [WebEditingTester] Add a custom protocol for loading canned content
2203         https://bugs.webkit.org/show_bug.cgi?id=141830
2204
2205         Reviewed by Enrica Casucci.
2206
2207         Add a canned:// protocol handler, which can be used to emulate behaviors
2208         in WebKit client apps (like Mail) that use custom protocol handlers,
2209         which can have important effects on editing (mostly, the URLs are only
2210         valid inside of the client application, but not when copied/dragged out).
2211
2212         For now, we only support two canned files:
2213
2214             canned://dice is a PNG of dice (stolen from LayoutTests/)
2215             canned://text is the string "canned text" served as text/html
2216
2217         In the future we could support things like very large (generated) files,
2218         progressive loading, etc. to further simulate conditions in other apps.
2219
2220         * WebEditingTester/AppDelegate.m:
2221         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2222         Register the protocol with CFNetwork, and the scheme with WebKit2.
2223
2224         * WebEditingTester/Canned Content/dice.png: Added.
2225         * WebEditingTester/CannedContent.h: Added.
2226         * WebEditingTester/CannedContent.m: Added.
2227         (-[CannedContent initWithRequest:cachedResponse:client:]):
2228         (+[CannedContent canonicalRequestForRequest:]):
2229         (+[CannedContent canInitWithRequest:]):
2230         We only want to handle canned:// URLs.
2231
2232         (-[CannedContent startLoading]):
2233         For now, immediately load the two files we know about.
2234         Otherwise, immediately fail the load.
2235
2236         (-[CannedContent stopLoading]):
2237         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2238
2239 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2240
2241         [WebEditingTester] Implement an open panel
2242         https://bugs.webkit.org/show_bug.cgi?id=141829
2243
2244         Reviewed by Simon Fraser.
2245
2246         * WebEditingTester/AppDelegate.m:
2247         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2248         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2249         (-[WebEditingAppDelegate openDocument:]):
2250         Add an open panel (with radio buttons to pick which WebKit to open with).
2251         Loads the file as an HTML string.
2252
2253 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
2254
2255         [WebEditingTester] @properties, dot syntax, and remember the window position
2256         https://bugs.webkit.org/show_bug.cgi?id=141843
2257
2258         Reviewed by Tim Horton.
2259         
2260         Modernize a bit with more dot syntax, use @property for the web views,
2261         and give the main window an Autosave name so it remembers the widow position.
2262
2263         * WebEditingTester/WK1WebDocumentController.m:
2264         (-[WK1WebDocumentController awakeFromNib]):
2265         (-[WK1WebDocumentController loadHTMLString:]):
2266         * WebEditingTester/WK2WebDocumentController.m:
2267         (-[WK2WebDocumentController awakeFromNib]):
2268         * WebEditingTester/WebDocument.xib:
2269
2270 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2271
2272         [WebEditingTester] Hook up key equivalents for new window action
2273         https://bugs.webkit.org/show_bug.cgi?id=141828
2274
2275         Reviewed by Enrica Casucci.
2276
2277         * WebEditingTester/AppDelegate.h:
2278         * WebEditingTester/AppDelegate.m:
2279         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2280         (-[WebEditingAppDelegate newEditor:]):
2281         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2282         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2283         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2284         (defaultConfiguration): Deleted.
2285         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2286         Move WKWebViewConfiguration setup into WK2WebDocumentController.
2287         Remove unused application termination code.
2288         Update new-window menu item key equivalents when launching and when
2289         changing the use-WebKit2-by-default setting.
2290         Make WebDocumentController subclasses all initialized the same way,
2291         and use that to factor out alloc/init.
2292         Rename loadContent to loadHTMLString for future use.
2293
2294         * WebEditingTester/MainMenu.xib:
2295         Add default key equivalents.
2296         Cmd-N will always make the default kind of window (controlled by the pref).
2297         Cmd-Opt-N will always make the other kind.
2298         The menu items are configured as alternates so they only show up if you
2299         press alt (just like in MiniBrowser).
2300
2301         * WebEditingTester/WK1WebDocumentController.m:
2302         (-[WK1WebDocumentController loadHTMLString:]):
2303         (-[WK1WebDocumentController loadContent]): Deleted.
2304         * WebEditingTester/WK2WebDocumentController.h:
2305         * WebEditingTester/WK2WebDocumentController.m:
2306         (defaultConfiguration):
2307         (-[WK2WebDocumentController awakeFromNib]):
2308         (-[WK2WebDocumentController loadHTMLString:]):
2309         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2310         (-[WK2WebDocumentController dealloc]): Deleted.
2311         * WebEditingTester/WebDocumentController.h:
2312         * WebEditingTester/WebDocumentController.m:
2313         (-[WebDocumentController init]):
2314         (-[WebDocumentController initWithWindow:]):
2315         (+[WebDocumentController defaultEditingSource]):
2316         (-[WebDocumentController loadHTMLString:]):
2317         (-[WebDocumentController windowDidLoad]): Deleted.
2318         (-[WebDocumentController defaultEditingSource]): Deleted.
2319         (-[WebDocumentController applicationTerminating]): Deleted.
2320         (-[WebDocumentController loadContent]): Deleted.
2321
2322 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2323
2324         [WebEditingTester] ARC-ify WebEditingTester
2325         https://bugs.webkit.org/show_bug.cgi?id=141827
2326
2327         Reviewed by Sam Weinig.
2328
2329         * WebEditingTester/AppDelegate.m:
2330         (-[WebEditingAppDelegate showOperations:]):
2331         * WebEditingTester/EditingOperations.m:
2332         (editingOperations):
2333         * WebEditingTester/WK1WebDocumentController.m:
2334         (-[WK1WebDocumentController dealloc]): Deleted.
2335         * WebEditingTester/WK2WebDocumentController.m:
2336         (-[WK2WebDocumentController dealloc]): Deleted.
2337         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2338         Turn on ARC and remove a few retain/release/autorelease calls.
2339         We don't need to implement dealloc in either document controller
2340         because WebView and WKWebView's UIDelegate property does not hold a
2341         strong reference.
2342
2343 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2344
2345         [WebEditingTester] Factor out list of editing operations
2346         https://bugs.webkit.org/show_bug.cgi?id=141826
2347
2348         Reviewed by Sam Weinig.
2349
2350         * WebEditingTester/AppDelegate.m:
2351         (-[WebEditingAppDelegate showOperations:]):
2352         * WebEditingTester/EditingOperations.h: Added.
2353         * WebEditingTester/EditingOperations.m: Added.
2354         (editingOperations):
2355         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2356         Move EditingOperations array to its own file, and make it an NSArray
2357         instead of a C array. Adjust accordingly in showOperations:.
2358
2359 2015-02-20  Michael Saboff  <msaboff@apple.com>
2360
2361         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2362         https://bugs.webkit.org/show_bug.cgi?id=141676
2363
2364         Reviewed by Filip Pizlo.
2365
2366         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2367         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2368         large string expression that we want to eval.
2369
2370         * Scripts/run-jsc-stress-tests:
2371
2372 2015-02-19  Daniel Bates  <dabates@apple.com>
2373
2374         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2375         https://bugs.webkit.org/show_bug.cgi?id=141815
2376         <rdar://problem/19893933>
2377
2378         Reviewed by Simon Fraser.
2379
2380         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2381         was booted by iOS Simulator in a previous run of run-webkit-test.
2382
2383         * Scripts/webkitpy/port/ios.py:
2384         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2385         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2386         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2387
2388 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2389
2390         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2391         <http://webkit.org/b/141799>
2392
2393         Reviewed by Alex Christensen.
2394
2395         * Scripts/webkitpy/style/checkers/cpp.py:
2396         (_IncludeState.check_next_include_order): Don't emit a warning
2397         if the primary header exists and the source file name ends with
2398         "SoftLink.cpp".  Add 'filename' argument to method.
2399         (check_include_line): Pass in 'filename'.
2400
2401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2402         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2403         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2404         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2405         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2406         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2407         - Add test filename arguments for calls to
2408           check_next_include_order().
2409         (OrderOfIncludesTest.test_primary_header): Add test for a file
2410         name ending in "SoftLink.cpp".
2411
2412 2015-02-18  Enrica Casucci  <enrica@apple.com>
2413
2414         Add new tool to test editable Webviews.
2415         https://bugs.webkit.org/show_bug.cgi?id=141772
2416
2417         Reviewed by Tim Horton.
2418
2419         Adding WebEditingTester, a Cocoa application to
2420         test WK1 and Wk2 views in editable mode.
2421
2422         * WebEditingTester: Added.
2423         * WebEditingTester/AppDelegate.h: Added.
2424         * WebEditingTester/AppDelegate.m: Added.
2425         (-[WebEditingAppDelegate init]):
2426         (defaultConfiguration):
2427         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2428         (-[WebEditingAppDelegate applicationWillTerminate:]):
2429         (-[WebEditingAppDelegate newEditor:]):
2430         (-[WebEditingAppDelegate showOperations:]):
2431         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2432         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2433         (-[WebEditingAppDelegate validateMenuItem:]):
2434         * WebEditingTester/Info.plist: Added.
2435         * WebEditingTester/MainMenu.xib: Added.
2436         * WebEditingTester/WK1WebDocumentController.h: Added.
2437         * WebEditingTester/WK1WebDocumentController.m: Added.
2438         (-[WK1WebDocumentController awakeFromNib]):
2439         (-[WK1WebDocumentController loadContent]):
2440         (-[WK1WebDocumentController dealloc]):
2441         (-[WK1WebDocumentController pasteAsMarkup:]):
2442         * WebEditingTester/WK2WebDocumentController.h: Added.
2443         * WebEditingTester/WK2WebDocumentController.m: Added.
2444         (-[WK2WebDocumentController initWithConfiguration:]):
2445         (-[WK2WebDocumentController pasteAsMarkup:]):
2446         (-[WK2WebDocumentController awakeFromNib]):
2447         (-[WK2WebDocumentController dealloc]):
2448         (-[WK2WebDocumentController loadContent]):
2449         * WebEditingTester/WebDocument.xib: Added.
2450         * WebEditingTester/WebDocumentController.h: Added.
2451         * WebEditingTester/WebDocumentController.m: Added.
2452         (-[WebDocumentController initWithWindow:]):
2453         (-[WebDocumentController windowDidLoad]):
2454         (-[WebDocumentController defaultEditingSource]):
2455         (-[WebDocumentController applicationTerminating]):
2456         (-[WebDocumentController loadContent]):
2457         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2458         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2459         * WebEditingTester/main.m: Added.
2460         (main):
2461
2462 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2463
2464         Run JSC tests on ARM EFL bots
2465         https://bugs.webkit.org/show_bug.cgi?id=141165
2466
2467         Reviewed by Alexey Proskuryakov.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/config.json:
2470         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2471         (RunJavaScriptCoreTests.countFailures):
2472         (RunRemoteJavaScriptCoreTests):
2473         (RunRemoteJavaScriptCoreTests.start):
2474         (BuildAndRemoteJSCTestsFactory):
2475         (BuildAndRemoteJSCTestsFactory.__init__):
2476
2477 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2478
2479         Streamline unexported function build fixes
2480         https://bugs.webkit.org/show_bug.cgi?id=141761
2481
2482         Reviewed by Alex Christensen.
2483
2484         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2485         We don't need to ignore symbols that are not exported due to the .unexp file.
2486
2487 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2488
2489         Remove more references to WebCore.exp.in
2490         https://bugs.webkit.org/show_bug.cgi?id=141747
2491
2492         Reviewed by Alexey Proskuryakov.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2495         (ShouldBuildTest):
2496
2497 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2498
2499         Windows test results should not fall back to mac-mountainlion after r180176
2500         https://bugs.webkit.org/show_bug.cgi?id=141719
2501
2502         Reviewed by Brent Fulgham.
2503
2504         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2505         (_should_file_trigger_build):
2506         * Scripts/webkitpy/port/win.py:
2507         (WinPort.default_baseline_search_path):
2508         * Scripts/webkitpy/port/win_unittest.py:
2509         (WinPortTest.test_baseline_search_path):
2510
2511 2015-02-17  Daniel Bates  <dabates@apple.com>
2512
2513         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2514         https://bugs.webkit.org/show_bug.cgi?id=141718
2515
2516         Reviewed by Alex Christensen.
2517
2518         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2519
2520         * Scripts/webkitpy/port/ios.py:
2521         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2522         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2523         appropriate action, say exit(3) before running any layout tests.
2524         * Scripts/webkitpy/xcode/simulator.py:
2525         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2526         with the specified UDID.
2527         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2528         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2529         boot and shut down the device, erasing the device between tries so as to restore the device
2530         to a known good state.
2531
2532 2015-02-17  Daniel Bates  <dabates@apple.com>
2533
2534         run_webkit_tests.py should not know about iOS Simulator details
2535         https://bugs.webkit.org/show_bug.cgi?id=141711
2536
2537         Reviewed by Alex Christensen.
2538
2539         Run_webkit_tests.py should only parse the iOS-specific command
2540         line options --runtime and --device-type. Let the port-specific
2541         logic in ios.py validate the parsed options and instantiate
2542         internal data structures.
2543
2544         Currently run_webkit_tests.py parses the iOS-specific command
2545         line options --runtime and --device-type, validates them, and
2546         instantiates internal data structures from the parsed strings.
2547         Instead the validation logic and instantiation of internal
2548         data structures should be handled by the iOS port object.
2549
2550         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2551         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2552         and instantiate internal data structures for them.
2553         * Scripts/webkitpy/port/driver.py:
2554         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2555         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2556         respectively.
2557         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2558         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2559         object from --runtime, if specified. Otherwise, instantiates a Runtime
2560         object for the latest installed iphonesimulator SDK version.
2561         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2562         object from --device-type, if specified. Otherwise, instantiates
2563         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2564         machine, respectively.
2565         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2566         runtime is available to use.
2567         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2568         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2569         * Scripts/webkitpy/xcode/simulator.py:
2570         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2571         with a runtime identifier for the specified iOS version.
2572
2573 2015-02-17  Dana Burkart  <dburkart@apple.com>
2574
2575         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2576         https://bugs.webkit.org/show_bug.cgi?id=141672
2577
2578         Reviewed by David Kilzer.
2579
2580         * asan/webkit-asan-ignore.txt:
2581
2582 2015-02-17  Alex Christensen  <achristensen@webkit.org>
2583
2584         Remove WebCore.exp.in and clean up.
2585         https://bugs.webkit.org/show_bug.cgi?id=141491
2586
2587         Reviewed by Andreas Kling.
2588
2589         * Scripts/sort-export-file: Removed.
2590         * Scripts/webkitpy/style/checker.py:
2591         (_all_categories):
2592         (FileType):
2593         (CheckerDispatcher._file_type):
2594         (CheckerDispatcher._create_checker):
2595         Don't check if the export files are sorted.
2596         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2597         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2598
2599 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2600
2601         Unreviewed. Fix GTK+ make distcheck.
2602
2603         Do not exclude bmalloc directory from the tarball.
2604
2605         * gtk/manifest.txt.in:
2606
2607 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2610
2611         I forgot to add the return of a bool function.
2612
2613         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2614         (WebKitDOMNodeTest::testDOMCache):
2615
2616 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2617
2618         [GTK] GObject DOM bindings object are cached forever
2619         https://bugs.webkit.org/show_bug.cgi?id=141558
2620
2621         Reviewed by Sergio Villar Senin.
2622
2623         Add checks for all DOM objects to ensure they are not leaked. Also
2624         add a dedicated test for the DOM Object Cache.
2625
2626         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2627         (WebKitDOMNodeFilterTest::testTreeWalker):
2628         (WebKitDOMNodeFilterTest::testNodeIterator):
2629         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2630         (WebKitDOMNodeTest::testHierarchyNavigation):
2631         (WebKitDOMNodeTest::testInsertion):
2632         (WebKitDOMNodeTest::testTagNames):
2633         (WebKitDOMNodeTest::testDOMCache):
2634         (registerTests):
2635         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2636         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2637         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2638         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2639         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2640         (testWebKitDOMObjectCache):
2641         (beforeAll):
2642         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2643         (documentLoadedCallback):
2644
2645 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2646
2647         [GTK] WebKitFrame objects are never released
2648         https://bugs.webkit.org/show_bug.cgi?id=141641
2649
2650         Reviewed by Martin Robinson.
2651
2652         Add a way to check GObjects leaks for WebProcess tests and check
2653         WebKitFrame objects are not leaked.
2654
2655         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2656         (WebKitFrameTest::testMainFrame):
2657         (WebKitFrameTest::testURI):
2658         (WebKitFrameTest::testJavaScriptContext):
2659         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2660         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2661         (runTest):
2662         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2663
2664 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2665
2666         Fix the MiniBrowser build with newer clang
2667
2668         * MiniBrowser/mac/SettingsController.m:
2669         (-[SettingsController _toggleBooleanDefault:]):
2670         * MiniBrowser/mac/WK1BrowserWindowController.m:
2671         (-[WK1BrowserWindowController windowWillClose:]):
2672         * MiniBrowser/mac/WK2BrowserWindowController.m:
2673         (-[WK2BrowserWindowController windowWillClose:]):
2674         NSApp is id and clang gets confused about which -delegate we're talking about.
2675
2676 2015-02-16  Antti Koivisto  <antti@apple.com>
2677
2678         Develop/Disable Caches does not properly disable disk cache
2679         https://bugs.webkit.org/show_bug.cgi?id=141636
2680
2681         Reviewed by Anders Carlsson.
2682
2683         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2684         the network process too.
2685
2686         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2687
2688         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2689         (WTR::InjectedBundle::beginTesting):
2690         (WTR::InjectedBundle::setCacheModel):
2691         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2692         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2693
2694             Forward to TestController.
2695
2696         (WTR::TestRunner::setCacheModel):
2697         * WebKitTestRunner/TestInvocation.cpp:
2698         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2699
2700 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
2701
2702         Unreviewed. Add myself as a committer.
2703
2704         * Scripts/webkitpy/common/config/contributors.json:
2705
2706 2015-02-15  David Kilzer  <ddkilzer@apple.com>
2707
2708         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2709         <http://webkit.org/b/141607>
2710
2711         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2712         externals in Source/WebCore/Configurations/WebCore.unexp when
2713         building with Xcode 5.x.
2714         (readXcode5SymbolsToIgnore): Add.
2715
2716 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
2717
2718         [EFL] fix Evas GL engine error.
2719         https://bugs.webkit.org/show_bug.cgi?id=141621
2720
2721         Reviewed by Gyuyoung Kim.
2722
2723         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2724
2725         * MiniBrowser/efl/main.c:
2726         (elm_main):
2727
2728 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
2729
2730         [buildbot] Enable run-api-tests on release Mac bots
2731         https://bugs.webkit.org/show_bug.cgi?id=141518
2732
2733         Reviewed by Darin Adler.
2734
2735         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2736         (RunUnitTests):
2737         (BuildFactory.__init__):
2738         (TestFactory.__init__):
2739         (BuildAndTestFactory.__init__):
2740         (RunUnitTests.start): Deleted.
2741         (unitTestsSupported): Deleted.
2742
2743 2015-02-13  Anders Carlsson  <andersca@apple.com>
2744
2745         Add a move constructor and move assignment operator to Deque
2746         https://bugs.webkit.org/show_bug.cgi?id=141571
2747
2748         Reviewed by Andreas Kling.
2749
2750         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2751         (TestWebKitAPI::TEST):
2752
2753 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2754
2755         run-jsc-stress-tests --remote should skip profiler tests
2756         https://bugs.webkit.org/show_bug.cgi?id=141470
2757
2758         Reviewed by Filip Pizlo.
2759
2760         * Scripts/run-jsc-stress-tests:
2761
2762 2015-02-13  Anders Carlsson  <andersca@apple.com>
2763
2764         Add an initializer list constructor to Deque
2765         https://bugs.webkit.org/show_bug.cgi?id=141565
2766
2767         Reviewed by Andreas Kling.
2768
2769         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2770         (TestWebKitAPI::TEST):
2771
2772 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2773
2774         [buildbot] Remove buildJSCTool cruft from master.cfg
2775         https://bugs.webkit.org/show_bug.cgi?id=141513
2776
2777         Reviewed by Alexey Proskuryakov.
2778
2779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2780         (RunJavaScriptCoreTests):
2781         (RunJavaScriptCoreTests.start):
2782         (RunWebKitTests):
2783         (RunWebKitTests.start):
2784         (TestFactory.__init__):
2785         (TestLeaksFactory.__init__):
2786         (RunJavaScriptCoreTests.__init__): Deleted.
2787         (RunWebKitTests.__init__): Deleted.
2788
2789 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2790
2791         Unreviewed, remove empty directories.
2792
2793         * DumpRenderTree/gtk: Removed.
2794         * DumpRenderTree/gtk/fonts: Removed.
2795         * DumpRenderTree/unix: Removed.
2796         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2797         * GtkLauncher: Removed.
2798         * TestWebKitAPI/Tests/WebKitGtk: Removed.
2799         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2800         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2801         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2802
2803 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2804
2805         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2806         https://bugs.webkit.org/show_bug.cgi?id=141519
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * Scripts/build-webkittestrunner:
2811
2812 2015-02-12  Alex Christensen  <achristensen@webkit.org>
2813
2814         Removed empty directory.
2815
2816         * WinCELauncher: Removed.
2817
2818 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2819
2820         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2821         https://bugs.webkit.org/show_bug.cgi?id=141202
2822
2823         Reviewed by Darin Adler.
2824
2825         * Scripts/run-jsc-stress-tests:
2826
2827 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
2828
2829         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2830         https://bugs.webkit.org/show_bug.cgi?id=141517
2831
2832         Reviewed by Anders Carlsson.
2833
2834         We do not need to locate or use the DLL's that came with Safari, so stop
2835         failing when we cannot find them. Also remove some old Qt cruft from this
2836         script.
2837
2838         * BuildSlaveSupport/built-product-archive:
2839         (archiveBuiltProduct): 
2840         (extractBuiltProduct):
2841
2842 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
2843
2844         [Win] [64-bit] Work around MSVC2013 Runtime Bug
2845         https://bugs.webkit.org/show_bug.cgi?id=141498
2846         <rdar://problem/19803642>
2847
2848         Reviewed by Anders Carlsson.
2849
2850         Disable FMA3 instruction use in the MSVC math library to
2851         work around a VS2013 runtime crash. We can remove this
2852         workaround when we switch to VS2015.
2853
2854         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2855         disable FMA3 support.
2856         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2857         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2858         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2859         * Scripts/webkitperl/httpd.pm: Ditto.
2860         * TestWebKitAPI/win/main.cpp: Ditto.
2861         * WinLauncher/Common.cpp: Ditto.
2862         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2863
2864 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2865
2866         run-jsc-stress-tests should accept remote host config from JSON file
2867         https://bugs.webkit.org/show_bug.cgi?id=141509
2868
2869         Reviewed by Michael Saboff.
2870
2871         * Scripts/run-javascriptcore-tests:
2872         (runJSCStressTests):
2873         * Scripts/run-jsc-stress-tests:
2874
2875 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2876
2877         [GTK] Add API to allow overriding the default color chooser implementation
2878         https://bugs.webkit.org/show_bug.cgi?id=98935
2879
2880         Reviewed by Gustavo Noronha Silva.
2881
2882         Add a color chooser implementation for MiniBrowser using
2883         GtkPopover when the GTK+ version is recent enough.
2884         And a test case to check the new color chooser API.
2885
2886         * MiniBrowser/gtk/BrowserWindow.c:
2887         (colorChooserRGBAChanged):
2888         (popoverColorClosed):
2889         (colorChooserRequestFinished):
2890         (runColorChooserCallback):
2891         (browserWindowConstructed):
2892         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2893         (testWebViewColorChooserRequest):
2894         (beforeAll):
2895
2896 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2897
2898         Make run-jsc-stress-tests --remote work with make-based runner
2899         https://bugs.webkit.org/show_bug.cgi?id=141079
2900
2901         Reviewed by Darin Adler.
2902
2903         * Scripts/run-javascriptcore-tests:
2904         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2905         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2906         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2907         to avoid code duplication.
2908
2909 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2910
2911         run-jsc-stress tests should detect the number of processors on the remote machine too
2912         https://bugs.webkit.org/show_bug.cgi?id=141196
2913
2914         Reviewed by Darin Adler.
2915
2916         * Scripts/run-javascriptcore-tests:
2917         (runJSCStressTests): Pass through the --child-processes argument.
2918         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2919         to detect the number of local and remote processors with the same algorithm.
2920         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2921         same as $numProcessors.
2922
2923 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2924
2925         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2926         https://bugs.webkit.org/show_bug.cgi?id=141164
2927
2928         Reviewed by Darin Adler.
2929
2930         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2931
2932         * Scripts/run-jsc-stress-tests:
2933
2934 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2935
2936         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2937         https://bugs.webkit.org/show_bug.cgi?id=141392
2938
2939         Reviewed by Gustavo Noronha Silva.
2940
2941         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2942
2943         * Scripts/webkitperl/FeatureList.pm:
2944
2945 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2946
2947         run-jsc-stress-tests shell test runner should run tests in fixed order
2948         https://bugs.webkit.org/show_bug.cgi?id=141383
2949
2950         Reviewed by Darin Adler.
2951
2952         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2953
2954 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2955
2956         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2957         https://bugs.webkit.org/show_bug.cgi?id=140485
2958
2959         Reviewed by Anders Carlsson.
2960
2961         Implement takeFocus() as a way to set focus through accessibility wrappers.
2962
2963         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2964         (AccessibilityUIElement::takeFocus):
2965         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2966         (WTR::AccessibilityUIElement::takeFocus):
2967
2968 2015-02-08  Darin Adler  <darin@apple.com>
2969
2970         Remove the SVG instance tree
2971         https://bugs.webkit.org/show_bug.cgi?id=140602
2972
2973         Reviewed by Dean Jackson.
2974
2975         * Scripts/check-for-global-initializers: Removed special case for
2976         SVGElementInstance.o.
2977
2978 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2979
2980         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2981         <http://webkit.org/b/141365>
2982
2983         Reviewed by Daniel Bates.
2984
2985         * Scripts/webkitpy/xcode/simulator.py:
2986         (Simulator): Add unavailable_version_re precompiled regex.
2987         (Simulator._parse_devices): Check for unavailable versions and
2988         ignore them if found when parsing the output of
2989         `xcrun simctl list`.
2990         * Scripts/webkitpy/xcode/simulator_unittest.py:
2991         (test_unavailable_devices): Add test with output from
2992         `xcrun simctl list` with unavailable runtimes that fails before
2993         the fix.
2994
2995 2015-02-07  Chris Dumez  <cdumez@apple.com>
2996
2997         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2998         https://bugs.webkit.org/show_bug.cgi?id=141321
2999
3000         Reviewed by Darin Adler.
3001
3002         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
3003
3004 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3005
3006         [iOS] Make Simulator class testable
3007         <http://webkit.org/b/141358>
3008
3009         Rubber-stamped by Darin Adler.
3010
3011         * Scripts/webkitpy/common/system/platforminfo.py:
3012         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
3013         command to here from Simulator.refresh() in xcode/simulator.py
3014         so that the output of the command can be mocked.
3015
3016         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3017         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
3018         to None.
3019         (MockPlatformInfo.xcode_simctl_list): Add method that returns
3020         self.expected_xcode_simctl_list expectation.
3021
3022         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
3023         and license header.
3024         (Simulator.__init__): Add optional 'host' parameter to make it
3025         possible to pass in a mock object for testing.  Set self._host
3026         to 'host' parameter or create Host() object.
3027         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
3028         method.
3029
3030         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
3031         for current code.
3032         (SimulatorTest):
3033         (SimulatorTest.setUp):
3034         (SimulatorTest._set_expected_xcrun_simctl_list):
3035         (SimulatorTest.test_simulator_device_types):
3036         (test_invalid_device_types_header):
3037         (test_invalid_runtimes_header):
3038         (test_invalid_devices_header):
3039
3040 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
3041
3042         run-jsc-stress-tests --remote should use the default ssh port
3043         https://bugs.webkit.org/show_bug.cgi?id=141287
3044
3045         Reviewed by Darin Adler.
3046
3047         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
3048
3049 2015-02-06  Dana Burkart  <dburkart@apple.com>
3050
3051         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
3052         https://bugs.webkit.org/show_bug.cgi?id=141349
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3057         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3058         (BuildbotTesterQueueView.prototype.update):
3059
3060 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
3061
3062         Report network process crashes during layout tests
3063         https://bugs.webkit.org/show_bug.cgi?id=139646
3064
3065         Reviewed by Anders Carlsson.
3066
3067         * WebKitTestRunner/TestController.cpp:
3068         (WTR::TestController::initialize):
3069         (WTR::TestController::networkProcessName):
3070         (WTR::TestController::networkProcessDidCrash):
3071         * WebKitTestRunner/TestController.h:
3072
3073 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
3074
3075         run-jsc-stress-tests --remote should create remote directory before copying the bundle
3076         https://bugs.webkit.org/show_bug.cgi?id=141329
3077
3078         Reviewed by Michael Saboff.
3079
3080         * Scripts/run-jsc-stress-tests:
3081
3082 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3083
3084         [GTK] Remove WebKitWebView::close-notification signal
3085         https://bugs.webkit.org/show_bug.cgi?id=141330
3086
3087         Reviewed by Gustavo Noronha Silva.
3088
3089         Update notifications unit tests according to the API changes, and
3090         add a test case to check that onclose event is fired when a
3091         notification is closed by the user.
3092
3093         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3094         (testWebViewNotification):
3095
3096 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3097
3098         Dashboard doesn't consider building ASan a productive step
3099         https://bugs.webkit.org/show_bug.cgi?id=141312
3100
3101         Reviewed by Simon Fraser.
3102
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3104
3105 2015-02-05  Daniel Bates  <dabates@apple.com>
3106
3107         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
3108         https://bugs.webkit.org/show_bug.cgi?id=141306
3109
3110         Reviewed by Alexey Proskuryakov.
3111
3112         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
3113         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
3114         existent runtime.
3115
3116         * Scripts/webkitpy/xcode/simulator.py:
3117         (Runtime.from_identifier):
3118
3119 2015-02-05  Daniel Bates  <dabates@apple.com>
3120
3121         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
3122         https://bugs.webkit.org/show_bug.cgi?id=139746
3123         <rdar://problem/19283658>
3124
3125         Reviewed by Alexey Proskuryakov.
3126
3127         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
3128         if the simulator device is not in state Booted.
3129
3130         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
3131         launching/relaunching the iOS Simulator app and a simulator app can only be installed
3132         on a device that is in the Booted state. LayoutTestRelay may run before the
3133         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
3134         We should defer executing LayoutTestRelay until the simulator device booted by
3135         iOS Simulator is in the Booted state.
3136
3137         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
3138         Simulator methods with the module name, simulator.
3139         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
3140         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
3141         before launching iOS Simulator to boot it.
3142         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
3143         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3144         * Scripts/webkitpy/xcode/simulator.py:
3145         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3146         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3147         interested in the state of the device are more likely interested in the current state of the device as
3148         opposed to the state of the device when the Device object was created.
3149         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3150         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3151         from both this function and Simulator.device_state().
3152         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3153         (Simulator.DeviceState): Added; class of constants.
3154         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3155         device is in the specified state.
3156         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3157         (Simulator.device_directory): Added.
3158         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3159
3160 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3161
3162         Disable retries on Mac debug testers
3163         https://bugs.webkit.org/show_bug.cgi?id=141296
3164
3165         Reviewed by Simon Fraser.
3166
3167         * BuildSlaveSupport/build.webkit.org-config/config.json:
3168
3169 2015-02-05  Dan Bernstein  <mitz@apple.com>
3170
3171         Need a way to force $xcodeSDK in webkitdirs.pm
3172         https://bugs.webkit.org/show_bug.cgi?id=141291
3173
3174         Reviewed by Anders Carlsson.
3175
3176         * Scripts/webkitdirs.pm:
3177         (setXcodeSDK): Added.
3178
3179 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3180
3181         [Streams API] Implement a barebone ReadableStream interface
3182         https://bugs.webkit.org/show_bug.cgi?id=141045
3183
3184         Reviewed by Benjamin Poulain.
3185
3186         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3187
3188 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
3189
3190         filter-build-webkit: reduce more unfiltered output
3191         https://bugs.webkit.org/show_bug.cgi?id=141282
3192
3193         Reviewed by Daniel Bates.
3194
3195         * Scripts/filter-build-webkit:
3196         Report CompileDTraceScript and Preprocess lines as successful.
3197
3198 2015-02-04  Dana Burkart  <dburkart@apple.com>
3199
3200         Botwatcher's Dashboard is cramped
3201         https://bugs.webkit.org/show_bug.cgi?id=140273
3202
3203         Reviewed by Alexey Proskuryakov.
3204
3205         Add a heading key which will allow for arbitrary headings in builder queues.
3206
3207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3208         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3209         (BuildbotBuilderQueueView.prototype.update):
3210         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3212         (BuildbotIteration.prototype._parseData):
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3214         (BuildbotLeaksQueueView.prototype.update):
3215         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3217         (BuildbotPerformanceQueueView.prototype.update):
3218         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3220         (BuildbotQueue):
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3222         (BuildbotQueueView.prototype._unauthorizedAccess):
3223         (BuildbotQueueView.prototype._appendBuild):
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3225         (BuildbotTestResults):
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3227         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3228         (BuildbotTesterQueueView.prototype.update):
3229         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
3230
3231 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3232
3233         WKTR should not use -mainScreen to pick a color profile
3234         https://bugs.webkit.org/show_bug.cgi?id=141265
3235
3236         Reviewed by Tim Horton.
3237         
3238         -[NSScreen mainScreen] depends on the active window, so use the first screen
3239         (which is the one we put the window on anyway).
3240         
3241         Do some cleanup in DRT that makes the code look similar.
3242
3243         * DumpRenderTree/mac/DumpRenderTree.mm:
3244         (createWebViewAndOffscreenWindow):
3245         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3246         (WTR::PlatformWebView::PlatformWebView):
3247
3248 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3249
3250         LayoutTestHelper should set the color profile of all displays
3251         https://bugs.webkit.org/show_bug.cgi?id=141260
3252
3253         Reviewed by Tim Horton.
3254         
3255         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
3256         which is the screen with the active window. Make things more robust by changing
3257         the colorspace of all displays, not just the main screen, when running layout tests.
3258
3259         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
3260         * DumpRenderTree/mac/LayoutTestHelper.m: 
3261         (originalColorProfileURLs):
3262         (colorProfileURLForDisplay):
3263         (displayUUIDStrings):
3264         (saveDisplayColorProfiles):
3265         (setDisplayColorProfile):
3266         (restoreDisplayColorProfiles):
3267         (installLayoutTestColorProfile):
3268         (restoreUserColorProfile):
3269         (main):        
3270         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
3271         toll-free bridged, sadly). Use the map to restore all profiles on exit.
3272         Convert to use more Obj-C types.
3273
3274 2015-02-04  Daniel Bates  <dabates@apple.com>
3275
3276         test-webkitpy fails on Mac without iphoneos SDK
3277         https://bugs.webkit.org/show_bug.cgi?id=141255
3278         <rdar://problem/19619691>
3279
3280         I inadvertently committed the wrong exception message. Fix up the exception message
3281         to instruct a person to install the iOS SDK when it cannot be found.
3282
3283         * Scripts/webkitpy/port/ios.py:
3284         (IOSPort.determine_full_port_name):
3285
3286 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3287
3288         W3C test importer should sort the list of files when generating the w3c-import.log
3289         https://bugs.webkit.org/show_bug.cgi?id=141156
3290
3291         Reviewed by Bem Jones-Bey.
3292
3293         Sort explicitly the list of imported files written in the w3c-import.log.
3294         Removed logging of the import date.
3295
3296         * Scripts/webkitpy/w3c/test_importer.py:
3297         (TestImporter.write_import_log):
3298
3299 2015-02-04  Daniel Bates  <dabates@apple.com>
3300
3301         test-webkitpy fails on Mac without iphoneos SDK
3302         https://bugs.webkit.org/show_bug.cgi?id=141255
3303         <rdar://problem/19619691>
3304
3305         Reviewed by David Kilzer and Alexey Proskuryakov.
3306
3307         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
3308         should not require the iphoneos SDK to be installed to run the webkitpy tests.
3309
3310         * Scripts/webkitpy/common/system/platforminfo.py:
3311         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
3312         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
3313         to standard output if the SDK is installed to return the empty string if the SDK is
3314         not installed.
3315         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3316         (MockPlatformInfo.xcode_sdk_version): Added.
3317         * Scripts/webkitpy/port/ios.py:
3318         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
3319         to get the version of the iphoneos SDK, if installed.
3320
3321 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3322
3323         run-webkit-tests doesn't always capture ASan violation reports
3324         https://bugs.webkit.org/show_bug.cgi?id=141231
3325
3326         Reviewed by Darin Adler.
3327
3328         * Scripts/webkitpy/port/driver.py:
3329         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
3330         by the driver already (as is the case with ASan violations, which are printed to
3331         stderr).
3332         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
3333         report.
3334         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
3335         a separate variable for reporting.
3336
3337 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3338
3339         [webkitpy] Add platform specific Skipped file mechanism for performance tests
3340         https://bugs.webkit.org/show_bug.cgi?id=141152
3341
3342         Reviewed by Csaba Osztrogonác.
3343
3344         Support a test-expectation-like syntax in performance tests' skipped files.
3345         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
3346
3347         * Scripts/webkitpy/port/base.py:
3348         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3349
3350         * Scripts/webkitpy/port/base_unittest.py:
3351         (PortTest.test_skipped_perf_tests): Test the new syntax.
3352
3353 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3354
3355         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3356         https://bugs.webkit.org/show_bug.cgi?id=141236
3357
3358         Reviewed by Sam Weinig.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3361         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3362
3363 2015-02-04  Chris Dumez  <cdumez@apple.com>
3364
3365         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3366         https://bugs.webkit.org/show_bug.cgi?id=141192
3367
3368         Reviewed by Benjamin Poulain.
3369
3370         Add API tests for Vector::removeFirst(value) and
3371         Vector::removeAll(value).
3372
3373         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3374         (TestWebKitAPI::TEST):
3375
3376 2015-02-03  Tim Horton  <timothy_horton@apple.com>
3377
3378         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3379         https://bugs.webkit.org/show_bug.cgi?id=141217
3380
3381         Reviewed by Sam Weinig.
3382
3383         * WebKitTestRunner/TestController.cpp:
3384         (WTR::copyWebCryptoMasterKey):
3385         (WTR::TestController::createOtherPage):
3386         (WTR::TestController::createWebViewWithOptions):
3387         (WTR::TestController::ensureViewSupportsOptions):
3388         (WTR::TestController::didCommitNavigation):
3389         (WTR::TestController::didFinishNavigation):
3390         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3391         (WTR::TestController::didReceiveAuthenticationChallenge):
3392         (WTR::TestController::decidePolicyForPluginLoad):
3393         (WTR::TestController::decidePolicyForNavigationAction):
3394         (WTR::TestController::decidePolicyForNavigationResponse):
3395         (WTR::TestController::didCommitLoadForFrame): Deleted.
3396         (WTR::TestController::didFinishLoadForFrame): Deleted.
3397         * WebKitTestRunner/TestController.h:
3398         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3399
3400 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
3401
3402         Unreviewed. Add myself as a committer.
3403
3404         * Scripts/webkitpy/common/config/contributors.json:
3405
3406 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3407
3408         [Win] Unreviewed test fix.
3409
3410         * DumpRenderTree/win/PolicyDelegate.cpp:
3411         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3412         so was not matching expected output.
3413
3414 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3415
3416         Unreviewed. Moving myself to the committer section at last.
3417
3418         * Scripts/webkitpy/common/config/contributors.json:
3419
3420 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3421
3422         [Win] Tests fail because DRT reports '(null)' instead of an empty string
3423         https://bugs.webkit.org/show_bug.cgi?id=141205
3424
3425         Reviewed by Anders Carlsson.
3426
3427         * DumpRenderTree/win/HistoryDelegate.cpp:
3428         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3429         properly so that we match expected DumpRenderTree output.
3430
3431 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3432
3433         [GTK] TestWebKitAccessibility is not skipped
3434         https://bugs.webkit.org/show_bug.cgi?id=141179
3435
3436         Reviewed by Carlos Garcia Campos.
3437
3438         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3439         skipped, and it apparently works reliably on the bots.
3440
3441         * Scripts/run-gtk-tests:
3442         (TestRunner):
3443
3444 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3445
3446         run-perf-tests: allow to specify a wrapper command.
3447         https://bugs.webkit.org/show_bug.cgi?id=141172
3448
3449         Reviewed by Ryosuke Niwa.
3450
3451         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3452         (parse_args): Update text to indicate is also valid for WTR.
3453         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3454         (PerfTestsRunner._parse_args): Add wrapper command.
3455
3456 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3457
3458         [Win] Correct version parsing warning in update-webkit
3459         https://bugs.webkit.org/show_bug.cgi?id=141200
3460
3461         Reviewed by Anders Carlsson.
3462
3463         * Scripts/webkitdirs.pm:
3464         (setupAppleWinEnv): Strip out any specific version build level
3465         from the Cygwin version information.
3466   
3467
3468 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3469
3470         [Win] Attempt to improve the reliability of HTTP service
3471         https://bugs.webkit.org/show_bug.cgi?id=141191
3472
3473         Reviewed by Darin Adler.
3474
3475         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3476         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3477         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3478         when stopping the service doesn't do so on its own (for Windows runs).
3479
3480 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3481
3482         Web platform test server should not need to create __init__.py files
3483         https://bugs.webkit.org/show_bug.cgi?id=141030
3484
3485         Reviewed by Ryosuke Niwa.
3486
3487         W3C TestImporter ensures that copied __init__.py files are not empty.
3488         If needed, a comment is inserted in __init__.py files.
3489         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3490
3491         * Scripts/webkitpy/common/system/filesystem.py:
3492         (FileSystem.getsize):
3493         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3494         (TestWebPlatformTestServer.test_start_cmd):
3495         (TestWebPlatformTestServer):
3496         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3497         * Scripts/webkitpy/w3c/test_importer.py:
3498         (TestImporter.import_tests):
3499
3500 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3501
3502         Unreviewed. Moving myself to the committer section.
3503
3504         * Scripts/webkitpy/common/config/contributors.json:
3505
3506 2015-02-02  Saam Barati  <saambarati1@gmail.com>
3507
3508         Create tests for JSC's Control Flow Profiler
3509         https://bugs.webkit.org/show_bug.cgi?id=141123
3510
3511         Reviewed by Filip Pizlo.
3512
3513         * Scripts/run-javascriptcore-tests:
3514         (runJSCStressTests):
3515         * Scripts/run-jsc-stress-tests:
3516
3517 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
3518
3519         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3520         https://bugs.webkit.org/show_bug.cgi?id=141158
3521
3522         Reviewed by Darin Adler.
3523
3524         * Scripts/run-jsc-stress-tests:
3525
3526 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3527
3528         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3529         https://bugs.webkit.org/show_bug.cgi?id=141142
3530
3531         Reviewed by Carlos Garcia Campos.
3532
3533         * MiniBrowser/gtk/BrowserWindow.c:
3534         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3535
3536 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3537
3538         Web platform test server is not always launching properly on Mac EWS bots
3539         https://bugs.webkit.org/show_bug.cgi?id=141141
3540
3541         Unreviewed.
3542
3543         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3544         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3545
3546 2015-01-31  Sam Weinig  <sam@webkit.org>
3547
3548         Remove even more Mountain Lion support
3549         https://bugs.webkit.org/show_bug.cgi?id=141124
3550
3551         Reviewed by Alexey Proskuryakov.
3552
3553         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3554         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3555         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3556         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3557         * DumpRenderTree/mac/DumpRenderTree.mm:
3558         (activateTestingFonts):
3559         (prepareConsistentTestingEnvironment):
3560         * DumpRenderTree/mac/EventSendingController.mm:
3561         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3562         (-[EventSendingController contextClick]):
3563         * DumpRenderTree/mac/TextInputController.m:
3564         * LayoutTestRelay/Configurations/Base.xcconfig:
3565         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3566         * MiniBrowser/Configurations/Base.xcconfig:
3567         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3568         * MiniBrowser/mac/WK2BrowserWindowController.m:
3569         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3570         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3571         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3572         * TestWebKitAPI/Configurations/Base.xcconfig:
3573         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3574         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3575         (-[DownloadDelegate _downloadDidFinish:]):
3576         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3577         (TestWebKitAPI::TEST):
3578         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3579         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3580         * WebKitLauncher/Configurations/Base.xcconfig:
3581         * WebKitTestRunner/Configurations/Base.xcconfig:
3582         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3583         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3584         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3585         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3586         (WTR::activateFonts):
3587         * WebKitTestRunner/TestController.cpp:
3588         (WTR::TestController::initialize):
3589         (WTR::TestController::webProcessName):
3590         * WebKitTestRunner/mac/EventSenderProxy.mm:
3591         * asan/asan.xcconfig:
3592
3593 2015-01-31  Commit Queue  <commit-queue@webkit.org>
3594
3595         Unreviewed, rolling out r179408.
3596         https://bugs.webkit.org/show_bug.cgi?id=141117
3597
3598         This didn't fully fix the issue (Requested by anttik on
3599         #webkit).
3600
3601         Reverted changeset:
3602
3603         "OSObjectPtr does not work with dispatch_data_t on Maverics"
3604         https://bugs.webkit.org/show_bug.cgi?id=141081
3605         http://trac.webkit.org/changeset/179408
3606
3607 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3608
3609         https://trac.webkit.org/changeset/179439 breaks a python test
3610         https://bugs.webkit.org/show_bug.cgi?id=141114
3611
3612         Unreviewed.
3613
3614         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3615         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
3616
3617 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3618
3619         Import W3C web platform tests infrastructure
3620         https://bugs.webkit.org/show_bug.cgi?id=140934
3621
3622         Reviewed by Ryosuke Niwa.
3623
3624         Loading necessary web platform tests modules before launching server.
3625         Ensuring that some empty __init__.py files are present and create them if necessary. 
3626
3627         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3628         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3629
3630 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3631
3632         [Win] Another unreviewed test fix.
3633
3634         Correct copy/paste error in buildbot handling.
3635
3636         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3637         (LayoutTestApacheHttpd.__init__):
3638         (LayoutTestApacheHttpd._get_apache_config_file_path):
3639
3640 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3641
3642         [Win] Unreviewed test fix.
3643
3644         Correct path handling based on failures on test bots to get things running again.
3645
3646         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3647         (LayoutTestApacheHttpd.__init__):
3648         (LayoutTestApacheHttpd._get_apache_config_file_path):
3649
3650 2015-01-30  Chris Dumez  <cdumez@apple.com>
3651
3652         Unreviewed. Fix Windows build after r179409.
3653
3654         * DumpRenderTree/win/TestRunnerWin.cpp:
3655         (TestRunner::notifyDone):
3656         (TestRunner::queueLoad):
3657
3658 2015-01-30  Chris Dumez  <cdumez@apple.com>
3659
3660         Rename shared() static member functions to singleton() for singleton classes.
3661         https://bugs.webkit.org/show_bug.cgi?id=141088
3662
3663         Reviewed by Ryosuke Niwa and Benjamin Poulain.
3664