[EFL] css3/device-adapt/* tests failed after r190335.
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2
3         [EFL] css3/device-adapt/* tests failed after r190335.
4         https://bugs.webkit.org/show_bug.cgi?id=149655
5
6         Reviewed by Simon Fraser.
7
8         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
9         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
10
11         * WebKitTestRunner/efl/TestControllerEfl.cpp:
12         (WTR::shouldUseFixedLayout):
13
14 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
15
16         Extend JetStream timeout for slow devices.
17
18         Reviewed by Chris Dumez.
19
20         Extend JetStream timeout to 20 minutes.
21
22         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
23
24 2015-09-30  Daniel Bates  <dabates@apple.com>
25
26         Rename iOS builders/testers to include version
27         https://bugs.webkit.org/show_bug.cgi?id=149685
28
29         Reviewed by Simon Fraser.
30
31         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
32         make it clear to a reader the version of iOS these builders/testers are using.
33
34         * BuildSlaveSupport/build.webkit.org-config/config.json:
35         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
36
37 2015-09-30  Daniel Bates  <dabates@apple.com>
38
39         Add iOS criterion for triggering a build
40         https://bugs.webkit.org/show_bug.cgi?id=149679
41
42         Rubber-stamped by Alexey Proskuryakov.
43
44         First pass at defining criterion for triggering an iOS build.
45
46         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
47         (_should_file_trigger_build):
48         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
49         (ShouldBuildTest):
50         (ShouldBuildTest.test_should_build):
51
52 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
53
54         [iOS] Allow tests to generate user gestures for UI testing
55         https://bugs.webkit.org/show_bug.cgi?id=149653
56
57         Reviewed by Tim Horton.
58
59         Expose functionality in UIScriptController to allow for testing single- and double-tap,
60         and to listen for completion of scrolling and zooming in the WKWebView.
61         
62         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
63         which hides the complexity of creating these events. Event dispatch is asynchronous.
64         We detect when the last event has been handled by dispatching a vendor-specific event,
65         which is detected via -_handleHIDEvent: in our UIApplication subclass.
66         
67         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
68         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
69         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
70         single and double taps.
71         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
72         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
73         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
74         (UIScriptContext::unregisterCallback):
75         (UIScriptContext::callbackWithID):
76         (UIScriptContext::fireCallback):
77         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
78         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
79         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
80         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
81         (WTR::UIScriptController::setDidEndZoomingCallback):
82         (WTR::UIScriptController::didEndZoomingCallback):
83         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
84         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
85         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
86         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
87         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
88         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
89         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
90         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
91         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
92         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
93         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
94         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
95         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
96         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
97         (simpleDragCurve):
98         (calculateNextLocation):
99         (delayBetweenMove):
100         (+[HIDEventGenerator sharedHIDEventGenerator]):
101         (+[HIDEventGenerator nextEventCallbackID]):
102         (-[HIDEventGenerator init]):
103         (-[HIDEventGenerator _createIOHIDEventType:]):
104         (-[HIDEventGenerator _sendHIDEvent:]):
105         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
106         (-[HIDEventGenerator _updateTouchPoints:count:]):
107         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
108         (-[HIDEventGenerator touchDown:touchCount:]):
109         (-[HIDEventGenerator touchDown:]):
110         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
111         (-[HIDEventGenerator liftUp:touchCount:]):
112         (-[HIDEventGenerator liftUp:]):
113         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
114         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
115         (-[HIDEventGenerator tap:completionBlock:]):
116         (-[HIDEventGenerator doubleTap:completionBlock:]):
117         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
118         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
119         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
120         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
121         (-[HIDEventGenerator markerEventReceived:]):
122         * WebKitTestRunner/ios/IOKitSPI.h: Added.
123         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
124         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
125         (WTR::globalToContentCoordinates):
126         (WTR::UIScriptController::singleTapAtPoint):
127         (WTR::UIScriptController::doubleTapAtPoint):
128         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
129         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
130         * WebKitTestRunner/ios/mainIOS.mm:
131         (-[WebKitTestRunnerApp _handleHIDEvent:]):
132
133 2015-09-30  Dana Burkart  <dburkart@apple.com>
134
135         git-add-reviewer should trim trailing spaces/newlines
136         https://bugs.webkit.org/show_bug.cgi?id=149513
137
138         Reviewed by Darin Adler.
139
140         * Scripts/git-add-reviewer:
141         (nonInteractive):
142
143 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
144
145         REGRESSION(r190262): User media unit test failures after r190262
146         https://bugs.webkit.org/show_bug.cgi?id=149580
147
148         Reviewed by Darin Adler.
149
150         * WebKitTestRunner/TestController.cpp:
151         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
152           order to WKUserMediaPermissionRequestAllow.
153
154 2015-09-30  Daniel Bates  <dabates@apple.com>
155
156         Add iOS builders and testers
157         https://bugs.webkit.org/show_bug.cgi?id=149549
158
159         Reviewed by Alexey Proskuryakov.
160
161         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
162         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
163
164         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
165         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
166
167 2015-09-30  Timothy Hatcher  <timothy@apple.com>
168
169         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
170         https://bugs.webkit.org/show_bug.cgi?id=149674
171
172         Reviewed by Lucas Forschler.
173
174         * WebKitLauncher/WebKitLauncher.entitlements: Added.
175         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
176
177 2015-09-30  Jason Marcell  <jmarcell@apple.com>
178
179         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
180         have an associated trac instance.
181         https://bugs.webkit.org/show_bug.cgi?id=149673
182
183         Reviewed by Alexey Proskuryakov.
184
185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
186         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
187         have an associated trac instance.
188
189 2015-09-30  Daniel Bates  <dabates@apple.com>
190
191         Prioritize testing latest build request on iOS test bots
192         https://bugs.webkit.org/show_bug.cgi?id=149669
193
194         Reviewed by Darin Adler.
195
196         We should prioritize testing of the latest build request on the iOS test bots
197         as we do for Mac and Windows test bots.
198
199         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
200         (loadBuilderConfig):
201
202 2015-09-30  Daniel Bates  <dabates@apple.com>
203
204         Add buildbot category for iOS builders and testers
205         https://bugs.webkit.org/show_bug.cgi?id=149667
206
207         Reviewed by Darin Adler.
208
209         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
210         for iOS to the build.webkit.org home page.
211
212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
213         (loadBuilderConfig):
214         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
215
216 2015-09-30  Daniel Bates  <dabates@apple.com>
217
218         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
219         (https://bugs.webkit.org/show_bug.cgi?id=149539)
220
221         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
222         in <http://trac.webkit.org/changeset/190351>.
223
224         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
225         (CompileWebKit.start):
226
227 2015-09-30  Daniel Bates  <dabates@apple.com>
228
229         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
230         (https://bugs.webkit.org/show_bug.cgi?id=149539)
231
232         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
233         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
234
235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
236         (CompileWebKit.start):
237
238 2015-09-30  Lucas Forschler  <lforschler@apple.com>
239
240         bot210 was configured for a queue instead of bot126.
241         
242         Unreviewed config.json fix.
243         
244         * BuildSlaveSupport/build.webkit.org-config/config.json:
245
246 2015-09-30  Lucas Forschler  <lforschler@apple.com>
247
248         Bring El Capitan buildbot infrastructure online.
249         https://bugs.webkit.org/show_bug.cgi?id=149605
250         
251         Reviewed by Darin Adler.
252
253         * BuildSlaveSupport/build.webkit.org-config/config.json:
254
255 2015-09-30  Tomas Popela  <tpopela@redhat.com>
256
257         [GTK] Deprecation warnings in DOMNodeTest
258         https://bugs.webkit.org/show_bug.cgi?id=149663
259
260         After the webkit_dom_document_get_elements_by_tag_name deprecation we
261         need to update the tests to use webkit_dom_document_query_selector_all
262         to avoid compilation warnings.
263
264         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
265         (the suggested replacement for the deprecated function).
266
267         Reviewed by Carlos Garcia Campos.
268
269         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
270         (WebKitDOMNodeTest::testTagNamesNodeList):
271         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
272         (registerTests):
273         (WebKitDOMNodeTest::testTagNames): Deleted.
274         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
275         (prepareDOMForTagNamesTests):
276         (testWebKitDOMNodeTagNamesNodeList):
277         (testWebKitDOMNodeTagNamesHTMLCollection):
278         (beforeAll):
279         (testWebKitDOMNodeTagNames): Deleted.
280
281 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
282
283         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
284         https://bugs.webkit.org/show_bug.cgi?id=149650
285
286         Reviewed by Tim Horton.
287         
288         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
289         looks at the file path, and not the custom options that come from file comments.
290         
291         Fix by computing TestOptions before making the TestInvocation, and setting them
292         as const TestInvocation data. This meant changing various call sites to take
293         the std::string pathOrURL, rather than the TestInvocation itself.
294         
295         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
296
297         * WebKitTestRunner/CMakeLists.txt:
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::ensureViewSupportsOptionsForTest):
300         (WTR::testPath):
301         (WTR::createTestURL):
302         (WTR::updateTestOptionsFromTestHeader):
303         (WTR::TestController::testOptionsForTest):
304         (WTR::TestController::updateWebViewSizeForTest):
305         (WTR::TestController::updateWindowScaleForTest):
306         (WTR::TestController::runTest):
307         * WebKitTestRunner/TestController.h:
308         * WebKitTestRunner/TestInvocation.cpp:
309         (WTR::TestInvocation::TestInvocation):
310         (WTR::TestInvocation::invoke):
311         (WTR::createWKURL): Deleted.
312         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
313         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
314         * WebKitTestRunner/TestInvocation.h:
315         (WTR::TestInvocation::options):
316         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
317         (WTR::pathContains):
318         (WTR::shouldMakeViewportFlexible):
319         (WTR::shouldUseFixedLayout):
320         (WTR::isSVGTestPath):
321         (WTR::isHiDPITestPath):
322         (WTR::TestOptions::TestOptions):
323         * WebKitTestRunner/TestOptions.h:
324         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
325         * WebKitTestRunner/efl/TestControllerEfl.cpp:
326         (WTR::pathContains):
327         (WTR::shouldUseFixedLayout):
328         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
329         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
330         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
331         * WebKitTestRunner/ios/TestControllerIOS.mm:
332         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
333         * WebKitTestRunner/mac/TestControllerMac.mm:
334         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
335
336 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
337
338         Flakiness dashboard should support OS X El Capitan
339         https://bugs.webkit.org/show_bug.cgi?id=149648
340
341         Reviewed by Alexey Proskuryakov.
342
343         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
344         difference between new appscale and old Google App Engine implementation.
345         * TestResultServer/app.yaml: Same.
346         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
347
348 2015-09-29  Daniel Bates  <dabates@apple.com>
349
350         configure-xcode-for-ios-development does not work with Xcode 7
351         https://bugs.webkit.org/show_bug.cgi?id=149640
352
353         Reviewed by Alexey Proskuryakov.
354
355         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
356         because it cannot find the Xcode specification files for iOS simulator and device. These
357         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
358         relevant definitions to the Xcode 7 specification files directly as opposed to creating
359         new specification files with the added definitions (as we did in older versions of Xcode)
360         in order for Xcode 7 to honor these definitions.
361
362         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
363         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
364         (updateXcode7SpecificationFile): Added.
365         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
366         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
367         appropriate success message.
368         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
369         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
370         (createXcodeSpecificationFromSpecificationAndId): Deleted.
371
372 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
373
374         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
375         https://bugs.webkit.org/show_bug.cgi?id=149639
376
377         Reviewed by Alex Christensen.
378
379         * Scripts/VCSUtils.pm:
380         (exitStatus): Use 'isWindows()' method.
381         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
382         an error. This method could probably just go away.
383         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
384         always changing to Unix style. 
385         (unixPath): Added. Needed so Windows can always show a Unix path in the
386         ChangeLog file.
387         (changeLogName): Work around the fact that 'getpwuid' is not available on
388         a pure Windows build of Perl.
389         * Scripts/prepare-ChangeLog:
390         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
391         path on Windows.
392         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
393         support using arrays for 'open' arguments.
394         (resolveChangeLogsPath): Ditto.
395         (resolveConflictedChangeLogs): Use new helper functions.
396         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
397         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
398         quotes. Unix systems are happy either way.
399         (statusCommand): Ditto.
400         * Scripts/webkitdirs.pm:
401         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
402
403 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
404
405         [Win] Unreviewed 64-bit build fix after switch to CMake.
406
407         * Scripts/webkitdirs.pm:
408         (determineIsWin64FromArchitecture): Added.
409
410 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
411
412         printing does not use minimum page zoom factor
413         https://bugs.webkit.org/show_bug.cgi?id=108507
414
415         Reviewed by Darin Adler.
416
417         WebKitTestRunner always takes the snapshots from the UI process
418         (expect for IOS), so in the case of printing, the layout in the
419         web view is not the expected one. When printing, we need to take
420         the snapshot in the web process and ensure it's rendered with a
421         PrintContext.
422
423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
424         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
425         kWKSnapshotOptionsPrinting option to
426         WKBundlePageCreateSnapshotWithOptions() when printing.
427
428 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
429
430         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
431         https://bugs.webkit.org/show_bug.cgi?id=149595
432
433         Reviewed by Tim Horton.
434
435         All ports except IOS implement
436         PlatformWebView::windowSnapshotImage() to generate the snapshot
437         for the pixel tests in the UI process. But we are still generating
438         a snapshot for pixel tests in the Web process too, that is passed
439         to the UI process but ignored.
440         Whether a pixel result is needed or not, is only known by the web
441         process depending on whether the test called dumpAsText with
442         dumpPixels == true or not. Since the pixels are now dump in the UI
443         process, we need to pass that information to the UI process when
444         the test is done. For that we set a PixelResultIsPending bool
445         parameter to the Done message, and we only add the PixelResult
446         when UI process doesn't need to generate the pixels dump.
447
448         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
449         (WTR::InjectedBundle::didReceiveMessageToPage): Set
450         m_pixelResultIsPending to false on reset.
451         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
452         Done message, and set the PixelResult if m_pixelResultIsPending is false.
453         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
454         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
455         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
457         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
458         port.
459         * WebKitTestRunner/TestInvocation.cpp:
460         (WTR::TestInvocation::dumpResults): Use either the pixel result
461         from the web process or generate a pixel result from the web view
462         if need it.
463         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
464         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
465         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
466         is created by the caller now, but the CG implementation needs to
467         know if it's a Web or UI process snapshot.
468         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
469         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
470         cairo surface for the given image.
471         * WebKitTestRunner/cg/TestInvocationCG.cpp:
472         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
473         CGContext for the given image.
474
475 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
476
477         Fix JS errors on dashboard metrics page
478         https://bugs.webkit.org/show_bug.cgi?id=149608
479
480         Reviewed by Alexey Proskuryakov.
481
482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
483         (initPlatformsByFamily): 
484         (updateHiddenPlatforms):
485         (parsePlatformFamily): Deleted.
486         (updateToggleButtons): Deleted.
487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
488         (updateHiddenPlatforms): Added to remove errors.
489         (initPlatformsByFamily): Added to remove errors.
490         (unhiddenQueues): Updated to use Settings.
491         (documentReady): Added logic to add toggle buttons to the settings menu.
492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
493         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
494         MetricsMain.js to Settings.
495         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
496         MetricsMain.js to Settings.
497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
498         (QueueView.prototype._updateHiddenState): Updated to use Settings.
499
500 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
501
502         Appscale query fails because of missing index
503         https://bugs.webkit.org/show_bug.cgi?id=149609
504
505         Reviewed by Darin Adler.
506
507         * QueueStatusServer/index.yaml: Added the required index.
508
509 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
510
511         [Win] Fix the 64-bit build after switch to cmake.
512
513         Reviewed by Alex Christensen.
514
515         * Scripts/webkitdirs.pm:
516         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
517         run a 64-bit build.
518
519 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
520
521         [Win] Allow Windows to run test-webkitpy without Cygwin
522         https://bugs.webkit.org/show_bug.cgi?id=149602
523
524         Reviewed by Alex Christensen.
525
526         These changes mostly shift from hard-coded paths using UNIX-style
527         separators to Python's "os.path.join" syntax that uses the correct
528         path separator for each platform.
529         
530         * Scripts/webkitpy/common/system/path.py:
531         (cygpath): Don't pass paths through Cygpath on native Windows.
532         * Scripts/webkitpy/port/win.py:
533         (WinPort._path_to_apache): Use os.path.join.
534         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
535         in 64-bit environments).
536         * Scripts/webkitpy/style/checker.py: Use os.path.join.
537         * Scripts/webkitpy/style/checker_unittest.py:
538         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
539         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
540         (GlobalVariablesTest): Ditto.
541         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
542         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
543         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
544         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
545         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
546         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
547         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
548         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
549         (StyleProcessor_CodeCoverageTest): Ditto.
550         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
551         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
552         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
553         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
554         manual string concatenation of paths.
555
556 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
557
558         Add bugzilla addresses of committers to contributors.json
559         https://bugs.webkit.org/show_bug.cgi?id=149520
560
561         Reviewed by Darin Adler.
562
563         * Scripts/webkitpy/common/config/contributors.json:
564
565 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
566
567         validate-committer-lists -b shouldn't need edituser privileges
568         https://bugs.webkit.org/show_bug.cgi?id=149519
569
570         Reviewed by Darin Adler.
571
572         * Scripts/validate-committer-lists:
573         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
574         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
575         (BugzillaQueries.is_invalid_bugzilla_email):
576         (BugzillaQueries): Deleted.
577         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
578
579 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         Unreviewed. Gardening: skip media stream tests failing after r190262.
582
583         * Scripts/run-gtk-tests:
584         (TestRunner):
585
586 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
587
588         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
589         https://bugs.webkit.org/show_bug.cgi?id=149571
590
591         Reviewed by Dan Bernstein.
592
593         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
594
595         * DumpRenderTree/mac/Configurations/Base.xcconfig:
596         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
597         * LayoutTestRelay/Configurations/Base.xcconfig:
598         * MiniBrowser/Configurations/Base.xcconfig:
599         * MiniBrowser/Configurations/DebugRelease.xcconfig:
600         * TestWebKitAPI/Configurations/Base.xcconfig:
601         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
602         * WebEditingTester/Configurations/Base.xcconfig:
603         * WebEditingTester/Configurations/DebugRelease.xcconfig:
604         * WebKitTestRunner/Configurations/Base.xcconfig:
605         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
606         * WebKitTestRunner/iOS.xcconfig: Removed.
607
608 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
609
610         Clean up user media request internal API
611         https://bugs.webkit.org/show_bug.cgi?id=149527
612
613         Reviewed by Tim Horton.
614
615         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
616         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
617
618         * WebKitTestRunner/TestController.cpp:
619         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
620
621 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
622
623         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
624         https://bugs.webkit.org/show_bug.cgi?id=149577
625
626         Reviewed by Tim Horton.
627         
628         When calling testRunner.runUIScript() from a page load event, the script could run
629         in the UI process before the current remote layer tree transaction had been handled
630         there. This meant that runUIScript() could query state which was about to change.
631         
632         Fix by delaying the execution of the UI script until a layer tree transaction has
633         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
634
635         * WebKitTestRunner/TestInvocation.cpp:
636         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
637         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
638         * WebKitTestRunner/TestInvocation.h:
639
640 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
641
642         [Mac] Media tests start to time out after a few days of bot uptime
643         https://bugs.webkit.org/show_bug.cgi?id=149468
644
645         Reviewed by Darin Adler.
646
647         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
648         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
649         all temporary and cache files go to a custom location.
650
651         * Scripts/webkitpy/port/base.py:
652         * Scripts/webkitpy/port/driver.py:
653         * Scripts/webkitpy/port/mac.py:
654         * Scripts/webkitpy/port/win.py:
655         (WinPort._driver_tempdir_for_environment): Deleted unused function.
656
657 2015-09-25  Dan Bernstein  <mitz@apple.com>
658
659         Removed MiniBrowser.entitlements.
660
661         Rubber-stamped by Anders Carlsson.
662
663         The entitlements weren’t used anyway.
664
665         * MiniBrowser/MiniBrowser.entitlements: Removed.
666         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
667
668 2015-09-24  Daniel Bates  <dabates@apple.com>
669
670         Add WebKitSystemInterface for iOS 9.0
671         https://bugs.webkit.org/show_bug.cgi?id=149550
672
673         Rubber-stamped by Alexey Proskuryakov.
674
675         * Scripts/copy-webkitlibraries-to-product-directory:
676
677 2015-09-24  Daniel Bates  <dabates@apple.com>
678
679         Support building for arbitrary architectures
680         https://bugs.webkit.org/show_bug.cgi?id=149539
681
682         Reviewed by Alexey Proskuryakov.
683
684         Teach buildbot to pass the architectures associated with the builder to build-webkit
685         when building on OS X and iOS. As a side effect of this change we now support building
686         universal binaries when multiples architectures are specified.
687
688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
689         (CompileWebKit.start):
690
691 2015-09-24  Daniel Bates  <dabates@apple.com>
692
693         Fix the build after <http://trac.webkit.org/changeset/190212>
694         (http://trac.webkit.org/changeset/190212)
695
696         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
697
698         * BuildSlaveSupport/built-product-archive:
699         (main):
700
701 2015-09-24  Daniel Bates  <dabates@apple.com>
702
703         Support running unit tests on iOS Simulator test bot
704         https://bugs.webkit.org/show_bug.cgi?id=149536
705
706         Reviewed by Alexey Proskuryakov.
707
708         Implements support for running unit tests on a iOS test bot. At the time of writing,
709         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
710
711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
712         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
713         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
714
715 2015-09-24  Daniel Bates  <dabates@apple.com>
716
717         Add support infrastructure for OpenSource iOS builders and testers
718         https://bugs.webkit.org/show_bug.cgi?id=149534
719
720         Reviewed by Darin Adler.
721
722         Towards setting up OpenSource iOS build bots, teach buildbot and its support
723         scripts about iOS.
724
725         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
726         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
727         --ios-simulator or --device for a builder/tester whose full platform name begins with
728         "ios-simulator" or "ios", respectively.
729         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
730         * BuildSlaveSupport/built-product-archive:
731         (main): Pass the full platform name to determineWebKitBuildDirectory().
732         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
733         command line flag when building for iOS.
734         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
735         parameter fullPlatform. This parameter was originally added in r125066 to support the
736         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
737         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
738         * BuildSlaveSupport/clean-build:
739         (main): Call script webkit-build-directory with the appropriate command line flag when
740         building for iOS.
741         * BuildSlaveSupport/delete-stale-build-files:
742         (main): Use the same logic for iOS as we do for Mac.
743         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
744         flag when building for iOS.
745         * BuildSlaveSupport/test-result-archive:
746         (archiveTestResults): Use the same logic for iOS as we do for Mac.
747
748 2015-09-24  Daniel Bates  <dabates@apple.com>
749
750         Remove Chromium-specific changes to script built-product-archive
751         https://bugs.webkit.org/show_bug.cgi?id=149530
752
753         Rubber-stamped by Csaba Osztrogonác.
754
755         Reverts changes made in r113074 and r113067 to support Chromium testers. The
756         Chromium code has long since been removed from the OpenSource WebKit Project.
757
758         * BuildSlaveSupport/built-product-archive:
759         (createZipManually):
760         (createZip):
761         (archiveBuiltProduct):
762
763 2015-09-24  Dan Bernstein  <mitz@apple.com>
764
765         Build fix.
766
767         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
768
769 2015-09-24  Mark Lam  <mark.lam@apple.com>
770
771         Unreviewed. Make Lucas Forschler a WebKit reviewer.
772
773         * Scripts/webkitpy/common/config/contributors.json:
774
775 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
776
777         Unreviewed. Fix GObject DOM API breaks after r190120.
778
779         Bring back code removed in r169931 to handle documentation of
780         deleted classes.
781
782         * gtk/webkitdom.py:
783         (WebKitDOMDocGenerator):
784         (WebKitDOMDocGenerator.write_deleted_classes):
785         (WebKitDOMDocGenerator.generate):
786         (write_deleted_classes):
787         (WebKitDOMDocGeneratorSections._deleted_class):
788         (WebKitDOMDocGeneratorSections._deleted_class.in):
789         (WebKitDOMDocGeneratorSections.write_deleted_classes):
790         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
791
792 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
793
794         [Cocoa] [Font Features] Implement font-variant-*
795         https://bugs.webkit.org/show_bug.cgi?id=148413
796
797         Reviewed by Darin Adler.
798
799         Update test font to use "lnum" feature.
800
801         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
802         (Generator::appendGSUBTable):
803
804 2015-09-22  Andy Estes  <aestes@apple.com>
805
806         ContentFiltering.AllowDownloadAfterAddData is very flaky
807         https://bugs.webkit.org/show_bug.cgi?id=148885
808         <rdar://problem/22729563>
809
810         Reviewed by Alexey Proskuryakov.
811
812         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
813         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
814         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
815
816         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
817         (downloadTest):
818
819 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
820
821         Mavericks: Media tests start to time out after a few days of bot uptime
822         https://bugs.webkit.org/show_bug.cgi?id=149468
823
824         Reviewed by Chris Dumez.
825
826         * Scripts/webkitpy/port/base.py:
827         * Scripts/webkitpy/port/driver.py:
828         * Scripts/webkitpy/port/mac.py:
829
830 2015-09-22  Nan Wang  <n_wang@apple.com>
831
832         Unreviewed, add myself to the committers list.
833
834         * Scripts/webkitpy/common/config/contributors.json:
835
836 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
837
838         Remove 'nullable' to fix older iOS builds.
839
840         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
841         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
842
843 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
844
845         [Win] Show tiled drawing debug overlay on Windows
846         https://bugs.webkit.org/show_bug.cgi?id=149426
847
848         Reviewed by Dean Jackson.
849
850         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
851         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
852         * MiniBrowser/win/Common.cpp:
853         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
854         flag if needed.
855         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
856
857 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
858
859         [Win] Use command-line argument to launch in regular or High DPI mode.
860         https://bugs.webkit.org/show_bug.cgi?id=149417
861
862         Reviewed by Dean Jackson.
863
864         * MiniBrowser/win/Common.cpp:
865         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
866         very start of execution, before the MiniBrowser.dll is loaded.
867         * win/DLLLauncher/DLLLauncherMain.cpp:
868         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
869         present. On WinCairo, always use High DPI.
870
871 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
872
873         32-bit Mac build fix attempt after r190065.
874
875         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
876
877 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
878
879         [OS X] Update for Xcode 7.0 on Yosemite
880         https://bugs.webkit.org/show_bug.cgi?id=149389
881
882         Reviewed by Dan Bernstein.
883
884         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
885         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
886         Removed unneeded declarations - conforming to a protocol is sufficient.
887
888         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
889         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
890         Changed the definitions to be compiled whenever the SDK requires it (so we will have
891         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
892
893 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
894
895         Add the ability for tests to run script in the UI process in WebKitTestRunner
896         https://bugs.webkit.org/show_bug.cgi?id=149356
897
898         Reviewed by Tim Horton.
899
900         This change adds testRunner.runUIScript(script, callback), which allows a test
901         to execute script in a JSContext which runs in the UI process. That context
902         has bindings exposed through the UIScriptController interface; currently one test
903         function, and some iOS-specific functions are included. UIScriptController can be
904         async with a callback, and runUIScript() itself is asynchronous. When the UI 
905         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
906         is a string passed back to the web process, and given to the runUIScript()
907         callback function.
908         
909         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
910
911         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
912         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
913         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
914         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
915         complete, call back into TestRunner.
916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
917         (WTR::nextUIScriptCallbackID):
918         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
919         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
921         * WebKitTestRunner/PlatformWebView.h:
922         * WebKitTestRunner/TestController.cpp:
923         (WTR::updateTestOptionsFromTestHeader):
924         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
925         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
926         * WebKitTestRunner/TestInvocation.cpp:
927         (WTR::TestInvocation::shouldUseFixedLayout):
928         (WTR::TestInvocation::shouldUseThreadedScrolling):
929         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
930         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
931         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
932         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
933         * WebKitTestRunner/TestInvocation.h:
934         * WebKitTestRunner/TestOptions.h:
935         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
936         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
937         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
938         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
939         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
940         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
941         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
942         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
943         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
944         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
945         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
946         (WTR::UIScriptController::doAsyncTask):
947         (WTR::UIScriptController::zoomToScale):
948         (WTR::UIScriptController::zoomScale):
949         (WTR::UIScriptController::minimumZoomScale):
950         (WTR::UIScriptController::maximumZoomScale):
951         (WTR::UIScriptController::contentVisibleRect):
952         * WebKitTestRunner/mac/EventSenderProxy.mm:
953         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
954         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
955         * WebKitTestRunner/mac/TestControllerMac.mm:
956         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
957         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
958         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
959         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
960         (UIScriptContext::UIScriptContext):
961         (UIScriptContext::~UIScriptContext):
962         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
963         asynchronous, call the callback.
964         (UIScriptContext::nextTaskCallbackID):
965         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
966         that has a callback). Has to store the callbackID of the script, so code called from the completion
967         callback knows which UI script invoked it.
968         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
969         (UIScriptContext::uiScriptComplete):
970         (UIScriptContext::objectFromRect): Make a JS object from a rect.
971         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
972         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
973         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
974         (WTR::UIScriptController::UIScriptController):
975         (WTR::UIScriptController::makeWindowObject):
976         (WTR::UIScriptController::wrapperClass):
977         (WTR::UIScriptController::doAsyncTask):
978         (WTR::UIScriptController::zoomToScale):
979         (WTR::UIScriptController::zoomScale):
980         (WTR::UIScriptController::minimumZoomScale):
981         (WTR::UIScriptController::maximumZoomScale):
982         (WTR::UIScriptController::contentVisibleRect):
983         (WTR::UIScriptController::uiScriptComplete):
984         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
985         (WTR::UIScriptController::create):
986         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
987
988 2015-09-21  Tim Horton  <timothy_horton@apple.com>
989
990         Turn on threaded scrolling by default in the tests
991         https://bugs.webkit.org/show_bug.cgi?id=149377
992
993         Reviewed by Simon Fraser.
994
995         * WebKitTestRunner/mac/TestControllerMac.mm:
996         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
997         (WTR::shouldUseThreadedScrolling): Deleted.
998         Turn on threaded scrolling by default.
999
1000 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1003         https://bugs.webkit.org/show_bug.cgi?id=149252
1004
1005         Reviewed by Darin Adler.
1006
1007         In case of glib tests the test runner notifies about tests
1008         crashing, but for google tests we don't get any feedback, which
1009         means that in case of a test crashing we get a list of **PASS**
1010         messages and at the summary we are notified that the test suite
1011         has failed, but it's impossible to know which test cases have failed.
1012
1013         * Scripts/run-gtk-tests:
1014         (TestRunner._run_google_test): Add a **CRASH** message if test
1015         case crashed.
1016
1017 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1018
1019         WebKitTestRunner can leak user content script results between tests
1020         https://bugs.webkit.org/show_bug.cgi?id=149391
1021
1022         Reviewed by Sam Weinig.
1023
1024         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1025         about:blank, and thus about:blank doesn't have unintended side effects.
1026
1027         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1028         (WTR::InjectedBundle::beginTesting):
1029         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1030         (WTR::InjectedBundlePage::resetAfterTest):
1031
1032 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1033
1034         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1035         https://bugs.webkit.org/show_bug.cgi?id=149384
1036
1037         Reviewed by Chris Fleizach.
1038
1039         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1040         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1041         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1042         regardless of whether someone else holds a reference (we also call -stopListening in
1043         -dealloc).
1044
1045         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1046         (AccessibilityController::platformResetToConsistentState):
1047         (AccessibilityController::addNotificationListener):
1048         Ditto.
1049
1050 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1051
1052         Remove XHR_TIMEOUT compilation guard
1053         https://bugs.webkit.org/show_bug.cgi?id=149260
1054
1055         Reviewed by Benjamin Poulain.
1056
1057         * Scripts/webkitperl/FeatureList.pm:
1058
1059 2015-09-19  Dan Bernstein  <mitz@apple.com>
1060
1061         Attempted build fix.
1062
1063         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1064
1065 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1066
1067         Unreviewed, rolling out r189908.
1068         https://bugs.webkit.org/show_bug.cgi?id=149368
1069
1070         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1071
1072         Reverted changeset:
1073
1074         "printing does not use minimum page zoom factor"
1075         https://bugs.webkit.org/show_bug.cgi?id=108507
1076         http://trac.webkit.org/changeset/189908
1077
1078 2015-09-18  Andy Estes  <aestes@apple.com>
1079
1080         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1081         https://bugs.webkit.org/show_bug.cgi?id=149360
1082
1083         Reviewed by Tim Horton.
1084
1085         Added an API test.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1089         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1090         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1091         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1092         (TEST):
1093         * TestWebKitAPI/ios/pages.pages: Added.
1094
1095 2015-09-18  Nan Wang  <n_wang@apple.com>
1096
1097         AX: Implement ARIA 1.1 @aria-current on iOS
1098         https://bugs.webkit.org/show_bug.cgi?id=149297
1099
1100         Reviewed by Chris Fleizach.
1101
1102         Added support to test aria-current on iOS.
1103
1104         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1105         (AccessibilityUIElement::stringAttributeValue):
1106         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1107         (WTR::AccessibilityUIElement::stringAttributeValue):
1108
1109 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1110
1111         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1112         https://bugs.webkit.org/show_bug.cgi?id=149352
1113
1114         Reviewed by Simon Fraser.
1115
1116         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1117         m_context can be null. This may indicate a bug in webkitpy too, but
1118         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1119         wrong with opening and immediately closing it.
1120
1121 2015-09-18  Daniel Bates  <dabates@apple.com>
1122
1123         isGitSVNDirectory() returns true when Git is not installed
1124         https://bugs.webkit.org/show_bug.cgi?id=149351
1125
1126         Reviewed by Alexey Proskuryakov.
1127
1128         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1129         Git is not installed on the machine.
1130
1131         * Scripts/VCSUtils.pm:
1132         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1133         status code 0 (success).
1134
1135 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1136
1137         Prevent build-webkit from building four times on Windows 
1138         https://bugs.webkit.org/show_bug.cgi?id=149336
1139
1140         Reviewed by Brent Fulgham.
1141
1142         * Scripts/build-webkit:
1143         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1144         They're built all at once.
1145         * Scripts/webkitdirs.pm:
1146         (buildVisualStudioProject):
1147         (cmakeGeneratedBuildfile):
1148         Don't generate the Visual Studio solution if it already exists.
1149         It will run CMake again if necessary.
1150
1151 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1152
1153         [iOS WK2] WTR fails to set the key window in the UIKit sense
1154         https://bugs.webkit.org/show_bug.cgi?id=149325
1155
1156         Reviewed by Tim Horton.
1157
1158         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1159         This causes UIKit to bypass code that actually sets the key window, resulting in
1160         [UIAppliation sharedApplication].keyWindow always being nil.
1161
1162         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1163         -[WebKitTestRunnerWindow isKeyWindow] call super.
1164
1165         * WebKitTestRunner/PlatformWebView.h:
1166         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1167         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1168         (WTR::PlatformWebView::setWindowIsKey):
1169         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1170         (WTR::PlatformWebView::setWindowIsKey):
1171         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1172         (-[WebKitTestRunnerWindow isKeyWindow]):
1173         (WTR::PlatformWebView::PlatformWebView):
1174         (WTR::PlatformWebView::~PlatformWebView):
1175         (WTR::PlatformWebView::setWindowIsKey):
1176         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1177         (WTR::PlatformWebView::setWindowIsKey):
1178
1179 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1180
1181         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1182         https://bugs.webkit.org/show_bug.cgi?id=149321
1183
1184         Reviewed by Tim Horton.
1185         
1186         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1187         enabled the "testing" viewport configuration, which disables page scaling.
1188         
1189         If we're running viewport tests, we want the normal web page configuration.
1190         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1191         based on whether the test is in a "viewport" directory.
1192
1193         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1194         (WTR::InjectedBundle::beginTesting):
1195         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1196         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1199         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1200         (WTR::TestInvocation::shouldMakeViewportFlexible):
1201         (WTR::TestInvocation::invoke):
1202         * WebKitTestRunner/TestInvocation.h:
1203         * WebKitTestRunner/ios/TestControllerIOS.mm:
1204         (WTR::TestController::platformConfigureViewForTest):
1205         (WTR::shouldMakeViewportFlexible): Deleted.
1206
1207 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1208
1209         Give iOS WebKitTestRunner a launch storyboard
1210         https://bugs.webkit.org/show_bug.cgi?id=149314
1211
1212         Reviewed by Dan Bates.
1213         
1214         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1215         that it's been built for specific device configurations, and puts the window
1216         at the top of the screen. This simplifies coordinate conversions in a future patch.
1217
1218         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1219         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1220         * WebKitTestRunner/ios/Launch.storyboard: Added.
1221
1222 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1223
1224         Update licence in r189890
1225         https://bugs.webkit.org/show_bug.cgi?id=149306
1226
1227         Reviewed by Dean Jackson.
1228
1229         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1230         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1231         * FontWithFeatures/FontWithFeatures/main.cpp:
1232
1233 2015-09-17  Mark Lam  <mark.lam@apple.com>
1234
1235         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1236         https://bugs.webkit.org/show_bug.cgi?id=149285
1237
1238         Reviewed by Saam Barati.
1239
1240         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1241
1242         * Scripts/run-javascriptcore-tests:
1243         (runJSCStressTests):
1244
1245 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1246
1247         Switch AppleWin build to use CMake
1248         https://bugs.webkit.org/show_bug.cgi?id=149163
1249
1250         Reviewed by Brent Fulgham.
1251
1252         * Scripts/build-webkit:
1253         * Scripts/run-api-tests:
1254         (runTest):
1255         (listAllTests):
1256         (prepareEnvironmentForRunningTestTool):
1257         (testToolPaths):
1258         (testToolPath): Deleted.
1259         Run the API tests as separate executables on Windows.
1260         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1261         * Scripts/webkitdirs.pm:
1262         (checkRequiredSystemConfig):
1263         (jhbuildWrapperPrefixIfNeeded):
1264         (generateBuildSystemFromCMakeProject):
1265         Fix configuration quirks.
1266
1267 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1268
1269         Added toggle options for hiding and showing certain platform families on the dashboard.
1270         https://bugs.webkit.org/show_bug.cgi?id=148403
1271
1272         Reviewed by David Kilzer.
1273
1274         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1275         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1276         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1277         in lieu of an "all" button in the toggle menu.
1278
1279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1280         (parsePlatformFamily): Helper function to parse out a platform family.
1281         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1282         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1283         (updateToggleButtons): Updates the status of the toggle buttons.
1284         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1285         (documentReady): Added creation of toggle buttons.
1286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1287         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1288         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1289         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1290         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1292         (QueueView): Updated to use hiddenPlatformFamilies.
1293         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1295         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1296         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1297         (Settings.prototype.toggleHiddenPlatform): Deleted.
1298         (Settings.prototype.clearHiddenPlatforms): Deleted.
1299         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1301         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1302         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1303         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1304         (table.queue-grid tr.headers th):
1305         (div.settingsWrapper.hide):
1306         (div.settingsWrapper):
1307         (div.familyToggleWrapper):
1308         (div.platformFamilyToggleButton):
1309         (div.platformFamilyShowToggleButton:not(:last-child)):
1310         (div.familyShown):
1311         (div.accessibilityButton):
1312         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1313         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1314         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1315         platformFamilyToggleButton and settingsWrapper class.
1316         (.accessibilityButton): Deleted.
1317
1318 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1319
1320         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1321         https://bugs.webkit.org/show_bug.cgi?id=148904
1322
1323         Reviewed by Myles Maxfield.
1324
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::parseBooleanTestHeaderValue):
1327         (WTR::updateViewOptionsFromTestHeader):
1328         Check for the key "useThreadedScrolling".
1329         Add some code to check for "true" and "false" for boolean options.
1330
1331         (WTR::TestController::viewOptionsForTest):
1332         Apply the test's overrides last, even after the platform's.
1333
1334 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         printing does not use minimum page zoom factor
1337         https://bugs.webkit.org/show_bug.cgi?id=108507
1338
1339         Reviewed by Darin Adler.
1340
1341         WebKitTestRunner always takes the snapshots from the UI process
1342         (expect for IOS), so in the case of printing, the layout in the
1343         web view is not the expected one. When printing, we need to take
1344         the snapshot in the web process and ensure it's rendered with a
1345         PrintContext.
1346
1347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1348         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1349         kWKSnapshotOptionsPrinting option to
1350         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1351         printing, don't even create the snapshot, since it will be ignored
1352         by the UI process that always creates its own from the WebView (expect for IOS platform)
1353         * WebKitTestRunner/TestInvocation.cpp:
1354         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1355         received from the web process if any when comparing pixel
1356         results. Now we only receive a snapshot from the web process in
1357         case of printing, or when platform is IOS. Otherwhise, generate
1358         the snapshot from the WebView as usual.
1359         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1360         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1361         is created by the caller now, but the CG implementation needs to
1362         know if it's a Web or UI process snapshot.
1363         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1364         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1365         cairo surface for the given image.
1366         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1367         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1368         CGContext for the given image.
1369
1370 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1371
1372         Create a font which can be used for testing font features
1373         https://bugs.webkit.org/show_bug.cgi?id=149237
1374
1375         Reviewed by Simon Fraser.
1376
1377         This patch adds a new project in the Tools/ directory which generates a font which can
1378         be used for testing font features. This is a standalone project consisting of two files:
1379         1. A file which actually generates the byte vector representing the font. This file has
1380         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1381         specific, and only relies on the C++ STL.
1382         2. A file with a main() which calls generateFont() and writes out the font, as well as
1383         uses the font to render some demonstration text into a .png file. This file is platform
1384         specific.
1385
1386         The font itself only supports the following characters:
1387         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1388         However, the shape of these letters are either an X or a check mark.
1389
1390         The letter "A" always is a check mark.
1391         The letter "B" always is an X.
1392         Without any font features turned on, the rest of the letters are shown as X.
1393
1394         Each font feature has an letter associated with it. When the font feature is enabled,
1395         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1396         as a check mark.
1397
1398         Here are the mappings of font features to letters:
1399         liga: C
1400         clig: D
1401         dlig: E
1402         hlig: F
1403         calt: G
1404         subs: H
1405         sups: I
1406         smcp: J
1407         c2sc: K
1408         pcap: L
1409         c2pc: M
1410         unic: N
1411         titl: O
1412         onum: P
1413         pnum: Q
1414         tnum: R
1415         frac: S
1416         afrc: T
1417         ordn: U
1418         zero: V
1419         hist: W
1420         jp78: X
1421         jp83: Y
1422         jp90: Z
1423         jp04: a
1424         smpl: b
1425         trad: c
1426         fwid: d
1427         pwid: e
1428         ruby: f
1429
1430         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1431         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1432         (integralLog2):
1433         (roundDownToPowerOfTwo):
1434         (isFourByteAligned):
1435         (clampTo):
1436         (append32):
1437         (writeCFFEncodedNumber):
1438         (CFFBuilder::CFFBuilder):
1439         (CFFBuilder::takeResult):
1440         (CFFBuilder::moveTo):
1441         (CFFBuilder::lineTo):
1442         (CFFBuilder::curveToCubic):
1443         (CFFBuilder::closePath):
1444         (CFFBuilder::writePoint):
1445         (generateBoxCharString):
1446         (generateCheckCharString):
1447         (generateXCharString):
1448         (charStringForGlyph):
1449         (Generator::generate):
1450         (Generator::Placeholder::Placeholder):
1451         (Generator::Placeholder::populate):
1452         (Generator::Placeholder::~Placeholder):
1453         (Generator::placeholder):
1454         (Generator::append16):
1455         (Generator::append32):
1456         (Generator::append32BitCode):
1457         (Generator::overwrite16):
1458         (Generator::overwrite32):
1459         (Generator::appendCFFTable):
1460         (Generator::appendSubstitutionSubtable):
1461         (Generator::appendScriptSubtable):
1462         (Generator::appendGSUBTable):
1463         (Generator::appendOS2Table):
1464         (Generator::appendFormat12CMAPTable):
1465         (Generator::appendFormat4CMAPTable):
1466         (Generator::appendCMAPTable):
1467         (Generator::appendHEADTable):
1468         (Generator::appendHHEATable):
1469         (Generator::appendHMTXTable):
1470         (Generator::appendMAXPTable):
1471         (Generator::appendNAMETable):
1472         (Generator::appendPOSTTable):
1473         (Generator::calculateChecksum):
1474         (Generator::appendTable):
1475         (generateFont):
1476         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1477         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1478         (drawTextWithFeature):
1479         (main):
1480
1481 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1482
1483         Unreviewed, rolling out r189875 and r189878.
1484         https://bugs.webkit.org/show_bug.cgi?id=149235
1485
1486         cygwin cmake build not ready yet (Requested by alexchristensen
1487         on #webkit).
1488
1489         Reverted changesets:
1490
1491         "Switch AppleWin build to use CMake"
1492         https://bugs.webkit.org/show_bug.cgi?id=149163
1493         http://trac.webkit.org/changeset/189875
1494
1495         "Cygwin build fix after r189875"
1496         http://trac.webkit.org/changeset/189878
1497
1498 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1499
1500         Cygwin build fix after r189875
1501
1502         * Scripts/build-webkit:
1503         * Scripts/webkitdirs.pm:
1504         (jhbuildWrapperPrefixIfNeeded):
1505         (generateBuildSystemFromCMakeProject):
1506         Make things work with cygwin and cmake.
1507
1508 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1509
1510         Switch AppleWin build to use CMake
1511         https://bugs.webkit.org/show_bug.cgi?id=149163
1512
1513         Reviewed by Brent Fulgham.
1514
1515         * Scripts/build-webkit:
1516         Build with CMake.
1517         * Scripts/run-api-tests:
1518         (runTest):
1519         (listAllTests):
1520         (prepareEnvironmentForRunningTestTool):
1521         (testToolPaths):
1522         (testToolPath): Deleted.
1523         Run the API tests as separate executables on Windows.
1524         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1525
1526 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1527
1528         Add newer build.webkit.org pages to robots.txt
1529         https://bugs.webkit.org/show_bug.cgi?id=149219
1530
1531         Reviewed by Darin Adler.
1532
1533         Indexing bot watcher's dashboard can't be good.
1534
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1536
1537 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1538
1539         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1540
1541         * BuildSlaveSupport/built-product-archive:
1542         (unzipArchive):
1543
1544 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1545
1546         [EFL] Fix the help message of separated web process option of MiniBrowser
1547         https://bugs.webkit.org/show_bug.cgi?id=149212
1548
1549         Reviewed by Gyuyoung Kim.
1550
1551         * MiniBrowser/efl/main.c:
1552
1553 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1554
1555         Fix python syntax after r189851.
1556
1557         * BuildSlaveSupport/built-product-archive:
1558         (unzipArchive):
1559         For loops need a colon.
1560
1561 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1562
1563         Fix Windows test bots after changing to non-cygwin build
1564         https://bugs.webkit.org/show_bug.cgi?id=149196
1565
1566         Reviewed by Daniel Bates.
1567
1568         * BuildSlaveSupport/built-product-archive:
1569         (unzipArchive):
1570         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1571         prevent us from executing files from the archive on the test bots.
1572
1573 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         Add ShadowRoot interface and Element.prototype.attachShadow
1576         https://bugs.webkit.org/show_bug.cgi?id=149187
1577
1578         Reviewed by Antti Koivisto.
1579
1580         * Scripts/webkitperl/FeatureList.pm:
1581
1582 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1583
1584         Appscale queue status json output lacks bots
1585         https://bugs.webkit.org/show_bug.cgi?id=149194
1586         <rdar://problem/22171089>
1587
1588         Reviewed by Alexey Proskuryakov.
1589
1590         * QueueStatusServer/handlers/queuestatusjson.py:
1591         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1592         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1593
1594 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1595
1596         [Win] Provide a means for viewing the layer tree
1597         https://bugs.webkit.org/show_bug.cgi?id=149165
1598
1599         Reviewed by Simon Fraser.
1600
1601         Update MiniBrowser with a new Debug menu option that will
1602         dump the current layer tree to the debug console.
1603         
1604         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1605         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1606         * MiniBrowser/win/Common.cpp:
1607         (WndProc): Add handler for 'Print Layer Tree' menu option.
1608         * MiniBrowser/win/MiniBrowser.cpp:
1609         (MiniBrowser::printLayerTree): Added Handler.
1610         * MiniBrowser/win/MiniBrowser.h:
1611
1612 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1613
1614         WebKitTestRunner declarative language setting is broken for iOS
1615         https://bugs.webkit.org/show_bug.cgi?id=149119
1616
1617         Unreviewed.
1618
1619         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1620         lost in the final version which got committed. This simply implements the existing
1621         OS X behavior on iOS.
1622
1623         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1624         (WTR::InjectedBundle::platformInitialize):
1625
1626 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1627
1628         Unreviewed, add myself to committers list.
1629
1630         * Scripts/webkitpy/common/config/contributors.json:
1631
1632 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1633
1634         [Cocoa] Allow testing with the system language
1635         https://bugs.webkit.org/show_bug.cgi?id=148671
1636
1637         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1638
1639         React to tests marked with language=lang1,lang2,etc in their header.
1640         Once this information is parsed, pass it to
1641         WKContextConfigurationSetOverrideLanguages().
1642
1643         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1644         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1645         list.
1646         * WebKitTestRunner/TestController.cpp:
1647         (WTR::TestController::createWebViewWithOptions): Call
1648         WKContextConfigurationSetOverrideLanguages().
1649         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1650         * WebKitTestRunner/TestOptions.h:
1651         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1652         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1653         option to restart the web process.
1654         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1655         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1656
1657 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1658
1659         [WKTR] Allow changing the WKContextConfiguration between successive tests
1660         https://bugs.webkit.org/show_bug.cgi?id=148833
1661
1662         Reviewed by Tim Horton.
1663
1664         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1665         However, there are certain tests which require specifying options in this object. This patch makes
1666         our existing code for recreating the test runner web view also recreate the WKContext.
1667
1668         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1669         class.
1670
1671         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1672         * WebKitTestRunner/PlatformWebView.h:
1673         (WTR::PlatformWebView::options):
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::initialize):
1676         (WTR::TestController::generateContextConfiguration):
1677         (WTR::TestController::generatePageConfiguration):
1678         (WTR::TestController::createWebViewWithOptions):
1679         (WTR::TestController::ensureViewSupportsOptionsForTest):
1680         (WTR::updateContextConfigurationOptionsFromTestHeader):
1681         (WTR::TestController::contextConfigurationOptionsForTest):
1682         (WTR::TestController::platformCreateWebView):
1683         (WTR::TestController::platformCreateOtherPage):
1684         (WTR::updateViewOptionsFromTestHeader): Deleted.
1685         (WTR::TestController::viewOptionsForTest): Deleted.
1686         * WebKitTestRunner/TestController.h:
1687         (WTR::TestController::injectedBundlePath):
1688         (WTR::TestController::testPluginDirectory):
1689         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1690         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1691         (WTR::TestController::platformCreateWebView):
1692         (WTR::TestController::platformCreateOtherPage):
1693         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1694         (WTR::PlatformWebView::PlatformWebView):
1695         (WTR::PlatformWebView::viewSupportsOptions):
1696         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1697         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1698         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1699         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1700         (WTR::PlatformWebView::PlatformWebView):
1701         (WTR::PlatformWebView::viewSupportsOptions):
1702         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1703         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1704         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1705         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1706         (WTR::PlatformWebView::PlatformWebView):
1707         (WTR::PlatformWebView::viewSupportsOptions):
1708         * WebKitTestRunner/ios/TestControllerIOS.mm:
1709         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1710         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1711         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1712         (WTR::PlatformWebView::PlatformWebView):
1713         (WTR::PlatformWebView::viewSupportsOptions):
1714         * WebKitTestRunner/mac/TestControllerMac.mm:
1715         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1716         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1717
1718 2015-09-11  Michael Saboff  <msaboff@apple.com>
1719
1720         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1721         https://bugs.webkit.org/show_bug.cgi?id=149083
1722
1723         Reviewed by Alexey Proskuryakov.
1724
1725         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1726
1727         * DumpRenderTree/mac/LayoutTestHelper.m:
1728         (colorProfileURLForDisplay):
1729
1730 2015-09-11  Saam barati  <sbarati@apple.com>
1731
1732         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1733         https://bugs.webkit.org/show_bug.cgi?id=149058
1734
1735         Reviewed by Geoffrey Garen.
1736
1737         * Scripts/run-jsc-stress-tests:
1738
1739 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1740
1741         Unreviewed, rolling out r189595.
1742         https://bugs.webkit.org/show_bug.cgi?id=149052
1743
1744         The tests still fail (Requested by ap on #webkit).
1745
1746         Reverted changeset:
1747
1748         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1749         error -1"
1750         https://bugs.webkit.org/show_bug.cgi?id=142929
1751         http://trac.webkit.org/changeset/189595
1752
1753 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1754
1755         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1756         https://bugs.webkit.org/show_bug.cgi?id=142929
1757
1758         Reviewed by Brent Fulgham.
1759
1760         Silence the logging. We'll track fixing the root cause in Radar.
1761
1762         * Scripts/webkitpy/port/mac.py:
1763         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1764
1765         * Scripts/webkitpy/port/win.py:
1766         (WinPort.logging_patterns_to_strip): Added.
1767
1768 2015-09-09  Andy Estes  <aestes@apple.com>
1769
1770         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1771         https://bugs.webkit.org/show_bug.cgi?id=149022
1772
1773         Reviewed by Daniel Bates.
1774
1775         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1776         did not account for this.
1777
1778         * Scripts/webkitpy/xcode/simulator.py:
1779         (Simulator): Optionally matched a revision at the end of a runtime version number.
1780         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1781
1782 2015-09-09  Andy Estes  <aestes@apple.com>
1783
1784         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1785         https://bugs.webkit.org/show_bug.cgi?id=149029
1786         <rdar://problem/22432624>
1787
1788         Reviewed by Daniel Bates.
1789
1790         * Scripts/webkitpy/xcode/simulator.py:
1791         (Simulator): Taught to parse tvOS runtimes.
1792         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1793
1794 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1795
1796         Fix bit rot on bot watcher's dashboard page
1797         https://bugs.webkit.org/show_bug.cgi?id=149012
1798
1799         Reviewed by Tim Horton.
1800
1801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1802         The code path used by the metrics page was trying to add properties to an undefined.
1803
1804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1805         Silence an expection that would occur when the step has no logs. This should never
1806         happen, but it did (perhaps buildbot was misconfigured for a while).
1807
1808 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1809
1810         Update LayoutTestRelay xcconfig file.
1811
1812         Rubber-stamped by Dan Bernstein.
1813
1814         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1815
1816 2015-09-09  Saam barati  <sbarati@apple.com>
1817
1818         DFG should have a debugging option that runs a phase that flushes all locals
1819         https://bugs.webkit.org/show_bug.cgi?id=148916
1820
1821         Reviewed by Filip Pizlo.
1822
1823         * Scripts/run-jsc-stress-tests:
1824
1825 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1826
1827         Unreviewed, rolling out r189530 and r189534.
1828         https://bugs.webkit.org/show_bug.cgi?id=148996
1829
1830         Caused assertion failures on Yosemite (Requested by litherum
1831         on #webkit).
1832
1833         Reverted changesets:
1834
1835         "[WKTR] Allow changing the WKContextConfiguration between
1836         successive tests"
1837         https://bugs.webkit.org/show_bug.cgi?id=148833
1838         http://trac.webkit.org/changeset/189530
1839
1840         "[Cocoa] Fix the tests after r189530"
1841         http://trac.webkit.org/changeset/189534
1842
1843 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1844
1845         [Cocoa] Fix the tests after r189530
1846
1847         Unreviewed.
1848
1849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1850         (WTR::initializeWebViewConfiguration):
1851
1852 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1853
1854         [WKTR] Allow changing the WKContextConfiguration between successive tests
1855         https://bugs.webkit.org/show_bug.cgi?id=148833
1856
1857         Reviewed by Tim Horton.
1858
1859         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1860         However, there are certain tests which require specifying options in this object. This patch makes
1861         our existing code for recreating the test runner web view also recreate the WKContext.
1862
1863         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1864         class.
1865
1866         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1867         * WebKitTestRunner/PlatformWebView.h:
1868         (WTR::PlatformWebView::options):
1869         * WebKitTestRunner/TestController.cpp:
1870         (WTR::TestController::initialize):
1871         (WTR::TestController::generateContextConfiguration):
1872         (WTR::TestController::generatePageConfiguration):
1873         (WTR::TestController::createWebViewWithOptions):
1874         (WTR::TestController::ensureViewSupportsOptionsForTest):
1875         (WTR::updateContextConfigurationOptionsFromTestHeader):
1876         (WTR::TestController::contextConfigurationOptionsForTest):
1877         (WTR::TestController::platformCreateWebView):
1878         (WTR::TestController::platformCreateOtherPage):
1879         (WTR::updateViewOptionsFromTestHeader): Deleted.
1880         (WTR::TestController::viewOptionsForTest): Deleted.
1881         * WebKitTestRunner/TestController.h:
1882         (WTR::TestController::injectedBundlePath):
1883         (WTR::TestController::testPluginDirectory):
1884         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1885         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1886         (WTR::TestController::platformCreateWebView):
1887         (WTR::TestController::platformCreateOtherPage):
1888         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1889         (WTR::PlatformWebView::PlatformWebView):
1890         (WTR::PlatformWebView::viewSupportsOptions):
1891         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1892         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1893         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1894         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1895         (WTR::PlatformWebView::PlatformWebView):
1896         (WTR::PlatformWebView::viewSupportsOptions):
1897         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1898         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1899         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1900         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1901         (WTR::PlatformWebView::PlatformWebView):
1902         (WTR::PlatformWebView::viewSupportsOptions):
1903         * WebKitTestRunner/ios/TestControllerIOS.mm:
1904         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1905         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1906         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1907         (WTR::PlatformWebView::PlatformWebView):
1908         (WTR::PlatformWebView::viewSupportsOptions):
1909         * WebKitTestRunner/mac/TestControllerMac.mm:
1910         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1911         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1912
1913 2015-09-08  Daniel Bates  <dabates@apple.com>
1914
1915         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1916         https://bugs.webkit.org/show_bug.cgi?id=148980
1917
1918         Reviewed by Alexey Proskuryakov.
1919
1920         Add setting to enable/disable accelerated drawing so as to support testing
1921         this feature in MiniBrowser on Mac.
1922
1923         * MiniBrowser/mac/SettingsController.h:
1924         * MiniBrowser/mac/SettingsController.m:
1925         (-[SettingsController _populateMenu]): Add menu item.
1926         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1927         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1928         (-[SettingsController acceleratedDrawingEnabled]): Added.
1929         * MiniBrowser/mac/WK1BrowserWindowController.m:
1930         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1931         * MiniBrowser/mac/WK2BrowserWindowController.m:
1932         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1933
1934 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1935
1936         Unreviewed. Added myself as a commiter in contributors.json.
1937
1938         * Scripts/webkitpy/common/config/contributors.json:
1939
1940 2015-09-08  Keith Miller  <keith_miller@apple.com>
1941
1942         Unreviewed, added myself to the list of contributors.
1943
1944         * Scripts/webkitpy/common/config/contributors.json:
1945
1946 2015-09-08  Daniel Bates  <dabates@apple.com>
1947
1948         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1949         https://bugs.webkit.org/show_bug.cgi?id=148921
1950
1951         Reviewed by Alexey Proskuryakov.
1952
1953         The ring image is positioned above the platform icon in markup and we specify the CSS
1954         property z-index for the ring image so that it is painted on top of the platform icon
1955         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1956         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1957         property z-index to achieve a similar effect.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1960         (documentReady): Create the platform icon image element before the ring image such that
1961         the ring image is painted on top of the platform icon.
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1963         (table.queue-grid td.logo img.ring): Removed property z-index.
1964
1965 2015-09-08  Daniel Bates  <dabates@apple.com>
1966
1967         Dashboard: Remove duplicate gear icon data URLs
1968         https://bugs.webkit.org/show_bug.cgi?id=148920
1969
1970         Reviewed by Alexey Proskuryakov.
1971
1972         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1973         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1974         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1975         as a mask and make use of the CSS background-color to define the fill color for each of these three
1976         states.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1979         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
1980         (.settings:hover): Override CSS background-color for hover state.
1981         (.settings-visible .settings): Override CSS background-color for expanded state.
1982
1983 2015-09-07  Andy Estes  <aestes@apple.com>
1984
1985         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1986         https://bugs.webkit.org/show_bug.cgi?id=148946
1987         <rdar://problem/22603981>
1988
1989         Reviewed by Dan Bernstein.
1990
1991         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1992         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1993
1994 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1995
1996         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1997         https://bugs.webkit.org/show_bug.cgi?id=148927
1998
1999         Reviewed by Csaba Osztrogonác.
2000
2001         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2002         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2003
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2006         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2007         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2008
2009 2015-09-07  Andy Estes  <aestes@apple.com>
2010
2011         Fix the Production build after r189455.
2012
2013         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2014         In-App Purchase template instead of the Aggregate template. Whoops.
2015
2016 2015-09-06  Andy Estes  <aestes@apple.com>
2017
2018         WebKit.xcworkspace should be be able to build iOS platforms
2019         https://bugs.webkit.org/show_bug.cgi?id=148881
2020
2021         Reviewed by Daniel Bates.
2022
2023         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2024         for all supported platforms.
2025
2026         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2027         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2028         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2029         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2030
2031 2015-09-06  Andy Estes  <aestes@apple.com>
2032
2033         WebKitTestRunner should build for iOS using the default target
2034         https://bugs.webkit.org/show_bug.cgi?id=148918
2035
2036         Reviewed by Daniel Bates.
2037
2038         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2039         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2040         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2041
2042         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2043         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2044         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2045         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2046         WebKitTestRunner is skipped when installing on iOS.
2047
2048         The target dependency graph now looks like this:
2049
2050             All
2051                 WebKitTestRunnerApp
2052                     WebKitTestRunner (Library)
2053                         WebKitTestRunnerInjectedBundle
2054                             Derived Sources
2055                 WebKitTestRunner
2056                     WebKitTestRunner (Library)
2057                         WebKitTestRunnerInjectedBundle
2058                             Derived Sources
2059
2060         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2061         * Scripts/build-webkittestrunner: Ditto.
2062         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2063         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2064         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2065         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2066         excluded iOS-only files, and skipped installing on iOS.
2067         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2068         excluded Mac-only files, and skipped installing on Mac.
2069         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2070         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2071         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2072         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2073         new configuration files.
2074
2075 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2076
2077         Web Inspector: Improve prepare-ChangeLog for multiple cases
2078         https://bugs.webkit.org/show_bug.cgi?id=148875
2079
2080         Reviewed by Timothy Hatcher.
2081
2082         * Scripts/prepare-ChangeLog:
2083         (get_function_line_ranges_for_javascript):
2084         - We were ignoring everything inside of an anonymous function expression,
2085           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2086           Better handle this by inserting a few tweaks.
2087         - Allow method syntax outside of classes as long as they are at the global level.
2088         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2089
2090         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2091         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2092         (Foo.prototype.method1):
2093         (Foo.prototype.method2):
2094         (Foo.prototype.method3.innerFunction):
2095         (Foo.prototype.method3):
2096         (insideGlobalAnonymousFunctionExpression):
2097         (foo.insideGlobalFunctionExpression):
2098         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2099         (IssueWithMapGetAndSet.prototype.method1):
2100         (IssueWithMapGetAndSet.prototype.method2):
2101         (IssueWithMapGetAndSet.prototype.method3):
2102         (IssueWithMapGetAndSet):
2103
2104 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2105
2106         [ES6] Enable ES6 Module in JSC shell by default
2107         https://bugs.webkit.org/show_bug.cgi?id=148689
2108
2109         Reviewed by Geoffrey Garen.
2110
2111         * Scripts/run-javascriptcore-tests:
2112         (runJSCStressTests):
2113         * Scripts/run-jsc-stress-tests:
2114
2115 2015-09-04  Basile Clement  <basile_clement@apple.com>
2116
2117         Unreviewed, change my email address.
2118
2119         * Scripts/webkitpy/common/config/contributors.json:
2120
2121 2015-09-04  Beth Dakin  <bdakin@apple.com>
2122
2123         Should have a test to make sure links don't navigate after a cancelled force 
2124         click
2125         https://bugs.webkit.org/show_bug.cgi?id=148846
2126
2127         Reviewed by Tim Horton.
2128
2129         New EventSender function for a started then cancelled force click.
2130         * WebKitTestRunner/EventSenderProxy.h:
2131         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2132         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2133         (WTR::EventSendingController::mouseForceClick):
2134         (WTR::EventSendingController::startAndCancelMouseForceClick):
2135         (WTR::EventSendingController::mouseForceDown):
2136         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2137         * WebKitTestRunner/TestController.cpp:
2138         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2139         * WebKitTestRunner/mac/EventSenderProxy.mm:
2140         (WTR::EventSenderProxy::mouseForceClick):
2141         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2142         (WTR::EventSenderProxy::mouseForceDown):
2143         (WTR::EventSenderProxy::mouseMoveTo):
2144
2145 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2146
2147         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2148         https://bugs.webkit.org/show_bug.cgi?id=148830
2149
2150         Reviewed by Beth Dakin.
2151
2152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2153         (WTR::InjectedBundle::beginTesting):
2154         Make sure that TestRunner callbacks don't leak between tests!
2155
2156 2015-09-04  Anders Carlsson  <andersca@apple.com>
2157
2158         It should be possible to pass relative HTTP test paths to DumpRenderTree
2159         https://bugs.webkit.org/show_bug.cgi?id=148825
2160         <rdar://problem/22583866>
2161
2162         Reviewed by Tim Horton.
2163
2164         Convert the path to an absolute path if needed.
2165
2166         * DumpRenderTree/mac/DumpRenderTree.mm:
2167         (computeTestURL):
2168
2169 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2170
2171         Fix Swift unit tests for prepare-ChangeLog.
2172         https://bugs.webkit.org/show_bug.cgi?id=148817
2173
2174         Reviewed by Alexey Proskuryakov.
2175
2176         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2177         Swift unit tests for prepare-ChangeLog.
2178
2179 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2180
2181         Modifications to the webkit-nightly logic.
2182         
2183         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2184         (updateAlertPanel):
2185         * WebKitLauncher/main.m:
2186         (displayErrorAndQuit):
2187
2188 2015-09-04  Beth Dakin  <bdakin@apple.com>
2189
2190         Speculative build fix.
2191
2192         * WebKitTestRunner/mac/EventSenderProxy.mm:
2193
2194 2015-09-04  Brian Burg  <bburg@apple.com>
2195
2196         Web Inspector: InspectorController should support multiple frontend channels
2197         https://bugs.webkit.org/show_bug.cgi?id=148538
2198
2199         Reviewed by Joseph Pecoraro.
2200
2201         InspectorClients must explicitly disconnect their frontend channel(s) from the
2202         inspected page's InspectorController.
2203
2204         To make this possible, DumpRenderTree should not destroy non-primary views until
2205         it has tried to close any abandoned Web Inspector instances. Performing teardown
2206         in the reverse order prevents disconnection of the frontend channel because that
2207         prematurely destroys the inspector frontend client.
2208
2209         * DumpRenderTree/mac/DumpRenderTree.mm:
2210         (runTest):
2211         * DumpRenderTree/win/DumpRenderTree.cpp:
2212         (runTest):
2213
2214 2015-09-04  Beth Dakin  <bdakin@apple.com>
2215
2216         Need to be able to test default behaviors on force click
2217         https://bugs.webkit.org/show_bug.cgi?id=148758
2218
2219         Reviewed by Tim Horton.
2220
2221         This patch adds a new eventSender method to do a full, completed force click, 
2222         and it re-works all of the existing force methods to dispatch their events in 
2223         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2224         To do this, first we need to send the events to the app rather than straight 
2225         to the view, and also needed to tweak some state and send the events in a 
2226         delayed fashion.
2227
2228         New public function mouseForceClick() and private helper functions to make 
2229         NSEvents.
2230         * WebKitTestRunner/EventSenderProxy.h:
2231
2232         New public function mouseForceClick().
2233         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2234         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2235         (WTR::EventSendingController::mouseMoveTo):
2236         (WTR::EventSendingController::mouseForceClick):
2237         (WTR::EventSendingController::mouseForceDown):
2238         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2239         * WebKitTestRunner/TestController.cpp:
2240         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2241
2242         initPressureEventAtLocation needs to take a stageTransition and a window.
2243         * WebKitTestRunner/mac/EventSenderProxy.mm:
2244         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2245         (-[EventSenderSyntheticEvent stageTransition]):
2246         (-[EventSenderSyntheticEvent timestamp]):
2247         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2248         (-[EventSenderSyntheticEvent window]):
2249
2250         In order to enter the gesture recognizer, we need to start with a mouse down 
2251         that has a NSEventMaskPressure modifier.
2252         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2253
2254         This ensures that the events queue properly for the force monitor in AppKit.
2255         (WTR::spinRunLoopForForce):
2256
2257          We need to start the pressure change events with a began.
2258         (WTR::EventSenderProxy::beginPressureEvent):
2259
2260         These functions can be used to create the NSEvent for a pressure change every 
2261         time we need one.
2262         (WTR::EventSenderProxy::pressureChangeEvent):
2263
2264         Send the right series of events to emulate a full, completed force click.
2265         (WTR::EventSenderProxy::mouseForceClick):
2266
2267         Use all of the new things for these existing functions.
2268         (WTR::EventSenderProxy::mouseForceDown):
2269         (WTR::EventSenderProxy::mouseForceUp):
2270         (WTR::EventSenderProxy::mouseForceChanged):
2271
2272         Set NSFakeForceTouchDevice to YES.
2273         * WebKitTestRunner/mac/main.mm:
2274         (setDefaultsToConsistentValuesForTesting):
2275
2276 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2277
2278         prepare-ChangeLog needs to know how to parse Swift files.
2279         https://bugs.webkit.org/show_bug.cgi?id=148784
2280         <rdar://problem/22510062>
2281
2282         Reviewed by Darin Adler.
2283
2284         * Scripts/prepare-ChangeLog:
2285         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2286         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2287         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2288         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2289         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2290         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2291         (freeFunction): Ditto.
2292         (MyClass.function): Ditto.
2293         (MyClass.functionWithArgument(_:)): Ditto.
2294         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2295         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2296         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2297         (MyClass.classFunction): Ditto.
2298         (MyClass.readWriteComputedVariable): Ditto.
2299         (MyClass.readOnlyComputedVariable): Ditto.
2300
2301 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2302
2303         Import css/css-color-3
2304         https://bugs.webkit.org/show_bug.cgi?id=148803
2305
2306         Reviewed by Chris Dumez.
2307
2308         Fixed a bug that the imported reference files used the same extention as tests.
2309         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2310
2311         * Scripts/webkitpy/w3c/test_importer.py:
2312         (TestImporter.find_importable_tests):
2313
2314 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2315
2316         Unreviewed, rolling out r189338.
2317         https://bugs.webkit.org/show_bug.cgi?id=148785
2318
2319         Caused tons of crashes (Requested by cdumez on #webkit).
2320
2321         Reverted changeset:
2322
2323         "Web Inspector: InspectorController should support multiple
2324         frontend channels"
2325         https://bugs.webkit.org/show_bug.cgi?id=148538
2326         http://trac.webkit.org/changeset/189338
2327
2328 2015-09-03  Brian Burg  <bburg@apple.com>
2329
2330         Web Inspector: InspectorController should support multiple frontend channels
2331         https://bugs.webkit.org/show_bug.cgi?id=148538
2332
2333         Reviewed by Joseph Pecoraro.
2334
2335         InspectorClients must explicitly disconnect their frontend channel(s) from the
2336         inspected page's InspectorController.
2337
2338         To make this possible, DumpRenderTree should not destroy non-primary views until
2339         it has tried to close any abandoned Web Inspector instances. Performing teardown
2340         in the reverse order prevents disconnection of the frontend channel because that
2341         prematurely destroys the inspector frontend client.
2342
2343         * DumpRenderTree/mac/DumpRenderTree.mm:
2344         (runTest):
2345         * DumpRenderTree/win/DumpRenderTree.cpp:
2346         (runTest):
2347
2348 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2349
2350         Update WebKit nightly icon to be more like Safari
2351         https://bugs.webkit.org/show_bug.cgi?id=148768
2352
2353         Reviewed by Joseph Pecoraro.
2354
2355         * WebKitLauncher/webkit.icns:
2356
2357 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2358
2359         JavaScriptCore should have some ES6 conformance tests
2360         https://bugs.webkit.org/show_bug.cgi?id=148771
2361
2362         Reviewed by Chris Dumez.
2363
2364         * Scripts/run-javascriptcore-tests:
2365         (runJSCStressTests): Added es6 as a test suite.
2366
2367         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2368
2369         Some of these tests currently fail, so I also added a way to expect
2370         failure for now. We'll migrate failing tests to expected passes as we
2371         fix them.
2372
2373 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2374
2375         Add a test for swipe-start hysteresis
2376         https://bugs.webkit.org/show_bug.cgi?id=148756
2377
2378         Reviewed by Anders Carlsson.
2379
2380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2382         (WTR::cacheTestRunnerCallback):
2383         (WTR::TestRunner::clearTestRunnerCallbacks):
2384         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2385         Make sure that we log if a client tries to install a callback twice
2386         (since we use .add, the second call would not work).
2387
2388         Also, add clearTestRunnerCallbacks so tests can swap out installed
2389         callbacks.
2390
2391 2015-09-03  Anders Carlsson  <andersca@apple.com>
2392
2393         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2394         https://bugs.webkit.org/show_bug.cgi?id=148746
2395         rdar://problem/22568073
2396
2397         Reviewed by Tim Horton.
2398
2399         * DumpRenderTree/mac/DumpRenderTree.mm:
2400         (computeTestURL):
2401         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2402
2403         (runTest):
2404         Call computeTestURL.
2405
2406         (testPathFromURL):
2407         Get rid of this; computeTestURL does this for us now.
2408
2409         * Scripts/webkitpy/port/driver.py:
2410         (Driver._command_from_driver_input):
2411         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2412
2413 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2414
2415         Swipe tests fail on Mavericks
2416         https://bugs.webkit.org/show_bug.cgi?id=148752
2417
2418         Reviewed by Beth Dakin.
2419
2420         * WebKitTestRunner/mac/EventSenderProxy.mm:
2421
2422 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2423
2424         Fix the 32-bit build
2425
2426         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2427         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2428
2429 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2430
2431         Remove some logging that wasn't meant to be in the tree
2432
2433         * WebKitTestRunner/mac/EventSenderProxy.mm:
2434         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2435
2436 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2437
2438         [Mac] Add support for testing swipes
2439         https://bugs.webkit.org/show_bug.cgi?id=148700
2440
2441         Reviewed by Beth Dakin.
2442
2443         * WebKitTestRunner/EventSenderProxy.h:
2444         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2445         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2446         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2447         (WTR::cgEventPhaseFromString):
2448         (WTR::cgEventMomentumPhaseFromString):
2449         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2450         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2451         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2452         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2453         (WTR::InjectedBundle::didReceiveMessageToPage):
2454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2455         (WTR::TestRunner::installDidBeginSwipeCallback):
2456         (WTR::TestRunner::installWillEndSwipeCallback):
2457         (WTR::TestRunner::installDidEndSwipeCallback):
2458         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2459         (WTR::TestRunner::callDidBeginSwipeCallback):
2460         (WTR::TestRunner::callWillEndSwipeCallback):
2461         (WTR::TestRunner::callDidEndSwipeCallback):
2462         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2463         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2464         * WebKitTestRunner/TestController.cpp:
2465         (WTR::TestController::createOtherPage):
2466         (WTR::TestController::createWebViewWithOptions):
2467         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2468         (WTR::TestController::didBeginNavigationGesture):
2469         (WTR::TestController::willEndNavigationGesture):
2470         (WTR::TestController::didEndNavigationGesture):
2471         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2472         * WebKitTestRunner/TestController.h:
2473         * WebKitTestRunner/TestInvocation.cpp:
2474         (WTR::TestInvocation::didBeginSwipe):
2475         (WTR::TestInvocation::willEndSwipe):
2476         (WTR::TestInvocation::didEndSwipe):
2477         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2478         * WebKitTestRunner/TestInvocation.h:
2479         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2480         when the snapshot is removed.
2481
2482         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2483         mouseScrollBy function.
2484
2485         * WebKitTestRunner/mac/EventSenderProxy.mm:
2486         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2487         (-[EventSenderSyntheticEvent type]):
2488         (-[EventSenderSyntheticEvent subtype]):
2489         (-[EventSenderSyntheticEvent locationInWindow]):
2490         (-[EventSenderSyntheticEvent location]):
2491         (-[EventSenderSyntheticEvent momentumPhase]):
2492         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2493         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2494         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2495         more adjustable values.
2496
2497         (WTR::EventSenderProxy::mouseForceDown):
2498         (WTR::EventSenderProxy::mouseForceUp):
2499         (WTR::EventSenderProxy::mouseForceChanged):
2500         Adopt EventSenderSyntheticEvent.
2501
2502         (WTR::nsEventPhaseFromCGEventPhase):
2503         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2504         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2505
2506         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2507         (WTR::PlatformWebView::PlatformWebView):
2508         Enable swipe.
2509
2510 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2511
2512         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2513         https://bugs.webkit.org/show_bug.cgi?id=148723
2514
2515         Reviewed by Anders Carlsson.
2516
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::testPath):
2519         (WTR::updateViewOptionsFromTestHeader):
2520         (WTR::TestController::viewOptionsForTest):
2521
2522 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2523
2524         Test commit.
2525
2526 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2527
2528         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2529         https://bugs.webkit.org/show_bug.cgi?id=148693
2530
2531         Reviewed by Anders Carlsson.
2532
2533         * WebKitTestRunner/TestController.cpp:
2534         (WTR::TestController::createOtherPage):
2535         (WTR::TestController::createWebViewWithOptions):
2536
2537 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2538
2539         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2540         https://bugs.webkit.org/show_bug.cgi?id=148529
2541
2542         Reviewed by Darin Adler.
2543
2544         When there are pending EventSender messages after a test finishes,
2545         they could be processed in the main loop started by the
2546         resetStateToConsistentValues(), but the old EventSender has been
2547         replaced by a new one at that point. The new Eventsender can crash
2548         when processing messages that were sent to the old one. To avoid
2549         this, we return early when receiving an EventSender message and
2550         the TestController state is not RunningTest.
2551
2552         * WebKitTestRunner/TestController.cpp:
2553         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2554         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2555
2556 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2557
2558         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2559         https://bugs.webkit.org/show_bug.cgi?id=148528
2560
2561         Reviewed by Darin Adler.
2562
2563         Before r188548 resetStateToConsistentValues() was called in
2564         TestController::run(), before tests are run, but now it's called
2565         for every test in TestInvocation::invoke(), after m_status has
2566         changed to RunningTest.
2567
2568         * WebKitTestRunner/TestController.cpp:
2569         (WTR::TestController::resetStateToConsistentValues): Use
2570         TemporaryChange to reset m_state ot its previous value after reset
2571         is done.
2572
2573 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2574
2575         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2576         that are marked as requiring corresponding tests.
2577         https://bugs.webkit.org/show_bug.cgi?id=148498
2578         <rdar://problem/21555314>
2579
2580         Reviewed by Dan Bernstein and David Kilzer.
2581
2582         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2583         simulate Git's attribute behevaior.
2584         (main): Added "requiresTests" array to contain files that require tests.
2585         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2586         section in ChangeLog.
2587         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2588         however, we check if the file or any containing folder has the given property set to "1" and
2589         return 1 if so; return 0 otherwise.
2590         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2591         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2592
2593 2015-08-26  Andy Estes  <aestes@apple.com>
2594
2595         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2596         https://bugs.webkit.org/show_bug.cgi?id=148506
2597
2598         Reviewed by Brady Eidson.
2599
2600         Added download API tests covering every decision and decision point.
2601         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2602
2603         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2604         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2605         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2606         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2607         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2608         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2609         decision and decision point as a bundle parameter.
2610         (+[MockContentFilterEnabler supportsSecureCoding]):
2611         (-[MockContentFilterEnabler copyWithZone:]):
2612         (-[MockContentFilterEnabler initWithCoder:]):
2613         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2614         (-[MockContentFilterEnabler encodeWithCoder:]):
2615         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2616         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2617         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2618         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2619         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2620         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2621         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2623         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2624         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2625         (+[MockContentFilterEnabler supportsSecureCoding]):
2626         (-[MockContentFilterEnabler copyWithZone:]):
2627         (-[MockContentFilterEnabler initWithCoder:]):
2628         (-[MockContentFilterEnabler dealloc]):
2629         (-[MockContentFilterEnabler encodeWithCoder:]):
2630         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2631         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2632         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2633         (+[ServerRedirectPlugIn initialize]): Deleted.
2634         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2635         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2636         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2637         (TEST): Deleted.
2638
2639 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2640
2641         Skip slow lock tests on Windows/debug
2642         https://bugs.webkit.org/show_bug.cgi?id=148643
2643
2644         Reviewed by Alexey Proskuryakov.
2645
2646         The lock tests simulate a critical section by doing some floating point math, and then either
2647         make those critical sections very long or invoke them many times. This appears to be
2648         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2649         that kind of computation slow.
2650
2651         These tests are almost as useful in release as they are in debug, so it's probably better to
2652         just skip the in debug on platforms where this causes timeouts.
2653
2654         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2655         (TestWebKitAPI::runLockTest):
2656         (TestWebKitAPI::skipSlow):
2657         (TestWebKitAPI::TEST):
2658
2659 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2660
2661         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2662         https://bugs.webkit.org/show_bug.cgi?id=125720
2663
2664         Reviewed by Daniel Bates.
2665
2666         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2667
2668         * DumpRenderTree/AccessibilityUIElement.cpp:
2669         (pressCallback):
2670         (scrollToMakeVisibleWithSubFocusCallback):
2671         (scrollToGlobalPointCallback):
2672         (scrollToMakeVisibleCallback):
2673         (AccessibilityUIElement::getJSClass):
2674         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2675         (AccessibilityUIElement::scrollToMakeVisible):
2676         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2677         (AccessibilityUIElement::scrollToGlobalPoint):
2678         (AccessibilityUIElement::selectedTextRange):
2679         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2680         (AccessibilityUIElement::AccessibilityUIElement):
2681         (AccessibilityUIElement::mathPrescriptsDescription):
2682         (AccessibilityUIElement::scrollToMakeVisible):
2683         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2684         (AccessibilityUIElement::scrollToGlobalPoint):
2685         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2686         (WTR::AccessibilityUIElement::isTextMarkerValid):
2687         (WTR::AccessibilityUIElement::textMarkerForIndex):
2688         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2689         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2690         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2691         (WTR::AccessibilityUIElement::supportedActions):
2692         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2693         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2694         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2695         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2696         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2697         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2698         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2699         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2700         (WTR::AccessibilityUIElement::selectedTextRange):
2701         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2702         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2703         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2704         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2705         (WTR::AccessibilityUIElement::selectedTextRange):
2706
2707 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2708
2709         Add a mysteriously nonproblematic missing comma.
2710
2711         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2712         (TestExpectationParser._collect_matching_tests):
2713         (TestExpectationParser):
2714
2715 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2716
2717         Remove an old temporary script that has served its purpose
2718
2719         * Scripts/convert-test-expectations: Removed.
2720
2721 2015-08-28  Jer Noble  <jer.noble@apple.com>
2722
2723         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2724         https://bugs.webkit.org/show_bug.cgi?id=148579
2725
2726         Reviewed by Anders Carlsson.
2727
2728         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2729
2730         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2731         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2732
2733         * DumpRenderTree/mac/DumpRenderTree.mm:
2734         (resetWebPreferencesToConsistentValues):
2735         (resetWebViewToConsistentStateBeforeTesting): 
2736         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2737         (WTR::initializeWebViewConfiguration):
2738
2739 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2742         https://bugs.webkit.org/show_bug.cgi?id=148592
2743
2744         Reviewed by Tim Horton.
2745
2746         * Scripts/webkitpy/port/base.py:
2747         (Port.to.setup_environ_for_server):
2748         (Port.to):
2749         (Port.to._append_value_colon_separated):
2750         (Port.to.show_results_html_file):
2751         * Scripts/webkitpy/port/ios.py:
2752         (IOSSimulatorPort.setup_environ_for_server):
2753         * Scripts/webkitpy/port/mac.py:
2754         (MacPort.setup_environ_for_server):
2755
2756 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2757
2758         LICM should be sound even if the CFG has changed
2759         https://bugs.webkit.org/show_bug.cgi?id=148259
2760
2761         Reviewed by Benjamin Poulain.
2762
2763         Add a utility for creating tests that set some uncommon option.
2764
2765         * Scripts/run-jsc-stress-tests:
2766
2767 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2768
2769         [Win] Unreviewed EWS correction.
2770
2771         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2772
2773 2015-08-28  Jer Noble  <jer.noble@apple.com>
2774
2775         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2776         https://bugs.webkit.org/show_bug.cgi?id=147512
2777
2778         Reviewed by Anders Carlsson.
2779
2780         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2781         to a consistent (true) value.
2782
2783         * DumpRenderTree/mac/DumpRenderTree.mm:
2784         (setDefaultsToConsistentValuesForTesting):
2785         * WebKitTestRunner/TestController.cpp:
2786         (WTR::TestController::resetPreferencesToConsistentValues):
2787
2788 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2789
2790         Add navigation gesture callbacks to WKPageNavigationClient
2791         https://bugs.webkit.org/show_bug.cgi?id=148568
2792         <rdar://problem/22371346>
2793
2794         Reviewed by Anders Carlsson.
2795
2796         * WebKitTestRunner/TestController.cpp:
2797         (WTR::TestController::createOtherPage):
2798         (WTR::TestController::createWebViewWithOptions):
2799         Add some zeroes.
2800
2801 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2802
2803         [Mac] kill-old-processes should kill more processes
2804         https://bugs.webkit.org/show_bug.cgi?id=148577
2805
2806         Reviewed by Tim Horton.
2807
2808         * BuildSlaveSupport/kill-old-processes:
2809
2810 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2811
2812         The status message for combined builder queues should say "all builds succeeded" if everything
2813         built correctly.
2814         https://bugs.webkit.org/show_bug.cgi?id=148535
2815
2816         Reviewed by David Kilzer and Alexey Proskuryakov.
2817
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2819         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2820         say "all builds succeeded" if everything built correctly.
2821
2822 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2823
2824         [GTK] Simplify the internal API to create a WebView
2825         https://bugs.webkit.org/show_bug.cgi?id=148570
2826
2827         Reviewed by Žan Doberšek.
2828
2829         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2830         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2831         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2832         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2833         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2834         passing the received PageConfiguration.
2835         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2836         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2837         passing the received PageConfiguration.
2838
2839 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2840
2841         iOS Simulator API tests fails as Simulator is not running
2842         https://bugs.webkit.org/show_bug.cgi?id=148501
2843         rdar://problem/22447525
2844
2845         Reviewed by Daniel Bates.
2846
2847         This change is a workaround for <rdar://problem/22388812>.
2848
2849          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2850          and quit it on program termination when running tests on the iOS port.
2851          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2852          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2853
2854 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2855
2856         Make DLLLauncherMain executables dependent on dll
2857         https://bugs.webkit.org/show_bug.cgi?id=148548
2858
2859         Reviewed by Brent Fulgham.
2860
2861         * DumpRenderTree/CMakeLists.txt:
2862         * DumpRenderTree/PlatformWin.cmake:
2863         * MiniBrowser/win/CMakeLists.txt:
2864         * TestWebKitAPI/CMakeLists.txt:
2865         * TestWebKitAPI/PlatformWin.cmake:
2866
2867 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2868
2869         Remove Mac slaves 188/189 after being replaced with 400/401.
2870         
2871         Unreviewed.
2872         
2873         * BuildSlaveSupport/build.webkit.org-config/config.json:
2874
2875 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2876
2877         Add two bots to the Mac Yosemite queue.
2878         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2879         
2880         Unreviewed.
2881         
2882         * BuildSlaveSupport/build.webkit.org-config/config.json:
2883
2884 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2885
2886         [Win CMake] Fix incremental build after r188673
2887         https://bugs.webkit.org/show_bug.cgi?id=148539
2888
2889         Reviewed by Brent Fulgham.
2890
2891         * TestWebKitAPI/PlatformWin.cmake:
2892         Copy forwarding headers from WebCore before building in case that was not yet done.
2893         It used to be done when running CMake, but now it's a build step.
2894
2895 2015-08-27  Nan Wang  <n_wang@apple.com>
2896
2897         AX: Fix accessibility/select-element-at-index.html test
2898         https://bugs.webkit.org/show_bug.cgi?id=148516
2899
2900         Reviewed by Chris Fleizach.
2901
2902         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2903
2904         * DumpRenderTree/AccessibilityUIElement.cpp:
2905         (setSelectedChildCallback):
2906         (setSelectedChildAtIndexCallback):
2907         (removeSelectionAtIndexCallback):
2908         (elementAtPointCallback):
2909         (sentenceAtOffsetCallback):
2910         (stringForSelectionCallback):
2911         (AccessibilityUIElement::getJSClass):
2912         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2913         (AccessibilityUIElement::setSelectedChild):
2914         (AccessibilityUIElement::setSelectedChildAtIndex):
2915         (AccessibilityUIElement::removeSelectionAtIndex):
2916         (AccessibilityUIElement::accessibilityValue):
2917         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2918         (WTR::AccessibilityUIElement::wordAtOffset):
2919         (WTR::AccessibilityUIElement::lineAtOffset):
2920         (WTR::AccessibilityUIElement::sentenceAtOffset):
2921         (WTR::AccessibilityUIElement::isSelectable):
2922         (WTR::AccessibilityUIElement::isMultiSelectable):
2923         (WTR::AccessibilityUIElement::setSelectedChild):
2924         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2925         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2926         (WTR::AccessibilityUIElement::selectedChildrenCount):
2927         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2928         (WTR::AccessibilityUIElement::isExpanded):
2929         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2930         (WTR::AccessibilityUIElement::setSelectedChild):
2931         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2932         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2933         (WTR::AccessibilityUIElement::accessibilityValue):
2934
2935 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2936
2937         Build fix after r188982
2938
2939         * MiniBrowser/win/CMakeLists.txt:
2940         The directory structure changed in the move.
2941
2942 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2943
2944         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2945
2946         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2947
2948         * gtk/install-dependencies:
2949
2950 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2951
2952         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2953
2954         * Scripts/run-gtk-tests:
2955         (TestRunner):
2956
2957 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2958
2959         Fix GTK+ WTR crashes in initializeMainRunLoop()
2960
2961         Rubber-stamped by Žan Doberšek.
2962
2963         Initialize threading and main thread before
2964         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2965         the RunLoop uses isMainThread() to decide whether to create a new
2966         GMainContext or use the default one. Also use RunLoop::run() and
2967         ::stop() instead of gtk_main/quit.
2968
2969         * WebKitTestRunner/TestController.cpp:
2970         (WTR::TestController::initialize):
2971         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2972         (WTR::TestController::notifyDone):
2973         (WTR::TestController::platformRunUntil):
2974
2975 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2976
2977         Unreviewed, further shorten a test that times out because it's very long
2978         running.
2979
2980         I've locally run these tests on repeat for 24 hours and found no genuine
2981         failures, like deadlocks. So, the timeouts are probably because the test
2982         machine is slow and debug is slow. We should just run this test for fewer
2983         iterations.
2984
2985         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2986         (TestWebKitAPI::TEST):
2987
2988 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2989
2990         Unreviewed build fix attempt on EFL
2991
2992         * WebKitTestRunner/PlatformEfl.cmake:
2993
2994 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2995
2996         Build fix after r188982
2997
2998         * MiniBrowser/win/CMakeLists.txt:
2999         Find .rc files in correct directory.
3000
3001 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3002
3003         [EFL] Bump cairo version to 1.14.2
3004         https://bugs.webkit.org/show_bug.cgi?id=148474
3005
3006         Reviewed by Csaba Osztrogonác.
3007
3008         * efl/jhbuild.modules:
3009
3010 2015-08-26  Andy Estes  <aestes@apple.com>
3011
3012         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3013         https://bugs.webkit.org/show_bug.cgi?id=147651
3014
3015         Rubber-stamped by Brady Eidson.
3016
3017         Taught TestRunner how to decide the navigation policy after a delay.
3018
3019         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3021         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3022         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3023         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3024         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3025         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3026         * WebKitTestRunner/TestController.cpp:
3027         (WTR::TestController::initialize):
3028         (WTR::TestController::resetStateToConsistentValues):
3029         (WTR::TestController::decidePolicyForNavigationAction):
3030         * WebKitTestRunner/TestController.h:
3031         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3032         * WebKitTestRunner/TestInvocation.cpp:
3033         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3034
3035 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3036
3037         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3038         https://bugs.webkit.org/show_bug.cgi?id=148485
3039
3040         Reviewed by Alex Christensen
3041
3042         Move the WinLauncher project and source files to a subdirectory
3043         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3044         source code and project files.
3045         
3046         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3047         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3048         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3049         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3050         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3051         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3052         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3053         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3054         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3055         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3056         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3057         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3058         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3059         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3060         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3061         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3062         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3063         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3064         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3065         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3066         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3067         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3068         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3069         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3070         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3071         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3072         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3073         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3074         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3075         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3076         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3077         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3078         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3079         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3080         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3081         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3082         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3083         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3084         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3085         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3086         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3087         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3088         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3089         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3090         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3091         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3092         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3093         * MiniBrowser/win: Copied from WinLauncher.
3094         * MiniBrowser/win/Common.cpp:
3095         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3096         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3097         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3098         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3099         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3100         * MiniBrowser/win/PageLoadTestClient.cpp:
3101         * MiniBrowser/win/PageLoadTestClient.h:
3102         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3103         * MiniBrowser/win/ResourceLoadDelegate.h:
3104         * MiniBrowser/win/WinLauncher.cpp: Removed.
3105         * MiniBrowser/win/WinLauncher.h: Removed.
3106         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3107         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3108         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3109         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3110         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3111         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3112         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3113         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3121         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3122         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3123         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3124         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3125         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3126         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3127         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3128         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3129         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3130         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3131         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3132         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3133         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3134         * MiniBrowser/win/WinMain.cpp:
3135         * WinLauncher: Removed.
3136         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3137         * WinLauncher/AccessibilityDelegate.h: Removed.
3138         * WinLauncher/CMakeLists.txt: Removed.
3139         * WinLauncher/Common.cpp: Removed.
3140         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3141         * WinLauncher/DOMDefaultImpl.h: Removed.
3142         * WinLauncher/PageLoadTestClient.cpp: Removed.
3143         * WinLauncher/PageLoadTestClient.h: Removed.
3144         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3145         * WinLauncher/PrintWebUIDelegate.h: Removed.
3146         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3147         * WinLauncher/ResourceLoadDelegate.h: Removed.
3148         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3149         * WinLauncher/WebDownloadDelegate.h: Removed.
3150         * WinLauncher/WinLauncher.cpp: Removed.
3151         * WinLauncher/WinLauncher.h: Removed.
3152         * WinLauncher/WinLauncher.vcxproj: Removed.
3153         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3154         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3155         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3156         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3157         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3158         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3159         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3160         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3163         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3164         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3165         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3166         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3167         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3168         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3170         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3171         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3172         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3173         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3174         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3175         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3176         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3177         * WinLauncher/WinLauncherReplace.h: Removed.
3178         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3179         * WinLauncher/WinLauncherWebHost.h: Removed.
3180         * WinLauncher/WinMain.cpp: Removed.
3181         * WinLauncher/resource.h: Removed.
3182         * WinLauncher/stdafx.cpp: Removed.
3183         * WinLauncher/stdafx.h: Removed.
3184         * win/AssembleBuildLogs/AssembleLogs.cmd:
3185
3186 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3187
3188         [Win] Simplify menu handling code in WinLauncher
3189         https://bugs.webkit.org/show_bug.cgi?id=148461
3190
3191         Reviewed by Zalan Bujtas.
3192
3193         Revise 'ToggleMenuItem' to return a boolean value indicating if
3194         it handled the message. Revise WndProc to use this to decide if it
3195         should pass the message on to the default handler, rather than
3196         duplicating the logic in both places.
3197         
3198         * WinLauncher/Common.cpp:
3199         (ToggleMenuItem): Return true if the menu item message was handled.
3200         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3201         the message tothe default handler.
3202
3203 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3204
3205         Remove unused code after r188948
3206         https://bugs.webkit.org/show_bug.cgi?id=148467
3207
3208         Reviewed by Gyuyoung Kim.
3209
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::TestController::platformPreferences): Deleted.
3212
3213 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3214
3215         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3216         https://bugs.webkit.org/show_bug.cgi?id=148377
3217
3218         Reviewed by Carlos Garcia Campos.
3219
3220         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3221         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3222         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3223         EFL and GTK at the moment.
3224
3225         * WebKitTestRunner/TestController.cpp:
3226         (WTR::TestController::platformWillRunTest):
3227         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3228         (WTR::TestController::platformPreferences):
3229         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3230         (WTR::TestController::platformPreferences):
3231
3232 2015-08-25  Nan Wang  <n_wang@apple.com>
3233
3234         AX: Enable accessibility/aria-controls.html test for mac
3235         https://bugs.webkit.org/show_bug.cgi?id=148458
3236
3237         Reviewed by Chris Fleizach.
3238
3239         Implemented ariaControlsElementAtIndex(unsigned index).
3240
3241         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3242         (AccessibilityUIElement::ariaControlsElementAtIndex):
3243         (AccessibilityUIElement::disclosedRowAtIndex):
3244         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3245         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3246
3247 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3248
3249         Remove python tests for PassRefPtr 
3250         https://bugs.webkit.org/show_bug.cgi?id=148463
3251
3252         Reviewed by Andy Estes.
3253
3254         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3255
3256         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3257         (PassPtrTest): Deleted.
3258         (PassPtrTest.assert_pass_ptr_check): Deleted.
3259         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3260         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3261         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3262         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3263         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3264         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3265
3266 2015-08-25  Andy Estes  <aestes@apple.com>
3267
3268         [iOS] run-webkit-tests fails if watchOS SDK is installed
3269         https://bugs.webkit.org/show_bug.cgi?id=148453
3270
3271         Reviewed by David Kilzer.
3272
3273         * Scripts/webkitpy/xcode/simulator.py:
3274         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3275         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3276
3277 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3278
3279         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3280         https://bugs.webkit.org/show_bug.cgi?id=148197
3281         rdar://problem/22334382
3282
3283         Reviewed by Daniel Bates.
3284
3285         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3286         * Scripts/webkitpy/port/ios.py:
3287         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3288         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3289         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3290         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3291         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3292
3293 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3294
3295         Remove PassRefPtr style check rule
3296         https://bugs.webkit.org/show_bug.cgi?id=148432
3297
3298         Reviewed by Andreas Kling.
3299
3300         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3301
3302         * Scripts/webkitpy/style/checkers/cpp.py:
3303         (_check_parameter_name_against_text): Deleted.
3304         (check_function_definition_and_pass_ptr): Deleted.
3305         (check_function_definition): Deleted.
3306         (check_pass_ptr_usage): Deleted.
3307         (process_line): Deleted.
3308         (CppChecker): Deleted.
3309
3310 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3311
3312         [Win] Expose "Inverted Colors" option in WinLauncher
3313         https://bugs.webkit.org/show_bug.cgi?id=148451
3314
3315         Reviewed by Tim Horton.
3316
3317         Add the ability to toggle the "Inverted Colors" preference
3318         in WinLauncher.
3319         
3320         * WinLauncher/Common.cpp:
3321         (ToggleMenuItem): Toggle the feature when the menu item
3322         is selected.
3323         (WndProc): Recognize the new menu option.
3324         * WinLauncher/WinLauncher.cpp:
3325         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3326         Colors" turned off.
3327         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3328         entry for "Invert Colors".
3329         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3330
3331 2015-08-25  Nan Wang  <n_wang@apple.com>
3332
3333         [Mac] accessibility/document-attributes.html fails
3334         https://bugs.webkit.org/show_bug.cgi?id=116636
3335
3336         Reviewed by Chris Fleizach.
3337
3338         Implemented documentURI() and documentEncoding().
3339
3340         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3341         (AccessibilityUIElement::documentEncoding):
3342         (AccessibilityUIElement::documentURI):
3343         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3344         (WTR::AccessibilityUIElement::documentEncoding):
3345         (WTR::AccessibilityUIElement::documentURI):
3346
3347 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3348
3349         [Win] Unreviewed test gardening.
3350
3351         Fix another case where the logging string is constructed using the variable 'frame',
3352         but the method argument is not given a name. This causes the global 'frame' value to
3353         be used, producing incorrect output.
3354
3355         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3356         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3357         argument.
3358
3359 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3360
3361         (Finally...) get rid of WKViewIOS
3362         https://bugs.webkit.org/show_bug.cgi?id=148404
3363
3364         Reviewed by Anders Carlsson.
3365
3366         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3367         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3368         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3369         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3370         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3371         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3372         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3373         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3374         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3375         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3376         Mark tests that use WKBrowsingContextController as Mac-only.
3377
3378         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3379         (WTR::AccessibilityController::addNotificationListener):
3380         * WebKitTestRunner/ios/mainIOS.mm:
3381         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3382         Import UIKit instead of depending on WKView.h to do so.
3383
3384 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3385
3386         Add support to dashboard for displaying Git SHA's as revisions.
3387         https://bugs.webkit.org/show_bug.cgi?id=148387
3388
3389         Reviewed by Daniel Bates.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3392         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3394         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3396         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3397
3398 2015-08-24  Andy Estes  <aestes@apple.com>
3399
3400         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3401
3402         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3403
3404 2015-08-23  Andy Estes  <aestes@apple.com>
3405
3406         Addressed a missed piece of review feedback from r188851.
3407
3408         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3409
3410 2015-08-23  Andy Estes  <aestes@apple.com>
3411
3412         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3413         https://bugs.webkit.org/show_bug.cgi?id=147872
3414         rdar://problem/22044000
3415
3416         Reviewed by Dan Bernstein.
3417         
3418         Added an API test.
3419
3420         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3422         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3423         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3424         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3425         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3426         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3428         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3429         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3430         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3431
3432 2015-08-23  Andy Estes  <aestes@apple.com>
3433
3434         Fixed the 32-bit Mac build after r188844.
3435
3436         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3437         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3438
3439 2015-08-22  Andy Estes  <aestes@apple.com>
3440
3441         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3442         https://bugs.webkit.org/show_bug.cgi?id=148317
3443
3444         Reviewed by Dan Bernstein.
3445
3446         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3447         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3448         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3449         when creating WKWebViews.
3450
3451         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3452         added a new API test for bundle parameters.
3453
3454         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3455         named its executable TestWebKitAPI.bundle.
3456         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3458         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3459         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3460         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3461         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3462         bundle parameter and asked for an initial notification.
3463         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3464         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3465         mirror its value in the main frame's JSContext.
3466         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3467         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3468         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3469         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3470         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3471         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3472         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3473         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3474         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3475         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3476
3477 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3478
3479         URTBF after r188828.
3480
3481         * WebKitTestRunner/PlatformWebView.h:
3482
3483 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3484
3485         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3486         https://bugs.webkit.org/show_bug.cgi?id=148356
3487
3488         Reviewed by Darin Adler.
3489
3490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3491         (BuildbotCombinedQueueView.prototype.update):
3492
3493 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3494
3495         build.webkit.org/dashboard: Respect step's hidden flag
3496         https://bugs.webkit.org/show_bug.cgi?id=148357
3497
3498         Reviewed by Darin Adler.
3499
3500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3501         (BuildbotIteration.prototype._parseData):
3502
3503 2015-08-23  Nan Wang  <n_wang@apple.com>
3504
3505         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3506         https://bugs.webkit.org/show_bug.cgi?id=148328
3507
3508         Reviewed by Darin Adler.
3509
3510         We should only expose stringValue() when value attribute is set.
3511
3512         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3513         (AccessibilityUIElement::stringValue):
3514         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3515         (WTR::AccessibilityUIElement::stringValue):
3516
3517 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3518
3519         Remove style checking rule regarding OwnPtr and PassOwnPtr
3520         https://bugs.webkit.org/show_bug.cgi?id=148360
3521
3522         Reviewed by Darin Adler.
3523
3524         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3525         Removed it.
3526
3527         * Scripts/do-webcore-rename:
3528         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3529         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3530         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3531         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3532         (WebKitStyleTest.test_names): Deleted.
3533
3534 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3535
3536         WebKitTestRunner should use WKWebView on OS X and iOS
3537         https://bugs.webkit.org/show_bug.cgi?id=143743
3538         <rdar://problem/16947123>
3539
3540         Reviewed by Anders Carlsson.
3541         Patch by Enrica Casucci and myself.
3542
3543         * WebKitTestRunner/PlatformWebView.h:
3544         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3545         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3546         instead of WKContext and WKPageGroup.
3547
3548         Remove the unused, always-true windowSnapshotEnabled().
3549         While technically some platforms don't have window snapshotting,
3550         they just return null instead of implementing windowSnapshotEnabled().
3551
3552         * WebKitTestRunner/TestController.h:
3553         * WebKitTestRunner/TestContro