[Fetch API] Add fetch API compile time flag
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         [Fetch API] Add fetch API compile time flag
4         https://bugs.webkit.org/show_bug.cgi?id=152254
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitperl/FeatureList.pm:
9
10 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
11
12         Unreviewed.
13
14         Added files that have impact in building Streams API to the watchlist.
15
16         * Scripts/webkitpy/common/config/watchlist:
17
18 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
19
20         Unreviewed.
21
22         Added imported tests to Streams API watchlist.
23
24         * Scripts/webkitpy/common/config/watchlist:
25
26 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
27
28         Remove default copy of wpt testharness.js when launching wpt server
29         https://bugs.webkit.org/show_bug.cgi?id=152298
30
31         Reviewed by Darin Adler.
32
33         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
34         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
35
36 2015-12-15  David Kilzer  <ddkilzer@apple.com>
37
38         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
39         <http://webkit.org/b/152314>
40
41         Reviewed by Daniel Bates.
42
43         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
44         code path to exit immediately when calling main().
45         Unfortunately, DumpRenderTreeMain.mm was used for both
46         DumpRenderTree command-line binary and DumpRenderTree.app, which
47         meant that the app would exit immediately with no error code
48         when run!
49
50         The workaround is to introduce a separate source file called
51         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
52         already does.
53
54         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
55         DumpRenderTreeAppMain.mm to the project.  Make it the only
56         compiled source for the DumpRenderTree.app target.
57         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
58         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
59         case someone tries mistakenly to use the app.
60         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
61         Link to JavaScriptCore.framework on iOS for the assert.
62         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
63         Link to JavaScriptCore.framework on OS X for the assert.  Remove
64         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
65         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
66         (main): Add assert for iOS so that a crash occurs if someone
67         tries to run the wrong command.
68
69 2015-12-14  Tim Horton  <timothy_horton@apple.com>
70
71         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
72         https://bugs.webkit.org/show_bug.cgi?id=152266
73         <rdar://problem/22092676>
74
75         Reviewed by Simon Fraser.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
79         Add a test that crashed before this change, and doesn't crash after.
80
81 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
82
83         AX: iOS: Text field variations do not have the correct traits
84         https://bugs.webkit.org/show_bug.cgi?id=152237
85
86         Reviewed by Mario Sanchez Prada.
87
88         Add iOS calls for determing if an object is a search field or a text area.
89
90         * DumpRenderTree/AccessibilityUIElement.cpp:
91         (getIsSearchFieldCallback):
92         (getIsTextAreaCallback):
93         (stringForSelectionCallback):
94         (AccessibilityUIElement::getJSClass):
95         * DumpRenderTree/AccessibilityUIElement.h:
96         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
97         (AccessibilityUIElement::identifier):
98         (AccessibilityUIElement::isTextArea):
99         (AccessibilityUIElement::isSearchField):
100         (AccessibilityUIElement::traits):
101         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
102         (WTR::AccessibilityUIElement::scrollPageRight):
103         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
104         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
105         (WTR::AccessibilityUIElement::isSearchField):
106         (WTR::AccessibilityUIElement::isTextArea):
107         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
108         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
109         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
110         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
111         (WTR::AccessibilityUIElement::isTextArea):
112         (WTR::AccessibilityUIElement::isSearchField):
113         (WTR::AccessibilityUIElement::rowCount):
114
115 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
116
117         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
118         https://bugs.webkit.org/show_bug.cgi?id=152252
119
120         Reviewed by Sergio Villar Senin.
121
122         * gtk/install-dependencies: Add libtool-bin to the list of packages required
123         for building the JHBuild on Debian systems.
124
125 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
126
127         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
128         https://bugs.webkit.org/show_bug.cgi?id=152156
129
130         Reviewed by Dan Bernstein.
131
132         Our frameworks should appropriately prefix all ObjC classes,
133         not just external symbols.
134
135         * Scripts/check-for-inappropriate-objc-class-names:
136         Remove the -g switch to check all ObjC class names.
137
138 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
139
140         [MediaStream] Expose media capture devices persistent permissions to WebCore
141         https://bugs.webkit.org/show_bug.cgi?id=152087
142
143         Add support for the new user media permission checker page UI client method.
144
145         Reviewed by Chris Dumez.
146
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::decidePolicyForUserMediaPermissionRequest):
149         (WTR::checkUserMediaPermissionForOrigin):
150         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
151         (WTR::TestController::createWebViewWithOptions): Ditto.
152         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
153         (WTR::originUserVisibleName): New, create a string for the origin.
154         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
155           according to the state of the origin permission map.
156         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
157           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
158         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
159           origin permission map.
160         * WebKitTestRunner/TestController.h:
161
162 2015-12-10  Alex Christensen  <achristensen@webkit.org>
163
164         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
165         https://bugs.webkit.org/show_bug.cgi?id=152022
166         rdar://problem/23763584
167
168         Reviewed by Darin Adler.
169
170         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
172         (WTR::InjectedBundlePage::willSendRequestForFrame):
173         * WebKitTestRunner/InjectedBundle/TestRunner.h:
174         (WTR::TestRunner::setWillSendRequestReturnsNull):
175         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
176         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
177         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
178         (WTR::TestRunner::willSendRequestHTTPBody):
179         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
180
181 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
182
183         Remove additional simulator checks before running layout-tests
184         https://bugs.webkit.org/show_bug.cgi?id=152146
185
186         Reviewed by Darin Adler.
187
188         * Scripts/webkitpy/port/ios.py:
189         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
190         * Scripts/webkitpy/xcode/simulator.py:
191         (Simulator._boot_and_shutdown_simulator_device): Deleted.
192         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
193
194 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
195
196         Run atleast one simulator even if max process limit is low
197         https://bugs.webkit.org/show_bug.cgi?id=152081
198         <rdar://problem/23819694>
199
200         Reviewed by Alexey Proskuryakov.
201
202 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
203
204         [GTK] Crash in WebProcess when loading large content with custom URI schemes
205         https://bugs.webkit.org/show_bug.cgi?id=144262
206
207         Reviewed by Carlos Garcia Campos.
208
209         Added new unit test to check the additional scenarios we now
210         handle for custom URI schemes.
211
212         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
213         (generateHTMLContent): New helper function to generate big enough content.
214         (testWebContextURIScheme): New unit test.
215
216 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
217
218         [EFL] Fix unhandled web process message when launching MiniBrowser
219         https://bugs.webkit.org/show_bug.cgi?id=152048
220
221         Reviewed by Gyuyoung Kim.
222
223         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
224         (TestWebKitAPI::TEST):
225
226 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
227
228         [GTK] Add API to handle beforeunload events
229         https://bugs.webkit.org/show_bug.cgi?id=139090
230
231         Reviewed by Gustavo Noronha Silva.
232
233         * MiniBrowser/gtk/BrowserWindow.c:
234         (browserWindowConstructed):
235         (browserWindowDeleteEvent):
236         (browser_window_class_init):
237         Handle delete-event to prevent the window from being closed when
238         the page has beforeunload handlers. Use
239         webkit_web_view_try_close() when the window is requested to be
240         closed.
241         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
242         (testWebViewJavaScriptDialogs):
243         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
244         script dialog type.
245
246 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
247
248         Refactored initialization code in LoadTrackingTest.
249
250         Rubber-stamped by Carlos Garcia Campos.
251
252         Small refactoring to make sure that the state of a LoadTrackingTest
253         gets properly reset before loading new web content.
254
255         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
256         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
257         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
258         functions and reset the remaining local variables.
259         (LoadTrackingTest::loadURI): Call reset();
260         (LoadTrackingTest::loadHtml): Ditto.
261         (LoadTrackingTest::loadPlainText): Ditto.
262         (LoadTrackingTest::loadBytes): Ditto.
263         (LoadTrackingTest::loadRequest): Ditto.
264         (LoadTrackingTest::reload): Ditto.
265         (LoadTrackingTest::goBack): Ditto.
266         (LoadTrackingTest::goForward): Ditto.
267
268 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
269
270         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
271         https://bugs.webkit.org/show_bug.cgi?id=151942
272
273         Reviewed by Darin Adler.
274
275         * MiniBrowser/efl/main.c:
276         (window_create): Enable offline web application cache feature on MiniBrowser.
277         (elm_main):
278
279 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
280
281         https://bugs.webkit.org/show_bug.cgi?id=151243
282         <rdar://problem/22955197>
283
284         Reviewed by Alexey Proskuryakov.
285
286         * LayoutTestRelay/LayoutTestRelay/main.m:
287         (getTestingSimDevice): Use separate testing device for each worker.
288         * Scripts/webkitpy/layout_tests/controllers/manager.py:
289         (Manager.run): Perform cleanup even if setup fails.
290         * Scripts/webkitpy/port/ios.py:
291         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
292         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
293         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
294         (IOSSimulatorPort._quit_ios_simulator): Same
295         (IOSSimulatorPort.clean_up_test_run): Same
296         (IOSSimulatorPort.check_sys_deps): Same
297         (IOSSimulatorPort.testing_device): Same
298         (IOSSimulatorPort.reset_preferences): Same
299         (IOSSimulatorPort.get_simulator_path): Return simulator path.
300         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
301         * Scripts/webkitpy/xcode/simulator.py:
302         (Device.delete): Delete the simulator device.
303         (Simulator.delete_device): Same
304         (Simulator.wait_until_device_is_booted): Wait for device booting.
305
306 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
307
308         [EFL] Add API to provide preferences before creating ewk_view
309         https://bugs.webkit.org/show_bug.cgi?id=151587
310
311         Reviewed by Gyuyoung Kim.
312
313         * MiniBrowser/efl/main.c:
314         (on_key_down):
315         (quit):
316         (window_create):
317         Moved settings related code to configuration() not to update settings
318         whenever ewk_view is created.
319         (configuration):
320         (elm_main):
321
322 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         Unreviewed. Fix GTK+ API tests after r193639.
325
326         The new jhbuild version needs some more variables ot be present in
327         the builtin dict, even if they are set to None.
328
329         * jhbuild/jhbuildutils.py:
330         (enter_jhbuild_environment_if_available):
331
332 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
333
334         [GTK] Notify WebCore when notification is clicked
335         https://bugs.webkit.org/show_bug.cgi?id=151951
336
337         Reviewed by Carlos Garcia Campos.
338
339         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
340         (testWebViewNotification): test the new API.
341
342 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
343
344         'jhbuild build' should fail immediately when building any module fails
345         https://bugs.webkit.org/show_bug.cgi?id=145697
346
347         Reviewed by Carlos Garcia Campos.
348
349         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
350         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
351         Everything is placed under lib instead of lib64 now.
352         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
353         --exit-on-error when running 'jhbuild build'.
354         * jhbuild/jhbuildrc_common.py:
355         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
356         jhbuild should be able to handle these for us without breaking things....
357
358 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
359
360         Add support to import w3c tests from a repository with a different root that the main repo dir
361         https://bugs.webkit.org/show_bug.cgi?id=151751
362
363         Reviewed by Ryosuke Niwa and Youenn Fablet.
364
365         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
366         in a different directory than the repository root.
367
368         This patch introduces a new parameter tests_directory that we will use as root directory to search for
369         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
370         requires having the copy_path lists including tuples of origin and destination directories.
371
372         * Scripts/webkitpy/w3c/test_downloader.py:
373         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
374         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
375         * Scripts/webkitpy/w3c/test_importer_unittest.py:
376         (TestImporterTest.test_tests_directory): Test.
377
378 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
379
380         Mock TestRepositories in W3C importer tests
381         https://bugs.webkit.org/show_bug.cgi?id=151938
382
383         Reviewed by Youenn Fablet.
384
385         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
386         is because the test repository method reading the file was using the filesystem directly instead of taking the
387         host one. This patch changes that.
388
389         * Scripts/webkitpy/w3c/test_downloader.py:
390         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
391         default one.
392         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
393         * Scripts/webkitpy/w3c/test_importer_unittest.py:
394         (TestImporterTest.test_harnesslinks_conversion):
395         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
396
397 2015-12-07  David Kilzer  <ddkilzer@apple.com>
398
399         TestNetscapePlugIn: Address review comment on 193607
400         <http://webkit.org/b/151881>
401
402         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
403         (testSetStatus): Initializing std::unique_ptr<char[]> with
404         nullptr is redundant.
405
406 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         [GTK] Add webkit_uri_request_get_http_method
409         https://bugs.webkit.org/show_bug.cgi?id=151601
410
411         Reviewed by Martin Robinson.
412
413         Add test case to check HTTP method of WebKitURIRequest.
414
415         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
416         (testURIRequestHTTPMethod):
417         (serverCallback):
418         (beforeAll):
419         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
420         (sendRequestCallback):
421
422 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
423
424         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
425         https://bugs.webkit.org/show_bug.cgi?id=79918
426
427         Reviewed by Gustavo Noronha Silva.
428
429         Add unit tests to check the different console messages.
430
431         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
432         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
433         (ConsoleMessageTest::ConsoleMessage::operator==):
434         (ConsoleMessageTest::consoleMessageReceivedCallback):
435         (ConsoleMessageTest::ConsoleMessageTest):
436         (ConsoleMessageTest::~ConsoleMessageTest):
437         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
438         (testWebKitConsoleMessageConsoleAPI):
439         (testWebKitConsoleMessageJavaScriptException):
440         (testWebKitConsoleMessageNetworkError):
441         (testWebKitConsoleMessageSecurityError):
442         (beforeAll):
443         (afterAll):
444         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
445         (consoleMessageSentCallback):
446         (pageCreatedCallback):
447
448 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
449
450         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
451         https://bugs.webkit.org/show_bug.cgi?id=151934
452
453         Reviewed by Csaba Osztrogonác.
454
455         * MiniBrowser/efl/main.c:
456         (on_window_deletion): Revert the changes of r192767.
457
458 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
459
460         [GTK] update-webkitgtk-libs cannot build mesa
461         https://bugs.webkit.org/show_bug.cgi?id=151535
462
463         Reviewed by Martin Robinson.
464
465         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
466         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
467         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
468         does not have a stable API and we cannot expect mesa to be buildable unless we control the
469         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
470         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
471
472         * gtk/jhbuild.modules:
473
474 2015-12-07  Philippe Normand  <pnormand@igalia.com>
475
476         [GTK][Mac] libWebExtensionTest link error
477         https://bugs.webkit.org/show_bug.cgi?id=150802
478
479         Reviewed by Carlos Garcia Campos.
480
481         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
482
483 2015-12-06  David Kilzer  <ddkilzer@apple.com>
484
485         TestNetscapePlugIn: Fix leaks found by static analyzer
486         <http://webkit.org/b/151881>
487
488         Reviewed by Darin Adler.
489
490         Fixes the following leaks found by the static analyzer:
491             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
492                     return false;
493                            ^~~~~
494             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
495                     return false;
496                            ^~~~~
497             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
498                     return false;
499                            ^~~~~
500
501         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
502         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
503         early return if allocation fails.
504         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
505         Make sure to call fclose() on filehandle, even for an early
506         return.
507         (testSetStatus): Switch to using std::unique_ptr<char[]>.
508
509 2015-12-05  David Kilzer  <ddkilzer@apple.com>
510
511         prepare-ChangeLog: Fix some warning messages when using svn
512         <http://webkit.org/b/151914>
513
514         Reviewed by Daniel Bates.
515
516         * Scripts/prepare-ChangeLog:
517         (generateFunctionLists): Simplify logic so that we never call
518         normalizePath() with an undefined value.
519         (attributeCommand): Quote $subPath for the shell so that we
520         don't try to run "svn propget" on invalid paths.
521
522 2015-12-04  David Kilzer  <ddkilzer@apple.com>
523
524         TestNetscapePlugIn: Fix remaining static analyzer warnings
525         <http://webkit.org/b/151888>
526
527         Reviewed by Alexey Proskuryakov.
528
529         Fixes the following static analyzer warnings:
530             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
531                     CRASH();
532                     ^~~~~~~
533             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
534                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
535                 ^~~~~~~~~~~~~~~~
536             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
537                 return obj->pluginTest->NPP_SetWindow(window);
538                        ^~~~~~~~~~~~~~~
539             2 warnings generated.
540
541         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
542         (CRASH): Use __builtin_trap() for gcc/clang.
543         (NPP_SetWindow): Add early return if obj is nullptr.
544
545 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
546
547         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
548         https://bugs.webkit.org/show_bug.cgi?id=151797
549
550         Reviewed by Martin Robinson.
551
552         Since we switched to use the network process to run the unit tests
553         the test /webkit2/WebKitWebResource/get-data sometimes fails and
554         sometimes passes. We are now also getting the notification for the
555         css image. Since we wait for 3 resources, sometimes the css image
556         is loaded before and then checkResourceData is called for it, but
557         not handled. When the css image is the last one loaded the test
558         passes. So, we just need to wait for the 4 resources.
559
560         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
561         (testWebResourceGetData):
562
563 2015-12-03  David Kilzer  <ddkilzer@apple.com>
564
565         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
566         <http://webkit.org/b/151845>
567
568         Reviewed by Simon Fraser.
569
570         Fixes the following static analyzer warning:
571             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
572                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
573                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
574
575         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
576         (createBitmapContext): Free 'buffer' after using it in logging
577         to fix the use-after-free.  Assign a value of nullptr to buffer
578         so we don't return with it set to a freed address.
579
580 2015-12-03  Jer Noble  <jer.noble@apple.com>
581
582         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
583         https://bugs.webkit.org/show_bug.cgi?id=151830
584
585         Reviewed by Anders Carlsson.
586
587         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
588
589         * DumpRenderTree/mac/DumpRenderTree.mm:
590         (resetWebPreferencesToConsistentValues):
591         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
592         (WTR::initializeWebViewConfiguration):
593
594 2015-12-03  Anders Carlsson  <andersca@apple.com>
595
596         Remove Objective-C GC support
597         https://bugs.webkit.org/show_bug.cgi?id=151819
598         rdar://problem/23746991
599
600         Reviewed by Dan Bernstein.
601
602         * asan/asan.xcconfig:
603
604 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
605
606         Allow nil for unspecified benchmark pathes
607         https://bugs.webkit.org/show_bug.cgi?id=151784
608
609         Reviewed by Filip Pizlo.
610
611         `Pathname.new(nil)` will raise an error.
612         Only generate Pathname if the benchmark path is specified.
613
614         * Scripts/run-jsc-benchmarks:
615
616 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
617
618         [Win] Run non-http tests without Cygwin
619         https://bugs.webkit.org/show_bug.cgi?id=151721
620
621         Reviewed by Andy Estes.
622
623         Support native 32-bit and 64-bit Python (and Perl) builds
624         for running tests:
625
626         1. Use "startswith('win')", rather than "== 'win32'" to support
627         various Windows build types.
628         2. Supply full path for some native Windows utilities, since the
629         path environment does not always have the specified, and they are
630         guaranteed to exist in those specific locations.
631         3. Make sure native Windows Python test runs pass proper environment
632         variables to run programs.
633         4. Append 'exe' suffix when running Windows executables.
634         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
635         command doesn't exist.
636         
637         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
638         the current Perl executable, rather than requiring a new path search.
639         * Scripts/webkitpy/common/find_files_unittest.py:
640         (TestWinNormalize.test_win): Use startswith('win').
641         * Scripts/webkitpy/common/prettypatch_unittest.py:
642         (test_pretty_diff_encodings): Ditto.
643         * Scripts/webkitpy/common/system/executive.py:
644         (Executive._should_close_fds): Ditto.
645         (Executive.shell_command_for_script): Use startswith('win').
646         (Executive.kill_process): Use full path to killall executable.
647         (Executive.check_running_pid): Use startswith('win').
648         (Executive.running_pids): Ditto.
649         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
650         running under native Windows Python.
651         (Executive._child_process_encoding): Use startswith('win').
652         (Executive._should_encode_child_process_arguments): Ditto.
653         (Executive.popen): Recognize proper script engine on Windows, since it
654         does not support the shebang syntax.
655         (Executive.run_in_parallel): Use startswith('win').
656         * Scripts/webkitpy/common/system/executive_unittest.py:
657         (never_ending_command): Ditto.
658         (ExecutiveTest.test_run_command_with_unicode): Ditto.
659         (ExecutiveTest.serial_test_kill_process): Ditto.
660         (ExecutiveTest.serial_test_kill_all): Ditto.
661         (ExecutiveTest.serial_test_check_running_pid): Ditto.
662         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
663         (main): Ditto.
664         * Scripts/webkitpy/common/system/file_lock.py:
665         (FileLock._create_lock): Ditto.
666         (FileLock._remove_lock): Ditto.
667         * Scripts/webkitpy/common/system/filesystem_unittest.py:
668         (RealFileSystemTest.test_chdir): Ditto.
669         (RealFileSystemTest.test_chdir__notexists): Ditto.
670         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
671         * Scripts/webkitpy/common/system/path_unittest.py:
672         (AbspathTest.test_abspath_to_uri_win): Ditto.
673         * Scripts/webkitpy/common/system/platforminfo.py:
674         (PlatformInfo._determine_os_name): Ditto.
675         * Scripts/webkitpy/common/system/user.py: Ditto.
676         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
677         (ManagerTest.integration_test_needs_servers): Ditto.
678         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
679         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
680         driver letters.
681         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
682         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
683         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
684         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
685         (HttpServerBase._check_that_all_ports_are_available): Ditto.
686         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
687         (TestHttpServer.test_start_cmd): Ditto.
688         * Scripts/webkitpy/port/base.py:
689         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
690         and 'SYSTEMROOT' in environment passed to test runners.
691         (Port._apache_config_file_name_for_platform): Use startswith('win').
692         (Port._build_path): Ditto.
693         (Port._path_to_driver): Include 'exe' suffix when running under native
694         Windows.
695         * Scripts/webkitpy/port/driver.py:
696         (Driver._setup_environ_for_driver): Explicitly make some environment
697         variables strings.
698         * Scripts/webkitpy/port/server_process.py:
699         (ServerProcess.__init__): Use startswith('win').
700         * Scripts/webkitpy/port/win.py:
701         (WinPort): Use the win32 registry utilities on Windows, and appropriate
702         registry key formats.
703         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
704         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
705         and regtool on Cygwin.
706         (WinPort.write_registry_value): Ditto.
707         (WinPort.setup_crash_log_saving): Ditto.
708         (WinPort.restore_crash_log_saving): Ditto.
709         (WinPort.prevent_error_dialogs): Ditto.
710         (WinPort.allow_error_dialogs): Ditto.
711         (WinPort.find_system_pid): Revise to use Windows management
712         infrastructure on native Windows, continue using 'ps' on Cygwin.
713         (WinPort.read_registry_string): Deleted.
714         (WinPort.write_registry_string): Deleted.
715         * Scripts/webkitpy/test/main.py:
716         (main): Use startswith('win').
717         (Tester._parse_args): Ditto.
718
719 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
720
721         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
722         https://bugs.webkit.org/show_bug.cgi?id=150792
723
724         Reviewed by Saam Barati.
725
726         * Scripts/webkitperl/FeatureList.pm:
727
728 2015-12-01  Commit Queue  <commit-queue@webkit.org>
729
730         Unreviewed, rolling out r192914.
731         https://bugs.webkit.org/show_bug.cgi?id=151734
732
733         JSC tests for this change are failing on 32 and 64-bit bots
734         (Requested by ryanhaddad on #webkit).
735
736         Reverted changeset:
737
738         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
739         enable this feature"
740         https://bugs.webkit.org/show_bug.cgi?id=150792
741         http://trac.webkit.org/changeset/192914
742
743 2015-12-01  David Kilzer  <ddkilzer@apple.com>
744
745         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
746         <http://webkit.org/b/151726>
747
748         Reviewed by Simon Fraser.
749
750         * WebKitTestRunner/mac/EventSenderProxy.mm:
751         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
752         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
753
754 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
755
756         Give String and AtomicString an existingHash() function
757         https://bugs.webkit.org/show_bug.cgi?id=151717
758
759         Reviewed by Andreas Kling.
760
761         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
762         (TestWebKitAPI::TEST):
763         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
764         (TestWebKitAPI::TEST):
765
766 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
767
768         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
769         https://bugs.webkit.org/show_bug.cgi?id=150792
770
771         Reviewed by Saam Barati.
772
773         * Scripts/webkitperl/FeatureList.pm:
774
775 2015-12-01  Sam Weinig  <sam@webkit.org>
776
777         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
778         <rdar://problem/23320863>
779         https://bugs.webkit.org/show_bug.cgi?id=151708
780
781         Reviewed by Anders Carlsson.
782
783         * WebKitTestRunner/TestController.cpp:
784         (WTR::TestController::createOtherPage):
785         (WTR::TestController::createWebViewWithOptions):
786         Update for new WKPageUIClient.
787
788 2015-12-01  Anders Carlsson  <andersca@apple.com>
789
790         Remove WebKit2.framework
791         https://bugs.webkit.org/show_bug.cgi?id=151715
792
793         Reviewed by Dan Bernstein.
794
795         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
796         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
797         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
798         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
799         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
800         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
801         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
802
803 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
804
805         Unreviewed common typo fix "occurance" => "occurrence".
806
807         * Scripts/webkitpy/tool/commands/queries.py:
808         (FindFlakyTests._print_statistics):
809
810 2015-11-30  Alex Christensen  <achristensen@webkit.org>
811
812         Make ProcessModel always MultipleSecondaryProcesses
813         https://bugs.webkit.org/show_bug.cgi?id=151662
814
815         Reviewed by Antti Koivisto.
816
817         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
818         (TestWebKitAPI::TEST):
819         * WebKitTestRunner/TestController.cpp:
820         (WTR::TestController::generatePageConfiguration):
821
822 2015-11-30  Alex Christensen  <achristensen@webkit.org>
823
824         Make usesNetworkProcess always true
825         https://bugs.webkit.org/show_bug.cgi?id=151580
826
827         Reviewed by Darin Adler.
828
829         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
830         (TestWebKitAPI::TEST):
831         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
832         (TestWebKitAPI::TEST):
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::generatePageConfiguration):
835
836 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
837
838         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
839
840         Add a way to skip unit tests only for Debug or Release builds and
841         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
842
843         * Scripts/run-gtk-tests:
844         (SkippedTest):
845         (SkippedTest.__init__):
846         (SkippedTest.__str__):
847         (SkippedTest.skip_entire_suite):
848         (SkippedTest.skip_for_build_type):
849         (TestRunner):
850         (TestRunner.__init__):
851
852 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
855
856         It's an assert hit because we are reloading a view loaded with
857         HTML data which is not supported. Use loadURI instead.
858
859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
860         (testWebViewCustomCharset):
861
862 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
863
864         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
865         https://bugs.webkit.org/show_bug.cgi?id=151633
866
867         Reviewed by Csaba Osztrogonác.
868
869         * TestWebKitAPI/PlatformGTK.cmake:
870         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
871
872 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
873
874         [GTK] Remove the remaining uses of GMainLoopSource
875         https://bugs.webkit.org/show_bug.cgi?id=151632
876
877         Reviewed by Žan Doberšek.
878
879         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
880         (testWebViewSyncRequestOnMaxConns):
881         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
883         (WTR::TestRunner::TestRunner):
884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
885         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
886         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
887         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
888         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
889         (WTR::timeoutSource):
890         (WTR::TestController::notifyDone):
891         (WTR::TestController::platformRunUntil):
892
893 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
894
895         [cmake] Add testb3 to the build system
896         https://bugs.webkit.org/show_bug.cgi?id=151619
897
898         Reviewed by Gyuyoung Kim.
899
900         * Scripts/build-jsc:
901
902 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
903
904         [jhbuild] Fix pixman build with clang
905         https://bugs.webkit.org/show_bug.cgi?id=151441
906
907         Reviewed by Carlos Garcia Campos.
908
909         * efl/jhbuild.modules:
910         * gtk/jhbuild.modules:
911
912 2015-11-26  David Kilzer  <ddkilzer@apple.com>
913
914         Extract prependToEnvironmentVariableList
915         <http://webkit.org/b/151536>
916
917         Reviewed by Daniel Bates.
918
919         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
920                webkitdirs_unittest/prependToEnvironmentVariableList.pl
921
922         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
923         and prependToEnvironmentVariableList.
924         (appendToEnvironmentVariableList): Simplify variable name.
925         Switch to use $Config{path_sep}.
926         (prependToEnvironmentVariableList): Add new method.
927         (setupMacWebKitEnvironment): Switch to use
928         prependToEnvironmentVariableList().
929         (setupIOSWebKitEnvironment): Ditto.
930
931         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
932         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
933
934 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
935
936         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
937         https://bugs.webkit.org/show_bug.cgi?id=151567
938
939         Reviewed by Darin Adler.
940
941         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
942         (on_window_deletion):
943
944 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
945
946         [GTK] Use the network process unconditionally
947         https://bugs.webkit.org/show_bug.cgi?id=151541
948
949         Reviewed by Alex Christensen.
950
951         Fix TestInspectorServer test. Do not assume we already have the
952         title we want when the page has been loaded, since the title is
953         changed afterwards. So, check if the title has already been set,
954         and if not wait for it.
955
956         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
957         (openRemoteDebuggingSession):
958
959 2015-11-23  Alex Christensen  <achristensen@webkit.org>
960
961         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
962         https://bugs.webkit.org/show_bug.cgi?id=151532
963
964         Reviewed by Benjamin Poulain.
965
966         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
967         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
968         (TestWebKitAPI::TEST):
969         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
970         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
971         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
972         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
973         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
974         so it was calling a function on a test object that had gone out of scope.
975         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
976         but that will become the default soon and that call will be removed.
977
978 2015-11-22  David Kilzer  <ddkilzer@apple.com>
979
980         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
981         <http://webkit.org/b/151542>
982
983         Reviewed by Daniel Bates.
984
985         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
986         (base_url): Use the Port object (already passed in) to give us
987         the path to the LayoutTests directory, which already checks for a
988         --layout-tests-directory command-line switch.
989         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
990         argument since we can get this from the Port object already
991         passed in via Port.results_directory().  Also switch to use
992         Port.layout_tests_dir() to get the LayoutTests directory.
993
994         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
995         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
996         Add test case for custom LayoutTests directory.
997         (TestWebPlatformTestServer.test_previously_spawned_instance):
998         Update Port object to set mock results directory as if it was
999         set on the command-line.  Remove unneeded argument from
1000         WebPlatformTestServer constructor.
1001         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1002
1003         * Scripts/webkitpy/port/base.py:
1004         (Port.to.start_web_platform_test_server): Remove unneeded
1005         argument from WebPlatformTestServer constuctor.
1006
1007 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1008
1009         [GTK] Some unit tests fail when using the network process
1010         https://bugs.webkit.org/show_bug.cgi?id=151490
1011
1012         Reviewed by Martin Robinson.
1013
1014         Run the soup server in a separate thread in TestResources test to
1015         avoid deadlocks.
1016
1017         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1018         /webkit2/WebKitWebResource/get-data when using the network process.
1019
1020         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1021         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1022         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1023         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1024         present, create a WorkQueue to run the server.
1025         (WebKitTestServer::run): Run the server in the work queue if it
1026         has been created.
1027         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1028         type into server options as flags.
1029
1030 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1031
1032         [GTK] ImageDiff should normalize the diff image
1033         https://bugs.webkit.org/show_bug.cgi?id=151261
1034
1035         Reviewed by Sergio Villar Senin.
1036
1037         * ImageDiff/gtk/ImageDiff.cpp:
1038         (readPixbufFromStdin): Fix memory leak.
1039         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1040         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1041
1042 == Rolled over to ChangeLog-2015-11-21 ==