[Win] Fix compile error.
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2
3         update-webkit-dependency fails to fetch updates through firewall on Windows
4         https://bugs.webkit.org/show_bug.cgi?id=153619
5
6         Reviewed by Myles C. Maxfield.
7
8         On Windows, when a firewall is present we need to read proxy settings
9         from environment variables.
10
11         This patch relies on the following environment variables being set:
12         HTTP_PROXY
13         HTTPS_PROXY
14
15         * Scripts/update-webkit-dependency:
16
17 2016-01-28  Dan Bernstein  <mitz@apple.com>
18
19         [Cocoa] Use the non-Development variants of XPC services for development
20         https://bugs.webkit.org/show_bug.cgi?id=152545
21
22         Reviewed by Darin Adler.
23
24         * Scripts/webkitdirs.pm:
25         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
26
27         * Scripts/webkitpy/port/driver.py:
28         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
29           set in the XPC services as well.
30
31         * Scripts/webkitpy/port/ios.py:
32         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
33           Guard Malloc are enabled in XPC services as well.
34
35         * Scripts/webkitpy/port/mac.py:
36         (MacPort.setup_environ_for_server): Ditto.
37
38 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
39
40         Unreviewed buildfix after r195743.
41
42         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
43         (WTR::AccessibilityUIElement::isPressActionSupported):
44
45 2016-01-12  Jer Noble  <jer.noble@apple.com>
46
47         Custom protocol loading through AVFoundation does not support byte-range requests.
48         https://bugs.webkit.org/show_bug.cgi?id=152919
49         <rdar://problem/23664657>
50
51         Reviewed by Alex Christensen.
52
53         Add tests for new ParsedContntRange class.
54
55         * TestWebKitAPI/PlatformWin.cmake:
56         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
57         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
58         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
59         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
60         (TestWebKitAPI::TEST):
61
62 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
63
64         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
65         https://bugs.webkit.org/show_bug.cgi?id=153594
66
67         Reviewed by Alex Christensen.
68
69         * Scripts/webkitdirs.pm:
70         (determineNumberOfCPUs):
71         (jscPath):
72         (checkFrameworks):
73         (setupCygwinEnv):
74         (wrapperPrefixIfNeeded):
75         (cmakeGeneratedBuildfile):
76         (generateBuildSystemFromCMakeProject):
77         * Scripts/webkitperl/features.pm:
78         (libraryContainsSymbol):
79
80 2016-01-28  Chris Dumez  <cdumez@apple.com>
81
82         Unreviewed, rolling out r195742.
83
84         Broke EWS
85
86         Reverted changeset:
87
88         "[webkitdirs] Clarify logic behind is{PortName} functions."
89         https://bugs.webkit.org/show_bug.cgi?id=153554
90         http://trac.webkit.org/changeset/195742
91
92 2016-01-28  Darin Adler  <darin@apple.com>
93
94         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
95         https://bugs.webkit.org/show_bug.cgi?id=153411
96
97         Reviewed by Ryosuke Niwa.
98
99         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
100         have removed the function instead.
101
102         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
103         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
104         added overloads for const char*.
105
106         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
107         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
108         (WTR::AccessibilityUIElement::hasPopup): Ditto.
109         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
110         (WTR::testPathFromURL): Ditto.
111
112 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
113
114         [webkitdirs] Clarify logic behind is{PortName} functions.
115         https://bugs.webkit.org/show_bug.cgi?id=153554
116
117         Reviewed by Darin Adler.
118
119         * Scripts/webkitdirs.pm:
120         (determinePortName): Added new function which decides which port are
121         we building based on command line switches and platform defaults.
122         (portName): Added getter for determined $portName.
123         (isEfl): Modified to use portName().
124         (isGtk): Ditto.
125         (isWinCairo): Ditto.
126         (isAppleMacWebKit): Ditto.
127         (isAppleWinWebKit): Ditto.
128         (isIOSWebKit): Ditto.
129         (cmakeBasedPortName): Code replaced with portName() call.
130         (determineIsEfl): Deleted.
131         (determineIsGtk): Deleted.
132         (determineIsWinCairo): Deleted.
133
134 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
135
136         [webkitdirs] Don't pass cmakeBasedPortName around.
137         https://bugs.webkit.org/show_bug.cgi?id=153589
138
139         Reviewed by Darin Adler.
140
141         It should be local function of webkitdirs.pm instead.
142
143         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
144         buildCMakeProjectOrExit().
145         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
146         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
147         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
148         generateBuildSystemFromCMakeProject().
149         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
150         (generateBuildSystemFromCMakeProject): Removed $port argument as we
151         can get it from cmakeBasedPortName().
152         (buildCMakeProjectOrExit): Ditto.
153
154 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
155
156         [GStreamer] Clean up includes and headers related with GStreamerGL
157         https://bugs.webkit.org/show_bug.cgi?id=153590
158
159         Reviewed by Philippe Normand.
160
161         * Scripts/webkitpy/style/checker.py: Skips
162         include_order check for MediaPlayerPrivateGStreamerBase.cpp
163         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
164
165 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
166
167         [EFL] Remove unused accessibility related code
168         https://bugs.webkit.org/show_bug.cgi?id=153543
169
170         Reviewed by Darin Adler.
171
172         Removed reference to EAIL library.
173         It not going to be support anymore. There have been changes in
174         EFL/Elementary in terms of the accessibility and we should
175         follow those.
176
177         * efl/jhbuild-optional.modules:
178
179 2016-01-27  Daniel Bates  <dabates@apple.com>
180
181         Remove WebKitSystemInterface for iOS SDK < 9
182         https://bugs.webkit.org/show_bug.cgi?id=153570
183
184         Reviewed by Andy Estes.
185
186         * Scripts/copy-webkitlibraries-to-product-directory:
187
188 2016-01-27  Jason Marcell  <jmarcell@apple.com>
189
190         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
191         https://bugs.webkit.org/show_bug.cgi?id=153330
192
193         Reviewed by Daniel Bates.
194
195         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
196         "branchName" implies that the variable or property in question is simply a string. We fixed some
197         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
198         spotted in BuildbotQueueView.js.
199
200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
201         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
202         Changed branchName to branch.name in call to commitsOnBranch.
203         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
204         _popoverLinesForCommitRange.
205         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
206         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
208         fix.
209
210 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
211
212         Add API to access closed shadowRoot in InjectedBundle
213         https://bugs.webkit.org/show_bug.cgi?id=153533
214
215         Reviewed by Antti Koivisto.
216
217         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
218
219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
220         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
221         (TestWebKitAPI::runJavaScriptAlert):
222         (TestWebKitAPI::TEST):
223         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
224         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
225         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
226
227 2016-01-27  Jason Marcell  <jmarcell@apple.com>
228
229         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
230         https://bugs.webkit.org/show_bug.cgi?id=153332
231
232         Reviewed by Alexey Proskuryakov.
233
234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
235         (Trac.prototype._xmlTimelineURL): Uses new function.
236         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
237         logic for parsing git hashes.
238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
239         Trac._parseRevisionFromURL.
240
241 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
242
243         Remove Mavericks from the flakiness dashboard
244         https://bugs.webkit.org/show_bug.cgi?id=153521
245
246         Reviewed by Dan Bernstein.
247
248         * TestResultServer/static-dashboards/builders.jsonp:
249         * TestResultServer/static-dashboards/flakiness_dashboard.js:
250
251 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
252
253         Remove ENABLE_CURRENTSRC
254         https://bugs.webkit.org/show_bug.cgi?id=153545
255
256         Reviewed by Simon Fraser.
257
258         * Scripts/webkitperl/FeatureList.pm:
259
260 2016-01-26  Jason Marcell  <jmarcell@apple.com>
261
262         Sort incoming commits via date instead of revision number.
263         https://bugs.webkit.org/show_bug.cgi?id=153467
264
265         Reviewed by Alexey Proskuryakov.
266
267         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
268         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
269
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
271         (Trac.prototype._loaded): Sort via date instead of revision number.
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
273         (MockTrac): Fix up the mock data to look more like real-world data.
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
275         Fake RSS feed that adds three more commits.
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
277         Trac._loaded().
278
279 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
280
281         Add a test for WebKit::stringMatchesWildcardString.
282         https://bugs.webkit.org/show_bug.cgi?id=153090
283
284         Reviewed by Darin Adler.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         Add the file to the project.
288
289         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
290         (TestWebKitAPI::TEST):
291         Test that a string matches another string that may contain wildcard characters.
292
293 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
294
295         [webkitdirs] Removed check for bison, gperf, and flex.
296         https://bugs.webkit.org/show_bug.cgi?id=153496
297
298         Reviewed by Alex Christensen.
299
300         This prerequisites are checked in WebKitCommon.cmake and don't
301         have to be in $PATH.
302
303         * Scripts/webkitdirs.pm:
304         (checkRequiredSystemConfig):
305
306 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
307
308         [webkitdirs] isCMakeBuild should be true by default
309         https://bugs.webkit.org/show_bug.cgi?id=153497
310
311         Reviewed by Michael Catanzaro.
312
313         * Scripts/webkitdirs.pm:
314         (isCMakeBuild):
315
316 2016-01-26  Daniel Bates  <dabates@apple.com>
317
318         Add WebKitSystemInterface for iOS 9.2
319         https://bugs.webkit.org/show_bug.cgi?id=153355
320
321         Rubber-stamped by David Kilzer.
322
323         * Scripts/copy-webkitlibraries-to-product-directory:
324
325 2016-01-26  Daniel Bates  <dabates@apple.com>
326
327         WebKitTestRunner: Credential cache is not cleared between tests
328         https://bugs.webkit.org/show_bug.cgi?id=153407
329         <rdar://problem/24280834>
330
331         Reviewed by Alexey Proskuryakov.
332
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
335         to clear cached credentials.
336
337 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
338
339         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
340         https://bugs.webkit.org/show_bug.cgi?id=153483
341
342         Reviewed by Csaba Osztrogonác.
343
344         * BuildSlaveSupport/kill-old-processes:
345         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
346
347 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
348
349         Give the layout test results file a <title> showing the date and time the tests were run
350         https://bugs.webkit.org/show_bug.cgi?id=153187
351
352         Reviewed by Darin Adler.
353         
354         Include a 'date' property in the JSON with the date and time the tests completed.
355
356         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
357         (summarize_results):
358
359 2016-01-25  Commit Queue  <commit-queue@webkit.org>
360
361         Unreviewed, rolling out r195543.
362         https://bugs.webkit.org/show_bug.cgi?id=153451
363
364         regressed performance of test bots by ~6% (Requested by dydz
365         on #webkit).
366
367         Reverted changeset:
368
369         "WebKitTestRunner: Credential cache is not cleared between
370         tests"
371         https://bugs.webkit.org/show_bug.cgi?id=153407
372         http://trac.webkit.org/changeset/195543
373
374 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
375
376         Failing to upload to flakiness dashboard should not be a hard error
377         https://bugs.webkit.org/show_bug.cgi?id=153444
378         <rdar://problem/22146294>
379
380         Reviewed by Alexey Proskuryakov.
381
382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
383         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
384
385 2016-01-25  Daniel Bates  <dabates@apple.com>
386
387         WebKitTestRunner: Credential cache is not cleared between tests
388         https://bugs.webkit.org/show_bug.cgi?id=153407
389         <rdar://problem/24280834>
390
391         Reviewed by Brady Eidson.
392
393         * WebKitTestRunner/TestController.cpp:
394         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
395         to clear cached credentials.
396
397 2016-01-24  Dan Bernstein  <mitz@apple.com>
398
399         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
400
401         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
402
403 2016-01-22  Enrica Casucci  <enrica@apple.com>
404
405         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
406
407         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
408         (WTR::TestController::platformCreateWebView):
409
410 2016-01-22  Tim Horton  <timothy_horton@apple.com>
411
412         Add a test for iOS arrow-key repeat
413         https://bugs.webkit.org/show_bug.cgi?id=152857
414         <rdar://problem/24017380>
415
416         Reviewed by Darin Adler.
417
418         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
419         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
420         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
421         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
422         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
423         * WebKitTestRunner/ios/HIDEventGenerator.h:
424         * WebKitTestRunner/ios/HIDEventGenerator.mm:
425         (-[HIDEventGenerator keyPress:completionBlock:]):
426         (-[HIDEventGenerator keyDown:completionBlock:]):
427         (-[HIDEventGenerator keyUp:completionBlock:]):
428         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
429         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
430         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
431         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
432         Make it possible to independently send keyUp/keyDown, instead of just paired.
433
434 2016-01-22  Tim Horton  <timothy_horton@apple.com>
435
436         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
437         https://bugs.webkit.org/show_bug.cgi?id=153193
438         <rdar://problem/24222034>
439
440         Reviewed by Darin Adler.
441
442         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
443         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
444         (TEST):
445         Add a test that exhibits the problems we're fixing here.
446         Before, it would both log and assert in debug, and crash in release.
447         Now it runs happily to completion.
448
449 2016-01-22  Enrica Casucci  <enrica@apple.com>
450
451         Add support for testing data detection.
452         https://bugs.webkit.org/show_bug.cgi?id=153360
453
454         Reviewed by Tim Horton.
455
456         Adding a new testing option (useDataDetection) to turn on
457         data detection when running the a test.
458
459         * WebKitTestRunner/TestController.cpp:
460         (WTR::updateTestOptionsFromTestHeader):
461         * WebKitTestRunner/TestOptions.h:
462         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
463         (WTR::TestController::platformCreateWebView):
464
465 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
466
467         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
468         https://bugs.webkit.org/show_bug.cgi?id=153334
469
470         Reviewed by Zalan Bujtas.
471         
472         Evaluating expressions in the LayoutUnit summary provider seems to cause
473         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
474         denominator to 64.
475
476         * lldb/lldb_webkit.py:
477         (WebCoreLayoutUnitProvider.to_string):
478
479 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
480
481         display-profiler-output should be able to display code blocks sorted by machine counts
482         https://bugs.webkit.org/show_bug.cgi?id=153298
483
484         Reviewed by Oliver Hunt.
485
486         * Scripts/display-profiler-output:
487
488 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
489
490         Ensure to use compatible liborc version with wanted gstreamer version
491         https://bugs.webkit.org/show_bug.cgi?id=153276
492
493         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
494         The user may have a very recent liborc installed on his system.
495
496         Reviewed by Philippe Normand.
497
498         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
499         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
500
501 2016-01-21  Nan Wang  <n_wang@apple.com>
502
503         AX: [IOS] Implement next/previous text marker functions using TextIterator
504         https://bugs.webkit.org/show_bug.cgi?id=153292
505         <rdar://problem/24268243>
506
507         Reviewed by Chris Fleizach.
508
509         Made text marker tests available on iOS.
510
511         * DumpRenderTree/AccessibilityTextMarker.h:
512         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
513         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
514         (AccessibilityTextMarker::AccessibilityTextMarker):
515         (AccessibilityTextMarker::~AccessibilityTextMarker):
516         (AccessibilityTextMarker::isEqual):
517         (AccessibilityTextMarker::platformTextMarker):
518         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
519         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
520         (AccessibilityTextMarkerRange::isEqual):
521         (AccessibilityTextMarkerRange::platformTextMarkerRange):
522         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
523         (AccessibilityUIElement::pathDescription):
524         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
525         (AccessibilityUIElement::textMarkerRangeForElement):
526         (AccessibilityUIElement::selectedTextMarkerRange):
527         (AccessibilityUIElement::resetSelectedTextMarkerRange):
528         (AccessibilityUIElement::textMarkerRangeLength):
529         (AccessibilityUIElement::textMarkerRangeForMarkers):
530         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
531         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
532         (AccessibilityUIElement::accessibilityElementForTextMarker):
533         (AccessibilityUIElement::endTextMarkerForBounds):
534         (AccessibilityUIElement::startTextMarkerForBounds):
535         (AccessibilityUIElement::textMarkerForPoint):
536         (AccessibilityUIElement::previousTextMarker):
537         (AccessibilityUIElement::nextTextMarker):
538         (AccessibilityUIElement::stringForTextMarkerRange):
539         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
540         (AccessibilityUIElement::indexForTextMarker):
541         (AccessibilityUIElement::isTextMarkerValid):
542         (AccessibilityUIElement::textMarkerForIndex):
543         (AccessibilityUIElement::startTextMarker):
544         (AccessibilityUIElement::endTextMarker):
545         (AccessibilityUIElement::setSelectedVisibleTextRange):
546         (AccessibilityUIElement::getLinkedUIElements):
547         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
548         (AccessibilityTextMarkerRange::platformTextMarkerRange):
549         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
550         (AccessibilityUIElement::removeSelection):
551         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
552         (AccessibilityUIElement::setSelectedVisibleTextRange):
553         (AccessibilityUIElement::supportedActions):
554         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
555         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
556         (WTR::AccessibilityUIElement::textMarkerRangeLength):
557         (WTR::AccessibilityUIElement::previousTextMarker):
558         (WTR::AccessibilityUIElement::nextTextMarker):
559         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
560         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
561         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
562         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
563         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
564         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
565         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
566
567 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
568
569         Unreviewed, revert accidental unreviewed commit.
570
571         * Scripts/display-profiler-output:
572
573 2016-01-20  Jason Marcell  <jmarcell@apple.com>
574
575         Refactor compareIterations to remove duplicate code.
576         https://bugs.webkit.org/show_bug.cgi?id=152913
577
578         Reviewed by Daniel Bates.
579
580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
581         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
582         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
584         the same behavior before and after refactor.
585
586 2016-01-20  Dana Burkart  <dburkart@apple.com>
587
588         Botwatcher's dashboard should show an 'X' when the build is broken
589         https://bugs.webkit.org/show_bug.cgi?id=152507
590
591         Reviewed by David Kilzer.
592
593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
594         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
595         (BuildbotStaticAnalyzerQueueView.prototype.update):
596
597 2016-01-19  Jason Marcell  <jmarcell@apple.com>
598
599         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
600         https://bugs.webkit.org/show_bug.cgi?id=153262
601
602         Reviewed by Alexey Proskuryakov.
603
604         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
605         such cases this revisionContentForIteration method does not have any content to return, thus the
606         assertion fails.
607
608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
609         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
610
611 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
612
613         [GTK] Runtime critical warnings when loading a URL after a session restore
614         https://bugs.webkit.org/show_bug.cgi?id=153233
615
616         Reviewed by Michael Catanzaro.
617
618         Add new test case.
619
620         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
621         (viewLoadChanged):
622         (testWebKitWebViewNavigationAfterSessionRestore):
623         (beforeAll):
624
625 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
626
627         [GTK] Remove jhbuild-optional.modules
628         https://bugs.webkit.org/show_bug.cgi?id=152964
629
630         Reviewed by Alex Christensen.
631
632         * gtk/jhbuild-optional.modules: Removed.
633         * gtk/jhbuild.modules:
634
635 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
636
637         [GTK] Add support to load/save session in MiniBrowser
638         https://bugs.webkit.org/show_bug.cgi?id=153201
639
640         Reviewed by Michael Catanzaro.
641
642         It makes it easier to test the new WebView session API.
643
644         * MiniBrowser/gtk/BrowserWindow.c:
645         (browserWindowFinalize): Free the session file path.
646         (browserWindowSaveSession): Save the current WebView session if
647         there's a session file path.
648         (browserWindowDeleteEvent): Call browserWindowSaveSession().
649         (browser_window_load_session): Try to load the session from the
650         given file path, otherwise fall back to homepage and keep the
651         session file to save the session on window close.
652         * MiniBrowser/gtk/BrowserWindow.h:
653         * MiniBrowser/gtk/main.c:
654         (createBrowserWindow): Pass the given session file path when
655         shouldLoadSession is TRUE.
656         (main): Only allow to restore/save session when MiniBrowser is
657         launched without URL arguments.
658
659 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
660
661         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
662
663         Geolocation is no longer allowed for unique origins after r195075.
664
665         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
666         (testWebViewGeolocationPermissionRequests):
667
668 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
669
670         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
671         https://bugs.webkit.org/show_bug.cgi?id=153216
672
673         Reviewed by Michael Catanzaro.
674
675         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
676         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
677
678 2016-01-18  Nan Wang  <n_wang@apple.com>
679
680         AX: [Mac] Implement next/previous text marker functions using TextIterator
681         https://bugs.webkit.org/show_bug.cgi?id=152728
682
683         Reviewed by Chris Fleizach.
684
685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
686         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
687
688 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
689
690         [cmake] Add testair to the build system
691         https://bugs.webkit.org/show_bug.cgi?id=153126
692
693         Reviewed by Michael Catanzaro.
694
695         * Scripts/build-jsc:
696
697 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
698
699         Remove TextRun::allowsRoundingHacks()
700         https://bugs.webkit.org/show_bug.cgi?id=153185
701
702         Reviewed by Simon Fraser.
703
704         * DumpRenderTree/mac/DumpRenderTree.mm:
705         (resetWebViewToConsistentStateBeforeTesting): Deleted.
706
707 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
708
709         [webkitdirs] Avoid list form of open because it broke WinCairo
710         https://bugs.webkit.org/show_bug.cgi?id=153106
711
712         Reviewed by Alex Christensen.
713
714         * Scripts/webkitdirs.pm:
715         (determineArchitecture):
716
717 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
718
719         Add kdebug_trace signposts for a few WebCore operations
720         https://bugs.webkit.org/show_bug.cgi?id=153136
721         rdar://problem/24208487
722
723         Reviewed by Sam Weinig.
724         
725         Plist used by kdebug_trace() viewing tools.
726
727         * Tracing/SystemTracePoints.plist: Added.
728
729 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
730
731         [webkitdirs] Replaced grep invocation with perl code
732         https://bugs.webkit.org/show_bug.cgi?id=153106
733
734         Reviewed by Alex Christensen.
735
736         * Scripts/webkitdirs.pm:
737         (determineArchitecture):
738
739 2016-01-14  Brian Burg  <bburg@apple.com>
740
741         prepare-changelog does not read paths containing spaces properly
742         https://bugs.webkit.org/show_bug.cgi?id=137982
743
744         Reviewed by Joseph Pecoraro.
745
746         Escape whitespace in filenames before passing the file path to other functions.
747
748         * Scripts/prepare-ChangeLog:
749         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
750
751 2016-01-14  Jason Marcell  <jmarcell@apple.com>
752
753         Standardize the usage of "branch" vs. "branchName".
754         https://bugs.webkit.org/show_bug.cgi?id=152982
755
756         Reviewed by Daniel Bates.
757
758         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
759         "branchName" implies that the variable or property in question is simply a string.
760
761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
762         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
763         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
764         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
766         (Trac.prototype.commitsOnBranch): Change branch to branchName.
767         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
769         (MockTrac): Ditto.
770
771 2016-01-14  Jason Marcell  <jmarcell@apple.com>
772
773         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
774         https://bugs.webkit.org/show_bug.cgi?id=152910
775
776         Reviewed by Daniel Bates.
777
778         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
779         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
781         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
782         the need to talk to a real Buildbot server.
783         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
784         without the need to talk to a real Buildbot server.
785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
786         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
787         server.
788         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
789         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
790         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
791         trying to talk to Trac.
792         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
793         QUnit unit tests.
794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
795
796 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
797
798         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
799         https://bugs.webkit.org/show_bug.cgi?id=132599
800
801         Reviewed by Michael Catanzaro.
802
803         Check if cmake Ninja generators are installed.
804
805         * Scripts/webkitdirs.pm:
806         (canUseNinjaGenerator):
807         (canUseEclipseNinjaGenerator):
808         (generateBuildSystemFromCMakeProject):
809         (canUseEclipse): Deleted.
810
811 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
812
813         [Cocoa] Testing with font family name "System Font" is unused
814         https://bugs.webkit.org/show_bug.cgi?id=153073
815         <rdar://problem/24091683>
816
817         Reviewed by Brent Fulgham.
818
819         * DumpRenderTree/mac/DumpRenderTree.mm:
820         (allowedFontFamilySet): Deleted.
821         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
822         (WTR::allowedFontFamilySet): Deleted.
823         * WebKitTestRunner/mac/TestControllerMac.mm:
824         (WTR::allowedFontFamilySet): Deleted.
825
826 2016-01-13  Daniel Bates  <dabates@apple.com>
827
828         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
829         https://bugs.webkit.org/show_bug.cgi?id=152871
830
831         Reviewed by Brent Fulgham.
832
833         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
834         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
835
836         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
837
838 2016-01-08  Andy Estes  <aestes@apple.com>
839
840         [Content Filtering] Lazily load platform frameworks
841         https://bugs.webkit.org/show_bug.cgi?id=152881
842         rdar://problem/23270886
843
844         Reviewed by Brady Eidson.
845
846         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
847         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
848         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
849         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
850         is loaded after an HTTPS request.
851
852         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
853         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
854         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
855         also re-enabled on iOS after mistakenly being disabled by r188892.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
859         (TestWebKitAPI::TEST):
860         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
861         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
862         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
863         (TEST):
864         (downloadTest):
865         (-[LazilyLoadPlatformFrameworksController init]):
866         (-[LazilyLoadPlatformFrameworksController webView]):
867         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
868         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
869         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
870         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
871         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
872         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
873         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
874         (TestWebKitAPI::TEST):
875         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
876         (TestWebKitAPI::TEST): Deleted.
877         * TestWebKitAPI/cocoa/TestProtocol.h:
878         * TestWebKitAPI/cocoa/TestProtocol.mm:
879         (+[TestProtocol registerWithScheme:]):
880         (+[TestProtocol unregister]):
881
882 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
883
884         Fix the Sunpider converage in slow device.
885         https://bugs.webkit.org/show_bug.cgi?id=152938
886         <rdar://problem/22511411>
887
888         Reviewed by Ryosuke Niwa.
889
890         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
891
892         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
893
894 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Add a build flag for custom element
897         https://bugs.webkit.org/show_bug.cgi?id=153005
898
899         Reviewed by Alex Christensen.
900
901         Added --custom-elements option to enable custom elements support.
902
903         * Scripts/webkitperl/FeatureList.pm:
904
905 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
906
907         [JSC] Add a help message when run-jsc-stress-tests fails
908         https://bugs.webkit.org/show_bug.cgi?id=153014
909
910         Reviewed by Csaba Osztrogonác.
911
912         * Scripts/run-jsc-stress-tests:
913
914 2016-01-11  Saam barati  <sbarati@apple.com>
915
916         run-jsc-stress-tests should try to figure out a JSC path
917         https://bugs.webkit.org/show_bug.cgi?id=152971
918
919         Reviewed by Yusuke Suzuki.
920
921         This patch now allows run-jsc-stress-tests to be run
922         without a "--jsc <jsc-path>" argument. It tries
923         to take its best guess at a <jsc-path> automagically.
924         
925         This makes it much easier to just run run-jsc-stress-tests
926         with a directory or a yaml file as an argument.
927         You now just do this:
928         `run-jsc-stress-tests <path-to-yaml>`
929         or
930         `run-jsc-stress-tests <path-to-directory-of-js-files>`
931         
932         I wrote this patch because I'd often find myself hacking the 
933         run-javascriptcore-tests file just to run a particular subset of tests.
934         Because I always forget the arguments to run-jsc-stress-tests (which means
935         I always forgot to provide a --jsc argument), I always found it easier to 
936         just hack on that file instead of calling run-jsc-stress-tests directly.
937         No longer is this true!
938
939         * Scripts/run-jsc-stress-tests:
940
941 2016-01-09  Andy Estes  <aestes@apple.com>
942
943         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
944         https://bugs.webkit.org/show_bug.cgi?id=152950
945         rdar://problem/24066652
946
947         Reviewed by Tim Horton.
948
949         Added an API test.
950
951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
952         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
953         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
954         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
955         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
956         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
957         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
958         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
959         (TEST):
960
961 2016-01-11  Commit Queue  <commit-queue@webkit.org>
962
963         Unreviewed, rolling out r194866.
964         https://bugs.webkit.org/show_bug.cgi?id=152986
965
966         This change broke the mac build (Requested by ryanhaddad on
967         #webkit).
968
969         Reverted changeset:
970
971         "[Cocoa] Add SPI to opt out a URL scheme from the memory
972         cache"
973         https://bugs.webkit.org/show_bug.cgi?id=152950
974         http://trac.webkit.org/changeset/194866
975
976 2016-01-11  Andy Estes  <aestes@apple.com>
977
978         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
979         https://bugs.webkit.org/show_bug.cgi?id=152950
980         rdar://problem/24066652
981
982         Reviewed by Tim Horton.
983
984         Added an API test.
985
986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
987         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
988         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
989         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
990         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
991         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
992         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
993         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
994         (TEST):
995
996 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
997
998         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
999         https://bugs.webkit.org/show_bug.cgi?id=152959
1000
1001         Reviewed by Brent Fulgham.
1002
1003         * Scripts/webkitdirs.pm:
1004         (determineArchitecture):
1005
1006 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1007
1008         [GTK] W3C CSS2.1 anonymous table tests are failing
1009         https://bugs.webkit.org/show_bug.cgi?id=152455
1010
1011         Reviewed by Mario Sanchez Prada.
1012
1013         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1014         tests. Add upstream patches to fix detection of XHTML files.
1015
1016         * gtk/jhbuild.modules:
1017         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1018         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1019
1020 2016-01-10  Saam barati  <sbarati@apple.com>
1021
1022         Implement a sampling profiler
1023         https://bugs.webkit.org/show_bug.cgi?id=151713
1024
1025         Reviewed by Filip Pizlo.
1026
1027         * Scripts/run-jsc-stress-tests:
1028
1029 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
1030
1031         [webkitdirs] Try arch and uname commands on non-windows OS
1032         https://bugs.webkit.org/show_bug.cgi?id=152958
1033
1034         Reviewed by Michael Catanzaro.
1035
1036         Right now, determineArchitecture()  uses `arch` and `uname -m`
1037         commands to determine architecture in case of condition (isGtk() ||
1038         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1039         instead, because this code is applicable to any non-windows OS WebKit
1040         supports (even Haiku which once was supported is moderately
1041         POSIX-compliant and has uname command).
1042
1043         * Scripts/webkitdirs.pm:
1044         (determineArchitecture):
1045
1046 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
1047
1048         run-webkit-tests mis-counts totals when there are other crashes
1049         https://bugs.webkit.org/show_bug.cgi?id=152894
1050         <rdar://problem/24098697>
1051
1052         Reviewed by Alexey Proskuryakov.
1053
1054         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1055         (TestRunResults.add): Do not update result counters for other crashes.
1056
1057 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1058
1059         webkit-patch build-and-test should have an option to iterate over new tests
1060         https://bugs.webkit.org/show_bug.cgi?id=143093
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1065         It allows running run-webkit-tests on modified or new paths in LayoutTests.
1066         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1067         It implements the translation of -expected.* paths to their related tests.
1068         It also implements the removal of skipped tests.
1069
1070         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1071         (LayoutTestFinder.find_touched_tests):
1072         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1073         (MockPort):
1074         (MockPort.__init__):
1075         (MockPort.tests):
1076         (LayoutTestFinderTests):
1077         (LayoutTestFinderTests.touched_files):
1078         (LayoutTestFinderTests.test_touched_test):
1079         (LayoutTestFinderTests.test_expected_touched_test):
1080         (LayoutTestFinderTests.test_platform_expected_touched_test):
1081         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1082         (LayoutTestFinderTests.test_touched_but_skipped_test):
1083         * Scripts/webkitpy/port/base.py:
1084         (Port.potential_test_names_from_expected_file):
1085         * Scripts/webkitpy/tool/commands/download_unittest.py:
1086         (DownloadCommandsTest._default_options):
1087         * Scripts/webkitpy/tool/steps/options.py:
1088         (Options):
1089         * Scripts/webkitpy/tool/steps/runtests.py:
1090         (RunTests.options):
1091         (RunTests.run):
1092         (RunTests):
1093         (RunTests._new_or_modified_tests):
1094         (RunTests._run_webkit_tests):
1095         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1096         (RunTestsTest.test_webkit_run_unit_tests):
1097         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1098         (StepsTest._step_options):
1099
1100 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
1101
1102         prepare-ChangeLog should include radar number
1103         https://bugs.webkit.org/show_bug.cgi?id=152839
1104         <rdar://problem/24093563>
1105
1106         Reviewed by Daniel Bates.
1107
1108         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1109         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1110         in the ChangeLog description after the bug URL.
1111
1112         * Scripts/prepare-ChangeLog:
1113         (main): Update signatures.
1114         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1115         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1116         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1117         (generateNewChangeLogs): Include radar URL if we found one.
1118
1119         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1120         Tests for the radar URL extraction.
1121
1122 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
1123
1124         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1125         https://bugs.webkit.org/show_bug.cgi?id=152390
1126         <rdar://problem/23948321>
1127
1128         Reviewed by Simon Fraser.
1129
1130         Fix two use-after-frees.
1131
1132         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1133         but we may have already progressed to another test by the time the callback fires,
1134         having destroyed the TestInvocation.
1135         2. UIScriptController is a RefCounted object, but it has a raw pointer to
1136         UIScriptContext which has the same lifetime as a TestInvocation.
1137         As a result, completion blocks of UIScriptController actions would use a destroyed
1138         TestInvocation.
1139
1140         * WebKitTestRunner/TestInvocation.cpp:
1141         (WTR::TestInvocation::~TestInvocation):
1142         (WTR::TestInvocation::url):
1143         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1144         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1145         (WTR::TestInvocation::runUISideScript):
1146         * WebKitTestRunner/TestInvocation.h:
1147         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1148         (UIScriptContext::UIScriptContext):
1149         (UIScriptContext::~UIScriptContext):
1150         (UIScriptContext::runUIScript):
1151         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1152         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1153         (WTR::UIScriptController::UIScriptController):
1154         (WTR::UIScriptController::contextDestroyed):
1155         (WTR::UIScriptController::makeWindowObject):
1156         (WTR::UIScriptController::setWillBeginZoomingCallback):
1157         (WTR::UIScriptController::willBeginZoomingCallback):
1158         (WTR::UIScriptController::setDidEndZoomingCallback):
1159         (WTR::UIScriptController::didEndZoomingCallback):
1160         (WTR::UIScriptController::setDidEndScrollingCallback):
1161         (WTR::UIScriptController::didEndScrollingCallback):
1162         (WTR::UIScriptController::setDidShowKeyboardCallback):
1163         (WTR::UIScriptController::didShowKeyboardCallback):
1164         (WTR::UIScriptController::setDidHideKeyboardCallback):
1165         (WTR::UIScriptController::didHideKeyboardCallback):
1166         (WTR::UIScriptController::uiScriptComplete):
1167         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1168         (WTR::UIScriptController::create):
1169         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1170         (WTR::UIScriptController::doAsyncTask):
1171         (WTR::UIScriptController::zoomToScale):
1172         (WTR::UIScriptController::singleTapAtPoint):
1173         (WTR::UIScriptController::doubleTapAtPoint):
1174         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1175         (WTR::UIScriptController::contentVisibleRect):
1176         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1177         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1178         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1179         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1180         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1181         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1182         (WTR::UIScriptController::doAsyncTask):
1183
1184 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1185
1186         [buildbot] clean-build script should remove untracked files and revert local changes too
1187         https://bugs.webkit.org/show_bug.cgi?id=142400
1188
1189         Reviewed by Ryosuke Niwa.
1190
1191         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1192         A helper routine SCM.discard_untracked_files is added for that purpose.
1193
1194         * BuildSlaveSupport/clean-build:
1195         (main): Making call to Scripts/clean-webkit
1196         * Scripts/clean-webkit: Added.
1197         (main): Revert changes and delete untracked files.
1198         * Scripts/webkitpy/common/checkout/scm/scm.py:
1199         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1200         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1201         (SCMTest._shared_test_discard_untracked_files):
1202         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1203
1204 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
1205
1206         Add a setting and preferences to enable display-list drawing. Does nothing yet.
1207         https://bugs.webkit.org/show_bug.cgi?id=152807
1208
1209         Reviewed by Zalan Bujtas.
1210         
1211         Add an item to the Settings menu to toggle display-list drawing.
1212
1213         * MiniBrowser/mac/SettingsController.h:
1214         * MiniBrowser/mac/SettingsController.m:
1215         (-[SettingsController _populateMenu]):
1216         (-[SettingsController validateMenuItem:]):
1217         (-[SettingsController toggleDisplayListDrawingEnabled:]):
1218         (-[SettingsController displayListDrawingEnabled]):
1219         * MiniBrowser/mac/WK2BrowserWindowController.m:
1220         (-[WK2BrowserWindowController didChangeSettings]):
1221
1222 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1223
1224         Python SCM should be able to retrieve untracked files - Add GIT support
1225         https://bugs.webkit.org/show_bug.cgi?id=143135
1226
1227         Reviewed by Michael Catanzaro.
1228
1229         * Scripts/webkitpy/common/checkout/scm/git.py:
1230         (Git.untracked_files): Adding support for git.
1231         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1232         (GitTest.setUp):
1233         (GitTest.test_untracked_files): Adding test.
1234
1235 2016-01-05  Mark Lam  <mark.lam@apple.com>
1236
1237         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1238         https://bugs.webkit.org/show_bug.cgi?id=152748
1239
1240         Reviewed by Geoffrey Garen.
1241
1242         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1243         bots to have a bad time.
1244
1245         * Scripts/run-javascriptcore-tests:
1246         * Scripts/run-jsc-stress-tests:
1247
1248 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1249
1250         [GTK] Allow to save and restore session
1251         https://bugs.webkit.org/show_bug.cgi?id=115600
1252
1253         Reviewed by Michael Catanzaro.
1254
1255         Add test case to check the new session API.
1256
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1258         (testWebKitWebViewSessionState):
1259         (testWebKitWebViewSessionStateWithFormData):
1260         (beforeAll):
1261
1262 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1263
1264         [EFL] Bump EFL version to 1.16.1
1265         https://bugs.webkit.org/show_bug.cgi?id=152688
1266
1267         Reviewed by Gyuyoung Kim.
1268
1269         * efl/jhbuild.modules:
1270
1271 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1272
1273         error running layout tests on iOS simulator on latest build
1274         https://bugs.webkit.org/show_bug.cgi?id=152719
1275         <rdar://problem/24009549>
1276
1277         Reviewed by Alexey Proskuryakov.
1278
1279         * Scripts/webkitpy/xcode/simulator.py:
1280         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1281           before running simctl spawn command.
1282
1283 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1284
1285         Unreviewed, move Frédéric Wang to committers list
1286
1287         He seems to be on the contributors list by accident. He has been landing his own commits for
1288         about two years now.
1289
1290         * Scripts/webkitpy/common/config/contributors.json:
1291
1292 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1293
1294         Unreviewed, move Sebastian Dröge to committers list harder
1295
1296         He accidentally added himself to the reviewers list because the file is confusing. Then I
1297         accidentially moved him to the contributors list because the file is confusing, even though
1298         I knew the contributors list existed in this file and was attempting to add him to the
1299         committers list. Really move him to the committers list now.
1300
1301         * Scripts/webkitpy/common/config/contributors.json:
1302
1303 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1304
1305         Python SCM should be able to retrieve untracked files - Add SVN support
1306         https://bugs.webkit.org/show_bug.cgi?id=152546
1307
1308         Reviewed by Michael Catanzaro.
1309
1310         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1311         (test_untracked_files): Activating test for SVN.
1312         * Scripts/webkitpy/common/checkout/scm/svn.py:
1313         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1314
1315 2015-12-31  Andy Estes  <aestes@apple.com>
1316
1317         Replace WTF::move with WTFMove
1318         https://bugs.webkit.org/show_bug.cgi?id=152601
1319
1320         Reviewed by Brady Eidson.
1321
1322         * DumpRenderTree/TestRunner.h:
1323         (TestRunner::setAllowedHosts):
1324         * DumpRenderTree/win/DRTDataObject.cpp:
1325         (DRTDataObject::SetData):
1326         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1327         (TestWebKitAPI::TEST):
1328         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1329         (TestWebKitAPI::TEST):
1330         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1331         (TestWebKitAPI::TEST):
1332         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1333         (TestWebKitAPI::TEST):
1334         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1335         (TestWebKitAPI::passWithRef):
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1338         (TestWebKitAPI::TEST):
1339         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1342         (TestWebKitAPI::TEST):
1343         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1344         (TestWebKitAPI::TEST):
1345         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1346         (TestWebKitAPI::createTestValue):
1347         (TestWebKitAPI::TEST):
1348         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1349         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1350         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1351         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1352         (TestWebKitAPI::createNFAs):
1353         (TestWebKitAPI::TEST_F):
1354         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1355         (TestWebKitAPI::combine):
1356         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1357         (TestWebKitAPI::createNFAs):
1358         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1359         (TEST):
1360         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1361         (WebProcessTest::add):
1362
1363 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1364
1365         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1366         https://bugs.webkit.org/show_bug.cgi?id=152634
1367
1368         Reviewed by Carlos Garcia Campos.
1369
1370         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1371         (testLoadFromGResource): Added test.
1372         (beforeAll):
1373         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1374         (registerGResource): Added.
1375         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1376         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1377         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1378
1379 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1380
1381         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1382         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1383
1384         Ignore unknown pragmas on older clangs.  Fixes the following
1385         build failure:
1386
1387             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1388             #pragma clang diagnostic ignored "-Wself-move"
1389                                              ^
1390             1 error generated.
1391
1392         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1393         (TestWebKitAPI::TEST):
1394         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1395         (TestWebKitAPI::TEST):
1396
1397 2015-12-31  Andy Estes  <aestes@apple.com>
1398
1399         Update the style checker to advise using WTFMove() instead of WTF::move()
1400         https://bugs.webkit.org/show_bug.cgi?id=152601
1401
1402         Reviewed by Daniel Bates.
1403
1404         * Scripts/webkitpy/style/checkers/cpp.py:
1405         (check_wtf_move):
1406         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1407         (WebKitStyleTest.test_wtf_move):
1408
1409 2015-12-31  Andy Estes  <aestes@apple.com>
1410
1411         Fix warnings uncovered by migrating to WTF_MOVE
1412         https://bugs.webkit.org/show_bug.cgi?id=152601
1413
1414         Reviewed by Daniel Bates.
1415
1416         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1417         self-move, even if doing so would trigger a warning.
1418
1419         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1420         (TestWebKitAPI::TEST):
1421         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1422         (TestWebKitAPI::TEST):
1423
1424 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1425
1426         [GTK] The install-dependencies script has a syntax error
1427         https://bugs.webkit.org/show_bug.cgi?id=152613
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         * gtk/install-dependencies: Add the missing 'then.'
1432
1433 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1434
1435         [Mac][GTK] Jhbuild support for OSX
1436         https://bugs.webkit.org/show_bug.cgi?id=150799
1437
1438         Reviewed by Michael Catanzaro.
1439
1440         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1441         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1442         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1443         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1444
1445 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1446
1447         Unreviewed, move Sebastian Dröge to committers list
1448
1449         He accidentally added himself to the reviewers list because the file is confusing.
1450
1451         * Scripts/webkitpy/common/config/contributors.json:
1452
1453 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1454
1455         Remove the unused #define _USE_MATH_DEFINES
1456         https://bugs.webkit.org/show_bug.cgi?id=152034
1457
1458         Reviewed by Tim Horton.
1459         
1460         Update this test to use piDouble from MathExtras.h, and
1461         std::numeric_limits<>.
1462
1463         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1464
1465 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1466
1467         Python SCM should be able to retrieve untracked files - Generic changes
1468         https://bugs.webkit.org/show_bug.cgi?id=152536
1469
1470         Reviewed by Brent Fulgham.
1471
1472         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1473         No support is yet added to GIT and SVN specific implementations.
1474
1475         * Scripts/webkitpy/common/checkout/scm/scm.py:
1476         (SCM.untracked_files):
1477         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1478         (SCMTest._shared_test_untracked_files):
1479
1480 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1481
1482         SVN checkout used by RunBenchmark should be non-interactive
1483         https://bugs.webkit.org/show_bug.cgi?id=152542
1484
1485         Reviewed by Ryosuke Niwa.
1486
1487         RunBenchmark should not require user interaction while running.
1488
1489         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1490         (BenchmarkBuilder._checkout_with_subversion):
1491
1492 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1493
1494         Web Inspector: add support for running protocol-test.js tests on Windows
1495         https://bugs.webkit.org/show_bug.cgi?id=148037
1496         <rdar://problem/22292237>
1497
1498         Reviewed by Simon Fraser.
1499
1500         * DumpRenderTree/win/TestRunnerWin.cpp:
1501         (TestRunner::inspectorTestStubURL): Provide implementation.
1502
1503 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1504
1505         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1506         https://bugs.webkit.org/show_bug.cgi?id=152000
1507
1508         Reviewed by Brent Fulgham.
1509
1510         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1511         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1512         (WTR::InjectedBundle::setUserMediaPermission):
1513         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1514         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1515
1516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1517         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1519
1520         * WebKitTestRunner/TestController.cpp:
1521         (WTR::TestController::setUserMediaPermissionForOrigin):
1522         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1523         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1524           persistent permission for origin, that can be done from script now.
1525         * WebKitTestRunner/TestController.h:
1526
1527         * WebKitTestRunner/TestInvocation.cpp:
1528         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1529           SetUserMediaPermissionForOrigin.
1530
1531 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1532
1533         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1534
1535         * Scripts/webkitpy/common/system/platforminfo.py:
1536         (PlatformInfo._determine_win_version):
1537
1538 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1539
1540         Content blockers should be able to promote http to https
1541         https://bugs.webkit.org/show_bug.cgi?id=148966
1542
1543         Reviewed by Benjamin Poulain.
1544
1545         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1546         (WebCore::ContentExtensions::operator<<):
1547         (TestWebKitAPI::TEST_F):
1548
1549 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1550
1551         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1552         https://bugs.webkit.org/show_bug.cgi?id=152516
1553
1554         Reviewed by Gyuyoung Kim.
1555
1556         * MiniBrowser/efl/main.c:
1557
1558 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1559
1560         Unreviewed: Add John Wilander as a contributor.
1561
1562         * Scripts/webkitpy/common/config/contributors.json:
1563
1564 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1565
1566         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1567         https://bugs.webkit.org/show_bug.cgi?id=152482
1568
1569         Reviewed by Brent Fulgham.
1570
1571         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1572         for the same property. On WK2, the element returned will not be valid, but is still present and
1573         that can lead to looping.
1574
1575         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1576         (AccessibilityUIElement::horizontalScrollbar):
1577         (AccessibilityUIElement::verticalScrollbar):
1578         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1579         (WTR::AccessibilityUIElement::horizontalScrollbar):
1580         (WTR::AccessibilityUIElement::verticalScrollbar):
1581
1582 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1583
1584         Unreviewed.
1585
1586         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1587
1588 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1589
1590         [EFL] test_ewk2_context failed after r192808
1591         https://bugs.webkit.org/show_bug.cgi?id=151846
1592
1593         Reviewed by Gyuyoung Kim.
1594
1595         Used the added ewk_context_web_process_count_limit_set api
1596         instead of the deprecated ewk_context_process_model_set.
1597
1598         * MiniBrowser/efl/main.c:
1599         (elm_main):
1600
1601 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1602
1603         Unreviewed, move myself to reviewer list.
1604
1605         * Scripts/webkitpy/common/config/contributors.json:
1606
1607 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1608
1609         Unreviewed, add myself to the committers list.
1610
1611         * Scripts/webkitpy/common/config/contributors.json:
1612
1613 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1614
1615         [GTK] jquery.min.js violates DFSG
1616         https://bugs.webkit.org/show_bug.cgi?id=152428
1617
1618         Reviewed by Joseph Pecoraro.
1619
1620         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1621         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1622
1623         * gtk/manifest.txt.in:
1624
1625 2015-12-19  Dan Bernstein  <mitz@apple.com>
1626
1627         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1628         https://bugs.webkit.org/show_bug.cgi?id=152462
1629
1630         Reviewed by Alexey Proskuryakov.
1631
1632         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1633           OS X 10.9:
1634
1635         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1636         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1637         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1638         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1639         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1640
1641         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1642           never getting compiled:
1643
1644         * DumpRenderTree/mac/TextInputController.m:
1645         * MiniBrowser/mac/BrowserWindowController.m:
1646         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1647         * WebKitTestRunner/mac/EventSenderProxy.mm:
1648
1649 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1650
1651         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1652
1653         This is to make it easy to CC it on Bugzilla.
1654
1655         * Scripts/webkitpy/common/config/contributors.json:
1656
1657 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1658
1659         Pasteboard get messed up after running kill-old-processes
1660         https://bugs.webkit.org/show_bug.cgi?id=152426
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         * BuildSlaveSupport/kill-old-processes:
1665         (main): Do not kill pasteboard anymore.
1666
1667 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1668
1669         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1670         https://bugs.webkit.org/show_bug.cgi?id=152157
1671         <rdar://problem/23851817>
1672
1673         Reviewed by Alexey Proskuryakov.
1674
1675         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1676         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1678         (Manager._get_test_inputs): Common method to calculate test_inputs.
1679         (Manager._update_worker_count): Calculate and update required number of workers.
1680
1681 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1682
1683         run-webkit-tests fails to delete Simulator device during cleanup
1684         https://bugs.webkit.org/show_bug.cgi?id=152363
1685
1686         Reviewed by Alexey Proskuryakov.
1687
1688         * Scripts/webkitpy/xcode/simulator.py:
1689         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1690
1691 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1692
1693         [mac-wk2] fast/events force click tests crashing
1694         https://bugs.webkit.org/show_bug.cgi?id=152339
1695
1696         Reviewed by Beth Dakin.
1697
1698         * WebKitTestRunner/mac/EventSenderProxy.mm:
1699         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1700         Set the NSEvent's _type member in addition to overriding -type,
1701         because there are assertions in touch event handling code that depend on it.
1702
1703 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1704
1705         Enforce temporarily bots to sync WebKit and WPT testharness.js
1706         https://bugs.webkit.org/show_bug.cgi?id=152334
1707
1708         Reviewed by Darin Adler.
1709
1710         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1711         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1712
1713 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1714
1715         [Fetch API] Add fetch API compile time flag
1716         https://bugs.webkit.org/show_bug.cgi?id=152254
1717
1718         Reviewed by Darin Adler.
1719
1720         * Scripts/webkitperl/FeatureList.pm:
1721
1722 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1723
1724         Unreviewed.
1725
1726         Added files that have impact in building Streams API to the watchlist.
1727
1728         * Scripts/webkitpy/common/config/watchlist:
1729
1730 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1731
1732         Unreviewed.
1733
1734         Added imported tests to Streams API watchlist.
1735
1736         * Scripts/webkitpy/common/config/watchlist:
1737
1738 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1739
1740         Remove default copy of wpt testharness.js when launching wpt server
1741         https://bugs.webkit.org/show_bug.cgi?id=152298
1742
1743         Reviewed by Darin Adler.
1744
1745         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1746         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1747
1748 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1749
1750         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1751         <http://webkit.org/b/152314>
1752
1753         Reviewed by Daniel Bates.
1754
1755         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1756         code path to exit immediately when calling main().
1757         Unfortunately, DumpRenderTreeMain.mm was used for both
1758         DumpRenderTree command-line binary and DumpRenderTree.app, which
1759         meant that the app would exit immediately with no error code
1760         when run!
1761
1762         The workaround is to introduce a separate source file called
1763         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1764         already does.
1765
1766         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1767         DumpRenderTreeAppMain.mm to the project.  Make it the only
1768         compiled source for the DumpRenderTree.app target.
1769         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1770         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1771         case someone tries mistakenly to use the app.
1772         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1773         Link to JavaScriptCore.framework on iOS for the assert.
1774         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1775         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1776         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1777         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1778         (main): Add assert for iOS so that a crash occurs if someone
1779         tries to run the wrong command.
1780
1781 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1782
1783         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1784         https://bugs.webkit.org/show_bug.cgi?id=152266
1785         <rdar://problem/22092676>
1786
1787         Reviewed by Simon Fraser.
1788
1789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1791         Add a test that crashed before this change, and doesn't crash after.
1792
1793 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1794
1795         AX: iOS: Text field variations do not have the correct traits
1796         https://bugs.webkit.org/show_bug.cgi?id=152237
1797
1798         Reviewed by Mario Sanchez Prada.
1799
1800         Add iOS calls for determing if an object is a search field or a text area.
1801
1802         * DumpRenderTree/AccessibilityUIElement.cpp:
1803         (getIsSearchFieldCallback):
1804         (getIsTextAreaCallback):
1805         (stringForSelectionCallback):
1806         (AccessibilityUIElement::getJSClass):
1807         * DumpRenderTree/AccessibilityUIElement.h:
1808         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1809         (AccessibilityUIElement::identifier):
1810         (AccessibilityUIElement::isTextArea):
1811         (AccessibilityUIElement::isSearchField):
1812         (AccessibilityUIElement::traits):
1813         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1814         (WTR::AccessibilityUIElement::scrollPageRight):
1815         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1816         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1817         (WTR::AccessibilityUIElement::isSearchField):
1818         (WTR::AccessibilityUIElement::isTextArea):
1819         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1820         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1821         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1822         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1823         (WTR::AccessibilityUIElement::isTextArea):
1824         (WTR::AccessibilityUIElement::isSearchField):
1825         (WTR::AccessibilityUIElement::rowCount):
1826
1827 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1828
1829         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1830         https://bugs.webkit.org/show_bug.cgi?id=152252
1831
1832         Reviewed by Sergio Villar Senin.
1833
1834         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1835         for building the JHBuild on Debian systems.
1836
1837 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1838
1839         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1840         https://bugs.webkit.org/show_bug.cgi?id=152156
1841
1842         Reviewed by Dan Bernstein.
1843
1844         Our frameworks should appropriately prefix all ObjC classes,
1845         not just external symbols.
1846
1847         * Scripts/check-for-inappropriate-objc-class-names:
1848         Remove the -g switch to check all ObjC class names.
1849
1850 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1851
1852         [MediaStream] Expose media capture devices persistent permissions to WebCore
1853         https://bugs.webkit.org/show_bug.cgi?id=152087
1854
1855         Add support for the new user media permission checker page UI client method.
1856
1857         Reviewed by Chris Dumez.
1858
1859         * WebKitTestRunner/TestController.cpp:
1860         (WTR::decidePolicyForUserMediaPermissionRequest):
1861         (WTR::checkUserMediaPermissionForOrigin):
1862         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1863         (WTR::TestController::createWebViewWithOptions): Ditto.
1864         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1865         (WTR::originUserVisibleName): New, create a string for the origin.
1866         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1867           according to the state of the origin permission map.
1868         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1869           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1870         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1871           origin permission map.
1872         * WebKitTestRunner/TestController.h:
1873
1874 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1875
1876         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1877         https://bugs.webkit.org/show_bug.cgi?id=152022
1878         rdar://problem/23763584
1879
1880         Reviewed by Darin Adler.
1881
1882         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1884         (WTR::InjectedBundlePage::willSendRequestForFrame):
1885         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1886         (WTR::TestRunner::setWillSendRequestReturnsNull):
1887         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1888         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1889         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1890         (WTR::TestRunner::willSendRequestHTTPBody):
1891         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1892
1893 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1894
1895         Remove additional simulator checks before running layout-tests
1896         https://bugs.webkit.org/show_bug.cgi?id=152146
1897
1898         Reviewed by Darin Adler.
1899
1900         * Scripts/webkitpy/port/ios.py:
1901         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1902         * Scripts/webkitpy/xcode/simulator.py:
1903         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1904         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1905
1906 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1907
1908         Run atleast one simulator even if max process limit is low
1909         https://bugs.webkit.org/show_bug.cgi?id=152081
1910         <rdar://problem/23819694>
1911
1912         Reviewed by Alexey Proskuryakov.
1913
1914 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1915
1916         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1917         https://bugs.webkit.org/show_bug.cgi?id=144262
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         Added new unit test to check the additional scenarios we now
1922         handle for custom URI schemes.
1923
1924         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1925         (generateHTMLContent): New helper function to generate big enough content.
1926         (testWebContextURIScheme): New unit test.
1927
1928 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1929
1930         [EFL] Fix unhandled web process message when launching MiniBrowser
1931         https://bugs.webkit.org/show_bug.cgi?id=152048
1932
1933         Reviewed by Gyuyoung Kim.
1934
1935         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1936         (TestWebKitAPI::TEST):
1937
1938 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1939
1940         [GTK] Add API to handle beforeunload events
1941         https://bugs.webkit.org/show_bug.cgi?id=139090
1942
1943         Reviewed by Gustavo Noronha Silva.
1944
1945         * MiniBrowser/gtk/BrowserWindow.c:
1946         (browserWindowConstructed):
1947         (browserWindowDeleteEvent):
1948         (browser_window_class_init):
1949         Handle delete-event to prevent the window from being closed when
1950         the page has beforeunload handlers. Use
1951         webkit_web_view_try_close() when the window is requested to be
1952         closed.
1953         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1954         (testWebViewJavaScriptDialogs):
1955         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1956         script dialog type.
1957
1958 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1959
1960         Refactored initialization code in LoadTrackingTest.
1961
1962         Rubber-stamped by Carlos Garcia Campos.
1963
1964         Small refactoring to make sure that the state of a LoadTrackingTest
1965         gets properly reset before loading new web content.
1966
1967         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1968         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1969         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1970         functions and reset the remaining local variables.
1971         (LoadTrackingTest::loadURI): Call reset();
1972         (LoadTrackingTest::loadHtml): Ditto.
1973         (LoadTrackingTest::loadPlainText): Ditto.
1974         (LoadTrackingTest::loadBytes): Ditto.
1975         (LoadTrackingTest::loadRequest): Ditto.
1976         (LoadTrackingTest::reload): Ditto.
1977         (LoadTrackingTest::goBack): Ditto.
1978         (LoadTrackingTest::goForward): Ditto.
1979
1980 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1981
1982         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1983         https://bugs.webkit.org/show_bug.cgi?id=151942
1984
1985         Reviewed by Darin Adler.
1986
1987         * MiniBrowser/efl/main.c:
1988         (window_create): Enable offline web application cache feature on MiniBrowser.
1989         (elm_main):
1990
1991 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=151243
1994         <rdar://problem/22955197>
1995
1996         Reviewed by Alexey Proskuryakov.
1997
1998         * LayoutTestRelay/LayoutTestRelay/main.m:
1999         (getTestingSimDevice): Use separate testing device for each worker.
2000         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2001         (Manager.run): Perform cleanup even if setup fails.
2002         * Scripts/webkitpy/port/ios.py:
2003         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2004         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2005         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2006         (IOSSimulatorPort._quit_ios_simulator): Same
2007         (IOSSimulatorPort.clean_up_test_run): Same
2008         (IOSSimulatorPort.check_sys_deps): Same
2009         (IOSSimulatorPort.testing_device): Same
2010         (IOSSimulatorPort.reset_preferences): Same
2011         (IOSSimulatorPort.get_simulator_path): Return simulator path.
2012         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2013         * Scripts/webkitpy/xcode/simulator.py:
2014         (Device.delete): Delete the simulator device.
2015         (Simulator.delete_device): Same
2016         (Simulator.wait_until_device_is_booted): Wait for device booting.
2017
2018 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
2019
2020         [EFL] Add API to provide preferences before creating ewk_view
2021         https://bugs.webkit.org/show_bug.cgi?id=151587
2022
2023         Reviewed by Gyuyoung Kim.
2024
2025         * MiniBrowser/efl/main.c:
2026         (on_key_down):
2027         (quit):
2028         (window_create):
2029         Moved settings related code to configuration() not to update settings
2030         whenever ewk_view is created.
2031         (configuration):
2032         (elm_main):
2033
2034 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2035
2036         Unreviewed. Fix GTK+ API tests after r193639.
2037
2038         The new jhbuild version needs some more variables ot be present in
2039         the builtin dict, even if they are set to None.
2040
2041         * jhbuild/jhbuildutils.py:
2042         (enter_jhbuild_environment_if_available):
2043
2044 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
2045
2046         [GTK] Notify WebCore when notification is clicked
2047         https://bugs.webkit.org/show_bug.cgi?id=151951
2048
2049         Reviewed by Carlos Garcia Campos.
2050
2051         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2052         (testWebViewNotification): test the new API.
2053
2054 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2055
2056         'jhbuild build' should fail immediately when building any module fails
2057         https://bugs.webkit.org/show_bug.cgi?id=145697
2058
2059         Reviewed by Carlos Garcia Campos.
2060
2061         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2062         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2063         Everything is placed under lib instead of lib64 now.
2064         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2065         --exit-on-error when running 'jhbuild build'.
2066         * jhbuild/jhbuildrc_common.py:
2067         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2068         jhbuild should be able to handle these for us without breaking things....
2069
2070 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2071
2072         Add support to import w3c tests from a repository with a different root that the main repo dir
2073         https://bugs.webkit.org/show_bug.cgi?id=151751
2074
2075         Reviewed by Ryosuke Niwa and Youenn Fablet.
2076
2077         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2078         in a different directory than the repository root.
2079
2080         This patch introduces a new parameter tests_directory that we will use as root directory to search for
2081         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2082         requires having the copy_path lists including tuples of origin and destination directories.
2083
2084         * Scripts/webkitpy/w3c/test_downloader.py:
2085         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2086         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2087         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2088         (TestImporterTest.test_tests_directory): Test.
2089
2090 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2091
2092         Mock TestRepositories in W3C importer tests
2093         https://bugs.webkit.org/show_bug.cgi?id=151938
2094
2095         Reviewed by Youenn Fablet.
2096
2097         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2098         is because the test repository method reading the file was using the filesystem directly instead of taking the
2099         host one. This patch changes that.
2100
2101         * Scripts/webkitpy/w3c/test_downloader.py:
2102         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2103         default one.
2104         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2105         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2106         (TestImporterTest.test_harnesslinks_conversion):
2107         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2108
2109 2015-12-07  David Kilzer  <ddkilzer@apple.com>
2110
2111         TestNetscapePlugIn: Address review comment on 193607
2112         <http://webkit.org/b/151881>
2113
2114         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2115         (testSetStatus): Initializing std::unique_ptr<char[]> with
2116         nullptr is redundant.
2117
2118 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2119
2120         [GTK] Add webkit_uri_request_get_http_method
2121         https://bugs.webkit.org/show_bug.cgi?id=151601
2122
2123         Reviewed by Martin Robinson.
2124
2125         Add test case to check HTTP method of WebKitURIRequest.
2126
2127         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2128         (testURIRequestHTTPMethod):
2129         (serverCallback):
2130         (beforeAll):
2131         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2132         (sendRequestCallback):
2133
2134 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2137         https://bugs.webkit.org/show_bug.cgi?id=79918
2138
2139         Reviewed by Gustavo Noronha Silva.
2140
2141         Add unit tests to check the different console messages.
2142
2143         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2144         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2145         (ConsoleMessageTest::ConsoleMessage::operator==):
2146         (ConsoleMessageTest::consoleMessageReceivedCallback):
2147         (ConsoleMessageTest::ConsoleMessageTest):
2148         (ConsoleMessageTest::~ConsoleMessageTest):
2149         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2150         (testWebKitConsoleMessageConsoleAPI):
2151         (testWebKitConsoleMessageJavaScriptException):
2152         (testWebKitConsoleMessageNetworkError):
2153         (testWebKitConsoleMessageSecurityError):
2154         (beforeAll):
2155         (afterAll):
2156         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2157         (consoleMessageSentCallback):
2158         (pageCreatedCallback):
2159
2160 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
2161
2162         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2163         https://bugs.webkit.org/show_bug.cgi?id=151934
2164
2165         Reviewed by Csaba Osztrogonác.
2166
2167         * MiniBrowser/efl/main.c:
2168         (on_window_deletion): Revert the changes of r192767.
2169
2170 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2171
2172         [GTK] update-webkitgtk-libs cannot build mesa
2173         https://bugs.webkit.org/show_bug.cgi?id=151535
2174
2175         Reviewed by Martin Robinson.
2176
2177         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2178         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2179         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2180         does not have a stable API and we cannot expect mesa to be buildable unless we control the
2181         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2182         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2183
2184         * gtk/jhbuild.modules:
2185
2186 2015-12-07  Philippe Normand  <pnormand@igalia.com>
2187
2188         [GTK][Mac] libWebExtensionTest link error
2189         https://bugs.webkit.org/show_bug.cgi?id=150802
2190
2191         Reviewed by Carlos Garcia Campos.
2192
2193         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2194
2195 2015-12-06  David Kilzer  <ddkilzer@apple.com>
2196
2197         TestNetscapePlugIn: Fix leaks found by static analyzer
2198         <http://webkit.org/b/151881>
2199
2200         Reviewed by Darin Adler.
2201
2202         Fixes the following leaks found by the static analyzer:
2203             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2204                     return false;
2205                            ^~~~~
2206             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2207                     return false;
2208                            ^~~~~
2209             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2210                     return false;
2211                            ^~~~~
2212
2213         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2214         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
2215         early return if allocation fails.
2216         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2217         Make sure to call fclose() on filehandle, even for an early
2218         return.
2219         (testSetStatus): Switch to using std::unique_ptr<char[]>.
2220
2221 2015-12-05  David Kilzer  <ddkilzer@apple.com>
2222
2223         prepare-ChangeLog: Fix some warning messages when using svn
2224         <http://webkit.org/b/151914>
2225
2226         Reviewed by Daniel Bates.
2227
2228         * Scripts/prepare-ChangeLog:
2229         (generateFunctionLists): Simplify logic so that we never call
2230         normalizePath() with an undefined value.
2231         (attributeCommand): Quote $subPath for the shell so that we
2232         don't try to run "svn propget" on invalid paths.
2233
2234 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2235
2236         TestNetscapePlugIn: Fix remaining static analyzer warnings
2237         <http://webkit.org/b/151888>
2238
2239         Reviewed by Alexey Proskuryakov.
2240
2241         Fixes the following static analyzer warnings:
2242             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2243                     CRASH();
2244                     ^~~~~~~
2245             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2246                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2247                 ^~~~~~~~~~~~~~~~
2248             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2249                 return obj->pluginTest->NPP_SetWindow(window);
2250                        ^~~~~~~~~~~~~~~
2251             2 warnings generated.
2252
2253         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2254         (CRASH): Use __builtin_trap() for gcc/clang.
2255         (NPP_SetWindow): Add early return if obj is nullptr.
2256
2257 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2258
2259         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2260         https://bugs.webkit.org/show_bug.cgi?id=151797
2261
2262         Reviewed by Martin Robinson.
2263
2264         Since we switched to use the network process to run the unit tests
2265         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2266         sometimes passes. We are now also getting the notification for the
2267         css image. Since we wait for 3 resources, sometimes the css image
2268         is loaded before and then checkResourceData is called for it, but
2269         not handled. When the css image is the last one loaded the test
2270         passes. So, we just need to wait for the 4 resources.
2271
2272         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2273         (testWebResourceGetData):
2274
2275 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2276
2277         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2278         <http://webkit.org/b/151845>
2279
2280         Reviewed by Simon Fraser.
2281
2282         Fixes the following static analyzer warning:
2283             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2284                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2285                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2286
2287         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2288         (createBitmapContext): Free 'buffer' after using it in logging
2289         to fix the use-after-free.  Assign a value of nullptr to buffer
2290         so we don't return with it set to a freed address.
2291
2292 2015-12-03  Jer Noble  <jer.noble@apple.com>
2293
2294         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2295         https://bugs.webkit.org/show_bug.cgi?id=151830
2296
2297         Reviewed by Anders Carlsson.
2298
2299         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2300
2301         * DumpRenderTree/mac/DumpRenderTree.mm:
2302         (resetWebPreferencesToConsistentValues):
2303         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2304         (WTR::initializeWebViewConfiguration):
2305
2306 2015-12-03  Anders Carlsson  <andersca@apple.com>
2307
2308         Remove Objective-C GC support
2309         https://bugs.webkit.org/show_bug.cgi?id=151819
2310         rdar://problem/23746991
2311
2312         Reviewed by Dan Bernstein.
2313
2314         * asan/asan.xcconfig:
2315
2316 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2317
2318         Allow nil for unspecified benchmark pathes
2319         https://bugs.webkit.org/show_bug.cgi?id=151784
2320
2321         Reviewed by Filip Pizlo.
2322
2323         `Pathname.new(nil)` will raise an error.
2324         Only generate Pathname if the benchmark path is specified.
2325
2326         * Scripts/run-jsc-benchmarks:
2327
2328 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2329
2330         [Win] Run non-http tests without Cygwin
2331         https://bugs.webkit.org/show_bug.cgi?id=151721
2332
2333         Reviewed by Andy Estes.
2334
2335         Support native 32-bit and 64-bit Python (and Perl) builds
2336         for running tests:
2337
2338         1. Use "startswith('win')", rather than "== 'win32'" to support
2339         various Windows build types.
2340         2. Supply full path for some native Windows utilities, since the
2341         path environment does not always have the specified, and they are
2342         guaranteed to exist in those specific locations.
2343         3. Make sure native Windows Python test runs pass proper environment
2344         variables to run programs.
2345         4. Append 'exe' suffix when running Windows executables.
2346         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2347         command doesn't exist.
2348         
2349         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2350         the current Perl executable, rather than requiring a new path search.
2351         * Scripts/webkitpy/common/find_files_unittest.py:
2352         (TestWinNormalize.test_win): Use startswith('win').
2353         * Scripts/webkitpy/common/prettypatch_unittest.py:
2354         (test_pretty_diff_encodings): Ditto.
2355         * Scripts/webkitpy/common/system/executive.py:
2356         (Executive._should_close_fds): Ditto.
2357         (Executive.shell_command_for_script): Use startswith('win').
2358         (Executive.kill_process): Use full path to killall executable.
2359         (Executive.check_running_pid): Use startswith('win').
2360         (Executive.running_pids): Ditto.
2361         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2362         running under native Windows Python.
2363         (Executive._child_process_encoding): Use startswith('win').
2364         (Executive._should_encode_child_process_arguments): Ditto.
2365         (Executive.popen): Recognize proper script engine on Windows, since it
2366         does not support the shebang syntax.
2367         (Executive.run_in_parallel): Use startswith('win').
2368         * Scripts/webkitpy/common/system/executive_unittest.py:
2369         (never_ending_command): Ditto.
2370         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2371         (ExecutiveTest.serial_test_kill_process): Ditto.
2372         (ExecutiveTest.serial_test_kill_all): Ditto.
2373         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2374         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2375         (main): Ditto.
2376         * Scripts/webkitpy/common/system/file_lock.py:
2377         (FileLock._create_lock): Ditto.
2378         (FileLock._remove_lock): Ditto.
2379         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2380         (RealFileSystemTest.test_chdir): Ditto.
2381         (RealFileSystemTest.test_chdir__notexists): Ditto.
2382         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2383         * Scripts/webkitpy/common/system/path_unittest.py:
2384         (AbspathTest.test_abspath_to_uri_win): Ditto.
2385         * Scripts/webkitpy/common/system/platforminfo.py:
2386         (PlatformInfo._determine_os_name): Ditto.
2387         * Scripts/webkitpy/common/system/user.py: Ditto.
2388         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2389         (ManagerTest.integration_test_needs_servers): Ditto.
2390         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2391         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2392         driver letters.
2393         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2394         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2395         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2396         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2397         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2398         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2399         (TestHttpServer.test_start_cmd): Ditto.
2400         * Scripts/webkitpy/port/base.py:
2401         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2402         and 'SYSTEMROOT' in environment passed to test runners.
2403         (Port._apache_config_file_name_for_platform): Use startswith('win').
2404         (Port._build_path): Ditto.
2405         (Port._path_to_driver): Include 'exe' suffix when running under native
2406         Windows.
2407         * Scripts/webkitpy/port/driver.py:
2408         (Driver._setup_environ_for_driver): Explicitly make some environment
2409         variables strings.
2410         * Scripts/webkitpy/port/server_process.py:
2411         (ServerProcess.__init__): Use startswith('win').
2412         * Scripts/webkitpy/port/win.py:
2413         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2414         registry key formats.
2415         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2416         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2417         and regtool on Cygwin.
2418         (WinPort.write_registry_value): Ditto.
2419         (WinPort.setup_crash_log_saving): Ditto.
2420         (WinPort.restore_crash_log_saving): Ditto.
2421         (WinPort.prevent_error_dialogs): Ditto.
2422         (WinPort.allow_error_dialogs): Ditto.
2423         (WinPort.find_system_pid): Revise to use Windows management
2424         infrastructure on native Windows, continue using 'ps' on Cygwin.
2425         (WinPort.read_registry_string): Deleted.
2426         (WinPort.write_registry_string): Deleted.
2427         * Scripts/webkitpy/test/main.py:
2428         (main): Use startswith('win').
2429         (Tester._parse_args): Ditto.
2430
2431 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2432
2433         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2434         https://bugs.webkit.org/show_bug.cgi?id=150792
2435
2436         Reviewed by Saam Barati.
2437
2438         * Scripts/webkitperl/FeatureList.pm:
2439
2440 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2441
2442         Unreviewed, rolling out r192914.
2443         https://bugs.webkit.org/show_bug.cgi?id=151734
2444
2445         JSC tests for this change are failing on 32 and 64-bit bots
2446         (Requested by ryanhaddad on #webkit).
2447
2448         Reverted changeset:
2449
2450         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2451         enable this feature"
2452         https://bugs.webkit.org/show_bug.cgi?id=150792
2453         http://trac.webkit.org/changeset/192914
2454
2455 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2456
2457         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2458         <http://webkit.org/b/151726>
2459
2460         Reviewed by Simon Fraser.
2461
2462         * WebKitTestRunner/mac/EventSenderProxy.mm:
2463         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2464         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2465
2466 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2467
2468         Give String and AtomicString an existingHash() function
2469         https://bugs.webkit.org/show_bug.cgi?id=151717
2470
2471         Reviewed by Andreas Kling.
2472
2473         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2474         (TestWebKitAPI::TEST):
2475         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2476         (TestWebKitAPI::TEST):
2477
2478 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2479
2480         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2481         https://bugs.webkit.org/show_bug.cgi?id=150792
2482
2483         Reviewed by Saam Barati.
2484
2485         * Scripts/webkitperl/FeatureList.pm:
2486
2487 2015-12-01  Sam Weinig  <sam@webkit.org>
2488
2489         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2490         <rdar://problem/23320863>
2491         https://bugs.webkit.org/show_bug.cgi?id=151708
2492
2493         Reviewed by Anders Carlsson.
2494
2495         * WebKitTestRunner/TestController.cpp:
2496         (WTR::TestController::createOtherPage):
2497         (WTR::TestController::createWebViewWithOptions):
2498         Update for new WKPageUIClient.
2499
2500 2015-12-01  Anders Carlsson  <andersca@apple.com>
2501
2502         Remove WebKit2.framework
2503         https://bugs.webkit.org/show_bug.cgi?id=151715
2504
2505         Reviewed by Dan Bernstein.
2506
2507         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2508         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2509         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2510         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2511         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2512         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2513         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2514
2515 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2516
2517         Unreviewed common typo fix "occurance" => "occurrence".
2518
2519         * Scripts/webkitpy/tool/commands/queries.py:
2520         (FindFlakyTests._print_statistics):
2521
2522 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2523
2524         Make ProcessModel always MultipleSecondaryProcesses
2525         https://bugs.webkit.org/show_bug.cgi?id=151662
2526
2527         Reviewed by Antti Koivisto.
2528
2529         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2530         (TestWebKitAPI::TEST):
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::TestController::generatePageConfiguration):
2533
2534 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2535
2536         Make usesNetworkProcess always true
2537         https://bugs.webkit.org/show_bug.cgi?id=151580
2538
2539         Reviewed by Darin Adler.
2540
2541         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2542         (TestWebKitAPI::TEST):
2543         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2544         (TestWebKitAPI::TEST):
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::TestController::generatePageConfiguration):
2547
2548 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2549
2550         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2551
2552         Add a way to skip unit tests only for Debug or Release builds and
2553         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2554
2555         * Scripts/run-gtk-tests:
2556         (SkippedTest):
2557         (SkippedTest.__init__):
2558         (SkippedTest.__str__):
2559         (SkippedTest.skip_entire_suite):
2560         (SkippedTest.skip_for_build_type):
2561         (TestRunner):
2562         (TestRunner.__init__):
2563
2564 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2565
2566         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2567
2568         It's an assert hit because we are reloading a view loaded with
2569         HTML data which is not supported. Use loadURI instead.
2570
2571         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2572         (testWebViewCustomCharset):
2573
2574 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2575
2576         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2577         https://bugs.webkit.org/show_bug.cgi?id=151633
2578
2579         Reviewed by Csaba Osztrogonác.
2580
2581         * TestWebKitAPI/PlatformGTK.cmake:
2582         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2583
2584 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2585
2586         [GTK] Remove the remaining uses of GMainLoopSource
2587         https://bugs.webkit.org/show_bug.cgi?id=151632
2588
2589         Reviewed by Žan Doberšek.
2590
2591         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2592         (testWebViewSyncRequestOnMaxConns):
2593         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2595         (WTR::TestRunner::TestRunner):
2596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2597         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2598         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2599         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2600         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2601         (WTR::timeoutSource):
2602         (WTR::TestController::notifyDone):
2603         (WTR::TestController::platformRunUntil):
2604
2605 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2606
2607         [cmake] Add testb3 to the build system
2608         https://bugs.webkit.org/show_bug.cgi?id=151619
2609
2610         Reviewed by Gyuyoung Kim.
2611
2612         * Scripts/build-jsc:
2613
2614 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2615
2616         [jhbuild] Fix pixman build with clang
2617         https://bugs.webkit.org/show_bug.cgi?id=151441
2618
2619         Reviewed by Carlos Garcia Campos.
2620
2621         * efl/jhbuild.modules:
2622         * gtk/jhbuild.modules:
2623
2624 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2625
2626         Extract prependToEnvironmentVariableList
2627         <http://webkit.org/b/151536>
2628
2629         Reviewed by Daniel Bates.
2630
2631         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2632                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2633
2634         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2635         and prependToEnvironmentVariableList.
2636         (appendToEnvironmentVariableList): Simplify variable name.
2637         Switch to use $Config{path_sep}.
2638         (prependToEnvironmentVariableList): Add new method.
2639         (setupMacWebKitEnvironment): Switch to use
2640         prependToEnvironmentVariableList().
2641         (setupIOSWebKitEnvironment): Ditto.
2642
2643         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2644         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2645
2646 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2647
2648         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2649         https://bugs.webkit.org/show_bug.cgi?id=151567
2650
2651         Reviewed by Darin Adler.
2652
2653         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2654         (on_window_deletion):
2655
2656 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2657
2658         [GTK] Use the network process unconditionally
2659         https://bugs.webkit.org/show_bug.cgi?id=151541
2660
2661         Reviewed by Alex Christensen.
2662
2663         Fix TestInspectorServer test. Do not assume we already have the
2664         title we want when the page has been loaded, since the title is
2665         changed afterwards. So, check if the title has already been set,
2666         and if not wait for it.
2667
2668         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2669         (openRemoteDebuggingSession):
2670
2671 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2672
2673         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2674         https://bugs.webkit.org/show_bug.cgi?id=151532
2675
2676         Reviewed by Benjamin Poulain.
2677
2678         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2679         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2680         (TestWebKitAPI::TEST):
2681         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2682         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2683         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2684         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2685         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2686         so it was calling a function on a test object that had gone out of scope.
2687         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2688         but that will become the default soon and that call will be removed.
2689
2690 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2691
2692         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2693         <http://webkit.org/b/151542>
2694
2695         Reviewed by Daniel Bates.
2696
2697         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2698         (base_url): Use the Port object (already passed in) to give us
2699         the path to the LayoutTests directory, which already checks for a
2700         --layout-tests-directory command-line switch.
2701         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2702         argument since we can get this from the Port object already
2703         passed in via Port.results_directory().  Also switch to use
2704         Port.layout_tests_dir() to get the LayoutTests directory.
2705
2706         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2707         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2708         Add test case for custom LayoutTests directory.
2709         (TestWebPlatformTestServer.test_previously_spawned_instance):
2710         Update Port object to set mock results directory as if it was
2711         set on the command-line.  Remove unneeded argument from
2712         WebPlatformTestServer constructor.
2713         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2714
2715         * Scripts/webkitpy/port/base.py:
2716         (Port.to.start_web_platform_test_server): Remove unneeded
2717         argument from WebPlatformTestServer constuctor.
2718
2719 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         [GTK] Some unit tests fail when using the network process
2722         https://bugs.webkit.org/show_bug.cgi?id=151490
2723
2724         Reviewed by Martin Robinson.
2725
2726         Run the soup server in a separate thread in TestResources test to
2727         avoid deadlocks.
2728
2729         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2730         /webkit2/WebKitWebResource/get-data when using the network process.
2731
2732         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2733         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2734         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2735         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2736         present, create a WorkQueue to run the server.
2737         (WebKitTestServer::run): Run the server in the work queue if it
2738         has been created.
2739         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2740         type into server options as flags.
2741
2742 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2743
2744         [GTK] ImageDiff should normalize the diff image
2745         https://bugs.webkit.org/show_bug.cgi?id=151261
2746
2747         Reviewed by Sergio Villar Senin.
2748
2749         * ImageDiff/gtk/ImageDiff.cpp:
2750         (readPixbufFromStdin): Fix memory leak.
2751         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2752         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2753
2754 == Rolled over to ChangeLog-2015-11-21 ==