[CSS Shadow Parts] Parse 'part' attribute
[WebKit-https.git] / Tools / ChangeLog
1 2019-10-01  Antti Koivisto  <antti@apple.com>
2
3         [CSS Shadow Parts] Parse 'part' attribute
4         https://bugs.webkit.org/show_bug.cgi?id=202409
5
6         Reviewed by Ryosuke Niwa.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (enableExperimentalFeatures):
10
11 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
12
13         Follow-up fix to r250572 to fix a typo.
14         [ews] Add method to retry a build using Buildbot API
15         https://bugs.webkit.org/show_bug.cgi?id=202408
16
17         Unreviewed follow-up fix.
18
19         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
20
21 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews] Add method to retry a build using Buildbot API
24         https://bugs.webkit.org/show_bug.cgi?id=202408
25
26         Reviewed by Jonathan Bedard.
27
28         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
29         (Buildbot.retry_build): Method to retry given build using Buildbot API.
30
31 2019-10-01  David Kilzer  <ddkilzer@apple.com>
32
33         clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
34         <https://webkit.org/b/202387>
35
36         Reviewed by Darin Adler.
37
38         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
39         (WTR::TestController::setAllowedMenuActions): Make loop variable
40         a reference to fix unnecessary copying/ref churn.
41
42 2019-10-01  Nikolas Zimmermann  <nzimmermann@igalia.com>
43
44         Update my affiliation - since today I work for Igalia.
45
46         Unreviewed.
47
48         * Scripts/webkitpy/common/config/contributors.json:
49
50 2019-10-01  Keith Miller  <keith_miller@apple.com>
51
52         Add support for the Wasm multi-value proposal
53         https://bugs.webkit.org/show_bug.cgi?id=202250
54
55         Reviewed by Saam Barati.
56
57         * Scripts/run-jsc-stress-tests:
58
59 2019-10-01  youenn fablet  <youenn@apple.com>
60
61         Remove races condition when validating capture sandbox extension revocation
62         https://bugs.webkit.org/show_bug.cgi?id=202133
63         <rdar://problem/55660905>
64
65         Reviewed by Eric Carlson.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
68         Updated test to not use page cache so that on going back, the page is reloaded and will call getUserMedia again.
69
70 2019-09-30  Alex Christensen  <achristensen@webkit.org>
71
72         Resurrect Mac CMake build
73         https://bugs.webkit.org/show_bug.cgi?id=202384
74
75         Rubber-stamped by Tim Horton.
76
77         * DumpRenderTree/PlatformMac.cmake:
78         * TestWebKitAPI/PlatformMac.cmake:
79
80 2019-09-30  Zhifei Fang  <zhifei_fang@apple.com>
81
82         [results.webkit.org Timeline] New axis style
83         https://bugs.webkit.org/show_bug.cgi?id=202292
84
85         Reviewed by Jonathan Bedard.
86
87         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
88
89 2019-09-30  Alex Christensen  <achristensen@webkit.org>
90
91         Move DownloadMonitor test speed multiplier from WebProcessPool to WebsiteDataStoreConfiguration
92         https://bugs.webkit.org/show_bug.cgi?id=202339
93
94         Reviewed by Youenn Fablet.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
97         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
98
99 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
100
101         [GTK] IconDatabase is not thread-safe
102         https://bugs.webkit.org/show_bug.cgi?id=201303
103
104         Reviewed by Žan Doberšek.
105
106         Rewrite the WebKitFaviconDatabase tests, splitting tests cases again and making them independent to each other.
107
108         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
109         (testFaviconDatabaseInitialization):
110         (testFaviconDatabaseGetFavicon):
111         (ephemeralViewFaviconChanged):
112         (testFaviconDatabaseEphemeral):
113         (testFaviconDatabaseClear):
114         (beforeAll):
115         (afterAll):
116         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFaviconDatabase shouls always pass now.
117
118 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
119
120         [GTK][WPE] Add about:gpu
121         https://bugs.webkit.org/show_bug.cgi?id=202305
122
123         Reviewed by Žan Doberšek.
124
125         Allow to use about:gpu in MiniBrowser. Add a script to get the current svn revision.
126
127         * MiniBrowser/gtk/BrowserTab.c:
128         (getInternalURI):
129         * MiniBrowser/gtk/main.c:
130         (argumentToURL):
131         * MiniBrowser/wpe/main.cpp:
132         (main):
133         * glib/svn-revision: Added.
134
135 2019-09-27  Andres Gonzalez  <andresg_22@apple.com>
136
137         Support accessibility for <figure> element on iOS.
138         https://bugs.webkit.org/show_bug.cgi?id=202272
139         <rdar://problem/54789907>
140
141         Reviewed by Chris Fleizach.
142
143         Implemented titleUIElement and roleDescription properties for <figure> elements on iOS.
144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
145         (WTR::AccessibilityUIElement::titleUIElement):
146         (WTR::AccessibilityUIElement::roleDescription):
147
148 2019-09-27  Alex Christensen  <achristensen@webkit.org>
149
150         Move shouldUseTestingNetworkSession from NetworkProcessCreationParameters to NetworkSessionCreationParameters
151         https://bugs.webkit.org/show_bug.cgi?id=202327
152
153         Reviewed by Tim Horton.
154
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::TestController::websiteDataStore):
157
158 2019-09-27  Alex Christensen  <achristensen@webkit.org>
159
160         Move service worker process termination delay disabling from process pool to website data store
161         https://bugs.webkit.org/show_bug.cgi?id=202308
162
163         Reviewed by Chris Dumez.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
166
167 2019-09-27  Alex Christensen  <achristensen@webkit.org>
168
169         Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
170         https://bugs.webkit.org/show_bug.cgi?id=202285
171
172         Reviewed by Youenn Fablet.
173
174         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
175         (-[ServerTrustDelegate webView:didFinishNavigation:]):
176         (-[ServerTrustDelegate webView:didFailProvisionalNavigation:withError:]):
177         (-[ServerTrustDelegate waitForDidFinishNavigation]):
178         (-[ServerTrustDelegate waitForDidFailProvisionalNavigationError]):
179         (-[ServerTrustDelegate authenticationChallengeCount]):
180         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
181         (TestWebKitAPI::TEST):
182         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
183         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
184         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation): Deleted.
185         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess): Deleted.
186         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount): Deleted.
187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
188         * WebKitTestRunner/TestController.cpp:
189         (WTR::TestController::resetStateToConsistentValues):
190         (WTR::TestController::didReceiveAuthenticationChallenge):
191         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
192         * WebKitTestRunner/TestController.h:
193         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const): Deleted.
194         * WebKitTestRunner/TestInvocation.cpp:
195         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
196         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
197         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
198
199 2019-09-27  Alex Christensen  <achristensen@webkit.org>
200
201         Remove unused APIProcessPoolConfiguration::diskCacheSpeculativeValidationEnabled
202         https://bugs.webkit.org/show_bug.cgi?id=202290
203
204         Reviewed by Carlos Garcia Campos.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
207         (TEST):
208         * WebKitTestRunner/TestController.cpp:
209         (WTR::TestController::websiteDataStore):
210         (WTR::TestController::generatePageConfiguration):
211
212 2019-09-27  Youenn Fablet  <youenn@apple.com>
213
214         Make IsNSURLSessionWebSocketEnabled an experimental flag
215         https://bugs.webkit.org/show_bug.cgi?id=202135
216         <rdar://problem/55694721>
217
218         Reviewed by Geoff Garen.
219
220         * WebKitTestRunner/TestController.cpp:
221         (WTR::TestController::resetPreferencesToConsistentValues):
222         Set preference to false by default.
223
224 2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
225
226         SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
227         https://bugs.webkit.org/show_bug.cgi?id=202061
228         <rdar://problem/55485666>
229
230         Reviewed by Youenn Fablet.
231
232         Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
235         (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
236         (resetState):
237         (TestWebKitAPI::TEST):
238
239 2019-09-26 Kate Cheney <katherine_cheney@apple.com>
240
241         Resource Load Statistics: Downgrade all third-party referrer headers
242         https://bugs.webkit.org/show_bug.cgi?id=201353
243         <rdar://problem/54895650>
244
245         Majority of this patch was written by John Wilander <wilander@apple.com>.
246
247         Reviewed by Brent Fulgham. 
248
249         The changes to the TestRunner facilitates an opt-out for test cases
250         that either test the referrer mechanism explicitly or tests that
251         rely on the full referrer to be sent. 
252
253         The new boolean variable and early return in 
254         TestRunner::setStatisticsShouldDowngradeReferrer() prevent the same
255         event from trying to set multiple TestRunner callbacks.
256
257         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
259         (WTR::InjectedBundle::didReceiveMessageToPage):
260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
261         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
262         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
264         * WebKitTestRunner/TestController.cpp:
265         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
266         * WebKitTestRunner/TestController.h:
267         * WebKitTestRunner/TestInvocation.cpp:
268         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
269         (WTR::TestInvocation::didSetShouldDowngradeReferrer):
270         * WebKitTestRunner/TestInvocation.h:
271
272 2019-09-26  Dean Jackson  <dino@apple.com>
273
274         Build fix.
275
276         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
277         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]): Deleted.
278         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]): Deleted.
279         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]): Deleted.
280         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]): Deleted.
281
282 2019-09-26  Dean Jackson  <dino@apple.com>
283
284         ContextMenu on a link in an email no longer shows web preview
285         https://bugs.webkit.org/show_bug.cgi?id=201120
286         <rdar://54353617>
287
288         Reviewed by Wenson Hsieh.
289
290         Test context menus on a link that is also an image.
291
292         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
293         (contextMenuWebViewDriver):
294         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
295         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]):
296         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
297         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]):
298         (TEST):
299
300 2019-09-26  Frederic Wang  <fwang@igalia.com>
301
302         run-safari --ios-simulator is no longer working with Xcode 11
303         https://bugs.webkit.org/show_bug.cgi?id=199852
304
305         Path of MobileSafari.app has changed in Xcode 11. This patch updates
306         the run-safari script to use the new path. This removes support for
307         running Safari on iOS < 13, see discussions on bug 177595.
308
309         Reviewed by Jonathan Bedard.
310
311         * Scripts/webkitdirs.pm:
312         (iosSimulatorApplicationsPath):
313
314 2019-09-26  Zhifei Fang  <zhifei_fang@apple.com>
315
316         [results.webkit.org] Timeline support Image inner label
317         https://bugs.webkit.org/show_bug.cgi?id=202180
318
319         Reviewed by Jonathan Bedard.
320
321         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
322         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
323         (.lengend>.item .dot img): support img symbol for lengend and dot
324         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
325         (Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
326
327 2019-09-26  Chris Dumez  <cdumez@apple.com>
328
329         Stop using testRunner.overridePreference() to turn on Page Cache
330         https://bugs.webkit.org/show_bug.cgi?id=202274
331
332         Reviewed by Alex Christensen.
333
334         * DumpRenderTree/TestRunner.cpp:
335         (overridePreferenceCallback):
336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
337         (WTR::TestRunner::overridePreference):
338
339 2019-09-26  Jonathan Bedard  <jbedard@apple.com>
340
341         results.webkit.org: Use cursor: pointer for clickable elements
342         https://bugs.webkit.org/show_bug.cgi?id=202268
343
344         Rubber-stamped by Aakash Jain.
345
346         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Give collapse button a pointer for cursor.
347         * resultsdbpy/resultsdbpy/view/templates/search.html: Make 'X' to close test timeline a link-button.
348
349 2019-09-26  Kate Cheney  <katherine_cheney@apple.com>
350
351         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
352         https://bugs.webkit.org/show_bug.cgi?id=195420                          
353         <rdar://problem/54213551>                                               
354
355         Reviewed by Brent Fulgham.                                             
356
357         Added in logic to send a message from the UIProcess to the Network      
358         Process which will initalize the ITP Database backend to allow for      
359         layout testing.                                                         
360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
361         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
362         (WTR::TestRunner::setUseITPDatabase):
363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::setUseITPDatabase):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/TestInvocation.cpp:
368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
369
370 2019-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
371
372         TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
373         https://bugs.webkit.org/show_bug.cgi?id=202273
374
375         Reviewed by Aakash Jain.
376
377         The content width scaling limits added in r250361 prevent this test from scaling down the content width (2000px
378         wide) to fit the viewport (375px). To avoid this issue, change the content width from 2000px to 1500px, which is
379         still a very wide content width for a web page.
380
381         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm:
382
383 2019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
384
385         toExponential, toFixed, and toPrecision should allow arguments up to 100
386         https://bugs.webkit.org/show_bug.cgi?id=199163
387
388         Reviewed by Ross Kirsling.
389
390         Adjust StringNumberFixedWidth test due to lowering kMaxFixedDigitsBeforePoint.
391
392         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
393
394 2019-09-26  Jiewen Tan  <jiewen_tan@apple.com>
395
396         TestWebKitAPI.SOAuthorizationSubFrame.AuthorizationOptions is failing consistently on iOS API tests EWS
397         https://bugs.webkit.org/show_bug.cgi?id=202249
398
399         Reviewed by Alex Christensen.
400
401         Swizzles +[AKAuthorizationController isURLFromAppleOwnedDomain:] following other tests.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
404         (TestWebKitAPI::TEST):
405
406 2019-09-25  Alex Christensen  <achristensen@webkit.org>
407
408         Add replacement SPI on _WKWebsiteDataStoreConfiguration for enabling speculative cache validation and IPC-free server trust evaluation
409         https://bugs.webkit.org/show_bug.cgi?id=202251
410
411         Reviewed by Tim Horton.
412
413         Adopt new SPI instead of deprecated SPI.
414
415         * MiniBrowser/mac/AppDelegate.m:
416         (persistentDataStore):
417         (defaultConfiguration):
418         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
419         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
420         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
421
422 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
423
424         Python 3: Add support in webkitpy.common.system
425         https://bugs.webkit.org/show_bug.cgi?id=201826
426         <rdar://problem/55452671>
427
428         Reviewed by Stephanie Lewis.
429
430         Tested compatibility by running 'python3 -m unittest webkitpy.common.system.<_unittest>' on
431         each of the effected files.
432
433         * Scripts/webkitpy/common/checkout/changelog.py: Import StringIO from io module.
434         (set_reviewer):
435         (set_short_description_and_bug_url):
436         * Scripts/webkitpy/common/checkout/checkout.py:  Import StringIO from io module.
437         (Checkout._latest_entry_for_changelog_at_revision):
438         * Scripts/webkitpy/common/config/committers.py:
439         (CommitterList.load_json): iteritems -> items.
440         * Scripts/webkitpy/common/net/networktransaction.py:
441         (NetworkTransaction.run): urllib2 is urllib in Python3. 
442         * Scripts/webkitpy/common/system/abstractexecutive.py:
443         (AbstractExecutive._stringify_args):
444         (AbstractExecutive.command_for_printing): The str type is unicode in Python3.
445         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Explicitly encode and decode binary crashlogs.
446         * Scripts/webkitpy/common/system/environment_unittest.py: Use absolute imports.
447         * Scripts/webkitpy/common/system/executive.py:
448         (ScriptError.message_with_output): The str type is unicode in Python3.
449         (Executive.WrappedPopen): Python3's Popen object is a context manager. To allow us to use it as one,
450         our Python2 Popen needs to be one as well.
451         (Executive.WrappedPopen.__init__):
452         (Executive.WrappedPopen.__enter__):
453         (Executive.WrappedPopen.__exit__):
454         (Executive._run_command_with_teed_output): Simplify loop, decode unicode strings.
455         (Executive.run_and_throw_if_fail): The child output file should not be unicode strings.
456         (Executive.running_pids): Use the Popen context manager to guarantee clean-up.
457         (Executive._compute_stdin):
458         (Executive.run_command): Use the Popen context manager to guarantee clean-up.
459         (Executive._stringify_args): The str type is unicode in Python3.
460         (Executive.popen): Return a context manager if the Popen object is not one.
461         * Scripts/webkitpy/common/system/executive_mock.py:
462         (MockProcess.__init__): StringIO -> BytesIO.
463         (MockProcess.__enter__):
464         (MockProcess):
465         (MockProcess.__exit__):
466         * Scripts/webkitpy/common/system/executive_unittest.py:
467         (ExecutiveTest.test_auto_stringify_args): Use the Popen context manager to guarantee clean-up.
468         (ExecutiveTest.test_popen_args): Ditto.
469         (ExecutiveTest.serial_test_kill_process): Ditto.
470         (ExecutiveTest.serial_test_kill_all): Ditto.
471         * Scripts/webkitpy/common/system/filesystem.py:
472         (FileSystem.read_binary_file): Use 'open' instead of 'file'.
473         (FileSystem.write_binary_file): Ditto.
474         (FileSystem.write_text_file): The str type is unicode in Python3. 
475         (FileSystem.relpath):
476         (FileSystem.remove): The WindowsError is just anther OSError in Python3.
477         (FileSystem._WindowsError): Deleted.
478         * Scripts/webkitpy/common/system/filesystem_mock.py:
479         (MockFileSystem.glob): filter returns a generator instead of a list.
480         (WritableBinaryFileObject.__init__): Binary files are comprised of bytes, not string in Python3.
481         (WritableBinaryFileObject.write): Ditto.
482         (ReadableTextFileObject.__init__): Ditto.
483         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
484         (MockFileSystemTest.test_normpath):
485         (MockFileSystemTest.test_dirs_under): assertEquals -> assertEqual.
486         * Scripts/webkitpy/common/system/filesystem_unittest.py:
487         (RealFileSystemTest.test_read_and_write_file): Explicitly define byte arrays instead of strings.
488         (RealFileSystemTest.test_remove_file_with_retry.remove_with_exception): The WindowsError is just
489         anther OSError in Python3.
490         * Scripts/webkitpy/common/system/outputcapture.py:
491         * Scripts/webkitpy/common/system/outputtee_unittest.py:
492         (SimpleTeeTest.test_simple_tee):
493         * Scripts/webkitpy/common/system/path.py:
494         (_escape): urllib library has been broken into parts.
495         * Scripts/webkitpy/common/system/pemfile.py:
496         (_parse_pem_format.find_end): Python3 does not define a maxint.
497         * Scripts/webkitpy/common/system/pemfile_unittest.py:
498         * Scripts/webkitpy/common/system/platforminfo.py:
499         (PlatformInfo.total_bytes_memory): Not 'long' type in Python3.
500         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
501         (TestPlatformInfo.test_real_code): assertNotEquals -> assertNotEqual.
502         (TestPlatformInfo.test_display_name): Ditto.
503         * Scripts/webkitpy/common/system/profiler.py:
504         (ProfilerFactory.create_profiler): Manually implement ifilter.
505         * Scripts/webkitpy/common/system/profiler_unittest.py: Use absolute imports.
506         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
507         (current_thread_id): items() returns a generator in Python3.
508         * Scripts/webkitpy/common/system/systemhost.py: Use absolute imports.
509         * Scripts/webkitpy/common/system/urlfetcher.py: Removed.
510         * Scripts/webkitpy/common/system/urlfetcher_mock.py: Removed.
511         * Scripts/webkitpy/common/system/user.py:
512         (User.prompt): Use absolute imports, raw_input -> input.
513         (User.prompt_with_multiple_lists):
514         (User.prompt_with_list):
515         (User.confirm):
516         * Scripts/webkitpy/common/unicode.py: Tooling to manage compatibility between Python 2
517         and Python 3 unicode handling.
518         * Scripts/webkitpy/common/system/user_mock.py:
519         (MockUser.prompt): raw_input -> input.
520         (MockUser.prompt_with_list): Ditto.
521         * Scripts/webkitpy/common/version.py:
522         (Version.from_iterable): xrange -> range.
523         (Version.from_name): Use absolute import path.
524         (Version.__contains__): xrange -> range.
525         (Version.__str__): xrange -> range.
526         (Version.__cmp__): amp is no longer an operator in Python3, but versions are comprised
527         Of integers, so subtraction has the same effect.
528         (Version):
529         (Version.__eq__): __cmp__ operator is no longer respected, so we need to implement
530         each comparison.
531         (Version.__ne__): Ditto.
532         (Version.__lt__): Ditto.
533         (Version.__le__): Ditto.
534         (Version.__gt__): Ditto.
535         (Version.__ge__): Ditto.
536         * Scripts/webkitpy/common/version_name_map.py:
537         (VersionNameMap._automap_to_major_version):
538         (VersionNameMap.to_name): xrange -> range.
539         (VersionNameMap.from_name): iteritems -> items.
540         * Scripts/webkitpy/common/version_name_map_unittest.py: Use absolute imports.
541         * Scripts/webkitpy/common/version_unittest.py: Ditto.
542         * Scripts/webkitpy/common/wavediff.py:
543         (WaveDiff.__init__): StringIO -> BytesIO.
544         * Scripts/webkitpy/port/__init__.py:
545         (outside):
546
547 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
548
549         [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
550         https://bugs.webkit.org/show_bug.cgi?id=202216
551
552         Reviewed by Jonathan Bedard.
553
554         * BuildSlaveSupport/ews-build/steps.py:
555         (RunJavaScriptCoreTestsToT): Removed the command so as to use the command from base class.
556         * BuildSlaveSupport/ews-build/steps_unittest.py: Updatd unit-tests.
557
558 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
559
560         [ews] JSC queues should run or skip tests based on runTests key from config.json
561         https://bugs.webkit.org/show_bug.cgi?id=202223
562
563         Reviewed by Jonathan Bedard.
564
565         * BuildSlaveSupport/ews-build/config.json: Added the runTests key.
566         * BuildSlaveSupport/ews-build/factories.py:
567         (JSCTestsFactory.__init__): Add RunJavaScriptCoreTests step based on runTests key.
568         * BuildSlaveSupport/ews-build/loadConfig.py:
569         (loadBuilderConfig): Pass the runTests key to the factory.
570         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
571         (ConfigDotJSONTest.test_builder_keys): Added the runTests key.
572
573 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
574
575         results.webkit.org: Add investigation drawer
576         https://bugs.webkit.org/show_bug.cgi?id=202106
577
578         Reviewed by Dewei Zhu.
579
580         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Support multiple 'main' classes.
581         * resultsdbpy/resultsdbpy/view/static/js/expectations.js: Added.
582         (Expectations.colorMap): Return a dictionary mapping type strings to colors.
583         (Expectations.stringToStateId): Map a string to a state ID for sorting.
584         (Expectations.typeForId): Return a type string given an ID.
585         (Expectations.symbolForId): Return a symbol for a type given an ID.
586         (Expectations.colorForId): Return a color given an ID.
587         (Expectations.unexpectedResults): Given a list of actual results and expected results,
588         return a state.
589         (Expectations):
590         * resultsdbpy/resultsdbpy/view/static/js/investigate.js: Added.
591         (commitsForUuid):
592         (testRunLink):
593         (elapsed):
594         (percentage):
595         (contentForAgregateData):
596         (contentForData):
597         (_InvestigateDrawer):
598         (_InvestigateDrawer.prototype.isRendered):
599         (_InvestigateDrawer.prototype.expand): Expand the investigation drawer.
600         (_InvestigateDrawer.prototype.collapse): Collapse the investigation drawer.
601         (_InvestigateDrawer.prototype.select): Select an element to investigate.
602         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
603         (statsForSingleResult): Move Expectation constants.
604         (TimelineFromEndpoint.prototype.render): Investigate specific data points instead
605         of jumping to the build.
606         (Expectations.stringToStateId): Deleted.
607         (Expectations.unexpectedResults): Deleted.
608         (Expectations): Deleted.
609         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
610         (.drawer.display): Make minimum height.
611         (@media screen and (min-width: 600px)): Move main and sidebar so they override drawer.
612         (@media screen and (min-width: 768px)): Ditto.
613         * resultsdbpy/resultsdbpy/view/templates/commits.html:
614         * resultsdbpy/resultsdbpy/view/templates/search.html:
615         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
616
617 2019-09-25  Alex Christensen  <achristensen@webkit.org>
618
619         Remove duplicate WebsiteDataStoreConfiguration copying code
620         https://bugs.webkit.org/show_bug.cgi?id=202215
621
622         Reviewed by Tim Horton.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
625         (TEST):
626
627 2019-09-25  Alex Christensen  <achristensen@webkit.org>
628
629         Replace WebsiteDataStoreParameters::privateSessionParameters with re-initializing all sessions immediately upon NetworkProcess resumption
630         https://bugs.webkit.org/show_bug.cgi?id=202211
631
632         Reviewed by Tim Horton.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
635         (checkRecoveryAfterCrash):
636         (TEST):
637
638 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
639
640         [EWS] JSC queues should dynamically add required build steps for re-testing the patch
641         https://bugs.webkit.org/show_bug.cgi?id=202170
642
643         Reviewed by Jonathan Bedard.
644
645         * BuildSlaveSupport/ews-build/factories.py:
646         (JSCTestsFactory.__init__): Do not add ReRunJavaScriptCoreTests and related steps here, as
647         these are dynamically added (if required) in steps.py.
648         * BuildSlaveSupport/ews-build/steps.py:
649         (CompileJSCToT): Remove doStepIf() and hideStepIf() method, these are no longer required as we add
650         this step dynamically only if required. We don't need an extra property ('patchFailedToBuild') to be set.
651         (RunJavaScriptCoreTests.evaluateCommand): Dynamically add ReRunJavaScriptCoreTests step if required.
652         (ReRunJavaScriptCoreTests): Removed doStepIf() and hideStepIf() method.
653         (ReRunJavaScriptCoreTests.evaluateCommand): Dynamically add UnApplyPatchIfRequired(), CompileJSCToT() and RunJavaScriptCoreTestsToT steps.
654         (RunJavaScriptCoreTestsToT.evaluateCommand): Overriden to avoid caling the base-class method which dynamically adds
655         more steps.
656         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
657
658 2019-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
659
660         [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
661         https://bugs.webkit.org/show_bug.cgi?id=202167
662         <rdar://problem/55185021>
663
664         Reviewed by Tim Horton.
665
666         Rebaseline an API test.
667
668         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
669         (TestWebKitAPI::TEST):
670
671 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
672
673         Unreviewed, rolling out r250324.
674
675         Tools/ChangeLog
676
677         Reverted changeset:
678
679         "Enable LayoutTests using ResourceLoadStatistics SQLite
680         backend (195420)"
681         https://bugs.webkit.org/show_bug.cgi?id=195420
682         https://trac.webkit.org/changeset/250324
683
684 2019-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
685
686         [Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account
687         https://bugs.webkit.org/show_bug.cgi?id=202134
688
689         Reviewed by Jonathan Bedard.
690
691         _apache_config_file_name_for_platform always returns a config file
692         name for PHP5 on Cygwin Python, one for PHP7 on Win32 Python. It
693         should detect the system PHP version as Linux ports do.
694
695         Both AppleWin and WinCairo are using XAMPP Apache. Unify the code
696         paths for them. And, remove a stale conf file.
697
698         This change makes it possible to use Cygwin Python with PHP7.
699
700         * Scripts/webkitpy/port/base.py:
701         (Port._win_php_version): Added.
702         (Port._apache_config_file_name_for_platform): Unified cygwin and
703         win32 code path by using _win_php_version.
704         * Scripts/webkitpy/port/port_testcase.py:
705         (test_apache_config_file_name_for_platform): Updated cygwin and
706         win32 test cases.
707
708 2019-09-24  Matt Lewis  <jlewis3@apple.com>
709
710         Bring up queues for iPadOS Simulator Tests
711         https://bugs.webkit.org/show_bug.cgi?id=202151
712
713         Reviewed by Jonathan Bedard.
714
715         * BuildSlaveSupport/build.webkit.org-config/config.json:
716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
717         (WebKitBuildbot):
718         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
719
720 2019-09-24  Kate Cheney  <katherine_cheney@apple.com>
721
722         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
723         https://bugs.webkit.org/show_bug.cgi?id=195420                          
724         <rdar://problem/54213551>                                               
725
726         Reviewed by Brent Fulgham.                                             
727
728         Added in logic to send a message from the UIProcess to the Network      
729         Process which will initalize the ITP Database backend to allow for      
730         layout testing.                                                         
731         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
732         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
733         (WTR::TestRunner::setUseITPDatabase):
734         * WebKitTestRunner/InjectedBundle/TestRunner.h:
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::TestController::setUseITPDatabase):
737         * WebKitTestRunner/TestController.h:
738         * WebKitTestRunner/TestInvocation.cpp:
739         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
740
741 2019-09-24  Patrick Griffis  <pgriffis@igalia.com>
742
743         Add Patrick Griffis to contributors.json
744
745         Unreviewed.
746
747         * Scripts/webkitpy/common/config/contributors.json:
748
749 2019-09-24  Aakash Jain  <aakash_jain@apple.com>
750
751         [ews-build] Improve summary for Validate Patch step
752         https://bugs.webkit.org/show_bug.cgi?id=202163
753
754         Reviewed by Jonathan Bedard.
755
756         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Remove the redundant message saying:
757         'Some messages were logged while the patch was still eligible'.
758         * BuildSlaveSupport/ews-build/steps.py:
759         (ValidatePatch.skip_build): Updated the descritionDone with the reason to skip the patch.
760         (ValidatePatch.getResultSummary): Overrode this method so as to prevent buildbot from automatically
761         appending '(failure)' at the end of the summary string.
762
763 2019-09-24  Keith Rollin  <krollin@apple.com>
764
765         Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
766         https://bugs.webkit.org/show_bug.cgi?id=202119
767         <rdar://problem/55638792>
768
769         Reviewed by Alex Christensen.
770
771         After refactoring and other code evolution, some platform checks have
772         ended up looking like PLATFORM(MAC) || PLATFORM(IOS_FAMILY) (or
773         vice-versa). These can be converted into the equivalent
774         PLATFORM(COCOA). Where the instance occurs in a Cocoa-only file, the
775         check can be removed altogether (along with any "#else" branches).
776
777         * DumpRenderTree/AccessibilityTextMarker.h:
778         * DumpRenderTree/AccessibilityUIElement.cpp:
779         (AccessibilityUIElement::setValue):
780
781 2019-09-24  Zhifei Fang  <zhifei_fang@apple.com>
782
783         Add tests for Ref.js.
784         https://bugs.webkit.org/show_bug.cgi?id=201778.
785
786         Reviewed by Jonathan Bedard.
787
788         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
789         (applyStateDiff): null, 0, false are all valid state
790         (Ref.prototype.setState): We should do nothing for undefined stateDiff
791         * resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added.
792         (AssertFailedError):
793         (Expect): Perform assertions during unit tests.
794         (Expect.prototype.isType):
795         (Expect.prototype.equalToValue):
796         (Expect.prototype.equalToHtmlWithoutRef):
797         (Expect.prototype.notEqualToValue):
798         (Expect.prototype.greaterThan):
799         (Expect.prototype.greaterThanOrEqualTo):
800         (Expect.prototype.lessThan):
801         (Expect.prototype.lessThanOrEqualTo):
802         (TestSuite): Common TestSuite class for user to extend. 
803         (TestSuite.prototype.expect):
804         (TestSuite.prototype.sleep): Test will sleep for certain ms
805         (TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout
806         (TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout
807         (TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout
808         (TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout
809         (TestSuite.prototype.async.setup): Common interface for setup a test suite
810         (TestSuite.prototype.async.clearUp): Common interface for clear up a test suite
811         (getTestFucntionNames): Collect all the test method of a test instance.
812         (TestResult):
813         (TestResult.prototype.catchException):
814         (async.getTestResult): Run the test and generate a TestResult object
815         (TestController):
816         (TestController.prototype.addResultHandler): Test controller will send notification of a test result to result handler
817         (TestController.prototype.addSetupArgs): This gives some additional args for the common setup method for each test class, 
818         it is the best place to setup something like a root element, a fake data source, etc
819         (TestController.prototype.collect): This method used for collect the test classes.
820         (TestController.prototype.async.collectFile): It will import the file as a module dynamicly and collect all the test classes that module export
821         (TestController.prototype.async.runTest): It will run a test method of a test class
822         (TestController.prototype.async.run): It will run all test or a test class or a test method
823         * resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js: components for test app.
824         * resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js: Ref.js test cases.
825         * resultsdbpy/resultsdbpy/view/static/library/js/test/index.html: Test app entry.
826
827 2019-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
828
829         FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState triggers a debug assertion
830         https://bugs.webkit.org/show_bug.cgi?id=202145
831         <rdar://problem/51273128>
832
833         Reviewed by Tim Horton.
834
835         Fixes this API test to work on iPad as well as iPhone. Importantly, we show a popover when focusing
836         select elements on iPad, which means that there is no -inputView present on WKContentView, and upon
837         dismissing the form accessory view, the select element is still focused.
838
839         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
840
841 2019-09-25  Cathie Chen  <cathiechen@igalia.com>
842
843         Add Cathie Chen as WebKit committer
844
845         Unreviewed.
846
847         * Scripts/webkitpy/common/config/contributors.json:
848
849 2019-09-24  Alex Christensen  <achristensen@webkit.org>
850
851         Require a WebsiteDataStore when creating or resuming downloads
852         https://bugs.webkit.org/show_bug.cgi?id=202081
853
854         Reviewed by Youenn Fablet.
855
856         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
857         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
858
859 2019-09-23  Zan Dobersek  <zdobersek@igalia.com>
860
861         run-web-platform-tests: remove support for in-repository manifest, expectation management
862         https://bugs.webkit.org/show_bug.cgi?id=202037
863
864         Reviewed by Carlos Alberto Lopez Perez.
865
866         Instead of keeping wpt metadata inside the WebKit repository or have it
867         generated on-the-fly, provide additional option flags for the
868         run-web-platform-tests script that allows detailed specification of the
869         metadata, manifest and include manifest locations, if necessary.
870
871         If the metadata location is not provided, the wptrunner tool will simply
872         not rely on any metadata to adjust expected results. With no manifest
873         path specified, the manifest will be generated inside the wpt checkout.
874         If no include manifest is specified, all the tests will be initially
875         selected for running (until they're possibly filtered through additional
876         command line arguments).
877
878         * Scripts/webkitpy/common/config/ports_mock.py:
879         (MockPort.run_bindings_tests_command):
880         (MockPort.wpt_metadata_directory): Deleted.
881         (MockPort.wpt_manifest_file): Deleted.
882         * Scripts/webkitpy/port/base.py:
883         (Port.default_results_directory):
884         (Port.wpt_metadata_directory): Deleted.
885         (Port.wpt_manifest_file): Deleted.
886         * Scripts/webkitpy/w3c/wpt_runner.py:
887         (parse_args):
888         (WPTRunner.prepare_wpt_checkout):
889         (WPTRunner.run):
890         (WPTRunner._generate_metadata_directory): Deleted.
891         (WPTRunner._wpt_run_paths): Deleted.
892         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
893         (WPTRunnerTest.TestInstance.__init__):
894         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
895         (WPTRunnerTest.test_run):
896         (WPTRunnerTest.test_run_with_specified_options):
897         (WPTRunnerTest.test_run_with_args):
898         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): Deleted.
899         (WPTRunnerTest.test_generate_metadata_directory): Deleted.
900
901 2019-09-23  Fujii Hironori  <Hironori.Fujii@sony.com>
902
903         [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown
904         https://bugs.webkit.org/show_bug.cgi?id=201913
905
906         Reviewed by Ross Kirsling.
907
908         Implemented eventSender.keyDown for Windows WebKitTestRunner based
909         on DumpRenderTree implementation.
910
911         There is a difference between them. Only WTR truns KF_UP and
912         KF_REPEAT flags on for WM_KEYUP event.
913         EventSenderProxy::dispatchMessage is used in WTR. It calls
914         TranslateMessage, this introduces the difference. If I didn't turn
915         those bits, TranslateMessage posts WM_CHAR even for WM_KEYUP.
916         According the spec, WM_KEYUP needs those bits.
917         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-keyup>
918         DRT doesn't need the those bits becasuse it doesn't use
919         TranslateMessage for WM_KEYUP.
920
921         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
922         (WTR::makeKeyDataForScanCode): Added.
923         (WTR::pumpMessageQueue): Added.
924         (WTR::EventSenderProxy::keyDown): Implemented by using DRT code.
925
926 2019-09-23  Aakash Jain  <aakash_jain@apple.com>
927
928         [EWS] Rename CompileJSCOnly to CompileJSC
929         https://bugs.webkit.org/show_bug.cgi?id=202118
930
931         Reviewed by Jonathan Bedard.
932
933         * BuildSlaveSupport/ews-build/factories.py:
934         (JSCTestsFactory.__init__): Renamed CompileJSCOnly to CompileJSC.
935         * BuildSlaveSupport/ews-build/steps.py:
936         (CompileWebKit.evaluateCommand): Ditto.
937         (AnalyzeCompileWebKitResults.start): Ditto.
938         (CompileJSC): Changed step-name to 'compile-jsc' to better match with similar steps like 'compile-webkit'. 
939         (CompileJSCToT): Ditto for 'compile-jsc-tot'.
940         * BuildSlaveSupport/ews-build/steps_unittest.py: Renamed CompileJSCOnly to CompileJSC and CompileJSCOnlyToT to CompileJSCToT.
941
942 2019-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
943
944         [iOS] Drop animation when dragging images from Photos to WebKit2 Mail compose is incorrect
945         https://bugs.webkit.org/show_bug.cgi?id=201674
946         <rdar://problem/51250952>
947
948         Reviewed by Tim Horton.
949
950         Add a couple of new API tests to exercise the new image placeholder drop codepath, in addition to testing
951         infrastructure to simulate the timing of drop animation delegate calls.
952
953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
954         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
955         (-[NSArray _attachmentWithName:]):
956         (-[TestWKWebView allBoundingClientRects:]):
957
958         Add some new API testing helper methods.
959
960         (TestWebKitAPI::targetedImageDragPreview):
961         (TestWebKitAPI::TEST):
962
963         Add two new tests, to:
964         (1) verify that images are dropped as attachment-backed placeholder image elements when the web view is editable
965             and enables attachment elements, and
966         (2) verify that when dropping an image taller than the web view, the bottom portion of the drop preview is
967             clipped using the targeted preview parameter's visiblePath.
968
969         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
970         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
971         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
972         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h: Added.
973         * TestWebKitAPI/cocoa/NSItemProviderAdditions.mm: Added.
974
975         Move some common helpers for registering data on a NSItemProvider to a separate file, so that it can be used in
976         both WKAttachmentTests and DragAndDropTests.
977
978         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
979         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:loadingDelay:]):
980         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
981         (-[DragAndDropSimulator initWithWebView:]):
982         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
983         (-[DragAndDropSimulator clearExternalDragInformation]):
984         (-[DragAndDropSimulator setExternalItemProviders:defaultDropPreviews:]):
985
986         Add a new method to allow tests to specify both a list of externally dragged item providers, as well as default
987         targeted previews for each of the corresponding items. These default previews are used when invoking the drop
988         interaction delegate's preview generation methods.
989
990         (-[DragAndDropSimulator addAnimations:]):
991
992         Not implemented yet; for now, this simply asserts.
993
994         (-[DragAndDropSimulator addCompletion:]):
995
996         Queues a completion handler, which is invoked when the drop animation for each item completes. Depending on the
997         value of DragAndDropSimulator's -dropAnimationTiming, this may occur either before or after handling the drop.
998         By default, these will be invoked after the drop completes, which represents the common case where data can be
999         loaded quickly relative to the drop animation.
1000
1001         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
1002         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1003
1004 2019-09-23  Jonathan Bedard  <jbedard@apple.com>
1005
1006         results.webkit.org: Collapse results with the same version name (Follow-up fix)
1007         https://bugs.webkit.org/show_bug.cgi?id=201779
1008
1009         Rubber-stamped by Aakash Jain.
1010
1011         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1012         (Configuration.prototype.compare): Correctly compare constructed version names.
1013
1014 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1015
1016         [WebAuthn] LocalAuthenticator tests are failing on internal bots
1017         https://bugs.webkit.org/show_bug.cgi?id=201844
1018         <rdar://problem/54278693>
1019
1020         Reviewed by Brent Fulgham.
1021
1022         LocalAuthenticator tests utilize Keychain for mock testing. Unlike iOS simulator tests which
1023         each test runner is running in different simulator containers, all test runners are running
1024         in the same macOS container in macOS. Therefore, Keychain is shared among all test runners
1025         in macOS while it is not in iOS simulators. And therefore, race conditions would happen in
1026         macOS which make the current tests flaky given they don't consider race conditions.
1027
1028         This patch then makes each test generate a random credential, and thus no other tests would
1029         be able to access it, and therefore eliminate any race condition. To support this, a few new
1030         functionalities are introduced to the mock test infrastructure as well:
1031         1) TestRunner.cleanUpKeychain accepts a new parameter to more precisely identify an item.
1032         2) WebAuthenticationMockConfiguration.Local has a new member to uniquely select a credential
1033         for getAssertion ceremony when multiple presents.
1034
1035         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1036         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1037         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1038         (WTR::TestRunner::cleanUpKeychain):
1039         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1040         * WebKitTestRunner/TestController.h:
1041         * WebKitTestRunner/TestInvocation.cpp:
1042         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::cleanUpKeychain):
1045         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1046         (WTR::TestController::cleanUpKeychain):
1047
1048 2019-09-20  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [EWS] JSC queues should re-build ToT and compare results on build failure
1051         https://bugs.webkit.org/show_bug.cgi?id=201999
1052
1053         Reviewed by Jonathan Bedard.
1054
1055         * BuildSlaveSupport/ews-build/factories.py:
1056         (JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
1057         these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
1058         Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.
1059         * BuildSlaveSupport/ews-build/steps.py:
1060         (CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
1061         (AnalyzeCompileWebKitResults.start): Ditto.
1062         (CompileJSCOnly.start): Set the 'group' property to 'jsc'.
1063         (CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is 
1064         not used, base class evaluateCommand adds build-steps dynamically.
1065
1066 2019-09-20  Keith Rollin  <krollin@apple.com>
1067
1068         Remove some support for < iOS 13
1069         https://bugs.webkit.org/show_bug.cgi?id=201967
1070         <rdar://problem/55504738>
1071
1072         Reviewed by Andy Estes.
1073
1074         Remove some support for iOS versions less than 13.0.
1075
1076         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1077         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1078         values >= 130000. This means that expressions like
1079         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1080         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1081
1082         After version checks have been removed, there are some cases where the
1083         preprocessor conditional looks like "#if PLATFORM(MAC) ||
1084         PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
1085         PLATFORM(COCOA)". This additional cleanup will be performed in a
1086         subsequent patch.
1087
1088         This removal is part of a series of patches effecting the removal of
1089         dead code for old versions of iOS. This particular pass involves
1090         changes in which Andy Estes was involved. These changes are isolated
1091         from other similar changes in order to facilitate the reviewing
1092         process.
1093
1094         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.
1095
1096 2019-09-20  Alex Christensen  <achristensen@webkit.org>
1097
1098         Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
1099         https://bugs.webkit.org/show_bug.cgi?id=202025
1100
1101         Reviewed by Chris Dumez.
1102
1103         One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
1104         because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
1107         * WebKitTestRunner/TestController.cpp:
1108         (WTR::TestController::websiteDataStore):
1109         (WTR::TestController::generatePageConfiguration):
1110
1111 2019-09-20  Keith Rollin  <krollin@apple.com>
1112
1113         Remove some support for < iOS 13
1114         https://bugs.webkit.org/show_bug.cgi?id=201973
1115         <rdar://problem/55506966>
1116
1117         Reviewed by Alex Christensen.
1118
1119         Remove some support for iOS versions less than 13.0.
1120
1121         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1122         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1123         values >= 130000. This means that expressions like
1124         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1125         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1126
1127         This removal is part of a series of patches effecting the removal of
1128         dead code for old versions of iOS. This particular pass involves
1129         changes in which Chris Dumez was involved. These changes are isolated
1130         from other similar changes in order to facilitate the reviewing
1131         process.
1132
1133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1134
1135 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1136
1137         [FTW] Enable WebKitTestRunner build
1138         https://bugs.webkit.org/show_bug.cgi?id=201996
1139
1140         Reviewed by Fujii Hironori.
1141
1142         It's time to start getting the test system up and running for FTW.
1143
1144         This patch does the following:
1145
1146         1. Adds relevant CMake changes to get things building.
1147         2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
1148         3. Updates 'webkitpy' to recognize the 'ftw' port.
1149
1150         Note: Pixel tests are not yet supported.
1151
1152         * PlatformFTW.cmake: Build the WK2 test runner.
1153         * Scripts/build-webkit: Update to recognize the FTW port.
1154         * Scripts/webkitdirs.pm: Ditto.
1155         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Ditto.
1156         * Scripts/webkitpy/common/config/ports.py: Ditto.
1157         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1158         * Scripts/webkitpy/common/version_name_map.py: Ditto.
1159         * Scripts/webkitpy/port/factory.py: Ditto.
1160         * Scripts/webkitpy/port/win.py: Ditto.
1161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1162         (WTR::InjectedBundlePage::dumpDOMAsWebArchive): Don't build or run this method
1163         on Windows.
1164         * WebKitTestRunner/PlatformFTW.cmake: Added.
1165         * WebKitTestRunner/PlatformWebView.h:
1166         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1167         * WebKitTestRunner/win/TestInvocationDirect2D.cpp: Added.
1168         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add stub implementation.
1169
1170 2019-09-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1171
1172         [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
1173         https://bugs.webkit.org/show_bug.cgi?id=201976
1174
1175         Reviewed by Don Olmstead.
1176
1177         This change consists of three refactorings:
1178         1. Replaced explicit QueryInterface with _com_ptr_t methods
1179         2. Replaced typedef with _COM_SMARTPTR_TYPEDEF macro
1180         3. Replaced WebCore's COMPtr with _com_ptr_t because it is not a public WebKit API
1181
1182         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1183         (MiniBrowserWebHost::didFirstLayoutInFrame): Deleted.
1184         * MiniBrowser/win/MiniBrowserWebHost.h:
1185         (MiniBrowserWebHost::didFirstLayoutInFrame):
1186         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1187         (getHandleFromWebView):
1188         (PrintWebUIDelegate::webViewPrintingMarginRect):
1189         (PrintWebUIDelegate::runModal):
1190         (PrintWebUIDelegate::createModalDialog):
1191         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1192         (WebKitLegacyBrowserWindow::init):
1193         (WebKitLegacyBrowserWindow::setToDefaultPreferences):
1194         (WebKitLegacyBrowserWindow::showLastVisitedSites):
1195         (WebKitLegacyBrowserWindow::reload):
1196         (WebKitLegacyBrowserWindow::resetZoom):
1197         (WebKitLegacyBrowserWindow::zoomIn):
1198         (WebKitLegacyBrowserWindow::zoomOut):
1199         (WebKitLegacyBrowserWindow::showLayerTree):
1200         (WebKitLegacyBrowserWindow::print):
1201         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1202         (WebKitLegacyBrowserWindow::privatePreferences):
1203         * MiniBrowser/win/WinMain.cpp:
1204         (wWinMain):
1205         * MiniBrowser/win/stdafx.h:
1206
1207 2019-09-19  Joanmarie Diggs  <jdiggs@igalia.com>
1208
1209         [GTK] Dependency hunspell-en-gb cannot be found on Fedora 30
1210         https://bugs.webkit.org/show_bug.cgi?id=202009
1211
1212         Update package name to hunspell-en-GB.
1213
1214         Reviewed by Carlos Alberto Lopez Perez.
1215
1216         * gtk/install-dependencies:
1217
1218 2019-09-19  Jonathan Bedard  <jbedard@apple.com>
1219
1220         results.webkit.org: Collapse results with the same version name
1221         https://bugs.webkit.org/show_bug.cgi?id=201779
1222
1223         Rubber-stamped by Aakash Jain.
1224
1225         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1226         (Configuration.prototype.const.ending.this.version_name.substring):
1227         (Configuration.prototype.toKey): Prefer version_name over version number in key.
1228         (Configuration.prototype.compare): version_name comparison should always override version comparison.
1229         (Configuration.prototype.compareSDKs): Make SDK regex global.
1230         (Configuration.prototype.toParams): Remove E tag on version_name.
1231         (Configuration): Append E tag on the version_name based on the SDK.
1232         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1233         (TimelineFromEndpoint.prototype.toString): Print version number with SDK.
1234
1235 2019-09-19  Ryan Haddad  <ryanhaddad@apple.com>
1236
1237         REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
1238         https://bugs.webkit.org/show_bug.cgi?id=201902
1239
1240         Unreviewed test gardening.
1241
1242         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Disable the test on iOS.
1243
1244 2019-09-19  Aakash Jain  <aakash_jain@apple.com>
1245
1246         [ews] Fix platform for JSC EWS
1247         https://bugs.webkit.org/show_bug.cgi?id=201997
1248
1249         Reviewed by Jonathan Bedard.
1250
1251         * BuildSlaveSupport/ews-build/config.json:
1252
1253 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1254
1255         Create InjectedBundle SPI to better support NSSecureCoding
1256         https://bugs.webkit.org/show_bug.cgi?id=201810
1257         <rdar://problem/55265713>
1258
1259         The encoding/decoding routines used by WebKit’s InjectedBundles are based on NSCoding.
1260         While we have changed WebKit internals to use NSSecureCoding, there are a number of
1261         injected bundles that need to serialize custom classes between the InjectedBundle and
1262         the relevant WebKit UIProcess.
1263
1264         We need to lock down this communications channel by enforcing NSSecureCoding.
1265
1266         This patch creates new SPI to allow the UIProcess to specify classes that it will accept
1267         in messages from the WebContet Process (and Injected Bundle).
1268
1269         It adds the following property to the WKProcessPoolConfiguration:
1270
1271             @property (nonatomic, copy) NSSet<Class> *customClassesForParameterCoder;
1272
1273         If no custom classes are specified, the standard serialization primitives are supported:
1274             NSArray, NSData, NSDate, NSDictionary, NSNull, NSNumber, NSSet, NSString,
1275             NSTimeZone, NSURL, and NSUUID.
1276
1277         Reviewed by Brady Eidson.
1278
1279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1280         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm: Added.
1281         (-[BundleFormDelegateRemoteObject didGetFocus]):
1282         (-[FormInputDelegate _webView:decidePolicyForFocusedElement:]):
1283         (TEST):
1284         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegatePlugIn.mm: Added.
1285         (-[BundleFormDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1286         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:willBeginInputSessionForElement:inFrame:userIsInteracting:]):
1287         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:didFocusTextField:inFrame:]):
1288         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegateProtocol.h: Copied from Tools/TestWebKitAPI/WKWebViewConfigurationExtras.h.
1289         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1290         (TEST):
1291         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1292         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1293         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
1294         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:andCustomParameterClasses:]):
1295
1296 2019-09-18  Zhifei Fang  <zhifei_fang@apple.com>
1297
1298         [results.webkit.org] fix missing col classes
1299         https://bugs.webkit.org/show_bug.cgi?id=201949
1300
1301         Reviewed by Jonathan Bedard.
1302
1303         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1304         (@media screen and (min-width: 768px)):
1305         (.row):
1306         (.col-1):
1307         (.col-2):
1308         (.col-3):
1309         (.col-4):
1310         (.col-5):
1311         (.col-6):
1312         (.col-7):
1313         (.col-8):
1314         (.col-9):
1315         (.col-10):
1316         (.col-11):
1317         (.col-12):
1318         (@media screen and (min-width: 600px)):
1319
1320 2019-09-18  Ryan Haddad  <ryanhaddad@apple.com>
1321
1322         Update flakiness dashboard configuration for iOS 13 queues
1323         https://bugs.webkit.org/show_bug.cgi?id=201711
1324
1325         Reviewed by Jonathan Bedard.
1326
1327         * TestResultServer/static-dashboards/builders.jsonp:
1328
1329 2019-09-18  Adrian Perez de Castro  <aperez@igalia.com>
1330
1331         [WPE][GTK] Update build environments to use libwpe+WPEBackend-fdo 1.4.0
1332         https://bugs.webkit.org/show_bug.cgi?id=201915
1333
1334         Reviewed by Michael Catanzaro.
1335
1336         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.4.0
1337         * gtk/jhbuild.modules: Ditto.
1338         * wpe/jhbuild.modules: Ditto.
1339
1340 2019-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1341
1342         [Win][MiniBrowser] Remove unused DOMDefaultImpl.cpp
1343         https://bugs.webkit.org/show_bug.cgi?id=201867
1344
1345         Reviewed by Darin Adler.
1346
1347         * MiniBrowser/win/CMakeLists.txt: Removed DOMDefaultImpl.cpp.
1348         * MiniBrowser/win/DOMDefaultImpl.cpp: Removed.
1349         * MiniBrowser/win/DOMDefaultImpl.h: Removed.
1350         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1351
1352 2019-09-17  Dean Jackson  <dino@apple.com>
1353
1354         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1355         https://bugs.webkit.org/show_bug.cgi?id=201864
1356         <rdar://55190038>
1357
1358         Reviewed by Simon Fraser.
1359
1360         Test for the suggested actions.
1361
1362         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1363         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1364         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1365         (TEST):
1366
1367 2019-09-17  Jonathan Bedard  <jbedard@apple.com>
1368
1369         results.webkit.org results bubbles' tooltips should include SDK information
1370         https://bugs.webkit.org/show_bug.cgi?id=201823
1371
1372         Rubber-stamped by Aakash Jain.
1373
1374         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1375         (Configuration.prototype.compare): Like the Python instance of this class,
1376         support using null as a wildcard.
1377         (Configuration.prototype.compareSDKs): Ditto.
1378         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1379         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Construct a configuration
1380         object from all bits of data used to construct a given bubble.
1381         (TimelineFromEndpoint.prototype.render):
1382
1383 2019-09-17  Keith Rollin  <krollin@apple.com>
1384
1385         Remove some support for < iOS 12
1386         https://bugs.webkit.org/show_bug.cgi?id=201851
1387         <rdar://problem/55422044>
1388
1389         Reviewed by Jiewen Tan and Alexey Proskuryakov.
1390
1391         Remove some support for iOS versions less than 12.0.
1392
1393         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1394         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1395         values >= 120000. This means that expressions like
1396         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and
1397         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True.
1398
1399         This removal is part of a series of patches effecting such removal.
1400
1401         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1402         (WTR::installFakeHelvetica):
1403
1404 2019-09-17  David Kilzer  <ddkilzer@apple.com>
1405
1406         run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
1407         <https://webkit.org/b/201873>
1408
1409         Reviewed by Jonathan Bedard.
1410
1411         * Scripts/webkitpy/port/driver.py:
1412         (Driver.run_test): Call self.do_post_tests_work() when a test
1413         shard has completed, but didn't crash or time out.
1414
1415 2019-09-17  Chris Dumez  <cdumez@apple.com>
1416
1417         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
1418         https://bugs.webkit.org/show_bug.cgi?id=201859
1419         <rdar://problem/55426742>
1420
1421         Reviewed by Alex Christensen.
1422
1423         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
1424         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
1425
1426         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1427         (TestWebKitAPI::TEST):
1428
1429 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
1430
1431         Bring up queues for iOS 13
1432         https://bugs.webkit.org/show_bug.cgi?id=201710
1433
1434         Reviewed by Jonathan Bedard.
1435
1436         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1439         (WebKitBuildbot):
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1441         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
1442         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
1443         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
1444         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1445         (_should_file_trigger_build):
1446         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1447         (ShouldBuildTest):
1448         (ShouldBuildTest.test_should_build):
1449         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
1450
1451 2019-09-17  Truitt Savell  <tsavell@apple.com>
1452
1453         Unreviewed, rolling out r249950.
1454
1455         Broke the iOS build.
1456
1457         Reverted changeset:
1458
1459         "Remove the "Show Link Previews" and "Hide Link Previews"
1460         action menus in the preview platter"
1461         https://bugs.webkit.org/show_bug.cgi?id=201864
1462         https://trac.webkit.org/changeset/249950
1463
1464 2019-09-17  Dean Jackson  <dino@apple.com>
1465
1466         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1467         https://bugs.webkit.org/show_bug.cgi?id=201864
1468         <rdar://55190038>
1469
1470         Reviewed by Simon Fraser.
1471
1472         Test for the suggested actions.
1473
1474         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1475         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1476         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1477         (TEST):
1478
1479 2019-09-16  Alex Christensen  <achristensen@webkit.org>
1480
1481         Remove "gopher" from list of special schemes in URLParser
1482         https://bugs.webkit.org/show_bug.cgi?id=201852
1483
1484         Reviewed by Simon Fraser.
1485
1486         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1487         (TestWebKitAPI::TEST_F):
1488         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
1489         (TestWebKitAPI::TEST_F):
1490         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1491
1492 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1493
1494         results.webkit.org: Shard result archives
1495         https://bugs.webkit.org/show_bug.cgi?id=201734
1496
1497         Reviewed by Dewei Zhu.
1498
1499         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
1500         In practice, this usually doesn't work according to the Cassandra developers,
1501         large blobs should be broken up into shards of, at most, 10 MB.
1502
1503         * resultsdbpy/resultsdbpy/model/archive_context.py:
1504         (ArchiveContext):
1505         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
1506         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
1507         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
1508         (ArchiveContext.__init__):
1509         (ArchiveContext.register): When saving archives, save a reference hash and then
1510         shard the actual archive data before saving.
1511         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
1512         the archive. Raise an exception if we determine that memory usage is a problem.
1513         (ArchiveContext.ArchivesByCommit): Deleted.
1514         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
1515         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
1516         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
1517         (ArchiveContextTest):
1518         (ArchiveContextTest.test_large_archive): Test archive sharding.
1519
1520 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1521
1522         [WebAuthn] Support more than two FIDO protocol versions
1523         https://bugs.webkit.org/show_bug.cgi?id=198408
1524         <rdar://problem/51292176>
1525
1526         Reviewed by Chris Dumez.
1527
1528         Adds a new test case that includes a FIDO_2_1_PRE version string.
1529
1530         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1533
1534 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1535
1536         results.webkit.org: Configurations should be branch specific
1537         https://bugs.webkit.org/show_bug.cgi?id=201561
1538
1539         Reviewed by Dewei Zhu.
1540
1541         Partition configurations by branch in both Redis and Cassandra.
1542
1543         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
1544         (UploadController.suites): Allow the user to specify branches while listing suites.
1545         * resultsdbpy/resultsdbpy/model/archive_context.py:
1546         (ArchiveContext.register): Register each configuration with a branch.
1547         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1548         (ConfigurationContext.ByPlatform): Index by branch.
1549         (ConfigurationContext.ByPlatformAndVersion): Ditto.
1550         (ConfigurationContext.ByArchitecture): Ditto.
1551         (ConfigurationContext.ByModel): Ditto.
1552         (ConfigurationContext.__init__): Populate Redis cache with branch.
1553         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
1554         (ConfigurationContext._register_in_redis): Register configuration with branch.
1555         (ConfigurationContext.register_configuration): Ditto.
1556         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
1557         (ConfigurationContext.search_for_recent_configuration): Ditto.
1558         (ConfigurationContext.select_from_table_with_configurations): Ditto.
1559         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
1560         (ConfigurationContextTest.register_configurations): Register with branch.
1561         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
1562         CommitContext object.
1563         * resultsdbpy/resultsdbpy/model/upload_context.py:
1564         (UploadContext.SuitesByConfiguration): Index by branch.
1565         (UploadContext.upload_test_results): Register each configuration with a branch.
1566         (UploadContext.find_suites): Pass branch to search for configurations.
1567         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
1568         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
1569
1570 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1571
1572         check-webkit-style: Fix warning message for std::make_unique<typename[]>
1573         <https://webkit.org/b/201818>
1574
1575         Reviewed by Darin Adler.
1576
1577         * Scripts/webkitpy/style/checkers/cpp.py:
1578         (check_wtf_make_unique): Emit different error message when using
1579         std::make_unique<>() to create an array.  Personalize the error
1580         message by including the original type name, which also
1581         demonstrates that WTF::makeUniqueArray<>() does not need square
1582         brackets for its typename.
1583         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1584         (WebKitStyleTest.test_wtf_make_unique): Add test.
1585         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
1586
1587 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1588
1589         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
1590         https://bugs.webkit.org/show_bug.cgi?id=201820
1591
1592         Reviewed by Chris Fleizach.
1593
1594         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1595         (AccessibilityUIElement::insertText):
1596         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1597         (AccessibilityUIElement::insertText):
1598         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1599         (WTR::AccessibilityUIElement::insertText):
1600         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1601         (WTR::AccessibilityUIElement::insertText):
1602
1603 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1604
1605         Fix leaks in DumpRenderTree and WebKitTestRunner
1606         <https://webkit.org/b/201814>
1607
1608         Reviewed by Darin Adler.
1609
1610         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1611         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1612         Add CF_RETURNS_RETAINED to document behavior.
1613         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1614         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1615
1616         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1617         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
1618         behavior.
1619         (createBitmapContextFromWebView): Fix leak of CGImageRef when
1620         generating a replacement image.
1621
1622         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
1623         declaration for _stableStateOverride so compiler wouldn't try to
1624         create another instance variable for it.
1625
1626         * WebKitTestRunner/mac/EventSenderProxy.mm:
1627         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1628         Release `cgEvent` to fix leak.
1629
1630 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1631
1632         Expose misspelling ranges for editable content to accessibility clients.
1633         https://bugs.webkit.org/show_bug.cgi?id=201752
1634         <rdar://problem/49556828>
1635
1636         Reviewed by Chris Fleizach.
1637
1638         Test code needed for LayoutTests/accessibility/misspelling-range.html.
1639         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1640         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1641         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1642         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1643         (WTR::AccessibilityUIElement::indexForTextMarker):
1644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1645         (WTR::misspellingSearchParameterizedAttributeForCriteria):
1646         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1647
1648 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1649
1650         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
1651         https://bugs.webkit.org/show_bug.cgi?id=201544
1652
1653         Reviewed by Michael Catanzaro.
1654
1655         Add new test cases.
1656
1657         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1658         (testWebViewActiveURI):
1659         (testWebViewIsLoading):
1660         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1661         (loadChangedCallback):
1662         (LoadTrackingTest::loadAlternateHTML):
1663         (LoadTrackingTest::reset):
1664         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
1665
1666 2019-09-15  David Kilzer  <ddkilzer@apple.com>
1667
1668         block-spammers should obtain credentials the same way as webkit-patch
1669         <https://webkit.org/b/201733>
1670
1671         Reviewed by Lucas Forschler.
1672
1673         * Scripts/block-spammers: Import Credentials from webkitpy.
1674         Remove unused imports.  Enable logging at info level to match
1675         webkit-patch.
1676         (get_bugzilla_token): Use Credentials module to get
1677         bugs.webkit.org credentials.
1678         * Scripts/webkitpy/common/net/credentials.py:
1679         (Credentials._run_security_tool): Change logging level from
1680         error to info since multiple attempts are made at reading the
1681         keychain.  Fix typos in comment.
1682         (Credentials._credentials_from_security_command): Extract common
1683         logic from Credentials._credentials_from_keychain into new
1684         method.
1685         (Credentials._credentials_from_keychain): Make fallback logic
1686         for checking for credentials in the keychain more consistent and
1687         easier to read.  Add error logging if no credentials are found.
1688
1689 2019-09-13  Youenn Fablet  <youenn@apple.com>
1690
1691         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
1692         https://bugs.webkit.org/show_bug.cgi?id=201718
1693
1694         Reviewed by Chris Dumez.
1695
1696         Read meta tag information to select the environments where the any.js template tests will be run.
1697         Added support to run service worker tests from any.js template tests.
1698
1699         Covered by unit test.
1700         Since we import only a single repository nowadays, use a test config file with just one repository
1701         to simplify the new test.
1702
1703         * Scripts/webkitpy/w3c/test_importer.py:
1704         (TestImporter.__init__):
1705         (TestImporter.readEnvironmentsForTemplateTest):
1706         (TestImporter.write_html_files_for_templated_js_tests):
1707         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1708         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1709         (TestImporterTest.test_import_dir_with_no_tests):
1710         (TestImporterTest.test_import_dir_with_empty_init_py):
1711         (TestImporterTest.test_harnesslinks_conversion):
1712         (TestImporterTest.test_submodules_generation):
1713         (test_checkout_directory):
1714         (test_clean_directory_option):
1715         (test_git_ignore_generation):
1716         (test_initpy_generation):
1717         (test_remove_obsolete_content):
1718         (test_manual_slow_test):
1719         (test_webkit_test_runner_options):
1720         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
1721         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
1722         (test_template_test):
1723
1724 2019-09-13  Dean Jackson  <dino@apple.com>
1725
1726         Provide a prototype for AR QuickLook to trigger processing in the originating page
1727         https://bugs.webkit.org/show_bug.cgi?id=201371
1728         <rdar://54904781>
1729
1730         Disable the test for the moment.
1731
1732         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
1733         (TestWebKitAPI::TEST):
1734
1735 2019-09-11  Dean Jackson  <dino@apple.com>
1736
1737         Provide a prototype for AR QuickLook to trigger processing in the originating page
1738         https://bugs.webkit.org/show_bug.cgi?id=201371
1739         <rdar://54904781>
1740
1741         Reviewed by Simon Fraser.
1742
1743         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
1744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1745         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
1746
1747 2019-09-13  Youenn Fablet  <youenn@apple.com>
1748
1749         Partition processes running service workers by session ID
1750         https://bugs.webkit.org/show_bug.cgi?id=201643
1751
1752         Reviewed by Chris Dumez.
1753
1754         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1755
1756 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
1757
1758         Re-add myself to the list of committers
1759
1760         Unreviewed.
1761
1762         * Scripts/webkitpy/common/config/contributors.json:
1763
1764 2019-09-13  Alex Christensen  <achristensen@webkit.org>
1765
1766         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
1767         https://bugs.webkit.org/show_bug.cgi?id=201745
1768
1769         Reviewed by Chris Dumez.
1770
1771         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1772         (TestWebKitAPI::TEST):
1773         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
1774
1775 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
1776
1777         [JHBuild] Fix building gst-plugins-good against glibc 2.30
1778         https://bugs.webkit.org/show_bug.cgi?id=201715
1779
1780         Reviewed by Xabier Rodriguez-Calvar.
1781
1782         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
1783
1784 2019-09-12  Chris Dumez  <cdumez@apple.com>
1785
1786         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
1787         https://bugs.webkit.org/show_bug.cgi?id=201546
1788
1789         Reviewed by Alex Christensen.
1790
1791         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
1792         the right thing for WebKit2 and tests have been rewritten to not use it.
1793
1794         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1795         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1796         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
1797         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1798
1799 2019-09-12  Brady Eidson  <beidson@apple.com>
1800
1801         PDF exporting on iOS should include URL rects.
1802         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
1803
1804         Reviewed by Tim Horton.
1805
1806         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
1807         (TestWebKitAPI::TEST): Enable on iOS.
1808
1809 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
1810
1811         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
1812         https://bugs.webkit.org/show_bug.cgi?id=201077
1813
1814         Reviewed by Carlos Garcia Campos.
1815
1816         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
1817         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1818         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
1819
1820 2019-09-12  Mark Lam  <mark.lam@apple.com>
1821
1822         Harden JSC against the abuse of runtime options.
1823         https://bugs.webkit.org/show_bug.cgi?id=201597
1824         <rdar://problem/55167068>
1825
1826         Reviewed by Filip Pizlo.
1827
1828         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
1829         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
1830
1831         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
1832         to disable the hardening on test runs.  Tests rely on setting options to enable
1833         test features.
1834
1835         * DumpRenderTree/mac/DumpRenderTree.mm:
1836         (dumpRenderTree):
1837         * DumpRenderTree/win/DumpRenderTree.cpp:
1838         (initialize):
1839         * TestWebKitAPI/PlatformUtilities.cpp:
1840         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1841         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1842         (main):
1843         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1844         (TestWebKitAPI::TEST):
1845         (TestWebKitAPI::runActiveSessionTest):
1846         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1847         (TEST):
1848         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1849         (TEST):
1850         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1853         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1854         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1855         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::generateContextConfiguration const):
1858
1859 2019-09-12  Keith Rollin  <krollin@apple.com>
1860
1861         Fix PDFKit references in TestWebKitAPI
1862         https://bugs.webkit.org/show_bug.cgi?id=201700
1863         <rdar://problem/55279539>
1864
1865         Reviewed by Youenn Fablet.
1866
1867         These references fail in watchOS and tvOS, so remove them on those
1868         platforms.
1869
1870         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
1873         * TestWebKitAPI/cocoa/TestPDFDocument.h:
1874         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
1875         * TestWebKitAPI/config.h:
1876
1877 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1878
1879         [Win][MiniBrowser] Select all text in the URL bar by clicking it
1880         https://bugs.webkit.org/show_bug.cgi?id=201677
1881
1882         Reviewed by Don Olmstead.
1883
1884         * MiniBrowser/win/MainWindow.cpp:
1885         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
1886
1887 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GTK][WPE] Stop using the session bus in the unit tests
1890         https://bugs.webkit.org/show_bug.cgi?id=201636
1891
1892         Reviewed by Žan Doberšek.
1893
1894         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
1895         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
1896         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
1897         test. The server address is passed to the web extension as initialization parameter to connect directly to
1898         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
1899         a WebKitWebView.
1900
1901         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1902         (beforeAll):
1903         (afterAll):
1904         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1905         (testProcessPerWebView):
1906         (beforeAll):
1907         (afterAll):
1908         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1909         (testWebExtensionGetTitle):
1910         (testWebExtensionInputElementIsUserEdited):
1911         (testDocumentLoadedSignal):
1912         (testWebKitWebViewProcessCrashed):
1913         (testWebExtensionIsolatedWorld):
1914         (testInstallMissingPluginsPermissionRequest):
1915         (testWebExtensionFormControlsAssociated):
1916         (FormSubmissionTest::FormSubmissionTest):
1917         (beforeAll):
1918         (afterAll):
1919         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1920         (DelayedSignal::DelayedSignal):
1921         (emitPageCreated):
1922         (pageCreatedCallback):
1923         (webkit_web_extension_initialize_with_user_data):
1924         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1925         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1926         (AccessibilityTest::AccessibilityTest):
1927         (AccessibilityTest::ensureProxy):
1928         (beforeAll):
1929         (afterAll):
1930         * TestWebKitAPI/glib/CMakeLists.txt:
1931         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1932         (dbusConnectionClosed):
1933         (dbusServerConnection):
1934         (startDBusServer):
1935         (stopDBusServer):
1936         (main):
1937         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1938         (Test::initializeWebExtensions):
1939         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
1940         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
1941         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1942         (WebViewTest::~WebViewTest):
1943         (WebViewTest::extensionProxy):
1944         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1945
1946 2019-09-10  Dean Jackson  <dino@apple.com>
1947
1948         setup-git-clone is using http not https
1949         https://bugs.webkit.org/show_bug.cgi?id=201658
1950
1951         Reviewed by Sam Weinig.
1952
1953         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1954         (SetupGitClone.execute):
1955
1956 2019-09-10  Matt Lewis  <jlewis3@apple.com>
1957
1958         run-webkit-test: Allow results to be uploaded without scm checkout
1959         https://bugs.webkit.org/show_bug.cgi?id=200787
1960
1961         Reviewed by Jonathan Bedard.
1962
1963         * Scripts/webkitpy/common/checkout/scm/detection.py:
1964         (SCMDetector.detect_scm_system): Added in detection of stub repository.
1965         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
1966         (StubRepository):
1967         (StubRepository.__init__):
1968         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
1969         find the directory containing the checkout_information.json of the stub repository.
1970         (StubRepository.in_working_directory): Required functions to be implemented.
1971         (StubRepository.svn_revision): Required functions to be implemented.
1972         (StubRepository.native_revision): Required functions to be implemented.
1973         (StubRepository.native_branch): Required functions to be implemented.
1974         (StubRepository._decode_json): Decodes checkout_information.json.
1975         (StubRepository.find_checkout_root): Required functions to be implemented.
1976         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
1977         (StubRepositoryTest): Unit test for stub_repository SCM.
1978         (StubRepositoryTest.mock_host_for_stub_repository):
1979         (StubRepositoryTest.test_in_working_directory):
1980         (StubRepositoryTest.test_native_revision):
1981         (StubRepositoryTest.test_native_branch):
1982         (StubRepositoryTest.test_svn_revision):
1983         (StubRepositoryTest.test_find_checkout_root):
1984         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1985         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
1986         * Scripts/webkitpy/port/base.py:
1987         (Port.commits_for_upload): Removed unnecessary scm initialization.
1988
1989 2019-09-10  Brady Eidson  <beidson@apple.com>
1990
1991         Add SPI to save a PDF from the contents of a WKWebView.
1992         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
1993
1994         Reviewed by Tim Horton.
1995
1996         -Add an "Export to PDF..." menu option to MiniBrowser.
1997         -Add API tests for the API itself.
1998
1999         * MiniBrowser/MiniBrowser.entitlements:
2000
2001         * MiniBrowser/mac/BrowserWindowController.h:
2002         * MiniBrowser/mac/BrowserWindowController.m:
2003         (-[BrowserWindowController forceRepaint:]):
2004         (-[BrowserWindowController saveAsPDF:]):
2005
2006         * MiniBrowser/mac/MainMenu.xib:
2007
2008         * MiniBrowser/mac/WK1BrowserWindowController.m:
2009         (-[WK1BrowserWindowController validateMenuItem:]):
2010         * MiniBrowser/mac/WK2BrowserWindowController.m:
2011         (-[WK2BrowserWindowController validateMenuItem:]):
2012         (-[WK2BrowserWindowController saveAsPDF:]):
2013
2014         * TestWebKitAPI/Configurations/Base.xcconfig:
2015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2016         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
2017         (TestWebKitAPI::TEST):
2018         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
2019         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
2020         (TestWebKitAPI::toCGRect):
2021         (TestWebKitAPI::toPlatformPoint):
2022         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
2023         (TestWebKitAPI::TestPDFAnnotation::isLink const):
2024         (TestWebKitAPI::TestPDFAnnotation::bounds const):
2025         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
2026         (TestWebKitAPI::TestPDFPage::create):
2027         (TestWebKitAPI::TestPDFPage::TestPDFPage):
2028         (TestWebKitAPI::TestPDFPage::annotations):
2029         (TestWebKitAPI::TestPDFPage::characterCount const):
2030         (TestWebKitAPI::TestPDFPage::text const):
2031         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
2032         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
2033         (TestWebKitAPI::TestPDFPage::bounds const):
2034         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
2035         (TestWebKitAPI::TestPDFDocument::createFromData):
2036         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
2037         (TestWebKitAPI::TestPDFDocument::pageCount const):
2038         (TestWebKitAPI::TestPDFDocument::page):
2039
2040 2019-09-10  Keith Rollin  <krollin@apple.com>
2041
2042         Remove SSL-based TLSDeprecation.mm contents
2043         https://bugs.webkit.org/show_bug.cgi?id=201657
2044         <rdar://problem/55237678>
2045
2046         Reviewed by Alex Christensen.
2047
2048         This file does not build on watchOS due to references to SSL
2049         facilities. Conditionalize out the contents on HAVE_SSL.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2052
2053 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2054
2055         Unreviewed, remove myself from watchlists
2056
2057         * Scripts/webkitpy/common/config/watchlist:
2058
2059 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2060
2061         Rebase API test after r249675
2062         https://bugs.webkit.org/show_bug.cgi?id=201596
2063
2064         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2065         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2066         We removed the restriction on WebsitePolicies with non-default persistent sessions.
2067         We needed to change the expectations of the test that exercised that code path.
2068
2069 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2070
2071         Fix iOS API tests after r249684
2072         https://bugs.webkit.org/show_bug.cgi?id=201573
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2075         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
2076         (TestWebKitAPI::TEST):
2077         The web thread still exists :(
2078         That makes iOS immediate failure results more like WK2, which is fine.
2079         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
2080
2081 2019-09-09  Chris Dumez  <cdumez@apple.com>
2082
2083         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
2084         https://bugs.webkit.org/show_bug.cgi?id=201550
2085
2086         Reviewed by Alex Christensen.
2087
2088         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
2089         anything or not.
2090
2091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2092         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2093         (WTR::InjectedBundle::statisticsNotifyObserver):
2094         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2096         (WTR::TestRunner::statisticsNotifyObserver):
2097         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2098
2099 2019-09-09  Timothy Hatcher  <timothy@apple.com>
2100
2101         Tap and hold on Facebook sometimes creates a tall empty selection.
2102         https://bugs.webkit.org/show_bug.cgi?id=201618
2103         rdar://53630145
2104
2105         Reviewed by Megan Gardner.
2106
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
2109
2110 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [EWS] Watchlist doesn't work sometimes
2113         https://bugs.webkit.org/show_bug.cgi?id=201433
2114
2115         Reviewed by Michael Catanzaro.
2116
2117         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
2118         corresponding Bugzilla accounts.
2119
2120 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2121
2122         Disable TLS 1.0 and 1.1 in WebSockets
2123         https://bugs.webkit.org/show_bug.cgi?id=201573
2124
2125         Reviewed by Youenn Fablet.
2126
2127         * TestWebKitAPI/SourcesCocoa.txt:
2128         * TestWebKitAPI/TCPServer.cpp:
2129         (sk_CRYPTO_BUFFER_num):
2130         (sk_CRYPTO_BUFFER_value):
2131         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
2132         (TestWebKitAPI::TCPServer::TCPServer):
2133         (TestWebKitAPI::TCPServer::listenForConnections):
2134         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
2135         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
2136         * TestWebKitAPI/TCPServer.h:
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
2139         (-[WebSocketDelegate waitForMessage]):
2140         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2143         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2144         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2145         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
2146
2147 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2148
2149         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
2150         https://bugs.webkit.org/show_bug.cgi?id=201600
2151
2152         Reviewed by Brent Fulgham.
2153
2154         There were some circular references between
2155         WebKitLegacyBrowserWindow and its delegation classes. For
2156         example, WebKitLegacyBrowserWindow has a reference of
2157         WebDownloadDelegate, and WebDownloadDelegate shares the ref
2158         counter with WebKitLegacyBrowserWindow.
2159
2160         WebNotificationObserver was leaked because it wasn't unregistered
2161         from the default notification center by using
2162         IWebNotificationCenter::removeObserver.
2163
2164         If a new legacy window was created by mouse right click a link,
2165         WebView was released twice because
2166         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
2167         WebView.
2168
2169         This change does:
2170         1. Make delegation classes have own ref-counter to avoid circular references
2171         2. Do removeObserver notification observers
2172         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
2173
2174         * MiniBrowser/win/AccessibilityDelegate.cpp:
2175         (AccessibilityDelegate::AddRef):
2176         (AccessibilityDelegate::Release):
2177         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
2178         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2179         (MiniBrowserWebHost::QueryInterface):
2180         (MiniBrowserWebHost::AddRef):
2181         (MiniBrowserWebHost::Release):
2182         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
2183         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2184         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
2185         (PrintWebUIDelegate::AddRef):
2186         (PrintWebUIDelegate::Release):
2187         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
2188         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2189         (ResourceLoadDelegate::AddRef):
2190         (ResourceLoadDelegate::Release):
2191         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
2192         * MiniBrowser/win/WebDownloadDelegate.cpp:
2193         (WebDownloadDelegate::AddRef):
2194         (WebDownloadDelegate::Release):
2195         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
2196         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2197         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
2198         (WebKitLegacyBrowserWindow::init):
2199         (WebKitLegacyBrowserWindow::setUIDelegate):
2200         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
2201         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
2202         (WebKitLegacyBrowserWindow::setDownloadDelegate):
2203         (WebKitLegacyBrowserWindow::AddRef): Deleted.
2204         (WebKitLegacyBrowserWindow::Release): Deleted.
2205         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
2206         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
2207         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2208
2209 2019-09-09  Chris Dumez  <cdumez@apple.com>
2210
2211         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
2212         https://bugs.webkit.org/show_bug.cgi?id=201596
2213
2214         Reviewed by Alex Christensen.
2215
2216         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
2217         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
2218         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
2219         the WebCore::Document think it changed session.
2220
2221         * DumpRenderTree/TestRunner.cpp:
2222         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
2223         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
2224         (TestRunner::staticFunctions):
2225         (TestRunner::willNavigate):
2226         * DumpRenderTree/TestRunner.h:
2227         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2228         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2229         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2230         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2231         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2233         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2234         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::TestController::decidePolicyForNavigationAction):
2238         * WebKitTestRunner/TestController.h:
2239         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
2240         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
2241         * WebKitTestRunner/TestInvocation.cpp:
2242         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2243
2244 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2245
2246         EWS testtube emoji doesn't exist on macOS Mojave
2247         https://bugs.webkit.org/show_bug.cgi?id=201532
2248
2249         Reviewed by Simon Fraser.
2250
2251         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2252         (StatusBubble): Change the emoji to microscope emoji.
2253
2254 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
2257         https://bugs.webkit.org/show_bug.cgi?id=201607
2258
2259         Reviewed by Jonathan Bedard.
2260
2261         * BuildSlaveSupport/ews-build/steps.py:
2262         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
2263         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
2264
2265 2019-09-07  Keith Miller  <keith_miller@apple.com>
2266
2267         OSR entry into wasm misses some contexts
2268         https://bugs.webkit.org/show_bug.cgi?id=201569
2269
2270         Reviewed by Yusuke Suzuki.
2271
2272         Add new test harness mode for tests created from wast files.
2273
2274         * Scripts/run-jsc-stress-tests:
2275
2276 2019-09-09  Daniel Bates  <dabates@apple.com>
2277
2278         Remove all selection view animations before dumping results
2279         https://bugs.webkit.org/show_bug.cgi?id=199241
2280
2281         Reviewed by Wenson Hsieh.
2282
2283         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
2284         historical tests that were written for Mac and expect Mac's lack of animations that we run on
2285         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
2286         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
2287         API for a test to remove selection animations at any time during the run.
2288
2289         * WebKitTestRunner/ios/TestControllerIOS.mm:
2290         (WTR::TestController::notifyDone):
2291
2292 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2293
2294         run-webkit-tests: Report results archive to results.webkit.org
2295         https://bugs.webkit.org/show_bug.cgi?id=201321
2296
2297         Reviewed by Aakash Jain.
2298
2299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2300         (Manager.run): After all tests are finish, upload the results archive for each
2301         configuration.
2302         * Scripts/webkitpy/results/upload.py:
2303         (Upload):
2304         (Upload.__init__): Automatically define timestamp.
2305         (Upload.upload_archive): Upload an archive associated with the test run.
2306         * Scripts/webkitpy/results/upload_unittest.py:
2307         (UploadTest.test_buildbot):
2308         (UploadTest):
2309         (UploadTest.test_archive_upload):
2310
2311 2019-09-09  Chris Dumez  <cdumez@apple.com>
2312
2313         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
2314         https://bugs.webkit.org/show_bug.cgi?id=201590
2315
2316         Reviewed by Youenn Fablet.
2317
2318         Add a new API test to check that if the default session registers a service worker, the
2319         hasServiceWorkerRegistration flag is still false in an ephemeral session.
2320
2321         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2322
2323 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2324
2325         results.webkit.org: mobile-sidebar-control should override button
2326         https://bugs.webkit.org/show_bug.cgi?id=201566
2327
2328         Rubber-stamped by Aakash Jain.
2329
2330         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2331         (@media screen and (min-width: 600px)):
2332         (.mobile-sidebar-control):
2333         (.mobile-sidebar-control.display):
2334
2335 2019-09-07  Chris Dumez  <cdumez@apple.com>
2336
2337         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
2338         https://bugs.webkit.org/show_bug.cgi?id=201574
2339
2340         Reviewed by Alex Christensen.
2341
2342         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
2343         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
2344         does not work well for WK2.
2345
2346         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2347
2348 2019-09-07  Chris Dumez  <cdumez@apple.com>
2349
2350         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
2351         https://bugs.webkit.org/show_bug.cgi?id=201547
2352
2353         Reviewed by Alex Christensen.
2354
2355         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
2356         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
2357         hack.
2358
2359         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2360         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2361         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
2362         (TEST):
2363
2364 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2365
2366         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
2367         https://bugs.webkit.org/show_bug.cgi?id=200054
2368
2369         Reviewed by Carlos Garcia Campos.
2370
2371         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2372         This test relied on the default data store having been instantiated.
2373
2374 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2375
2376         Remove calls to WKContextGetWebsiteDataStore missed in r249614
2377         https://bugs.webkit.org/show_bug.cgi?id=200050
2378
2379         * WebKitTestRunner/TestController.cpp:
2380         (WTR::TestController::resetPreferencesToConsistentValues):
2381         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2382         * WebKitTestRunner/TestInvocation.cpp:
2383         (WTR::TestInvocation::invoke):
2384
2385 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2386
2387         Remove invalid assertion added in r249614
2388         https://bugs.webkit.org/show_bug.cgi?id=200050
2389
2390         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2391         (WTR::TestController::cocoaResetStateToConsistentValues):
2392         Something is instantiating the default data store, which is no problem right now.
2393
2394 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
2395
2396         Unreviewed, rolling out r249353.
2397
2398         The test for this change is a flaky failure.
2399
2400         Reverted changeset:
2401
2402         "Add support for postMessage buffering between the service
2403         worker and window"
2404         https://bugs.webkit.org/show_bug.cgi?id=201169
2405         https://trac.webkit.org/changeset/249353
2406
2407 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2408
2409         Deprecate WKContextGetWebsiteDataStore
2410         https://bugs.webkit.org/show_bug.cgi?id=200050
2411
2412         Reviewed by Geoff Garen.
2413
2414         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2415         (WebKitBrowserWindow::updateProxySettings):
2416         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::TestController::generateContextConfiguration const):
2419         (WTR::TestController::websiteDataStore):
2420         (WTR::TestController::generatePageConfiguration):
2421         (WTR::TestController::resetStateToConsistentValues):
2422         (WTR::TestController::platformAdjustContext):
2423         (WTR::TestController::clearServiceWorkerRegistrations):
2424         (WTR::TestController::clearDOMCache):
2425         (WTR::TestController::clearDOMCaches):
2426         (WTR::TestController::ClearIndexedDatabases):
2427         (WTR::TestController::hasDOMCache):
2428         (WTR::TestController::domCacheSize):
2429         (WTR::TestController::setStatisticsDebugMode):
2430         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2431         (WTR::TestController::setStatisticsLastSeen):
2432         (WTR::TestController::setStatisticsPrevalentResource):
2433         (WTR::TestController::setStatisticsVeryPrevalentResource):
2434         (WTR::TestController::dumpResourceLoadStatistics):
2435         (WTR::TestController::isStatisticsPrevalentResource):
2436         (WTR::TestController::isStatisticsVeryPrevalentResource):
2437         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2438         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2439         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2440         (WTR::TestController::setStatisticsHasHadUserInteraction):
2441         (WTR::TestController::isStatisticsHasHadUserInteraction):
2442         (WTR::TestController::setStatisticsGrandfathered):
2443         (WTR::TestController::isStatisticsGrandfathered):
2444         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2445         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2446         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2447         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2448         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2449         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2450         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2451         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2452         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2453         (WTR::TestController::statisticsUpdateCookieBlocking):
2454         (WTR::TestController::statisticsSubmitTelemetry):
2455         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2456         (WTR::TestController::setStatisticsIsRunningTest):
2457         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2458         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2459         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2460         (WTR::TestController::setStatisticsGrandfatheringTime):
2461         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2462         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2463         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2464         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2465         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2466         (WTR::TestController::statisticsDeleteCookiesForHost):
2467         (WTR::TestController::isStatisticsHasLocalStorage):
2468         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2469         (WTR::TestController::statisticsResetToConsistentState):
2470         (WTR::TestController::setWebAuthenticationMockConfiguration):
2471         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2472         * WebKitTestRunner/TestController.h:
2473         * WebKitTestRunner/TestInvocation.cpp:
2474         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2475         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2476         (WTR::initializeWebViewConfiguration):
2477
2478 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2479
2480         Incorrect selection rect revealed after pasting images in a contenteditable element
2481         https://bugs.webkit.org/show_bug.cgi?id=201549
2482         <rdar://problem/50956429>
2483
2484         Reviewed by Simon Fraser.
2485
2486         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
2487         directly written to the pasteboard.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2490
2491 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2492
2493         Unreviewed, rolling out r249582.
2494
2495         This caused results.html fail to be created on internal
2496         testers.
2497
2498         Reverted changeset:
2499
2500         "run-webkit-test: Allow results to be uploaded without scm
2501         checkout"
2502         https://bugs.webkit.org/show_bug.cgi?id=200787
2503         https://trac.webkit.org/changeset/249582
2504
2505 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
2506
2507         [ews-app] Status bubble should only display important messages in pop-over - part 2
2508         https://bugs.webkit.org/show_bug.cgi?id=201557
2509
2510         Reviewed by Jonathan Bedard.
2511
2512         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2513         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
2514
2515 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2516
2517         Deprecate all WKCookieManagerRef functions
2518         https://bugs.webkit.org/show_bug.cgi?id=201473
2519
2520         Reviewed by Chris Dumez.
2521
2522         Adopt replacement C API in WebKitTestRunner.
2523
2524         * TestWebKitAPI/CMakeLists.txt:
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::resetPreferencesToConsistentValues):
2529         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2530         * WebKitTestRunner/TestInvocation.cpp:
2531         (WTR::TestInvocation::invoke):
2532         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2533         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2534         (WTR::initializeWebViewConfiguration):
2535
2536 2019-09-06  Tim Horton  <timothy_horton@apple.com>
2537
2538         Marking up a note on iOS results in a PDF with no contents
2539         https://bugs.webkit.org/show_bug.cgi?id=201530
2540         <rdar://problem/53686019>
2541
2542         Reviewed by Andy Estes.
2543
2544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2545         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
2546         Add some tests for WKWebViewPrintFormatter; specifically that it is
2547         possible to _recalcPageCount twice in quick succession, and that
2548         we don't hang if we start painting the printed content immediately
2549         after a Web Content process crash.
2550
2551 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2552
2553         run-webkit-test: Allow results to be uploaded without scm checkout
2554         https://bugs.webkit.org/show_bug.cgi?id=200787
2555
2556         Reviewed by Jonathan Bedard.
2557
2558         * Scripts/webkitpy/common/checkout/scm/detection.py:
2559         (SCMDetector.detect_scm_system): Added in detection of stub repository.
2560         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
2561         (StubRepository):
2562         (StubRepository.__init__):
2563         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
2564         find the directory containing the checkout_information.json of the stub repository.
2565         (StubRepository.in_working_directory): Required functions to be implemented.
2566         (StubRepository.svn_revision): Required functions to be implemented.
2567         (StubRepository.native_revision): Required functions to be implemented.
2568         (StubRepository.native_branch): Required functions to be implemented.
2569         (StubRepository._decode_json): Decodes checkout_information.json.
2570         (StubRepository.find_checkout_root): Required functions to be implemented.
2571         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
2572         (StubRepositoryTest): Unit test for stub_repository SCM.
2573         (StubRepositoryTest.mock_host_for_stub_repository):
2574         (StubRepositoryTest.test_in_working_directory):
2575         (StubRepositoryTest.test_native_revision):
2576         (StubRepositoryTest.test_native_branch):
2577         (StubRepositoryTest.test_svn_revision):
2578         (StubRepositoryTest.test_find_checkout_root):
2579         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2580         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
2581         * Scripts/webkitpy/port/base.py:
2582         (Port.commits_for_upload): Removed unnecessary scm initialization.
2583
2584 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2585
2586         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
2587         https://bugs.webkit.org/show_bug.cgi?id=201480
2588
2589         Reviewed by Youenn Fablet.
2590
2591         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2592         (WTR::InjectedBundle::beginTesting):
2593         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2594         (WTR::TestRunner::setPrivateBrowsingEnabled):
2595
2596 2019-09-06  Rob Buis  <rbuis@igalia.com>
2597
2598         Add runtime flag for lazy image loading
2599         https://bugs.webkit.org/show_bug.cgi?id=199794
2600
2601         Reviewed by Frédéric Wang.
2602
2603         Remove parts of r248409 that were meant for WK1 since
2604         lazy image loading is WK2 only.
2605
2606         * DumpRenderTree/TestOptions.cpp:
2607         (TestOptions::TestOptions):
2608         * DumpRenderTree/TestOptions.h:
2609         * DumpRenderTree/mac/DumpRenderTree.mm:
2610         (enableExperimentalFeatures):
2611         (setWebPreferencesForTestOptions):
2612         * DumpRenderTree/win/DumpRenderTree.cpp:
2613         (enableExperimentalFeatures):
2614
2615 2019-09-05  Chris Dumez  <cdumez@apple.com>
2616
2617         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2618         https://bugs.webkit.org/show_bug.cgi?id=201519
2619
2620         Reviewed by Alex Christensen.
2621
2622         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2623         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
2624         TestOption::useEphemeralSession flag based on the test folder.
2625
2626         * DumpRenderTree/mac/DumpRenderTree.mm:
2627         (shouldUseEphemeralSession):
2628         (runTest):
2629         * WebKitTestRunner/TestOptions.cpp:
2630         (WTR::shouldUseEphemeralSession):
2631         (WTR::TestOptions::TestOptions):
2632
2633 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2634
2635         [Win] Support Per-Monitor (V2) DPI Awareness
2636         https://bugs.webkit.org/show_bug.cgi?id=201450
2637
2638         Reviewed by Don Olmstead.
2639
2640         * MiniBrowser/win/MainWindow.cpp:
2641         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
2642         * MiniBrowser/win/WinMain.cpp:
2643         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
2644
2645 2019-09-05  Chris Dumez  <cdumez@apple.com>
2646
2647         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
2648         https://bugs.webkit.org/show_bug.cgi?id=201440
2649         <rdar://problem/54998427>
2650
2651         Reviewed by Alex Christensen.
2652
2653         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
2654         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
2655         created in the WebContent process is the one that is currently running the test and that we want to talk to.
2656         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
2657
2658         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2659         (WTR::InjectedBundle::page const):
2660
2661 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2662
2663         results.webkit.org: Assign notifyRerender before calling
2664         https://bugs.webkit.org/show_bug.cgi?id=201510
2665
2666         Reviewed by Aakash Jain.
2667
2668         Timelines should define notifyRerender to an empty function,
2669         rename notifiyRerender to notifyRerender.
2670
2671         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2672         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2673         * resultsdbpy/resultsdbpy/view/templates/search.html:
2674         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2675
2676 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2677
2678         results.webkit.org: Fix prepending search result on empty list 
2679         https://bugs.webkit.org/show_bug.cgi?id=201512
2680
2681         Reviewed by Aakash Jain.
2682
2683         * resultsdbpy/resultsdbpy/view/templates/search.html:
2684
2685 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2686
2687         results.webkit.org: Retain certain parameters when following menu links
2688         https://bugs.webkit.org/show_bug.cgi?id=201463
2689
2690         Rubber-stamped by Aakash Jain.
2691
2692         * resultsdbpy/resultsdbpy/view/site_menu.py:
2693         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
2694         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
2695         retain the specified parameters
2696         * resultsdbpy/resultsdbpy/view/view_routes.py:
2697         (ViewRoutes.__init__):
2698
2699 2019-09-05  Chris Dumez  <cdumez@apple.com>
2700
2701         [WK2] Add proper layout test support for ephemeral sessions
2702         https://bugs.webkit.org/show_bug.cgi?id=201475
2703
2704         Reviewed by Antti Koivisto.
2705
2706         Add proper layout test support for ephemeral sessions via:
2707         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
2708
2709         This actually creates a new WebView using an ephemeral data store to load the test which
2710         is *true* private browsing.
2711
2712         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
2713         process, which is a hack and does not truly enable private browsing because the UIProcess and
2714         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
2715         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
2716         get rid of it.
2717
2718         Note that WK2 does not support using a WebContent process for different sessions / data stores.
2719         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
2720         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
2721         simply to support testRunner.setPrivateBrowsingEnabled().
2722
2723         * DumpRenderTree/TestOptions.cpp:
2724         (TestOptions::TestOptions):
2725         * DumpRenderTree/TestOptions.h:
2726         * DumpRenderTree/TestRunner.cpp:
2727         (TestRunner::staticFunctions):
2728         * DumpRenderTree/mac/DumpRenderTree.mm:
2729         (setWebPreferencesForTestOptions):
2730         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2731         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2732         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
2733         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2734         * WebKitTestRunner/TestController.cpp:
2735         (WTR::TestController::generatePageConfiguration):
2736         (WTR::updateTestOptionsFromTestHeader):
2737         * WebKitTestRunner/TestOptions.h:
2738         (WTR::TestOptions::hasSameInitializationOptions const):
2739         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2740         (WTR::TestController::platformCreateWebView):
2741
2742 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
2743
2744         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
2745         https://bugs.webkit.org/show_bug.cgi?id=201490
2746
2747         Reviewed by Daniel Bates.
2748
2749         Added a test.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2753         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
2754
2755 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
2756
2757         Remove unused SPI that accesses MemoryCache directly
2758         https://bugs.webkit.org/show_bug.cgi?id=201468
2759
2760         Reviewed by Youenn Fablet.
2761
2762         Removed the API test.
2763
2764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2765         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
2766
2767 2019-09-04  Timothy Hatcher  <timothy@apple.com>
2768
2769         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
2770         https://bugs.webkit.org/show_bug.cgi?id=201368
2771         rdar://problem/40529867
2772
2773         Reviewed by Ryosuke Niwa.
2774
2775         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
2776             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
2777
2778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2779         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2780         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
2781         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2782         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
2783         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
2784         * TestWebKitAPI/cocoa/TestWKWebView.h:
2785         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2786         (-[TestWKWebView forceDarkMode]):
2787
2788 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2789
2790         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
2791         https://bugs.webkit.org/show_bug.cgi?id=201479
2792         <rdar://problem/51511834>
2793
2794         Reviewed by Tim Horton.
2795
2796         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2799         * TestWebKitAPI/ios/UIKitSPI.h:
2800
2801 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2802
2803         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
2804         https://bugs.webkit.org/show_bug.cgi?id=201471
2805         <rdar://problem/55039227>
2806
2807         Reviewed by Tim Horton.
2808
2809         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
2810         selected.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2813         (TestWebKitAPI::TEST):
2814         * TestWebKitAPI/ios/UIKitSPI.h:
2815
2816 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
2817
2818         results.webkit.org: Fix mobile vs desktop mode
2819         https://bugs.webkit.org/show_bug.cgi?id=201441
2820
2821         Rubber-stamped by Aakash Jain.
2822
2823         We should unconditionally use desktop mode if the device screen-width
2824         is large enough.
2825
2826         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2827
2828 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
2829
2830         run-api-tests: Add support for specifying additional environment variables
2831         https://bugs.webkit.org/show_bug.cgi?id=201311
2832         <rdar://problem/54852698>
2833
2834         Reviewed by Daniel Bates.
2835
2836         * Scripts/webkitpy/api_tests/run_api_tests.py:
2837         (parse_args): Add --additional-env-var flag.
2838         * Scripts/webkitpy/port/base.py:
2839         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
2840         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
2841         environment.
2842
2843 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
2844
2845         EWS bubbles should indicate builder vs tester
2846         https://bugs.webkit.org/show_bug.cgi?id=201253
2847
2848         Reviewed by Jonathan Bedard.
2849
2850         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2851         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
2852         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
2853         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
2854         (StatusBubble.get):
2855         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2856         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
2857         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
2858         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2859         (FetchLoop.run): Update the icons for queues mapping.
2860         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
2861         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
2862         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
2863         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
2864
2865 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
2866
2867         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
2868         https://bugs.webkit.org/show_bug.cgi?id=201448
2869
2870         Reviewed by Mark Lam.
2871
2872         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2873         (TEST):
2874
2875 2019-09-03  Dean Jackson  <dino@apple.com>
2876
2877         Test for ContextMenus with images
2878         https://bugs.webkit.org/show_bug.cgi?id=201437
2879
2880         Reviewed by Wenson Hsieh.
2881
2882         Add a test for ContextMenus that trigger on images, and make
2883         sure that they ask for alternate URLs (added in r249171).
2884
2885         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2886         (contextMenuWebViewDriver):
2887         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
2888         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
2889         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
2890         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
2891         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
2892         (TEST):
2893
2894 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
2895
2896         results.webkit.org: Move legend into sidebar
2897         https://bugs.webkit.org/show_bug.cgi?id=201258
2898
2899         Rubber-stamped by Aakash Jain.
2900
2901         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
2902         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
2903         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
2904         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2905         (isPointInElement): Make bound check include borders.
2906         (_ToolTip.toString): Add left/right cases.
2907         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
2908         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
2909         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2910
2911 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
2912
2913         results.webkit.org: Increase default limit for LimitSlider
2914         https://bugs.webkit.org/show_bug.cgi?id=201424
2915
2916         Reviewed by Aakash Jain.
2917
2918         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2919         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
2920
2921 2019-09-03  Antoine Quint  <graouts@apple.com>
2922
2923         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
2924         https://bugs.webkit.org/show_bug.cgi?id=201420
2925         <rdar://problem/53207786>
2926
2927         Reviewed by Simon Fraser.
2928
2929         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
2930         -[HIDEventGenerator twoFingerTap:completionBlock:].
2931
2932         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2933         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2934         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
2935         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2936         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2937         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
2938
2939 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
2940
2941         [WPE] MiniBrowser should handle the WebKitWebView::create signal
2942         https://bugs.webkit.org/show_bug.cgi?id=201417
2943
2944         Reviewed by Carlos Garcia Campos.
2945
2946         WPE's MiniBrowser should connect to and handle the
2947         WebKitWebView::create signal, constructing a new bit related
2948         WebKitWebView object upon invocation.
2949
2950         * MiniBrowser/wpe/main.cpp:
2951         (webViewClose):
2952         (createWebView):
2953         (main):
2954
2955 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
2956
2957         [WPE] Make view backends multi-view-friendly
2958         https://bugs.webkit.org/show_bug.cgi?id=201415
2959
2960         Reviewed by Carlos Garcia Campos.
2961
2962         Have the Wayland EGL connection for WindowViewBackend instances managed
2963         through a per-process singleton, allowing multiple backend objects
2964         use it for different views. HeadlessViewBackend already does this, but
2965         the code there is refurbished into a singleton structure.
2966
2967         The ViewBackend classes are adjusted to work with the backend-specific
2968         EGLDisplay objects (as constructed through the backend-specific EGL
2969         connection approach).
2970
2971         * wpe/backends/HeadlessViewBackend.cpp:
2972         (WPEToolingBackends::HeadlessEGLConnection::singleton):
2973         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
2974         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
2975         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
2976         (WPEToolingBackends::getEGLDisplay): Deleted.
2977         * wpe/backends/ViewBackend.cpp:
2978         (WPEToolingBackends::ViewBackend::initialize):
2979         (WPEToolingBackends::ViewBackend::deinitialize):
2980         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
2981         * wpe/backends/ViewBackend.h:
2982         * wpe/backends/WindowViewBackend.cpp:
2983         (WPEToolingBackends::WaylandEGLConnection::singleton):
2984         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
2985         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
2986         (WPEToolingBackends::WindowViewBackend::displayBuffer):
2987
2988 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2989
2990         [WPE][GTK] Deprecate nonfunctional process limit APIs
2991         https://bugs.webkit.org/show_bug.cgi?id=193749
2992
2993         Reviewed by Žan Doberšek.
2994
2995         * MiniBrowser/gtk/main.c:
2996         (main):
2997         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2998         (beforeAll):
2999         (testWebProcessLimit): Deleted.
3000
3001 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
3002
3003         [WPE] WindowBackend should do resizing properly
3004         https://bugs.webkit.org/show_bug.cgi?id=201386
3005
3006         Reviewed by Carlos Garcia Campos.
3007
3008         The WindowBackend implementation is resized via the XDG protocol. The
3009         initial size is stored for the object's lifetime and fallen back to when
3010         the XDG protocol reports (0,0) configuration size.
3011
3012         Upon each resize, we have to recreate the texture. We also have to size
3013         the GL viewport accordingly.
3014
3015         * wpe/backends/WindowViewBackend.cpp:
3016         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3017         (WPEToolingBackends::WindowViewBackend::createViewTexture):
3018         (WPEToolingBackends::WindowViewBackend::resize):
3019         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3020         * wpe/backends/WindowViewBackend.h:
3021
3022 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
3023
3024         Unreviewed, rolling out r249366.
3025
3026         WinCairo WebKit2 crashes in some websites and the device scale
3027         factor is not correct in high DPI.
3028
3029         Reverted changeset:
3030
3031         "[WinCairo, FTW] Properly handle device scale factor"
3032         https://bugs.webkit.org/show_bug.cgi?id=201361
3033         https://trac.webkit.org/changeset/249366
3034
3035 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3036
3037         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
3038         https://bugs.webkit.org/show_bug.cgi?id=201346
3039         <rdar://problem/54885784>
3040
3041         Reviewed by Dean Jackson.
3042
3043         Add a new test option to allow tests to disable link previews.
3044
3045         * WebKitTestRunner/TestController.cpp:
3046         (WTR::updateTestOptionsFromTestHeader):
3047         * WebKitTestRunner/TestOptions.h:
3048
3049         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
3050
3051         (WTR::TestOptions::hasSameInitializationOptions const):
3052         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3053         (WTR::TestController::platformCreateWebView):
3054
3055 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
3056
3057         [WinCairo, FTW] Properly handle device scale factor
3058         https://bugs.webkit.org/show_bug.cgi?id=201361
3059
3060         Reviewed by Don Olmstead.
3061
3062         Reset zoom to 1.0; device scale is handled elsewhere.
3063
3064         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3065         (WebKitBrowserWindow::resetZoom):
3066
3067 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
3068
3069         [results.webkit.org Timeline] Add notify rerender API for timeline
3070         https://bugs.webkit.org/show_bug.cgi?id=201363
3071
3072         Reviewed by Jonathan Bedard.
3073
3074         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
3075         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3076         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
3077         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
3078         (prototype.Timeline.CanvasContainer):
3079
3080 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
3081
3082         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
3083         https://bugs.webkit.org/show_bug.cgi?id=201350
3084
3085         Reviewed by Jonathan Bedard.
3086
3087         * BuildSlaveSupport/ews-build/steps.py:
3088         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
3089         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
3090
3091 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
3092
3093         results.webkit.org: Add endpoints to upload and download archives
3094         https://bugs.webkit.org/show_bug.cgi?id=201100
3095
3096         Reviewed by Aakash Jain.
3097
3098         Add the endpoint to upload and download a zip archive associated with a test run.
3099
3100         * resultsdbpy/resultsdbpy/controller/api_routes.py:
3101         (APIRoutes.__init__): Add archive endpoint.
3102         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
3103         (ArchiveController):
3104         (ArchiveController.__init__):
3105         (ArchiveController.endpoint):
3106         (ArchiveController.download):
3107         (ArchiveController.upload):
3108         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
3109         (ArchiveControllerUnittest):
3110         * resultsdbpy/resultsdbpy/model/configuration_context.py:
3111         (ClusteredByConfiguration.register_configuration): Make error message more clear.
3112
3113 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
3114
3115         Add system tracing points for compositing updates, and touch-event dispatching
3116         https://bugs.webkit.org/show_bug.cgi?id=201327
3117
3118         Reviewed by Alex Christensen.
3119
3120         * Tracing/SystemTracePoints.plist:
3121
3122 2019-08-30  Keith Rollin  <krollin@apple.com>
3123
3124         Simplify PLATFORM expression
3125         https://bugs.webkit.org/show_bug.cgi?id=201286
3126         <rdar://problem/54822347>
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         The preprocessor expression conditionalizing the inclusion of the body
3131         of ExitFullscreenOnEnterPiP.mm evolved into:
3132
3133             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
3134
3135         Simplify this to just:
3136
3137             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
3138
3139         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3140
3141 2019-08-30  Keith Rollin  <krollin@apple.com>
3142
3143         Remove AppKitCompatibilityDeclarations.h
3144         https://bugs.webkit.org/show_bug.cgi?id=201283
3145         <rdar://problem/54822042>
3146
3147         Reviewed by Alexey Proskuryakov.
3148
3149         The two copies of these files -- on in WTF, one in MiniBrowser -- are
3150         empty and can be removed.
3151
3152         * DumpRenderTree/mac/EventSendingController.mm:
3153         * DumpRenderTree/mac/TextInputControllerMac.m:
3154         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
3155         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3156         * MiniBrowser/mac/SettingsController.m:
3157         * MiniBrowser/mac/WK1BrowserWindowController.m:
3158         * MiniBrowser/mac/WK2BrowserWindowController.m:
3159         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3160         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3161         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3162         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3163         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
3164         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
3165         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3166         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3167         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3168         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
3169         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3170         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3171         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
3172         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3173         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3174         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3175         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3176         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3177         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3178         * WebKitTestRunner/mac/EventSenderProxy.mm:
3179         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3180         * WebKitTestRunner/mac/TestControllerMac.mm:
3181
3182 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
3183
3184         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
3185         https://bugs.webkit.org/show_bug.cgi?id=200479
3186
3187         Reviewed by Carlos Garcia Campos.
3188
3189         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3190         (testUserContentManagerContentFilter): Test also the new
3191         webkit_user_content_manager_remove_filter_by_id() public API function.
3192
3193 2019-08-30  Philippe Normand  <pnormand@igalia.com>
3194
3195         [WPE][Qt] loadingChanged signal parameter is unusable
3196         https://bugs.webkit.org/show_bug.cgi?id=201301
3197
3198         Reviewed by Carlos Garcia Campos.
3199
3200         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
3201         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
3202         readablity/parameter_name code styl checker rule.
3203
3204 2019-08-29  Keith Rollin  <krollin@apple.com>
3205
3206         Update .xcconfig symbols to reflect the current set of past and future product versions.
3207         https://bugs.webkit.org/show_bug.cgi?id=200720
3208         <rdar://problem/54305032>
3209
3210         Reviewed by Alex Christensen.
3211
3212         Remove version symbols related to old OS's we no longer support,
3213         ensure that version symbols are defined for OS's we do support.
3214
3215         * ContentExtensionTester/Configurations/Base.xcconfig:
3216         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3217         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3218         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3219         * ImageDiff/cg/Configurations/Base.xcconfig:
3220         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3221         * MiniBrowser/Configurations/Base.xcconfig:
3222         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3223         * TestWebKitAPI/Configurations/Base.xcconfig:
3224         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3225         * WebEditingTester/Configurations/Base.xcconfig:
3226         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3227         * WebKitTestRunner/Configurations/Base.xcconfig:
3228         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3229         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3230         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3231
3232 2019-08-29  Keith Rollin  <krollin@apple.com>
3233
3234         Remove empty FontCache.cpp file in TestWebKitAPI
3235         https://bugs.webkit.org/show_bug.cgi?id=201277
3236         <rdar://problem/54820726>
3237
3238         Reviewed by Alex Christensen.
3239
3240         Bug 200694 emptied out the contents of FontCache.cpp. This patch
3241         removes the file from the project.
3242
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
3245
3246 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
3247
3248         [ews-app] Status bubble should only display important messages in pop-over
3249         https://bugs.webkit.org/show_bug.cgi?id=201308
3250
3251         Reviewed by Jonathan Bedard.
3252
3253         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
3254         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
3255
3256 2019-08-29  Keith Rollin  <krollin@apple.com>
3257
3258         Remove support for macOS < 10.13 (part 3)
3259         https://bugs.webkit.org/show_bug.cgi?id=201224
3260         <rdar://problem/54795934>
3261
3262         Reviewed by Darin Adler.
3263
3264         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
3265         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
3266         like _MACOS_SINCE_1013.
3267
3268         Also added some macOS target numbers.
3269
3270         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
3271
3272 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
3273
3274         results.webkit.org: Remove border from tooltip
3275         https://bugs.webkit.org/show_bug.cgi?id=201239
3276
3277         Reviewed by Alex Christensen.
3278
3279         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
3280         (.tooltip-content): Remove border.
3281
3282 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3283
3284         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
3285         https://bugs.webkit.org/show_bug.cgi?id=201215
3286
3287         Reviewed by Don Olmstead.
3288
3289         MiniBrowser crashed if it was going to go to a unreachable page
3290         because WKPageCopyActiveURL returned a nullptr.
3291
3292         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3293         (createString): Added null checking of the argument.
3294
3295 2019-08-28  Tim Horton  <timothy_horton@apple.com>
3296
3297         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
3298         https://bugs.webkit.org/show_bug.cgi?id=201256
3299         <rdar://problem/54809509>
3300
3301         Reviewed by Simon Fraser.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
3305         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
3306         (TestWebKitAPI::TEST):
3307         Add a test. I left many comments because I had a great deal of trouble
3308         writing this test and wanted to document my findings.
3309
3310 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3311
3312         results.webkit.org: Do not display branch selector if only one branches available
3313         https://bugs.webkit.org/show_bug.cgi?id=201244
3314
3315         Rubber-stamped by Aakash Jain.
3316
3317         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
3318         container if there aren't multiple branches to choose from.
3319
3320 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
3323         https://bugs.webkit.org/show_bug.cgi?id=201241
3324         <rdar://problem/54317588>
3325
3326         Reviewed by Tim Horton.
3327
3328         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
3329         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
3330         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
3331         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
3332         it believes that the web view has rejected the drop from being handled.
3333
3334         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
3335         to make sure that the web process has had time to send a response after each update.
3336
3337         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3338         (-[DragAndDropSimulator _advanceProgress]):
3339
3340 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
3341
3342         Null check webFrame when creating a print preview to prevent a crash.
3343         https://bugs.webkit.org/show_bug.cgi?id=201237
3344         <rdar://problem/51618863>
3345
3346         Reviewed by Tim Horton.
3347
3348         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3351         (TEST):
3352
3353 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3354
3355         results.webkit.org: Move drawer to the right, open by default
3356         https://bugs.webkit.org/show_bug.cgi?id=200977
3357
3358         Rubber-stamped by Aakash Jain.
3359
3360         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
3361         moving the drawer to the right side of the screen, opening it by default and have it displace
3362         instead of hide the main content.
3363
3364         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
3365         (CommitViewUnittest.test_drawer): Support new drawer style.
3366         (CommitViewUnittest.test_range_slider): Ditto.
3367         (CommitViewUnittest.test_one_line_switch): Ditto.
3368         (CommitViewUnittest.test_branch_selection): Ditto.
3369         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
3370         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3371         (setEnableRecursive): Disable all elements underneath this one 
3372         (Drawer): Make drawer a sidebar.
3373         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3374         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
3375         (:root): Move boldInverseColor into webkit.css.
3376         (@media (prefers-color-scheme: dark)):
3377         (.sidebar): Sidebars on mobile should behave like drawers.
3378         (.sidebar.hidden): Add concept of hidden sidebar.
3379         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
3380         (.mobile-sidebar-control.display):
3381         (.main.under-topbar-with-actions):
3382         (@media screen and (min-width: 600px) and (orientation: landscape)):
3383         (.sidebar.left.hidden):
3384         (.sidebar.right.hidden):
3385         (.main.right.hidden):
3386         (.main.left.hidden):
3387         (@media screen and (min-width: 768px) and (orientation: landscape)):
3388         (.sidebar.right):
3389         (a.disabled): Add ability to disable a link.
3390         (.desktop-control): Add a control which only exists on desktop.
3391         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
3392         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
3393         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
3394         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
3395         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
3396         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3397         (WebSiteTestCase.toggle_drawer): Support new drawer style.
3398         (WebSiteTestCase.find_input_with_name): Ditto.
3399
3400 2019-08-28  Keith Rollin  <krollin@apple.com>
3401
3402         Remove support for macOS < 10.13 (part 2)
3403         https://bugs.webkit.org/show_bug.cgi?id=201197
3404         <rdar://problem/54759985>
3405
3406         Reviewed by Darin Adler.
3407
3408         Update conditionals that reference WK_MACOS_1013 and suffixes like
3409         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
3410         later and that these conditionals are always True or False.
3411
3412         See Bug 200694 for earlier changes in this area.
3413
3414         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3415
3416 2019-08-28  Alicia Boya García  <aboya@igalia.com>
3417
3418         [MSE][GStreamer] WebKitMediaSrc rework
3419         https://bugs.webkit.org/show_bug.cgi?id=199719
3420
3421         Reviewed by Xabier Rodriguez-Calvar.
3422
3423         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
3424         whitelist.
3425
3426         * Scripts/webkitpy/style/checker.py:
3427
3428 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
3429
3430         Updating inactive contributors in contributors.json.
3431
3432         * Scripts/webkitpy/common/config/contributors.json:
3433
3434 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3435
3436         results.webkit.org: Auto-expand single configurations
3437         https://bugs.webkit.org/show_bug.cgi?id=201218
3438
3439         Rubber-stamped by Aakash Jain.
3440
3441         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3442         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
3443         configuration has been specified.
3444         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3445         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
3446         is expanded or collapsed by default.
3447
3448 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3449
3450         results.webkit.org: Sanitize all commit arguments on upload
3451         https://bugs.webkit.org/show_bug.cgi?id=201189
3452         <rdar://problem/54564837>
3453
3454         Reviewed by Aakash Jain.
3455
3456         * resultsdbpy/resultsdbpy/controller/commit.py:
3457         (Commit.__init__): Only allow commits to be constructed with valid values.
3458         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
3459         (CommitController.register): Strip potential API key.
3460         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
3461         (CommitUnittest.test_invalid): Test that commits which contain html inside the
3462         repository_id, branch or commit id are rejected.
3463
3464 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
3465
3466         [GTK][WPE] Implement HSTS for the soup network backend
3467         https://bugs.webkit.org/show_bug.cgi?id=192074
3468
3469         Reviewed by Carlos Garcia Campos.
3470
3471         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
3472         Add support to the soup network backend by adding the feature to
3473         SoupNetworkSession and handling HSTS protocol upgrades, by
3474         propagating the scheme change further to clients. This patch adds
3475         the HSTS feature unconditionally, but it still possible to add
3476         a boolean property to the web context class if desired.
3477
3478         Additionally, add API to the WebKitWebsiteDataManager to specify
3479         the directory where the HSTS database is saved. If the directory
3480         is not set or if the data manager is ephemeral, use a
3481         non-persistent, memory only HSTS enforcer.
3482
3483         Implement as well the methods needed to clean-up and delete HSTS
3484         policies from the storage and expose the feature in GTK+
3485         MiniBrowser's about:data.
3486
3487         * MiniBrowser/gtk/main.c:
3488         (gotWebsiteDataCallback):
3489         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3490         (serverCallback):
3491         (testWebsiteDataConfiguration):
3492         (testWebsiteDataEphemeral):
3493         (prepopulateHstsData):
3494         (testWebsiteDataHsts):
3495         (beforeAll):
3496         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3497         (Test::Test):
3498         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
3499         * wpe/jhbuild.modules: Ditto
3500         * MiniBrowser/gtk/main.c:
3501         (gotWebsiteDataCallback):
3502
3503 2019-08-27  James Darpinian  <jdarpinian@google.com>
3504
3505         Fix applying diffs that only change file mode
3506         https://bugs.webkit.org/show_bug.cgi?id=201191
3507
3508         Reviewed by Daniel Bates.
3509
3510         * Scripts/svn-apply:
3511         (patch): Handle case of file mode change without content change
3512
3513 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
3514
3515         [ews] Status bubble should be red for CANCELLED builds
3516         https://bugs.webkit.org/show_bug.cgi?id=201204
3517
3518         Reviewed by Jonathan Bedard.
3519
3520         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3521         (StatusBubble._build_bubble):
3522
3523 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
3524
3525         [results.webkit.org Webkit.css] Center the legend symbols
3526         https://bugs.webkit.org/show_bug.cgi?id=201187
3527
3528         Reviewed by Jonathan Bedard.
3529
3530         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3531         (.lengend>.item .dot .text): center the dot symbol vertically
3532
3533 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
3534
3535         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
3536         https://bugs.webkit.org/show_bug.cgi?id=201000
3537         <rdar://problem/53778938>
3538
3539         Unreviewed follow-up fix.
3540
3541         * Scripts/webkitpy/port/darwin.py:
3542         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
3543         spindump call failed.
3544         * Scripts/webkitpy/port/darwin_testcase.py:
3545         * Scripts/webkitpy/port/ios_device_unittest.py:
3546
3547 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
3548
3549         [ews-build] Use update-webkit script in Apply-WatchList EWS
3550         https://bugs.webkit.org/show_bug.cgi?id=201179
3551
3552         Reviewed by Jonathan Bedard.
3553
3554         * BuildSlaveSupport/ews-build/factories.py:
3555         (WatchListFactory): Updated to use CheckOutSource step as well.
3556
3557 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3558
3559         W3C test importer should be able to handle expected references with an absolute path.
3560         https://bugs.webkit.org/show_bug.cgi?id=200717
3561
3562         Reviewed by Youenn Fablet.
3563
3564         This patch implements the logic to resolve test references with absolute paths
3565         when importing w3c tests (like web-platform-tests).
3566         When an absolute path is found for a test reference, the parser now
3567         tries to find the right file by looking for a relative path inside
3568         the root directory of the source test repository.
3569         It works when the tool is run in download-mode as well as when the
3570         tool is run to import the tests from a local directory.
3571
3572         This fixes the import of test references for tests like
3573         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
3574
3575         * Scripts/webkitpy/w3c/test_importer.py:
3576         (TestImporter._source_root_directory_for_path):