9cd0f289750865f0e36f1fa88fc99ed659ced866
[WebKit-https.git] / Tools / ChangeLog
1 2019-09-27  Alex Christensen  <achristensen@webkit.org>
2
3         Move shouldUseTestingNetworkSession from NetworkProcessCreationParameters to NetworkSessionCreationParameters
4         https://bugs.webkit.org/show_bug.cgi?id=202327
5
6         Reviewed by Tim Horton.
7
8         * WebKitTestRunner/TestController.cpp:
9         (WTR::TestController::websiteDataStore):
10
11 2019-09-27  Alex Christensen  <achristensen@webkit.org>
12
13         Move service worker process termination delay disabling from process pool to website data store
14         https://bugs.webkit.org/show_bug.cgi?id=202308
15
16         Reviewed by Chris Dumez.
17
18         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
19
20 2019-09-27  Alex Christensen  <achristensen@webkit.org>
21
22         Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
23         https://bugs.webkit.org/show_bug.cgi?id=202285
24
25         Reviewed by Youenn Fablet.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
28         (-[ServerTrustDelegate webView:didFinishNavigation:]):
29         (-[ServerTrustDelegate webView:didFailProvisionalNavigation:withError:]):
30         (-[ServerTrustDelegate waitForDidFinishNavigation]):
31         (-[ServerTrustDelegate waitForDidFailProvisionalNavigationError]):
32         (-[ServerTrustDelegate authenticationChallengeCount]):
33         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
34         (TestWebKitAPI::TEST):
35         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
36         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
37         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation): Deleted.
38         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess): Deleted.
39         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount): Deleted.
40         * WebKitTestRunner/InjectedBundle/TestRunner.h:
41         * WebKitTestRunner/TestController.cpp:
42         (WTR::TestController::resetStateToConsistentValues):
43         (WTR::TestController::didReceiveAuthenticationChallenge):
44         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
45         * WebKitTestRunner/TestController.h:
46         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const): Deleted.
47         * WebKitTestRunner/TestInvocation.cpp:
48         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
49         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
50         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
51
52 2019-09-27  Alex Christensen  <achristensen@webkit.org>
53
54         Remove unused APIProcessPoolConfiguration::diskCacheSpeculativeValidationEnabled
55         https://bugs.webkit.org/show_bug.cgi?id=202290
56
57         Reviewed by Carlos Garcia Campos.
58
59         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
60         (TEST):
61         * WebKitTestRunner/TestController.cpp:
62         (WTR::TestController::websiteDataStore):
63         (WTR::TestController::generatePageConfiguration):
64
65 2019-09-27  Youenn Fablet  <youenn@apple.com>
66
67         Make IsNSURLSessionWebSocketEnabled an experimental flag
68         https://bugs.webkit.org/show_bug.cgi?id=202135
69         <rdar://problem/55694721>
70
71         Reviewed by Geoff Garen.
72
73         * WebKitTestRunner/TestController.cpp:
74         (WTR::TestController::resetPreferencesToConsistentValues):
75         Set preference to false by default.
76
77 2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
78
79         SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
80         https://bugs.webkit.org/show_bug.cgi?id=202061
81         <rdar://problem/55485666>
82
83         Reviewed by Youenn Fablet.
84
85         Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
86
87         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
88         (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
89         (resetState):
90         (TestWebKitAPI::TEST):
91
92 2019-09-26 Kate Cheney <katherine_cheney@apple.com>
93
94         Resource Load Statistics: Downgrade all third-party referrer headers
95         https://bugs.webkit.org/show_bug.cgi?id=201353
96         <rdar://problem/54895650>
97
98         Majority of this patch was written by John Wilander <wilander@apple.com>.
99
100         Reviewed by Brent Fulgham. 
101
102         The changes to the TestRunner facilitates an opt-out for test cases
103         that either test the referrer mechanism explicitly or tests that
104         rely on the full referrer to be sent. 
105
106         The new boolean variable and early return in 
107         TestRunner::setStatisticsShouldDowngradeReferrer() prevent the same
108         event from trying to set multiple TestRunner callbacks.
109
110         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
111         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
112         (WTR::InjectedBundle::didReceiveMessageToPage):
113         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
114         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
115         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
116         * WebKitTestRunner/InjectedBundle/TestRunner.h:
117         * WebKitTestRunner/TestController.cpp:
118         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
119         * WebKitTestRunner/TestController.h:
120         * WebKitTestRunner/TestInvocation.cpp:
121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
122         (WTR::TestInvocation::didSetShouldDowngradeReferrer):
123         * WebKitTestRunner/TestInvocation.h:
124
125 2019-09-26  Dean Jackson  <dino@apple.com>
126
127         Build fix.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
130         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]): Deleted.
131         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]): Deleted.
132         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]): Deleted.
133         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]): Deleted.
134
135 2019-09-26  Dean Jackson  <dino@apple.com>
136
137         ContextMenu on a link in an email no longer shows web preview
138         https://bugs.webkit.org/show_bug.cgi?id=201120
139         <rdar://54353617>
140
141         Reviewed by Wenson Hsieh.
142
143         Test context menus on a link that is also an image.
144
145         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
146         (contextMenuWebViewDriver):
147         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
148         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]):
149         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
150         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]):
151         (TEST):
152
153 2019-09-26  Frederic Wang  <fwang@igalia.com>
154
155         run-safari --ios-simulator is no longer working with Xcode 11
156         https://bugs.webkit.org/show_bug.cgi?id=199852
157
158         Path of MobileSafari.app has changed in Xcode 11. This patch updates
159         the run-safari script to use the new path. This removes support for
160         running Safari on iOS < 13, see discussions on bug 177595.
161
162         Reviewed by Jonathan Bedard.
163
164         * Scripts/webkitdirs.pm:
165         (iosSimulatorApplicationsPath):
166
167 2019-09-26  Zhifei Fang  <zhifei_fang@apple.com>
168
169         [results.webkit.org] Timeline support Image inner label
170         https://bugs.webkit.org/show_bug.cgi?id=202180
171
172         Reviewed by Jonathan Bedard.
173
174         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
175         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
176         (.lengend>.item .dot img): support img symbol for lengend and dot
177         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
178         (Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
179
180 2019-09-26  Chris Dumez  <cdumez@apple.com>
181
182         Stop using testRunner.overridePreference() to turn on Page Cache
183         https://bugs.webkit.org/show_bug.cgi?id=202274
184
185         Reviewed by Alex Christensen.
186
187         * DumpRenderTree/TestRunner.cpp:
188         (overridePreferenceCallback):
189         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
190         (WTR::TestRunner::overridePreference):
191
192 2019-09-26  Jonathan Bedard  <jbedard@apple.com>
193
194         results.webkit.org: Use cursor: pointer for clickable elements
195         https://bugs.webkit.org/show_bug.cgi?id=202268
196
197         Rubber-stamped by Aakash Jain.
198
199         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Give collapse button a pointer for cursor.
200         * resultsdbpy/resultsdbpy/view/templates/search.html: Make 'X' to close test timeline a link-button.
201
202 2019-09-26  Kate Cheney  <katherine_cheney@apple.com>
203
204         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
205         https://bugs.webkit.org/show_bug.cgi?id=195420                          
206         <rdar://problem/54213551>                                               
207
208         Reviewed by Brent Fulgham.                                             
209
210         Added in logic to send a message from the UIProcess to the Network      
211         Process which will initalize the ITP Database backend to allow for      
212         layout testing.                                                         
213         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
215         (WTR::TestRunner::setUseITPDatabase):
216         * WebKitTestRunner/InjectedBundle/TestRunner.h:
217         * WebKitTestRunner/TestController.cpp:
218         (WTR::TestController::setUseITPDatabase):
219         * WebKitTestRunner/TestController.h:
220         * WebKitTestRunner/TestInvocation.cpp:
221         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
222
223 2019-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
224
225         TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
226         https://bugs.webkit.org/show_bug.cgi?id=202273
227
228         Reviewed by Aakash Jain.
229
230         The content width scaling limits added in r250361 prevent this test from scaling down the content width (2000px
231         wide) to fit the viewport (375px). To avoid this issue, change the content width from 2000px to 1500px, which is
232         still a very wide content width for a web page.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm:
235
236 2019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
237
238         toExponential, toFixed, and toPrecision should allow arguments up to 100
239         https://bugs.webkit.org/show_bug.cgi?id=199163
240
241         Reviewed by Ross Kirsling.
242
243         Adjust StringNumberFixedWidth test due to lowering kMaxFixedDigitsBeforePoint.
244
245         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
246
247 2019-09-26  Jiewen Tan  <jiewen_tan@apple.com>
248
249         TestWebKitAPI.SOAuthorizationSubFrame.AuthorizationOptions is failing consistently on iOS API tests EWS
250         https://bugs.webkit.org/show_bug.cgi?id=202249
251
252         Reviewed by Alex Christensen.
253
254         Swizzles +[AKAuthorizationController isURLFromAppleOwnedDomain:] following other tests.
255
256         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
257         (TestWebKitAPI::TEST):
258
259 2019-09-25  Alex Christensen  <achristensen@webkit.org>
260
261         Add replacement SPI on _WKWebsiteDataStoreConfiguration for enabling speculative cache validation and IPC-free server trust evaluation
262         https://bugs.webkit.org/show_bug.cgi?id=202251
263
264         Reviewed by Tim Horton.
265
266         Adopt new SPI instead of deprecated SPI.
267
268         * MiniBrowser/mac/AppDelegate.m:
269         (persistentDataStore):
270         (defaultConfiguration):
271         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
272         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
273         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
274
275 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
276
277         Python 3: Add support in webkitpy.common.system
278         https://bugs.webkit.org/show_bug.cgi?id=201826
279         <rdar://problem/55452671>
280
281         Reviewed by Stephanie Lewis.
282
283         Tested compatibility by running 'python3 -m unittest webkitpy.common.system.<_unittest>' on
284         each of the effected files.
285
286         * Scripts/webkitpy/common/checkout/changelog.py: Import StringIO from io module.
287         (set_reviewer):
288         (set_short_description_and_bug_url):
289         * Scripts/webkitpy/common/checkout/checkout.py:  Import StringIO from io module.
290         (Checkout._latest_entry_for_changelog_at_revision):
291         * Scripts/webkitpy/common/config/committers.py:
292         (CommitterList.load_json): iteritems -> items.
293         * Scripts/webkitpy/common/net/networktransaction.py:
294         (NetworkTransaction.run): urllib2 is urllib in Python3. 
295         * Scripts/webkitpy/common/system/abstractexecutive.py:
296         (AbstractExecutive._stringify_args):
297         (AbstractExecutive.command_for_printing): The str type is unicode in Python3.
298         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Explicitly encode and decode binary crashlogs.
299         * Scripts/webkitpy/common/system/environment_unittest.py: Use absolute imports.
300         * Scripts/webkitpy/common/system/executive.py:
301         (ScriptError.message_with_output): The str type is unicode in Python3.
302         (Executive.WrappedPopen): Python3's Popen object is a context manager. To allow us to use it as one,
303         our Python2 Popen needs to be one as well.
304         (Executive.WrappedPopen.__init__):
305         (Executive.WrappedPopen.__enter__):
306         (Executive.WrappedPopen.__exit__):
307         (Executive._run_command_with_teed_output): Simplify loop, decode unicode strings.
308         (Executive.run_and_throw_if_fail): The child output file should not be unicode strings.
309         (Executive.running_pids): Use the Popen context manager to guarantee clean-up.
310         (Executive._compute_stdin):
311         (Executive.run_command): Use the Popen context manager to guarantee clean-up.
312         (Executive._stringify_args): The str type is unicode in Python3.
313         (Executive.popen): Return a context manager if the Popen object is not one.
314         * Scripts/webkitpy/common/system/executive_mock.py:
315         (MockProcess.__init__): StringIO -> BytesIO.
316         (MockProcess.__enter__):
317         (MockProcess):
318         (MockProcess.__exit__):
319         * Scripts/webkitpy/common/system/executive_unittest.py:
320         (ExecutiveTest.test_auto_stringify_args): Use the Popen context manager to guarantee clean-up.
321         (ExecutiveTest.test_popen_args): Ditto.
322         (ExecutiveTest.serial_test_kill_process): Ditto.
323         (ExecutiveTest.serial_test_kill_all): Ditto.
324         * Scripts/webkitpy/common/system/filesystem.py:
325         (FileSystem.read_binary_file): Use 'open' instead of 'file'.
326         (FileSystem.write_binary_file): Ditto.
327         (FileSystem.write_text_file): The str type is unicode in Python3. 
328         (FileSystem.relpath):
329         (FileSystem.remove): The WindowsError is just anther OSError in Python3.
330         (FileSystem._WindowsError): Deleted.
331         * Scripts/webkitpy/common/system/filesystem_mock.py:
332         (MockFileSystem.glob): filter returns a generator instead of a list.
333         (WritableBinaryFileObject.__init__): Binary files are comprised of bytes, not string in Python3.
334         (WritableBinaryFileObject.write): Ditto.
335         (ReadableTextFileObject.__init__): Ditto.
336         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
337         (MockFileSystemTest.test_normpath):
338         (MockFileSystemTest.test_dirs_under): assertEquals -> assertEqual.
339         * Scripts/webkitpy/common/system/filesystem_unittest.py:
340         (RealFileSystemTest.test_read_and_write_file): Explicitly define byte arrays instead of strings.
341         (RealFileSystemTest.test_remove_file_with_retry.remove_with_exception): The WindowsError is just
342         anther OSError in Python3.
343         * Scripts/webkitpy/common/system/outputcapture.py:
344         * Scripts/webkitpy/common/system/outputtee_unittest.py:
345         (SimpleTeeTest.test_simple_tee):
346         * Scripts/webkitpy/common/system/path.py:
347         (_escape): urllib library has been broken into parts.
348         * Scripts/webkitpy/common/system/pemfile.py:
349         (_parse_pem_format.find_end): Python3 does not define a maxint.
350         * Scripts/webkitpy/common/system/pemfile_unittest.py:
351         * Scripts/webkitpy/common/system/platforminfo.py:
352         (PlatformInfo.total_bytes_memory): Not 'long' type in Python3.
353         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
354         (TestPlatformInfo.test_real_code): assertNotEquals -> assertNotEqual.
355         (TestPlatformInfo.test_display_name): Ditto.
356         * Scripts/webkitpy/common/system/profiler.py:
357         (ProfilerFactory.create_profiler): Manually implement ifilter.
358         * Scripts/webkitpy/common/system/profiler_unittest.py: Use absolute imports.
359         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
360         (current_thread_id): items() returns a generator in Python3.
361         * Scripts/webkitpy/common/system/systemhost.py: Use absolute imports.
362         * Scripts/webkitpy/common/system/urlfetcher.py: Removed.
363         * Scripts/webkitpy/common/system/urlfetcher_mock.py: Removed.
364         * Scripts/webkitpy/common/system/user.py:
365         (User.prompt): Use absolute imports, raw_input -> input.
366         (User.prompt_with_multiple_lists):
367         (User.prompt_with_list):
368         (User.confirm):
369         * Scripts/webkitpy/common/unicode.py: Tooling to manage compatibility between Python 2
370         and Python 3 unicode handling.
371         * Scripts/webkitpy/common/system/user_mock.py:
372         (MockUser.prompt): raw_input -> input.
373         (MockUser.prompt_with_list): Ditto.
374         * Scripts/webkitpy/common/version.py:
375         (Version.from_iterable): xrange -> range.
376         (Version.from_name): Use absolute import path.
377         (Version.__contains__): xrange -> range.
378         (Version.__str__): xrange -> range.
379         (Version.__cmp__): amp is no longer an operator in Python3, but versions are comprised
380         Of integers, so subtraction has the same effect.
381         (Version):
382         (Version.__eq__): __cmp__ operator is no longer respected, so we need to implement
383         each comparison.
384         (Version.__ne__): Ditto.
385         (Version.__lt__): Ditto.
386         (Version.__le__): Ditto.
387         (Version.__gt__): Ditto.
388         (Version.__ge__): Ditto.
389         * Scripts/webkitpy/common/version_name_map.py:
390         (VersionNameMap._automap_to_major_version):
391         (VersionNameMap.to_name): xrange -> range.
392         (VersionNameMap.from_name): iteritems -> items.
393         * Scripts/webkitpy/common/version_name_map_unittest.py: Use absolute imports.
394         * Scripts/webkitpy/common/version_unittest.py: Ditto.
395         * Scripts/webkitpy/common/wavediff.py:
396         (WaveDiff.__init__): StringIO -> BytesIO.
397         * Scripts/webkitpy/port/__init__.py:
398         (outside):
399
400 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
401
402         [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
403         https://bugs.webkit.org/show_bug.cgi?id=202216
404
405         Reviewed by Jonathan Bedard.
406
407         * BuildSlaveSupport/ews-build/steps.py:
408         (RunJavaScriptCoreTestsToT): Removed the command so as to use the command from base class.
409         * BuildSlaveSupport/ews-build/steps_unittest.py: Updatd unit-tests.
410
411 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
412
413         [ews] JSC queues should run or skip tests based on runTests key from config.json
414         https://bugs.webkit.org/show_bug.cgi?id=202223
415
416         Reviewed by Jonathan Bedard.
417
418         * BuildSlaveSupport/ews-build/config.json: Added the runTests key.
419         * BuildSlaveSupport/ews-build/factories.py:
420         (JSCTestsFactory.__init__): Add RunJavaScriptCoreTests step based on runTests key.
421         * BuildSlaveSupport/ews-build/loadConfig.py:
422         (loadBuilderConfig): Pass the runTests key to the factory.
423         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
424         (ConfigDotJSONTest.test_builder_keys): Added the runTests key.
425
426 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
427
428         results.webkit.org: Add investigation drawer
429         https://bugs.webkit.org/show_bug.cgi?id=202106
430
431         Reviewed by Dewei Zhu.
432
433         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Support multiple 'main' classes.
434         * resultsdbpy/resultsdbpy/view/static/js/expectations.js: Added.
435         (Expectations.colorMap): Return a dictionary mapping type strings to colors.
436         (Expectations.stringToStateId): Map a string to a state ID for sorting.
437         (Expectations.typeForId): Return a type string given an ID.
438         (Expectations.symbolForId): Return a symbol for a type given an ID.
439         (Expectations.colorForId): Return a color given an ID.
440         (Expectations.unexpectedResults): Given a list of actual results and expected results,
441         return a state.
442         (Expectations):
443         * resultsdbpy/resultsdbpy/view/static/js/investigate.js: Added.
444         (commitsForUuid):
445         (testRunLink):
446         (elapsed):
447         (percentage):
448         (contentForAgregateData):
449         (contentForData):
450         (_InvestigateDrawer):
451         (_InvestigateDrawer.prototype.isRendered):
452         (_InvestigateDrawer.prototype.expand): Expand the investigation drawer.
453         (_InvestigateDrawer.prototype.collapse): Collapse the investigation drawer.
454         (_InvestigateDrawer.prototype.select): Select an element to investigate.
455         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
456         (statsForSingleResult): Move Expectation constants.
457         (TimelineFromEndpoint.prototype.render): Investigate specific data points instead
458         of jumping to the build.
459         (Expectations.stringToStateId): Deleted.
460         (Expectations.unexpectedResults): Deleted.
461         (Expectations): Deleted.
462         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
463         (.drawer.display): Make minimum height.
464         (@media screen and (min-width: 600px)): Move main and sidebar so they override drawer.
465         (@media screen and (min-width: 768px)): Ditto.
466         * resultsdbpy/resultsdbpy/view/templates/commits.html:
467         * resultsdbpy/resultsdbpy/view/templates/search.html:
468         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
469
470 2019-09-25  Alex Christensen  <achristensen@webkit.org>
471
472         Remove duplicate WebsiteDataStoreConfiguration copying code
473         https://bugs.webkit.org/show_bug.cgi?id=202215
474
475         Reviewed by Tim Horton.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
478         (TEST):
479
480 2019-09-25  Alex Christensen  <achristensen@webkit.org>
481
482         Replace WebsiteDataStoreParameters::privateSessionParameters with re-initializing all sessions immediately upon NetworkProcess resumption
483         https://bugs.webkit.org/show_bug.cgi?id=202211
484
485         Reviewed by Tim Horton.
486
487         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
488         (checkRecoveryAfterCrash):
489         (TEST):
490
491 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
492
493         [EWS] JSC queues should dynamically add required build steps for re-testing the patch
494         https://bugs.webkit.org/show_bug.cgi?id=202170
495
496         Reviewed by Jonathan Bedard.
497
498         * BuildSlaveSupport/ews-build/factories.py:
499         (JSCTestsFactory.__init__): Do not add ReRunJavaScriptCoreTests and related steps here, as
500         these are dynamically added (if required) in steps.py.
501         * BuildSlaveSupport/ews-build/steps.py:
502         (CompileJSCToT): Remove doStepIf() and hideStepIf() method, these are no longer required as we add
503         this step dynamically only if required. We don't need an extra property ('patchFailedToBuild') to be set.
504         (RunJavaScriptCoreTests.evaluateCommand): Dynamically add ReRunJavaScriptCoreTests step if required.
505         (ReRunJavaScriptCoreTests): Removed doStepIf() and hideStepIf() method.
506         (ReRunJavaScriptCoreTests.evaluateCommand): Dynamically add UnApplyPatchIfRequired(), CompileJSCToT() and RunJavaScriptCoreTestsToT steps.
507         (RunJavaScriptCoreTestsToT.evaluateCommand): Overriden to avoid caling the base-class method which dynamically adds
508         more steps.
509         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
510
511 2019-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
512
513         [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
514         https://bugs.webkit.org/show_bug.cgi?id=202167
515         <rdar://problem/55185021>
516
517         Reviewed by Tim Horton.
518
519         Rebaseline an API test.
520
521         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
522         (TestWebKitAPI::TEST):
523
524 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
525
526         Unreviewed, rolling out r250324.
527
528         Tools/ChangeLog
529
530         Reverted changeset:
531
532         "Enable LayoutTests using ResourceLoadStatistics SQLite
533         backend (195420)"
534         https://bugs.webkit.org/show_bug.cgi?id=195420
535         https://trac.webkit.org/changeset/250324
536
537 2019-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
538
539         [Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account
540         https://bugs.webkit.org/show_bug.cgi?id=202134
541
542         Reviewed by Jonathan Bedard.
543
544         _apache_config_file_name_for_platform always returns a config file
545         name for PHP5 on Cygwin Python, one for PHP7 on Win32 Python. It
546         should detect the system PHP version as Linux ports do.
547
548         Both AppleWin and WinCairo are using XAMPP Apache. Unify the code
549         paths for them. And, remove a stale conf file.
550
551         This change makes it possible to use Cygwin Python with PHP7.
552
553         * Scripts/webkitpy/port/base.py:
554         (Port._win_php_version): Added.
555         (Port._apache_config_file_name_for_platform): Unified cygwin and
556         win32 code path by using _win_php_version.
557         * Scripts/webkitpy/port/port_testcase.py:
558         (test_apache_config_file_name_for_platform): Updated cygwin and
559         win32 test cases.
560
561 2019-09-24  Matt Lewis  <jlewis3@apple.com>
562
563         Bring up queues for iPadOS Simulator Tests
564         https://bugs.webkit.org/show_bug.cgi?id=202151
565
566         Reviewed by Jonathan Bedard.
567
568         * BuildSlaveSupport/build.webkit.org-config/config.json:
569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
570         (WebKitBuildbot):
571         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
572
573 2019-09-24  Kate Cheney  <katherine_cheney@apple.com>
574
575         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
576         https://bugs.webkit.org/show_bug.cgi?id=195420                          
577         <rdar://problem/54213551>                                               
578
579         Reviewed by Brent Fulgham.                                             
580
581         Added in logic to send a message from the UIProcess to the Network      
582         Process which will initalize the ITP Database backend to allow for      
583         layout testing.                                                         
584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
585         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
586         (WTR::TestRunner::setUseITPDatabase):
587         * WebKitTestRunner/InjectedBundle/TestRunner.h:
588         * WebKitTestRunner/TestController.cpp:
589         (WTR::TestController::setUseITPDatabase):
590         * WebKitTestRunner/TestController.h:
591         * WebKitTestRunner/TestInvocation.cpp:
592         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
593
594 2019-09-24  Patrick Griffis  <pgriffis@igalia.com>
595
596         Add Patrick Griffis to contributors.json
597
598         Unreviewed.
599
600         * Scripts/webkitpy/common/config/contributors.json:
601
602 2019-09-24  Aakash Jain  <aakash_jain@apple.com>
603
604         [ews-build] Improve summary for Validate Patch step
605         https://bugs.webkit.org/show_bug.cgi?id=202163
606
607         Reviewed by Jonathan Bedard.
608
609         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Remove the redundant message saying:
610         'Some messages were logged while the patch was still eligible'.
611         * BuildSlaveSupport/ews-build/steps.py:
612         (ValidatePatch.skip_build): Updated the descritionDone with the reason to skip the patch.
613         (ValidatePatch.getResultSummary): Overrode this method so as to prevent buildbot from automatically
614         appending '(failure)' at the end of the summary string.
615
616 2019-09-24  Keith Rollin  <krollin@apple.com>
617
618         Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
619         https://bugs.webkit.org/show_bug.cgi?id=202119
620         <rdar://problem/55638792>
621
622         Reviewed by Alex Christensen.
623
624         After refactoring and other code evolution, some platform checks have
625         ended up looking like PLATFORM(MAC) || PLATFORM(IOS_FAMILY) (or
626         vice-versa). These can be converted into the equivalent
627         PLATFORM(COCOA). Where the instance occurs in a Cocoa-only file, the
628         check can be removed altogether (along with any "#else" branches).
629
630         * DumpRenderTree/AccessibilityTextMarker.h:
631         * DumpRenderTree/AccessibilityUIElement.cpp:
632         (AccessibilityUIElement::setValue):
633
634 2019-09-24  Zhifei Fang  <zhifei_fang@apple.com>
635
636         Add tests for Ref.js.
637         https://bugs.webkit.org/show_bug.cgi?id=201778.
638
639         Reviewed by Jonathan Bedard.
640
641         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
642         (applyStateDiff): null, 0, false are all valid state
643         (Ref.prototype.setState): We should do nothing for undefined stateDiff
644         * resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added.
645         (AssertFailedError):
646         (Expect): Perform assertions during unit tests.
647         (Expect.prototype.isType):
648         (Expect.prototype.equalToValue):
649         (Expect.prototype.equalToHtmlWithoutRef):
650         (Expect.prototype.notEqualToValue):
651         (Expect.prototype.greaterThan):
652         (Expect.prototype.greaterThanOrEqualTo):
653         (Expect.prototype.lessThan):
654         (Expect.prototype.lessThanOrEqualTo):
655         (TestSuite): Common TestSuite class for user to extend. 
656         (TestSuite.prototype.expect):
657         (TestSuite.prototype.sleep): Test will sleep for certain ms
658         (TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout
659         (TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout
660         (TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout
661         (TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout
662         (TestSuite.prototype.async.setup): Common interface for setup a test suite
663         (TestSuite.prototype.async.clearUp): Common interface for clear up a test suite
664         (getTestFucntionNames): Collect all the test method of a test instance.
665         (TestResult):
666         (TestResult.prototype.catchException):
667         (async.getTestResult): Run the test and generate a TestResult object
668         (TestController):
669         (TestController.prototype.addResultHandler): Test controller will send notification of a test result to result handler
670         (TestController.prototype.addSetupArgs): This gives some additional args for the common setup method for each test class, 
671         it is the best place to setup something like a root element, a fake data source, etc
672         (TestController.prototype.collect): This method used for collect the test classes.
673         (TestController.prototype.async.collectFile): It will import the file as a module dynamicly and collect all the test classes that module export
674         (TestController.prototype.async.runTest): It will run a test method of a test class
675         (TestController.prototype.async.run): It will run all test or a test class or a test method
676         * resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js: components for test app.
677         * resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js: Ref.js test cases.
678         * resultsdbpy/resultsdbpy/view/static/library/js/test/index.html: Test app entry.
679
680 2019-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
681
682         FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState triggers a debug assertion
683         https://bugs.webkit.org/show_bug.cgi?id=202145
684         <rdar://problem/51273128>
685
686         Reviewed by Tim Horton.
687
688         Fixes this API test to work on iPad as well as iPhone. Importantly, we show a popover when focusing
689         select elements on iPad, which means that there is no -inputView present on WKContentView, and upon
690         dismissing the form accessory view, the select element is still focused.
691
692         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
693
694 2019-09-25  Cathie Chen  <cathiechen@igalia.com>
695
696         Add Cathie Chen as WebKit committer
697
698         Unreviewed.
699
700         * Scripts/webkitpy/common/config/contributors.json:
701
702 2019-09-24  Alex Christensen  <achristensen@webkit.org>
703
704         Require a WebsiteDataStore when creating or resuming downloads
705         https://bugs.webkit.org/show_bug.cgi?id=202081
706
707         Reviewed by Youenn Fablet.
708
709         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
710         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
711
712 2019-09-23  Zan Dobersek  <zdobersek@igalia.com>
713
714         run-web-platform-tests: remove support for in-repository manifest, expectation management
715         https://bugs.webkit.org/show_bug.cgi?id=202037
716
717         Reviewed by Carlos Alberto Lopez Perez.
718
719         Instead of keeping wpt metadata inside the WebKit repository or have it
720         generated on-the-fly, provide additional option flags for the
721         run-web-platform-tests script that allows detailed specification of the
722         metadata, manifest and include manifest locations, if necessary.
723
724         If the metadata location is not provided, the wptrunner tool will simply
725         not rely on any metadata to adjust expected results. With no manifest
726         path specified, the manifest will be generated inside the wpt checkout.
727         If no include manifest is specified, all the tests will be initially
728         selected for running (until they're possibly filtered through additional
729         command line arguments).
730
731         * Scripts/webkitpy/common/config/ports_mock.py:
732         (MockPort.run_bindings_tests_command):
733         (MockPort.wpt_metadata_directory): Deleted.
734         (MockPort.wpt_manifest_file): Deleted.
735         * Scripts/webkitpy/port/base.py:
736         (Port.default_results_directory):
737         (Port.wpt_metadata_directory): Deleted.
738         (Port.wpt_manifest_file): Deleted.
739         * Scripts/webkitpy/w3c/wpt_runner.py:
740         (parse_args):
741         (WPTRunner.prepare_wpt_checkout):
742         (WPTRunner.run):
743         (WPTRunner._generate_metadata_directory): Deleted.
744         (WPTRunner._wpt_run_paths): Deleted.
745         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
746         (WPTRunnerTest.TestInstance.__init__):
747         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
748         (WPTRunnerTest.test_run):
749         (WPTRunnerTest.test_run_with_specified_options):
750         (WPTRunnerTest.test_run_with_args):
751         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): Deleted.
752         (WPTRunnerTest.test_generate_metadata_directory): Deleted.
753
754 2019-09-23  Fujii Hironori  <Hironori.Fujii@sony.com>
755
756         [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown
757         https://bugs.webkit.org/show_bug.cgi?id=201913
758
759         Reviewed by Ross Kirsling.
760
761         Implemented eventSender.keyDown for Windows WebKitTestRunner based
762         on DumpRenderTree implementation.
763
764         There is a difference between them. Only WTR truns KF_UP and
765         KF_REPEAT flags on for WM_KEYUP event.
766         EventSenderProxy::dispatchMessage is used in WTR. It calls
767         TranslateMessage, this introduces the difference. If I didn't turn
768         those bits, TranslateMessage posts WM_CHAR even for WM_KEYUP.
769         According the spec, WM_KEYUP needs those bits.
770         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-keyup>
771         DRT doesn't need the those bits becasuse it doesn't use
772         TranslateMessage for WM_KEYUP.
773
774         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
775         (WTR::makeKeyDataForScanCode): Added.
776         (WTR::pumpMessageQueue): Added.
777         (WTR::EventSenderProxy::keyDown): Implemented by using DRT code.
778
779 2019-09-23  Aakash Jain  <aakash_jain@apple.com>
780
781         [EWS] Rename CompileJSCOnly to CompileJSC
782         https://bugs.webkit.org/show_bug.cgi?id=202118
783
784         Reviewed by Jonathan Bedard.
785
786         * BuildSlaveSupport/ews-build/factories.py:
787         (JSCTestsFactory.__init__): Renamed CompileJSCOnly to CompileJSC.
788         * BuildSlaveSupport/ews-build/steps.py:
789         (CompileWebKit.evaluateCommand): Ditto.
790         (AnalyzeCompileWebKitResults.start): Ditto.
791         (CompileJSC): Changed step-name to 'compile-jsc' to better match with similar steps like 'compile-webkit'. 
792         (CompileJSCToT): Ditto for 'compile-jsc-tot'.
793         * BuildSlaveSupport/ews-build/steps_unittest.py: Renamed CompileJSCOnly to CompileJSC and CompileJSCOnlyToT to CompileJSCToT.
794
795 2019-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
796
797         [iOS] Drop animation when dragging images from Photos to WebKit2 Mail compose is incorrect
798         https://bugs.webkit.org/show_bug.cgi?id=201674
799         <rdar://problem/51250952>
800
801         Reviewed by Tim Horton.
802
803         Add a couple of new API tests to exercise the new image placeholder drop codepath, in addition to testing
804         infrastructure to simulate the timing of drop animation delegate calls.
805
806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
807         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
808         (-[NSArray _attachmentWithName:]):
809         (-[TestWKWebView allBoundingClientRects:]):
810
811         Add some new API testing helper methods.
812
813         (TestWebKitAPI::targetedImageDragPreview):
814         (TestWebKitAPI::TEST):
815
816         Add two new tests, to:
817         (1) verify that images are dropped as attachment-backed placeholder image elements when the web view is editable
818             and enables attachment elements, and
819         (2) verify that when dropping an image taller than the web view, the bottom portion of the drop preview is
820             clipped using the targeted preview parameter's visiblePath.
821
822         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
823         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
824         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
825         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h: Added.
826         * TestWebKitAPI/cocoa/NSItemProviderAdditions.mm: Added.
827
828         Move some common helpers for registering data on a NSItemProvider to a separate file, so that it can be used in
829         both WKAttachmentTests and DragAndDropTests.
830
831         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
832         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:loadingDelay:]):
833         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
834         (-[DragAndDropSimulator initWithWebView:]):
835         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
836         (-[DragAndDropSimulator clearExternalDragInformation]):
837         (-[DragAndDropSimulator setExternalItemProviders:defaultDropPreviews:]):
838
839         Add a new method to allow tests to specify both a list of externally dragged item providers, as well as default
840         targeted previews for each of the corresponding items. These default previews are used when invoking the drop
841         interaction delegate's preview generation methods.
842
843         (-[DragAndDropSimulator addAnimations:]):
844
845         Not implemented yet; for now, this simply asserts.
846
847         (-[DragAndDropSimulator addCompletion:]):
848
849         Queues a completion handler, which is invoked when the drop animation for each item completes. Depending on the
850         value of DragAndDropSimulator's -dropAnimationTiming, this may occur either before or after handling the drop.
851         By default, these will be invoked after the drop completes, which represents the common case where data can be
852         loaded quickly relative to the drop animation.
853
854         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
855         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
856
857 2019-09-23  Jonathan Bedard  <jbedard@apple.com>
858
859         results.webkit.org: Collapse results with the same version name (Follow-up fix)
860         https://bugs.webkit.org/show_bug.cgi?id=201779
861
862         Rubber-stamped by Aakash Jain.
863
864         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
865         (Configuration.prototype.compare): Correctly compare constructed version names.
866
867 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
868
869         [WebAuthn] LocalAuthenticator tests are failing on internal bots
870         https://bugs.webkit.org/show_bug.cgi?id=201844
871         <rdar://problem/54278693>
872
873         Reviewed by Brent Fulgham.
874
875         LocalAuthenticator tests utilize Keychain for mock testing. Unlike iOS simulator tests which
876         each test runner is running in different simulator containers, all test runners are running
877         in the same macOS container in macOS. Therefore, Keychain is shared among all test runners
878         in macOS while it is not in iOS simulators. And therefore, race conditions would happen in
879         macOS which make the current tests flaky given they don't consider race conditions.
880
881         This patch then makes each test generate a random credential, and thus no other tests would
882         be able to access it, and therefore eliminate any race condition. To support this, a few new
883         functionalities are introduced to the mock test infrastructure as well:
884         1) TestRunner.cleanUpKeychain accepts a new parameter to more precisely identify an item.
885         2) WebAuthenticationMockConfiguration.Local has a new member to uniquely select a credential
886         for getAssertion ceremony when multiple presents.
887
888         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
890         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
891         (WTR::TestRunner::cleanUpKeychain):
892         * WebKitTestRunner/InjectedBundle/TestRunner.h:
893         * WebKitTestRunner/TestController.h:
894         * WebKitTestRunner/TestInvocation.cpp:
895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
896         * WebKitTestRunner/TestController.cpp:
897         (WTR::TestController::cleanUpKeychain):
898         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
899         (WTR::TestController::cleanUpKeychain):
900
901 2019-09-20  Aakash Jain  <aakash_jain@apple.com>
902
903         [EWS] JSC queues should re-build ToT and compare results on build failure
904         https://bugs.webkit.org/show_bug.cgi?id=201999
905
906         Reviewed by Jonathan Bedard.
907
908         * BuildSlaveSupport/ews-build/factories.py:
909         (JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
910         these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
911         Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.
912         * BuildSlaveSupport/ews-build/steps.py:
913         (CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
914         (AnalyzeCompileWebKitResults.start): Ditto.
915         (CompileJSCOnly.start): Set the 'group' property to 'jsc'.
916         (CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is 
917         not used, base class evaluateCommand adds build-steps dynamically.
918
919 2019-09-20  Keith Rollin  <krollin@apple.com>
920
921         Remove some support for < iOS 13
922         https://bugs.webkit.org/show_bug.cgi?id=201967
923         <rdar://problem/55504738>
924
925         Reviewed by Andy Estes.
926
927         Remove some support for iOS versions less than 13.0.
928
929         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
930         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
931         values >= 130000. This means that expressions like
932         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
933         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
934
935         After version checks have been removed, there are some cases where the
936         preprocessor conditional looks like "#if PLATFORM(MAC) ||
937         PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
938         PLATFORM(COCOA)". This additional cleanup will be performed in a
939         subsequent patch.
940
941         This removal is part of a series of patches effecting the removal of
942         dead code for old versions of iOS. This particular pass involves
943         changes in which Andy Estes was involved. These changes are isolated
944         from other similar changes in order to facilitate the reviewing
945         process.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.
948
949 2019-09-20  Alex Christensen  <achristensen@webkit.org>
950
951         Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
952         https://bugs.webkit.org/show_bug.cgi?id=202025
953
954         Reviewed by Chris Dumez.
955
956         One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
957         because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
958
959         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
960         * WebKitTestRunner/TestController.cpp:
961         (WTR::TestController::websiteDataStore):
962         (WTR::TestController::generatePageConfiguration):
963
964 2019-09-20  Keith Rollin  <krollin@apple.com>
965
966         Remove some support for < iOS 13
967         https://bugs.webkit.org/show_bug.cgi?id=201973
968         <rdar://problem/55506966>
969
970         Reviewed by Alex Christensen.
971
972         Remove some support for iOS versions less than 13.0.
973
974         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
975         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
976         values >= 130000. This means that expressions like
977         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
978         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
979
980         This removal is part of a series of patches effecting the removal of
981         dead code for old versions of iOS. This particular pass involves
982         changes in which Chris Dumez was involved. These changes are isolated
983         from other similar changes in order to facilitate the reviewing
984         process.
985
986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
987
988 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
989
990         [FTW] Enable WebKitTestRunner build
991         https://bugs.webkit.org/show_bug.cgi?id=201996
992
993         Reviewed by Fujii Hironori.
994
995         It's time to start getting the test system up and running for FTW.
996
997         This patch does the following:
998
999         1. Adds relevant CMake changes to get things building.
1000         2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
1001         3. Updates 'webkitpy' to recognize the 'ftw' port.
1002
1003         Note: Pixel tests are not yet supported.
1004
1005         * PlatformFTW.cmake: Build the WK2 test runner.
1006         * Scripts/build-webkit: Update to recognize the FTW port.
1007         * Scripts/webkitdirs.pm: Ditto.
1008         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Ditto.
1009         * Scripts/webkitpy/common/config/ports.py: Ditto.
1010         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1011         * Scripts/webkitpy/common/version_name_map.py: Ditto.
1012         * Scripts/webkitpy/port/factory.py: Ditto.
1013         * Scripts/webkitpy/port/win.py: Ditto.
1014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1015         (WTR::InjectedBundlePage::dumpDOMAsWebArchive): Don't build or run this method
1016         on Windows.
1017         * WebKitTestRunner/PlatformFTW.cmake: Added.
1018         * WebKitTestRunner/PlatformWebView.h:
1019         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1020         * WebKitTestRunner/win/TestInvocationDirect2D.cpp: Added.
1021         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add stub implementation.
1022
1023 2019-09-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1024
1025         [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
1026         https://bugs.webkit.org/show_bug.cgi?id=201976
1027
1028         Reviewed by Don Olmstead.
1029
1030         This change consists of three refactorings:
1031         1. Replaced explicit QueryInterface with _com_ptr_t methods
1032         2. Replaced typedef with _COM_SMARTPTR_TYPEDEF macro
1033         3. Replaced WebCore's COMPtr with _com_ptr_t because it is not a public WebKit API
1034
1035         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1036         (MiniBrowserWebHost::didFirstLayoutInFrame): Deleted.
1037         * MiniBrowser/win/MiniBrowserWebHost.h:
1038         (MiniBrowserWebHost::didFirstLayoutInFrame):
1039         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1040         (getHandleFromWebView):
1041         (PrintWebUIDelegate::webViewPrintingMarginRect):
1042         (PrintWebUIDelegate::runModal):
1043         (PrintWebUIDelegate::createModalDialog):
1044         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1045         (WebKitLegacyBrowserWindow::init):
1046         (WebKitLegacyBrowserWindow::setToDefaultPreferences):
1047         (WebKitLegacyBrowserWindow::showLastVisitedSites):
1048         (WebKitLegacyBrowserWindow::reload):
1049         (WebKitLegacyBrowserWindow::resetZoom):
1050         (WebKitLegacyBrowserWindow::zoomIn):
1051         (WebKitLegacyBrowserWindow::zoomOut):
1052         (WebKitLegacyBrowserWindow::showLayerTree):
1053         (WebKitLegacyBrowserWindow::print):
1054         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1055         (WebKitLegacyBrowserWindow::privatePreferences):
1056         * MiniBrowser/win/WinMain.cpp:
1057         (wWinMain):
1058         * MiniBrowser/win/stdafx.h:
1059
1060 2019-09-19  Joanmarie Diggs  <jdiggs@igalia.com>
1061
1062         [GTK] Dependency hunspell-en-gb cannot be found on Fedora 30
1063         https://bugs.webkit.org/show_bug.cgi?id=202009
1064
1065         Update package name to hunspell-en-GB.
1066
1067         Reviewed by Carlos Alberto Lopez Perez.
1068
1069         * gtk/install-dependencies:
1070
1071 2019-09-19  Jonathan Bedard  <jbedard@apple.com>
1072
1073         results.webkit.org: Collapse results with the same version name
1074         https://bugs.webkit.org/show_bug.cgi?id=201779
1075
1076         Rubber-stamped by Aakash Jain.
1077
1078         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1079         (Configuration.prototype.const.ending.this.version_name.substring):
1080         (Configuration.prototype.toKey): Prefer version_name over version number in key.
1081         (Configuration.prototype.compare): version_name comparison should always override version comparison.
1082         (Configuration.prototype.compareSDKs): Make SDK regex global.
1083         (Configuration.prototype.toParams): Remove E tag on version_name.
1084         (Configuration): Append E tag on the version_name based on the SDK.
1085         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1086         (TimelineFromEndpoint.prototype.toString): Print version number with SDK.
1087
1088 2019-09-19  Ryan Haddad  <ryanhaddad@apple.com>
1089
1090         REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
1091         https://bugs.webkit.org/show_bug.cgi?id=201902
1092
1093         Unreviewed test gardening.
1094
1095         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Disable the test on iOS.
1096
1097 2019-09-19  Aakash Jain  <aakash_jain@apple.com>
1098
1099         [ews] Fix platform for JSC EWS
1100         https://bugs.webkit.org/show_bug.cgi?id=201997
1101
1102         Reviewed by Jonathan Bedard.
1103
1104         * BuildSlaveSupport/ews-build/config.json:
1105
1106 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1107
1108         Create InjectedBundle SPI to better support NSSecureCoding
1109         https://bugs.webkit.org/show_bug.cgi?id=201810
1110         <rdar://problem/55265713>
1111
1112         The encoding/decoding routines used by WebKit’s InjectedBundles are based on NSCoding.
1113         While we have changed WebKit internals to use NSSecureCoding, there are a number of
1114         injected bundles that need to serialize custom classes between the InjectedBundle and
1115         the relevant WebKit UIProcess.
1116
1117         We need to lock down this communications channel by enforcing NSSecureCoding.
1118
1119         This patch creates new SPI to allow the UIProcess to specify classes that it will accept
1120         in messages from the WebContet Process (and Injected Bundle).
1121
1122         It adds the following property to the WKProcessPoolConfiguration:
1123
1124             @property (nonatomic, copy) NSSet<Class> *customClassesForParameterCoder;
1125
1126         If no custom classes are specified, the standard serialization primitives are supported:
1127             NSArray, NSData, NSDate, NSDictionary, NSNull, NSNumber, NSSet, NSString,
1128             NSTimeZone, NSURL, and NSUUID.
1129
1130         Reviewed by Brady Eidson.
1131
1132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1133         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm: Added.
1134         (-[BundleFormDelegateRemoteObject didGetFocus]):
1135         (-[FormInputDelegate _webView:decidePolicyForFocusedElement:]):
1136         (TEST):
1137         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegatePlugIn.mm: Added.
1138         (-[BundleFormDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1139         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:willBeginInputSessionForElement:inFrame:userIsInteracting:]):
1140         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:didFocusTextField:inFrame:]):
1141         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegateProtocol.h: Copied from Tools/TestWebKitAPI/WKWebViewConfigurationExtras.h.
1142         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1143         (TEST):
1144         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1145         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1146         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
1147         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:andCustomParameterClasses:]):
1148
1149 2019-09-18  Zhifei Fang  <zhifei_fang@apple.com>
1150
1151         [results.webkit.org] fix missing col classes
1152         https://bugs.webkit.org/show_bug.cgi?id=201949
1153
1154         Reviewed by Jonathan Bedard.
1155
1156         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1157         (@media screen and (min-width: 768px)):
1158         (.row):
1159         (.col-1):
1160         (.col-2):
1161         (.col-3):
1162         (.col-4):
1163         (.col-5):
1164         (.col-6):
1165         (.col-7):
1166         (.col-8):
1167         (.col-9):
1168         (.col-10):
1169         (.col-11):
1170         (.col-12):
1171         (@media screen and (min-width: 600px)):
1172
1173 2019-09-18  Ryan Haddad  <ryanhaddad@apple.com>
1174
1175         Update flakiness dashboard configuration for iOS 13 queues
1176         https://bugs.webkit.org/show_bug.cgi?id=201711
1177
1178         Reviewed by Jonathan Bedard.
1179
1180         * TestResultServer/static-dashboards/builders.jsonp:
1181
1182 2019-09-18  Adrian Perez de Castro  <aperez@igalia.com>
1183
1184         [WPE][GTK] Update build environments to use libwpe+WPEBackend-fdo 1.4.0
1185         https://bugs.webkit.org/show_bug.cgi?id=201915
1186
1187         Reviewed by Michael Catanzaro.
1188
1189         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.4.0
1190         * gtk/jhbuild.modules: Ditto.
1191         * wpe/jhbuild.modules: Ditto.
1192
1193 2019-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1194
1195         [Win][MiniBrowser] Remove unused DOMDefaultImpl.cpp
1196         https://bugs.webkit.org/show_bug.cgi?id=201867
1197
1198         Reviewed by Darin Adler.
1199
1200         * MiniBrowser/win/CMakeLists.txt: Removed DOMDefaultImpl.cpp.
1201         * MiniBrowser/win/DOMDefaultImpl.cpp: Removed.
1202         * MiniBrowser/win/DOMDefaultImpl.h: Removed.
1203         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1204
1205 2019-09-17  Dean Jackson  <dino@apple.com>
1206
1207         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1208         https://bugs.webkit.org/show_bug.cgi?id=201864
1209         <rdar://55190038>
1210
1211         Reviewed by Simon Fraser.
1212
1213         Test for the suggested actions.
1214
1215         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1216         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1217         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1218         (TEST):
1219
1220 2019-09-17  Jonathan Bedard  <jbedard@apple.com>
1221
1222         results.webkit.org results bubbles' tooltips should include SDK information
1223         https://bugs.webkit.org/show_bug.cgi?id=201823
1224
1225         Rubber-stamped by Aakash Jain.
1226
1227         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1228         (Configuration.prototype.compare): Like the Python instance of this class,
1229         support using null as a wildcard.
1230         (Configuration.prototype.compareSDKs): Ditto.
1231         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1232         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Construct a configuration
1233         object from all bits of data used to construct a given bubble.
1234         (TimelineFromEndpoint.prototype.render):
1235
1236 2019-09-17  Keith Rollin  <krollin@apple.com>
1237
1238         Remove some support for < iOS 12
1239         https://bugs.webkit.org/show_bug.cgi?id=201851
1240         <rdar://problem/55422044>
1241
1242         Reviewed by Jiewen Tan and Alexey Proskuryakov.
1243
1244         Remove some support for iOS versions less than 12.0.
1245
1246         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1247         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1248         values >= 120000. This means that expressions like
1249         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and
1250         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True.
1251
1252         This removal is part of a series of patches effecting such removal.
1253
1254         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1255         (WTR::installFakeHelvetica):
1256
1257 2019-09-17  David Kilzer  <ddkilzer@apple.com>
1258
1259         run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
1260         <https://webkit.org/b/201873>
1261
1262         Reviewed by Jonathan Bedard.
1263
1264         * Scripts/webkitpy/port/driver.py:
1265         (Driver.run_test): Call self.do_post_tests_work() when a test
1266         shard has completed, but didn't crash or time out.
1267
1268 2019-09-17  Chris Dumez  <cdumez@apple.com>
1269
1270         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
1271         https://bugs.webkit.org/show_bug.cgi?id=201859
1272         <rdar://problem/55426742>
1273
1274         Reviewed by Alex Christensen.
1275
1276         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
1277         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
1278
1279         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1280         (TestWebKitAPI::TEST):
1281
1282 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
1283
1284         Bring up queues for iOS 13
1285         https://bugs.webkit.org/show_bug.cgi?id=201710
1286
1287         Reviewed by Jonathan Bedard.
1288
1289         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
1290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1292         (WebKitBuildbot):
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1294         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
1295         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
1296         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
1297         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1298         (_should_file_trigger_build):
1299         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1300         (ShouldBuildTest):
1301         (ShouldBuildTest.test_should_build):
1302         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
1303
1304 2019-09-17  Truitt Savell  <tsavell@apple.com>
1305
1306         Unreviewed, rolling out r249950.
1307
1308         Broke the iOS build.
1309
1310         Reverted changeset:
1311
1312         "Remove the "Show Link Previews" and "Hide Link Previews"
1313         action menus in the preview platter"
1314         https://bugs.webkit.org/show_bug.cgi?id=201864
1315         https://trac.webkit.org/changeset/249950
1316
1317 2019-09-17  Dean Jackson  <dino@apple.com>
1318
1319         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1320         https://bugs.webkit.org/show_bug.cgi?id=201864
1321         <rdar://55190038>
1322
1323         Reviewed by Simon Fraser.
1324
1325         Test for the suggested actions.
1326
1327         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1328         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1329         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1330         (TEST):
1331
1332 2019-09-16  Alex Christensen  <achristensen@webkit.org>
1333
1334         Remove "gopher" from list of special schemes in URLParser
1335         https://bugs.webkit.org/show_bug.cgi?id=201852
1336
1337         Reviewed by Simon Fraser.
1338
1339         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1340         (TestWebKitAPI::TEST_F):
1341         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
1342         (TestWebKitAPI::TEST_F):
1343         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1344
1345 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1346
1347         results.webkit.org: Shard result archives
1348         https://bugs.webkit.org/show_bug.cgi?id=201734
1349
1350         Reviewed by Dewei Zhu.
1351
1352         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
1353         In practice, this usually doesn't work according to the Cassandra developers,
1354         large blobs should be broken up into shards of, at most, 10 MB.
1355
1356         * resultsdbpy/resultsdbpy/model/archive_context.py:
1357         (ArchiveContext):
1358         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
1359         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
1360         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
1361         (ArchiveContext.__init__):
1362         (ArchiveContext.register): When saving archives, save a reference hash and then
1363         shard the actual archive data before saving.
1364         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
1365         the archive. Raise an exception if we determine that memory usage is a problem.
1366         (ArchiveContext.ArchivesByCommit): Deleted.
1367         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
1368         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
1369         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
1370         (ArchiveContextTest):
1371         (ArchiveContextTest.test_large_archive): Test archive sharding.
1372
1373 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1374
1375         [WebAuthn] Support more than two FIDO protocol versions
1376         https://bugs.webkit.org/show_bug.cgi?id=198408
1377         <rdar://problem/51292176>
1378
1379         Reviewed by Chris Dumez.
1380
1381         Adds a new test case that includes a FIDO_2_1_PRE version string.
1382
1383         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1384         (TestWebKitAPI::TEST):
1385         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1386
1387 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1388
1389         results.webkit.org: Configurations should be branch specific
1390         https://bugs.webkit.org/show_bug.cgi?id=201561
1391
1392         Reviewed by Dewei Zhu.
1393
1394         Partition configurations by branch in both Redis and Cassandra.
1395
1396         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
1397         (UploadController.suites): Allow the user to specify branches while listing suites.
1398         * resultsdbpy/resultsdbpy/model/archive_context.py:
1399         (ArchiveContext.register): Register each configuration with a branch.
1400         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1401         (ConfigurationContext.ByPlatform): Index by branch.
1402         (ConfigurationContext.ByPlatformAndVersion): Ditto.
1403         (ConfigurationContext.ByArchitecture): Ditto.
1404         (ConfigurationContext.ByModel): Ditto.
1405         (ConfigurationContext.__init__): Populate Redis cache with branch.
1406         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
1407         (ConfigurationContext._register_in_redis): Register configuration with branch.
1408         (ConfigurationContext.register_configuration): Ditto.
1409         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
1410         (ConfigurationContext.search_for_recent_configuration): Ditto.
1411         (ConfigurationContext.select_from_table_with_configurations): Ditto.
1412         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
1413         (ConfigurationContextTest.register_configurations): Register with branch.
1414         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
1415         CommitContext object.
1416         * resultsdbpy/resultsdbpy/model/upload_context.py:
1417         (UploadContext.SuitesByConfiguration): Index by branch.
1418         (UploadContext.upload_test_results): Register each configuration with a branch.
1419         (UploadContext.find_suites): Pass branch to search for configurations.
1420         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
1421         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
1422
1423 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1424
1425         check-webkit-style: Fix warning message for std::make_unique<typename[]>
1426         <https://webkit.org/b/201818>
1427
1428         Reviewed by Darin Adler.
1429
1430         * Scripts/webkitpy/style/checkers/cpp.py:
1431         (check_wtf_make_unique): Emit different error message when using
1432         std::make_unique<>() to create an array.  Personalize the error
1433         message by including the original type name, which also
1434         demonstrates that WTF::makeUniqueArray<>() does not need square
1435         brackets for its typename.
1436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1437         (WebKitStyleTest.test_wtf_make_unique): Add test.
1438         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
1439
1440 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1441
1442         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
1443         https://bugs.webkit.org/show_bug.cgi?id=201820
1444
1445         Reviewed by Chris Fleizach.
1446
1447         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1448         (AccessibilityUIElement::insertText):
1449         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1450         (AccessibilityUIElement::insertText):
1451         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1452         (WTR::AccessibilityUIElement::insertText):
1453         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1454         (WTR::AccessibilityUIElement::insertText):
1455
1456 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1457
1458         Fix leaks in DumpRenderTree and WebKitTestRunner
1459         <https://webkit.org/b/201814>
1460
1461         Reviewed by Darin Adler.
1462
1463         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1464         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1465         Add CF_RETURNS_RETAINED to document behavior.
1466         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1467         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1468
1469         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1470         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
1471         behavior.
1472         (createBitmapContextFromWebView): Fix leak of CGImageRef when
1473         generating a replacement image.
1474
1475         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
1476         declaration for _stableStateOverride so compiler wouldn't try to
1477         create another instance variable for it.
1478
1479         * WebKitTestRunner/mac/EventSenderProxy.mm:
1480         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1481         Release `cgEvent` to fix leak.
1482
1483 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1484
1485         Expose misspelling ranges for editable content to accessibility clients.
1486         https://bugs.webkit.org/show_bug.cgi?id=201752
1487         <rdar://problem/49556828>
1488
1489         Reviewed by Chris Fleizach.
1490
1491         Test code needed for LayoutTests/accessibility/misspelling-range.html.
1492         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1493         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1494         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1495         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1496         (WTR::AccessibilityUIElement::indexForTextMarker):
1497         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1498         (WTR::misspellingSearchParameterizedAttributeForCriteria):
1499         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1500
1501 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1502
1503         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
1504         https://bugs.webkit.org/show_bug.cgi?id=201544
1505
1506         Reviewed by Michael Catanzaro.
1507
1508         Add new test cases.
1509
1510         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1511         (testWebViewActiveURI):
1512         (testWebViewIsLoading):
1513         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1514         (loadChangedCallback):
1515         (LoadTrackingTest::loadAlternateHTML):
1516         (LoadTrackingTest::reset):
1517         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
1518
1519 2019-09-15  David Kilzer  <ddkilzer@apple.com>
1520
1521         block-spammers should obtain credentials the same way as webkit-patch
1522         <https://webkit.org/b/201733>
1523
1524         Reviewed by Lucas Forschler.
1525
1526         * Scripts/block-spammers: Import Credentials from webkitpy.
1527         Remove unused imports.  Enable logging at info level to match
1528         webkit-patch.
1529         (get_bugzilla_token): Use Credentials module to get
1530         bugs.webkit.org credentials.
1531         * Scripts/webkitpy/common/net/credentials.py:
1532         (Credentials._run_security_tool): Change logging level from
1533         error to info since multiple attempts are made at reading the
1534         keychain.  Fix typos in comment.
1535         (Credentials._credentials_from_security_command): Extract common
1536         logic from Credentials._credentials_from_keychain into new
1537         method.
1538         (Credentials._credentials_from_keychain): Make fallback logic
1539         for checking for credentials in the keychain more consistent and
1540         easier to read.  Add error logging if no credentials are found.
1541
1542 2019-09-13  Youenn Fablet  <youenn@apple.com>
1543
1544         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
1545         https://bugs.webkit.org/show_bug.cgi?id=201718
1546
1547         Reviewed by Chris Dumez.
1548
1549         Read meta tag information to select the environments where the any.js template tests will be run.
1550         Added support to run service worker tests from any.js template tests.
1551
1552         Covered by unit test.
1553         Since we import only a single repository nowadays, use a test config file with just one repository
1554         to simplify the new test.
1555
1556         * Scripts/webkitpy/w3c/test_importer.py:
1557         (TestImporter.__init__):
1558         (TestImporter.readEnvironmentsForTemplateTest):
1559         (TestImporter.write_html_files_for_templated_js_tests):
1560         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1561         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1562         (TestImporterTest.test_import_dir_with_no_tests):
1563         (TestImporterTest.test_import_dir_with_empty_init_py):
1564         (TestImporterTest.test_harnesslinks_conversion):
1565         (TestImporterTest.test_submodules_generation):
1566         (test_checkout_directory):
1567         (test_clean_directory_option):
1568         (test_git_ignore_generation):
1569         (test_initpy_generation):
1570         (test_remove_obsolete_content):
1571         (test_manual_slow_test):
1572         (test_webkit_test_runner_options):
1573         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
1574         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
1575         (test_template_test):
1576
1577 2019-09-13  Dean Jackson  <dino@apple.com>
1578
1579         Provide a prototype for AR QuickLook to trigger processing in the originating page
1580         https://bugs.webkit.org/show_bug.cgi?id=201371
1581         <rdar://54904781>
1582
1583         Disable the test for the moment.
1584
1585         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
1586         (TestWebKitAPI::TEST):
1587
1588 2019-09-11  Dean Jackson  <dino@apple.com>
1589
1590         Provide a prototype for AR QuickLook to trigger processing in the originating page
1591         https://bugs.webkit.org/show_bug.cgi?id=201371
1592         <rdar://54904781>
1593
1594         Reviewed by Simon Fraser.
1595
1596         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
1599
1600 2019-09-13  Youenn Fablet  <youenn@apple.com>
1601
1602         Partition processes running service workers by session ID
1603         https://bugs.webkit.org/show_bug.cgi?id=201643
1604
1605         Reviewed by Chris Dumez.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1608
1609 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
1610
1611         Re-add myself to the list of committers
1612
1613         Unreviewed.
1614
1615         * Scripts/webkitpy/common/config/contributors.json:
1616
1617 2019-09-13  Alex Christensen  <achristensen@webkit.org>
1618
1619         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
1620         https://bugs.webkit.org/show_bug.cgi?id=201745
1621
1622         Reviewed by Chris Dumez.
1623
1624         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1625         (TestWebKitAPI::TEST):
1626         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
1627
1628 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
1629
1630         [JHBuild] Fix building gst-plugins-good against glibc 2.30
1631         https://bugs.webkit.org/show_bug.cgi?id=201715
1632
1633         Reviewed by Xabier Rodriguez-Calvar.
1634
1635         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
1636
1637 2019-09-12  Chris Dumez  <cdumez@apple.com>
1638
1639         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
1640         https://bugs.webkit.org/show_bug.cgi?id=201546
1641
1642         Reviewed by Alex Christensen.
1643
1644         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
1645         the right thing for WebKit2 and tests have been rewritten to not use it.
1646
1647         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1648         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1649         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
1650         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1651
1652 2019-09-12  Brady Eidson  <beidson@apple.com>
1653
1654         PDF exporting on iOS should include URL rects.
1655         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
1656
1657         Reviewed by Tim Horton.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
1660         (TestWebKitAPI::TEST): Enable on iOS.
1661
1662 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
1663
1664         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
1665         https://bugs.webkit.org/show_bug.cgi?id=201077
1666
1667         Reviewed by Carlos Garcia Campos.
1668
1669         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
1670         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1671         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
1672
1673 2019-09-12  Mark Lam  <mark.lam@apple.com>
1674
1675         Harden JSC against the abuse of runtime options.
1676         https://bugs.webkit.org/show_bug.cgi?id=201597
1677         <rdar://problem/55167068>
1678
1679         Reviewed by Filip Pizlo.
1680
1681         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
1682         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
1683
1684         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
1685         to disable the hardening on test runs.  Tests rely on setting options to enable
1686         test features.
1687
1688         * DumpRenderTree/mac/DumpRenderTree.mm:
1689         (dumpRenderTree):
1690         * DumpRenderTree/win/DumpRenderTree.cpp:
1691         (initialize):
1692         * TestWebKitAPI/PlatformUtilities.cpp:
1693         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1694         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1695         (main):
1696         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1697         (TestWebKitAPI::TEST):
1698         (TestWebKitAPI::runActiveSessionTest):
1699         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1700         (TEST):
1701         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1702         (TEST):
1703         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1706         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1707         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1708         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
1709         * WebKitTestRunner/TestController.cpp:
1710         (WTR::TestController::generateContextConfiguration const):
1711
1712 2019-09-12  Keith Rollin  <krollin@apple.com>
1713
1714         Fix PDFKit references in TestWebKitAPI
1715         https://bugs.webkit.org/show_bug.cgi?id=201700
1716         <rdar://problem/55279539>
1717
1718         Reviewed by Youenn Fablet.
1719
1720         These references fail in watchOS and tvOS, so remove them on those
1721         platforms.
1722
1723         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1725         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
1726         * TestWebKitAPI/cocoa/TestPDFDocument.h:
1727         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
1728         * TestWebKitAPI/config.h:
1729
1730 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1731
1732         [Win][MiniBrowser] Select all text in the URL bar by clicking it
1733         https://bugs.webkit.org/show_bug.cgi?id=201677
1734
1735         Reviewed by Don Olmstead.
1736
1737         * MiniBrowser/win/MainWindow.cpp:
1738         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
1739
1740 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1741
1742         [GTK][WPE] Stop using the session bus in the unit tests
1743         https://bugs.webkit.org/show_bug.cgi?id=201636
1744
1745         Reviewed by Žan Doberšek.
1746
1747         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
1748         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
1749         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
1750         test. The server address is passed to the web extension as initialization parameter to connect directly to
1751         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
1752         a WebKitWebView.
1753
1754         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1755         (beforeAll):
1756         (afterAll):
1757         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1758         (testProcessPerWebView):
1759         (beforeAll):
1760         (afterAll):
1761         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1762         (testWebExtensionGetTitle):
1763         (testWebExtensionInputElementIsUserEdited):
1764         (testDocumentLoadedSignal):
1765         (testWebKitWebViewProcessCrashed):
1766         (testWebExtensionIsolatedWorld):
1767         (testInstallMissingPluginsPermissionRequest):
1768         (testWebExtensionFormControlsAssociated):
1769         (FormSubmissionTest::FormSubmissionTest):
1770         (beforeAll):
1771         (afterAll):
1772         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1773         (DelayedSignal::DelayedSignal):
1774         (emitPageCreated):
1775         (pageCreatedCallback):
1776         (webkit_web_extension_initialize_with_user_data):
1777         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1778         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1779         (AccessibilityTest::AccessibilityTest):
1780         (AccessibilityTest::ensureProxy):
1781         (beforeAll):
1782         (afterAll):
1783         * TestWebKitAPI/glib/CMakeLists.txt:
1784         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1785         (dbusConnectionClosed):
1786         (dbusServerConnection):
1787         (startDBusServer):
1788         (stopDBusServer):
1789         (main):
1790         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1791         (Test::initializeWebExtensions):
1792         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
1793         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
1794         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1795         (WebViewTest::~WebViewTest):
1796         (WebViewTest::extensionProxy):
1797         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1798
1799 2019-09-10  Dean Jackson  <dino@apple.com>
1800
1801         setup-git-clone is using http not https
1802         https://bugs.webkit.org/show_bug.cgi?id=201658
1803
1804         Reviewed by Sam Weinig.
1805
1806         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1807         (SetupGitClone.execute):
1808
1809 2019-09-10  Matt Lewis  <jlewis3@apple.com>
1810
1811         run-webkit-test: Allow results to be uploaded without scm checkout
1812         https://bugs.webkit.org/show_bug.cgi?id=200787
1813
1814         Reviewed by Jonathan Bedard.
1815
1816         * Scripts/webkitpy/common/checkout/scm/detection.py:
1817         (SCMDetector.detect_scm_system): Added in detection of stub repository.
1818         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
1819         (StubRepository):
1820         (StubRepository.__init__):
1821         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
1822         find the directory containing the checkout_information.json of the stub repository.
1823         (StubRepository.in_working_directory): Required functions to be implemented.
1824         (StubRepository.svn_revision): Required functions to be implemented.
1825         (StubRepository.native_revision): Required functions to be implemented.
1826         (StubRepository.native_branch): Required functions to be implemented.
1827         (StubRepository._decode_json): Decodes checkout_information.json.
1828         (StubRepository.find_checkout_root): Required functions to be implemented.
1829         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
1830         (StubRepositoryTest): Unit test for stub_repository SCM.
1831         (StubRepositoryTest.mock_host_for_stub_repository):
1832         (StubRepositoryTest.test_in_working_directory):
1833         (StubRepositoryTest.test_native_revision):
1834         (StubRepositoryTest.test_native_branch):
1835         (StubRepositoryTest.test_svn_revision):
1836         (StubRepositoryTest.test_find_checkout_root):
1837         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1838         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
1839         * Scripts/webkitpy/port/base.py:
1840         (Port.commits_for_upload): Removed unnecessary scm initialization.
1841
1842 2019-09-10  Brady Eidson  <beidson@apple.com>
1843
1844         Add SPI to save a PDF from the contents of a WKWebView.
1845         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
1846
1847         Reviewed by Tim Horton.
1848
1849         -Add an "Export to PDF..." menu option to MiniBrowser.
1850         -Add API tests for the API itself.
1851
1852         * MiniBrowser/MiniBrowser.entitlements:
1853
1854         * MiniBrowser/mac/BrowserWindowController.h:
1855         * MiniBrowser/mac/BrowserWindowController.m:
1856         (-[BrowserWindowController forceRepaint:]):
1857         (-[BrowserWindowController saveAsPDF:]):
1858
1859         * MiniBrowser/mac/MainMenu.xib:
1860
1861         * MiniBrowser/mac/WK1BrowserWindowController.m:
1862         (-[WK1BrowserWindowController validateMenuItem:]):
1863         * MiniBrowser/mac/WK2BrowserWindowController.m:
1864         (-[WK2BrowserWindowController validateMenuItem:]):
1865         (-[WK2BrowserWindowController saveAsPDF:]):
1866
1867         * TestWebKitAPI/Configurations/Base.xcconfig:
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
1870         (TestWebKitAPI::TEST):
1871         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
1872         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
1873         (TestWebKitAPI::toCGRect):
1874         (TestWebKitAPI::toPlatformPoint):
1875         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
1876         (TestWebKitAPI::TestPDFAnnotation::isLink const):
1877         (TestWebKitAPI::TestPDFAnnotation::bounds const):
1878         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
1879         (TestWebKitAPI::TestPDFPage::create):
1880         (TestWebKitAPI::TestPDFPage::TestPDFPage):
1881         (TestWebKitAPI::TestPDFPage::annotations):
1882         (TestWebKitAPI::TestPDFPage::characterCount const):
1883         (TestWebKitAPI::TestPDFPage::text const):
1884         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
1885         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
1886         (TestWebKitAPI::TestPDFPage::bounds const):
1887         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
1888         (TestWebKitAPI::TestPDFDocument::createFromData):
1889         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
1890         (TestWebKitAPI::TestPDFDocument::pageCount const):
1891         (TestWebKitAPI::TestPDFDocument::page):
1892
1893 2019-09-10  Keith Rollin  <krollin@apple.com>
1894
1895         Remove SSL-based TLSDeprecation.mm contents
1896         https://bugs.webkit.org/show_bug.cgi?id=201657
1897         <rdar://problem/55237678>
1898
1899         Reviewed by Alex Christensen.
1900
1901         This file does not build on watchOS due to references to SSL
1902         facilities. Conditionalize out the contents on HAVE_SSL.
1903
1904         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1905
1906 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1907
1908         Unreviewed, remove myself from watchlists
1909
1910         * Scripts/webkitpy/common/config/watchlist:
1911
1912 2019-09-09  Alex Christensen  <achristensen@webkit.org>
1913
1914         Rebase API test after r249675
1915         https://bugs.webkit.org/show_bug.cgi?id=201596
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1918         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1919         We removed the restriction on WebsitePolicies with non-default persistent sessions.
1920         We needed to change the expectations of the test that exercised that code path.
1921
1922 2019-09-09  Alex Christensen  <achristensen@webkit.org>
1923
1924         Fix iOS API tests after r249684
1925         https://bugs.webkit.org/show_bug.cgi?id=201573
1926
1927         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1928         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
1929         (TestWebKitAPI::TEST):
1930         The web thread still exists :(
1931         That makes iOS immediate failure results more like WK2, which is fine.
1932         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
1933
1934 2019-09-09  Chris Dumez  <cdumez@apple.com>
1935
1936         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
1937         https://bugs.webkit.org/show_bug.cgi?id=201550
1938
1939         Reviewed by Alex Christensen.
1940
1941         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
1942         anything or not.
1943
1944         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1946         (WTR::InjectedBundle::statisticsNotifyObserver):
1947         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1948         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1949         (WTR::TestRunner::statisticsNotifyObserver):
1950         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1951
1952 2019-09-09  Timothy Hatcher  <timothy@apple.com>
1953
1954         Tap and hold on Facebook sometimes creates a tall empty selection.
1955         https://bugs.webkit.org/show_bug.cgi?id=201618
1956         rdar://53630145
1957
1958         Reviewed by Megan Gardner.
1959
1960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1961         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
1962
1963 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [EWS] Watchlist doesn't work sometimes
1966         https://bugs.webkit.org/show_bug.cgi?id=201433
1967
1968         Reviewed by Michael Catanzaro.
1969
1970         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
1971         corresponding Bugzilla accounts.
1972
1973 2019-09-09  Alex Christensen  <achristensen@webkit.org>
1974
1975         Disable TLS 1.0 and 1.1 in WebSockets
1976         https://bugs.webkit.org/show_bug.cgi?id=201573
1977
1978         Reviewed by Youenn Fablet.
1979
1980         * TestWebKitAPI/SourcesCocoa.txt:
1981         * TestWebKitAPI/TCPServer.cpp:
1982         (sk_CRYPTO_BUFFER_num):
1983         (sk_CRYPTO_BUFFER_value):
1984         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
1985         (TestWebKitAPI::TCPServer::TCPServer):
1986         (TestWebKitAPI::TCPServer::listenForConnections):
1987         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
1988         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
1989         * TestWebKitAPI/TCPServer.h:
1990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1991         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
1992         (-[WebSocketDelegate waitForMessage]):
1993         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1994         (TestWebKitAPI::TEST):
1995         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1996         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1997         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1998         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
1999
2000 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2001
2002         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
2003         https://bugs.webkit.org/show_bug.cgi?id=201600
2004
2005         Reviewed by Brent Fulgham.
2006
2007         There were some circular references between
2008         WebKitLegacyBrowserWindow and its delegation classes. For
2009         example, WebKitLegacyBrowserWindow has a reference of
2010         WebDownloadDelegate, and WebDownloadDelegate shares the ref
2011         counter with WebKitLegacyBrowserWindow.
2012
2013         WebNotificationObserver was leaked because it wasn't unregistered
2014         from the default notification center by using
2015         IWebNotificationCenter::removeObserver.
2016
2017         If a new legacy window was created by mouse right click a link,
2018         WebView was released twice because
2019         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
2020         WebView.
2021
2022         This change does:
2023         1. Make delegation classes have own ref-counter to avoid circular references
2024         2. Do removeObserver notification observers
2025         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
2026
2027         * MiniBrowser/win/AccessibilityDelegate.cpp:
2028         (AccessibilityDelegate::AddRef):
2029         (AccessibilityDelegate::Release):
2030         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
2031         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2032         (MiniBrowserWebHost::QueryInterface):
2033         (MiniBrowserWebHost::AddRef):
2034         (MiniBrowserWebHost::Release):
2035         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
2036         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2037         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
2038         (PrintWebUIDelegate::AddRef):
2039         (PrintWebUIDelegate::Release):
2040         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
2041         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2042         (ResourceLoadDelegate::AddRef):
2043         (ResourceLoadDelegate::Release):
2044         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
2045         * MiniBrowser/win/WebDownloadDelegate.cpp:
2046         (WebDownloadDelegate::AddRef):
2047         (WebDownloadDelegate::Release):
2048         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
2049         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2050         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
2051         (WebKitLegacyBrowserWindow::init):
2052         (WebKitLegacyBrowserWindow::setUIDelegate):
2053         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
2054         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
2055         (WebKitLegacyBrowserWindow::setDownloadDelegate):
2056         (WebKitLegacyBrowserWindow::AddRef): Deleted.
2057         (WebKitLegacyBrowserWindow::Release): Deleted.
2058         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
2059         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
2060         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2061
2062 2019-09-09  Chris Dumez  <cdumez@apple.com>
2063
2064         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
2065         https://bugs.webkit.org/show_bug.cgi?id=201596
2066
2067         Reviewed by Alex Christensen.
2068
2069         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
2070         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
2071         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
2072         the WebCore::Document think it changed session.
2073
2074         * DumpRenderTree/TestRunner.cpp:
2075         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
2076         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
2077         (TestRunner::staticFunctions):
2078         (TestRunner::willNavigate):
2079         * DumpRenderTree/TestRunner.h:
2080         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2081         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2082         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2083         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2085         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2086         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2087         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2089         * WebKitTestRunner/TestController.cpp:
2090         (WTR::TestController::decidePolicyForNavigationAction):
2091         * WebKitTestRunner/TestController.h:
2092         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
2093         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
2094         * WebKitTestRunner/TestInvocation.cpp:
2095         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2096
2097 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2098
2099         EWS testtube emoji doesn't exist on macOS Mojave
2100         https://bugs.webkit.org/show_bug.cgi?id=201532
2101
2102         Reviewed by Simon Fraser.
2103
2104         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2105         (StatusBubble): Change the emoji to microscope emoji.
2106
2107 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2108
2109         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
2110         https://bugs.webkit.org/show_bug.cgi?id=201607
2111
2112         Reviewed by Jonathan Bedard.
2113
2114         * BuildSlaveSupport/ews-build/steps.py:
2115         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
2116         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
2117
2118 2019-09-07  Keith Miller  <keith_miller@apple.com>
2119
2120         OSR entry into wasm misses some contexts
2121         https://bugs.webkit.org/show_bug.cgi?id=201569
2122
2123         Reviewed by Yusuke Suzuki.
2124
2125         Add new test harness mode for tests created from wast files.
2126
2127         * Scripts/run-jsc-stress-tests:
2128
2129 2019-09-09  Daniel Bates  <dabates@apple.com>
2130
2131         Remove all selection view animations before dumping results
2132         https://bugs.webkit.org/show_bug.cgi?id=199241
2133
2134         Reviewed by Wenson Hsieh.
2135
2136         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
2137         historical tests that were written for Mac and expect Mac's lack of animations that we run on
2138         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
2139         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
2140         API for a test to remove selection animations at any time during the run.
2141
2142         * WebKitTestRunner/ios/TestControllerIOS.mm:
2143         (WTR::TestController::notifyDone):
2144
2145 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2146
2147         run-webkit-tests: Report results archive to results.webkit.org
2148         https://bugs.webkit.org/show_bug.cgi?id=201321
2149
2150         Reviewed by Aakash Jain.
2151
2152         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2153         (Manager.run): After all tests are finish, upload the results archive for each
2154         configuration.
2155         * Scripts/webkitpy/results/upload.py:
2156         (Upload):
2157         (Upload.__init__): Automatically define timestamp.
2158         (Upload.upload_archive): Upload an archive associated with the test run.
2159         * Scripts/webkitpy/results/upload_unittest.py:
2160         (UploadTest.test_buildbot):
2161         (UploadTest):
2162         (UploadTest.test_archive_upload):
2163
2164 2019-09-09  Chris Dumez  <cdumez@apple.com>
2165
2166         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
2167         https://bugs.webkit.org/show_bug.cgi?id=201590
2168
2169         Reviewed by Youenn Fablet.
2170
2171         Add a new API test to check that if the default session registers a service worker, the
2172         hasServiceWorkerRegistration flag is still false in an ephemeral session.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2175
2176 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2177
2178         results.webkit.org: mobile-sidebar-control should override button
2179         https://bugs.webkit.org/show_bug.cgi?id=201566
2180
2181         Rubber-stamped by Aakash Jain.
2182
2183         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2184         (@media screen and (min-width: 600px)):
2185         (.mobile-sidebar-control):
2186         (.mobile-sidebar-control.display):
2187
2188 2019-09-07  Chris Dumez  <cdumez@apple.com>
2189
2190         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
2191         https://bugs.webkit.org/show_bug.cgi?id=201574
2192
2193         Reviewed by Alex Christensen.
2194
2195         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
2196         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
2197         does not work well for WK2.
2198
2199         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2200
2201 2019-09-07  Chris Dumez  <cdumez@apple.com>
2202
2203         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
2204         https://bugs.webkit.org/show_bug.cgi?id=201547
2205
2206         Reviewed by Alex Christensen.
2207
2208         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
2209         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
2210         hack.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2213         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2214         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
2215         (TEST):
2216
2217 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2218
2219         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
2220         https://bugs.webkit.org/show_bug.cgi?id=200054
2221
2222         Reviewed by Carlos Garcia Campos.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2225         This test relied on the default data store having been instantiated.
2226
2227 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2228
2229         Remove calls to WKContextGetWebsiteDataStore missed in r249614
2230         https://bugs.webkit.org/show_bug.cgi?id=200050
2231
2232         * WebKitTestRunner/TestController.cpp:
2233         (WTR::TestController::resetPreferencesToConsistentValues):
2234         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2235         * WebKitTestRunner/TestInvocation.cpp:
2236         (WTR::TestInvocation::invoke):
2237
2238 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2239
2240         Remove invalid assertion added in r249614
2241         https://bugs.webkit.org/show_bug.cgi?id=200050
2242
2243         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2244         (WTR::TestController::cocoaResetStateToConsistentValues):
2245         Something is instantiating the default data store, which is no problem right now.
2246
2247 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
2248
2249         Unreviewed, rolling out r249353.
2250
2251         The test for this change is a flaky failure.
2252
2253         Reverted changeset:
2254
2255         "Add support for postMessage buffering between the service
2256         worker and window"
2257         https://bugs.webkit.org/show_bug.cgi?id=201169
2258         https://trac.webkit.org/changeset/249353
2259
2260 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2261
2262         Deprecate WKContextGetWebsiteDataStore
2263         https://bugs.webkit.org/show_bug.cgi?id=200050
2264
2265         Reviewed by Geoff Garen.
2266
2267         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2268         (WebKitBrowserWindow::updateProxySettings):
2269         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::TestController::generateContextConfiguration const):
2272         (WTR::TestController::websiteDataStore):
2273         (WTR::TestController::generatePageConfiguration):
2274         (WTR::TestController::resetStateToConsistentValues):
2275         (WTR::TestController::platformAdjustContext):
2276         (WTR::TestController::clearServiceWorkerRegistrations):
2277         (WTR::TestController::clearDOMCache):
2278         (WTR::TestController::clearDOMCaches):
2279         (WTR::TestController::ClearIndexedDatabases):
2280         (WTR::TestController::hasDOMCache):
2281         (WTR::TestController::domCacheSize):
2282         (WTR::TestController::setStatisticsDebugMode):
2283         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2284         (WTR::TestController::setStatisticsLastSeen):
2285         (WTR::TestController::setStatisticsPrevalentResource):
2286         (WTR::TestController::setStatisticsVeryPrevalentResource):
2287         (WTR::TestController::dumpResourceLoadStatistics):
2288         (WTR::TestController::isStatisticsPrevalentResource):
2289         (WTR::TestController::isStatisticsVeryPrevalentResource):
2290         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2291         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2292         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2293         (WTR::TestController::setStatisticsHasHadUserInteraction):
2294         (WTR::TestController::isStatisticsHasHadUserInteraction):
2295         (WTR::TestController::setStatisticsGrandfathered):
2296         (WTR::TestController::isStatisticsGrandfathered):
2297         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2298         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2299         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2300         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2301         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2302         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2303         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2304         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2305         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2306         (WTR::TestController::statisticsUpdateCookieBlocking):
2307         (WTR::TestController::statisticsSubmitTelemetry):
2308         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2309         (WTR::TestController::setStatisticsIsRunningTest):
2310         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2311         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2312         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2313         (WTR::TestController::setStatisticsGrandfatheringTime):
2314         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2315         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2316         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2317         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2318         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2319         (WTR::TestController::statisticsDeleteCookiesForHost):
2320         (WTR::TestController::isStatisticsHasLocalStorage):
2321         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2322         (WTR::TestController::statisticsResetToConsistentState):
2323         (WTR::TestController::setWebAuthenticationMockConfiguration):
2324         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2325         * WebKitTestRunner/TestController.h:
2326         * WebKitTestRunner/TestInvocation.cpp:
2327         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2328         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2329         (WTR::initializeWebViewConfiguration):
2330
2331 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2332
2333         Incorrect selection rect revealed after pasting images in a contenteditable element
2334         https://bugs.webkit.org/show_bug.cgi?id=201549
2335         <rdar://problem/50956429>
2336
2337         Reviewed by Simon Fraser.
2338
2339         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
2340         directly written to the pasteboard.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2343
2344 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2345
2346         Unreviewed, rolling out r249582.
2347
2348         This caused results.html fail to be created on internal
2349         testers.
2350
2351         Reverted changeset:
2352
2353         "run-webkit-test: Allow results to be uploaded without scm
2354         checkout"
2355         https://bugs.webkit.org/show_bug.cgi?id=200787
2356         https://trac.webkit.org/changeset/249582
2357
2358 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews-app] Status bubble should only display important messages in pop-over - part 2
2361         https://bugs.webkit.org/show_bug.cgi?id=201557
2362
2363         Reviewed by Jonathan Bedard.
2364
2365         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2366         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
2367
2368 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2369
2370         Deprecate all WKCookieManagerRef functions
2371         https://bugs.webkit.org/show_bug.cgi?id=201473
2372
2373         Reviewed by Chris Dumez.
2374
2375         Adopt replacement C API in WebKitTestRunner.
2376
2377         * TestWebKitAPI/CMakeLists.txt:
2378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2379         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
2380         * WebKitTestRunner/TestController.cpp:
2381         (WTR::TestController::resetPreferencesToConsistentValues):
2382         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2383         * WebKitTestRunner/TestInvocation.cpp:
2384         (WTR::TestInvocation::invoke):
2385         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2386         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2387         (WTR::initializeWebViewConfiguration):
2388
2389 2019-09-06  Tim Horton  <timothy_horton@apple.com>
2390
2391         Marking up a note on iOS results in a PDF with no contents
2392         https://bugs.webkit.org/show_bug.cgi?id=201530
2393         <rdar://problem/53686019>
2394
2395         Reviewed by Andy Estes.
2396
2397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2398         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
2399         Add some tests for WKWebViewPrintFormatter; specifically that it is
2400         possible to _recalcPageCount twice in quick succession, and that
2401         we don't hang if we start painting the printed content immediately
2402         after a Web Content process crash.
2403
2404 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2405
2406         run-webkit-test: Allow results to be uploaded without scm checkout
2407         https://bugs.webkit.org/show_bug.cgi?id=200787
2408
2409         Reviewed by Jonathan Bedard.
2410
2411         * Scripts/webkitpy/common/checkout/scm/detection.py:
2412         (SCMDetector.detect_scm_system): Added in detection of stub repository.
2413         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
2414         (StubRepository):
2415         (StubRepository.__init__):
2416         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
2417         find the directory containing the checkout_information.json of the stub repository.
2418         (StubRepository.in_working_directory): Required functions to be implemented.
2419         (StubRepository.svn_revision): Required functions to be implemented.
2420         (StubRepository.native_revision): Required functions to be implemented.
2421         (StubRepository.native_branch): Required functions to be implemented.
2422         (StubRepository._decode_json): Decodes checkout_information.json.
2423         (StubRepository.find_checkout_root): Required functions to be implemented.
2424         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
2425         (StubRepositoryTest): Unit test for stub_repository SCM.
2426         (StubRepositoryTest.mock_host_for_stub_repository):
2427         (StubRepositoryTest.test_in_working_directory):
2428         (StubRepositoryTest.test_native_revision):
2429         (StubRepositoryTest.test_native_branch):
2430         (StubRepositoryTest.test_svn_revision):
2431         (StubRepositoryTest.test_find_checkout_root):
2432         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2433         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
2434         * Scripts/webkitpy/port/base.py:
2435         (Port.commits_for_upload): Removed unnecessary scm initialization.
2436
2437 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2438
2439         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
2440         https://bugs.webkit.org/show_bug.cgi?id=201480
2441
2442         Reviewed by Youenn Fablet.
2443
2444         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2445         (WTR::InjectedBundle::beginTesting):
2446         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2447         (WTR::TestRunner::setPrivateBrowsingEnabled):
2448
2449 2019-09-06  Rob Buis  <rbuis@igalia.com>
2450
2451         Add runtime flag for lazy image loading
2452         https://bugs.webkit.org/show_bug.cgi?id=199794
2453
2454         Reviewed by Frédéric Wang.
2455
2456         Remove parts of r248409 that were meant for WK1 since
2457         lazy image loading is WK2 only.
2458
2459         * DumpRenderTree/TestOptions.cpp:
2460         (TestOptions::TestOptions):
2461         * DumpRenderTree/TestOptions.h:
2462         * DumpRenderTree/mac/DumpRenderTree.mm:
2463         (enableExperimentalFeatures):
2464         (setWebPreferencesForTestOptions):
2465         * DumpRenderTree/win/DumpRenderTree.cpp:
2466         (enableExperimentalFeatures):
2467
2468 2019-09-05  Chris Dumez  <cdumez@apple.com>
2469
2470         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2471         https://bugs.webkit.org/show_bug.cgi?id=201519
2472
2473         Reviewed by Alex Christensen.
2474
2475         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2476         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
2477         TestOption::useEphemeralSession flag based on the test folder.
2478
2479         * DumpRenderTree/mac/DumpRenderTree.mm:
2480         (shouldUseEphemeralSession):
2481         (runTest):
2482         * WebKitTestRunner/TestOptions.cpp:
2483         (WTR::shouldUseEphemeralSession):
2484         (WTR::TestOptions::TestOptions):
2485
2486 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2487
2488         [Win] Support Per-Monitor (V2) DPI Awareness
2489         https://bugs.webkit.org/show_bug.cgi?id=201450
2490
2491         Reviewed by Don Olmstead.
2492
2493         * MiniBrowser/win/MainWindow.cpp:
2494         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
2495         * MiniBrowser/win/WinMain.cpp:
2496         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
2497
2498 2019-09-05  Chris Dumez  <cdumez@apple.com>
2499
2500         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
2501         https://bugs.webkit.org/show_bug.cgi?id=201440
2502         <rdar://problem/54998427>
2503
2504         Reviewed by Alex Christensen.
2505
2506         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
2507         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
2508         created in the WebContent process is the one that is currently running the test and that we want to talk to.
2509         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
2510
2511         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2512         (WTR::InjectedBundle::page const):
2513
2514 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2515
2516         results.webkit.org: Assign notifyRerender before calling
2517         https://bugs.webkit.org/show_bug.cgi?id=201510
2518
2519         Reviewed by Aakash Jain.
2520
2521         Timelines should define notifyRerender to an empty function,
2522         rename notifiyRerender to notifyRerender.
2523
2524         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2525         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2526         * resultsdbpy/resultsdbpy/view/templates/search.html:
2527         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2528
2529 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2530
2531         results.webkit.org: Fix prepending search result on empty list 
2532         https://bugs.webkit.org/show_bug.cgi?id=201512
2533
2534         Reviewed by Aakash Jain.
2535
2536         * resultsdbpy/resultsdbpy/view/templates/search.html:
2537
2538 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2539
2540         results.webkit.org: Retain certain parameters when following menu links
2541         https://bugs.webkit.org/show_bug.cgi?id=201463
2542
2543         Rubber-stamped by Aakash Jain.
2544
2545         * resultsdbpy/resultsdbpy/view/site_menu.py:
2546         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
2547         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
2548         retain the specified parameters
2549         * resultsdbpy/resultsdbpy/view/view_routes.py:
2550         (ViewRoutes.__init__):
2551
2552 2019-09-05  Chris Dumez  <cdumez@apple.com>
2553
2554         [WK2] Add proper layout test support for ephemeral sessions
2555         https://bugs.webkit.org/show_bug.cgi?id=201475
2556
2557         Reviewed by Antti Koivisto.
2558
2559         Add proper layout test support for ephemeral sessions via:
2560         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
2561
2562         This actually creates a new WebView using an ephemeral data store to load the test which
2563         is *true* private browsing.
2564
2565         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
2566         process, which is a hack and does not truly enable private browsing because the UIProcess and
2567         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
2568         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
2569         get rid of it.
2570
2571         Note that WK2 does not support using a WebContent process for different sessions / data stores.
2572         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
2573         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
2574         simply to support testRunner.setPrivateBrowsingEnabled().
2575
2576         * DumpRenderTree/TestOptions.cpp:
2577         (TestOptions::TestOptions):
2578         * DumpRenderTree/TestOptions.h:
2579         * DumpRenderTree/TestRunner.cpp:
2580         (TestRunner::staticFunctions):
2581         * DumpRenderTree/mac/DumpRenderTree.mm:
2582         (setWebPreferencesForTestOptions):
2583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2585         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
2586         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2587         * WebKitTestRunner/TestController.cpp:
2588         (WTR::TestController::generatePageConfiguration):
2589         (WTR::updateTestOptionsFromTestHeader):
2590         * WebKitTestRunner/TestOptions.h:
2591         (WTR::TestOptions::hasSameInitializationOptions const):
2592         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2593         (WTR::TestController::platformCreateWebView):
2594
2595 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
2596
2597         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
2598         https://bugs.webkit.org/show_bug.cgi?id=201490
2599
2600         Reviewed by Daniel Bates.
2601
2602         Added a test.
2603
2604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2605         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2606         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
2607
2608 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         Remove unused SPI that accesses MemoryCache directly
2611         https://bugs.webkit.org/show_bug.cgi?id=201468
2612
2613         Reviewed by Youenn Fablet.
2614
2615         Removed the API test.
2616
2617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2618         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
2619
2620 2019-09-04  Timothy Hatcher  <timothy@apple.com>
2621
2622         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
2623         https://bugs.webkit.org/show_bug.cgi?id=201368
2624         rdar://problem/40529867
2625
2626         Reviewed by Ryosuke Niwa.
2627
2628         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
2629             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
2630
2631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2632         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2633         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
2634         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2635         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
2636         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
2637         * TestWebKitAPI/cocoa/TestWKWebView.h:
2638         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2639         (-[TestWKWebView forceDarkMode]):
2640
2641 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2642
2643         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
2644         https://bugs.webkit.org/show_bug.cgi?id=201479
2645         <rdar://problem/51511834>
2646
2647         Reviewed by Tim Horton.
2648
2649         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2652         * TestWebKitAPI/ios/UIKitSPI.h:
2653
2654 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2655
2656         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
2657         https://bugs.webkit.org/show_bug.cgi?id=201471
2658         <rdar://problem/55039227>
2659
2660         Reviewed by Tim Horton.
2661
2662         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
2663         selected.
2664
2665         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/ios/UIKitSPI.h:
2668
2669 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
2670
2671         results.webkit.org: Fix mobile vs desktop mode
2672         https://bugs.webkit.org/show_bug.cgi?id=201441
2673
2674         Rubber-stamped by Aakash Jain.
2675
2676         We should unconditionally use desktop mode if the device screen-width
2677         is large enough.
2678
2679         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2680
2681 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
2682
2683         run-api-tests: Add support for specifying additional environment variables
2684         https://bugs.webkit.org/show_bug.cgi?id=201311
2685         <rdar://problem/54852698>
2686
2687         Reviewed by Daniel Bates.
2688
2689         * Scripts/webkitpy/api_tests/run_api_tests.py:
2690         (parse_args): Add --additional-env-var flag.
2691         * Scripts/webkitpy/port/base.py:
2692         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
2693         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
2694         environment.
2695
2696 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
2697
2698         EWS bubbles should indicate builder vs tester
2699         https://bugs.webkit.org/show_bug.cgi?id=201253
2700
2701         Reviewed by Jonathan Bedard.
2702
2703         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2704         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
2705         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
2706         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
2707         (StatusBubble.get):
2708         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2709         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
2710         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
2711         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2712         (FetchLoop.run): Update the icons for queues mapping.
2713         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
2714         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
2715         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
2716         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
2717
2718 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
2719
2720         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
2721         https://bugs.webkit.org/show_bug.cgi?id=201448
2722
2723         Reviewed by Mark Lam.
2724
2725         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2726         (TEST):
2727
2728 2019-09-03  Dean Jackson  <dino@apple.com>
2729
2730         Test for ContextMenus with images
2731         https://bugs.webkit.org/show_bug.cgi?id=201437
2732
2733         Reviewed by Wenson Hsieh.
2734
2735         Add a test for ContextMenus that trigger on images, and make
2736         sure that they ask for alternate URLs (added in r249171).
2737
2738         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2739         (contextMenuWebViewDriver):
2740         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
2741         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
2742         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
2743         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
2744         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
2745         (TEST):
2746
2747 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
2748
2749         results.webkit.org: Move legend into sidebar
2750         https://bugs.webkit.org/show_bug.cgi?id=201258
2751
2752         Rubber-stamped by Aakash Jain.
2753
2754         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
2755         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
2756         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
2757         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2758         (isPointInElement): Make bound check include borders.
2759         (_ToolTip.toString): Add left/right cases.
2760         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
2761         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
2762         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2763
2764 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
2765
2766         results.webkit.org: Increase default limit for LimitSlider
2767         https://bugs.webkit.org/show_bug.cgi?id=201424
2768
2769         Reviewed by Aakash Jain.
2770
2771         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2772         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
2773
2774 2019-09-03  Antoine Quint  <graouts@apple.com>
2775
2776         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
2777         https://bugs.webkit.org/show_bug.cgi?id=201420
2778         <rdar://problem/53207786>
2779
2780         Reviewed by Simon Fraser.
2781
2782         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
2783         -[HIDEventGenerator twoFingerTap:completionBlock:].
2784
2785         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2786         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2787         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
2788         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2789         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2790         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
2791
2792 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
2793
2794         [WPE] MiniBrowser should handle the WebKitWebView::create signal
2795         https://bugs.webkit.org/show_bug.cgi?id=201417
2796
2797         Reviewed by Carlos Garcia Campos.
2798
2799         WPE's MiniBrowser should connect to and handle the
2800         WebKitWebView::create signal, constructing a new bit related
2801         WebKitWebView object upon invocation.
2802
2803         * MiniBrowser/wpe/main.cpp:
2804         (webViewClose):
2805         (createWebView):
2806         (main):
2807
2808 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
2809
2810         [WPE] Make view backends multi-view-friendly
2811         https://bugs.webkit.org/show_bug.cgi?id=201415
2812
2813         Reviewed by Carlos Garcia Campos.
2814
2815         Have the Wayland EGL connection for WindowViewBackend instances managed
2816         through a per-process singleton, allowing multiple backend objects
2817         use it for different views. HeadlessViewBackend already does this, but
2818         the code there is refurbished into a singleton structure.
2819
2820         The ViewBackend classes are adjusted to work with the backend-specific
2821         EGLDisplay objects (as constructed through the backend-specific EGL
2822         connection approach).
2823
2824         * wpe/backends/HeadlessViewBackend.cpp:
2825         (WPEToolingBackends::HeadlessEGLConnection::singleton):
2826         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
2827         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
2828         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
2829         (WPEToolingBackends::getEGLDisplay): Deleted.
2830         * wpe/backends/ViewBackend.cpp:
2831         (WPEToolingBackends::ViewBackend::initialize):
2832         (WPEToolingBackends::ViewBackend::deinitialize):
2833         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
2834         * wpe/backends/ViewBackend.h:
2835         * wpe/backends/WindowViewBackend.cpp:
2836         (WPEToolingBackends::WaylandEGLConnection::singleton):
2837         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
2838         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
2839         (WPEToolingBackends::WindowViewBackend::displayBuffer):
2840
2841 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2842
2843         [WPE][GTK] Deprecate nonfunctional process limit APIs
2844         https://bugs.webkit.org/show_bug.cgi?id=193749
2845
2846         Reviewed by Žan Doberšek.
2847
2848         * MiniBrowser/gtk/main.c:
2849         (main):
2850         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2851         (beforeAll):
2852         (testWebProcessLimit): Deleted.
2853
2854 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
2855
2856         [WPE] WindowBackend should do resizing properly
2857         https://bugs.webkit.org/show_bug.cgi?id=201386
2858
2859         Reviewed by Carlos Garcia Campos.
2860
2861         The WindowBackend implementation is resized via the XDG protocol. The
2862         initial size is stored for the object's lifetime and fallen back to when
2863         the XDG protocol reports (0,0) configuration size.
2864
2865         Upon each resize, we have to recreate the texture. We also have to size
2866         the GL viewport accordingly.
2867
2868         * wpe/backends/WindowViewBackend.cpp:
2869         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
2870         (WPEToolingBackends::WindowViewBackend::createViewTexture):
2871         (WPEToolingBackends::WindowViewBackend::resize):
2872         (WPEToolingBackends::WindowViewBackend::displayBuffer):
2873         * wpe/backends/WindowViewBackend.h:
2874
2875 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
2876
2877         Unreviewed, rolling out r249366.
2878
2879         WinCairo WebKit2 crashes in some websites and the device scale
2880         factor is not correct in high DPI.
2881
2882         Reverted changeset:
2883
2884         "[WinCairo, FTW] Properly handle device scale factor"
2885         https://bugs.webkit.org/show_bug.cgi?id=201361
2886         https://trac.webkit.org/changeset/249366
2887
2888 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2889
2890         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
2891         https://bugs.webkit.org/show_bug.cgi?id=201346
2892         <rdar://problem/54885784>
2893
2894         Reviewed by Dean Jackson.
2895
2896         Add a new test option to allow tests to disable link previews.
2897
2898         * WebKitTestRunner/TestController.cpp:
2899         (WTR::updateTestOptionsFromTestHeader):
2900         * WebKitTestRunner/TestOptions.h:
2901
2902         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
2903
2904         (WTR::TestOptions::hasSameInitializationOptions const):
2905         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2906         (WTR::TestController::platformCreateWebView):
2907
2908 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
2909
2910         [WinCairo, FTW] Properly handle device scale factor
2911         https://bugs.webkit.org/show_bug.cgi?id=201361
2912
2913         Reviewed by Don Olmstead.
2914
2915         Reset zoom to 1.0; device scale is handled elsewhere.
2916
2917         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2918         (WebKitBrowserWindow::resetZoom):
2919
2920 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
2921
2922         [results.webkit.org Timeline] Add notify rerender API for timeline
2923         https://bugs.webkit.org/show_bug.cgi?id=201363
2924
2925         Reviewed by Jonathan Bedard.
2926
2927         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
2928         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2929         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
2930         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
2931         (prototype.Timeline.CanvasContainer):
2932
2933 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
2934
2935         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
2936         https://bugs.webkit.org/show_bug.cgi?id=201350
2937
2938         Reviewed by Jonathan Bedard.
2939
2940         * BuildSlaveSupport/ews-build/steps.py:
2941         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
2942         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
2943
2944 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
2945
2946         results.webkit.org: Add endpoints to upload and download archives
2947         https://bugs.webkit.org/show_bug.cgi?id=201100
2948
2949         Reviewed by Aakash Jain.
2950
2951         Add the endpoint to upload and download a zip archive associated with a test run.
2952
2953         * resultsdbpy/resultsdbpy/controller/api_routes.py:
2954         (APIRoutes.__init__): Add archive endpoint.
2955         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
2956         (ArchiveController):
2957         (ArchiveController.__init__):
2958         (ArchiveController.endpoint):
2959         (ArchiveController.download):
2960         (ArchiveController.upload):
2961         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
2962         (ArchiveControllerUnittest):
2963         * resultsdbpy/resultsdbpy/model/configuration_context.py:
2964         (ClusteredByConfiguration.register_configuration): Make error message more clear.
2965
2966 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
2967
2968         Add system tracing points for compositing updates, and touch-event dispatching
2969         https://bugs.webkit.org/show_bug.cgi?id=201327
2970
2971         Reviewed by Alex Christensen.
2972
2973         * Tracing/SystemTracePoints.plist:
2974
2975 2019-08-30  Keith Rollin  <krollin@apple.com>
2976
2977         Simplify PLATFORM expression
2978         https://bugs.webkit.org/show_bug.cgi?id=201286
2979         <rdar://problem/54822347>
2980
2981         Reviewed by Alexey Proskuryakov.
2982
2983         The preprocessor expression conditionalizing the inclusion of the body
2984         of ExitFullscreenOnEnterPiP.mm evolved into:
2985
2986             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
2987
2988         Simplify this to just:
2989
2990             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2993
2994 2019-08-30  Keith Rollin  <krollin@apple.com>
2995
2996         Remove AppKitCompatibilityDeclarations.h
2997         https://bugs.webkit.org/show_bug.cgi?id=201283
2998         <rdar://problem/54822042>
2999
3000         Reviewed by Alexey Proskuryakov.
3001
3002         The two copies of these files -- on in WTF, one in MiniBrowser -- are
3003         empty and can be removed.
3004
3005         * DumpRenderTree/mac/EventSendingController.mm:
3006         * DumpRenderTree/mac/TextInputControllerMac.m:
3007         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
3008         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3009         * MiniBrowser/mac/SettingsController.m:
3010         * MiniBrowser/mac/WK1BrowserWindowController.m:
3011         * MiniBrowser/mac/WK2BrowserWindowController.m:
3012         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3013         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3014         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3015         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3016         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
3017         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
3018         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3019         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3020         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3021         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
3022         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3023         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3024         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
3025         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3026         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3027         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3028         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3029         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3030         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3031         * WebKitTestRunner/mac/EventSenderProxy.mm:
3032         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3033         * WebKitTestRunner/mac/TestControllerMac.mm:
3034
3035 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
3036
3037         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
3038         https://bugs.webkit.org/show_bug.cgi?id=200479
3039
3040         Reviewed by Carlos Garcia Campos.
3041
3042         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3043         (testUserContentManagerContentFilter): Test also the new
3044         webkit_user_content_manager_remove_filter_by_id() public API function.
3045
3046 2019-08-30  Philippe Normand  <pnormand@igalia.com>
3047
3048         [WPE][Qt] loadingChanged signal parameter is unusable
3049         https://bugs.webkit.org/show_bug.cgi?id=201301
3050
3051         Reviewed by Carlos Garcia Campos.
3052
3053         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
3054         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
3055         readablity/parameter_name code styl checker rule.
3056
3057 2019-08-29  Keith Rollin  <krollin@apple.com>
3058
3059         Update .xcconfig symbols to reflect the current set of past and future product versions.
3060         https://bugs.webkit.org/show_bug.cgi?id=200720
3061         <rdar://problem/54305032>
3062
3063         Reviewed by Alex Christensen.
3064
3065         Remove version symbols related to old OS's we no longer support,
3066         ensure that version symbols are defined for OS's we do support.
3067
3068         * ContentExtensionTester/Configurations/Base.xcconfig:
3069         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3070         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3071         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3072         * ImageDiff/cg/Configurations/Base.xcconfig:
3073         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3074         * MiniBrowser/Configurations/Base.xcconfig:
3075         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3076         * TestWebKitAPI/Configurations/Base.xcconfig:
3077         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3078         * WebEditingTester/Configurations/Base.xcconfig:
3079         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3080         * WebKitTestRunner/Configurations/Base.xcconfig:
3081         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3082         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3083         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3084
3085 2019-08-29  Keith Rollin  <krollin@apple.com>
3086
3087         Remove empty FontCache.cpp file in TestWebKitAPI
3088         https://bugs.webkit.org/show_bug.cgi?id=201277
3089         <rdar://problem/54820726>
3090
3091         Reviewed by Alex Christensen.
3092
3093         Bug 200694 emptied out the contents of FontCache.cpp. This patch
3094         removes the file from the project.
3095
3096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3097         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
3098
3099 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
3100
3101         [ews-app] Status bubble should only display important messages in pop-over
3102         https://bugs.webkit.org/show_bug.cgi?id=201308
3103
3104         Reviewed by Jonathan Bedard.
3105
3106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
3107         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
3108
3109 2019-08-29  Keith Rollin  <krollin@apple.com>
3110
3111         Remove support for macOS < 10.13 (part 3)
3112         https://bugs.webkit.org/show_bug.cgi?id=201224
3113         <rdar://problem/54795934>
3114
3115         Reviewed by Darin Adler.
3116
3117         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
3118         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
3119         like _MACOS_SINCE_1013.
3120
3121         Also added some macOS target numbers.
3122
3123         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
3124
3125 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
3126
3127         results.webkit.org: Remove border from tooltip
3128         https://bugs.webkit.org/show_bug.cgi?id=201239
3129
3130         Reviewed by Alex Christensen.
3131
3132         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
3133         (.tooltip-content): Remove border.
3134
3135 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3136
3137         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
3138         https://bugs.webkit.org/show_bug.cgi?id=201215
3139
3140         Reviewed by Don Olmstead.
3141
3142         MiniBrowser crashed if it was going to go to a unreachable page
3143         because WKPageCopyActiveURL returned a nullptr.
3144
3145         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3146         (createString): Added null checking of the argument.
3147
3148 2019-08-28  Tim Horton  <timothy_horton@apple.com>
3149
3150         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
3151         https://bugs.webkit.org/show_bug.cgi?id=201256
3152         <rdar://problem/54809509>
3153
3154         Reviewed by Simon Fraser.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3157         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
3158         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
3159         (TestWebKitAPI::TEST):
3160         Add a test. I left many comments because I had a great deal of trouble
3161         writing this test and wanted to document my findings.
3162
3163 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3164
3165         results.webkit.org: Do not display branch selector if only one branches available
3166         https://bugs.webkit.org/show_bug.cgi?id=201244
3167
3168         Rubber-stamped by Aakash Jain.
3169
3170         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
3171         container if there aren't multiple branches to choose from.
3172
3173 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3174
3175         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
3176         https://bugs.webkit.org/show_bug.cgi?id=201241
3177         <rdar://problem/54317588>
3178
3179         Reviewed by Tim Horton.
3180
3181         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
3182         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
3183         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
3184         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
3185         it believes that the web view has rejected the drop from being handled.
3186
3187         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
3188         to make sure that the web process has had time to send a response after each update.
3189
3190         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3191         (-[DragAndDropSimulator _advanceProgress]):
3192
3193 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
3194
3195         Null check webFrame when creating a print preview to prevent a crash.
3196         https://bugs.webkit.org/show_bug.cgi?id=201237
3197         <rdar://problem/51618863>
3198
3199         Reviewed by Tim Horton.
3200
3201         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3204         (TEST):
3205
3206 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3207
3208         results.webkit.org: Move drawer to the right, open by default
3209         https://bugs.webkit.org/show_bug.cgi?id=200977
3210
3211         Rubber-stamped by Aakash Jain.
3212
3213         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
3214         moving the drawer to the right side of the screen, opening it by default and have it displace
3215         instead of hide the main content.
3216
3217         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
3218         (CommitViewUnittest.test_drawer): Support new drawer style.
3219         (CommitViewUnittest.test_range_slider): Ditto.
3220         (CommitViewUnittest.test_one_line_switch): Ditto.
3221         (CommitViewUnittest.test_branch_selection): Ditto.
3222         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
3223         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3224         (setEnableRecursive): Disable all elements underneath this one 
3225         (Drawer): Make drawer a sidebar.
3226         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3227         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
3228         (:root): Move boldInverseColor into webkit.css.
3229         (@media (prefers-color-scheme: dark)):
3230         (.sidebar): Sidebars on mobile should behave like drawers.
3231         (.sidebar.hidden): Add concept of hidden sidebar.
3232         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
3233         (.mobile-sidebar-control.display):
3234         (.main.under-topbar-with-actions):
3235         (@media screen and (min-width: 600px) and (orientation: landscape)):
3236         (.sidebar.left.hidden):
3237         (.sidebar.right.hidden):
3238         (.main.right.hidden):
3239         (.main.left.hidden):
3240         (@media screen and (min-width: 768px) and (orientation: landscape)):
3241         (.sidebar.right):
3242         (a.disabled): Add ability to disable a link.
3243         (.desktop-control): Add a control which only exists on desktop.
3244         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
3245         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
3246         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
3247         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
3248         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
3249         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3250         (WebSiteTestCase.toggle_drawer): Support new drawer style.
3251         (WebSiteTestCase.find_input_with_name): Ditto.
3252
3253 2019-08-28  Keith Rollin  <krollin@apple.com>
3254
3255         Remove support for macOS < 10.13 (part 2)
3256         https://bugs.webkit.org/show_bug.cgi?id=201197
3257         <rdar://problem/54759985>
3258
3259         Reviewed by Darin Adler.
3260
3261         Update conditionals that reference WK_MACOS_1013 and suffixes like
3262         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
3263         later and that these conditionals are always True or False.
3264
3265         See Bug 200694 for earlier changes in this area.
3266
3267         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3268
3269 2019-08-28  Alicia Boya García  <aboya@igalia.com>
3270
3271         [MSE][GStreamer] WebKitMediaSrc rework
3272         https://bugs.webkit.org/show_bug.cgi?id=199719
3273
3274         Reviewed by Xabier Rodriguez-Calvar.
3275
3276         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
3277         whitelist.
3278
3279         * Scripts/webkitpy/style/checker.py:
3280
3281 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
3282
3283         Updating inactive contributors in contributors.json.
3284
3285         * Scripts/webkitpy/common/config/contributors.json:
3286
3287 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3288
3289         results.webkit.org: Auto-expand single configurations
3290         https://bugs.webkit.org/show_bug.cgi?id=201218
3291
3292         Rubber-stamped by Aakash Jain.
3293
3294         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3295         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
3296         configuration has been specified.
3297         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3298         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
3299         is expanded or collapsed by default.
3300
3301 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
3302
3303         results.webkit.org: Sanitize all commit arguments on upload
3304         https://bugs.webkit.org/show_bug.cgi?id=201189
3305         <rdar://problem/54564837>
3306
3307         Reviewed by Aakash Jain.
3308
3309         * resultsdbpy/resultsdbpy/controller/commit.py:
3310         (Commit.__init__): Only allow commits to be constructed with valid values.
3311         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
3312         (CommitController.register): Strip potential API key.
3313         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
3314         (CommitUnittest.test_invalid): Test that commits which contain html inside the
3315         repository_id, branch or commit id are rejected.
3316
3317 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
3318
3319         [GTK][WPE] Implement HSTS for the soup network backend
3320         https://bugs.webkit.org/show_bug.cgi?id=192074
3321
3322         Reviewed by Carlos Garcia Campos.
3323
3324         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
3325         Add support to the soup network backend by adding the feature to
3326         SoupNetworkSession and handling HSTS protocol upgrades, by
3327         propagating the scheme change further to clients. This patch adds
3328         the HSTS feature unconditionally, but it still possible to add
3329         a boolean property to the web context class if desired.
3330
3331         Additionally, add API to the WebKitWebsiteDataManager to specify
3332         the directory where the HSTS database is saved. If the directory
3333         is not set or if the data manager is ephemeral, use a
3334         non-persistent, memory only HSTS enforcer.
3335
3336         Implement as well the methods needed to clean-up and delete HSTS
3337         policies from the storage and expose the feature in GTK+
3338         MiniBrowser's about:data.
3339
3340         * MiniBrowser/gtk/main.c:
3341         (gotWebsiteDataCallback):
3342         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3343         (serverCallback):
3344         (testWebsiteDataConfiguration):
3345         (testWebsiteDataEphemeral):
3346         (prepopulateHstsData):
3347         (testWebsiteDataHsts):
3348         (beforeAll):
3349         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3350         (Test::Test):
3351         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
3352         * wpe/jhbuild.modules: Ditto
3353         * MiniBrowser/gtk/main.c:
3354         (gotWebsiteDataCallback):
3355
3356 2019-08-27  James Darpinian  <jdarpinian@google.com>
3357
3358         Fix applying diffs that only change file mode
3359         https://bugs.webkit.org/show_bug.cgi?id=201191
3360
3361         Reviewed by Daniel Bates.
3362
3363         * Scripts/svn-apply:
3364         (patch): Handle case of file mode change without content change
3365
3366 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
3367
3368         [ews] Status bubble should be red for CANCELLED builds
3369         https://bugs.webkit.org/show_bug.cgi?id=201204
3370
3371         Reviewed by Jonathan Bedard.
3372
3373         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3374         (StatusBubble._build_bubble):
3375
3376 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
3377
3378         [results.webkit.org Webkit.css] Center the legend symbols
3379         https://bugs.webkit.org/show_bug.cgi?id=201187
3380
3381         Reviewed by Jonathan Bedard.
3382
3383         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3384         (.lengend>.item .dot .text): center the dot symbol vertically
3385
3386 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
3387
3388         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
3389         https://bugs.webkit.org/show_bug.cgi?id=201000
3390         <rdar://problem/53778938>
3391
3392         Unreviewed follow-up fix.
3393
3394         * Scripts/webkitpy/port/darwin.py:
3395         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
3396         spindump call failed.
3397         * Scripts/webkitpy/port/darwin_testcase.py:
3398         * Scripts/webkitpy/port/ios_device_unittest.py:
3399
3400 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
3401
3402         [ews-build] Use update-webkit script in Apply-WatchList EWS
3403         https://bugs.webkit.org/show_bug.cgi?id=201179
3404
3405         Reviewed by Jonathan Bedard.
3406
3407         * BuildSlaveSupport/ews-build/factories.py:
3408         (WatchListFactory): Updated to use CheckOutSource step as well.
3409
3410 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3411
3412         W3C test importer should be able to handle expected references with an absolute path.
3413         https://bugs.webkit.org/show_bug.cgi?id=200717
3414
3415         Reviewed by Youenn Fablet.
3416
3417         This patch implements the logic to resolve test references with absolute paths
3418         when importing w3c tests (like web-platform-tests).
3419         When an absolute path is found for a test reference, the parser now
3420         tries to find the right file by looking for a relative path inside
3421         the root directory of the source test repository.
3422         It works when the tool is run in download-mode as well as when the
3423         tool is run to import the tests from a local directory.
3424
3425         This fixes the import of test references for tests like
3426         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
3427
3428         * Scripts/webkitpy/w3c/test_importer.py:
3429         (TestImporter._source_root_directory_for_path):
3430         (TestImporter.find_importable_tests):
3431         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3432         (TestImporterTest.import_directory):
3433         (test_webkit_test_runner_options):
3434         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
3435         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
3436         * Scripts/webkitpy/w3c/test_parser.py:
3437         (TestParser.__init__):
3438         (TestParser.analyze_test):
3439
3440 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3441
3442         Remove UIHelper.activateElementAtHumanSpeed
3443         https://bugs.webkit.org/show_bug.cgi?id=201147
3444
3445         Reviewed by Tim Horton.
3446
3447         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
3448         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
3449         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
3450
3451         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3452         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3453         (WTR::UIScriptController::doAfterDoubleTapDelay):
3454         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3455         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3456         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
3457
3458 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
3459
3460         [results.webkit.org Timline] Add symbols to the timeline dot
3461         https://bugs.webkit.org/show_bug.cgi?id=201105
3462
3463         Reviewed by Jonathan Bedard.
3464
3465         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3466         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3467         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
3468         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
3469
3470 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
3471
3472         Unreviewed, remove useMaximalFlushInsertionPhase use
3473         https://bugs.webkit.org/show_bug.cgi?id=201036
3474
3475         * Scripts/run-jsc-stress-tests:
3476
3477 2019-08-26  David Kilzer  <ddkilzer@apple.com>
3478
3479         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
3480         <https://webkit.org/b/201144>
3481         <rdar://problem/54689399>
3482
3483         Reviewed by Brent Fulgham.
3484
3485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
3486         DataDetectorsTestIOS.mm to the project.
3487         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
3488         test for Data Detectors for phone numbers.
3489
3490 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3491
3492         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
3493         https://bugs.webkit.org/show_bug.cgi?id=201129
3494         <rdar://problem/51857277>
3495
3496         Reviewed by Tim Horton.
3497
3498         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
3499         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
3500         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
3501         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
3502         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
3503         capable of recognizing further touches yet.
3504
3505         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
3506         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
3507         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
3508         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
3509         allows both of them to be reset.
3510
3511         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
3512         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
3513         immediately after sending the first tap. This change in dependencies is caused by the introduction of
3514         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
3515         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
3516         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
3517         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
3518
3519         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
3520         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
3521         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
3522         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
3523         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
3524         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
3525         requiring arbitrary 120 ms "human speed" delays.
3526
3527         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
3528
3529         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3530         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3531         (WTR::UIScriptController::doubleTapAtPoint):
3532
3533         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
3534         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
3535         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
3536         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
3537         recognized only as a single tap instead of a double tap.
3538
3539         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
3540         gestures use instead to wait after simulating the first tap.
3541
3542         * WebKitTestRunner/ios/HIDEventGenerator.h:
3543         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3544         (-[HIDEventGenerator _waitFor:]):
3545         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
3546
3547         Plumb the tap gesture delay through to this helper method.
3548
3549         (-[HIDEventGenerator tap:completionBlock:]):
3550         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
3551         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
3552         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
3553         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
3554         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3555         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3556         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
3557
3558         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
3559         attempting to simulate single taps (either using a stylus, or with a regular touch).
3560
3561         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3562         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
3563         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
3564
3565 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
3566
3567         results.webkit.org: Allow clicking on the tooltip arrow
3568         https://bugs.webkit.org/show_bug.cgi?id=201103
3569
3570         Rubber-stamped by Aakash Jain.
3571
3572         By design, the arrow sits above the canvas and intercepts mouse events from it.
3573         This will often make an element that has a tooltip unclickable.
3574
3575         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3576         (xAxisFromScale):
3577         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
3578         (TimelineFromEndpoint.prototype.render):
3579         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3580         (_ToolTip):
3581         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
3582         (_ToolTip.prototype.set): Set the onClick callback.
3583
3584 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
3585
3586         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
3587         https://bugs.webkit.org/show_bug.cgi?id=201140
3588
3589         Reviewed by Jonathan Bedard.
3590
3591         * BuildSlaveSupport/ews-build/steps.py:
3592         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
3593         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3594
3595 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
3596
3597         run-webkit-tests: Cap the number of automatically booted simulators at 12
3598         https://bugs.webkit.org/show_bug.cgi?id=201139
3599
3600         Reviewed by Aakash Jain.
3601
3602         To make local development with simulators more pleasant, machines should
3603         never automatically boot more than 12 simulators.
3604
3605         * Scripts/webkitpy/xcode/simulated_device.py:
3606         (SimulatedDeviceManager.max_supported_simulators):
3607
3608 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews] Add EWS queue for applying watchlist
3611         https://bugs.webkit.org/show_bug.cgi?id=201072
3612
3613         Reviewed by Jonathan Bedard.
3614
3615         * BuildSlaveSupport/ews-build/steps.py:
3616         (ApplyWatchList): Build step to apply watchlist.
3617         (ApplyWatchList.__init__): Set logEnviron to False.
3618         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
3619         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3620         * BuildSlaveSupport/ews-build/factories.py:
3621         (WatchListFactory): Build factory for WatchList.
3622         * BuildSlaveSupport/ews-build/loadConfig.py:
3623         * BuildSlaveSupport/ews-build/config.json:
3624
3625 2019-08-26  Youenn Fablet  <youenn@apple.com>
3626
3627         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
3628         https://bugs.webkit.org/show_bug.cgi?id=196870
3629
3630         Reviewed by Alex Christensen.
3631
3632         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
3633         Accept any server certificate by default.
3634
3635         * WebKitTestRunner/TestController.cpp:
3636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3637         (WTR::TestController::cocoaResetStateToConsistentValues):
3638         (WTR::TestController::setAllowsAnySSLCertificate):
3639         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
3640         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3641         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
3642         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
3643
3644 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
3645
3646         Increase log level for watchlist result
3647         https://bugs.webkit.org/show_bug.cgi?id=201081
3648
3649         Reviewed by Jonathan Bedard.
3650
3651         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
3652         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
3653         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
3654
3655 2019-08-23  Chris Dumez  <cdumez@apple.com>
3656
3657         [geolocation] Rename interfaces and remove [NoInterfaceObject]
3658         https://bugs.webkit.org/show_bug.cgi?id=200885
3659
3660         Reviewed by Alex Christensen.
3661
3662         * DumpRenderTree/mac/TestRunnerMac.mm:
3663         (TestRunner::setMockGeolocationPosition):
3664
3665 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
3666
3667         Unreviewed, rolling out r249001.
3668
3669         Caused one layout test to fail on all configurations and
3670         another to time out on Catalina / iOS 13.
3671
3672         Reverted changeset:
3673
3674         "Add a WebsiteDataStore delegate to handle
3675         AuthenticationChallenge that do not come from pages"
3676         https://bugs.webkit.org/show_bug.cgi?id=196870
3677         https://trac.webkit.org/changeset/249001
3678
3679 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
3680
3681         results.webkit.org: Escape html in changelog
3682         https://bugs.webkit.org/show_bug.cgi?id=201025
3683         <rdar://problem/54564837>
3684
3685         Reviewed by Darin Adler.
3686
3687         * resultsdbpy/resultsdbpy/view/commit_view.py:
3688         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
3689         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
3690         directly into a JavaScript dictionary.
3691
3692 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
3693
3694         [WebAuthn] Support NFC authenticators for iOS
3695         https://bugs.webkit.org/show_bug.cgi?id=188624
3696         <rdar://problem/43354214>
3697
3698         Reviewed by Chris Dumez.
3699
3700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3701         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3702         Setup NFC mock testing configuration.
3703
3704 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
3705
3706         [ews] Enable Style queue on new EWS
3707         https://bugs.webkit.org/show_bug.cgi?id=201071
3708
3709         Reviewed by Jonathan Bedard.
3710
3711         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
3712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
3713         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
3714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3715         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
3716
3717 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
3718
3719         [Win][MiniBrowser] URL bar should be updated for in-page navigations
3720         https://bugs.webkit.org/show_bug.cgi?id=201032
3721
3722         Reviewed by Darin Adler.
3723
3724         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
3725         * MiniBrowser/win/MainWindow.cpp:
3726         (MainWindow::init):
3727         (MainWindow::activeURLChanged): Added.
3728         * MiniBrowser/win/MainWindow.h:
3729         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3730         (MiniBrowserWebHost::didCommitLoadForFrame):
3731         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
3732         (MiniBrowserWebHost::updateAddressBar): Deleted.
3733         (MiniBrowserWebHost::loadURL): Deleted.
3734         * MiniBrowser/win/MiniBrowserWebHost.h:
3735         (MiniBrowserWebHost::MiniBrowserWebHost):
3736         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
3737         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
3738         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3739         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3740         (WebKitBrowserWindow::create):
3741         (WebKitBrowserWindow::WebKitBrowserWindow):
3742         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
3743         (WebKitBrowserWindow::didChangeActiveURL): Added.
3744         (WebKitBrowserWindow::createNewPage):
3745         (WebKitBrowserWindow::didCommitNavigation): Deleted.
3746         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
3747         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3748         (WebKitLegacyBrowserWindow::create):
3749         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3750         (WebKitLegacyBrowserWindow::init):
3751         (WebKitLegacyBrowserWindow::navigateToHistory):
3752         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
3753
3754 2019-08-22  Andy Estes  <aestes@apple.com>
3755
3756         [watchOS] Disable Content Filtering in the simulator build
3757         https://bugs.webkit.org/show_bug.cgi?id=201047
3758
3759         Reviewed by Tim Horton.
3760
3761         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3762
3763 2019-08-22  Chris Dumez  <cdumez@apple.com>
3764
3765         Try to recover nicely when getting an unexpected schema in the service workers database
3766         https://bugs.webkit.org/show_bug.cgi?id=201002
3767         <rdar://problem/54574991>
3768
3769         Reviewed by Youenn Fablet.
3770
3771         Add API test coverage.
3772
3773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3774         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3775
3776 2019-08-22  Keith Rollin  <krollin@apple.com>
3777
3778         Remove support for tvOS < 13.0
3779         https://bugs.webkit.org/show_bug.cgi?id=200963
3780         <rdar://problem/54541355>
3781
3782         Reviewed by Tim Horton.
3783
3784         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
3785         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
3786         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
3787         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
3788         130000" are always True.
3789
3790         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
3791         (TestWebKitAPI::TEST):
3792
3793 2019-08-22  Daniel Bates  <dabates@apple.com>
3794
3795         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
3796         https://bugs.webkit.org/show_bug.cgi?id=200742
3797
3798         Reviewed by Simon Fraser.
3799
3800         The OptionSet synthetic provider must respond to requests for the value of m_storage
3801         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
3802         of the type summary.
3803
3804         Synthetic providers substitute alternative debug information (children) for the default
3805         information for a variable. The OptionSet type summary is implemented in terms of the
3806         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
3807         before invoking the type summary handler then evaluating GetChildMemberWithName() on
3808         the SBValue passed to the type summary handler will access the substitute information
3809         instead of the original debug information. As a result OptionSet's synthetic provider's
3810         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
3811         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
3812         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
3813         should return a valid value.
3814
3815         * lldb/lldb_webkit.py:
3816         (FlagEnumerationProvider.__init__):
3817         (FlagEnumerationProvider):
3818         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
3819         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
3820         (FlagEnumerationProvider.size): Added.
3821         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
3822         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
3823         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
3824         and removed self.size. For the latter we can just expose a getter that returns the size of
3825         the list self._elements.
3826         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
3827         value of m_storage.
3828         (WTFOptionSetProvider):
3829         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
3830         matches the specified index.
3831         * lldb/lldb_webkit_unittest.py:
3832         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
3833         that we return the value of m_storage as the last synthetic child.
3834
3835 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
3836
3837         results.webkit.org: Remove branch and repository information from commit tooltip
3838         https://bugs.webkit.org/show_bug.cgi?id=201035
3839
3840         Reviewed by Aakash Jain.
3841
3842         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3843         (xAxisFromScale): Remove branch and repository information from tooltip.
3844
3845 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
3846
3847         run-webkit-tests: Use -noBulkSymbolication when calling spindump
3848         https://bugs.webkit.org/show_bug.cgi?id=201000
3849         <rdar://problem/53778938>
3850
3851         Reviewed by Alexey Proskuryakov.
3852
3853         * Scripts/webkitpy/port/darwin.py:
3854         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
3855         * Scripts/webkitpy/port/darwin_testcase.py:
3856         (DarwinTest.test_tailspin):
3857         (DarwinTest.test_get_crash_log): Deleted.
3858         * Scripts/webkitpy/port/ios_device_unittest.py:
3859         (IOSDeviceTest.test_tailspin):
3860
3861 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
3862
3863         [results.webkit.org Webkit.css] Change input's disable style
3864         The disable input style will always show the label like it has a value 
3865         https://bugs.webkit.org/show_bug.cgi?id=200998
3866
3867         Reviewed by Jonathan Bedard.
3868
3869         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
3870         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
3871         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
3872         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3873         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
3874         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
3875         (@media (prefers-color-scheme: dark)):
3876
3877 2019-08-17  Darin Adler  <darin@apple.com>
3878
3879         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
3880         https://bugs.webkit.org/show_bug.cgi?id=200862
3881
3882         Reviewed by Ryosuke Niwa.
3883
3884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3885         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
3886         * WebKitTestRunner/TestController.cpp:
3887         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
3888         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
3889         (WTR::TestController::downloadDidFail): Ditto.
3890
3891 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
3892
3893         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
3894         https://bugs.webkit.org/show_bug.cgi?id=200978
3895
3896         Unreviewed follow-up fix.
3897
3898         Update the string format specifier for unsigned it.
3899
3900         * MiniBrowser/gtk/main.c:
3901         (main):
3902         * MiniBrowser/wpe/main.cpp:
3903         (main):
3904
3905 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3906
3907         [GTK][WPE] Support for command "--version" on the MiniBrowser
3908         https://bugs.webkit.org/show_bug.cgi?id=200978
3909
3910         Reviewed by Žan Doberšek.
3911
3912         Printing the engine version used from the MiniBrowser is useful.
3913         For example, the test scripts on WPT can use this info to better
3914         tag the generated results.
3915
3916         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
3917         (main):
3918         * MiniBrowser/wpe/main.cpp: Ditto.
3919         (main):
3920
3921 2019-08-22  Youenn Fablet  <youenn@apple.com>
3922
3923         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
3924         https://bugs.webkit.org/show_bug.cgi?id=196870
3925
3926         Reviewed by Alex Christensen.
3927
3928         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
3929         Accept any server certificate by default.
3930
3931         * WebKitTestRunner/TestController.cpp:
3932         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3933         (WTR::TestController::cocoaResetStateToConsistentValues):
3934         (WTR::TestController::setAllowsAnySSLCertificate):
3935         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
3936         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3937         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
3938         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
3939
3940 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
3941
3942         results.webkit.org: Fix drawer style
3943         https://bugs.webkit.org/show_bug.cgi?id=200988
3944
3945         Rubber-stamped by Aakash Jain.
3946
3947         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3948         (Drawer): Nothing in the drawer should be selectable.
3949         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
3950         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3951         (.action:hover): Disable underline on 'links' which are actually actions
3952         (.unselectable): Make a div unselectable.
3953         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3954         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
3955
3956 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3957
3958         [Win][MiniBrowser] Add a progress indicator to the main window
3959         https://bugs.webkit.org/show_bug.cgi?id=200970
3960
3961         Reviewed by Alex Christensen.
3962
3963         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
3964         * MiniBrowser/win/MainWindow.cpp:
3965         (MainWindow::init):
3966         (MainWindow::resizeSubViews):
3967         (MainWindow::progressChanged):
3968         (MainWindow::progressFinished):
3969         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
3970         Added m_hProgressIndicator.
3971         (MainWindow::hwnd const): Deleted.
3972         (MainWindow::browserWindow const): Deleted.
3973         (): Deleted.
3974         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3975         (MiniBrowserWebHost::onNotify):
3976         * MiniBrowser/win/MiniBrowserWebHost.h:
3977         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3978         (WebKitBrowserWindow::create):
3979         (WebKitBrowserWindow::WebKitBrowserWindow):
3980         (WebKitBrowserWindow::didChangeIsLoading):
3981         (WebKitBrowserWindow::didChangeEstimatedProgress):
3982         (WebKitBrowserWindow::createNewPage):
3983         * MiniBrowser/win/WebKitBrowserWindow.h:
3984         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3985         (WebKitLegacyBrowserWindow::create):
3986         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3987         (WebKitLegacyBrowserWindow::init):
3988         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3989
3990 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
3991
3992         Unreviewed, rolling out r248970.
3993
3994         Caused
3995         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
3996         to fail.
3997
3998         Reverted changeset:
3999
4000         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
4001         non-empty set"
4002         https://bugs.webkit.org/show_bug.cgi?id=200742
4003         https://trac.webkit.org/changeset/248970
4004
4005 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
4006
4007         results.webkit.org: Add database table to save zip archives to
4008         https://bugs.webkit.org/show_bug.cgi?id=200718
4009
4010         Rubber-stamped by Aakash Jain.
4011
4012         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
4013         (ArchiveContext):
4014         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
4015         (ArchiveContext.ArchivesByCommit.unpack):
4016         (ArchiveContext.assert_zipfile):
4017         (ArchiveContext.open_zipfile):
4018         (ArchiveContext.__init__):
4019         (ArchiveContext.__enter__):
4020         (ArchiveContext.__exit__):
4021         (ArchiveContext.register): Save the provided archive to Cassandra.
4022         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
4023         (ArchiveContext._files_for_archive):
4024         (ArchiveContext.ls): List all files in the matching archives.
4025         (ArchiveContext.file): Extract a file from the matching archives.
4026         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
4027         (ArchiveContextTest):
4028         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
4029         (MockModelFactory):
4030         (MockModelFactory.process_results):
4031         (MockModelFactory.add_mock_archives):
4032         * resultsdbpy/resultsdbpy/model/model.py:
4033         (Model.__init__): Add an ArchiveContext to the model.
4034
4035 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
4036
4037         [ews-build] view layout test results option should be displayed next to layout-test build step
4038         https://bugs.webkit.org/show_bug.cgi?id=200048
4039
4040         Reviewed by Jonathan Bedard.
4041
4042         * BuildSlaveSupport/ews-build/steps.py:
4043         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
4044         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
4045
4046 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
4047
4048         [ews] Fix capitalization in Found x new Test failure message
4049         https://bugs.webkit.org/show_bug.cgi?id=201004
4050
4051         Reviewed by Alexey Proskuryakov.
4052
4053         * BuildSlaveSupport/ews-build/steps.py:
4054         (AnalyzeLayoutTestsResults.report_failure):
4055         (AnalyzeAPITestsResults.analyzeResults):
4056         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
4057
4058 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
4059
4060         Assign ews117 to EWS High-Sierra Debug queues
4061         https://bugs.webkit.org/show_bug.cgi?id=200993
4062
4063         Reviewed by Jonathan Bedard.
4064
4065         * BuildSlaveSupport/ews-build/config.json:
4066
4067 2019-08-21  Daniel Bates  <dabates@apple.com>
4068
4069         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
4070         https://bugs.webkit.org/show_bug.cgi?id=200742
4071
4072         Reviewed by Simon Fraser.
4073
4074         The OptionSet synthetic provider must respond to requests for the value of m_storage
4075         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
4076         of the type summary.
4077
4078         Synthetic providers substitute alternative debug information (children) for the default
4079         information for a variable. The OptionSet type summary is implemented in terms of the
4080         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
4081         before invoking the type summary handler then evaluating GetChildMemberWithName() on
4082         the SBValue passed to the type summary handler will access the substitute information
4083         instead of the original debug information. As a result OptionSet's synthetic provider's
4084         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
4085         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
4086         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
4087         should return a valid value.
4088
4089         * lldb/lldb_webkit.py:
4090         (FlagEnumerationProvider.__init__):
4091         (FlagEnumerationProvider):
4092         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
4093         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
4094         (FlagEnumerationProvider.size): Added.
4095         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
4096         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
4097         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
4098         and removed self.size. For the latter we can just expose a getter that returns the size of
4099         the list self._elements.
4100         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
4101         value of m_storage.
4102         (WTFOptionSetProvider):
4103         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
4104         matches the specified index.
4105
4106 2019-08-21  Alex Christensen  <achristensen@webkit.org>
4107
4108         Disabling text autosizing should prevent text autosizing
4109         https://bugs.webkit.org/show_bug.cgi?id=200955
4110         <rdar://problem/48095374>
4111
4112         Reviewed by Simon Fraser.
4113
4114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4115         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
4116         (TEST):
4117
4118 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
4119
4120         [GTK][WPE] Make debug-test-runner work
4121         https://bugs.webkit.org/show_bug.cgi?id=193576
4122
4123         Reviewed by Michael Catanzaro.
4124
4125         * Scripts/webkitdirs.pm:
4126         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
4127         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
4128         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
4129         (execUnixAppForDebugging): Added.
4130         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
4131
4132 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
4133
4134         Put keygen element behind a runtime flag and disable it by default
4135         https://bugs.webkit.org/show_bug.cgi?id=200850
4136
4137         Reviewed by Antti Koivisto.
4138
4139         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
4140
4141         * DumpRenderTree/TestOptions.cpp:
4142         (TestOptions::TestOptions):
4143         * DumpRenderTree/TestOptions.h:
4144         * DumpRenderTree/mac/DumpRenderTree.mm:
4145         (setWebPreferencesForTestOptions):
4146         * DumpRenderTree/win/DumpRenderTree.cpp:
4147         (setWebPreferencesForTestOptions):
4148         * WebKitTestRunner/TestController.cpp:
4149         (WTR::TestController::resetPreferencesToConsistentValues):
4150         (WTR::updateTestOptionsFromTestHeader):
4151         * WebKitTestRunner/TestOptions.h:
4152         (WTR::TestOptions::hasSameInitializationOptions const):
4153
4154 2019-08-21  Chris Dumez  <cdumez@apple.com>
4155
4156         Add internal setting to disable SecureContext checks
4157         https://bugs.webkit.org/show_bug.cgi?id=200980
4158         <rdar://problem/54438512>
4159
4160         Reviewed by Alex Christensen.
4161
4162         Add API test coverage.
4163
4164         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
4165         (log):
4166         (requestPermission):
4167
4168 2019-08-21  Keith Rollin  <krollin@apple.com>
4169
4170         Remove support for watchOS < 6.0
4171         https://bugs.webkit.org/show_bug.cgi?id=200937
4172         <rdar://problem/54524009>
4173
4174         Reviewed by Darin Adler.
4175
4176         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
4177         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
4178         60000. This means that expressions like
4179         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
4180         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
4181
4182         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
4183         (TestWebKitAPI::TEST):
4184
4185 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
4186
4187         [results.webkit.org Webkit.css] Add right sidebar
4188         https://bugs.webkit.org/show_bug.cgi?id=200946
4189