Add static version of JSCell::getConstructData
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-07  Adam Barth  <abarth@webkit.org>
2
3         Add a Content-Security-Policy to garden-o-matic
4         https://bugs.webkit.org/show_bug.cgi?id=69668
5
6         Reviewed by David Levin.
7
8         This will help mitigate cross-site script and will also help us dogfood CSP.
9
10         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
11
12 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
13
14         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
15         https://bugs.webkit.org/show_bug.cgi?id=66380
16
17         Reviewed by Antonio Gomes.
18
19         This encapsulates EWebKit into an object that manages multiple windows
20         and provides a cleaner interface to EFL's DumpRenderTree.
21
22         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
23         (DumpRenderTreeChrome::create):
24         (DumpRenderTreeChrome::DumpRenderTreeChrome):
25         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
26         (DumpRenderTreeChrome::createNewWindow):
27         (DumpRenderTreeChrome::createView):
28         (DumpRenderTreeChrome::removeWindow):
29         (DumpRenderTreeChrome::initialize):
30         (DumpRenderTreeChrome::extraViews):
31         (DumpRenderTreeChrome::mainFrame):
32         (DumpRenderTreeChrome::mainView):
33         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
34         (DumpRenderTreeChrome::onWindowObjectCleared):
35         (DumpRenderTreeChrome::onLoadStarted):
36         (DumpRenderTreeChrome::processWork):
37         (DumpRenderTreeChrome::onLoadFinished):
38         (DumpRenderTreeChrome::onStatusbarTextSet):
39         (DumpRenderTreeChrome::onTitleChanged):
40         (DumpRenderTreeChrome::onDocumentLoadFinished):
41         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
42         * DumpRenderTree/efl/EventSender.cpp:
43         (sendClick): Use browser->mainFrame() instead of mainFrame.
44         (mouseDownCallback): Ditto.
45         (mouseUpCallback): Ditto.
46         (mouseMoveToCallback): Ditto.
47         (mouseScrollByCallback): Ditto.
48         (keyDownCallback): Ditto.
49         (scalePageByCallback): Ditto.
50         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
51         (LayoutTestController::counterValueForElementById): Use
52         browser->mainFrame() instead of mainFrame.
53         (LayoutTestController::pageNumberForElementById): Ditto.
54         (LayoutTestController::numberOfPages): Ditto.
55         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
56         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
57         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
58         (LayoutTestController::numberOfActiveAnimations): Ditto.
59         (LayoutTestController::suspendAnimations): Ditto.
60         (LayoutTestController::resumeAnimations): Ditto.
61         (LayoutTestController::setWebViewEditable): Ditto.
62         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
63         instead of browser.
64         (LayoutTestController::queueLoad): Ditto.
65         (LayoutTestController::setAcceptsEditing): Ditto.
66         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
67         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
68         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
69         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
70         (LayoutTestController::setPluginsEnabled): Ditto.
71         (LayoutTestController::findString): Ditto.
72         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
73         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
74         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
75         mainFrame.
76         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
77         (LoadItem::invoke): Ditto.
78         (LoadHTMLStringItem::invoke): Ditto.
79         (ScriptItem::invoke): Ditto.
80         (ReloadItem::invoke): Use browser->mainView() instead of browser.
81
82 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
83
84         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
85         https://bugs.webkit.org/show_bug.cgi?id=69617
86
87         Reviewed by Andreas Kling.
88
89         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
90         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
91         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
92         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
93         logic.
94
95         * MiniBrowser/qt/MiniBrowserApplication.cpp:
96         (MiniBrowserApplication::MiniBrowserApplication):
97         (MiniBrowserApplication::notify):
98         * MiniBrowser/qt/MiniBrowserApplication.h:
99
100 2011-10-06  Adam Barth  <abarth@webkit.org>
101
102         Port PixelZoomer to work in garden-o-matic
103         https://bugs.webkit.org/show_bug.cgi?id=69577
104
105         Reviewed by David Levin.
106
107         This implementation of PixelZoomer is basically a fork of the
108         implementation used by results.html.  These two apps have different
109         requirements on where this code lives.  results.html wants to be
110         self-contained whereas garden-o-matic wants to live in the public_html
111         folder of the buildbot.  We could do something fancy here to share the
112         code, but that's not likely to be of much benefit.
113
114         I had to change a few things about pixelzoomer to accounter for the
115         differences in DOM between results.html and garden-o-matic, but
116         surprisingly little.  I also moved all the code into an anonymous
117         function, which is the style we're suing for module separation in
118         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
119         want to drag along too many extra functions from results.html.
120
121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
126         (.pixel-zoom-container):
127         (.pixel-zoom-container > *):
128         (.pixel-zoom-container .scaled-image-container):
129         (.scaled-image-container > img):
130
131 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
132
133         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
134         https://bugs.webkit.org/show_bug.cgi?id=69505
135
136         Reviewed by Andreas Kling.
137
138         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
139         (on_viewport_changed):
140
141 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
142
143         [WinCairo] Unreviewed test correction.
144
145         * Scripts/webkitdirs.pm:
146         (argumentsForConfiguration): Add 'wincairo' option to the set of
147         configuration flags used by run-javascript-core tests, so that it
148         does not attempt to run Apple's release version.
149
150 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
151
152         [WinCairo] Unreviewed test correction.
153
154         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
155          of known build slave types so that test-result-archive won't fail
156          when running tests.
157
158 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
159
160         The GTK+ WebKit2 headers produce a lot of style warnings
161         https://bugs.webkit.org/show_bug.cgi?id=69481
162
163         Reviewed by David Levin.
164
165         Prevent emitting so many style warnings for GTK+ API. We skip header
166         files in the WebKit2 GTK+ API directory and also avoid warnings about
167         identifier names that begin with "webkit_" in files that contain the
168         string "gtk".
169
170         * Scripts/webkitpy/style/checker.py: Do not check header files in
171         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
172         adding the ability to specify a regular expression in the skip list. Remove
173         a few files from the skipped list that no longer exist.
174         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
175         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
176         about identifiers that begin with "webkit_".
177         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
178
179 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
180
181         [WinCairo] Correct config.json for WinCairo Test builds.
182         https://bugs.webkit.org/show_bug.cgi?id=69272
183
184         Reviewed by Ryosuke Niwa.
185
186         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
187          old 'WinCairo Debug (Build)' label and replace with correct
188          'WinCairo Release' label.
189
190 2011-10-06  David Levin  <levin@chromium.org>
191
192         Add a style checker watchlist definition and add myself to it.
193         https://bugs.webkit.org/show_bug.cgi?id=69564
194
195         Reviewed by Daniel Bates.
196
197         * Scripts/webkitpy/common/config/watchlist:
198
199 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
200
201         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
202         https://bugs.webkit.org/show_bug.cgi?id=69450
203
204         Reviewed by Ryosuke Niwa.
205
206         This should avoid stderr messages when running
207         webarchive/test-link-rel-icon.html.
208
209         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
210         (LayoutTestController::setIconDatabaseEnabled):
211
212 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
213
214         [WK2] [GTK] Add Skipped file for Webkit2 test runner
215         https://bugs.webkit.org/show_bug.cgi?id=69517
216
217         Use the shared WK2 skipped file also in GTK port.
218
219         Reviewed by Martin Robinson.
220
221         * Scripts/old-run-webkit-tests:
222         (readSkippedFiles):
223
224 2011-10-06  Elliot Poger  <epoger@google.com>
225
226         allow new-run-webkit-tests to run on Lion
227         https://bugs.webkit.org/show_bug.cgi?id=69429
228
229         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
230         directory to fallback lists (even though that directory doesn't exist yet)
231
232         Reviewed by Adam Barth.
233
234         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
235         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
236
237 2011-10-03  Hans Wennborg  <hans@chromium.org>
238
239         IndexedDB: Remove SQLite-LevelDB migration code
240         https://bugs.webkit.org/show_bug.cgi?id=69264
241
242         Reviewed by Tony Chang.
243
244         Remove setOverrideIndexedDBBackingStore. It was used in the layout
245         test for migration.
246
247         * DumpRenderTree/chromium/LayoutTestController.cpp:
248         (LayoutTestController::LayoutTestController):
249         * DumpRenderTree/chromium/LayoutTestController.h:
250
251 2011-10-05  James Robinson  <jamesr@chromium.org>
252
253         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
254         https://bugs.webkit.org/show_bug.cgi?id=69498
255
256         Reviewed by Adam Barth.
257
258         * DumpRenderTree/chromium/DumpRenderTree.cpp:
259         (main):
260         * DumpRenderTree/chromium/TestShell.cpp:
261         (TestShell::TestShell):
262         (TestShell::resetWebSettings):
263         * DumpRenderTree/chromium/TestShell.h:
264         (TestShell::setThreadedCompositingEnabled):
265         * DumpRenderTree/chromium/WebPreferences.cpp:
266         (WebPreferences::reset):
267         (WebPreferences::applyTo):
268         * DumpRenderTree/chromium/WebPreferences.h:
269         * Scripts/webkitpy/layout_tests/port/chromium.py:
270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
271
272 2011-10-05  Erik Arvidsson  <arv@chromium.org>
273
274         [QT] Fix DRT after r96779
275
276         unreviewed.
277
278         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
279         (WebCore::dumpHistoryItem):
280
281 2011-10-05  Erik Arvidsson  <arv@chromium.org>
282
283         window.location.href and others needlessly decodes URI-encoded characters
284         https://bugs.webkit.org/show_bug.cgi?id=30225
285
286         Reviewed by Darin Adler.
287
288         * DumpRenderTree/chromium/TestShell.cpp:
289         (normalizeLayoutTestURLInternal): Remove extra encode.
290
291 2011-10-05  Darin Adler  <darin@apple.com>
292
293         Fix build.
294
295         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
296         (TestWebKitAPI::TEST): Remove underscore prefix from call to
297         WKContextRegisterURLSchemeAsEmptyDocument.
298
299 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
300
301         [WinCairo] Switch to building Release target, and activate tests.
302         https://bugs.webkit.org/show_bug.cgi?id=69272
303
304         Reviewed by Adam Barth.
305
306         * BuildSlaveSupport/build.webkit.org-config/config.json:
307         Change from debug to release target. Switch from "Build" to
308         "BuildAndTest"
309
310 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
311
312         In WebKitTestRunner, text has font smoothing in pixel snapshots
313         https://bugs.webkit.org/show_bug.cgi?id=69396
314
315         Reviewed by Darin Adler.
316         
317         Call the new WKContext method that disables font smoothing in
318         WebKitTestRunner, so that pixel snapshots don't have font smoothing
319         enabled. Remove leading underscore from a WKContext function call.
320
321         * WebKitTestRunner/TestController.cpp:
322         (WTR::TestController::resetStateToConsistentValues):
323
324 2011-10-05  David Levin  <levin@chromium.org>
325
326         Improve the watchlist for threading entries.
327         https://bugs.webkit.org/show_bug.cgi?id=69463
328
329         Reviewed by Adam Barth.
330
331         * Scripts/webkitpy/common/config/watchlist:
332
333 2011-10-05  Adam Roben  <aroben@apple.com>
334
335         Add tests for using RetainPtrs inside HashMap and HashSet
336
337         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
338         in HashMap/HashSet fails to compile
339
340         Reviewed by John Sullivan.
341
342         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
343         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
344         and value type of HashMap.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
348         Added new file.
349
350 2011-10-05  Adam Barth  <abarth@webkit.org>
351
352         Mark as Expected in garden-o-matic is confusing
353         https://bugs.webkit.org/show_bug.cgi?id=69452
354
355         Reviewed by David Levin.
356
357         krit didn't understand the difference between this button and the
358         Rebaseline button because both of them seem to indicate that the new
359         behavior is expected.  This patch renames "Mark as Expected" to "Expect
360         Failure" to make it clear that we're just expecting the test to fail
361         rather than accepting the new results as passing.  We might need to
362         iterate on these names a bit more if folks continue to find them
363         confusing.
364
365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
366
367 2011-10-05  Adam Barth  <abarth@webkit.org>
368
369         Add watchlist entries for abarth
370         https://bugs.webkit.org/show_bug.cgi?id=69461
371
372         Reviewed by David Levin.
373
374         I might have gone a bit overboard.  We'll see if this is too much spam
375         for me.
376
377         * Scripts/webkitpy/common/config/watchlist:
378
379 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
380
381         [WinCairo] Teach old-run-webkit-tests about wincairo.
382         https://bugs.webkit.org/show_bug.cgi?id=69280
383
384         Reviewed by Adam Roben.
385
386         * Scripts/old-run-webkit-tests: Handle wincairo case.
387         (buildPlatformResultHierarchy):
388         (readSkippedFiles): Ditto
389         * Scripts/webkitdirs.pm: Deal with wincairo build case.
390         (determineConfiguration):
391
392 2011-10-05  Chang Shu  <cshu@webkit.org>
393
394         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
395         https://bugs.webkit.org/show_bug.cgi?id=68924
396
397         Added TextInputController files and JS interfaces for the above functions.
398
399         Reviewed by Darin Adler.
400
401         * WebKitTestRunner/DerivedSources.make:
402         * WebKitTestRunner/DerivedSources.pro:
403         * WebKitTestRunner/GNUmakefile.am:
404         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
405         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
406         (WTR::InjectedBundle::beginTesting):
407         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
408         (WTR::InjectedBundle::textInputController):
409         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
410         (WTR::InjectedBundlePage::didClearWindowForFrame):
411         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
412         (WTR::TextInputController::create):
413         (WTR::TextInputController::TextInputController):
414         (WTR::TextInputController::~TextInputController):
415         (WTR::TextInputController::wrapperClass):
416         (WTR::TextInputController::makeWindowObject):
417         (WTR::TextInputController::setMarkedText):
418         (WTR::TextInputController::hasMarkedText):
419         (WTR::TextInputController::unmarkText):
420         (WTR::TextInputController::insertText):
421         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
422         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
423         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
424         * WebKitTestRunner/win/InjectedBundle.vcproj:
425
426 2011-10-04  Oliver Hunt  <oliver@apple.com>
427
428         Add rudimentary filtering to write barriers
429         https://bugs.webkit.org/show_bug.cgi?id=69392
430
431         Reviewed by Filip Pizlo.
432
433         When we're recording gc phase times Heap.o picks up
434         some exit time destructors, so we'll just ignore Heap.o
435         in this check.
436
437         * Scripts/check-for-exit-time-destructors:
438
439 2011-10-05  Chang Shu  <cshu@webkit.org>
440
441         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
442         https://bugs.webkit.org/show_bug.cgi?id=69365
443
444         Reviewed by Darin Adler.
445
446         Added js API in WTR LayoutTestController.
447
448         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
449         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
450         (WTR::LayoutTestController::dumpConfigurationForViewport):
451         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
452
453 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
454
455         [EFL] ImageDiff: Do not clear the image before it is processed and compared
456         https://bugs.webkit.org/show_bug.cgi?id=69378
457
458         Reviewed by Antonio Gomes.
459
460         Commit 61836 to Evas added a few cleanup calls to some
461         evas_object_image functions which effectively made ImageDiff consider
462         all images to be equal.
463
464         It turns out that now evas_object_image_colorspace_set clears any
465         data set, so the call to evas_object_image_data_set was not having any
466         effect.
467
468         * DumpRenderTree/efl/ImageDiff.cpp:
469         (readImageFromStdin): Call evas_object_image_data_set after
470         evas_object_image_colorspace_set.
471
472 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
473
474         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
475         https://bugs.webkit.org/show_bug.cgi?id=68449
476
477         Reviewed by Antonio Gomes.
478
479         evas_render() must be called to close up temporary files and unmap unused
480         resources. evas_object_image_data_set() must be called after an
481         evas_object_image_data_get() to balance an internal reference count.
482
483         * DumpRenderTree/efl/ImageDiff.cpp:
484         (differenceImageFromDifferenceBuffer):
485         (calculateDifference):
486         (printImage):
487         (printImageDifferences):
488
489 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
490
491         [Qt][WK2] Unreviewed build fix.
492
493         Don't use WebCore directly in WTR.
494
495         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
496         (WTR::PlatformWebView::addChromeInputField):
497         (WTR::PlatformWebView::removeChromeInputField):
498         (WTR::PlatformWebView::makeWebViewFirstResponder):
499
500 2011-10-05  David Levin  <levin@chromium.org>
501
502         watchlist: Add more rules for chromium public api and sort the file.
503         https://bugs.webkit.org/show_bug.cgi?id=69323
504
505         Reviewed by Adam Barth.
506
507         * Scripts/webkitpy/common/config/watchlist:
508
509 2011-10-05  David Levin  <levin@chromium.org>
510
511         watchlist: Don't add the same message to a bug more than once.
512         https://bugs.webkit.org/show_bug.cgi?id=69303
513
514         Reviewed by Adam Barth.
515
516         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
517         if a message is in the comments already.
518         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
519         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
520         Pick a bug supplied by the mock. Change the test due to different output
521         from the mock watch list tool.
522         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
523         another email so it will be filtered out, fix bugs to have the cc and comment fields,
524         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
525         to debug).
526         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
527         and/or cc's that are already in the bug.
528         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
529         and remove a comment that is filtered out.
530
531 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
532
533         [Qt][WK2] Unreviewed build fix after r96643.
534
535         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
536         (WTR::PlatformWebView::addChromeInputField):
537         (WTR::PlatformWebView::removeChromeInputField):
538         (WTR::PlatformWebView::makeWebViewFirstResponder):
539
540 2011-10-04  Kent Tamura  <tkent@chromium.org>
541
542         Introduce feature flags for incomplete input types
543         https://bugs.webkit.org/show_bug.cgi?id=68971
544
545         Reviewed by Hajime Morita.
546
547         * Scripts/build-webkit:
548         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
549         They are disabled by default.
550
551 2011-10-04  Adam Barth  <abarth@webkit.org>
552
553         garden-o-matic doesn't launch it's UI on Lion
554         https://bugs.webkit.org/show_bug.cgi?id=69349
555
556         Reviewed by Darin Adler.
557
558         It turns out that Lion is a bit more picky about file URLs.  This patch
559         switches us from using a path to using an actual file URL, silencing
560         the warning and making the tool actually launch on Lion.
561
562         * Scripts/webkitpy/tool/servers/gardeningserver.py:
563
564 2011-10-04  Daniel Bates  <dbates@rim.com>
565
566         Fix Perl undefined variable warning when using run-safari after
567         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
568
569         Rubber-stamped by Alexey Proskuryakov.
570
571         * Scripts/webkitdirs.pm:
572         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
573         is defined before using it in a comparison operation.
574
575 2011-10-04  Scott Graham  <scottmg@chromium.org>
576
577         Add GAMEPAD feature flag
578         https://bugs.webkit.org/show_bug.cgi?id=66859
579
580         Reviewed by Darin Fisher.
581
582         * Scripts/build-webkit:
583
584 2011-10-04  Jon Lee  <jonlee@apple.com>
585
586         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
587         https://bugs.webkit.org/show_bug.cgi?id=68412
588         <rdar://problem/9988252>
589
590         Reviewed by Darin Adler.
591
592         In order to create a test for the bug, I had to update DRT and WKTR to create some
593         widget that allows first responder status to move away from the main web view.
594
595         Three methods were added to layoutTestController: addChromeInputField,
596         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
597         that is a sibling to the web view, and sets up the key event loop between the two.
598         removeChromeInputField removes that field. focusWebView moves first responder
599         status to the web view.
600
601         The test makes the call via layoutTestController and passes a callback that it
602         assumes will be executed once the task is completed. In DRT the callback is called
603         synchronously. In WKTR this is handled with message passing between the two
604         processes.
605
606         * DumpRenderTree/LayoutTestController.cpp:
607         (addChromeInputFieldCallback):
608         (removeChromeInputFieldCallback):
609         (focusWebViewCallback):
610         (LayoutTestController::staticFunctions):
611         * DumpRenderTree/LayoutTestController.h:
612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
613         (LayoutTestController::addChromeInputField):
614         (LayoutTestController::removeChromeInputField):
615         (LayoutTestController::focusWebView):
616         * DumpRenderTree/mac/DumpRenderTree.mm:
617         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
618         make sure to remove the chrome input field.
619         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
620         (LayoutTestController::addChromeInputField):
621         (LayoutTestController::removeChromeInputField):
622         (LayoutTestController::focusWebView):
623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
624         (LayoutTestController::addChromeInputField):
625         (LayoutTestController::removeChromeInputField):
626         (LayoutTestController::focusWebView):
627         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
628         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
629         (WTR::InjectedBundle::didReceiveMessage):
630         (WTR::InjectedBundle::postAddChromeInputField):
631         (WTR::InjectedBundle::postRemoveChromeInputField):
632         (WTR::InjectedBundle::postFocusWebView):
633         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
634         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
635         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
636         through JS.
637         (WTR::cacheLayoutTestControllerCallback):
638         (WTR::callLayoutTestControllerCallback):
639         (WTR::LayoutTestController::addChromeInputField):
640         (WTR::LayoutTestController::removeChromeInputField):
641         (WTR::LayoutTestController::focusWebView):
642         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
643         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
644         (WTR::LayoutTestController::callFocusWebViewCallback):
645         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
646         * WebKitTestRunner/PlatformWebView.h:
647         * WebKitTestRunner/TestController.cpp:
648         (WTR::TestController::resetStateToConsistentValues):
649         * WebKitTestRunner/TestInvocation.cpp:
650         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
651         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
652         (WTR::PlatformWebView::addChromeInputField):
653         (WTR::PlatformWebView::removeChromeInputField):
654         (WTR::PlatformWebView::makeWebViewFirstResponder):
655         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
656         (WTR::PlatformWebView::addChromeInputField):
657         (WTR::PlatformWebView::removeChromeInputField):
658         (WTR::PlatformWebView::makeWebViewFirstResponder):
659         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
660         (WTR::PlatformWebView::addChromeInputField):
661         (WTR::PlatformWebView::removeChromeInputField):
662         (WTR::PlatformWebView::makeWebViewFirstResponder):
663
664         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
665         with the patch-- just cleaning up style.
666         (LayoutTestController::addDisallowedURL):
667         (originsArrayToJS):
668         (LayoutTestController::queueLoad):
669         (LayoutTestController::setMockDeviceOrientation):
670         (LayoutTestController::setIconDatabaseEnabled):
671         (LayoutTestController::setEditingBehavior):
672
673 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
674
675         Move font-fixup code in WebKitTestRunner to a better place
676         https://bugs.webkit.org/show_bug.cgi?id=69356
677
678         Reviewed by Sam Weinig.
679         
680         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
681         already contains font-related code.
682
683         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
684         (WTR::InjectedBundle::initialize):
685         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
686         (WTR::allowedFontFamilySet):
687         (WTR::drt_NSFontManager_availableFontFamilies):
688         (WTR::drt_NSFontManager_availableFonts):
689         (WTR::swizzleNSFontManagerMethods):
690         (WTR::activateFonts):
691         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
692         (WTR::InjectedBundle::platformInitialize):
693
694 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
695
696         [EFL] DRT: Add DumpRenderTree.cpp
697         https://bugs.webkit.org/show_bug.cgi?id=62034
698
699         Reviewed by Antonio Gomes.
700
701         This is the main implementation file for EFL's DumpRenderTree.
702
703         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
704         (dumpFramesAsText):
705         (dumpFrameScrollPosition):
706         (shouldLogFrameLoadDelegates):
707         (shouldDumpAsText):
708         (sendPixelResultsEOF):
709         (invalidateAnyPreviousWaitToDumpWatchdog):
710         (onEcoreEvasResize):
711         (onCloseWindow):
712         (useLongRunningServerMode):
713         (parseCommandLineOptions):
714         (getFinalTestURL):
715         (getExpectedPixelHash):
716         (createLayoutTestController):
717         (runTest):
718         (runTestingServerLoop):
719         (adjustOutputTypeByMimeType):
720         (dumpFrameContentsAsText):
721         (shouldDumpFrameScrollPosition):
722         (shouldDumpPixelsAndCompareWithExpected):
723         (shouldDumpBackForwardList):
724         (initEfl):
725         (shutdownEfl):
726         (displayWebView):
727         (dump):
728         (initEcoreEvas):
729         (main):
730
731 2011-10-03  Adam Barth  <abarth@webkit.org>
732
733         garden-o-matic should remove builders from the failure grid once they start to pass
734         https://bugs.webkit.org/show_bug.cgi?id=69309
735
736         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
737         in reviewing these patches.
738
739         This patch follows the update/purge model from UpdateTracker.  This
740         patch is less awesome than it could be because it causes the UI to
741         flash slightly.  In a future patch, we'll want to use these
742         update/purge notifications to update the UI without flashing.  However,
743         that's not such a big deal because this UI is hidden in the default
744         view.
745
746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
750
751 2011-10-03  David Levin  <levin@chromium.org>
752
753         webkitpy: Expose cc_emails and comments from bug.py
754         https://bugs.webkit.org/show_bug.cgi?id=69308
755
756         Reviewed by Adam Barth.
757
758         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
759         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
760         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
761         to comments being exposed.
762
763 2011-10-03  James Robinson  <jamesr@chromium.org>
764
765         Add myself to the watchlist for platform/graphics/chromium
766         https://bugs.webkit.org/show_bug.cgi?id=69297
767
768         Reviewed by David Levin.
769
770         * Scripts/webkitpy/common/config/watchlist:
771
772 2011-10-03  Anders Carlsson  <andersca@apple.com>
773
774         Remove custom scrollbar painting hooks
775         https://bugs.webkit.org/show_bug.cgi?id=69163
776
777         Reviewed by Alexey Proskuryakov.
778
779         * DumpRenderTree/chromium/WebPreferences.cpp:
780         (WebPreferences::applyTo):
781         No need to enable custom scrollbar painting.
782
783 2011-10-03  David Levin  <levin@chromium.org>
784
785         watchlist: Make watchlist run on a bot.
786         https://bugs.webkit.org/show_bug.cgi?id=68974
787
788         Reviewed by Adam Barth.
789
790         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
791         * Scripts/webkitpy/tool/commands/queues_unittest.py:
792         Change to log what is run so that we can see the style command
793         and the watchlist command being run.
794
795 2011-10-03  David Levin  <levin@chromium.org>
796
797         watchlist: Allow specified a bug to attach the watchlist info to.
798         https://bugs.webkit.org/show_bug.cgi?id=69288
799
800         Reviewed by Eric Seidel.
801
802         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
803         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
804         Add tests and fix an existing test because the unit tests do not go through the
805         normal command line processing (so the -g argument remained when we determined bug ids).
806         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
807         get the assert raises regex method.
808         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
809
810 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
811
812         [EFL] DRT: Add JSStringUtils.{cpp,h}
813         https://bugs.webkit.org/show_bug.cgi?id=66397
814
815         Reviewed by Ryosuke Niwa.
816         
817         Adds helper functions to compare the equality of C-style strings and
818         JSStringRef objects.
819
820         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
821         (equals):
822         * DumpRenderTree/efl/JSStringUtils.h: Added.
823
824 2011-10-03  Adam Barth  <abarth@webkit.org>
825
826         garden-o-matic should work in Safari 5.1
827         https://bugs.webkit.org/show_bug.cgi?id=69290
828
829         Reviewed by Sam Weinig.
830
831         My old implementation of bind was too clever by half.  This one seems
832         to work better, at least according to this test.
833
834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
836
837 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
838
839         Unreviewed: change my e-mail in commiters.py
840
841         (I'm leaving the company and my @openbossa.org will be no more)
842
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
844
845 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
846
847         Correct post-build step for WinCairo test runs.
848         https://bugs.webkit.org/show_bug.cgi?id=69191 
849
850         Reviewed by Brian Weinstein.
851
852         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
853         shell case to handle the CFLite build.
854
855 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
856
857         Added myself to reviewers, because I'm now a reviewer.
858
859         * Scripts/webkitpy/common/config/committers.py:
860
861 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
862
863         Bencher script makes it difficult to do automated performance testing
864         https://bugs.webkit.org/show_bug.cgi?id=69207
865
866         Reviewed by Sam Weinig.
867         
868         This adds two new features:
869         
870         The ability to disable automatic VM detection, which is flaky if any
871         profiling features are enabled in jsc.
872         
873         The ability to compute, and report, a scaled result for all benchmark
874         suites. It is the geometric mean of three numbers: SunSpider's
875         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
876         It is also possible to turn off all other output from bencher and just
877         get this number with the --brief option.
878
879         * Scripts/bencher:
880
881 2011-10-01  Sam Weinig  <sam@webkit.org>
882
883         WTR is not successfully changing the NSUserDefaults
884         https://bugs.webkit.org/show_bug.cgi?id=69204
885
886         Reviewed by Dan Bernstein.
887
888         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
889         (WTR::InjectedBundle::platformInitialize):
890         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
891         get our overrides picked up.
892
893 2011-09-30  Daniel Bates  <dbates@rim.com>
894
895         Cleanup: Extract code to launch a Mac WebKit application into a common function
896         https://bugs.webkit.org/show_bug.cgi?id=68662
897
898         Reviewed by Adam Roben.
899
900         Extracts common code to launch a WebKit application on Mac OS X into a function
901         so that we can remove duplicate code.
902
903         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
904         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
905         (runMacWebKitApp): Added.
906         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
907         (runMiniBrowser): Ditto.
908         (runWebKitTestRunner): Ditto.
909         (runTestWebKitAPI): Ditto.
910
911 2011-09-29  David Levin  <levin@chromium.org>
912
913         watchlist: Add webkit-patch command to run watchlist.
914         https://bugs.webkit.org/show_bug.cgi?id=68973
915
916         Reviewed by Eric Seidel.
917
918         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
919         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
920         the cc and messages as sorted lists. To allow for deterministic ordering.
921         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
922         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
923         that it will be exposed as a command by webkit-patch.
924         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
925         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
926         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
927         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
928         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
929         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
930         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
931         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
932
933 2011-09-30  David Levin  <levin@chromium.org>
934
935         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
936         https://bugs.webkit.org/show_bug.cgi?id=69031
937
938         Reviewed by Adam Barth.
939
940         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
941         a comment to explain something important about the email addresses, and
942         a comment to let emacs know to treat the file as a python file.
943         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
944         Detects increases or decreases in a pattern.
945         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
946         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
947         Added unit tests for watchlist which has "more" or "less".
948         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
949         Added support for "more" or "less".
950
951 2011-09-30  Sam Weinig  <sam@webkit.org>
952
953         Add support for eventSender.mouseScrollBy in WTR
954         https://bugs.webkit.org/show_bug.cgi?id=69189
955
956         Add implementation of eventSender.mouseScrollBy for the mac.
957
958         Reviewed by Simon Fraser.
959
960         * WebKitTestRunner/EventSenderProxy.h:
961         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
962         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
963         (WTR::EventSendingController::keyDown):
964         (WTR::EventSendingController::mouseScrollBy):
965         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
966         * WebKitTestRunner/TestController.cpp:
967         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
968         * WebKitTestRunner/mac/EventSenderProxy.mm:
969         (WTR::EventSenderProxy::mouseScrollBy):
970
971 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
972
973         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
974         https://bugs.webkit.org/show_bug.cgi?id=35273
975
976         Reviewed by Dan Bernstein.
977         
978         There are two types of font issue that can cause layout test failure.
979         First, the user may have non-standard fonts installed that affect the layout
980         of some tests. For example, some tests use the MS Gothic font if installed.
981         
982         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
983         which override the system fonts (e.g. a copy of Arial from MS Office). For
984         some tests, this can affect font metrics or fallback behavior.
985         
986         This change addresses the first problem only. It limits the set of fonts
987         available through NSFontManager, by swizzling some methods to return
988         a list of fonts or font families which only include fonts from a hardcoded
989         whitelist.
990         
991         * DumpRenderTree/mac/DumpRenderTree.mm:
992         (allowedFontFamilySet):
993         (drt_NSFontManager_availableFontFamilies):
994         (drt_NSFontManager_availableFonts):
995         (swizzleNSFontManagerMethods):
996         (activateTestingFonts):
997         (adjustFonts):
998         (createWebViewAndOffscreenWindow):
999         (prepareConsistentTestingEnvironment):
1000         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1001         (WTR::allowedFontFamilySet):
1002         (WTR::drt_NSFontManager_availableFontFamilies):
1003         (WTR::drt_NSFontManager_availableFonts):
1004         (WTR::swizzleNSFontManagerMethods):
1005         (WTR::InjectedBundle::platformInitialize):
1006
1007 2011-09-30  David Levin  <levin@chromium.org>
1008
1009         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
1010         https://bugs.webkit.org/show_bug.cgi?id=69039
1011
1012         Reviewed by Adam Barth.
1013
1014         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1015         Actually skip only one specific test that is failing on Windows.
1016
1017 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1018
1019         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
1020
1021         For DRT we didn't install the message handler early enough to
1022         catch output while constructing the QApplication. For WTR we
1023         didn't even install a message handler.
1024
1025         Since the UI process will forward any output from the web process
1026         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
1027         in WTR before the web process is started. This is picked up by the
1028         web process which installs its own message handler.
1029
1030         The environment variable can be overriden on the command line if you
1031         want to see output from the web process, or you can pass --verbose to
1032         WTR to see output from both processes.
1033
1034         https://bugs.webkit.org/show_bug.cgi?id=69132
1035
1036         Reviewed by Andreas Kling.
1037
1038         * DumpRenderTree/qt/main.cpp:
1039         * WebKitTestRunner/qt/main.cpp:
1040
1041 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1042
1043         [Qt] Make sure WTR sizes the window and item correctly
1044
1045         Revision 96345 changed the logic for how the view and
1046         window was created, but missed a vital part, setting
1047         the size.
1048
1049         We now use a QSGView for the window, that has a simple
1050         item as its root object that is always resized to fit
1051         within the window. The webview is then parented to the
1052         root object and set to anchors.fill: parent. That way
1053         any window geometry changes will propagate to the web
1054         view.
1055
1056         https://bugs.webkit.org/show_bug.cgi?id=69134
1057
1058         Reviewed by Andreas Kling.
1059
1060         * WebKitTestRunner/PlatformWebView.h:
1061         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1062
1063 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
1064
1065         [EFL] Only save the current viewport in PixelDumpSupportEfl.
1066         https://bugs.webkit.org/show_bug.cgi?id=68450
1067
1068         Reviewed by Antonio Gomes.
1069
1070         The previous implementation saved the whole page contents in the final
1071         PNG, however the baselines and expectations in the tree only want the
1072         current viewport (with a scrollbar, if needed), so we now only save the
1073         currently visible contents.
1074
1075         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1076         (createBitmapContextFromWebView): Use
1077         ewk_frame_visible_content_geometry_get instead of
1078         ewk_frame_contents_size_get.
1079
1080 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
1081
1082         [EFL] Support and keep track of extra windows (views).
1083         https://bugs.webkit.org/show_bug.cgi?id=68454
1084
1085         Reviewed by Antonio Gomes.
1086
1087         So far, window.open and related JavaScript code would not work, as
1088         DRTView did not implementation
1089         Ewk_View_Smart_Class::window_{open,close}. The default implementation
1090         in ewk just returns the current window/view, which broke any
1091         layouttest which relied on window.open.
1092
1093         We now properly create and remove these new views. Unfortunately, the
1094         current way ewk works (and due to the fact that we cannot pass class
1095         methods as function pointers to the EFL functions), DRTView needs to
1096         know that DRTChrome exists and call `browser' directly in some points.
1097
1098         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1099         (onWindowCreate):
1100         (onWindowCloseDelayed):
1101         (onWindowClose):
1102         (drtViewTiledAdd):
1103
1104 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
1105
1106         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
1107         https://bugs.webkit.org/show_bug.cgi?id=42698
1108
1109         Reviewed by Andreas Kling.
1110
1111         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
1112         and call clearApplicationCache when layoutTest start up.
1113
1114         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1115         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1116         (WTR::InjectedBundle::beginTesting):
1117         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1118         (WTR::LayoutTestController::clearAllApplicationCaches):
1119         (WTR::LayoutTestController::setAppCacheMaximumSize):
1120         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1121
1122 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
1123
1124         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
1125         https://bugs.webkit.org/show_bug.cgi?id=69145
1126
1127         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
1128         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
1129         and is perfectly suitable for SceneGraph as well. GraphicsScene events
1130         will not be available in QtGui anymore in future. Therefore we also have to change
1131         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
1132
1133         Reviewed by Chang Shu.
1134
1135         * WebKitTestRunner/EventSenderProxy.h:
1136         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1137         (WTR::EventSenderProxy::createMouseEvent):
1138         (WTR::EventSenderProxy::mouseDown):
1139         (WTR::EventSenderProxy::mouseUp):
1140         (WTR::EventSenderProxy::mouseMoveTo):
1141
1142 2011-09-30  James Robinson  <jamesr@chromium.org>
1143
1144         [chromium] Add WebKit API for sending input events to the compositor thread
1145         https://bugs.webkit.org/show_bug.cgi?id=69117
1146
1147         Reviewed by Darin Fisher.
1148
1149         Adds support for creating and setting a compositor thread in DRT.
1150
1151         * DumpRenderTree/chromium/WebViewHost.cpp:
1152         (WebViewHost::WebViewHost):
1153         * DumpRenderTree/chromium/WebViewHost.h:
1154
1155 2011-09-29  David Levin  <levin@chromium.org>
1156
1157         watchlist: Add cross-checks for WatchList once it is filled.
1158         https://bugs.webkit.org/show_bug.cgi?id=68975
1159
1160         Reviewed by Eric Seidel.
1161
1162         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
1163         instead of having trivial getter and setters.
1164         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
1165         pass the validation checks.
1166         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
1167         and fix a few style nits.
1168         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
1169         validation checks.
1170         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
1171
1172 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
1173
1174         run-api-tests fails on chromium-win bot
1175         https://bugs.webkit.org/show_bug.cgi?id=69121
1176
1177         On Windows running a perl script needs the interpreter.
1178
1179         Reviewed by Adam Barth.
1180
1181         * Scripts/run-api-tests:
1182         (buildTestTool):
1183
1184 2011-09-29  Adam Barth  <abarth@webkit.org>
1185
1186         Attempt to make this tool work on Windows.
1187
1188         * Scripts/run-api-tests:
1189         (buildTestTool):
1190
1191 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1192
1193         [Qt] Try to fix the minial build
1194
1195         * QtTestBrowser/launcherwindow.cpp:
1196         * QtTestBrowser/webpage.cpp:
1197
1198 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1199
1200         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1201
1202         QWidget and friends now live in the QtWidgets library. We update
1203         includes in implementation files and private headers to us the
1204         non-module-prefixed path, and leave the lookup for the include
1205         path. For public headers we have to ifdef the includes as the
1206         user might now have the modules we need in his QT config.
1207
1208         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1209         have to update our code and use windowHandle() for setting the
1210         parent relationships.
1211
1212         https://bugs.webkit.org/show_bug.cgi?id=68687
1213
1214         Reviewed by Andreas Kling.
1215
1216         * DumpRenderTree/qt/DumpRenderTree.pro:
1217         * DumpRenderTree/qt/ImageDiff.pro:
1218         * MiniBrowser/qt/BrowserView.cpp:
1219         * MiniBrowser/qt/BrowserView.h:
1220         * MiniBrowser/qt/BrowserWindow.cpp:
1221         * MiniBrowser/qt/BrowserWindow.h:
1222         * MiniBrowser/qt/MiniBrowser.pro:
1223         * MiniBrowser/qt/MiniBrowserApplication.h:
1224         * MiniBrowser/qt/main.cpp:
1225         * QtTestBrowser/QtTestBrowser.pro:
1226         * QtTestBrowser/launcherwindow.cpp:
1227         * QtTestBrowser/launcherwindow.h:
1228         * QtTestBrowser/locationedit.h:
1229         * QtTestBrowser/main.cpp:
1230         * QtTestBrowser/mainwindow.cpp:
1231         * QtTestBrowser/mainwindow.h:
1232         * QtTestBrowser/webinspector.h:
1233         * QtTestBrowser/webpage.cpp:
1234         * QtTestBrowser/webview.cpp:
1235         * WebKitTestRunner/PlatformWebView.h:
1236         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1237
1238 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
1239
1240         Initial implementation of WebInspector for WebKit2 GTK port.
1241         https://bugs.webkit.org/show_bug.cgi?id=68235
1242
1243         Reviewed by Martin Robinson.
1244
1245         * MiniBrowser/gtk/BrowserWindow.c:
1246         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
1247
1248 2011-09-29  Adam Barth  <abarth@webkit.org>
1249
1250         Unbreak the "update expectatations" button by using the existing
1251         machinery to create the failureInfo objects.
1252
1253         Unbreak the "close" button on the progress dialog by using |this|
1254         instead of the old name of the object.
1255
1256         Teach the controllers unit test not to talk to the actual network.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
1260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1261
1262 2011-09-29  Hans Wennborg  <hans@chromium.org>
1263
1264         IndexedDB: Use LevelDB also for in-memory databases
1265         https://bugs.webkit.org/show_bug.cgi?id=68903
1266
1267         Reviewed by Steve Block.
1268
1269         Remove the temporary dir that was necessary before LevelDB supported
1270         in-memory databases.
1271
1272         * DumpRenderTree/chromium/TestShell.cpp:
1273         (TestShell::TestShell):
1274         * DumpRenderTree/chromium/TestShell.h:
1275
1276 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1277
1278         Run TestWebKitAPI on Chromium buildbots
1279         https://bugs.webkit.org/show_bug.cgi?id=68678
1280
1281         Reviewed by Tony Chang.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1284
1285 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
1286
1287         garden-o-matic results should anticipate 0 unexpected failures.
1288         https://bugs.webkit.org/show_bug.cgi?id=69036
1289
1290         Also fixes controllers: UnexpectedFailures test.
1291
1292         Reviewed by Adam Barth.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
1295
1296 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
1297
1298         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
1299
1300         https://bugs.webkit.org/show_bug.cgi?id=67253
1301
1302         Reviewed by Eric Seidel.
1303
1304         Nearly all of the work in this was done by Simon Fraser; I'm
1305         just repackaging it and cleaning it up a bit. This change
1306         modifies port.diff_image() to return a tuple of (pass/fail,
1307         %age), adds the value to the FailureImageHashMismatch, and
1308         writes the value into the full_results.json files to be
1309         displayed in the results page.
1310
1311         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1312         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1313         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1314         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1315         * Scripts/webkitpy/layout_tests/port/base.py:
1316         * Scripts/webkitpy/layout_tests/port/chromium.py:
1317         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1318         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1319         * Scripts/webkitpy/layout_tests/port/test.py:
1320         * Scripts/webkitpy/layout_tests/port/webkit.py:
1321         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1322
1323 2011-09-25  Kentaro Hara  <haraken@chromium.org>
1324
1325         Unreviewed. Adding myself to committers.py.
1326
1327         * Scripts/webkitpy/common/config/committers.py:
1328
1329 2011-09-28  Adam Barth  <abarth@webkit.org>
1330
1331         garden-o-matic shouldn't depend on test-results.appspot.com
1332         https://bugs.webkit.org/show_bug.cgi?id=69019
1333
1334         Reviewed by Dimitri Glazkov.
1335
1336         This patch moves garden-o-matic from getting full_results.json from
1337         test-results.appspot.com to getting that information directly from the
1338         buildbot.  This patch improve the load time and accuracy of
1339         garden-o-matic because test-results.appspot.com is slow and is dropping
1340         a significant number of writes (see
1341         https://bugs.webkit.org/show_bug.cgi?id=68748).
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1346
1347 2011-09-28  David Levin  <levin@chromium.org>
1348
1349         watchlist: Add a way to load the watchlist from config.
1350         https://bugs.webkit.org/show_bug.cgi?id=68991
1351
1352         Reviewed by Eric Seidel.
1353
1354         * Scripts/webkitpy/common/config/watchlist: Added.
1355         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
1356         Support for loading the watch list.
1357         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
1358         Tests for the loading.
1359         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1360         Adjusted to use the common base class.
1361         * Scripts/webkitpy/common/webkitunittest.py: Added.
1362         Made a common base class for functionality used in more than one.
1363
1364 2011-09-28  David Levin  <levin@chromium.org>
1365
1366         Attempt fix for Leopard python unit test run.
1367
1368         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1369
1370 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
1371
1372         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
1373         https://bugs.webkit.org/show_bug.cgi?id=68938
1374
1375         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
1376
1377         Reviewed by David Hyatt.
1378
1379         * DumpRenderTree/chromium/WebViewHost.cpp:
1380         (WebViewHost::didUpdateLayout): Added width/height queries.
1381         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
1382
1383 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
1384
1385         Get rebaseline server running again
1386         https://bugs.webkit.org/show_bug.cgi?id=69020
1387
1388         Reviewed by Adam Barth.
1389
1390         Make rebaseline server run again after r90337 (missing format_date_time
1391         import, results_json wasn't outputting anything).
1392
1393         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1394         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1395
1396 2011-09-28  David Grogan  <dgrogan@chromium.org>
1397
1398         Move dgrogan from contributor to committer
1399         https://bugs.webkit.org/show_bug.cgi?id=69021
1400
1401         * Scripts/webkitpy/common/config/committers.py:
1402
1403 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
1404
1405         Add Mac Skia GPU bots to builders.py
1406         https://bugs.webkit.org/show_bug.cgi?id=69016
1407
1408         Reviewed by Eric Seidel.
1409
1410         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
1411         GPU tests.
1412
1413         * Scripts/webkitpy/layout_tests/port/builders.py:
1414         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1415
1416 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1417
1418         Second try at fixing the GTK+ build.
1419
1420         * GNUmakefile.am:
1421
1422 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1423
1424         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
1425         https://bugs.webkit.org/show_bug.cgi?id=68680
1426
1427         Reviewed by Tony Chang.
1428
1429         * Scripts/run-chromium-webkit-unit-tests:
1430         * Scripts/webkitdirs.pm:
1431         (determineBaseProductDir):
1432
1433 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1434
1435         [Gtk] Implement textInputController.doCommand
1436         https://bugs.webkit.org/show_bug.cgi?id=66496
1437
1438         Reviewed by Martin Robinson.
1439
1440         * DumpRenderTree/gtk/TextInputController.cpp:
1441         (doCommandCallback): Callback function for textInputController.doCommand
1442
1443 2011-09-28  David Levin  <levin@chromium.org>
1444
1445         watchlist: Suggest corrections for typos and improve error message consistency.
1446         https://bugs.webkit.org/show_bug.cgi?id=68976
1447
1448         Reviewed by Adam Barth.
1449
1450         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
1451         for typos and improve consistency of the error messages.
1452         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
1453         and improve the regex that were already present.
1454
1455 2011-09-28  David Levin  <levin@chromium.org>
1456
1457         watchlist: Add support for matching added or deleted lines.
1458         https://bugs.webkit.org/show_bug.cgi?id=68972
1459
1460         Reviewed by Adam Barth.
1461
1462         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
1463         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
1464         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
1465         to the pattern match to only have the diff lines instead of the DiffFile.
1466         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1467         Add tests for the new patterns and combinations of the patterns.
1468         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1469         Sort imports. Add changeline support.
1470
1471 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GTK] Add WebKitError to GTK+ WebKit2 API
1474         https://bugs.webkit.org/show_bug.cgi?id=68508
1475
1476         Reviewed by Martin Robinson.
1477
1478         * GNUmakefile.am: Add path to webkitgtk derived sources to the
1479         include path.
1480
1481 2011-09-28  Philippe Normand  <pnormand@igalia.com>
1482
1483         [GTK] missing WebKit2 support in run-gtk-tests
1484         https://bugs.webkit.org/show_bug.cgi?id=68992
1485
1486         Rubber-stamped by Andreas Kling.
1487
1488         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
1489         webkit2 directory.
1490
1491 2011-09-27  Philippe Normand  <pnormand@igalia.com>
1492
1493         [GTK] build-webkit --no-webkit2 still builds WebKit2
1494         https://bugs.webkit.org/show_bug.cgi?id=68892
1495
1496         Reviewed by Martin Robinson.
1497
1498         Take the --no-webkit2 option in account when building WebKitGTK+.
1499
1500         * Scripts/build-webkit:
1501         * Scripts/webkitdirs.pm:
1502         (buildAutotoolsProject):
1503         (buildGtkProject):
1504
1505 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1506
1507         Make Chromium Win Release (Tests) a core builder
1508         https://bugs.webkit.org/show_bug.cgi?id=68906
1509
1510         Reviewed by Adam Barth.
1511
1512         Add Chromium Win Release (Tests) to the list of core builders.
1513
1514         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1515         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1516
1517 2011-09-27  Adam Barth  <abarth@webkit.org>
1518
1519         garden-o-matic should load faster and inform the user what is happening
1520         https://bugs.webkit.org/show_bug.cgi?id=68954
1521
1522         Reviewed by Dimitri Glazkov.
1523
1524         This test disables the expected failures tab.  The web inspector showed
1525         that loading the data for this tab was slowing down the loading time
1526         for the whole app.  We need to find a way to load that data lazily.
1527
1528         This patch also improves the update message to better describe the
1529         progress the app is making analyzing data from the buildbot.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1534
1535 2011-09-27  Adam Barth  <abarth@webkit.org>
1536
1537         garden-o-matic should show the first result when examining results
1538         https://bugs.webkit.org/show_bug.cgi?id=68960
1539
1540         Reviewed by Dimitri Glazkov.
1541
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1543
1544 2011-09-27  David Levin  <levin@chromium.org>
1545
1546         watchlist: Add support for cc and message rules.
1547         https://bugs.webkit.org/show_bug.cgi?id=68950
1548
1549         Reviewed by Adam Barth.
1550
1551         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
1552         the cc's and messages for a patch.
1553         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
1554         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
1555         for the rules.
1556         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
1557         A generic encapsulation of either a message list or a cc list.
1558         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
1559
1560 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
1561
1562         webkit-patch doesn't like UTF-8 characters in reviewers names
1563         https://bugs.webkit.org/show_bug.cgi?id=63452
1564
1565         Reviewed by Eric Seidel.
1566
1567         * Scripts/webkit-patch:
1568
1569 2011-09-27  Adam Barth  <abarth@webkit.org>
1570
1571         garden-o-matic examine buttons shows both expected and unexpected failures
1572         https://bugs.webkit.org/show_bug.cgi?id=68918
1573
1574         Reviewed by Dimitri Glazkov.
1575
1576         This was a copy/paste error when I refactored this classes to share
1577         more code.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1580
1581 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
1582
1583         Add Kaustubh Atrawalkar to the list of contributors.
1584
1585         * Scripts/webkitpy/common/config/committers.py:
1586
1587 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
1588
1589         [Chromium] Fixed layout mode tests break subsequent tests
1590         https://bugs.webkit.org/show_bug.cgi?id=68923
1591         
1592         Reviewed by Adam Barth.        
1593
1594         Reset fixed layout mode between tests, so that tests that run after
1595         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
1596         regular 800x600 non-fixed layout.
1597
1598         * DumpRenderTree/chromium/TestShell.cpp:
1599         (TestShell::resetTestController):
1600
1601 2011-09-27  David Levin  <levin@chromium.org>
1602
1603         watchlist: Add the filename pattern for definitions.
1604         https://bugs.webkit.org/show_bug.cgi?id=68917
1605
1606         Reviewed by Adam Barth.
1607
1608         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
1609         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
1610         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
1611         for definitions.
1612         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
1613         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
1614
1615 2011-09-27  Adam Barth  <abarth@webkit.org>
1616
1617         garden-o-matic results view should sort test and builder names
1618         https://bugs.webkit.org/show_bug.cgi?id=68488
1619
1620         Reviewed by Andy Estes.
1621
1622         Previously, the test and builder names were displayed in an arbitrary
1623         order that changed from time to time.  That confused one user study
1624         participant.  This patch sorts the lists so that they occur in a
1625         predictable order.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1628
1629 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1630
1631         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
1632         http://trac.webkit.org/changeset/96108
1633         http://trac.webkit.org/changeset/96111
1634         http://trac.webkit.org/changeset/96113
1635         http://trac.webkit.org/changeset/96116
1636         https://bugs.webkit.org/show_bug.cgi?id=68913
1637
1638         Wait for working Qt5 (Requested by ossy on #webkit).
1639
1640         * DumpRenderTree/qt/DumpRenderTree.pro:
1641         * DumpRenderTree/qt/ImageDiff.pro:
1642         * MiniBrowser/qt/BrowserView.cpp:
1643         (BrowserView::BrowserView):
1644         * MiniBrowser/qt/BrowserView.h:
1645         * MiniBrowser/qt/BrowserWindow.cpp:
1646         (BrowserWindow::BrowserWindow):
1647         (BrowserWindow::urlChanged):
1648         (BrowserWindow::~BrowserWindow):
1649         * MiniBrowser/qt/BrowserWindow.h:
1650         * MiniBrowser/qt/MiniBrowser.pro:
1651         * MiniBrowser/qt/MiniBrowserApplication.h:
1652         * MiniBrowser/qt/main.cpp:
1653         * QtTestBrowser/QtTestBrowser.pro:
1654         * QtTestBrowser/launcherwindow.cpp:
1655         * QtTestBrowser/launcherwindow.h:
1656         * QtTestBrowser/locationedit.h:
1657         * QtTestBrowser/main.cpp:
1658         * QtTestBrowser/mainwindow.cpp:
1659         * QtTestBrowser/mainwindow.h:
1660         * QtTestBrowser/webinspector.h:
1661         * QtTestBrowser/webpage.cpp:
1662         * QtTestBrowser/webview.cpp:
1663         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1664         * WebKitTestRunner/PlatformWebView.h:
1665         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1666         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1667         (WTR::WebView::wkView):
1668         (WTR::WebView::pageRef):
1669         (WTR::WebView::~WebView):
1670         (WTR::WebView::WebView):
1671         (WTR::PlatformWebView::PlatformWebView):
1672         (WTR::PlatformWebView::sendEvent):
1673         (WTR::PlatformWebView::postEvent):
1674         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1675
1676 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1677
1678         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
1679         https://bugs.webkit.org/show_bug.cgi?id=65178
1680
1681         Reviewed by Martin Robinson.
1682
1683         * GNUmakefile.am:
1684         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
1685
1686 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
1687
1688         [Qt][WK2] Buildfix after r96108.
1689
1690         Rubber-stamped by Andreas Kling.
1691
1692         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1693         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1694         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1695
1696 2011-09-27  David Levin  <levin@chromium.org>
1697
1698         watchlist: Change watchlistparser.py to be class based.
1699         https://bugs.webkit.org/show_bug.cgi?id=68869
1700
1701         Reviewed by Eric Seidel.
1702
1703         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1704         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1705
1706 2011-09-27  David Levin  <levin@chromium.org>
1707
1708         watchlist: Break out the diff boilerplate to allow for re-use.
1709         https://bugs.webkit.org/show_bug.cgi?id=68871
1710
1711         Reviewed by Eric Seidel.
1712
1713         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1714         Break out the diff into a new file.
1715         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
1716
1717 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
1718
1719         Web Inspector: UI performance: introduce heap size tracking stats.
1720         https://bugs.webkit.org/show_bug.cgi?id=68901
1721
1722         It is interesting how much the heap memory is used by Inspector in order of running the test.
1723
1724         Reviewed by Yury Semikhatsky.
1725
1726         * DumpRenderTree/chromium/TestShell.cpp:
1727         (TestShell::showDevTools):
1728         (TestShell::closeDevTools):
1729
1730 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1731
1732         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1733
1734         QWidget and friends now live in the QtWidgets library. We update
1735         includes in implementation files and private headers to us the
1736         non-module-prefixed path, and leave the lookup for the include
1737         path. For public headers we have to ifdef the includes as the
1738         user might now have the modules we need in his QT config.
1739
1740         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1741         have to update our code and use windowHandle() for setting the
1742         parent relationships.
1743
1744         https://bugs.webkit.org/show_bug.cgi?id=68687
1745
1746         Reviewed by Andreas Kling.
1747
1748         * DumpRenderTree/qt/DumpRenderTree.pro:
1749         * DumpRenderTree/qt/ImageDiff.pro:
1750         * MiniBrowser/qt/BrowserView.cpp:
1751         * MiniBrowser/qt/BrowserView.h:
1752         * MiniBrowser/qt/BrowserWindow.cpp:
1753         * MiniBrowser/qt/BrowserWindow.h:
1754         * MiniBrowser/qt/MiniBrowser.pro:
1755         * MiniBrowser/qt/MiniBrowserApplication.h:
1756         * MiniBrowser/qt/main.cpp:
1757         * QtTestBrowser/QtTestBrowser.pro:
1758         * QtTestBrowser/launcherwindow.cpp:
1759         * QtTestBrowser/launcherwindow.h:
1760         * QtTestBrowser/locationedit.h:
1761         * QtTestBrowser/main.cpp:
1762         * QtTestBrowser/mainwindow.cpp:
1763         * QtTestBrowser/mainwindow.h:
1764         * QtTestBrowser/webinspector.h:
1765         * QtTestBrowser/webpage.cpp:
1766         * QtTestBrowser/webview.cpp:
1767         * WebKitTestRunner/PlatformWebView.h:
1768         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1769
1770 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1771
1772         [Qt][WK2] Add support for hover API in Qt WebKit2
1773         https://bugs.webkit.org/show_bug.cgi?id=68369
1774
1775         Reviewed by Andreas Kling.
1776
1777         Change the statusbar to show the link URL when hovering links in
1778         MiniBrowser using QDesktopWebView.
1779
1780         * MiniBrowser/qt/BrowserWindow.cpp:
1781         (BrowserWindow::BrowserWindow):
1782         (BrowserWindow::onLinkHovered):
1783         * MiniBrowser/qt/BrowserWindow.h:
1784
1785 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1786
1787         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
1788         https://bugs.webkit.org/show_bug.cgi?id=68864
1789
1790         Reviewed by Adam Barth.
1791
1792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
1793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
1794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
1796
1797 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1798
1799         [Qt][WK2] One more unreviewed buildfix after r96005.
1800
1801         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
1802
1803 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1804
1805         [Qt][WK2] Unreviewed buildfix after r96005.
1806
1807         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1808         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1809
1810 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1811
1812         garden-o-matic should be pretty in Open Sans.
1813         https://bugs.webkit.org/show_bug.cgi?id=68845
1814
1815         Reviewed by Adam Barth.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
1818
1819 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1820
1821         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
1822         https://bugs.webkit.org/show_bug.cgi?id=68841
1823
1824         Reviewed by Adam Barth.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
1829
1830 2011-09-26  David Levin  <levin@chromium.org>
1831
1832         watchlist: Add parsing for definition section.
1833         https://bugs.webkit.org/show_bug.cgi?id=68850
1834
1835         Reviewed by Adam Barth.
1836
1837         * Scripts/webkitpy/common/watchlist/watchlist.py:
1838         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1839         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1840
1841 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1842
1843         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
1844
1845         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1846         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1847         * WebKitTestRunner/win/TestInvocationWin.cpp:
1848         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1849
1850 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1851
1852         Repaint tests don't work in WebKit2
1853         https://bugs.webkit.org/show_bug.cgi?id=68453
1854
1855         Reviewed by Sam Weinig.
1856         
1857         Convert DumpRenderTree to use use the repaint rects
1858         exposed via WebKit API when generating the repaint test
1859         overlay.
1860         
1861         Fix WebKitTestRunner to work with repaint tests, again
1862         using the repaint rects exposed from WK2.
1863         
1864         In both cases, layoutTestController.display() now just
1865         forces a display of the web view, and turns on repaint
1866         rect tracking on the main FrameView.
1867         
1868         Later, when pixel results are requested, the alpha overlay
1869         that shows the repaint rects is generated using the list
1870         of rects supplied by WebCore.
1871
1872         * DumpRenderTree/mac/DumpRenderTree.mm:
1873         (resetDefaultsToConsistentValues):
1874         (resetWebViewToConsistentStateBeforeTesting):
1875         (displayWebView):
1876         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1877         (paintRepaintRectOverlay):
1878         (createBitmapContextFromWebView):
1879         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1880         (WTR::InjectedBundle::beginTesting):
1881         (WTR::InjectedBundle::done):
1882         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1883         (WTR::InjectedBundle::setRepaintRects):
1884         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1885         (WTR::InjectedBundlePage::reset):
1886         (WTR::InjectedBundlePage::dump):
1887         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1888         (WTR::LayoutTestController::display):
1889         * WebKitTestRunner/TestInvocation.cpp:
1890         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1891         * WebKitTestRunner/TestInvocation.h:
1892         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1893         (WTR::paintRepaintRectOverlay):
1894         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1895
1896 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1897
1898         Get hover'ed element URL from HitTest.
1899
1900         mouseDidMoveOverElement now gets the hover'ed element link using
1901         WKHitTestResult API's.
1902         https://bugs.webkit.org/show_bug.cgi?id=68426 
1903
1904         Reviewed by Anders Carlsson.
1905
1906         * MiniBrowser/gtk/BrowserWindow.c:
1907         (mouseDidMoveOverElement):
1908
1909 2011-09-26  David Levin  <levin@chromium.org>
1910
1911         Add skeleton parsing for a WatchList.
1912         https://bugs.webkit.org/show_bug.cgi?id=68823
1913
1914         Reviewed by Adam Barth.
1915
1916         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1917         Parses the top level watch list sections -- none are defined yet -- and
1918         throws an exception if an invalid one is listed.
1919         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1920         Verify the exception for an invalid section in a watch list.
1921         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1922
1923 2011-09-26  Adam Roben  <aroben@apple.com>
1924
1925         Clean up code imported from WebKitAPITest
1926
1927         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1928         TestWebKitAPI conventions
1929
1930         Reviewed by David Levin.
1931
1932         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1933         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1934         namespace name.
1935
1936         (TestWebKitAPI::WebViewDestruction::SetUp):
1937         (TestWebKitAPI::WebViewDestruction::webViewCount):
1938         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1939         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1940         (TestWebKitAPI::WebViewDestruction::TearDown):
1941         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1942         Moved functionality from free functions into these new test fixtures.
1943
1944         * TestWebKitAPI/win/HostWindow.cpp:
1945         * TestWebKitAPI/win/HostWindow.h:
1946         Prefixed Win32 API calls with ::. Updated namespace name.
1947
1948 2011-09-23  Adam Roben  <aroben@apple.com>
1949
1950         Merge WebKitAPITest into TestWebKitAPI
1951
1952         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1953
1954         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1955         them more idiomatic in a separate pass.
1956
1957         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1958         functionality (and names!)
1959
1960         Reviewed by Anders Carlsson.
1961
1962         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1963         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1964         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1965
1966         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1967
1968         * TestWebKitAPI/win/main.cpp:
1969         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1970
1971         * WebKitAPITest: Removed this directory and its contents.
1972
1973 2011-09-23  Adam Roben  <aroben@apple.com>
1974
1975         Remove two failing WebKitAPITest tests
1976
1977         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1978
1979         Reviewed by Anders Carlsson.
1980
1981         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1982         MainFrameAfterClose tests.
1983
1984 2011-09-25  Adam Barth  <abarth@webkit.org>
1985
1986         Finish removing PLATFORM(BREWMP) by removing associated code
1987         https://bugs.webkit.org/show_bug.cgi?id=68779
1988
1989         Reviewed by Sam Weinig.
1990
1991         * Scripts/webkitpy/common/config/build.py:
1992         * waf/build/settings.py:
1993
1994 2011-09-21  Ai Makabi  <makabi@google.com>
1995
1996         Provides a simple LRU cache class in Python.
1997
1998         https://bugs.webkit.org/show_bug.cgi?id=67823
1999
2000         Reviewed by Tony Chang.
2001
2002         * Scripts/webkitpy/common/lru_cache.py:
2003         * Scripts/webkitpy/common/lru_cache_unittest.py:
2004
2005 2011-09-25  Adam Barth  <abarth@webkit.org>
2006
2007         Remove PLATFORM(HAIKU) and associated code
2008         https://bugs.webkit.org/show_bug.cgi?id=68774
2009
2010         Reviewed by Sam Weinig.
2011
2012         * Scripts/webkitpy/common/config/build.py:
2013         * waf/build/settings.py:
2014
2015 2011-09-24  Adam Barth  <abarth@webkit.org>
2016
2017         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
2018         https://bugs.webkit.org/show_bug.cgi?id=68767
2019
2020         Reviewed by Eric Seidel.
2021
2022         * Scripts/build-webkit:
2023
2024 2011-09-24  Adam Barth  <abarth@webkit.org>
2025
2026         Remove ENABLE(WCSS) and associated code
2027         https://bugs.webkit.org/show_bug.cgi?id=68759
2028
2029         Reviewed by Darin Adler.
2030
2031         * Scripts/build-webkit:
2032         * Scripts/old-run-webkit-tests:
2033         * Scripts/webkitperl/features.pm:
2034         (hasFeature):
2035         * Scripts/webkitpy/layout_tests/port/webkit.py:
2036         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2037
2038 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
2039
2040         Fixed GTK compilation after r95878, the operator== was defined
2041         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
2042
2043         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2044
2045 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
2046
2047         [DRT] Include the right config file for EFL's DRT.
2048         https://bugs.webkit.org/show_bug.cgi?id=67042
2049
2050         Reviewed by Martin Robinson.
2051
2052         Ports which use CMake as their buildsystem (such as the EFL one) also
2053         have config.h files, but they are named differently, so include the
2054         right one depending on the buildsystem being used.
2055
2056         * DumpRenderTree/config.h:
2057
2058 2011-09-23  Adam Klein  <adamk@chromium.org>
2059
2060         Add ENABLE_MUTATION_OBSERVERS feature flag
2061         https://bugs.webkit.org/show_bug.cgi?id=68732
2062
2063         Reviewed by Ojan Vafai.
2064
2065         This flag will guard an implementation of the "Mutation Observers" proposed in
2066         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
2067
2068         * Scripts/build-webkit:
2069
2070 2011-09-23  Chang Shu  <cshu@webkit.org>
2071
2072         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
2073         https://bugs.webkit.org/show_bug.cgi?id=68556
2074
2075         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
2076
2077         Reviewed by Darin Adler.
2078
2079         * WebKitTestRunner/EventSenderProxy.h:
2080         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2081         * WebKitTestRunner/PlatformWebView.h:
2082         * WebKitTestRunner/mac/EventSenderProxy.mm:
2083         (WTR::EventSenderProxy::EventSenderProxy):
2084         (WTR::EventSenderProxy::leapForward):
2085         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2086         (WTR::EventSenderProxy::EventSenderProxy):
2087         (WTR::getMouseButton):
2088         (WTR::getModifiers):
2089         (WTR::EventSenderProxy::updateClickCountForButton):
2090         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
2091         (WTR::EventSenderProxy::mouseDown):
2092         (WTR::EventSenderProxy::mouseUp):
2093         (WTR::EventSenderProxy::mouseMoveTo):
2094         (WTR::EventSenderProxy::leapForward):
2095         (WTR::EventSenderProxy::sendOrQueueEvent):
2096         (WTR::EventSenderProxy::replaySavedEvents):
2097         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2098         (WTR::PlatformWebView::postEvent):
2099         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2100
2101 2011-09-23  Lei Zhang  <thestig@chromium.org>
2102
2103         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
2104         https://bugs.webkit.org/show_bug.cgi?id=68026
2105
2106         Reviewed by Dirk Pranke.
2107
2108         * Scripts/webkitpy/layout_tests/port/chromium.py:
2109
2110 2011-09-23  Elliot Poger  <epoger@google.com>
2111
2112         update layout_tests to account for new default of use_skia=1
2113         https://bugs.webkit.org/show_bug.cgi?id=68698
2114
2115         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
2116         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
2117         (Chromium-on-Mac now uses the Skia graphics library instead of
2118         Core Graphics).
2119
2120         Also updates layout_test code to work with that change.
2121
2122         Reviewed by Mihai Parparita.
2123
2124         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2125         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2126
2127 2011-09-23  Mark Rowe  <mrowe@apple.com>
2128
2129         Fix the build.
2130         
2131         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
2132         the WTF namespace.
2133
2134 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
2135
2136         enable NRWT for run-webkit-tests on Lion
2137         https://bugs.webkit.org/show_bug.cgi?id=68673
2138
2139         Reviewed by Eric Seidel.
2140
2141         * Scripts/run-webkit-tests:
2142         (useNewRunWebKitTests):
2143
2144 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2145
2146         Add unit test for existing StringBuilder
2147         https://bugs.webkit.org/show_bug.cgi?id=67080
2148
2149         Reviewed by Darin Adler.
2150
2151         * TestWebKitAPI/TestWebKitAPI.gypi:
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
2154         (operator<<):
2155         (TestWebKitAPI::expectBuilderContent):
2156         (TestWebKitAPI::expectEmpty):
2157         (TestWebKitAPI::TEST):
2158
2159 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
2160
2161         [EFL] Use ewk_view to navigate in history instead of ewk_history.
2162         https://bugs.webkit.org/show_bug.cgi?id=68455
2163
2164         Reviewed by Antonio Gomes.
2165
2166         BackForwardItem::invoke() was using ewk_history functions to navigate
2167         in history; however, this will only call WebCore::BackForwardListImpl
2168         and not move between pages at all. We now call ewk_view_navigate and
2169         its siblings to make sure the navigation actually happens.
2170
2171         This should make tests like fast/dom/navigation-type-back-forward.html
2172         stop timing out.
2173
2174         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2175         (BackForwardItem::invoke):
2176
2177 2011-09-22  Dean Jackson  <dino@apple.com>
2178
2179         Add ENABLE_CSS_FILTERS
2180         https://bugs.webkit.org/show_bug.cgi?id=68652
2181
2182         Reviewed by Simon Fraser.
2183
2184         * Scripts/build-webkit:
2185
2186 2011-09-22  Anders Carlsson  <andersca@apple.com>
2187
2188         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
2189         https://bugs.webkit.org/show_bug.cgi?id=68660
2190
2191         Reviewed by Adam Barth.
2192
2193         * WebKitTestRunner/mac/EventSenderProxy.mm:
2194         (WTR::EventSenderProxy::mouseUp):
2195
2196 2011-09-22  Adam Roben  <aroben@apple.com>
2197
2198         Remove FindSafari
2199
2200         It isn't used or built anymore.
2201
2202         Fixes <http://webkit.org/b/68628>
2203
2204         Reviewed by Darin Adler.
2205
2206         * FindSafari: Removed this directory and its contents.
2207
2208 2011-09-22  Adam Roben  <aroben@apple.com>
2209
2210         Remove FindSafari from all our .sln files
2211
2212         It isn't used anymore, so there's no point in building it.
2213
2214         Part of <http://webkit.org/b/68628> Remove FindSafari
2215
2216         Reviewed by Steve Falkenburg.
2217
2218         * DumpRenderTree/DumpRenderTree.sln:
2219         * WebKitTestRunner/WebKitTestRunner.sln:
2220
2221 2011-09-22  Adam Roben  <aroben@apple.com>
2222
2223         Remove all uses of FindSafari
2224
2225         It isn't really needed anymore.
2226
2227         Fixes <http://webkit.org/b/68626>.
2228
2229         Reviewed by Darin Adler.
2230
2231         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
2232
2233         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
2234         WebKit, but now we use WebKit.exe for that.
2235
2236         * Scripts/webkitdirs.pm:
2237         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
2238         do the same thing.
2239
2240         (readRegistryString):
2241         (writeRegistryString):
2242         Moved here from old-run-webkit-tests.
2243
2244 2011-09-22  Adam Roben  <aroben@apple.com>
2245
2246         Use the "direct object" form of system() to run WebKit.exe
2247
2248         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
2249         path to WebKit.exe.
2250
2251         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
2252         %WEBKITOUTPUTDIR%
2253
2254         Reviewed by Steve Falkenburg.
2255
2256         * Scripts/webkitdirs.pm:
2257         (runSafari):
2258
2259 2011-09-22  Adam Roben  <aroben@apple.com>
2260
2261         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
2262
2263         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
2264         spaces in the path to the WebKit source tree
2265
2266         Reviewed by John Sullivan.
2267
2268         * Scripts/webkitdirs.pm:
2269         (setupCygwinEnv):
2270
2271 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2272
2273         [Qt] Use same DPI for application font as rest of app in DRT and WTR
2274
2275         QApplication will initialize the default application font based
2276         on the application DPI at construction time, but we then override
2277         the application DPI using QX11Info (hard-coding it to 96 for
2278         consistency). This hard-coding is not reflected in the application
2279         font, so we explicitly have update the font ourselves.
2280
2281         The 6 test results that are updated were originally produced with
2282         a DPI of 75, as this is the default fallback DPI when a QFont is
2283         constructed before QApplication. This was wrong, and the results
2284         are updated to match a DPI of 96.
2285
2286         Reviewed by Csaba Osztrogonác.
2287
2288         * DumpRenderTree/qt/main.cpp:
2289         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2290
2291 2011-09-21  Anna Cavender  <annacc@chromium.org>
2292
2293         Update committers.py with a new contributor contact        
2294         https://bugs.webkit.org/show_bug.cgi?id=68565
2295
2296         Reviewed by Eric Carlson.
2297
2298         * Scripts/webkitpy/common/config/committers.py:
2299
2300 2011-09-21  Chang Shu  <cshu@webkit.org>
2301
2302         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
2303         https://bugs.webkit.org/show_bug.cgi?id=68108
2304
2305         This patch implements the event sender mouse events through WebKit2 UIProcess which is
2306         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
2307         platform as the first step so the existing code is still kept for other platforms.
2308
2309         Reviewed by Darin Adler.
2310
2311         * WebKitTestRunner/EventSenderProxy.h:
2312         (WTR::EventSenderProxy::EventSenderProxy):
2313         (WTR::EventSenderProxy::leapForward):
2314         (WTR::EventSenderProxy::currentEventTime):
2315         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2316         (WTR::EventSendingController::EventSendingController):
2317         (WTR::EventSendingController::mouseDown):
2318         (WTR::EventSendingController::mouseUp):
2319         (WTR::EventSendingController::mouseMoveTo):
2320         (WTR::EventSendingController::leapForward):
2321         (WTR::EventSendingController::keyDown):
2322         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2323         * WebKitTestRunner/TestController.cpp:
2324         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2325         * WebKitTestRunner/mac/EventSenderProxy.mm:
2326         (WTR::eventTypeForMouseButtonAndAction):
2327         (WTR::operator==):
2328         (WTR::EventSenderProxy::updateClickCountForButton):
2329         (WTR::EventSenderProxy::mouseDown):
2330         (WTR::EventSenderProxy::mouseUp):
2331         (WTR::EventSenderProxy::mouseMoveTo):
2332         (WTR::EventSenderProxy::keyDown):
2333         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2334         (WTR::EventSenderProxy::keyDown):
2335         (WTR::EventSenderProxy::mouseDown):
2336         (WTR::EventSenderProxy::mouseUp):
2337         (WTR::EventSenderProxy::mouseMoveTo):
2338
2339 2011-09-21  Dan Bernstein  <mitz@apple.com>
2340
2341         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
2342         https://bugs.webkit.org/show_bug.cgi?id=68451
2343
2344         Reviewed by Darin Adler.
2345
2346         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
2347         Objective-C classes with names not having one of a list of prefixes
2348         passed on the command line.
2349
2350 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
2351
2352         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
2353         https://bugs.webkit.org/show_bug.cgi?id=68206
2354
2355         Reviewed by Tony Chang.
2356
2357         * Scripts/webkitdirs.pm:
2358         (determineBaseProductDir): add support for chromium-mac
2359         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2360         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2361
2362 2011-09-21  Adam Barth  <abarth@webkit.org>
2363
2364         garden-o-matic command should explain that it is starting a local server
2365         https://bugs.webkit.org/show_bug.cgi?id=68486
2366
2367         Reviewed by Dimitri Glazkov.
2368
2369         In the user study, both participants didn't understand why the
2370         garden-o-matic command appeared to hang.  This patch adds an
2371         explaination of what's going on.  It also adds a confirmation prompt
2372         before launching the browser to give the user a chance to read the
2373         text.  If that's too much of a speed bump, we can iterate.
2374
2375         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2376
2377 2011-09-21  Chang Shu  <cshu@webkit.org>
2378
2379         [Qt] Implement KeyDown function for WebKit2 EventSender.
2380         https://bugs.webkit.org/show_bug.cgi?id=56485
2381
2382         Implement the KeyDown function on Qt platform.
2383
2384         Reviewed by Andreas Kling.
2385
2386         * WebKitTestRunner/PlatformWebView.h:
2387         * WebKitTestRunner/TestController.cpp:
2388         (WTR::TestController::TestController):
2389         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2390         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
2391         (WTR::getModifiers):
2392         (WTR::EventSenderProxy::keyDown):
2393         (buildModifierFlags):
2394         (EventSenderProxy::keyDown):
2395         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2396         (WTR::PlatformWebView::sendEvent):
2397         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2398
2399 2011-09-20  Adam Barth  <abarth@webkit.org>
2400
2401         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
2402         https://bugs.webkit.org/show_bug.cgi?id=68496
2403
2404         Reviewed by Dimitri Glazkov.
2405
2406         This patch adds a bunch of sorting to make sure things happen in a
2407         predictable order in both JavaScriptCore and V8.  We've talked before
2408         about whether these two JavaScript engines should enumerate
2409         dictionaries in the same order, but the consensus has been that they
2410         shouldn't.  Personally, I disagree with that consensus, but such is life.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2416
2417 2011-09-20  Adam Barth  <abarth@webkit.org>
2418
2419         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
2420         https://bugs.webkit.org/show_bug.cgi?id=68495
2421
2422         Reviewed by Dimitri Glazkov.
2423
2424         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2427
2428 2011-09-20  Eric Seidel  <eric@webkit.org>
2429
2430         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2431         https://bugs.webkit.org/show_bug.cgi?id=65781
2432
2433         Reviewed by Ryosuke Niwa.
2434
2435         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
2436         to resolve the passed in url relative to the absolute url for the test.
2437         For http tests, since the test url is an http url, we can't resolve relative
2438         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
2439         for resolving.
2440
2441         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2442         (which resolves the path relative to the built location of the DRT executable)
2443         and we should move this new code into a shared location in a follow-up patch.
2444
2445         It turns out that there was a second use for pathToLocalResource, used by one
2446         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
2447         To support this test I made the new pathToLocalResource smart enough to map
2448         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
2449
2450         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2451         (LayoutTestController::pathToLocalResource):
2452         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
2453
2454 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2455
2456         Need to specify a django version, instead of using default
2457         https://bugs.webkit.org/show_bug.cgi?id=68398
2458
2459         Reviewed by Eric Seidel.
2460
2461         * QueueStatusServer/__init__.py:
2462         * QueueStatusServer/main.py:
2463
2464 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2465
2466         Update committers.py with a few more contributor contacts
2467         https://bugs.webkit.org/show_bug.cgi?id=68487
2468
2469         Reviewed by Eric Seidel.
2470
2471         * Scripts/webkitpy/common/config/committers.py:
2472
2473 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2474
2475         Fix webkitpy unit tests after 95547 and 95549
2476         https://bugs.webkit.org/show_bug.cgi?id=68483
2477
2478         Reviewed by Adam Barth.
2479         
2480         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
2481
2482         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
2483         parse_entries_from_file(), use StringIO and entry.reviewer_text().
2484         While testing parse_latest_entry_from_file(), expect the correct
2485         touched_files() list.
2486
2487 2011-09-20  Adam Barth  <abarth@webkit.org>
2488
2489         garden-o-matic makes it hard to compare images when scroll bars appear
2490         https://bugs.webkit.org/show_bug.cgi?id=68482
2491
2492         Reviewed by Eric Seidel.
2493
2494         Because we autoscale image width, the images rescale if we overflow
2495         vertically and get a scrollbar.  That makes it hard to compare two sets
2496         of images.  This patch reserves space for the scrollbar so we won't
2497         have the layout change.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2500
2501 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2502
2503         Unreviewed, rolling out r95565.
2504         http://trac.webkit.org/changeset/95565
2505         https://bugs.webkit.org/show_bug.cgi?id=68470
2506
2507         Broke builds (Requested by andersca on #webkit).
2508
2509         * MiniBrowser/gtk/BrowserWindow.c:
2510         (mouseDidMoveOverElement):
2511
2512 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
2513
2514         Get hover'ed element URL from HitTest.
2515         
2516         mouseDidMoveOverElement now gets the hover'ed element link using
2517         WKHitTestResult API's.
2518         https://bugs.webkit.org/show_bug.cgi?id=68426
2519
2520         Reviewed by Anders Carlsson.
2521
2522         * MiniBrowser/gtk/BrowserWindow.c:
2523         (mouseDidMoveOverElement):
2524
2525 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2526
2527         Changelog class should have a method to return all entries
2528         https://bugs.webkit.org/show_bug.cgi?id=68399
2529         
2530         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
2531         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
2532
2533         Reviewed by Ryosuke Niwa.
2534
2535         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
2536         and adapt it to become a generator.
2537         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
2538
2539 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
2540
2541         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
2542         https://bugs.webkit.org/show_bug.cgi?id=51159
2543
2544         Permit any URL with a local scheme to set a user style sheet. Allow qrc
2545         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
2546         
2547         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
2548
2549         Reviewed by Kenneth Rohde Christiansen.
2550
2551         * DumpRenderTree/qt/DumpRenderTree.pro:
2552         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
2553         * DumpRenderTree/qt/resources/user.css: Added.
2554         (body):
2555         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2556         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
2557         * WebKitTestRunner/qt/resources/user.css: Added.
2558         (body):
2559
2560 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2561
2562         ChangeLogEntry class should contain a list of touched files
2563         https://bugs.webkit.org/show_bug.cgi?id=68115
2564
2565         Reviewed by Eric Seidel.
2566         
2567         Add method to return the list of files touched in a ChangeLog entry.
2568
2569         * Scripts/webkitpy/common/checkout/changelog.py: Add
2570         touched_files_regexp and touched_files() method.
2571         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
2572         unit tests for touched_files() method.
2573
2574 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2575
2576         Unreviewed, rolling out r95526 and r95541.
2577         http://trac.webkit.org/changeset/95526
2578         http://trac.webkit.org/changeset/95541
2579         https://bugs.webkit.org/show_bug.cgi?id=68443
2580
2581         It broke 6 tests (Requested by ossy_ on #webkit).
2582
2583         * DumpRenderTree/qt/main.cpp:
2584         (main):
2585         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2586         (WTR::activateFonts):
2587
2588 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2589
2590         Fix patch and bug numbering in the mocktool simulation code
2591         https://bugs.webkit.org/show_bug.cgi?id=68374
2592
2593         Reviewed by Adam Barth.
2594
2595         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2596         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2597         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2598         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2599         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2600         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2601         * Scripts/webkitpy/tool/commands/download_unittest.py:
2602         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2603         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2604         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2605         * Scripts/webkitpy/tool/commands/queuestest.py:
2606         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2607         * Scripts/webkitpy/tool/mocktool.py:
2608         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2609         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2610
2611 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2612
2613         [Qt] Don't override default QApplication font for DRT and WTR
2614
2615         Revision 95526 moved the relevant code below the QApplication
2616         constructor, to fix a potential crash, and that made the code
2617         take effect, breaking 6 tests.
2618
2619         We should rely on the QWebSettings to set default fonts, and
2620         this QApplication::setFont() is a relic from when we didn't
2621         have that option, so we remove the code.
2622
2623         Reviewed by Csaba Osztrogonác.
2624
2625         * DumpRenderTree/qt/main.cpp:
2626         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2627
2628 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2629
2630         WebKitTestRunner: Provide usage if run without arguments
2631
2632         If WTR is run without either one or more filenames, or
2633         a '-' to indicate server mode, we don't need to start
2634         up the test machinery. Doing so might actually crash,
2635         as we'll exit the application immedeatly after anyways.
2636
2637         Reviewed by Simon Hausmann.
2638
2639         * WebKitTestRunner/TestController.cpp:
2640         (WTR::TestController::initialize):
2641
2642 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2643
2644         [Qt] Don't use QFont before initializing QApplication
2645
2646         Could potentially result in crash.
2647
2648         Reviewed by Simon Hausmann.
2649
2650         * DumpRenderTree/qt/main.cpp:
2651         (main):
2652
2653 2011-09-19  Adam Barth  <abarth@webkit.org>
2654
2655         Always enable ENABLE(EVENTSOURCE)
2656         https://bugs.webkit.org/show_bug.cgi?id=68414
2657
2658         Reviewed by Eric Seidel.
2659
2660         * Scripts/build-webkit:
2661
2662 2011-09-19  David Levin  <levin@chromium.org>
2663
2664         Sheriffbot rollout should be more intuitive.
2665         https://bugs.webkit.org/show_bug.cgi?id=68415
2666
2667         Reviewed by Adam Barth.
2668
2669         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
2670         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
2671           and a few others cases.
2672         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
2673
2674 2011-09-19  David Levin  <levin@chromium.org>
2675
2676         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
2677         https://bugs.webkit.org/show_bug.cgi?id=68391
2678
2679         Reviewed by Darin Adler.
2680
2681         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
2682         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
2683
2684 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
2685
2686         Style checker should not check public Qt WK2 API for parameter_name.
2687         https://bugs.webkit.org/show_bug.cgi?id=68359
2688
2689         Reviewed by Andreas Kling.
2690
2691         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
2692         Add an exception in the style checker to disable the check. Also added the test for it.
2693
2694         * Scripts/webkitpy/style/checker.py:
2695         * Scripts/webkitpy/style/checker_unittest.py:
2696
2697 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
2698
2699         GTK DRT leaks memory while comparing history items
2700         https://bugs.webkit.org/show_bug.cgi?id=68086
2701
2702         Reviewed by Martin Robinson.
2703         
2704         webkit_web_history_item_get_target() returns a g_strdup()'d string,
2705         so memory must be freed before compareHistoryItems() returns.
2706
2707         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2708         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
2709
2710 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2711
2712         Buildbot marks a nrwt bot red when tests are missing results
2713         https://bugs.webkit.org/show_bug.cgi?id=64812
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2718         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2719
2720 2011-09-19  Jessie Berlin  <jberlin@apple.com>
2721
2722         Sites that use history pushState or replaceState are recorded in history in Private Browsing
2723         mode.
2724         https://bugs.webkit.org/show_bug.cgi?id=68208
2725
2726         Reviewed by Brady Eidson.
2727
2728         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
2729         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
2730
2731         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
2732         (TestWebKitAPI::didNavigateWithNavigationData):
2733         This is a context history client callback, so it should not be called when in Private
2734         Browsing. Add a call to FAIL().
2735         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2736         This is a page load client callback that happens after the didNavigateWithNavigationData
2737         callback. End the test.
2738         (TestWebKitAPI::TEST):
2739         Enable Private Browsing and load a page that uses history.pushState.
2740
2741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2742         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
2743         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
2744         Ditto.
2745         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2746         Ditto.
2747         * TestWebKitAPI/win/copy-resources.cmd:
2748         Ditto.
2749
2750 2011-09-16  Elliot Poger  <epoger@google.com>
2751
2752         add non-CG Webkit-Mac builds to flakiness dashboard
2753         https://bugs.webkit.org/show_bug.cgi?id=68265
2754
2755         Reviewed by Adam Barth.
2756
2757         As Chromium-on-Mac approaches the switchover from Core Graphics to
2758         Skia, we need to add the Skia version to the flakiness dashboard.
2759
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2761         * TestResultServer/static-dashboards/builders.js:
2762         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2763
2764 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
2765
2766         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
2767         https://bugs.webkit.org/show_bug.cgi?id=68071
2768
2769         Reviewed by Adam Barth.
2770
2771         * DumpRenderTree/chromium/WebPermissions.cpp:
2772         (WebPermissions::allowImage):
2773         * DumpRenderTree/chromium/WebPermissions.h:
2774
2775 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
2776
2777         update-webkit-chromium should retry the gclient call if it fails once
2778         https://bugs.webkit.org/show_bug.cgi?id=68252
2779
2780         Reviewed by Adam Barth.
2781
2782         * Scripts/update-webkit-chromium:
2783
2784 2011-09-16  Rob Buis  <rbuis@rim.com>
2785
2786         Add Eli's rim address and change the nick.
2787
2788         * Scripts/webkitpy/common/config/committers.py:
2789
2790 2011-09-16  Anders Carlsson  <andersca@apple.com>
2791
2792         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
2793         https://bugs.webkit.org/show_bug.cgi?id=68269
2794
2795         Reviewed by Geoffrey Garen.
2796
2797         Update client function signatures.
2798
2799         * MiniBrowser/gtk/BrowserWindow.c:
2800         (browserWindowUIClientInit):
2801         * MiniBrowser/mac/BrowserWindowController.m:
2802         (mouseDidMoveOverElement):
2803         (-[BrowserWindowController awakeFromNib]):
2804         * MiniBrowser/win/BrowserView.cpp:
2805         (BrowserView::create):
2806         * WebKitTestRunner/TestController.cpp:
2807         (WTR::TestController::createOtherPage):
2808         (WTR::TestController::initialize):
2809
2810 2011-09-16  Anders Carlsson  <andersca@apple.com>
2811
2812         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
2813         https://bugs.webkit.org/show_bug.cgi?id=68266
2814
2815         Reviewed by John Sullivan.
2816
2817         * MiniBrowser/mac/BrowserWindowController.m:
2818         (mouseDidMoveOverElement):
2819
2820 2011-09-16  Vincent Scheib  <scheib@chromium.org>
2821
2822         Add Vincent Scheib to the committers list.
2823
2824         * Scripts/webkitpy/common/config/committers.py:
2825
2826 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2827
2828         Unreviewed, rolling out r95285.
2829         http://trac.webkit.org/changeset/95285
2830         https://bugs.webkit.org/show_bug.cgi?id=68247
2831
2832         It broke a webkitpy test (Requested by ossy on #webkit).
2833
2834         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2835
2836 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2837
2838         Buildbot marks a nrwt bot red when tests are missing results
2839         https://bugs.webkit.org/show_bug.cgi?id=64812
2840
2841         Reviewed by Dirk Pranke.
2842
2843         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2844
2845 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
2846
2847         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
2848         https://bugs.webkit.org/show_bug.cgi?id=68178
2849
2850         Reviewed by Xan Lopez.
2851
2852         Add a work-around to enable WebKit2 when using build-webkit.
2853
2854         * Scripts/webkitdirs.pm:
2855         (buildAutotoolsProject): 
2856
2857 2011-09-15  James Robinson  <jamesr@chromium.org>
2858
2859         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
2860
2861         * Scripts/webkitpy/common/config/committers.py:
2862
2863 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2864
2865         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
2866         https://bugs.webkit.org/show_bug.cgi?id=68003
2867
2868         Reviewed by Adam Barth.
2869
2870         * Scripts/webkitpy/tool/mocktool.py:
2871         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2872         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2873
2874 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2875
2876         Python version check is confusing in test-webkitpy
2877         https://bugs.webkit.org/show_bug.cgi?id=68004
2878
2879         Reviewed by Adam Barth.
2880
2881         * Scripts/test-webkitpy:
2882
2883 2011-09-15  Eric Seidel  <eric@webkit.org>
2884
2885         Reviewed by Adam Barth.
2886
2887         webkit-patch should be able to find users and add them to bugzilla groups
2888         https://bugs.webkit.org/show_bug.cgi?id=63351
2889
2890         These are both very basic commands.  But it's now possible to find
2891         all users matching a regexp, as well as add all users matching a regexp
2892         to a set of groups.
2893
2894         bugzilla.py already knew how to find users (for validate-committer-lists)
2895         but now it has the ability to modify the user records.
2896
2897         I split some of the logic out into a new EditUsersParser class
2898         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2899
2900         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2901         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2902         * Scripts/webkitpy/tool/commands/__init__.py:
2903         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2904         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2905
2906 2011-09-15  Eric Seidel  <eric@webkit.org>
2907
2908         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2909         https://bugs.webkit.org/show_bug.cgi?id=68182
2910
2911         Reviewed by Adam Barth.
2912
2913         * Scripts/build-webkit:
2914         * waf/build/settings.py:
2915
2916 2011-09-15  Eric Seidel  <eric@webkit.org>
2917
2918         Unreviewed.  Make contributor email look-up case-insensitive.
2919
2920         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2921         was missing from committers.py due to case sensitivity.
2922
2923         This also includes a test expectations update to committers_unittest.py
2924         after my previous change.
2925
2926         * Scripts/webkitpy/common/config/committers.py:
2927         * Scripts/webkitpy/common/config/committers_unittest.py:
2928         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2929
2930 2011-09-15  Eric Seidel  <eric@webkit.org>
2931
2932         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2933
2934         Add a bunch of email aliases to committers.py for regular contributors
2935         who are committing using other email addresses than they have listed in the file.
2936
2937         * Scripts/webkitpy/common/config/committers.py:
2938
2939 2011-09-15  Eric Seidel  <eric@webkit.org>
2940
2941         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2942         https://bugs.webkit.org/show_bug.cgi?id=68022
2943
2944         Reviewed by Ryosuke Niwa.
2945
2946         * Scripts/build-webkit:
2947         * waf/build/settings.py:
2948
2949 2011-09-15  Anders Carlsson  <andersca@apple.com>
2950
2951         Fix Mac build by including config.h where needed.
2952
2953         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2954         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2955         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2956         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2957         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2958         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2959         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2960         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2961         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2962         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2963         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2964         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2965         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2966         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2967         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2968         * TestWebKitAPI/mac/main.mm:
2969
2970 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2971
2972         Let TestWebKitAPI work for chromium
2973         https://bugs.webkit.org/show_bug.cgi?id=67756
2974
2975         Reviewed by Sam Weinig.
2976
2977         * Scripts/build-api-tests:
2978         * Scripts/run-api-tests:
2979         (isSupportedPlatform):
2980         (runTest):
2981         (populateTests):
2982         * Scripts/webkitdirs.pm:
2983         (determineBaseProductDir):
2984         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2985         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2986         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2987         * TestWebKitAPI/InjectedBundleController.cpp:
2988         * TestWebKitAPI/InjectedBundleMain.cpp:
2989         * TestWebKitAPI/JavaScriptTest.cpp:
2990         * TestWebKitAPI/PlatformUtilities.cpp:
2991         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2993         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2994         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2995         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2996         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2997         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2998         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2999         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3000         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3001         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3002         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3003         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3004         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3005         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3006         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3007         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3008         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3009         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3010         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3011         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3012         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3013         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3014         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3015         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
3016         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
3017         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3018         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
3019         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3020         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3021         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3022         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3023         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
3024         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3025         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3026         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3027         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3028         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3029         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3030         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3031         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3032         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3033         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3034         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3035         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3036         * TestWebKitAPI/TestsController.cpp:
3037         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
3038         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
3039         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3040         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3041         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3042         * TestWebKitAPI/win/main.cpp:
3043
3044 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
3045
3046         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
3047         https://bugs.webkit.org/show_bug.cgi?id=68145
3048
3049         This will allow for other classes in DumpRenderTree to reuse this functionality
3050
3051         Reviewed by David Levin.
3052
3053         * DumpRenderTree/chromium/TestShell.cpp:
3054         (normalizeLayoutTestURLInternal):
3055         (dumpHistoryItem):
3056         (TestShell::normalizeLayoutTestURL):
3057         * DumpRenderTree/chromium/TestShell.h:
3058
3059 2011-09-14  Ada Chan  <adachan@apple.com>
3060
3061         Add test for WKBundleFrameCopyWebArchive().
3062         https://bugs.webkit.org/show_bug.cgi?id=67857
3063
3064         Reviewed by Anders Carlsson.
3065
3066         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
3067         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
3068         the returned data is a valid webarchive.
3069         (TestWebKitAPI::setInjectedBundleClient):
3070         (TestWebKitAPI::didFinishLoadForFrame):
3071         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
3072         injected bundle for the webarchive and check the returned webarchive.
3073         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
3074         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
3075         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
3076         the web archive.
3077
3078         Add files to project.
3079         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
3080         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3082
3083 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
3084
3085         committers.py should support multiple IRC nicknames
3086         https://bugs.webkit.org/show_bug.cgi?id=68110
3087
3088         Reviewed by Eric Seidel.
3089
3090         Add multiple IRC nickname support to committers.py
3091
3092         * Scripts/webkitpy/common/config/committers.py:
3093         * Scripts/webkitpy/common/config/committers_unittest.py:
3094         * Scripts/webkitpy/tool/bot/irc_command.py:
3095         * Scripts/webkitpy/tool/bot/sheriff.py:
3096
3097 2011-09-14  Jon Lee  <jonlee@apple.com>
3098
3099         Implement globalFlag for WebKitTestRunner
3100         https://bugs.webkit.org/show_bug.cgi?id=68033
3101         <rdar://problem/10119204>
3102
3103         Reviewed by Sam Weinig.
3104
3105         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
3106         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3107         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
3108         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
3109         (WTR::LayoutTestController::globalFlag): simple getter
3110         (WTR::LayoutTestController::setGlobalFlag): simple setter
3111
3112 2011-09-13  Eric Seidel  <eric@webkit.org>
3113
3114         Remove ENABLE_SVG_USE as <use> is required by HTML5
3115         https://bugs.webkit.org/show_bug.cgi?id=68019
3116
3117         Reviewed by Ryosuke Niwa.
3118
3119         * Scripts/build-webkit:
3120         * waf/build/settings.py:
3121
3122 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
3123
3124         Remove Jan Erik Hanssen (added in my r95078) from the list for now
3125         since I can't confirm acceptable his committership.
3126
3127         * Scripts/webkitpy/common/config/committers.py:
3128
3129 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
3130
3131         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
3132         https://bugs.webkit.org/show_bug.cgi?id=68066
3133
3134         Reviewed by Adam Barth.
3135
3136         * DumpRenderTree/chromium/WebViewHost.cpp:
3137         * DumpRenderTree/chromium/WebViewHost.h:
3138
3139 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3140
3141         committers.py is missing some contributors
3142         https://bugs.webkit.org/show_bug.cgi?id=68059
3143
3144         Reviewed by Adam Barth.
3145
3146         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
3147
3148         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
3149
3150         * Scripts/webkitpy/common/config/committers.py:
3151
3152 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3153
3154         Fix webkit python test after r95061.
3155
3156         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3157
3158 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
3159
3160         Add myself as a contributor. No review needed.
3161
3162         * Scripts/webkitpy/common/config/committers.py:
3163
3164 2011-09-13  Adam Barth  <abarth@webkit.org>
3165
3166         garden-o-matic has unfriendly error messages when the local server is not available
3167         https://bugs.webkit.org/show_bug.cgi?id=68042
3168
3169         Reviewed by Dimitri Glazkov.
3170
3171         This patch moves us from using alert to showing the error inline in the
3172         progress dialog.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3179
3180 2011-09-13  Adam Barth  <abarth@webkit.org>
3181
3182         FailureGrid in garden-o-matic should link to the builder's waterfall page
3183         https://bugs.webkit.org/show_bug.cgi?id=68036
3184
3185         Reviewed by Dimitri Glazkov.
3186
3187         One of the users in the user study thought the configurations names in
3188         the failure grid would link to the underlying bots.  That makes sense,
3189         so this patch adds the behavior.
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3195
3196 2011-09-13  Adam Barth  <abarth@webkit.org>
3197
3198         garden-o-matic should be able to mark failures as expected
3199         https://bugs.webkit.org/show_bug.cgi?id=68027
3200
3201         Reviewed by Dimitri Glazkov.
3202
3203         All the back-end infrastructure exists for this operation.  This patch
3204         just adds some UI to the front-end and wires that UI up to the back
3205         end.  This exact UI will likely need some more polish, but this should
3206         be a reasonable first cut.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3213
3214 2011-09-13  Adam Barth  <abarth@webkit.org>
3215
3216         garden-o-matic should tell you about the progress of your rebaseline
3217         https://bugs.webkit.org/show_bug.cgi?id=67967
3218
3219         Reviewed by Dimitri Glazkov.
3220
3221         This patch adds ui.MessageBox, which is a light wrapper around jQuery
3222         UI's dialog widget.  We then use ui.MessageBox to show status messages
3223         about in-progress rebaselines.  As each baseline is downloaded, the
3224         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3232
3233 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
3234
3235         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
3236         https://bugs.webkit.org/show_bug.cgi?id=68024
3237
3238         Reviewed by Gustavo Noronha Silva.
3239         
3240         Using g_list_count() and g_list_nth_data() together on a loop is
3241         inneficient since they're both O(n). Iterate over lists in a saner
3242         way.
3243
3244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3245         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
3246         iterate on it using g_list_next(). Free the list after done with it.
3247         (dumpBackForwardListForWebView): Instead of appending (which is
3248         expensive in GLists) history items and then iterating from the tail
3249         of the itemsToPrint list, prepend items and walk forwards as usual.
3250         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
3251         remove the (unneeded) viewList variable.
3252
3253 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3254
3255         Add Eric's IRC nick.
3256
3257         * Scripts/webkitpy/common/config/committers.py:
3258
3259 2011-09-13  Anders Carlsson  <andersca@apple.com>
3260
3261         Disable C++ exceptions when building with clang
3262         https://bugs.webkit.org/show_bug.cgi?id=68031
3263         <rdar://problem/9556880>
3264
3265         Reviewed by Mark Rowe.
3266
3267         * MiniBrowser/Configurations/Base.xcconfig:
3268         * TestWebKitAPI/Configurations/Base.xcconfig:
3269         * WebKitTestRunner/Configurations/Base.xcconfig:
3270
3271 2011-09-13  Ojan Vafai  <ojan@chromium.org>
3272
3273         [chromium] fix flakiness dashboard for chromium interactive tests
3274         https://bugs.webkit.org/show_bug.cgi?id=68029
3275
3276         Reviewed by Tony Chang.
3277
3278         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3279         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3280
3281 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3282
3283         Add Alice and Aryeh to the list of contributors.
3284
3285         * Scripts/webkitpy/common/config/committers.py:
3286
3287 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3288
3289         sheriffbot whois should also tell us email addresses
3290         https://bugs.webkit.org/show_bug.cgi?id=67975
3291
3292         Reviewed by Eric Seidel and David Levin.
3293
3294         Taught sheriffbot how to tell us contributor's email addresses.
3295
3296         * Scripts/webkitpy/tool/bot/irc_command.py:
3297         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3298
3299 2011-09-13  Eric Seidel  <eric@webkit.org>
3300
3301         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
3302         https://bugs.webkit.org/show_bug.cgi?id=68018
3303
3304         Reviewed by Ryosuke Niwa.
3305
3306         * Scripts/build-webkit:
3307         * waf/build/settings.py:
3308
3309 2011-09-13  Chang Shu  <cshu@webkit.org>
3310
3311         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
3312         https://bugs.webkit.org/show_bug.cgi?id=57515
3313
3314         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
3315         TestController synchronously. The latter then sends simulated event to WebKit2 module,
3316         which is synchronous, too.
3317
3318         Reviewed by Darin Adler.
3319
3320         * WebKitTestRunner/EventSenderProxy.h: Added.
3321         (WTR::EventSenderProxy::EventSenderProxy):
3322         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3323         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3324         (WTR::EventSendingController::keyDown):
3325         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3326         * WebKitTestRunner/PlatformWebView.h:
3327         (WTR::PlatformWebView::platformWindow):
3328         * WebKitTestRunner/TestController.cpp:
3329         (WTR::TestController::TestController):
3330         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3331         * WebKitTestRunner/TestController.h:
3332         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3333         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
3334         (WTR::buildModifierFlags):
3335         (WTR::EventSenderProxy::keyDown):
3336
3337 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
3338
3339         [EFL] DRT: Add DumpRenderTreeEfl.h
3340         https://bugs.webkit.org/show_bug.cgi?id=63993
3341
3342         Reviewed by Eric Seidel.
3343         
3344         This header contains some global variables used by EFL's
3345         DumpRenderTree implementation.
3346
3347         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
3348         appropriate.
3349         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
3350
3351 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
3352
3353         [EFL] Send the right key names for PageUp and PageDown.
3354         https://bugs.webkit.org/show_bug.cgi?id=67044
3355
3356         Reviewed by Kenneth Rohde Christiansen.
3357
3358         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
3359         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
3360         However, EventSender was sending "Page_Up" and "Page_Down", so tests
3361         such as editing/input/page-up-down-scrolls.html were timing out due to
3362         the right key down events not being sent.
3363
3364         * DumpRenderTree/efl/EventSender.cpp:
3365         (keyPadNameFromJSValue):
3366         (keyNameFromJSValue):
3367
3368 2011-09-12  Eric Seidel  <eric@webkit.org>
3369
3370         sheriffbot whois is case sensitive
3371         https://bugs.webkit.org/show_bug.cgi?id=67972
3372
3373         Reviewed by Adam Barth.
3374
3375         I also fixed a typo in the "More than 5 contributors" message
3376         from my previous commit.
3377
3378         * Scripts/webkitpy/common/config/committers.py:
3379         * Scripts/webkitpy/common/config/committers_unittest.py:
3380         * Scripts/webkitpy/tool/bot/irc_command.py:
3381         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3382
3383 2011-09-12  Eric Seidel  <eric@webkit.org>
3384
3385         sheriffbot whois should be smarter
3386         https://bugs.webkit.org/show_bug.cgi?id=67971
3387
3388         Reviewed by Adam Barth.
3389
3390         This makes sheriffbot whois basically grep the committers list
3391         making it much easier to find a contributor by name.
3392
3393         Unfortunately the current unittests depend on the real committers.py
3394         file, so as we add more eric's to the project, this unittest result will
3395         change.  I think that's OK for now.  We'll fix it when it breaks.
3396
3397         * Scripts/webkitpy/common/config/committers.py:
3398         * Scripts/webkitpy/tool/bot/irc_command.py:
3399         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3400
3401 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3402
3403         Unreviewed, rolling out r94976.
3404         http://trac.webkit.org/changeset/94976
3405         https://bugs.webkit.org/show_bug.cgi?id=67953
3406
3407         Broke a bunch of security/load& tests (Requested by rniwa on
3408         #webkit).
3409
3410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3411         (LayoutTestController::pathToLocalResource):
3412
3413 2011-09-12  Eric Seidel  <eric@webkit.org>
3414
3415         Rubber-stamped by Adam Barth.
3416
3417         Remove the "the tree is burning!" warning previously shown
3418         when landing patches.  It was a dream.  But it's just noise now.
3419
3420         Some bots will require a restart to notice the removal of the option
3421         so I've left the --ignore-builders option in for now.
3422
3423         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3424         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3425         * Scripts/webkitpy/tool/commands/download.py:
3426         * Scripts/webkitpy/tool/commands/download_unittest.py:
3427         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3428         * Scripts/webkitpy/tool/steps/__init__.py:
3429         * Scripts/webkitpy/tool/steps/commit.py:
3430         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
3431         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3432
3433 2011-09-12  Eric Seidel  <eric@webkit.org>
3434
3435         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
3436         https://bugs.webkit.org/show_bug.cgi?id=65781
3437
3438         Reviewed by Ryosuke Niwa.
3439
3440         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
3441         to resolve the passed in url relative to the absolute url for the test.
3442
3443         I believe this is a better approach than the on used in the Qt and Chromium DRT's
3444         (which resolves the path relative to the built location of the DRT executable)
3445         and we should move this new code into a shared location in a follow-up patch.
3446
3447         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3448         (LayoutTestController::pathToLocalResource):
3449
3450 2011-09-12  Eric Seidel  <eric@webkit.org>
3451
3452         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3453         https://bugs.webkit.org/show_bug.cgi?id=67530
3454
3455         Reviewed by Adam Barth.
3456
3457         I believe I've fixed the bug in the original patch which prompted the rollout.
3458         The previous patch was using the wrong deadline for the initial read,
3459         subtracting time.time() twice from the deadline value.
3460
3461         * Scripts/webkitpy/layout_tests/port/webkit.py:
3462         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3463
3464 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
3465
3466         [Qt][WK2] WebKitTestRunner does not produce crash logs
3467         https://bugs.webkit.org/show_bug.cgi?id=67714
3468
3469         Reviewed by Chang Shu.
3470
3471         Added a simple way of generating backtrace on crash
3472         to the web process. The implementation is similar what
3473         we have in DRT. It depends on GNU libc functionality
3474         so it is only enabled where we are running in such an environment.
3475
3476         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3477         (WTR::printBacktrace):
3478         (WTR::crashHandler):
3479         (WTR::InjectedBundle::platformInitialize):
3480
3481 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
3482
3483         Added my IRC nick to the committers file.
3484
3485         * Scripts/webkitpy/common/config/committers.py:
3486
3487 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
3488
3489         The executable allocator makes it difficult to free individual
3490         chunks of executable memory
3491         https://bugs.webkit.org/show_bug.cgi?id=66363
3492
3493         Reviewed by Oliver Hunt.
3494         
3495         Introduced a best-fit, balanced-tree based allocator. The allocator
3496         required a balanced tree that does not allocate memory and that
3497         permits the removal of individual nodes directly (as opposed to by
3498         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
3499         Changed all references to executable code to use a reference counted
3500         handle.
3501
3502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3503         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
3504         (TestWebKitAPI::TEST_F):
3505         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
3506         (TestWebKitAPI::Pair::findExact):
3507         (TestWebKitAPI::Pair::remove):
3508         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
3509         (TestWebKitAPI::Pair::assertFoundAndRemove):
3510         (TestWebKitAPI::Pair::assertEqual):
3511         (TestWebKitAPI::Pair::assertSameValuesForKey):
3512         (TestWebKitAPI::Pair::testDriver):
3513         (TestWebKitAPI::TEST_F):
3514
3515 2011-09-10  Andy Estes  <aestes@apple.com>
3516
3517         Move myself from committers_unable_to_review to reviewers_list.
3518
3519         * Scripts/webkitpy/common/config/committers.py:
3520
3521 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
3522
3523         [wx] Unreviewed build fix. MSW build fixes.
3524
3525         * DumpRenderTree/config.h:
3526         * waf/build/wxpresets.py:
3527
3528 2011-09-10  Andreas Kling  <kling@webkit.org>
3529
3530         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
3531         https://bugs.webkit.org/show_bug.cgi?id=59328
3532
3533         Reviewed by Kenneth Rohde Christiansen.
3534
3535         * MiniBrowser/mac/BrowserWindowController.m:
3536         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
3537
3538 2011-09-10  Adam Barth  <abarth@webkit.org>
3539
3540         Build fix for Android.  DumpRenderTree is a client of the WebKit API
3541         and does not have access to notImplemented().
3542
3543         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3544         (openStartupDialog):
3545
3546 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
3547
3548         Add a script to create a monolithic script-test
3549         https://bugs.webkit.org/show_bug.cgi?id=67747
3550
3551         Reviewed by Darin Adler.
3552
3553         * Scripts/make-new-script-test: Added.
3554
3555 2011-09-09  Luiz Agostini  <luiz@webkit.org>
3556
3557         Adding myself to the reviewers list.
3558
3559         * Scripts/webkitpy/common/config/committers.py:
3560
3561 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
3562
3563         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
3564         https://bugs.webkit.org/show_bug.cgi?id=67855
3565
3566         Reviewed by Dirk Pranke.
3567
3568         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
3569         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
3570
3571         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
3572
3573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3574
3575 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
3576
3577         Add myself to committers.py
3578         https://bugs.webkit.org/show_bug.cgi?id=67853
3579
3580         Reviewed by Darin Adler.
3581
3582         * Scripts/webkitpy/common/config/committers.py:
3583
3584 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3585
3586         [Qt] Remove common.pri
3587         https://bugs.webkit.org/show_bug.cgi?id=67814
3588
3589         Reviewed by Andreas Kling.
3590
3591         * Tools.pro:
3592
3593 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3594
3595         [NRWT] the nrwt check httpd with --no-http option
3596         https://bugs.webkit.org/show_bug.cgi?id=67835
3597
3598         Reviewed by Tony Chang.
3599
3600         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3601         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3602
3603 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
3604
3605         [chromium] Implement DRT support for Android.
3606         https://bugs.webkit.org/show_bug.cgi?id=67590
3607
3608         Reviewed by Tony Chang.
3609
3610         Add 2 mechanism to make DRT interaction more robust on Android:
3611         - Send 'QUIT' to DRT to make it stop.
3612         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
3613         input commands before it starts.
3614         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
3615         and <clocale> for 'LC_ALL' to compile on Android.
3616
3617         Also change to use sigaction instead of signal for TestShellGtk.cpp,
3618         as signal() man page recommends using sigaction().
3619
3620         * DumpRenderTree/DumpRenderTree.gypi:
3621         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3622         (main):
3623         * DumpRenderTree/chromium/LayoutTestController.cpp:
3624         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
3625         (AlarmHandler):
3626         (TestShell::waitTestFinished):
3627         (platformInit):
3628         (openStartupDialog):
3629         (checkLayoutTestSystemDependencies):
3630         * DumpRenderTree/chromium/TestShellGtk.cpp:
3631         (AlarmHandler):
3632         (TestShell::waitTestFinished):
3633
3634 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
3635
3636         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
3637
3638         * waf/build/settings.py:
3639
3640 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3641
3642         Unreviewed, rolling out r94851.
3643         http://trac.webkit.org/changeset/94851
3644         https://bugs.webkit.org/show_bug.cgi?id=67847
3645
3646         It broke a webkitpy test (Requested by ossy on #webkit).
3647
3648         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3649
3650 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3651
3652         [NRWT] the nrwt check httpd with --no-http option
3653         https://bugs.webkit.org/show_bug.cgi?id=67835
3654
3655         Reviewed by Csaba Osztrogonác.
3656
3657         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3658
3659 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
3660
3661         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
3662         https://bugs.webkit.org/show_bug.cgi?id=67794
3663         <rdar://problem/9892024>
3664         
3665         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
3666
3667         Reviewed by Brady Eidson.
3668
3669         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.