1 2015-04-07 Brent Fulgham <bfulgham@apple.com>
3 [Win] Bots complain about missing /etc/catalog
4 https://bugs.webkit.org/show_bug.cgi?id=143484
6 Reviewed by Chris Dumez.
8 The libxml2 build on Mac, iOS, and Windows does not provide the set
9 of default catalog files. We do not actually need these for our
10 purposes, but we get warnings and some bot flakiness because they
13 We can avoid both problems the same way the Mac and iOS ports do,
14 by setting the XML_CATALOG_FILES environment variable to 'empty string',
15 which avoid the warnings and bot problems.
17 * Scripts/webkitpy/port/win.py:
18 (WinPort.setup_environ_for_server): Added.
20 2015-04-06 Sam Weinig <sam@webkit.org>
22 Use content extensions in MiniBrowser.
23 https://bugs.webkit.org/show_bug.cgi?id=143446
25 Reviewed by Alex Christensen.
27 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
28 * MiniBrowser/mac/AppDelegate.h:
29 * MiniBrowser/mac/AppDelegate.m:
30 (-[BrowserAppDelegate init]):
31 (-[BrowserAppDelegate showExtensionsManager:]):
32 (-[BrowserAppDelegate userContentContoller]):
33 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
34 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
35 (-[ExtensionManagerWindowController init]):
36 (-[ExtensionManagerWindowController windowDidLoad]):
37 (-[ExtensionManagerWindowController add:]):
38 (-[ExtensionManagerWindowController remove:]):
39 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
40 * MiniBrowser/mac/MainMenu.xib:
42 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
44 web-platform-tests server should retrieve the modules file relatively to its docroot path
45 https://bugs.webkit.org/show_bug.cgi?id=142742
47 Reviewed by Darin Adler.
49 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
50 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
52 2015-04-06 Commit Queue <commit-queue@webkit.org>
54 Unreviewed, rolling out r182445.
55 https://bugs.webkit.org/show_bug.cgi?id=143459
57 broke 32 bit build (Requested by alexchristensen on #webkit).
61 "Use content extensions in MiniBrowser."
62 https://bugs.webkit.org/show_bug.cgi?id=143446
63 http://trac.webkit.org/changeset/182445
65 2015-04-06 Sam Weinig <sam@webkit.org>
67 Use content extensions in MiniBrowser.
68 https://bugs.webkit.org/show_bug.cgi?id=143446
70 Reviewed by Alex Christensen.
72 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
73 * MiniBrowser/mac/AppDelegate.h:
74 * MiniBrowser/mac/AppDelegate.m:
75 (-[BrowserAppDelegate init]):
76 (-[BrowserAppDelegate showExtensionsManager:]):
77 (-[BrowserAppDelegate userContentContoller]):
78 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
79 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
80 (-[ExtensionManagerWindowController init]):
81 (-[ExtensionManagerWindowController windowDidLoad]):
82 (-[ExtensionManagerWindowController add:]):
83 (-[ExtensionManagerWindowController remove:]):
84 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
85 * MiniBrowser/mac/MainMenu.xib:
87 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
89 [GTK] install-dependencies should prefer dnf to yum
90 https://bugs.webkit.org/show_bug.cgi?id=143441
92 Reviewed by Martin Robinson.
94 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
96 * gtk/install-dependencies:
98 2015-04-06 Andy Estes <aestes@apple.com>
100 [iOS] 'make clean' fails in Tools/WebKitTestRunner
101 https://bugs.webkit.org/show_bug.cgi?id=143455
103 Reviewed by Dan Bernstein.
105 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
106 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
108 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
110 2015-04-06 Alexey Proskuryakov <ap@apple.com>
112 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
113 https://bugs.webkit.org/show_bug.cgi?id=143450
115 Reviewed by Anders Carlsson.
117 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
118 Make sure that the view is actually closed, regardless of anything else that happens beneath.
119 Also, removed unnecessary get() calls.
121 2015-04-03 Alexey Proskuryakov <ap@apple.com>
123 Reduce the dependency on Flash in regression tests
124 https://bugs.webkit.org/show_bug.cgi?id=143391
126 Reviewed by Anders Carlsson.
128 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
129 Only allow QuickTime and the test plug-in.
131 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
133 W3C test importer should generate the modules installed dynamically to run wpt tests
134 https://bugs.webkit.org/show_bug.cgi?id=142738
136 Reviewed by Ryosuke Niwa.
138 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
139 The implementation is done within TestDownloader and it is activated for the WPT repository.
140 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
142 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
143 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
144 * Scripts/webkitpy/w3c/test_downloader.py:
145 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
147 (TestDownloader._git_submodules_description): Computes submodule description.
148 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
149 * Scripts/webkitpy/w3c/test_importer.py:
150 (TestImporter.do_import): Added the possibility to post process the tests.
152 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
153 (TestImporter.should_convert_test_harness_links): Updated according new options format.
154 * Scripts/webkitpy/w3c/test_importer_unittest.py:
155 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
156 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
157 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
158 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
159 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
161 2015-04-05 Antti Koivisto <antti@apple.com>
163 Bloom filter should support longer hashes
164 https://bugs.webkit.org/show_bug.cgi?id=143419
166 Reviewed by Dan Bernstein.
168 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
169 (TestWebKitAPI::generateRandomDigests):
170 (TestWebKitAPI::TEST):
172 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
174 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
175 https://bugs.webkit.org/show_bug.cgi?id=143372
177 Reviewed by Darin Adler.
179 * Scripts/run-jsc-stress-tests:
181 2015-04-03 Antti Koivisto <antti@apple.com>
183 Add non-counting bloom filter class
184 https://bugs.webkit.org/show_bug.cgi?id=143366
186 Reviewed by Sam Weinig.
188 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
189 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
190 (TestWebKitAPI::generateRandomHashes):
191 (TestWebKitAPI::TEST):
193 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
195 FTL JIT tests should fail if LLVM library isn't available
196 https://bugs.webkit.org/show_bug.cgi?id=143374
198 Reviewed by Mark Lam.
200 * Scripts/run-jsc-stress-tests:
202 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
204 [EFL] Speedup jhbuild with disable running autogen.sh
205 https://bugs.webkit.org/show_bug.cgi?id=143369
207 Reviewed by Gyuyoung Kim.
209 * efl/jhbuild.modules:
211 2015-04-01 Alexey Proskuryakov <ap@apple.com>
213 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
214 https://bugs.webkit.org/show_bug.cgi?id=143282
216 Reviewed by Daniel Bates.
218 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
220 2015-04-01 Alexey Proskuryakov <ap@apple.com>
222 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
223 https://bugs.webkit.org/show_bug.cgi?id=143240
224 rdar://problem/19990425
226 Reviewed by Tim Horton.
228 * DumpRenderTree/mac/LayoutTestHelper.m:
229 (colorProfileURLForDisplay):
230 (saveDisplayColorProfiles):
231 Gracefully handle it when the current profile cannot be retrieved, fixing at
232 least one case when LayoutTestHelper couldn't start.
234 * Scripts/webkitpy/layout_tests/controllers/manager.py:
235 (Manager._set_up_run):
236 (Manager._force_pixel_tests_if_needed):
237 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
238 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
239 Return and check an error from start_helper().
241 2015-04-01 Brent Fulgham <bfulgham@apple.com>
243 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
244 https://bugs.webkit.org/show_bug.cgi?id=143321
246 Reviewed by Alexey Proskuryakov.
248 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
250 2015-04-01 Enrica Casucci <enrica@apple.com>
252 Injected bundle messages should be at the page level.
253 https://bugs.webkit.org/show_bug.cgi?id=143283
255 Reviewed by Alexey Proskuryakov.
257 Updating WebKitTestRunner to use the new page level messaging.
258 The author of this patch is Tim Horton, I just finished it.
260 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
261 (WTR::EventSendingController::mouseDown):
262 (WTR::EventSendingController::mouseUp):
263 (WTR::EventSendingController::mouseMoveTo):
264 (WTR::EventSendingController::leapForward):
265 (WTR::EventSendingController::scheduleAsynchronousClick):
266 (WTR::EventSendingController::keyDown):
267 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
268 (WTR::EventSendingController::mouseScrollBy):
269 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
270 (WTR::EventSendingController::continuousMouseScrollBy):
271 (WTR::EventSendingController::addTouchPoint):
272 (WTR::EventSendingController::updateTouchPoint):
273 (WTR::EventSendingController::setTouchModifier):
274 (WTR::EventSendingController::setTouchPointRadius):
275 (WTR::EventSendingController::touchStart):
276 (WTR::EventSendingController::touchMove):
277 (WTR::EventSendingController::touchEnd):
278 (WTR::EventSendingController::touchCancel):
279 (WTR::EventSendingController::clearTouchPoints):
280 (WTR::EventSendingController::releaseTouchPoint):
281 (WTR::EventSendingController::cancelTouchPoint):
282 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
283 (WTR::InjectedBundle::didReceiveMessage):
284 (WTR::InjectedBundle::didReceiveMessageToPage):
285 (WTR::InjectedBundle::done):
286 (WTR::InjectedBundle::outputText):
287 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
288 (WTR::InjectedBundle::postAddChromeInputField):
289 (WTR::InjectedBundle::postRemoveChromeInputField):
290 (WTR::InjectedBundle::postFocusWebView):
291 (WTR::InjectedBundle::postSetBackingScaleFactor):
292 (WTR::InjectedBundle::postSetWindowIsKey):
293 (WTR::InjectedBundle::postSimulateWebNotificationClick):
294 (WTR::InjectedBundle::postSetAddsVisitedLinks):
295 (WTR::InjectedBundle::setGeolocationPermission):
296 (WTR::InjectedBundle::setMockGeolocationPosition):
297 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
298 (WTR::InjectedBundle::setUserMediaPermission):
299 (WTR::InjectedBundle::setCustomPolicyDelegate):
300 (WTR::InjectedBundle::setHidden):
301 (WTR::InjectedBundle::setCacheModel):
302 (WTR::InjectedBundle::shouldProcessWorkQueue):
303 (WTR::InjectedBundle::processWorkQueue):
304 (WTR::InjectedBundle::queueBackNavigation):
305 (WTR::InjectedBundle::queueForwardNavigation):
306 (WTR::InjectedBundle::queueLoad):
307 (WTR::InjectedBundle::queueLoadHTMLString):
308 (WTR::InjectedBundle::queueReload):
309 (WTR::InjectedBundle::queueLoadingScript):
310 (WTR::InjectedBundle::queueNonLoadingScript):
311 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
312 (WTR::TestRunner::setHandlesAuthenticationChallenges):
313 (WTR::TestRunner::setAuthenticationUsername):
314 (WTR::TestRunner::setAuthenticationPassword):
315 (WTR::TestRunner::secureEventInputIsEnabled):
316 (WTR::TestRunner::setBlockAllPlugins):
317 * WebKitTestRunner/TestController.cpp:
318 (WTR::TestController::createWebViewWithOptions):
319 (WTR::TestController::resetStateToConsistentValues):
320 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
321 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
322 * WebKitTestRunner/TestController.h:
323 * WebKitTestRunner/TestInvocation.cpp:
324 (WTR::TestInvocation::invoke):
325 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
327 2015-04-01 Commit Queue <commit-queue@webkit.org>
329 Unreviewed, rolling out r182174 and r182177.
330 https://bugs.webkit.org/show_bug.cgi?id=143314
332 Try to correct EWS failures (Requested by bfulgham on
337 "Python SCM should be able to retrieve untracked files"
338 https://bugs.webkit.org/show_bug.cgi?id=143135
339 http://trac.webkit.org/changeset/182174
341 "[buildbot] clean-build script should remove untracked files
342 and revert local changes too"
343 https://bugs.webkit.org/show_bug.cgi?id=142400
344 http://trac.webkit.org/changeset/182177
346 2015-04-01 Alex Christensen <achristensen@webkit.org>
348 [Content Extensions] Properly handle regexes that match everything.
349 https://bugs.webkit.org/show_bug.cgi?id=143281
351 Reviewed by Benjamin Poulain.
353 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
354 (TestWebKitAPI::testRequest):
355 (TestWebKitAPI::makeBackend):
356 (TestWebKitAPI::TEST_F):
357 Removed duplicate code and added test.
359 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
361 Content Extensions: split the state machines to minimize prefix states
362 https://bugs.webkit.org/show_bug.cgi?id=143253
364 Reviewed by Alex Christensen.
366 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
367 (TestWebKitAPI::TEST_F):
368 (TestWebKitAPI::testPatternStatus):
370 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
372 Clean up Identifier factories to clarify the meaning of StringImpl*
373 https://bugs.webkit.org/show_bug.cgi?id=143146
375 Reviewed by Filip Pizlo.
377 Simple API tests for StringImpl are added.
379 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
380 (TestWebKitAPI::TEST):
382 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
384 [EFL] Add AArch64 builder and tester bot to build.webkit.org
385 https://bugs.webkit.org/show_bug.cgi?id=143092
387 Reviewed by Gyuyoung Kim.
389 * BuildSlaveSupport/build.webkit.org-config/config.json:
390 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
392 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
394 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
396 [buildbot] clean-build script should remove untracked files and revert local changes too
397 https://bugs.webkit.org/show_bug.cgi?id=142400
399 Reviewed by Ryosuke Niwa.
401 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
402 A helper routine SCM.discard_untracked_files is added for that purpose.
404 * BuildSlaveSupport/clean-build:
405 (main): Making call to Scripts/clean-webkit
406 * Scripts/clean-webkit: Added.
407 (main): Revert changes and delete untracked files.
408 * Scripts/webkitpy/common/checkout/scm/scm.py:
409 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
410 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
411 (SCMTest._shared_test_discard_untracked_files):
412 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
414 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
416 Python SCM should be able to retrieve untracked files
417 https://bugs.webkit.org/show_bug.cgi?id=143135
419 Reviewed by Ryosuke Niwa.
421 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
422 Ignored files may be included or not in this list according boolean passed to the function.
424 * Scripts/webkitpy/common/checkout/scm/git.py:
425 (Git.untracked_files):
426 * Scripts/webkitpy/common/checkout/scm/scm.py:
427 (SCM.untracked_files):
428 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
429 (SCMTest._shared_test_untracked_files):
430 (test_untracked_files):
431 (GitSVNTest.test_untracked_files):
432 * Scripts/webkitpy/common/checkout/scm/svn.py:
433 (SVN.untracked_files):
435 2015-03-30 Alex Christensen <achristensen@webkit.org>
437 [Content Extensions] Correctly handle regular expressions matching everything
438 https://bugs.webkit.org/show_bug.cgi?id=143235
440 Reviewed by Benjamin Poulain.
442 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
443 (TestWebKitAPI::checkCompilerError):
444 (TestWebKitAPI::TEST_F):
445 Test ContentExtensionErrors.
447 2015-03-30 Alexey Proskuryakov <ap@apple.com>
449 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
450 https://bugs.webkit.org/show_bug.cgi?id=143241
451 rdar://problem/20351297
453 Reviewed by Mark Lam.
455 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
457 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
459 [CMake][EFL] Remove redundant library link and include path
460 https://bugs.webkit.org/show_bug.cgi?id=143221
462 Reviewed by Csaba Osztrogonác.
464 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
466 2015-03-30 Sam Weinig <sam@webkit.org>
468 [Content Extensions] Flesh out the UserContentExtensionStore
469 https://bugs.webkit.org/show_bug.cgi?id=143123
471 Reviewed by Benjamin Poulain.
473 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
475 Add tests for _WKUserContentExtensionStore.
477 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
479 Update install-dependencies Fedora packages after r181624
480 https://bugs.webkit.org/show_bug.cgi?id=143215
482 Add json-glib, libv4l, openssl and pulseaudio development packages to
483 the Fedora list providing we need them to build WebKit dependencies
484 for this distribution.
486 Reviewed by Philippe Normand.
488 * gtk/install-dependencies:
490 2015-03-30 Commit Queue <commit-queue@webkit.org>
492 Unreviewed, rolling out r182119.
493 https://bugs.webkit.org/show_bug.cgi?id=143196
495 problem with syntax (Requested by youenn on #webkit).
499 "[buildbot] clean-build script should remove untracked files
500 and revert local changes too"
501 https://bugs.webkit.org/show_bug.cgi?id=142400
502 http://trac.webkit.org/changeset/182119
504 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
506 Start the features.json files
507 https://bugs.webkit.org/show_bug.cgi?id=143207
509 Reviewed by Darin Adler.
511 I kept the style checking light. We'll have to figure
512 what is the best format for each field.
514 * Scripts/webkitpy/style/checker.py:
515 (CheckerDispatcher._create_checker):
516 * Scripts/webkitpy/style/checkers/jsonchecker.py:
517 (JSONContributorsChecker.check):
518 (JSONFeaturesChecker):
519 (JSONFeaturesChecker.check):
521 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
523 [buildbot] clean-build script should remove untracked files and revert local changes too
524 https://bugs.webkit.org/show_bug.cgi?id=142400
526 Reviewed by Ryosuke Niwa.
528 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
530 * BuildSlaveSupport/clean-build:
531 (main): Adding call to Tools/Scripts/clean-webkit.
532 * Scripts/clean-webkit: Added.
533 (main): Removes untracked and changed files.
534 * Scripts/webkitpy/common/checkout/scm/git.py:
535 (Git.untracked_files): Retrieves GIT untracked files.
536 * Scripts/webkitpy/common/checkout/scm/scm.py:
537 (SCM.untracked_files): Retrieves SVN untracked files.
539 (SCM.discard_untracked_files): Deletes untracked files/folders.
540 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
541 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
542 (test_untracked_files):
543 (GitSVNTest.test_untracked_files):
544 * Scripts/webkitpy/common/checkout/scm/svn.py:
545 (SVN.untracked_files):
547 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
549 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
550 https://bugs.webkit.org/show_bug.cgi?id=143138
552 Reviewed by Csaba Osztrogonác.
554 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
555 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
557 * ImageDiff/CMakeLists.txt:
558 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
559 * WebKitTestRunner/CMakeLists.txt: ditto.
561 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
563 Support building WTF on Windows without Cygwin
564 https://bugs.webkit.org/show_bug.cgi?id=143084
566 Reviewed by Brent Fulgham.
568 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
569 This patch also migrates to using File::Spec->catfile() for directory separators.
571 * Scripts/update-webkit-dependency:
573 * Scripts/update-webkit-support-libs:
575 (downloadExpectedVersionNumber):
577 (toUnixPath): Deleted.
578 * Scripts/webkitdirs.pm:
579 (determineSourceDir):
580 (windowsSourceSourceDir):
581 (windowsLibrariesDir):
583 (checkInstalledTools):
584 (buildVisualStudioProject):
586 2015-03-27 Alex Christensen <achristensen@webkit.org>
589 https://bugs.webkit.org/show_bug.cgi?id=143086
591 Reviewed by Brent Fulgham.
593 * Scripts/webkitdirs.pm:
594 (buildVisualStudioProject):
595 (runSvnUpdateAndResolveChangeLogs):
596 Use ActivePerl-friendly perl.
598 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
600 URTBF after r182059 to fix the EFL build.
602 * TestWebKitAPI/CMakeLists.txt:
604 2015-03-26 Alexey Proskuryakov <ap@apple.com>
606 Layout test results URL loads in WK1 but not WK2 minibrowser
607 https://bugs.webkit.org/show_bug.cgi?id=143117
609 Reviewed by Tim Horton.
611 * MiniBrowser/mac/WK2BrowserWindowController.m:
612 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
614 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
616 2015-03-26 Jer Noble <jer.noble@apple.com>
618 Add --allowed-host support to run-webkit-tests
619 https://bugs.webkit.org/show_bug.cgi?id=142938
621 Reviewed by Brent Fulgham.
623 Accept --allowed-host arguments from run-webkit-tests and pass them through to
624 DumpRenderTree and WebKitTestRunner.
626 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
627 are placed in the wrong location. The argument is compared with each tests's path, and if a
628 relative path or a path with '..' was used, results are placed alongside the test. Take the
629 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
631 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
633 * Scripts/webkitpy/port/base.py:
635 (Port.allowed_hosts):
636 * Scripts/webkitpy/port/driver.py:
639 2015-03-26 Jer Noble <jer.noble@apple.com>
641 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
642 https://bugs.webkit.org/show_bug.cgi?id=142931
644 Reviewed by Brent Fulgham.
646 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
647 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
648 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
651 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
652 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
654 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
655 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
656 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
657 the top loading frame from the page, as we do elsewhere in this class.
659 * DumpRenderTree/TestRunner.h:
660 (TestRunner::allowedHosts):
661 (TestRunner::setAllowedHosts):
662 * DumpRenderTree/mac/DumpRenderTree.mm:
663 (initializeGlobalsFromCommandLineOptions):
665 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
667 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
668 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
669 (WTR::InjectedBundle::didReceiveMessage):
670 (WTR::InjectedBundle::isAllowedHost):
671 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
672 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
673 (WTR::isAllowedHost):
674 (WTR::InjectedBundlePage::willSendRequestForFrame):
675 * WebKitTestRunner/InjectedBundle/TestRunner.h:
676 * WebKitTestRunner/Options.cpp:
677 (WTR::handleOptionAllowedHost):
678 (WTR::OptionsHandler::OptionsHandler):
679 * WebKitTestRunner/Options.h:
680 * WebKitTestRunner/TestController.cpp:
681 (WTR::TestController::initialize):
682 (WTR::TestController::resetStateToConsistentValues):
683 * WebKitTestRunner/TestController.h:
685 2015-03-26 Brady Eidson <beidson@apple.com>
687 Apply ContentExtension actions after redirects.
688 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
690 Reviewed by Alex Christensen.
692 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
693 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
694 which is specifically interesting to a new test.
696 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
698 [EFL] Disable building libseccomp on AArch64
699 https://bugs.webkit.org/show_bug.cgi?id=143094
701 Reviewed by Gyuyoung Kim.
705 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
707 [jhbuild] git should use only 1 thread for cloning jhbuild
708 https://bugs.webkit.org/show_bug.cgi?id=143095
710 Reviewed by Gyuyoung Kim.
712 * jhbuild/jhbuild-wrapper:
715 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
717 Update prepare-ChangeLog to work with ES6 Class syntax
718 https://bugs.webkit.org/show_bug.cgi?id=143069
720 Reviewed by Timothy Hatcher.
722 * Scripts/prepare-ChangeLog:
723 (get_function_line_ranges_for_javascript):
724 Better handle ES6 Class syntax.
726 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
727 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
730 (DerivedClass.staticMethod):
731 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
732 (DerivedClass.prototype.method):
733 (DerivedClass.prototype.get getter):
735 (namespace.MyClass.staticMethod):
736 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
737 (namespace.MyClass.prototype.method):
738 (namespace.MyClass.prototype.get getter):
741 2015-03-25 Filip Pizlo <fpizlo@apple.com>
743 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
744 https://bugs.webkit.org/show_bug.cgi?id=142993
746 Reviewed by Mark Lam.
748 Bunch of support for testing executable allocation failure.
750 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
752 * Scripts/run-javascriptcore-tests:
754 * Scripts/run-jsc-stress-tests:
756 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
758 Fix Windows build from r181977.
762 * Scripts/update-webkit-dependency:
764 2015-03-25 Sam Weinig <sam@webkit.org>
766 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
768 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
769 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
771 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
773 Migrate update-webkit for Windows to not require Cygwin
774 https://bugs.webkit.org/show_bug.cgi?id=143040
776 Reviewed by Brent Fulgham.
778 * Scripts/update-webkit-dependency:
780 (toUnixPath): Deleted.
781 * Scripts/webkitdirs.pm:
783 (checkInstalledTools):
786 2015-03-25 Sam Weinig <sam@webkit.org>
788 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
789 https://bugs.webkit.org/show_bug.cgi?id=143059
791 Reviewed by Alex Christensen.
793 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
794 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
795 Update for new interface of compileRuleList().
797 2015-03-25 Alex Christensen <achristensen@webkit.org>
799 [Content Extensions] Add multi-DFA compiling and interpreting.
800 https://bugs.webkit.org/show_bug.cgi?id=143010
802 Reviewed by Benjamin Poulain.
804 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
805 (TestWebKitAPI::testRequest):
806 (TestWebKitAPI::TEST_F):
807 Add some tests for ignore-previous-rules and large rulesets.
809 2015-03-25 Alexey Proskuryakov <ap@apple.com>
811 Mavericks WK1 still runs JSC tests
812 https://bugs.webkit.org/show_bug.cgi?id=143035
814 Reviewed by Csaba Osztrogonác.
816 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
819 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
822 2015-03-25 Commit Queue <commit-queue@webkit.org>
824 Unreviewed, rolling out r181932.
825 https://bugs.webkit.org/show_bug.cgi?id=143041
827 The test fails most of the time on bots (Requested by ap on
832 "[Content Extensions] Add multi-DFA compiling and
834 https://bugs.webkit.org/show_bug.cgi?id=143010
835 http://trac.webkit.org/changeset/181932
837 2015-03-24 Alex Christensen <achristensen@webkit.org>
839 [Content Extensions] Add multi-DFA compiling and interpreting.
840 https://bugs.webkit.org/show_bug.cgi?id=143010
842 Reviewed by Benjamin Poulain.
844 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
845 (TestWebKitAPI::testRequest):
846 (TestWebKitAPI::TEST_F):
847 Add some tests for ignore-previous-rules and large rulesets.
849 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
851 Make URL filter patterns matching consistent and add a simple canonicalization step
852 https://bugs.webkit.org/show_bug.cgi?id=142998
854 Reviewed by Alex Christensen.
856 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
858 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
860 [EFL] Add OpenWebRTC in jhbuild
861 https://bugs.webkit.org/show_bug.cgi?id=142778
863 Reviewed by Gyuyoung Kim.
865 Original patch by Philippe Normand <pnormand@igalia.com>
867 * efl/install-dependencies: Dependencies for OpenWebRTC.
868 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
869 the openwebrtc gst plugins.
871 2015-03-23 Brent Fulgham <bfulgham@apple.com>
873 Regression(r181257): WTF_WorkQueue.Simple is flaky
874 https://bugs.webkit.org/show_bug.cgi?id=142560
876 Remove the check that the refCount has returned to one after the
877 individual tasks have completed. It's too nondeterministic when
878 the reference count will be reduced.
880 Reviewed by Alexey Proskuryakov
882 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
883 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
885 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
887 [CMake][EFL] Put failure API test excutables into failure directory
888 https://bugs.webkit.org/show_bug.cgi?id=142965
890 Reviewed by Csaba Osztrogonác.
892 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
894 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
895 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
897 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
899 CSS Selectors: fix attribute case-insensitive matching of Contain and List
900 https://bugs.webkit.org/show_bug.cgi?id=142932
902 Reviewed by Darin Adler.
904 Add tests for the new features and fix some existing tests using the
905 stringFromUTF8() utility recently added by Dhi.
907 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
908 (TestWebKitAPI::stringFromUTF8):
909 * TestWebKitAPI/Tests/WTF/StringView.cpp:
911 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
913 [GTK] install-dependencies should install orc
914 https://bugs.webkit.org/show_bug.cgi?id=142955
916 Reviewed by Martin Robinson.
918 Install orc, needed by openwebrtc
920 * gtk/install-dependencies:
922 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
924 Detect when url filter pattern with groups match the empty string
925 https://bugs.webkit.org/show_bug.cgi?id=142930
927 Reviewed by Sam Weinig.
929 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
931 2015-03-22 Anders Carlsson <andersca@apple.com>
933 _WKWebsiteDataStore should clear WebSQL databases
934 https://bugs.webkit.org/show_bug.cgi?id=142947
936 Reviewed by Sam Weinig.
938 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
940 * MiniBrowser/mac/WK2BrowserWindowController.m:
941 (-[WK2BrowserWindowController fetchWebsiteData:]):
942 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
943 (-[WK2BrowserWindowController clearWebsiteData:]):
945 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
947 GCTimer should know keep track of nested GC phases
948 https://bugs.webkit.org/show_bug.cgi?id=142675
950 Reviewed by Darin Adler.
952 Adds a tool to aid in parsing the GC phase timing output into a
953 tree-like structure based on the parent-child relationships
956 * Scripts/parse-gc-phase-timings: Added.
959 (Timing.__unicode__):
968 2015-03-20 Brent Fulgham <bfulgham@apple.com>
970 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
972 * Scripts/webkitpy/common/config/ews.json:
974 2015-03-20 Philippe Normand <pnormand@igalia.com>
976 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
977 https://bugs.webkit.org/show_bug.cgi?id=142867
979 Rubber-stamped by Csaba Osztrogon.
981 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
982 a fixed revision for the openwebrtc-gst-plugins.
984 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
986 Unreviewed build fix. Don't try to report stats for all benchmarks.
987 Just report the geometric mean of preferred means.
989 * Scripts/run-jsc-benchmarks:
991 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
993 run-jsc-benchmarks should only report preferred mean
994 https://bugs.webkit.org/show_bug.cgi?id=142874
996 Reviewed by Geoffrey Garen.
998 Just collect statistics for the preferred mean.
1000 * Scripts/run-jsc-benchmarks:
1002 2015-03-19 Alex Christensen <achristensen@webkit.org>
1004 [Content Extensions] Test regular expression parse failures.
1005 https://bugs.webkit.org/show_bug.cgi?id=142872
1007 Reviewed by Benjamin Poulain.
1009 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1010 (TestWebKitAPI::testPatternStatus):
1011 (TestWebKitAPI::TEST_F):
1012 Added tests for each parsing status.
1014 2015-03-19 Alex Christensen <achristensen@webkit.org>
1016 Fix API tests after r181754.
1018 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1019 (TestWebKitAPI::testRequest):
1021 2015-03-19 Brady Eidson <beidson@apple.com>
1023 Part of content extensions should apply css selectors
1024 https://bugs.webkit.org/show_bug.cgi?id=142604
1026 Reviewed by Alex Christensen.
1028 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1029 (WebCore::ContentExtensions::operator<<):
1031 2015-03-19 Brent Fulgham <bfulgham@apple.com>
1033 [Win] Activate tests on EWS
1034 https://bugs.webkit.org/show_bug.cgi?id=142850
1036 Reviewed by Alexey Proskuryakov.
1038 * Scripts/webkitpy/common/config/ews.json: Add me as
1039 the EWS bot watcher, and activate tests.
1041 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
1043 [GTK] Fix inspector userinterface related incremental build issue
1044 https://bugs.webkit.org/show_bug.cgi?id=142849
1046 Reviewed by Carlos Garcia Campos.
1048 * Scripts/webkitdirs.pm:
1049 (shouldRemoveCMakeCache):
1051 2015-03-18 Alex Christensen <achristensen@webkit.org>
1053 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1054 https://bugs.webkit.org/show_bug.cgi?id=142799
1056 Reviewed by Brady Eidson.
1058 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1059 (TestWebKitAPI::testPattern):
1060 (TestWebKitAPI::TEST_F):
1061 Start testing regex failures.
1063 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
1065 Fix StringView typos after r181525 and r181558
1066 https://bugs.webkit.org/show_bug.cgi?id=142772
1068 Reviewed by Darin Adler.
1070 Add some tests in [1] to cover the StringView::startsWith,
1071 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1072 StringView::endsWithIgnoringASCIICase implementations.
1074 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1075 (TestWebKitAPI::TEST):
1077 2015-03-18 Dana Burkart <dburkart@apple.com>
1079 Remove extraneous import to fix the build.
1083 * Scripts/webkitpy/port/driver.py:
1085 2015-03-18 Dana Burkart <dburkart@apple.com>
1087 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1088 https://bugs.webkit.org/show_bug.cgi?id=142547
1090 Reviewed by Alexey Proskuryakov.
1092 * Scripts/webkitpy/port/driver.py:
1093 (Driver._setup_environ_for_driver):
1095 2015-03-18 Alexey Proskuryakov <ap@apple.com>
1097 Tweak how AppleSystemFontOSSubversion default is added
1098 https://bugs.webkit.org/show_bug.cgi?id=142835
1100 Reviewed by Dan Bernstein.
1102 * DumpRenderTree/mac/DumpRenderTree.mm:
1103 (setDefaultsToConsistentValuesForTesting):
1105 2015-03-18 Dan Bernstein <mitz@apple.com>
1107 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1108 https://bugs.webkit.org/show_bug.cgi?id=142815
1110 Reviewed by Darin Adler.
1112 * Scripts/prepare-ChangeLog:
1113 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1114 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1115 keep consuming the quoted text until the matching quotation mark is reached. Emit the
1116 warning only if a line ends without a backslash before the matching quotation mark was found.
1118 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
1120 Remove unused "preprocessor" parameter to sub-CodeGenerators
1121 https://bugs.webkit.org/show_bug.cgi?id=142793
1123 Reviewed by Darin Adler.
1125 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1128 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
1130 [EFL] Bump gstreamer version to 1.4.4
1131 https://bugs.webkit.org/show_bug.cgi?id=142782
1133 Reviewed by Philippe Normand.
1135 * efl/jhbuild.modules:
1136 * efl/patches/gst-libav.patch:
1137 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1138 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1140 2015-03-17 Tim Horton <timothy_horton@apple.com>
1144 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1145 (WTR::InjectedBundle::platformInitialize):
1147 2015-03-17 Dean Jackson <dino@apple.com>
1149 check-webkit-style should allow "bool a : 1"
1150 https://bugs.webkit.org/show_bug.cgi?id=142794
1152 Reviewed by Brent Fulgham.
1154 We should allow member bitfields of the form:
1158 It seems that Visual Studio 8 was the last compiler that
1159 wasn't happy about not using unsigned here. We already have
1160 about 500 cases (in WebCore) where people were ignoring this rule.
1162 * Scripts/webkitpy/style/checkers/cpp.py:
1163 (check_language): Allow "bool".
1164 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1165 (CppStyleTest.test_enum_bitfields):
1166 (CppStyleTest.test_plain_integral_bitfields):
1168 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
1170 Compile character ranges targeting the same state as range check in the bytecode
1171 https://bugs.webkit.org/show_bug.cgi?id=142759
1173 Reviewed by Alex Christensen.
1175 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1176 (TestWebKitAPI::TEST_F):
1178 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1180 W3C test parser and converter should use test importer host
1181 https://bugs.webkit.org/show_bug.cgi?id=142729
1183 Reviewed by Bem Jones-Bey.
1185 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1186 This enables adding more TestImporter unit testing.
1187 This patch also ensures that the git object instantiated by TestDownloader is using the
1188 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1190 * Scripts/webkitpy/common/system/filesystem_mock.py:
1191 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1192 * Scripts/webkitpy/w3c/test_downloader.py:
1193 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1194 (TestDownloader.checkout_test_repository): Making use of the new git function.
1195 * Scripts/webkitpy/w3c/test_importer.py:
1196 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1197 (TestImporter.import_tests): Adding host as parameter to the converter.
1198 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1199 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1201 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1202 * Scripts/webkitpy/w3c/test_parser.py:
1203 (TestParser.__init__): Adding host as parameter constructor.
1205 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
1207 [GTK] WebKitDOM objects leaking
1208 https://bugs.webkit.org/show_bug.cgi?id=118788
1210 Reviewed by Darin Adler and Sergio Villar Senin.
1212 Update DOMObjectCache unit test to check that DOM objects are also
1213 released when new contents are loaded in the web view, and the old
1214 document is detached from the frame.
1216 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1217 (testWebKitDOMObjectCache):
1218 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1221 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1223 W3C test importer default import folder should be LayoutTests/imported/w3c
1224 https://bugs.webkit.org/show_bug.cgi?id=142728
1226 Reviewed by Bem Jones-Bey.
1228 * Scripts/webkitpy/w3c/test_importer.py:
1229 (parse_args): Updating the default destination option value to 'imported/w3c'.
1231 2015-03-17 Philippe Normand <pnormand@igalia.com>
1233 [GTK] basic OpenWebRTC build support
1234 https://bugs.webkit.org/show_bug.cgi?id=142393
1236 Reviewed by Carlos Garcia Campos.
1238 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1239 is not the upstream OpenWebRTC repository. This temporary fork
1240 contains a few patches needed by WebKit for audio/video rendering.
1242 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1244 [CMake][EFL] Build test tools only for developer mode
1245 https://bugs.webkit.org/show_bug.cgi?id=142761
1247 Reviewed by Csaba Osztrogonác.
1249 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1253 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
1255 Remove never used "useLayerOnTop" bindings generator argument
1256 https://bugs.webkit.org/show_bug.cgi?id=142773
1258 Reviewed by Darin Adler.
1260 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1263 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
1265 Enable ES6 classes by default
1266 https://bugs.webkit.org/show_bug.cgi?id=142774
1268 Reviewed by Gavin Barraclough.
1270 * Scripts/webkitperl/FeatureList.pm:
1272 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1274 Fix webkitpy tests after r181585.
1276 Looks like "me" cannot be anyone's email, it's a special case.
1278 * Scripts/webkitpy/common/config/contributors.json:
1280 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1282 Add tolerance to WebAudio tests
1283 https://bugs.webkit.org/show_bug.cgi?id=142676
1285 Reviewed by Tim Horton.
1287 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1289 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1290 (TestResultWriter.create_audio_diff_and_write_result):
1291 * Scripts/webkitpy/layout_tests/models/test_failures.py:
1292 (FailureAudio.write_failure):
1293 * Scripts/webkitpy/port/base.py:
1294 (Port.do_audio_results_differ):
1295 Diff audio failures.
1297 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1298 tests to use real parseable WAV data, and got rid of base64, which there didn't
1299 seem to have been any reason for.
1301 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1303 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1304 https://bugs.webkit.org/show_bug.cgi?id=142720
1306 Reviewed by Myles C. Maxfield.
1308 Activate system copies of Microsoft fonts for the current process, thus overriding
1309 any other ones that could be preferred by the system otherwise.
1311 * DumpRenderTree/mac/DumpRenderTree.mm:
1312 (activateSystemCoreWebFonts):
1314 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1315 (WTR::activateSystemCoreWebFonts):
1316 (WTR::activateFonts):
1318 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1320 Created Streams API watchlist
1321 https://bugs.webkit.org/show_bug.cgi?id=142684
1323 Reviewed by Benjamin Poulain.
1325 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1326 watchlist and added Benjamin, Youenn and me to it.
1328 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
1330 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1331 https://bugs.webkit.org/show_bug.cgi?id=142715
1333 Reviewed by Brent Fulgham.
1335 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1336 (TestWebKitAPI::TEST):
1338 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
1340 Change the exact attribute matching to be ASCII case-insensitive
1341 https://bugs.webkit.org/show_bug.cgi?id=142609
1343 Reviewed by Darin Adler.
1345 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1346 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1348 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
1350 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1351 https://bugs.webkit.org/show_bug.cgi?id=134764
1353 Reviewed by Ryosuke Niwa.
1355 TestDownloader is introduced to download W3C tests from the official
1356 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1357 and https://github.com/w3c/csswg-test.git).
1358 TestDownloader clones the repositories and checkouts revisions of the tests
1359 defined in LayoutTests/imported/w3c/resources/TestRepositories.
1361 Similarly to https://codereview.chromium.org/148173016,
1362 TestDownloader copies part of the files based on the rules
1363 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1365 TestDownloader is used by TestImporter when no source directory is provided.
1367 * Scripts/webkitpy/w3c/test_downloader.py: Added.
1369 (TestDownloader.default_options):
1370 (TestDownloader.load_test_repositories):
1371 (TestDownloader.__init__):
1372 (TestDownloader.checkout_test_repository):
1373 (TestDownloader._init_paths_from_expectations):
1374 (TestDownloader._add_test_suite_paths):
1375 (TestDownloader._empty_directory):
1376 (TestDownloader.copy_tests):
1377 (TestDownloader.download_tests):
1378 * Scripts/webkitpy/w3c/test_importer.py:
1381 (TestImporter.__init__):
1382 (TestImporter.do_import):
1383 (TestImporter.test_downloader):
1384 (TestImporter.find_importable_tests.should_keep_subdir):
1385 (TestImporter.should_convert_test_harness_links):
1386 (TestImporter.import_tests):
1387 (TestImporter.write_import_log):
1389 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1391 [Mavericks] Test snapshots are 1600x1200 on Retina devices
1392 https://bugs.webkit.org/show_bug.cgi?id=142630
1394 Reviewed by Tim Horton.
1396 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1397 Removed an ifdef that disabled the fix on Mavericks.
1399 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1401 Remove isWK2 cruft from webkitdirs.pm after r170426
1402 https://bugs.webkit.org/show_bug.cgi?id=142618
1404 Reviewed by Daniel Bates.
1406 * Scripts/webkitdirs.pm:
1409 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1411 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1412 https://bugs.webkit.org/show_bug.cgi?id=138687
1414 Reviewed by Carlos Garcia Campos.
1416 Always change cookie policy from UI process, as changing it from WebProcess doesn't
1417 affect other processes.
1419 The implementation is imperfect, because the change happens asynchronously, but I
1420 don't expect it to be a problem in practice.
1422 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1423 (WTR::InjectedBundle::beginTesting):
1424 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1425 (WTR::TestRunner::setAlwaysAcceptCookies):
1426 * WebKitTestRunner/TestInvocation.cpp:
1427 (WTR::TestInvocation::invoke):
1428 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1430 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1432 [EFL] Enable building EFL 1.13 with NEON support
1433 https://bugs.webkit.org/show_bug.cgi?id=142619
1435 Reviewed by Gyuyoung Kim.
1437 * efl/jhbuild.modules:
1439 2015-03-11 Alex Christensen <achristensen@webkit.org>
1441 [Content Extensions] Add resource type and load type triggers.
1442 https://bugs.webkit.org/show_bug.cgi?id=142422
1444 Reviewed by Benjamin Poulain.
1446 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1447 (TestWebKitAPI::testRequest):
1448 (TestWebKitAPI::mainDocumentRequest):
1449 (TestWebKitAPI::TEST_F):
1450 (TestWebKitAPI::testURL): Deleted.
1452 2015-03-10 Sam Weinig <sam@webkit.org>
1454 Allow adding a button in input elements for auto fill related functionality
1455 <rdar://problem/19782066>
1456 https://bugs.webkit.org/show_bug.cgi?id=142564
1458 Reviewed by Anders Carlsson.
1460 * WebKitTestRunner/TestController.cpp:
1461 (WTR::TestController::createOtherPage):
1462 (WTR::TestController::createWebViewWithOptions):
1463 Update for new callback.
1465 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
1467 Add basic support for BOL and EOL assertions to the URL Filter parser
1468 https://bugs.webkit.org/show_bug.cgi?id=142568
1470 Reviewed by Alex Christensen.
1472 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1473 (TestWebKitAPI::TEST_F):
1475 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1477 [GTK] Add support for handling TLS errors to MiniBrowser
1478 https://bugs.webkit.org/show_bug.cgi?id=142576
1480 Reviewed by Sergio Villar Senin.
1482 It's useful for testing TLS errors handling itself, but also to
1483 allow ignoring TLS errors when testing.
1485 * MiniBrowser/gtk/BrowserWindow.c:
1486 (webViewLoadFailedWithTLSerrors):
1487 (browserWindowConstructed):
1489 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
1491 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1492 https://bugs.webkit.org/show_bug.cgi?id=142569
1494 Reviewed by David Hyatt.
1496 Test Optional::valueOrCompute().
1498 * TestWebKitAPI/Tests/WTF/Optional.cpp:
1499 (TestWebKitAPI::TEST):
1501 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1503 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1504 https://bugs.webkit.org/show_bug.cgi?id=126688
1506 Reviewed by Gustavo Noronha Silva.
1508 * CMakeLists.txt: Build testing tools only for developer builds,
1509 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1510 * MiniBrowser/gtk/CMakeLists.txt: Only add
1511 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1512 and add a rule to install the MiniBrowser.
1513 * MiniBrowser/gtk/main.c:
1514 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1517 2015-03-11 Brent Fulgham <bfulgham@apple.com>
1519 Add some DateMath tests to TestWebKitAPI
1520 https://bugs.webkit.org/show_bug.cgi?id=142565
1522 Reviewed by Alexey Proskuryakov.
1524 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1525 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1526 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1527 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1528 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1530 2015-03-10 Brent Fulgham <bfulgham@apple.com>
1532 Regression(r181257): WTF_WorkQueue.Simple is flaky
1533 https://bugs.webkit.org/show_bug.cgi?id=142560
1535 Unreviewed attempt to improve test stability.
1537 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1538 the WorkQueue a little later to redue flakiness.
1540 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
1542 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1543 https://bugs.webkit.org/show_bug.cgi?id=142555
1545 Reviewed by Simon Fraser.
1547 * DumpRenderTree/mac/DumpRenderTree.mm:
1548 (setDefaultsToConsistentValuesForTesting):
1549 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1550 (WTR::InjectedBundle::platformInitialize):
1552 2015-03-10 Alex Christensen <achristensen@webkit.org>
1554 Use unsigned for HashSet size.
1555 https://bugs.webkit.org/show_bug.cgi?id=142518
1557 Reviewed by Benjamin Poulain.
1559 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1560 (TestWebKitAPI::TEST):
1561 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1562 (TestWebKitAPI::testInitialCapacity):
1563 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1564 (TestWebKitAPI::TEST):
1566 2015-03-10 Daniel Bates <dabates@apple.com>
1568 [iOS] Add WebKitSystemInterface for iOS 8.2
1569 https://bugs.webkit.org/show_bug.cgi?id=142505
1571 Rubber-stamped by Anders Carlsson.
1573 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1574 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1575 copy-webkitlibraries-to-product-directory in r181286.
1577 * Scripts/copy-webkitlibraries-to-product-directory:
1579 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
1581 Extend URL filter's Term definition to support groups/subpatterns
1582 https://bugs.webkit.org/show_bug.cgi?id=142519
1584 Reviewed by Alex Christensen.
1586 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1587 (TestWebKitAPI::testURL):
1589 2015-03-06 Jer Noble <jer.noble@apple.com>
1591 Add an option to run-webkit-tests to override the LayoutTests/ directory
1592 https://bugs.webkit.org/show_bug.cgi?id=142418
1594 Reviewed by David Kilzer.
1596 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1597 directory. The base port will parse the options during initialization and store the override
1598 location if present. layout_tests_dir() will return this overridden location if set.
1600 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1602 * Scripts/webkitpy/port/base.py:
1604 (Port.layout_tests_dir):
1606 2015-03-09 Martin Robinson <mrobinson@igalia.com>
1608 [CMake] Enable WorkQueue tests for CMake ports
1609 https://bugs.webkit.org/show_bug.cgi?id=142473
1611 Reviewed by Darin Adler.
1613 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1614 the list of source files.
1615 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1616 to the list of include directories for EFL.
1618 2015-03-09 David Kilzer <ddkilzer@apple.com>
1620 Attempt to fix timeouts on iOS Simulator layout tests
1622 * Scripts/webkitpy/port/ios.py:
1623 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1624 Simulator end after the first 50 tests time out. Some analysis
1625 this past weekend shows that the 'Booted' status in the output
1626 of `xcrun simctl list` is not sufficient (and watching the test
1627 run shows that SpringBoard hasn't fully started to the point
1628 where it's displaying icons on the home screen). The workaround
1629 until we have a better fix is to add an arbitrary timeout to let
1630 SpringBoard finish launching. In practice, 15 seconds is
1631 probably enough, but 30 seconds should nearly always work.
1633 2015-03-09 Per Arne Vollan <peavo@outlook.com>
1635 Unreviewed. Add myself as a committer.
1637 * Scripts/webkitpy/common/config/contributors.json:
1639 2015-03-09 David Kilzer <ddkilzer@apple.com>
1641 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1643 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1644 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1645 an expectation that will fail if we hit the race condition.
1646 This test is inherently racy and will deadlock if the first job
1647 for queue2 takes the mutex lock before the second job for
1650 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1652 [Win] WTF::WorkQueue does not balance ref/deref properly
1653 https://bugs.webkit.org/show_bug.cgi?id=142471
1655 Reviewed by Antti Koivisto.
1657 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1658 (TestWebKitAPI::TEST): Check that the refcount is correct.
1660 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1662 Do not show passing test result on output of EFL layout test
1663 https://bugs.webkit.org/show_bug.cgi?id=142380
1665 Reviewed by Darin Adler.
1667 To show passing tests has caused inconvenience when we detect problem tests
1668 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1669 in order not to show passing tests in the output of EFL layout test.
1671 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1672 (RunWebKitTests.start):
1674 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1676 Unreviewed build fix.
1678 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1679 (TestWebKitAPI::TEST): Remove two unused variables.
1681 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1683 Add some WorkQueue tests to TestWebKitAPI
1684 https://bugs.webkit.org/show_bug.cgi?id=142447
1686 Reviewed by Sam Weinig.
1688 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1689 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1690 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1691 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1692 (TestWebKitAPI::simpleTest):
1693 (TestWebKitAPI::longTest):
1694 (TestWebKitAPI::thirdTest):
1695 (TestWebKitAPI::finishedTests):
1696 (TestWebKitAPI::TEST):
1697 (TestWebKitAPI::longTest2):
1699 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
1701 Remove willDestroyFrame in WKBundlePageLoaderClient
1702 https://bugs.webkit.org/show_bug.cgi?id=142389
1704 Reviewed by Anders Carlsson.
1706 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1707 (WTR::InjectedBundlePage::InjectedBundlePage):
1709 2015-03-07 Brent Fulgham <bfulgham@apple.com>
1711 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1712 https://bugs.webkit.org/show_bug.cgi?id=142433
1714 Reviewed by Darin Adler.
1716 Include more TestWebKitAPI tests when building for Windows. Also
1717 fix a build error in MetaAllocator.cpp caused by one of the
1718 Microsoft headers #defining 'small'.
1720 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1721 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1722 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1724 2015-03-06 Sam Weinig <sam@webkit.org>
1726 [Content Extensions] Move compiling of content extensions to the UIProcess
1727 https://bugs.webkit.org/show_bug.cgi?id=142402
1729 Reviewed by Benjamin Poulain.
1731 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1733 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1734 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1735 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1736 (TestWebKitAPI::TEST_F):
1737 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1738 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1741 2015-03-06 Brent Fulgham <bfulgham@apple.com>
1743 [Win] Correct Windows build.
1745 Rubberstamped by Michael Saboff
1747 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1750 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
1752 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1753 https://bugs.webkit.org/show_bug.cgi?id=142385
1755 Reviewed by Sergio Villar Senin.
1757 Use stack allocated GMainLoopSources to make sure they are
1758 cancelled automatically if the test finishes before they have
1761 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1762 (testWebViewSyncRequestOnMaxConns):
1764 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1766 Remove Mountain Lion libraries since ML isn't supported
1767 https://bugs.webkit.org/show_bug.cgi?id=142332
1769 Reviewed by Darin Adler.
1771 * Scripts/copy-webkitlibraries-to-product-directory:
1773 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
1775 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1776 https://bugs.webkit.org/show_bug.cgi?id=142083
1778 Reviewed by Simon Fraser.
1780 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1782 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1783 (WebPlatformTestServer._copy_webkit_test_files):
1785 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1787 setup-git-clone fails due to the failure to download python-irclib-0.4.8
1788 https://bugs.webkit.org/show_bug.cgi?id=141946
1790 Reviewed by Ryosuke Niwa.
1792 Check in ircbot.py and irclib.py to avoid network problems in the future.
1794 * Scripts/webkitpy/common/net/irc/ircbot.py:
1795 * Scripts/webkitpy/thirdparty/__init__.py:
1796 (AutoinstallImportHook.find_module):
1797 (AutoinstallImportHook._install_irc): Deleted.
1798 * Scripts/webkitpy/thirdparty/__init___unittest.py:
1799 (ThirdpartyTest.test_imports):
1800 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1801 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1802 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1804 2015-03-06 David Kilzer <ddkilzer@apple.com>
1806 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1808 See also fix to config.json in r181097.
1810 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1811 (WebKitBuildbot): Add missing "WK2" to the names of the perf
1814 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1816 run-jsc-stress-tests should determine the architecture from ELF binaries
1817 https://bugs.webkit.org/show_bug.cgi?id=142335
1819 Reviewed by Darin Adler.
1821 * Scripts/run-jsc-stress-tests:
1823 2015-03-05 David Kilzer <ddkilzer@apple.com>
1825 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1826 <http://webkit.org/b/142226>
1828 Reviewed by Darin Adler.
1830 * Scripts/webkitpy/port/ios.py:
1831 (IOSSimulatorPort.default_baseline_search_path): Switch the
1832 TestExpectations order of ios-simulator-wk2 from this:
1833 ios-simulator-wk2, wk2, ios-simulator
1835 ios-simulator-wk2, ios-simualtor, wk2
1837 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1839 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1840 https://bugs.webkit.org/show_bug.cgi?id=142370
1842 Reviewed by Dean Jackson.
1844 * Scripts/webkitdirs.pm:
1845 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1846 logs, one for warnings, the other for errors.
1847 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1848 into the standard BuildOutput.htm document.
1850 2015-03-05 David Kilzer <ddkilzer@apple.com>
1852 Dashboard has trouble parsing iOS test output
1853 <http://webkit.org/b/142364>
1855 Reviewed by Alex Christensen.
1857 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1858 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1859 Add fallback path to build a regex using 'matchString' so that
1860 it matches anywhere in the line. In practice, 'matchString' is
1861 a prefix for the label following the number.
1863 2015-03-05 Alex Christensen <achristensen@webkit.org>
1865 Fix linker warnings in TestWebKitAPI.
1866 https://bugs.webkit.org/show_bug.cgi?id=141912
1868 Reviewed by David Kilzer.
1870 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1871 Do not export TearDownTestCase or SetUpTestCase symbols.
1873 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1875 [Win] Unreviewed EWS fix.
1877 * Scripts/webkitdirs.pm:
1878 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1879 the EWS output more usable.
1881 2015-03-05 Chris Dumez <cdumez@apple.com>
1883 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1884 https://bugs.webkit.org/show_bug.cgi?id=142350
1886 Reviewed by Michael Saboff and Benjamin Poulain.
1888 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1889 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1891 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1892 (TestWebKitAPI::TEST):
1894 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1896 [Win] Ensure build target directory exists when launching MSBuild
1897 https://bugs.webkit.org/show_bug.cgi?id=142360
1899 Reviewed by Dean Jackson.
1901 Create the build output directory (if it doesn't exist) before
1902 launching MSBuild so that it can immediately begin writing logs.
1904 * Scripts/webkitdirs.pm:
1905 (buildVisualStudioProject):
1907 2015-03-05 Chris Dumez <cdumez@apple.com>
1909 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1910 https://bugs.webkit.org/show_bug.cgi?id=142325
1912 Reviewed by Csaba Osztrogonác.
1914 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1915 As a result, "--webkit-test-runner / -2" parameters are replaced by
1916 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1917 than WebKitTestRunner.
1919 * BuildSlaveSupport/build.webkit.org-config/config.json:
1920 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1922 (RunWebKit1Tests.start):
1923 (RunWebKit1LeakTests):
1924 (RunWebKit1LeakTests.start):
1925 (RunAndUploadPerfTestsWebKit1):
1926 (RunAndUploadPerfTestsWebKit1.start):
1928 (TestWebKit1LeaksFactory):
1929 (TestWebKit1LeaksFactory.__init__):
1930 (TestWebKit1Factory):
1931 (TestWebKit1AllButJSCFactory):
1932 (TestAllButJSCFactory):
1933 (BuildAndPerfTestWebKit1Factory):
1934 (BuildAndPerfTestWebKit1Factory.__init__):
1935 (BuildAndPerfTestFactory):
1936 (BuildAndPerfTestFactory.__init__):
1937 (DownloadAndPerfTestWebKit1Factory):
1938 (DownloadAndPerfTestWebKit1Factory.__init__):
1939 (DownloadAndPerfTestFactory):
1940 (DownloadAndPerfTestFactory.__init__):
1941 (RunWebKitLeakTests): Deleted.
1942 (RunWebKitLeakTests.start): Deleted.
1943 (RunWebKit2Tests): Deleted.
1944 (RunWebKit2Tests.start): Deleted.
1945 (RunAndUploadPerfTestsWebKit2): Deleted.
1946 (RunAndUploadPerfTestsWebKit2.start): Deleted.
1947 (TestLeaksFactory): Deleted.
1948 (TestLeaksFactory.__init__): Deleted.
1949 (TestWebKit2Factory): Deleted.
1950 (TestWebKit2AndJSCFactory): Deleted.
1951 (BuildAndPerfTestWebKit2Factory): Deleted.
1952 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1953 (DownloadAndPerfTestWebKit2Factory): Deleted.
1954 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1955 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1957 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1958 (PerfTestsRunner._parse_args):
1959 * Scripts/webkitpy/port/port_testcase.py:
1960 (PortTestCase.test_build_driver):
1962 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1964 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1965 https://bugs.webkit.org/show_bug.cgi?id=140845
1967 Reviewed by David Kilzer.
1969 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1970 and generate suitable build commands to drive a full build from our
1971 existing solution files.
1973 * Scripts/webkitdirs.pm:
1974 (msBuildInstallDir): Added.
1975 (determineConfigurationForVisualStudio): Revise to use MSBuild command
1976 line arguments to drive the build.
1977 (setupCygwinEnv): Warn user if MSBuild cannot be located.
1978 (buildVisualStudioProject): Revise to use MSBuild command line arguments
1979 to specify build architecture.
1980 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1981 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1982 bother looking for CoreUI or SafariTheme build logs.
1984 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
1986 [buildbot] mastercfg_unittest.py should be runnable easily
1987 https://bugs.webkit.org/show_bug.cgi?id=142219
1989 Reviewed by Chris Dumez.
1991 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1992 the last Twisted version works together with this buildbot version.
1994 * Scripts/webkitpy/common/system/autoinstall.py:
1995 (AutoInstaller): Added prepend_to_search_path argument to be able
1996 to prefer autoinstalled package to system package.
1997 (AutoInstaller.__init__):
1998 (AutoInstaller._set_up_target_dir):
1999 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2000 (AutoInstaller._prepare_package):
2001 (AutoInstaller._extract_targz): Renamed to _extract_tar.
2002 * Scripts/webkitpy/thirdparty/__init__.py:
2003 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2005 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
2007 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2008 https://bugs.webkit.org/show_bug.cgi?id=131162
2010 Reviewed by Gyuyoung Kim.
2012 * MiniBrowser/efl/main.c:
2013 (on_download_request):
2014 (on_download_finished):
2015 (on_download_failed):
2017 Adapt download callbacks to new callback mechanism
2019 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2021 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2023 In r180927 we updated the libsoup version used by the jhbuild. In
2024 this new version the sniffer uses image/x-icon instead of
2025 image/vnd.microsoft.icon for blank.ico resource.
2027 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2028 (testWebResourceMimeType):
2030 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2032 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2033 https://bugs.webkit.org/show_bug.cgi?id=142244
2035 Reviewed by Sergio Villar Senin.
2037 Check that the SSL server doesn't process any request in case of
2038 TLS errors when the policy is set to FAIL.
2040 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2041 (testTLSErrorsPolicy):
2042 (testTLSErrorsRedirect):
2043 (testTLSErrorsHTTPAuth):
2044 (testLoadFailedWithTLSErrors):
2045 (testSubresourceLoadFailedWithTLSErrors):
2046 (httpsServerCallback):
2048 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
2050 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2051 https://bugs.webkit.org/show_bug.cgi?id=141154
2053 Reviewed by Jer Noble.
2055 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2057 For the sake of completeness WebKitTestRunner should specify temporary
2058 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2060 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2061 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2062 to get data storage paths. Only Mac port has an actual implementation of it.
2063 However, WebKitTestRunner overrides them in favour of unique temporary dir
2064 which is taken from libraryPathForTesting().
2066 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2067 is not implemented for EFL and GTK ports it returns an empty string.
2068 All default data folders besides MediaKeys are overridden in TestRunner
2069 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2072 GTK port does not enable encrypted keys by default so
2073 WebMediaKeyStorageManager::initialize() code path is never triggered.
2075 * WebKitTestRunner/TestController.cpp:
2076 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2079 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
2081 [buildbot] Add regression test to check which builder runs which tests
2082 https://bugs.webkit.org/show_bug.cgi?id=142166
2084 Reviewed by Alexey Proskuryakov.
2086 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2087 (BuildStepsConstructorTest.createTest):
2089 (BuildStepsTest.generateTests):
2090 (BuildStepsTest.createTest):
2091 (BuildStepsTest.createTest.doTest):
2092 (BuildStepsTest.test_unnecessary_expected_results):
2094 2015-03-04 Commit Queue <commit-queue@webkit.org>
2096 Unreviewed, rolling out r181054.
2097 https://bugs.webkit.org/show_bug.cgi?id=142320
2099 Broke the api tests (Requested by sundiamonde on #webkit).
2103 "Fix linker warnings in TestWebKitAPI."
2104 https://bugs.webkit.org/show_bug.cgi?id=141912
2105 http://trac.webkit.org/changeset/181054
2107 2015-03-04 Alex Christensen <achristensen@webkit.org>
2109 Fix linker warnings in TestWebKitAPI.
2110 https://bugs.webkit.org/show_bug.cgi?id=141912
2112 Reviewed by David Kilzer.
2114 * TestWebKitAPI/Configurations/Base.xcconfig:
2115 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2117 2015-03-04 Alexey Proskuryakov <ap@apple.com>
2119 [Mac] Set SystemUIFontSelect in DRT and WKTR
2120 https://bugs.webkit.org/show_bug.cgi?id=142303
2122 Reviewed by Myles C. Maxfield.
2124 * DumpRenderTree/mac/DumpRenderTree.mm:
2125 (setDefaultsToConsistentValuesForTesting):
2126 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2127 (WTR::InjectedBundle::platformInitialize):
2129 2015-03-04 Chris Dumez <cdumez@apple.com>
2131 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2132 https://bugs.webkit.org/show_bug.cgi?id=142314
2133 <rdar://problem/20046835>
2135 Reviewed by Ryosuke Niwa.
2137 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2138 to get WK2 code coverage.
2140 * BuildSlaveSupport/build.webkit.org-config/config.json:
2142 2015-03-04 Alex Christensen <achristensen@webkit.org>
2144 Move content extensions test to properly named directory.
2145 https://bugs.webkit.org/show_bug.cgi?id=142299
2147 Reviewed by Tim Horton.
2149 * WebKitTestRunner/mac/TestControllerMac.mm:
2150 (WTR::TestController::platformConfigureViewForTest):
2152 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
2154 W3C test importer should use filesystem instead of os.walk
2155 https://bugs.webkit.org/show_bug.cgi?id=142085
2157 Reviewed by Bem Jones-Bey.
2159 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2160 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2161 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2163 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2164 Added a unit test to check that test importer is now black-box testable using a Mock system.
2166 * Scripts/webkitpy/common/system/filesystem.py:
2167 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2168 (FileSystem.dirs_under.filter_all):
2169 * Scripts/webkitpy/common/system/filesystem_mock.py:
2170 (MockFileSystem.dirs_under):
2171 (MockFileSystem.dirs_under.filter_all):
2172 (MockFileSystem.getsize):
2173 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2174 (MockFileSystemTest.test_dirs_under):
2175 (MockFileSystemTest.test_dirs_under.filter_dir):
2176 * Scripts/webkitpy/common/system/filesystem_unittest.py:
2177 (RealFileSystemTest.test_sep):
2178 (RealFileSystemTest):
2179 (RealFileSystemTest.test_dirs_under):
2180 (RealFileSystemTest.test_dirs_under.filter_this_dir):
2181 * Scripts/webkitpy/w3c/test_importer.py:
2182 (TestImporter.do_import):
2183 (TestImporter.find_importable_tests.should_keep_subdir):
2184 (TestImporter.find_importable_tests):
2185 (TestImporter.should_keep_subdir): Deleted.
2186 (TestImporter.should_skip_file): Deleted.
2187 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2188 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2190 2015-03-04 Timothy Horton <timothy_horton@apple.com>
2192 [WebEditingTester] Add support for the find and replace bar
2193 https://bugs.webkit.org/show_bug.cgi?id=142247
2195 Reviewed by Enrica Casucci.
2197 While it's not hooked up yet in WKWebView, adding support for the
2198 find bar to WebEditingTester will help us implement that functionality.
2200 * WebEditingTester/AppDelegate.h:
2201 * WebEditingTester/AppDelegate.m:
2202 (-[WebEditingAppDelegate performTextFinderAction:]):
2203 * WebEditingTester/MainMenu.xib:
2204 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2206 * WebEditingTester/WK2WebDocumentController.m:
2207 (-[WK2WebDocumentController awakeFromNib]):
2208 (-[WK2WebDocumentController performTextFinderAction:]):
2209 (-[WK2WebDocumentController findBarView]):
2210 (-[WK2WebDocumentController setFindBarView:]):
2211 (-[WK2WebDocumentController isFindBarVisible]):
2212 (-[WK2WebDocumentController setFindBarVisible:]):
2213 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2214 (-[WK2WebDocumentController layout]):
2215 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2216 pointing at the WKWebView (currently nothing will work, but the bar will
2217 show up). Install and uninstall the bar as needed.
2219 * WebEditingTester/WebDocument.xib:
2220 Don't use a full-size content view. There's no need, and it makes find
2223 * WebEditingTester/WebDocumentController.h:
2224 * WebEditingTester/WebDocumentController.m:
2225 (-[WebDocumentController performTextFinderAction:]):
2227 2015-03-03 Sam Weinig <sam@webkit.org>
2229 [Content Extensions] Split parsing and compiling of content extensions into their own files
2230 https://bugs.webkit.org/show_bug.cgi?id=142259
2232 Reviewed by Anders Carlsson.
2234 Add basic unit test for the content filter compiler.
2236 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2238 (WebCore::ContentExtensions::operator<<):
2239 (TestWebKitAPI::ContentFilterTest::SetUp):
2240 (TestWebKitAPI::TEST_F):
2242 2015-03-04 Matthew Mirman <mmirman@apple.com>
2244 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2245 https://bugs.webkit.org/show_bug.cgi?id=142230
2247 Reviewed by Csaba Osztrogonác.
2249 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2251 (TestFactory.getProduct): Added
2252 (TestFactory.__init__): moved downloader to getProduct
2253 (BuildAndTestFactory):
2254 (BuildAndTestFactory.getProduct): Added
2255 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2256 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
2258 2015-03-04 Debarshi Ray <debarshir@gnome.org>
2260 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2261 https://bugs.webkit.org/show_bug.cgi?id=142225
2263 Reviewed by Carlos Garcia Campos.
2265 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2266 (testWebViewWebContextLifetime):
2269 2015-03-03 David Kilzer <ddkilzer@apple.com>
2271 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2272 <http://webkit.org/b/142243>
2274 Reviewed by Alexey Proskuryakov.
2276 * WebKitTestRunner/TestController.cpp:
2277 (WTR::TestController::webProcessName):
2278 (WTR::TestController::networkProcessName):
2279 - Return the same process name on iOS and Mac because they both
2280 use the same process name for local engineering builds.
2282 2015-03-03 David Kilzer <ddkilzer@apple.com>
2284 check-webkit-style: Add exception for FrameworkSoftLink.h header order
2285 <http://webkit.org/b/141872>
2287 Reviewed by Alex Christensen.
2289 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2290 semi-colons in various places and fix whitespace.
2291 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2293 (_IncludeState.__init__): Add self._visited_soft_link_section
2294 boolean state variable.
2295 (_IncludeState.visited_soft_link_section): Getter for
2296 self._visited_soft_link_section.
2297 (_IncludeState.check_next_include_order): Update state machine
2298 for soft-link headers. Add check that soft-link headers always
2300 (_classify_include): Add check for soft-link header type.
2301 (check_include_line): Return early if there is a soft-link
2304 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2305 (OrderOfIncludesTest.test_public_primary_header): Add tests for
2306 including soft-link headers.
2307 (OrderOfIncludesTest.test_classify_include): Add test for
2308 _SOFT_LINK_HEADER type.
2310 2015-03-03 Alexey Proskuryakov <ap@apple.com>
2312 build.webkit.org/dashboard: Don't repeatedly handle each test type
2313 https://bugs.webkit.org/show_bug.cgi?id=142211
2315 Reviewed by Tim Horton and Matt Hanson.
2317 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2318 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2319 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2320 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2321 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2322 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2323 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2324 Removed functions that build a link to test step results. The buildbot provides
2325 these links in JSON.
2327 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2328 (BuildbotIteration): Put failing tests into an array, instead of named variables.
2329 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2330 We can easily add them to the map as needed.
2331 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2332 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2333 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2334 and then build a BuildbotTestResults object, which was strange.
2335 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2337 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2338 Corrected an unrelated assertion that was buggy, and kept firing.
2340 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2341 (BuildbotTestResults):
2342 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2343 (BuildbotTestResults.prototype._parseResults):
2344 (BuildbotTestResults.prototype.addFullLayoutTestResults):
2345 Moved the code for parsing JSON results for a single step here.
2347 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2348 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2349 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2350 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2351 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2352 (BuildbotTesterQueueView.prototype.update): Deleted.
2353 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2354 Updated for the new data structures. One behavior change is that we now display individual
2355 counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2356 test failures, 3 platform api test failures".
2358 2015-03-03 Matthew Mirman <mmirman@apple.com>
2360 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2361 https://bugs.webkit.org/show_bug.cgi?id=142094
2363 Reviewed by Csaba Osztrogonác.
2365 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2366 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2368 (TestFactory.__init__): Made running of JSC tests conditional.
2369 (TestAllButJSCFactory):
2370 (TestJSCFactory): Added.
2371 (TestJSCFactory.__init__):
2372 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2374 2015-03-03 David Kilzer <ddkilzer@apple.com>
2376 `build-webkit --help` is wrong about how to build for the iOS simulator
2377 <http://webkit.org/b/142223>
2379 Reviewed by Csaba Osztrogonác.
2381 * Scripts/build-webkit: Fix help.
2383 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2385 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2387 * gtk/jhbuild.modules:
2389 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2391 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2392 https://bugs.webkit.org/show_bug.cgi?id=141508
2394 Reviewed by Sergio Villar Senin.
2396 Add a unit test to check that synchronous XHRs load even if the
2397 maximum connection limits are reached.
2399 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2400 (testWebViewSyncRequestOnMaxConns):
2403 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2405 2015-03-02 Alexey Proskuryakov <ap@apple.com>
2407 Update the name of ASan build step.
2409 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2411 2015-03-02 Jer Noble <jer.noble@apple.com>
2413 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2414 https://bugs.webkit.org/show_bug.cgi?id=142121
2416 Reviewed by Simon Fraser.
2418 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2419 that the initial and final screen rects for the web content are as expected.
2421 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2422 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2423 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2424 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2425 (runJavaScriptAlert):
2426 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2427 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2428 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2429 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2430 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2431 (TestWebKitAPI::TEST_F):
2433 2015-03-01 David Kilzer <ddkilzer@apple.com>
2435 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2439 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2440 <http://webkit.org/b/142145>
2442 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2443 (-[LTRelayController _environmentVariables]): Fix think-o.
2445 2015-03-01 David Kilzer <ddkilzer@apple.com>
2447 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2448 <http://webkit.org/b/142145>
2450 Reviewed by Simon Fraser.
2452 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2453 (-[LTRelayController _environmentVariables]): Add.
2454 (-[LTRelayController launchApp]): Use -_environmentVariables.
2456 2015-02-28 David Kilzer <ddkilzer@apple.com>
2458 [iOS] Stop running webkit-build-directory on every layout test
2460 This was originally fixed by David Farler for Bug 135409 in
2463 * Scripts/webkitpy/port/ios.py:
2464 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2465 run webkit-build-directory every time it's called.
2467 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2469 W3C importer should use filesystem instead of shutil/host
2470 https://bugs.webkit.org/show_bug.cgi?id=142012
2472 Reviewed by Bem Jones-Bey.
2474 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2476 * Scripts/webkitpy/w3c/test_importer.py:
2478 (TestImporter.do_import):
2479 (TestImporter.find_importable_tests):
2480 (TestImporter.import_tests):
2481 (TestImporter.remove_deleted_files):
2482 (TestImporter.write_import_log):
2484 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2486 W3C test importer should use filesystem to read and write files
2487 https://bugs.webkit.org/show_bug.cgi?id=142084
2489 Reviewed by Bem Jones-Bey.
2491 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2493 * Scripts/webkitpy/w3c/test_importer.py:
2494 (TestImporter.import_tests):
2495 (TestImporter.remove_deleted_files):
2496 (TestImporter.write_import_log):
2498 2015-02-27 Sam Weinig <sam@webkit.org>
2500 Add WebKit2 SPI to create a DOM File object
2501 https://bugs.webkit.org/show_bug.cgi?id=142109
2503 Reviewed by Tim Horton.
2505 Add a test for WKBundleFileHandleRef.
2507 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2508 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2509 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2510 (TestWebKitAPI::didFinishLoadForFrame):
2511 (TestWebKitAPI::TEST):
2512 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2513 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2514 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2516 2015-02-27 Michael Saboff <msaboff@apple.com>
2518 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2519 https://bugs.webkit.org/show_bug.cgi?id=142112
2521 Reviewed by Filip Pizlo.
2523 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2524 <someDir> as the library path.
2526 * Scripts/run-jsc-benchmarks:
2528 2015-02-27 Alex Christensen <achristensen@webkit.org>
2530 [WinCairo] Unreviewed build fix.
2532 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2533 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2535 2015-02-27 Anders Carlsson <andersca@apple.com>
2537 Add infrastructure for handling website data in the network process
2538 https://bugs.webkit.org/show_bug.cgi?id=142092
2540 Reviewed by Andreas Kling.
2542 Add a menu item that will fetch all website data, delete the returned data records, and
2543 fetch all website data again so we can confirm that it's all empty.
2545 * MiniBrowser/mac/WK2BrowserWindowController.m:
2546 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2548 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2550 [Win] Remove remaining SafariTheme cruft
2551 https://bugs.webkit.org/show_bug.cgi?id=142075
2553 Reviewed by Anders Carlsson.
2555 Remove reference to SafariTheme-switching preference.
2557 * DumpRenderTree/win/DumpRenderTree.cpp:
2558 (resetWebPreferencesToConsistentValues):
2559 (prepareConsistentTestingEnvironment):
2561 2015-02-26 Doug Russell <d_russell@apple.com>
2563 AX: Expose caret browsing preference to accessibility API
2564 https://bugs.webkit.org/show_bug.cgi?id=141862
2566 Reviewed by Chris Fleizach.
2568 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2569 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2571 * DumpRenderTree/AccessibilityUIElement.cpp:
2572 (setBoolAttributeValueCallback):
2573 (selectedTextMarkerRangeCallback):
2574 (resetSelectedTextMarkerRangeCallback):
2575 (AccessibilityUIElement::setBoolAttributeValue):
2576 (AccessibilityUIElement::selectedTextMarkerRange):
2577 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2578 (AccessibilityUIElement::getJSClass):
2579 * DumpRenderTree/AccessibilityUIElement.h:
2580 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2581 (AccessibilityUIElement::setBoolAttributeValue):
2582 (AccessibilityUIElement::selectedTextMarkerRange):
2583 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2584 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2585 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2586 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2587 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2588 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2589 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2590 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2591 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2592 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2593 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2595 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2597 [Win] Remove WebKitExportGenerator project (and related)
2598 https://bugs.webkit.org/show_bug.cgi?id=142035
2600 Reviewed by Dean Jackson.
2602 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2603 build log from WebKitExportGenerator.
2605 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2607 [EFL] Bump EFL version to 1.13.0
2608 https://bugs.webkit.org/show_bug.cgi?id=141708
2610 Reviewed by Gyuyoung Kim.
2612 * efl/jhbuild.modules:
2614 2015-02-26 Sam Weinig <sam@webkit.org>
2616 Check in missing WebEditingTester.xcconfig file.
2618 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2620 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2622 [webkitpy] Remove skipped file related crufts
2623 https://bugs.webkit.org/show_bug.cgi?id=142046
2625 Reviewed by Ryosuke Niwa.
2627 * Scripts/webkitpy/port/base.py:
2628 (Port.skipped_layout_tests):
2629 (Port._tests_from_skipped_file_contents): Deleted.
2631 (Port._expectations_from_skipped_files): Deleted.
2632 * Scripts/webkitpy/port/mac_unittest.py:
2633 (MacTest.test_default_timeout_ms):
2635 (test_tests_from_skipped_file_contents): Deleted.
2637 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2639 [Win] Unreviewed WinCairo build fix after r180653.
2641 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2643 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2644 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2645 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2646 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2647 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2649 2015-02-25 Brent Fulgham <bfulgham@apple.com>
2651 [Win] Use WEBCORE_EXPORT instead of Definition file
2652 https://bugs.webkit.org/show_bug.cgi?id=141734
2654 Reviewed by Alex Christensen.
2656 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2657 Use a precompiled header so we can define our export macros properly.
2658 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2659 Visual studio automatic update stuff.
2660 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2661 Set up Precompiled Header use for project..
2662 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2663 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2664 declarations for building DumpRenderTree as a client of
2667 2015-02-25 Mark Lam <mark.lam@apple.com>
2669 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2670 <https://webkit.org/b/141672>
2672 Reviewed by Alexey Proskuryakov.
2674 ASan does not like the fact that we memcpy the stack for GC scans. So,
2675 we're working around this by using our own memcpy (asanUnsafeMemcpy)
2676 implementation that we can tell ASan to ignore.
2678 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2679 which isn't effective for working around this issue.
2681 * asan/webkit-asan-ignore.txt:
2683 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
2685 CodeBlock crashes when dumping op_push_name_scope
2686 https://bugs.webkit.org/show_bug.cgi?id=141953
2688 Reviewed by Filip Pizlo.
2690 * Scripts/run-jsc-stress-tests:
2692 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
2694 W3C test importer should use argparse instead of optparse
2695 https://bugs.webkit.org/show_bug.cgi?id=142013
2697 Reviewed by Bem Jones-Bey.
2699 * Scripts/webkitpy/w3c/test_importer.py:
2700 (main): Updating according argparse.
2701 (parse_args): Moving from optparse to argparse.
2703 2015-02-25 Brady Eidson <beidson@apple.com>
2705 Get rid of TestInvocation::pathOrURL
2706 https://bugs.webkit.org/show_bug.cgi?id=142021
2708 Reviewed by Tim Horton.
2710 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2711 but most code that uses it expected an absolute path.
2713 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2715 * WebKitTestRunner/TestController.cpp:
2716 (WTR::TestController::updateWebViewSizeForTest):
2717 (WTR::TestController::updateWindowScaleForTest):
2718 (WTR::shouldUseFixedLayout):
2719 (WTR::TestController::updateLayoutTypeForTest):
2721 * WebKitTestRunner/TestInvocation.cpp:
2722 (WTR::TestInvocation::TestInvocation):
2723 (WTR::TestInvocation::urlContains):
2724 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2725 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2726 (WTR::TestInvocation::invoke):
2727 (WTR::shouldLogFrameLoadDelegates): Deleted.
2728 (WTR::shouldLogHistoryClientCallbacks): Deleted.
2729 * WebKitTestRunner/TestInvocation.h:
2730 (WTR::TestInvocation::pathOrURL): Deleted.
2732 * WebKitTestRunner/ios/TestControllerIOS.mm:
2733 (WTR::shouldMakeViewportFlexible):
2734 (WTR::TestController::platformConfigureViewForTest):
2736 * WebKitTestRunner/mac/TestControllerMac.mm:
2737 (WTR::shouldUseThreadedScrolling):
2738 (WTR::TestController::platformConfigureViewForTest):
2740 2015-02-25 Brady Eidson <beidson@apple.com>
2742 Layout test support for user content filters
2743 https://bugs.webkit.org/show_bug.cgi?id=142018
2745 Reviewed by Tim Horton.
2747 * WebKitTestRunner/TestController.cpp:
2748 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2750 * WebKitTestRunner/mac/TestControllerMac.mm:
2751 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2752 file before loading the test itself.
2754 2015-02-24 Sam Weinig <sam@webkit.org>
2756 Convert WebEditingTester to use xcconfig files
2757 https://bugs.webkit.org/show_bug.cgi?id=141879
2759 Reviewed by Darin Adler.
2761 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2763 * WebEditingTester/Configurations: Added.
2764 * WebEditingTester/Configurations/Base.xcconfig: Added.
2765 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2766 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2768 2015-02-24 Andy Estes <aestes@apple.com>
2770 Teach MiniBrowser how to disable per-window web processes
2771 https://bugs.webkit.org/show_bug.cgi?id=141988
2773 Reviewed by Darin Adler.
2775 * MiniBrowser/mac/AppDelegate.m:
2776 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2777 * MiniBrowser/mac/SettingsController.h:
2778 * MiniBrowser/mac/SettingsController.m:
2779 (-[SettingsController _populateMenu]): Added a new Settings menu item.
2780 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2781 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2782 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2784 2015-02-24 Alexey Proskuryakov <ap@apple.com>
2786 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2787 https://bugs.webkit.org/show_bug.cgi?id=141889
2789 Reviewed by Darin Adler.
2791 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2793 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
2795 REGRESSION(r179429): Can't type comments in Facebook
2796 https://bugs.webkit.org/show_bug.cgi?id=141859
2798 Reviewed by Brent Fulgham.
2800 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2802 * DumpRenderTree/mac/DumpRenderTree.mm:
2803 (resetWebPreferencesToConsistentValues):
2804 * DumpRenderTree/win/DumpRenderTree.cpp:
2805 (resetWebPreferencesToConsistentValues):
2806 * WebKitTestRunner/TestController.cpp:
2807 (WTR::TestController::resetPreferencesToConsistentValues):
2809 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
2811 Crash loading local file with WebPageProxy::loadAlternateHTMLString
2812 https://bugs.webkit.org/show_bug.cgi?id=141867
2814 Reviewed by Anders Carlsson.
2816 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2817 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2818 be shared with the new test.
2819 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2820 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2821 (testLoadAlternateHTMLForLocalPage):
2824 2015-02-24 David Kilzer <ddkilzer@apple.com>
2826 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2827 <http://webkit.org/b/141900>
2829 Reviewed by Myles C. Maxfield.
2831 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2832 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2833 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2834 - Rename to share code with iOS.
2835 - Add USE(APPKIT) around AppKit-specific headers and code.
2836 - Fix a check-webkit-style warning.
2837 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2838 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2839 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2840 - Remove ios/ActivateFontsIOS.mm.
2841 - Fix InjectedBundle/cocoa group to represent the directory on
2842 disk. Includes a change to InjectedBundlePageCocoa.mm.
2844 2015-02-23 Commit Queue <commit-queue@webkit.org>
2846 Unreviewed, rolling out r180547 and r180550.
2847 https://bugs.webkit.org/show_bug.cgi?id=141957
2849 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2851 Reverted changesets:
2853 "REGRESSION(r179429): Can't type comments in Facebook"
2854 https://bugs.webkit.org/show_bug.cgi?id=141859
2855 http://trac.webkit.org/changeset/180547
2857 "Constructor returning null should construct an object instead
2859 https://bugs.webkit.org/show_bug.cgi?id=141640
2860 http://trac.webkit.org/changeset/180550
2862 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
2864 REGRESSION(r179429): Can't type comments in Facebook
2865 https://bugs.webkit.org/show_bug.cgi?id=141859
2867 Reviewed by Geoffrey Garen.
2869 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2871 * DumpRenderTree/mac/DumpRenderTree.mm:
2872 (resetWebPreferencesToConsistentValues):
2873 * WebKitTestRunner/TestController.cpp:
2874 (WTR::TestController::resetPreferencesToConsistentValues):
2876 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
2879 https://bugs.webkit.org/show_bug.cgi?id=141909
2881 Reviewed by Gyuyoung Kim.
2883 Fix eo errors that occur whenever minibrowser is launched.
2884 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2885 - elm_obj_win_resize_object_add's first parameter should be elm_win
2887 * MiniBrowser/efl/main.c:
2890 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
2892 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2894 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2895 (TestWebKitAPI::TEST):
2897 2015-02-23 Brent Fulgham <bfulgham@apple.com>
2899 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2900 https://bugs.webkit.org/show_bug.cgi?id=141935
2902 Reviewed by Myles C. Maxfield.
2904 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2905 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2906 tests for assigning from nullptr.
2908 2015-02-23 Brent Fulgham <bfulgham@apple.com>
2910 WTF::WeakPtr should have a 'forget' method.
2911 https://bugs.webkit.org/show_bug.cgi?id=141923
2913 Reviewed by Myles C. Maxfield.
2915 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2916 (TestWebKitAPI::TEST): Added 'Forget' tests case.
2918 2015-02-23 Alexey Proskuryakov <ap@apple.com>
2920 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2921 https://bugs.webkit.org/show_bug.cgi?id=141920
2923 Reviewed by Tim Horton.
2925 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2926 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2927 Do the same thing as we do for regular green bubbles.
2929 2015-02-23 Alexey Proskuryakov <ap@apple.com>
2931 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2932 https://bugs.webkit.org/show_bug.cgi?id=141925
2934 Reviewed by Tim Horton.
2936 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2937 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2939 2015-02-23 Anders Carlsson <andersca@apple.com>
2941 Add API for fetching website data records to _WKWebsiteDataStore
2942 https://bugs.webkit.org/show_bug.cgi?id=141926
2944 Reviewed by Beth Dakin.
2946 * MiniBrowser/mac/MainMenu.xib:
2947 * MiniBrowser/mac/WK2BrowserWindowController.m:
2948 (-[WK2BrowserWindowController fetchWebsiteData:]):
2949 Add menu item to fetch and dump website data.
2951 2015-02-23 David Kilzer <ddkilzer@apple.com>
2953 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2954 <http://webkit.org/b/141884>
2956 Reviewed by Alexey Proskuryakov.
2958 * Scripts/webkitpy/port/leakdetector.py:
2959 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2960 snowleopard, lion and older leaks. Add known leak for
2961 mavericks, but check Port.operating_system before calling
2963 * Scripts/webkitpy/port/mac.py:
2964 (MacPort.is_snowleopard): Delete.
2965 (MacPort.is_lion): Delete.
2966 (MacPort.is_mavericks): Add.
2968 2015-02-23 Alexey Proskuryakov <ap@apple.com>
2970 build.webkit.org/dashboard should filter out commits to other branches
2971 https://bugs.webkit.org/show_bug.cgi?id=140362
2973 Reviewed by Tim Horton.
2975 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2977 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2978 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2979 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2980 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2981 (BuildbotQueueView.prototype.revisionContentForIteration):
2982 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2983 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2984 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2985 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2986 (Trac.prototype.get oldestRecordedRevisionNumber):
2987 (Trac.prototype.commitsOnBranch):
2988 (Trac.prototype._xmlTimelineURL):
2989 (Trac.prototype._convertCommitInfoElementToObject):
2990 (Trac.prototype._update):
2991 (Trac.prototype.startPeriodicUpdates):
2992 (Trac.prototype.loadMoreHistoricalData):
2993 (Trac.prototype.update): Deleted.
2995 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
2997 Tests don't work on some bots: Failed to stop wptwk
2998 https://bugs.webkit.org/show_bug.cgi?id=141235
3000 Reviewed by Ryosuke Niwa.
3002 Logging of server subprocesses in launcher script.
3003 Killing of server subprocesses when stopping/before starting.
3004 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3006 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3007 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3008 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3009 (WebPlatformTestServer.__init__):
3010 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3011 (WebPlatformTestServer):
3012 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3013 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3014 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3015 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3016 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3017 (TestWebPlatformTestServer):
3018 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3020 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3022 [WebEditingTester] Allow dropping HTML files on the app
3023 https://bugs.webkit.org/show_bug.cgi?id=141834
3025 Reviewed by Simon Fraser.
3027 * WebEditingTester/AppDelegate.m:
3028 (-[WebEditingAppDelegate openDocument:]):
3029 (-[WebEditingAppDelegate application:openFile:]):
3030 Implement application:openFile:, factoring file loading code out of openDocument.
3032 * WebEditingTester/Info.plist:
3033 Register as an editor for HTML files.
3035 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3036 Enrica is not an organization.
3038 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3040 [WebEditingTester] Expand "WK" to "WebKit" in a few places
3041 https://bugs.webkit.org/show_bug.cgi?id=141833
3043 Reviewed by Anders Carlsson.
3045 * WebEditingTester/AppDelegate.h:
3046 * WebEditingTester/AppDelegate.m:
3047 (-[WebEditingAppDelegate newEditor:]):
3048 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3049 (-[WebEditingAppDelegate validateMenuItem:]):
3050 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3051 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3052 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3053 (-[WebEditingAppDelegate showOperations:]): Deleted.
3054 * WebEditingTester/MainMenu.xib:
3055 The WK abbreviation is unnaturally grating in menu items for some reason.
3057 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3059 [WebEditingTester] Add a custom protocol for loading canned content
3060 https://bugs.webkit.org/show_bug.cgi?id=141830
3062 Reviewed by Enrica Casucci.
3064 Add a canned:// protocol handler, which can be used to emulate behaviors
3065 in WebKit client apps (like Mail) that use custom protocol handlers,
3066 which can have important effects on editing (mostly, the URLs are only
3067 valid inside of the client application, but not when copied/dragged out).
3069 For now, we only support two canned files:
3071 canned://dice is a PNG of dice (stolen from LayoutTests/)
3072 canned://text is the string "canned text" served as text/html
3074 In the future we could support things like very large (generated) files,
3075 progressive loading, etc. to further simulate conditions in other apps.
3077 * WebEditingTester/AppDelegate.m:
3078 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3079 Register the protocol with CFNetwork, and the scheme with WebKit2.
3081 * WebEditingTester/Canned Content/dice.png: Added.
3082 * WebEditingTester/CannedContent.h: Added.
3083 * WebEditingTester/CannedContent.m: Added.
3084 (-[CannedContent initWithRequest:cachedResponse:client:]):
3085 (+[CannedContent canonicalRequestForRequest:]):
3086 (+[CannedContent canInitWithRequest:]):
3087 We only want to handle canned:// URLs.
3089 (-[CannedContent startLoading]):
3090 For now, immediately load the two files we know about.
3091 Otherwise, immediately fail the load.
3093 (-[CannedContent stopLoading]):
3094 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3096 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3098 [WebEditingTester] Implement an open panel
3099 https://bugs.webkit.org/show_bug.cgi?id=141829
3101 Reviewed by Simon Fraser.
3103 * WebEditingTester/AppDelegate.m:
3104 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3105 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3106 (-[WebEditingAppDelegate openDocument:]):
3107 Add an open panel (with radio buttons to pick which WebKit to open with).
3108 Loads the file as an HTML string.
3110 2015-02-20 Simon Fraser <simon.fraser@apple.com>
3112 [WebEditingTester] @properties, dot syntax, and remember the window position
3113 https://bugs.webkit.org/show_bug.cgi?id=141843
3115 Reviewed by Tim Horton.
3117 Modernize a bit with more dot syntax, use @property for the web views,
3118 and give the main window an Autosave name so it remembers the widow position.
3120 * WebEditingTester/WK1WebDocumentController.m:
3121 (-[WK1WebDocumentController awakeFromNib]):
3122 (-[WK1WebDocumentController loadHTMLString:]):
3123 * WebEditingTester/WK2WebDocumentController.m:
3124 (-[WK2WebDocumentController awakeFromNib]):
3125 * WebEditingTester/WebDocument.xib:
3127 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3129 [WebEditingTester] Hook up key equivalents for new window action
3130 https://bugs.webkit.org/show_bug.cgi?id=141828
3132 Reviewed by Enrica Casucci.
3134 * WebEditingTester/AppDelegate.h:
3135 * WebEditingTester/AppDelegate.m:
3136 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3137 (-[WebEditingAppDelegate newEditor:]):
3138 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3139 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3140 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3141 (defaultConfiguration): Deleted.
3142 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3143 Move WKWebViewConfiguration setup into WK2WebDocumentController.
3144 Remove unused application termination code.
3145 Update new-window menu item key equivalents when launching and when
3146 changing the use-WebKit2-by-default setting.
3147 Make WebDocumentController subclasses all initialized the same way,
3148 and use that to factor out alloc/init.
3149 Rename loadContent to loadHTMLString for future use.
3151 * WebEditingTester/MainMenu.xib:
3152 Add default key equivalents.
3153 Cmd-N will always make the default kind of window (controlled by the pref).
3154 Cmd-Opt-N will always make the other kind.
3155 The menu items are configured as alternates so they only show up if you
3156 press alt (just like in MiniBrowser).
3158 * WebEditingTester/WK1WebDocumentController.m:
3159 (-[WK1WebDocumentController loadHTMLString:]):
3160 (-[WK1WebDocumentController loadContent]): Deleted.
3161 * WebEditingTester/WK2WebDocumentController.h:
3162 * WebEditingTester/WK2WebDocumentController.m:
3163 (defaultConfiguration):
3164 (-[WK2WebDocumentController awakeFromNib]):
3165 (-[WK2WebDocumentController loadHTMLString:]):
3166 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3167 (-[WK2WebDocumentController dealloc]): Deleted.
3168 * WebEditingTester/WebDocumentController.h:
3169 * WebEditingTester/WebDocumentController.m:
3170 (-[WebDocumentController init]):
3171 (-[WebDocumentController initWithWindow:]):
3172 (+[WebDocumentController defaultEditingSource]):
3173 (-[WebDocumentController loadHTMLString:]):
3174 (-[WebDocumentController windowDidLoad]): Deleted.
3175 (-[WebDocumentController defaultEditingSource]): Deleted.
3176 (-[WebDocumentController applicationTerminating]): Deleted.
3177 (-[WebDocumentController loadContent]): Deleted.
3179 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3181 [WebEditingTester] ARC-ify WebEditingTester
3182 https://bugs.webkit.org/show_bug.cgi?id=141827
3184 Reviewed by Sam Weinig.
3186 * WebEditingTester/AppDelegate.m:
3187 (-[WebEditingAppDelegate showOperations:]):
3188 * WebEditingTester/EditingOperations.m:
3189 (editingOperations):
3190 * WebEditingTester/WK1WebDocumentController.m:
3191 (-[WK1WebDocumentController dealloc]): Deleted.
3192 * WebEditingTester/WK2WebDocumentController.m:
3193 (-[WK2WebDocumentController dealloc]): Deleted.
3194 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3195 Turn on ARC and remove a few retain/release/autorelease calls.
3196 We don't need to implement dealloc in either document controller
3197 because WebView and WKWebView's UIDelegate property does not hold a
3200 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3202 [WebEditingTester] Factor out list of editing operations
3203 https://bugs.webkit.org/show_bug.cgi?id=141826
3205 Reviewed by Sam Weinig.
3207 * WebEditingTester/AppDelegate.m:
3208 (-[WebEditingAppDelegate showOperations:]):
3209 * WebEditingTester/EditingOperations.h: Added.
3210 * WebEditingTester/EditingOperations.m: Added.
3211 (editingOperations):
3212 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3213 Move EditingOperations array to its own file, and make it an NSArray
3214 instead of a C array. Adjust accordingly in showOperations:.
3216 2015-02-20 Michael Saboff <msaboff@apple.com>
3218 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3219 https://bugs.webkit.org/show_bug.cgi?id=141676
3221 Reviewed by Filip Pizlo.
3223 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
3224 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
3225 large string expression that we want to eval.
3227 * Scripts/run-jsc-stress-tests:
3229 2015-02-19 Daniel Bates <dabates@apple.com>
3231 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3232 https://bugs.webkit.org/show_bug.cgi?id=141815
3233 <rdar://problem/19893933>
3235 Reviewed by Simon Fraser.
3237 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3238 was booted by iOS Simulator in a previous run of run-webkit-test.
3240 * Scripts/webkitpy/port/ios.py:
3241 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3242 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3243 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3245 2015-02-19 David Kilzer <ddkilzer@apple.com>
3247 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3248 <http://webkit.org/b/141799>
3250 Reviewed by Alex Christensen.
3252 * Scripts/webkitpy/style/checkers/cpp.py:
3253 (_IncludeState.check_next_include_order): Don't emit a warning
3254 if the primary header exists and the source file name ends with
3255 "SoftLink.cpp". Add 'filename' argument to method.
3256 (check_include_line): Pass in 'filename'.
3258 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3259 (OrderOfIncludesTest.test_check_next_include_order__no_config):
3260 (OrderOfIncludesTest.test_check_next_include_order__no_self):
3261 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3262 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3263 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3264 - Add test filename arguments for calls to
3265 check_next_include_order().
3266 (OrderOfIncludesTest.test_primary_header): Add test for a file
3267 name ending in "SoftLink.cpp".
3269 2015-02-18 Enrica Casucci <enrica@apple.com>
3271 Add new tool to test editable Webviews.
3272 https://bugs.webkit.org/show_bug.cgi?id=141772
3274 Reviewed by Tim Horton.
3276 Adding WebEditingTester, a Cocoa application to
3277 test WK1 and Wk2 views in editable mode.
3279 * WebEditingTester: Added.
3280 * WebEditingTester/AppDelegate.h: Added.
3281 * WebEditingTester/AppDelegate.m: Added.
3282 (-[WebEditingAppDelegate init]):
3283 (defaultConfiguration):
3284 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3285 (-[WebEditingAppDelegate applicationWillTerminate:]):
3286 (-[WebEditingAppDelegate newEditor:]):
3287 (-[WebEditingAppDelegate showOperations:]):
3288 (-[WebEditingAppDelegate useWebKit2ByDefault]):
3289 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3290 (-[WebEditingAppDelegate validateMenuItem:]):
3291 * WebEditingTester/Info.plist: Added.
3292 * WebEditingTester/MainMenu.xib: Added.
3293 * WebEditingTester/WK1WebDocumentController.h: Added.
3294 * WebEditingTester/WK1WebDocumentController.m: Added.
3295 (-[WK1WebDocumentController awakeFromNib]):
3296 (-[WK1WebDocumentController loadContent]):
3297 (-[WK1WebDocumentController dealloc]):
3298 (-[WK1WebDocumentController pasteAsMarkup:]):
3299 * WebEditingTester/WK2WebDocumentController.h: Added.
3300 * WebEditingTester/WK2WebDocumentController.m: Added.
3301 (-[WK2WebDocumentController initWithConfiguration:]):
3302 (-[WK2WebDocumentController pasteAsMarkup:]):
3303 (-[WK2WebDocumentController awakeFromNib]):
3304 (-[WK2WebDocumentController dealloc]):
3305 (-[WK2WebDocumentController loadContent]):
3306 * WebEditingTester/WebDocument.xib: Added.
3307 * WebEditingTester/WebDocumentController.h: Added.
3308 * WebEditingTester/WebDocumentController.m: Added.
3309 (-[WebDocumentController initWithWindow:]):
3310 (-[WebDocumentController windowDidLoad]):
3311 (-[WebDocumentController defaultEditingSource]):
3312 (-[WebDocumentController applicationTerminating]):
3313 (-[WebDocumentController loadContent]):
3314 * WebEditingTester/WebEditingTester.xcodeproj: Added.
3315 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3316 * WebEditingTester/main.m: Added.
3319 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
3321 Run JSC tests on ARM EFL bots
3322 https://bugs.webkit.org/show_bug.cgi?id=141165
3324 Reviewed by Alexey Proskuryakov.
3326 * BuildSlaveSupport/build.webkit.org-config/config.json:
3327 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3328 (RunJavaScriptCoreTests.countFailures):
3329 (RunRemoteJavaScriptCoreTests):
3330 (RunRemoteJavaScriptCoreTests.start):
3331 (BuildAndRemoteJSCTestsFactory):
3332 (BuildAndRemoteJSCTestsFactory.__init__):
3334 2015-02-18 Alexey Proskuryakov <ap@apple.com>
3336 Streamline unexported function build fixes
3337 https://bugs.webkit.org/show_bug.cgi?id=141761
3339 Reviewed by Alex Christensen.
3341 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3342 We don't need to ignore symbols that are not exported due to the .unexp file.
3344 2015-02-18 Timothy Horton <timothy_horton@apple.com>
3346 Remove more references to WebCore.exp.in
3347 https://bugs.webkit.org/show_bug.cgi?id=141747
3349 Reviewed by Alexey Proskuryakov.
3351 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3354 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
3356 Windows test results should not fall back to mac-mountainlion after r180176
3357 https://bugs.webkit.org/show_bug.cgi?id=141719
3359 Reviewed by Brent Fulgham.
3361 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3362 (_should_file_trigger_build):
3363 * Scripts/webkitpy/port/win.py:
3364 (WinPort.default_baseline_search_path):
3365 * Scripts/webkitpy/port/win_unittest.py:
3366 (WinPortTest.test_baseline_search_path):
3368 2015-02-17 Daniel Bates <dabates@apple.com>
3370 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3371 https://bugs.webkit.org/show_bug.cgi?id=141718
3373 Reviewed by Alex Christensen.
3375 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3377 * Scripts/webkitpy/port/ios.py:
3378 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3379 Log a error and return False if we are unable to boot the simulator device so that the caller can take
3380 appropriate action, say exit(3) before running any layout tests.
3381 * Scripts/webkitpy/xcode/simulator.py:
3382 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3383 with the specified UDID.
3384 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3385 with the specified UDID can successfully boot and shut down. We make at most two attempts to
3386 boot and shut down the device, erasing the device between tries so as to restore the device
3387 to a known good state.
3389 2015-02-17 Daniel Bates <dabates@apple.com>
3391 run_webkit_tests.py should not know about iOS Simulator details
3392 https://bugs.webkit.org/show_bug.cgi?id=141711
3394 Reviewed by Alex Christensen.
3396 Run_webkit_tests.py should only parse the iOS-specific command
3397 line options --runtime and --device-type. Let the port-specific
3398 logic in ios.py validate the parsed options and instantiate
3399 internal data structures.
3401 Currently run_webkit_tests.py parses the iOS-specific command
3402 line options --runtime and --device-type, validates them, and
3403 instantiates internal data structures from the parsed strings.
3404 Instead the validation logic and instantiation of internal
3405 data structures should be handled by the iOS port object.
3407 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3408 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3409 and instantiate internal data structures for them.
3410 * Scripts/webkitpy/port/driver.py:
3411 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3412 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3414 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3415 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3416 object from --runtime, if specified. Otherwise, instantiates a Runtime
3417 object for the latest installed iphonesimulator SDK version.
3418 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3419 object from --device-type, if specified. Otherwise, instantiates
3420 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3421 machine, respectively.
3422 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3423 runtime is available to use.
3424 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3425 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3426 * Scripts/webkitpy/xcode/simulator.py:
3427 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3428 with a runtime identifier for the specified iOS version.
3430 2015-02-17 Dana Burkart <dburkart@apple.com>
3432 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3433 https://bugs.webkit.org/show_bug.cgi?id=141672
3435 Reviewed by David Kilzer.
3437 * asan/webkit-asan-ignore.txt:
3439 2015-02-17 Alex Christensen <achristensen@webkit.org>
3441 Remove WebCore.exp.in and clean up.
3442 https://bugs.webkit.org/show_bug.cgi?id=141491
3444 Reviewed by Andreas Kling.
3446 * Scripts/sort-export-file: Removed.
3447 * Scripts/webkitpy/style/checker.py:
3450 (CheckerDispatcher._file_type):
3451 (CheckerDispatcher._create_checker):
3452 Don't check if the export files are sorted.
3453 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3454 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3456 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3458 Unreviewed. Fix GTK+ make distcheck.
3460 Do not exclude bmalloc directory from the tarball.
3462 * gtk/manifest.txt.in:
3464 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3466 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3468 I forgot to add the return of a bool function.
3470 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3471 (WebKitDOMNodeTest::testDOMCache):
3473 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3475 [GTK] GObject DOM bindings object are cached forever
3476 https://bugs.webkit.org/show_bug.cgi?id=141558
3478 Reviewed by Sergio Villar Senin.
3480 Add checks for all DOM objects to ensure they are not leaked. Also
3481 add a dedicated test for the DOM Object Cache.
3483 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3484 (WebKitDOMNodeFilterTest::testTreeWalker):
3485 (WebKitDOMNodeFilterTest::testNodeIterator):
3486 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3487 (WebKitDOMNodeTest::testHierarchyNavigation):
3488 (WebKitDOMNodeTest::testInsertion):
3489 (WebKitDOMNodeTest::testTagNames):
3490 (WebKitDOMNodeTest::testDOMCache):
3492 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3493 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3494 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3495 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3496 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3497 (testWebKitDOMObjectCache):
3499 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3500 (documentLoadedCallback):
3502 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
3504 [GTK] WebKitFrame objects are never released
3505 https://bugs.webkit.org/show_bug.cgi?id=141641
3507 Reviewed by Martin Robinson.
3509 Add a way to check GObjects leaks for WebProcess tests and check
3510 WebKitFrame objects are not leaked.
3512 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3513 (WebKitFrameTest::testMainFrame):
3514 (WebKitFrameTest::testURI):
3515 (WebKitFrameTest::testJavaScriptContext):
3516 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3517 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3519 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3521 2015-02-16 Tim Horton <timothy_horton@apple.com>
3523 Fix the MiniBrowser build with newer clang
3525 * MiniBrowser/mac/SettingsController.m:
3526 (-[SettingsController _toggleBooleanDefault:]):
3527 * MiniBrowser/mac/WK1BrowserWindowController.m:
3528 (-[WK1BrowserWindowController windowWillClose:]):
3529 * MiniBrowser/mac/WK2BrowserWindowController.m:
3530 (-[WK2BrowserWindowController windowWillClose:]):
3531 NSApp is id and clang gets confused about which -delegate we're talking about.
3533 2015-02-16 Antti Koivisto <antti@apple.com>
3535 Develop/Disable Caches does not properly disable disk cache
3536 https://bugs.webkit.org/show_bug.cgi?id=141636
3538 Reviewed by Anders Carlsson.
3540 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3541 the network process too.
3543 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3545 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3546 (WTR::InjectedBundle::beginTesting):
3547 (WTR::InjectedBundle::setCacheModel):
3548 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3549 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3551 Forward to TestController.
3553 (WTR::TestRunner::setCacheModel):
3554 * WebKitTestRunner/TestInvocation.cpp:
3555 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3557 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
3559 Unreviewed. Add myself as a committer.
3561 * Scripts/webkitpy/common/config/contributors.json:
3563 2015-02-15 David Kilzer <ddkilzer@apple.com>
3565 REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3566 <http://webkit.org/b/141607>
3568 * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3569 externals in Source/WebCore/Configurations/WebCore.unexp when
3570 building with Xcode 5.x.
3571 (readXcode5SymbolsToIgnore): Add.
3573 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com>
3575 [EFL] fix Evas GL engine error.
3576 https://bugs.webkit.org/show_bug.cgi?id=141621
3578 Reviewed by Gyuyoung Kim.
3580 As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3582 * MiniBrowser/efl/main.c:
3585 2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
3587 [buildbot] Enable run-api-tests on release Mac bots
3588 https://bugs.webkit.org/show_bug.cgi?id=141518
3590 Reviewed by Darin Adler.
3592 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3594 (BuildFactory.__init__):
3595 (TestFactory.__init__):
3596 (BuildAndTestFactory.__init__):
3597 (RunUnitTests.start): Deleted.
3598 (unitTestsSupported): Deleted.
3600 2015-02-13 Anders Carlsson <andersca@apple.com>
3602 Add a move constructor and move assignment operator to Deque
3603 https://bugs.webkit.org/show_bug.cgi?id=141571
3605 Reviewed by Andreas Kling.
3607 * TestWebKitAPI/Tests/WTF/Deque.cpp:
3608 (TestWebKitAPI::TEST):
3610 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
3612 run-jsc-stress-tests --remote should skip profiler tests
3613 https://bugs.webkit.org/show_bug.cgi?id=141470
3615 Reviewed by Filip Pizlo.
3617 * Scripts/run-jsc-stress-tests:
3619 2015-02-13 Anders Carlsson <andersca@apple.com>
3621 Add an initializer list constructor to Deque
3622 https://bugs.webkit.org/show_bug.cgi?id=141565
3624 Reviewed by Andreas Kling.
3626 * TestWebKitAPI/Tests/WTF/Deque.cpp:
3627 (TestWebKitAPI::TEST):
3629 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
3631 [buildbot] Remove buildJSCTool cruft from master.cfg
3632 https://bugs.webkit.org/show_bug.cgi?id=141513
3634 Reviewed by Alexey Proskuryakov.
3636 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3637 (RunJavaScriptCoreTests):
3638 (RunJavaScriptCoreTests.start):
3640 (RunWebKitTests.start):
3641 (TestFactory.__init__):
3642 (TestLeaksFactory.__init__):
3643 (RunJavaScriptCoreTests.__init__): Deleted.
3644 (RunWebKitTests.__init__): Deleted.
3646 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
3648 Unreviewed, remove empty directories.
3650 * DumpRenderTree/gtk: Removed.
3651 * DumpRenderTree/gtk/fonts: Removed.
3652 * DumpRenderTree/unix: Removed.
3653 * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3654 * GtkLauncher: Removed.
3655 * TestWebKitAPI/Tests/WebKitGtk: Removed.
3656 * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3657 * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3658 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3660 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
3662 Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3663 https://bugs.webkit.org/show_bug.cgi?id=141519
3665 Reviewed by Alexey Proskuryakov.
3667 * Scripts/build-webkittestrunner:
3669 2015-02-12 Alex Christensen <achristensen@webkit.org>
3671 Removed empty directory.