Update AppEngine app version numbers to the latest commit.
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2
3         Update AppEngine app version numbers to the latest commit.
4
5         * QueueStatusServer/app.yaml:
6         * TestResultServer/app.yaml:
7
8 2015-08-07  Anders Carlsson  <andersca@apple.com>
9
10         Simplify WKTR's view options
11         https://bugs.webkit.org/show_bug.cgi?id=147791
12
13         Reviewed by Sam Weinig.
14
15         Instead of using a WKDictionaryRef, just use a struct for the options.
16
17         * WebKitTestRunner/PlatformWebView.h:
18         (WTR::PlatformWebView::options):
19         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
20         * WebKitTestRunner/TestController.cpp:
21         (WTR::TestController::initialize):
22         (WTR::TestController::createWebViewWithOptions):
23         (WTR::TestController::ensureViewSupportsOptions):
24         (WTR::TestController::updateLayoutTypeForTest):
25         * WebKitTestRunner/TestController.h:
26         * WebKitTestRunner/ViewOptions.h: Added.
27         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
28         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
29         (WTR::PlatformWebView::PlatformWebView):
30         (WTR::PlatformWebView::viewSupportsOptions):
31         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
32         (WTR::PlatformWebView::viewSupportsOptions):
33         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
34         (WTR::PlatformWebView::viewSupportsOptions):
35         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
36         (WTR::PlatformWebView::PlatformWebView):
37         (WTR::PlatformWebView::viewSupportsOptions):
38         * WebKitTestRunner/mac/TestControllerMac.mm:
39         (WTR::TestController::platformConfigureViewForTest):
40
41 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
42
43         Running tests for a long time results in some tests running very slowly (throttling)
44         https://bugs.webkit.org/show_bug.cgi?id=147718
45
46         Reviewed by Chris Dumez.
47
48         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
49         Although COCOA ports default this setting to be disabled in WebKit1,
50         we should make both test harnesses disable the setting for consistency.
51
52         * DumpRenderTree/mac/DumpRenderTree.mm:
53         (resetWebPreferencesToConsistentValues):
54
55 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
56
57         Use a specific version of Speedometer in run-benchmark
58         https://bugs.webkit.org/show_bug.cgi?id=147769
59
60         Reviewed by Chris Dumez.
61
62         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
63
64         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
65
66 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
67
68         twisted_http_server.py should support --port
69         https://bugs.webkit.org/show_bug.cgi?id=147771
70
71         Reviewed by Chris Dumez.
72
73         Added the option. This makes the script more useful on its own.
74
75         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
76
77 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
78
79         [GTK] WTF unit tests are timing out in the bots
80         https://bugs.webkit.org/show_bug.cgi?id=147777
81
82         Reviewed by Filip Pizlo.
83
84         Add a way to mark google unit tests as slow and add
85         WTF_Lock.ContentedShortSection to the list. In case of slow test
86         we use the double of the given timeout for that particular test.
87
88         * Scripts/run-gtk-tests:
89         (TestRunner):
90         (TestRunner._run_google_test):
91
92 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
93
94         [GTK] run-gtk-tests should not stop when a google test case fails
95         https://bugs.webkit.org/show_bug.cgi?id=147778
96
97         Reviewed by Philippe Normand.
98
99         For glib based tests we run the test runner with the -k option,
100         but for google tests we are aborting as soon as we find a failure.
101
102         * Scripts/run-gtk-tests:
103         (TestRunner._run_google_test_suite): Use a global return code that
104         is set to 1 when any test has failed.
105
106 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
107
108         [GStreamer] Do not automatically show PackageKit codec installation notifications
109         https://bugs.webkit.org/show_bug.cgi?id=135973
110
111         Reviewed by Philippe Normand.
112
113         Handle the missing media plugins installation permission request
114         in MiniBrowser and add a test case for the new API.
115
116         * MiniBrowser/gtk/BrowserWindow.c:
117         (webViewDecidePermissionRequest):
118         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
119         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
120         (permissionRequestCallback):
121         (testInstallMissingPluginsPermissionRequest):
122         (beforeAll):
123         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
124         (methodCallCallback):
125
126 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
127
128         Running tests for a long time results in some tests running very slowly (throttling)
129         https://bugs.webkit.org/show_bug.cgi?id=147718
130
131         Reviewed by Alexey Proskuryakov.
132
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::TestController::resetPreferencesToConsistentValues):
135         Ensure throttling settings are disabled for tests for all ports, as
136         COCOA ports default to having these setting enabled. Note, there is
137         still other timer throttling not covered by these setting.
138
139 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
140
141         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
142         https://bugs.webkit.org/show_bug.cgi?id=147752
143
144         Reviewed by Chris Dumez.
145
146         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
147
148         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
149         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
150
151         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
152         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
153         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
154         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
155         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
156         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
157         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
158         HTTPServerDriverFactory taking the platform name as an argument.
159         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
160         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
161         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
162         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
163         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
164         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
165         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
166         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
167         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
168         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
169         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
170         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
171         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
172         (HTTPServerDriver): Replaced name by platforms.
173         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
174         (SimpleHTTPServerDriver): Ditto.
175         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
176         (parse_args): Removed --http-server-driver option.
177         (start): Ditto.
178
179 2015-08-06  Chris Dumez  <cdumez@apple.com>
180
181         Toggle GPS state based on page visibility to save battery
182         https://bugs.webkit.org/show_bug.cgi?id=147685
183
184         Reviewed by Benjamin Poulain.
185
186         Add testRunner.isGeolocationProviderActive() test support function.
187
188         * DumpRenderTree/TestRunner.cpp:
189         (isGeolocationProviderActiveCallback):
190         (TestRunner::staticFunctions):
191         * DumpRenderTree/TestRunner.h:
192         * DumpRenderTree/mac/MockGeolocationProvider.h:
193         * DumpRenderTree/mac/MockGeolocationProvider.mm:
194         (-[MockGeolocationProvider isActive]):
195         * DumpRenderTree/mac/TestRunnerMac.mm:
196         (TestRunner::isGeolocationProviderActive):
197         * DumpRenderTree/win/TestRunnerWin.cpp:
198         (TestRunner::isGeolocationProviderActive):
199         * WebKitTestRunner/GeolocationProviderMock.h:
200         (WTR::GeolocationProviderMock::isActive):
201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
202         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
203         (WTR::InjectedBundle::isGeolocationProviderActive):
204         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
206         (WTR::TestRunner::isGeolocationProviderActive):
207         * WebKitTestRunner/InjectedBundle/TestRunner.h:
208         * WebKitTestRunner/TestController.cpp:
209         (WTR::TestController::isGeolocationProviderActive):
210         * WebKitTestRunner/TestController.h:
211         * WebKitTestRunner/TestInvocation.cpp:
212         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
213
214 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
215
216         Automate JSBench with run-benchmark
217         https://bugs.webkit.org/show_bug.cgi?id=147716
218
219         Reviewed by Chris Dumez.
220
221         Added JSBench plan to run-benchmark.
222
223         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
224         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
225         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
226         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
227         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
228         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
229         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
230         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
231         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
232         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
233         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
234         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
235         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
236         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
237         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
238         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
239
240 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
241
242         Pass-through the undefined options in run-jsc
243         https://bugs.webkit.org/show_bug.cgi?id=147717
244
245         Undefined options in run-jsc is just passed to the actual jsc shell.
246         We can execute `Tools/Scripts/run-jsc -d`.
247
248         Reviewed by Csaba Osztrogonác.
249
250         * Scripts/run-jsc:
251
252 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
253
254         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
255
256         It's flaky.
257
258         * Scripts/run-gtk-tests:
259         (TestRunner):
260
261 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
262
263         [EFL] Bump EFL version to 1.15.0
264         https://bugs.webkit.org/show_bug.cgi?id=147450
265
266         Reviewed by Gyuyoung Kim.
267
268         * efl/jhbuild.modules:
269
270 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
271
272         Unreviewed. Unksip TestContextMenu GTK+ API test.
273
274         This has been skipped for a long time, and it's very
275         unconvenient. It has never failed for me locally, so let's try
276         again to see if it works in the bots. I'll skip it again if it
277         keeps failing.
278
279         * Scripts/run-gtk-tests:
280         (TestRunner):
281
282 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
283
284         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
285
286         * DumpRenderTree/JavaScriptThreading.cpp:
287         (javaScriptThreadsMutex):
288         (runJavaScriptThread):
289         (startJavaScriptThreads):
290         (stopJavaScriptThreads):
291         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
294         (TestWebKitAPI::TEST):
295
296 2015-08-05  Alex Christensen  <achristensen@webkit.org>
297
298         Build DumpRenderTree with CMake.
299         https://bugs.webkit.org/show_bug.cgi?id=147519
300
301         Reviewed by Brent Fulgham.
302
303         * CMakeLists.txt:
304         Build the DumpRenderTree directory now that it builds successfully.
305         * DumpRenderTree/CMakeLists.txt:
306         Added missing source file and don't link with WebCore.lib.
307         * DumpRenderTree/PlatformWin.cmake:
308         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
309         * WinLauncher/CMakeLists.txt:
310         We need libcmt now that we are not linking with WebCore.lib.
311
312 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
313
314         AppScale: Use https URLs for subresources and links
315         https://bugs.webkit.org/show_bug.cgi?id=147686
316
317         Reviewed by Ryosuke Niwa.
318
319         * QueueStatusServer/filters/webkit_extras.py:
320         * TestResultServer/static-dashboards/dashboard_base.js:
321         * TestResultServer/static-dashboards/flakiness_dashboard.js:
322         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
323         * TestResultServer/static-dashboards/treemap.js:
324         * TestResultServer/static-dashboards/ui.js:
325
326 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
327
328         Rename Mutex to DeprecatedMutex
329         https://bugs.webkit.org/show_bug.cgi?id=147675
330
331         Reviewed by Geoffrey Garen.
332
333         * DumpRenderTree/JavaScriptThreading.cpp:
334         (javaScriptThreadsMutex):
335         (runJavaScriptThread):
336         (startJavaScriptThreads):
337         (stopJavaScriptThreads):
338         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
341         (TestWebKitAPI::TEST):
342
343 2015-08-05  Timothy Hatcher  <timothy@apple.com>
344
345         Update the WebKit nightly icon
346         https://bugs.webkit.org/show_bug.cgi?id=147684
347
348         Reviewed by Sam Weinig.
349
350         * WebKitLauncher/webkit.icns: Replaced.
351
352 2015-08-05  Daniel Bates  <dabates@apple.com>
353
354         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
355         https://bugs.webkit.org/show_bug.cgi?id=147678
356         <rdar://problem/21827815>
357
358         Reviewed by Brady Eidson.
359
360         Add a test to ensure that we restore the "should open external URLs" policy on
361         page reload after the web content process crashes.
362
363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
364         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
365         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
366         (TEST):
367
368 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
369
370         [EFL] Editing tests have been broken since r186694
371         https://bugs.webkit.org/show_bug.cgi?id=146888
372
373         Reviewed by Brent Fulgham.
374
375         Restored some codes for the context click on GTK+ and EFL port.
376
377         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
378         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
379
380 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
381
382         Install twisted package for http server when necessary.
383         https://bugs.webkit.org/show_bug.cgi?id=147082
384
385         Reviewed by Ryosuke Niwa.
386
387         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
388         * Scripts/webkitpy/thirdparty/__init__.py:
389         (AutoinstallImportHook.find_module):
390         (AutoinstallImportHook._install_twisted):
391
392 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
393
394         [Win] Update Apple Windows build for VS2015
395         https://bugs.webkit.org/show_bug.cgi?id=147653
396
397         Reviewed by Dean Jackson.
398
399         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
400         something older than VS2015, define snprintf as _snprintf.
401         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
402         Remove unneeded macro definition for snprintf.
403         * Scripts/webkitpy/common/system/platforminfo.py:
404         (PlatformInfo._determine_win_version): Recognize Windows 10.
405         * Scripts/webkitpy/port/win.py:
406         (WinPort): Ditto.
407         * Scripts/webkitpy/port/win_unittest.py:
408         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
409         (WinPortTest._assert_version): Ditto.
410
411 2015-08-04  Brian Burg  <bburg@apple.com>
412
413         Unreviewed, update email addresses in contributors.json and watchlist.
414
415         * Scripts/webkitpy/common/config/contributors.json:
416         * Scripts/webkitpy/common/config/watchlist:
417
418 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
419
420         Implement NPAPI redirect handling
421         https://bugs.webkit.org/show_bug.cgi?id=138675
422         rdar://problem/15779101
423
424         Patch by Jeffrey Pfau, updated and tweaked by me.
425
426         Reviewed by Anders Carlsson.
427
428         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
429         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
431         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
432         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
433         (PluginTest::NPP_URLNotify):
434         (PluginTest::NPP_URLRedirectNotify):
435         (PluginTest::NPP_GetValue):
436         (PluginTest::NPN_GetURLNotify):
437         (PluginTest::NPN_PostURLNotify):
438         (PluginTest::NPN_GetValue):
439         (PluginTest::NPN_ReleaseVariantValue):
440         (PluginTest::NPN_URLRedirectResponse):
441         (PluginTest::NPN_ConvertPoint):
442         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
443         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
444         (URLRedirect::URLRedirect):
445         (URLRedirect::ScriptableObject::hasMethod):
446         (URLRedirect::ScriptableObject::get):
447         (URLRedirect::ScriptableObject::serviceAsync):
448         (URLRedirect::ScriptableObject::invoke):
449         (URLRedirect::NPP_GetValue):
450         (URLRedirect::NPP_URLNotify):
451         (URLRedirect::NPP_URLRedirectNotify):
452         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
453         (NP_GetEntryPoints):
454         (NPP_URLNotify):
455         (NPP_URLRedirectNotify):
456         (NPP_GetValue):
457
458 2015-08-04  Tim Horton  <timothy_horton@apple.com>
459
460         Move Matt Daiter to committers.
461
462         * Scripts/webkitpy/common/config/contributors.json:
463
464 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
465
466         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
467         https://bugs.webkit.org/show_bug.cgi?id=147636
468
469         Reviewed by Alex Christensen.
470         
471         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
472         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
473         on EWS machines)
474
475         * Scripts/build-webkit:
476
477 2015-08-04  Jason Marcell  <jmarcell@apple.com>
478
479         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
480         https://bugs.webkit.org/show_bug.cgi?id=147280
481
482         Reviewed by Daniel Bates.
483
484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
485         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
486         Refactored _parseData to handle repositories more generically.
487         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
489         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
490         "opensourceRevision" and "internalRevision".
491         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
493         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
494         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
495         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
496         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
497         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
498         and "internalRevision".
499         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
500         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
501         "opensourceRevision" and "internalRevision".
502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
503         constants for internal and opensource repositories.
504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
505         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
506         instead of "opensourceRevision" and "internalRevision".
507         (Analyzer.prototype._countPercentageOfGreen): Ditto.
508         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
509         (Analyzer.prototype._countTimes): Ditto.
510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
511         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
512
513 2015-08-04  Mark Lam  <mark.lam@apple.com>
514
515         Removed a local debugging line I accidentally left in from a previous commit.
516
517         Not Reviewed.
518
519         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
520
521 2015-08-04  Mark Lam  <mark.lam@apple.com>
522
523         Unreviewed. Make Saam Barati a WebKit reviewer.
524
525         * Scripts/webkitpy/common/config/contributors.json:
526
527 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
528
529         Unreviewed, updated Streams API watchlist.
530
531         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
532
533 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
534
535         [CMake] Add an option to build AllInOne files
536         https://bugs.webkit.org/show_bug.cgi?id=102647
537
538         Reviewed by Alex Christensen.
539
540         * Scripts/webkitperl/FeatureList.pm:
541
542 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
543
544         AppScale: Add required indices
545         https://bugs.webkit.org/show_bug.cgi?id=147593
546
547         Reviewed by Tim Horton.
548
549         * QueueStatusServer/index.yaml:
550
551 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
552
553         Check in LLVM 3.6.2 binary drops for El Capitan
554         https://bugs.webkit.org/show_bug.cgi?id=147582
555
556         Reviewed by Alexey Proskuryakov.
557         
558         Recognize 10.11 and use the right drops.
559
560         * Scripts/copy-webkitlibraries-to-product-directory:
561
562 2015-08-03  Alex Christensen  <achristensen@webkit.org>
563
564         [Win] Build fix after r187733.
565
566         * WinLauncher/PageLoadTestClient.cpp:
567         (PageLoadTestClient::dumpRunStatistics):
568         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
569
570 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
571
572         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
573         https://bugs.webkit.org/show_bug.cgi?id=118455
574
575         Reviewed by Filip Pizlo.
576
577         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
578         (TestWebKitAPI::TEST):
579
580 2015-07-31  Alex Christensen  <achristensen@webkit.org>
581
582         Prepare for VS2015
583         https://bugs.webkit.org/show_bug.cgi?id=146579
584
585         Reviewed by Jon Honeycutt.
586
587         * WinLauncher/stdafx.h:
588         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
589
590 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
591
592         [EFL] Fix pixman build on ARM with GCC 4.9.3
593         https://bugs.webkit.org/show_bug.cgi?id=147224
594
595         Reviewed by Gyuyoung Kim.
596
597         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
598
599 2015-07-30  Anders Carlsson  <andersca@apple.com>
600
601         Add support for window.open to WK1BrowserWindowController
602         https://bugs.webkit.org/show_bug.cgi?id=147474
603
604         Reviewed by Dan Bernstein.
605
606         * MiniBrowser/mac/WK1BrowserWindowController.m:
607         (-[WK1BrowserWindowController awakeFromNib]):
608         Set javaScriptCanOpenWindowsAutomatically to YES. 
609         If this becomes a nuisance, we can always add a menu item to toggle this.
610
611         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
612         Implement this UI delegate method.
613
614 2015-07-30  Anders Carlsson  <andersca@apple.com>
615
616         Undo stray commit.
617
618         * MiniBrowser/mac/WK1BrowserWindowController.m:
619         (-[WK1BrowserWindowController awakeFromNib]):
620         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
621
622 2015-07-29  Dean Jackson  <dino@apple.com>
623
624         Don't use (Details) when exposing SPI
625         https://bugs.webkit.org/show_bug.cgi?id=147426
626         <rdar://problem/22062407>
627
628         Reviewed by Dan Bernstein.
629
630         If we are declaring the interface without any implementation,
631         we should use class extensions.
632
633         * DumpRenderTree/mac/DumpRenderTree.mm:
634         * DumpRenderTree/mac/EventSendingController.mm:
635         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
636         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
637         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
638         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
639         * WebKitTestRunner/mac/TestControllerMac.mm:
640
641 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
642
643         Replace Google App Engine with AppScale
644         https://bugs.webkit.org/show_bug.cgi?id=147178
645
646         Reviewed by Daniel Bates.
647
648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
649         (RunWebKitTests):
650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
655         (.):
656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
657         (BubbleQueueServer):
658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
659         (TestHistory):
660         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
661         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
662         * TestResultServer/app.yaml: Ditto
663         * Scripts/webkitpy/common/config/urls.py:
664         * TestResultServer/main.py:
665         * TestResultServer/static-dashboards/dashboard_base.js:
666         * TestResultServer/static-dashboards/loader.js:
667
668 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
669
670         [EFL] Enable IndexedDB based on DatabaseProcess
671         https://bugs.webkit.org/show_bug.cgi?id=147221
672
673         Reviewed by Csaba Osztrogonác.
674
675         * Scripts/webkitperl/FeatureList.pm:
676
677 2015-07-30  Alex Christensen  <achristensen@webkit.org>
678
679         Build AppleWin port with CMake
680         https://bugs.webkit.org/show_bug.cgi?id=147385
681
682         Reviewed by Martin Robinson.
683
684         * WinLauncher/CMakeLists.txt:
685         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
686
687 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
688
689         Implement basic types for ECMAScript Internationalization API
690         https://bugs.webkit.org/show_bug.cgi?id=146926
691
692         Reviewed by Benjamin Poulain.
693
694         Enable flag now that the basic objects are in place.
695
696         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
697
698 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
699
700         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
701         https://bugs.webkit.org/show_bug.cgi?id=147108
702
703         Reviewed by Gustavo Noronha Silva.
704
705         Add test case to check the web process limit.
706
707         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
708         (testWebProcessLimit):
709         (beforeAll):
710
711 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
712
713         [GTK] Missing casts in BrowserWindow.c
714         https://bugs.webkit.org/show_bug.cgi?id=147395
715
716         Reviewed by Carlos Garcia Campos.
717
718         * MiniBrowser/gtk/BrowserWindow.c:
719         (browserWindowSetupEditorToolbar):
720
721 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
722
723         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
724         https://bugs.webkit.org/show_bug.cgi?id=147350
725
726         Reviewed by Sam Weinig.
727
728         * Scripts/webkitperl/FeatureList.pm:
729
730 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
731
732         [Freetype] Always allow font matching for strong aliases
733         https://bugs.webkit.org/show_bug.cgi?id=147057
734
735         Reviewed by Martin Robinson.
736
737         Create family aliases needed for the new layout tests.
738
739         * WebKitTestRunner/gtk/fonts/fonts.conf:
740
741 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
742
743         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
744         https://bugs.webkit.org/show_bug.cgi?id=147359
745
746         Reviewed by Ryosuke Niwa.
747
748         * Scripts/webkitpy/tool/commands/newcommitbot.py:
749         (NewCommitBot.begin_work_queue):
750         * Scripts/webkitpy/tool/commands/sheriffbot.py:
751         (SheriffBot.begin_work_queue):
752
753 2015-07-27  Alex Christensen  <achristensen@webkit.org>
754
755         Use Ninja on Windows.
756         https://bugs.webkit.org/show_bug.cgi?id=147228
757
758         Reviewed by Martin Robinson.
759
760         * WinLauncher/CMakeLists.txt:
761         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
762         * Scripts/build-webkit:
763         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
764
765 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
766
767         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
768         highlight after being tapped to style a selection"
769         https://bugs.webkit.org/show_bug.cgi?id=147278
770
771         Reviewed by Ryosuke Niwa.
772
773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
774
775         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
776         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
777         (TestWebKitAPI::TEST):
778         Load a page with the string "Hello, world!", then select "world" and
779         underline it. Test that the typing attributes for the current selection
780         include the underline attribute.
781
782 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
783
784         Unreviewed, updated my nick name in contributors.json
785
786         * Scripts/webkitpy/common/config/contributors.json:
787
788 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
789
790         AX: scrollable elements do not allow 3-finger swipe
791         https://bugs.webkit.org/show_bug.cgi?id=141893
792
793         Reviewed by Mario Sanchez Prada.
794
795         Support global notification listeners for iOS code.
796         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
797         Implement scrollUp/Down/Left/Right.
798
799         * DumpRenderTree/AccessibilityController.h:
800         * DumpRenderTree/AccessibilityUIElement.cpp:
801         (increaseTextSelectionCallback):
802         (scrollPageUpCallback):
803         (scrollPageDownCallback):
804         (scrollPageLeftCallback):
805         (scrollPageRightCallback):
806         (decreaseTextSelectionCallback):
807         (getElementTextLengthCallback):
808         (AccessibilityUIElement::getJSClass):
809         * DumpRenderTree/AccessibilityUIElement.h:
810         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
811         (AccessibilityController::~AccessibilityController):
812         (AccessibilityController::elementAtPoint):
813         (AccessibilityController::addNotificationListener):
814         (AccessibilityController::platformResetToConsistentState):
815         (AccessibilityController::removeNotificationListener):
816         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
817         (AccessibilityUIElement::AccessibilityUIElement):
818         (AccessibilityUIElement::subrole):
819         (AccessibilityUIElement::scrollPageUp):
820         (AccessibilityUIElement::scrollPageDown):
821         (AccessibilityUIElement::scrollPageLeft):
822         (AccessibilityUIElement::scrollPageRight):
823         (AccessibilityUIElement::roleDescription):
824         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
825         (-[AccessibilityNotificationHandler _notificationReceived:]):
826         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
827         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
828         (WTR::AccessibilityUIElement::linkedElement):
829         (WTR::AccessibilityUIElement::headerElementAtIndex):
830         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
831         (WTR::AccessibilityUIElement::scrollPageUp):
832         (WTR::AccessibilityUIElement::scrollPageDown):
833         (WTR::AccessibilityUIElement::scrollPageLeft):
834         (WTR::AccessibilityUIElement::scrollPageRight):
835         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
836         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
837         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
838         (WTR::AccessibilityController::addNotificationListener):
839         (WTR::AccessibilityController::removeNotificationListener):
840         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
841         (WTR::AccessibilityUIElement::AccessibilityUIElement):
842         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
843         (WTR::AccessibilityUIElement::scrollPageUp):
844         (WTR::AccessibilityUIElement::scrollPageDown):
845         (WTR::AccessibilityUIElement::scrollPageLeft):
846         (WTR::AccessibilityUIElement::scrollPageRight):
847         (WTR::AccessibilityUIElement::increaseTextSelection):
848
849 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
850
851         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
852         https://bugs.webkit.org/show_bug.cgi?id=147279
853         <rdar://problem/21990767>
854
855         Reviewed by Dean Jackson.
856
857         * DumpRenderTree/win/TestRunnerWin.cpp:
858         (TestRunner::addUserScript):
859         (TestRunner::addUserStyleSheet):
860         (TestRunner::setDeveloperExtrasEnabled):
861
862 2015-07-24  Basile Clement  <basile_clement@apple.com>
863
864         Call fixChangeLogPatch when generating patches from webkit-patch
865         https://bugs.webkit.org/show_bug.cgi?id=147248
866
867         Reviewed by Geoffrey Garen.
868
869         When two consecutive patches are from the same author, diff tools
870         create wrong-looking diffs for ChangeLog files where the apparent added
871         author is actually the previous patch's author line, making it awkward
872         to read - and things only get worse when committing a patch and a
873         followup fix for the same bug shortly after.
874
875         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
876         this, which we use in perl scripts (svn-create-patch et al). But it is
877         not used by webkit-patch, which is a python script, and thus creates
878         "bad" diffs.
879
880         In the long term, we should probably port fixChangeLogPatch to python -
881         but in the short term, let's make webkit-patch call perl to run
882         fixChangeLogPatch. We are already making various external calls there
883         anyway.
884
885         * Scripts/webkitpy/common/checkout/scm/git.py:
886         (Git.create_patch):
887         * Scripts/webkitpy/common/checkout/scm/scm.py:
888         (SCM.fix_changelog_patch):
889         * Scripts/webkitpy/common/checkout/scm/svn.py:
890         (SVN.create_patch):
891
892 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
893
894         commit-queue flags in webkit-patch are confusing
895         https://bugs.webkit.org/show_bug.cgi?id=88694
896
897         Reviewed by Csaba Osztrogonác.
898
899         * Scripts/webkitpy/tool/steps/options.py:
900         (Options): Updated help string to be more descriptive.
901
902 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
903
904         [Win] Implement proper High DPI support features
905         https://bugs.webkit.org/show_bug.cgi?id=146335
906         <rdar://problem/21558269>
907
908         Reviewed by Alex Christensen.
909
910         Update WinLauncher to take device scaling factor into account.
911
912         * WinLauncher/Common.cpp:
913         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
914         a valid font.
915         (computeFullDesktopFrame): Handle high DPI desktops.
916         (WndProc): Make comments more precise.
917         * WinLauncher/WinLauncher.cpp:
918         (WinLauncher::init): Determine device scale factor at launch.
919         (WinLauncher::updateDeviceScaleFactor): Added.
920         * WinLauncher/WinLauncher.h:
921         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
922         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
923         (wWinMain): Ditto.
924         * win/DLLLauncher/DLLLauncherMain.cpp:
925         (wWinMain): Tell Windows we understand high DPI.
926
927 2015-07-23  Alex Christensen  <achristensen@webkit.org>
928
929         [Win] Unreviewed build fix after r187169.
930
931         * Scripts/build-webkit:
932         Correctly find WebKit.sln.
933
934 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         [GTK] Add API to allow executing editing commands that require an argument
937         https://bugs.webkit.org/show_bug.cgi?id=146781
938
939         Reviewed by Gustavo Noronha Silva.
940
941         Add buttons to insert image/link to the MiniBrowser edit toolbar,
942         and test cases for insert image/link commands too.
943
944         * MiniBrowser/gtk/BrowserWindow.c:
945         (insertImageCommandCallback):
946         (insertLinkCommandCallback):
947         (browserWindowSetupEditorToolbar):
948         (browserWindowConstructed):
949         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
950         (testWebViewEditorInsertImage):
951         (testWebViewEditorCreateLink):
952         (beforeAll):
953
954 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
955
956         Unregistering and re-registering a user message handler does not work
957         https://bugs.webkit.org/show_bug.cgi?id=138142
958
959         Reviewed by Martin Robinson.
960
961         This has probably been fixed in r184846, enable the test case
962         blocked on it.
963
964         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
965         (testUserContentManagerScriptMessageReceived):
966
967 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
968
969         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
970         https://bugs.webkit.org/show_bug.cgi?id=147212
971
972         Reviewed by Filip Pizlo.
973
974         * Scripts/webkitperl/FeatureList.pm:
975
976 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
977
978         Add --ios-simulator to run-api-tests --help.
979
980         Rubber-stamped by Dan Bates.
981
982         * Scripts/run-api-tests:
983
984 2015-07-22  Jason Marcell  <jmarcell@apple.com>
985
986         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
987         https://bugs.webkit.org/show_bug.cgi?id=147043
988
989         Reviewed by Daniel Bates and Alexey Proskuryakov.
990
991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
992         (Buildbot.prototype._normalizeQueueInfo):
993         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
994         in cases where the queue.branch property is not set and the queue is not a combined queue.
995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
996         (BuildbotCombinedQueueView):
997         Ensuring uniformity of repository branches within a combined queue.
998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
999         (WebKitBuildbot.prototype.get defaultBranches):
1000         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
1001         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
1002         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
1003         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
1004         implement defaultBranches so that a person can either update the definition of the sub-queue or
1005         implement defaultBranches in the derived Buildbot class they are using.
1006
1007 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1008
1009         Switch WinCairo build to use CMake.
1010         https://bugs.webkit.org/show_bug.cgi?id=147169
1011
1012         Reviewed by Brent Fulgham.
1013
1014         * Scripts/build-webkit:
1015         * Scripts/webkitdirs.pm:
1016         (determineConfiguration):
1017         (determineArchitecture):
1018         (determinePassedConfiguration):
1019         (passedConfiguration):
1020         (jhbuildWrapperPrefixIfNeeded):
1021         (generateBuildSystemFromCMakeProject):
1022         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
1023
1024 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1025
1026         Fix quirks in CMake build on Mac and Windows
1027         https://bugs.webkit.org/show_bug.cgi?id=147174
1028
1029         Reviewed by Gyuyoung Kim.
1030
1031         * CMakeLists.txt:
1032         Don't build DumpRenderTree with CMake for now (until we get that working).
1033         * WinLauncher/CMakeLists.txt:
1034         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
1035
1036 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1037
1038         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
1039         https://bugs.webkit.org/show_bug.cgi?id=147146
1040
1041         Reviewed by Darin Adler.
1042
1043         * Scripts/webkitpy/style/checkers/cpp.py:
1044         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
1045         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1046         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
1047
1048 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
1049
1050         Fixed VM pool allocation should have a reserve for allocations that cannot fail
1051         https://bugs.webkit.org/show_bug.cgi?id=147154
1052         rdar://problem/21847618
1053
1054         Reviewed by Geoffrey Garen.
1055         
1056         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
1057         mitigations work, these should all pass. Prior to this patch there were >20 failures.
1058
1059         * Scripts/run-jsc-stress-tests:
1060
1061 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1062
1063         [GTK] Add API to be notified about editor state changes
1064         https://bugs.webkit.org/show_bug.cgi?id=145875
1065
1066         Reviewed by Gustavo Noronha Silva.
1067
1068         Update the typing attributes toggle buttons state according to the
1069         editor state in MiniBrowser, and add a test case to the
1070         WebViewEditor unit tests.
1071
1072         * MiniBrowser/gtk/BrowserWindow.c:
1073         (browserWindowEditingCommandToggleButtonSetActive):
1074         (typingAttributesChanged):
1075         (browserWindowSetupEditorToolbar):
1076         (browserWindowConstructed):
1077         (browser_window_init):
1078         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1079         (testWebViewEditorEditorStateTypingAttributes):
1080         (beforeAll):
1081
1082 2015-07-20  Tomas Popela  <tpopela@redhat.com>
1083
1084         [GTK] Add selection-changed signal to the WebKit2 API
1085         https://bugs.webkit.org/show_bug.cgi?id=137116
1086
1087         Reviewed by Carlos Garcia Campos.
1088
1089         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
1090         (namely the selection-changed signal).
1091
1092         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1093         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
1094         (WebKitWebEditorTest::create):
1095         (WebKitWebEditorTest::selectionChangedCallback):
1096         (WebKitWebEditorTest::testSelectionSelectAll):
1097         (WebKitWebEditorTest::testSelectionCollapse):
1098         (WebKitWebEditorTest::testSelectionModifyMove):
1099         (WebKitWebEditorTest::testSelectionModifyExtend):
1100         (WebKitWebEditorTest::testSelectionUnselect):
1101         (registerTests):
1102         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
1103         (testWebKitWebEditorSelectionChanged):
1104         (beforeAll):
1105         (afterAll):
1106
1107 2015-07-20  Alex Christensen  <achristensen@webkit.org>
1108
1109         Resurrect CMake build on Windows.
1110         https://bugs.webkit.org/show_bug.cgi?id=147083
1111
1112         Reviewed by Gyuyoung Kim.
1113
1114         * DumpRenderTree/CMakeLists.txt:
1115         * DumpRenderTree/PlatformWin.cmake: Added.
1116         * WinLauncher/CMakeLists.txt:
1117
1118 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1119
1120         [GTK] Enable seccomp filter API tests
1121         https://bugs.webkit.org/show_bug.cgi?id=140071
1122
1123         Reviewed by Žan Doberšek.
1124
1125         These tests will now be run by the run-gtk-tests script.
1126
1127         * TestWebKitAPI/PlatformGTK.cmake:
1128
1129 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1130
1131         [GTK] Add seccomp filters support
1132         https://bugs.webkit.org/show_bug.cgi?id=110014
1133
1134         Reviewed by Žan Doberšek.
1135
1136         Add libseccomp to jhbuild modulesets.
1137
1138         * gtk/jhbuild.modules:
1139
1140 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
1141
1142         MiniBrowser window title is just "Window" when page has no <title>
1143         https://bugs.webkit.org/show_bug.cgi?id=147076
1144
1145         Reviewed by Tim Horton.
1146         
1147         Make MiniBrowser windows show the filename from the URL if we never get a title changed
1148         notification.
1149
1150         * MiniBrowser/mac/WK1BrowserWindowController.m:
1151         (-[WK1BrowserWindowController updateTitle:]):
1152         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
1153         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1154         * MiniBrowser/mac/WK2BrowserWindowController.m:
1155         (-[WK2BrowserWindowController updateTitle:]):
1156         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1157         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1158
1159 2015-07-17  Andy Estes  <aestes@apple.com>
1160
1161         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
1162         https://bugs.webkit.org/show_bug.cgi?id=147044
1163         rdar://problem/21567820
1164
1165         Reviewed by Brady Eidson.
1166
1167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1168         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
1169         This matches the behavior of DumpRenderTree.
1170
1171 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
1172
1173         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
1174         https://bugs.webkit.org/show_bug.cgi?id=147032
1175
1176         Reviewed by Alex Christensen.
1177
1178         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1179         Test that the useless terms are eliminated by counting
1180         the number of NFA nodes generated.
1181
1182 2015-07-17  Dan Bernstein  <mitz@apple.com>
1183
1184         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
1185         https://bugs.webkit.org/show_bug.cgi?id=147040
1186
1187         Reviewed by Dean Jackson.
1188
1189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1190         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
1191         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
1192         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
1193         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1194         (TEST):
1195
1196 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
1197
1198         webkit-patch uses incorrect credentials from keychain to login until account lockout
1199         https://bugs.webkit.org/show_bug.cgi?id=146923
1200
1201         Reviewed by Daniel Bates.
1202
1203         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
1204         provide incorrect credentials then ask for them to be saved to the keychain
1205         webkit-patch will then use those incorrect credentials until 5 total attempts
1206         have been made to log in. This will lock the user out of Bugzilla for a
1207         half hour.
1208
1209         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1210         (Bugzilla.authenticate): Added argument to read_credentials() that
1211         passes in whether or not to use stored credentials.
1212         * Scripts/webkitpy/common/net/credentials.py:
1213         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
1214         that specifies whether or not to use credentials stored on the system. If it
1215         does, we do not auto-fill credentials since either the credentials caused
1216         the failure, or they weren't used in the first place so there is no reason
1217         to try and use them again if a failure happened.
1218         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
1219         use_stored_credentials argument.
1220         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
1221         retrieve username/password information from the local system (environment, Git, keychain,
1222         keyring) are never called. It also tests that we get back our mocked username and password.
1223         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
1224         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
1225         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
1226         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
1227         is never called.
1228         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
1229         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
1230         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
1231         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
1232         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
1233         against.
1234
1235 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1236
1237         Unreviewed, remove my redundant email information.
1238
1239         * Scripts/webkitpy/common/config/contributors.json:
1240
1241 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1242
1243         Unreviewed. Add Hyungwook Lee as a committer.
1244
1245         * Scripts/webkitpy/common/config/contributors.json:
1246
1247 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1248
1249         Added myself to the list of contributors.
1250
1251         Reviewed by Brent Fulgham.
1252
1253         * Scripts/webkitpy/common/config/contributors.json:
1254
1255 2015-07-16  Alex Christensen  <achristensen@webkit.org>
1256
1257         [Content Extensions] Cache domain actions
1258         https://bugs.webkit.org/show_bug.cgi?id=146817
1259
1260         Reviewed by Benjamin Poulain.
1261
1262         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1263         (TestWebKitAPI::TEST_F):
1264         Test if-domain and unless-domain with multiple load types.
1265
1266 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
1267
1268         [Content extensions] Combine suffixes when generating NFAs
1269         https://bugs.webkit.org/show_bug.cgi?id=146961
1270
1271         Reviewed by Alex Christensen.
1272
1273         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1274         (TestWebKitAPI::compareContents):
1275         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1276
1277 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1278
1279         [GTK] Input method filter is always enabled when the view is focused
1280         https://bugs.webkit.org/show_bug.cgi?id=146965
1281
1282         Reviewed by Martin Robinson.
1283
1284         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
1285
1286         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1287         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1288
1289 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1290
1291         [EFL] Bump libseccomp version to 2.2.3
1292         https://bugs.webkit.org/show_bug.cgi?id=146980
1293
1294         Reviewed by Gyuyoung Kim.
1295
1296         * efl/jhbuild.modules:
1297
1298 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
1299
1300         [Win] Maintain consistent COM Interfaces
1301         https://bugs.webkit.org/show_bug.cgi?id=146983
1302         <rdar://problem/21822278>
1303
1304         Reviewed by Dean Jackson.
1305
1306         Update DumpRenderTree and WinLauncher to use the properly
1307         versioned COM interface objects.
1308
1309         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1310         (AccessibilityController::rootElement):
1311         * DumpRenderTree/win/DumpRenderTree.cpp:
1312         (resetWebPreferencesToConsistentValues):
1313         (resetWebViewToConsistentStateBeforeTesting):
1314         (runTest):
1315         (createWebViewAndOffscreenWindow):
1316         * DumpRenderTree/win/EditingDelegate.cpp:
1317         (EditingDelegate::QueryInterface):
1318         (EditingDelegate::shouldEndEditingInDOMRange):
1319         (EditingDelegate::shouldInsertNode):
1320         * DumpRenderTree/win/EditingDelegate.h:
1321         * DumpRenderTree/win/EventSender.cpp:
1322         (scalePageByCallback):
1323         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1324         (FrameLoadDelegate::didCommitLoadForFrame):
1325         * DumpRenderTree/win/TestRunnerWin.cpp:
1326         (TestRunner::callShouldCloseOnWebView):
1327         (TestRunner::applicationCacheDiskUsageForOrigin):
1328         (TestRunner::clearApplicationCacheForOrigin):
1329         (TestRunner::setDefersLoading):
1330         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1331         (TestRunner::setTabKeyCyclesThroughElements):
1332         (TestRunner::setValueForUser):
1333         (TestRunner::dispatchPendingLoadRequests):
1334         (TestRunner::setWindowIsKey):
1335         (TestRunner::execCommand):
1336         (TestRunner::addOriginAccessWhitelistEntry):
1337         (TestRunner::removeOriginAccessWhitelistEntry):
1338         (TestRunner::addUserScript):
1339         (TestRunner::addUserStyleSheet):
1340         (TestRunner::showWebInspector):
1341         (TestRunner::closeWebInspector):
1342         (TestRunner::evaluateInWebInspector):
1343         (TestRunner::setSerializeHTTPLoads):
1344         * DumpRenderTree/win/TextInputControllerWin.cpp:
1345         (TextInputController::setMarkedText):
1346         (TextInputController::hasMarkedText):
1347         (TextInputController::unmarkText):
1348         (TextInputController::markedRange):
1349         (TextInputController::insertText):
1350         (TextInputController::firstRectForCharacterRange):
1351         (TextInputController::selectedRange):
1352         * DumpRenderTree/win/UIDelegate.h:
1353         (UIDelegate::unused2):
1354         (UIDelegate::unused3):
1355         (UIDelegate::webViewScrolled):
1356         (UIDelegate::webViewShouldInterruptJavaScript):
1357         (UIDelegate::webViewReceivedFocus):
1358         (UIDelegate::unused4): Deleted.
1359         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1360         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1361         * WinLauncher/PageLoadTestClient.cpp:
1362         (PageLoadTestClient::didStartProvisionalLoad):
1363         * WinLauncher/WinLauncher.cpp:
1364         (WinLauncher::init):
1365         * WinLauncher/WinLauncher.h:
1366         * WinLauncher/WinLauncherWebHost.cpp:
1367         (WinLauncherWebHost::didFinishLoadForFrame):
1368         (WinLauncherWebHost::didFirstLayoutInFrame):
1369         * WinLauncher/WinLauncherWebHost.h:
1370
1371 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
1372
1373         Many test failures in scm_unittest.py
1374         https://bugs.webkit.org/show_bug.cgi?id=143967
1375
1376         Reviewed by Daniel Bates. 
1377
1378         * Scripts/webkitpy/common/checkout/scm/detection.py:
1379         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
1380         absolute canonical file paths. Two mutually exclusive issues cause this
1381         to be a problem.
1382             1) Python's os.path.relpath() function does not return correct relative
1383             paths between two filepaths that point to the same file, if symlinks are
1384             involved.
1385                 On Mac, /tmp points to /private/tmp
1386                 ex. os.path.relpath('/tmp', '/private/tmp')
1387                     returns '../../tmp'
1388             What we want is actually just '.'
1389             2) Git does not allow file paths to trace outside of
1390             the Git repository. This means that if you have a repository in
1391             /tmp and you refer to that repository when invoking a git command as
1392             ../tmp, Git will produce errors about working outside of the repository.
1393         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
1394         its default behavior and such, needed to be updated.
1395         (Git.changed_files): '--' was added into the command so that patch_directories
1396         were taken as positional arguments.
1397         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
1398         in the GitSVNTest class to more closely emulate the version of Git that the tests
1399         assumed a system had. Also fixed a small side-effect from the absolute canonical
1400         path fix in SCMDetector.detect_scm_system
1401         (SVNTestRepository.setup): A relative filepath was previously passed as the
1402         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
1403         an absolute canonical path before being passed in. The failing test
1404         was a "sanity check" that the svn.checkout_root and scm.checkout_root
1405         were the same.
1406         (GitSVNTest._setup_git_checkout):
1407             1) Added "--prefix ''" option to `git clone` since Git changed its default
1408             behavior in version 2.0.
1409             2) The branch master was renamed to trunk to more closely emulate what
1410             tests expected when they were written. 
1411         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
1412         original tests failed because the tests expected the trunk branch
1413         to produce its parent's commit, whereas Git merely provides the HEAD commit
1414         for a given branch (trunk in this case). Based on other tests written
1415         in the same commit, it appears these tests were failing from the point they
1416         were written.
1417
1418 2015-07-14  Anders Carlsson  <andersca@apple.com>
1419
1420         Assertions.h should include ExportMacros.h
1421         https://bugs.webkit.org/show_bug.cgi?id=146948
1422
1423         Reviewed by Tim Horton.
1424
1425         Remove now unneeded WTF_EXPORT_PRIVATE define.
1426
1427         * DumpRenderTree/cg/ImageDiffCG.cpp:
1428
1429 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1430
1431         [GTK] [Wayland] Build by default the X11 and Wayland targets.
1432         https://bugs.webkit.org/show_bug.cgi?id=146057
1433
1434         Reviewed by Carlos Garcia Campos.
1435
1436         * gtk/install-dependencies:
1437
1438 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
1439
1440         [Mac] Unable to dismiss context menu during test runs
1441         https://bugs.webkit.org/show_bug.cgi?id=146836
1442
1443         Reviewed by Tim Horton.
1444
1445         Since Context Menus are modal, the test system would block on the displayed context menu,
1446         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
1447         mouse click and generate the menu contents, but not ask AppKit to display it.
1448
1449         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
1450
1451         * DumpRenderTree/mac/EventSendingController.mm:
1452         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
1453         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1454         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
1455         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
1456         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
1457         work without actually calling on AppKit to display the menu.
1458         ask WebCore to do all the work EXCEPT displaying the menu.
1459         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1460         * WebKitTestRunner/mac/EventSenderProxy.mm:
1461         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
1462
1463 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
1464
1465         It should be possible to run the OSR exit fuzzer
1466         https://bugs.webkit.org/show_bug.cgi?id=146814
1467
1468         Reviewed by Mark Lam.
1469         
1470         This runs a test command to detect how many static OSR exit sites it had, and then for
1471         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
1472         middle opportunity), plus a mode where the check always exits. This is an exhaustive
1473         search, so in the future it'll be very appropriate for cases where we have a simple test
1474         and we want to see what happens when you eventually exit in this test.
1475         
1476         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
1477         and it seems to do the right thing.
1478
1479         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
1480         (fail):
1481
1482 2015-07-10  Alex Christensen  <achristensen@webkit.org>
1483
1484         Add tests for r186649
1485         https://bugs.webkit.org/show_bug.cgi?id=146821
1486
1487         Reviewed by Darin Adler.
1488
1489         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1490         (TestWebKitAPI::TEST_F):
1491         (TestWebKitAPI::compareContents):
1492         (TestWebKitAPI::expectedIndex):
1493         Add some larger tests to test large jumps.
1494
1495 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
1496
1497         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
1498         https://bugs.webkit.org/show_bug.cgi?id=146820
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1503         (OSXBrowserDriver):
1504         (OSXBrowserDriver.close_browsers):
1505         (OSXBrowserDriver._terminiate_processes):
1506         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1507         (OSXChromeDriver):
1508         (OSXChromeCanaryDriver):
1509         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1510         (OSXFirefoxDriver):
1511         (OSXFirefoxNightlyDriver):
1512         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1513         (OSXSafariDriver):
1514
1515 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1516
1517         [GTK] pango should be included in the default jhbuild moduleset
1518         https://bugs.webkit.org/show_bug.cgi?id=146683
1519
1520         Reviewed by Martin Robinson.
1521
1522         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
1523         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
1524         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
1525         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
1526         the same problem again the next time pango wants to use a new fontconfig feature), or remove
1527         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
1528         best.
1529
1530         * gtk/jhbuild-optional.modules: Remove pango
1531         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
1532
1533 2015-07-09  Devin Rousso  <drousso@apple.com>
1534
1535         Unreviewed.  Added myself as a committer.
1536
1537         * Scripts/webkitpy/common/config/contributors.json:
1538
1539 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
1540
1541         Add a way to set the default URL from Minibrowser UI
1542         https://bugs.webkit.org/show_bug.cgi?id=146780
1543
1544         Reviewed by Simon Fraser.
1545
1546         * MiniBrowser/mac/AppDelegate.m:
1547         (-[BrowserAppDelegate didChangeSettings]):
1548         * MiniBrowser/mac/BrowserWindowController.h:
1549         * MiniBrowser/mac/BrowserWindowController.m:
1550         (-[BrowserWindowController fetch:]):
1551         (-[BrowserWindowController reload:]):
1552         (-[BrowserWindowController forceRepaint:]):
1553         (-[BrowserWindowController goBack:]):
1554         (-[BrowserWindowController goForward:]):
1555         (-[BrowserWindowController showHideWebView:]):
1556         (-[BrowserWindowController removeReinsertWebView:]):
1557         (-[BrowserWindowController zoomIn:]):
1558         (-[BrowserWindowController zoomOut:]):
1559         (-[BrowserWindowController resetZoom:]):
1560         (-[BrowserWindowController canZoomIn]):
1561         (-[BrowserWindowController canZoomOut]):
1562         (-[BrowserWindowController canResetZoom]):
1563         (-[BrowserWindowController toggleZoomMode:]):
1564         (-[BrowserWindowController setScale:]):
1565         (-[BrowserWindowController toggleShrinkToFit:]):
1566         (-[BrowserWindowController dumpSourceToConsole:]):
1567         (-[BrowserWindowController find:]):
1568         (-[BrowserWindowController didChangeSettings]):
1569         (-[BrowserWindowController currentURL]):
1570         Get rid of the BrowserController protocol. It was a bad idea and confused
1571         Interface Builder more than I thought possible.
1572
1573         * MiniBrowser/mac/SettingsController.m:
1574         (-[SettingsController _populateMenu]):
1575         (-[SettingsController setDefaultURLToCurrentURL:]):
1576         If we have a BrowserWindowController, grab its URL and set the relevant default.
1577
1578         * MiniBrowser/mac/WK1BrowserWindowController.h:
1579         * MiniBrowser/mac/WK1BrowserWindowController.m:
1580         (-[WK1BrowserWindowController currentURL]):
1581         * MiniBrowser/mac/WK2BrowserWindowController.h:
1582         * MiniBrowser/mac/WK2BrowserWindowController.m:
1583         (-[WK2BrowserWindowController currentURL]):
1584         Retrieve the current URL from the WKView/WebView.
1585
1586 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
1587
1588         Increase MiniBrowser location bar maximum width
1589         https://bugs.webkit.org/show_bug.cgi?id=146779
1590
1591         Reviewed by Simon Fraser.
1592
1593         * MiniBrowser/mac/BrowserWindow.xib:
1594         Have an enormous maximum width on the location bar, so that it doesn't
1595         stop expanding with the window at 800px.
1596
1597 2015-07-08  Brady Eidson  <beidson@apple.com>
1598
1599         Crash calling [WebView close] in didFinishLoadForFrame callback.
1600         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
1601
1602         Reviewed by David Kilzer.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         
1606         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
1607         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
1608         (TestWebKitAPI::TEST):
1609
1610 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1611
1612         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
1613         https://bugs.webkit.org/show_bug.cgi?id=146546
1614
1615         Reviewed by Darin Adler.
1616
1617         We did't reset pendingNavigationID value when request url is empty.
1618         Hence we need to ignore ASSERT check in this case.
1619
1620         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1621         (TestWebKitAPI::TEST):
1622
1623 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
1624
1625         [Content Extensions] Fuse undistinguishable actions as much as possible
1626         https://bugs.webkit.org/show_bug.cgi?id=146762
1627
1628         Reviewed by Alex Christensen.
1629
1630         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1631         Test that combinations and flags still work as expected.
1632
1633 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1634
1635         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
1636         https://bugs.webkit.org/show_bug.cgi?id=146056
1637
1638         Reviewed by Martin Robinson.
1639
1640         * gtk/install-dependencies: libepoxy is now required for building GTK+.
1641         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
1642         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
1643         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
1644         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
1645         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
1646         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
1647         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
1648
1649 2015-07-06  Matt Rajca  <mrajca@apple.com>
1650
1651         Media Session: propagate metadata changes to UI clients
1652         https://bugs.webkit.org/show_bug.cgi?id=146660
1653
1654         Reviewed by Tim Horton.
1655
1656         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
1657         (WTR::TestController::createOtherPage):
1658         (WTR::TestController::createWebViewWithOptions):
1659
1660 2015-07-07  Brady Eidson  <beidson@apple.com>
1661
1662         HTTP Auth cached after disabling private browsing/reset.
1663         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
1664
1665         Reviewed by Tim Horton.
1666
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
1669
1670 2015-07-06  Alex Christensen  <achristensen@webkit.org>
1671
1672         [Content Extensions] Remove memory page reporting
1673         https://bugs.webkit.org/show_bug.cgi?id=146659
1674
1675         Reviewed by Benjamin Poulain.
1676
1677         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1678         (TestWebKitAPI::TEST_F):
1679
1680 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
1681
1682         [Content Extensions] Make the DFA transitions ranges instead of characters
1683         https://bugs.webkit.org/show_bug.cgi?id=146575
1684
1685         Reviewed by Alex Christensen.
1686
1687         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1688         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1689         Since the minimizer is perfect, we get the minimal solution now,
1690         which is really cool!
1691
1692 2015-07-06  Brady Eidson  <beidson@apple.com>
1693
1694         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
1695         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
1696
1697         Reviewed by Geoff Garen.
1698
1699         * WebKitTestRunner/TestInvocation.cpp:
1700         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
1701           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
1702
1703 2015-07-06  Daniel Bates  <dabates@apple.com>
1704
1705         Unreviewed, rolling out r170639.
1706
1707         Broke using webkit-patch apply-attachment to apply an
1708         attachment from a security bug. The patch incorrectly assumed
1709         that Bugzilla returns a non-HTTP 200 status code in its HTTP
1710         response when authentication is required.
1711
1712         Reverted changeset:
1713
1714         "webkit-patch apply-from-bug / apply-attachment should not ask
1715         for credentials if none are required"
1716         https://bugs.webkit.org/show_bug.cgi?id=40095
1717         http://trac.webkit.org/changeset/170639
1718
1719 2015-07-04  Chris Dumez  <cdumez@apple.com>
1720
1721         Drop RefPtr::clear() method
1722         https://bugs.webkit.org/show_bug.cgi?id=146556
1723
1724         Reviewed by Brady Eidson.
1725
1726         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
1727
1728 2015-07-03  Dan Bernstein  <mitz@apple.com>
1729
1730         Fixed the iOS build.
1731
1732         * DumpRenderTree/mac/EventSendingController.mm:
1733         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1734         (+[EventSendingController webScriptNameForSelector:]):
1735
1736 2015-07-03  Dan Bernstein  <mitz@apple.com>
1737
1738         [Xcode] Update some build settings as recommended by Xcode 7
1739         https://bugs.webkit.org/show_bug.cgi?id=146597
1740
1741         Reviewed by Sam Weinig.
1742
1743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
1744
1745         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
1746         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
1747         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
1748         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
1749         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
1750
1751         * DumpRenderTree/mac/EventSendingController.mm:
1752         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
1753         which was removed in r19101.
1754
1755         * DumpRenderTree/mac/TextInputController.m:
1756         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
1757         around used of a selector not that is not declared anywhere.
1758
1759         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
1760
1761         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
1762
1763         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
1764         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
1765         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
1766         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
1767         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
1768
1769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
1770
1771 2015-07-02  Daniel Bates  <dabates@apple.com>
1772
1773         [iOS] Add WebKitSystemInterface for iOS 8.4
1774         https://bugs.webkit.org/show_bug.cgi?id=146548
1775
1776         Rubber-stamped by Zalan Bujtas.
1777
1778         * Scripts/copy-webkitlibraries-to-product-directory:
1779
1780 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
1783         https://bugs.webkit.org/show_bug.cgi?id=146234
1784
1785         Reviewed by Sergio Villar Senin.
1786
1787         Enable the WebSQL directory test that was disabled because of this bug.
1788
1789         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1790         (testWebContextConfiguration):
1791
1792 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
1793
1794         Enabled MEDIA_STREAM flag
1795         https://bugs.webkit.org/show_bug.cgi?id=145947
1796         <rdar://problem/21365829>
1797         
1798         Reviewed by Eric Carlson.
1799
1800         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1801
1802 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
1803
1804         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
1805         https://bugs.webkit.org/show_bug.cgi?id=144828
1806
1807         Reviewed by Carlos Garcia Campos.
1808
1809         * WebKitTestRunner/gtk/main.cpp:
1810         (main): Use the new WKTextChecker API to set the spell checking languages
1811         when the process is starting up.
1812
1813 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
1814
1815         Implement ECMAScript Internationalization API
1816         https://bugs.webkit.org/show_bug.cgi?id=90906
1817
1818         Reviewed by Benjamin Poulain.
1819
1820         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
1821
1822 2015-06-30  Jonathan Davis  <jond@apple.com>
1823
1824         Unreviewed. Added myself as a committer.
1825
1826         * Scripts/webkitpy/common/config/contributors.json:
1827
1828 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
1829
1830         Unreviewed build fix.
1831
1832         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
1833         to developer.apple.com to get update libraries.
1834
1835 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
1836
1837         Add timeout in run-webkit-tests for launching the simulator
1838         https://bugs.webkit.org/show_bug.cgi?id=146371
1839
1840         Reviewed by Darin Adler.
1841
1842         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
1843         for the otherwise infinitely patient wait_until_device_is_in_state method.
1844
1845         * Scripts/webkitpy/xcode/simulator.py:
1846         (Simulator.DeviceState):
1847         (Simulator):
1848         (Simulator.wait_until_device_is_in_state):
1849         (Simulator.device_state):
1850
1851 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
1852
1853         Make the NFA transitions range-based
1854         https://bugs.webkit.org/show_bug.cgi?id=146338
1855
1856         Reviewed by Alex Christensen.
1857
1858         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1859         Test some new interesting cases.
1860
1861 2015-06-28  Dan Bernstein  <mitz@apple.com>
1862
1863         [Xcode] Use the same environment for command-line and IDE builds
1864         https://bugs.webkit.org/show_bug.cgi?id=146401
1865
1866         Reviewed by Anders Carlsson.
1867
1868         * Scripts/webkitdirs.pm:
1869         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
1870         xcodebuild use the same environment Xcode uses.
1871
1872 2015-06-28  Dan Bernstein  <mitz@apple.com>
1873
1874         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
1875         https://bugs.webkit.org/show_bug.cgi?id=146396
1876
1877         Reviewed by Anders Carlsson.
1878
1879         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1880         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
1881         (TestWebKitAPI::TEST): Updated for renames.
1882         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1883         (runJavaScriptAlert): Removed suffix.
1884         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
1885         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1886         (runJavaScriptAlert): Removed suffix.
1887         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
1888
1889 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1890
1891         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
1892         https://bugs.webkit.org/show_bug.cgi?id=146318
1893
1894         Reviewed by Sergio Villar Senin.
1895
1896         Copy mac PublicSuffix test to the common directory and add it to
1897         the GTK+ build.
1898
1899         * TestWebKitAPI/PlatformGTK.cmake:
1900         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
1901         (TestWebKitAPI::TEST_F):
1902
1903 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
1904
1905         WinLauncher fails to download files.
1906         https://bugs.webkit.org/show_bug.cgi?id=146242
1907
1908         Reviewed by Alex Christensen.
1909
1910         Added WinLauncher download delegate.
1911
1912         * WinLauncher/Common.cpp:
1913         * WinLauncher/WebDownloadDelegate.cpp: Added.
1914         (WebDownloadDelegate::WebDownloadDelegate):
1915         (WebDownloadDelegate::~WebDownloadDelegate):
1916         (WebDownloadDelegate::QueryInterface):
1917         (WebDownloadDelegate::AddRef):
1918         (WebDownloadDelegate::Release):
1919         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
1920         (WebDownloadDelegate::didCancelAuthenticationChallenge):
1921         (WebDownloadDelegate::didCreateDestination):
1922         (WebDownloadDelegate::didFailWithError):
1923         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
1924         (WebDownloadDelegate::didReceiveDataOfLength):
1925         (WebDownloadDelegate::didReceiveResponse):
1926         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
1927         (WebDownloadDelegate::willResumeWithResponse):
1928         (WebDownloadDelegate::willSendRequest):
1929         (WebDownloadDelegate::didBegin):
1930         (WebDownloadDelegate::didFinish):
1931         * WinLauncher/WebDownloadDelegate.h: Added.
1932         * WinLauncher/WinLauncher.cpp:
1933         (WinLauncher::setAccessibilityDelegate):
1934         (WinLauncher::setResourceLoadDelegate):
1935         (WinLauncher::setDownloadDelegate):
1936         (WinLauncher::mainFrame):
1937         * WinLauncher/WinLauncher.h:
1938         (WinLauncher::standardPreferences):
1939         (WinLauncher::privatePreferences):
1940         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1941         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1942         * WinLauncher/WinMain.cpp:
1943         (wWinMain):
1944
1945 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
1946
1947         [EFL] Bump libseccomp version to 2.2.1
1948         https://bugs.webkit.org/show_bug.cgi?id=146341
1949
1950         Reviewed by Gyuyoung Kim.
1951
1952         * efl/jhbuild.modules:
1953         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
1954         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
1955
1956 2015-06-25  Alex Christensen  <achristensen@webkit.org>
1957
1958         [Content Extensions] Add a way to match a domain but not subdomains
1959         https://bugs.webkit.org/show_bug.cgi?id=146241
1960         rdar://problem/21557754
1961
1962         Reviewed by Darin Adler.
1963
1964         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1965         (TestWebKitAPI::TEST_F):
1966         Update subdomain test because of changed behavior and add test for new '*' functionality.
1967
1968 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
1969
1970         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
1971         https://bugs.webkit.org/show_bug.cgi?id=146308
1972
1973         Reviewed by Csaba Osztrogonác.
1974
1975         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
1976
1977         * Scripts/webkitperl/FeatureList.pm:
1978
1979 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1980
1981         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
1982         https://bugs.webkit.org/show_bug.cgi?id=146149
1983
1984         Reviewed by Sergio Villar Senin.
1985
1986         Update unit tests to use WebKitWebsiteDataManager.
1987
1988         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1989         (testWebContextConfiguration):
1990         (serverCallback):
1991         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1992         (Test::Test): Use WebKitWebsiteDataManager and set all possible
1993         values to ensure unit tests don't write outside the temporary directory.
1994         (Test::~Test): Explicitly reset the web context to ensure its
1995         objects are released before the leaks check.
1996         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1997         (WebViewTest::wait): Fix the GSource used, since we are receiving
1998         a double in seconds, but using g_timeout_add_seconds() that
1999         expects an unsigned in seconds. Use GMainLoopSource to correctly
2000         handle the value and simplify the code.
2001
2002 2015-06-24  Jason Marcell  <jmarcell@apple.com>
2003
2004         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
2005         https://bugs.webkit.org/show_bug.cgi?id=146126
2006         <rdar://problem/18226291>
2007
2008         Reviewed by Alexey Proskuryakov.
2009
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2011         (documentReady): Using combined queues to display iOS projects
2012
2013 2015-06-24  Doug Russell  <d_russell@apple.com>
2014
2015         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
2016         when posting a selection notification when on the border between two accessibilityObjects
2017         https://bugs.webkit.org/show_bug.cgi?id=146177
2018
2019         Reviewed by Darin Adler.
2020
2021         Add support for mapping WebCore Accessibility types into JSValueRef types
2022         so they can be used in tests.
2023
2024         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2025         (webAccessibilityObjectWrapperClass):
2026         (-[AccessibilityNotificationHandler startObserving]):
2027         (makeValueRefForValue):
2028         (makeArrayRefForArray):
2029         (makeObjectRefForDictionary):
2030         (-[AccessibilityNotificationHandler _notificationReceived:]):
2031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2032         (webAccessibilityObjectWrapperClass):
2033         (-[AccessibilityNotificationHandler startObserving]):
2034         (makeValueRefForValue):
2035         (makeArrayRefForArray):
2036         (makeObjectRefForDictionary):
2037         (-[AccessibilityNotificationHandler _notificationReceived:]):
2038
2039 2015-06-24  Zalan Bujtas  <zalan@apple.com>
2040
2041         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
2042         https://bugs.webkit.org/show_bug.cgi?id=146273
2043         rdar://problem/18509840
2044
2045         Reviewed by Simon Fraser.
2046
2047         Due to the floating point approximate representation, we can't always produce
2048         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
2049         and by changing the rounding in roundToDevicePixel() from float to double.
2050
2051         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2052         (TestWebKitAPI::TEST):
2053
2054 2015-06-24  Brady Eidson  <beidson@apple.com>
2055
2056         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
2057         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
2058
2059         Reviewed by Alex Christensen.
2060
2061         - Update WKTR to the new client structure.
2062         - Update existing TestWebKitAPI tests to either use the new client structure or
2063           assign the old function signature to the updated variable name.
2064         - Include a new test.
2065
2066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2067
2068         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2069         (TestWebKitAPI::runJavaScriptAlert):
2070
2071         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2072         (TestWebKitAPI::TEST):
2073
2074         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2075         (TestWebKitAPI::analyzeDialogArguments):
2076         (TestWebKitAPI::runJavaScriptAlert):
2077         (TestWebKitAPI::runJavaScriptConfirm):
2078         (TestWebKitAPI::runJavaScriptPrompt):
2079         (TestWebKitAPI::createNewPage):
2080         (TestWebKitAPI::TEST):
2081
2082         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2083         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2084
2085         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2086         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2087
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::TestController::createOtherPage):
2090         (WTR::TestController::createWebViewWithOptions):
2091
2092 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
2093
2094         Refactoring benchmark runner script to follow pep8 code style.
2095         https://bugs.webkit.org/show_bug.cgi?id=146264
2096
2097         Reviewed by Ryosuke Niwa.
2098
2099         Refactor benchmark runner script to follow pep8 code style.
2100
2101         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2102         (GenericBenchmarkBuilder.prepare):
2103         (GenericBenchmarkBuilder._run_create_script):
2104         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
2105         (GenericBenchmarkBuilder._fetch_remote_archive):
2106         (GenericBenchmarkBuilder):
2107         (GenericBenchmarkBuilder._checkout_with_subversion):
2108         (GenericBenchmarkBuilder._apply_patch):
2109         (GenericBenchmarkBuilder.clean):
2110         (GenericBenchmarkBuilder._runCreateScript): Deleted.
2111         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
2112         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
2113         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
2114         (GenericBenchmarkBuilder._applyPatch): Deleted.
2115         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2116         (BenchmarkRunner.__init__):
2117         (BenchmarkRunner._find_plan_file):
2118         (BenchmarkRunner.execute):
2119         (BenchmarkRunner._cleanup):
2120         (BenchmarkRunner._dump):
2121         (BenchmarkRunner._wrap):
2122         (BenchmarkRunner._merge):
2123         (BenchmarkRunner._show_results):
2124         (BenchmarkRunner._findPlanFile): Deleted.
2125         (BenchmarkRunner.cleanup): Deleted.
2126         (BenchmarkRunner.dump): Deleted.
2127         (BenchmarkRunner.wrap): Deleted.
2128         (BenchmarkRunner.merge): Deleted.
2129         (BenchmarkRunner.show_results): Deleted.
2130         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2131         (BrowserDriver.prepare_env):
2132         (BrowserDriver.launch_url):
2133         (BrowserDriver.close_browsers):
2134         (BrowserDriver.prepareEnv): Deleted.
2135         (BrowserDriver.launchUrl): Deleted.
2136         (BrowserDriver.closeBrowser): Deleted.
2137         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2138         (OSXBrowserDriver):
2139         (OSXBrowserDriver.prepare_env):
2140         (OSXBrowserDriver.close_browsers):
2141         (OSXBrowserDriver._launch_process):
2142         (OSXBrowserDriver._terminiate_processes):
2143         (OSXBrowserDriver._launch_process_with_caffinate):
2144         (OSXBrowserDriver._screen_size):
2145         (OSXBrowserDriver.prepareEnv): Deleted.
2146         (OSXBrowserDriver.closeBrowsers): Deleted.
2147         (OSXBrowserDriver.launchProcess): Deleted.
2148         (OSXBrowserDriver.terminateProcesses): Deleted.
2149         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
2150         (OSXBrowserDriver.screenSize): Deleted.
2151         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2152         (OSXChromeDriver):
2153         (OSXChromeDriver.launch_url):
2154         (OSXChromeCanaryDriver):
2155         (OSXChromeCanaryDriver.launch_url):
2156         (OSXChromeDriver.launchUrl): Deleted.
2157         (OSXChromeCanaryDriver.launchUrl): Deleted.
2158         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2159         (OSXFirefoxDriver):
2160         (OSXFirefoxDriver.launch_url):
2161         (OSXFirefoxNightlyDriver):
2162         (OSXFirefoxNightlyDriver.launch_url):
2163         (OSXFirefoxDriver.launchUrl): Deleted.
2164         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
2165         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2166         (OSXSafariDriver):
2167         (OSXSafariDriver.prepare_env):
2168         (OSXSafariDriver.launch_url):
2169         (OSXSafariDriver.close_browsers):
2170         (OSXSafariDriver._maximize_window):
2171         (OSXSafariDriver.prepareEnv): Deleted.
2172         (OSXSafariDriver.launchUrl): Deleted.
2173         (OSXSafariDriver.closeBrowsers): Deleted.
2174         (OSXSafariDriver.maximizeWindow): Deleted.
2175         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2176         (HTTPServerDriver.fetch_result):
2177         (HTTPServerDriver.kill_server):
2178         (HTTPServerDriver.get_return_code):
2179         (HTTPServerDriver.set_device_id):
2180         (HTTPServerDriver.fetchResult): Deleted.
2181         (HTTPServerDriver.killServer): Deleted.
2182         (HTTPServerDriver.getReturnCode): Deleted.
2183         (HTTPServerDriver.setDeviceID): Deleted.
2184         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2185         (SimpleHTTPServerDriver.serve):
2186         (SimpleHTTPServerDriver.base_url):
2187         (SimpleHTTPServerDriver.fetch_result):
2188         (SimpleHTTPServerDriver.kill_server):
2189         (SimpleHTTPServerDriver.get_return_code):
2190         (SimpleHTTPServerDriver): Deleted.
2191         (SimpleHTTPServerDriver.baseUrl): Deleted.
2192         (SimpleHTTPServerDriver.fetchResult): Deleted.
2193         (SimpleHTTPServerDriver.killServer): Deleted.
2194         (SimpleHTTPServerDriver.getReturnCode): Deleted.
2195         * Scripts/webkitpy/benchmark_runner/utils.py:
2196         (get_path_from_project_root):
2197         (force_remove):
2198         (getPathFromProjectRoot): Deleted.
2199         (forceRemove): Deleted.
2200
2201 2015-06-23  Anders Carlsson  <andersca@apple.com>
2202
2203         Add operator! and copy/move constructors to WeakObjCPtr
2204         https://bugs.webkit.org/show_bug.cgi?id=146255
2205
2206         Reviewed by Andreas Kling.
2207
2208         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2209         (TEST):
2210
2211 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
2212
2213         Expose some more rendering progress events, and have MiniBrowser log for each of them
2214         https://bugs.webkit.org/show_bug.cgi?id=146227
2215
2216         Reviewed by Darin Adler.
2217
2218         Register for layout milestones/rendering progress events in the WK1 and WK2
2219         browser window controllers, and, if logging is turned on, log when they are
2220         reached.
2221
2222         * MiniBrowser/mac/WK1BrowserWindowController.m:
2223         (-[WK1BrowserWindowController awakeFromNib]):
2224         (-[WK1BrowserWindowController webView:didLayout:]):
2225         * MiniBrowser/mac/WK2BrowserWindowController.m:
2226         (-[WK2BrowserWindowController awakeFromNib]):
2227         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
2228
2229 2015-06-23  Brady Eidson  <beidson@apple.com>
2230
2231         WKFrameInfo should have an accessor for the Frame's current security origin.
2232         https://bugs.webkit.org/show_bug.cgi?id=146162
2233
2234         Reviewed by Dan Bernstein.
2235
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
2238         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
2239         (sawDialog):
2240         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2241         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2242         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2243         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2244         (TEST):
2245
2246 2015-06-23  Tanay C  <tanay.c@samsung.com>
2247
2248         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
2249         https://bugs.webkit.org/show_bug.cgi?id=146007
2250
2251         Reviewed by Darin Adler.
2252
2253         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2254         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
2255         (pluginLogWithWindowObject):
2256         (pluginLogWithArguments):
2257         (pluginLog):
2258         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
2259         (PluginTest::executeScript):
2260         (PluginTest::log):
2261
2262 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
2263
2264         [EFL] Add libhyphen-dev as dependency after r185862
2265         https://bugs.webkit.org/show_bug.cgi?id=146230
2266
2267         Reviewed by Gyuyoung Kim.
2268
2269         * efl/install-dependencies:
2270
2271 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
2272
2273         [EFL] Hyphenation is not supported
2274         https://bugs.webkit.org/show_bug.cgi?id=89830
2275
2276         Reviewed by Gyuyoung Kim.
2277
2278         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
2279
2280 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
2281
2282         Get rid of factory json files in benchmark_runner
2283         https://bugs.webkit.org/show_bug.cgi?id=146175
2284
2285         Reviewed by Ryosuke Niwa.
2286
2287         Get rid of factory json files in benchmark_runner and refactoring the code.
2288
2289         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
2290         (benchmark_builder_loader):
2291         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
2292         (BenchmarkBuilderFactory):
2293         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
2294         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2295         (GenericBenchmarkBuilder):
2296         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2297         (BenchmarkRunner.__init__):
2298         (BenchmarkRunner.execute):
2299         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
2300         (browser_driver_loader):
2301         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2302         (BrowserDriver):
2303         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2304         (BrowserDriverFactory):
2305         (BrowserDriverFactory.available_platforms):
2306         (BrowserDriverFactory.available_browsers):
2307         (BrowserDriverFactory.add_browser_driver):
2308         (BrowserDriverFactory.create):
2309         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
2310         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2311         (OSXBrowserDriver):
2312         (OSXBrowserDriver.prepareEnv):
2313         (OSXBrowserDriver.terminateProcesses):
2314         (OSXBrowserDriver.screenSize):
2315         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2316         (OSXChromeDriver):
2317         (OSXChromeCanaryDriver):
2318         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2319         (OSXFirefoxDriver):
2320         (OSXFirefoxNightlyDriver):
2321         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2322         (OSXSafariDriver):
2323         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
2324         (GenericFactory.create):
2325         (GenericFactory.add):
2326         (GenericFactory.iterateGetItem): Deleted.
2327         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2328         (http_server_driver_loader):
2329         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2330         (HTTPServerDriver):
2331         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
2332         (HTTPServerDriverFactory):
2333         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
2334         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2335         (SimpleHTTPServerDriver):
2336         * Scripts/webkitpy/benchmark_runner/utils.py:
2337         (is_subclass):
2338         (load_subclasses):
2339         (ModuleNotFoundError): Deleted.
2340         (loadModule): Deleted.
2341         (loadJSONFromFile): Deleted.
2342
2343 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
2344
2345         Make it possible to enable incremental rendering suppression in MiniBrowser
2346         https://bugs.webkit.org/show_bug.cgi?id=146223
2347         
2348         Reviewed by Tim Horton.
2349
2350         Add a menu item to enable incremental rendering suppression to MiniBrowser.
2351         
2352         For WK1, this just toggles a pref, and takes effect immediately.
2353         
2354         For WK2, this is a WKConfiguration property, so only affects new web views.
2355         
2356         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
2357         logging on launch.
2358
2359         * MiniBrowser/mac/AppDelegate.m:
2360         (defaultConfiguration):
2361         * MiniBrowser/mac/BrowserWindow.xib:
2362         * MiniBrowser/mac/SettingsController.h:
2363         * MiniBrowser/mac/SettingsController.m:
2364         (-[SettingsController _populateMenu]):
2365         (-[SettingsController validateMenuItem:]):
2366         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
2367         (-[SettingsController incrementalRenderingSuppressed]):
2368         * MiniBrowser/mac/WK1BrowserWindowController.m:
2369         (-[WK1BrowserWindowController didChangeSettings]):
2370
2371 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
2372
2373         Run CDjs as part of JSC stress testing
2374         https://bugs.webkit.org/show_bug.cgi?id=146174
2375
2376         Reviewed by Geoffrey Garen.
2377
2378         * Scripts/run-javascriptcore-tests:
2379         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
2380         * Scripts/run-jsc-stress-tests:
2381         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
2382         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
2383         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
2384
2385 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
2386
2387         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
2388         https://bugs.webkit.org/show_bug.cgi?id=146121
2389         rdar://problem/21395180
2390
2391         Reviewed by Darin Adler.
2392
2393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2394         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
2395         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
2396         (TestWebKitAPI::overrideAppleLanguages):
2397         (TestWebKitAPI::languageForSystemLanguage):
2398         (TestWebKitAPI::TEST):
2399
2400 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2401
2402         [CMake] Ignore warnings from system headers when compiling Tools
2403         https://bugs.webkit.org/show_bug.cgi?id=146185
2404
2405         Reviewed by Martin Robinson.
2406
2407         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
2408         from system headers that we don't control.
2409
2410         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2411         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
2412         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
2413         * ImageDiff/PlatformGTK.cmake:
2414         * MiniBrowser/efl/CMakeLists.txt:
2415         * MiniBrowser/gtk/CMakeLists.txt:
2416         * TestWebKitAPI/PlatformEfl.cmake:
2417         * TestWebKitAPI/PlatformGTK.cmake:
2418         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2419         * WebKitTestRunner/CMakeLists.txt:
2420         * WebKitTestRunner/PlatformEfl.cmake:
2421         * WebKitTestRunner/PlatformGTK.cmake:
2422
2423 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2424
2425         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
2426         https://bugs.webkit.org/show_bug.cgi?id=146186
2427
2428         Reviewed by Martin Robinson.
2429
2430         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
2431         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
2432
2433         * MiniBrowser/gtk/CMakeLists.txt:
2434
2435 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Build fix after r146125.
2438
2439         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2440         (OSXSafariDriver):
2441         (OSXSafariDriver.prepareEnv):
2442
2443 2015-06-19  Brady Eidson  <beidson@apple.com>
2444
2445         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
2446         https://bugs.webkit.org/show_bug.cgi?id=146152
2447
2448         Reviewed by Dan Bernstein.
2449
2450         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2451         * WebKitTestRunner/WebNotificationProvider.cpp:
2452
2453 2015-06-19  Mark Lam  <mark.lam@apple.com>
2454
2455         CheckedArithmetic's operator bool() and operator==() is broken.
2456         https://bugs.webkit.org/show_bug.cgi?id=146129
2457
2458         Reviewed by Geoffrey Garen and Oliver Hunt.
2459
2460         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
2461         and overflow scenarios in usage of the Checked arithmetic class.
2462
2463         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2464         (TestWebKitAPI::OverflowCrashLogger::overflowed):
2465         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
2466         (TestWebKitAPI::OverflowCrashLogger::crash):
2467         (TestWebKitAPI::OverflowCrashLogger::reset):
2468         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
2469         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
2470         (TestWebKitAPI::OverflowCrashLogger::didCrash):
2471         - crash logger for verifying that a crash occurs when expected. 
2472
2473         (TestWebKitAPI::resetOverflow):
2474         - convenience function for resetting a test value to an initial overflowed state
2475           before a crash.  We will use this value in the overflow testing.
2476
2477         (TestWebKitAPI::CheckedArithmeticTester::run):
2478         - Added new tests for all the comparison operators.
2479
2480 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
2481
2482         Fix the Windows build after r185721
2483         https://bugs.webkit.org/show_bug.cgi?id=146146
2484
2485         Reviewed by Csaba Osztrogonác.
2486
2487         Speculative buildfix.
2488
2489         * DumpRenderTree/win/UIDelegate.h:
2490         (UIDelegate::unused4): Added.
2491         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
2492
2493 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
2494
2495         Unreviewed. Add myself as a committer.
2496
2497         * Scripts/webkitpy/common/config/contributors.json:
2498
2499 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2500
2501         Remove unnecessary svn:executable flags
2502         https://bugs.webkit.org/show_bug.cgi?id=146107
2503
2504         Reviewed by Alexey Proskuryakov.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
2511         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
2512         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
2513         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
2514         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
2515         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
2516         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
2517         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
2518         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
2519         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
2520
2521 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2522
2523         Disable tests on the WinCairo buildbot
2524         https://bugs.webkit.org/show_bug.cgi?id=146106
2525
2526         Reviewed by Alexey Proskuryakov.
2527
2528         * BuildSlaveSupport/build.webkit.org-config/config.json:
2529         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2530
2531 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
2532
2533         [EFL] Fix the minibrowser after r185725
2534         https://bugs.webkit.org/show_bug.cgi?id=146135
2535
2536         Reviewed by Gyuyoung Kim.
2537
2538         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
2539         for the elm_config_accel_preference_set() to set the config of acceleration preference.
2540
2541         * MiniBrowser/efl/main.c:
2542         (elm_main): Deleted the HAVE_ECORE_X guard.
2543
2544 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
2545
2546         Extend capability of run-benchmark script to support mobile device
2547         https://bugs.webkit.org/show_bug.cgi?id=146125
2548
2549         Reviewed by Ryosuke Niwa.
2550
2551         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
2552         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
2553
2554         * Scripts/run-benchmark:
2555         (main): Deleted.
2556         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2557         (BenchmarkRunner.__init__):
2558         (BenchmarkRunner.execute):
2559         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2560         (BrowserDriver.prepareEnv):
2561         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2562         (OSXBrowserDriver.prepareEnv):
2563         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2564         (OSXSafariDriver.prepareEnv):
2565         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2566         (HTTPServerDriver.getReturnCode):
2567         (HTTPServerDriver):
2568         (HTTPServerDriver.setDeviceID):
2569         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
2570         (parse_args):
2571         (start):
2572         (main):
2573         * Scripts/webkitpy/benchmark_runner/utils.py:
2574         (getPathFromProjectRoot):
2575
2576 2015-06-18  Jon Lee  <jonlee@apple.com>
2577
2578         Unreviewed. Add Matt Daiter as a contributor.
2579
2580         * Scripts/webkitpy/common/config/contributors.json:
2581
2582 2015-06-18  Mark Lam  <mark.lam@apple.com>
2583
2584         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
2585         https://bugs.webkit.org/show_bug.cgi?id=146103
2586
2587         Not reviewed.
2588
2589         Follow up to fix some typos not caught before original patch was landed.
2590
2591         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2592         (TestWebKitAPI::CheckedArithmeticTester::run):
2593         (TestWebKitAPI::AllowMixedSignednessTest::run):
2594         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
2595
2596 2015-06-18  Daniel Bates  <dabates@apple.com>
2597
2598         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
2599         https://bugs.webkit.org/show_bug.cgi?id=146082
2600
2601         Reviewed by Darin Adler.
2602
2603         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
2604         working directory after being invoked in a different Git checkout. In particular,
2605         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
2606         a pure Git checkout g will fail to update g.
2607
2608         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
2609         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
2610         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
2611         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
2612         different than the current working directory). Instead runGitUpdate() should check
2613         whether the current working directory is a Git SVN checkout on each invocation.
2614
2615         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
2616         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
2617         SVN directory from isGitSVN().
2618         (isGitSVN): Implemented in terms of isGitSVNDirectory().
2619         * Scripts/webkitdirs.pm:
2620         (runGitUpdate): Modified to use isGitSVNDirectory().
2621
2622 2015-06-18  Mark Lam  <mark.lam@apple.com>
2623
2624         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
2625         https://bugs.webkit.org/show_bug.cgi?id=146103
2626
2627         Reviewed by Anders Carlsson.
2628
2629         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
2630         part of a large macro.  This makes them harder to:
2631
2632         1. write: no editor help with indentations, have to add trailing '\'s,
2633            inconvenient to add line breaks and comments.
2634
2635         2. read: no chroma coding / syntax highlighting.
2636
2637         3. debug: compile time errors are reported as being on the single line where
2638            the macro is used.
2639
2640         Refactoring the tests to use C++ templates solves all these issues.
2641
2642         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2643         (TestWebKitAPI::CheckedArithmeticTester::run):
2644         (TestWebKitAPI::AllowMixedSignednessTest::run):
2645         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
2646         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
2647         (TestWebKitAPI::CoerceLiteralNop::coerce):
2648
2649 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2650
2651         [EFL][WK2] Use Web Browser cache model in MiniBrowser
2652         https://bugs.webkit.org/show_bug.cgi?id=112273
2653
2654         Reviewed by Laszlo Gombos.
2655
2656         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
2657         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
2658         This way we have a decent cache capacity and the page cache actually works.
2659
2660         * MiniBrowser/efl/main.c:
2661         (elm_main):
2662
2663 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2664
2665         Remove redundant Chromium bug keyword
2666         https://bugs.webkit.org/show_bug.cgi?id=146097
2667
2668         Reviewed by Csaba Osztrogonác.
2669
2670         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2671         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
2672         (TestExpectationLine._format_line): Deleted.
2673
2674 2015-06-17  Daniel Bates  <dabates@apple.com>
2675
2676         Client may receive began editing callback for already focused text field
2677         https://bugs.webkit.org/show_bug.cgi?id=146074
2678         <rdar://problem/21293562>
2679
2680         Reviewed by Darin Adler.
2681
2682         Add a unit test to ensure that a client receives exactly one began editing
2683         callback when a text field is newly focused. In particular, dispatching
2684         a DOM focus event at an already focused text field does not dispatch a
2685         began editing callback to the client.
2686
2687         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
2688         (TestWebKitAPI::TEST_F):
2689
2690 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2691
2692         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
2693         https://bugs.webkit.org/show_bug.cgi?id=26481
2694
2695         Reviewed by Darin Adler.
2696
2697         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
2698
2699         * DumpRenderTree/win/TestRunnerWin.cpp:
2700         (TestRunner::dispatchPendingLoadRequests):
2701         (TestRunner::overridePreference):
2702
2703 2015-06-17  Alex Christensen  <achristensen@webkit.org>
2704
2705         [Content Extensions] Fail to parse invalid arrays
2706         https://bugs.webkit.org/show_bug.cgi?id=146079
2707         rdar://problem/21422649
2708
2709         Reviewed by Benjamin Poulain.
2710
2711         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2712         (TestWebKitAPI::TEST_F):
2713         Correct and add parsing tests with invalid arrays.
2714
2715 2015-06-17  Matt Rajca  <mrajca@apple.com>
2716
2717         Unreviewed. Added myself as a committer.
2718
2719         * Scripts/webkitpy/common/config/contributors.json:
2720
2721 2015-06-17  Daniel Bates  <dabates@apple.com>
2722
2723         Export VCSUtils::gitTreeDirectory()
2724         <rdar://problem/21248901>
2725
2726         Rubber-stamped by Alexey Proskuryakov.
2727
2728         * Scripts/VCSUtils.pm:
2729
2730 2015-06-17  Tim Horton  <timothy_horton@apple.com>
2731
2732         Safari tabs still have shrunken content after coming out of fullscreen
2733         https://bugs.webkit.org/show_bug.cgi?id=146037
2734         <rdar://problem/21105960>
2735
2736         Reviewed by Simon Fraser and Darin Adler.
2737
2738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2739         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
2740         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
2741         (TEST):
2742         Add a test that ensures that disabling scale-to-fit mode correctly updates
2743         the page's layout.
2744
2745 2015-06-17  Dan Bernstein  <mitz@apple.com>
2746
2747         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
2748         https://bugs.webkit.org/show_bug.cgi?id=145957
2749
2750         Reviewed by Darin Adler.
2751
2752         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2753         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
2754
2755 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
2756
2757         AX:  iOS accessibility tests are not running because we need WKTR support
2758         https://bugs.webkit.org/show_bug.cgi?id=145991
2759
2760         Reviewed by Daniel Bates.
2761
2762         Add support for WKTR iOS accessibility.
2763         Utilize the notification handling mechanisms that Mac already uses.
2764         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
2765
2766         * DumpRenderTree/AccessibilityUIElement.cpp:
2767         (stringForSelectionCallback):
2768         (getIdentifierCallback):
2769         (getTraitsCallback):
2770         (getElementTextPositionCallback):
2771         (getElementTextLengthCallback):
2772         (AccessibilityUIElement::getJSClass):
2773         (getIPhoneLabelCallback): Deleted.
2774         (getIPhoneHintCallback): Deleted.
2775         (getIPhoneValueCallback): Deleted.
2776         (getIPhoneIdentifierCallback): Deleted.
2777         (getIPhoneTraitsCallback): Deleted.
2778         (getIPhoneIsElementCallback): Deleted.
2779         (getIPhoneElementTextPositionCallback): Deleted.
2780         (getIPhoneElementTextLengthCallback): Deleted.
2781         * DumpRenderTree/AccessibilityUIElement.h:
2782         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2783         (AccessibilityUIElement::identifier):
2784         (AccessibilityUIElement::traits):
2785         (AccessibilityUIElement::elementTextPosition):
2786         (AccessibilityUIElement::elementTextLength):
2787         (AccessibilityUIElement::description):
2788         (AccessibilityUIElement::orientation):
2789         (AccessibilityUIElement::stringValue):
2790         (AccessibilityUIElement::language):
2791         (AccessibilityUIElement::helpText):
2792         (AccessibilityUIElement::intValue):
2793         (AccessibilityUIElement::isSelected):
2794         (AccessibilityUIElement::isExpanded):
2795         (AccessibilityUIElement::documentURI):
2796         (AccessibilityUIElement::addNotificationListener):
2797         (AccessibilityUIElement::removeNotificationListener):
2798         (AccessibilityUIElement::isFocusable):
2799         (AccessibilityUIElement::isIgnored):
2800         (AccessibilityUIElement::hasPopup):
2801         (AccessibilityUIElement::iphoneLabel): Deleted.
2802         (AccessibilityUIElement::iphoneHint): Deleted.
2803         (AccessibilityUIElement::iphoneValue): Deleted.
2804         (AccessibilityUIElement::iphoneIdentifier): Deleted.
2805         (AccessibilityUIElement::iphoneTraits): Deleted.
2806         (AccessibilityUIElement::iphoneIsElement): Deleted.
2807         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
2808         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
2809         (_accessibilityNotificationCallback): Deleted.
2810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2811         (WTR::AccessibilityUIElement::isValid):
2812         (WTR::AccessibilityUIElement::identifier):
2813         (WTR::AccessibilityUIElement::traits):
2814         (WTR::AccessibilityUIElement::elementTextPosition):
2815         (WTR::AccessibilityUIElement::elementTextLength):
2816         (WTR::AccessibilityUIElement::stringForSelection):
2817         (WTR::AccessibilityUIElement::elementsForRange):
2818         (WTR::AccessibilityUIElement::increaseTextSelection):
2819         (WTR::AccessibilityUIElement::decreaseTextSelection):
2820         (WTR::AccessibilityUIElement::linkedElement):
2821         (WTR::AccessibilityUIElement::headerElementAtIndex):
2822         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2823         (WTR::AccessibilityUIElement::characterAtOffset):
2824         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2825         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2826         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2827         (WTR::findAccessibleObjectById):
2828         (WTR::AccessibilityController::accessibleElementById):
2829         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2830         (+[NSString stringWithJSStringRef:]):
2831         (-[NSString createJSStringRef]):
2832         (WTR::convertNSArrayToVector):
2833         (WTR::concatenateAttributeAndValue):
2834         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2835         (WTR::AccessibilityUIElement::isEqual):
2836         (WTR::AccessibilityUIElement::headerElementAtIndex):
2837         (WTR::AccessibilityUIElement::linkedElement):
2838         (WTR::AccessibilityUIElement::getLinkedUIElements):
2839         (WTR::AccessibilityUIElement::elementAtPoint):
2840         (WTR::convertElementsToObjectArray):
2841         (WTR::AccessibilityUIElement::elementsForRange):
2842         (WTR::AccessibilityUIElement::indexOfChild):
2843         (WTR::AccessibilityUIElement::stringAttributeValue):
2844         (WTR::AccessibilityUIElement::description):
2845         (WTR::AccessibilityUIElement::orientation):
2846         (WTR::AccessibilityUIElement::stringValue):
2847         (WTR::AccessibilityUIElement::language):
2848         (WTR::AccessibilityUIElement::helpText):
2849         (WTR::AccessibilityUIElement::x):
2850         (WTR::AccessibilityUIElement::clickPointX):
2851         (WTR::AccessibilityUIElement::clickPointY):
2852         (WTR::AccessibilityUIElement::intValue):
2853         (WTR::AccessibilityUIElement::minValue):
2854         (WTR::AccessibilityUIElement::maxValue):
2855         (WTR::AccessibilityUIElement::valueDescription):
2856         (WTR::AccessibilityUIElement::isSelected):
2857         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2858         (WTR::AccessibilityUIElement::stringForRange):
2859         (WTR::AccessibilityUIElement::attributedStringForRange):
2860         (WTR::AccessibilityUIElement::attributesOfHeader):
2861         (WTR::AccessibilityUIElement::traits):
2862         (WTR::AccessibilityUIElement::identifier):
2863         (WTR::AccessibilityUIElement::rowCount):
2864         (WTR::AccessibilityUIElement::rowIndexRange):
2865         (WTR::AccessibilityUIElement::columnIndexRange):
2866         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2867         (WTR::AccessibilityUIElement::horizontalScrollbar):
2868         (WTR::AccessibilityUIElement::documentURI):
2869         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2870         (WTR::AccessibilityUIElement::increaseTextSelection):
2871         (WTR::AccessibilityUIElement::decreaseTextSelection):
2872         (WTR::AccessibilityUIElement::stringForSelection):
2873         (WTR::AccessibilityUIElement::elementTextPosition):
2874         (WTR::AccessibilityUIElement::elementTextLength):
2875         (WTR::AccessibilityUIElement::url):
2876         (WTR::AccessibilityUIElement::addNotificationListener):
2877         (WTR::AccessibilityUIElement::removeNotificationListener):
2878         (WTR::AccessibilityUIElement::isFocusable):
2879         (WTR::AccessibilityUIElement::isIgnored):
2880         (WTR::AccessibilityUIElement::hasPopup):
2881         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2882         (WTR::_CGPathEnumerationIteration):
2883         (WTR::AccessibilityUIElement::pathDescription):
2884         (WTR::AccessibilityUIElement::supportedActions):
2885
2886 2015-06-16  Mark Lam  <mark.lam@apple.com>
2887
2888         Use NakedPtr<Exception>& to return exception results.
2889         https://bugs.webkit.org/show_bug.cgi?id=145870
2890
2891         Reviewed by Anders Carlsson and Filip Pizlo.
2892
2893         * TestWebKitAPI/CMakeLists.txt:
2894         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2895         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2897         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
2898         (TestWebKitAPI::TEST):
2899         (TestWebKitAPI::nakedPtrFoo):
2900
2901 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
2902
2903         Unreviewed. Adding myself as a committer.
2904
2905         * Scripts/webkitpy/common/config/contributors.json:
2906
2907 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
2908
2909         Add test expectations for El Capitan
2910         https://bugs.webkit.org/show_bug.cgi?id=146005
2911
2912         Rubber-stamped by Dan Bernstein.
2913
2914         Add appropriate tools code.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
2918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2920         Added dashboard support.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2923         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2924         Trigger the right build queues on check-in.
2925
2926         * Scripts/webkitpy/common/system/platforminfo.py:
2927         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2928         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2929         * Scripts/webkitpy/port/mac.py:
2930         * Scripts/webkitpy/port/mac_unittest.py:
2931         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2932         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2933         Added cases for El Capitan, and updated tests for new baseline search paths.
2934
2935 2015-06-15  Alex Christensen  <achristensen@webkit.org>
2936
2937         [Content Extensions] Make max NFA size and max rule count user defaults.
2938         https://bugs.webkit.org/show_bug.cgi?id=145663
2939
2940         Reviewed by Benjamin Poulain.
2941
2942         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2943         (TestWebKitAPI::TEST_F):
2944
2945 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2946
2947         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
2948         https://bugs.webkit.org/show_bug.cgi?id=145900
2949
2950         Reviewed by Sam Weinig.
2951
2952         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2953         (TEST): Added tests.
2954
2955 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2956
2957         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
2958         https://bugs.webkit.org/show_bug.cgi?id=145969
2959
2960         Reviewed by Sergio Villar Senin.
2961
2962         Add a test case to the custom URI schemes unit test.
2963
2964         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2965         (testWebContextURIScheme):
2966
2967 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
2968
2969         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
2970         https://bugs.webkit.org/show_bug.cgi?id=145922
2971
2972         Reviewed by Carlos Garcia Campos.
2973
2974         * gtk/jhbuild.modules:
2975         * gtk/patches/glib-warning-fix.patch: Added.
2976
2977 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2978
2979         Update springLoadingHighlight type
2980         https://bugs.webkit.org/show_bug.cgi?id=145939
2981         rdar://problem/20880213
2982
2983         Reviewed by Darin Adler.
2984
2985         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2986         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2987         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2988         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2989
2990 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
2991
2992         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
2993         https://bugs.webkit.org/show_bug.cgi?id=145945
2994
2995         Reviewed by Stephanie Lewis.
2996
2997         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2998         (OSXBrowserDriver.prepareEnv):
2999         (OSXBrowserDriver.moveCursor): Deleted.
3000         (OSXBrowserDriver): Deleted.
3001         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3002         (OSXSafariDriver.prepareEnv):
3003
3004 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
3005
3006         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
3007         https://bugs.webkit.org/show_bug.cgi?id=145938
3008
3009         Reviewed by Alexey Proskuryakov.
3010
3011         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
3012         LWP::UserAgent to get access to more robust HTTPS support.
3013
3014 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3015
3016         [GTK] Fix return type warning in WebViewTest.cpp
3017         https://bugs.webkit.org/show_bug.cgi?id=145914
3018
3019         Reviewed by Darin Adler.
3020
3021         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3022         (WebViewTest::isEditable):
3023
3024 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
3025
3026         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
3027         https://bugs.webkit.org/show_bug.cgi?id=145799
3028
3029         Reviewed by Carlos Garcia Campos.
3030
3031         Update header inclusions for headers that have been moved
3032         to Source/WTF/wtf/glib/.
3033
3034         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
3035         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
3036
3037         * TestWebKitAPI/PlatformGTK.cmake:
3038         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
3039         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3040         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3041         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3042         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3043         (TestWebKitAPI::GMainLoopSourceTest::finish):
3044         (TestWebKitAPI::GMainLoopSourceTest::source):
3045         (TestWebKitAPI::basicRescheduling):
3046         (TestWebKitAPI::TEST):
3047         (TestWebKitAPI::reentrantRescheduling):
3048         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3049         (TestWebKitAPI::basicDestroyCallbacks):
3050         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3051         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3052         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
3053         (log):
3054         (takeLogStr):
3055         (TestWebKitAPI::TEST):
3056         (TestWebKitAPI::returnOutChar):
3057         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3058         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3059         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
3060         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
3061         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
3062         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
3063         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
3064         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
3065         (TestWebKitAPI::basicRescheduling): Deleted.
3066         (TestWebKitAPI::TEST): Deleted.
3067         (TestWebKitAPI::reentrantRescheduling): Deleted.
3068         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
3069         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
3070         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
3071         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
3072         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
3073         (log): Deleted.
3074         (takeLogStr): Deleted.
3075         (TestWebKitAPI::TEST): Deleted.
3076         (TestWebKitAPI::returnOutChar): Deleted.
3077         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3078         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3079         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3080         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3081         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3082         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3083         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3084         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3085         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3086         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3087         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3088         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3089         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3090         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
3091         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3092         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
3093         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3094         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3095         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3096         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3097         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3098         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3099         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3100         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3101         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3102         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3103         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3104         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3105         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
3106         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
3107         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3108         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
3109         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3110         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3111         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3112         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3113         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3114         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3115         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3116         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3117         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3118         * WebKitTestRunner/PlatformGTK.cmake:
3119         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3120         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3121
3122 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3123
3124         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
3125         https://bugs.webkit.org/show_bug.cgi?id=145913
3126
3127         Reviewed by Gyuyoung Kim.
3128
3129         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3130         (TestWebKitAPI::setupGeolocationProvider):
3131         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3132         (TestWebKitAPI::setPageLoaderClient):
3133         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3134         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3135         * WebKitTestRunner/GeolocationProviderMock.cpp:
3136         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3137         * WebKitTestRunner/WebNotificationProvider.cpp:
3138         (WTR::WebNotificationProvider::provider):
3139
3140 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3141
3142         Fix the libusrsctp build with clang
3143         https://bugs.webkit.org/show_bug.cgi?id=145128
3144
3145         Reviewed by Gyuyoung Kim.
3146
3147         * efl/jhbuild.modules:
3148         * gtk/jhbuild.modules:
3149
3150 2015-06-11  Mark Lam  <mark.lam@apple.com>
3151
3152         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
3153         https://bugs.webkit.org/show_bug.cgi?id=145872
3154
3155         Reviewed by Michael Saboff.
3156
3157         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3158         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3159         - Exercises the JSC ObjC API to call a function which throws an exception.  That
3160           exception will be returned as a JSValue instead of an Exception object.  We
3161           will use this JSValue to test WebCore::reportException() to confirm that it is
3162           able to handle an exception value which is not an Exception object.
3163
3164 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
3165
3166         Move cursor to corner and fix safari window size before running benchmark
3167         https://bugs.webkit.org/show_bug.cgi?id=145858
3168
3169         Reviewed by Ryosuke Niwa
3170
3171         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3172         (OSXBrowserDriver.prepareEnv):
3173         (OSXBrowserDriver):
3174         (OSXBrowserDriver.moveCursor):
3175         (OSXBrowserDriver.getScreenSize):
3176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3177         (OSXChromeDriver.launchUrl):
3178         (OSXChromeCanaryDriver.launchUrl):
3179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3180         (OSXFirefoxDriver.launchUrl):
3181         (OSXFirefoxNightlyDriver.launchUrl):
3182         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3183         (OSXSafariDriver.prepareEnv):
3184         (OSXSafariDriver):
3185         (OSXSafariDriver.maximizeWindow):
3186
3187 2015-06-11  Daniel Bates  <dabates@apple.com>
3188
3189         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
3190         https://bugs.webkit.org/show_bug.cgi?id=145319
3191
3192         Reviewed by David Kilzer.
3193
3194         Add SPI wrapper header for CoreSimulator and update the source files to reference
3195         it instead of directly referencing the CoreSimulator header.
3196
3197         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
3198         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
3199         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3200         * LayoutTestRelay/LayoutTestRelay/main.m:
3201
3202 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3203
3204         [EFL] dimmed area for popup does not cover the fullscreen mode.
3205         https://bugs.webkit.org/show_bug.cgi?id=145133
3206
3207         Reviewed by Gyuyoung Kim.
3208
3209         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
3210         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
3211
3212         * MiniBrowser/efl/main.c:
3213         (on_fullscreen_accept):
3214         (on_fullscreen_deny):
3215         (on_fullscreen_enter):
3216
3217 2015-06-10  Commit Queue  <commit-queue@webkit.org>
3218
3219         Unreviewed, rolling out r185442.
3220         https://bugs.webkit.org/show_bug.cgi?id=145871
3221
3222         seems to have broken WTF.StringOperators test (Requested by
3223         alexchristensen on #webkit).
3224
3225         Reverted changeset:
3226
3227         "[Content Extensions] Limit number of rules."
3228         https://bugs.webkit.org/show_bug.cgi?id=145663
3229         http://trac.webkit.org/changeset/185442
3230
3231 2015-06-10  Alex Christensen  <achristensen@webkit.org>
3232
3233         [Content Extensions] Make max NFA size and max rule count user defaults.
3234         https://bugs.webkit.org/show_bug.cgi?id=145663
3235         rdar://problem/21242407
3236
3237         Reviewed by Benjamin Poulain.
3238
3239         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3240         (TestWebKitAPI::TEST_F):
3241
3242 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3243
3244         [EFL] Execute Javascript method in mini browser address bar.
3245         https://bugs.webkit.org/show_bug.cgi?id=145725
3246
3247         Reviewed by Gyuyoung Kim.
3248
3249         Support 'javascript:' scheme in WebKit EFL Mini Browser.
3250
3251         * MiniBrowser/efl/main.c:
3252         (url_from_user_input):
3253         (url_load_from_user_input):
3254         (on_url_bar_activated):
3255         (elm_main):
3256
3257 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3258
3259         Implement dumpProgressFinishedCallback() for Win layoutTestController.
3260         https://bugs.webkit.org/show_bug.cgi?id=66773
3261
3262         Reviewed by Darin Adler.
3263
3264         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3265         * DumpRenderTree/win/FrameLoadDelegate.h:
3266
3267 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
3268
3269         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
3270         https://bugs.webkit.org/show_bug.cgi?id=145764
3271
3272         Reviewed by Darin Adler.
3273
3274         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
3275         JetStream and SunSpider.
3276
3277         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3278         (GenericBenchmarkBuilder):
3279         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
3280         the whole JSON as the input.
3281         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
3282         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
3283         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3284         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
3285         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
3286         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3287         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
3288
3289 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3290
3291         Remove ewstool scripts used by chromium port
3292         https://bugs.webkit.org/show_bug.cgi?id=145789
3293
3294         Reviewed by Csaba Osztrogonác.
3295
3296         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
3297         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
3298         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
3299         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
3300         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
3301
3302 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3303
3304         Unreviewed, updated my list of email addresses.
3305
3306         * Scripts/webkitpy/common/config/contributors.json:
3307
3308 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
3309
3310         [cmake] Fix the style issues in cmake project files
3311         https://bugs.webkit.org/show_bug.cgi?id=145755
3312
3313         Reviewed by Darin Adler.
3314
3315         * TestWebKitAPI/CMakeLists.txt:
3316         * TestWebKitAPI/PlatformEfl.cmake:
3317
3318 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3319
3320         Fix a typo in r185345.
3321
3322         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3323         (OSXSafariDriver.closeBrowsers):
3324
3325 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3326
3327         Yet another unreviewed build fix :(
3328
3329         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3330         (OSXSafariDriver):
3331         (OSXSafariDriver.launchUrl):
3332         (OSXSafariDriver.closeBrowsers):
3333
3334 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3335
3336         Unreviewed build fix. Initialize result in the case things blow up below.
3337
3338         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3339         (BenchmarkRunner.execute):
3340
3341 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3342
3343         Partially revert and fix after r185243.
3344
3345         * Scripts/benchmark_runner/benchmark_runner.py:
3346         * Scripts/run-benchmark:
3347
3348 2015-06-08  Daniel Bates  <dabates@apple.com>
3349
3350         Many LayoutTests/http tests time out in DumpRenderTree
3351         https://bugs.webkit.org/show_bug.cgi?id=145770
3352         <rdar://problem/19593910>
3353
3354         Reviewed by Alexey Proskuryakov.
3355
3356         * DumpRenderTree/ios/Info.plist: Add ATS key.
3357         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3358         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
3359         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
3360         that make use of testRunner.pathToLocalResource().
3361
3362 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
3363
3364         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
3365         https://bugs.webkit.org/show_bug.cgi?id=145759
3366
3367         Reviewed by Carlos Garcia Campos.
3368
3369         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3370         (testWebViewSave):
3371
3372 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3373
3374         [GTK] Add editor mode to MiniBrowser
3375         https://bugs.webkit.org/show_bug.cgi?id=145595
3376
3377         Reviewed by Sergio Villar Senin.
3378
3379         It loads an empty editable web view with an edit toolbar. It makes
3380         easier to test the editor, editing commands and input methods.
3381
3382         * MiniBrowser/gtk/BrowserWindow.c:
3383         (editingCommandCallback):
3384         (browserWindowSetupEditorToolbar):
3385         (browserWindowConstructed):
3386         * MiniBrowser/gtk/main.c:
3387         (createBrowserWindow):
3388
3389 2015-06-05  Zalan Bujtas  <zalan@apple.com>
3390
3391         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
3392
3393         Reviewed by Dan Bernstein.
3394
3395         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3396         (TestWebKitAPI::TEST):
3397
3398 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3399
3400         [EFL] API test has been broken since r184357
3401         https://bugs.webkit.org/show_bug.cgi?id=145635
3402
3403         Reviewed by Darin Adler.
3404
3405         r184357 suppress cmake build warning using TARGET_FILE property. However
3406         many EFL API test cases have been broken after applying it.
3407
3408         * TestWebKitAPI/CMakeLists.txt:
3409
3410 2015-06-05  Anders Carlsson  <andersca@apple.com>
3411
3412         Make the network cache directory part of WKContextConfigurationRef
3413         https://bugs.webkit.org/show_bug.cgi?id=145711
3414
3415         Reviewed by Antti Koivisto.
3416
3417         * WebKitTestRunner/TestController.cpp:
3418         (WTR::TestController::initialize):
3419
3420 2015-06-05  Anders Carlsson  <andersca@apple.com>
3421
3422         Make the application cache directory part of WKContextConfigurationRef
3423         https://bugs.webkit.org/show_bug.cgi?id=145704
3424
3425         Reviewed by Geoffrey Garen.
3426
3427         * WebKitTestRunner/TestController.cpp:
3428         (WTR::TestController::initialize):
3429
3430 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3431
3432         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
3433         https://bugs.webkit.org/show_bug.cgi?id=145680
3434
3435         Reviewed by Brent Fulgham.
3436
3437         * Scripts/webkitpy/style/checkers/cpp.py:
3438         (check_for_null):
3439         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3440         (WebKitStyleTest.test_null_false_zero):
3441
3442 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3443
3444         Make the web server more robust to timing issues..
3445
3446         Reviewed by Ryosuke Niwa.
3447
3448         Cleaned up exception handling.
3449         Test server is actually serving pages before returning.
3450         Clean up some style issues.
3451
3452         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3453         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3454         (SimpleHTTPServerDriver.__init__):
3455         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
3456         (SimpleHTTPServerDriver.baseUrl): 
3457         (SimpleHTTPServerDriver.fetchResult):
3458         (SimpleHTTPServerDriver.killServer):
3459         (SimpleHTTPServerDriver.getReturnCode):
3460
3461 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3462
3463
3464         Add errors to run-benchmark exception handling.
3465
3466         Reviewed by Ryosuke Niwa.
3467
3468         * Scripts/run-benchmark:
3469         (main):
3470         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3471         (GenericBenchmarkBuilder.prepare):
3472         (GenericBenchmarkBuilder._runCreateScript):
3473         (GenericBenchmarkBuilder._applyPatch):
3474         (GenericBenchmarkBuilder.clean):
3475         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3476         (BenchmarkRunner.__init__):
3477         (BenchmarkRunner.execute):
3478         (BenchmarkRunner):
3479         (BenchmarkRunner.cleanup):
3480         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
3481         (GenericFactory.iterateGetItem):
3482         (GenericFactory.create):
3483         * Scripts/webkitpy/benchmark_runner/utils.py:
3484         (loadModule):
3485         (loadJSONFromFile):
3486         (forceRemove):
3487
3488 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3489
3490         Streamline run-benchmark browser
3491
3492         Reviewed by Ryosuke Niwa.
3493
3494         Add Caffeinate so computer won't sleep while running.
3495         Remove calls to collect output since we were just dumping to stdout anyway.
3496         Add xpc dyld_path.
3497         Default to system safari.
3498
3499         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3500         (OSXBrowserDriver.launchProcess):
3501         (OSXBrowserDriver.terminateProcesses):
3502         (OSXBrowserDriver):
3503         (OSXBrowserDriver.launchCaffeinateForProcess):
3504         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3505         (OSXSafariDriver.launchUrl):
3506         (OSXSafariDriver.closeBrowsers):
3507
3508 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
3509
3510         Combine tiny DFAs into slightly larger ones
3511         https://bugs.webkit.org/show_bug.cgi?id=145572
3512
3513         Reviewed by Alex Christensen.
3514
3515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3516         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
3517         (TestWebKitAPI::DFACombinerTest::SetUp):
3518         (TestWebKitAPI::combine):
3519         (TestWebKitAPI::TEST_F):
3520         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
3521         (TestWebKitAPI::countLiveNodes):
3522         (TestWebKitAPI::createNFAs):
3523         (TestWebKitAPI::buildDFAFromPatterns):
3524         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3525         (TestWebKitAPI::countLiveNodes): Deleted.
3526         (TestWebKitAPI::createNFAs): Deleted.
3527         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
3528
3529 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
3530
3531         WebKitTestRunner leaks strings in generateWhitelist()
3532         https://bugs.webkit.org/show_bug.cgi?id=145665
3533
3534         Reviewed by Myles C. Maxfield.
3535
3536         * WebKitTestRunner/mac/TestControllerMac.mm:
3537         (WTR::generateWhitelist):
3538
3539 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3540
3541         Fix options in build-jsc for CMake builds
3542         https://bugs.webkit.org/show_bug.cgi?id=145636
3543
3544         Reviewed by Gyuyoung Kim.
3545
3546         CMake only accepts -DXXX=YYY style options.
3547         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
3548
3549         * Scripts/build-jsc:
3550
3551 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
3552
3553         Added a patch so that the colors displayed on the page could be toggled
3554         in case people need accessibility colors displayed in their browser.
3555         https://bugs.webkit.org/show_bug.cgi?id=145570
3556         <rdar://problem/20994468>
3557
3558         Added in CSS colors and toggle buttons for checkmarks in the page, so that
3559         the page could be rendered in a specific way for accessibility needs if needed.
3560
3561         Reviewed by Alexey Proskuryakov.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3564         (updateHiddenPlatforms):
3565         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
3566         (toggleAccessibilityColors): Toggle colors on and off
3567         (documentReady): Needed to make changes to the initialization
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3569         (a:hover):
3570         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
3571         (div.cellButton.hide, div.accessibilityButton.hide):
3572         (div.cellButton.unhide, div.accessibilityButton.unhide):
3573         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
3574         (.popover-tracking:hover):
3575         (.accessibilityButton):
3576         (div.cellButton): Deleted.
3577         (div.cellButton.hide): Deleted.
3578         (div.cellButton.unhide): Deleted.
3579         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
3580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3581         (.status-line.neutral .bubble):
3582         (.status-line.unauthorized .bubble):
3583         (.status-line.danger .bubble.pictogram):
3584         (.status-line.bad .bubble.pictogram):
3585         (.status-line.no-bubble .message):
3586         (.status-line.bad .bubble):
3587         (.status-line.good .bubble):
3588         (.status-line.good .message):
3589         (.status-line.bad .message):
3590         (body.accessibility-colors .status-line.good .bubble):
3591         (body.accessibility-colors .status-line.bad .bubble):
3592         (body.accessibility-colors .status-line.good .message):
3593         (body.accessibility-colors .status-line.bad .message):
3594         (.status-line.danger .message):
3595         (.status-line.unauthorized .message):
3596
3597 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
3598
3599         Unreviewed build fix for Dromaeo.
3600
3601         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
3602         (BenchmarkResults._aggregate_results_for_test):
3603
3604 2015-06-03  Anders Carlsson  <andersca@apple.com>
3605
3606         Fix build.
3607
3608         * DumpRenderTree/mac/TestRunnerMac.mm:
3609
3610 2015-06-03  Daniel Bates  <dabates@apple.com>
3611
3612         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
3613         https://bugs.webkit.org/show_bug.cgi?id=145616
3614
3615         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
3616         of the test. Further investigation is needed.
3617
3618         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3619         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3620
3621 2015-06-03  Brady Eidson  <beidson@apple.com>
3622
3623         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
3624         https://bugs.webkit.org/show_bug.cgi?id=145580
3625
3626         Reviewed by Mark Lam.
3627
3628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3629         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
3630
3631 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
3632
3633         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
3634