1 2015-10-04 Alexey Proskuryakov <ap@apple.com>
3 Bot watcher's dashboard builders should turn yellow when svn fails
4 https://bugs.webkit.org/show_bug.cgi?id=149791
6 Reviewed by Lucas Forschler.
8 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
9 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
10 (BuildbotBuilderQueueView.prototype.update):
12 2015-10-02 Daniel Bates <dabates@apple.com>
14 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
15 https://bugs.webkit.org/show_bug.cgi?id=149769
17 Reviewed by Alexey Proskuryakov.
19 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
20 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
21 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
22 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
24 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
25 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
27 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
29 REGRESSION(r190370): Speedometer spits out an extra console message
30 https://bugs.webkit.org/show_bug.cgi?id=149720
32 Unreviewed. Temporarily ignore the console error message.
34 * Scripts/webkitpy/performance_tests/perftest.py:
35 (PerfTest._filter_output):
37 2015-10-02 Brent Fulgham <bfulgham@apple.com>
39 Provide "--no-ninja" option to avoid using Ninja
40 https://bugs.webkit.org/show_bug.cgi?id=149757
42 Reviewed by Alex Christensen.
44 Add a new command line argument understood by webkitdirs.pm so
45 that we can conditionally avoid using Ninja. This is an
46 'opt-out' argument, so no existing Ninja users should be affected.
48 * Scripts/webkitdirs.pm:
49 (canUseNinja): Check for option and block ninja if present.
51 2015-10-02 Aakash Jain <aakash_jain@apple.com>
53 Flakiness dashboard should support OS X El Capitan
54 https://bugs.webkit.org/show_bug.cgi?id=149648
56 Reviewed by Alexey Proskuryakov.
58 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
60 2015-10-02 Daniel Bates <dabates@apple.com>
62 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
63 (https://bugs.webkit.org/show_bug.cgi?id=149753)
65 For now, pass --ios-simulator.
67 * Scripts/webkitpy/port/ios.py:
68 (IOSSimulatorPort._build_relay):
70 2015-10-02 Simon Fraser <simon.fraser@apple.com>
72 Remove a "nullable" that breaks the iOS 8 build.
74 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
75 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
77 2015-10-02 Daniel Bates <dabates@apple.com>
79 LayoutTestRelay is not built and archived when building for iOS Simulator
80 https://bugs.webkit.org/show_bug.cgi?id=149753
82 Reviewed by Alexey Proskuryakov and Andy Estes.
84 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
85 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
86 product archive when building for iOS Simulator, respectively.
88 * BuildSlaveSupport/built-product-archive:
89 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
90 differentiate between iOS device and iOS Simulator platforms.
91 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
92 from determineWebKitBuildDirectories() into this function so that it can be used by both
93 determineWebKitBuildDirectories() and archiveBuiltProduct().
94 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
95 webkitBuildDirectoryForConfigurationAndPlatform().
96 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
97 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
98 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
99 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
100 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
101 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
102 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
103 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
104 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
105 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
106 * Scripts/build-layouttestrelay:
107 - Remove unnecessary include of Perl module POSIX.
108 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
109 * Scripts/build-webkit:
110 - Invoke script build-layouttestrelay when building for iOS Simulator.
112 2015-10-02 Brent Fulgham <bfulgham@apple.com>
114 [Win] Unreviewed test fix.
116 You cannot run 'run-webkit-tests' from the command line because it does not know
117 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
118 because they explicitly set use the 'root' argument to provide the full path to
121 * Scripts/webkitpy/port/win.py:
122 (WinPort._build_path): Added.
124 2015-10-02 Alex Christensen <achristensen@webkit.org>
126 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
127 https://bugs.webkit.org/show_bug.cgi?id=149430
128 rdar://problem/22742222
130 Reviewed by Geoffrey Garen.
132 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
133 (WTR::TestController::cocoaResetStateToConsistentValues):
134 * WebKitTestRunner/mac/TestControllerMac.mm:
135 (WTR::TestController::platformConfigureViewForTest):
136 Test what happens when you disable content blockers from the SPI.
138 2015-10-01 Brent Fulgham <bfulgham@apple.com>
140 [Win] Unreviewed build fix for run-api-tests
142 * Scripts/run-api-tests:
143 (testToolPaths): Windows run needs to specify the binary path.
145 2015-10-01 Daniel Bates <dabates@apple.com>
147 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
148 (https://bugs.webkit.org/show_bug.cgi?id=149695)
150 Following r190424 we can now rely on webkit-build-directory to return the path to
151 the correct configuration-specific build directory on Windows.
153 * BuildSlaveSupport/built-product-archive:
154 (archiveBuiltProduct):
156 2015-10-01 Brent Fulgham <bfulgham@apple.com>
158 [Win] Unreviewed build fix.
160 * Scripts/webkitdirs.pm:
161 (setupAppleWinEnv): Use 64-bit build tools if available
163 2015-10-01 Brent Fulgham <bfulgham@apple.com>
165 [Win] Fix TestWebKitAPI build under CMake.
167 Reviewed by Alex Christensen.
169 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
172 2015-10-01 Brent Fulgham <bfulgham@apple.com>
174 [Win] Fix behavior of webkit-build-directory script
175 https://bugs.webkit.org/show_bug.cgi?id=149718
177 Reviewed by Alex Christensen.
179 * Scripts/webkitdirs.pm:
180 (determineConfigurationProductDir): Do not include the binary
181 sub-directory in the configuration product directory output.
182 (jscProductDir): Append correct binary path for Windows build.
183 (setPathForRunningWebKitApp): Include properly binary subdirectories.
184 (runSafari): Update for revised productDir behavior.
185 (runMiniBrowser): Ditto.
187 2015-10-01 Alexey Proskuryakov <ap@apple.com>
189 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
190 use iOS SDK, like with all the others.
192 * Scripts/build-webkit:
194 2015-10-01 Daniel Bates <dabates@apple.com>
196 Attempt to fix the iOS 9 Simulator testers
198 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
199 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
200 LayoutTestRelay when building for iOS Simulator.
202 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
203 * Scripts/build-webkit:
205 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
207 [GTK] Websites with invalid auth header keep loading forever
208 https://bugs.webkit.org/show_bug.cgi?id=149710
210 Reviewed by Martin Robinson.
212 Add test case to check that we can authenticate sites with an
215 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
216 (testWebViewAuthenticationEmptyRealm):
220 2015-10-01 Alexey Proskuryakov <ap@apple.com>
222 [Mac] Make run-api-tests work with System Integrity Protection
223 https://bugs.webkit.org/show_bug.cgi?id=149711
224 rdar://problem/22928202
226 Reviewed by Dan Bernstein.
228 * Scripts/run-api-tests:
230 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
232 2015-10-01 Daniel Bates <dabates@apple.com>
234 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
235 (https://bugs.webkit.org/show_bug.cgi?id=149695)
237 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
238 For now, use the path to the top-level WebKit build directory instead of using the configuration-
239 specific build directory.
241 * BuildSlaveSupport/built-product-archive:
242 (archiveBuiltProduct):
244 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
246 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
247 https://bugs.webkit.org/show_bug.cgi?id=145837
249 Reviewed by Philippe Normand.
251 * efl/jhbuild.modules:
252 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
253 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
255 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
257 Unreviewed. Fix the iOS build after r190407.
259 * WebKitTestRunner/ios/IOKitSPI.h:
261 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
263 Implement keyboard event sending for iOS in WebKitTestRunner
264 https://bugs.webkit.org/show_bug.cgi?id=149676
266 Reviewed by Simon Fraser.
268 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
269 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
270 allows us to run code when the keyboard is shown or hidden.
272 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
273 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
274 (WTR::UIScriptController::setDidShowKeyboardCallback):
275 (WTR::UIScriptController::didShowKeyboardCallback):
276 (WTR::UIScriptController::setDidHideKeyboardCallback):
277 (WTR::UIScriptController::didHideKeyboardCallback):
278 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
279 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
280 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
281 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
282 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
283 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
284 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
285 the notifications that the keyboard has been raised or lowered.
286 (-[TestRunnerWKWebView _keyboardDidShow:]):
287 (-[TestRunnerWKWebView _keyboardDidHide:]):
288 * WebKitTestRunner/ios/HIDEventGenerator.h:
289 * WebKitTestRunner/ios/HIDEventGenerator.m:
290 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
291 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
292 (hidUsageCodeForCharacter): Ditto.
293 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
294 a keyDown event in WebKit.
295 * WebKitTestRunner/ios/IOKitSPI.h:
296 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
298 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
300 Unreviewed, rolling out r190399.
302 Tests are still failing even after r190362
306 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
307 http://trac.webkit.org/changeset/190399
309 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
311 [jhbuild] switch to new upstream usrsctp library
312 https://bugs.webkit.org/show_bug.cgi?id=149494
314 Reviewed by Philippe Normand.
316 * efl/jhbuild.modules:
317 * gtk/jhbuild.modules:
319 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
321 Unreviewed. Unskip GTK+ user media unit tests after r190362.
323 They should pass now.
325 * Scripts/run-gtk-tests:
328 2015-09-30 Daniel Bates <dabates@apple.com>
330 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
331 (https://bugs.webkit.org/show_bug.cgi?id=149695)
333 * BuildSlaveSupport/built-product-archive:
334 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
335 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
337 2015-09-30 Daniel Bates <dabates@apple.com>
339 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
340 (https://bugs.webkit.org/show_bug.cgi?id=149695)
342 Actually, we need to pass --configuration to script webkit-build-directory to have
343 it return the path to the configuration-specific build directory.
345 * BuildSlaveSupport/built-product-archive:
346 (determineWebKitBuildDirectories):
348 2015-09-30 Daniel Bates <dabates@apple.com>
350 built-product-archive archives incorrect build directory for iOS port
351 https://bugs.webkit.org/show_bug.cgi?id=149695
353 Reviewed by Darin Adler.
355 Fixes an issue where the script built-product-archive archives a non-existent
356 build directory for the iOS port. Without loss of generality, the script assumes
357 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
358 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
360 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
361 to determine the top-level build directory and computes the configuration-specific
362 build directory to be the concatenation of the the top-level build directory and
363 the configuration (e.g. Release). This is incorrect. Instead we should call
364 webkit-build-directory omitting the flag --top-level to compute the path to the
365 configuration-specific build directory.
367 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
368 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
369 its purpose and added global variable _configurationBuildDirectory to store the path
370 to the configuration-specific build directory. Ensure that we have a non-empty string
371 for both the top-level and configuration-specific build directories.
372 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
373 Compute the configuration-specific build directory and store it in the global variable
374 _configurationBuildDirectory.
375 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
376 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
378 (determineWebKitBuildDirectory): Deleted.
380 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
382 [EFL] css3/device-adapt/* tests failed after r190335.
383 https://bugs.webkit.org/show_bug.cgi?id=149655
385 Reviewed by Simon Fraser.
387 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
388 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
390 * WebKitTestRunner/efl/TestControllerEfl.cpp:
391 (WTR::shouldUseFixedLayout):
393 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
395 Extend JetStream timeout for slow devices.
397 Reviewed by Chris Dumez.
399 Extend JetStream timeout to 20 minutes.
401 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
403 2015-09-30 Daniel Bates <dabates@apple.com>
405 Rename iOS builders/testers to include version
406 https://bugs.webkit.org/show_bug.cgi?id=149685
408 Reviewed by Simon Fraser.
410 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
411 make it clear to a reader the version of iOS these builders/testers are using.
413 * BuildSlaveSupport/build.webkit.org-config/config.json:
414 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
416 2015-09-30 Daniel Bates <dabates@apple.com>
418 Add iOS criterion for triggering a build
419 https://bugs.webkit.org/show_bug.cgi?id=149679
421 Rubber-stamped by Alexey Proskuryakov.
423 First pass at defining criterion for triggering an iOS build.
425 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
426 (_should_file_trigger_build):
427 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
429 (ShouldBuildTest.test_should_build):
431 2015-09-29 Simon Fraser <simon.fraser@apple.com>
433 [iOS] Allow tests to generate user gestures for UI testing
434 https://bugs.webkit.org/show_bug.cgi?id=149653
436 Reviewed by Tim Horton.
438 Expose functionality in UIScriptController to allow for testing single- and double-tap,
439 and to listen for completion of scrolling and zooming in the WKWebView.
441 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
442 which hides the complexity of creating these events. Event dispatch is asynchronous.
443 We detect when the last event has been handled by dispatching a vendor-specific event,
444 which is detected via -_handleHIDEvent: in our UIApplication subclass.
446 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
447 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
448 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
449 single and double taps.
450 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
451 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
452 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
453 (UIScriptContext::unregisterCallback):
454 (UIScriptContext::callbackWithID):
455 (UIScriptContext::fireCallback):
456 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
457 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
458 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
459 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
460 (WTR::UIScriptController::setDidEndZoomingCallback):
461 (WTR::UIScriptController::didEndZoomingCallback):
462 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
463 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
464 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
465 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
466 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
467 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
468 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
469 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
470 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
471 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
472 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
473 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
474 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
475 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
477 (calculateNextLocation):
479 (+[HIDEventGenerator sharedHIDEventGenerator]):
480 (+[HIDEventGenerator nextEventCallbackID]):
481 (-[HIDEventGenerator init]):
482 (-[HIDEventGenerator _createIOHIDEventType:]):
483 (-[HIDEventGenerator _sendHIDEvent:]):
484 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
485 (-[HIDEventGenerator _updateTouchPoints:count:]):
486 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
487 (-[HIDEventGenerator touchDown:touchCount:]):
488 (-[HIDEventGenerator touchDown:]):
489 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
490 (-[HIDEventGenerator liftUp:touchCount:]):
491 (-[HIDEventGenerator liftUp:]):
492 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
493 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
494 (-[HIDEventGenerator tap:completionBlock:]):
495 (-[HIDEventGenerator doubleTap:completionBlock:]):
496 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
497 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
498 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
499 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
500 (-[HIDEventGenerator markerEventReceived:]):
501 * WebKitTestRunner/ios/IOKitSPI.h: Added.
502 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
503 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
504 (WTR::globalToContentCoordinates):
505 (WTR::UIScriptController::singleTapAtPoint):
506 (WTR::UIScriptController::doubleTapAtPoint):
507 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
508 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
509 * WebKitTestRunner/ios/mainIOS.mm:
510 (-[WebKitTestRunnerApp _handleHIDEvent:]):
512 2015-09-30 Dana Burkart <dburkart@apple.com>
514 git-add-reviewer should trim trailing spaces/newlines
515 https://bugs.webkit.org/show_bug.cgi?id=149513
517 Reviewed by Darin Adler.
519 * Scripts/git-add-reviewer:
522 2015-09-30 Eric Carlson <eric.carlson@apple.com>
524 REGRESSION(r190262): User media unit test failures after r190262
525 https://bugs.webkit.org/show_bug.cgi?id=149580
527 Reviewed by Darin Adler.
529 * WebKitTestRunner/TestController.cpp:
530 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
531 order to WKUserMediaPermissionRequestAllow.
533 2015-09-30 Daniel Bates <dabates@apple.com>
535 Add iOS builders and testers
536 https://bugs.webkit.org/show_bug.cgi?id=149549
538 Reviewed by Alexey Proskuryakov.
540 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
541 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
543 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
544 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
546 2015-09-30 Timothy Hatcher <timothy@apple.com>
548 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
549 https://bugs.webkit.org/show_bug.cgi?id=149674
551 Reviewed by Lucas Forschler.
553 * WebKitLauncher/WebKitLauncher.entitlements: Added.
554 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
556 2015-09-30 Jason Marcell <jmarcell@apple.com>
558 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
559 have an associated trac instance.
560 https://bugs.webkit.org/show_bug.cgi?id=149673
562 Reviewed by Alexey Proskuryakov.
564 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
565 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
566 have an associated trac instance.
568 2015-09-30 Daniel Bates <dabates@apple.com>
570 Prioritize testing latest build request on iOS test bots
571 https://bugs.webkit.org/show_bug.cgi?id=149669
573 Reviewed by Darin Adler.
575 We should prioritize testing of the latest build request on the iOS test bots
576 as we do for Mac and Windows test bots.
578 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
581 2015-09-30 Daniel Bates <dabates@apple.com>
583 Add buildbot category for iOS builders and testers
584 https://bugs.webkit.org/show_bug.cgi?id=149667
586 Reviewed by Darin Adler.
588 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
589 for iOS to the build.webkit.org home page.
591 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
593 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
595 2015-09-30 Daniel Bates <dabates@apple.com>
597 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
598 (https://bugs.webkit.org/show_bug.cgi?id=149539)
600 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
601 in <http://trac.webkit.org/changeset/190351>.
603 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
604 (CompileWebKit.start):
606 2015-09-30 Daniel Bates <dabates@apple.com>
608 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
609 (https://bugs.webkit.org/show_bug.cgi?id=149539)
611 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
612 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
614 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
615 (CompileWebKit.start):
617 2015-09-30 Lucas Forschler <lforschler@apple.com>
619 bot210 was configured for a queue instead of bot126.
621 Unreviewed config.json fix.
623 * BuildSlaveSupport/build.webkit.org-config/config.json:
625 2015-09-30 Lucas Forschler <lforschler@apple.com>
627 Bring El Capitan buildbot infrastructure online.
628 https://bugs.webkit.org/show_bug.cgi?id=149605
630 Reviewed by Darin Adler.
632 * BuildSlaveSupport/build.webkit.org-config/config.json:
634 2015-09-30 Tomas Popela <tpopela@redhat.com>
636 [GTK] Deprecation warnings in DOMNodeTest
637 https://bugs.webkit.org/show_bug.cgi?id=149663
639 After the webkit_dom_document_get_elements_by_tag_name deprecation we
640 need to update the tests to use webkit_dom_document_query_selector_all
641 to avoid compilation warnings.
643 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
644 (the suggested replacement for the deprecated function).
646 Reviewed by Carlos Garcia Campos.
648 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
649 (WebKitDOMNodeTest::testTagNamesNodeList):
650 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
652 (WebKitDOMNodeTest::testTagNames): Deleted.
653 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
654 (prepareDOMForTagNamesTests):
655 (testWebKitDOMNodeTagNamesNodeList):
656 (testWebKitDOMNodeTagNamesHTMLCollection):
658 (testWebKitDOMNodeTagNames): Deleted.
660 2015-09-29 Simon Fraser <simon.fraser@apple.com>
662 WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
663 https://bugs.webkit.org/show_bug.cgi?id=149650
665 Reviewed by Tim Horton.
667 TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
668 looks at the file path, and not the custom options that come from file comments.
670 Fix by computing TestOptions before making the TestInvocation, and setting them
671 as const TestInvocation data. This meant changing various call sites to take
672 the std::string pathOrURL, rather than the TestInvocation itself.
674 Also initialize TestInvocation with a WKURLRef, rather than a std::string.
676 * WebKitTestRunner/CMakeLists.txt:
677 * WebKitTestRunner/TestController.cpp:
678 (WTR::TestController::ensureViewSupportsOptionsForTest):
680 (WTR::createTestURL):
681 (WTR::updateTestOptionsFromTestHeader):
682 (WTR::TestController::testOptionsForTest):
683 (WTR::TestController::updateWebViewSizeForTest):
684 (WTR::TestController::updateWindowScaleForTest):
685 (WTR::TestController::runTest):
686 * WebKitTestRunner/TestController.h:
687 * WebKitTestRunner/TestInvocation.cpp:
688 (WTR::TestInvocation::TestInvocation):
689 (WTR::TestInvocation::invoke):
690 (WTR::createWKURL): Deleted.
691 (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
692 (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
693 * WebKitTestRunner/TestInvocation.h:
694 (WTR::TestInvocation::options):
695 * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
697 (WTR::shouldMakeViewportFlexible):
698 (WTR::shouldUseFixedLayout):
699 (WTR::isSVGTestPath):
700 (WTR::isHiDPITestPath):
701 (WTR::TestOptions::TestOptions):
702 * WebKitTestRunner/TestOptions.h:
703 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
704 * WebKitTestRunner/efl/TestControllerEfl.cpp:
706 (WTR::shouldUseFixedLayout):
707 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
708 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
709 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
710 * WebKitTestRunner/ios/TestControllerIOS.mm:
711 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
712 * WebKitTestRunner/mac/TestControllerMac.mm:
713 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
715 2015-09-29 Aakash Jain <aakash_jain@apple.com>
717 Flakiness dashboard should support OS X El Capitan
718 https://bugs.webkit.org/show_bug.cgi?id=149648
720 Reviewed by Alexey Proskuryakov.
722 * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
723 difference between new appscale and old Google App Engine implementation.
724 * TestResultServer/app.yaml: Same.
725 * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
727 2015-09-29 Daniel Bates <dabates@apple.com>
729 configure-xcode-for-ios-development does not work with Xcode 7
730 https://bugs.webkit.org/show_bug.cgi?id=149640
732 Reviewed by Alexey Proskuryakov.
734 When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
735 because it cannot find the Xcode specification files for iOS simulator and device. These
736 files have moved to a new location in Xcode 7 distribution. Moreover we must add the
737 relevant definitions to the Xcode 7 specification files directly as opposed to creating
738 new specification files with the added definitions (as we did in older versions of Xcode)
739 in order for Xcode 7 to honor these definitions.
741 * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
742 (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
743 (updateXcode7SpecificationFile): Added.
744 (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
745 (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
746 appropriate success message.
747 (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
748 (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
749 (createXcodeSpecificationFromSpecificationAndId): Deleted.
751 2015-09-29 Brent Fulgham <bfulgham@apple.com>
753 [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
754 https://bugs.webkit.org/show_bug.cgi?id=149639
756 Reviewed by Alex Christensen.
758 * Scripts/VCSUtils.pm:
759 (exitStatus): Use 'isWindows()' method.
760 (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
761 an error. This method could probably just go away.
762 (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
763 always changing to Unix style.
764 (unixPath): Added. Needed so Windows can always show a Unix path in the
766 (changeLogName): Work around the fact that 'getpwuid' is not available on
767 a pure Windows build of Perl.
768 * Scripts/prepare-ChangeLog:
769 (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
771 (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
772 support using arrays for 'open' arguments.
773 (resolveChangeLogsPath): Ditto.
774 (resolveConflictedChangeLogs): Use new helper functions.
775 (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
776 (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
777 quotes. Unix systems are happy either way.
778 (statusCommand): Ditto.
779 * Scripts/webkitdirs.pm:
780 (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
782 2015-09-29 Brent Fulgham <bfulgham@apple.com>
784 [Win] Unreviewed 64-bit build fix after switch to CMake.
786 * Scripts/webkitdirs.pm:
787 (determineIsWin64FromArchitecture): Added.
789 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
791 printing does not use minimum page zoom factor
792 https://bugs.webkit.org/show_bug.cgi?id=108507
794 Reviewed by Darin Adler.
796 WebKitTestRunner always takes the snapshots from the UI process
797 (expect for IOS), so in the case of printing, the layout in the
798 web view is not the expected one. When printing, we need to take
799 the snapshot in the web process and ensure it's rendered with a
802 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
803 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
804 kWKSnapshotOptionsPrinting option to
805 WKBundlePageCreateSnapshotWithOptions() when printing.
807 2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
809 [WTR] Pixel tests generate the snapshots twice in Web and UI processes
810 https://bugs.webkit.org/show_bug.cgi?id=149595
812 Reviewed by Tim Horton.
814 All ports except IOS implement
815 PlatformWebView::windowSnapshotImage() to generate the snapshot
816 for the pixel tests in the UI process. But we are still generating
817 a snapshot for pixel tests in the Web process too, that is passed
818 to the UI process but ignored.
819 Whether a pixel result is needed or not, is only known by the web
820 process depending on whether the test called dumpAsText with
821 dumpPixels == true or not. Since the pixels are now dump in the UI
822 process, we need to pass that information to the UI process when
823 the test is done. For that we set a PixelResultIsPending bool
824 parameter to the Done message, and we only add the PixelResult
825 when UI process doesn't need to generate the pixels dump.
827 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
828 (WTR::InjectedBundle::didReceiveMessageToPage): Set
829 m_pixelResultIsPending to false on reset.
830 (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
831 Done message, and set the PixelResult if m_pixelResultIsPending is false.
832 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
833 (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
834 (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
835 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
836 (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
838 * WebKitTestRunner/TestInvocation.cpp:
839 (WTR::TestInvocation::dumpResults): Use either the pixel result
840 from the web process or generate a pixel result from the web view
842 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
843 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
844 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
845 is created by the caller now, but the CG implementation needs to
846 know if it's a Web or UI process snapshot.
847 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
848 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
849 cairo surface for the given image.
850 * WebKitTestRunner/cg/TestInvocationCG.cpp:
851 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
852 CGContext for the given image.
854 2015-09-28 Dean Johnson <dean_johnson@apple.com>
856 Fix JS errors on dashboard metrics page
857 https://bugs.webkit.org/show_bug.cgi?id=149608
859 Reviewed by Alexey Proskuryakov.
861 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
862 (initPlatformsByFamily):
863 (updateHiddenPlatforms):
864 (parsePlatformFamily): Deleted.
865 (updateToggleButtons): Deleted.
866 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
867 (updateHiddenPlatforms): Added to remove errors.
868 (initPlatformsByFamily): Added to remove errors.
869 (unhiddenQueues): Updated to use Settings.
870 (documentReady): Added logic to add toggle buttons to the settings menu.
871 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
872 (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
873 MetricsMain.js to Settings.
874 (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
875 MetricsMain.js to Settings.
876 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
877 (QueueView.prototype._updateHiddenState): Updated to use Settings.
879 2015-09-28 Aakash Jain <aakash_jain@apple.com>
881 Appscale query fails because of missing index
882 https://bugs.webkit.org/show_bug.cgi?id=149609
884 Reviewed by Darin Adler.
886 * QueueStatusServer/index.yaml: Added the required index.
888 2015-09-28 Brent Fulgham <bfulgham@apple.com>
890 [Win] Fix the 64-bit build after switch to cmake.
892 Reviewed by Alex Christensen.
894 * Scripts/webkitdirs.pm:
895 (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
898 2015-09-28 Brent Fulgham <bfulgham@apple.com>
900 [Win] Allow Windows to run test-webkitpy without Cygwin
901 https://bugs.webkit.org/show_bug.cgi?id=149602
903 Reviewed by Alex Christensen.
905 These changes mostly shift from hard-coded paths using UNIX-style
906 separators to Python's "os.path.join" syntax that uses the correct
907 path separator for each platform.
909 * Scripts/webkitpy/common/system/path.py:
910 (cygpath): Don't pass paths through Cygpath on native Windows.
911 * Scripts/webkitpy/port/win.py:
912 (WinPort._path_to_apache): Use os.path.join.
913 (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
914 in 64-bit environments).
915 * Scripts/webkitpy/style/checker.py: Use os.path.join.
916 * Scripts/webkitpy/style/checker_unittest.py:
917 (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
918 (GlobalVariablesTest.test_path_rules_specifier): Ditto.
919 (GlobalVariablesTest): Ditto.
920 (GlobalVariablesTest.test_max_reports_per_category): Ditto.
921 (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
922 (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
923 (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
924 (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
925 (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
926 (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
927 (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
928 (StyleProcessor_CodeCoverageTest): Ditto.
929 (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
930 (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
931 (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
932 * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
933 manual string concatenation of paths.
935 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
937 Add bugzilla addresses of committers to contributors.json
938 https://bugs.webkit.org/show_bug.cgi?id=149520
940 Reviewed by Darin Adler.
942 * Scripts/webkitpy/common/config/contributors.json:
944 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
946 validate-committer-lists -b shouldn't need edituser privileges
947 https://bugs.webkit.org/show_bug.cgi?id=149519
949 Reviewed by Darin Adler.
951 * Scripts/validate-committer-lists:
952 (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
953 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
954 (BugzillaQueries.is_invalid_bugzilla_email):
955 (BugzillaQueries): Deleted.
956 (BugzillaQueries.fetch_logins_matching_substring): Deleted.
958 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
960 Unreviewed. Gardening: skip media stream tests failing after r190262.
962 * Scripts/run-gtk-tests:
965 2015-09-25 Alexey Proskuryakov <ap@apple.com>
967 [Mac] USE_INTERNAL_SDK is used undefined in tools projects
968 https://bugs.webkit.org/show_bug.cgi?id=149571
970 Reviewed by Dan Bernstein.
972 Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
974 * DumpRenderTree/mac/Configurations/Base.xcconfig:
975 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
976 * LayoutTestRelay/Configurations/Base.xcconfig:
977 * MiniBrowser/Configurations/Base.xcconfig:
978 * MiniBrowser/Configurations/DebugRelease.xcconfig:
979 * TestWebKitAPI/Configurations/Base.xcconfig:
980 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
981 * WebEditingTester/Configurations/Base.xcconfig:
982 * WebEditingTester/Configurations/DebugRelease.xcconfig:
983 * WebKitTestRunner/Configurations/Base.xcconfig:
984 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
985 * WebKitTestRunner/iOS.xcconfig: Removed.
987 2015-09-25 Eric Carlson <eric.carlson@apple.com>
989 Clean up user media request internal API
990 https://bugs.webkit.org/show_bug.cgi?id=149527
992 Reviewed by Tim Horton.
994 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
995 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
997 * WebKitTestRunner/TestController.cpp:
998 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1000 2015-09-25 Simon Fraser <simon.fraser@apple.com>
1002 [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1003 https://bugs.webkit.org/show_bug.cgi?id=149577
1005 Reviewed by Tim Horton.
1007 When calling testRunner.runUIScript() from a page load event, the script could run
1008 in the UI process before the current remote layer tree transaction had been handled
1009 there. This meant that runUIScript() could query state which was about to change.
1011 Fix by delaying the execution of the UI script until a layer tree transaction has
1012 been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1014 * WebKitTestRunner/TestInvocation.cpp:
1015 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1016 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1017 * WebKitTestRunner/TestInvocation.h:
1019 2015-09-25 Alexey Proskuryakov <ap@apple.com>
1021 [Mac] Media tests start to time out after a few days of bot uptime
1022 https://bugs.webkit.org/show_bug.cgi?id=149468
1024 Reviewed by Darin Adler.
1026 Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1027 as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1028 all temporary and cache files go to a custom location.
1030 * Scripts/webkitpy/port/base.py:
1031 * Scripts/webkitpy/port/driver.py:
1032 * Scripts/webkitpy/port/mac.py:
1033 * Scripts/webkitpy/port/win.py:
1034 (WinPort._driver_tempdir_for_environment): Deleted unused function.
1036 2015-09-25 Dan Bernstein <mitz@apple.com>
1038 Removed MiniBrowser.entitlements.
1040 Rubber-stamped by Anders Carlsson.
1042 The entitlements weren’t used anyway.
1044 * MiniBrowser/MiniBrowser.entitlements: Removed.
1045 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1047 2015-09-24 Daniel Bates <dabates@apple.com>
1049 Add WebKitSystemInterface for iOS 9.0
1050 https://bugs.webkit.org/show_bug.cgi?id=149550
1052 Rubber-stamped by Alexey Proskuryakov.
1054 * Scripts/copy-webkitlibraries-to-product-directory:
1056 2015-09-24 Daniel Bates <dabates@apple.com>
1058 Support building for arbitrary architectures
1059 https://bugs.webkit.org/show_bug.cgi?id=149539
1061 Reviewed by Alexey Proskuryakov.
1063 Teach buildbot to pass the architectures associated with the builder to build-webkit
1064 when building on OS X and iOS. As a side effect of this change we now support building
1065 universal binaries when multiples architectures are specified.
1067 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1068 (CompileWebKit.start):
1070 2015-09-24 Daniel Bates <dabates@apple.com>
1072 Fix the build after <http://trac.webkit.org/changeset/190212>
1073 (http://trac.webkit.org/changeset/190212)
1075 I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1077 * BuildSlaveSupport/built-product-archive:
1080 2015-09-24 Daniel Bates <dabates@apple.com>
1082 Support running unit tests on iOS Simulator test bot
1083 https://bugs.webkit.org/show_bug.cgi?id=149536
1085 Reviewed by Alexey Proskuryakov.
1087 Implements support for running unit tests on a iOS test bot. At the time of writing,
1088 the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1090 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1091 (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1092 (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1094 2015-09-24 Daniel Bates <dabates@apple.com>
1096 Add support infrastructure for OpenSource iOS builders and testers
1097 https://bugs.webkit.org/show_bug.cgi?id=149534
1099 Reviewed by Darin Adler.
1101 Towards setting up OpenSource iOS build bots, teach buildbot and its support
1104 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1105 (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1106 --ios-simulator or --device for a builder/tester whose full platform name begins with
1107 "ios-simulator" or "ios", respectively.
1108 (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1109 * BuildSlaveSupport/built-product-archive:
1110 (main): Pass the full platform name to determineWebKitBuildDirectory().
1111 (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1112 command line flag when building for iOS.
1113 (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1114 parameter fullPlatform. This parameter was originally added in r125066 to support the
1115 Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1116 (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1117 * BuildSlaveSupport/clean-build:
1118 (main): Call script webkit-build-directory with the appropriate command line flag when
1120 * BuildSlaveSupport/delete-stale-build-files:
1121 (main): Use the same logic for iOS as we do for Mac.
1122 (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1123 flag when building for iOS.
1124 * BuildSlaveSupport/test-result-archive:
1125 (archiveTestResults): Use the same logic for iOS as we do for Mac.
1127 2015-09-24 Daniel Bates <dabates@apple.com>
1129 Remove Chromium-specific changes to script built-product-archive
1130 https://bugs.webkit.org/show_bug.cgi?id=149530
1132 Rubber-stamped by Csaba Osztrogonác.
1134 Reverts changes made in r113074 and r113067 to support Chromium testers. The
1135 Chromium code has long since been removed from the OpenSource WebKit Project.
1137 * BuildSlaveSupport/built-product-archive:
1138 (createZipManually):
1140 (archiveBuiltProduct):
1142 2015-09-24 Dan Bernstein <mitz@apple.com>
1146 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1148 2015-09-24 Mark Lam <mark.lam@apple.com>
1150 Unreviewed. Make Lucas Forschler a WebKit reviewer.
1152 * Scripts/webkitpy/common/config/contributors.json:
1154 2015-09-24 Carlos Garcia Campos <cgarcia@igalia.com>
1156 Unreviewed. Fix GObject DOM API breaks after r190120.
1158 Bring back code removed in r169931 to handle documentation of
1162 (WebKitDOMDocGenerator):
1163 (WebKitDOMDocGenerator.write_deleted_classes):
1164 (WebKitDOMDocGenerator.generate):
1165 (write_deleted_classes):
1166 (WebKitDOMDocGeneratorSections._deleted_class):
1167 (WebKitDOMDocGeneratorSections._deleted_class.in):
1168 (WebKitDOMDocGeneratorSections.write_deleted_classes):
1169 (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1171 2015-09-23 Myles C. Maxfield <mmaxfield@apple.com>
1173 [Cocoa] [Font Features] Implement font-variant-*
1174 https://bugs.webkit.org/show_bug.cgi?id=148413
1176 Reviewed by Darin Adler.
1178 Update test font to use "lnum" feature.
1180 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1181 (Generator::appendGSUBTable):
1183 2015-09-22 Andy Estes <aestes@apple.com>
1185 ContentFiltering.AllowDownloadAfterAddData is very flaky
1186 https://bugs.webkit.org/show_bug.cgi?id=148885
1187 <rdar://problem/22729563>
1189 Reviewed by Alexey Proskuryakov.
1191 The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1192 but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1193 -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1195 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1198 2015-09-22 Alexey Proskuryakov <ap@apple.com>
1200 Mavericks: Media tests start to time out after a few days of bot uptime
1201 https://bugs.webkit.org/show_bug.cgi?id=149468
1203 Reviewed by Chris Dumez.
1205 * Scripts/webkitpy/port/base.py:
1206 * Scripts/webkitpy/port/driver.py:
1207 * Scripts/webkitpy/port/mac.py:
1209 2015-09-22 Nan Wang <n_wang@apple.com>
1211 Unreviewed, add myself to the committers list.
1213 * Scripts/webkitpy/common/config/contributors.json:
1215 2015-09-21 Simon Fraser <simon.fraser@apple.com>
1217 Remove 'nullable' to fix older iOS builds.
1219 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1220 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1222 2015-09-21 Brent Fulgham <bfulgham@apple.com>
1224 [Win] Show tiled drawing debug overlay on Windows
1225 https://bugs.webkit.org/show_bug.cgi?id=149426
1227 Reviewed by Dean Jackson.
1229 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1230 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1231 * MiniBrowser/win/Common.cpp:
1232 (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1234 * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1236 2015-09-21 Brent Fulgham <bfulgham@apple.com>
1238 [Win] Use command-line argument to launch in regular or High DPI mode.
1239 https://bugs.webkit.org/show_bug.cgi?id=149417
1241 Reviewed by Dean Jackson.
1243 * MiniBrowser/win/Common.cpp:
1244 (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1245 very start of execution, before the MiniBrowser.dll is loaded.
1246 * win/DLLLauncher/DLLLauncherMain.cpp:
1247 (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1248 present. On WinCairo, always use High DPI.
1250 2015-09-21 Ryosuke Niwa <rniwa@webkit.org>
1252 32-bit Mac build fix attempt after r190065.
1254 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1256 2015-09-21 Alexey Proskuryakov <ap@apple.com>
1258 [OS X] Update for Xcode 7.0 on Yosemite
1259 https://bugs.webkit.org/show_bug.cgi?id=149389
1261 Reviewed by Dan Bernstein.
1263 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1264 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1265 Removed unneeded declarations - conforming to a protocol is sufficient.
1267 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1268 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1269 Changed the definitions to be compiled whenever the SDK requires it (so we will have
1270 dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1272 2015-09-21 Simon Fraser <simon.fraser@apple.com>
1274 Add the ability for tests to run script in the UI process in WebKitTestRunner
1275 https://bugs.webkit.org/show_bug.cgi?id=149356
1277 Reviewed by Tim Horton.
1279 This change adds testRunner.runUIScript(script, callback), which allows a test
1280 to execute script in a JSContext which runs in the UI process. That context
1281 has bindings exposed through the UIScriptController interface; currently one test
1282 function, and some iOS-specific functions are included. UIScriptController can be
1283 async with a callback, and runUIScript() itself is asynchronous. When the UI
1284 script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1285 is a string passed back to the web process, and given to the runUIScript()
1288 Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1290 * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1291 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1292 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1293 (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1294 complete, call back into TestRunner.
1295 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1296 (WTR::nextUIScriptCallbackID):
1297 (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1298 (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1299 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1300 * WebKitTestRunner/PlatformWebView.h:
1301 * WebKitTestRunner/TestController.cpp:
1302 (WTR::updateTestOptionsFromTestHeader):
1303 (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1304 (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1305 * WebKitTestRunner/TestInvocation.cpp:
1306 (WTR::TestInvocation::shouldUseFixedLayout):
1307 (WTR::TestInvocation::shouldUseThreadedScrolling):
1308 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1309 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1310 (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1311 (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1312 * WebKitTestRunner/TestInvocation.h:
1313 * WebKitTestRunner/TestOptions.h:
1314 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1315 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1316 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1317 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1318 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1319 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1320 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1321 (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1322 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1323 (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1324 * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1325 (WTR::UIScriptController::doAsyncTask):
1326 (WTR::UIScriptController::zoomToScale):
1327 (WTR::UIScriptController::zoomScale):
1328 (WTR::UIScriptController::minimumZoomScale):
1329 (WTR::UIScriptController::maximumZoomScale):
1330 (WTR::UIScriptController::contentVisibleRect):
1331 * WebKitTestRunner/mac/EventSenderProxy.mm:
1332 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1333 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1334 * WebKitTestRunner/mac/TestControllerMac.mm:
1335 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1336 (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1337 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1338 * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1339 (UIScriptContext::UIScriptContext):
1340 (UIScriptContext::~UIScriptContext):
1341 (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1342 asynchronous, call the callback.
1343 (UIScriptContext::nextTaskCallbackID):
1344 (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1345 that has a callback). Has to store the callbackID of the script, so code called from the completion
1346 callback knows which UI script invoked it.
1347 (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1348 (UIScriptContext::uiScriptComplete):
1349 (UIScriptContext::objectFromRect): Make a JS object from a rect.
1350 * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1351 (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1352 * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1353 (WTR::UIScriptController::UIScriptController):
1354 (WTR::UIScriptController::makeWindowObject):
1355 (WTR::UIScriptController::wrapperClass):
1356 (WTR::UIScriptController::doAsyncTask):
1357 (WTR::UIScriptController::zoomToScale):
1358 (WTR::UIScriptController::zoomScale):
1359 (WTR::UIScriptController::minimumZoomScale):
1360 (WTR::UIScriptController::maximumZoomScale):
1361 (WTR::UIScriptController::contentVisibleRect):
1362 (WTR::UIScriptController::uiScriptComplete):
1363 * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1364 (WTR::UIScriptController::create):
1365 * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1367 2015-09-21 Tim Horton <timothy_horton@apple.com>
1369 Turn on threaded scrolling by default in the tests
1370 https://bugs.webkit.org/show_bug.cgi?id=149377
1372 Reviewed by Simon Fraser.
1374 * WebKitTestRunner/mac/TestControllerMac.mm:
1375 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1376 (WTR::shouldUseThreadedScrolling): Deleted.
1377 Turn on threaded scrolling by default.
1379 2015-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
1381 [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1382 https://bugs.webkit.org/show_bug.cgi?id=149252
1384 Reviewed by Darin Adler.
1386 In case of glib tests the test runner notifies about tests
1387 crashing, but for google tests we don't get any feedback, which
1388 means that in case of a test crashing we get a list of **PASS**
1389 messages and at the summary we are notified that the test suite
1390 has failed, but it's impossible to know which test cases have failed.
1392 * Scripts/run-gtk-tests:
1393 (TestRunner._run_google_test): Add a **CRASH** message if test
1396 2015-09-20 Alexey Proskuryakov <ap@apple.com>
1398 WebKitTestRunner can leak user content script results between tests
1399 https://bugs.webkit.org/show_bug.cgi?id=149391
1401 Reviewed by Sam Weinig.
1403 Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1404 about:blank, and thus about:blank doesn't have unintended side effects.
1406 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1407 (WTR::InjectedBundle::beginTesting):
1408 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1409 (WTR::InjectedBundlePage::resetAfterTest):
1411 2015-09-20 Alexey Proskuryakov <ap@apple.com>
1413 [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1414 https://bugs.webkit.org/show_bug.cgi?id=149384
1416 Reviewed by Chris Fleizach.
1418 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1419 (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1420 (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1421 regardless of whether someone else holds a reference (we also call -stopListening in
1424 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1425 (AccessibilityController::platformResetToConsistentState):
1426 (AccessibilityController::addNotificationListener):
1429 2015-09-20 Youenn Fablet <youenn.fablet@crf.canon.fr>
1431 Remove XHR_TIMEOUT compilation guard
1432 https://bugs.webkit.org/show_bug.cgi?id=149260
1434 Reviewed by Benjamin Poulain.
1436 * Scripts/webkitperl/FeatureList.pm:
1438 2015-09-19 Dan Bernstein <mitz@apple.com>
1440 Attempted build fix.
1442 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1444 2015-09-18 Commit Queue <commit-queue@webkit.org>
1446 Unreviewed, rolling out r189908.
1447 https://bugs.webkit.org/show_bug.cgi?id=149368
1449 Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1453 "printing does not use minimum page zoom factor"
1454 https://bugs.webkit.org/show_bug.cgi?id=108507
1455 http://trac.webkit.org/changeset/189908
1457 2015-09-18 Andy Estes <aestes@apple.com>
1459 [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1460 https://bugs.webkit.org/show_bug.cgi?id=149360
1462 Reviewed by Tim Horton.
1466 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1468 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1469 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1470 (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1472 * TestWebKitAPI/ios/pages.pages: Added.
1474 2015-09-18 Nan Wang <n_wang@apple.com>
1476 AX: Implement ARIA 1.1 @aria-current on iOS
1477 https://bugs.webkit.org/show_bug.cgi?id=149297
1479 Reviewed by Chris Fleizach.
1481 Added support to test aria-current on iOS.
1483 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1484 (AccessibilityUIElement::stringAttributeValue):
1485 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1486 (WTR::AccessibilityUIElement::stringAttributeValue):
1488 2015-09-18 Alexey Proskuryakov <ap@apple.com>
1490 iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1491 https://bugs.webkit.org/show_bug.cgi?id=149352
1493 Reviewed by Simon Fraser.
1495 * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1496 m_context can be null. This may indicate a bug in webkitpy too, but
1497 WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1498 wrong with opening and immediately closing it.
1500 2015-09-18 Daniel Bates <dabates@apple.com>
1502 isGitSVNDirectory() returns true when Git is not installed
1503 https://bugs.webkit.org/show_bug.cgi?id=149351
1505 Reviewed by Alexey Proskuryakov.
1507 Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1508 Git is not installed on the machine.
1510 * Scripts/VCSUtils.pm:
1511 (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1512 status code 0 (success).
1514 2015-09-18 Alex Christensen <achristensen@webkit.org>
1516 Prevent build-webkit from building four times on Windows
1517 https://bugs.webkit.org/show_bug.cgi?id=149336
1519 Reviewed by Brent Fulgham.
1521 * Scripts/build-webkit:
1522 Move the Windows code out of the for loop iterating over each subdirectory to be build.
1523 They're built all at once.
1524 * Scripts/webkitdirs.pm:
1525 (buildVisualStudioProject):
1526 (cmakeGeneratedBuildfile):
1527 Don't generate the Visual Studio solution if it already exists.
1528 It will run CMake again if necessary.
1530 2015-09-17 Simon Fraser <simon.fraser@apple.com>
1532 [iOS WK2] WTR fails to set the key window in the UIKit sense
1533 https://bugs.webkit.org/show_bug.cgi?id=149325
1535 Reviewed by Tim Horton.
1537 -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1538 This causes UIKit to bypass code that actually sets the key window, resulting in
1539 [UIAppliation sharedApplication].keyWindow always being nil.
1541 Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1542 -[WebKitTestRunnerWindow isKeyWindow] call super.
1544 * WebKitTestRunner/PlatformWebView.h:
1545 (WTR::PlatformWebView::setWindowIsKey): Deleted.
1546 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1547 (WTR::PlatformWebView::setWindowIsKey):
1548 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1549 (WTR::PlatformWebView::setWindowIsKey):
1550 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1551 (-[WebKitTestRunnerWindow isKeyWindow]):
1552 (WTR::PlatformWebView::PlatformWebView):
1553 (WTR::PlatformWebView::~PlatformWebView):
1554 (WTR::PlatformWebView::setWindowIsKey):
1555 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1556 (WTR::PlatformWebView::setWindowIsKey):
1558 2015-09-17 Simon Fraser <simon.fraser@apple.com>
1560 [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1561 https://bugs.webkit.org/show_bug.cgi?id=149321
1563 Reviewed by Tim Horton.
1565 InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
1566 enabled the "testing" viewport configuration, which disables page scaling.
1568 If we're running viewport tests, we want the normal web page configuration.
1569 Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1570 based on whether the test is in a "viewport" directory.
1572 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1573 (WTR::InjectedBundle::beginTesting):
1574 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1575 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1576 * WebKitTestRunner/TestInvocation.cpp:
1577 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1578 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1579 (WTR::TestInvocation::shouldMakeViewportFlexible):
1580 (WTR::TestInvocation::invoke):
1581 * WebKitTestRunner/TestInvocation.h:
1582 * WebKitTestRunner/ios/TestControllerIOS.mm:
1583 (WTR::TestController::platformConfigureViewForTest):
1584 (WTR::shouldMakeViewportFlexible): Deleted.
1586 2015-09-17 Simon Fraser <simon.fraser@apple.com>
1588 Give iOS WebKitTestRunner a launch storyboard
1589 https://bugs.webkit.org/show_bug.cgi?id=149314
1591 Reviewed by Dan Bates.
1593 Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1594 that it's been built for specific device configurations, and puts the window
1595 at the top of the screen. This simplifies coordinate conversions in a future patch.
1597 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1598 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1599 * WebKitTestRunner/ios/Launch.storyboard: Added.
1601 2015-09-17 Myles C. Maxfield <mmaxfield@apple.com>
1603 Update licence in r189890
1604 https://bugs.webkit.org/show_bug.cgi?id=149306
1606 Reviewed by Dean Jackson.
1608 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1609 * FontWithFeatures/FontWithFeatures/FontCreator.h:
1610 * FontWithFeatures/FontWithFeatures/main.cpp:
1612 2015-09-17 Mark Lam <mark.lam@apple.com>
1614 Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1615 https://bugs.webkit.org/show_bug.cgi?id=149285
1617 Reviewed by Saam Barati.
1619 Just need to add an option to pass --no-jit to run-jsc-stress-test.
1621 * Scripts/run-javascriptcore-tests:
1622 (runJSCStressTests):
1624 2015-09-17 Alex Christensen <achristensen@webkit.org>
1626 Switch AppleWin build to use CMake
1627 https://bugs.webkit.org/show_bug.cgi?id=149163
1629 Reviewed by Brent Fulgham.
1631 * Scripts/build-webkit:
1632 * Scripts/run-api-tests:
1635 (prepareEnvironmentForRunningTestTool):
1637 (testToolPath): Deleted.
1638 Run the API tests as separate executables on Windows.
1639 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1640 * Scripts/webkitdirs.pm:
1641 (checkRequiredSystemConfig):
1642 (jhbuildWrapperPrefixIfNeeded):
1643 (generateBuildSystemFromCMakeProject):
1644 Fix configuration quirks.
1646 2015-09-17 Dean Johnson <dean_johnson@apple.com>
1648 Added toggle options for hiding and showing certain platform families on the dashboard.
1649 https://bugs.webkit.org/show_bug.cgi?id=148403
1651 Reviewed by David Kilzer.
1653 This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1654 individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1655 families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1656 in lieu of an "all" button in the toggle menu.
1658 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1659 (parsePlatformFamily): Helper function to parse out a platform family.
1660 (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1661 page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1662 (updateToggleButtons): Updates the status of the toggle buttons.
1663 (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1664 (documentReady): Added creation of toggle buttons.
1665 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1666 (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1667 (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1668 (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
1669 this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1670 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1671 (QueueView): Updated to use hiddenPlatformFamilies.
1672 (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1673 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1674 (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1675 (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1676 (Settings.prototype.toggleHiddenPlatform): Deleted.
1677 (Settings.prototype.clearHiddenPlatforms): Deleted.
1678 (Settings.prototype.toggleShowPlatformFamily): Deleted.
1679 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1680 (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1681 (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1682 (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1683 (table.queue-grid tr.headers th):
1684 (div.settingsWrapper.hide):
1685 (div.settingsWrapper):
1686 (div.familyToggleWrapper):
1687 (div.platformFamilyToggleButton):
1688 (div.platformFamilyShowToggleButton:not(:last-child)):
1690 (div.accessibilityButton):
1691 (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1692 (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1693 (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1694 platformFamilyToggleButton and settingsWrapper class.
1695 (.accessibilityButton): Deleted.
1697 2015-09-17 Tim Horton <timothy_horton@apple.com>
1699 Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1700 https://bugs.webkit.org/show_bug.cgi?id=148904
1702 Reviewed by Myles Maxfield.
1704 * WebKitTestRunner/TestController.cpp:
1705 (WTR::parseBooleanTestHeaderValue):
1706 (WTR::updateViewOptionsFromTestHeader):
1707 Check for the key "useThreadedScrolling".
1708 Add some code to check for "true" and "false" for boolean options.
1710 (WTR::TestController::viewOptionsForTest):
1711 Apply the test's overrides last, even after the platform's.
1713 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
1715 printing does not use minimum page zoom factor
1716 https://bugs.webkit.org/show_bug.cgi?id=108507
1718 Reviewed by Darin Adler.
1720 WebKitTestRunner always takes the snapshots from the UI process
1721 (expect for IOS), so in the case of printing, the layout in the
1722 web view is not the expected one. When printing, we need to take
1723 the snapshot in the web process and ensure it's rendered with a
1726 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1727 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1728 kWKSnapshotOptionsPrinting option to
1729 WKBundlePageCreateSnapshotWithOptions() when printing. When not
1730 printing, don't even create the snapshot, since it will be ignored
1731 by the UI process that always creates its own from the WebView (expect for IOS platform)
1732 * WebKitTestRunner/TestInvocation.cpp:
1733 (WTR::TestInvocation::dumpResults): Use always the snapshot image
1734 received from the web process if any when comparing pixel
1735 results. Now we only receive a snapshot from the web process in
1736 case of printing, or when platform is IOS. Otherwhise, generate
1737 the snapshot from the WebView as usual.
1738 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1739 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1740 is created by the caller now, but the CG implementation needs to
1741 know if it's a Web or UI process snapshot.
1742 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1743 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1744 cairo surface for the given image.
1745 * WebKitTestRunner/cg/TestInvocationCG.cpp:
1746 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1747 CGContext for the given image.
1749 2015-09-16 Myles C. Maxfield <mmaxfield@apple.com>
1751 Create a font which can be used for testing font features
1752 https://bugs.webkit.org/show_bug.cgi?id=149237
1754 Reviewed by Simon Fraser.
1756 This patch adds a new project in the Tools/ directory which generates a font which can
1757 be used for testing font features. This is a standalone project consisting of two files:
1758 1. A file which actually generates the byte vector representing the font. This file has
1759 a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1760 specific, and only relies on the C++ STL.
1761 2. A file with a main() which calls generateFont() and writes out the font, as well as
1762 uses the font to render some demonstration text into a .png file. This file is platform
1765 The font itself only supports the following characters:
1766 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1767 However, the shape of these letters are either an X or a check mark.
1769 The letter "A" always is a check mark.
1770 The letter "B" always is an X.
1771 Without any font features turned on, the rest of the letters are shown as X.
1773 Each font feature has an letter associated with it. When the font feature is enabled,
1774 that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1777 Here are the mappings of font features to letters:
1809 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1810 * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1812 (roundDownToPowerOfTwo):
1813 (isFourByteAligned):
1816 (writeCFFEncodedNumber):
1817 (CFFBuilder::CFFBuilder):
1818 (CFFBuilder::takeResult):
1819 (CFFBuilder::moveTo):
1820 (CFFBuilder::lineTo):
1821 (CFFBuilder::curveToCubic):
1822 (CFFBuilder::closePath):
1823 (CFFBuilder::writePoint):
1824 (generateBoxCharString):
1825 (generateCheckCharString):
1826 (generateXCharString):
1827 (charStringForGlyph):
1828 (Generator::generate):
1829 (Generator::Placeholder::Placeholder):
1830 (Generator::Placeholder::populate):
1831 (Generator::Placeholder::~Placeholder):
1832 (Generator::placeholder):
1833 (Generator::append16):
1834 (Generator::append32):
1835 (Generator::append32BitCode):
1836 (Generator::overwrite16):
1837 (Generator::overwrite32):
1838 (Generator::appendCFFTable):
1839 (Generator::appendSubstitutionSubtable):
1840 (Generator::appendScriptSubtable):
1841 (Generator::appendGSUBTable):
1842 (Generator::appendOS2Table):
1843 (Generator::appendFormat12CMAPTable):
1844 (Generator::appendFormat4CMAPTable):
1845 (Generator::appendCMAPTable):
1846 (Generator::appendHEADTable):
1847 (Generator::appendHHEATable):
1848 (Generator::appendHMTXTable):
1849 (Generator::appendMAXPTable):
1850 (Generator::appendNAMETable):
1851 (Generator::appendPOSTTable):
1852 (Generator::calculateChecksum):
1853 (Generator::appendTable):
1855 * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1856 * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1857 (drawTextWithFeature):
1860 2015-09-16 Commit Queue <commit-queue@webkit.org>
1862 Unreviewed, rolling out r189875 and r189878.
1863 https://bugs.webkit.org/show_bug.cgi?id=149235
1865 cygwin cmake build not ready yet (Requested by alexchristensen
1868 Reverted changesets:
1870 "Switch AppleWin build to use CMake"
1871 https://bugs.webkit.org/show_bug.cgi?id=149163
1872 http://trac.webkit.org/changeset/189875
1874 "Cygwin build fix after r189875"
1875 http://trac.webkit.org/changeset/189878
1877 2015-09-16 Alex Christensen <achristensen@webkit.org>
1879 Cygwin build fix after r189875
1881 * Scripts/build-webkit:
1882 * Scripts/webkitdirs.pm:
1883 (jhbuildWrapperPrefixIfNeeded):
1884 (generateBuildSystemFromCMakeProject):
1885 Make things work with cygwin and cmake.
1887 2015-09-16 Alex Christensen <achristensen@webkit.org>
1889 Switch AppleWin build to use CMake
1890 https://bugs.webkit.org/show_bug.cgi?id=149163
1892 Reviewed by Brent Fulgham.
1894 * Scripts/build-webkit:
1896 * Scripts/run-api-tests:
1899 (prepareEnvironmentForRunningTestTool):
1901 (testToolPath): Deleted.
1902 Run the API tests as separate executables on Windows.
1903 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1905 2015-09-16 Alexey Proskuryakov <ap@apple.com>
1907 Add newer build.webkit.org pages to robots.txt
1908 https://bugs.webkit.org/show_bug.cgi?id=149219
1910 Reviewed by Darin Adler.
1912 Indexing bot watcher's dashboard can't be good.
1914 * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1916 2015-09-16 Alex Christensen <achristensen@webkit.org>
1918 Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1920 * BuildSlaveSupport/built-product-archive:
1923 2015-09-16 Csaba Osztrogonác <ossy@webkit.org>
1925 [EFL] Fix the help message of separated web process option of MiniBrowser
1926 https://bugs.webkit.org/show_bug.cgi?id=149212
1928 Reviewed by Gyuyoung Kim.
1930 * MiniBrowser/efl/main.c:
1932 2015-09-16 Alex Christensen <achristensen@webkit.org>
1934 Fix python syntax after r189851.
1936 * BuildSlaveSupport/built-product-archive:
1938 For loops need a colon.
1940 2015-09-15 Alex Christensen <achristensen@webkit.org>
1942 Fix Windows test bots after changing to non-cygwin build
1943 https://bugs.webkit.org/show_bug.cgi?id=149196
1945 Reviewed by Daniel Bates.
1947 * BuildSlaveSupport/built-product-archive:
1949 Using different versions of python makes what I think is https://bugs.python.org/issue15795
1950 prevent us from executing files from the archive on the test bots.
1952 2015-09-15 Ryosuke Niwa <rniwa@webkit.org>
1954 Add ShadowRoot interface and Element.prototype.attachShadow
1955 https://bugs.webkit.org/show_bug.cgi?id=149187
1957 Reviewed by Antti Koivisto.
1959 * Scripts/webkitperl/FeatureList.pm:
1961 2015-09-15 Aakash Jain <aakash_jain@apple.com>
1963 Appscale queue status json output lacks bots
1964 https://bugs.webkit.org/show_bug.cgi?id=149194
1965 <rdar://problem/22171089>
1967 Reviewed by Alexey Proskuryakov.
1969 * QueueStatusServer/handlers/queuestatusjson.py:
1970 (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1971 * QueueStatusServer/index.yaml: Index according to appscale requirements.
1973 2015-09-15 Brent Fulgham <bfulgham@apple.com>
1975 [Win] Provide a means for viewing the layer tree
1976 https://bugs.webkit.org/show_bug.cgi?id=149165
1978 Reviewed by Simon Fraser.
1980 Update MiniBrowser with a new Debug menu option that will
1981 dump the current layer tree to the debug console.
1983 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1984 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1985 * MiniBrowser/win/Common.cpp:
1986 (WndProc): Add handler for 'Print Layer Tree' menu option.
1987 * MiniBrowser/win/MiniBrowser.cpp:
1988 (MiniBrowser::printLayerTree): Added Handler.
1989 * MiniBrowser/win/MiniBrowser.h:
1991 2015-09-14 Myles C. Maxfield <mmaxfield@apple.com>
1993 WebKitTestRunner declarative language setting is broken for iOS
1994 https://bugs.webkit.org/show_bug.cgi?id=149119
1998 In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1999 lost in the final version which got committed. This simply implements the existing
2000 OS X behavior on iOS.
2002 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2003 (WTR::InjectedBundle::platformInitialize):
2005 2015-09-14 Dewei Zhu <dewei_zhu@apple.com>
2007 Unreviewed, add myself to committers list.
2009 * Scripts/webkitpy/common/config/contributors.json:
2011 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
2013 [Cocoa] Allow testing with the system language
2014 https://bugs.webkit.org/show_bug.cgi?id=148671
2016 Reviewed by Anders Carlsson and Alexey Proskuryakov.
2018 React to tests marked with language=lang1,lang2,etc in their header.
2019 Once this information is parsed, pass it to
2020 WKContextConfigurationSetOverrideLanguages().
2022 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2023 (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2025 * WebKitTestRunner/TestController.cpp:
2026 (WTR::TestController::createWebViewWithOptions): Call
2027 WKContextConfigurationSetOverrideLanguages().
2028 (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2029 * WebKitTestRunner/TestOptions.h:
2030 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2031 (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2032 option to restart the web process.
2033 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2034 (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2036 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
2038 [WKTR] Allow changing the WKContextConfiguration between successive tests
2039 https://bugs.webkit.org/show_bug.cgi?id=148833
2041 Reviewed by Tim Horton.
2043 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2044 However, there are certain tests which require specifying options in this object. This patch makes
2045 our existing code for recreating the test runner web view also recreate the WKContext.
2047 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2050 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2051 * WebKitTestRunner/PlatformWebView.h:
2052 (WTR::PlatformWebView::options):
2053 * WebKitTestRunner/TestController.cpp:
2054 (WTR::TestController::initialize):
2055 (WTR::TestController::generateContextConfiguration):
2056 (WTR::TestController::generatePageConfiguration):
2057 (WTR::TestController::createWebViewWithOptions):
2058 (WTR::TestController::ensureViewSupportsOptionsForTest):
2059 (WTR::updateContextConfigurationOptionsFromTestHeader):
2060 (WTR::TestController::contextConfigurationOptionsForTest):
2061 (WTR::TestController::platformCreateWebView):
2062 (WTR::TestController::platformCreateOtherPage):
2063 (WTR::updateViewOptionsFromTestHeader): Deleted.
2064 (WTR::TestController::viewOptionsForTest): Deleted.
2065 * WebKitTestRunner/TestController.h:
2066 (WTR::TestController::injectedBundlePath):
2067 (WTR::TestController::testPluginDirectory):
2068 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2069 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2070 (WTR::TestController::platformCreateWebView):
2071 (WTR::TestController::platformCreateOtherPage):
2072 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2073 (WTR::PlatformWebView::PlatformWebView):
2074 (WTR::PlatformWebView::viewSupportsOptions):
2075 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2076 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2077 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2078 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2079 (WTR::PlatformWebView::PlatformWebView):
2080 (WTR::PlatformWebView::viewSupportsOptions):
2081 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2082 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2083 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2084 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2085 (WTR::PlatformWebView::PlatformWebView):
2086 (WTR::PlatformWebView::viewSupportsOptions):
2087 * WebKitTestRunner/ios/TestControllerIOS.mm:
2088 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2089 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2090 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2091 (WTR::PlatformWebView::PlatformWebView):
2092 (WTR::PlatformWebView::viewSupportsOptions):
2093 * WebKitTestRunner/mac/TestControllerMac.mm:
2094 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2095 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2097 2015-09-11 Michael Saboff <msaboff@apple.com>
2099 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2100 https://bugs.webkit.org/show_bug.cgi?id=149083
2102 Reviewed by Alexey Proskuryakov.
2104 Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2106 * DumpRenderTree/mac/LayoutTestHelper.m:
2107 (colorProfileURLForDisplay):
2109 2015-09-11 Saam barati <sbarati@apple.com>
2111 There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2112 https://bugs.webkit.org/show_bug.cgi?id=149058
2114 Reviewed by Geoffrey Garen.
2116 * Scripts/run-jsc-stress-tests:
2118 2015-09-10 Commit Queue <commit-queue@webkit.org>
2120 Unreviewed, rolling out r189595.
2121 https://bugs.webkit.org/show_bug.cgi?id=149052
2123 The tests still fail (Requested by ap on #webkit).
2127 "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2129 https://bugs.webkit.org/show_bug.cgi?id=142929
2130 http://trac.webkit.org/changeset/189595
2132 2015-09-10 Alexey Proskuryakov <ap@apple.com>
2134 Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2135 https://bugs.webkit.org/show_bug.cgi?id=142929
2137 Reviewed by Brent Fulgham.
2139 Silence the logging. We'll track fixing the root cause in Radar.
2141 * Scripts/webkitpy/port/mac.py:
2142 (MacPort.stderr_patterns_to_strip): Added a FIXME.
2144 * Scripts/webkitpy/port/win.py:
2145 (WinPort.logging_patterns_to_strip): Added.
2147 2015-09-09 Andy Estes <aestes@apple.com>
2149 [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2150 https://bugs.webkit.org/show_bug.cgi?id=149022
2152 Reviewed by Daniel Bates.
2154 Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2155 did not account for this.
2157 * Scripts/webkitpy/xcode/simulator.py:
2158 (Simulator): Optionally matched a revision at the end of a runtime version number.
2159 * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2161 2015-09-09 Andy Estes <aestes@apple.com>
2163 [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2164 https://bugs.webkit.org/show_bug.cgi?id=149029
2165 <rdar://problem/22432624>
2167 Reviewed by Daniel Bates.
2169 * Scripts/webkitpy/xcode/simulator.py:
2170 (Simulator): Taught to parse tvOS runtimes.
2171 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2173 2015-09-09 Alexey Proskuryakov <ap@apple.com>
2175 Fix bit rot on bot watcher's dashboard page
2176 https://bugs.webkit.org/show_bug.cgi?id=149012
2178 Reviewed by Tim Horton.
2180 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2181 The code path used by the metrics page was trying to add properties to an undefined.
2183 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2184 Silence an expection that would occur when the step has no logs. This should never
2185 happen, but it did (perhaps buildbot was misconfigured for a while).
2187 2015-09-09 Alexey Proskuryakov <ap@apple.com>
2189 Update LayoutTestRelay xcconfig file.
2191 Rubber-stamped by Dan Bernstein.
2193 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2195 2015-09-09 Saam barati <sbarati@apple.com>
2197 DFG should have a debugging option that runs a phase that flushes all locals
2198 https://bugs.webkit.org/show_bug.cgi?id=148916
2200 Reviewed by Filip Pizlo.
2202 * Scripts/run-jsc-stress-tests:
2204 2015-09-09 Commit Queue <commit-queue@webkit.org>
2206 Unreviewed, rolling out r189530 and r189534.
2207 https://bugs.webkit.org/show_bug.cgi?id=148996
2209 Caused assertion failures on Yosemite (Requested by litherum
2212 Reverted changesets:
2214 "[WKTR] Allow changing the WKContextConfiguration between
2216 https://bugs.webkit.org/show_bug.cgi?id=148833
2217 http://trac.webkit.org/changeset/189530
2219 "[Cocoa] Fix the tests after r189530"
2220 http://trac.webkit.org/changeset/189534
2222 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
2224 [Cocoa] Fix the tests after r189530
2228 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2229 (WTR::initializeWebViewConfiguration):
2231 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
2233 [WKTR] Allow changing the WKContextConfiguration between successive tests
2234 https://bugs.webkit.org/show_bug.cgi?id=148833
2236 Reviewed by Tim Horton.
2238 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2239 However, there are certain tests which require specifying options in this object. This patch makes
2240 our existing code for recreating the test runner web view also recreate the WKContext.
2242 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2245 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2246 * WebKitTestRunner/PlatformWebView.h:
2247 (WTR::PlatformWebView::options):
2248 * WebKitTestRunner/TestController.cpp:
2249 (WTR::TestController::initialize):
2250 (WTR::TestController::generateContextConfiguration):
2251 (WTR::TestController::generatePageConfiguration):
2252 (WTR::TestController::createWebViewWithOptions):
2253 (WTR::TestController::ensureViewSupportsOptionsForTest):
2254 (WTR::updateContextConfigurationOptionsFromTestHeader):
2255 (WTR::TestController::contextConfigurationOptionsForTest):
2256 (WTR::TestController::platformCreateWebView):
2257 (WTR::TestController::platformCreateOtherPage):
2258 (WTR::updateViewOptionsFromTestHeader): Deleted.
2259 (WTR::TestController::viewOptionsForTest): Deleted.
2260 * WebKitTestRunner/TestController.h:
2261 (WTR::TestController::injectedBundlePath):
2262 (WTR::TestController::testPluginDirectory):
2263 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2264 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2265 (WTR::TestController::platformCreateWebView):
2266 (WTR::TestController::platformCreateOtherPage):
2267 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2268 (WTR::PlatformWebView::PlatformWebView):
2269 (WTR::PlatformWebView::viewSupportsOptions):
2270 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2271 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2272 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2273 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2274 (WTR::PlatformWebView::PlatformWebView):
2275 (WTR::PlatformWebView::viewSupportsOptions):
2276 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2277 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2278 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2279 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2280 (WTR::PlatformWebView::PlatformWebView):
2281 (WTR::PlatformWebView::viewSupportsOptions):
2282 * WebKitTestRunner/ios/TestControllerIOS.mm:
2283 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2284 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2285 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2286 (WTR::PlatformWebView::PlatformWebView):
2287 (WTR::PlatformWebView::viewSupportsOptions):
2288 * WebKitTestRunner/mac/TestControllerMac.mm:
2289 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2290 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2292 2015-09-08 Daniel Bates <dabates@apple.com>
2294 [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2295 https://bugs.webkit.org/show_bug.cgi?id=148980
2297 Reviewed by Alexey Proskuryakov.
2299 Add setting to enable/disable accelerated drawing so as to support testing
2300 this feature in MiniBrowser on Mac.
2302 * MiniBrowser/mac/SettingsController.h:
2303 * MiniBrowser/mac/SettingsController.m:
2304 (-[SettingsController _populateMenu]): Add menu item.
2305 (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2306 (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2307 (-[SettingsController acceleratedDrawingEnabled]): Added.
2308 * MiniBrowser/mac/WK1BrowserWindowController.m:
2309 (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2310 * MiniBrowser/mac/WK2BrowserWindowController.m:
2311 (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2313 2015-09-08 Jason Marcell <jmarcell@apple.com>
2315 Unreviewed. Added myself as a commiter in contributors.json.
2317 * Scripts/webkitpy/common/config/contributors.json:
2319 2015-09-08 Keith Miller <keith_miller@apple.com>
2321 Unreviewed, added myself to the list of contributors.
2323 * Scripts/webkitpy/common/config/contributors.json:
2325 2015-09-08 Daniel Bates <dabates@apple.com>
2327 Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2328 https://bugs.webkit.org/show_bug.cgi?id=148921
2330 Reviewed by Alexey Proskuryakov.
2332 The ring image is positioned above the platform icon in markup and we specify the CSS
2333 property z-index for the ring image so that it is painted on top of the platform icon
2334 instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2335 of the ring image, switch the order of these DOM elements and remove the use of the CSS
2336 property z-index to achieve a similar effect.
2338 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2339 (documentReady): Create the platform icon image element before the ring image such that
2340 the ring image is painted on top of the platform icon.
2341 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2342 (table.queue-grid td.logo img.ring): Removed property z-index.
2344 2015-09-08 Daniel Bates <dabates@apple.com>
2346 Dashboard: Remove duplicate gear icon data URLs
2347 https://bugs.webkit.org/show_bug.cgi?id=148920
2349 Reviewed by Alexey Proskuryakov.
2351 Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2352 background-image associated with each of the three gear icon states: collapsed (.settings), hover
2353 (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2354 as a mask and make use of the CSS background-color to define the fill color for each of these three
2357 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2358 (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
2359 (.settings:hover): Override CSS background-color for hover state.
2360 (.settings-visible .settings): Override CSS background-color for expanded state.
2362 2015-09-07 Andy Estes <aestes@apple.com>
2364 [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2365 https://bugs.webkit.org/show_bug.cgi?id=148946
2366 <rdar://problem/22603981>
2368 Reviewed by Dan Bernstein.
2370 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2371 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2373 2015-09-07 Hunseop Jeong <hs85.jeong@samsung.com>
2375 [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2376 https://bugs.webkit.org/show_bug.cgi?id=148927
2378 Reviewed by Csaba Osztrogonác.
2380 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2381 overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2383 * WebKitTestRunner/TestController.cpp:
2384 (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2385 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2386 (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2388 2015-09-07 Andy Estes <aestes@apple.com>
2390 Fix the Production build after r189455.
2392 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2393 In-App Purchase template instead of the Aggregate template. Whoops.
2395 2015-09-06 Andy Estes <aestes@apple.com>
2397 WebKit.xcworkspace should be be able to build iOS platforms
2398 https://bugs.webkit.org/show_bug.cgi?id=148881
2400 Reviewed by Daniel Bates.
2402 Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2403 for all supported platforms.
2405 * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2406 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2407 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2408 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2410 2015-09-06 Andy Estes <aestes@apple.com>
2412 WebKitTestRunner should build for iOS using the default target
2413 https://bugs.webkit.org/show_bug.cgi?id=148918
2415 Reviewed by Daniel Bates.
2417 When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2418 iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2419 non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2421 This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2422 both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2423 and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2424 WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2425 WebKitTestRunner is skipped when installing on iOS.
2427 The target dependency graph now looks like this:
2431 WebKitTestRunner (Library)
2432 WebKitTestRunnerInjectedBundle
2435 WebKitTestRunner (Library)
2436 WebKitTestRunnerInjectedBundle
2439 * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2440 * Scripts/build-webkittestrunner: Ditto.
2441 * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2442 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2443 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2444 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2445 excluded iOS-only files, and skipped installing on iOS.
2446 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2447 excluded Mac-only files, and skipped installing on Mac.
2448 * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2449 * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2450 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2451 Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2452 new configuration files.
2454 2015-09-05 Joseph Pecoraro <pecoraro@apple.com>
2456 Web Inspector: Improve prepare-ChangeLog for multiple cases
2457 https://bugs.webkit.org/show_bug.cgi?id=148875
2459 Reviewed by Timothy Hatcher.
2461 * Scripts/prepare-ChangeLog:
2462 (get_function_line_ranges_for_javascript):
2463 - We were ignoring everything inside of an anonymous function expression,
2464 such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2465 Better handle this by inserting a few tweaks.
2466 - Allow method syntax outside of classes as long as they are at the global level.
2467 - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2469 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2470 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2471 (Foo.prototype.method1):
2472 (Foo.prototype.method2):
2473 (Foo.prototype.method3.innerFunction):
2474 (Foo.prototype.method3):
2475 (insideGlobalAnonymousFunctionExpression):
2476 (foo.insideGlobalFunctionExpression):
2477 (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2478 (IssueWithMapGetAndSet.prototype.method1):
2479 (IssueWithMapGetAndSet.prototype.method2):
2480 (IssueWithMapGetAndSet.prototype.method3):
2481 (IssueWithMapGetAndSet):
2483 2015-09-05 Yusuke Suzuki <utatane.tea@gmail.com>
2485 [ES6] Enable ES6 Module in JSC shell by default
2486 https://bugs.webkit.org/show_bug.cgi?id=148689
2488 Reviewed by Geoffrey Garen.
2490 * Scripts/run-javascriptcore-tests:
2491 (runJSCStressTests):
2492 * Scripts/run-jsc-stress-tests:
2494 2015-09-04 Basile Clement <basile_clement@apple.com>
2496 Unreviewed, change my email address.
2498 * Scripts/webkitpy/common/config/contributors.json:
2500 2015-09-04 Beth Dakin <bdakin@apple.com>
2502 Should have a test to make sure links don't navigate after a cancelled force
2504 https://bugs.webkit.org/show_bug.cgi?id=148846
2506 Reviewed by Tim Horton.
2508 New EventSender function for a started then cancelled force click.
2509 * WebKitTestRunner/EventSenderProxy.h:
2510 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2511 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2512 (WTR::EventSendingController::mouseForceClick):
2513 (WTR::EventSendingController::startAndCancelMouseForceClick):
2514 (WTR::EventSendingController::mouseForceDown):
2515 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2516 * WebKitTestRunner/TestController.cpp:
2517 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2518 * WebKitTestRunner/mac/EventSenderProxy.mm:
2519 (WTR::EventSenderProxy::mouseForceClick):
2520 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2521 (WTR::EventSenderProxy::mouseForceDown):
2522 (WTR::EventSenderProxy::mouseMoveTo):
2524 2015-09-04 Tim Horton <timothy_horton@apple.com>
2526 Add a test for r179736 (programmatic navigation during swipe causing a crash)
2527 https://bugs.webkit.org/show_bug.cgi?id=148830
2529 Reviewed by Beth Dakin.
2531 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2532 (WTR::InjectedBundle::beginTesting):
2533 Make sure that TestRunner callbacks don't leak between tests!
2535 2015-09-04 Anders Carlsson <andersca@apple.com>
2537 It should be possible to pass relative HTTP test paths to DumpRenderTree
2538 https://bugs.webkit.org/show_bug.cgi?id=148825
2539 <rdar://problem/22583866>
2541 Reviewed by Tim Horton.
2543 Convert the path to an absolute path if needed.
2545 * DumpRenderTree/mac/DumpRenderTree.mm:
2548 2015-09-04 Jason Marcell <jmarcell@apple.com>
2550 Fix Swift unit tests for prepare-ChangeLog.
2551 https://bugs.webkit.org/show_bug.cgi?id=148817
2553 Reviewed by Alexey Proskuryakov.
2555 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2556 Swift unit tests for prepare-ChangeLog.
2558 2015-09-04 Lucas Forschler <lforschler@apple.com>
2560 Modifications to the webkit-nightly logic.
2562 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2564 * WebKitLauncher/main.m:
2565 (displayErrorAndQuit):
2567 2015-09-04 Beth Dakin <bdakin@apple.com>
2569 Speculative build fix.
2571 * WebKitTestRunner/mac/EventSenderProxy.mm:
2573 2015-09-04 Brian Burg <bburg@apple.com>
2575 Web Inspector: InspectorController should support multiple frontend channels
2576 https://bugs.webkit.org/show_bug.cgi?id=148538
2578 Reviewed by Joseph Pecoraro.
2580 InspectorClients must explicitly disconnect their frontend channel(s) from the
2581 inspected page's InspectorController.
2583 To make this possible, DumpRenderTree should not destroy non-primary views until
2584 it has tried to close any abandoned Web Inspector instances. Performing teardown
2585 in the reverse order prevents disconnection of the frontend channel because that
2586 prematurely destroys the inspector frontend client.
2588 * DumpRenderTree/mac/DumpRenderTree.mm:
2590 * DumpRenderTree/win/DumpRenderTree.cpp:
2593 2015-09-04 Beth Dakin <bdakin@apple.com>
2595 Need to be able to test default behaviors on force click
2596 https://bugs.webkit.org/show_bug.cgi?id=148758
2598 Reviewed by Tim Horton.
2600 This patch adds a new eventSender method to do a full, completed force click,
2601 and it re-works all of the existing force methods to dispatch their events in
2602 such a way that they will trigger the NSImmediateAction gesture recognizer.
2603 To do this, first we need to send the events to the app rather than straight
2604 to the view, and also needed to tweak some state and send the events in a
2607 New public function mouseForceClick() and private helper functions to make
2609 * WebKitTestRunner/EventSenderProxy.h:
2611 New public function mouseForceClick().
2612 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2613 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2614 (WTR::EventSendingController::mouseMoveTo):
2615 (WTR::EventSendingController::mouseForceClick):
2616 (WTR::EventSendingController::mouseForceDown):
2617 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2618 * WebKitTestRunner/TestController.cpp:
2619 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2621 initPressureEventAtLocation needs to take a stageTransition and a window.
2622 * WebKitTestRunner/mac/EventSenderProxy.mm:
2623 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2624 (-[EventSenderSyntheticEvent stageTransition]):
2625 (-[EventSenderSyntheticEvent timestamp]):
2626 (-[EventSenderSyntheticEvent _cgsEventRecord]):
2627 (-[EventSenderSyntheticEvent window]):
2629 In order to enter the gesture recognizer, we need to start with a mouse down
2630 that has a NSEventMaskPressure modifier.
2631 (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2633 This ensures that the events queue properly for the force monitor in AppKit.
2634 (WTR::spinRunLoopForForce):
2636 We need to start the pressure change events with a began.
2637 (WTR::EventSenderProxy::beginPressureEvent):
2639 These functions can be used to create the NSEvent for a pressure change every
2641 (WTR::EventSenderProxy::pressureChangeEvent):
2643 Send the right series of events to emulate a full, completed force click.
2644 (WTR::EventSenderProxy::mouseForceClick):
2646 Use all of the new things for these existing functions.
2647 (WTR::EventSenderProxy::mouseForceDown):
2648 (WTR::EventSenderProxy::mouseForceUp):
2649 (WTR::EventSenderProxy::mouseForceChanged):
2651 Set NSFakeForceTouchDevice to YES.
2652 * WebKitTestRunner/mac/main.mm:
2653 (setDefaultsToConsistentValuesForTesting):
2655 2015-09-04 Jason Marcell <jmarcell@apple.com>
2657 prepare-ChangeLog needs to know how to parse Swift files.
2658 https://bugs.webkit.org/show_bug.cgi?id=148784
2659 <rdar://problem/22510062>
2661 Reviewed by Darin Adler.
2663 * Scripts/prepare-ChangeLog:
2664 (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2665 (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2666 (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2667 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2668 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2669 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2670 (freeFunction): Ditto.
2671 (MyClass.function): Ditto.
2672 (MyClass.functionWithArgument(_:)): Ditto.
2673 (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2674 (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2675 (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2676 (MyClass.classFunction): Ditto.
2677 (MyClass.readWriteComputedVariable): Ditto.
2678 (MyClass.readOnlyComputedVariable): Ditto.
2680 2015-09-04 Ryosuke Niwa <rniwa@webkit.org>
2682 Import css/css-color-3
2683 https://bugs.webkit.org/show_bug.cgi?id=148803
2685 Reviewed by Chris Dumez.
2687 Fixed a bug that the imported reference files used the same extention as tests.
2688 This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2690 * Scripts/webkitpy/w3c/test_importer.py:
2691 (TestImporter.find_importable_tests):
2693 2015-09-03 Commit Queue <commit-queue@webkit.org>
2695 Unreviewed, rolling out r189338.
2696 https://bugs.webkit.org/show_bug.cgi?id=148785
2698 Caused tons of crashes (Requested by cdumez on #webkit).
2702 "Web Inspector: InspectorController should support multiple
2704 https://bugs.webkit.org/show_bug.cgi?id=148538
2705 http://trac.webkit.org/changeset/189338
2707 2015-09-03 Brian Burg <bburg@apple.com>
2709 Web Inspector: InspectorController should support multiple frontend channels
2710 https://bugs.webkit.org/show_bug.cgi?id=148538
2712 Reviewed by Joseph Pecoraro.
2714 InspectorClients must explicitly disconnect their frontend channel(s) from the
2715 inspected page's InspectorController.
2717 To make this possible, DumpRenderTree should not destroy non-primary views until
2718 it has tried to close any abandoned Web Inspector instances. Performing teardown
2719 in the reverse order prevents disconnection of the frontend channel because that
2720 prematurely destroys the inspector frontend client.
2722 * DumpRenderTree/mac/DumpRenderTree.mm:
2724 * DumpRenderTree/win/DumpRenderTree.cpp:
2727 2015-09-03 Timothy Hatcher <timothy@apple.com>
2729 Update WebKit nightly icon to be more like Safari
2730 https://bugs.webkit.org/show_bug.cgi?id=148768
2732 Reviewed by Joseph Pecoraro.
2734 * WebKitLauncher/webkit.icns:
2736 2015-09-03 Geoffrey Garen <ggaren@apple.com>
2738 JavaScriptCore should have some ES6 conformance tests
2739 https://bugs.webkit.org/show_bug.cgi?id=148771
2741 Reviewed by Chris Dumez.
2743 * Scripts/run-javascriptcore-tests:
2744 (runJSCStressTests): Added es6 as a test suite.
2746 * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2748 Some of these tests currently fail, so I also added a way to expect
2749 failure for now. We'll migrate failing tests to expected passes as we
2752 2015-09-03 Tim Horton <timothy_horton@apple.com>
2754 Add a test for swipe-start hysteresis
2755 https://bugs.webkit.org/show_bug.cgi?id=148756
2757 Reviewed by Anders Carlsson.
2759 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2760 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2761 (WTR::cacheTestRunnerCallback):
2762 (WTR::TestRunner::clearTestRunnerCallbacks):
2763 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2764 Make sure that we log if a client tries to install a callback twice
2765 (since we use .add, the second call would not work).
2767 Also, add clearTestRunnerCallbacks so tests can swap out installed
2770 2015-09-03 Anders Carlsson <andersca@apple.com>
2772 DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2773 https://bugs.webkit.org/show_bug.cgi?id=148746
2774 rdar://problem/22568073
2776 Reviewed by Tim Horton.
2778 * DumpRenderTree/mac/DumpRenderTree.mm:
2780 Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
2783 Call computeTestURL.
2786 Get rid of this; computeTestURL does this for us now.
2788 * Scripts/webkitpy/port/driver.py:
2789 (Driver._command_from_driver_input):
2790 Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2792 2015-09-03 Tim Horton <timothy_horton@apple.com>
2794 Swipe tests fail on Mavericks
2795 https://bugs.webkit.org/show_bug.cgi?id=148752
2797 Reviewed by Beth Dakin.
2799 * WebKitTestRunner/mac/EventSenderProxy.mm:
2801 2015-09-03 Tim Horton <timothy_horton@apple.com>
2803 Fix the 32-bit build
2805 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2806 (WTR::PlatformWebView::setNavigationGesturesEnabled):
2808 2015-09-03 Tim Horton <timothy_horton@apple.com>
2810 Remove some logging that wasn't meant to be in the tree
2812 * WebKitTestRunner/mac/EventSenderProxy.mm:
2813 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2815 2015-09-03 Tim Horton <timothy_horton@apple.com>
2817 [Mac] Add support for testing swipes
2818 https://bugs.webkit.org/show_bug.cgi?id=148700
2820 Reviewed by Beth Dakin.
2822 * WebKitTestRunner/EventSenderProxy.h:
2823 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2824 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2825 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2826 (WTR::cgEventPhaseFromString):
2827 (WTR::cgEventMomentumPhaseFromString):
2828 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2829 (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2830 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2831 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2832 (WTR::InjectedBundle::didReceiveMessageToPage):
2833 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2834 (WTR::TestRunner::installDidBeginSwipeCallback):
2835 (WTR::TestRunner::installWillEndSwipeCallback):
2836 (WTR::TestRunner::installDidEndSwipeCallback):
2837 (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2838 (WTR::TestRunner::callDidBeginSwipeCallback):
2839 (WTR::TestRunner::callWillEndSwipeCallback):
2840 (WTR::TestRunner::callDidEndSwipeCallback):
2841 (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2842 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2843 * WebKitTestRunner/TestController.cpp:
2844 (WTR::TestController::createOtherPage):
2845 (WTR::TestController::createWebViewWithOptions):
2846 (WTR::TestController::didReceiveMessageFromInjectedBundle):
2847 (WTR::TestController::didBeginNavigationGesture):
2848 (WTR::TestController::willEndNavigationGesture):
2849 (WTR::TestController::didEndNavigationGesture):
2850 (WTR::TestController::didRemoveNavigationGestureSnapshot):
2851 * WebKitTestRunner/TestController.h:
2852 * WebKitTestRunner/TestInvocation.cpp:
2853 (WTR::TestInvocation::didBeginSwipe):
2854 (WTR::TestInvocation::willEndSwipe):
2855 (WTR::TestInvocation::didEndSwipe):
2856 (WTR::TestInvocation::didRemoveSwipeSnapshot):
2857 * WebKitTestRunner/TestInvocation.h:
2858 Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2859 when the snapshot is removed.
2861 Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2862 mouseScrollBy function.
2864 * WebKitTestRunner/mac/EventSenderProxy.mm:
2865 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2866 (-[EventSenderSyntheticEvent type]):
2867 (-[EventSenderSyntheticEvent subtype]):
2868 (-[EventSenderSyntheticEvent locationInWindow]):
2869 (-[EventSenderSyntheticEvent location]):
2870 (-[EventSenderSyntheticEvent momentumPhase]):
2871 (-[EventSenderSyntheticEvent _isTouchesEnded]):
2872 (-[EventSenderSyntheticEvent _cgsEventRecord]):
2873 Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2874 more adjustable values.
2876 (WTR::EventSenderProxy::mouseForceDown):
2877 (WTR::EventSenderProxy::mouseForceUp):
2878 (WTR::EventSenderProxy::mouseForceChanged):
2879 Adopt EventSenderSyntheticEvent.
2881 (WTR::nsEventPhaseFromCGEventPhase):
2882 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2883 Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2885 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2886 (WTR::PlatformWebView::PlatformWebView):
2889 2015-09-03 Myles C. Maxfield <mmaxfield@apple.com>
2891 [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2892 https://bugs.webkit.org/show_bug.cgi?id=148723
2894 Reviewed by Anders Carlsson.
2896 * WebKitTestRunner/TestController.cpp:
2898 (WTR::updateViewOptionsFromTestHeader):
2899 (WTR::TestController::viewOptionsForTest):
2901 2015-09-03 Lucas Forschler <lforschler@apple.com>
2905 2015-09-02 Tim Horton <timothy_horton@apple.com>
2907 Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2908 https://bugs.webkit.org/show_bug.cgi?id=148693
2910 Reviewed by Anders Carlsson.
2912 * WebKitTestRunner/TestController.cpp:
2913 (WTR::TestController::createOtherPage):
2914 (WTR::TestController::createWebViewWithOptions):
2916 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
2918 REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2919 https://bugs.webkit.org/show_bug.cgi?id=148529
2921 Reviewed by Darin Adler.
2923 When there are pending EventSender messages after a test finishes,
2924 they could be processed in the main loop started by the
2925 resetStateToConsistentValues(), but the old EventSender has been
2926 replaced by a new one at that point. The new Eventsender can crash
2927 when processing messages that were sent to the old one. To avoid
2928 this, we return early when receiving an EventSender message and
2929 the TestController state is not RunningTest.
2931 * WebKitTestRunner/TestController.cpp:
2932 (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2933 (WTR::TestController::didReceiveMessageFromInjectedBundle):
2935 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
2937 REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2938 https://bugs.webkit.org/show_bug.cgi?id=148528
2940 Reviewed by Darin Adler.
2942 Before r188548 resetStateToConsistentValues() was called in
2943 TestController::run(), before tests are run, but now it's called
2944 for every test in TestInvocation::invoke(), after m_status has
2945 changed to RunningTest.
2947 * WebKitTestRunner/TestController.cpp:
2948 (WTR::TestController::resetStateToConsistentValues): Use
2949 TemporaryChange to reset m_state ot its previous value after reset
2952 2015-08-31 Jason Marcell <jmarcell@apple.com>
2954 Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2955 that are marked as requiring corresponding tests.
2956 https://bugs.webkit.org/show_bug.cgi?id=148498
2957 <rdar://problem/21555314>
2959 Reviewed by Dan Bernstein and David Kilzer.
2961 * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2962 simulate Git's attribute behevaior.
2963 (main): Added "requiresTests" array to contain files that require tests.
2964 (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2965 section in ChangeLog.
2966 (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2967 however, we check if the file or any containing folder has the given property set to "1" and
2968 return 1 if so; return 0 otherwise.
2969 (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2970 adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2972 2015-08-26 Andy Estes <aestes@apple.com>
2974 [Content Filtering] Determine navigation and content policy before continuing to filter a load
2975 https://bugs.webkit.org/show_bug.cgi?id=148506
2977 Reviewed by Brady Eidson.
2979 Added download API tests covering every decision and decision point.
2980 Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2982 * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2983 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2984 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2985 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2986 returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2987 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2988 decision and decision point as a bundle parameter.
2989 (+[MockContentFilterEnabler supportsSecureCoding]):
2990 (-[MockContentFilterEnabler copyWithZone:]):
2991 (-[MockContentFilterEnabler initWithCoder:]):
2992 (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2993 (-[MockContentFilterEnabler encodeWithCoder:]):
2994 (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2995 (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2996 (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2997 (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2998 (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2999 (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3000 (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3001 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3002 the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3003 singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3004 (+[MockContentFilterEnabler supportsSecureCoding]):
3005 (-[MockContentFilterEnabler copyWithZone:]):
3006 (-[MockContentFilterEnabler initWithCoder:]):
3007 (-[MockContentFilterEnabler dealloc]):
3008 (-[MockContentFilterEnabler encodeWithCoder:]):
3009 (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3010 (-[ContentFilteringPlugIn dealloc]): Stop observing.
3011 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3012 (+[ServerRedirectPlugIn initialize]): Deleted.
3013 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3014 (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3015 (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3018 2015-08-31 Filip Pizlo <fpizlo@apple.com>
3020 Skip slow lock tests on Windows/debug
3021 https://bugs.webkit.org/show_bug.cgi?id=148643
3023 Reviewed by Alexey Proskuryakov.
3025 The lock tests simulate a critical section by doing some floating point math, and then either
3026 make those critical sections very long or invoke them many times. This appears to be
3027 particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3028 that kind of computation slow.
3030 These tests are almost as useful in release as they are in debug, so it's probably better to
3031 just skip the in debug on platforms where this causes timeouts.
3033 * TestWebKitAPI/Tests/WTF/Lock.cpp:
3034 (TestWebKitAPI::runLockTest):
3035 (TestWebKitAPI::skipSlow):
3036 (TestWebKitAPI::TEST):
3038 2015-08-29 Chris Fleizach <cfleizach@apple.com>
3040 AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3041 https://bugs.webkit.org/show_bug.cgi?id=125720
3043 Reviewed by Daniel Bates.
3045 Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3047 * DumpRenderTree/AccessibilityUIElement.cpp:
3049 (scrollToMakeVisibleWithSubFocusCallback):
3050 (scrollToGlobalPointCallback):
3051 (scrollToMakeVisibleCallback):
3052 (AccessibilityUIElement::getJSClass):
3053 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3054 (AccessibilityUIElement::scrollToMakeVisible):
3055 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3056 (AccessibilityUIElement::scrollToGlobalPoint):
3057 (AccessibilityUIElement::selectedTextRange):
3058 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3059 (AccessibilityUIElement::AccessibilityUIElement):
3060 (AccessibilityUIElement::mathPrescriptsDescription):
3061 (AccessibilityUIElement::scrollToMakeVisible):
3062 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3063 (AccessibilityUIElement::scrollToGlobalPoint):
3064 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3065 (WTR::AccessibilityUIElement::isTextMarkerValid):
3066 (WTR::AccessibilityUIElement::textMarkerForIndex):
3067 (WTR::AccessibilityUIElement::scrollToMakeVisible):
3068 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3069 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3070 (WTR::AccessibilityUIElement::supportedActions):
3071 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3072 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3073 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3074 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3075 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3076 (WTR::AccessibilityUIElement::scrollToMakeVisible):
3077 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3078 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3079 (WTR::AccessibilityUIElement::selectedTextRange):
3080 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3081 (WTR::AccessibilityUIElement::scrollToMakeVisible):
3082 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3083 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3084 (WTR::AccessibilityUIElement::selectedTextRange):
3086 2015-08-28 Timothy Horton <timothy_horton@apple.com>
3088 Add a mysteriously nonproblematic missing comma.
3090 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3091 (TestExpectationParser._collect_matching_tests):
3092 (TestExpectationParser):
3094 2015-08-28 Timothy Horton <timothy_horton@apple.com>
3096 Remove an old temporary script that has served its purpose
3098 * Scripts/convert-test-expectations: Removed.
3100 2015-08-28 Jer Noble <jer.noble@apple.com>
3102 [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3103 https://bugs.webkit.org/show_bug.cgi?id=148579
3105 Reviewed by Anders Carlsson.
3107 In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3109 In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3110 and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3112 * DumpRenderTree/mac/DumpRenderTree.mm:
3113 (resetWebPreferencesToConsistentValues):
3114 (resetWebViewToConsistentStateBeforeTesting):
3115 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3116 (WTR::initializeWebViewConfiguration):
3118 2015-08-28 Alexey Proskuryakov <ap@apple.com>
3120 Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3121 https://bugs.webkit.org/show_bug.cgi?id=148592
3123 Reviewed by Tim Horton.
3125 * Scripts/webkitpy/port/base.py:
3126 (Port.to.setup_environ_for_server):
3128 (Port.to._append_value_colon_separated):
3129 (Port.to.show_results_html_file):
3130 * Scripts/webkitpy/port/ios.py:
3131 (IOSSimulatorPort.setup_environ_for_server):
3132 * Scripts/webkitpy/port/mac.py:
3133 (MacPort.setup_environ_for_server):
3135 2015-08-28 Filip Pizlo <fpizlo@apple.com>
3137 LICM should be sound even if the CFG has changed
3138 https://bugs.webkit.org/show_bug.cgi?id=148259
3140 Reviewed by Benjamin Poulain.
3142 Add a utility for creating tests that set some uncommon option.
3144 * Scripts/run-jsc-stress-tests:
3146 2015-08-28 Brent Fulgham <bfulgham@apple.com>
3148 [Win] Unreviewed EWS correction.
3150 * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3152 2015-08-28 Jer Noble <jer.noble@apple.com>
3154 [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3155 https://bugs.webkit.org/show_bug.cgi?id=147512
3157 Reviewed by Anders Carlsson.
3159 Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3160 to a consistent (true) value.
3162 * DumpRenderTree/mac/DumpRenderTree.mm:
3163 (setDefaultsToConsistentValuesForTesting):
3164 * WebKitTestRunner/TestController.cpp:
3165 (WTR::TestController::resetPreferencesToConsistentValues):
3167 2015-08-28 Tim Horton <timothy_horton@apple.com>
3169 Add navigation gesture callbacks to WKPageNavigationClient
3170 https://bugs.webkit.org/show_bug.cgi?id=148568
3171 <rdar://problem/22371346>
3173 Reviewed by Anders Carlsson.
3175 * WebKitTestRunner/TestController.cpp:
3176 (WTR::TestController::createOtherPage):
3177 (WTR::TestController::createWebViewWithOptions):
3180 2015-08-28 Alexey Proskuryakov <ap@apple.com>
3182 [Mac] kill-old-processes should kill more processes
3183 https://bugs.webkit.org/show_bug.cgi?id=148577
3185 Reviewed by Tim Horton.
3187 * BuildSlaveSupport/kill-old-processes:
3189 2015-08-28 Jason Marcell <jmarcell@apple.com>
3191 The status message for combined builder queues should say "all builds succeeded" if everything
3193 https://bugs.webkit.org/show_bug.cgi?id=148535
3195 Reviewed by David Kilzer and Alexey Proskuryakov.
3197 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3198 (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3199 say "all builds succeeded" if everything built correctly.
3201 2015-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
3203 [GTK] Simplify the internal API to create a WebView
3204 https://bugs.webkit.org/show_bug.cgi?id=148570
3206 Reviewed by Žan Doberšek.
3208 * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3209 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3210 (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3211 PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3212 (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3213 passing the received PageConfiguration.
3214 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3215 (WTR::PlatformWebView::PlatformWebView): Create the WebView
3216 passing the received PageConfiguration.
3218 2015-08-27 Aakash Jain <aakash_jain@apple.com>
3220 iOS Simulator API tests fails as Simulator is not running
3221 https://bugs.webkit.org/show_bug.cgi?id=148501
3222 rdar://problem/22447525
3224 Reviewed by Daniel Bates.
3226 This change is a workaround for <rdar://problem/22388812>.
3228 * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3229 and quit it on program termination when running tests on the iOS port.
3230 * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3231 SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3233 2015-08-27 Alex Christensen <achristensen@webkit.org>
3235 Make DLLLauncherMain executables dependent on dll
3236 https://bugs.webkit.org/show_bug.cgi?id=148548
3238 Reviewed by Brent Fulgham.
3240 * DumpRenderTree/CMakeLists.txt:
3241 * DumpRenderTree/PlatformWin.cmake:
3242 * MiniBrowser/win/CMakeLists.txt:
3243 * TestWebKitAPI/CMakeLists.txt:
3244 * TestWebKitAPI/PlatformWin.cmake:
3246 2015-08-27 Lucas Forschler <lforschler@apple.com>
3248 Remove Mac slaves 188/189 after being replaced with 400/401.
3252 * BuildSlaveSupport/build.webkit.org-config/config.json:
3254 2015-08-27 Lucas Forschler <lforschler@apple.com>
3256 Add two bots to the Mac Yosemite queue.
3257 This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3261 * BuildSlaveSupport/build.webkit.org-config/config.json:
3263 2015-08-27 Alex Christensen <achristensen@webkit.org>
3265 [Win CMake] Fix incremental build after r188673
3266 https://bugs.webkit.org/show_bug.cgi?id=148539
3268 Reviewed by Brent Fulgham.
3270 * TestWebKitAPI/PlatformWin.cmake:
3271 Copy forwarding headers from WebCore before building in case that was not yet done.
3272 It used to be done when running CMake, but now it's a build step.
3274 2015-08-27 Nan Wang <n_wang@apple.com>
3276 AX: Fix accessibility/select-element-at-index.html test
3277 https://bugs.webkit.org/show_bug.cgi?id=148516
3279 Reviewed by Chris Fleizach.
3281 Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3283 * DumpRenderTree/AccessibilityUIElement.cpp:
3284 (setSelectedChildCallback):
3285 (setSelectedChildAtIndexCallback):
3286 (removeSelectionAtIndexCallback):
3287 (elementAtPointCallback):
3288 (sentenceAtOffsetCallback):
3289 (stringForSelectionCallback):
3290 (AccessibilityUIElement::getJSClass):
3291 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3292 (AccessibilityUIElement::setSelectedChild):
3293 (AccessibilityUIElement::setSelectedChildAtIndex):
3294 (AccessibilityUIElement::removeSelectionAtIndex):
3295 (AccessibilityUIElement::accessibilityValue):
3296 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3297 (WTR::AccessibilityUIElement::wordAtOffset):
3298 (WTR::AccessibilityUIElement::lineAtOffset):
3299 (WTR::AccessibilityUIElement::sentenceAtOffset):
3300 (WTR::AccessibilityUIElement::isSelectable):
3301 (WTR::AccessibilityUIElement::isMultiSelectable):
3302 (WTR::AccessibilityUIElement::setSelectedChild):
3303 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3304 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3305 (WTR::AccessibilityUIElement::selectedChildrenCount):
3306 (WTR::AccessibilityUIElement::selectedChildAtIndex):
3307 (WTR::AccessibilityUIElement::isExpanded):
3308 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3309 (WTR::AccessibilityUIElement::setSelectedChild):
3310 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3311 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3312 (WTR::AccessibilityUIElement::accessibilityValue):
3314 2015-08-27 Alex Christensen <achristensen@webkit.org>
3316 Build fix after r188982
3318 * MiniBrowser/win/CMakeLists.txt:
3319 The directory structure changed in the move.
3321 2015-08-27 Michael Catanzaro <mcatanzaro@igalia.com>
3323 [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3325 geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3327 * gtk/install-dependencies:
3329 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
3331 Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3333 * Scripts/run-gtk-tests:
3336 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
3338 Fix GTK+ WTR crashes in initializeMainRunLoop()
3340 Rubber-stamped by Žan Doberšek.
3342 Initialize threading and main thread before
3343 RunLoop::initializeMainRunLoop(), since the GLib implementation of
3344 the RunLoop uses isMainThread() to decide whether to create a new
3345 GMainContext or use the default one. Also use RunLoop::run() and
3346 ::stop() instead of gtk_main/quit.
3348 * WebKitTestRunner/TestController.cpp:
3349 (WTR::TestController::initialize):
3350 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3351 (WTR::TestController::notifyDone):
3352 (WTR::TestController::platformRunUntil):
3354 2015-08-27 Filip Pizlo <fpizlo@apple.com>
3356 Unreviewed, further shorten a test that times out because it's very long
3359 I've locally run these tests on repeat for 24 hours and found no genuine
3360 failures, like deadlocks. So, the timeouts are probably because the test
3361 machine is slow and debug is slow. We should just run this test for fewer
3364 * TestWebKitAPI/Tests/WTF/Lock.cpp:
3365 (TestWebKitAPI::TEST):
3367 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
3369 Unreviewed build fix attempt on EFL
3371 * WebKitTestRunner/PlatformEfl.cmake:
3373 2015-08-26 Alex Christensen <achristensen@webkit.org>
3375 Build fix after r188982
3377 * MiniBrowser/win/CMakeLists.txt:
3378 Find .rc files in correct directory.
3380 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
3382 [EFL] Bump cairo version to 1.14.2
3383 https://bugs.webkit.org/show_bug.cgi?id=148474
3385 Reviewed by Csaba Osztrogonác.
3387 * efl/jhbuild.modules:
3389 2015-08-26 Andy Estes <aestes@apple.com>
3391 Crash when following a Google search link to Twitter with Limit Adult Content enabled
3392 https://bugs.webkit.org/show_bug.cgi?id=147651
3394 Rubber-stamped by Brady Eidson.
3396 Taught TestRunner how to decide the navigation policy after a delay.
3398 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3399 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3400 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3401 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3402 (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3403 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3404 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3405 * WebKitTestRunner/TestController.cpp:
3406 (WTR::TestController::initialize):
3407 (WTR::TestController::resetStateToConsistentValues):
3408 (WTR::TestController::decidePolicyForNavigationAction):
3409 * WebKitTestRunner/TestController.h:
3410 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3411 * WebKitTestRunner/TestInvocation.cpp:
3412 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3414 2015-08-26 Brent Fulgham <bfulgham@apple.com>
3416 [Win] Rename 'WinLauncher' to 'MiniBrowser'
3417 https://bugs.webkit.org/show_bug.cgi?id=148485
3419 Reviewed by Alex Christensen
3421 Move the WinLauncher project and source files to a subdirectory
3422 of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3423 source code and project files.
3425 * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3426 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3427 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3428 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3429 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3430 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3431 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3432 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3433 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3434 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3435 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3436 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3437 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3438 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3439 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3440 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3441 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3442 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3443 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3444 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3445 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3446 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3447 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3448 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3449 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3450 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3451 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3452 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3453 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3454 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3455 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3456 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3457 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3458 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3459 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3460 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3461 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3462 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3463 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3464 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3465 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3466 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3467 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3468 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3469 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3470 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3471 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3472 * MiniBrowser/win: Copied from WinLauncher.
3473 * MiniBrowser/win/Common.cpp:
3474 * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3475 * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3476 * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3477 * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3478 * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3479 * MiniBrowser/win/PageLoadTestClient.cpp:
3480 * MiniBrowser/win/PageLoadTestClient.h:
3481 * MiniBrowser/win/ResourceLoadDelegate.cpp:
3482 * MiniBrowser/win/ResourceLoadDelegate.h:
3483 * MiniBrowser/win/WinLauncher.cpp: Removed.
3484 * MiniBrowser/win/WinLauncher.h: Removed.
3485 * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3486 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3487 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3488 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3489 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3490 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3491 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3492 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3493 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3494 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3495 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3496 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3497 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3498 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3499 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3500 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3501 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3502 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3503 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3504 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3505 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3506 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3507 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3508 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3509 * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3510 * MiniBrowser/win/WinLauncherReplace.h: Removed.
3511 * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3512 * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3513 * MiniBrowser/win/WinMain.cpp:
3514 * WinLauncher: Removed.
3515 * WinLauncher/AccessibilityDelegate.cpp: Removed.
3516 * WinLauncher/AccessibilityDelegate.h: Removed.
3517 * WinLauncher/CMakeLists.txt: Removed.
3518 * WinLauncher/Common.cpp: Removed.
3519 * WinLauncher/DOMDefaultImpl.cpp: Removed.
3520 * WinLauncher/DOMDefaultImpl.h: Removed.
3521 * WinLauncher/PageLoadTestClient.cpp: Removed.
3522 * WinLauncher/PageLoadTestClient.h: Removed.
3523 * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3524 * WinLauncher/PrintWebUIDelegate.h: Removed.
3525 * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3526 * WinLauncher/ResourceLoadDelegate.h: Removed.
3527 * WinLauncher/WebDownloadDelegate.cpp: Removed.
3528 * WinLauncher/WebDownloadDelegate.h: Removed.
3529 * WinLauncher/WinLauncher.cpp: Removed.
3530 * WinLauncher/WinLauncher.h: Removed.
3531 * WinLauncher/WinLauncher.vcxproj: Removed.
3532 * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3533 * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3534 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3535 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3536 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3537 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3538 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3539 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3540 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3541 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3542 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3543 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3544 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3545 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3546 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3547 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3548 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3549 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3550 * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3551 * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3552 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3553 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3554 * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3555 * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3556 * WinLauncher/WinLauncherReplace.h: Removed.
3557 * WinLauncher/WinLauncherWebHost.cpp: Removed.
3558 * WinLauncher/WinLauncherWebHost.h: Removed.
3559 * WinLauncher/WinMain.cpp: Removed.
3560 * WinLauncher/resource.h: Removed.
3561 * WinLauncher/stdafx.cpp: Removed.
3562 * WinLauncher/stdafx.h: Removed.
3563 * win/AssembleBuildLogs/AssembleLogs.cmd:
3565 2015-08-26 Brent Fulgham <bfulgham@apple.com>
3567 [Win] Simplify menu handling code in WinLauncher
3568 https://bugs.webkit.org/show_bug.cgi?id=148461
3570 Reviewed by Zalan Bujtas.
3572 Revise 'ToggleMenuItem' to return a boolean value indicating if
3573 it handled the message. Revise WndProc to use this to decide if it
3574 should pass the message on to the default handler, rather than
3575 duplicating the logic in both places.
3577 * WinLauncher/Common.cpp:
3578 (ToggleMenuItem): Return true if the menu item message was handled.
3579 (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3580 the message tothe default handler.
3582 2015-08-26 Csaba Osztrogonác <ossy@webkit.org>
3584 Remove unused code after r188948
3585 https://bugs.webkit.org/show_bug.cgi?id=148467
3587 Reviewed by Gyuyoung Kim.
3589 * WebKitTestRunner/TestController.cpp:
3590 (WTR::TestController::platformPreferences): Deleted.
3592 2015-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3594 [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3595 https://bugs.webkit.org/show_bug.cgi?id=148377
3597 Reviewed by Carlos Garcia Campos.
3599 EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3600 It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3601 TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3602 EFL and GTK at the moment.
3604 * WebKitTestRunner/TestController.cpp:
3605 (WTR::TestController::platformWillRunTest):
3606 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3607 (WTR::TestController::platformPreferences):
3608 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3609 (WTR::TestController::platformPreferences):
3611 2015-08-25 Nan Wang <n_wang@apple.com>
3613 AX: Enable accessibility/aria-controls.html test for mac
3614 https://bugs.webkit.org/show_bug.cgi?id=148458
3616 Reviewed by Chris Fleizach.
3618 Implemented ariaControlsElementAtIndex(unsigned index).
3620 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3621 (AccessibilityUIElement::ariaControlsElementAtIndex):
3622 (AccessibilityUIElement::disclosedRowAtIndex):
3623 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3624 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3626 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3628 Remove python tests for PassRefPtr
3629 https://bugs.webkit.org/show_bug.cgi?id=148463
3631 Reviewed by Andy Estes.
3633 As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3635 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3636 (PassPtrTest): Deleted.
3637 (PassPtrTest.assert_pass_ptr_check): Deleted.
3638 (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3639 (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3640 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3641 (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3642 (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3643 (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3645 2015-08-25 Andy Estes <aestes@apple.com>
3647 [iOS] run-webkit-tests fails if watchOS SDK is installed
3648 https://bugs.webkit.org/show_bug.cgi?id=148453
3650 Reviewed by David Kilzer.
3652 * Scripts/webkitpy/xcode/simulator.py:
3653 (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3654 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3656 2015-08-25 Aakash Jain <aakash_jain@apple.com>
3658 iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3659 https://bugs.webkit.org/show_bug.cgi?id=148197
3660 rdar://problem/22334382
3662 Reviewed by Daniel Bates.
3664 * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3665 * Scripts/webkitpy/port/ios.py:
3666 (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3667 (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3668 (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3669 (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3670 (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3672 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3674 Remove PassRefPtr style check rule
3675 https://bugs.webkit.org/show_bug.cgi?id=148432
3677 Reviewed by Andreas Kling.
3679 PassRefPtr is being removed. Thus style rule needs to be removed as well.
3681 * Scripts/webkitpy/style/checkers/cpp.py:
3682 (_check_parameter_name_against_text): Deleted.
3683 (check_function_definition_and_pass_ptr): Deleted.
3684 (check_function_definition): Deleted.
3685 (check_pass_ptr_usage): Deleted.
3686 (process_line): Deleted.
3687 (CppChecker): Deleted.
3689 2015-08-25 Brent Fulgham <bfulgham@apple.com>
3691 [Win] Expose "Inverted Colors" option in WinLauncher
3692 https://bugs.webkit.org/show_bug.cgi?id=148451
3694 Reviewed by Tim Horton.
3696 Add the ability to toggle the "Inverted Colors" preference
3699 * WinLauncher/Common.cpp:
3700 (ToggleMenuItem): Toggle the feature when the menu item
3702 (WndProc): Recognize the new menu option.
3703 * WinLauncher/WinLauncher.cpp:
3704 (WinLauncher::setToDefaultPreferences): Launch with "Invert
3706 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3707 entry for "Invert Colors".
3708 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3710 2015-08-25 Nan Wang <n_wang@apple.com>
3712 [Mac] accessibility/document-attributes.html fails
3713 https://bugs.webkit.org/show_bug.cgi?id=116636
3715 Reviewed by Chris Fleizach.
3717 Implemented documentURI() and documentEncoding().
3719 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3720 (AccessibilityUIElement::documentEncoding):
3721 (AccessibilityUIElement::documentURI):
3722 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3723 (WTR::AccessibilityUIElement::documentEncoding):
3724 (WTR::AccessibilityUIElement::documentURI):
3726 2015-08-24 Brent Fulgham <bfulgham@apple.com>
3728 [Win] Unreviewed test gardening.
3730 Fix another case where the logging string is constructed using the variable 'frame',
3731 but the method argument is not given a name. This causes the global 'frame' value to
3732 be used, producing incorrect output.
3734 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3735 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3738 2015-08-24 Tim Horton <timothy_horton@apple.com>
3740 (Finally...) get rid of WKViewIOS
3741 https://bugs.webkit.org/show_bug.cgi?id=148404
3743 Reviewed by Anders Carlsson.
3745 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3746 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3747 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3748 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3749 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3750 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3751 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3752 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3753 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3754 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3755 Mark tests that use WKBrowsingContextController as Mac-only.
3757 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3758 (WTR::AccessibilityController::addNotificationListener):
3759 * WebKitTestRunner/ios/mainIOS.mm:
3760 (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3761 Import UIKit instead of depending on WKView.h to do so.
3763 2015-08-24 Jason Marcell <jmarcell@apple.com>
3765 Add support to dashboard for displaying Git SHA's as revisions.
3766 https://bugs.webkit.org/show_bug.cgi?id=148387
3768 Reviewed by Daniel Bates.
3770 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3771 (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3772 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3773 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3774 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3775 "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3777 2015-08-24 Andy Estes <aestes@apple.com>
3779 REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3781 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3783 2015-08-23 Andy Estes <aestes@apple.com>
3785 Addressed a missed piece of review feedback from r188851.
3787 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3789 2015-08-23 Andy Estes <aestes@apple.com>
3791 [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3792 https://bugs.webkit.org/show_bug.cgi?id=147872
3793 rdar://problem/22044000
3795 Reviewed by Dan Bernstein.
3799 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3800 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3801 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3802 (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3803 (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3804 (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3805 (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3806 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3807 (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3808 * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3809 * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3811 2015-08-23 Andy Estes <aestes@apple.com>
3813 Fixed the 32-bit Mac build after r188844.
3815 * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3816 * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3818 2015-08-22 Andy Estes <aestes@apple.com>
3820 [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3821 https://bugs.webkit.org/show_bug.cgi?id=148317
3823 Reviewed by Dan Bernstein.
3825 Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3826 creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3827 WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3828 when creating WKWebViews.
3830 Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3831 added a new API test for bundle parameters.
3833 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3834 named its executable TestWebKitAPI.bundle.
3835 * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3836 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3837 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3838 (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3839 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3840 (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3841 bundle parameter and asked for an initial notification.
3842 (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3843 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3844 mirror its value in the main frame's JSContext.
3845 * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3846 * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3847 (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3848 TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3849 * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3850 * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3851 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3852 (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3853 (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3854 (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3856 2015-08-23 Csaba Osztrogonác <ossy@webkit.org>
3858 URTBF after r188828.
3860 * WebKitTestRunner/PlatformWebView.h:
3862 2015-08-23 Alexey Proskuryakov <ap@apple.com>
3864 build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3865 https://bugs.webkit.org/show_bug.cgi?id=148356
3867 Reviewed by Darin Adler.
3869 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3870 (BuildbotCombinedQueueView.prototype.update):
3872 2015-08-23 Alexey Proskuryakov <ap@apple.com>
3874 build.webkit.org/dashboard: Respect step's hidden flag
3875 https://bugs.webkit.org/show_bug.cgi?id=148357
3877 Reviewed by Darin Adler.
3879 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3880 (BuildbotIteration.prototype._parseData):
3882 2015-08-23 Nan Wang <n_wang@apple.com>
3884 AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3885 https://bugs.webkit.org/show_bug.cgi?id=148328
3887 Reviewed by Darin Adler.
3889 We should only expose stringValue() when value attribute is set.
3891 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3892 (AccessibilityUIElement::stringValue):
3893 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3894 (WTR::AccessibilityUIElement::stringValue):
3896 2015-08-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3898 Remove style checking rule regarding OwnPtr and PassOwnPtr
3899 https://bugs.webkit.org/show_bug.cgi?id=148360
3901 Reviewed by Darin Adler.
3903 OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3906 * Scripts/do-webcore-rename:
3907 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3908 (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3909 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3910 (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3911 (WebKitStyleTest.test_names): Deleted.
3913 2015-08-22 Timothy Horton <timothy_horton@apple.com>
3915 WebKitTestRunner should use WKWebView on OS X and iOS
3916 https://bugs.webkit.org/show_bug.cgi?id=143743
3917 <rdar://problem/16947123>
3919 Reviewed by Anders Carlsson.
3920 Patch by Enrica Casucci and myself.
3922 * WebKitTestRunner/PlatformWebView.h:
3923 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3924 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3925 instead of WKContext and WKPageGroup.
3927 Remove the unused, always-true windowSnapshotEnabled().
3928 While technically some platforms don't have window snapshotting,
3929 they just return null instead of implementing windowSnapshotEnabled().
3931 * WebKitTestRunner/TestController.h:
3932 * WebKitTestRunner/TestController.cpp:
3933 (WTR::TestController::createOtherPage):
3934 (WTR::TestController::initialize):
3935 (WTR::TestController::createWebViewWithOptions):
3936 Delegate to the various platforms for creating PlatformWebView instances,
3937 for creating WKContexts, and for accessing WKPreferences,
3938 so that they can do special things (like, use WKWebView instead!).
3940 (WTR::TestController::resetPreferencesToConsistentValues):
3941 Make explicit WebKitTestRunner's desired default for two preferences
3942 which have differing defaults between the antique and modern API,
3943 for consistency's sake.
3945 (WTR::TestController::resetStateToConsistentValues):
3946 Add platformResetStateToConsistentValues.
3948 * WebKitTestRunner/TestInvocation.cpp:
3949 (WTR::TestInvocation::dumpResults):
3950 Adjust to the aforementioned removal of windowSnapshotEnabled().
3952 * WebKitTestRunner/ios/TestControllerCocoa.mm:
3953 (WTR::TestController::platformResetStateToConsistentValues):
3954 (WTR::TestController::platformPreferences):
3955 (WTR::TestController::platformCreateWebView):
3956 (WTR::TestController::platformCreateOtherPage):
3957 (WTR::TestController::platformInitializeConfiguration):
3958 Implement the new platform functions for the Modern WebKit2 API,
3959 in a new TestControllerCocoa file that is shared between iOS and Mac.
3961 For platformMaybeCreateContext, use the trick that we know we can cast
3962 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3963 WKWebView's configuration.
3965 Ditto for WKPreferencesRef and WKPreferences.
3967 Remove user content filters on the WKWebView's userContentController.
3969 * WebKitTestRunner/mac/TestControllerMac.mm:
3970 * WebKitTestRunner/ios/TestControllerIOS.mm:
3971 Move code into TestControllerCocoa.
3973 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3974 (WTR::InjectedBundle::beginTesting):
3975 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3976 (WTR::TestRunner::addUserScript):
3977 (WTR::TestRunner::addUserStyleSheet):
3978 Adopt WKBundlePage API for user scripts/sheets.
3980 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3981 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3982 Make and keep a WKWebView instead of a WKView.
3984 * WebKitTestRunner/mac/EventSenderProxy.mm:
3985 (WTR::EventSenderProxy::mouseUp):
3986 (WTR::EventSenderProxy::mouseMoveTo):
3987 Reach inside the WKWebView to the WKView when dispatching events.
3988 This is fairly ugly and we should come up with a better solution.
3989 Also, fix some flipping and style errors.
3991 2015-08-22 Michael Catanzaro <mcatanzaro@igalia.com>
3993 Unreviewed, attempt to fix GTK build after r188718
3995 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3996 (WTR::PlatformWebView::PlatformWebView):
3998 2015-08-21 Commit Queue <commit-queue@webkit.org>
4000 Unreviewed, rolling out r188807, r188813, and r188815.
4001 https://bugs.webkit.org/show_bug.cgi?id=148349
4003 lots of 32-bit build problems, better to resolve separately
4004 and try again (Requested by thorton on #webkit).
4006 Reverted changesets:
4008 "WebKitTestRunner should use WKWebView on OS X and iOS"
4009 https://bugs.webkit.org/show_bug.cgi?id=143743
4010 http://trac.webkit.org/changeset/188807
4012 "Stop building WebKitTestRunner for 32-bit platforms"
4013 https://bugs.webkit.org/show_bug.cgi?id=143743
4014 http://trac.webkit.org/changeset/188813
4016 "Stop building WebKitTestRunner for 32-bit platforms"
4017 https://bugs.webkit.org/show_bug.cgi?id=143743
4018 http://trac.webkit.org/changeset/188815
4020 2015-08-21 Tim Horton <timothy_horton@apple.com>
4022 Stop building WebKitTestRunner for 32-bit platforms
4023 https://bugs.webkit.org/show_bug.cgi?id=143743
4024 <rdar://problem/16947123>
4026 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4027 This is a restriction on the valid set, not the desired set.
4029 2015-08-21 Jason Marcell <jmarcell@apple.com>
4031 Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
4032 to work with these new objects.
4033 https://bugs.webkit.org/show_bug.cgi?id=148188
4035 Reviewed by Daniel Bates.
4037 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
4038 (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
4039 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4040 (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
4041 (repository, "branch name")-pair.
4042 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
4043 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4044 (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
4045 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4046 (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
4047 objects which represent a (repository, "branch name")-pair.
4048 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
4049 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
4050 (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
4051 (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
4052 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
4053 BuildbotQueue.branch to BuildbotQueue.branches.
4054 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4055 (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
4057 2015-08-21 Tim Horton <timothy_horton@apple.com>
4059 Stop building WebKitTestRunner for 32-bit platforms
4060 https://bugs.webkit.org/show_bug.cgi?id=143743
4061 <rdar://problem/16947123>
4063 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4064 WKWebView is not available on 32-bit OS X.
4066 2015-08-21 Brent Fulgham <bfulgham@apple.com>
4068 [Win] Unreviewed test correction after r188709.
4070 I removed a function argument that happened to be mirrored by a global
4071 value with the same name. This prevented a compile error, but testing
4072 showed that the wrong value was being used in the function.
4074 * DumpRenderTree/win/FrameLoadDelegate.cpp:
4075 (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
4078 2015-08-21 Timothy Horton <timothy_horton@apple.com>
4080 WebKitTestRunner should use WKWebView on OS X and iOS
4081 https://bugs.webkit.org/show_bug.cgi?id=143743
4082 <rdar://problem/16947123>
4084 Reviewed by Anders Carlsson.
4085 Patch by Enrica Casucci and myself.
4087 * WebKitTestRunner/PlatformWebView.h:
4088 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
4089 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
4090 instead of WKContext and WKPageGroup.
4092 Remove the unused, always-true windowSnapshotEnabled().
4093 While technically some platforms don't have window snapshotting,
4094 they just return null instead of implementing windowSnapshotEnabled().
4096 * WebKitTestRunner/TestController.h:
4097 * WebKitTestRunner/TestController.cpp:
4098 (WTR::TestController::createOtherPage):
4099 (WTR::TestController::initialize):
4100 (WTR::TestController::createWebViewWithOptions):
4101 Delegate to the various platforms for creating PlatformWebView instances,
4102 for creating WKContexts, and for accessing WKPreferences,
4103 so that they can do special things (like, use WKWebView instead!).
4105 (WTR::TestController::resetPreferencesToConsistentValues):
4106 Make explicit WebKitTestRunner's desired default for two preferences
4107 which have differing defaults between the antique and modern API,
4108 for consistency's sake.
4110 (WTR::TestController::resetStateToConsistentValues):
4111 Add platformResetStateToConsistentValues.
4113 * WebKitTestRunner/TestInvocation.cpp:
4114 (WTR::TestInvocation::dumpResults):
4115 Adjust to the aforementioned removal of windowSnapshotEnabled().
4117 * WebKitTestRunner/ios/TestControllerCocoa.mm:
4118 (WTR::TestController::platformResetStateToConsistentValues):
4119 (WTR::TestController::platformPreferences):
4120 (WTR::TestController::platformCreateWebView):
4121 (WTR::TestController::platformCreateOtherPage):
4122 (WTR::TestController::platformInitializeConfiguration):
4123 Implement the new platform functions for the Modern WebKit2 API,
4124 in a new TestControllerCocoa file that is shared between iOS and Mac.
4126 For platformMaybeCreateContext, use the trick that we know we can cast
4127 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
4128 WKWebView's configuration.
4130 Ditto for WKPreferencesRef and WKPreferences.
4132 Remove user content filters on the WKWebView's userContentController.
4134 * WebKitTestRunner/mac/TestControllerMac.mm:
4135 * WebKitTestRunner/ios/TestControllerIOS.mm:
4136 Move code into TestControllerCocoa.
4138 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4139 (WTR::InjectedBundle::beginTesting):
4140 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4141 (WTR::TestRunner::addUserScript):
4142 (WTR::TestRunner::addUserStyleSheet):
4143 Adopt WKBundlePage API for user scripts/sheets.
4145 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4146 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4147 Make and keep a WKWebView instead of a WKView.
4149 * WebKitTestRunner/mac/EventSenderProxy.mm:
4150 (WTR::EventSenderProxy::mouseUp):
4151 (WTR::EventSenderProxy::mouseMoveTo):
4152 Reach inside the WKWebView to the WKView when dispatching events.
4153 This is fairly ugly and we should come up with a better solution.
4154 Also, fix some flipping and style errors.
4156 2015-08-21 Alexey Proskuryakov <ap@apple.com>
4158 Improve how UI events are dispatched by WebKitTestRunner
4159 https://bugs.webkit.org/show_bug.cgi?id=148326
4161 Reviewed by Anders Carlsson.
4163 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4164 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4165 Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
4166 asynchronous (and really, it has always been for the most part).
4168 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4169 (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
4170 (WTR::EventSendingController::mouseUp): Ditto.
4171 (WTR::EventSendingController::mouseMoveTo): Ditto.
4172 (WTR::EventSendingController::mouseForceDown): Ditto.
4173 (WTR::EventSendingController::mouseForceUp): Ditto.
4174 (WTR::EventSendingController::mouseForceChanged): Ditto.
4175 (WTR::EventSendingController::leapForward): Ditto.
4176 (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
4177 (WTR::EventSendingController::keyDown): Ditto.
4178 (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
4179 (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used