Added link to bug in ChangeLog.
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-28  David Kilzer  <ddkilzer@apple.com>
2
3         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
4         <http://webkit.org/b/53353>
5
6         Reviewed by Mark Rowe.
7
8         * Scripts/webkitdirs.pm:
9         (checkRequiredSystemConfig): Check the Xcode marketing version
10         in addition to the DevCoreTools build version before complaining
11         about an old version of Xcode.  Also make the Mac OS X version
12         check use Perl's built-in version string comparitor.
13
14 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
15
16         Unreviewed, build fix.
17
18         Work around breakage on Win 7 Release bot caused by r76982
19         and the fact that windows ports use "file:////" instead of
20         "file:///". Ideally the test code should be isolated from
21         this, but it isn't yet. Will fix properly in a bit.
22
23         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
24
25 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
26
27         Reviewed by Tony Chang.
28
29         new-run-webkit-tests: change worker model values to
30         "old-inline", "old-threads" in preparation for test_runner2 /
31         multiprocessing changes.
32
33         https://bugs.webkit.org/show_bug.cgi?id=53156
34
35         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
36         * Scripts/webkitpy/layout_tests/port/base.py:
37         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
38         * Scripts/webkitpy/layout_tests/port/mac.py:
39         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
40
41 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
42
43         Reviewed by Tony Chang.
44
45         committers.py - add an IRC nickname for dpranke
46         https://bugs.webkit.org/show_bug.cgi?id=53335
47
48         * Scripts/webkitpy/common/config/committers.py:
49
50 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
51
52         Reviewed by Tony Chang.
53
54         new-run-webkit-tests: add a "mock DRT" port implementation
55         and a separate class that emulates what we expect the
56         DumpRenderTree behavior to be.
57
58         This will eventually replace port/dryrun.py and allow us to get
59         better test coverage of the new-run-webkit-tests code as well as
60         a reference for what new-run-webkit-tests expects from DRT.
61
62         This is the first attempt at this, and it is pretty bare-boned. It
63         really only has been tested on the 'mac' port (and a little on
64         the 'chromium-mac' port.
65
66         https://bugs.webkit.org/show_bug.cgi?id=53126
67
68         * Scripts/webkitpy/common/system/filesystem_mock.py:
69         * Scripts/webkitpy/layout_tests/port/dryrun.py:
70         * Scripts/webkitpy/layout_tests/port/factory.py:
71         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
72         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
73         * Scripts/webkitpy/layout_tests/port/test.py:
74
75 2011-01-28  Pratik Solanki  <psolanki@apple.com>
76
77         Unreviewed. Removing .swp file checked in by mistake.
78
79         * Scripts/.webkitdirs.pm.swp: Removed.
80
81 2011-01-28  Pratik Solanki  <psolanki@apple.com>
82
83         Reviewed by David Kilzer.
84
85         Space not necessary for undefined feature
86         https://bugs.webkit.org/show_bug.cgi?id=53317
87
88         * Scripts/build-webkit:
89
90 2011-01-28  Chang Shu  <chang.shu@nokia.com>
91
92         Reviewed by Andreas Kling.
93
94         Reset NetworkAccessManager to clean up credentials from previous tests.
95         This change causes no performance overhead either.
96         https://bugs.webkit.org/show_bug.cgi?id=36688
97
98         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
99         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
100         (WebCore::DumpRenderTree::open):
101         * DumpRenderTree/qt/DumpRenderTreeQt.h:
102
103 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
104
105         Reviewed by Andreas Kling.
106
107         [Qt] Add Zoom Text Only action to MiniBrowser
108         https://bugs.webkit.org/show_bug.cgi?id=53297
109
110         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
111
112         * MiniBrowser/qt/BrowserWindow.cpp:
113         (BrowserWindow::BrowserWindow):
114         (BrowserWindow::zoomIn):
115         (BrowserWindow::zoomOut):
116         (BrowserWindow::resetZoom):
117         (BrowserWindow::toggleZoomTextOnly):
118         (BrowserWindow::applyZoom):
119         * MiniBrowser/qt/BrowserWindow.h:
120
121 2011-01-28  Adam Barth  <abarth@webkit.org>
122
123         Reviewed by Eric Seidel.
124
125         Add webkit-patch roll-chromium-deps
126         https://bugs.webkit.org/show_bug.cgi?id=53288
127
128         This command updates the Source/WebKit/chromium/DEPS file with the
129         last-known good revision of Chromium (or a revision specified on the
130         command line).  I'd eventually like to turn this into a SheriffBot
131         command, but this is the first step.
132
133         This patch somewhat sprawled because I needed to move a bunch of code
134         out of ChangeLog that should never have been there in the first place.
135         Also, I had to fix a bug in MockUser in order to test the new command.
136
137         * Scripts/webkitpy/common/checkout/api.py:
138         * Scripts/webkitpy/common/checkout/changelog.py:
139         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
140         * Scripts/webkitpy/common/checkout/deps.py: Added.
141         * Scripts/webkitpy/common/config/urls.py:
142         * Scripts/webkitpy/tool/commands/__init__.py:
143         * Scripts/webkitpy/tool/commands/download_unittest.py:
144         * Scripts/webkitpy/tool/commands/roll.py: Added.
145         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
146         * Scripts/webkitpy/tool/commands/upload_unittest.py:
147         * Scripts/webkitpy/tool/mocktool.py:
148         * Scripts/webkitpy/tool/steps/__init__.py:
149         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
150         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
151         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
152         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
153         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
154         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
155
156 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
157
158         Reviewed by Laszlo Gombos.
159
160         Get rid of prefix header dependency for WebKit2 build system
161         https://bugs.webkit.org/show_bug.cgi?id=50174
162
163         Change the style checker so that it enforces config.h include for
164         WebKit2.
165
166         * Scripts/webkitpy/style/checker.py:
167
168 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
169
170         Reviewed by Darin Adler.
171
172         execCommand("Paste") doesn't work in WebKitTestRunner
173         https://bugs.webkit.org/show_bug.cgi?id=52785
174
175         Enable both of the settings needed to allow paste.
176         
177         * WebKitTestRunner/TestController.cpp:
178         (WTR::TestController::resetStateToConsistentValues):
179
180 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
181
182         Reviewed by Andreas Kling.
183
184         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
185         https://bugs.webkit.org/show_bug.cgi?id=48440
186
187         Preserve user input when toggling use of QGraphicsView
188
189         * QtTestBrowser/launcherwindow.cpp:
190         (LauncherWindow::initializeView):
191         (LauncherWindow::loadFinished):
192         * QtTestBrowser/launcherwindow.h:
193         * QtTestBrowser/mainwindow.cpp:
194         (MainWindow::addressUrl):
195         * QtTestBrowser/mainwindow.h:
196
197 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
198
199         Reviewed by Mihai Parparita.
200
201         new-run-webkit-tests: turn off pixel tests correctly by default
202         for webkit-based ports. r70013 (bug 47510) used
203         port.set_option_default() to attempt to set default values, but
204         that didn't work correctly. I have removed set_option_default
205         for now since it was only being used in two places and in three
206         useless unit tests. There is a separate bug open to fix the
207         option parsing (48095), so this workaround is fine for now.
208
209         https://bugs.webkit.org/show_bug.cgi?id=53217
210
211         * Scripts/webkitpy/layout_tests/port/webkit.py:
212         * Scripts/webkitpy/layout_tests/port/base.py:
213         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
214
215 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
216
217         Rubber-stamped by Ariya Hidayat.
218
219         Trivial crash fix in WTR.
220
221         * WebKitTestRunner/TestController.cpp:
222         (WTR::TestController::initialize): Increase the size
223         of the vector by one to be able to store the null character.
224
225 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
226
227         Reviewed by Csaba Osztrogonác.
228
229         [Qt][WK2] WTR should be initialized in the same way as DRT
230         https://bugs.webkit.org/show_bug.cgi?id=53240
231
232         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
233         (WTR::activateFonts): Added missing initialization steps.
234
235 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
236
237         Unreviewed. 
238
239         Adding myself to committers.py.
240
241         * Scripts/webkitpy/common/config/committers.py:
242
243 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
244
245         Reviewed by Csaba Osztrogonác.
246
247         [Qt] [Symbian] Move project files into Source
248         https://bugs.webkit.org/show_bug.cgi?id=52891
249
250         Fix the Symbian build after the project files
251         are moved to Source directory. On Symbian qmake
252         needs to run in the same directory where the main
253         pro files (WebKit.pro, Tools.pro) are located.
254
255         * Scripts/webkitdirs.pm: Change to the directory where the pro file
256         is located before running qmake for Symbian. Qmake on Symbian
257         does not properly honor the "-o" option, work it around by setting
258         the name of the Makefile to bld.inf.
259
260 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
261
262         Reviewed by Andreas Kling.
263
264         [Qt] Add simple zooming features to MiniBrowser
265         https://bugs.webkit.org/show_bug.cgi?id=53231
266
267         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
268
269         * MiniBrowser/qt/BrowserWindow.cpp:
270         (BrowserWindow::BrowserWindow):
271         (BrowserWindow::zoomIn):
272         (BrowserWindow::zoomOut):
273         (BrowserWindow::resetZoom):
274         (BrowserWindow::updateUserAgentList):
275         (BrowserWindow::applyZoom):
276         * MiniBrowser/qt/BrowserWindow.h:
277
278 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
279
280         Reviewed by Dan Bernstein.
281
282         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
283         https://bugs.webkit.org/show_bug.cgi?id=42319
284         
285         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
286
287         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
288         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
289         (WTR::LayoutTestController::showWebInspector):
290         (WTR::LayoutTestController::closeWebInspector):
291         (WTR::LayoutTestController::evaluateInWebInspector):
292         (WTR::LayoutTestController::setTimelineProfilingEnabled):
293         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
294         * WebKitTestRunner/TestInvocation.cpp:
295         (WTR::shouldOpenWebInspector):
296         (WTR::TestInvocation::invoke):
297         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
298
299 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
300
301         Reviewed by Xan Lopez.
302
303         [GTK] Pixel dumps do not include scrollbars in output images
304         https://bugs.webkit.org/show_bug.cgi?id=53216
305
306         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
307         that have scrollbars.
308
309         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
310         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
311         instead of the web view itself.
312
313 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
314
315         Reviewed by Mihai Parparita.
316
317         Fix regression introduced in r76322 ... new-run-webkit-tests
318         was attempting to save the image diff output as a UTF-8-encoded
319         file.
320
321         https://bugs.webkit.org/show_bug.cgi?id=53210
322
323         * Scripts/webkitpy/layout_tests/port/webkit.py:
324
325 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
326
327         Unreviewed, rolling out r76709.
328         http://trac.webkit.org/changeset/76709
329         https://bugs.webkit.org/show_bug.cgi?id=53194
330
331         "broke python tests on non-snowleopard platforms" (Requested
332         by dpranke on #webkit).
333
334         * Scripts/webkitpy/layout_tests/port/factory.py:
335         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
336         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
337
338 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
339
340         Reviewed by Tony Chang.
341
342         new-run-webkit-tests: add a "mock DRT" port implementation
343         and a separate class that emulates what we expect the
344         DumpRenderTree behavior to be.
345
346         This will eventually replace port/dryrun.py and allow us to get
347         better test coverage of the new-run-webkit-tests code as well as
348         a reference for what new-run-webkit-tests expects from DRT.
349
350         This is the first attempt at this, and it is pretty bare-boned. It
351         really only has been tested on the 'mac' port (and a little on
352         the 'chromium-mac' port.
353
354         https://bugs.webkit.org/show_bug.cgi?id=53126
355
356         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
357         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
358         * Scripts/webkitpy/layout_tests/port/factory.py:
359
360 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
361
362         Reviewed by Tony Chang.
363
364         Add '--no-timeout' option to Chromium DRT to ease debugging.
365         https://bugs.webkit.org/show_bug.cgi?id=52873
366
367         * DumpRenderTree/chromium/DumpRenderTree.cpp:
368         (main):
369
370 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
371
372         Reviewed by Andreas Kling.
373
374         [Qt] Fix qt_minimal build
375         https://bugs.webkit.org/show_bug.cgi?id=53172
376
377         * QtTestBrowser/locationedit.h:
378
379 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
380
381         Reviewed by Antonio Gomes.
382
383         QtTestBrowser should have a UI Setting to disable plugins
384         https://bugs.webkit.org/show_bug.cgi?id=52408
385         
386         Added a new action item named "Disable Plugins"
387         under the "Settings" menu. 
388
389         * QtTestBrowser/launcherwindow.cpp:
390         (LauncherWindow::createChrome):
391         (LauncherWindow::togglePlugins):
392         * QtTestBrowser/launcherwindow.h:
393
394 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
395
396         Reviewed by Adam Barth.
397
398         Move main CMakeLists.txt into Source directory
399         https://bugs.webkit.org/show_bug.cgi?id=52888
400
401         * Scripts/webkitdirs.pm:
402
403 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
404
405         Reviewed by Eric Seidel.
406
407         Improve label text in submit-to-ews
408         https://bugs.webkit.org/show_bug.cgi?id=53130
409
410         * QueueStatusServer/templates/submittoews.html:
411
412 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
413
414         Reviewed by Antonio Gomes.
415
416         QtTestBrowser should have a UI Settings to prevent loading images
417         https://bugs.webkit.org/show_bug.cgi?id=52409
418         
419         Added a new action item named "DisableAutoLoadImages"
420         under the "Settings" menu 
421
422         * QtTestBrowser/launcherwindow.cpp:
423         (LauncherWindow::createChrome):
424         (LauncherWindow::toggleAutoLoadImages):
425         * QtTestBrowser/launcherwindow.h:
426
427 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
428
429         Reviewed by Tony Chang.
430
431         Minor bug fixes and cleanup for filesystem wrappers, port/* test
432         classes, test_expectations.py. This change adds "test-win" and
433         "test-mac" variants to the test port so that we can better test
434         rebaselining, and adds a MockUser() object for reuse in testing.
435
436         https://bugs.webkit.org/show_bug.cgi?id=53036
437
438         * Scripts/webkitpy/common/system/filesystem.py:
439         * Scripts/webkitpy/common/system/filesystem_mock.py:
440         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
441         * Scripts/webkitpy/layout_tests/port/factory.py:
442         * Scripts/webkitpy/layout_tests/port/base.py:
443         * Scripts/webkitpy/layout_tests/port/test.py:
444         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
445         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
446         * Scripts/webkitpy/tool/mocktool.py:
447
448 2011-01-25  Tony Chang  <tony@chromium.org>
449
450         Reviewed by Dimitri Glazkov.
451
452         [chromium] remove unused layoutTestController callback
453         https://bugs.webkit.org/show_bug.cgi?id=53103
454
455         This method is used by a test_shell_test, but not needed by DRT.
456
457         * DumpRenderTree/chromium/LayoutTestController.cpp:
458         (LayoutTestController::LayoutTestController):
459         * DumpRenderTree/chromium/LayoutTestController.h:
460
461 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
462
463         Reviewed by Andreas Kling.
464
465         [GTK] Remove 64 bits release bot from the buildbot master
466         https://bugs.webkit.org/show_bug.cgi?id=52899
467
468         Removes the 64 bits release slave from the buildbot configuration,
469         so that we can use it as an EWS.
470
471         * BuildSlaveSupport/build.webkit.org-config/config.json:
472
473 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
474
475         Reviewed by Dan Bernstein.
476
477         Implement database quota callback to fix storage tests on WebKit2 bot
478         https://bugs.webkit.org/show_bug.cgi?id=53064
479
480         * WebKitTestRunner/TestController.cpp:
481         (WTR::exceededDatabaseQuota):
482         (WTR::TestController::createOtherPage):
483         (WTR::TestController::initialize):
484
485 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
486
487         Reviewed by Anders Carlsson.
488
489         Use designated temp directory for the database for WebKit2
490         https://bugs.webkit.org/show_bug.cgi?id=53052
491         
492         Adopt the new WK2 API for this.
493
494         * WebKitTestRunner/TestController.cpp:
495         (WTR::TestController::libraryPathForTesting):
496         (WTR::TestController::initialize):
497         * WebKitTestRunner/TestController.h:
498         * WebKitTestRunner/mac/TestControllerMac.mm:
499         (WTR::TestController::platformLibraryPathForTesting):
500         * WebKitTestRunner/qt/TestControllerQt.cpp:
501         (WTR::TestController::platformLibraryPathForTesting):
502         * WebKitTestRunner/win/TestControllerWin.cpp:
503         (WTR::TestController::platformLibraryPathForTesting):
504
505 2011-01-24  Lucas Forschler  <lforschler@apple.com>
506
507         Reviewed by Stephanie Lewis.
508
509         Add a new Leopard test bot.
510
511         * BuildSlaveSupport/build.webkit.org-config/config.json:
512
513 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
514
515         Reviewed by Adam Barth.
516
517         Add EFL Builder to core waterfall
518         https://bugs.webkit.org/show_bug.cgi?id=52704
519
520         Add EFL Builder to the core waterfall again.
521
522         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
523         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
524
525 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
526
527         Reviewed by Tony Chang.
528
529         new-run-webkit-tests fails to start HTTP server if there are proxy settings
530         https://bugs.webkit.org/show_bug.cgi?id=52872
531
532         Force disabling proxy to resolve the problem.
533
534         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
535         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
536
537 2011-01-24  Andreas Kling  <kling@webkit.org>
538
539         Reviewed by Darin Adler.
540
541         check-webkit-style: Update exemptions following Source/ move.
542         https://bugs.webkit.org/show_bug.cgi?id=53017
543
544         * Scripts/webkitpy/style/checker.py:
545         * Scripts/webkitpy/style/checker_unittest.py:
546
547 2011-01-24  Andras Becsi  <abecsi@webkit.org>
548
549         Rubber-stamped by Csaba Osztrogonác.
550
551         [Qt] Move project files into Source
552         https://bugs.webkit.org/show_bug.cgi?id=52891
553
554         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
555
556 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
557
558         Reviewed by Yury Semikhatsky.
559
560         Web Inspector: Find duplicate strings in localizedStrings.js
561
562         https://bugs.webkit.org/show_bug.cgi?id=53005
563
564         * Scripts/check-inspector-strings:
565
566 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
567
568         Reviewed by Andreas Kling.
569
570         [Qt] Regroup MiniBrowser's menubar and add open file action
571         https://bugs.webkit.org/show_bug.cgi?id=53000
572
573         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
574
575         * MiniBrowser/qt/BrowserWindow.cpp:
576         (BrowserWindow::BrowserWindow):
577         (BrowserWindow::openFile):
578         (BrowserWindow::~BrowserWindow):
579         * MiniBrowser/qt/BrowserWindow.h:
580
581 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
582
583         Unreviewed fix after r76496
584
585         [Qt] Move project files into Source
586         https://bugs.webkit.org/show_bug.cgi?id=52891
587
588         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
589         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
590         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
591
592 2011-01-24  Andras Becsi  <abecsi@webkit.org>
593
594         Reviewed by Csaba Osztrogonác.
595
596         [Qt] Move project files into Source
597         https://bugs.webkit.org/show_bug.cgi?id=52891
598
599         * DerivedSources.pro: Renamed from DerivedSources.pro.
600         * DumpRenderTree/qt/DumpRenderTree.pro:
601         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
602         * MiniBrowser/DerivedSources.pro:
603         * MiniBrowser/qt/MiniBrowser.pro:
604         * QtTestBrowser/QtTestBrowser.pro:
605         * Scripts/webkitdirs.pm:
606         * Tools.pro: Added.
607         * WebKitTestRunner/DerivedSources.pro:
608         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
609         * WebKitTestRunner/qt/WebKitTestRunner.pro:
610
611 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
612
613         Reviewed by Dan Bernstein.
614
615         Beefed up --threaded mode to catch even more kinds of errors.
616         https://bugs.webkit.org/show_bug.cgi?id=52971
617
618         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
619         context group to force JSC to mark multiple threads. (This used to be
620         the default, but it changed in SnowLeopard.)
621         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
622         to give threading mistakes more chances to show themselves.
623         (startJavaScriptThreads):
624         (stopJavaScriptThreads):
625
626 2011-01-22  Robert Hogan  <robert@webkit.org>
627
628         Reviewed by Andreas Kling.
629
630         [Qt] Support layoutTestController.addURLToRedirect()
631         https://bugs.webkit.org/show_bug.cgi?id=52956
632
633         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
634         (LayoutTestController::addURLToRedirect):
635         * DumpRenderTree/qt/LayoutTestControllerQt.h:
636
637 2011-01-22  Robert Hogan  <robert@webkit.org>
638
639         Reviewed by Kenneth Rohde Christiansen.
640
641         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
642         https://bugs.webkit.org/show_bug.cgi?id=49802
643
644         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
645         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
646         (WebCore::DumpRenderTree::open):
647
648 2011-01-21  Adam Barth  <abarth@webkit.org>
649
650         Reviewed by Maciej Stachowiak.
651
652         Disable mac_unittest.py that fails on some of the Mac bots
653         https://bugs.webkit.org/show_bug.cgi?id=52947
654
655         As noted in the comment, this test does not appear to be correct
656         because the function this test is testing returns different results
657         depending on which flavor of Mac the test is run on.  This patch
658         disable the test.  Hopefully we can re-enable the test once we've
659         probably insulated the test from its environment.
660
661         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
662
663 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
664
665         Reviewed by Mihai Parparita.
666
667         Fix bug introduced in r76322 that caused NRWT to not actually
668         read the Skipped files properly.
669
670         https://bugs.webkit.org/show_bug.cgi?id=52771
671
672         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
673         * Scripts/webkitpy/layout_tests/port/webkit.py:
674         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
675
676 2011-01-21  Sam Weinig  <sam@webkit.org>
677
678         Reviewed by Geoffrey Sean Garen and Mark Rowe.
679
680         WebKitTestRunner needs the HOME environment variable to be set.
681         <rdar://problem/8896573>
682
683         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
684         it exists.
685
686 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
687
688         Reviewed by Eric Seidel.
689
690         Suppress a few remaining integration tests so that none of the
691         layout_test unit tests ever read from the filesystem or launch
692         subprocesses that aren't part of the unit tests.
693
694         Also fix a minor bug in the printing unit tests that was
695         incorrectly relying on sys.argv.
696
697         https://bugs.webkit.org/show_bug.cgi?id=52863
698
699         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
700         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
701         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
702
703 2011-01-21  Darin Adler  <darin@apple.com>
704
705        Fix Mac build.
706
707         * MiniBrowser/mac/BrowserWindowController.m:
708         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
709
710 2011-01-20  Darin Adler  <darin@apple.com>
711
712         Reviewed by Dan Bernstein.
713
714         WebKit2: Implement showModalDialog
715         https://bugs.webkit.org/show_bug.cgi?id=52855
716
717         This fixes WebKitTestRunner to compile, but more work is probably
718         needed to get it to pass the tests.
719
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::TestController::runModal): Added. Calls through to the
722         platform-specific version of runModal.
723         (WTR::TestController::createOtherPage): Changed to be a private
724         static member function so it can refer to runModal, which is
725         a private static member function.
726         (WTR::TestController::initialize): Pass 0 for the runModal
727         function since we don't need to run the main window modal.
728         I suspect this is wrong and will need to change.
729         * WebKitTestRunner/TestController.h: Added declarations for
730         the functions added above.
731         * WebKitTestRunner/mac/TestControllerMac.mm:
732         (WTR::TestController::runModal): Added. Untested implementation.
733         * WebKitTestRunner/qt/TestControllerQt.cpp:
734         (WTR::TestController::runModal): Added.
735         * WebKitTestRunner/win/TestControllerWin.cpp:
736         (WTR::TestController::runModal): Added.
737
738 2011-01-21  Eric Seidel  <eric@webkit.org>
739
740         Reviewed by Adam Barth.
741
742         Split Host object off from WebKitPatch for easier re-use
743         https://bugs.webkit.org/show_bug.cgi?id=52284
744
745         new-run-webkit-tests and other tools are eventually going to want one of these.
746         Basically you need to inherit from this class if you want to pretend to be a
747         self.tool object for Steps/Commands.
748
749         * Scripts/webkitpy/common/host.py: Added.
750         * Scripts/webkitpy/tool/main.py:
751
752 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
753
754         Reviewed by Adam Barth.
755
756         Disable the tests that start and stop the http server and web
757         server, so that we don't have to worry about port collisions on
758         the bots.
759
760         https://bugs.webkit.org/show_bug.cgi?id=52861
761
762         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
763
764 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
765
766         Reviewed by Eric Seidel.
767
768         nrwt: rewrite google_chrome_unittest to use mock filesystem.
769         
770         https://bugs.webkit.org/show_bug.cgi?id=52772
771         
772         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
773
774 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
775
776         Reviewed by Eric Siedel.
777
778         nrwt: clean up almost all remaining port references, remove
779         unnecessary import clauses. The only remaining references are
780         in places where a mock filesystem makes no sense or can't be
781         used, and in one routine in port/google_chrome_unittest that
782         I'll rewrite in a separate patch.
783
784         https://bugs.webkit.org/show_bug.cgi?id=52771
785
786         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
787         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
788         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
789         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
790         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
791         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
792         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
793         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
794         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
795         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
796         * Scripts/webkitpy/layout_tests/port/gtk.py:
797         * Scripts/webkitpy/layout_tests/port/mac.py:
798         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
799         * Scripts/webkitpy/layout_tests/port/qt.py:
800         * Scripts/webkitpy/layout_tests/port/webkit.py:
801         * Scripts/webkitpy/layout_tests/port/win.py:
802         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
803
804 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
805
806         Reviewed by Mihai Parparita.
807
808         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
809
810         https://bugs.webkit.org/show_bug.cgi?id=52762
811
812         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
813         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
814
815 2011-01-20  Tony Chang  <tony@chromium.org>
816
817         Reviewed by Ojan Vafai.
818
819         [chromium] fix the paths used for the rebaseline tool
820         https://bugs.webkit.org/show_bug.cgi?id=52857
821
822         Some of the bots were renamed so the path to grab the results zip
823         file has changed.
824
825         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
826
827 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
828
829         Reviewed by Tony Chang.
830
831         Fix bug introduced in r72688 / bug 52768 that broke the
832         generation of the output filename links in the results.html
833         output. Apparently none of the unit tests actually checked to
834         make sure the generated links were correct :(
835
836         https://bugs.webkit.org/show_bug.cgi?id=52854
837
838         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
839         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
840
841 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
842
843         Reviewed by Darin Adler.
844
845         https://bugs.webkit.org/show_bug.cgi?id=52849
846         Make window.print work with WebKit2
847
848         * MiniBrowser/mac/BrowserWindowController.m:
849         (-[BrowserWindowController awakeFromNib]):
850         * WebKitTestRunner/TestController.cpp:
851         (WTR::createOtherPage):
852         (WTR::TestController::initialize):
853         Added zeroes to WKPageUIClient structures to avoid build failures.
854
855 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
856
857         Reviewed by Eric Seidel.
858
859         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
860
861         https://bugs.webkit.org/show_bug.cgi?id=52756
862
863         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
864         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
865         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
866         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
867         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
868         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
869
870 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
871
872         Reviewed by Antonio Gomes.
873
874         QtTestBrowser should have a seperate menu for Settings
875         https://bugs.webkit.org/show_bug.cgi?id=52817
876         
877         Added a new menu item named "Settings"
878         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
879
880         * QtTestBrowser/launcherwindow.cpp:
881         (LauncherWindow::createChrome):
882
883 2011-01-20  Sam Weinig  <sam@webkit.org>
884
885         Reviewed by John Sullivan.
886
887         Update update-webkit-localizable-strings with new path to WebKit.
888
889         * Scripts/update-webkit-localizable-strings:
890
891 2011-01-20  James Robinson  <jamesr@chromium.org>
892
893         Reviewed by Darin Fisher.
894
895         Implement mozilla's requestAnimationFrame API
896         https://bugs.webkit.org/show_bug.cgi?id=51218
897
898         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
899
900         * DumpRenderTree/chromium/WebViewHost.cpp:
901         (invokeScheduleComposite):
902         (WebViewHost::scheduleAnimation):
903         (WebViewHost::paintInvalidatedRegion):
904         * DumpRenderTree/chromium/WebViewHost.h:
905
906 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
907
908         Reviewed by Adam Roben.
909
910         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
911         https://bugs.webkit.org/show_bug.cgi?id=42327
912
913         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
914         for methods that take their normal arguments but also a JSContextRef.
915         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
916         for evaluateScriptInIsolatedWorld.
917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
918         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
919         this call is for an isolated world.
920         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
921         (WTR::worldMap): Helper to create a world map.
922         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
923         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
924         added LayoutTestController API.
925         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
926
927 2011-01-19  Adam Roben  <aroben@apple.com>
928
929         Convert paths in environment variables back to msys-style inside commit-log-editor
930
931         When this script gets run from inside git commit, msys-style paths in the environment will
932         have been turned into Windows-style paths with forward slashes. This screws up functions
933         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
934         the paths back to msys-style before doing anything else.
935
936         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
937         using msysgit's Perl and multiple ChangeLogs have been edited
938
939         Reviewed by David Kilzer.
940
941         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
942         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
943         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
944
945 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
946
947         [Win] Unreviewed build fix after r76248.
948
949         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
950
951 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
952
953         Reviewed by Csaba Osztrogonác.
954
955         Refactoring of the custom allocation framework
956         https://bugs.webkit.org/show_bug.cgi?id=49897
957
958         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
959         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
960         equivalent macro implementation at the necessary places.
961 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
962
963         Unreviewed. 
964
965         Adding myself to committers.py.
966
967         * Scripts/webkitpy/common/config/committers.py:
968
969 2011-01-20  Adam Barth  <abarth@webkit.org>
970
971         Reviewed by Tony Chang.
972
973         Chromium builders don't delete unversioned directories when DEPS change
974         https://bugs.webkit.org/show_bug.cgi?id=52745
975
976         If we pass this option to gclient sync, gclient will delete directories
977         that are no longer part of DEPS instead of leaving them around to
978         confuse us later.  Apparently, the downstream buildbots use this option
979         already.
980
981         * Scripts/update-webkit-chromium:
982
983 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
984
985         Unreviewed, build fix - I pulled this patch in to fix an issue
986         revealed by r76195 running on some new bots). Also fix a couple
987         of other issues revealed in testing.
988
989         nrwt: remove fs refs from layout_package/json*
990
991         https://bugs.webkit.org/show_bug.cgi?id=52754
992
993         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
994         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
995         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
996         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
997         * Scripts/webkitpy/layout_tests/port/base.py:
998
999 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1000
1001         Unreviewed, build fix.
1002
1003         Fix a couple of minor bugs discovered while bringing up new bots
1004         for testing.
1005
1006         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1007         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1008
1009 2011-01-19  James Robinson  <jamesr@chromium.org>
1010
1011         Unreviewed, rolling out r76194.
1012         http://trac.webkit.org/changeset/76194
1013         https://bugs.webkit.org/show_bug.cgi?id=51218
1014
1015         Caused mysterious compile failure on the chromium win
1016         build.webkit.org bots
1017
1018         * DumpRenderTree/chromium/WebViewHost.cpp:
1019         (WebViewHost::paintInvalidatedRegion):
1020         * DumpRenderTree/chromium/WebViewHost.h:
1021
1022 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1023
1024         Reviewed by Mihai Parparita.
1025
1026         remove fs refs from test_runner, dump_render_tree_thread
1027
1028         https://bugs.webkit.org/show_bug.cgi?id=52753
1029
1030         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1031         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1032         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1033         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1034
1035 2011-01-19  James Robinson  <jamesr@chromium.org>
1036
1037         Reviewed by Darin Fisher.
1038
1039         Implement mozilla's requestAnimationFrame API
1040         https://bugs.webkit.org/show_bug.cgi?id=51218
1041
1042         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1043
1044         * DumpRenderTree/chromium/WebViewHost.cpp:
1045         (invokeScheduleComposite):
1046         (WebViewHost::scheduleAnimation):
1047         (WebViewHost::paintInvalidatedRegion):
1048         * DumpRenderTree/chromium/WebViewHost.h:
1049
1050 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1051
1052         Unreviewed, build fix.
1053
1054         Fix a few incorrect "self._filesystem" references introduced in
1055         r76184.
1056
1057         * Scripts/webkitpy/layout_tests/port/chromium.py:
1058         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1059
1060 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1061
1062         Reviewed by Mihai Parparita.
1063
1064         add a .sep property, abspath(), isabs(), mtime(), and
1065         open_text_file_for_writing() to filesystem modules. Some of
1066         these properties are not needed in this patch but will be needed
1067         in subsequent patches (I'm doing this to avoid having to track
1068         multiple versions of a single file).
1069
1070         Also, change most of the port/* modules to use the filesystem
1071         objects instead of referencing the filesystem directly.
1072
1073         https://bugs.webkit.org/show_bug.cgi?id=52748
1074
1075         * Scripts/webkitpy/common/system/filesystem.py:
1076         * Scripts/webkitpy/common/system/filesystem_mock.py:
1077         * Scripts/webkitpy/layout_tests/port/__init__.py:
1078         * Scripts/webkitpy/layout_tests/port/base.py:
1079         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1080         * Scripts/webkitpy/layout_tests/port/chromium.py:
1081         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1082         * Scripts/webkitpy/layout_tests/port/config.py:
1083         * Scripts/webkitpy/layout_tests/port/test.py:
1084         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1085
1086 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1087
1088         Reviewed by Anders Carlsson.
1089
1090         If resetting between tests times out, treat it as a WebProcess crash
1091         https://bugs.webkit.org/show_bug.cgi?id=52757
1092
1093         * WebKitTestRunner/TestController.cpp:
1094         (WTR::TestController::runTest):
1095
1096 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Reviewed by Darin Adler.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=52739
1101         Make it possible for a WebKit2 client to print headers and footers
1102
1103         Added dummy implementations for new printing UIClient calls.
1104
1105         * MiniBrowser/mac/BrowserWindowController.m:
1106         (-[BrowserWindowController awakeFromNib]):
1107         * WebKitTestRunner/TestController.cpp:
1108         (WTR::createOtherPage):
1109         (WTR::TestController::initialize):
1110
1111 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1112
1113         Reviewed by Ojan Vafai.
1114
1115         Change webkitpy/layout_tests/port/test.py to use the
1116         in-memory filesystem for cleaner unit testing. This
1117         change allows us to kill a lot of code that was
1118         specific to the test port, at the cost of being a
1119         little less clear about how things would work if
1120         you didn't have a filesystem.
1121
1122         https://bugs.webkit.org/show_bug.cgi?id=52605
1123
1124         * Scripts/webkitpy/layout_tests/port/test.py:
1125
1126 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1127
1128         Unreviewed, build fix.
1129
1130         Fix test failure caused by committing attachment 79368 instead
1131         of attachment 79461 on bug 52604.
1132
1133         * Scripts/webkitpy/common/system/filesystem_mock.py:
1134
1135 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1136
1137         Reviewed by Mihai Parparita.
1138
1139         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1140         unit testing. os.walk() is too much of a hassle to implement on
1141         top of the in-memory mock filesystem and adding the necessary
1142         interface to files_under() gives clients a cleaner API anyway
1143         (for this particular usage model).
1144
1145         https://bugs.webkit.org/show_bug.cgi?id=52691
1146
1147         * Scripts/webkitpy/common/system/filesystem.py:
1148         * Scripts/webkitpy/common/system/filesystem_mock.py:
1149         * Scripts/webkitpy/layout_tests/port/test_files.py:
1150         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1151
1152 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1153
1154         Reviewed by Tony Chang.
1155
1156         Change more modules in the layout-tests code to use the
1157         filesystem wrapper for cleaner unit testing.
1158
1159         This patch also adds the glob() wrapper to the filesystem
1160         abstraction.
1161         
1162         https://bugs.webkit.org/show_bug.cgi?id=52604
1163
1164         * Scripts/webkitpy/layout_tests/port/test_files.py:
1165         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1166         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1167         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1168         * Scripts/webkitpy/common/system/filesystem.py:
1169         * Scripts/webkitpy/common/system/filesystem_mock.py:
1170
1171 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1172
1173         Unreviewed.
1174
1175         Updating my email addresses and irc nick.
1176
1177         * Scripts/webkitpy/common/config/committers.py:
1178
1179 2011-01-19  Tony Chang  <tony@chromium.org>
1180
1181         Reviewed by Mihai Parparita.
1182
1183         [chromium] [linux] if check-sys-deps fails, output the failure reason
1184         https://bugs.webkit.org/show_bug.cgi?id=52671
1185
1186         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1187             error handler functions.
1188         * Scripts/webkitpy/layout_tests/port/chromium.py:
1189             output the error text from --check-sys-deps
1190         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1191
1192 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1193
1194         Reviewed by Andreas Kling.
1195
1196         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1197         https://bugs.webkit.org/show_bug.cgi?id=52554
1198         
1199         QtNetworkAccessManager is created in a thread and set as
1200         member variable in QWebPage. When the thread is destroyed
1201         the object is still used. So fix will set the object to
1202         NULL once the thread is destroyed.
1203
1204         * QtTestBrowser/launcherwindow.cpp:
1205         (LauncherWindow::~LauncherWindow):
1206
1207 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1208
1209         Rubber stamped by Csaba Osztrogonac
1210
1211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1212
1213 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1214
1215         Reviewed by Tony Chang.
1216
1217         new-run-webkit-tests: add a --build-directory command line argument
1218
1219         Official Google Chrome builds use a non-standard build directory
1220         location. This patch adds a --build-directory argument that
1221         allows that location to be specified on the command line. Only
1222         Chromium-based builds will use this flag for now, but anyone can
1223         in the future.
1224
1225         There are no unit tests for this since it's difficult to test
1226         until mock filesystems are fully supported in the code. This was
1227         tested by hand for now.
1228
1229         https://bugs.webkit.org/show_bug.cgi?id=52694
1230
1231         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1232         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1233         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1234         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1235
1236 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1237
1238         Not reviewed. Bot fix.
1239
1240         Remove an inadvertently committed debugging print.
1241
1242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1243         (LayoutTestController::notifyDone):
1244
1245 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1246
1247         Reviewed by Sam Weinig.
1248
1249         WebKitTestRunner should track loading more like DumpRenderTree
1250         https://bugs.webkit.org/show_bug.cgi?id=52692
1251
1252         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1253         This makes some tests that call notifyDone multiple times pass.
1254         
1255         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1256         (WTR::InjectedBundle::InjectedBundle):
1257         (WTR::InjectedBundle::done):
1258         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1259         (WTR::InjectedBundle::topLoadingFrame):
1260         (WTR::InjectedBundle::setTopLoadingFrame):
1261         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1262         (WTR::InjectedBundlePage::InjectedBundlePage):
1263         (WTR::InjectedBundlePage::stopLoading):
1264         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1265         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1266         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1267         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1268         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1269         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1270         (WTR::LayoutTestController::notifyDone):
1271         * WebKitTestRunner/TestController.cpp:
1272         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1273
1274 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1275
1276         Reviewed by Kent Tamura.
1277
1278         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1279         https://bugs.webkit.org/show_bug.cgi?id=52678
1280         
1281         Update path now that WebKit is inside Source.
1282
1283         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1284
1285 2011-01-18  Robert Hogan  <robert@webkit.org>
1286
1287         Reviewed by Simon Hausmann.
1288
1289         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1290         https://bugs.webkit.org/show_bug.cgi?id=44282
1291
1292         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1293         (WebCore::DumpRenderTree::dump):
1294
1295 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1296
1297         Reviewed by Mihai Parparita.
1298
1299         Fix a small race condition that could cause the unit tests for
1300         new-run-webkit-tests to fail in a multithreaded environment.
1301         There was a small window in the code where one thread would
1302         check to see if a thread had raised an exception, do something,
1303         and then check to see if the thread was alive. If the other
1304         thread raised an exception and exited in between these two
1305         steps, the exception would be lost. Flipping the order of the
1306         two checks fixes the race, since we will now always check for an
1307         exception on the thread before exiting.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=51579
1310
1311         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1312
1313 2011-01-18  Eric Seidel  <eric@webkit.org>
1314
1315         Reviewed by Adam Barth.
1316
1317         commit-queue dies when test archiving fails
1318         https://bugs.webkit.org/show_bug.cgi?id=52617
1319
1320         I looked at the machine and it had 10 archives already
1321         thus find_unused_name was returning None.  I've upped
1322         the limit to 100 (per bug) and tested the case where
1323         find_unused_name returns None (making archive return None).
1324
1325         * Scripts/webkitpy/common/system/workspace.py:
1326         * Scripts/webkitpy/common/system/workspace_unittest.py:
1327         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1328         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1329         * Scripts/webkitpy/tool/commands/queues.py:
1330
1331 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1332
1333         Reviewed by Ojan Vafai.
1334
1335         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1336         filesystem. Also fix a couple of "with" statements missed by
1337         r76050.
1338
1339         https://bugs.webkit.org/show_bug.cgi?id=52487
1340
1341         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1342
1343 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1344
1345         Reviewed by Martin Robinson.
1346
1347         [Gtk] Build fixes for gtk3 build
1348         https://bugs.webkit.org/show_bug.cgi?id=52648
1349
1350         * DumpRenderTree/gtk/EventSender.cpp:
1351         (beginDragWithFilesCallback):
1352
1353 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1354
1355         Reviewed by Mihai Parparita.
1356
1357         Update rebaseline-chromium-webkit-tests to use filesystem objects
1358         instead of direct references to os.path, shutil, tempfile, etc.
1359
1360         This patch doesn't change anything, but will allow subsequent
1361         patches to change the unit tests to no longer use the real
1362         filesystem.
1363
1364         This patch adds a bunch more methods to the filesystem object as
1365         well.
1366
1367         https://bugs.webkit.org/show_bug.cgi?id=52482
1368
1369         * Scripts/webkitpy/common/system/filesystem.py:
1370         * Scripts/webkitpy/common/system/filesystem_mock.py:
1371         * Scripts/webkitpy/tool/commands/queues.py:
1372         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1373         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1374
1375 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1376
1377         Reviewed by Mihai Parparita.
1378
1379         new-run-webkit-tests shouldn't crash when you try to run a
1380         directory containing only skipped files.
1381
1382         https://bugs.webkit.org/show_bug.cgi?id=52478
1383         
1384         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1385         * Scripts/webkitpy/layout_tests/port/test.py:
1386         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1387
1388 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1389
1390         Reviewed by Gustavo Noronha Silva.
1391
1392         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1393         https://bugs.webkit.org/show_bug.cgi?id=40833
1394
1395         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1396         GTK+ event sender.
1397         (dragWithFilesDragDataGetCallback): Added.
1398         (dragWithFilesDragEndCallback): Added.
1399         (beginDragWithFilesCallback): Added.
1400
1401 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1402
1403         Reviewed by Adam Barth.
1404
1405         ews: Add additional watcher to efl ews
1406         https://bugs.webkit.org/show_bug.cgi?id=52613
1407
1408         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1409
1410         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1411
1412 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1413
1414         Reviewed by Alexey Proskuryakov.
1415
1416         Fix some headers with missing or misspelled #ifndef guards
1417         https://bugs.webkit.org/show_bug.cgi?id=52545
1418
1419         * DumpRenderTree/chromium/TestEventPrinter.h:
1420         * DumpRenderTree/chromium/WebPreferences.h:
1421
1422 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1423
1424         Reviewed by Anders Carlsson.
1425
1426         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1427         navigating back to an unreachable URL
1428         https://bugs.webkit.org/show_bug.cgi?id=52388
1429
1430         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1431
1432         * DumpRenderTree/LayoutTestController.cpp:
1433         (queueLoadHTMLStringCallback):
1434         (LayoutTestController::queueLoadHTMLString):
1435         (LayoutTestController::queueLoadAlternateHTMLString):
1436         * DumpRenderTree/LayoutTestController.h:
1437
1438         * DumpRenderTree/WorkQueueItem.h:
1439         (LoadHTMLStringItem::LoadHTMLStringItem):
1440
1441         * DumpRenderTree/chromium/LayoutTestController.cpp:
1442         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1443         (WorkItemLoadHTMLString::run):
1444         (LayoutTestController::queueLoadHTMLString):
1445
1446         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1447         (LoadHTMLStringItem::invoke):
1448         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1449         (LoadHTMLStringItem::invoke):
1450         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1451         (LoadHTMLStringItem::invoke):
1452
1453 2011-01-17  Dan Bernstein  <mitz@apple.com>
1454
1455         Rubber-stamped by Mark Rowe.
1456
1457         Update xcodeproj svn:ignore to include xcuserdata.
1458
1459         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1460         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1461         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1462         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1463         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1464
1465 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1466
1467         Unreviewed fix after r75908.
1468
1469         Move WebKit into Source
1470         https://bugs.webkit.org/show_bug.cgi?id=52530
1471
1472         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1473
1474 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1475
1476         Unreviewed.
1477
1478         Remove accidentally committed debug printing after r75908.
1479
1480         * Scripts/webkitdirs.pm:
1481
1482 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1483
1484         Unreviewed.
1485
1486         Add myself to committers list
1487         https://bugs.webkit.org/show_bug.cgi?id=52566
1488
1489         * Scripts/webkitpy/common/config/committers.py:
1490
1491 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1492
1493         Reviewed by Jeremy Orlow.
1494
1495         GeolocationController should call stopUpdating on destruction
1496         https://bugs.webkit.org/show_bug.cgi?id=52216
1497
1498         fast/dom/Geolocation/window-close-crash.html requires that a
1499         Geolocation watch be started in a secondary window. Consequently,
1500         we need to allow geolocation permission and provide a mock
1501         geolocation position for the secondary window's
1502         GeolocationClientMock.
1503
1504         * DumpRenderTree/chromium/LayoutTestController.cpp:
1505         (LayoutTestController::setGeolocationPermission):
1506         (LayoutTestController::setMockGeolocationPosition):
1507         (LayoutTestController::setMockGeolocationError):
1508         * DumpRenderTree/chromium/TestShell.h:
1509         (TestShell::windowList):
1510
1511 2011-01-16  Adam Barth  <abarth@webkit.org>
1512
1513         Update more include paths to reflect WebKit move.
1514
1515         * DumpRenderTree/chromium/EventSender.cpp:
1516         (EventSender::keyDown):
1517         (EventSender::needsShiftModifier):
1518         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1519         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1520
1521 2011-01-16  Kent Tamura  <tkent@chromium.org>
1522
1523         Unreviewed, Chromium build fix.
1524
1525         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1526
1527 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1528
1529         Build fix for GTK+ after source directory movement.
1530
1531         * GNUmakefile.am: Correct include paths.
1532
1533 2011-01-16  Adam Barth  <abarth@webkit.org>
1534
1535         Teach svn-apply about WebKit move.
1536
1537         * Scripts/VCSUtils.pm:
1538
1539 2011-01-16  Adam Barth  <abarth@webkit.org>
1540
1541         Rubber-stamped by Eric Seidel.
1542
1543         Move WebKit into Source
1544         https://bugs.webkit.org/show_bug.cgi?id=52530
1545
1546         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1547         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1548         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1549         * DumpRenderTree/qt/GCControllerQt.cpp:
1550         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1551         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1552         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1553         * DumpRenderTree/wscript:
1554         * QtTestBrowser/launcherwindow.h:
1555         * Scripts/build-webkit:
1556         * Scripts/webkitdirs.pm:
1557
1558 2011-01-15  Adam Barth  <abarth@webkit.org>
1559
1560         Teach svn-apply about WebKit2 move.
1561
1562         * Scripts/VCSUtils.pm:
1563
1564 2011-01-15  Adam Barth  <abarth@webkit.org>
1565
1566         Rubber-stamped by Eric Seidel.
1567
1568         Move WebKit2 into Source
1569         https://bugs.webkit.org/show_bug.cgi?id=52438
1570
1571         * MiniBrowser/qt/MiniBrowser.pro:
1572         * Scripts/build-webkit:
1573         * Scripts/do-file-rename:
1574         * Scripts/do-webcore-rename:
1575         * Scripts/test-webkitpy:
1576         * Scripts/webkitdirs.pm:
1577         * Scripts/webkitpy/style/checker.py:
1578         * WebKitTestRunner/DerivedSources.pro:
1579         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1580         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1581
1582 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1583
1584         Reviewed by David Levin.
1585
1586         [chromium] remove obsolete createView method
1587         https://bugs.webkit.org/show_bug.cgi?id=52437
1588
1589         * DumpRenderTree/chromium/WebViewHost.cpp:
1590         (WebViewHost::createView):
1591         * DumpRenderTree/chromium/WebViewHost.h:
1592
1593 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1594
1595         Reviewed by Geoff Garen.
1596
1597         ShouldLoadResourceForFrame should use strings, not URLs.
1598         https://bugs.webkit.org/show_bug.cgi?id=52476
1599
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1601         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1603
1604 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1605
1606         Reviewed by David Levin.
1607
1608         Add Tony Gentilcore as a reviewer
1609         https://bugs.webkit.org/show_bug.cgi?id=52480
1610
1611         * Scripts/webkitpy/common/config/committers.py:
1612
1613 2011-01-14  David Levin  <levin@chromium.org>
1614
1615         Reviewed by Eric Seidel.
1616
1617         check-webkit-style: _FunctionState should keep track of where the function name starts.
1618         https://bugs.webkit.org/show_bug.cgi?id=52454
1619
1620         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1621         _FunctionState and logic for setting it correctly.
1622         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1623
1624 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1625
1626         Reviewed by David Levin.
1627
1628         Add support to DumpRenderTree to use the GPU rather than software renderer
1629         https://bugs.webkit.org/show_bug.cgi?id=52333
1630
1631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1632         (main):
1633         * Scripts/webkitpy/layout_tests/port/chromium.py:
1634         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1635
1636 2011-01-14  Tony Chang  <tony@chromium.org>
1637
1638         Reviewed by Kent Tamura.
1639
1640         [chromium] update fonts.conf to fix 6 linux tests in drt
1641         https://bugs.webkit.org/show_bug.cgi?id=52411
1642
1643         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1644             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1645
1646 2011-01-14  Eric Seidel  <eric@webkit.org>
1647
1648         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1649
1650         Reviewed by Adam Barth.
1651
1652         Fix when running Tools/Scripts/check-webkit-style without arguments.
1653         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1654
1655         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1656         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1657
1658 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1659
1660         Reviewed by David Levin.
1661
1662         Store the tempdir object in a variable so it doesn't get deleted too early.
1663         https://bugs.webkit.org/show_bug.cgi?id=51875
1664
1665         * Scripts/update-webkit-auxiliary-libs:
1666         * Scripts/update-webkit-support-libs:
1667
1668 2011-01-14  Eric Seidel  <eric@webkit.org>
1669
1670         Unreviewed.  Make it work in python 2.5.
1671
1672         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1673         https://bugs.webkit.org/show_bug.cgi?id=49158
1674
1675         * Scripts/webkitpy/common/checkout/api_unittest.py:
1676
1677 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1678
1679         Unreviewed, rolling out r75774.
1680         http://trac.webkit.org/changeset/75774
1681         https://bugs.webkit.org/show_bug.cgi?id=52431
1682
1683         gtk builds were broken (Requested by loislo2 on #webkit).
1684
1685         * Scripts/webkitpy/common/checkout/scm.py:
1686
1687 2011-01-14  David Levin  <levin@chromium.org>
1688
1689         Reviewed by Shinichiro Hamaji.
1690
1691         check-webkit-style: _FunctionState should detect pure functions.
1692         https://bugs.webkit.org/show_bug.cgi?id=52428
1693
1694         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1695         is a pure virtual function.
1696         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1697         virtual functions are correctly detected.
1698
1699 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1700
1701         Reviewed by Yury Semikhatsky.
1702
1703         Just small fix for problem with check-webkit-style.
1704         It just didn't work for this patch.
1705         Old code can't concatenate a list of strings with None.
1706
1707         * Scripts/webkitpy/common/checkout/scm.py:
1708
1709 2011-01-13  David Levin  <levin@chromium.org>
1710
1711         Reviewed by Shinichiro Hamaji.
1712
1713         check-webkit-style: _FunctionState should use Position to know where items are.
1714         https://bugs.webkit.org/show_bug.cgi?id=52424
1715
1716         * Scripts/webkitpy/style/checkers/cpp.py:
1717         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1718         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1719         did some minor clean-up.
1720         (*): Other changes are simply about converting to use the Position's in_FunctionState
1721         instead of line numbers.
1722         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1723         to verify the positions stored in _FunctionState.
1724
1725 2011-01-13  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by David Levin.
1728
1729         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1730         https://bugs.webkit.org/show_bug.cgi?id=49158
1731
1732         This is not the most elegant, but it is a very safe fix to this bug.
1733         One advantage of catching ScriptError like this instead of adding a
1734         new added_or_modified_files or fixing all changed_files callers
1735         to use a more specific change_files variant, is that we catch
1736         all kinds of ScriptErrors which might cause our (non-essential)
1737         suggest-reviewers code to fail out.  This should make passing
1738         --suggest-reviewers to webkit-patch upload much more robust
1739         and may even make it possible for us to make it default.
1740
1741         The root of the problem here is that SCM.changed_files includes
1742         deleted ChangeLog paths (from moves, etc) which then when we ask
1743         SVN/Git for the contents of the file at that revision, the command
1744         errors out and Executive.run_command raises a ScriptError.
1745
1746         In the future we might fix this differently by making all current
1747         callers of chagned_files use a more specific method for requesting
1748         what types of changes they're interested in (adds, modifies, deletes, etc.)
1749
1750         * Scripts/webkitpy/common/checkout/api.py:
1751         * Scripts/webkitpy/common/checkout/api_unittest.py:
1752
1753 2011-01-13  Dan Bernstein  <mitz@apple.com>
1754
1755         Reviewed by Alexey Proskuryakov.
1756
1757         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1758         https://bugs.webkit.org/show_bug.cgi?id=52419
1759
1760         Allow to further control the behavior of the willSendRequest delegate callback by making it
1761         set a different URL in the new request.
1762
1763         * DumpRenderTree/LayoutTestController.cpp:
1764         (addURLToRedirectCallback): Added.
1765         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1766         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1767         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1768         * DumpRenderTree/LayoutTestController.h:
1769         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1770         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1771         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1772         change the URL in the new request to the redirect destination.
1773
1774 2011-01-13  Eric Seidel  <eric@webkit.org>
1775
1776         Reviewed by Mihai Parparita.
1777
1778         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1779         https://bugs.webkit.org/show_bug.cgi?id=52416
1780
1781         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1782         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1783
1784         I also added FIXMEs about the changed_files returning deleted files problem
1785         which is causing the other most common exception for suggest-reviewers
1786         (and is probably breaking sheriff-bots blame detection).
1787
1788         * Scripts/webkitpy/common/checkout/api.py:
1789         * Scripts/webkitpy/common/checkout/api_unittest.py:
1790         * Scripts/webkitpy/common/checkout/scm.py:
1791
1792 2011-01-13  Eric Seidel  <eric@webkit.org>
1793
1794         Reviewed by Adam Barth.
1795
1796         results archives from commit-queue are too large to upload
1797         https://bugs.webkit.org/show_bug.cgi?id=52405
1798
1799         * Scripts/webkitpy/common/system/filesystem.py:
1800         * Scripts/webkitpy/common/system/filesystem_mock.py:
1801         * Scripts/webkitpy/tool/commands/queues.py:
1802
1803 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1804
1805         Reviewed by Martin Robinson.
1806
1807         [gtk] Zero-sized font does not yet work
1808         https://bugs.webkit.org/show_bug.cgi?id=49793
1809
1810         Set minimum-font-size to 0 for the DRT.
1811
1812         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1813         (resetDefaultsToConsistentValues):
1814
1815 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1816
1817         Reviewed by Darin Adler.
1818
1819         Make old-run-webkit-tests more robust on buildbots
1820         https://bugs.webkit.org/show_bug.cgi?id=52364
1821
1822         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1823
1824 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1825
1826         Reviewed by Darin Adler.
1827
1828         Make old-run-webkit-tests more robust on buildbots
1829         https://bugs.webkit.org/show_bug.cgi?id=52364
1830
1831         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1832
1833 2011-01-13  Tony Chang  <tony@chromium.org>
1834
1835         Reviewed by Kent Tamura.
1836
1837         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1838         https://bugs.webkit.org/show_bug.cgi?id=52332
1839
1840         Forked Info.plist is not longer needed.
1841
1842         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1843
1844 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1845
1846         Reviewed by Timothy Hatcher.
1847
1848         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1849         to be passed directly to WebInspector.UIString
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=52365
1852
1853         * Scripts/check-inspector-strings:
1854
1855 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1856
1857         Unreviewed, rolling out r74881.
1858         http://trac.webkit.org/changeset/74881
1859         https://bugs.webkit.org/show_bug.cgi?id=52357
1860
1861         The EFL builder has been red for days (Requested by abarth on
1862         #webkit).
1863
1864         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1865         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1866
1867 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1868
1869         Reviewed by David Levin.
1870
1871         Add beforeunload support to WebKitTestRunner
1872         https://bugs.webkit.org/show_bug.cgi?id=52353
1873         
1874         This makes a number of currently failing tests pass.
1875
1876         * WebKitTestRunner/TestController.cpp:
1877         (WTR::runBeforeUnloadConfirmPanel):
1878         (WTR::createOtherPage):
1879         (WTR::TestController::initialize):
1880
1881 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1882
1883         Reviewed by Sam Weinig.
1884
1885         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1886         https://bugs.webkit.org/show_bug.cgi?id=52330
1887
1888         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1889         a web process crash.
1890         * WebKitTestRunner/TestController.cpp:
1891         (WTR::TestController::initialize): Set up a processDidCrash
1892         callback.
1893         (WTR::TestController::processDidCrash): Report that the Web process
1894         crashed.
1895         * WebKitTestRunner/TestController.h:
1896
1897 2011-01-12  David Levin  <levin@chromium.org>
1898
1899         Reviewed by Shinichiro Hamaji.
1900
1901         check-webkit-style -- close_expression function doesn't work correctly.
1902         https://bugs.webkit.org/show_bug.cgi?id=52272
1903
1904         * Scripts/webkitpy/style/checkers/cpp.py:
1905         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1906         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1907         generally useful (for upcoming code changes).
1908         (close_expression): Changed to use Position for input and output.
1909         Also, fixed many bugs such as only working correctly for parenthesis,
1910         not working correctly if given an offset in a line and not finding
1911         the real closing element if there were multiple closing elements in
1912         the same line.
1913         (detect_functions): Adjusted due to the change in arguments for
1914         close_expression.
1915         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1916         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1917         two positions are the same.
1918         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1919         (CppStyleTest.test_close_expression): Added tests to catch the issues
1920         that were fixed.
1921
1922 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1923
1924         Unreviewed, rolling out r75576.
1925         http://trac.webkit.org/changeset/75576
1926         https://bugs.webkit.org/show_bug.cgi?id=52304
1927
1928         broke rebaseline-chromium-webkit-test (Requested by thakis on
1929         #webkit).
1930
1931         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1932         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1933         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1934         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1935         * Scripts/webkitpy/layout_tests/port/base.py:
1936         * Scripts/webkitpy/layout_tests/port/chromium.py:
1937         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1938         * Scripts/webkitpy/layout_tests/port/test.py:
1939         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1940         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1941         * Scripts/webkitpy/style/checkers/test_expectations.py:
1942         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1943
1944 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1945
1946         Reviewed by Darin Adler.
1947
1948         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1949         https://bugs.webkit.org/show_bug.cgi?id=52307
1950
1951         * Scripts/old-run-webkit-tests:
1952
1953 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1954
1955         Reviewed by Martin Robinson.
1956
1957         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1958         https://bugs.webkit.org/show_bug.cgi?id=50867
1959
1960         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1961         TestNetscapePlugin.cpp 
1962
1963         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1964         * Scripts/webkitdirs.pm:
1965
1966 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1967
1968         Reviewed by Pavel Feldman.
1969
1970         Add check-inspector-strings script.
1971
1972         https://bugs.webkit.org/show_bug.cgi?id=52295
1973
1974         * Scripts/check-inspector-strings: Added.
1975
1976 2011-01-12  Adam Roben  <aroben@apple.com>
1977
1978         Advertise the .testnetscape file extension on Windows
1979
1980         Fixes <http://webkit.org/b/52298>
1981         plugins/no-mime-with-valid-extension.html fails on Windows
1982
1983         Reviewed by Dan Bernstein.
1984
1985         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1986         FileExtents field to map the .testnetscape file extension to the
1987         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1988
1989 2011-01-12  Adam Barth  <abarth@webkit.org>
1990
1991         Reviewed by Eric Seidel.
1992
1993         Make webkit-patch support subdirectories for SVN checkouts
1994         https://bugs.webkit.org/show_bug.cgi?id=52261
1995
1996         os.relpath does not exist on Python 2.5, so we need to call our version
1997         of the API.
1998
1999         * Scripts/webkitpy/common/checkout/scm.py:
2000
2001 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2002
2003         Reviewed by Eric Seidel.
2004
2005         Close additional pages opened during a test once the test completes.
2006         https://bugs.webkit.org/show_bug.cgi?id=52276
2007
2008         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2009         (WTR::InjectedBundle::done):
2010
2011 2011-01-11  David Levin  <levin@chromium.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         Errors should be separated from the command line in bot messages.
2016         https://bugs.webkit.org/show_bug.cgi?id=52275
2017
2018         * Scripts/webkitpy/common/system/executive.py:
2019         (ScriptError.message_with_output): Added a newline to separate the command
2020         line from the errors.
2021         * Scripts/webkitpy/common/system/executive_unittest.py:
2022         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2023         paths in message_with_output.
2024
2025 2011-01-11  Eric Seidel  <eric@webkit.org>
2026
2027         Unreviewed.
2028
2029         commit-queue should know how to upload archived results (for test flakes or general failures)
2030         https://bugs.webkit.org/show_bug.cgi?id=52048
2031
2032         The zips are mostly empty due to forgetting -r.
2033         Expected diffs were not being pulled from the archive due
2034         to the archive having longer paths than I realized.
2035
2036         * Scripts/webkitpy/common/system/workspace.py:
2037         * Scripts/webkitpy/common/system/workspace_unittest.py:
2038         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2039         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2040
2041 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2042
2043         Reviewed by Ojan Vafai.
2044
2045         The current modifier parsing code in test_expectations is
2046         fragile and hard-coded, so it's not easy to understand the logic
2047         or easily add new types of modifiers (like GPU vs. CPU testing
2048         for graphics tests, or 32-bit vs. 64-bit differences).
2049
2050         This is the first of two patches that will add in more generic
2051         support and then eliminate the GPU-specific test expectations
2052         files for Chromium.
2053
2054         This patch adds two standalone objects for handling modifiers. The
2055         rules for interpreting modifiers, precedence, and conflicts are
2056         given in the docstring to the ModifierMatcher class, which
2057         returns ModifierMatchResult objects.
2058         
2059         This patch also adds routines to the Port interface and a
2060         default set of values in the base object, in order to obtain the
2061         values needed on a given test run. These values are then passed
2062         to the expectation parser. This also allows us to clean up the
2063         logic used to lint all of the different configurations in a
2064         single test_expectations.txt file.
2065
2066         The next patch will merge in the separate GPU expectations file.
2067
2068         https://bugs.webkit.org/show_bug.cgi?id=51222
2069
2070         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2071         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2072         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2073         * Scripts/webkitpy/layout_tests/port/base.py:
2074         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2075         * Scripts/webkitpy/layout_tests/port/chromium.py:
2076         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2077         * Scripts/webkitpy/layout_tests/port/test.py:
2078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2079         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2080
2081 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2082
2083         Reviewed by Adam Barth.
2084
2085         Make webkit-patch support subdirectories for SVN checkouts
2086         https://bugs.webkit.org/show_bug.cgi?id=52261
2087
2088         * Scripts/webkitpy/common/checkout/scm.py:
2089         * Scripts/webkitpy/style_references.py:
2090         * Scripts/webkitpy/tool/main.py:
2091         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2092
2093 2011-01-11  Eric Seidel  <eric@webkit.org>
2094
2095         Unreviewed.
2096
2097         commit-queue should know how to upload archived results (for test flakes or general failures)
2098         https://bugs.webkit.org/show_bug.cgi?id=52048
2099
2100         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2101         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2102
2103         * Scripts/webkitpy/common/system/workspace.py:
2104         * Scripts/webkitpy/common/system/workspace_unittest.py:
2105         * Scripts/webkitpy/tool/commands/queues.py:
2106
2107 2011-01-11  Sam Weinig  <sam@webkit.org>
2108
2109         Roll r75474 back in.
2110
2111 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2112
2113         Reviewed by Kenneth Rohde Christiansen.
2114
2115         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2116         https://bugs.webkit.org/show_bug.cgi?id=51204
2117
2118         * QtTestBrowser/webpage.h:
2119         (QtNAMThread::QtNAMThread):
2120         (QtNAMThread::networkAccessManager):
2121         (QtNAMThread::run):
2122
2123 2011-01-11  Peter Varga  <pvarga@webkit.org>
2124
2125         Unreviewed.
2126
2127         Add myself to committers' list.
2128
2129         * Scripts/webkitpy/common/config/committers.py:
2130
2131 2011-01-11  Eric Seidel  <eric@webkit.org>
2132
2133         Reviewed by Adam Barth.
2134
2135         commit-queue should know how to upload archived results (for test flakes or general failures)
2136         https://bugs.webkit.org/show_bug.cgi?id=52048
2137
2138         Now the queue will always upload results.  Either the entire zip, or just
2139         the diffs.txt in the case of text failures.
2140
2141         This should make understanding flakes much easier, and paves the way
2142         for having the EWS run layout tests (and upload failures).
2143
2144         In order to upload .zip files I had to teach bugzilla.py to autodetect
2145         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2146         for .patch files, I have it add one before calling guess_type.
2147
2148         We may find that always uploading the whole zip instead of just the -diffs.txt
2149         file is preferable, but for now I'm keeping the old behavior because it makes
2150         quickly understanding text failures easy.
2151
2152         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2153         * Scripts/webkitpy/common/system/workspace.py: Added.
2154         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2155         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2156         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2157         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2158         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2159         * Scripts/webkitpy/tool/commands/queues.py:
2160         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2161
2162 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2163
2164         Unreviewed, rolling out r75464.
2165         http://trac.webkit.org/changeset/75464
2166         https://bugs.webkit.org/show_bug.cgi?id=52193
2167
2168         Followup rollout for 75474 (Requested by Ossy on #webkit).
2169
2170         * MiniBrowser/mac/BrowserWindowController.m:
2171         (-[BrowserWindowController awakeFromNib]):
2172         * MiniBrowser/win/BrowserView.cpp:
2173         (BrowserView::create):
2174         * WebKitTestRunner/TestController.cpp:
2175         (WTR::createOtherPage):
2176         (WTR::TestController::initialize):
2177
2178 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2179
2180         Reviewed by Csaba Osztrogonác.
2181
2182         [Qt] Baseline qt_minimal configuration
2183         https://bugs.webkit.org/show_bug.cgi?id=51313
2184
2185         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2186         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2187         QT_NO_UNDOSTACK guard.
2188
2189         * QtTestBrowser/launcherwindow.cpp:
2190         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2191         guards.
2192         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2193         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2194         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2195         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2196
2197         * QtTestBrowser/launcherwindow.h:
2198         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2199         * QtTestBrowser/locationedit.h: Ditto.
2200
2201         * QtTestBrowser/mainwindow.cpp:
2202         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2203         QT_NO_UNDOSTACK guards.
2204         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2205         (MainWindow::changeLocation): Ditto.
2206         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2207         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2208
2209         * QtTestBrowser/webpage.cpp:
2210         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2211         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2212
2213         * QtTestBrowser/webview.cpp:
2214         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2215         (WebViewGraphicsBased::animatedYFlip): Ditto.
2216
2217 2011-01-10  Sam Weinig  <sam@webkit.org>
2218
2219         Fix build.
2220
2221         * MiniBrowser/mac/BrowserWindowController.m:
2222         (-[BrowserWindowController awakeFromNib]):
2223         * MiniBrowser/win/BrowserView.cpp:
2224         (BrowserView::create):
2225         * WebKitTestRunner/TestController.cpp:
2226         (WTR::createOtherPage):
2227         (WTR::TestController::initialize):
2228
2229 2011-01-10  Eric Seidel  <eric@webkit.org>
2230
2231         Reviewed by Ojan Vafai.
2232
2233         style-queue messages are way too long for big patches
2234         https://bugs.webkit.org/show_bug.cgi?id=52161
2235
2236         We definitely could build much fancier list-to-string-with-limit functions
2237         but this should be sufficient for our needs at the moment.
2238
2239         * Scripts/webkitpy/common/system/executive.py:
2240         * Scripts/webkitpy/common/system/executive_unittest.py:
2241
2242 2011-01-10  Tony Chang  <tony@chromium.org>
2243
2244         Unreviewed, rolling out r75398.
2245         http://trac.webkit.org/changeset/75398
2246         https://bugs.webkit.org/show_bug.cgi?id=52008
2247
2248         Some layout tests are crashing on Chromium Win.
2249
2250         * DumpRenderTree/chromium/WebViewHost.cpp:
2251         (WebViewHost::updatePaintRect):
2252         * DumpRenderTree/chromium/WebViewHost.h:
2253
2254 2011-01-10  Adam Roben  <aroben@apple.com>
2255
2256         Roll out r75392
2257
2258         It isn't needed now that r75289 has been rolled out.
2259
2260         * Scripts/run-javascriptcore-tests:
2261
2262 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2263
2264         Reviewed by Anders Carlsson.
2265
2266         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2267         https://bugs.webkit.org/show_bug.cgi?id=52160
2268
2269         * WebKitTestRunner/mac/TestControllerMac.mm:
2270         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2271         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2272         anyway.
2273
2274 2011-01-10  Tony Chang  <tony@chromium.org>
2275
2276         Reviewed by Mihai Parparita.
2277
2278         [chromium] fix for animated gif layout tests
2279         https://bugs.webkit.org/show_bug.cgi?id=52008
2280
2281         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2282             to trigger gif animations.
2283         (WebViewHostPaintTask::WebViewHostPaintTask):
2284         (WebViewHostPaintTask::runIfValid):
2285         (WebViewHost::updatePaintRect):
2286         * DumpRenderTree/chromium/WebViewHost.h:
2287         (WebViewHost::taskList):
2288
2289 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2290
2291         Reviewed by Xan Lopez.
2292
2293         [GTK] Fix gtk2 compilation for master
2294         https://bugs.webkit.org/show_bug.cgi?id=51885
2295
2296         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2297         (createBitmapContextFromWebView): Replaced the old
2298         gdk_drawable_get_size with gdk_pixmap_get_size.
2299
2300 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2301
2302         Reviewed by Laszlo Gombos.
2303
2304         [WINCE] Reenable NPAPI after r75203
2305         https://bugs.webkit.org/show_bug.cgi?id=52109
2306
2307         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2308         it with !isEfl(), because EFL port does not support NPAPI (yet).
2309
2310         * Scripts/build-webkit:
2311
2312 2011-01-10  Adam Roben  <aroben@apple.com>
2313
2314         Skip some asserting JS tests
2315
2316         See <http://webkit.org/b/52156>.
2317
2318         * Scripts/run-javascriptcore-tests:
2319
2320 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2321
2322         Reviewed by Xan Lopez.
2323
2324         [GTK] build-webkit disable Blob support via arguments passed to automake
2325         https://bugs.webkit.org/show_bug.cgi?id=52097
2326
2327         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2328         build-webkit.
2329
2330 2011-01-10  Adam Roben  <aroben@apple.com>
2331
2332         Use the same name and description for TestNetscapePlugin on Windows and
2333         Mac
2334
2335         Fixes <http://webkit.org/b/52151>
2336         fast/frames/iframe-reparenting-plugins.html fails on Windows
2337
2338         Reviewed by Steve Falkenburg.
2339
2340         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2341         the name and description from Mac's Info.plist.
2342
2343 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2344
2345         Reviewed by Laszlo Gombos.
2346
2347         [Qt][WK2] Guard gcc-specific syntax
2348
2349         Non-gcc based compliers choke on the "-include"
2350         syntax for preinclude, place guard around it.
2351
2352         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2353         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2354
2355 2011-01-10  Andreas Kling  <kling@webkit.org>
2356
2357         Reviewed by Simon Hausmann.
2358
2359         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2360         https://bugs.webkit.org/show_bug.cgi?id=52111
2361
2362         When getting a createNewPage() callback from QWKPage, create the
2363         new page with the same QWKContext as the page that is passed to
2364         the callback.
2365
2366         * MiniBrowser/qt/BrowserView.h:
2367         * MiniBrowser/qt/BrowserWindow.cpp:
2368         (newPageFunction):
2369         (BrowserWindow::BrowserWindow):
2370         * MiniBrowser/qt/BrowserWindow.h:
2371
2372 2011-01-10  Andreas Kling  <kling@webkit.org>
2373
2374         Reviewed by Kenneth Rohde Christiansen.
2375
2376         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2377
2378         BrowserView set its own useless createNewPage() callback on QWKPage.
2379         This was immediately overridden by BrowserWindow anyway, so remove
2380         the BrowserView one.
2381
2382         * MiniBrowser/qt/BrowserView.cpp:
2383         (BrowserView::BrowserView):
2384
2385 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2386
2387         Reviewed by Jeremy Orlow.
2388
2389         [Chromium] Remove non-client-based Geolocation code
2390         https://bugs.webkit.org/show_bug.cgi?id=50921
2391
2392         * DumpRenderTree/chromium/LayoutTestController.cpp:
2393         (LayoutTestController::setGeolocationPermission):
2394         (LayoutTestController::setMockGeolocationPosition):
2395         (LayoutTestController::setMockGeolocationError):
2396         * DumpRenderTree/chromium/WebViewHost.cpp:
2397         (WebViewHost::geolocationClientMock):
2398         (WebViewHost::reset):
2399         * DumpRenderTree/chromium/WebViewHost.h:
2400
2401 2011-01-10  Eric Seidel  <eric@webkit.org>
2402
2403         Reviewed by Adam Barth.
2404
2405         Commit bot tried to land r? cq+ patch
2406         https://bugs.webkit.org/show_bug.cgi?id=36638
2407
2408         It should now be possible to post a patch with r? and cq+ and the
2409         commit-queue will correctly wait for the r+ before attempting to land the patch.
2410         (This was a feature requested by several users.)
2411
2412         One caveat: We don't actually reject r-, cq+ patches from the queue
2413         (we just ignore them), but I think that's OK for now.
2414
2415         I also noticed that setting r- once a commit-queue node had grabbed
2416         a patch would not properly cancel the landing.  That's fixed and
2417         tested in this patch.
2418
2419         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2420         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2421         * Scripts/webkitpy/tool/bot/feeders.py:
2422         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2423
2424 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2425
2426         Reviewed by Kenneth Rohde Christiansen.
2427
2428         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2429         https://bugs.webkit.org/show_bug.cgi?id=51934
2430
2431         When accessing the network from the destructor of QWebPage, the network access manager
2432         was already deleted because the object WebPage was already destructed.
2433
2434         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2435         The object is now destructed in the destructor of QObject.
2436
2437         * QtTestBrowser/webpage.cpp:
2438         (WebPage::WebPage):
2439         (WebPage::setQnamThreaded):
2440         * QtTestBrowser/webpage.h:
2441         (QtNAMThread::QtNAMThread):
2442
2443 2011-01-08  Eric Seidel  <eric@webkit.org>
2444
2445         Reviewed by Ojan Vafai.
2446
2447         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2448         https://bugs.webkit.org/show_bug.cgi?id=52067
2449
2450         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2451         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2452
2453         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2454
2455 2011-01-08  Eric Seidel  <eric@webkit.org>
2456
2457         Reviewed by Mihai Parparita.
2458
2459         commit-queue hangs when the ChangeLog diff is bad
2460         https://bugs.webkit.org/show_bug.cgi?id=52072
2461
2462         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2463         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2464
2465 2011-01-08  Adam Barth  <abarth@webkit.org>
2466
2467         Teach svn-apply how to re-write WebCore to Source/WebCore.
2468
2469         * Scripts/VCSUtils.pm:
2470
2471 2011-01-07  Adam Barth  <abarth@webkit.org>
2472
2473         Rubber-stamped by Eric Seidel.
2474
2475         Move WebCore to Source
2476         https://bugs.webkit.org/show_bug.cgi?id=52050
2477
2478         Update the tools to understand WebCore's new location.
2479
2480         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2481         * DumpRenderTree/wscript:
2482         * GNUmakefile.am:
2483         * Scripts/build-webkit:
2484         * Scripts/do-file-rename:
2485         * Scripts/do-webcore-rename:
2486         * Scripts/generate-qt-inspector-resource:
2487         * Scripts/prepare-ChangeLog:
2488         * Scripts/run-bindings-tests:
2489         * Scripts/update-iexploder-cssproperties:
2490         * Scripts/update-sources-list.py:
2491         * Scripts/update-webkit-localizable-strings:
2492         * Scripts/webkitdirs.pm:
2493         * Scripts/webkitpy/common/config/build.py:
2494         * Scripts/webkitpy/common/config/build_unittest.py:
2495         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2496         * Scripts/webkitpy/style/checker.py:
2497         * Scripts/webkitpy/style/checker_unittest.py:
2498         * WebKitTestRunner/DerivedSources.pro:
2499         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2500         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2501         * wx/browser/wscript:
2502         * wx/build/settings.py:
2503
2504 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2505
2506         Reviewed by Sam Weinig.
2507
2508         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2509         https://bugs.webkit.org/show_bug.cgi?id=52086
2510
2511         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2512         (WTR::InjectedBundle::didReceiveMessage):
2513         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2514         (WTR::LayoutTestController::notifyDone):
2515         * WebKitTestRunner/TestController.cpp:
2516         (WTR::TestController::resetStateToConsistentValues):
2517         (WTR::TestController::run):
2518
2519 2011-01-07  James Robinson  <jamesr@chromium.org>
2520
2521         Revert "Implement mozilla's animationTime property"
2522         https://bugs.webkit.org/show_bug.cgi?id=51952
2523
2524         This approach isn't quite right.
2525
2526         * DumpRenderTree/chromium/WebViewHost.cpp:
2527         (WebViewHost::paintInvalidatedRegion):
2528
2529 2011-01-07  Adam Roben  <aroben@apple.com>
2530
2531         Build master fix
2532
2533         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2534         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2535
2536 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2537
2538         Reviewed by Csaba Osztrogonác.
2539
2540         run-qtwebkit-tests should be able to kill a testsuite.
2541
2542         Add new option in the script that can setup a timeout for a test.
2543         If the test execution takes more then specified time then the test
2544         would be terminated.
2545
2546         [Qt] run-qtwebkit-tests needs timeout
2547         https://bugs.webkit.org/show_bug.cgi?id=51894
2548
2549         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2550         * Scripts/run-qtwebkit-tests:
2551
2552 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2553
2554         Unreviewed fix after r75233.
2555
2556         Based on idea from Eric Seidel.
2557
2558         Add remote zip file handling to webkitpy.
2559         https://bugs.webkit.org/show_bug.cgi?id=50901
2560
2561         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2562
2563 2011-01-07  Shane Stephens  <shanestephens@google.com>
2564
2565         Reviewed by Eric Seidel.
2566
2567         svn-apply: should support git binary delta diffs
2568         https://bugs.webkit.org/show_bug.cgi?id=38864
2569
2570         * Scripts/VCSUtils.pm:
2571         * Scripts/svn-apply:
2572
2573 2011-01-06  Julie Parent  <jparent@chromium.org>
2574
2575         Reviewed by Eric Seidel.
2576
2577         Test Result Server not removing old results.
2578         https://bugs.webkit.org/show_bug.cgi?id=52012
2579
2580         * TestResultServer/model/jsonresults.py:
2581         Fix off-by-one: Truncate if >= num_runs, not just >.
2582         * TestResultServer/model/jsonresults_unittest.py:
2583         Add unit test to test that merging in a new result with the same value
2584         as the last result causes previous result to fall off.
2585
2586 2011-01-06  James Kozianski  <koz@chromium.org>
2587
2588         Reviewed by Mihai Parparita.
2589
2590         Add classes to provide a consistent interface to a set of files.
2591         https://bugs.webkit.org/show_bug.cgi?id=50901
2592
2593         These classes allow us to write code that is agnostic to whether a
2594         particular set of files resides in a local directory or in a zip file
2595         on a remote machine.
2596
2597         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2598         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2599         * Scripts/webkitpy/common/system/fileset.py: Added.
2600         * Scripts/webkitpy/common/system/filesystem.py:
2601         * Scripts/webkitpy/common/system/filesystem_mock.py:
2602         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2603         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2604
2605 2011-01-06  Eric Seidel  <eric@webkit.org>
2606
2607         Reviewed by Adam Barth.
2608
2609         NetworkTransaction should log the url it is retrying
2610         https://bugs.webkit.org/show_bug.cgi?id=52043
2611
2612         * Scripts/webkitpy/common/net/networktransaction.py:
2613         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2614
2615 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2616
2617         Windows build fix.
2618         Import os before using it.
2619
2620         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2621
2622 2011-01-06  Eric Seidel  <eric@webkit.org>
2623
2624         Reviewed by Adam Barth.
2625
2626         StyleQueue fails to report errors when patches have many files
2627         https://bugs.webkit.org/show_bug.cgi?id=52042
2628
2629         This is one of at least two errors preventing style error reporting at the moment.
2630         When we moved to passing the list of files to check explicitly,
2631         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2632         We could change the type of the QueueStatus.message type, or we could
2633         just teach statusserver.py how to clamp values (and warn when it does).
2634         I chose the latter path.
2635
2636         * Scripts/webkitpy/common/net/statusserver.py:
2637
2638 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2639
2640         Reviewed by Stephanie Lewis.
2641         
2642         Fix syntax error in script.
2643
2644         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2645         https://bugs.webkit.org/show_bug.cgi?id=51996
2646
2647         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2648
2649 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2650
2651         Unreviewed, fixing WinCE build after r75196.
2652
2653         WinCE port does not (yet) support NPAPI.
2654
2655         * Scripts/build-webkit:
2656
2657 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2658
2659         Reviewed by Darin Adler.
2660
2661         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2662         https://bugs.webkit.org/show_bug.cgi?id=52015
2663
2664         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2665         after the platform has been detected, otherwise the script will
2666         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2667         detection.
2668
2669 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2670
2671         Reviewed by Eric Seidel.
2672
2673         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2674         https://bugs.webkit.org/show_bug.cgi?id=51346
2675
2676         * Scripts/build-webkit:
2677
2678 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2679
2680         Reviewed by Adam Roben.
2681
2682         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2683         https://bugs.webkit.org/show_bug.cgi?id=51996
2684         
2685         After the configuration directory change, we were archiving the incorrect directory for
2686         build product, so we were running tests on the wrong binaries.
2687         
2688         This change archives the correct directory, and also unarchives it into a configuration-
2689         specific directory.
2690
2691         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2692         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2693
2694 2011-01-06  Eric Seidel  <eric@webkit.org>
2695
2696         Reviewed by Mihai Parparita.
2697
2698         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2699         https://bugs.webkit.org/show_bug.cgi?id=52002
2700
2701         See an example of this here:
2702         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2703
2704         It's due to the fact that we pass around TestFailure() instance
2705         objects and yet expect them to all compare to be the same.
2706
2707         This is bad.  We should either have shared instances of these values
2708         or we should just pass around the class names.  There are already hacks
2709         in place to make TestFailure objects pass equality tests, I just added
2710         a __hash__ implementation so they can be used in sets as expected.
2711
2712         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2713         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2714
2715 2011-01-06  Evan Martin  <evan@chromium.org>
2716
2717         Reviewed by Tony Chang.
2718
2719         [gdb] handle inaccessible memory and UChar*
2720         https://bugs.webkit.org/show_bug.cgi?id=52003
2721
2722         To pretty-print a UChar*, we just grope around in the memory
2723         looking for a terminating NUL.  We need to handle the exception
2724         that can occur when we poke into an invalid location.
2725
2726         Additionally, the logic for choosing which pretty-printer would
2727         early return before hitting the point where we'd use the UChar*
2728         printer.  (Did this ever work?  How did it regress?)
2729
2730         * gdb/webkit.py:
2731
2732 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2733
2734         Reviewed by Ada Chan.
2735
2736         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2737         https://bugs.webkit.org/show_bug.cgi?id=51969
2738         
2739         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2740
2741         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2742         (WTR::InjectedBundlePage::InjectedBundlePage):
2743         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2744         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2745
2746 2011-01-06  James Robinson  <jamesr@chromium.org>
2747
2748         Reviewed by Simon Fraser.
2749
2750         Implement mozilla's animationTime property
2751         https://bugs.webkit.org/show_bug.cgi?id=51952
2752
2753         Chromium DRT support for webkitAnimationTime.
2754
2755         * DumpRenderTree/chromium/WebViewHost.cpp:
2756         (WebViewHost::paintInvalidatedRegion):
2757
2758 2011-01-06  Julie Parent  <jparent@chromium.org>
2759
2760         Reviewed by Tony Chang.
2761
2762         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2763         https://bugs.webkit.org/show_bug.cgi?id=51217
2764
2765         * TestResultServer/model/jsonresults.py:
2766         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2767         Adds missing documentation.
2768         * TestResultServer/model/jsonresults_unittest.py:
2769         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2770         Update test_merge to take a number of builds to truncate at.
2771
2772 2011-01-06  Adam Barth  <abarth@webkit.org>
2773
2774         Reviewed by Eric Seidel.
2775
2776         The EWS should log outside of the working directory
2777         https://bugs.webkit.org/show_bug.cgi?id=51986
2778
2779         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2780         script, which will actually clean the working copy back to a pristine
2781         state instead of leaving untracked directories and ignored files.
2782
2783         * Scripts/webkitpy/tool/commands/queues.py:
2784         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2785
2786 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2787
2788         Windows build fix.
2789         Back out attempted change to built-product-archive.
2790
2791         * BuildSlaveSupport/built-product-archive:
2792
2793 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2794
2795         Windows build fix.
2796         Include configuration name when unpacking a build archive.
2797
2798         Needed, since we split Windows build results into configuration-specific directories
2799         under WebKitOutputDir.
2800
2801         * BuildSlaveSupport/built-product-archive:
2802
2803 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2804
2805         Reviewed by Darin Adler.
2806
2807         Debug and Release builds on Windows clobber each other
2808         https://bugs.webkit.org/show_bug.cgi?id=49185
2809
2810         Changes the structure of WebKitBuild build products directory so we
2811         completely separate each build configuration into independent directories.
2812         
2813         Although we previously had per-configuration directories for obj, this change adds
2814         per-configuration directories for bin, lib, obj, and include. Each configuration's
2815         build products are stored within a directory inside of WebKitBuild.
2816         
2817         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2818         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2819
2820         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2821         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2822         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2823         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2824         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2825         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2826         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2827         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2828         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2829         * FindSafari/FindSafari.vcproj:
2830         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2831         * MiniBrowser/MiniBrowserPostBuild.cmd:
2832         * MiniBrowser/MiniBrowserPreBuild.cmd:
2833         * Scripts/webkitdirs.pm:
2834         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2835         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2836         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2837         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2838         * TestWebKitAPI/win/copy-resources.cmd:
2839         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2840         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2841         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2842         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2843         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2844         * WebKitTestRunner/win/InjectedBundle.vcproj:
2845         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2846         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2847         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2848         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2849         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2850         * WinLauncher/WinLauncherCommon.vsprops:
2851         * WinLauncher/WinLauncherPostBuild.cmd:
2852         * WinLauncher/WinLauncherPreBuild.cmd:
2853
2854 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2855
2856         Reviewed by Ariya Hidayat.
2857
2858         [Qt] TestNetscapePlugin doesn't link on OS X
2859         https://bugs.webkit.org/show_bug.cgi?id=51948
2860
2861         Only add a dependency on libX11 on X11 systems
2862
2863         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2864
2865 2011-01-05  Jeff Miller  <jeffm@apple.com>
2866
2867         Reviewed by Adam Roben.
2868
2869         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2870         https://bugs.webkit.org/show_bug.cgi?id=51970
2871
2872         * Scripts/webkitpy/style/checker.py:
2873         Add -readability/naming for WebKit2 C API directories.
2874
2875 2011-01-05  Eric Seidel  <eric@webkit.org>
2876
2877         Unreviewed, just fixing one more log error from my previous python patch.
2878
2879         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2880         https://bugs.webkit.org/show_bug.cgi?id=51802
2881
2882         webkit-patch failure-reason was logging about parsing errors
2883         due to my misunderstanding of how BeautifulSoup.findAll worked.
2884
2885         Fixed, and added a unit test.
2886
2887         * Scripts/webkitpy/common/net/layouttestresults.py:
2888         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2889
2890 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2891
2892         Reviewed by Kenneth Rohde Christiansen.
2893
2894         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2895         https://bugs.webkit.org/show_bug.cgi?id=51951
2896
2897         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2898         to create new window from WebKit.
2899
2900         * MiniBrowser/qt/BrowserWindow.cpp:
2901         (newPageFunction):
2902         (BrowserWindow::BrowserWindow):
2903         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2904         (BrowserWindow::newWindow):
2905         (BrowserWindow::updateUserAgentList):
2906         (BrowserWindow::showUserAgentDialog):
2907         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2908         define the type of the backing store used for new windows.
2909         * MiniBrowser/qt/main.cpp:
2910         (main):
2911
2912 2011-01-05  Eric Seidel  <eric@webkit.org>
2913
2914         Reviewed by Ojan Vafai.
2915
2916         commit-queue should report failure type when reporting flaky tests
2917         https://bugs.webkit.org/show_bug.cgi?id=51900
2918
2919         This patch was a ridiculous amount of plumbing.  In the end I like
2920         the NRWT-style TestResult class even less.  But now we're passing
2921         a list of TestResult objects from the queue to the FlakyTestReporter.
2922         Thus the FlakyTestReporter can more easily report what type of failure
2923         occurred.
2924
2925         In the process, I found that I was not alone in finding TestResult
2926         cumbersome to use.  A bunch of code was trying to create a TestResult
2927         object with default values.  However since the constructor didn't make
2928         this easy, some places were getting it wrong (including the TestResult unit test)!
2929         I've fixed the TestResult constructor to have default values for non-essential
2930         arguments.
2931
2932         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2933         * Scripts/webkitpy/common/net/layouttestresults.py:
2934         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2935         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2936         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2937         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2938         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2939         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2940         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2941         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2942         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2943         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2944         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2945         * Scripts/webkitpy/tool/commands/queues.py:
2946         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2947
2948 2011-01-05  Eric Seidel  <eric@webkit.org>
2949
2950         Unreviewed.
2951
2952         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2953         https://bugs.webkit.org/show_bug.cgi?id=51802
2954
2955         Add another unit test to cover a previously missing import.
2956
2957         * Scripts/webkitpy/common/net/layouttestresults.py:
2958         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2959
2960 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2961
2962         Reviewed by David Levin.
2963
2964         Add mihaip@chromium.org as a reviewer
2965         https://bugs.webkit.org/show_bug.cgi?id=51966
2966         
2967         Add myself as a reviewer.
2968
2969         * Scripts/webkitpy/common/config/committers.py:
2970
2971 2011-01-05  James Simonsen  <simonjam@chromium.org>
2972
2973         Unreviewed. Adding myself to the list of committers.
2974
2975         * Scripts/webkitpy/common/config/committers.py:
2976
2977 2011-01-05  Eric Seidel  <eric@webkit.org>
2978
2979         Unreviewed.
2980
2981         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2982         https://bugs.webkit.org/show_bug.cgi?id=51802
2983
2984         Fix two exceptions seen on the bots after my original commit.
2985
2986         * Scripts/webkitpy/common/net/layouttestresults.py:
2987         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2988
2989 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2990
2991         Reviewed by Andreas Kling.
2992
2993         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2994         https://bugs.webkit.org/show_bug.cgi?id=51750
2995
2996         * QtTestBrowser/main.cpp:
2997         (LauncherApplication::handleUserOptions):
2998          Local storage settings can be enable form command line arguments for
2999          QtTestBrowser.
3000
3001 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3002
3003         Reviewed by Martin Robinson.
3004
3005         GTK: AX: DRT needs to use correct root object method.
3006         https://bugs.webkit.org/show_bug.cgi?id=51911
3007
3008         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3009         (AccessibilityController::rootElement):
3010
3011 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3012
3013         Rubber-stamped by Csaba Osztrogonác.
3014
3015         Based on idea from Péter Gál.
3016
3017         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3018
3019 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3020
3021         Reviewed by Adam Barth.
3022
3023         sheriff-bot should be able to do multi-revision rollouts
3024         https://bugs.webkit.org/show_bug.cgi?id=51176
3025
3026         * Scripts/webkitpy/tool/bot/irc_command.py:
3027         * Scripts/webkitpy/tool/bot/sheriff.py:
3028         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3029
3030 2011-01-05  Eric Seidel  <eric@webkit.org>
3031
3032         Reviewed by Adam Barth.
3033
3034         queues.webkit.org should have per-bot status pages
3035         https://bugs.webkit.org/show_bug.cgi?id=51906
3036
3037         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3038         statuses from a single queue.  Now that we have many bots servicing
3039         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3040         you care about scroll off the end of the 15-message limit on the main page.
3041
3042         Eventually we should probably rename /queue-status to /queue or /queues,
3043         but that's fodder for another patch.
3044
3045         * QueueStatusServer/handlers/queuestatus.py:
3046         * QueueStatusServer/index.yaml:
3047         * QueueStatusServer/main.py:
3048         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3049          - This probably should use a custom filter instead of hard-coding
3050            the URL scheme here, but I couldn't figure out how to easily
3051            create such a filter.  Most filters work with "strings" so we can't
3052            pass the status object.  We could add a method to the status
3053            object and call that, but that seemed a bit strange too.
3054         * QueueStatusServer/templates/queuestatus.html:
3055
3056 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3057
3058         Unreviewed. Adding myself to the list of committers.
3059
3060         * Scripts/webkitpy/common/config/committers.py:
3061
3062 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3063
3064         Reviewed by David Levin.
3065
3066         check-webkit-style treated some macros with parentheses after #elif as function calls
3067         https://bugs.webkit.org/show_bug.cgi?id=51695
3068
3069         Ingore function call space checking in any preprocessor directives
3070         (things starting with #). Change search() to match() because 
3071         preprocessor directives are supposed to be in the beginning of lines.
3072
3073         * Scripts/webkitpy/style/checkers/cpp.py:
3074         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3075
3076 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3077
3078         Reviewed by Tony Chang.
3079
3080         Change the --multi-load test option to --stress-opt
3081         https://bugs.webkit.org/show_bug.cgi?id=50751
3082
3083         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3084         (runTest):
3085         (main):
3086         * DumpRenderTree/chromium/TestShell.cpp:
3087         (TestShell::TestShell):
3088         * DumpRenderTree/chromium/TestShell.h:
3089         (TestShell::stressOpt):
3090         (TestShell::setStressOpt):
3091         (TestShell::stressDeopt):
3092         (TestShell::setStressDeopt):
3093         (TestShell::javaScriptFlags):
3094         (TestShell::setJavaScriptFlags):
3095         * Scripts/webkitpy/layout_tests/port/chromium.py:
3096         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3097
3098 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3099
3100         Reviewed by Sam Weinig.
3101
3102         WK2: Support Accessibility
3103         https://bugs.webkit.org/show_bug.cgi?id=51859
3104
3105         Use rootObject() method to get top of accessibility tree.
3106
3107         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3108         (AccessibilityController::focusedElement):
3109         (AccessibilityController::rootElement):
3110
3111 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3112
3113         Reviewed by Darin Adler.
3114
3115         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3116         https://bugs.webkit.org/show_bug.cgi?id=51846
3117
3118         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3119         back to GRefPtr.
3120
3121 2011-01-04  Zhe Su  <suzhe@chromium.org>
3122
3123         Reviewed by Kenneth Russell.
3124
3125         Fix insertText, setMarkedText and unmarkText methods of
3126         TextInputController to call corresponding methods of WebKit::WebView
3127         rather than WebKit::WebFrame. This change matches the behavior of
3128         chromium browser.
3129         insertText corresponds to WebView::confirmComposition(text)
3130         setMarkedText corresponds to WebView::setComposition(...)
3131         unmarkText corresponds to WebView::confirmComposition()
3132         https://bugs.webkit.org/show_bug.cgi?id=51693
3133
3134         * DumpRenderTree/chromium/TextInputController.cpp:
3135         (TextInputController::insertText):
3136         (TextInputController::setMarkedText):
3137         (TextInputController::unmarkText):
3138
3139 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3140
3141         Reviewed by Laszlo Gombos.
3142
3143         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3144
3145         On Symbian productDir points to the source directory. Removing all the
3146         empty files from the productDir directory corrupts the svn repository.
3147
3148         * Scripts/build-webkit:
3149
3150 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3151
3152         Reviewed by Adam Barth.
3153
3154         [Qt] Add SelectAll option to the context menu for the editor
3155         https://bugs.webkit.org/show_bug.cgi?id=50049
3156
3157         Set shortcut for the SelectAll action.
3158
3159         * QtTestBrowser/mainwindow.cpp:
3160         (MainWindow::buildUI):
3161
3162 2011-01-03  David Levin  <levin@chromium.org>
3163
3164         Reviewed by Eric Seidel.
3165
3166         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3167         https://bugs.webkit.org/show_bug.cgi?id=51842
3168
3169         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3170         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3171
3172 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3173
3174         Reviewed by David Kilzer.
3175
3176         [WINCE] Adds a build slave.
3177         https://bugs.webkit.org/show_bug.cgi?id=50523
3178
3179         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3180         entry for a release build of the WinCE port.
3181         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3182         flag to build the WinCE port.
3183
3184 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3185
3186         Reviewed by David Kilzer.
3187
3188         Add WinCE support to build-webkit
3189         https://bugs.webkit.org/show_bug.cgi?id=51642
3190
3191         * Scripts/build-webkit:
3192         * Scripts/webkitdirs.pm:
3193
3194 2011-01-03  Eric Seidel  <eric@webkit.org>
3195
3196         Reviewed by Adam Barth.
3197
3198         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3199         https://bugs.webkit.org/show_bug.cgi?id=51802
3200
3201         I'm not the biggest fan of the test_failures or test_results classes,
3202         but it's better to have one shared set of classes, than separate ones
3203         for new vs. old run-webkit-test result handling.
3204
3205         This moves the ORWT results class "LayoutTestResults" over to using
3206         TestResult and TestFailure classes, making it easy for us to
3207         make all our sheriff-bot and other webkitpy code NRWT ready.
3208
3209         This also makes it a trivial patch to generate results.json information
3210         from ORWT results.html files (for flaky test analysis, etc.) as well
3211         as making it a one-liner to report test failure types when the
3212         commit-queue sees flaky tests.
3213
3214         This patch tried not to add new functionality, but only to replace
3215         the guts of LayoutTestResults, while adding unit tests and hoping
3216         not to break anything.
3217
3218         I also moved callers which assumed User.prompt* were static/class methods
3219         to using them as instance methods (since we'll eventually want to make them such).
3220
3221         In the process of re-writing things, I broke the rebaseline command, so I wrote
3222         a unit test to catch my breakage were I do do so again in the future.
3223
3224         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3225         * Scripts/webkitpy/common/net/layouttestresults.py:
3226         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3227         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3228         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3229         * Scripts/webkitpy/tool/commands/queries.py:
3230         * Scripts/webkitpy/tool/commands/rebaseline.py:
3231         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3232         * Scripts/webkitpy/tool/mocktool.py:
3233
3234 2011-01-03  Adam Barth  <abarth@webkit.org>
3235
3236         Reviewed by Simon Fraser.
3237
3238         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3239         https://bugs.webkit.org/show_bug.cgi?id=51840
3240
3241         * Scripts/webkitpy/common/checkout/scm.py:
3242
3243 2011-01-03  Adam Barth  <abarth@webkit.org>
3244
3245         Reviewed by Simon Fraser.
3246
3247         webkit-patch should only hide update output if --quiet
3248         https://bugs.webkit.org/show_bug.cgi?id=51838
3249
3250         As requested by smfr.
3251
3252         * Scripts/webkitpy/tool/steps/update.py:
3253
3254 2011-01-03  Adam Barth  <abarth@webkit.org>
3255
3256         Reviewed by David Levin.
3257
3258         commit-queue shouldn't reject patches twice if two bots process the same patch
3259         https://bugs.webkit.org/show_bug.cgi?id=51805
3260
3261         Before raising an error, we first check whether the patch is still in
3262         the commit-queue.  This check is still racy, of course, but the time
3263         window is much smaller.
3264
3265         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3266
3267 2011-01-03  Sam Weinig  <sam@webkit.org>
3268
3269         Reviewed by Anders Carlsson.
3270
3271         Make run-api-tests less chatty.
3272         https://bugs.webkit.org/show_bug.cgi?id=51831
3273
3274         - Make script quiet by default and add --verbose option (replacing --quiet).
3275         - When not verbose, pipe stdout and stderr to devnull.
3276
3277         * Scripts/run-api-tests:
3278
3279 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3280
3281         Unreviewed. Adding myself to committers.py.
3282
3283         * Scripts/webkitpy/common/config/committers.py:
3284
3285 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3286
3287         Reviewed by Xan Lopez.
3288
3289         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3290         https://bugs.webkit.org/show_bug.cgi?id=51806
3291
3292         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3293         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3294         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3295         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3296         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3297         so make it 'WebKitBuild/Release/.libs'
3298
3299         * Scripts/webkitdirs.pm: 
3300
3301 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         Make EFL a core builder
3306         https://bugs.webkit.org/show_bug.cgi?id=51804
3307
3308         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3309         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3310
3311 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3312
3313         [Qt] Unreviewed fix after r74855 and r74875.
3314
3315         * BuildSlaveSupport/built-product-archive:
3316          - Create directories explicitly.
3317          - Pass shell=True to subprocess.call().
3318
3319 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3320
3321         [Qt] Unreviewed fix after r74855.
3322
3323         Move JavaScriptCore to Source
3324         https://bugs.webkit.org/show_bug.cgi?id=51604
3325
3326         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3327
3328 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3329
3330         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3331
3332         Move JavaScriptCore to Source
3333         https://bugs.webkit.org/show_bug.cgi?id=51604
3334
3335         * Scripts/webkitdirs.pm:
3336
3337 2011-01-02  Robert Hogan  <robert@webkit.org>
3338
3339         Unreviewed, build fix.
3340
3341         [Qt] Fix DRT build after 74855
3342
3343         * DumpRenderTree/qt/DumpRenderTree.pro:
3344
3345 2011-01-01  Adam Barth  <abarth@webkit.org>
3346
3347         Remove the assumption from the Qt and Gtk builds that every project is
3348         in the root directory.
3349
3350         * Scripts/build-webkit:
3351
3352 2011-01-01  Adam Barth  <abarth@webkit.org>
3353
3354         Reviewed by Eric Seidel.
3355
3356         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3357         https://bugs.webkit.org/show_bug.cgi?id=51796
3358
3359         After this change, svn-apply will magically apply patches to
3360         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3361
3362         * Scripts/VCSUtils.pm:
3363
3364 2011-01-01  Adam Barth  <abarth@webkit.org>
3365
3366         Reviewed by Eric Seidel.
3367
3368         Move JavaScriptCore to Source
3369         https://bugs.webkit.org/show_bug.cgi?id=51604
3370
3371         Update references to JavaScriptCore to point to the new location.
3372
3373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3374         * DumpRenderTree/qt/DumpRenderTree.pro:
3375         * DumpRenderTree/qt/ImageDiff.pro:
3376         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3377         * DumpRenderTree/wscript:
3378         * Scripts/build-jsc:
3379         * Scripts/build-webkit:
3380         * Scripts/do-file-rename:
3381         * Scripts/do-webcore-rename:
3382         * Scripts/run-javascriptcore-tests:
3383         * Scripts/update-javascriptcore-test-results:
3384         * Scripts/webkitdirs.pm:
3385         * Scripts/webkitpy/common/config/build_unittest.py:
3386         * Scripts/webkitpy/style/checker.py:
3387         * Scripts/webkitpy/style/checker_unittest.py:
3388         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3389         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3390         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3391         * wx/build/settings.py:
3392
3393 2011-01-01  Adam Barth  <abarth@webkit.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         Move Sources to Source
3398         https://bugs.webkit.org/show_bug.cgi?id=51794
3399
3400         Update scripts to point to the new location.
3401
3402         * Scripts/build-webkit:
3403         * Scripts/do-file-rename:
3404         * Scripts/do-webcore-rename:
3405         * Scripts/webkitpy/common/config/build.py:
3406         * Scripts/webkitpy/common/config/build_unittest.py:
3407
3408 2010-12-31  Kent Tamura  <tkent@chromium.org>
3409
3410         Reviewed by Eric Seidel.
3411
3412         [DRT/Chromium] Enable mock spell checker on non-OSX
3413         https://bugs.webkit.org/show_bug.cgi?id=51401
3414
3415         * DumpRenderTree/chromium/WebViewHost.cpp:
3416         (WebViewHost::spellCheck):
3417
3418 2010-12-31  Adam Barth  <abarth@webkit.org>
3419
3420         Reviewed by Ariya Hidayat.
3421
3422         Remove Tools/Scripts/wkstyle
3423         https://bugs.webkit.org/show_bug.cgi?id=51774
3424
3425         This script appears to not have been touched in a while and seems to
3426         have been replaced by check-webkit-style.
3427
3428         * Scripts/wkstyle: Removed.
3429
3430 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3431
3432         Unreviewed. Coding style fix.
3433
3434         * DumpRenderTree/chromium/TestShell.h:
3435
3436 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3437
3438         Reviewed by Pavel Feldman.
3439
3440         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3441
3442         It was a problem with Chromium DRT. DevToolsAgent object instance was
3443         attached not only to the inspected page but to the DevTools window too.
3444         As result all the inspector files were interpreted as a content of inspected page
3445         and were transfered to the DevTools scripts panel for debugging etc.
3446
3447         https://bugs.webkit.org/show_bug.cgi?id=51735
3448
3449         * DumpRenderTree/chromium/TestShell.cpp:
3450         (TestShell::TestShell):
3451         (TestShell::bindJSObjectsToWindow):
3452         (TestShell::createNewWindow):
3453         * DumpRenderTree/chromium/TestShell.h:
3454
3455 2010-12-31  Adam Barth  <abarth@webkit.org>
3456
3457         Rubber-stamped by Eric Seidel.
3458
3459         Move PageLoadTests to PerformanceTests/PageLoad
3460         https://bugs.webkit.org/show_bug.cgi?id=51771
3461
3462         Update references to PageLoadTests to point to the new location.
3463
3464         * Scripts/run-pageloadtest:
3465         * Scripts/webkitpy/common/config/build.py:
3466
3467 2010-12-31  Adam Barth  <abarth@webkit.org>
3468
3469         Rubber-stamped by Eric Seidel.
3470
3471         Move SunSpider into PerformanceTests
3472         https://bugs.webkit.org/show_bug.cgi?id=51769
3473
3474         Update these scripts to point to the new location.
3475
3476         * Scripts/run-sunspider:
3477         * Scripts/sunspider-compare-results:
3478
3479 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3480
3481         Reviewed by Kent Tamura.
3482
3483         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3484         https://bugs.webkit.org/show_bug.cgi?id=51728
3485         
3486         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3487         to render top-level scrollbars. This makes them match the Mac port's
3488         use of an NSScrollView, which means that we'll be able to share more
3489         pixel baselines.
3490         
3491         The new rendering code will not be activated until the 
3492         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3493         ScrollbarThemeChromiumMac.
3494
3495         * DumpRenderTree/DumpRenderTree.gypi:
3496         * DumpRenderTree/chromium/TestShellMac.mm:
3497         (platformInit):
3498         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3499         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3500         (+[FakeActiveWindow alwaysActiveWindow]):
3501         (+[FakeActiveWindow alwaysInactiveWindow]):
3502         (-[FakeActiveWindow initWithActiveControls:]):
3503         (-[FakeActiveWindow _hasActiveControls]):
3504         (WebThemeEngineDRTMac::paintScrollbarThumb):
3505         (stateToHIEnableState):
3506         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3507         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3508
3509 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3510
3511         Reviewed by David Kilzer.
3512
3513         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3514         used
3515         https://bugs.webkit.org/show_bug.cgi?id=51672
3516
3517         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3518         with USE_SYSTEM_MALLOC=1
3519         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3520         with USE_SYSTEM_MALLOC=1
3521
3522 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3523
3524         Reviewed by David Kilzer.
3525
3526         [Qt] [Symbian] Fix build-webkit script for Symbian
3527         https://bugs.webkit.org/show_bug.cgi?id=51509
3528
3529         Set the OUTPUT_DIR for Symbian to be the same as the source
3530         directory.
3531
3532         * Scripts/webkitdirs.pm:
3533
3534 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3535
3536         Reviewed by Darin Adler.
3537
3538         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3539         https://bugs.webkit.org/show_bug.cgi?id=51758
3540
3541         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3542
3543         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3544         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3545
3546 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3547
3548         Unreviewed WinCE buildfix.
3549
3550         * WinCELauncher/main.cpp: Add missing include.
3551
3552 2010-12-29  Daniel Bates  <dbates@rim.com>
3553
3554         Reviewed by Darin Adler.
3555
3556         svn-apply updates date of wrong change log entry for a change log diff that
3557         contains two consecutive entries with the same author and date
3558         https://bugs.webkit.org/show_bug.cgi?id=46061
3559
3560         Fixes an issue where the date of the wrong change log entry may be modified.
3561         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3562         in a ChangeLog file to the top of the file.
3563
3564         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3565         diff when it detects that the diff inserts a change log entry earlier in a
3566         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3567         change. With the advent of the commit-queue this functionality of bailing out
3568         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3569         Instead, we should always move the change log entry to the top of the ChangeLog file.
3570
3571         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3572         the date line of the correct change log entry in a ChangeLog diff.
3573
3574         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3575
3576         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3577           Updated the following unit tests now that we move entries inserted earlier to the top:
3578           - "fixChangeLogPatch: New entry inserted in middle."
3579             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3580
3581           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3582             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3583
3584         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3585
3586 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3587
3588         Reviewed by Eric Seidel.
3589
3590         [Qt] Fixed compatibility with gold linker on X11 platforms
3591         https://bugs.webkit.org/show_bug.cgi?id=51700
3592
3593         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3594         Linked TestNetscapePlugin with libX11 on Unix platforms
3595
3596 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3597
3598         Reviewed by Darin Adler.
3599
3600         Circular dependency in webkitpy.common.checkout.changelog module
3601         https://bugs.webkit.org/show_bug.cgi?id=50475
3602
3603         Remove automatic import of api.Checkout module when any checkout/
3604         submodule is imported (e.g.: when checkout.scm.Git is imported).
3605
3606         * Scripts/webkitpy/common/checkout/__init__.py:
3607
3608 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3609
3610         Reviewed by Ojan Vafai.
3611
3612         prepare-ChangeLog should support the -g option for specifying the git-commit
3613         https://bugs.webkit.org/show_bug.cgi?id=51708
3614
3615         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3616         webkit-patch, though the exact meaning of the two options remain different.
3617
3618         * Scripts/prepare-ChangeLog: Add -g.
3619
3620 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3621
3622         Reviewed by Simon Hausmann.
3623
3624         [Qt] Fix compilation with Qt in namespace
3625         https://bugs.webkit.org/show_bug.cgi?id=51701
3626
3627         * QtTestBrowser/webview.h:
3628
3629 2010-12-28  Daniel Bates  <dbates@rim.com>
3630
3631         Reviewed by Sam Weinig.
3632
3633         Substitute // MARK: for compiler-specific #pragma mark
3634         https://bugs.webkit.org/show_bug.cgi?id=51657
3635
3636         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3637         substituting  "// MARK:" for "#pragma mark", which provides
3638         analogous code-bookmarking functionality under Xcode.
3639
3640         Also, for consistency, we should substitute "// MARK:" for compiler-
3641         specific "#pragma mark" in the source files for the Mac port.
3642
3643         * DumpRenderTree/AccessibilityTextMarker.cpp:
3644         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3645         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3646         * DumpRenderTree/mac/ObjCController.m:
3647         * MiniBrowser/mac/AppDelegate.m:
3648         * MiniBrowser/mac/BrowserWindowController.m:
3649
3650 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3651
3652         Reviewed by Eric Seidel.
3653
3654         Add --no-build option to run-sunspider
3655         https://bugs.webkit.org/show_bug.cgi?id=51658
3656
3657         * Scripts/run-sunspider: add --no-build flag to skip building
3658         phase.
3659
3660 2010-12-27  Daniel Bates  <dbates@rim.com>
3661
3662         Rubber-stamped by Martin Robinson.
3663
3664         Append the directory Tools/DumpRenderTree to the list of directories that
3665         do-webcore-rename should search so that it can rename DRT files and
3666         source code.
3667
3668         * Scripts/do-webcore-rename:
3669
3670 2010-12-27  Eric Seidel  <eric@webkit.org>
3671
3672         Reviewed by Adam Barth.
3673
3674         build-webkit should detect missing Java SDK and explain how to install it
3675         https://bugs.webkit.org/show_bug.cgi?id=51651
3676
3677         * Scripts/build-webkit:
3678
3679 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3680
3681         Reviewed by Daniel Bates.
3682
3683         [GTK] Add support for build-jsc
3684         https://bugs.webkit.org/show_bug.cgi?id=51625
3685
3686         Add GTK+ support to build-jsc now that building the jsc executable as
3687         a standalone target is easy.
3688
3689         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3690         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3691         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3692         and pass it along to buildAutotoolsProject.
3693
3694 2010-12-27  David Levin  <levin@chromium.org>
3695
3696         Reviewed by Eric Seidel.
3697
3698         check-webkit-style check for meaningless variable names in function declarations.
3699         https://bugs.webkit.org/show_bug.cgi?id=51523
3700
3701         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3702         from the new check and whitespace/parens because the syntax is unusual and
3703         produced a fair number of positives for these checks.
3704         * Scripts/webkitpy/style/checkers/cpp.py:
3705         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3706         and parameter names when determining if the parameter name is useless.
3707         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3708         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3709         format.
3710         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3711         text or an acronym of it.
3712  &n