REGRESSION (r257739): two fast/events/autoscroll test have started to fail
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2
3         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
4         https://bugs.webkit.org/show_bug.cgi?id=208520
5         <rdar://problem/60000214>
6
7         Reviewed by Chris Fleizach.
8
9         Calling InjectedBundle::singleton().page()->page() in the constructor
10         of the AccessibilityController is having this side effect on iOS.
11         So #if to MAC where it's actually being used.
12
13         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
14         (WTR::AccessibilityController::AccessibilityController):
15
16 2020-03-03  Alex Christensen  <achristensen@webkit.org>
17
18         Add SPI _WKResourceLoadInfo.loadedFromCache
19         https://bugs.webkit.org/show_bug.cgi?id=208554
20
21         Reviewed by Wenson Hsieh.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
24         (TEST):
25
26 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
27
28         Batch observations and completions of text manipulations
29         https://bugs.webkit.org/show_bug.cgi?id=208406
30
31         Reviewed by Wenson Hsieh.
32
33         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
34         multiple paragraphs at once.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
37         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
38         (-[TextManipulationDelegate items]):
39         (-[LegacyTextManipulationDelegate init]):
40         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
41         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
42         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
43         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
44         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
45         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
46         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
47
48 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
49
50         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
51         https://bugs.webkit.org/show_bug.cgi?id=208415
52
53         Reviewed by Brent Fulgham.
54
55         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
56         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
57         (TEST):
58
59 2020-03-03  Alex Christensen  <achristensen@webkit.org>
60
61         Add response to _WKResourceLoadDelegate didCompleteWithError callback
62         https://bugs.webkit.org/show_bug.cgi?id=208553
63
64         Reviewed by Simon Fraser.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
67         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
68         (TEST):
69         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
70
71 2020-03-03  Brady Eidson  <beidson@apple.com>
72
73         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
74         https://bugs.webkit.org/show_bug.cgi?id=198795
75
76         Reviewed by Chris Dumez.
77
78         This test appears to no longer be flaky.
79         
80         Let's re-enable it.
81         
82         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
83         (TestWebKitAPI::TEST):
84
85 2020-03-03  Alex Christensen  <achristensen@webkit.org>
86
87         Requests sent to _WKResourceLoadDelegate should include HTTPBody
88         https://bugs.webkit.org/show_bug.cgi?id=208550
89
90         Reviewed by Tim Hatcher.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
93         (TEST):
94         * TestWebKitAPI/cocoa/HTTPServer.mm:
95         (TestWebKitAPI::HTTPServer::respondToRequests):
96         HTTPServer now looks for Content-Length in its request.
97         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
98
99 2020-03-03  Alex Christensen  <achristensen@webkit.org>
100
101         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
102         https://bugs.webkit.org/show_bug.cgi?id=208522
103
104         Reviewed by Brian Weinstein.
105
106         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
107         (TEST):
108
109 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
110
111         commit-queue should update working directory and reapply patch just before commiting
112         https://bugs.webkit.org/show_bug.cgi?id=208521
113
114         Reviewed by Jonathan Bedard.
115
116         * BuildSlaveSupport/ews-build/factories.py:
117
118 2020-03-03  Matt Lewis  <jlewis3@apple.com>
119
120         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
121         https://bugs.webkit.org/show_bug.cgi?id=208485
122
123         Reviewed by Jonathan Bedard.
124
125         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
126         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
127         that we don't have to recreate the variables that are already created.
128         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
129         from each module, rather than making extra imports that we don't need.
130         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
131         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
132         and not part of the host.
133         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
134         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
135         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
136         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
137         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
138         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
139         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
140         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
141         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
142         if we were geting any value at all
143         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
144         sure we aren't gabking the wrong key:value pair
145         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
146         come with the MockHosts and MockHost inherits from MockSystemHost.
147         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
148         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
149         to the various upload steps.
150
151 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews] Add build step to find list of modified changelogs
154         https://bugs.webkit.org/show_bug.cgi?id=208514
155
156         Reviewed by Jonathan Bedard.
157
158         * BuildSlaveSupport/ews-build/factories.py:
159         * BuildSlaveSupport/ews-build/steps.py:
160         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
161         (FindModifiedChangeLogs.start): Initialize log observer.
162         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
163         (FindModifiedChangeLogs.evaluateCommand):
164         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
165         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
166         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
167         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
168
169 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
170
171         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
172         https://bugs.webkit.org/show_bug.cgi?id=208451
173
174         Unreviewed test gardening.
175
176         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
177
178 2020-03-03  Jiten Mehta  <jmehta@apple.com>
179
180         Adopt HTTP Alternative Services Storage
181         https://bugs.webkit.org/show_bug.cgi?id=208387
182
183         Reviewed by Alex Christensen.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
186         (checkUntilEntryFound):
187         (TEST):
188
189 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
190
191         Check for navigation to app-bound domain during script evaluation
192         https://bugs.webkit.org/show_bug.cgi?id=208319
193         <rdar://problem/57569321>
194
195         Reviewed by Brent Fulgham.
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
199         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
200         (TEST):
201         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
202         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
203
204 2020-03-03  Commit Queue  <commit-queue@webkit.org>
205
206         Unreviewed, rolling out r257754.
207         https://bugs.webkit.org/show_bug.cgi?id=208513
208
209         Introduced API test failure (Requested by perarne on #webkit).
210
211         Reverted changeset:
212
213         "[Cocoa] Mapping from MIME type to UTI type should be done in
214         the UI process"
215         https://bugs.webkit.org/show_bug.cgi?id=208415
216         https://trac.webkit.org/changeset/257754
217
218 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
219
220         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
221         https://bugs.webkit.org/show_bug.cgi?id=208506
222
223         Reviewed by Carlos Garcia Campos.
224
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
227
228 2020-03-02  Ben Nham  <nham@apple.com>
229
230         Add performance probes for HTML parsing
231         https://bugs.webkit.org/show_bug.cgi?id=208271
232
233         Reviewed by Daniel Bates.
234
235         This adds probes that show which lines of HTML are have been parsed.
236
237         * Tracing/SystemTracePoints.plist:
238
239 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
240
241         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
242         https://bugs.webkit.org/show_bug.cgi?id=208415
243
244         Reviewed by Brent Fulgham.
245
246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
247         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
248         (TEST):
249
250 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
251
252         Unreviewed, rolling out r257725.
253
254         This commit caused 10 API tests to fail
255
256         Reverted changeset:
257
258         "[Cocoa] Mapping from MIME type to UTI type should be done in
259         the UI process"
260         https://bugs.webkit.org/show_bug.cgi?id=208415
261         https://trac.webkit.org/changeset/257725
262
263 2020-03-02  Saam Barati  <sbarati@apple.com>
264
265         Don't skip tests unnecessarily on arm64
266         https://bugs.webkit.org/show_bug.cgi?id=208470
267         <rdar://problem/59968869>
268
269         Reviewed by Tadeu Zagallo.
270
271         * Scripts/run-jsc-stress-tests:
272
273 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
274
275         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
276         https://bugs.webkit.org/show_bug.cgi?id=208434
277
278         Reviewed by Chris Fleizach.
279
280         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
281         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
282         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
283         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
284         (WTR::AccessibilityController::accessibleElementById): Same as above.
285
286 2020-03-02  John Wilander  <wilander@apple.com>
287
288         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
289         https://bugs.webkit.org/show_bug.cgi?id=208399
290         <rdar://problem/24731650>
291
292         Reviewed by Brent Fulgham.
293
294         The majority of the changes in WTR::TestController is (partially) fixing a bug
295         where the TestRunner would statically use the default website datastore instead
296         of the website data store configure for the page. This worked for persistent
297         storage testing but not for ephemeral sessions which is what this patch is all
298         about. The previous TestController::websiteDataStore() is now called
299         TestController::defaultWebsiteDataStore() and the new
300         TestController::websiteDataStore() returns the configured website data store.
301         Most of the use of the default website data store should probably change but
302         that's not really for this patch to deal with. I did however move all of
303         resource load statistics' use to the new TestController::websiteDataStore().
304
305         A new TestRunner function was added: isStatisticsEphemeral()
306         It allows test cases to query the ephemeral status of resource load statistics.
307
308         One problem that is mitigated in this patch but not fully fixed is that for
309         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
310         TestController::generatePageConfiguration() via C API 
311         WKPageConfigurationSetWebsiteDataStore(), and then again in 
312         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
313         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
314         I tried removing the latter since one session for all platforms should be
315         Enough but got broken behavior as a result. So now both are still there
316         and both enable resource load statistics.
317
318         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
320         (WTR::TestRunner::isStatisticsEphemeral):
321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
322         * WebKitTestRunner/TestController.cpp:
323         (WTR::TestController::defaultWebsiteDataStore):
324         (WTR::TestController::websiteDataStore):
325         (WTR::TestController::generatePageConfiguration):
326         (WTR::TestController::resetPreferencesToConsistentValues):
327         (WTR::TestController::resetStateToConsistentValues):
328         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
329         (WTR::TestController::decidePolicyForNavigationAction):
330         (WTR::TestController::platformAdjustContext):
331         (WTR::TestController::clearServiceWorkerRegistrations):
332         (WTR::TestController::clearDOMCache):
333         (WTR::TestController::clearDOMCaches):
334         (WTR::TestController::clearIndexedDatabases):
335         (WTR::TestController::clearLocalStorage):
336         (WTR::TestController::hasDOMCache):
337         (WTR::TestController::domCacheSize):
338         (WTR::TestController::setStatisticsEnabled):
339         (WTR::TestController::isStatisticsEphemeral):
340         (WTR::TestController::setStatisticsDebugMode):
341         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
342         (WTR::TestController::setStatisticsLastSeen):
343         (WTR::TestController::setStatisticsMergeStatistic):
344         (WTR::TestController::setStatisticsPrevalentResource):
345         (WTR::TestController::setStatisticsVeryPrevalentResource):
346         (WTR::TestController::dumpResourceLoadStatistics):
347         (WTR::TestController::isStatisticsPrevalentResource):
348         (WTR::TestController::isStatisticsVeryPrevalentResource):
349         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
350         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
351         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
352         (WTR::TestController::setStatisticsHasHadUserInteraction):
353         (WTR::TestController::isStatisticsHasHadUserInteraction):
354         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
355         (WTR::TestController::setStatisticsGrandfathered):
356         (WTR::TestController::isStatisticsGrandfathered):
357         (WTR::TestController::setUseITPDatabase):
358         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
359         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
360         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
361         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
362         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
363         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
364         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
365         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
366         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
367         (WTR::TestController::statisticsUpdateCookieBlocking):
368         (WTR::TestController::statisticsSubmitTelemetry):
369         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
370         (WTR::TestController::setStatisticsIsRunningTest):
371         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
372         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
373         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
374         (WTR::TestController::setStatisticsGrandfatheringTime):
375         (WTR::TestController::setStatisticsMaxStatisticsEntries):
376         (WTR::TestController::setStatisticsPruneEntriesDownTo):
377         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
378         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
379         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
380         (WTR::TestController::statisticsDeleteCookiesForHost):
381         (WTR::TestController::isStatisticsHasLocalStorage):
382         (WTR::TestController::setStatisticsCacheMaxAgeCap):
383         (WTR::TestController::hasStatisticsIsolatedSession):
384         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
385         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
386         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
387         (WTR::TestController::statisticsResetToConsistentState):
388         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
389         * WebKitTestRunner/TestController.h:
390         * WebKitTestRunner/TestInvocation.cpp:
391         (WTR::TestInvocation::invoke):
392         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
393         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
394         (WTR::initializeWebViewConfiguration):
395         (WTR::TestController::platformCreateWebView):
396
397 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
398
399         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
400         https://bugs.webkit.org/show_bug.cgi?id=208415
401
402         Reviewed by Brent Fulgham.
403
404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
405         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
406         (TEST):
407
408 2020-03-02  Daniel Bates  <dabates@apple.com>
409
410         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
411         https://bugs.webkit.org/show_bug.cgi?id=208352
412         <rdar://problem/59867815>
413
414         Reviewed by Wenson Hsieh.
415
416         Update test results to reflect the new behavior. To do this I also need to fix up the test code
417         to actually scroll the web content. This also means we now execute the same code on both Mac and
418         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
419         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
420         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
423         (TEST):
424
425 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
426
427         Unreviewed, rolling out r257687.
428
429         This commit caused debug tests to crash for macOS & iOS
430
431         Reverted changeset:
432
433         "[Cocoa] Mapping from MIME type to UTI type should be done in
434         the UI process"
435         https://bugs.webkit.org/show_bug.cgi?id=208415
436         https://trac.webkit.org/changeset/257687
437
438 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
439
440         Unreviewed, rolling out r257618.
441
442         This allegedly causes Safari to crash when closing a window
443         (see rdar://problem/59922725).
444
445         Reverted changeset:
446
447         "UIProcess crash after using _prepareForMoveToWindow, then
448         deallocating the WKWebView before moving to the window"
449         https://bugs.webkit.org/show_bug.cgi?id=208365
450         https://trac.webkit.org/changeset/257618
451
452 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
453
454         Remove std::lock_guard
455         https://bugs.webkit.org/show_bug.cgi?id=206451
456
457         Reviewed by Anders Carlsson.
458
459         Add std::lock_guard lint rule to prevent from using it.
460
461         * Scripts/webkitpy/style/checkers/cpp.py:
462         (check_lock_guard):
463         (check_style):
464         (CppChecker):
465         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
466         (WebKitStyleTest.test_lock_guard):
467         * TestWebKitAPI/Tests/WTF/Condition.cpp:
468         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
469         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
470         (assertHasObjects):
471         (assertHasOnlyObjects):
472         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
473         (WTR::AXThread::dispatch):
474         (WTR::AXThread::dispatchFunctionsFromAXThread):
475         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
476         (WTR::AXThread::initializeRunLoop):
477
478 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
479
480         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
481         https://bugs.webkit.org/show_bug.cgi?id=208415
482
483         Reviewed by Brent Fulgham.
484
485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
486         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
487         (TEST):
488
489 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
490
491         Unreviewed, rolling out r257565.
492
493         It broke WinCairo MiniBrowser
494
495         Reverted changeset:
496
497         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
498         https://bugs.webkit.org/show_bug.cgi?id=206894
499         https://trac.webkit.org/changeset/257565
500
501 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
502
503         EWS fails to retry build in case of kill-old-processes exception
504         https://bugs.webkit.org/show_bug.cgi?id=208003
505
506         Reviewed by Jonathan Bedard.
507
508         * BuildSlaveSupport/ews-build/steps.py:
509         (KillOldProcesses.evaluateCommand):
510         (KillOldProcesses.getResultSummary):
511
512 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
513
514         [ews] commit-queue should update the ChangeLog with Reviewer name
515         https://bugs.webkit.org/show_bug.cgi?id=206535
516
517         Reviewed by Jonathan Bedard.
518
519         * BuildSlaveSupport/ews-build/steps.py:
520         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
521
522 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
523
524         run-javascriptcore-tests: Make upload format valid
525         https://bugs.webkit.org/show_bug.cgi?id=208341
526
527         Rubber-stamped by Aakash Jain.
528
529         * Scripts/run-javascriptcore-tests:
530         (uploadResults): Remove. FIXME.
531         * Scripts/webkitdirs.pm:
532         (splitVersionString): Handle case where the subminor version number has a - in it.
533         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
534
535 2020-02-28  youenn fablet  <youenn@apple.com>
536
537         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
538         https://bugs.webkit.org/show_bug.cgi?id=208130
539
540         Reviewed by Eric Carlson.
541
542         * WebKitTestRunner/TestOptions.h:
543         Use GPU process to capture by default.
544         We will remove this option once done verifying that every test works smoothly.
545
546 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
547
548         [ews] commit queue should skip building and testing for rollout patches
549         https://bugs.webkit.org/show_bug.cgi?id=208329
550
551         Reviewed by Jonathan Bedard.
552
553         * BuildSlaveSupport/ews-build/steps.py:
554         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
555         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
556         (RunWebKit1Tests.doStepIf): Ditto.
557         * BuildSlaveSupport/ews-build/steps_unittest.py:
558         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
559         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
560
561 2020-02-28  Daniel Bates  <dabates@apple.com>
562
563         Update my watch list preferences and contributor's entry.
564
565         * Scripts/webkitpy/common/config/contributors.json:
566         * Scripts/webkitpy/common/config/watchlist:
567
568 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
569
570         Fix WebCore export macros for declspec
571         https://bugs.webkit.org/show_bug.cgi?id=208363
572
573         Reviewed by Konstantin Tokarev.
574
575         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
576         files. Removed precompiled headers that were empty.
577
578         * DumpRenderTree/DumpRenderTreePrefix.h:
579         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
580         * MiniBrowser/win/stdafx.h:
581         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
582         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
583         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
584         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
585         * WebKitTestRunner/PlatformFTW.cmake:
586         * WebKitTestRunner/PlatformWin.cmake:
587         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
588
589 2020-02-27  Tim Horton  <timothy_horton@apple.com>
590
591         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
592         https://bugs.webkit.org/show_bug.cgi?id=208365
593
594         Reviewed by Alex Christensen.
595
596         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
597         (TEST):
598         Add a test! It was a 100% repro crash before this change.
599
600 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
601
602         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
603         https://bugs.webkit.org/show_bug.cgi?id=208260
604         <rdar://problem/59820107>
605
606         Reviewed by Tim Horton.
607
608         Followed instructions for adding an Info.plist for Single-File Tools
609         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
610
611         The default WebsiteDataStore file path will change with this test to
612         reflect the new bundleID so we must change expectations for any api
613         tests which rely on knowing the path.
614
615         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
617         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
618         (TEST):
619         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
620         (TEST):
621         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
622         (TEST):
623         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
624         (TEST):
625         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
626         (TEST):
627         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
628         (TEST):
629         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
630         (TEST):
631         (defaultWebsiteCacheDirectory):
632         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
633         (TEST):
634         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
635         (TEST):
636         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
637         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
638         (TEST):
639         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
640         (TEST):
641         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
642         (runWebsiteDataStoreCustomPaths):
643         (TEST):
644         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
645         (TestWebKitAPI::resetTestState):
646         Now that we set a bundleID, we have to reset the cache model between
647         tests, otherwise it gets stored between tests.
648
649         (TestWebKitAPI::TEST):
650         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
651         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
652
653 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
654
655         TextManipulationController should not generate a new item for content in manipulated paragraphs
656         https://bugs.webkit.org/show_bug.cgi?id=208286
657
658         Reviewed by Wenson Hsieh.
659
660         Added a regression test.
661
662         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
663         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
664
665 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
666
667         run-javascriptcore-tests: Make upload format valid
668         https://bugs.webkit.org/show_bug.cgi?id=208341
669
670         Reviewed by Aakash Jain.
671
672         * Scripts/run-javascriptcore-tests:
673         (uploadResults): Print json blob for upload after failure for debugging.
674
675 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
676
677         [CMake] Add WebKit::PAL target
678         https://bugs.webkit.org/show_bug.cgi?id=198493
679
680         Reviewed by Michael Catanzaro.
681
682         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
683
684         * DumpRenderTree/PlatformWin.cmake:
685
686 2020-02-27  Alex Christensen  <achristensen@webkit.org>
687
688         Add SPI to query WKFrameInfos in a WKWebView
689         https://bugs.webkit.org/show_bug.cgi?id=208212
690
691         Reviewed by Brady Eidson.
692
693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
694         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
695         * WebKitTestRunner/TestController.cpp:
696         (WTR::TestController::saltForOrigin):
697
698 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
699
700         Unreviewed, rolling out r257530.
701
702         This commit seems to have broke the build internally for
703         watchOS
704
705         Reverted changeset:
706
707         "Add SPI to query WKFrameInfos in a WKWebView"
708         https://bugs.webkit.org/show_bug.cgi?id=208212
709         https://trac.webkit.org/changeset/257530
710
711 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
712
713         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
714         https://bugs.webkit.org/show_bug.cgi?id=206894
715
716         Reviewed by Adrian Perez de Castro.
717
718         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
719         MiniBrowsers.
720
721         * MiniBrowser/gtk/CMakeLists.txt:
722         * MiniBrowser/win/CMakeLists.txt:
723         * MiniBrowser/wpe/CMakeLists.txt:
724
725 2020-02-26  Alex Christensen  <achristensen@webkit.org>
726
727         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
728         https://bugs.webkit.org/show_bug.cgi?id=206456
729
730         Reviewed by Brady Eidson.
731
732         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
733         (TEST):
734
735 2020-02-26  Alex Christensen  <achristensen@webkit.org>
736
737         _WKUserContentWorld should be a wrapper around WKContentWorld
738         https://bugs.webkit.org/show_bug.cgi?id=208274
739
740         Reviewed by Brady Eidson.
741
742         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
743         (TEST):
744         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
745         (TEST):
746
747 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
748
749         Unreviewed, rolling out r257522.
750
751         Caused 16 API test failures on the bots
752
753         Reverted changeset:
754
755         "TestWebKitAPI and WebKitTestRunner should have bundle
756         identifiers"
757         https://bugs.webkit.org/show_bug.cgi?id=208260
758         https://trac.webkit.org/changeset/257522
759
760 2020-02-26  Alex Christensen  <achristensen@webkit.org>
761
762         Add SPI to query WKFrameInfos in a WKWebView
763         https://bugs.webkit.org/show_bug.cgi?id=208212
764
765         Reviewed by Brady Eidson.
766
767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
768         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
769         * WebKitTestRunner/TestController.cpp:
770         (WTR::TestController::saltForOrigin):
771
772 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
773
774         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
775         https://bugs.webkit.org/show_bug.cgi?id=208260
776         <rdar://problem/59820107>
777
778         Reviewed by Tim Horton.
779
780         Followed instructions for adding an Info.plist for Single-File Tools
781         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
782
783         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
784         * TestWebKitAPI/Info.plist: Added.
785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
787         * WebKitTestRunner/Info.plist: Added.
788         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
789
790 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
791
792         Tests should each use a unique ResourceLoadStatistics file path for its database store
793         https://bugs.webkit.org/show_bug.cgi?id=208206
794         <rdar://problem/59690272>
795
796         Reviewed by Brady Eidson.
797
798         Initialize a default website data store before checking for the ITP
799         store to ensure the directory exists after the file has been deleted.
800
801         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
802         (TEST):
803
804 2020-02-26  Christopher Reid  <chris.reid@sony.com>
805
806         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
807         https://bugs.webkit.org/show_bug.cgi?id=197684
808         <rdar://problem/59467397>
809
810         Reviewed by Yusuke Suzuki.
811
812         Add test for FileSystem::createFile
813
814         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
815
816 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
817
818         [ews] commit-queue should verify patch committer and reviewer
819         https://bugs.webkit.org/show_bug.cgi?id=206532
820
821         Reviewed by Jonathan Bedard.
822
823         * BuildSlaveSupport/ews-build/steps.py:
824         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
825         (ValidateCommiterAndReviewer._addToLog):
826         (ValidateCommiterAndReviewer.getResultSummary):
827         (ValidateCommiterAndReviewer.fail_build):
828         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
829         (ValidateCommiterAndReviewer.is_reviewer):
830         (ValidateCommiterAndReviewer.is_committer):
831         (ValidateCommiterAndReviewer.full_name_from_email):
832         (ValidateCommiterAndReviewer.start):
833
834 2020-02-26  Daniel Bates  <dabates@apple.com>
835
836         [iOS] Send focus update immediately on becoming or resigning first responder
837         https://bugs.webkit.org/show_bug.cgi?id=208082
838         <rdar://problem/59688413>
839
840         Rubber-stamped by Jer Noble.
841
842         Add a test to ensure that selecting a position at a point after the web view
843         becomes first responder is allowed. Such an operation is only allowed if the
844         web view is focused.
845
846         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
847         (-[TestWKWebView selectPositionAtPoint:]):
848         (TEST):
849         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
850
851 2020-02-26  Chris Dumez  <cdumez@apple.com>
852
853         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
854
855         The test was added for macOS and times out on iOS.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
858         (TEST):
859
860 2020-02-26  Youenn Fablet  <youenn@apple.com>
861
862         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
863         https://bugs.webkit.org/show_bug.cgi?id=208238
864
865         Reviewed by Eric Carlson.
866
867         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
868         (TEST):
869         Remove use of deleted parameter.
870
871 2020-02-25  Devin Rousso  <drousso@apple.com>
872
873         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
874         https://bugs.webkit.org/show_bug.cgi?id=206911
875         <rdar://problem/58026635>
876
877         Reviewed by Brian Burg.
878
879         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
880         (TestWebKitAPI::TEST):
881         Add test for `WTF::HashSet::reserveInitialCapacity`.
882
883         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
884         (TestWebKitAPI::TEST):
885         Actually check the value of `WTF::HashMap::capacity`.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
888         (-[InspectorDelegate _webView:didAttachInspector:])
889         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
890         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
891         (TestWebKitAPI::TEST):
892         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
893         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
894         (TestWebKitAPI::TEST): Deleted.
895
896 2020-02-25  Matt Lewis  <jlewis3@apple.com>
897
898         Add checkout_root to stubrepository.py
899         https://bugs.webkit.org/show_bug.cgi?id=208213
900
901         Reviewed by Jonathan Bedard.
902
903         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
904         (StubRepository.__init__):
905
906         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
907         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
908
909 2020-02-25  Daniel Bates  <dabates@apple.com>
910
911         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
912         https://bugs.webkit.org/show_bug.cgi?id=208214
913
914         Reviewed by Wenson Hsieh.
915
916         Wait until the copy operation completes before loading the second web view and testing paste
917         to ensure that something was actually copied to the clipboard.
918
919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
920         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
921         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
922         so that we wait until the command completes.
923
924 2020-02-25  Chris Dumez  <cdumez@apple.com>
925
926         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
927         https://bugs.webkit.org/show_bug.cgi?id=208199
928         <rdar://problem/59746887>
929
930         Reviewed by Alex Christensen.
931
932         Add API test coverage.
933
934         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
935         (TEST):
936
937 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
938
939         spinRunLoop should take a non-zero integer as parameter
940         https://bugs.webkit.org/show_bug.cgi?id=208148
941         <rdar://problem/59766682>
942
943         Unreviewed iOS build fix.
944
945         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
946         (TestWebKitAPI::Util::spinRunLoop):
947
948 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
949
950         spinRunLoop should take a non-zero integer as parameter
951         https://bugs.webkit.org/show_bug.cgi?id=208148
952
953         Reviewed by Darin Adler.
954
955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
956         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
957         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
958         (TestWebKitAPI::Util::spinRunLoop):
959
960 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
961
962         [WTF] Add tests for CompactRefPtrTuple
963         https://bugs.webkit.org/show_bug.cgi?id=208172
964
965         Reviewed by Darin Adler.
966
967         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
968         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
969
970         * TestWebKitAPI/CMakeLists.txt:
971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
972         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
973         (TestWebKitAPI::TEST):
974
975 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews] commit-queue should check that patch have appropriate review flag
978         https://bugs.webkit.org/show_bug.cgi?id=208138
979
980         Reviewed by Jonathan Bedard.
981
982         * BuildSlaveSupport/ews-build/steps.py:
983         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
984         (BugzillaMixin._is_patch_cq_plus):
985         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
986         (ValidatePatch.start):
987
988 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
989
990         [WebAuthn] Implement SPI for the platform authenticator
991         https://bugs.webkit.org/show_bug.cgi?id=208087
992         <rdar://problem/59369305>
993
994         Reviewed by Brent Fulgham.
995
996         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
997
998         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
999         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1002         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1003         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
1004         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
1005         (TestWebKitAPI::TEST):
1006         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
1007         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
1008         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
1009         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
1010
1011 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1012
1013         Unreviewed, updating LLDB test for CompactPointerTuple.
1014         https://bugs.webkit.org/show_bug.cgi?id=207827
1015
1016         * lldb/lldb_webkit.py:
1017         (WTFCompactPointerTupleProvider):
1018         (WTFCompactPointerTupleProvider.update):
1019
1020 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1021
1022         Provide alternate way to name Web Content process
1023         https://bugs.webkit.org/show_bug.cgi?id=205224
1024         rdar://57038084
1025
1026         Reviewed by Alex Christensen.
1027
1028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1029         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1030         (TestWebKitAPI::TEST):
1031
1032 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1033
1034         results.webkit.org: Link to result archives
1035         https://bugs.webkit.org/show_bug.cgi?id=207646
1036         <rdar://problem/59395807>
1037
1038         Rubber-stamped by Aakash Jain.
1039
1040         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1041         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1042         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1043         return the most specific value.
1044         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1045         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1046         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1047         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1048         (parametersForInstance): Extract from lambda function.
1049         (testRunLink): Use parametersForInstance instead of a lambda function.
1050         (archiveLink): Return an archive link for data. 
1051         (contentForData): Add archive link to view.
1052         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1053         (TimelineFromEndpoint): Accept both suite and test.
1054         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1055         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1056         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1057         * resultsdbpy/resultsdbpy/view/view_routes.py:
1058         (ViewRoutes.__init__): Add archive_route dictionary.
1059
1060 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1061
1062         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1063         https://bugs.webkit.org/show_bug.cgi?id=208035
1064         <rdar://problem/58011337>
1065
1066         Reviewed by Tim Hatcher.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1069
1070 2020-02-22  Darin Adler  <darin@apple.com>
1071
1072         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1073         https://bugs.webkit.org/show_bug.cgi?id=208099
1074
1075         Reviewed by Antti Koivisto.
1076
1077         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1078         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1079         so we can use the -[NSString createJSStringRef] method.
1080         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1081         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1082
1083 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1084
1085         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1086         https://bugs.webkit.org/show_bug.cgi?id=208096
1087         <rdar://problem/59632008>
1088
1089         Reviewed by Alexey Proskuryakov.
1090
1091         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1092         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1093         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1094
1095         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1096         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1097         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1098         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1099         in the credit card expiry field.
1100
1101         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1102
1103         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1104         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1105         (WTR::UIScriptController::setDefaultCalendarType):
1106         * WebKitTestRunner/TestController.h:
1107
1108         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1109         identifier and calendar locale identifier.
1110
1111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1112         (WTR::swizzledCalendar):
1113         (WTR::TestController::overriddenCalendarIdentifier const):
1114         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1115
1116         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1117
1118         (WTR::TestController::setDefaultCalendarType):
1119
1120         Plumb the new calendar's locale identifier through this method.
1121
1122         (WTR::TestController::cocoaResetStateToConsistentValues):
1123         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1124         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1125         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1126         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1127
1128 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1129
1130         App-bound domains should have separate Network Sessions
1131         https://bugs.webkit.org/show_bug.cgi?id=208026
1132         <rdar://problem/59434006>
1133
1134         Reviewed by Brent Fulgham.
1135
1136         This patch is mostly test infrastructure involving 3 functions.
1137         One sets in-app browser privacy as enabled in the network process
1138         manually for the test. One ensures that setting the WebView category
1139         works properly, and the last one checks for an app-bound session for
1140         an app-bound navigation.
1141
1142         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1143         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1144         (WTR::InjectedBundle::didReceiveMessageToPage):
1145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1146         (WTR::TestRunner::getWebViewCategory):
1147         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1148         (WTR::TestRunner::hasAppBoundSession):
1149         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1150         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1151         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1152         * WebKitTestRunner/TestController.cpp:
1153         (WTR::TestController::ensureViewSupportsOptionsForTest):
1154         Clearing the bundleID should happen right before setting a new one, 
1155         otherwise it clears the ID after it is set and returns a null ID.
1156
1157         (WTR::TestController::resetStateToConsistentValues):
1158         (WTR::TestController::getWebViewCategory):
1159         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1160         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1161         (WTR::inAppBrowserPrivacyVoidResultCallback):
1162         (WTR::TestController::hasAppBoundSession):
1163         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1164         * WebKitTestRunner/TestController.h:
1165         * WebKitTestRunner/TestInvocation.cpp:
1166         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1167         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1168         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1169         (WTR::TestInvocation::didReceivePrevalentDomains):
1170         (WTR::TestInvocation::didReceiveWebViewCategory):
1171         * WebKitTestRunner/TestInvocation.h:
1172         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1173         (WTR::TestController::getWebViewCategory):
1174
1175 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1176
1177         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1178         https://bugs.webkit.org/show_bug.cgi?id=208068
1179         <rdar://problem/59676596>
1180
1181         Reviewed by Tim Horton.
1182
1183         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1184         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1185         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1186         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1187         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1188         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1189         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1190         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1191         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1192         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1193         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1194         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1195         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1196         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1197
1198 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews] Add build step to Validate ChangeLog for commit-queue
1201         https://bugs.webkit.org/show_bug.cgi?id=208064
1202
1203         Reviewed by Jonathan Bedard.
1204
1205         * BuildSlaveSupport/ews-build/steps.py:
1206         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1207         (ValidateChangeLogAndReviewer.start):
1208         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1209         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1210
1211 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews] Add build step to set cq- flag on bugzilla patch
1214         https://bugs.webkit.org/show_bug.cgi?id=208021
1215
1216         Reviewed by Jonathan Bedard.
1217
1218         * BuildSlaveSupport/ews-build/steps.py:
1219         (BugzillaMixin.set_cq_minus_flag_on_patch):
1220         (SetCommitQueueMinusFlagOnPatch):
1221         (SetCommitQueueMinusFlagOnPatch.start):
1222         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1223
1224 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1225
1226         Stub repositories fail to upload some results due to missing head svn revision
1227         https://bugs.webkit.org/show_bug.cgi?id=207684
1228
1229         Reviewed by Jonathan Bedard.
1230
1231         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1232         (MockHost.__init__):
1233         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1234         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1235         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1236         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
1237         * Scripts/webkitpy/port/base.py:
1238         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
1239         from using mock SCMs and more
1240         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
1241
1242 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
1243
1244         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
1245         https://bugs.webkit.org/show_bug.cgi?id=208051
1246
1247         Reviewed by Carlos Alberto Lopez Perez.
1248
1249         Verbose flag prints out each test name executed. Without this flag
1250         stdout prints out one or two periods.
1251
1252         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1253         (RunJavaScriptCoreTests.start):
1254
1255 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1256
1257         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
1258         https://bugs.webkit.org/show_bug.cgi?id=207984
1259
1260         Reviewed by Daniel Bates.
1261
1262         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1263         (TestWebKitAPI::TEST):
1264
1265 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
1266
1267         [GTK] Improve user agent quirk for Google Docs and Google Drive
1268         https://bugs.webkit.org/show_bug.cgi?id=206506
1269
1270         Reviewed by Carlos Garcia Campos.
1271
1272         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1273         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1274         (TestWebKitAPI::TEST):
1275
1276 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1277
1278         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
1279         https://bugs.webkit.org/show_bug.cgi?id=207380
1280
1281         Reviewed by Jonathan Bedard.
1282
1283         Added a new rule 'build/export_macro'.
1284
1285         Removed a obsolete rule 'readability/webkit_export' which was used
1286         only by Chromium port (r148185).
1287
1288         * Scripts/webkitpy/style/checkers/cpp.py:
1289         (_FunctionState.export_macro):
1290         (check_function_definition):
1291         (_unix_path): Added.
1292         (is_generated_file): Use _unix_path.
1293         (check_has_config_header): Ditto.
1294         (CppChecker):
1295         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1296         (WebKitStyleTest.test_export_macro_check):
1297         (WebKitStyleTest.test_webkit_export_check): Deleted.
1298
1299 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1300
1301         [Win][MiniBrowser] Add prettier toolbar button icons
1302         https://bugs.webkit.org/show_bug.cgi?id=207999
1303
1304         Reviewed by Ross Kirsling.
1305
1306         Use a custom toolbar button icons instead of system stock icons.
1307
1308         Fixed a bug toolbar button dropdown arrows always looked being
1309         hovered. TBSTYLE_FLAT should be given.
1310
1311         Removed the window border line of Progress Indicator.
1312
1313         * MiniBrowser/win/MainWindow.cpp:
1314         (MainWindow::createToolbar):
1315         * MiniBrowser/win/MiniBrowserLib.rc:
1316         * MiniBrowser/win/MiniBrowserLibResource.h:
1317         * MiniBrowser/win/toolbar.bmp: Added.
1318
1319 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
1320
1321         Update run-webkit-tests help description for skip-failing-tests
1322         https://bugs.webkit.org/show_bug.cgi?id=208031
1323
1324         Reviewed by Alexey Proskuryakov.
1325
1326         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1327
1328 2020-02-20  Chris Dumez  <cdumez@apple.com>
1329
1330         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
1331         https://bugs.webkit.org/show_bug.cgi?id=208015
1332         <rdar://problem/59591630>
1333
1334         Reviewed by Geoffrey Garen.
1335
1336         Add API test coverage.
1337
1338         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1339         (TEST):
1340
1341 2020-02-20  Tim Horton  <timothy_horton@apple.com>
1342
1343         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
1344         https://bugs.webkit.org/show_bug.cgi?id=207998
1345         <rdar://problem/40942425>
1346
1347         Reviewed by Sam Weinig.
1348
1349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
1351         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1352         (TestWebKitAPI::TEST):
1353         Add some tests for top content insets.
1354
1355 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
1356
1357         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
1358         https://bugs.webkit.org/show_bug.cgi?id=207910
1359
1360         Unreviewed infrastructure fix.
1361
1362         * Scripts/run-javascriptcore-tests:
1363         (configurationForUpload): Use the major version instead of the sub-minor version
1364         for version name.
1365
1366 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
1367
1368         [CMake] Add WPE::libwpe target
1369         https://bugs.webkit.org/show_bug.cgi?id=207970
1370
1371         Reviewed by Adrian Perez de Castro.
1372
1373         Use the WPE::libwpe target.
1374
1375         * MiniBrowser/wpe/CMakeLists.txt:
1376         * TestWebKitAPI/PlatformWPE.cmake:
1377         * TestWebKitAPI/glib/PlatformWPE.cmake:
1378         * wpe/backends/CMakeLists.txt:
1379
1380 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1381
1382         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
1383         https://bugs.webkit.org/show_bug.cgi?id=207749
1384
1385         Reviewed by Ross Kirsling.
1386
1387         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
1388
1389         * MiniBrowser/win/MainWindow.cpp:
1390         (MainWindow::createToolbar):
1391         (MainWindow::WndProc):
1392         (MainWindow::setDefaultURLToCurrentURL):
1393         (MainWindow::goHome): Added.
1394         (MainWindow::onURLBarEnter):
1395         * MiniBrowser/win/MainWindow.h:
1396         * MiniBrowser/win/MiniBrowserLib.rc:
1397         * MiniBrowser/win/MiniBrowserLibResource.h:
1398         * MiniBrowser/win/MiniBrowserReplace.h:
1399         * MiniBrowser/win/WinMain.cpp:
1400         (wWinMain):
1401
1402 2020-02-19  Peng Liu  <peng.liu6@apple.com>
1403
1404         Fix check-webkit-style errors related to AVFoundationSPI.h
1405         https://bugs.webkit.org/show_bug.cgi?id=207834
1406
1407         Reviewed by Daniel Bates.
1408
1409         Revert the change in r256770 regarding the headers ordering.
1410         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
1411
1412         * Scripts/webkitpy/style/checkers/cpp.py:
1413         (check_include_line):
1414
1415 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
1416
1417         results.webkit.org: Correctly report JSC tests for windows
1418         https://bugs.webkit.org/show_bug.cgi?id=207910
1419
1420         Rubber-stamped by Aakash Jain.
1421
1422         * Scripts/run-javascriptcore-tests:
1423         (configurationForUpload): Give Windows a version name.
1424         * Scripts/webkitdirs.pm:
1425         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
1426         Version dictionary.
1427
1428 2020-02-19  Chris Dumez  <cdumez@apple.com>
1429
1430         Unreviewed, fix assertions in storage access API layout tests after r256882.
1431
1432         Drop dead testRunner code to toggle storage access API feature.
1433
1434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1435         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1436         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
1437         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1438         * WebKitTestRunner/TestInvocation.cpp:
1439         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1440
1441 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
1442
1443         [WPE] Support 2D axis, smooth-motion events
1444         https://bugs.webkit.org/show_bug.cgi?id=207881
1445
1446         Reviewed by Carlos Garcia Campos.
1447
1448         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
1449
1450 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1451
1452         Unreviewed, rolling out r256851.
1453
1454         Broke internal bots
1455
1456         Reverted changeset:
1457
1458         "Stub repositories fail to upload some results due to missing
1459         head svn revision"
1460         https://bugs.webkit.org/show_bug.cgi?id=207684
1461         https://trac.webkit.org/changeset/256851
1462
1463 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1464
1465         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
1466         https://bugs.webkit.org/show_bug.cgi?id=207883
1467
1468         Reviewed by Ross Kirsling.
1469
1470         Unlike other mouse buttons, 4th and 5th mouse buttons are
1471         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
1472         WM_XBUTTONUP events to the window under the mouse cursor.
1473         Unhandled WM_XBUTTONUP events are automatically converted to
1474         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
1475         parent window.
1476         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
1477
1478         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
1479         handled.
1480
1481         * MiniBrowser/win/BrowserWindow.h:
1482         * MiniBrowser/win/MainWindow.cpp:
1483         (MainWindow::WndProc):
1484         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1485         (WebKitBrowserWindow::navigateForwardOrBackward):
1486         * MiniBrowser/win/WebKitBrowserWindow.h:
1487         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1488         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
1489         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1490
1491 2020-02-18  Alex Christensen  <achristensen@webkit.org>
1492
1493         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
1494         https://bugs.webkit.org/show_bug.cgi?id=207912
1495         <rdar://problem/59556922>
1496
1497         Reviewed by Brian Weinstein.
1498
1499         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1500         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1501         (TEST):
1502         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1503         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
1504
1505 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1506
1507         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
1508         https://bugs.webkit.org/show_bug.cgi?id=207899
1509         <rdar://problem/55658207>
1510
1511         Reviewed by Tim Horton and Simon Fraser.
1512
1513         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
1514
1515         * WebKitTestRunner/TestController.cpp:
1516         (WTR::updateTestOptionsFromTestHeader):
1517         * WebKitTestRunner/TestOptions.h:
1518         (WTR::TestOptions::hasSameInitializationOptions const):
1519         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1520         (WTR::TestController::platformCreateWebView):
1521
1522 2020-02-18  Matt Lewis  <jlewis3@apple.com>
1523
1524         Stub repositories fail to upload some results due to missing head svn revision
1525         https://bugs.webkit.org/show_bug.cgi?id=207684
1526
1527         Reviewed by Jonathan Bedard.
1528
1529         * Scripts/webkitpy/api_tests/run_api_tests.py:
1530         (main): Added initializing the scm to the host object.
1531         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1532         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1533         it in line with modern code.
1534         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1535         (main): Added inializing the scm to the host object.
1536         * Scripts/webkitpy/port/base.py:
1537         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
1538         from using mock SCMs and more
1539         * Scripts/webkitpy/test/main.py:
1540         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
1541         and converted the webkit_root variable to the SCM checkout root.
1542         (Tester._run_tests):
1543
1544 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
1545
1546         Move [UIDevice currentDevice] calls to UI process
1547         https://bugs.webkit.org/show_bug.cgi?id=204320
1548
1549         Reviewed by Darin Adler.
1550
1551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1552         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
1553         (TEST):
1554
1555 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
1556
1557         Move from "layer flush" terminology to "rendering update"
1558         https://bugs.webkit.org/show_bug.cgi?id=207870
1559
1560         Reviewed by Tim Horton.
1561
1562         Rename various functions and member variables to move away from the legacy "layer flush"
1563         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
1564         that we have layers is an implementation detail.
1565         
1566         Change LayerFlushThrottlingState to be an OptionSet<>.
1567
1568         * Tracing/SystemTracePoints.plist:
1569
1570 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
1571
1572         [Webkit.css] Adding popover style element
1573         This help to prevent us reinventing the wheel ever again
1574         https://bugs.webkit.org/show_bug.cgi?id=207787
1575
1576         Reviewed by Dean Jackson.
1577
1578         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
1579         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1580         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1581         (.popover):
1582         (.popover>.content):
1583         (.popover.display):
1584         (.popover .arrow):
1585         (.popover .arrow.point-top):
1586         (.popover .arrow.point-bottom):
1587         (.popover .arrow.point-left):
1588         (.popover .arrow.point-right):
1589         (@media (prefers-color-scheme: dark) .popover>.content):
1590         (@media (prefers-color-scheme: dark) .popover.display):
1591         (@media (prefers-color-scheme: dark) .popover .arrow):
1592         (.popover>.content>.section): Deleted.
1593         (.popover:focus>.content, .popover:hover>.content): Deleted.
1594         (.popover.right>.content): Deleted.
1595         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
1596         (.popover.left>.content): Deleted.
1597         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
1598         (.popover.bottom>.content): Deleted.
1599         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
1600
1601 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
1602
1603         Update WebKit Tools to issue mach extensions as needed
1604         https://bugs.webkit.org/show_bug.cgi?id=207850
1605         <rdar://problem/59521019>
1606
1607         Reviewed by Per Arne Vollan.
1608
1609         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
1610         to its child processes (WebContent, GPU, Network, etc.) as needed.
1611
1612         * MiniBrowser/MiniBrowser.entitlements:
1613         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
1614         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1616         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
1617
1618 2020-02-17  Peng Liu  <peng.liu6@apple.com>
1619
1620         Fix check-webkit-style errors related to AVFoundationSPI.h
1621         https://bugs.webkit.org/show_bug.cgi?id=207834
1622
1623         Reviewed by Eric Carlson.
1624
1625         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
1626         Soft-link headers can be included as either "file.h" or <file.h>.
1627
1628         * Scripts/webkitpy/style/checkers/cpp.py:
1629         (_classify_include):
1630         (check_include_line):
1631
1632 2020-02-17  Keith Rollin  <krollin@apple.com>
1633
1634         Unreviewed build fix after r256715.
1635
1636         Fix tvOS and watchOS builds.
1637
1638         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1639
1640 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
1641
1642         Use CF prefs direct mode in the WebContent process
1643         https://bugs.webkit.org/show_bug.cgi?id=203420
1644
1645         Reviewed by Brent Fulgham.
1646
1647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1648         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
1649         (TEST):
1650
1651 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1652
1653         EWS should be able to file Bugzilla bugs
1654         https://bugs.webkit.org/show_bug.cgi?id=207845
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         * BuildSlaveSupport/ews-build/steps.py:
1659         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
1660
1661 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1662
1663         EWS should be able to comment on Bugzilla
1664         https://bugs.webkit.org/show_bug.cgi?id=201927
1665
1666         Reviewed by Jonathan Bedard.
1667
1668         * BuildSlaveSupport/ews-build/steps.py:
1669         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
1670         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
1671         (BugzillaMixin.close_bug): Ditto.
1672         (CommentOnBug): Build step to comment on bugzilla bug.
1673
1674 2020-02-17  Antti Koivisto  <antti@apple.com>
1675
1676         [macOS] Add trace points for layer flush runloop observer
1677         https://bugs.webkit.org/show_bug.cgi?id=207837
1678
1679         Reviewed by Sam Weinig.
1680
1681         * Tracing/SystemTracePoints.plist:
1682
1683 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
1684
1685         [CMake] Use builtin targets
1686         https://bugs.webkit.org/show_bug.cgi?id=205166
1687
1688         Reviewed by Darin Adler.
1689
1690         * TestWebKitAPI/PlatformWin.cmake:
1691
1692 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1693
1694         [ews] add SetBuildSummary step for Windows EWS
1695         https://bugs.webkit.org/show_bug.cgi?id=207556
1696
1697         Reviewed by Jonathan Bedard.
1698
1699         * BuildSlaveSupport/ews-build/factories.py:
1700         (WindowsFactory.__init__):
1701         (GTKBuildAndTestFactory.__init__):
1702         * BuildSlaveSupport/ews-build/factories_unittest.py:
1703         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
1704
1705 2020-02-17  Alberto Garcia  <berto@igalia.com>
1706
1707         [WPE] Change the QML plugin install path
1708         https://bugs.webkit.org/show_bug.cgi?id=207761
1709
1710         Reviewed by Philippe Normand.
1711
1712         * Scripts/run-qt-wpe-minibrowser:
1713         * glib/api_test_runner.py:
1714         (TestRunner._run_test_qt):
1715
1716 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1717
1718         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
1719         https://bugs.webkit.org/show_bug.cgi?id=207746
1720
1721         Reviewed by Don Olmstead.
1722
1723         * MiniBrowser/win/stdafx.h:
1724
1725 2020-02-16  Brady Eidson  <beidson@apple.com>
1726
1727         Expose "allowsContentJavaScript" on WKWebpagePreferences
1728         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
1729
1730         Reviewed by Darin Adler.
1731
1732         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1733         (TEST):
1734         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1735         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1736         (TEST):
1737         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
1738         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1739         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1740         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1741         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
1742         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
1743         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1744         * TestWebKitAPI/cocoa/TestWKWebView.h:
1745         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1746         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
1747
1748 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
1749
1750         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
1751         https://bugs.webkit.org/show_bug.cgi?id=207747
1752
1753         Reviewed by Keith Miller.
1754
1755         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
1756         (TestWebKitAPI::TEST):
1757
1758 2020-02-14  Alex Christensen  <achristensen@webkit.org>
1759
1760         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
1761         https://bugs.webkit.org/show_bug.cgi?id=207360
1762         <rdar://problem/57825317>
1763
1764         Reviewed by Ryosuke Niwa.
1765
1766         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1767         (TestWebKitAPI::TEST):
1768
1769 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
1770
1771         [CMake] Add Fontconfig::Fontconfig target
1772         https://bugs.webkit.org/show_bug.cgi?id=207730
1773
1774         Reviewed by Adrian Perez de Castro.
1775
1776         Use the Fontconfig::Fontconfig target.
1777
1778         * WebKitTestRunner/PlatformGTK.cmake:
1779
1780 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
1781
1782          Expose prevalent domains on a per-page basis
1783          https://bugs.webkit.org/show_bug.cgi?id=207523
1784          <rdar://problem/59270758>
1785
1786         Reviewed by Chris Dumez.
1787
1788         Added WebKitTestRunner functions so this functionality can be tested.
1789         clearPrevalentDomains should be called between tests to reset the
1790         state.
1791
1792         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1793         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1794         (WTR::InjectedBundle::didReceiveMessageToPage):
1795         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1796         (WTR::TestRunner::getPrevalentDomains):
1797         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
1798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1799         * WebKitTestRunner/TestController.cpp:
1800         (WTR::TestController::resetStateToConsistentValues):
1801         (WTR::TestController::getPrevalentDomains):
1802         (WTR::TestController::clearPrevalentDomains):
1803         * WebKitTestRunner/TestController.h:
1804         * WebKitTestRunner/TestInvocation.cpp:
1805         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1806         (WTR::TestInvocation::didReceivePrevalentDomains):
1807         * WebKitTestRunner/TestInvocation.h:
1808         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1809         (WTR::TestController::getPrevalentDomains):
1810         (WTR::TestController::clearPrevalentDomains):
1811
1812 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1813
1814         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
1815         https://bugs.webkit.org/show_bug.cgi?id=207682
1816
1817         Reviewed by Ross Kirsling.
1818
1819         The toolbar placed button common controls as the toolbar buttons.
1820         However, because these buttons are focusable, shortcut keys don't
1821         work after clicking them.
1822
1823         Added Home button, Add to Bookmarks button, dropdown buttons of
1824         back and forward buttons, but they aren't implemented yet. Just
1825         placeholders at the moment.
1826
1827         * MiniBrowser/win/MainWindow.cpp:
1828         (MainWindow::createToolbar): Added.
1829         (MainWindow::resizeToolbar): Added.
1830         (MainWindow::rescaleToolbar): Added.
1831         (MainWindow::init):
1832         (MainWindow::resizeSubViews):
1833         (MainWindow::updateDeviceScaleFactor):
1834         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
1835
1836 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1837
1838         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
1839         https://bugs.webkit.org/show_bug.cgi?id=207676
1840
1841         Reviewed by Wenson Hsieh and Timothy Hatcher.
1842
1843         Added regression tests for pasting content with -apple-system-label and outdenting content.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1846         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
1847         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
1848
1849 2020-02-13  Alex Christensen  <achristensen@webkit.org>
1850
1851         _WKResourceLoadInfo should conform to NSSecureCoding
1852         https://bugs.webkit.org/show_bug.cgi?id=207667
1853
1854         Reviewed by Brady Eidson.
1855
1856         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1857         (TEST):
1858
1859 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
1860
1861         [PlayStation] Add Buildbots for Debug/Release builds
1862         https://bugs.webkit.org/show_bug.cgi?id=199454
1863
1864         Reviewed by Aakash Jain.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/config.json:
1867         Add PlayStation slaves, builders
1868         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1869         Use higher timeout for playstation as with win bot
1870         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
1871         Set PlayStation category for playstation platform
1872         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1873         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
1874         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1875         Add PlayStation expectations
1876
1877 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
1878
1879         [iOS] Check if PIP is supported in the UI process
1880         https://bugs.webkit.org/show_bug.cgi?id=207406
1881
1882         Reviewed by Brent Fulgham.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
1886         (TEST):
1887
1888 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1889
1890         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
1891         https://bugs.webkit.org/show_bug.cgi?id=207397
1892         <rdar://problem/59268128>
1893
1894         Reviewed by Jer Noble.
1895
1896         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1897         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1898
1899 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1900
1901         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
1902         https://bugs.webkit.org/show_bug.cgi?id=207696
1903
1904         Reviewed by Tim Horton.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1907
1908 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1909
1910         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
1911         https://bugs.webkit.org/show_bug.cgi?id=207680
1912         <rdar://problem/59340940>
1913
1914         Reviewed by Tim Horton.
1915
1916         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
1917         the current selection works.
1918
1919         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1920         (-[TestWKWebView updateSelectionWithExtentPoint:]):
1921         * TestWebKitAPI/ios/UIKitSPI.h:
1922
1923 2020-02-13  Said Abou-Hallawa  <said@apple.com>
1924
1925         Unreviewed, rolling out r255158, 255405 and r255486
1926
1927         Caused test flakiness and PLT regression.
1928
1929         * DumpRenderTree/mac/DumpRenderTree.mm:
1930         (resetWebPreferencesToConsistentValues):
1931         * DumpRenderTree/win/DumpRenderTree.cpp:
1932         (enableExperimentalFeatures):
1933         * WebKitTestRunner/TestController.cpp:
1934         (WTR::TestController::resetPreferencesToConsistentValues):
1935
1936 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1937
1938         run-javascriptcore-tests: Allow insecure requests on upload
1939         https://bugs.webkit.org/show_bug.cgi?id=207662
1940
1941         Rubber-stamped by Aakash Jain.
1942
1943         * Scripts/run-javascriptcore-tests:
1944         (uploadResults): Allow insecure curl request when posting results.
1945
1946 2020-02-12  Truitt Savell  <tsavell@apple.com>
1947
1948         Unreviewed, rolling out r256463.
1949
1950         Caused major flakiness on Mac wk2
1951
1952         Reverted changeset:
1953
1954         "REGRESSION (r255158): http/tests/frame-throttling/raf-
1955         throttle-in-cross-origin-subframe.html is a flaky failure"
1956         https://bugs.webkit.org/show_bug.cgi?id=206839
1957         https://trac.webkit.org/changeset/256463
1958
1959 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1960
1961         results.webkit.org: Remove debug JS logging
1962         https://bugs.webkit.org/show_bug.cgi?id=207663
1963
1964         Reviewed by Aakash Jain.
1965
1966         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1967         (elapsed):
1968         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1969         (_ToolTip.prototype.toString):
1970         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1971         (prototype.addWithDelay):
1972         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
1973
1974 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
1975
1976         Remove CSS_DEVICE_ADAPTATION
1977         https://bugs.webkit.org/show_bug.cgi?id=203479
1978
1979         Reviewed by Tim Horton.
1980         
1981         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
1982         so remove the code.
1983
1984         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1985
1986 2020-02-12  Said Abou-Hallawa  <said@apple.com>
1987
1988         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
1989         https://bugs.webkit.org/show_bug.cgi?id=206839
1990
1991         Reviewed by Simon Fraser.
1992
1993         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
1994
1995         * DumpRenderTree/mac/DumpRenderTree.mm:
1996         (resetWebPreferencesToConsistentValues):
1997         * DumpRenderTree/win/DumpRenderTree.cpp:
1998         (enableExperimentalFeatures):
1999         * WebKitTestRunner/TestController.cpp:
2000         (WTR::TestController::resetPreferencesToConsistentValues):
2001
2002 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2003
2004         results.webkit.org: Cache archive content
2005         https://bugs.webkit.org/show_bug.cgi?id=207589
2006
2007         Reviewed by Aakash Jain.
2008
2009         * resultsdbpy/resultsdbpy/flask_support/util.py:
2010         (cache_for): Add decorator function which sets the cache values on the returned response.
2011         * resultsdbpy/resultsdbpy/view/archive_view.py:
2012         (ArchiveView): Cache archive content client-side for 12 hours.
2013         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
2014         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2015
2016 2020-02-12  Youenn Fablet  <youenn@apple.com>
2017
2018         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2019         https://bugs.webkit.org/show_bug.cgi?id=207537
2020
2021         Reviewed by Chris Dumez.
2022
2023         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2024
2025 2020-02-11  Rob Buis  <rbuis@igalia.com>
2026
2027         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2028         <https://webkit.org/b/207424>
2029         <rdar://problem/59250384>
2030
2031         Reviewed by Rob Buis.
2032
2033         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2034         (TestWebKitAPI::TEST): Add more tests.
2035
2036 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2037
2038         Unreviewed, rolling out r256314.
2039         https://bugs.webkit.org/show_bug.cgi?id=207594
2040
2041         It is breaking an API test (Requested by youenn on #webkit).
2042
2043         Reverted changeset:
2044
2045         "WebSWServerConnection::registerServiceWorkerClient is not
2046         sending IPC message to UIProcess when it should"
2047         https://bugs.webkit.org/show_bug.cgi?id=207537
2048         https://trac.webkit.org/changeset/256314
2049
2050 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2051
2052         results.webkit.org: Configuration documentation should include architecture
2053         https://bugs.webkit.org/show_bug.cgi?id=207584
2054
2055         Reviewed by Aakash Jain.
2056
2057         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2058
2059 2020-02-11  Youenn Fablet  <youenn@apple.com>
2060
2061         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2062         https://bugs.webkit.org/show_bug.cgi?id=207325
2063         <rdar://problem/59224810>
2064
2065         Reviewed by Eric Carlson.
2066
2067         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2068         (TestWebKitAPI::TEST):
2069         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2070         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2071
2072 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2073
2074         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2075         https://bugs.webkit.org/show_bug.cgi?id=207557
2076
2077         Reviewed by Jonathan Bedard.
2078
2079         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2080         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2081         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2082         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2083         table view cells).
2084
2085         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2086
2087 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2088
2089         Add WKHTTPCookieStore._getCookiesForURL SPI
2090         https://bugs.webkit.org/show_bug.cgi?id=207527
2091
2092         Reviewed by Brady Eidson.
2093
2094         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2095         (TEST):
2096
2097 2020-02-11  Youenn Fablet  <youenn@apple.com>
2098
2099         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2100         https://bugs.webkit.org/show_bug.cgi?id=207537
2101
2102         Reviewed by Chris Dumez.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2105
2106 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2107
2108         [WPE][WebDriver] MiniBrowser should react to close session commands
2109         https://bugs.webkit.org/show_bug.cgi?id=207529
2110
2111         Reviewed by Carlos Garcia Campos.
2112
2113         WebDriver delete session command asks to close the WebView associated to the
2114         current automation session. We must react to it to avoid lots of
2115         timeouts and errors.
2116
2117         * MiniBrowser/wpe/main.cpp:
2118         (main): Listen to "close" signal on the main WebView.
2119
2120 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2121
2122         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2123         https://bugs.webkit.org/show_bug.cgi?id=207525
2124         <rdar://problem/59110543>
2125
2126         Reviewed by Tim Horton.
2127
2128         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2129         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2130         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2131         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2132         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2133         causing us to crash upon trying to create the dictionary.
2134
2135         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2136         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2137         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2138         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2139         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2140         beginning of each API test.
2141
2142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2143         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2144         (overrideBundleIdentifier):
2145
2146         Move this to the top of the file, so it can be shared.
2147
2148         (+[WKWebView initialize]):
2149
2150         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2151         internal class method that calls into the internal helper function, with no other side effects.
2152
2153         * TestWebKitAPI/ios/UIKitSPI.h:
2154
2155 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2156
2157         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2158         https://bugs.webkit.org/show_bug.cgi?id=207501
2159         <rdar://problem/59323414>
2160
2161         Reviewed by Alex Christensen.
2162
2163         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2164         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2165         The same behavior.
2166
2167 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2168
2169         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2170         https://bugs.webkit.org/show_bug.cgi?id=207352
2171         <rdar://problem/59115798>
2172
2173         Reviewed by Alex Christensen.
2174
2175         Add a test to exercise the new SPI.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2178         a webpage that contains text in subframes.
2179
2180
2181 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2182
2183         [iOS] Crash when granting access to asset services
2184         https://bugs.webkit.org/show_bug.cgi?id=207520
2185
2186         Reviewed by Brent Fulgham.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2190         (TEST):
2191
2192 2020-02-10  Chris Dumez  <cdumez@apple.com>
2193
2194         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2195         https://bugs.webkit.org/show_bug.cgi?id=207481
2196
2197         Reviewed by Alexey Proskuryakov.
2198
2199         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2200         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2201         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2202
2203         * DumpRenderTree/mac/DumpRenderTree.mm:
2204         (resetWebViewToConsistentStateBeforeTesting):
2205         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2206         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2207         over internal settings.
2208
2209 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2210
2211         [watchOS] Notification listener is never unregistered
2212         https://bugs.webkit.org/show_bug.cgi?id=207459
2213
2214         Reviewed by Maciej Stachowiak.
2215
2216         Add a test which tests that posting a backlight level change notification will not cause a crash.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2220         (TEST):
2221
2222 2020-02-10  James Howard  <jameshoward@mac.com>
2223
2224         Standard gamepad mapping for GameControllerGamepads
2225         https://bugs.webkit.org/show_bug.cgi?id=206033
2226
2227         Reviewed by Dean Jackson.
2228
2229         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2230         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2231         (WTR::TestRunner::setMockGamepadDetails):
2232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2233         * WebKitTestRunner/TestInvocation.cpp:
2234         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2235
2236 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2237
2238         [ews] Display flaky layout test names in build summary
2239         https://bugs.webkit.org/show_bug.cgi?id=207504
2240
2241         Reviewed by Jonathan Bedard.
2242
2243         * BuildSlaveSupport/ews-build/steps.py:
2244         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
2245         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
2246         (AnalyzeLayoutTestsResults.start):
2247
2248 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2249
2250         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
2251         https://bugs.webkit.org/show_bug.cgi?id=207492
2252
2253         Reviewed by Jonathan Bedard.
2254
2255         * BuildSlaveSupport/ews-build/steps.py:
2256         (RunWebKitTests.evaluateCommand):
2257         (ReRunWebKitTests.evaluateCommand):
2258         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2259         * BuildSlaveSupport/ews-build/factories.py:
2260         (TestFactory.__init__):
2261
2262 2020-02-10  Truitt Savell  <tsavell@apple.com>
2263
2264         Unreviewed, rolling out r256091.
2265
2266         Broke internal builds
2267
2268         Reverted changeset:
2269
2270         "Move trivial definitions from FeatureDefines.xcconfig to
2271         PlatformEnableCocoa.h"
2272         https://bugs.webkit.org/show_bug.cgi?id=207155
2273         https://trac.webkit.org/changeset/256091
2274
2275 2020-02-10  Truitt Savell  <tsavell@apple.com>
2276
2277         Unreviewed, rolling out r256103.
2278
2279         This patch is blocking the rollout of r256091
2280
2281         Reverted changeset:
2282
2283         "Move JavaScriptCore related feature defines from
2284         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
2285         https://bugs.webkit.org/show_bug.cgi?id=207436
2286         https://trac.webkit.org/changeset/256103
2287
2288 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2289
2290         results.webkit.org: Abstract archive storage solutions
2291         https://bugs.webkit.org/show_bug.cgi?id=207277
2292
2293         Rubber-stamped by Aakash Jain.
2294
2295         * resultsdbpy/resultsdbpy/model/archive_context.py:
2296         (ArchiveContext):
2297         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2298         (ArchiveContext.__init__): Add archiver member.
2299         (ArchiveContext.__enter__): archiver is a context manager.
2300         (ArchiveContext.__exit__): Ditto.
2301         (ArchiveContext.register): The archiver member owns saving an archive.
2302         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
2303         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
2304         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
2305         (Archiver): Base class for all Archiving systems.
2306         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
2307         (Archiver.archive_size): Given a file-like archive, calculate it's size.
2308         (Archiver.save):
2309         (Archiver.retrieve):
2310         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
2311         (CassandraArchiver):
2312         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
2313         (CassandraArchiver.__init__):
2314         (CassandraArchiver.__enter__):
2315         (CassandraArchiver.__exit__):
2316         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
2317         from ArchiveContext.
2318         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
2319         from ArchiveContext.
2320
2321 2020-02-09  Lauro Moura  <lmoura@igalia.com>
2322
2323         [GTK][WPE] Expose allowTopNavigationToDataURL
2324         https://bugs.webkit.org/show_bug.cgi?id=207384
2325
2326         Reviewed by Adrian Perez de Castro.
2327
2328         Updates with new "allow-top-navigation-to-data-urls" property.
2329
2330         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2331         (testWebViewAllowModalDialogs): This test requires this property to be
2332         set.
2333         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2334         (testWebKitSettings): Added tests for getter/setter.
2335
2336 2020-02-08  Sam Weinig  <weinig@apple.com>
2337
2338         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2339         https://bugs.webkit.org/show_bug.cgi?id=207436
2340
2341         Reviewed by Tim Horton.
2342
2343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2344         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
2345
2346 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
2347
2348         [WTF] Try using 75% load factor for HashTable
2349         https://bugs.webkit.org/show_bug.cgi?id=207183
2350
2351         Reviewed by Mark Lam.
2352
2353         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2354         (TestWebKitAPI::testInitialCapacity):
2355
2356 2020-02-08  Sam Weinig  <weinig@apple.com>
2357
2358         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2359         https://bugs.webkit.org/show_bug.cgi?id=207155
2360
2361         Reviewed by Tim Horton.
2362
2363         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2364         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2365         also has a default value in PlatformEnable.h
2366
2367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2368
2369 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2370
2371         Several iOS API tests that call -makeKeyWindow assert after r255907
2372         https://bugs.webkit.org/show_bug.cgi?id=207411
2373
2374         Reviewed by Tim Horton.
2375
2376         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
2377         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
2378         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
2379         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
2380
2381         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2382         (TestWebKitAPI::TEST):
2383         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
2384         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2385         (overrideBundleIdentifier):
2386         (setOverriddenApplicationKeyWindow):
2387
2388 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2389
2390         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
2391         https://bugs.webkit.org/show_bug.cgi?id=207405
2392
2393         Reviewed by Wenson Hsieh.
2394
2395         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2396
2397 2020-02-07  Alex Christensen  <achristensen@apple.com>
2398
2399         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
2400         https://bugs.webkit.org/show_bug.cgi?id=207409
2401         rdar://problem/59275641
2402
2403         Reviewed by Chris Dumez.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2406         (TestWebKitAPI::TEST):
2407
2408 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
2409
2410         Unreviewed, rolling out r256051.
2411
2412         Broke internal builds.
2413
2414         Reverted changeset:
2415
2416         "Move trivial definitions from FeatureDefines.xcconfig to
2417         PlatformEnableCocoa.h"
2418         https://bugs.webkit.org/show_bug.cgi?id=207155
2419         https://trac.webkit.org/changeset/256051
2420
2421 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2422
2423         iPad testers failing to launch processes
2424         https://bugs.webkit.org/show_bug.cgi?id=207401
2425         <rdar://problem/58184777>
2426
2427         Unreviewed infrastructure fix.
2428
2429         This is a speculative fix because I've had problems reproducing this error.
2430         The only time I managed to reproduce the problem was immediately after killing the 
2431         SimulatorTrampoline and CoreSimulator.xpc processes.
2432
2433         * BuildSlaveSupport/kill-old-processes:
2434         (main): Only kill Simulator.app, not all associated simulator processes.
2435
2436 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
2437
2438         [WebAuthn] Report CTAP Client Pin Error to clients
2439         https://bugs.webkit.org/show_bug.cgi?id=205837
2440         <rdar://problem/58356872>
2441
2442         Reviewed by Brent Fulgham.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2446         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2447         (TestWebKitAPI::TEST):
2448         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2449         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
2450         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2451         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2452         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
2453         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2454         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
2455         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
2456
2457 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2458
2459         run-safari Doesn't work with the latest Xcode version and iOS
2460         https://bugs.webkit.org/show_bug.cgi?id=207394
2461
2462         Reviewed by Ryosuke Niwa.
2463
2464         * Scripts/webkitdirs.pm:
2465         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
2466         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
2467
2468 2020-02-07  Daniel Bates  <dabates@apple.com>
2469
2470         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
2471         https://bugs.webkit.org/show_bug.cgi?id=207366
2472
2473         Reviewed by Brent Fulgham.
2474
2475         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
2476         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
2477         as the actual test instead of under a platform-specific directory even when the tests' behavior
2478         depends on the link-time version of WebKit.
2479
2480         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
2481         and toggling them in a test.
2482
2483         * DumpRenderTree/mac/DumpRenderTree.mm:
2484         (setDefaultsToConsistentValuesForTesting):
2485
2486 2020-02-03  Sam Weinig  <weinig@apple.com>
2487
2488         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2489         https://bugs.webkit.org/show_bug.cgi?id=207155
2490
2491         Reviewed by Tim Horton.
2492
2493         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2494         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2495         also has a default value in PlatformEnable.h
2496
2497         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2498
2499 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
2500
2501         Update WebView category name to be more accurate
2502         https://bugs.webkit.org/show_bug.cgi?id=207334
2503         <rdar://problem/59224855>
2504
2505         Reviewed by Brent Fulgham.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2508         (TEST):
2509
2510 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews] add commit-queue build step to close the bug
2513         https://bugs.webkit.org/show_bug.cgi?id=207387
2514
2515         Reviewed by Jonathan Bedard.
2516
2517         * BuildSlaveSupport/ews-build/steps.py:
2518         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
2519         (CloseBug): Build step to close bugzilla bug.
2520
2521 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
2522
2523         [ews] add commit-queue build step to clear flags on patch
2524         https://bugs.webkit.org/show_bug.cgi?id=206536
2525
2526         Reviewed by Jonathan Bedard.
2527
2528         * BuildSlaveSupport/ews-build/steps.py:
2529         (BugzillaMixin): Class for common bugzilla related methods.
2530         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
2531         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
2532         (ValidatePatch):
2533         (RemoveFlagsOnPatch): Class to remove flags on patch.
2534         (RemoveFlagsOnPatch.start):
2535         (ValidatePatch._addToLog): Moved.
2536         (ValidatePatch.fetch_data_from_url): Moved.
2537         (ValidatePatch.get_patch_json): Moved.
2538         (ValidatePatch.get_bug_json): Moved.
2539         (ValidatePatch.get_bug_id_from_patch): Moved.
2540         (ValidatePatch._is_patch_obsolete): Moved.
2541         (ValidatePatch._is_patch_review_denied): Moved.
2542         (ValidatePatch._is_patch_cq_plus): Moved.
2543         (ValidatePatch._is_bug_closed): Moved.
2544
2545 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2546
2547         EWS should run resultsdbpy tests
2548         https://bugs.webkit.org/show_bug.cgi?id=201928
2549
2550         Reviewed by Aakash Jain.
2551
2552         * BuildSlaveSupport/ews-build/factories.py:
2553         (ServicesFactory.__init__): Add RunResultsdbpyTests.
2554         * BuildSlaveSupport/ews-build/factories_unittest.py:
2555         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
2556         * BuildSlaveSupport/ews-build/steps.py:
2557         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
2558         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
2559         * BuildSlaveSupport/ews-build/steps_unittest.py:
2560         (TestRunResultsdbpyTests):
2561         (TestRunResultsdbpyTests.setUp):
2562         (TestRunResultsdbpyTests.tearDown):
2563         (TestRunResultsdbpyTests.test_success):
2564         (TestRunResultsdbpyTests.test_failure):
2565
2566 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
2567
2568         Adding myself to contributors.json
2569         
2570         Unreviewed
2571
2572         * Scripts/webkitpy/common/config/contributors.json:
2573
2574 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
2575
2576         Adding myself to contributors.json
2577         
2578         Unreviewed
2579
2580         * Scripts/webkitpy/common/config/contributors.json:
2581
2582 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
2583
2584         [GTK][WPE] Add same-site cookie support
2585         https://bugs.webkit.org/show_bug.cgi?id=204137
2586
2587         Reviewed by Carlos Garcia Campos.
2588
2589         Update libsoup to 2.69.90 in JHBuild.
2590
2591         * gtk/jhbuild.modules:
2592         * wpe/jhbuild.modules:
2593
2594 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
2595
2596         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
2597         https://bugs.webkit.org/show_bug.cgi?id=207183
2598
2599         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2600         (TestWebKitAPI::testInitialCapacity):
2601
2602 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2603
2604         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
2605         https://bugs.webkit.org/show_bug.cgi?id=207350
2606         <rdar://problem/59239914>
2607
2608         Reviewed by Tim Horton.
2609
2610         Add a test to exercise the corner case in the SPI.
2611
2612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2613         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
2614
2615 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
2616
2617         Adopt new SOAuthorizationOption constants
2618         https://bugs.webkit.org/show_bug.cgi?id=207186
2619         <rdar://problem/48909336>
2620
2621         Reviewed by Brent Fulgham.
2622
2623         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2624         (checkAuthorizationOptions):
2625
2626 2020-02-06  Brady Eidson  <beidson@apple.com>
2627
2628         Cleanup and promote WKContentWorld and its clients in WKWebView.
2629         https://bugs.webkit.org/show_bug.cgi?id=207351
2630
2631         Reviewed by Alex Christensen.
2632
2633         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2634         (TestWebKitAPI::TEST):
2635         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2636         (TEST):
2637         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2638         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
2639
2640 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2641
2642         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
2643         https://bugs.webkit.org/show_bug.cgi?id=207250
2644
2645         Reviewed by Alex Christensen.
2646
2647         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
2648         reload. However, they don't work unless the main window is
2649         focused.
2650
2651         Ctrl-W should be processed differently. Ctrl-W should be handled
2652         without dispatching to WebKit, others should be handled only when
2653         WebKit didn't consume. So, this change split the accelerator table
2654         into two, one is for Ctrl-W, another is for other shortcut keys.
2655
2656         For Ctrl-W, key events are processed before dispatching to
2657         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
2658         dispatched to WebView. WebKit2 WebView bubbles up unhandled
2659         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
2660         in the main window's WndProc. However, it doesn't work for WebKit1
2661         because this change doesn't add the bubbling up code to WebKit1
2662         WebView.
2663
2664         For other shortcut keys, for example Ctrl-R, key events are
2665         dispatched to WebView without accelerator key translations. Then,
2666         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
2667         aren't consumed. didNotHandleKeyEvent posts the messasge to the
2668         main window. The message loop processed key events dispatched to
2669         the main window with another accelerator table. However, it
2670         doesn't work for WebKit1, because WebKit1 doesn't have a API
2671         equivalent to didNotHandleKeyEvent.
2672
2673         After switching the active window by pressing Alt-Tab and
2674         reactivating the main window, the main window got the focus. This
2675         was the reason shortcut keys worked only after reactivating the
2676         main window. But, this is not the desired behavior after this
2677         change because other shortcut keys don't work if the main window
2678         is focused. So. set the focus to the brower window when
2679         WM_ACTIVATE of the main window.
2680
2681         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
2682         effective only for keyboard numpad. Add VK_OEM_MINUS and
2683         VK_OEM_PLUS for them.
2684
2685         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
2686
2687         * MiniBrowser/win/MainWindow.cpp:
2688         (MainWindow::isInstance):
2689         (MainWindow::WndProc):
2690         * MiniBrowser/win/MainWindow.h:
2691         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
2692         IDR_ACCELERATORS_PRE for Ctrl-W.
2693         * MiniBrowser/win/MiniBrowserLibResource.h:
2694         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2695         (WebKitBrowserWindow::didNotHandleKeyEvent):
2696         * MiniBrowser/win/WinMain.cpp:
2697         (wWinMain):
2698
2699 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
2700
2701         results.webkitorg: Dead CI links
2702         https://bugs.webkit.org/show_bug.cgi?id=207340
2703
2704         Reviewed by Alexey Proskuryakov.
2705
2706         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2707         (Configuration.prototype.toParams): Version name and version number often duplicate the
2708         same information, exception version number is often more specific than is useful.
2709
2710 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
2711
2712         Prevent navigating top level frames to Data URLs
2713         https://bugs.webkit.org/show_bug.cgi?id=206962
2714         <rdar://problem/56770676>
2715
2716         Reviewed by Youenn Fablet.
2717
2718         Revise test running code to allow data URL navigations by default, since they are so frequently
2719         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
2720         function.
2721
2722         * DumpRenderTree/TestOptions.cpp:
2723         (TestOptions::TestOptions):
2724         * DumpRenderTree/TestOptions.h:
2725         * DumpRenderTree/mac/DumpRenderTree.mm:
2726         (setWebPreferencesForTestOptions):
2727         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2728         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
2729         (StartDownloadWithDownloadAttribute): Ditto.
2730         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2731         (WebViewWillPerformClientRedirect): Ditto.
2732         (WebViewDidCancelClientRedirect): Ditto.
2733         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2734         (NavigateToDataURLThenBack): Ditto.
2735         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
2736         * WebKitTestRunner/TestController.cpp:
2737         (WTR::TestController::resetPreferencesToConsistentValues):
2738         (WTR::updateTestOptionsFromTestHeader):
2739         * WebKitTestRunner/TestOptions.h:
2740         (WTR::TestOptions::hasSameInitializationOptions const):
2741         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2742         (WTR::initializeWebViewConfiguration):
2743         (WTR::TestController::platformCreateWebView):
2744
2745 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2746
2747         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
2748         https://bugs.webkit.org/show_bug.cgi?id=207272
2749         <rdar://problem/59190828>
2750
2751         Reviewed by Tim Horton.
2752
2753         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
2754         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
2755         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
2756
2757         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2758         (TestWebKitAPI::overrideBundleIdentifier):
2759         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2760         (setOverriddenApplicationKeyWindow):
2761         (applicationKeyWindowOverride):
2762         (-[TestWKWebViewHostWindow makeKeyWindow]):
2763         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2764         * TestWebKitAPI/ios/UIKitSPI.h:
2765
2766         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
2767         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
2768
2769 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2770
2771         [PlayStation] Build a shared JavaScriptCore
2772         https://bugs.webkit.org/show_bug.cgi?id=198446
2773
2774         Reviewed by Fujii Hironori.
2775
2776         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
2777
2778         * TestWebKitAPI/PlatformPlayStation.cmake:
2779
2780 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
2781
2782         [WinCairo] Set up fonts for layout tests for test bot image
2783         https://bugs.webkit.org/show_bug.cgi?id=207223
2784
2785         Reviewed by Fujii Hironori.
2786
2787         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
2788           Implement activateFonts to load fonts for test
2789
2790 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2791
2792         [PlayStation] Miscellaneous build fixes February 2020 edition
2793         https://bugs.webkit.org/show_bug.cgi?id=207312
2794
2795         Unreviewed build fix.
2796
2797         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
2798
2799 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
2800
2801         [WTF] Try using 75% load factor for HashTable
2802         https://bugs.webkit.org/show_bug.cgi?id=207183
2803
2804         Reviewed by Mark Lam.
2805
2806         Fix load-factor assumption in existing tests.
2807
2808         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2809         (TestWebKitAPI::testInitialCapacity):
2810
2811 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2812
2813         resulsdbpy: Fix unit tests
2814         https://bugs.webkit.org/show_bug.cgi?id=207304
2815
2816         Reviewed by Aakash Jain.
2817
2818         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
2819         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
2820         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
2821         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
2822         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
2823         (FailureContextTest.test_unexpected_failures): Ditto.
2824         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2825         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
2826         of knowing how expensive the callback may be.
2827
2828 2020-02-05  Chris Dumez  <cdumez@apple.com>
2829
2830         Unreviewed, another build fix after r255846
2831
2832         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2833
2834 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2835
2836         Unreviewed infrastructure fix.
2837
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2839         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
2840
2841 2020-02-05  Chris Dumez  <cdumez@apple.com>
2842
2843         Unreviewed build fix after r255846.
2844
2845         * TestWebKitAPI/cocoa/HTTPServer.h:
2846
2847 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
2848
2849         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
2850         https://bugs.webkit.org/show_bug.cgi?id=207173
2851         <rdar://problem/55669065>
2852
2853         Reviewed by Brent Fulgham.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2856         (TestWebKitAPI::TEST):
2857         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2858         (-[TestWKWebView _setUpTestWindow:]):
2859         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
2860
2861 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2862
2863         results.webkit.org: Apply ttl to archive shards
2864         https://bugs.webkit.org/show_bug.cgi?id=207295
2865
2866         Rubber-stamped by Aakash Jain.
2867
2868         * resultsdbpy/resultsdbpy/model/archive_context.py:
2869         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
2870         (ArchiveContext.ArchiveChunks): Use new table.
2871         (ArchiveContext.register): Add ttl to archive shards.
2872
2873 2020-02-05  Alex Christensen  <achristensen@webkit.org>
2874
2875         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
2876         https://bugs.webkit.org/show_bug.cgi?id=207207
2877
2878         Reviewed by Chris Dumez.
2879
2880         HTTPServer now supports HTTPS. Tell your friends!
2881
2882         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2883         (testCertificate):
2884         (testIdentity):
2885         (credentialWithIdentity):
2886         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2887         (TestWebKitAPI::webViewWithNavigationDelegate):
2888         (TestWebKitAPI::TEST):
2889         * TestWebKitAPI/cocoa/HTTPServer.h:
2890         * TestWebKitAPI/cocoa/HTTPServer.mm:
2891         (TestWebKitAPI::HTTPServer::HTTPServer):
2892         (TestWebKitAPI::HTTPServer::request const):
2893
2894 2020-02-05  Brady Eidson  <beidson@apple.com>
2895
2896         _WKDownload should expose the originating FrameInfo.
2897         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
2898
2899         Reviewed by Geoff Garen.
2900
2901         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2902         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2903         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
2904         (loaded):
2905         * TestWebKitAPI/cocoa/HTTPServer.mm:
2906
2907 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2908
2909         [GTK] Fix dependencies build
2910         https://bugs.webkit.org/show_bug.cgi?id=207273
2911
2912         Reviewed by Carlos Garcia Campos.
2913
2914         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
2915         added mesa as one of its deps. Added the xserver patch as well.
2916         * gtk/patches/xserver-gl-version.patch: Added.
2917
2918 2020-02-05  Chris Dumez  <cdumez@apple.com>
2919
2920         REGRESSION(r255595): page not closed after beforeunload handler returns true
2921         https://bugs.webkit.org/show_bug.cgi?id=207189
2922         <rdar://problem/59149593>
2923
2924         Reviewed by Youenn Fablet.
2925
2926         Add API test coverage for fix landed in r255677.
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2929         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2930         (TEST):
2931
2932 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2933
2934         results.webkit.org should disable auto-capitalize over the search field
2935         https://bugs.webkit.org/show_bug.cgi?id=207240
2936         <rdar://problem/59053042>
2937
2938         Rubber-stamped by Aakash Jain.
2939
2940         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2941
2942 2020-02-01  Darin Adler  <darin@apple.com>
2943
2944         Replace RGBA32 typedef with a class to improve type safety
2945         https://bugs.webkit.org/show_bug.cgi?id=206862
2946
2947         Reviewed by Sam Weinig.
2948
2949         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2950         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
2951
2952 2020-02-04  Darin Adler  <darin@apple.com>
2953
2954         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
2955         https://bugs.webkit.org/show_bug.cgi?id=207203
2956
2957         Reviewed by Anders Carlsson.
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
2960         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
2961         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
2962         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
2963         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
2964
2965 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2966
2967         results.webkit.org: Support Internal in run-javascriptcore-tests
2968         https://bugs.webkit.org/show_bug.cgi?id=204095
2969
2970         Rubber-stamped by Aakash Jain.
2971
2972         * Scripts/VCSUtils.pm:
2973         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
2974         (gitBranchForDirectory): Compute branch for directory.
2975         (gitBranch): Compute branch for the current git directory.
2976         (commitForDirectory): Add git support.
2977         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
2978         * Scripts/run-javascriptcore-tests:
2979         (uploadResults): Check for Internal repository.
2980
2981 2020-02-04  Alex Christensen  <achristensen@webkit.org>
2982
2983         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
2984         https://bugs.webkit.org/show_bug.cgi?id=207204
2985
2986         Reviewed by Simon Fraser.
2987
2988         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
2989         in LLDB's python API.
2990
2991         * lldb/lldb_webkit_unittest.py:
2992         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
2993         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
2994         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
2995
2996 2020-02-04  Lauro Moura  <lmoura@igalia.com>
2997
2998         [EWS] Stop GTK/WPE build if jhbuild fails.
2999         https://bugs.webkit.org/show_bug.cgi?id=207220
3000
3001         Reviewed by Adrian Perez de Castro.
3002
3003         * BuildSlaveSupport/ews-build/steps.py:
3004         (InstallGtkDependencies): Halt on failure
3005         (InstallWpeDependencies): Ditto
3006
3007 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3008
3009         Fix Mac CMake build
3010         https://bugs.webkit.org/show_bug.cgi?id=207231
3011
3012         * DumpRenderTree/PlatformMac.cmake:
3013         * MiniBrowser/mac/CMakeLists.txt:
3014         * MiniBrowser/mac/WK2BrowserWindowController.m:
3015         (-[WK2BrowserWindowController awakeFromNib]):
3016         * WebKitTestRunner/PlatformMac.cmake:
3017
3018 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
3019
3020         [PlayStation] Enable TestWebKit
3021         https://bugs.webkit.org/show_bug.cgi?id=207211
3022
3023         Reviewed by Ross Kirsling.
3024
3025         Stub out PlayStation implementation of TestWebKit so it builds.
3026
3027         * TestWebKitAPI/PlatformPlayStation.cmake:
3028         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
3029         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
3030         (TestWebKitAPI::Util::createInjectedBundlePath):
3031         (TestWebKitAPI::Util::createURLForResource):
3032         (TestWebKitAPI::Util::URLForNonExistentResource):
3033         (TestWebKitAPI::Util::isKeyDown):
3034         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
3035         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3036         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3037         (TestWebKitAPI::PlatformWebView::initialize):
3038         (TestWebKitAPI::PlatformWebView::page const):
3039         (TestWebKitAPI::PlatformWebView::resizeTo):
3040         (TestWebKitAPI::PlatformWebView::focus):
3041         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3042         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3043         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3044         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3045
3046 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3047
3048         results.webkit.org: Support branches in run-javascriptcore-tests
3049         https://bugs.webkit.org/show_bug.cgi?id=204094
3050
3051         Rubber-stamped by Aakash Jain.
3052
3053         * Scripts/run-javascriptcore-tests:
3054         (uploadResults): Use webkitdirs function to generate commit information.
3055         * Scripts/VCSUtils.pm:
3056         (commitForDirectory): Generate commit information for SVN repository, including
3057         branch name.
3058
3059 2020-02-04  Matt Lewis  <jlewis3@apple.com>
3060
3061         Replace bot677 due to hardware failure
3062         https://bugs.webkit.org/show_bug.cgi?id=207224
3063
3064         Reviewed by Aakash Jain.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/config.json:
3067
3068 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3069
3070         TestWebKitAPI: Handle case where test result does not contain path
3071         https://bugs.webkit.org/show_bug.cgi?id=207216
3072
3073         Reviewed by Tim Horton.
3074
3075         * TestWebKitAPI/TestsController.cpp:
3076         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
3077         will not contain a file name. We should handle this case.
3078
3079 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3080
3081         results.webkit.org: Better order upload callbacks
3082         https://bugs.webkit.org/show_bug.cgi?id=207219
3083
3084         Reviewed by Aakash Jain.
3085
3086         Order upload callbacks more deliberately so that the quickest callbacks
3087         that are least likely to link to information from unfinished callbacks are
3088         executed first.
3089
3090         * resultsdbpy/resultsdbpy/model/model.py:
3091         (Model.__init__): Generate buildbot links first, then generate a failure
3092         list, then generate the collective suite results and finally, individual
3093         test results.
3094
3095 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3096
3097         [EWS] Do not remove TestWebKitAPI prefix from api test failures
3098         https://bugs.webkit.org/show_bug.cgi?id=207210
3099
3100         Reviewed by Jonathan Bedard.
3101
3102         * BuildSlaveSupport/ews-build/steps.py:
3103         (AnalyzeAPITestsResults.analyzeResults):
3104
3105 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3106
3107         [EWS] Do not remove webkitpy prefix from test failures
3108         https://bugs.webkit.org/show_bug.cgi?id=207206
3109
3110         Reviewed by Jonathan Bedard.
3111
3112         * BuildSlaveSupport/ews-build/steps.py:
3113         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
3114         case when json output doesn't have failures/errors key.
3115         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3116
3117 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
3118
3119         [CMake] Add Cairo::Cairo target
3120         https://bugs.webkit.org/show_bug.cgi?id=207159
3121
3122         Reviewed by Konstantin Tokarev.
3123
3124         * DumpRenderTree/PlatformWin.cmake:
3125         * ImageDiff/Cairo.cmake:
3126         * TestWebKitAPI/PlatformWPE.cmake:
3127         * TestWebKitAPI/PlatformWin.cmake:
3128         * TestWebKitAPI/glib/CMakeLists.txt:
3129         * WebKitTestRunner/PlatformGTK.cmake:
3130         * WebKitTestRunner/PlatformWPE.cmake:
3131         * WebKitTestRunner/PlatformWin.cmake:
3132         * wpe/backends/CMakeLists.txt:
3133
3134 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
3135
3136         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
3137         https://bugs.webkit.org/show_bug.cgi?id=207079
3138         <rdar://problem/48290464>
3139
3140         Reviewed by Brent Fulgham.
3141
3142         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3143         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3144         (overrideGetAuthorizationHintsWithURL):
3145         (TestWebKitAPI::TEST):
3146
3147 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3148
3149         results.webkit.org: Support jsc stress tests
3150         https://bugs.webkit.org/show_bug.cgi?id=204096
3151
3152         Rubber-stamped by Aakash Jain.
3153
3154         * Scripts/run-javascriptcore-tests:
3155         (runJSCStressTests): Add pass and failures to reported results.
3156
3157 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3158
3159         Make Bugzilla._find_select_element_for_flag more robust
3160         https://bugs.webkit.org/show_bug.cgi?id=207148
3161
3162         Reviewed by Jonathan Bedard.
3163
3164         This patch resolves two FIXMEs:
3165         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
3166         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
3167
3168         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3169         (Bugzilla._fill_attachment_form):
3170         (Bugzilla._find_select_element_for_flag):
3171
3172 2020-02-03  Alex Christensen  <achristensen@webkit.org>
3173
3174         Reduce size of HashMap and HashSet
3175         https://bugs.webkit.org/show_bug.cgi?id=207138
3176
3177         Reviewed by Yusuke Suzuki.
3178
3179         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3180         (TestWebKitAPI::TEST):
3181         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3182         (TestWebKitAPI::TEST):
3183
3184 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3185
3186         obsolete_attachment should not fail when flags do not exist
3187         https://bugs.webkit.org/show_bug.cgi?id=171121
3188
3189         Reviewed by Jonathan Bedard.
3190
3191         Before this change, an error occured if a contributor without EditBugs privileges tried
3192         to obsolete not their own attachment. With this patch, uploading routine continues with
3193         friendly console warning like we have in reassign_bug() method.
3194
3195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3196         (Bugzilla):
3197         (Bugzilla.obsolete_attachment):
3198         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
3199
3200 2020-02-03  Chris Dumez  <cdumez@apple.com>
3201
3202         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
3203         https://bugs.webkit.org/show_bug.cgi?id=207121
3204         <rdar://problem/58880177>
3205
3206         Reviewed by Alex Christensen.
3207
3208         Add API test coverage.
3209
3210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3211         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
3212         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3213         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3214         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
3215         (TEST):
3216
3217 2020-02-03  Lauro Moura  <lmoura@igalia.com>
3218
3219         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
3220         https://bugs.webkit.org/show_bug.cgi?id=206517
3221
3222         Reviewed by Carlos Alberto Lopez Perez.
3223
3224         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3225         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
3226         starts with a leading slash instead of using the test URL, which could
3227         cause input forms with invalid file data.
3228
3229 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
3230
3231         [ews] Set custom build summary for webkitpy tests
3232         https://bugs.webkit.org/show_bug.cgi?id=207027
3233
3234         Reviewed by Jonathan Bedard.
3235
3236         * BuildSlaveSupport/ews-build/factories.py:
3237         * BuildSlaveSupport/ews-build/steps.py:
3238         (WebKitPyTest.setBuildSummary):
3239         (WebKitPyTest.getResultSummary):
3240         * BuildSlaveSupport/ews-build/factories_unittest.py:
3241
3242 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3243
3244         run-javascriptcore-tests: Don't split binary results
3245         https://bugs.webkit.org/show_bug.cgi?id=207118
3246
3247         Rubber-stamped by Aakash Jain.
3248
3249         * Scripts/run-javascriptcore-tests:
3250         (runTest): Only report aggregated binary results.
3251
3252 2020-02-03  Chris Dumez  <cdumez@apple.com>
3253
3254         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
3255
3256         The ResponsivenessTimer is disabled for those configurations as of r255518.
3257
3258         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3259
3260 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
3261
3262         Use std::hypot() where possible
3263         https://bugs.webkit.org/show_bug.cgi?id=198483
3264
3265         Reviewed by Carlos Garcia Campos.
3266
3267         Use std::hypot() where possible, allowing for a possibly more precise
3268         calculation of square roots of sums of two or three square values.
3269
3270         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3271         (-[DragAndDropSimulator initialProgressForMouseDrag]):
3272
3273 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3274
3275         [JHBuild] remove libvpx
3276         https://bugs.webkit.org/show_bug.cgi?id=207103
3277
3278         Reviewed by Xabier Rodriguez-Calvar.
3279
3280         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
3281         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
3282
3283         * gstreamer/jhbuild.modules: remove libvpx.
3284
3285 2020-02-02  Sam Weinig  <weinig@apple.com>
3286
3287         Update style checker with new locations OS version checks are allowed
3288         https://bugs.webkit.org/show_bug.cgi?id=207106
3289
3290         Reviewed by Alexey Proskuryakov.
3291
3292         * Scripts/webkitpy/style/checkers/cpp.py:
3293         (check_os_version_checks):
3294         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3295         (WebKitStyleTest.test_os_version_checks):
3296         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
3297
3298 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
3299
3300         Closing a MiniBrowser WK2 window does not release the WKWebView
3301         https://bugs.webkit.org/show_bug.cgi?id=203185
3302
3303         Reviewed by Wenson Hsieh.
3304         
3305         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
3306         to avoid a retain cycle that keeps the window controller and WKWebView alive.
3307
3308         * MiniBrowser/mac/WK2BrowserWindowController.m:
3309         (-[WK2BrowserWindowController awakeFromNib]):
3310
3311 2020-01-31  David Quesada  <david_quesada@apple.com>
3312
3313         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
3314         https://bugs.webkit.org/show_bug.cgi?id=206984
3315         rdar://problem/58999654
3316
3317         Reviewed by Brady Eidson.
3318
3319         Add an API test for a resumed download that receives an authentication challenge. The download
3320         delegate should be asked to handle the challenge, and the download should be able to finish.
3321
3322         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3323         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3324         (-[DownloadCancelingDelegate _download:didReceiveData:]):
3325         (-[DownloadCancelingDelegate _downloadDidCancel:]):
3326         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
3327         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
3328         (TEST):
3329
3330 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3331
3332         Add support for specifying background colors when setting marked text
3333         https://bugs.webkit.org/show_bug.cgi?id=207065
3334         <rdar://problem/57876140>
3335
3336         Reviewed by Tim Horton.
3337
3338         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
3339         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
3340         each describing one range (in the composition) to highlight.
3341
3342         * DumpRenderTree/ios/TextInputControllerIOS.m:
3343         (+[TextInputController isSelectorExcludedFromWebScript:]):
3344         (+[TextInputController webScriptNameForSelector:]):
3345         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3346         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3347         * DumpRenderTree/mac/TextInputControllerMac.m:
3348         (+[TextInputController isSelectorExcludedFromWebScript:]):
3349         (+[TextInputController webScriptNameForSelector:]):
3350         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3351         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3352         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3353         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3354         (WTR::arrayLength):
3355         (WTR::createCompositionHighlightData):
3356
3357         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
3358         is then passed into WebKit via WKBundlePageSetComposition.
3359
3360         (WTR::TextInputController::setMarkedText):
3361         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3362
3363 2020-01-31  Alex Christensen  <achristensen@webkit.org>
3364
3365         Add KVO SPI WKWebView._negotiatedLegacyTLS
3366         https://bugs.webkit.org/show_bug.cgi?id=207067
3367
3368         Reviewed by Andy Estes.
3369
3370         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3371         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
3372         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
3373         (TestWebKitAPI::TEST):
3374         * TestWebKitAPI/config.h:
3375
3376 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3377
3378         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
3379         https://bugs.webkit.org/show_bug.cgi?id=207050
3380
3381         Reviewed by Jonathan Bedard.
3382
3383         * BuildSlaveSupport/ews-build/steps.py:
3384         (ReRunWebKitTests.evaluateCommand):
3385
3386 2020-01-31  David Kilzer  <ddkilzer@apple.com>
3387
3388         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
3389         <https://webkit.org/b/206759>
3390         <rdar://problem/58872607>
3391
3392         Reviewed by Brent Fulgham.
3393
3394         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3395         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3396         - Add declaration.
3397         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3398         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3399         - Implement by waiting for
3400           -[UIViewController isPerformingModalTransition] to return NO
3401           while spinning the runloop.
3402         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3403         - Call waitForModalTransitionToFinish() to fix the test.
3404
3405 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3406
3407         [ews] add build step to set custom build summary
3408         https://bugs.webkit.org/show_bug.cgi?id=207026
3409
3410         Reviewed by Jonathan Bedard.
3411
3412         * BuildSlaveSupport/ews-build/steps.py:
3413         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
3414         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
3415         (SetBuildSummary.start):
3416
3417 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
3418
3419         results.webkit.org: Handle modified firewall rules
3420         https://bugs.webkit.org/show_bug.cgi?id=207047
3421
3422         Reviewed by Aakash Jain.
3423
3424         * Scripts/webkitpy/results/upload.py:
3425         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
3426         indicating the upload failed.
3427         * Scripts/webkitpy/results/upload_unittest.py:
3428         (UploadTest.test_archive_upload):
3429
3430 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
3431
3432         Unreviewed, another speculative test fix after r255041
3433
3434         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3435         (WTR::TestController::addTestKeyToKeychain):
3436         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
3437         potential error due to screen locks.
3438
3439 2020-01-30  Alex Christensen  <achristensen@webkit.org>
3440
3441         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
3442         https://bugs.webkit.org/show_bug.cgi?id=206979
3443
3444         Reviewed by Brady Eidson.
3445
3446         * MiniBrowser/mac/SettingsController.m:
3447         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3448         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
3449         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
3450         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
3451         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3452         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
3453         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3454         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
3455         (TestWebKitAPI::TEST):
3456
3457 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3458
3459         PAL: Remove old iOS version macros
3460         https://bugs.webkit.org/show_bug.cgi?id=206905
3461
3462         Reviewed by Darin Adler.
3463
3464         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
3465         with HAVE(NSPROGRESS_PUBLISHING_SPI)
3466
3467 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3468
3469         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
3470         https://bugs.webkit.org/show_bug.cgi?id=206997
3471
3472         Reviewed by Wenson Hsieh.
3473
3474         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3475         (TestWebKitAPI::TEST):
3476
3477 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
3478
3479         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
3480         https://bugs.webkit.org/show_bug.cgi?id=206932
3481
3482         Reviewed by Alexey Proskuryakov.
3483
3484         * Scripts/webkitpy/xcode/simulated_device.py:
3485         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
3486         some version will return a runtime of the same major version with a minor version
3487         that is equal to or greater than the specified minor version.
3488         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3489         (test_matching_up_success):
3490         (test_matching_up_failure):
3491
3492 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3493
3494         [JSC] Give up IC when unknown structure transition happens
3495         https://bugs.webkit.org/show_bug.cgi?id=206846
3496
3497         Reviewed by Mark Lam.
3498
3499         Add `crash!` annotation, which allows us to write a crashing JS test.
3500
3501         * Scripts/run-jsc-stress-tests:
3502         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3503         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
3504         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3505
3506 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3507
3508         [GTK] Add api-gtk to EWS bubbles.
3509         https://bugs.webkit.org/show_bug.cgi?id=206930
3510
3511         Reviewed by Aakash Jain.
3512
3513         A new queue has been added to the EWS to run GTK API tests in r255238.
3514         The queue is now running fine with no pre-existent failures.
3515         Let's add it to the EWS bubbles.
3516
3517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3518         (StatusBubble):
3519
3520 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3521
3522         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
3523         https://bugs.webkit.org/show_bug.cgi?id=206927
3524
3525         Reviewed by Carlos Garcia Campos.
3526
3527         Update the default value tested from 4MB to 5MB.
3528
3529         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3530         (testsJSCOptions):
3531
3532 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3533
3534         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
3535         https://bugs.webkit.org/show_bug.cgi?id=206925
3536
3537         Reviewed by Carlos Garcia Campos.
3538
3539         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
3540         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
3541         run the complex text controller API tests.
3542
3543         * gtk/install-dependencies:
3544         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
3545
3546 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3547
3548         macCatalyst: Right clicking on a link follows it immediately
3549         https://bugs.webkit.org/show_bug.cgi?id=206919
3550         <rdar://problem/58936679>
3551
3552         Reviewed by Wenson Hsieh.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
3555         (TEST):
3556         Add a test ensuring that mouseup is still called with the secondary button,
3557         even if the event's buttonmask is 0.
3558
3559 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3560
3561         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
3562         https://bugs.webkit.org/show_bug.cgi?id=206913
3563         <rdar://problem/58973357>
3564
3565         Reviewed by Chris Dumez.
3566
3567         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3568
3569 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3570
3571         macCatalyst: Triple clicking to select a sentence results in an empty selection
3572         https://bugs.webkit.org/show_bug.cgi?id=206863
3573         <rdar://problem/58776993>
3574
3575         Reviewed by Wenson Hsieh.
3576
3577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3578         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm: Added.
3579         (-[WKTestingEvent locationInView:]):
3580         (-[WKTestingEvent _setButtonMask:]):
3581         (-[WKTestingEvent _buttonMask]):
3582         (-[WKTestingTouch locationInView:]):
3583         (-[WKTestingTouch setTapCount:]):
3584         (-[WKTestingTouch tapCount]):
3585         (mouseGesture):
3586         (TEST):
3587         Add a test ensuring that simply plumbing mouse events to WebCore
3588         does not result in a selection change in macCatalyst (because UIKit
3589         will handle the selection change itself, instead).
3590
3591 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3592
3593         TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
3594         https://bugs.webkit.org/show_bug.cgi?id=206907
3595         <rdar://problem/58969924>
3596
3597         Rubber-stamped by Alexey Proskuryakov.
3598
3599         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm: Conditionalize on USE(QUICK_LOOK).
3600
3601 2020-01-28  Sihui Liu  <sihui_liu@apple.com>
3602
3603         IndexedDB: speed up index records deletion
3604         https://bugs.webkit.org/show_bug.cgi?id=206196
3605
3606         Reviewed by Brady Eidson.
3607
3608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3609         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgrade.sqlite3: Added.
3610         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.html: Added.
3611         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm: Added.
3612         (-[IDBObjectStoreInfoUpgradeToV2MessageHandler userContentController:didReceiveScriptMessage:]):
3613         (TEST):
3614
3615 2020-01-28  James Darpinian  <jdarpinian@chromium.org>
3616
3617         Quote file argument to git check-attr
3618         https://bugs.webkit.org/show_bug.cgi?id=206322
3619
3620         Reviewed by Jonathan Bedard.
3621
3622         * Scripts/prepare-ChangeLog:
3623         (attributeCommand):
3624         * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Added.
3625         (writeFileWithContent):
3626
3627 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
3628
3629         Reset the application bundle identifier between test runs
3630         https://bugs.webkit.org/show_bug.cgi?id=206858
3631         <rdar://problem/58844002>
3632
3633         Reviewed by Per Arne Vollan.
3634
3635         Clear the application bundle identifier set during testing when resetting the test system
3636         to a known state in preparation for the next run.
3637
3638         * WebKitTestRunner/TestController.cpp:
3639         (WTR::TestController::resetStateToConsistentValues): Clear any override for the application
3640         bundle identifier before the next test invocation.
3641         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3642         (WTR::TestController::setApplicationBundleIdentifier): Correct an over-release caused by assigning
3643         an autorelease return value to an NSRetainPtr.
3644         (WTR::TestController::clearApplicationBundleIdentifierTestingOverride): Added.
3645
3646 2020-01-28  Aakash Jain  <aakash_jain@apple.com>
3647
3648         EWS django app should send cq+ patches to commit-queue
3649         https://bugs.webkit.org/show_bug.cgi?id=206534
3650
3651         Reviewed by Jonathan Bedard.
3652
3653         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3654         (Buildbot.send_patch_to_buildbot): Added support to send to commit queue.
3655         * BuildSlaveSupport/ews-app/ews/config.py: Added COMMIT_QUEUE_PORT.
3656         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added support for sending patches to commit queue.
3657         * BuildSlaveSupport/ews-app/ews/migrations/0003_patch_sent_to_commit_queue.py: Added.
3658         * BuildSlaveSupport/ews-app/ews/models/patch.py: