9aa99e02d209dbba0ee44208e15ed7993ac0ede8
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2
3         Disable accessibility notifications after each test
4         https://bugs.webkit.org/show_bug.cgi?id=112579
5
6         Reviewed by Tim Horton.
7         
8         In WebKitTestRunner, if any tests triggered accessibility notifications,
9         the global notification handler would thereafter be active, and fire
10         notifications for all subsequent tests.
11         
12         Fix by implementing AccessibilityController::resetToConsistentState() for
13         Mac, and using it to clear the global notification handler.
14
15         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
16         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
17         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
18         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
19         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
20         (e.g. because of -autorelease).
21         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
22         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
23         if there is one.
24         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
25         Add -stopObserving
26         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
27         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
28         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
29         center.
30
31 2013-03-18  Dana Jansens  <danakj@chromium.org>
32
33         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
34         https://bugs.webkit.org/show_bug.cgi?id=112392
35
36         Reviewed by James Robinson.
37
38         Removes the command line flag option from DRT.
39
40         * DumpRenderTree/chromium/DumpRenderTree.cpp:
41         (main):
42
43 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
44
45         [GTK] plugins/plugin-clip-subframe.html is failing
46         https://bugs.webkit.org/show_bug.cgi?id=112570
47
48         Reviewed by Martin Robinson.
49
50         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
51
52 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
53
54         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
55         https://bugs.webkit.org/show_bug.cgi?id=112442
56
57         Reviewed by Gustavo Noronha Silva.
58
59         * GtkLauncher/main.c:
60         (reloadCb):
61         (createToolbar):
62         (createWindow):
63
64 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
65
66         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
67         https://bugs.webkit.org/show_bug.cgi?id=112205
68
69         Disable this API test until Geoff can fix it.
70
71         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
72         (TestWebKitAPI::TEST):
73
74 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
75
76         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
77         https://bugs.webkit.org/show_bug.cgi?id=112478
78
79         Reviewed by Tony Chang.
80
81         There is nothing that ensures that the log messages from the plugin
82         come in before the layout test finished loading.
83
84         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
85         (PassDifferentNPPStruct::NPP_SetWindow):
86         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
87         (NPP_SetWindow):
88
89 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
90
91         Have the mac port support per_test_timeout in webkitpy
92         https://bugs.webkit.org/show_bug.cgi?id=112466
93
94         Reviewed by Dirk Pranke.
95         
96         Both WTR and DRT handle --timeout arguments, so we can
97         have the scripts pass the timeout values down to the tools.
98
99         * Scripts/webkitpy/layout_tests/port/mac.py:
100         (MacPort.supports_per_test_timeout):
101
102 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
103
104         Remove setAsynchronousSpellCheckingEnabled from test runners
105         https://bugs.webkit.org/show_bug.cgi?id=112362
106
107         Reviewed by Tony Chang.
108
109         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
110         in internals.settings, so all ports can share it.
111
112         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
113         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
114         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
115         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
116         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
117         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
118         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
119         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
120         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
121         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
122         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
123         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
124
125 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
126
127         Fix the stupid unit tests.
128
129         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
130         (test_sample_process):
131
132 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
133
134         Collect samples for unresponsive web processes
135         https://bugs.webkit.org/show_bug.cgi?id=112409
136
137         Reviewed by Tim Horton.
138         
139         When we detect that a subprocess was unresponsive, run the 'sample'
140         tool on that process, for the Mac port.
141         
142         The sample will be linked to from the results.html page, next
143         to the crash log link.
144
145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
146         (Manager._look_for_new_crash_logs): Before looking for crash logs,
147         look for samples on disk.
148         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
149         (TestResultWriter):
150         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
151         -sample.txt files, and have it copy their contents to a new file
152         next to the test that spawned them (as we do for crash logs).
153         * Scripts/webkitpy/layout_tests/port/base.py:
154         (Port.look_for_new_samples): Base class does nothing for sampling.
155         * Scripts/webkitpy/layout_tests/port/driver.py:
156         (Driver._check_for_driver_crash): Kick off a sample if we detected
157         that the subprocess was unresponsive.
158         * Scripts/webkitpy/layout_tests/port/mac.py:
159         (MacPort.sample_file_path): Utility to generate the file path
160         to the generated sample files at the top level of layout-test-results.
161         (MacPort.look_for_new_crash_logs): Fix typo
162         (MacPort.look_for_new_samples): New function to find sample files.
163         (MacPort.sample_process): Use the utility function to get the file path.
164
165 2013-03-15  Zeno Albisser  <zeno@webkit.org>
166
167         [Qt] Remove simple getters and setters from TestRunnerQt
168         https://bugs.webkit.org/show_bug.cgi?id=112343
169
170         Reviewed by Benjamin Poulain.
171
172         The removed functions and boolean members
173         are being replaced by the implementations in the
174         generic TestRunner.h.
175
176         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
177         (DumpRenderTree::dumpFrameScrollPosition):
178         (DumpRenderTree::dumpFramesAsText):
179         (DumpRenderTree::dump):
180         (DumpRenderTree::titleChanged):
181         (DumpRenderTree::dumpDatabaseQuota):
182         (DumpRenderTree::dumpApplicationCacheQuota):
183         (DumpRenderTree::statusBarMessage):
184         (DumpRenderTree::createWindow):
185         * DumpRenderTree/qt/TestRunnerQt.cpp:
186         (TestRunnerQt::reset):
187         * DumpRenderTree/qt/TestRunnerQt.h:
188         (TestRunnerQt):
189
190 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
191
192         Update the link on build.webkit.org to refer to perf.webkit.org
193         https://bugs.webkit.org/show_bug.cgi?id=112416
194
195         Reviewed by Philip Rogers.
196
197         Updated the link. Also updated the template to use HTML5 DOCTYPE.
198
199         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
200
201 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
202
203         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
204         https://bugs.webkit.org/show_bug.cgi?id=112394
205
206         Reviewed by Philippe Normand.
207
208         * GtkLauncher/main.c:
209         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
210
211 2013-03-14  Andreas Kling  <akling@apple.com>
212
213         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
214         <http://webkit.org/b/111815>
215         <rdar://problem/13380145>
216
217         Reviewed by Anders Carlsson.
218
219         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
220         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
221         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
222
223         * WebKitTestRunner/PlatformWebView.h:
224         (PlatformWebView):
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::createOtherPage):
227         (WTR::TestController::createWebViewWithOptions):
228         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
229         (WTR::PlatformWebView::didInitializeClients):
230
231 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
232
233         [EFL][MiniBrowser] Add a search field to the MiniBrowser
234         https://bugs.webkit.org/show_bug.cgi?id=112122
235
236         Reviewed by Kenneth Rohde Christiansen.
237
238         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
239
240         * MiniBrowser/efl/main.c:
241         (_Browser_Window):
242         (search_box_show):
243         (search_box_hide):
244         (on_key_down):
245         (on_url_changed):
246         (on_search_field_aborted):
247         (on_search_field_activated):
248         (on_search_field_clicked):
249         (on_search_backward_button_clicked):
250         (on_search_forward_button_clicked):
251         (window_create):
252
253 2013-03-14  Julie Parent  <jparent@chromium.org>
254
255         Cleanup: Remove g_resourceLoader.
256         https://bugs.webkit.org/show_bug.cgi?id=112305
257
258         Reviewed by Dirk Pranke.
259         
260         Removing another global.
261         
262         Now, each dashboard creates its own loader, rather than having
263         a general global one.
264         
265         Remove usage of g_resourceLoader.isLoadingComplete from 
266         handleLocationChange by ensuring that handleLocationChange is
267         never called before the loader is done.  It was called in two
268         places before: 1 was from the callback when the loader is done,
269         so that was obviously true, and the other was from onhashchange,
270         where it would just return rather than running.  Instead, lets
271         only register the onhashchange handler once the loader is
272         setup, so the check is no longer necessary.
273         
274         Remove isLoadingComplete since it is now unused.
275         
276         Callback for loader is now initializeHistory, rather than just
277         handleLocationChange which will set up the hashchange handler now.
278         This will all eventually be moving to a new History object.
279
280         * TestResultServer/static-dashboards/aggregate_results.html:
281         * TestResultServer/static-dashboards/dashboard_base.js:
282         (handleLocationChange):
283         (intializeHistory):
284         (decompressResults):
285         * TestResultServer/static-dashboards/flakiness_dashboard.js:
286         (generatePage):
287         * TestResultServer/static-dashboards/loader.js:
288         (.):
289         * TestResultServer/static-dashboards/loader_unittests.js:
290         * TestResultServer/static-dashboards/timeline_explorer.html:
291         * TestResultServer/static-dashboards/treemap.html:
292
293 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
294
295         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
296         https://bugs.webkit.org/show_bug.cgi?id=109404
297
298         Reviewed by Tony Chang.
299
300         Removes all the code related to smartInsertDeleteEnabled and
301         selectTrailingWhitespaceEnabled settings as they will be managed from
302         internals from now on.
303
304         * DumpRenderTree/TestRunner.cpp:
305         (TestRunner::staticFunctions):
306         * DumpRenderTree/TestRunner.h:
307         (TestRunner):
308         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
309         (WebKit):
310         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
311         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
312         (DumpRenderTree):
313         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
314         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
315         (WebTestRunner::WebTestProxy::didStopLoading):
316         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
317         (WebTestRunner::TestRunner::TestRunner):
318         (WebTestRunner::TestRunner::reset):
319         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
320         (TestRunner):
321         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
322         (WebTestRunner::WebPreferences::applyTo): Set default values for
323         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
324         Chromium DRT default values are different from Chromium browser.
325         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
326         * DumpRenderTree/chromium/WebViewHost.cpp:
327         * DumpRenderTree/chromium/WebViewHost.h:
328         (WebViewHost):
329         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
330         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
331         * DumpRenderTree/efl/TestRunnerEfl.cpp:
332         * DumpRenderTree/gtk/DumpRenderTree.cpp:
333         (resetDefaultsToConsistentValues):
334         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
335         * DumpRenderTree/mac/DumpRenderTree.mm:
336         (resetWebViewToConsistentStateBeforeTesting):
337         * DumpRenderTree/mac/TestRunnerMac.mm:
338         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
339         (WebCore::WebPage::resetSettings):
340         * DumpRenderTree/qt/TestRunnerQt.cpp:
341         * DumpRenderTree/qt/TestRunnerQt.h:
342         (TestRunnerQt):
343         * DumpRenderTree/win/DumpRenderTree.cpp:
344         (resetWebViewToConsistentStateBeforeTesting):
345         * DumpRenderTree/win/TestRunnerWin.cpp:
346         * DumpRenderTree/wx/TestRunnerWx.cpp:
347
348 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
349
350         [Qt] Disable DRT on Windows
351
352         Reviewed by Jocelyn Turcotte.
353
354         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
355
356         * qmake/mkspecs/features/configure.prf:
357
358 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
359
360         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
361         https://bugs.webkit.org/show_bug.cgi?id=110728
362
363         Reviewed by Gyuyoung Kim.
364
365         Use the page group to create the view object.
366
367         * MiniBrowser/efl/main.c:
368         (window_create):
369
370 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
371
372         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
373
374         Reviewed by Tor Arne Vestbø.
375
376         The mock versions of these web facing features should be instantiated when
377         running in DumpRenderTree only. In order for them to work, no extra Qt modules
378         such as QtLocation are actually needed.
379
380         This patch decouples enabling device orientation/motion and geolocation from
381         the underlying Qt modules and makes them available in developer builds
382         (!production_build) and backed by mock backends when running in drt.
383
384         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
385         developers the web facing features are always enabled (although requests will
386         time out) and the mock backends are enabled inside DRT, allowing for the layout
387         tests to run with less dependencies.
388
389         In addition this also enables the mock device motion client, which was
390         previously never instantiated.
391
392         * qmake/mkspecs/features/features.prf:
393
394 2013-03-14  Zeno Albisser  <zeno@webkit.org>
395
396         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
397         https://bugs.webkit.org/show_bug.cgi?id=112340
398
399         Reviewed by Simon Hausmann.
400
401         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
402         (DumpRenderTree::dump):
403             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
404         (DumpRenderTree::dumpApplicationCacheQuota):
405         * DumpRenderTree/qt/TestRunnerQt.cpp:
406         (TestRunnerQt::reset):
407         * DumpRenderTree/qt/TestRunnerQt.h:
408         (TestRunnerQt):
409
410 2013-03-14  Zeno Albisser  <zeno@webkit.org>
411
412         [Qt] Port DRT to use TestRunner::dumpAsText()
413         https://bugs.webkit.org/show_bug.cgi?id=112260
414
415         Reviewed by Benjamin Poulain.
416
417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
418         (WebCore::DumpRenderTree::open):
419         (WebCore::methodNameStringForFailedTest):
420             Change parameter from type TestRunnerQt* to TestRunner*.
421         (WebCore::DumpRenderTree::dump):
422             TestRunnerQt::shouldDumpPixels() always returned true in our case.
423             Instead we should rely on TestRunner::generatePixelResults().
424         * DumpRenderTree/qt/TestRunnerQt.cpp:
425         (TestRunnerQt::reset):
426         * DumpRenderTree/qt/TestRunnerQt.h:
427         (TestRunnerQt):
428
429 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
430
431         Implement FontLoader interface
432         https://bugs.webkit.org/show_bug.cgi?id=98395
433
434         Reviewed by Eric Seidel.
435
436         Enable FontLoadEvents runtime flag for TestShell.
437
438         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
439         (WebTestRunner::TestInterfaces::TestInterfaces):
440
441 2013-03-13  Julie Parent  <jparent@chromium.org>
442
443         CLeanup: remove unnecessary call to parseParameters.
444         https://bugs.webkit.org/show_bug.cgi?id=112309
445
446         Reviewed by Ojan Vafai.
447         
448         We call parseCrossDashboardParameters when the dashboard initially
449         loads to set the state required for loadBuildersList, and then we
450         call it again once we are fully done with loading, so there is no
451         reason to call it in the middle of the loading process here.
452
453         * TestResultServer/static-dashboards/loader.js:
454         (.):
455
456 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
457
458         Unreviewed. Now I'm a reviewer :)
459
460         * Scripts/webkitpy/common/config/committers.py:
461
462 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
463
464         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
465         https://bugs.webkit.org/show_bug.cgi?id=112277
466
467         Reviewed by Adam Barth.
468
469         * Scripts/webkitperl/FeatureList.pm:
470         * qmake/mkspecs/features/features.pri:
471
472 2013-03-13  Adam Barth  <abarth@webkit.org>
473
474         run-perf-tests should support content_shell
475         https://bugs.webkit.org/show_bug.cgi?id=112291
476
477         Reviewed by Eric Seidel.
478
479         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
480         (PerfTestsRunner._parse_args):
481
482 2013-03-13  Oliver Hunt  <oliver@apple.com>
483
484         Simplify Checked<> multiplication
485         https://bugs.webkit.org/show_bug.cgi?id=112286
486
487         Reviewed by James Robinson.
488
489         Add tests for multiplication by zero and max to ensure we don't
490         mess them up should we ever make changes to Checked<> in future.
491
492         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
493         (TestWebKitAPI):
494
495 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
496
497         [Qt] Unreviewed prospective Windows build fix
498
499         Do the usual thing, include the moc generated code in the .cpp file instead
500         of compiling it standalone, to ensure that config.h is included, too, and
501         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
502
503         * DumpRenderTree/qt/EventSenderQt.cpp:
504
505 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
506
507         [Qt] Port TestRunner::findString to shared interface
508         https://bugs.webkit.org/show_bug.cgi?id=112147
509
510         Reviewed by Jocelyn Turcotte.
511
512         This patch also removes DumpRenderTree and some other helper classes from
513         the WebCore namespace, to which they do not really belong.
514
515         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
516         (main):
517         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
518         (DumpRenderTree::DumpRenderTree):
519         (DumpRenderTree::~DumpRenderTree):
520         (DumpRenderTree::instance):
521         (DumpRenderTree::setShouldTimeout):
522         * DumpRenderTree/qt/DumpRenderTreeQt.h:
523         (DumpRenderTree):
524         * DumpRenderTree/qt/EventSenderQt.cpp:
525         (EventSender::contextClick):
526         (EventSender::sendEvent):
527         (EventSender::postEvent):
528         * DumpRenderTree/qt/EventSenderQt.h:
529         (EventSender::isGraphicsBased):
530         * DumpRenderTree/qt/TestRunnerQt.cpp:
531         (TestRunnerQt::TestRunnerQt):
532         (TestRunner::findString):
533         (TestRunnerQt::setMockDeviceOrientation):
534         (TestRunnerQt::setGeolocationPermission):
535         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
536         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
537         (TestRunnerQt::setMockGeolocationPosition):
538         * DumpRenderTree/qt/TestRunnerQt.h:
539         (TestRunnerQt):
540
541 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
542
543         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
544         https://bugs.webkit.org/show_bug.cgi?id=112129
545
546         Reviewed by Adam Barth.
547
548         Following Chromium
549         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
550         this is being renamed to better explain what it does.
551
552         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
553
554 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
555
556         [Qt] Unreviewed trivial typo fix
557
558         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
559         TextRunner.h. Thanks Zeno :)
560
561 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
562
563         [Qt] Prepare DRT for transition to shared TestRunner interface
564         https://bugs.webkit.org/show_bug.cgi?id=112144
565
566         Reviewed by Benjamin Poulain.
567
568         Prepare Qt's DRT for a transition from the QObject based TestRunner to
569         the JSC C API based one.
570
571         This is impplemented by instantiating the QObject based testRunner in
572         the global object, then instantiating the JSC C based TestRunner
573         separately and placing it "behind" the QObject based testRunner through
574         injection of the individual functions through proxies. (prototype
575         chaining doesn't work due to the this object and Function.prototype.bind
576         doesn't work due to the native function)
577
578         This allows for porting over method by method by removing the method
579         from the QObject TestRunnerQt and implementing it in the JSC C based
580         TestRunner.
581
582         In order for this to link and run dummy implementations of all the
583         necessary TestRunner functions are provided.
584
585         * DumpRenderTree/qt/DumpRenderTree.pro:
586         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
587         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
588         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
589         (WebCore::DumpRenderTree::initJSObjects):
590         * DumpRenderTree/qt/DumpRenderTreeQt.h:
591         (DumpRenderTree):
592         * DumpRenderTree/qt/TestRunnerQt.cpp:
593         (TestRunner::~TestRunner):
594         (TestRunner::addDisallowedURL):
595         (TestRunner::queueLoad):
596         (TestRunner::removeAllVisitedLinks):
597         (TestRunner::setAcceptsEditing):
598         (TestRunner::simulateLegacyWebNotificationClick):
599         (TestRunner::setWindowIsKey):
600         (TestRunner::setAlwaysAcceptCookies):
601         (TestRunner::addOriginAccessWhitelistEntry):
602         (TestRunner::setWebViewEditable):
603         (TestRunner::clearAllApplicationCaches):
604         (TestRunner::setTextDirection):
605         (TestRunner::notifyDone):
606         (TestRunner::numberOfPendingGeolocationPermissionRequests):
607         (TestRunner::overridePreference):
608         (TestRunner::pathToLocalResource):
609         (TestRunner::removeAllWebNotificationPermissions):
610         (TestRunner::simulateWebNotificationClick):
611         (TestRunner::closeIdleLocalStorageDatabases):
612         (TestRunner::focusWebView):
613         (TestRunner::setBackingScaleFactor):
614         (TestRunner::removeChromeInputField):
615         (TestRunner::addChromeInputField):
616         (TestRunner::originsWithLocalStorage):
617         (TestRunner::deleteAllLocalStorage):
618         (TestRunner::deleteLocalStorageForOrigin):
619         (TestRunner::observeStorageTrackerNotifications):
620         (TestRunner::syncLocalStorage):
621         (TestRunner::windowCount):
622         (TestRunner::setWaitToDump):
623         (TestRunner::waitForPolicyDelegate):
624         (TestRunner::webHistoryItemCount):
625         (TestRunner::showWebInspector):
626         (TestRunner::closeWebInspector):
627         (TestRunner::evaluateInWebInspector):
628         (TestRunner::setSerializeHTTPLoads):
629         (TestRunner::apiTestNewWindowDataLoadBaseURL):
630         (TestRunner::setCustomPolicyDelegate):
631         (TestRunner::setDatabaseQuota):
632         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
633         (TestRunner::resetPageVisibility):
634         (TestRunner::keepWebHistory):
635         (TestRunner::goBack):
636         (TestRunner::originsWithApplicationCache):
637         (TestRunner::applicationCacheDiskUsageForOrigin):
638         (TestRunner::display):
639         (TestRunner::dispatchPendingLoadRequests):
640         (TestRunner::clearPersistentUserStyleSheet):
641         (TestRunner::callShouldCloseOnWebView):
642         (TestRunner::copyDecodedHostName):
643         (TestRunner::clearBackForwardList):
644         (TestRunner::clearAllDatabases):
645         (TestRunner::clearApplicationCacheForOrigin):
646         (TestRunner::apiTestGoToCurrentBackForwardItem):
647         (TestRunner::authenticateSession):
648         (TestRunner::abortModal):
649         (TestRunner::setStorageDatabaseIdleInterval):
650         (TestRunner::setAsynchronousSpellCheckingEnabled):
651         (TestRunner::setXSSAuditorEnabled):
652         (TestRunner::setSpatialNavigationEnabled):
653         (TestRunner::setScrollbarPolicy):
654         (TestRunner::setJavaScriptCanAccessClipboard):
655         (TestRunner::setAutomaticLinkDetectionEnabled):
656         (TestRunner::setUserStyleSheetEnabled):
657         (TestRunner::setUserStyleSheetLocation):
658         (TestRunner::setUseDashboardCompatibilityMode):
659         (TestRunner::setTabKeyCyclesThroughElements):
660         (TestRunner::setSmartInsertDeleteEnabled):
661         (TestRunner::setSelectTrailingWhitespaceEnabled):
662         (TestRunner::setPrivateBrowsingEnabled):
663         (TestRunner::setPluginsEnabled):
664         (TestRunner::setPopupBlockingEnabled):
665         (TestRunner::setMockSpeechInputDumpRect):
666         (TestRunner::setPersistentUserStyleSheetLocation):
667         (TestRunner::setMockGeolocationPosition):
668         (TestRunner::setMockGeolocationPositionUnavailableError):
669         (TestRunner::setMockDeviceOrientation):
670         (TestRunner::setMainFrameIsFirstResponder):
671         (TestRunner::setIconDatabaseEnabled):
672         (TestRunner::setGeolocationPermission):
673         (TestRunner::setDefersLoading):
674         (TestRunner::setCacheModel):
675         (TestRunner::setAuthorAndUserStylesEnabled):
676         (TestRunner::setAllowFileAccessFromFileURLs):
677         (TestRunner::setAppCacheMaximumSize):
678         (TestRunner::setAllowUniversalAccessFromFileURLs):
679         (TestRunner::setApplicationCacheOriginQuota):
680         (TestRunner::denyWebNotificationPermission):
681         (TestRunner::grantWebNotificationPermission):
682         (TestRunner::setValueForUser):
683         (TestRunner::setViewModeMediaFeature):
684         (TestRunner::setPageVisibility):
685         (TestRunner::addMockSpeechInputResult):
686         (TestRunner::removeOriginAccessWhitelistEntry):
687         (TestRunner::addUserScript):
688         (TestRunner::isCommandEnabled):
689         (TestRunner::evaluateScriptInIsolatedWorld):
690         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
691         (TestRunner::copyEncodedHostName):
692         (TestRunner::addUserStyleSheet):
693         (TestRunner::findString):
694         (TestRunner::execCommand):
695         (TestRunner::localStorageDiskUsageForOrigin):
696
697 2013-03-12  Julie Parent  <jparent@chromium.org>
698
699         Cleanup: Move flatten-trie to loader.
700         https://bugs.webkit.org/show_bug.cgi?id=112196
701
702         Reviewed by Dirk Pranke.
703
704         flatten-trie is used only by the loader, so move it there and make it
705         private, rather than global in dashbaord_base. Moved the corresponding
706         unit test from flakiness_dashboard_unittests to loader_unittests.
707         
708         * TestResultServer/static-dashboards/dashboard_base.js:
709         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
710         * TestResultServer/static-dashboards/loader.js:
711         (.):
712         * TestResultServer/static-dashboards/loader_unittests.js:
713
714 2013-03-12  Oliver Hunt  <oliver@apple.com>
715
716         Unbreak api tests
717
718         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
719         (TestWebKitAPI):
720
721 2013-03-12  Tim Horton  <timothy_horton@apple.com>
722
723         Unreviewed, disabling tests for Win EWS.
724
725         win-ews obviously cannot keep up with running tests, it's >300 behind.
726         Probably doesn't help that its (likely) running tests serially.
727
728         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
729         (WinEWS):
730
731 2013-03-12  Tim Horton  <timothy_horton@apple.com>
732
733         Add a --build-directory argument to delete-stale-build-files
734         https://bugs.webkit.org/show_bug.cgi?id=112198
735
736         Reviewed by Ryosuke Niwa.
737
738         * BuildSlaveSupport/delete-stale-build-files:
739         (main): Add --build-directory argument.
740
741 2013-03-12  Oliver Hunt  <oliver@apple.com>
742
743         Appease MSVC
744
745         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
746         (TestWebKitAPI):
747
748 2013-03-12  Oliver Hunt  <oliver@apple.com>
749
750         Add more Checked<> tests
751         https://bugs.webkit.org/show_bug.cgi?id=112190
752
753         Reviewed by Geoffrey Garen.
754
755         Tests!
756
757         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
758         (TestWebKitAPI):
759
760 2013-03-12  Julie Parent  <jparent@chromium.org>
761
762         Cleanup: Move loading complete function into callback, rather than global.
763         https://bugs.webkit.org/show_bug.cgi?id=112167
764
765         Reviewed by Dirk Pranke.
766         
767         Stop calling global functions, pass in proper handler to Loader
768         constructor. Note that the callback is optional, as tests, and
769         some potential dashboards, do not need one.
770
771         * TestResultServer/static-dashboards/dashboard_base.js:
772         * TestResultServer/static-dashboards/loader.js:
773         (.):
774         * TestResultServer/static-dashboards/loader_unittests.js:
775
776 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
777
778         [EFL][WK2] Add popup menu support to MiniBrowser
779         https://bugs.webkit.org/show_bug.cgi?id=108934
780
781         Reviewed by Kenneth Rohde Christiansen.
782
783         Implement popup menu support in MiniBrowser by handling popup_menu_show
784         and popup_menu_hide smart functions on the view and using the Ewk popup
785         menu API.
786
787         * MiniBrowser/efl/main.c:
788         (_Browser_Window):
789         (on_popup_menu_discarded):
790         (on_popup_menu_item_clicked):
791         (popup_menu_populate):
792         (on_popup_menu_show):
793         (on_popup_menu_hide):
794         (window_create): Use calloc() instead of malloc() to allocate memory for
795         Browser_Window. This makes sure all the structs members are initialized
796         to 0 (such as the new elm_popup_menu pointer).
797
798 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
799
800         [GTK] Set up the libPlatformGtk.la library
801         https://bugs.webkit.org/show_bug.cgi?id=111738
802
803         Reviewed by Martin Robinson.
804
805         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
806         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
807         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
808
809 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
810
811         [GTK] Enable Web Audio in development builds
812         https://bugs.webkit.org/show_bug.cgi?id=111831
813
814         Reviewed by Philippe Normand.
815
816         Web Audio is already quite well supported on the GTK port but still has a few issues
817         that must be addressed before it is enabled by default. Despite that it should be enabled
818         in development builds just so we are up-to-date with future feature infrastructure changes.
819         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
820         that's an obvious goal before enabling the feature in release builds.
821
822         * Scripts/webkitperl/FeatureList.pm:
823
824 2013-03-11  Andreas Kling  <akling@apple.com>
825
826         [Mac][WK1] Add support for alert() in MiniBrowser.
827         <http://webkit.org/b/112090>
828
829         Reviewed by Anders Carlsson.
830
831         * MiniBrowser/mac/WK1BrowserWindowController.m:
832         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
833
834 2013-03-11  Julie Parent  <jparent@chromium.org>
835
836         Dashboard cleanup: Create ui.Errors
837         https://bugs.webkit.org/show_bug.cgi?id=111785
838
839         Reviewed by Ojan Vafai.
840         
841         Create ui.Errors for handling errors the dashboards
842         encounter. Loader now has a Error object that it can add to,
843         and individual dashboards can show errors when desired.
844         Currently, only flakiness_db shows errors, but this is 
845         generic and there is no reason why other dbs wouldn't want to
846         show errors.
847
848         * TestResultServer/static-dashboards/dashboard_base.js:
849         (resourceLoadingComplete):
850         * TestResultServer/static-dashboards/flakiness_dashboard.js:
851         (generatePage):
852         * TestResultServer/static-dashboards/loader.js:
853         (.):
854         * TestResultServer/static-dashboards/ui.js:
855         (.):
856
857 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
858
859         Some StringHasher tests are broken because of missing null termination
860         https://bugs.webkit.org/show_bug.cgi?id=111284
861
862         Reviewed by Darin Adler.
863
864         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
865         (TestWebKitAPI): Added null termination since C strings are null-terminated.
866         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
867         the bug caught by it is now fixed.
868
869 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
870
871         Unreviewed, rolling out r145200.
872         http://trac.webkit.org/changeset/145200
873         https://bugs.webkit.org/show_bug.cgi?id=112063
874
875         Broke a couple of unit tests (Requested by zdobersek on
876         #webkit).
877
878         * Scripts/webkitperl/FeatureList.pm:
879
880 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
881
882         [GTK] WebKit2-only build fails
883         https://bugs.webkit.org/show_bug.cgi?id=112033
884
885         Reviewed by Gustavo Noronha Silva.
886
887         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
888         generic part, WebKit1-specific part and WebKit2-specific part.
889         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
890         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
891         directly.
892
893 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
894
895         Adding myself to the committers list.
896
897         Unreviewed.
898
899         * Scripts/webkitpy/common/config/committers.py:
900
901 2013-03-11  Jeff Rogers  <jrogers@rim.com>
902
903         [BlackBerry] Disable MathML support
904         https://bugs.webkit.org/show_bug.cgi?id=111929
905
906         Reviewed by Rob Buis.
907
908         * Scripts/webkitperl/FeatureList.pm:
909
910 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
911
912         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
913         https://bugs.webkit.org/show_bug.cgi?id=111970
914
915         Reviewed by Chris Fleizach.
916
917         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
918         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
919         undefined symbol.
920
921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
922         (WTR::AccessibilityUIElement::supportedActions):
923         (WTR):
924
925 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
926
927         [chromium] Android apk targets should depend directly on Java library targets
928         https://bugs.webkit.org/show_bug.cgi?id=111746
929
930         Reviewed by Eric Seidel.
931
932         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
933         Make DumpRenderTree_apk depend directly on base_java and net_java.
934         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
935         Make TestWebKitAPI_apk depend directly on base_java.
936
937 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
938
939         [chromium] remove obsolete user gesture methods from WebFrame
940         https://bugs.webkit.org/show_bug.cgi?id=111696
941
942         Reviewed by Adam Barth.
943
944         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
945         (WebTestRunner::TestPlugin::handleInputEvent):
946         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
947
948 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
949
950         Unreviewed, add myself to commiters.py.
951
952         * Scripts/webkitpy/common/config/committers.py:
953
954 2013-03-08  Julie Parent  <jparent@chromium.org>
955
956         Cleanup: Remove dead code.
957         https://bugs.webkit.org/show_bug.cgi?id=111900
958
959         Reviewed by Dirk Pranke.
960         
961         Treemap overrides a global function that used to be in 
962         dashboard_base, but was removed months ago in
963         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
964         no caller. 
965
966         * TestResultServer/static-dashboards/treemap.html:
967
968 2013-03-08  Harald Alvestrand  <hta@chromium.org>
969
970         Implemented new API for RTCStatsReport object.
971         https://bugs.webkit.org/show_bug.cgi?id=110333
972
973         Reviewed by Adam Barth.
974
975         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
976         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
977
978 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
979
980         [chromium] use custom freetype on linux asan builds again
981         https://bugs.webkit.org/show_bug.cgi?id=111884
982
983         Reviewed by Tony Chang.
984
985         We no longer need the workaround after chromium r186540.
986
987         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
988
989 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
990
991         Warning about the user not having edit rights on Bugzilla is confusing new contributors
992         https://bugs.webkit.org/show_bug.cgi?id=111798
993
994         Reviewed by Dirk Pranke.
995
996         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
997
998         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
999
1000 2013-03-08  James Robinson  <jamesr@chromium.org>
1001
1002         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
1003         https://bugs.webkit.org/show_bug.cgi?id=111632
1004
1005         Reviewed by Adrienne Walker.
1006
1007         * DumpRenderTree/chromium/WebViewHost.cpp:
1008         (WebViewHost::initializeLayerTreeView):
1009         * DumpRenderTree/chromium/WebViewHost.h:
1010         (WebViewHost):
1011
1012 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
1013
1014         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
1015         https://bugs.webkit.org/show_bug.cgi?id=111297
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1020         (WTR::TestRunner::setViewModeMediaFeature):
1021
1022 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
1023
1024         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
1025         https://bugs.webkit.org/show_bug.cgi?id=111814
1026
1027         Reviewed by Ryosuke Niwa.
1028
1029         Add the needed supportedActions() attribute to WKTestRunner.
1030
1031         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1032         (WTR::AccessibilityUIElement::supportedActions):
1033         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1034         (AccessibilityUIElement):
1035         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1036         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1037         (WTR::AccessibilityUIElement::supportedActions):
1038
1039 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1040
1041         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
1042         https://bugs.webkit.org/show_bug.cgi?id=111851
1043
1044         Reviewed by Kenneth Rohde Christiansen.
1045
1046         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1047         (TestWebKitAPI::TEST):
1048
1049             Fixed WKURLRef instance leaking.
1050
1051 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1052
1053         [EFL] [WK2] Some authentication tests fail in WebKit2
1054         https://bugs.webkit.org/show_bug.cgi?id=106407
1055
1056         Reviewed by Kenneth Rohde Christiansen.
1057
1058         Add patch from upstream for libsoup 2.40 to fix several authentication
1059         test cases.
1060
1061         * efl/jhbuild.modules:
1062         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
1063
1064 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
1065
1066         [GTK] Enable Web Audio in development builds
1067         https://bugs.webkit.org/show_bug.cgi?id=111831
1068
1069         Reviewed by Philippe Normand.
1070
1071         Web Audio is already quite well supported on the GTK port but still has a few issues
1072         that must be addressed before it is enabled by default. Despite that it should be enabled
1073         in development builds just so we are up-to-date with future feature infrastructure changes.
1074         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
1075         that's an obvious goal before enabling the feature in release builds.
1076
1077         * Scripts/webkitperl/FeatureList.pm:
1078
1079 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1080
1081         [chromium] delay clearing the TestRunners until the main view was deleted
1082         https://bugs.webkit.org/show_bug.cgi?id=111823
1083
1084         Reviewed by Eric Seidel.
1085
1086         During WebViewHost::shutdown, we navigate the WebView to about:blank.
1087         This may call into the test runners which assume that the delegate is
1088         always non-NULL.
1089
1090         * DumpRenderTree/chromium/TestShell.cpp:
1091         (TestShell::~TestShell):
1092
1093 2013-03-07  Alan Cutter  <alancutter@chromium.org>
1094
1095         Sheriffbot whois command can't search by full name
1096         https://bugs.webkit.org/show_bug.cgi?id=111825
1097
1098         Reviewed by Eric Seidel.
1099
1100         Allowed multiple arguments to Sheriffbot's whois command.
1101         Updated test expectations.
1102
1103         * Scripts/webkitpy/tool/bot/irc_command.py:
1104         (Whois.execute):
1105         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1106         (IRCCommandTest.test_whois):
1107
1108 2013-03-07  Nils Barth  <nbarth@chromium.org>
1109
1110         Add Nils Barth and Koji Hara to committers.py
1111         https://bugs.webkit.org/show_bug.cgi?id=111806
1112
1113         Reviewed by Eric Seidel.
1114
1115         * Scripts/webkitpy/common/config/committers.py:
1116
1117 2013-03-07  Glenn Adams  <glenn@skynav.com>
1118
1119         run-pert-tests should have a --test-runner-count option
1120         https://bugs.webkit.org/show_bug.cgi?id=111726
1121
1122         Reviewed by Ryosuke Niwa.
1123
1124         Add --test-runner-count option to run-perf-tests, with default value of 4.
1125         This option allows command line configuration of the number of times to invoke
1126         the test runner (serially, not in parallel) when running a specific test in
1127         a test set.
1128
1129         * Scripts/webkitpy/performance_tests/perftest.py:
1130         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
1131         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
1132         (PerfTest.run): Rename process_run_count to test_runner_count.
1133         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
1134         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
1135         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
1136         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
1137         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1138         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
1139         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
1140         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1141         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
1142         (MainTest.test_run_with_repeat):
1143         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
1144         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1145         (MainTest.test_default_args): Add test for default option argument values.
1146         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
1147
1148 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
1149
1150         Add myself to reviewers.py
1151         https://bugs.webkit.org/show_bug.cgi?id=111757
1152
1153         Reviewed by Eric Seidel.
1154
1155         * Scripts/webkitpy/common/config/committers.py:
1156
1157 2013-03-07  Glenn Adams  <glenn@skynav.com>
1158
1159         run-perf-tests should have a --repeat option
1160         https://bugs.webkit.org/show_bug.cgi?id=100030
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         Add --repeat option to run-perf-tests, with default value of 1. When greater
1165         than 1, runs test set specified number of times. Note that multiple runs are
1166         not aggregated for statistical purposes.
1167
1168         Incidentally fixed typo: s/suceeds/succeeds/.
1169
1170         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1171         (PerfTestsRunner._parse_args): Add repeat option.
1172         (PerfTestsRunner.run): Add outer repeat loop.
1173         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
1174         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
1175         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1176         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
1177         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
1178         (MainTest.test_run_with_json_output): Fix typo.
1179         (MainTest.test_run_with_description): Fix typo.
1180         (MainTest.test_run_respects_no_results): Fix typo.
1181         (MainTest.test_run_with_slave_config_json): Fix typo.
1182         (MainTest.test_run_with_multiple_repositories): Fix typo.
1183         (MainTest.test_run_with_upload_json): Fix typo.
1184         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
1185         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
1186         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1187         (MainTest.test_parse_args): Add test for repeat option parsing.
1188
1189 2013-03-07  Julie Parent  <jparent@chromium.org>
1190
1191         showAllRuns checkbox no longer works on the stats dashboard
1192         https://bugs.webkit.org/show_bug.cgi?id=111673
1193
1194         Reviewed by Ojan Vafai.
1195
1196         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
1197         so we were trying to index into an undefined object.
1198         
1199         * TestResultServer/static-dashboards/dashboard_base.js:
1200         (invalidateQueryParameters):
1201
1202 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
1203
1204         [Chromium] Update #include for WebStorageNamespace.h
1205         https://bugs.webkit.org/show_bug.cgi?id=111748
1206
1207         Reviewed by Adam Barth.
1208
1209         In anticipation of removing
1210         WK/chromium/public/WebStorageNamespace.h (once downstream
1211         references have been updated)
1212
1213         * DumpRenderTree/chromium/WebViewHost.cpp:
1214
1215 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1216
1217         run-perf-tests fails due to svn_revision not working on a pure git clone
1218         https://bugs.webkit.org/show_bug.cgi?id=110839
1219
1220         Reviewed by Ryosuke Niwa.
1221
1222         Previously we would call git svn find-rev to look up the commit for
1223         a given revision, and that'll hang in a pure git checkout.
1224
1225         This patch changes the way we look up svn revisions in a git
1226         repository to use git log --grep 'git-svn-id', which is much faster
1227         than grepping ourselves. It also renames timestamp_of_latest_commit()
1228         to timestamp_of_revision() in order to accurately reflect what
1229         the method is doing. Note that this patch only changes the logic
1230         inside latest_revision() and svn_revision(). I'll file a separate
1231         bug to change git_commit_from_svn_revision().
1232
1233         This patch also contains some fixes to unit tests that had bit-rotted
1234         or were otherwise fragile, so that test-webkitpy --all would pass
1235         cleanly, and a fix to outputcapture so that
1236         test-webkitpy -p would work correctly again.
1237
1238         * Scripts/webkitpy/common/checkout/scm/git.py:
1239         (Git.svn_revision):
1240         (Git.timestamp_of_revision):
1241         * Scripts/webkitpy/common/checkout/scm/scm.py:
1242         (SCM.svn_revision):
1243         (SCM.timestamp_of_revision):
1244         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1245         (MockSCM.timestamp_of_revision):
1246         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1247         (_shared_test_commit_with_message):
1248         (test_commit_without_authorization):
1249         (test_timestamp_of_revision):
1250         * Scripts/webkitpy/common/checkout/scm/svn.py:
1251         (SVN.timestamp_of_revision):
1252         * Scripts/webkitpy/common/system/outputcapture.py:
1253           Importing unittest2 directly may not be safe if this module is
1254           imported before the autoinstaller gets a chance to set things up
1255           properly. We don't actually need unittest2 here.
1256         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1257         (PerfTestsRunner._generate_results_dict):
1258
1259 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1260
1261         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
1262         https://bugs.webkit.org/show_bug.cgi?id=111756
1263
1264         Reviewed by Kenneth Rohde Christiansen.
1265
1266         Bump libsoup to v2.40.3 to fix the regressions introduced by
1267         previous v2.40.0 bump.
1268
1269         * efl/jhbuild.modules:
1270
1271 2013-03-07  Roger Fong  <roger_fong@apple.com>
1272
1273         Re-enable Win EWS tests.
1274
1275         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1276         (WinEWS):
1277
1278 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1279
1280         [nrwt] handle corrupt http server pid files cleanly
1281         https://bugs.webkit.org/show_bug.cgi?id=111628
1282
1283         Reviewed by Eric Seidel.
1284
1285         If the pid file from a previous http server is corrupt for some
1286         reason, NRWT will just raise errors and not clean it up or recover.
1287         This patch fixes that to at least delete the pid file and
1288         not throw; not that we may still have stale http servers left on
1289         the system, since there's no way to know which pid to kill if
1290         the file was corrupted.
1291
1292         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1293         (HttpServerBase.start):
1294         (HttpServerBase.stop):
1295         (HttpServerBase._remove_pid_file):
1296         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
1297         (TestHttpServerBase):
1298         (TestHttpServerBase.test_corrupt_pid_file):
1299
1300 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
1301
1302         AX: Can't activate links with VoiceOver in Safari
1303         https://bugs.webkit.org/show_bug.cgi?id=111755
1304
1305         Reviewed by Tim Horton.
1306
1307         * DumpRenderTree/AccessibilityUIElement.cpp:
1308         (supportedActionsCallback):
1309         (AccessibilityUIElement::getJSClass):
1310         * DumpRenderTree/AccessibilityUIElement.h:
1311         (AccessibilityUIElement):
1312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1313         (AccessibilityUIElement::supportedActions):
1314
1315 2013-03-07  Roger Fong  <roger_fong@apple.com>
1316
1317         Windows debug layout tests are crashing like crazy again.
1318         Disable tests on Win EWS bots temporarily.
1319
1320         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1321         (WinEWS):
1322
1323 2013-03-07  Roger Fong  <roger_fong@apple.com>
1324
1325         Make EWS bots build and test in release.
1326
1327         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1328         (WinEWS):
1329         * Scripts/webkitpy/tool/steps/runtests.py:
1330         (RunTests.run):
1331
1332 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1333
1334         [chromium] don't track the top loading frame if no layout test is currently running
1335         https://bugs.webkit.org/show_bug.cgi?id=111716
1336
1337         Reviewed by Kentaro Hara.
1338
1339         In DRT, we synchronously stop the test and start loading the next test
1340         URL. However, in content_shell, this happens asynchronously. It's
1341         important that the top loading frame is not changed due to stray
1342         navigation events before the next test starts.
1343
1344         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1345         (WebTestRunner::TestRunner::setTopLoadingFrame):
1346
1347 2013-03-06  Julie Parent  <jparent@chromium.org>
1348
1349         Dashboard cleanup: Move all dashboard ui related code into ui.js.
1350         https://bugs.webkit.org/show_bug.cgi?id=111621
1351
1352         Reviewed by Ojan Vafai.
1353         
1354         Creates ui.js, a package for the common UI code the various
1355         dashboards use. HTML generation is now in the ui.html namespace
1356         and popup handling is in ui.popup.
1357         Also moves the event listening for popups to ui.popup.show and
1358         removes it on ui.popup.hid rather than having listener always
1359         around.
1360
1361         * TestResultServer/static-dashboards/aggregate_results.html:
1362         * TestResultServer/static-dashboards/dashboard_base.js:
1363         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1364         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1365         (showPopupForBuild):
1366         (htmlForNavBar):
1367         (generatePageForIndividualTests.if):
1368         (generatePageForIndividualTests):
1369         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
1370         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1371         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1372         * TestResultServer/static-dashboards/run-unittests.html:
1373         * TestResultServer/static-dashboards/timeline_explorer.html:
1374         * TestResultServer/static-dashboards/treemap.html:
1375         * TestResultServer/static-dashboards/ui.js: Added.
1376         (.):
1377
1378 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
1379
1380         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
1381         https://bugs.webkit.org/show_bug.cgi?id=110584
1382
1383         Reviewed by Gyuyoung Kim.
1384
1385         Adds missing implementation of AccessibilityControllerEfl
1386         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
1387         so that it can make accessibilityController as a js object.
1388
1389         * DumpRenderTree/AccessibilityController.h:
1390         (AccessibilityController):
1391         * DumpRenderTree/AccessibilityUIElement.h:
1392         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1393         (AccessibilityController::childElementById): Moved declaration to base class.
1394         Implementation can be shared among other ports.
1395         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
1396         (AccessibilityController::focusedElement):
1397         (AccessibilityController::rootElement):
1398         (AccessibilityController::accessibleElementById):
1399         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
1400         (AccessibilityUIElement::helpText):
1401         * DumpRenderTree/efl/CMakeLists.txt:
1402         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1403         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1404         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1405         (DumpRenderTreeChrome::onWindowObjectCleared):
1406         (DumpRenderTreeChrome::accessibilityController):
1407         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1408         (DumpRenderTreeChrome):
1409         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1410
1411 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
1412
1413         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
1414         https://bugs.webkit.org/show_bug.cgi?id=42696
1415
1416         Reviewed by Andreas Kling.
1417
1418         * DumpRenderTree/TestRunner.cpp:
1419         (TestRunner::staticFunctions):
1420         * DumpRenderTree/TestRunner.h:
1421         (TestRunner):
1422         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1424         (WebTestRunner::TestRunner::TestRunner):
1425         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1426         (TestRunner):
1427         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1428         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1429         * DumpRenderTree/mac/TestRunnerMac.mm:
1430         * DumpRenderTree/qt/TestRunnerQt.cpp:
1431         * DumpRenderTree/qt/TestRunnerQt.h:
1432         (TestRunnerQt):
1433         * DumpRenderTree/win/TestRunnerWin.cpp:
1434         * DumpRenderTree/wx/TestRunnerWx.cpp:
1435
1436 2013-03-06  Roger Fong  <roger_fong@apple.com>
1437
1438         Re-enable WinEWS test and decrease iterations before clean build back to 10.
1439
1440         * EWSTools/start-queue-win.sh:
1441         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1442         (WinEWS):
1443
1444 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
1445
1446         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
1447         https://bugs.webkit.org/show_bug.cgi?id=82866
1448
1449         Reviewed by Martin Robinson.
1450
1451         * Scripts/run-gtk-tests:
1452         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
1453         it is passing now.
1454
1455 2013-03-06  Julie Parent  <jparent@chromium.org>
1456
1457         Dashboard cleanup: remove dashboard time logging.
1458         https://bugs.webkit.org/show_bug.cgi?id=111608
1459
1460         Reviewed by Dirk Pranke.
1461
1462         Remove logTime.  It was never accurate, and the dev tools
1463         have better ways to measure this if anyone cares to look
1464         into dashboard perf.
1465         
1466         * TestResultServer/static-dashboards/dashboard_base.js:
1467         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1468         (processTestRunsForBuilder):
1469         (appendHTML):
1470
1471 2013-03-06  Tony Chang  <tony@chromium.org>
1472
1473         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1474         https://bugs.webkit.org/show_bug.cgi?id=111509
1475
1476         Reviewed by Dirk Pranke.
1477
1478         Add DumpRenderTree.pak to DumpRenderTree.app again.
1479
1480         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1481
1482 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
1483
1484         [chromium] introduce WebUserGestureIndicator
1485         https://bugs.webkit.org/show_bug.cgi?id=111531
1486
1487         Reviewed by Adam Barth.
1488
1489         * DumpRenderTree/chromium/WebViewHost.cpp:
1490         (WebViewHost::createView):
1491
1492 2013-03-06  Alan Cutter  <alancutter@chromium.org>
1493
1494         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
1495         https://bugs.webkit.org/show_bug.cgi?id=73482
1496
1497         Reviewed by Ryosuke Niwa.
1498
1499         Added input checking to the UpdateChromiumDEPS step.
1500         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
1501
1502         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
1503         (RollChromiumDEPS):
1504         (RollChromiumDEPS._parse_args):
1505         (RollChromiumDEPS.execute):
1506         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
1507         (IRCCommandTest.test_roll_chromium_deps):
1508         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
1509         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1510         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
1511         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
1512         (UpdateChromiumDEPS._fetch_last_known_good_revision):
1513         (UpdateChromiumDEPS):
1514         (UpdateChromiumDEPS._parse_revision_number):
1515         (UpdateChromiumDEPS._validate_revisions):
1516         (UpdateChromiumDEPS.run):
1517         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
1518         (UpdateChromiumDEPSTest):
1519         (UpdateChromiumDEPSTest.test_parse_revision_number):
1520         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
1521         (RollChromiumDEPS):
1522         (PostChromiumDEPSRoll):
1523
1524 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
1525
1526         [Qt][MiniBrowser] Touch mocking broken for chained getures
1527         https://bugs.webkit.org/show_bug.cgi?id=111430
1528
1529         Reviewed by Jocelyn Turcotte.
1530
1531         Make it possible again to use touch mocking to test gesture chains
1532         like pan->pinch->pan->pinch without lifting the primary "finger".
1533         For this to work we need to track the pressed mouse buttons and
1534         only synthesize touch release events when the ctrl key is released
1535         if no mouse button is pressed. Else the pressed mouse button(s)
1536         should result in a stationary touch point in a touch update event.
1537         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
1538         to check for the state of the ctrl key modifier instead of getting
1539         it from the mouse events.
1540
1541         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1542         (MiniBrowserApplication::MiniBrowserApplication):
1543         (MiniBrowserApplication::notify):
1544
1545 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1546
1547         [chromium] don't use custom freetype on linux asan for now
1548         https://bugs.webkit.org/show_bug.cgi?id=111516
1549
1550         Unreviewed, build fix.
1551
1552         Turns out the custom lib is getting picked up by other binaries
1553         on our bot, which is bad.
1554
1555         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1556
1557 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1558
1559         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1560         https://bugs.webkit.org/show_bug.cgi?id=111509
1561
1562         Unreviewed, build fix.
1563
1564         Actually comment out the flag :(.
1565
1566         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1567
1568 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1569
1570         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1571         https://bugs.webkit.org/show_bug.cgi?id=111509
1572
1573         Unreviewed, build fix.
1574
1575         r144863 appears to have broken the xcode build; I'm temporarily
1576         trying this instead, and if this doesn't work, I'll revert the
1577         other changes.
1578
1579         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1580
1581 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1582
1583         [chromium] build a DumpRenderTree.pak even on windows
1584         https://bugs.webkit.org/show_bug.cgi?id=111504
1585
1586         Reviewed by Tony Chang.
1587
1588         The Chromium Aura build uses the default theme to draw
1589         controls, and that theme requires the ui ResourceBundle
1590         to be initialized. On every other platform, we build
1591         a DumpRenderTree.pak that works for this, but on Windows we
1592         still compile the resources directly into DRT. As a first step,
1593         let's build the pak file. I will then need to land a patch
1594         in Chromium to actually load it. Then I can go back and move
1595         the resources over to just use the .pak file and no longer need
1596         the .rc's.
1597
1598         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1599
1600 2013-03-05  Julie Parent  <jparent@chromium.org>
1601         Dashboard cleanup: move string utilities into their own namespace.
1602         
1603         https://bugs.webkit.org/show_bug.cgi?id=111485
1604
1605         Reviewed by Ojan Vafai.
1606         
1607         One of many pieces to clean up dashboard_base.
1608         
1609         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
1610
1611         * TestResultServer/static-dashboards/aggregate_results.html:
1612         * TestResultServer/static-dashboards/dashboard_base.js:
1613         (isTreeMap):
1614         (isFlakinessDashboard):
1615         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1616         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1617         (determineWKPlatform):
1618         (chromiumPlatform):
1619         (platformAndBuildType):
1620         (substringList):
1621         (individualTestsForSubstringList):
1622         (filterBugs):
1623         (populateExpectationsData):
1624         (processMissingTestsWithExpectations):
1625         (processMissingAndExtraExpectations):
1626         (htmlForSingleTestRow):
1627         (.dummyNode.onload):
1628         (expectationsTitle):
1629         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1630         * TestResultServer/static-dashboards/run-unittests.html:
1631         * TestResultServer/static-dashboards/string.js: Added.
1632         * TestResultServer/static-dashboards/timeline_explorer.html:
1633         * TestResultServer/static-dashboards/treemap.html:
1634
1635 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
1636
1637         [EFL] Build break with latest EFL libraries
1638         https://bugs.webkit.org/show_bug.cgi?id=111028
1639
1640         Reviewed by Dirk Pranke.
1641
1642         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
1643         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1644         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1645
1646 2013-03-05  Roger Fong  <roger_fong@apple.com>
1647
1648         Increase number of WinEWS iterations to 20.
1649         Don't reboot after each iteration set.
1650         Make EWS bots just build temporarily so that the queue catches up again.
1651
1652         * EWSTools/start-queue-win.sh:
1653         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1654         (WinEWS):
1655
1656 2013-03-04  James Robinson  <jamesr@chromium.org>
1657
1658         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
1659         https://bugs.webkit.org/show_bug.cgi?id=111386
1660
1661         Reviewed by Adrienne Walker.
1662
1663         * DumpRenderTree/chromium/TestShell.cpp:
1664         (TestShell::initialize):
1665
1666 2013-03-05  Min Qin  <qinmin@chromium.org>
1667
1668         Copy dictionary to the external storage before running layout test on android
1669         https://bugs.webkit.org/show_bug.cgi?id=111480
1670
1671         Reviewed by Adam Barth.
1672
1673         TestWebKitPlatformSupport now needs to read an external dictionary file.
1674         This file does not exist on the device. We need to copy it before running layout tests.
1675
1676         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1677         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1678         (ChromiumAndroidDriver._push_platform_resources):
1679
1680 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1681
1682         [chromium] DRT crashes in an Aura/Win build
1683         https://bugs.webkit.org/show_bug.cgi?id=111394
1684
1685         Reviewed by Tony Chang.
1686
1687         When building (and running) with use_aura=1, we assume that
1688         we're using the default theme engine, but DRT creates the
1689         DRTWin theme engine and overwrites the default, leading to crashes
1690         in basically every test from the mismatch.
1691
1692         This fix gets us down to at least "lots of crashes" :).
1693
1694         * DumpRenderTree/chromium/TestShellWin.cpp:
1695         (platformInit):
1696
1697 2013-03-05  Eric Seidel  <eric@webkit.org>
1698
1699         Add html-parser-threaded perf test now that the threaded parser is enabled by default
1700         https://bugs.webkit.org/show_bug.cgi?id=111200
1701
1702         Reviewed by Ryosuke Niwa.
1703
1704         Had to teach run-perf-tests to ignore one more warning.
1705
1706         * Scripts/webkitpy/performance_tests/perftest.py:
1707         (PerfTest):
1708
1709 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1710
1711         Update list of builders for test results server
1712         https://bugs.webkit.org/show_bug.cgi?id=111166
1713
1714         Reviewed by Ojan Vafai.
1715
1716         * TestResultServer/static-dashboards/builders.jsonp:
1717
1718 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1719
1720         [GTK] Move basic dependency installation to a script
1721         https://bugs.webkit.org/show_bug.cgi?id=110692
1722
1723         Reviewed by Gustavo Noronha Silva.
1724
1725         * gtk/install-dependencies: Added. A Script which installs all dependencies
1726         necessary for building for Debian-based distributions and Fedora.
1727
1728 2013-03-05  James Robinson  <jamesr@chromium.org>
1729
1730         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1731         https://bugs.webkit.org/show_bug.cgi?id=111440
1732
1733         Reviewed by Adrienne Walker.
1734
1735         Remove unnecessary WebCompositorSupport::shutdown call
1736
1737         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1738         (main):
1739
1740 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1741
1742         Unreviewed build fix.
1743
1744         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1745
1746 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1747
1748         [Qt][MiniBrowser] Improve the update of touch indicators
1749         https://bugs.webkit.org/show_bug.cgi?id=111429
1750
1751         Reviewed by Jocelyn Turcotte.
1752
1753         MiniBrowserApplication::sendTouchEvent sends an empty list
1754         to BrowserWindow::updateVisualMockTouchPoints if the control
1755         button is released, in which case the touch indicators should
1756         be hidden so that we never end up with a leftover indicator
1757         sticking on the screen.
1758         This patch also simplifies the lookup of the indicator items by
1759         replacing the findChild search in the item tree with a QHash
1760         that stores the touch ID's and the pointers to the corresponding
1761         indicator items.
1762
1763         * MiniBrowser/qt/BrowserWindow.cpp:
1764         (BrowserWindow::updateVisualMockTouchPoints):
1765         * MiniBrowser/qt/BrowserWindow.h:
1766         (BrowserWindow):
1767
1768 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1769
1770         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1771         https://bugs.webkit.org/show_bug.cgi?id=81042
1772
1773         Reviewed by Enrica Casucci.
1774
1775         Add setAsynchronousSpellCheckingEnabled implementation for
1776         WebKitTestRunner to have the possibility to test asynchronous
1777         spell checking implementation from bug 109577.
1778
1779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1781         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1783         * WebKitTestRunner/TestController.cpp:
1784         (WTR::TestController::resetStateToConsistentValues):
1785
1786 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1787
1788         MediaStream API: Add the getStreamById method on RTCPeerConnection
1789         https://bugs.webkit.org/show_bug.cgi?id=111311
1790
1791         Reviewed by Adam Barth.
1792
1793         Changing mocks to be more realistic.
1794
1795         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1796         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1797         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1798         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1799         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1800
1801 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1802
1803         Add content shell bots to garden-o-matic for general failurse
1804         https://bugs.webkit.org/show_bug.cgi?id=111168
1805
1806         Reviewed by Adam Barth.
1807
1808         All but the WebKit (Content Shell) Android bot is stable enough. While
1809         they're not green yet, there must not be any non-layout test failures on
1810         them.
1811
1812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1813         (.):
1814
1815 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1816
1817         [chromium] remove deprecated WebTestRunner::setFocus API
1818         https://bugs.webkit.org/show_bug.cgi?id=111354
1819
1820         Reviewed by James Robinson.
1821
1822         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1823         (WebTestDelegate):
1824
1825 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1826
1827         Run the bindings generation tests on EWS and CQ bots
1828         https://bugs.webkit.org/show_bug.cgi?id=111358
1829
1830         Reviewed by Adam Barth.
1831
1832         The tests are super fast and not flaky.
1833
1834         * Scripts/webkitpy/common/config/ports.py:
1835         (DeprecatedPort.run_bindings_tests_command):
1836         * Scripts/webkitpy/common/config/ports_mock.py:
1837         (MockPort.run_webkit_tests_command):
1838         (MockPort):
1839         (MockPort.run_bindings_tests_command):
1840         * Scripts/webkitpy/tool/commands/download_unittest.py:
1841         * Scripts/webkitpy/tool/steps/runtests.py:
1842         (RunTests.run):
1843         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1844         (RunTestsTest.test_webkit_run_unit_tests):
1845         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1846
1847 2013-03-04  Eric Seidel  <eric@webkit.org>
1848
1849         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1850         https://bugs.webkit.org/show_bug.cgi?id=111384
1851
1852         Reviewed by Ryosuke Niwa.
1853
1854         Sometimes I want to know why various LayoutTests are slow
1855         without having to convert them into PerformanceTests in order
1856         to use our fancy profiling.  The Driver already knows how to
1857         do the right thing, we just need to expose the options to the user.
1858
1859         Handling of these options is already unittested in the perftests_unittest.
1860
1861         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1862         (parse_args):
1863
1864 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1865
1866         check-webkit-style says "Have to enable auto props in the subversion config file"
1867         https://bugs.webkit.org/show_bug.cgi?id=107724
1868
1869         Reviewed by Tony Chang.
1870
1871         Added a standard svn config file for WebKit developers to use.
1872         Updated the style and commit queue bot build scripts to load this file.
1873
1874         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1875         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1876         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1877         * svn-config: Added.
1878
1879 2013-03-04  James Robinson  <jamesr@chromium.org>
1880
1881         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1882         https://bugs.webkit.org/show_bug.cgi?id=111285
1883
1884         Reviewed by Adrienne Walker.
1885
1886         This removes the need for WebCompositorSupport::initialize and exposes
1887         slightly fewer entry points across the repository boundary.
1888
1889         * DumpRenderTree/chromium/TestShell.cpp:
1890         (TestShell::initialize):
1891         * DumpRenderTree/chromium/TestShell.h:
1892         (TestShell::webCompositorThread):
1893         (TestShell):
1894         * DumpRenderTree/chromium/WebViewHost.cpp:
1895         (WebViewHost::initializeLayerTreeView):
1896
1897 2013-03-04  Roger Fong  <roger_fong@apple.com>
1898
1899         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
1900
1901         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1902
1903 2013-03-04  David Kilzer  <ddkilzer@apple.com>
1904
1905         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
1906
1907             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
1908                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
1909                                         ^         ~~~~~~~~~~~~~~~~~~~~~
1910             1 error generated.
1911
1912         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
1913         AccessibilityCommonMac.h.
1914
1915 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1916
1917         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
1918         https://bugs.webkit.org/show_bug.cgi?id=109828
1919
1920         Reviewed by Kenneth Rohde Christiansen.
1921
1922         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
1923         callbacks.
1924
1925         * TestWebKitAPI/CMakeLists.txt:
1926
1927             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
1928             considered.
1929
1930         * TestWebKitAPI/PlatformEfl.cmake:
1931         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
1932         (TestWebKitAPI):
1933         (TestWebKitAPI::didFinishLoadForFrame):
1934         (TestWebKitAPI::setPageLoaderClient):
1935         (TestWebKitAPI::webProcessCrashed):
1936         (TestWebKitAPI::webProcessDidRelaunch):
1937         (TestWebKitAPI::setViewClient):
1938         (TestWebKitAPI::TEST):
1939
1940 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
1941
1942         AX: Upstream iOS Accessibility DumpRenderTree changes
1943         https://bugs.webkit.org/show_bug.cgi?id=111220
1944
1945         Reviewed by David Kilzer.
1946
1947         Upstream the iOS changes for accessibility in DumpRenderTree.
1948
1949         * DumpRenderTree/AccessibilityUIElement.cpp:
1950         (headerElementAtIndexCallback):
1951         (linkedElementCallback):
1952         (elementsForRangeCallback):
1953         (increaseTextSelectionCallback):
1954         (decreaseTextSelectionCallback):
1955         (assistiveTechnologySimulatedFocusCallback):
1956         (stringForSelectionCallback):
1957         (getIPhoneLabelCallback):
1958         (getIPhoneHintCallback):
1959         (getIPhoneValueCallback):
1960         (getIPhoneIdentifierCallback):
1961         (getIPhoneTraitsCallback):
1962         (getIPhoneIsElementCallback):
1963         (getIPhoneElementTextPositionCallback):
1964         (getIPhoneElementTextLengthCallback):
1965         (AccessibilityUIElement::getJSClass):
1966         * DumpRenderTree/AccessibilityUIElement.h:
1967         (AccessibilityUIElement):
1968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1969         * DumpRenderTree/ios: Added.
1970         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1971         (AccessibilityController::AccessibilityController):
1972         (AccessibilityController::~AccessibilityController):
1973         (AccessibilityController::elementAtPoint):
1974         (AccessibilityController::focusedElement):
1975         (AccessibilityController::rootElement):
1976         (findAccessibleObjectById):
1977         (AccessibilityController::accessibleElementById):
1978         (AccessibilityController::setLogFocusEvents):
1979         (AccessibilityController::setLogScrollingStartEvents):
1980         (AccessibilityController::setLogValueChangeEvents):
1981         (AccessibilityController::setLogAccessibilityEvents):
1982         (AccessibilityController::addNotificationListener):
1983         (AccessibilityController::removeNotificationListener):
1984         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1985         (AccessibilityUIElement::AccessibilityUIElement):
1986         (AccessibilityUIElement::~AccessibilityUIElement):
1987         (concatenateAttributeAndValue):
1988         (AccessibilityUIElement::iphoneLabel):
1989         (AccessibilityUIElement::iphoneHint):
1990         (AccessibilityUIElement::iphoneValue):
1991         (AccessibilityUIElement::iphoneIdentifier):
1992         (AccessibilityUIElement::iphoneTraits):
1993         (AccessibilityUIElement::iphoneIsElement):
1994         (AccessibilityUIElement::iphoneElementTextPosition):
1995         (AccessibilityUIElement::iphoneElementTextLength):
1996         (AccessibilityUIElement::url):
1997         (AccessibilityUIElement::x):
1998         (AccessibilityUIElement::y):
1999         (AccessibilityUIElement::width):
2000         (AccessibilityUIElement::height):
2001         (AccessibilityUIElement::clickPointX):
2002         (AccessibilityUIElement::clickPointY):
2003         (AccessibilityUIElement::getChildren):
2004         (AccessibilityUIElement::getChildrenWithRange):
2005         (AccessibilityUIElement::childrenCount):
2006         (AccessibilityUIElement::elementAtPoint):
2007         (AccessibilityUIElement::indexOfChild):
2008         (AccessibilityUIElement::getChildAtIndex):
2009         (AccessibilityUIElement::headerElementAtIndex):
2010         (AccessibilityUIElement::linkedElement):
2011         (AccessibilityUIElement::linkedUIElementAtIndex):
2012         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2013         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2014         (AccessibilityUIElement::disclosedRowAtIndex):
2015         (AccessibilityUIElement::selectedRowAtIndex):
2016         (AccessibilityUIElement::rowAtIndex):
2017         (AccessibilityUIElement::titleUIElement):
2018         (AccessibilityUIElement::parentElement):
2019         (AccessibilityUIElement::disclosedByRow):
2020         (AccessibilityUIElement::increaseTextSelection):
2021         (AccessibilityUIElement::decreaseTextSelection):
2022         (AccessibilityUIElement::stringForSelection):
2023         (AccessibilityUIElement::stringForRange):
2024         (AccessibilityUIElement::attributedStringForRange):
2025         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2026         (AccessibilityUIElement::elementsForRange):
2027         (AccessibilityUIElement::getLinkedUIElements):
2028         (AccessibilityUIElement::getDocumentLinks):
2029         (AccessibilityUIElement::attributesOfLinkedUIElements):
2030         (AccessibilityUIElement::attributesOfDocumentLinks):
2031         (AccessibilityUIElement::attributesOfChildren):
2032         (AccessibilityUIElement::allAttributes):
2033         (AccessibilityUIElement::stringAttributeValue):
2034         (AccessibilityUIElement::isPressActionSupported):
2035         (AccessibilityUIElement::isIncrementActionSupported):
2036         (AccessibilityUIElement::isDecrementActionSupported):
2037         (AccessibilityUIElement::boolAttributeValue):
2038         (AccessibilityUIElement::isAttributeSettable):
2039         (AccessibilityUIElement::isAttributeSupported):
2040         (AccessibilityUIElement::parameterizedAttributeNames):
2041         (AccessibilityUIElement::role):
2042         (AccessibilityUIElement::subrole):
2043         (AccessibilityUIElement::roleDescription):
2044         (AccessibilityUIElement::title):
2045         (AccessibilityUIElement::description):
2046         (AccessibilityUIElement::orientation):
2047         (AccessibilityUIElement::stringValue):
2048         (AccessibilityUIElement::language):
2049         (AccessibilityUIElement::helpText):
2050         (AccessibilityUIElement::intValue):
2051         (AccessibilityUIElement::minValue):
2052         (AccessibilityUIElement::maxValue):
2053         (AccessibilityUIElement::valueDescription):
2054         (AccessibilityUIElement::insertionPointLineNumber):
2055         (AccessibilityUIElement::isEnabled):
2056         (AccessibilityUIElement::isRequired):
2057         (AccessibilityUIElement::isFocused):
2058         (AccessibilityUIElement::isSelected):
2059         (AccessibilityUIElement::isExpanded):
2060         (AccessibilityUIElement::isChecked):
2061         (AccessibilityUIElement::hierarchicalLevel):
2062         (AccessibilityUIElement::ariaIsGrabbed):
2063         (AccessibilityUIElement::ariaDropEffects):
2064         (AccessibilityUIElement::lineForIndex):
2065         (AccessibilityUIElement::boundsForRange):
2066         (AccessibilityUIElement::attributesOfColumnHeaders):
2067         (AccessibilityUIElement::attributesOfRowHeaders):
2068         (AccessibilityUIElement::attributesOfColumns):
2069         (AccessibilityUIElement::attributesOfRows):
2070         (AccessibilityUIElement::attributesOfVisibleCells):
2071         (AccessibilityUIElement::attributesOfHeader):
2072         (AccessibilityUIElement::rowCount):
2073         (AccessibilityUIElement::columnCount):
2074         (AccessibilityUIElement::indexInTable):
2075         (AccessibilityUIElement::rowIndexRange):
2076         (AccessibilityUIElement::columnIndexRange):
2077         (AccessibilityUIElement::cellForColumnAndRow):
2078         (AccessibilityUIElement::selectedTextRange):
2079         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2080         (AccessibilityUIElement::setSelectedTextRange):
2081         (AccessibilityUIElement::increment):
2082         (AccessibilityUIElement::decrement):
2083         (AccessibilityUIElement::showMenu):
2084         (AccessibilityUIElement::press):
2085         (AccessibilityUIElement::accessibilityValue):
2086         (AccessibilityUIElement::documentEncoding):
2087         (AccessibilityUIElement::documentURI):
2088         (_accessibilityNotificationCallback):
2089         (AccessibilityUIElement::addNotificationListener):
2090         (AccessibilityUIElement::removeNotificationListener):
2091         (AccessibilityUIElement::isFocusable):
2092         (AccessibilityUIElement::isSelectable):
2093         (AccessibilityUIElement::isMultiSelectable):
2094         (AccessibilityUIElement::isSelectedOptionActive):
2095         (AccessibilityUIElement::isVisible):
2096         (AccessibilityUIElement::isOffScreen):
2097         (AccessibilityUIElement::isCollapsed):
2098         (AccessibilityUIElement::isIgnored):
2099         (AccessibilityUIElement::hasPopup):
2100         (AccessibilityUIElement::takeFocus):
2101         (AccessibilityUIElement::takeSelection):
2102         (AccessibilityUIElement::addSelection):
2103         (AccessibilityUIElement::removeSelection):
2104         (AccessibilityUIElement::uiElementForSearchPredicate):
2105         (AccessibilityUIElement::numberAttributeValue):
2106
2107 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
2108
2109         [chromium] pass all focus handling methods through the WebTestDelegate
2110         https://bugs.webkit.org/show_bug.cgi?id=111328
2111
2112         Reviewed by Nico Weber.
2113
2114         In content_shell, the focus handling is asynchronous. To allow for
2115         switching the focus synchronously between WebViews, we need to intercept
2116         didFocus and didBlur and forward it to the WebTestDelegate.
2117
2118         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2119         (WebTestDelegate):
2120         (WebTestRunner::WebTestDelegate::setFocus):
2121         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2122         (WebTestRunner::WebTestProxy::didFocus):
2123         (WebTestRunner::WebTestProxy::didBlur):
2124         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2125         (WebTestRunner::TestRunner::setWindowIsKey):
2126         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2127         (WebTestRunner::WebTestProxyBase::didFocus):
2128         (WebTestRunner):
2129         (WebTestRunner::WebTestProxyBase::didBlur):
2130         * DumpRenderTree/chromium/WebViewHost.cpp:
2131         (WebViewHost::didFocus):
2132         (WebViewHost::didBlur):
2133         (WebViewHost::setFocus):
2134         * DumpRenderTree/chromium/WebViewHost.h:
2135         (WebViewHost):
2136
2137 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
2138
2139         [GTK] No need to manually add system paths to jhbuildrc
2140         https://bugs.webkit.org/show_bug.cgi?id=110850
2141
2142         Reviewed by Gustavo Noronha Silva.
2143
2144         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
2145         already takes care of.
2146
2147 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
2148
2149         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
2150         https://bugs.webkit.org/show_bug.cgi?id=111284
2151
2152         Disabling the failing two tests on Android.
2153
2154         Reviewed by Jochen Eisinger.
2155
2156         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2157         (TestWebKitAPI):
2158         (TestWebKitAPI::TEST):
2159
2160 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2161
2162         Add build flag for FontLoader
2163         https://bugs.webkit.org/show_bug.cgi?id=111289
2164
2165         Reviewed by Benjamin Poulain.
2166
2167         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
2168
2169         * Scripts/webkitperl/FeatureList.pm:
2170         * qmake/mkspecs/features/features.pri:
2171
2172 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
2173
2174         [Mac] Get rid of a useless method from DOMHTMLInputElement
2175         https://bugs.webkit.org/show_bug.cgi?id=111279
2176
2177         Reviewed by Sam Weinig.
2178
2179         * DumpRenderTree/mac/TestRunnerMac.mm:
2180         (TestRunner::setValueForUser):
2181         The method _setValueForUser: was added for testing. This feature is already
2182         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
2183         in real use cases. Get rid of the method created for testing, use the real thing
2184         instead.
2185
2186 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2187
2188         Some perf. tests have variances that differ greatly between runs
2189         https://bugs.webkit.org/show_bug.cgi?id=97510
2190
2191         Reviewed by Benjamin Poulain.
2192
2193         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
2194         environment on test results (we run each instance after one another, not in parallel).
2195
2196         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
2197         iterations as it was done previously in single process. These values are hard-coded in perftest.py
2198         and runner.js but they are to be configurable in the future.
2199
2200         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
2201         metric now reports an array of the length 4 with each element containing an array of 5 iteration
2202         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
2203
2204         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
2205         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
2206         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
2207
2208         * Scripts/webkitpy/performance_tests/perftest.py:
2209         (PerfTestMetric.append_group): Renamed from append.
2210         (PerfTestMetric.grouped_iteration_values): Added.
2211         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
2212
2213         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
2214         This parameter is only used by SingleProcessPerfTest.
2215
2216         (PerfTest.run): Repeat tests using different driver processes.
2217         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
2218         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
2219         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
2220         (PerfTest._ensure_metrics): Added.
2221
2222         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
2223         instances of DumpRenderTree/WebKitTestRunner takes too long.
2224         (SingleProcessPerfTest.__init__):
2225
2226         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
2227
2228         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
2229
2230         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
2231         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
2232         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
2233
2234         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
2235         grouped_iteration_values.
2236
2237         (TestPerfTest._assert_results_are_correct):
2238
2239         (TestSingleProcessPerfTest): Added.
2240         (TestSingleProcessPerfTest.test_use_only_one_process):
2241         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
2242
2243         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2244         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2245
2246         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
2247         sample standard deviations since we're now running tests 4 times.
2248         (MainTest._test_run_with_json_output.mock_upload_json):
2249         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2250
2251 2013-03-03  Alexandre Elias  <aelias@chromium.org>
2252
2253         [chromium] Remove WebLayerTreeView::setViewportSize call
2254         https://bugs.webkit.org/show_bug.cgi?id=110727
2255
2256         Reviewed by James Robinson.
2257
2258         After https://codereview.chromium.org/12328080 lands,
2259         setViewportSize is called from the Chromium side. The multiplication
2260         by deviceScaleFactor here was prone to off-by-one errors.
2261         The layoutSize() function was only used here so delete it as well.
2262
2263         DumpRenderTree WebViewHost must now call this method as well.
2264
2265         * DumpRenderTree/chromium/WebViewHost.cpp:
2266         (WebViewHost::initializeLayerTreeView):
2267         (WebViewHost::setWindowRect):
2268         (WebViewHost::setDeviceScaleFactor):
2269         (WebViewHost::updateViewportSize):
2270         * DumpRenderTree/chromium/WebViewHost.h:
2271         (WebViewHost):
2272
2273 2013-02-27  Darin Adler  <darin@apple.com>
2274
2275         StringHasher functions require alignment that call sites do not all guarantee
2276         https://bugs.webkit.org/show_bug.cgi?id=110171
2277
2278         Reviewed by Benjamin Poulain.
2279
2280         * TestWebKitAPI/CMakeLists.txt:
2281         * TestWebKitAPI/GNUmakefile.am:
2282         * TestWebKitAPI/TestWebKitAPI.gypi:
2283         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2284         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2286         * TestWebKitAPI/Tests/WTF/WTF.pro:
2287         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2288         Added the StringHasher.cpp file.
2289
2290         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
2291         for the functions in the StringHasher class.
2292
2293 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
2294
2295         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
2296         https://bugs.webkit.org/show_bug.cgi?id=109772
2297
2298         Reviewed by Andreas Kling.
2299
2300         * DumpRenderTree/TestRunner.cpp:
2301         (TestRunner::staticFunctions):
2302         * DumpRenderTree/TestRunner.h:
2303         (TestRunner):
2304         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2305         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2306         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2307         * DumpRenderTree/mac/TestRunnerMac.mm:
2308         * DumpRenderTree/qt/TestRunnerQt.cpp:
2309         * DumpRenderTree/qt/TestRunnerQt.h:
2310         (TestRunner):
2311         * DumpRenderTree/win/TestRunnerWin.cpp:
2312         * DumpRenderTree/wx/TestRunnerWx.cpp:
2313         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2314         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2316         (TestRunner):
2317
2318 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2319
2320         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
2321         https://bugs.webkit.org/show_bug.cgi?id=110943
2322
2323         Reviewed by Yury Semikhatsky.
2324
2325         Unfortunately in many cases raw pointer may point to an object that has been deleted.
2326         There is no working solution to solve this problem in general.
2327         It could be solved only on case by case basis.
2328
2329         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2330         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2331         (TestWebKitAPI::TEST):
2332
2333 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
2334
2335         Move markerTextForListItem from TestRunner to Internals
2336         https://bugs.webkit.org/show_bug.cgi?id=110939
2337
2338         Reviewed by Benjamin Poulain.
2339
2340         * DumpRenderTree/TestRunner.cpp:
2341         (TestRunner::staticFunctions):
2342         * DumpRenderTree/TestRunner.h:
2343         (TestRunner):
2344         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2345         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2346         (WebTestRunner::TestRunner::TestRunner):
2347         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2348         (TestRunner):
2349         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2350         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2351         * DumpRenderTree/mac/TestRunnerMac.mm:
2352         * DumpRenderTree/qt/TestRunnerQt.cpp:
2353         * DumpRenderTree/qt/TestRunnerQt.h:
2354         (TestRunnerQt):
2355         * DumpRenderTree/win/TestRunnerWin.cpp:
2356         * DumpRenderTree/wx/TestRunnerWx.cpp:
2357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2360         (TestRunner):
2361
2362 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2363
2364         Don't use legacy test names when returning results from PerfTest.run
2365         https://bugs.webkit.org/show_bug.cgi?id=111148
2366
2367         Reviewed by Dirk Pranke.
2368
2369         * Scripts/webkitpy/performance_tests/perftest.py:
2370         (PerfTestMetric.name): Renamed from metric.
2371         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
2372         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
2373         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
2374
2375         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2376         (TestPerfTestMetric.test_init_set_time_metric):
2377         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
2378         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2379         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2380
2381         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2382         (PerfTestsRunner.__init__):
2383         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
2384         to obtain the trac URL instead of hard coding it.
2385         (PerfTestsRunner._run_tests_set):
2386
2387 2013-03-01  Roger Fong  <roger_fong@apple.com>
2388
2389         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
2390         https://bugs.webkit.org/show_bug.cgi?id=111202
2391
2392         This is useful for running VCExpress builds from command line because there is
2393         no unified solution output, only per project build logs.
2394         The project will be run as the last project in the solution.
2395
2396         * win/AssembleBuildLogs: Added.
2397         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
2398         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
2399         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
2400         * win/AssembleBuildLogs/README: Added.
2401
2402 2013-03-01  Roger Fong  <roger_fong@apple.com>
2403
2404         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
2405
2406         * EWSTools/start-queue-win.sh:
2407
2408 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2409
2410         Don't return statistics in PerfTest.run
2411         https://bugs.webkit.org/show_bug.cgi?id=111145
2412
2413         Reviewed by Dirk Pranke.
2414
2415         Simply return a list of values obtained in each iteration from PerfTest.run.
2416         Also simplify various methods as needed.
2417
2418         * Scripts/webkitpy/performance_tests/perftest.py:
2419         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
2420         as needed from PerfTestsRunner._generate_results_dict.
2421
2422         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
2423         that we don't have to worry about the backward compatibility here.
2424
2425         (PerfTestMetric.iteration_values): Added.
2426         (PerfTestMetric.unit): Added.
2427         (PerfTestMetric.metric_to_unit):
2428         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
2429
2430         (PerfTest.run):
2431         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
2432
2433         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2434         (TestPerfTestMetric.test_init_set_missing_unit):
2435         (TestPerfTestMetric.test_init_set_time_metric): Added.
2436         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
2437         (TestPerfTestMetric.test_append):
2438         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
2439         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
2440         (TestPerfTest._assert_results_are_correct):
2441         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2442         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2443
2444         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2445         (PerfTestsRunner._generate_results_dict):
2446
2447         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2448         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
2449         (SomeParserTestData): Ditto.
2450         (MemoryTestData): Ditto.
2451
2452 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2453
2454         [Qt] Enable LINK_PREFETCH
2455         https://bugs.webkit.org/show_bug.cgi?id=111158
2456
2457         Reviewed by Simon Hausmann.
2458
2459         * qmake/mkspecs/features/features.pri:
2460
2461 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2462
2463         [Qt] Update features.pri with new features
2464         https://bugs.webkit.org/show_bug.cgi?id=111157
2465
2466         Reviewed by Jocelyn Turcotte.
2467
2468         * qmake/mkspecs/features/features.pri:
2469
2470 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
2471
2472         [chromium] put WebTestProxy::scheduleComposite back in place
2473         https://bugs.webkit.org/show_bug.cgi?id=111146
2474
2475         Reviewed by Nico Weber.
2476
2477         The call was removed in http://trac.webkit.org/changeset/144398 because
2478         DRT doesn't need it. However, content shell depends on this call.
2479
2480         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2481         (WebTestRunner::WebTestProxy::scheduleComposite):
2482
2483 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2484
2485         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
2486         https://bugs.webkit.org/show_bug.cgi?id=111142
2487
2488         Reviewed by Adam Barth.
2489
2490         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
2491
2492         Also removed _print_status since it's never used anywhere.
2493
2494         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2495         (PerfTestsRunner.run):
2496         (PerfTestsRunner._run_tests_set):
2497         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2498         (MainTest.run_test):
2499         (MainTest.test_run_test_set):
2500         (MainTest.test_run_test_set_kills_drt_per_run):
2501         (MainTest.test_run_test_set_for_parser_tests):
2502
2503 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
2504
2505         Disable window occlusion detection for WebKitTestRunner Web View on Mac
2506         https://bugs.webkit.org/show_bug.cgi?id=111116
2507
2508         Reviewed by Simon Fraser.
2509
2510         Window occlusion notifications were causing WebKitTestRunner's Web View
2511         to be detected as occluded and causing a few JavaScript timer layout
2512         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
2513         by initializing the page visibility to "visible" after creating the view.
2514         But a better solution is to disable window occlusion detection, so that
2515         not only the page but also the view is treated as visible.
2516
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::TestController::createWebViewWithOptions): Remove call to
2519         setVisibilityState, since it is no longer necessary.
2520         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2521         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
2522         detection for the created WKView.
2523
2524 2013-02-28  Li Yin  <li.yin@intel.com>
2525
2526         [chromium] Events can't be triggered on MediaStreamTrack
2527         https://bugs.webkit.org/show_bug.cgi?id=110930
2528
2529         Reviewed by Kentaro Hara.
2530
2531         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
2532
2533         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
2534         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
2535
2536 2013-02-27  James Robinson  <jamesr@chromium.org>
2537
2538         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
2539         https://bugs.webkit.org/show_bug.cgi?id=111017
2540
2541         Reviewed by Adam Barth.
2542
2543         This decouples DumpRenderTree from WebLayerTreeViewClient.
2544
2545         * DumpRenderTree/chromium/WebViewHost.cpp:
2546         (WebViewHostDRTLayerTreeViewClient):
2547         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
2548         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
2549         (WebViewHostDRTLayerTreeViewClient::Layout):
2550         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
2551         (WebViewHost::initializeLayerTreeView):
2552         * DumpRenderTree/chromium/WebViewHost.h:
2553         (webkit_support):
2554         (WebViewHost):
2555
2556 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
2557
2558         Unreviewed, add my secondary email address to the list.
2559
2560         * Scripts/webkitpy/common/config/committers.py:
2561
2562 2013-02-28  Philip Rogers  <pdr@google.com>
2563
2564         Add Philip Rogers as a reviewer.
2565
2566         Unreviewed update of committers.py.
2567
2568         * Scripts/webkitpy/common/config/committers.py:
2569
2570 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         Merge more methods on PerfTest
2573         https://bugs.webkit.org/show_bug.cgi?id=111030
2574
2575         Reviewed by Dirk Pranke.
2576
2577         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
2578         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
2579
2580         This makes the control flow a lot more comprehensible.
2581
2582         * Scripts/webkitpy/performance_tests/perftest.py:
2583         (PerfTest._run_with_driver):
2584         (PerfTest._should_ignore_line):
2585         (PerfTest._filter_output):
2586
2587         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2588         (TestPerfTest._assert_results_are_correct):
2589         (test_ignored_stderr_lines):
2590
2591 2013-02-28  Robert Hogan  <robert@webkit.org>
2592
2593         Update my IRC nick
2594
2595         Unreviewed.
2596
2597         * Scripts/webkitpy/common/config/committers.py:
2598
2599 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2600
2601         [Qt] Enable thin archives before parsing the project files
2602
2603         Rubber-stamped by Simon Hausmann.
2604
2605         The targetSubDir() function can be called before default_post.prf has been
2606         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
2607         which is parsed before the main project file.
2608         This issue was revealed by r144299 and fixes the clean build.
2609
2610         * qmake/mkspecs/features/default_post.prf:
2611         * qmake/mkspecs/features/default_pre.prf:
2612
2613 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2614
2615         [Qt] Enable CANVAS_PATH flag
2616         https://bugs.webkit.org/show_bug.cgi?id=108508
2617
2618         Reviewed by Simon Hausmann.
2619
2620         Also enable CANVAS_PATH flag for Qt.
2621
2622         * qmake/mkspecs/features/features.pri:
2623
2624 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2625
2626         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
2627
2628         Rubber-stamped by Csaba Osztrogonác.
2629
2630         Besides suppressing a warning about the non-existing function this
2631         fixes the build if there is a subdirectory (eg. debug-and-release).
2632
2633         * TestWebKitAPI/InjectedBundle.pri:
2634         * TestWebKitAPI/TestWebKitAPI.pri:
2635
2636 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2637
2638         [EFL][WTR] WTR cannot load injected bundle
2639         https://bugs.webkit.org/show_bug.cgi?id=111063
2640
2641         Reviewed by Csaba Osztrogonác.
2642
2643         WTR was not able to load injected bundle because of undefined 
2644         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
2645         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
2646         solves the problem.
2647
2648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2649         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2650
2651 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
2652
2653         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
2654         https://bugs.webkit.org/show_bug.cgi?id=110464
2655
2656         Reviewed by Rob Buis.
2657
2658         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2659
2660 2013-02-28  Xan Lopez  <xlopez@rim.com>
2661
2662         [BlackBerry] DumpRenderTreeSupport: update the set position methods
2663         https://bugs.webkit.org/show_bug.cgi?id=110578
2664
2665         Reviewed by Rob Buis.
2666
2667         TestRunner::setMockGeolocationPosition() changed in r130416:
2668         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
2669
2670         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
2671         setMockGeolocationPositionUnavailableError() in r129444:
2672         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
2673
2674         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2675         (TestRunner::setMockGeolocationPosition):
2676         (TestRunner::setMockGeolocationPositionUnavailableError):
2677
2678 2013-02-28  Xan Lopez  <xlopez@rim.com>
2679
2680         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
2681         https://bugs.webkit.org/show_bug.cgi?id=110465
2682
2683         Reviewed by Rob Buis.
2684
2685         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2686         (LoadItem::invoke):
2687
2688 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2689
2690         PerfTestRunner doesn't need _needs_http and _has_http_lock
2691         https://bugs.webkit.org/show_bug.cgi?id=111037
2692
2693         Reviewed by Adam Barth.
2694
2695         Delete these variables in favor of using a local variable.
2696
2697         Member variables are like global variables. They introduce implicit dependencies
2698         between member functions.
2699
2700         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2701         (PerfTestsRunner.__init__):
2702         (PerfTestsRunner._start_http_servers):
2703         (PerfTestsRunner):
2704         (PerfTestsRunner._stop_http_servers):
2705         (PerfTestsRunner.run):
2706
2707 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2708
2709         Unreviewed, rolling out r144224.
2710         http://trac.webkit.org/changeset/144224
2711         https://bugs.webkit.org/show_bug.cgi?id=111045
2712
2713         Caused plugins/pass-different-npp-struct.html to time out
2714         (Requested by abarth on #webkit).
2715
2716         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2717         (PassDifferentNPPStruct::NPP_SetWindow):
2718         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2719         (NPP_SetWindow):
2720
2721 2013-02-27  Adam Barth  <abarth@webkit.org>
2722
2723         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2724         https://bugs.webkit.org/show_bug.cgi?id=110907
2725
2726         Reviewed by Eric Seidel.
2727
2728         This patch changes --enable-threaded-html-parser into
2729         --disable-threaded-html-parser and thereby enables the threaded HTML
2730         parser by default for the Chromium port.
2731
2732         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2733         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2734         (WebTestRunner::WebPreferences::reset):
2735         * DumpRenderTree/chromium/TestShell.cpp:
2736         (TestShell::TestShell):
2737
2738 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2739
2740         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2741         https://bugs.webkit.org/show_bug.cgi?id=111025
2742
2743         Reviewed by Simon Fraser.
2744
2745         Set page visibility to "visible" after creating WebView to override
2746         visibility state inferred from window occlusion notifications on Mac.
2747
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::createWebViewWithOptions): Add call to
2750         setVisibilityState.
2751
2752 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         Merge PageLoadingPerfTest into ReplayPerfTest
2755         https://bugs.webkit.org/show_bug.cgi?id=111027
2756
2757         Reviewed by Dirk Pranke.
2758
2759         Merged two classes.
2760
2761         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2762         part of ReplayPerfTest.
2763
2764         * Scripts/webkitpy/performance_tests/perftest.py:
2765         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2766         (ReplayPerfTest.__init__):
2767         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2768         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2769         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2770         (TestReplayPerfTest):
2771         (TestReplayPerfTest.test_run_single.run_test):
2772         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2773         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2774         TestPageLoadingPerfTest.test_run.
2775         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2776         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2777         TestPageLoadingPerfTest.test_run_with_memory_output
2778         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2779         (TestReplayPerfTest.test_prepare_calls_run_single):
2780
2781 2013-02-27  Eric Seidel  <eric@webkit.org>
2782
2783         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2784         https://bugs.webkit.org/show_bug.cgi?id=111021
2785
2786         Reviewed by Dirk Pranke.
2787
2788         The underlying code (which is shared with run-webkit-tests)
2789         already knew how to support this option, it just wasn't exposed
2790         via the run-perf-tests front-end.  This patch fixes that.
2791
2792         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2793         (PerfTestsRunner._parse_args):
2794
2795 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2796
2797         Stop uploading results to webkit-perf.appspot.com
2798         https://bugs.webkit.org/show_bug.cgi?id=110954
2799
2800         Reviewed by Benjamin Poulain.
2801
2802         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2805         (RunAndUploadPerfTests):
2806
2807 2013-02-27  James Simonsen  <simonjam@chromium.org>
2808
2809         [chromium] Lower priority of preloaded images
2810         https://bugs.webkit.org/show_bug.cgi?id=110527
2811
2812         Plumb the didChangePriority signal into DRT so it can be tested.
2813
2814         Reviewed by Nate Chapin.
2815
2816         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2817         (WebKit):
2818         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2819         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2820         (WebTestRunner::TestRunner::TestRunner):
2821         (WebTestRunner::TestRunner::reset):
2822         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2823         (WebTestRunner):
2824         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2826         (TestRunner):
2827         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2828         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2829         (WebTestRunner::WebTestProxyBase::willSendRequest):
2830         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2831         (WebTestRunner):
2832
2833 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2834
2835         AX: Mac platform should support ability to scroll an element into visible
2836         https://bugs.webkit.org/show_bug.cgi?id=109860
2837
2838         Reviewed by Beth Dakin.
2839
2840         * DumpRenderTree/AccessibilityUIElement.cpp:
2841         (scrollToMakeVisibleCallback):
2842         (AccessibilityUIElement::getJSClass):
2843         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2844         (AccessibilityUIElement::scrollToMakeVisible):
2845         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2846         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2847         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2848         (AccessibilityUIElement):
2849         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2850         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2851         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2852         (WTR):
2853
2854 2013-02-27  John Bauman  <jbauman@chromium.org>
2855
2856         Plugin in iframe may not display
2857         https://bugs.webkit.org/show_bug.cgi?id=109879
2858
2859         Reviewed by Simon Fraser.
2860
2861         LogNPPSetWindow will be used with other ports as well.
2862
2863         * DumpRenderTree/DumpRenderTree.gypi:
2864         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2865
2866 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2867
2868         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2869         https://bugs.webkit.org/show_bug.cgi?id=110973
2870
2871         Reviewed by Adam Barth.
2872
2873         There is nothing that ensures that the log messages from the plugin
2874         come in before the layout test finished loading.
2875
2876         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2877         (PassDifferentNPPStruct::NPP_SetWindow):
2878         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2879         (NPP_SetWindow):
2880
2881 2013-02-27  Glenn Adams  <glenn@skynav.com>
2882
2883         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2884         https://bugs.webkit.org/show_bug.cgi?id=110944
2885
2886         Reviewed by Dean Jackson.
2887
2888         * Scripts/webkitperl/FeatureList.pm:
2889         * qmake/mkspecs/features/features.pri:
2890
2891 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2892
2893         Unreviewed. Remove myself from watchlist.
2894
2895         * Scripts/webkitpy/common/config/watchlist:
2896
2897 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2898
2899         Switch QtWebKit to GStreamer 1.0.
2900         https://bugs.webkit.org/show_bug.cgi?id=106669.
2901
2902         Original patch by Sebastian Dröge.
2903         Reviewed by Csaba Osztrogonác.
2904
2905         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
2906         temporarily to make upgrading easy and the patch suitable for Qt5.
2907
2908         * qmake/mkspecs/features/features.prf:
2909
2910 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2911
2912         Unreviewed. Added myself to committers.py
2913
2914         * Scripts/webkitpy/common/config/committers.py:
2915
2916 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2917
2918         Unreviewed, rolling out r144192.
2919         http://trac.webkit.org/changeset/144192
2920         https://bugs.webkit.org/show_bug.cgi?id=110984
2921
2922         Stored svn password on wrong computer (Requested by kkristof
2923         on #webkit).
2924
2925         * Scripts/webkitpy/common/config/committers.py:
2926
2927 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2928
2929         Unreviewed. Added myself to committers.py
2930
2931         * Scripts/webkitpy/common/config/committers.py:
2932
2933 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2934
2935         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
2936
2937         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2938         (PerfTestsRunner._upload_json):
2939
2940 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2941
2942         Stop uploading results to webkit-perf.appspot.com
2943         https://bugs.webkit.org/show_bug.cgi?id=110954
2944
2945         Reviewed by Benjamin Poulain.
2946
2947         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
2948         Also, always use the new JSON format. Removed the code to generate the old format.
2949
2950         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2951         (PerfTestsRunner._generate_and_show_results):
2952         (PerfTestsRunner._generate_results_dict):
2953         (PerfTestsRunner._merge_slave_config_json):
2954         (PerfTestsRunner._generate_output_files):
2955
2956 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2957
2958         Unreviewed, rolling out r144136, r144143, and r144147.
2959         http://trac.webkit.org/changeset/144136
2960         http://trac.webkit.org/changeset/144143
2961         http://trac.webkit.org/changeset/144147
2962         https://bugs.webkit.org/show_bug.cgi?id=110950
2963
2964         Caused some timeouts and flaky crashes (Requested by abarth on
2965         #webkit).
2966
2967         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2968         (main):
2969         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2970         (WebTestRunner::WebPreferences::reset):
2971         * DumpRenderTree/chromium/TestShell.cpp:
2972         (TestShell::TestShell):
2973
2974 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2975
2976         Use perf.webkit.org JSON format in results page
2977         https://bugs.webkit.org/show_bug.cgi?id=110842
2978
2979         Reviewed by Benjamin Poulain.
2980
2981         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2982
2983         A whole bunch of integration tests have been updated to use the new JSON format.
2984
2985         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2986         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
2987         and legacy_output_json_path respectively.
2988         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
2989         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
2990         JSON file and the results page out of perf_webkit_output instead of legacy_output.
2991
2992         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2993         (MainTest.test_run_memory_test):
2994         (MainTest._test_run_with_json_output.mock_upload_json):
2995         (MainTest):
2996         (MainTest.test_run_with_json_output):
2997         (MainTest.test_run_with_description):
2998         (MainTest.test_run_generates_json_by_default):
2999         (MainTest.test_run_merges_output_by_default):
3000         (MainTest.test_run_respects_reset_results):
3001         (MainTest.test_run_generates_and_show_results_page):
3002         (MainTest.test_run_with_slave_config_json):
3003         (MainTest.test_run_with_multiple_repositories):
3004         (MainTest.test_run_with_upload_json):
3005         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3006
3007 2013-02-26  Adam Barth  <abarth@webkit.org>
3008
3009         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
3010         https://bugs.webkit.org/show_bug.cgi?id=110907
3011
3012         Reviewed by Eric Seidel.
3013
3014         This patch changes --enable-threaded-html-parser into
3015         --disable-threaded-html-parser and thereby enables the threaded HTML
3016         parser by default for the Chromium port.
3017
3018         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3019         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3020         (WebTestRunner::WebPreferences::reset):
3021         * DumpRenderTree/chromium/TestShell.cpp:
3022         (TestShell::TestShell):
3023
3024 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
3025
3026         [chromium] Re-enable the fixed version of freetype on linux
3027         https://bugs.webkit.org/show_bug.cgi?id=110542
3028
3029         Reviewed by Tony Chang.
3030
3031         Re-land the change in r143794 to switch to building with a fixed
3032         version of FreeType for just DumpRenderTree. This allows us to share
3033         one version of pixel baselines for both Lucid and Precise, and run the
3034         layout tests in a stock Precise install (instead of a Lucid chroot).
3035         Going forward, this approach isolates us from os-level changes to the
3036         version of FreeType. Note that Chromium itself still uses the system
3037         FreeType and is unaffected by this change.
3038         
3039         This setting can still be turned off (at compile/gyp-time) by
3040         manually setting use_custom_freetype=0.
3041
3042         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3043
3044 2013-02-26  Nico Weber  <thakis@chromium.org>
3045
3046         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
3047         https://bugs.webkit.org/show_bug.cgi?id=110890
3048
3049         Reviewed by Jochen Eisinger.
3050
3051         Several functions in webkit check that bit to change rendering
3052         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
3053         disables font smoothing in this mode. TestShell and DRT both set
3054         this flag, so content shell drt should set it too.
3055
3056         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3057         (WebTestRunner::TestInterfaces::TestInterfaces):
3058
3059 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3060
3061         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
3062         https://bugs.webkit.org/show_bug.cgi?id=110884
3063
3064         Reviewed by Csaba Osztrogonác.
3065
3066         Adding the missing spaces before ':' in the unit test.
3067
3068         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3069
3070 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3071
3072         new-commit-bot: Some IRC clients doesn't linkify rollout messages
3073         https://bugs.webkit.org/show_bug.cgi?id=110861
3074
3075         Reviewed by Ryosuke Niwa.
3076
3077         Adding the space before ':' in order to fix the links shown for the rollout message.
3078
3079         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3080         (NewCommitBot._summarize_commit_log):
3081
3082 2013-02-26  Joone Hur  <joone.hur@intel.com>
3083
3084         [GTK] Add Clutter to jhbuild
3085         https://bugs.webkit.org/show_bug.cgi?id=110245
3086
3087         Reviewed by Martin Robinson.
3088
3089         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
3090         This allows to build WebKitGtk+ with clutter as an acceleration backend
3091         within the jhbuild environment. 
3092
3093         * gtk/jhbuild-optional.modules:
3094
3095 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3096
3097         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
3098
3099         * Scripts/webkitpy/common/checkout/scm/svn.py:
3100         (SVN.value_from_svn_info):
3101
3102 2013-02-25  Alan Cutter  <alancutter@chromium.org>
3103
3104         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
3105         https://bugs.webkit.org/show_bug.cgi?id=110845
3106
3107         Unreviewed EWS bot fix.
3108
3109         Switch the Queue Status Server address the EWS bots use to a more direct URL that
3110         doesn't seem to be having problems from GCE like queues.webkit.org.
3111
3112         * Scripts/webkitpy/common/net/statusserver.py:
3113         (StatusServer):
3114
3115 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3116
3117         Forgot to delete a no-longer-needed unit test after r143980.
3118
3119         Unreviewed, build fix.
3120
3121         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3122         (ChromiumWinTest.test_path_to_image_diff):
3123
3124 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3125
3126         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
3127         Don't include \r at the end of svn info lines on Windows.
3128
3129         This is similar to r143839.
3130
3131         * Scripts/webkitpy/common/checkout/scm/svn.py:
3132         (SVN.value_from_svn_info):
3133
3134 2013-02-25  James Simonsen  <simonjam@chromium.org>
3135
3136         [Resource Timing] Update test suite so it can be exported to the W3C
3137         https://bugs.webkit.org/show_bug.cgi?id=107343
3138
3139         Reviewed by Tony Gentilcore.
3140
3141         * Scripts/export-w3c-performance-wg-tests: Clean up output.
3142         * Scripts/import-w3c-performance-wg-tests:
3143
3144 2013-02-25  Anders Carlsson  <andersca@apple.com>
3145
3146         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
3147         https://bugs.webkit.org/show_bug.cgi?id=110821
3148         <rdar://problem/13265303>
3149
3150         Reviewed by Beth Dakin.
3151
3152         Update for WebKit2 changes.
3153
3154         * MiniBrowser/mac/WK2BrowserWindowController.m:
3155         (-[WK2BrowserWindowController awakeFromNib]):
3156         * WebKitTestRunner/TestController.cpp:
3157         (WTR::TestController::createOtherPage):
3158         (WTR::TestController::createWebViewWithOptions):
3159         (WTR::TestController::unavailablePluginButtonClicked):
3160         * WebKitTestRunner/TestController.h:
3161         (TestController):
3162
3163 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
3164
3165         Optionally partition cache to prevent using cache for tracking
3166         https://bugs.webkit.org/show_bug.cgi?id=110269
3167
3168         Reviewed by Maciej Stachowiak.
3169
3170         Add test suite for public suffix functions on Mac.
3171
3172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3173         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
3174         (TestWebKitAPI):
3175         (TestWebKitAPI::TEST_F):
3176
3177 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3178
3179         nrwt: reenable multiple http shards on chromium win
3180         https://bugs.webkit.org/show_bug.cgi?id=110814
3181
3182         Reviewed by Tony Chang.
3183
3184         The underlying bug in DumpRenderTree that was causing us to look for a
3185         pac file and timeout under load was fixed a while ago.
3186
3187         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3188         (ChromiumWinPort.relative_test_filename):
3189
3190 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3191
3192         Make ninja the default w/ build-webkit --chromium on windows.
3193         https://bugs.webkit.org/show_bug.cgi?id=110731
3194
3195         Unreviewed - TBR'ing thakis :).
3196
3197         * Scripts/update-webkit-chromium:
3198
3199 2013-02-25  Anders Carlsson  <andersca@apple.com>
3200
3201         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
3202         https://bugs.webkit.org/show_bug.cgi?id=110793
3203         <rdar://problem/13265303>
3204
3205         Reviewed by Sam Weinig.
3206
3207         Update for WebKit2 API changes.
3208
3209         * MiniBrowser/mac/WK2BrowserWindowController.m:
3210         (-[WK2BrowserWindowController awakeFromNib]):
3211         * WebKitTestRunner/TestController.cpp:
3212         (WTR::TestController::createWebViewWithOptions):
3213
3214 2013-02-25  Nico Weber  <thakis@chromium.org>
3215
3216         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
3217         https://bugs.webkit.org/show_bug.cgi?id=110775
3218
3219         Unreviewed, basically a rebaseline.
3220
3221         * Scripts/webkitpy/common/config/watchlist:
3222
3223 2013-02-25  Nico Weber  <thakis@chromium.org>
3224
3225         [chromium] Try to get the webkit builder to use msvs again
3226         https://bugs.webkit.org/show_bug.cgi?id=110771
3227
3228         Reviewed by Eric Seidel.
3229
3230         The msvs gyp generator apparently doesn't write the sln file on every
3231         run, so check the vcxproj file instead.
3232
3233         * Scripts/webkitdirs.pm:
3234         (determineIsChromiumNinja):
3235
3236 2013-02-25  Nico Weber  <thakis@chromium.org>
3237
3238         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
3239         https://bugs.webkit.org/show_bug.cgi?id=110767
3240
3241         Reviewed by Eric Seidel.
3242
3243         The tester runs gyp, which generates out/Release/build.ninja. The bot
3244         scripts use existence (and timestamp) of that file to decide if the
3245         current build is supposed to be ninja or xcodebuild. The file exists,
3246         so the snapshot is extracted to out/Release. The snapshot doesn't
3247         contain build.ninja however due to
3248         http://trac.webkit.org/changeset/140375 , so after extracting the
3249         snapshot the scripts think that this is an xcodebuild build. So remove
3250         the part of that revision that removed ninja files from the archive,
3251         and the bots should be happy again.
3252
3253         * BuildSlaveSupport/built-product-archive:
3254         (archiveBuiltProduct):
3255
3256 2013-02-25  Nico Weber  <thakis@chromium.org>
3257
3258         Fix tests after r143910
3259         https://bugs.webkit.org/show_bug.cgi?id=110757
3260
3261         Reviewed by Andreas Kling.
3262
3263         While here, also add a test for the bug r143910 fixed.
3264
3265         * Scripts/webkitpy/common/system/executive_unittest.py:
3266         (ScriptErrorTest.test_message_with_output):
3267         (ScriptErrorTest):
3268         (ScriptErrorTest.test_message_with_tuple):
3269
3270 2013-02-25  Nico Weber  <thakis@chromium.org>
3271
3272         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
3273         https://bugs.webkit.org/show_bug.cgi?id=110755
3274
3275         Reviewed by Jochen Eisinger.
3276
3277         * BuildSlaveSupport/built-product-archive:
3278         (archiveBuiltProduct):
3279         (extractBuiltProduct):
3280
3281 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3282
3283         Unreviewed, rolling out r143895.
3284         http://trac.webkit.org/changeset/143895
3285         https://bugs.webkit.org/show_bug.cgi?id=110758
3286
3287         broke a bunch of tests (Requested by thakis__ on #webkit).
3288
3289         * Scripts/update-webkit-chromium:
3290
3291 2013-02-25  Andreas Kling  <akling@apple.com>
3292
3293         Unreviewed, fix simple mistake in r143903.
3294         <http://webkit.org/b/110746>
3295
3296         Reviewed by Andreas Kling.
3297
3298         Pass git revision, not svn revision, to git shell command.
3299
3300         * Scripts/webkitpy/common/checkout/scm/git.py:
3301         (Git.timestamp_of_latest_commit):
3302
3303 2013-02-25  Nico Weber  <thakis@chromium.org>
3304
3305         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
3306         https://bugs.webkit.org/show_bug.cgi?id=110748
3307
3308         Reviewed by Jochen Eisinger.
3309
3310         One of the mac testers runs DRT from out/ but WebKitUnitTests from
3311         xcodebuild. I'm trying to understand what's going on.
3312
3313         * BuildSlaveSupport/built-product-archive:
3314         (archiveBuiltProduct):
3315         (extractBuiltProduct):
3316
3317 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
3318
3319         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
3320         https://bugs.webkit.org/show_bug.cgi?id=110599
3321
3322         Reviewed by Yury Semikhatsky.
3323
3324         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
3325         that were given us via MemoryInstrumentation calls.
3326         So I extended client api with registerString method that pushes the strings
3327         down to the serializer.
3328
3329         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3330         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3331         (TestWebKitAPI::Helper::Helper):
3332         (Helper):
3333         (TestWebKitAPI::Helper::addNode):
3334         (TestWebKitAPI::TEST):
3335
3336 2013-02-25  Nico Weber  <thakis@chromium.org>
3337
3338         Make ScriptError not crash when args is a tuple
3339         https://bugs.webkit.org/show_bug.cgi?id=110747
3340
3341         Reviewed by Jochen Eisinger.
3342
3343         I'm trying to understand the error on
3344         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
3345         better. I'll likely have to revert the ninja switch on windows, but
3346         having error reporting code that doesn't itself crash sounds like a
3347         good thing to have anyways.
3348
3349         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
3350         tuple not a list.
3351
3352         * Scripts/run-chromium-webkit-unit-tests:
3353         * Scripts/webkitpy/common/system/executive.py:
3354         (ScriptError.__init__):
3355
3356 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
3357
3358         [EFL] Align feature defaults
3359         https://bugs.webkit.org/show_bug.cgi?id=110715
3360
3361         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
3362         OptionsEfl.cmake.
3363
3364         Reviewed by Gyuyoung Kim.
3365
3366         * Scripts/webkitperl/FeatureList.pm:
3367
3368 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3369
3370         run-perf-tests reports wrong commit time
3371         https://bugs.webkit.org/show_bug.cgi?id=110746
3372
3373         Reviewed by Andreas Kling.
3374
3375         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
3376         of when the subdirectory was last modified.
3377
3378         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
3379         insufficient since running "svn log -r <revision>" on a partial checkout only returns
3380         an empty result if the revision didn't modify the subdirectory.
3381
3382         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
3383         the interface compatible with svn.
3384
3385         * Scripts/webkitpy/common/checkout/scm/git.py:
3386         (Git.timestamp_of_latest_commit):
3387         * Scripts/webkitpy/common/checkout/scm/scm.py:
3388         (SCM.timestamp_of_latest_commit):
3389         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3390         (MockSCM.timestamp_of_latest_commit):
3391         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3392         (test_timestamp_of_latest_commit):
3393         * Scripts/webkitpy/common/checkout/scm/svn.py:
3394         (SVN.timestamp_of_latest_commit):
3395         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3396         (PerfTestsRunner._generate_results_dict):
3397
3398 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
3399
3400         [chromium] move WebRuntimeFeatures configuration to TestRunner library
3401         https://bugs.webkit.org/show_bug.cgi?id=110712
3402
3403         Reviewed by Nico Weber.
3404
3405         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3406         (WebTestRunner::TestInterfaces::TestInterfaces):
3407         * DumpRenderTree/chromium/TestShell.cpp:
3408         (TestShell::TestShell):
3409
3410 2013-02-25  Nico Weber  <thakis@chromium.org>
3411
3412         Make ninja the default build system for build-webkit --chromium on windows
3413         https://bugs.webkit.org/show_bug.cgi?id=110731
3414
3415         Reviewed by Jochen Eisinger.
3416
3417         With http://crbug.com/169945 fixed, this should now work.
3418
3419         * Scripts/update-webkit-chromium:
3420
3421 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
3422
3423         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
3424         https://bugs.webkit.org/show_bug.cgi?id=110702
3425
3426         Reviewed by Martin Robinson.
3427
3428         * GtkLauncher/main.c: include autotoolsconfig.h.
3429         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
3430         the include ordering check, since it uses autotoolsconfig.h which needs to
3431         come first.
3432
3433 2013-02-24  Hajime Morrita  <morrita@google.com>
3434
3435         [Custom Elements] Implement bare-bone document.register()
3436         https://bugs.webkit.org/show_bug.cgi?id=100229
3437
3438         Reviewed by Adam Barth.
3439
3440         Added enableCustomDOMElements flag.
3441
3442         * DumpRenderTree/chromium/TestShell.cpp:
3443         (TestShell::TestShell):
3444
3445 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
3446
3447         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
3448         https://bugs.webkit.org/show_bug.cgi?id=110606
3449
3450         Reviewed by Adam Barth.
3451
3452         Part of a larger refactoring series; see tracking bug 82948.
3453
3454         * DumpRenderTree/DumpRenderTree.gypi:
3455         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3456         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3457         (WebKitSupportTestEnvironment::mockPlatform):
3458         (WebKitSupportTestEnvironment):
3459         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3460         (MockPlatform::create):
3461         (MockPlatform::MockPlatform):
3462         (MockPlatform::~MockPlatform):
3463         (MockPlatform::setInterfaces):
3464         (MockPlatform::cryptographicallyRandomValues):
3465         (MockPlatform::createMediaStreamCenter):
3466         (MockPlatform::createRTCPeerConnectionHandler):
3467         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3468         (MockPlatform):
3469         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
3470         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
3471         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3472         (WebTestDelegate):
3473         * DumpRenderTree/chromium/TestShell.cpp:
3474         (TestShell::initialize):
3475         * DumpRenderTree/chromium/TestShell.h:
3476         (TestShell):
3477
3478 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3479
3480         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
3481
3482         * Scripts/webkitpy/common/checkout/scm/svn.py:
3483         (SVN.timestamp_of_latest_commit):
3484
3485 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
3486
3487         Move setAutofilled from TestRunner to WebCore
3488         https://bugs.webkit.org/show_bug.cgi?id=110521
3489
3490         Reviewed by Benjamin Poulain.
3491
3492         * DumpRenderTree/TestRunner.cpp:
3493         (TestRunner::staticFunctions):
3494         * DumpRenderTree/TestRunner.h:
3495         (TestRunner):
3496         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3497         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3498         (WebTestRunner::TestRunner::TestRunner):
3499         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3500         (TestRunner):
3501         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3502         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3503         * DumpRenderTree/mac/TestRunnerMac.mm:
3504         * DumpRenderTree/qt/TestRunnerQt.cpp:
3505         * DumpRenderTree/qt/TestRunnerQt.h:
3506         (TestRunnerQt):
3507         * DumpRenderTree/win/TestRunnerWin.cpp:
3508         * DumpRenderTree/wx/TestRunnerWx.cpp:
3509
3510 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
3511
3512         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
3513         https://bugs.webkit.org/show_bug.cgi?id=108577
3514
3515         Reviewed by Dirk Pranke.
3516
3517         Upload results to perf.webkit.org using new JSON format as well as the host specified by
3518         --test-results-server. The new format is needed to provide extra information perf.webkit.org
3519         need such as the subversion commit time and test URLs. This is a temporarily measure until
3520         we complete the transition and the old JSON format and the code to upload results to
3521         webkit-perf.appspot.com can be deleted.
3522
3523         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
3524         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
3525         so that the app can sort performance test results based on the timestamp of the last commit.
3526
3527         It also changes the repository names returned by port objects to be properly capitalized
3528         human readable names such as WebKit instead of lowercased names such as webkit since these names
3529         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
3530         to explicitly lowercase the names.
3531
3532
3533         * Scripts/webkitpy/common/checkout/scm/git.py:
3534         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
3535         git's timestamp granularity is seconds so we're losing some information compared to using a regular
3536         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
3537         UTC so we're going to manually fiddle with timezone.
3538
3539         * Scripts/webkitpy/common/checkout/scm/scm.py:
3540         (SCM.timestamp_of_latest_commit): Added.
3541
3542         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3543         (MockSCM.timestamp_of_latest_commit): Added.
3544
3545         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3546         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
3547
3548         * Scripts/webkitpy/common/checkout/scm/svn.py:
3549         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
3550         the timestamp which is always in UTC.
3551
3552         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3553         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
3554         'chromium' needs to be substituted by 'chrome' for historical reasons.
3555
3556         * Scripts/webkitpy/layout_tests/port/base.py:
3557         (Port.repository_paths): Return WebKit instead of webkit as noted above.
3558
3559         * Scripts/webkitpy/layout_tests/port/chromium.py:
3560         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
3561
3562         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3563         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
3564         (PerfTestsRunner._collect_tests):
3565
3566         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
3567         and upload them appropriately.
3568
3569         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
3570         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
3571
3572         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
3573
3574         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
3575         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
3576         e.g. "processor" would be renamed to "builderProcessor".
3577
3578         (PerfTestsRunner._generate_output_files):
3579
3580         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
3581         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
3582         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
3583         webkit-perf.appspot.com which spits out a plaintext response.
3584
3585         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3586         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
3587         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
3588         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
3589
3590         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3591         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
3592         cases to parse JSON responses.
3593         (MainTest.test_upload_json.MockFileUploader): Refactored.
3594         (MainTest.test_upload_json.MockFileUploader.reset): Added.
3595         (MainTest.test_upload_json.MockFileUploader.__init__):
3596         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
3597
3598 2013-02-22  Roger Fong  <roger_fong@apple.com>
3599
3600         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
3601
3602         * BuildSlaveSupport/build.webkit.org-config/config.json:
3603
3604 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3605
3606         Unreviewed, rolling out r143794.
3607         http://trac.webkit.org/changeset/143794
3608         https://bugs.webkit.org/show_bug.cgi?id=110542
3609
3610         debug linux builds broken?
3611
3612         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3613
3614 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3615
3616         [chromium] enable the fixed version of freetype on linux
3617         https://bugs.webkit.org/show_bug.cgi?id=110542
3618
3619         Reviewed by Tony Chang.
3620
3621         Switch to building with a fixed version of FreeType for
3622         just DumpRenderTree. This allows us to share one version
3623         of pixel baselines for both Lucid and Precise, and run
3624         the layout tests in a stock Precise install (instead of a Lucid
3625         chroot). Going forward, this approach isolates us from os-level
3626         changes to the version of FreeType. Note that Chromium itself
3627         still uses the system FreeType and is unaffected by this change.
3628         
3629         This setting can still be turned off (at compile/gyp-time) by
3630         manually setting use_custom_freetype=0.
3631
3632         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3633
3634 2013-02-22  Anders Carlsson  <andersca@apple.com>
3635
3636         Move pluginLoadPolicy to the page loader client
3637         https://bugs.webkit.org/show_bug.cgi?id=110635
3638
3639         Reviewed by Sam Weinig.
3640
3641         * MiniBrowser/mac/WK2BrowserWindowController.m:
3642         (-[WK2BrowserWindowController awakeFromNib]):
3643         * WebKitTestRunner/TestController.cpp:
3644         (WTR::TestController::createOtherPage):
3645         (WTR::TestController::createWebViewWithOptions):
3646
3647 2013-02-22  Kenneth Russell  <kbr@google.com>
3648
3649         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
3650
3651         * Scripts/webkitpy/common/config/committers.py:
3652
3653 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3654
3655         [WTR] Do not dump information about empty subframes.
3656         https://bugs.webkit.org/show_bug.cgi?id=110585
3657
3658         Reviewed by Simon Fraser.
3659
3660         Follow DumpRenderTree more closely by skipping empty frames
3661         (frames which have no document). We are not really interested in
3662         showing anything about them.
3663
3664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3665         (WTR::dumpDescendantFramesText): Do not print subframe names when they
3666         have no associated Document.
3667
3668 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3669
3670         [EFL][DRT] Do not dump empty frames.
3671         https://bugs.webkit.org/show_bug.cgi?id=110474
3672
3673         Reviewed by Kenneth Rohde Christiansen.
3674
3675         Follow the original Mac implementation more closely by skipping
3676         empty frames (frames which have no document). We are not really
3677         interested in showing anything about them.
3678
3679         * DumpRenderTree/efl/DumpRenderTree.cpp:
3680         (dumpFramesAsText):
3681
3682 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
3683
3684         [chromium] support the lucid version of freetype on precise in DRT
3685         https://bugs.webkit.org/show_bug.cgi?id=107338
3686
3687         Reviewed by Tony Chang.
3688
3689         Modify the DRT build so that we can optionally link against
3690         a fixed version of Freetype2. This allows us to share pixel test
3691         results across multiple versions of Ubuntu without having to
3692         worry about differences in font rendering.
3693
3694         At the moment this feature is off by default. Eventually it will
3695         be on by default on linux.
3696
3697         Note that this only affects DRT; the regular Chromium binary
3698         (and, for now, content_shell) will still use the system version
3699         of Freetype.
3700
3701         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3702
3703 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
3704
3705         [Chromium] Remove the word "cheher" from the list of misspelled words
3706         https://bugs.webkit.org/show_bug.cgi?id=110447
3707
3708         Reviewed by Tony Chang.
3709
3710         Other platforms do not mark "cheher" as a misspelled word in layout tests.
3711         This change is to bring Chromium platform in line with the rest of the
3712         platforms.
3713
3714         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3715         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
3716         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
3717         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
3718
3719 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
3720
3721         [chromium] document WebTestDelegate and WebTestRunner interfaces
3722         https://bugs.webkit.org/show_bug.cgi?id=110472
3723
3724         Reviewed by Adam Barth.
3725
3726         Also remove the default implementation of the remaining WebTestDelegate
3727         methods now that all embedders provide this interface.
3728
3729         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3730         (WebTestDelegate):
3731         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3732         (WebTestRunner):
3733
3734 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3735
3736         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
3737         https://bugs.webkit.org/show_bug.cgi?id=106059
3738
3739         Reviewed by Geoffrey Garen.
3740
3741         Added new tests for the WebKit API portion of the JSC Objective-C API.
3742
3743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3744         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
3745         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
3746         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
3747         (-[MyConsole log:]):
3748         (-[MyConsole printHelloWorld]):
3749         (-[MyConsole add:to:]):
3750         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
3751         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3752         (TestWebKitAPI):
3753         (TestWebKitAPI::TEST):
3754
3755 2013-02-21  Stephen Chenney  <schenney@chromium.org>
3756
3757         Unreviewed, add myself as a reviewer
3758
3759         * Scripts/webkitpy/common/config/committers.py:
3760
3761 2013-02-21  Jer Noble  <jer.noble@apple.com>
3762
3763         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
3764
3765         * Scripts/webkitpy/common/config/committers.py:
3766         * Scripts/webkitpy/common/config/watchlist:
3767
3768 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3769
3770         gtk/DumpRenderTree.cpp is missing <locale.h> include
3771         https://bugs.webkit.org/show_bug.cgi?id=109386
3772
3773         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
3774         by include locale.h when we use setlocale.
3775
3776 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3777
3778         [GTK] Move feature overriding to the configure phase
3779         https://bugs.webkit.org/show_bug.cgi?id=110293
3780
3781         Reviewed by Gustavo Noronha Silva.
3782
3783         * Scripts/webkitdirs.pm:
3784         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
3785         WebKitFeatureOverrides.txt to better match the other filenames used in
3786         the new feature processing.
3787         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
3788         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
3789         and writes WebKitFeatures.txt and WebKitFeatures.h.
3790         * gtk/override-feature-defines: Removed.
3791
3792 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3793
3794         [Qt] Remove obsolete DEPENDPATH assignment
3795
3796         Reviewed by Simon Hausmann
3797
3798         qmake now adds CONFIG+=depend_includepath by default, making manual
3799         DEPENDPATH setup unnecessary.
3800
3801         * qmake/mkspecs/features/default_post.prf:
3802
3803 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
3804
3805         Unreviewed. Changing primary email id.
3806
3807         * Scripts/webkitpy/common/config/committers.py:
3808
3809 2013-02-14  James Robinson  <jamesr@chromium.org>
3810
3811         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3812         https://bugs.webkit.org/show_bug.cgi?id=109634
3813
3814         Reviewed by Adrienne Walker.
3815
3816         * DumpRenderTree/chromium/WebViewHost.cpp:
3817         (WebViewHost::createOutputSurface):
3818         (WebViewHost::initializeLayerTreeView):
3819
3820 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
3821
3822         [GTK] Re-enable 3D CSS transforms when using build-webkit
3823         https://bugs.webkit.org/show_bug.cgi?id=110402
3824
3825         Reviewed by Xan Lopez.
3826
3827         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
3828         when building WebKitGTK+.
3829
3830 2013-02-20  Roger Fong  <roger_fong@apple.com>
3831
3832         Get VS2010 Solution B&I ready.
3833         <rdar://problem/1322988>
3834
3835         Rubberstamped by Timothy Horton.        
3836         
3837         Add Production configurations.
3838         
3839         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3840         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3841         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
3842         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3843         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
3844         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3845         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3846         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3847         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
3848         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3849         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
3850         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3851         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3852         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
3853         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3854         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3855         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
3856         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3857         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3858         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3859         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
3860         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3861         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
3862         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3863         * win/record-memory/record-memory.vcxproj:
3864         * win/record-memory/record-memoryProduction.props: Added.
3865         * win/record-memory/record-memoryRelease.props:
3866
3867 2013-02-20  Dirk Schulze  <krit@webkit.org>
3868
3869         Enable CANVAS_PATH flag
3870         https://bugs.webkit.org/show_bug.cgi?id=108508
3871
3872         Reviewed by Simon Fraser.
3873
3874         Enable CANVAS_PATH flag on trunk.
3875
3876         * Scripts/webkitperl/FeatureList.pm:
3877
3878 2013-02-20  Tony Chang  <tony@chromium.org>
3879
3880         Parse author names with commas in ChangeLogs
3881         https://bugs.webkit.org/show_bug.cgi?id=110356
3882
3883         Reviewed by Dirk Pranke.
3884
3885         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
3886
3887         * Scripts/webkitpy/common/checkout/changelog.py:
3888         (ChangeLogEntry): Move name splitting regexp into a constant.
3889         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
3890         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
3891         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
3892         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
3893         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3894         (test_parse_authors): Test case with Paweł's name.
3895
3896 2013-02-15  Dirk Schulze  <krit@webkit.org>
3897
3898         [Chromium] Add runtime flag for CanvasPath
3899         https://bugs.webkit.org/show_bug.cgi?id=109997
3900
3901         Reviewed by Adam Barth.
3902
3903         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
3904         the constructor for Path on DOMWindow would never be activatable, since the script
3905         is running after creating the DOMWindow object.
3906
3907         * DumpRenderTree/chromium/TestShell.cpp:
3908         (TestShell::TestShell):
3909
3910 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3911
3912         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
3913         https://bugs.webkit.org/show_bug.cgi?id=110346
3914
3915         Reviewed by Adam Barth.
3916
3917         Using an index is very brittle, as the TestRunner API does not define
3918         any ordering of windows.
3919
3920         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
3921         trigger the capturing in the browser process before generating the
3922         text dump.
3923
3924         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3925         (WebTestRunner):
3926         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3927         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3928         (WebTestRunner):
3929         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3930         (TestRunner):
3931         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3932         (WebTestRunner::WebTestProxyBase::captureTree):
3933         * DumpRenderTree/chromium/WebViewHost.cpp:
3934         (WebViewHost::captureHistoryForWindow):
3935         * DumpRenderTree/chromium/WebViewHost.h:
3936         (WebViewHost):
3937
3938 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
3939
3940         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
3941         https://bugs.webkit.org/show_bug.cgi?id=109220
3942
3943         Reviewed by Tony Chang.
3944
3945         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3946         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
3947         (WebTestRunner):
3948         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
3949         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
3950         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
3951         (MockSpellCheck):
3952         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
3953         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
3954
3955 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3956
3957         [Gtk] HTML5 Media controls require a design refresh
3958         https://bugs.webkit.org/show_bug.cgi?id=83869
3959
3960         Reviewed by Philippe Normand.
3961
3962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3963         (initializeGtkFontSettings): Added gnome as default icon theme for
3964         the DRT.
3965         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3966         (WTR::initializeGtkSettings): Added gnome as default icon theme for
3967         the WTR.
3968         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
3969         dependency.
3970
3971 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3972
3973         [chromium] move most of the remaining mocks to TestRunner library
3974         https://bugs.webkit.org/show_bug.cgi?id=110217
3975
3976         Reviewed by Nico Weber.
3977
3978         While most of the functionality provided by these mocks is also
3979         available in the content module, there is no straight forward way to
3980         inject the mock results required for layout tests.
3981
3982         * DumpRenderTree/DumpRenderTree.gypi:
3983         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3984         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3985         (WebKit):
3986         (WebTestRunner):
3987         (WebTestRunner::WebTestProxy::geolocationClient):
3988         (WebTestRunner::WebTestProxy::speechInputController):
3989         (WebTestRunner::WebTestProxy::speechRecognizer):
3990         (WebTestRunner::WebTestProxy::deviceOrientationClient):
3991         (WebTestRunner::WebTestProxy::requestPointerLock):
3992         (WebTestRunner::WebTestProxy::requestPointerUnlock):
3993         (WebTestRunner::WebTestProxy::isPointerLocked):
3994         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
3995         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
3996         (WebTestRunner):
3997         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
3998         (WebTestRunner::MockWebSpeechInputController::setDelegate):
3999         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
4000         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
4001         (WebTestRunner::MockWebSpeechInputController::clearResults):
4002         (WebTestRunner::MockWebSpeechInputController::startRecognition):
4003         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
4004         (WebTestRunner::MockWebSpeechInputController::stopRecording):
4005         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
4006         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
4007         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
4008         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
4009         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
4010         (WebKit):
4011         (WebTestRunner):
4012         (MockWebSpeechInputController):
4013         (WebTestRunner::MockWebSpeechInputController::taskList):
4014         (SpeechTask):
4015         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
4016         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
4017         (WebTestRunner):
4018         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
4019         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
4020         (WebTestRunner::MockWebSpeechRecognizer::start):
4021         (WebTestRunner::MockWebSpeechRecognizer::stop):
4022         (WebTestRunner::MockWebSpeechRecognizer::abort):
4023         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
4024         (WebTestRunner::MockWebSpeechRecognizer::setError):
4025         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
4026         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
4027         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
4028         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
4029         (WebKit):
4030         (WebTestRunner):
4031         (MockWebSpeechRecognizer):
4032         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
4033         (WebTestRunner::MockWebSpeechRecognizer::client):
4034         (WebTestRunner::MockWebSpeechRecognizer::handle):
4035         (WebTestRunner::MockWebSpeechRecognizer::taskList):
4036         (Task):
4037         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
4038         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
4039         (StepTask):
4040         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
4041         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4042         (WebTestRunner::TestInterfaces::TestInterfaces):
4043         (WebTestRunner::TestInterfaces::windowOpened):
4044         (WebTestRunner):
4045         (WebTestRunner::TestInterfaces::windowClosed):
4046         (WebTestRunner::TestInterfaces::windowList):
4047         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4048         (TestInterfaces):
4049         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4050         (WebTestRunner::TestRunner::TestRunner):
4051         (WebTestRunner::TestRunner::reset):
4052         (WebTestRunner::TestRunner::requestPointerLock):
4053         (WebTestRunner):
4054         (WebTestRunner::TestRunner::requestPointerUnlock):
4055         (WebTestRunner::TestRunner::isPointerLocked):
4056         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
4057         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
4058         (WebTestRunner::TestRunner::didLosePointerLockInternal):
4059         (WebTestRunner::TestRunner::windowCount):
4060         (WebTestRunner::TestRunner::setMockDeviceOrientation):
4061         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
4062         (WebTestRunner::TestRunner::setGeolocationPermission):
4063         (WebTestRunner::TestRunner::setMockGeolocationPosition):
4064         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
4065         (WebTestRunner::TestRunner::addMockSpeechInputResult):
4066         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
4067         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
4068         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
4069         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
4070         (WebTestRunner::TestRunner::didAcquirePointerLock):
4071         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
4072         (WebTestRunner::TestRunner::didLosePointerLock):
4073         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
4074         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
4075         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4076         (WebTestRunner):
4077         (TestRunner):
4078         (HostMethodTask):
4079         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
4080         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
4081         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4082         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
4083         (WebTestRunner::WebTestProxyBase::setInterfaces):
4084         (WebTestRunner::WebTestProxyBase::setDelegate):
4085         (WebTestRunner::WebTestProxyBase::reset):
4086         (WebTestRunner::WebTestProxyBase::captureTree):
4087         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
4088         (WebTestRunner):
4089         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
4090         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
4091         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
4092         (WebTestRunner::WebTestProxyBase::geolocationClient):
4093         (WebTestRunner::WebTestProxyBase::speechInputController):
4094         (WebTestRunner::WebTestProxyBase::speechRecognizer):
4095         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
4096         (WebTestRunner::WebTestProxyBase::requestPointerLock):
4097         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
4098         (WebTestRunner::WebTestProxyBase::isPointerLocked):
4099         * DumpRenderTree/chromium/WebViewHost.cpp:
4100         (WebViewHost::reset):
4101         * DumpRenderTree/chromium/WebViewHost.h:
4102         (WebKit):
4103         (WebViewHost):
4104
4105 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
4106
4107         [Qt] Make debug builds possible on 32bit Linux
4108         https://bugs.webkit.org/show_bug.cgi?id=110231
4109
4110         Reviewed by Tor Arne Vestbø.
4111
4112         Use the stabs format for debug builds to make the object files
4113         a bit smaller so that they can be linked on a 32bit system.
4114
4115         * qmake/mkspecs/features/unix/default_post.prf:
4116
4117 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
4118
4119         Unreviewed. Add myself to watch lists.
4120
4121         * Scripts/webkitpy/common/config/committers.py:
4122         * Scripts/webkitpy/common/config/watchlist:
4123
4124 2013-02-19  Joshua Bell  <jsbell@chromium.org>
4125
4126         Remove warning from run-bindings-tests
4127         https://bugs.webkit.org/show_bug.cgi?id=110285
4128
4129         Reviewed by Kentaro Hara.
4130
4131         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
4132         "Unknown option: idlattributesfile". That option was removed from
4133         bindings/scripts/preprocess-idls.pl but was still being passed by
4134         the test script. Remove it.
4135
4136         * Scripts/webkitpy/bindings/main.py:
4137         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
4138
4139 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
4140
4141         Unreviewed. Add myself to watch lists.
4142
4143         * Scripts/webkitpy/common/config/committers.py:
4144         * Scripts/webkitpy/common/config/watchlist:
4145
4146 2013-02-19  Hans Muller  <hmuller@adobe.com>
4147
4148         Unreviewed, corrected primary email.
4149
4150         * Scripts/webkitpy/common/config/committers.py:
4151
4152 2013-02-19  Hans Muller  <hmuller@adobe.com>
4153
4154         Unreviewed. Adding myself as a committer.
4155
4156         * Scripts/webkitpy/common/config/committers.py:
4157
4158 2013-02-19  Pravin D  <pravind@webkit.org>
4159
4160         Unreviewed, changing primary email.
4161
4162         * Scripts/webkitpy/common/config/committers.py:
4163
4164 2013-02-19  Alan Cutter  <alancutter@chromium.org>
4165
4166         REGRESSION: Sheriffbot is failing to process rollout requests
4167         https://bugs.webkit.org/show_bug.cgi?id=106945
4168
4169         Reviewed by Adam Barth.
4170
4171         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
4172         This resolves problems when Sheriffbot attempts to perform a rollout request.
4173
4174         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4175         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
4176         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
4177
4178 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
4179
4180         Unreviewed build fix.
4181
4182         * efl/jhbuild.modules:
4183         * gtk/jhbuild.modules:
4184
4185         Bump harfbuzz module to 0.9.7. See related bug 110145.
4186
4187 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
4188
4189         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
4190         https://bugs.webkit.org/show_bug.cgi?id=110215
4191
4192         Reviewed by Tor Arne Vestbø.
4193
4194         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
4195         continuing the build. Otherwise skip with an error message explaining which
4196         programs are missing from the build.
4197
4198         * qmake/mkspecs/features/configure.prf:
4199         * qmake/mkspecs/features/functions.prf:
4200
4201 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
4202
4203         Unreviewed, rolling out r143319.
4204         http://trac.webkit.org/changeset/143319
4205         https://bugs.webkit.org/show_bug.cgi?id=110214
4206
4207         Causes build issues on win32 (Requested by carewolf on
4208         #webkit).
4209
4210         * qmake/mkspecs/features/features.pri:
4211
4212 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4213
4214         [Qt] Enable MathML
4215         https://bugs.webkit.org/show_bug.cgi?id=110205
4216
4217         Reviewed by Simon Hausmann.
4218
4219         * qmake/mkspecs/features/features.pri:
4220
4221 2013-02-17  Andrei Bucur  <abucur@adobe.com>
4222
4223         Unreviewed. Adding myself as a committer.
4224
4225         * Scripts/webkitpy/common/config/committers.py:
4226
4227 2013-02-19  Hajime Morrita  <morrita@google.com>
4228
4229         Unreviewed, updated spelling of my name.
4230
4231         * Scripts/webkitpy/common/config/committers.py:
4232
4233 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
4234
4235         Unreviewed. Adjust expectations.
4236
4237         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
4238         (TestWebKitAPI::TEST):
4239
4240 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
4241
4242         Unreviewed GTK gardening.
4243
4244         * Scripts/run-gtk-tests:
4245         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
4246
4247 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4248
4249         [Qt][WK2] Remove duped test name and append new test in project file
4250         https://bugs.webkit.org/show_bug.cgi?id=110117
4251
4252         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
4253         add this test into the runnable test suite and remove a duped test in project file.
4254
4255         Reviewed by Jocelyn Turcotte.
4256
4257         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
4258
4259 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
4260
4261         [chromium] remove log spew from dumpAllBackForwardLists
4262         https://bugs.webkit.org/show_bug.cgi?id=110108
4263
4264         Reviewed by Nico Weber.
4265
4266         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4267
4268 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4269
4270         [EFL][WK2] Disable failing API tests
4271         https://bugs.webkit.org/show_bug.cgi?id=110081
4272
4273         Reviewed by Kenneth Rohde Christiansen.
4274
4275         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
4276
4277         * TestWebKitAPI/PlatformEfl.cmake:
4278
4279 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
4280
4281         [Qt] Disable the build if certain configure checks fail
4282         https://bugs.webkit.org/show_bug.cgi?id=110094
4283
4284         Reviewed by Tor Arne Vestbø.
4285
4286         Allow for the build to be skipped (clear out SUBDIRS) if certain
4287         configure conditions aren't met.
4288
4289         * qmake/mkspecs/features/configure.prf:
4290
4291 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4292
4293         [Qt][WK2] Support WK2 API tests
4294         https://bugs.webkit.org/show_bug.cgi?id=109843
4295
4296         Reviewed by Jocelyn Turcotte.
4297
4298         * TestWebKitAPI/DerivedSources.pri: Added.
4299         * TestWebKitAPI/InjectedBundle.pri: Added.
4300         * TestWebKitAPI/PlatformWebView.h:
4301         * TestWebKitAPI/TestWebKitAPI.pri:
4302         * TestWebKitAPI/TestWebKitAPI.pro:
4303         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
4304         * TestWebKitAPI/Tests/WTF/WTF.pro:
4305         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
4306         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
4307         (TestWebKitAPI::Util::sleep):
4308         (TestWebKitAPI::Util::createInjectedBundlePath):
4309         (TestWebKitAPI::Util::createURLForResource):
4310         (TestWebKitAPI::Util::isKeyDown):
4311         (Util):
4312         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
4313         (TestWebKitAPI):
4314         (WrapperWindow):
4315         (TestWebKitAPI::WrapperWindow::WrapperWindow):
4316         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
4317         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4318         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4319         (TestWebKitAPI::PlatformWebView::resizeTo):