1 2015-11-03 Commit Queue <commit-queue@webkit.org>
3 Unreviewed, rolling out r191995.
4 https://bugs.webkit.org/show_bug.cgi?id=150880
6 Broke iOS tests (Requested by ap on #webkit).
10 "run-webkit-test should look in --root directory for
12 https://bugs.webkit.org/show_bug.cgi?id=150859
13 http://trac.webkit.org/changeset/191995
15 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
17 Add graphics benchmark to performance bot
18 https://bugs.webkit.org/show_bug.cgi?id=150450
20 Reviewed by Chris Dumez.
22 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
23 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
24 Add a patch and a plan to set the defaults of the benchmark, run it,
25 collect the result and report it to the benchmark runner.
27 2015-11-03 Jason Marcell <jmarcell@apple.com>
29 run-webkit-test should look in --root directory for LayoutTestRelay
30 https://bugs.webkit.org/show_bug.cgi?id=150859
32 Reviewed by Daniel Bates.
34 For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
35 LayoutTestRelay in the Mac build directory when --root is unspecified.
37 * Scripts/webkitpy/port/ios.py:
38 (IOSSimulatorPort.relay_path):
40 2015-11-03 Alexey Proskuryakov <ap@apple.com>
42 build.webkit.org/dashboard should use ISO dates in Trac URLs
43 https://bugs.webkit.org/show_bug.cgi?id=150855
45 Reviewed by Darin Adler.
47 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
48 (Trac.prototype._xmlTimelineURL):
50 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
52 Unreviewed, add myself to the SVG watchlist.
54 * Scripts/webkitpy/common/config/watchlist:
56 2015-11-03 Wenson Hsieh <wenson_hsieh@apple.com>
58 Fix touch event sending crash in WebKitTestRunner
59 https://bugs.webkit.org/show_bug.cgi?id=150848
60 <rdar://problem/23360841>
62 Reviewed by Simon Fraser.
64 Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
66 * WebKitTestRunner/ios/HIDEventGenerator.mm:
67 (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
69 2015-11-03 Brent Fulgham <bfulgham@apple.com>
71 [Win] Unreviewed build fix after r191958.
73 * MiniBrowser/win/MiniBrowser.h: Add missing include.
74 * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
76 2015-11-02 Jiewen Tan <jiewen_tan@apple.com>
78 Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
80 * Scripts/webkitpy/common/config/contributors.json:
82 2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
84 Unreviewed, add unittest after r191827.
86 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
88 2015-11-02 Andy Estes <aestes@apple.com>
90 [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
91 https://bugs.webkit.org/show_bug.cgi?id=150819
93 Reviewed by Dan Bernstein.
95 This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
97 * DumpRenderTree/mac/Configurations/Base.xcconfig:
98 * MiniBrowser/Configurations/Base.xcconfig:
99 * TestWebKitAPI/Configurations/Base.xcconfig:
100 * WebKitTestRunner/Configurations/Base.xcconfig:
102 2015-11-02 Anders Carlsson <andersca@apple.com>
104 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
105 https://bugs.webkit.org/show_bug.cgi?id=150739
107 Reviewed by Tim Horton.
109 Add a test. We only test the encoding right now.
111 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
112 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
114 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
115 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
117 2015-11-02 Tim Horton <timothy_horton@apple.com>
119 Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
120 https://bugs.webkit.org/show_bug.cgi?id=150174
122 Reviewed by Anders Carlsson.
124 * WebKitTestRunner/mac/EventSenderProxy.mm:
125 (WTR::EventSenderProxy::mouseUp):
126 (WTR::EventSenderProxy::mouseMoveTo):
127 Revert some parts of r188828 which no longer apply.
129 2015-10-30 Dana Burkart <dburkart@apple.com>
131 svn-apply should handle unified diffs
132 https://bugs.webkit.org/show_bug.cgi?id=150650
134 Reviewed by Darin Adler.
136 * Scripts/VCSUtils.pm:
137 (parseUnifiedDiffHeader):
138 This method parses a unified diff header, and returns a information in the
139 style of parseGitDiffHeader and parseSvnDiffHeader.
142 Teach parseDiffHeader to recognize unified diff headers.
145 Teach parseDiff to recognize unified diffs.
147 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
148 * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
150 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
152 Fix the FTL JIT build with system LLVM on Linux
153 https://bugs.webkit.org/show_bug.cgi?id=150795
155 Reviewed by Filip Pizlo.
157 * efl/install-dependencies:
158 * gtk/install-dependencies:
160 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
162 [EFL] Bump harfbuzz versions to 0.9.35
163 https://bugs.webkit.org/show_bug.cgi?id=150448
165 Reviewed by Gyuyoung Kim.
167 * efl/jhbuild.modules:
169 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
171 [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
172 https://bugs.webkit.org/show_bug.cgi?id=150622
174 Reviewed by Gyuyoung Kim.
176 * efl/install-dependencies:
177 * efl/jhbuild.modules:
179 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
181 Fix EFL jhbuild module build on Ubuntu 15.10
182 https://bugs.webkit.org/show_bug.cgi?id=150621
184 Reviewed by Gyuyoung Kim.
186 * efl/jhbuild.modules:
187 * efl/patches/efl-remove-XPrint.patch: Added.
189 2015-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
191 [GLIB] Remove delete on destroy GMainLoopSources
192 https://bugs.webkit.org/show_bug.cgi?id=150771
194 Reviewed by Žan Doberšek.
196 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
197 (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
198 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
199 (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
201 2015-11-01 Yusuke Suzuki <utatane.tea@gmail.com>
203 [ES6] Support Generator Syntax
204 https://bugs.webkit.org/show_bug.cgi?id=150769
206 Reviewed by Geoffrey Garen.
208 Added ENABLE_ES6_GENERATORS flag.
210 * Scripts/webkitperl/FeatureList.pm:
212 2015-11-01 Alexey Proskuryakov <ap@apple.com>
214 Sort EWS bots in popovers
215 https://bugs.webkit.org/show_bug.cgi?id=150782
217 Reviewed by Darin Adler.
219 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
220 (BubbleQueueView.prototype._popoverContentForBubbleQueue):
222 2015-10-31 Filip Pizlo <fpizlo@apple.com>
224 B3::reduceStrength's DCE should be more agro and less wrong
225 https://bugs.webkit.org/show_bug.cgi?id=150748
227 Reviewed by Geoffrey Garen.
229 Add an LLVM version of testb3's "testComplex".
231 * ReducedFTL/ComplexTest.cpp: Added.
233 2015-11-01 Commit Queue <commit-queue@webkit.org>
235 Unreviewed, rolling out r191831.
236 https://bugs.webkit.org/show_bug.cgi?id=150774
238 The new test fails (Requested by ap on #webkit).
242 "Begin work on supporting reply blocks in
243 _WKRemoteObjectRegistry"
244 https://bugs.webkit.org/show_bug.cgi?id=150739
245 http://trac.webkit.org/changeset/191831
247 2015-10-31 Andreas Kling <akling@apple.com>
249 Add a debug overlay with information about web process resource usage.
250 <https://webkit.org/b/150599>
252 Reviewed by Darin Adler.
254 Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
256 * MiniBrowser/mac/SettingsController.h:
257 * MiniBrowser/mac/SettingsController.m:
258 (-[SettingsController _populateMenu]):
259 (-[SettingsController validateMenuItem:]):
260 (-[SettingsController toggleShowResourceUsageOverlay:]):
261 (-[SettingsController resourceUsageOverlayVisible]):
262 * MiniBrowser/mac/WK2BrowserWindowController.m:
263 (-[WK2BrowserWindowController didChangeSettings]):
265 2015-10-31 Lucas Forschler <lforschler@apple.com>
267 Teach the CompileWebKit step to look for additional arguments.
269 Unreviewed config change.
271 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
272 (CompileWebKit.start):
274 2015-10-30 Anders Carlsson <andersca@apple.com>
276 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
277 https://bugs.webkit.org/show_bug.cgi?id=150739
279 Reviewed by Tim Horton.
281 Add a test. We only test the encoding right now.
283 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
284 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
286 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
287 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
289 2015-10-30 Lucas Forschler <lforschler@apple.com>
291 Add CMAke builder to build.webkit.org
292 https://bugs.webkit.org/show_bug.cgi?id=150738
294 Reviewed by Alex Christensen.
296 * BuildSlaveSupport/build.webkit.org-config/config.json:
298 2015-10-30 Brent Fulgham <bfulgham@apple.com>
300 [Win] build-jsc and run-javascriptcore-tests do not work
301 https://bugs.webkit.org/show_bug.cgi?id=150700
303 Reviewed by Mark Lam.
305 Correct our build system so that it expects Windows to be using CMake,
306 and to build the correct sub-projects for our JSC helper scripts.
308 * Scripts/build-jsc: Make sure to build the testapi harness when
309 building for Windows.
310 * Scripts/build-webkit:
311 (1) Use the existing 'cmakeBasedPortName()'
312 (2) Use File::Spec rather than hard-coding path delimeters.
313 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
314 method rather than hard-coding the name based on conditional.
315 * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
316 LLVM libraries on Apple Windows build.
317 * Scripts/run-javascriptcore-tests:
318 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
319 * Scripts/run-jsc: Ditto.
320 * Scripts/webkitdirs.pm:
321 (cmakeBasedPortName): Update to return the right value for the Apple
322 Windows port and the WinCairo port.
323 (isCMakeBuild): Expect CMake build for all Windows ports.
325 2015-10-30 Carlos Garcia Campos <cgarcia@igalia.com>
327 [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
328 https://bugs.webkit.org/show_bug.cgi?id=150665
330 Reviewed by Csaba Osztrogonác.
332 We check it only to wipe the directory or not, but we are still
333 tryihng to update every module even when the configuration hasn't
334 changed. This is problematic because it makes the whole build fail
335 when any repository fails to checkout an already checked out
336 revision, because the server is down for example. This is even
337 more problematic for the bots that skip perfectly valid revisions.
338 It's still possible to force an update passing --force command
341 * Scripts/update-webkit-libs-jhbuild:
342 (deleteJhbuildMd5): Delete the md5sum files if exist.
343 (runJhbuild): Return early if the md5sum files haven't
344 changed. Only write them after a successful build and delete them
345 if the build fails to ensure we don't skip next run.
347 2015-10-30 Philippe Normand <pnormand@igalia.com>
349 [GTK] Fix MacCLang build errors in Tools
350 https://bugs.webkit.org/show_bug.cgi?id=150031
352 Reviewed by Carlos Garcia Campos.
354 * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
355 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
356 * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
357 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
359 2015-10-29 Hunseop Jeong <hs85.jeong@samsung.com>
361 [EFL] MiniBrowser didn't work after r191749.
362 https://bugs.webkit.org/show_bug.cgi?id=150706
364 Reviewed by Alex Christensen.
366 Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
368 * Scripts/run-minibrowser:
370 2015-10-29 Commit Queue <commit-queue@webkit.org>
372 Unreviewed, rolling out r191766.
373 https://bugs.webkit.org/show_bug.cgi?id=150707
375 Problem with Cygwin build (Requested by bfulgham_ on #webkit).
379 "[Win] build-jsc and run-javascriptcore-tests do not work"
380 https://bugs.webkit.org/show_bug.cgi?id=150700
381 http://trac.webkit.org/changeset/191766
383 2015-10-29 Brent Fulgham <bfulgham@apple.com>
385 [Win] build-jsc and run-javascriptcore-tests do not work
386 https://bugs.webkit.org/show_bug.cgi?id=150700
388 Reviewed by Mark Lam.
390 Correct our build system so that it expects Windows to be using CMake,
391 and to build the correct sub-projects for our JSC helper scripts.
393 * Scripts/build-jsc: Make sure to build the testapi harness when
394 building for Windows.
395 * Scripts/build-webkit:
396 (1) Use the existing 'cmakeBasedPortName()'
397 (2) Use File::Spec rather than hard-coding path delimeters.
398 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
399 method rather than hard-coding the name based on conditional.
400 * Scripts/run-javascriptcore-tests:
401 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
402 * Scripts/run-jsc: Ditto.
403 * Scripts/webkitdirs.pm:
404 (cmakeBasedPortName): Update to return the right value for the Apple
405 Windows port and the WinCairo port.
406 (isCMakeBuild): Expect CMake build for all Windows ports.
408 2015-10-29 Alex Christensen <achristensen@webkit.org>
410 Fix build-jsc on Mac after r191749.
413 Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
415 2015-10-29 Alex Christensen <achristensen@webkit.org>
418 https://bugs.webkit.org/show_bug.cgi?id=150686
420 Reviewed by Filip Pizlo.
422 * Scripts/build-webkit:
423 * Scripts/webkitdirs.pm:
424 (isCachedArgumentfileOutOfDate):
425 (wrapperPrefixIfNeeded):
426 (generateBuildSystemFromCMakeProject):
427 (buildCMakeGeneratedProject):
428 (cmakeBasedPortName):
429 (determineIsCMakeBuild):
432 (jhbuildWrapperPrefixIfNeeded): Deleted.
434 2015-10-29 Lucas Forschler <lforschler@apple.com>
436 Teach JSC bots to build 32bit instead of x86_64
438 Reviewed by Mark Lam.
440 * BuildSlaveSupport/build.webkit.org-config/config.json:
442 2015-10-29 Per Arne Vollan <peavo@outlook.com>
444 [WinCairo] Fall back to AppleWin results in layout tests.
445 https://bugs.webkit.org/show_bug.cgi?id=150672
447 Reviewed by Alex Christensen.
449 * Scripts/webkitpy/port/win.py:
451 (WinCairoPort.default_baseline_search_path):
453 2015-10-28 Keith Rollin <krollin@apple.com>
455 Do not sanitize user input for input[type=url]
456 https://bugs.webkit.org/show_bug.cgi?id=150346
457 <rdar://problem/23243240>
459 Reviewed by Brent Fulgham.
461 The Windows version of DumpRenderTree's eventSender.keyDown handler
462 simulates user-entry by decomposing the given character into a virtual
463 key code and a set of modifier keys. The code that determines if the
464 shift key should be simulated only worked if the character was an
465 upper case character. Extend this support to also include symbols that
466 (on the U.S. keyboard) require holding down the shift key.
468 This change allows fast/forms/input-user-input-sanitization.html
469 to succeed, which requires us to simulate the entering of '@' and ':'.
471 * DumpRenderTree/win/EventSender.cpp:
474 2015-10-28 Alex Christensen <achristensen@webkit.org>
476 Compile and link with CMake on Mac
477 https://bugs.webkit.org/show_bug.cgi?id=150632
479 Reviewed by Tim Horton.
481 * TestWebKitAPI/PlatformMac.cmake:
483 2015-10-28 Xabier Rodriguez Calvar <calvaris@igalia.com>
487 * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
489 2015-10-28 Per Arne Vollan <peavo@outlook.com>
491 Add WinCairo to list of ports in run-webkit-tests.
492 https://bugs.webkit.org/show_bug.cgi?id=150625
494 Reviewed by Brent Fulgham.
496 * Scripts/webkitpy/common/config/ports.py:
497 (DeprecatedPort.port):
498 (WinPort.run_webkit_tests_command):
501 * Scripts/webkitpy/port/factory.py:
503 * Scripts/webkitpy/port/win.py:
504 (WinPort.find_system_pid):
507 2015-10-27 Alexey Proskuryakov <ap@apple.com>
509 WebKitTestRunner leaks in generateWhitelist()
510 https://bugs.webkit.org/show_bug.cgi?id=150563
512 Reviewed by Andreas Kling.
514 * WebKitTestRunner/mac/TestControllerMac.mm:
515 (WTR::generateWhitelist):
517 2015-10-27 Anders Carlsson <andersca@apple.com>
519 Add an API test for _WKRemoteObjectRegistry
520 https://bugs.webkit.org/show_bug.cgi?id=150597
522 Reviewed by Andreas Kling.
524 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
525 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
526 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
528 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
529 (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
530 (-[RemoteObjectRegistryPlugIn sayHello:]):
532 2015-10-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
534 Add myself to the reviewers list
535 https://bugs.webkit.org/show_bug.cgi?id=150581
539 * Scripts/webkitpy/common/config/contributors.json:
541 2015-10-26 Ryan Haddad <ryanhaddad@apple.com>
543 Adding myself to contributors.json
545 * Scripts/webkitpy/common/config/contributors.json:
547 2015-10-26 Tim Horton <timothy_horton@apple.com>
549 Don't expose the whitelist/blacklist in _WKUserStyleSheet
550 https://bugs.webkit.org/show_bug.cgi?id=150566
552 Reviewed by Anders Carlsson.
554 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
557 2015-10-26 Philippe Normand <pnormand@igalia.com>
559 Unreviewed, rolling out r191576.
565 "[GStreamer] Bump internal jhbuild versions to 1.6.0"
566 https://bugs.webkit.org/show_bug.cgi?id=149594
567 http://trac.webkit.org/changeset/191576
569 2015-10-26 ChangSeok Oh <changseok.oh@collabora.com>
571 [GStreamer] Bump internal jhbuild versions to 1.6.0
572 https://bugs.webkit.org/show_bug.cgi?id=149594
574 Reviewed by Philippe Normand.
576 Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
577 useful so they are removed accordingly.
579 * gtk/jhbuild.modules:
580 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
581 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
582 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
584 2015-10-25 Alexey Proskuryakov <ap@apple.com>
586 API tests fail on El Capitan after r191543
587 https://bugs.webkit.org/show_bug.cgi?id=150547
589 Reviewed by Dan Bernstein.
591 * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
593 2015-10-24 Tim Horton <timothy_horton@apple.com>
595 Add a way to add user style sheets to WKUserContentController
596 https://bugs.webkit.org/show_bug.cgi?id=150531
597 <rdar://problem/23191691>
599 Reviewed by Darin Adler.
601 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
604 2015-10-24 Tim Horton <timothy_horton@apple.com>
606 Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
607 https://bugs.webkit.org/show_bug.cgi?id=150525
609 Reviewed by Darin Adler.
611 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
613 Test the various new keys.
615 2015-10-24 Frederic Wang <fred.wang@free.fr>
617 check-webkit-style complains about missing operator whitespace inside character literal
618 https://bugs.webkit.org/show_bug.cgi?id=150396
620 Reviewed by Darin Adler.
622 * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
623 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
624 (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
626 2015-10-23 Michael Saboff <msaboff@apple.com>
628 REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
629 https://bugs.webkit.org/show_bug.cgi?id=150513
631 Reviewed by Saam Barati.
633 Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
635 * DumpRenderTree/TestRunner.cpp:
636 (simulateWebNotificationClickCallback):
638 (numberOfDFGCompiles):
639 (TestRunner::staticFunctions):
640 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
641 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
642 (WTR::TestRunner::setBlockAllPlugins):
643 (WTR::TestRunner::failNextCodeBlock):
644 (WTR::TestRunner::numberOfDFGCompiles):
645 * WebKitTestRunner/InjectedBundle/TestRunner.h:
647 2015-10-23 Anders Carlsson <andersca@apple.com>
649 Simplify the WebKitLegacy menu conversion code
650 https://bugs.webkit.org/show_bug.cgi?id=150509
652 Reviewed by Andreas Kling.
654 Implement the context menu delegate method so we'll test that code path.
656 * MiniBrowser/mac/WK1BrowserWindowController.m:
657 (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
659 2015-10-23 Per Arne Vollan <peavo@outlook.com>
661 [WinCairo] Improve test results for fast layouttests.
662 https://bugs.webkit.org/show_bug.cgi?id=150464
664 Reviewed by Alex Christensen.
666 Set custom device scale factor to 1.0.
668 * DumpRenderTree/win/DumpRenderTree.cpp:
669 (createWebViewAndOffscreenWindow):
671 2015-10-23 Mark Salisbury <mark.salisbury@hp.com>
673 [GTK] update-webkitgtk-libs should use mesa tarball
675 https://bugs.webkit.org/show_bug.cgi?id=150470
677 update-webkitgtk-libs downloads all build dependencies; in fixing
678 bug 148941 mesa was switched from ftp to git access. Now an http
679 tarball is available, which is preferred over accessing via git.
681 Reviewed by Philippe Normand
683 * gtk/jhbuild.modules:
684 Mesa access changed to http tarball.
686 2015-10-22 Sam Weinig <sam@webkit.org>
688 Navigations on the same host (but with different schemes and ports) should not trigger universal links
689 <rdar://problem/22811325>
690 https://bugs.webkit.org/show_bug.cgi?id=150481
692 Reviewed by Dan Bernstein.
694 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
695 Update test to test that navigations on the same host but with different schemes does not
696 trigger universal links, but that changes in the host do.
698 2015-10-22 Ryosuke Niwa <rniwa@webkit.org>
700 REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
701 https://bugs.webkit.org/show_bug.cgi?id=150428
703 Reviewed by Antti Koivisto.
705 Added a regression test using WebKit API test.
707 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708 * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
709 (TestWebKitAPI::didFinishLoadForFrame):
710 (TestWebKitAPI::TEST):
712 2015-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
714 Unreviewed. Fix GTK+ build after r191423.
716 Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
719 (WebKitDOMDocGenerator):
721 2015-10-22 Aakash Jain <aakash_jain@apple.com>
723 [Win][EFL][GTK] webkitpy test failed after r191374.
724 https://bugs.webkit.org/show_bug.cgi?id=150433
726 Reviewed by Alexey Proskuryakov.
728 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
729 (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
730 (CrashLogsTest.test_find_log_darwin): Same.
732 2015-10-21 Brian Burg <bburg@apple.com>
734 Unreviewed, update watchlist for JS builtins.
736 Add a category for JS builtins code generator, similar to other generators.
738 Add a nag message to rebaseline builtins generator tests when touching
739 code generator files in Source/JavaScriptCore/Scripts/builtins/.
741 * Scripts/webkitpy/common/config/watchlist:
743 2015-10-21 Brian Burg <bburg@apple.com>
745 Restructure generate-js-bindings script to be modular and testable
746 https://bugs.webkit.org/show_bug.cgi?id=149929
748 Reviewed by Alex Christensen.
750 Add a stub shell script and basic webkitpy support for running builtins
753 * Scripts/run-builtins-generator-tests: Added.
755 * Scripts/webkitpy/codegen/__init__.py: Added.
756 * Scripts/webkitpy/codegen/main.py: Added.
758 The only interesting difference here from the inspector protocol
759 generator equivalent is that this implementation decodes the target
760 framework and output mode (combined or separate) from the test's file name.
762 (BuiltinsGeneratorTests):
763 (BuiltinsGeneratorTests.__init__):
764 (BuiltinsGeneratorTests.generate_from_js_builtins):
765 (BuiltinsGeneratorTests.write_error_file):
766 (BuiltinsGeneratorTests.detect_changes):
767 (BuiltinsGeneratorTests.run_tests):
768 (BuiltinsGeneratorTests.main):
770 2015-10-21 Aakash Jain <aakash_jain@apple.com>
772 run-webkit-tests does not copy all crash logs for layout test failures on Mac
773 https://bugs.webkit.org/show_bug.cgi?id=150407
774 <rdar://problem/22239750>
776 Reviewed by Alexey Proskuryakov.
778 * Scripts/webkitpy/port/mac.py:
779 (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
780 (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
782 (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
783 from log directory and merge them with the list of already crashed tests.
785 2015-10-21 Filip Pizlo <fpizlo@apple.com>
787 Failures in PutStackSinkingPhase should be less severe
788 https://bugs.webkit.org/show_bug.cgi?id=150400
790 Reviewed by Geoffrey Garen.
792 Add a test mode for no PutStackSinkingPhase.
794 * Scripts/run-jsc-stress-tests:
796 2015-10-21 Nan Wang <n_wang@apple.com>
798 AX: Expose table size and cell indexes on iOS
799 https://bugs.webkit.org/show_bug.cgi?id=150366
801 Reviewed by Chris Fleizach.
803 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
804 (AccessibilityUIElement::rowCount):
805 (AccessibilityUIElement::columnCount):
806 (AccessibilityUIElement::indexInTable):
807 (AccessibilityUIElement::numberAttributeValue):
808 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
809 (WTR::AccessibilityUIElement::numberAttributeValue):
810 (WTR::AccessibilityUIElement::rowCount):
811 (WTR::AccessibilityUIElement::columnCount):
812 (WTR::AccessibilityUIElement::indexInTable):
814 2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
816 W3C test importer should not import reference files as regular tests
817 https://bugs.webkit.org/show_bug.cgi?id=150331
819 Reviewed by Darin Adler.
821 Updated test_parser to return information that a file can be a referencefile or a manual test.
822 Updated test importer to skip those files.
823 Updated/Added test parser unit tests accordingly.
825 Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
826 Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
827 to mark these files as Skip, since they are not direct tests.
829 * Scripts/webkitpy/w3c/test_importer.py:
830 (TestImporter.__init__):
831 (TestImporter.find_importable_tests):
832 (TestImporter.import_tests):
833 * Scripts/webkitpy/w3c/test_parser.py:
834 (TestParser.analyze_test):
835 * Scripts/webkitpy/w3c/test_parser_unittest.py:
836 (test_analyze_non_html_file):
837 (test_reference_test):
839 2015-10-20 Aakash Jain <aakash_jain@apple.com>
841 run-webkit-tests does not copy all crash logs for layout test failures on iOS
842 https://bugs.webkit.org/show_bug.cgi?id=150056
843 <rdar://problem/9280656>
845 Reviewed by Alexey Proskuryakov.
847 * Scripts/webkitpy/common/system/crashlogs.py:
848 (CrashLogs.find_all_logs): Generic method to find all crash logs.
849 (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
850 It iterates through log directory and returns all the logs based on timestamp.
851 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
852 (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
853 (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
854 (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
855 * Scripts/webkitpy/layout_tests/controllers/manager.py:
856 (Manager.run): Modified start_time to start counting before simulator launch
857 so that we can capture crashes during simualator launch.
858 (Manager._look_for_new_crash_logs): Browse through list of crashes and append
859 any test which is not already marked as CRASH to the run_results.
860 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
861 (TestExpectationsModel.get_expectations_string): return PASS in case there
862 are no expectations defined for this test.
863 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
864 (summarize_results): Add other_crashes in a separte category in full_results.json.
865 * Scripts/webkitpy/port/ios.py:
866 (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
867 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
868 from the log directory.
869 (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
870 logs from log directory and merge them with the list of already crashed tests.
872 2015-10-20 Dana Burkart <dburkart@apple.com>
878 My previous patch was missing a necessary space character.
880 * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
882 2015-10-20 Dana Burkart <dburkart@apple.com>
884 svn-apply fails to apply binary diffs in some cases
885 https://bugs.webkit.org/show_bug.cgi?id=64647
887 Reviewed by Daniel Bates.
889 * Scripts/VCSUtils.pm:
890 (decodeGitBinaryPatchDeltaSize): Modified.
891 We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
892 * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
894 2015-10-20 Alexey Proskuryakov <ap@apple.com>
896 Mac Debug EWS never finishes when there are failures
897 https://bugs.webkit.org/show_bug.cgi?id=150334
899 Reviewed by Daniel Bates.
901 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
902 * Scripts/webkitpy/tool/commands/queues.py:
904 2015-10-20 Philippe Normand <pnormand@igalia.com>
906 [GTK] Enable OpenWebRTC test video/audio sources in tests
908 This is needed because we can't expect the buildbots to have
909 webcam/mic devices plugged in.
911 Rubber-stamped by Carlos Garcia Campos.
913 * Scripts/run-gtk-tests:
914 (TestRunner._setup_testing_environment):
915 * Scripts/webkitpy/port/gtk.py:
916 (GtkPort.setup_environ_for_server):
918 2015-10-20 Yoav Weiss <yoav@yoav.ws>
920 Rename the PICTURE_SIZES flag to CURRENTSRC
921 https://bugs.webkit.org/show_bug.cgi?id=150275
923 Reviewed by Dean Jackson.
925 * Scripts/webkitperl/FeatureList.pm:
927 2015-10-19 Hunseop Jeong <hs85.jeong@samsung.com>
929 Unreviewed, add myself to the committers list.
931 * Scripts/webkitpy/common/config/contributors.json:
933 2015-10-19 Alexey Proskuryakov <ap@apple.com>
935 Add new EWS queues to bot watcher's dashboard
936 https://bugs.webkit.org/show_bug.cgi?id=150297
938 Reviewed by Darin Adler.
940 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
943 2015-10-19 ChangSeok Oh <changseok.oh@collabora.com>
945 REGRESSION(r190262): User media unit test failures after r190262
946 https://bugs.webkit.org/show_bug.cgi?id=149580
948 Reviewed by Carlos Garcia Campos.
950 The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
951 So we do not need to skip them anymore.
953 * Scripts/run-gtk-tests:
954 (TestRunner): Deleted.
956 2015-10-19 Csaba Osztrogonác <ossy@webkit.org>
958 Add historical addresses to contributors.json
959 https://bugs.webkit.org/show_bug.cgi?id=150227
961 Reviewed by Darin Adler.
963 * Scripts/webkitpy/common/config/contributors.json:
965 2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
967 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
968 https://bugs.webkit.org/show_bug.cgi?id=150307
970 Reviewed by Brent Fulgham.
972 The DLL build rules have been changed to generate "{Name}Lib.DLL",
973 but these changes have not yet been applied to the Visual Studio builds.
975 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
977 2015-10-16 Andreas Kling <akling@apple.com>
979 [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
980 <https://webkit.org/b/150153>
984 Just use simple arrays of LChar and UChar for this test instead of creating String
985 objects and then getting the characters8()/characters16() from them, since that
986 doesn't guarantee null-termination (the bug.)
988 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
989 (TestWebKitAPI::TEST):
990 (TestWebKitAPI::build): Deleted.
992 2015-10-16 Tim Horton <timothy_horton@apple.com>
994 WebKit2.AutoLayoutIntegration API test is failing on some of the bots
995 https://bugs.webkit.org/show_bug.cgi?id=150255
997 Reviewed by Simon Fraser.
999 * Scripts/run-api-tests:
1001 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1002 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
1003 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
1004 (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
1005 (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
1006 Don't set the layout size until after the load finishes and we're waiting
1007 for the reply, so that there is no race between the new size coming in
1008 and us waiting for it.
1010 2015-10-16 Anders Carlsson <andersca@apple.com>
1012 WebEditingDelegate should be a formal protocol
1013 https://bugs.webkit.org/show_bug.cgi?id=150254
1014 <rdar://problem/23149847>
1016 Reviewed by Dan Bernstein.
1018 * DumpRenderTree/mac/EditingDelegate.h:
1019 Conform to the WebEditingDelegate protocol.
1021 2015-10-16 Tim Horton <timothy_horton@apple.com>
1023 Hook up autolayout intrinsic sizing for WKWebView
1024 https://bugs.webkit.org/show_bug.cgi?id=150219
1025 <rdar://problem/20016905>
1027 Reviewed by Simon Fraser.
1029 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1030 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
1031 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
1032 (-[AutoLayoutWKWebView load:expectingContentSize:]):
1033 (-[AutoLayoutWKWebView expectContentSizeChange:]):
1034 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
1036 Add a variety of tests, including one which catches the bug that
1037 the WebCore part of this patch fixes.
1039 2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
1041 Update the help message of --system-malloc
1042 https://bugs.webkit.org/show_bug.cgi?id=150169
1044 Reviewed by Geoffrey Garen.
1046 * Scripts/webkitperl/FeatureList.pm:
1048 2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
1050 Update ImportExpectations according currently imported wpt tests
1051 https://bugs.webkit.org/show_bug.cgi?id=150158
1053 Reviewed by Chris Dumez.
1055 * Scripts/webkitpy/w3c/test_downloader.py:
1056 (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
1058 2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
1060 Unreviewed, Update my email address.
1062 * Scripts/webkitpy/common/config/contributors.json:
1064 2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
1066 [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
1067 https://bugs.webkit.org/show_bug.cgi?id=84960
1069 Reviewed by Žan Doberšek.
1071 * Scripts/run-gtk-tests:
1072 (TestRunner): Unskip tests using SessionState.
1073 * TestWebKitAPI/PlatformGTK.cmake: Add
1074 WKPageCopySessionStateWithFiltering test.
1076 2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
1078 [GTK] Missing return value on TestWebExtensions.cpp:193
1079 https://bugs.webkit.org/show_bug.cgi?id=149755
1081 Unreviewed. Add missing return value.
1083 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1084 (permissionRequestCallback):
1086 2015-10-14 Andy Estes <aestes@apple.com>
1088 [iOS] build-dumprendertree does not build ImageDiff
1089 https://bugs.webkit.org/show_bug.cgi?id=150152
1091 Reviewed by Tim Horton.
1093 run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
1094 On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
1095 as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
1096 WebKit.xcworkspace), tests that rely on image diffing won't work properly.
1098 There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
1099 fine on that platform, and results in ImageDiff being built.
1101 * Scripts/build-dumprendertree:
1103 2015-10-14 Brent Fulgham <bfulgham@apple.com>
1105 [Win] Enforce launcher/library naming scheme
1106 https://bugs.webkit.org/show_bug.cgi?id=150124
1108 Reviewed by Alex Christensen.
1110 * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
1111 * MiniBrowser/win/CMakeLists.txt: Ditto.
1112 * TestWebKitAPI/PlatformWin.cmake: Ditto.
1113 * win/DLLLauncher/DLLLauncherMain.cpp:
1114 (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
1115 original {name}.dll.
1117 2015-10-14 Andreas Kling <akling@apple.com>
1119 REGRESSION(r190882): Concatenating a character array and an empty string is broken.
1120 <https://webkit.org/b/150135>
1122 Reviewed by Geoffrey Garen.
1124 Add a new WTF API test that covers this issue.
1126 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1127 (TestWebKitAPI::build):
1128 (TestWebKitAPI::TEST):
1130 2015-10-14 Alex Christensen <achristensen@webkit.org>
1132 Add SPI for reloading without content blockers
1133 https://bugs.webkit.org/show_bug.cgi?id=150058
1134 rdar://problem/22742222
1136 Reviewed by Sam Weinig.
1138 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1139 (WTR::TestController::cocoaResetStateToConsistentValues):
1140 * WebKitTestRunner/mac/TestControllerMac.mm:
1141 (WTR::TestController::platformConfigureViewForTest):
1143 2015-10-14 Mark Lam <mark.lam@apple.com>
1145 Rename some JSC option names to be more uniform.
1146 https://bugs.webkit.org/show_bug.cgi?id=150127
1148 Reviewed by Geoffrey Garen.
1150 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1151 * Scripts/run-jsc-stress-tests:
1153 2015-10-14 Anders Carlsson <andersca@apple.com>
1155 Change the bundle app cache APIs to take a page
1156 https://bugs.webkit.org/show_bug.cgi?id=150123
1158 Reviewed by Sam Weinig.
1162 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1163 (WTR::InjectedBundle::beginTesting):
1164 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1165 (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1166 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1167 (WTR::TestRunner::clearAllApplicationCaches):
1168 (WTR::TestRunner::clearApplicationCacheForOrigin):
1169 (WTR::TestRunner::setAppCacheMaximumSize):
1170 (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1171 (WTR::TestRunner::originsWithApplicationCache):
1173 2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
1175 Update web-platform-tests tools to the latest revision
1176 https://bugs.webkit.org/show_bug.cgi?id=149645
1178 Reviewed by Darin Adler.
1180 Disabling git submodules information conversion to json install file for web-platform-tests.
1181 Disabling related python unit tests.
1182 The tools submodules contain submodules and the conversion tool does not support that yet.
1184 Updating wpt launcher script to aling it with web-platform-test main script.
1186 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1188 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1189 (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1190 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1191 (TestImporterTest.test_submodules_generation):
1193 2015-10-13 Alexey Proskuryakov <ap@apple.com>
1195 More debug queue build fixing.
1197 Preserve the build style in one more place. Changed mock build_style from "both"
1198 to "release", as we don't support testing both debug and release.
1200 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1201 (MockCommitQueue.archive_last_test_results):
1203 (MockCommitQueue.build_style):
1204 (MockCommitQueue.did_pass_testing_ews):
1205 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1206 (PatchAnalysisTask._test):
1207 (PatchAnalysisTask._build_and_test_without_patch):
1208 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1209 (EarlyWarningSystemTest._default_expected_logs):
1210 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1212 2015-10-13 Alexey Proskuryakov <ap@apple.com>
1214 More debug queue build fixing.
1216 Add build_style argument to derived classes as well.
1218 * Scripts/webkitpy/common/config/ports.py:
1220 (MacPort.run_webkit_tests_command):
1221 (WinPort.run_bindings_tests_command):
1223 (WinPort.run_webkit_tests_command):
1224 (GtkWK2Port.build_webkit_command):
1226 (GtkWK2Port.run_webkit_tests_command):
1228 2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
1234 Mach-O section names are limited to 16 characters.
1236 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1237 * DumpRenderTree/mac/DumpRenderTree.mm:
1240 2015-10-13 Alexey Proskuryakov <ap@apple.com>
1242 Build fix for mac-debug EWS queue.
1246 Pass --debug to run-webkit-tests.
1248 While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1249 will need to be substantially modified to work in EWS, so the dummy implementation
1252 * Scripts/webkitpy/common/config/ports.py:
1253 (DeprecatedPort.run_javascriptcore_tests_command):
1255 (DeprecatedPort.run_webkit_tests_command):
1256 (DeprecatedPort.run_python_unittests_command):
1257 (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1258 * Scripts/webkitpy/common/config/ports_mock.py:
1259 (MockPort.run_javascriptcore_tests_command):
1261 (MockPort.run_webkit_tests_command):
1262 (MockPort.run_bindings_tests_command):
1263 (MockPort.run_webkit_unit_tests_command): Deleted.
1264 * Scripts/webkitpy/tool/commands/download_unittest.py:
1265 * Scripts/webkitpy/tool/steps/runtests.py:
1267 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1268 (RunTestsTest.test_webkit_run_unit_tests):
1269 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1270 (StepsTest.test_runtests_args):
1272 2015-10-13 Brent Fulgham <bfulgham@apple.com>
1274 [Win] Generate Crash Traces
1275 https://bugs.webkit.org/show_bug.cgi?id=150103
1277 Reviewed by Daniel Bates.
1279 We were using an exception filter to try to emit "#CRASHED" to stderr
1280 when a test program crashed. However, the modern Python implementation
1281 seems capable of recognizing crashes on its own. Furthermore, registering
1282 the exception handler was preventing the JIT debugger (NTSD) from
1283 automatically attaching to the crashing program, so we were not getting
1286 * DumpRenderTree/win/DumpRenderTree.cpp:
1287 (main): Don't register an exception filter.
1288 (exceptionFilter): Deleted.
1289 * Scripts/webkitpy/common/system/crashlogs.py:
1290 (CrashLogs): Add another regular expression to handle a second crash trace
1291 syntax I encountered during testing.
1292 (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1293 try the new one. The PID found by the new expression is in hexadecimal, so
1294 convert it to an integer before returning it.
1295 * Scripts/webkitpy/port/driver.py:
1296 (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1297 the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1298 check for "#CRASHED" after stripping off the EOL characters.
1299 * Scripts/webkitpy/port/win.py:
1300 (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1301 invocation. This is apparently used to signal an event when the debugger is finished.
1303 2015-10-13 Alexey Proskuryakov <ap@apple.com>
1305 Mac Debug and 32-bit queues should be separate
1306 https://bugs.webkit.org/show_bug.cgi?id=150092
1308 Reviewed by Lucas Forschler.
1310 * QueueStatusServer/config/queues.py:
1311 * QueueStatusServer/model/queues.py:
1312 (Queue._capitalize_after_dash):
1313 (Queue._caplitalize_after_dash): Deleted.
1314 * Scripts/webkitpy/common/config/ews.json:
1316 2015-10-13 Sergio Villar Senin <svillar@igalia.com>
1318 [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1319 https://bugs.webkit.org/show_bug.cgi?id=150085
1321 Reviewed by Carlos Garcia Campos.
1323 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1325 2015-10-13 Sebastian Dröge <sebastian@centricular.com>
1327 Unreviewed, add myself to the committers list.
1329 * Scripts/webkitpy/common/config/contributors.json:
1331 2015-10-12 Alexey Proskuryakov <ap@apple.com>
1333 Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1334 https://bugs.webkit.org/show_bug.cgi?id=149983
1336 Reviewed by Dan Bates.
1338 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1339 (BubbleQueueServer):
1340 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1342 2015-10-12 Alexey Proskuryakov <ap@apple.com>
1344 Fix webkitpy tests after r190922.
1346 * Scripts/webkitpy/common/config/ews.json:
1347 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1348 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1350 2015-10-12 Alexey Proskuryakov <ap@apple.com>
1352 Add a Mac debug EWS queue
1353 https://bugs.webkit.org/show_bug.cgi?id=150069
1355 Reviewed by Geoffrey Garen.
1357 * QueueStatusServer/config/queues.py:
1358 * Scripts/webkitpy/common/config/ews.json:
1359 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1360 (AbstractEarlyWarningSystem):
1361 (AbstractEarlyWarningSystem.archive_last_test_results):
1362 (AbstractEarlyWarningSystem.build_style):
1363 (AbstractEarlyWarningSystem.refetch_patch):
1364 (AbstractEarlyWarningSystem.load_ews_classes):
1366 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
1368 [GTK] Update jhbuild's version of harfbuzz
1369 https://bugs.webkit.org/show_bug.cgi?id=149749
1371 Reviewed by Martin Robinson.
1373 Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1375 * gtk/jhbuild.modules: Updated details for harfbuzz.
1377 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
1379 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1380 https://bugs.webkit.org/show_bug.cgi?id=150026
1382 Reviewed by Philippe Normand.
1384 Backport upstream patch from gst-plugins-bad so that the right version
1385 of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1386 gets compiled properly, avoiding crashes on runtime while running tests.
1388 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1389 * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1391 2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
1393 Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1394 https://bugs.webkit.org/show_bug.cgi?id=149777
1396 Reviewed by Simon Fraser.
1398 Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1399 to the list of tests to preinstall at startup time.
1401 Also, update the generation of the 'name' table in the FontWithFeatures font.
1403 * DumpRenderTree/mac/DumpRenderTree.mm:
1404 (allowedFontFamilySet):
1405 (activateTestingFonts):
1407 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1408 (Generator::generate):
1409 (Generator::appendCFFTable):
1410 (Generator::appendNameSubtable):
1411 (Generator::appendNAMETable):
1412 * FontWithFeatures/FontWithFeatures/main.cpp:
1414 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1415 (WTR::allowedFontFamilySet):
1416 (WTR::activateFonts):
1417 * WebKitTestRunner/mac/TestControllerMac.mm:
1418 (WTR::allowedFontFamilySet):
1420 2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
1422 Unreviewed. Add Jinyoung Hur as a committer.
1424 * Scripts/webkitpy/common/config/contributors.json:
1426 2015-10-10 Dan Bernstein <mitz@apple.com>
1428 [iOS] Remove unnecessary iOS version checks
1429 https://bugs.webkit.org/show_bug.cgi?id=150002
1431 Reviewed by Alexey Proskuryakov.
1433 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1434 (-[HIDEventGenerator _createIOHIDEventType:]):
1435 (-[HIDEventGenerator _sendHIDEvent:]):
1436 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1437 * WebKitTestRunner/ios/UIKitSPI.h:
1439 2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
1441 Unreviewed, rolling out r190689
1442 https://bugs.webkit.org/show_bug.cgi?id=149992
1444 Fixed in other repository.
1446 Reverted changesets:
1448 "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1449 https://bugs.webkit.org/show_bug.cgi?id=149897
1451 2015-10-09 Brian Burg <bburg@apple.com>
1453 Teach webkitperl how to figure out IOS versions from the SDK
1454 https://bugs.webkit.org/show_bug.cgi?id=149963
1456 Reviewed by Daniel Bates.
1458 It should be easier to check the major and minor version of IOS SDKs.
1460 * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1461 * Scripts/webkitdirs.pm:
1462 (splitVersionString): Added.
1463 (determineOSXVersion): Use splitVersionString.
1464 (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1465 (iosVersion): Added.
1467 2015-10-09 Simon Fraser <simon.fraser@apple.com>
1469 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1470 https://bugs.webkit.org/show_bug.cgi?id=149960
1472 Reviewed by Tim Horton.
1474 Use adoptWK(), and null out some members (file is not using ARC).
1476 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1477 (UIScriptContext::uiScriptComplete):
1478 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1479 (-[TestRunnerWKWebView dealloc]):
1481 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
1483 Remove ENABLE_SUID_SANDBOX_LINUX cruft
1484 https://bugs.webkit.org/show_bug.cgi?id=149954
1486 Reviewed by Darin Adler.
1488 * Scripts/webkitperl/FeatureList.pm:
1490 2015-10-09 Daniel Bates <dabates@apple.com>
1492 Make iOS builders generate debug information in a separate dSYM file
1493 https://bugs.webkit.org/show_bug.cgi?id=149696
1495 Reviewed by Darin Adler.
1497 Similar to the Mac builders, the iOS builders should write debug information
1498 into a separate dSYM file instead of including such information in the binary
1499 itself (default Xcode behavior)
1501 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1502 (CompileWebKit.start):
1504 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
1506 Fix webkitpy tests after r190779
1507 https://bugs.webkit.org/show_bug.cgi?id=149949
1509 Reviewed by Ryosuke Niwa.
1511 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1512 (BenchmarkResults.format):
1513 (BenchmarkResults._format_values):
1515 2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
1517 Extend run-benchmark script to support human-readable results conversion.
1518 https://bugs.webkit.org/show_bug.cgi?id=149944
1520 Reviewed by Ryosuke Niwa.
1522 Add '--read-results-json' and '--no-adjust-unit' options.
1523 '--read-results-json' option converts result file to human readable format.
1524 '--no-adjust-unit' option skips scientific notation convertion.
1525 '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1527 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1528 (BenchmarkResults.format):
1529 (BenchmarkResults._format_tests):
1530 (BenchmarkResults._format_values):
1531 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1532 (BenchmarkRunner.__init__):
1533 (BenchmarkRunner._run_benchmark):
1534 (BenchmarkRunner._dump):
1535 (BenchmarkRunner.show_results):
1536 (BenchmarkRunner._show_results): Deleted.
1537 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1541 2015-10-08 Daniel Bates <dabates@apple.com>
1543 Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1544 https://bugs.webkit.org/show_bug.cgi?id=149945
1546 Reviewed by Dan Bernstein.
1548 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1549 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1550 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1551 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1553 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1554 (table.queue-grid tr.platform.ios-9 img.logo):
1556 2015-10-08 Daniel Bates <dabates@apple.com>
1558 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1559 https://bugs.webkit.org/show_bug.cgi?id=149943
1561 Reviewed by Dan Bernstein.
1563 Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1564 teach build-webkit to install them when building for iOS device using the public iOS SDK.
1566 * Scripts/build-webkit:
1568 2015-10-08 Daniel Bates <dabates@apple.com>
1570 Add LLVM binaries for iOS 9 device
1571 https://bugs.webkit.org/show_bug.cgi?id=149913
1573 Reviewed by Filip Pizlo.
1575 Implement support for building LLVM for ARM64-based iOS devices.
1577 * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1578 * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1579 an existing build earlier in the file such that remove previously built
1580 libraries before building/copying new ones (if applicable).
1581 (fileContains): Moved function outside of if-block.
1582 (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1583 (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1584 added logic to build LLVM for ARM64-based iOS devices.
1585 (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1586 LLVM into the WebKitBuild directory.
1588 2015-10-08 Alexey Proskuryakov <ap@apple.com>
1590 Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1591 https://bugs.webkit.org/show_bug.cgi?id=149848
1593 Reviewed by Darin Adler.
1595 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1597 2015-10-07 Brent Fulgham <bfulgham@apple.com>
1599 [Win] Support 64-bit Build and Testing
1600 https://bugs.webkit.org/show_bug.cgi?id=149904
1602 Reviewed by Daniel Bates.
1604 Extend our existing scripts to support 64-bit build and test operations on
1607 * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1608 Windows always builds the whole stack.
1609 * Scripts/webkit-build-directory: Add an option to return the location of
1610 the executable files produced by a specific configuration. This change is
1611 actually useful for Gtk and EFL, too.
1612 * Scripts/webkitdirs.pm:
1613 (executableProductDir): Added. This function appends the proper binary
1614 path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1615 (jscProductDir): Use the new 'executableProductDir' method.
1616 (setPathForRunningWebKitApp): Ditto.
1618 (runMiniBrowser): Ditto.
1619 * Scripts/webkitpy/port/factory.py:
1620 (configuration_options): Add a 64-bit option, used on Windows to specify
1621 which binary target should be used for testing.
1622 * Scripts/webkitpy/port/win.py:
1623 (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1624 processes when needed.
1625 (WinPort._build_path): Add the correct binary target path to _build_path.
1626 (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1627 64-bit paths for 64-bit tests.
1628 (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1629 NTSD debugger does not understand this argument.
1631 2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
1633 Test font-variant-* and font-feature-settings with TrueType fonts
1634 https://bugs.webkit.org/show_bug.cgi?id=149776
1636 Reviewed by Simon Fraser.
1638 This test extends our existing FontWithFeatures project to be able to generate a
1639 TrueType font. This font is conceptually similar as the existing OpenType font,
1640 except the feature -> character mapping is different.
1642 The font itself only supports the following characters:
1643 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1644 However, the shape of these letters are either an X or a check mark.
1645 The letter "A" always is a check mark.
1646 The letter "B" always is an X.
1647 Each font feature has an letter associated with it. When the font feature is enabled,
1648 that letter is shown as a check mark. For example, when
1649 "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1652 Here are the mappings of font features to letters:
1653 kLigaturesType / kCommonLigaturesOnSelector: C
1654 kLigaturesType / kContextualLigaturesOnSelector: D
1655 kLigaturesType / kRareLigaturesOnSelector: G
1656 kLigaturesType / kHistoricalLigaturesOnSelector: I
1657 kContextualAlternatesType / kContextualAlternatesOnSelector: L
1658 kVerticalPositionType / kInferiorsSelector: O
1659 kVerticalPositionType / kSuperiorsSelector: P
1660 kLowerCaseType / kLowerCaseSmallCapsSelector: S
1661 kUpperCaseType / kUpperCaseSmallCapsSelector: V
1662 kLowerCaseType / kLowerCasePetiteCapsSelector: T
1663 kUpperCaseType / kUpperCasePetiteCapsSelector: W
1664 kLetterCaseType / 14: Y
1665 kStyleOptionsType / kTitlingCapsSelector: a
1666 kNumberCaseType / kUpperCaseNumbersSelector: c
1667 kNumberCaseType / kLowerCaseNumbersSelector: d
1668 kNumberSpacingType / kProportionalNumbersSelector: f
1669 kNumberSpacingType / kMonospacedNumbersSelector: g
1670 kFractionsType / kDiagonalFractionsSelector: i
1671 kFractionsType / kVerticalFractionsSelector: j
1672 kVerticalPositionType / kOrdinalsSelector: Q
1673 kTypographicExtrasType / kSlashedZeroOnSelector: k
1674 kLigaturesType / kHistoricalLigaturesOnSelector: K
1675 kCharacterShapeType / kJIS1978CharactersSelector: m
1676 kCharacterShapeType / kJIS1983CharactersSelector: n
1677 kCharacterShapeType / kJIS1990CharactersSelector: o
1678 kCharacterShapeType / kJIS2004CharactersSelector: p
1679 kCharacterShapeType / kSimplifiedCharactersSelector: q
1680 kCharacterShapeType / kTraditionalCharactersSelector: r
1681 kTextSpacingType / kMonospacedTextSelector: t
1682 kTextSpacingType / kProportionalTextSelector: u
1683 kRubyKanaType / kRubyKanaOnSelector: v
1685 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1686 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1687 (CFFBuilder::moveTo):
1688 (CFFBuilder::lineTo):
1689 (GLYFBuilder::GLYFBuilder):
1690 (GLYFBuilder::takeResult):
1691 (GLYFBuilder::moveTo):
1692 (GLYFBuilder::lineTo):
1693 (GLYFBuilder::closePath):
1694 (GLYFBuilder::writePoint):
1695 (GLYFBuilder::append16):
1696 (generateBoxCharString):
1697 (generateCheckCharString):
1698 (generateXCharString):
1700 (Generator::generate):
1701 (Generator::insertSelector):
1702 (Generator::insertFeature):
1703 (Generator::generateFeatureDescription):
1704 (Generator::appendCFFTable):
1705 (Generator::appendGLYFTable):
1706 (Generator::appendLOCATable):
1707 (Generator::appendFEATTable):
1708 (Generator::appendMetamorphosisChain):
1709 (Generator::appendMORXTable):
1710 (Generator::appendHEADTable):
1711 (Generator::appendHMTXTable):
1712 (Generator::appendNameSubtable):
1713 (Generator::append2ByteASCIIString):
1714 (Generator::appendNAMETable):
1716 (CFFBuilder::curveToCubic): Deleted.
1717 (charStringForGlyph): Deleted.
1718 * FontWithFeatures/FontWithFeatures/FontCreator.h:
1719 * FontWithFeatures/FontWithFeatures/main.cpp:
1720 (constructFontWithTrueTypeFeature):
1721 (constructFontWithOpenTypeFeature):
1724 (drawTextWithFeature): Deleted.
1726 2015-10-07 Commit Queue <commit-queue@webkit.org>
1728 Unreviewed, rolling out r190572, r190593, r190594, and
1730 https://bugs.webkit.org/show_bug.cgi?id=149897
1732 Breaks Mavericks build (Requested by litherum on #webkit).
1734 Reverted changesets:
1736 "Allow WKRetainPtrs to be used as keys in hashing data
1738 https://bugs.webkit.org/show_bug.cgi?id=149762
1739 http://trac.webkit.org/changeset/190572
1741 "REGRESSION(189668?): http/tests/notifications/events.html
1742 flakily asserts or times out"
1743 https://bugs.webkit.org/show_bug.cgi?id=149218
1744 http://trac.webkit.org/changeset/190593
1746 "Prospective Mavericks build fix."
1747 http://trac.webkit.org/changeset/190594
1749 "Post-review cleanup after r190572."
1750 http://trac.webkit.org/changeset/190639
1752 2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
1754 [GTK] Add autocleanups
1755 https://bugs.webkit.org/show_bug.cgi?id=149588
1757 Reviewed by Darin Adler.
1759 * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1760 (AutocleanupsTest::create):
1761 (AutocleanupsTest::testWebProcessAutocleanups):
1763 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1764 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1765 (testUIProcessAutocleanups):
1766 (testWebProcessAutocleanups):
1770 2015-10-06 Brian Burg <bburg@apple.com>
1772 Unreviewed, try to fix the iOS 8 build after r190368.
1774 On older versions, IOHIDEventCreateForceEvent is not available.
1776 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1777 (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1779 2015-10-06 Keith Miller <keith_miller@apple.com>
1781 Add gmalloc option to run-javascriptcore-tests.
1782 https://bugs.webkit.org/show_bug.cgi?id=149858
1784 Reviewed by Geoffrey Garen.
1786 run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1787 If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1789 * Scripts/run-javascriptcore-tests:
1791 2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
1793 Post-review cleanup after r190572.
1797 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1799 2015-10-06 Brent Fulgham <bfulgham@apple.com>
1801 [Win] Unreviewed build correction.
1803 * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1804 are soft-linked at runtime.
1806 2015-10-06 Keith Miller <keith_miller@apple.com>
1808 Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1809 https://bugs.webkit.org/show_bug.cgi?id=149815
1811 Reviewed by Filip Pizlo.
1813 Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1814 Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1815 running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1816 Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1817 so should just use one test runner.
1819 * Scripts/run-javascriptcore-tests:
1820 (runJSCStressTests):
1821 (runMozillaTests): Deleted.
1822 (defaultJsDriverArgsForMozillaTests): Deleted.
1823 * Scripts/run-jsc-stress-tests:
1825 2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
1827 [GTK] Make update-webkitgtk-libs work behind firewall
1829 update-webkitgtk-libs can work behind a firewall with changes to
1830 a few packages. Where outbound git and active FTP connections
1831 fail, using http protocol succeeds. Most packages are
1832 already accessed using http.
1834 https://bugs.webkit.org/show_bug.cgi?id=148941
1836 Reviewed by Martin Robinson.
1839 * gtk/jhbuild.modules:
1840 Replace git URLs with http. Remove no longer used ftp repositories.
1841 Update argument for libxml2's autogen.sh script (--without-python
1842 is ignored; --with-python=no is correct).
1843 * jhbuild/jhbuild-wrapper:
1844 Instead of connecting to git://git.gnome.org/jhbuild, connect to
1845 http://git.gnome.org/browse/jhbuild.
1847 2015-10-06 Daniel Bates <dbates@webkit.org>
1849 Enable XSLT when building WebKit for iOS using the public iOS SDK
1850 https://bugs.webkit.org/show_bug.cgi?id=149827
1852 Reviewed by Alexey Proskuryakov.
1854 Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1855 and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1856 run this script before building WebKit for iOS or the build will fail because one or more XSLT
1857 headers cannot be found.
1859 * Scripts/configure-xcode-for-ios-development:
1860 (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1862 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
1864 REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1865 https://bugs.webkit.org/show_bug.cgi?id=149218
1867 Reviewed by Alexey Proskuryakov.
1869 Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1870 when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1871 WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1872 and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1873 the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1874 WebNotificationProvider must be updated to appropriately handle multiple
1875 WKNotificationManagerRefs in flight at the same time.
1877 * WebKitTestRunner/WebNotificationProvider.cpp:
1878 (WTR::WebNotificationProvider::~WebNotificationProvider):
1879 (WTR::WebNotificationProvider::showWebNotification):
1880 (WTR::WebNotificationProvider::closeWebNotification):
1881 (WTR::WebNotificationProvider::addNotificationManager):
1882 (WTR::WebNotificationProvider::removeNotificationManager):
1883 (WTR::WebNotificationProvider::simulateWebNotificationClick):
1884 (WTR::WebNotificationProvider::reset):
1885 * WebKitTestRunner/WebNotificationProvider.h:
1887 2015-10-05 Daniel Bates <dabates@apple.com>
1889 Disable Bitcode when building for iOS device
1890 https://bugs.webkit.org/show_bug.cgi?id=149818
1892 Reviewed by Alexey Proskuryakov.
1894 Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1895 when building for iOS device.
1897 * Scripts/webkitdirs.pm:
1900 2015-10-05 Daniel Bates <dabates@apple.com>
1902 [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1903 https://bugs.webkit.org/show_bug.cgi?id=140828
1904 <rdar://problem/19520599>
1906 Reviewed by Alexey Proskuryakov.
1908 Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1909 we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1910 to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1913 * Scripts/webkitdirs.pm:
1914 (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1915 to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1916 Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1917 (hasIOSDevelopmentCertificate): Added.
1919 2015-10-05 Daniel Bates <dabates@apple.com>
1921 DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1922 https://bugs.webkit.org/show_bug.cgi?id=149766
1924 Reviewed by Alexey Proskuryakov.
1926 Create network storage testing session on iOS.
1928 Currently we do not create a network storage testing session on iOS. A network storage testing session always
1929 has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1930 returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1931 NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1932 NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1933 it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1934 create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1935 testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1936 DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1938 As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1939 when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1940 returns a non-null pointer to a cookie store.
1942 * DumpRenderTree/mac/DumpRenderTree.mm:
1943 (prepareConsistentTestingEnvironment):
1945 2015-10-05 Simon Fraser <simon.fraser@apple.com>
1947 Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1950 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1951 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1953 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
1955 Allow WKRetainPtrs to be used as keys in hashing data structures
1956 https://bugs.webkit.org/show_bug.cgi?id=149762
1958 Reviewed by Anders Carlsson.
1960 * TestWebKitAPI/PlatformGTK.cmake:
1961 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1962 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1963 (TestWebKitAPI::TEST):
1965 2015-10-05 Simon Fraser <simon.fraser@apple.com>
1967 Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1968 available, and tidy up the #ifdefs in the UIKitSPI header.
1970 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1971 (-[HIDEventGenerator _sendHIDEvent:]):
1972 * WebKitTestRunner/ios/UIKitSPI.h:
1974 2015-10-04 Zan Dobersek <zdobersek@igalia.com>
1976 [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1977 https://bugs.webkit.org/show_bug.cgi?id=149792
1979 Reviewed by Martin Robinson.
1981 * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1982 for WebKitTestRunner multiple times.
1984 2015-10-04 Daniel Bates <dabates@apple.com>
1986 Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1987 (https://bugs.webkit.org/show_bug.cgi?id=149753)
1989 For now, support calling build-layouttestrelay without --ios-simulator so long
1990 as we are building on a Mac.
1992 * Scripts/build-layouttestrelay:
1994 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1996 Support Trac 1.0.x XML timeline link format
1997 https://bugs.webkit.org/show_bug.cgi?id=149786
1999 Reviewed by Lucas Forschler.
2001 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2002 (Trac.prototype._convertCommitInfoElementToObject):
2004 2015-10-04 Alexey Proskuryakov <ap@apple.com>
2006 Fix some errors on bot watcher's dashboard
2007 https://bugs.webkit.org/show_bug.cgi?id=149789
2009 Reviewed by Lucas Forschler.
2011 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2012 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
2013 tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
2015 2015-10-04 Alexey Proskuryakov <ap@apple.com>
2017 Bot watcher's dashboard builders should turn yellow when svn fails
2018 https://bugs.webkit.org/show_bug.cgi?id=149791
2020 Reviewed by Lucas Forschler.
2022 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2023 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
2024 (BuildbotBuilderQueueView.prototype.update):
2026 2015-10-02 Daniel Bates <dabates@apple.com>
2028 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
2029 https://bugs.webkit.org/show_bug.cgi?id=149769
2031 Reviewed by Alexey Proskuryakov.
2033 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
2034 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
2035 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2036 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2038 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2039 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
2041 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
2043 REGRESSION(r190370): Speedometer spits out an extra console message
2044 https://bugs.webkit.org/show_bug.cgi?id=149720
2046 Unreviewed. Temporarily ignore the console error message.
2048 * Scripts/webkitpy/performance_tests/perftest.py:
2049 (PerfTest._filter_output):
2051 2015-10-02 Brent Fulgham <bfulgham@apple.com>
2053 Provide "--no-ninja" option to avoid using Ninja
2054 https://bugs.webkit.org/show_bug.cgi?id=149757
2056 Reviewed by Alex Christensen.
2058 Add a new command line argument understood by webkitdirs.pm so
2059 that we can conditionally avoid using Ninja. This is an
2060 'opt-out' argument, so no existing Ninja users should be affected.
2062 * Scripts/webkitdirs.pm:
2063 (canUseNinja): Check for option and block ninja if present.
2065 2015-10-02 Aakash Jain <aakash_jain@apple.com>
2067 Flakiness dashboard should support OS X El Capitan
2068 https://bugs.webkit.org/show_bug.cgi?id=149648
2070 Reviewed by Alexey Proskuryakov.
2072 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2074 2015-10-02 Daniel Bates <dabates@apple.com>
2076 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
2077 (https://bugs.webkit.org/show_bug.cgi?id=149753)
2079 For now, pass --ios-simulator.
2081 * Scripts/webkitpy/port/ios.py:
2082 (IOSSimulatorPort._build_relay):
2084 2015-10-02 Simon Fraser <simon.fraser@apple.com>
2086 Remove a "nullable" that breaks the iOS 8 build.
2088 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2089 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2091 2015-10-02 Daniel Bates <dabates@apple.com>
2093 LayoutTestRelay is not built and archived when building for iOS Simulator
2094 https://bugs.webkit.org/show_bug.cgi?id=149753
2096 Reviewed by Alexey Proskuryakov and Andy Estes.
2098 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
2099 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
2100 product archive when building for iOS Simulator, respectively.
2102 * BuildSlaveSupport/built-product-archive:
2103 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
2104 differentiate between iOS device and iOS Simulator platforms.
2105 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
2106 from determineWebKitBuildDirectories() into this function so that it can be used by both
2107 determineWebKitBuildDirectories() and archiveBuiltProduct().
2108 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
2109 webkitBuildDirectoryForConfigurationAndPlatform().
2110 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
2111 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
2112 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
2113 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
2114 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
2115 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
2116 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
2117 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
2118 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
2119 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
2120 * Scripts/build-layouttestrelay:
2121 - Remove unnecessary include of Perl module POSIX.
2122 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
2123 * Scripts/build-webkit:
2124 - Invoke script build-layouttestrelay when building for iOS Simulator.
2126 2015-10-02 Brent Fulgham <bfulgham@apple.com>
2128 [Win] Unreviewed test fix.
2130 You cannot run 'run-webkit-tests' from the command line because it does not know
2131 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
2132 because they explicitly set use the 'root' argument to provide the full path to
2135 * Scripts/webkitpy/port/win.py:
2136 (WinPort._build_path): Added.
2138 2015-10-02 Alex Christensen <achristensen@webkit.org>
2140 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
2141 https://bugs.webkit.org/show_bug.cgi?id=149430
2142 rdar://problem/22742222
2144 Reviewed by Geoffrey Garen.
2146 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2147 (WTR::TestController::cocoaResetStateToConsistentValues):
2148 * WebKitTestRunner/mac/TestControllerMac.mm:
2149 (WTR::TestController::platformConfigureViewForTest):
2150 Test what happens when you disable content blockers from the SPI.
2152 2015-10-01 Brent Fulgham <bfulgham@apple.com>
2154 [Win] Unreviewed build fix for run-api-tests
2156 * Scripts/run-api-tests:
2157 (testToolPaths): Windows run needs to specify the binary path.
2159 2015-10-01 Daniel Bates <dabates@apple.com>
2161 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
2162 (https://bugs.webkit.org/show_bug.cgi?id=149695)
2164 Following r190424 we can now rely on webkit-build-directory to return the path to
2165 the correct configuration-specific build directory on Windows.
2167 * BuildSlaveSupport/built-product-archive:
2168 (archiveBuiltProduct):
2170 2015-10-01 Brent Fulgham <bfulgham@apple.com>
2172 [Win] Unreviewed build fix.
2174 * Scripts/webkitdirs.pm:
2175 (setupAppleWinEnv): Use 64-bit build tools if available
2177 2015-10-01 Brent Fulgham <bfulgham@apple.com>
2179 [Win] Fix TestWebKitAPI build under CMake.
2181 Reviewed by Alex Christensen.
2183 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2186 2015-10-01 Brent Fulgham <bfulgham@apple.com>
2188 [Win] Fix behavior of webkit-build-directory script
2189 https://bugs.webkit.org/show_bug.cgi?id=149718
2191 Reviewed by Alex Christensen.
2193 * Scripts/webkitdirs.pm:
2194 (determineConfigurationProductDir): Do not include the binary
2195 sub-directory in the configuration product directory output.
2196 (jscProductDir): Append correct binary path for Windows build.
2197 (setPathForRunningWebKitApp): Include properly binary subdirectories.
2198 (runSafari): Update for revised productDir behavior.
2199 (runMiniBrowser): Ditto.
2201 2015-10-01 Alexey Proskuryakov <ap@apple.com>
2203 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2204 use iOS SDK, like with all the others.
2206 * Scripts/build-webkit:
2208 2015-10-01 Daniel Bates <dabates@apple.com>
2210 Attempt to fix the iOS 9 Simulator testers
2212 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2213 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2214 LayoutTestRelay when building for iOS Simulator.
2216 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2217 * Scripts/build-webkit:
2219 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
2221 [GTK] Websites with invalid auth header keep loading forever
2222 https://bugs.webkit.org/show_bug.cgi?id=149710
2224 Reviewed by Martin Robinson.
2226 Add test case to check that we can authenticate sites with an
2229 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2230 (testWebViewAuthenticationEmptyRealm):
2234 2015-10-01 Alexey Proskuryakov <ap@apple.com>
2236 [Mac] Make run-api-tests work with System Integrity Protection
2237 https://bugs.webkit.org/show_bug.cgi?id=149711
2238 rdar://problem/22928202
2240 Reviewed by Dan Bernstein.
2242 * Scripts/run-api-tests:
2244 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2246 2015-10-01 Daniel Bates <dabates@apple.com>
2248 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2249 (https://bugs.webkit.org/show_bug.cgi?id=149695)
2251 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2252 For now, use the path to the top-level WebKit build directory instead of using the configuration-
2253 specific build directory.
2255 * BuildSlaveSupport/built-product-archive:
2256 (archiveBuiltProduct):
2258 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
2260 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2261 https://bugs.webkit.org/show_bug.cgi?id=145837
2263 Reviewed by Philippe Normand.
2265 * efl/jhbuild.modules:
2266 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2267 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2269 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
2271 Unreviewed. Fix the iOS build after r190407.
2273 * WebKitTestRunner/ios/IOKitSPI.h:
2275 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
2277 Implement keyboard event sending for iOS in WebKitTestRunner
2278 https://bugs.webkit.org/show_bug.cgi?id=149676
2280 Reviewed by Simon Fraser.
2282 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2283 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2284 allows us to run code when the keyboard is shown or hidden.
2286 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2287 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2288 (WTR::UIScriptController::setDidShowKeyboardCallback):
2289 (WTR::UIScriptController::didShowKeyboardCallback):
2290 (WTR::UIScriptController::setDidHideKeyboardCallback):
2291 (WTR::UIScriptController::didHideKeyboardCallback):
2292 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2293 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2294 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2295 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2296 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2297 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2298 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2299 the notifications that the keyboard has been raised or lowered.
2300 (-[TestRunnerWKWebView _keyboardDidShow:]):
2301 (-[TestRunnerWKWebView _keyboardDidHide:]):
2302 * WebKitTestRunner/ios/HIDEventGenerator.h:
2303 * WebKitTestRunner/ios/HIDEventGenerator.m:
2304 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2305 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2306 (hidUsageCodeForCharacter): Ditto.
2307 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2308 a keyDown event in WebKit.
2309 * WebKitTestRunner/ios/IOKitSPI.h:
2310 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2312 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
2314 Unreviewed, rolling out r190399.
2316 Tests are still failing even after r190362
2320 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2321 http://trac.webkit.org/changeset/190399
2323 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
2325 [jhbuild] switch to new upstream usrsctp library
2326 https://bugs.webkit.org/show_bug.cgi?id=149494
2328 Reviewed by Philippe Normand.
2330 * efl/jhbuild.modules:
2331 * gtk/jhbuild.modules:
2333 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
2335 Unreviewed. Unskip GTK+ user media unit tests after r190362.
2337 They should pass now.
2339 * Scripts/run-gtk-tests:
2342 2015-09-30 Daniel Bates <dabates@apple.com>
2344 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2345 (https://bugs.webkit.org/show_bug.cgi?id=149695)
2347 * BuildSlaveSupport/built-product-archive:
2348 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2349 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2351 2015-09-30 Daniel Bates <dabates@apple.com>
2353 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2354 (https://bugs.webkit.org/show_bug.cgi?id=149695)
2356 Actually, we need to pass --configuration to script webkit-build-directory to have
2357 it return the path to the configuration-specific build directory.
2359 * BuildSlaveSupport/built-product-archive:
2360 (determineWebKitBuildDirectories):
2362 2015-09-30 Daniel Bates <dabates@apple.com>
2364 built-product-archive archives incorrect build directory for iOS port
2365 https://bugs.webkit.org/show_bug.cgi?id=149695
2367 Reviewed by Darin Adler.
2369 Fixes an issue where the script built-product-archive archives a non-existent
2370 build directory for the iOS port. Without loss of generality, the script assumes
2371 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2372 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2374 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2375 to determine the top-level build directory and computes the configuration-specific
2376 build directory to be the concatenation of the the top-level build directory and
2377 the configuration (e.g. Release). This is incorrect. Instead we should call
2378 webkit-build-directory omitting the flag --top-level to compute the path to the
2379 configuration-specific build directory.
2381 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2382 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2383 its purpose and added global variable _configurationBuildDirectory to store the path
2384 to the configuration-specific build directory. Ensure that we have a non-empty string
2385 for both the top-level and configuration-specific build directories.
2386 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2387 Compute the configuration-specific build directory and store it in the global variable
2388 _configurationBuildDirectory.
2389 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2390 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2392 (determineWebKitBuildDirectory): Deleted.
2394 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
2396 [EFL] css3/device-adapt/* tests failed after r190335.
2397 https://bugs.webkit.org/show_bug.cgi?id=149655
2399 Reviewed by Simon Fraser.
2401 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2402 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2404 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2405 (WTR::shouldUseFixedLayout):
2407 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
2409 Extend JetStream timeout for slow devices.
2411 Reviewed by Chris Dumez.
2413 Extend JetStream timeout to 20 minutes.
2415 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2417 2015-09-30 Daniel Bates <dabates@apple.com>
2419 Rename iOS builders/testers to include version
2420 https://bugs.webkit.org/show_bug.cgi?id=149685
2422 Reviewed by Simon Fraser.
2424 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2425 make it clear to a reader the version of iOS these builders/testers are using.
2427 * BuildSlaveSupport/build.webkit.org-config/config.json:
2428 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2430 2015-09-30 Daniel Bates <dabates@apple.com>
2432 Add iOS criterion for triggering a build
2433 https://bugs.webkit.org/show_bug.cgi?id=149679
2435 Rubber-stamped by Alexey Proskuryakov.
2437 First pass at defining criterion for triggering an iOS build.
2439 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2440 (_should_file_trigger_build):
2441 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2443 (ShouldBuildTest.test_should_build):
2445 2015-09-29 Simon Fraser <simon.fraser@apple.com>
2447 [iOS] Allow tests to generate user gestures for UI testing
2448 https://bugs.webkit.org/show_bug.cgi?id=149653
2450 Reviewed by Tim Horton.
2452 Expose functionality in UIScriptController to allow for testing single- and double-tap,
2453 and to listen for completion of scrolling and zooming in the WKWebView.
2455 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2456 which hides the complexity of creating these events. Event dispatch is asynchronous.
2457 We detect when the last event has been handled by dispatching a vendor-specific event,
2458 which is detected via -_handleHIDEvent: in our UIApplication subclass.
2460 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2461 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2462 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2463 single and double taps.
2464 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2465 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2466 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2467 (UIScriptContext::unregisterCallback):
2468 (UIScriptContext::callbackWithID):
2469 (UIScriptContext::fireCallback):
2470 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2471 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2472 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2473 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2474 (WTR::UIScriptController::setDidEndZoomingCallback):
2475 (WTR::UIScriptController::didEndZoomingCallback):
2476 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2477 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2478 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2479 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2480 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2481 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2482 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2483 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2484 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2485 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2486 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2487 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2488 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2489 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2491 (calculateNextLocation):
2493 (+[HIDEventGenerator sharedHIDEventGenerator]):
2494 (+[HIDEventGenerator nextEventCallbackID]):
2495 (-[HIDEventGenerator init]):
2496 (-[HIDEventGenerator _createIOHIDEventType:]):
2497 (-[HIDEventGenerator _sendHIDEvent:]):
2498 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2499 (-[HIDEventGenerator _updateTouchPoints:count:]):
2500 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2501 (-[HIDEventGenerator touchDown:touchCount:]):
2502 (-[HIDEventGenerator touchDown:]):
2503 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2504 (-[HIDEventGenerator liftUp:touchCount:]):
2505 (-[HIDEventGenerator liftUp:]):
2506 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2507 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2508 (-[HIDEventGenerator tap:completionBlock:]):
2509 (-[HIDEventGenerator doubleTap:completionBlock:]):
2510 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2511 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2512 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2513 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2514 (-[HIDEventGenerator markerEventReceived:]):
2515 * WebKitTestRunner/ios/IOKitSPI.h: Added.
2516 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2517 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2518 (WTR::globalToContentCoordinates):
2519 (WTR::UIScriptController::singleTapAtPoint):
2520 (WTR::UIScriptController::doubleTapAtPoint):
2521 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2522 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2523 * WebKitTestRunner/ios/mainIOS.mm:
2524 (-[WebKitTestRunnerApp _handleHIDEvent:]):
2526 2015-09-30 Dana Burkart <dburkart@apple.com>
2528 git-add-reviewer should trim trailing spaces/newlines
2529 https://bugs.webkit.org/show_bug.cgi?id=149513
2531 Reviewed by Darin Adler.
2533 * Scripts/git-add-reviewer:
2536 2015-09-30 Eric Carlson <eric.carlson@apple.com>
2538 REGRESSION(r190262): User media unit test failures after r190262
2539 https://bugs.webkit.org/show_bug.cgi?id=149580
2541 Reviewed by Darin Adler.
2543 * WebKitTestRunner/TestController.cpp:
2544 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2545 order to WKUserMediaPermissionRequestAllow.
2547 2015-09-30 Daniel Bates <dabates@apple.com>
2549 Add iOS builders and testers
2550 https://bugs.webkit.org/show_bug.cgi?id=149549
2552 Reviewed by Alexey Proskuryakov.
2554 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2555 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2557 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2558 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2560 2015-09-30 Timothy Hatcher <timothy@apple.com>
2562 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2563 https://bugs.webkit.org/show_bug.cgi?id=149674
2565 Reviewed by Lucas Forschler.
2567 * WebKitLauncher/WebKitLauncher.entitlements: Added.
2568 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2570 2015-09-30 Jason Marcell <jmarcell@apple.com>
2572 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2573 have an associated trac instance.
2574 https://bugs.webkit.org/show_bug.cgi?id=149673
2576 Reviewed by Alexey Proskuryakov.
2578 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2579 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2580 have an associated trac instance.
2582 2015-09-30 Daniel Bates <dabates@apple.com>
2584 Prioritize testing latest build request on iOS test bots
2585 https://bugs.webkit.org/show_bug.cgi?id=149669
2587 Reviewed by Darin Adler.
2589 We should prioritize testing of the latest build request on the iOS test bots
2590 as we do for Mac and Windows test bots.
2592 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2593 (loadBuilderConfig):
2595 2015-09-30 Daniel Bates <dabates@apple.com>
2597 Add buildbot category for iOS builders and testers
2598 https://bugs.webkit.org/show_bug.cgi?id=149667
2600 Reviewed by Darin Adler.
2602 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2603 for iOS to the build.webkit.org home page.
2605 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2606 (loadBuilderConfig):
2607 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2609 2015-09-30 Daniel Bates <dabates@apple.com>
2611 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2612 (https://bugs.webkit.org/show_bug.cgi?id=149539)
2614 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2615 in <http://trac.webkit.org/changeset/190351>.
2617 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2618 (CompileWebKit.start):
2620 2015-09-30 Daniel Bates <dabates@apple.com>
2622 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2623 (https://bugs.webkit.org/show_bug.cgi?id=149539)
2625 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2626 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2628 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2629 (CompileWebKit.start):
2631 2015-09-30 Lucas Forschler <lforschler@apple.com>
2633 bot210 was configured for a queue instead of bot126.
2635 Unreviewed config.json fix.
2637 * BuildSlaveSupport/build.webkit.org-config/config.json:
2639 2015-09-30 Lucas Forschler <lforschler@apple.com>
2641 Bring El Capitan buildbot infrastructure online.
2642 https://bugs.webkit.org/show_bug.cgi?id=149605
2644 Reviewed by Darin Adler.
2646 * BuildSlaveSupport/build.webkit.org-config/config.json:
2648 2015-09-30 Tomas Popela <tpopela@redhat.com>
2650 [GTK] Deprecation warnings in DOMNodeTest
2651 https://bugs.webkit.org/show_bug.cgi?id=149663
2653 After the webkit_dom_document_get_elements_by_tag_name deprecation we
2654 need to update the tests to use webkit_dom_document_query_selector_all
2655 to avoid compilation warnings.
2657 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2658 (the suggested replacement for the deprecated function).
2660 Reviewed by Carlos Garcia Campos.
2662 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2663 (WebKitDOMNodeTest::testTagNamesNodeList):
2664 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2666 (WebKitDOMNodeTest::testTagNames): Deleted.
2667 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2668 (prepareDOMForTagNamesTests):
2669 (testWebKitDOMNodeTagNamesNodeList):
2670 (testWebKitDOMNodeTagNamesHTMLCollection):
2672 (testWebKitDOMNodeTagNames): Deleted.
2674 2015-09-29 Simon Fraser <simon.fraser@apple.com>
2676 WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2677 https://bugs.webkit.org/show_bug.cgi?id=149650
2679 Reviewed by Tim Horton.
2681 TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2682 looks at the file path, and not the custom options that come from file comments.
2684 Fix by computing TestOptions before making the TestInvocation, and setting them
2685 as const TestInvocation data. This meant changing various call sites to take
2686 the std::string pathOrURL, rather than the TestInvocation itself.
2688 Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2690 * WebKitTestRunner/CMakeLists.txt:
2691 * WebKitTestRunner/TestController.cpp:
2692 (WTR::TestController::ensureViewSupportsOptionsForTest):
2694 (WTR::createTestURL):
2695 (WTR::updateTestOptionsFromTestHeader):
2696 (WTR::TestController::testOptionsForTest):
2697 (WTR::TestController::updateWebViewSizeForTest):
2698 (WTR::TestController::updateWindowScaleForTest):
2699 (WTR::TestController::runTest):
2700 * WebKitTestRunner/TestController.h:
2701 * WebKitTestRunner/TestInvocation.cpp:
2702 (WTR::TestInvocation::TestInvocation):
2703 (WTR::TestInvocation::invoke):
2704 (WTR::createWKURL): Deleted.
2705 (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2706 (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2707 * WebKitTestRunner/TestInvocation.h:
2708 (WTR::TestInvocation::options):
2709 * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2710 (WTR::pathContains):
2711 (WTR::shouldMakeViewportFlexible):
2712 (WTR::shouldUseFixedLayout):
2713 (WTR::isSVGTestPath):
2714 (WTR::isHiDPITestPath):
2715 (WTR::TestOptions::TestOptions):
2716 * WebKitTestRunner/TestOptions.h:
2717 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2718 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2719 (WTR::pathContains):
2720 (WTR::shouldUseFixedLayout):
2721 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2722 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2723 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2724 * WebKitTestRunner/ios/TestControllerIOS.mm:
2725 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2726 * WebKitTestRunner/mac/TestControllerMac.mm:
2727 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2729 2015-09-29 Aakash Jain <aakash_jain@apple.com>
2731 Flakiness dashboard should support OS X El Capitan
2732 https://bugs.webkit.org/show_bug.cgi?id=149648
2734 Reviewed by Alexey Proskuryakov.
2736 * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
2737 difference between new appscale and old Google App Engine implementation.
2738 * TestResultServer/app.yaml: Same.
2739 * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2741 2015-09-29 Daniel Bates <dabates@apple.com>
2743 configure-xcode-for-ios-development does not work with Xcode 7
2744 https://bugs.webkit.org/show_bug.cgi?id=149640
2746 Reviewed by Alexey Proskuryakov.
2748 When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2749 because it cannot find the Xcode specification files for iOS simulator and device. These
2750 files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2751 relevant definitions to the Xcode 7 specification files directly as opposed to creating
2752 new specification files with the added definitions (as we did in older versions of Xcode)
2753 in order for Xcode 7 to honor these definitions.
2755 * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2756 (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2757 (updateXcode7SpecificationFile): Added.
2758 (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2759 (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2760 appropriate success message.
2761 (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2762 (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2763 (createXcodeSpecificationFromSpecificationAndId): Deleted.
2765 2015-09-29 Brent Fulgham <bfulgham@apple.com>
2767 [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2768 https://bugs.webkit.org/show_bug.cgi?id=149639
2770 Reviewed by Alex Christensen.
2772 * Scripts/VCSUtils.pm:
2773 (exitStatus): Use 'isWindows()' method.
2774 (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2775 an error. This method could probably just go away.
2776 (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2777 always changing to Unix style.
2778 (unixPath): Added. Needed so Windows can always show a Unix path in the
2780 (changeLogName): Work around the fact that 'getpwuid' is not available on
2781 a pure Windows build of Perl.
2782 * Scripts/prepare-ChangeLog:
2783 (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2785 (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2786 support using arrays for 'open' arguments.
2787 (resolveChangeLogsPath): Ditto.
2788 (resolveConflictedChangeLogs): Use new helper functions.
2789 (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2790 (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2791 quotes. Unix systems are happy either way.
2792 (statusCommand): Ditto.
2793 * Scripts/webkitdirs.pm:
2794 (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2796 2015-09-29 Brent Fulgham <bfulgham@apple.com>
2798 [Win] Unreviewed 64-bit build fix after switch to CMake.
2800 * Scripts/webkitdirs.pm:
2801 (determineIsWin64FromArchitecture): Added.
2803 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
2805 printing does not use minimum page zoom factor
2806 https://bugs.webkit.org/show_bug.cgi?id=108507
2808 Reviewed by Darin Adler.
2810 WebKitTestRunner always takes the snapshots from the UI process
2811 (expect for IOS), so in the case of printing, the layout in the
2812 web view is not the expected one. When printing, we need to take
2813 the snapshot in the web process and ensure it's rendered with a
2816 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2817 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2818 kWKSnapshotOptionsPrinting option to
2819 WKBundlePageCreateSnapshotWithOptions() when printing.
2821 2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
2823 [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2824 https://bugs.webkit.org/show_bug.cgi?id=149595
2826 Reviewed by Tim Horton.
2828 All ports except IOS implement
2829 PlatformWebView::windowSnapshotImage() to generate the snapshot
2830 for the pixel tests in the UI process. But we are still generating
2831 a snapshot for pixel tests in the Web process too, that is passed
2832 to the UI process but ignored.
2833 Whether a pixel result is needed or not, is only known by the web
2834 process depending on whether the test called dumpAsText with
2835 dumpPixels == true or not. Since the pixels are now dump in the UI
2836 process, we need to pass that information to the UI process when
2837 the test is done. For that we set a PixelResultIsPending bool
2838 parameter to the Done message, and we only add the PixelResult
2839 when UI process doesn't need to generate the pixels dump.
2841 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2842 (WTR::InjectedBundle::didReceiveMessageToPage): Set
2843 m_pixelResultIsPending to false on reset.
2844 (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2845 Done message, and set the PixelResult if m_pixelResultIsPending is false.
2846 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2847 (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2848 (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2849 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2850 (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2852 * WebKitTestRunner/TestInvocation.cpp:
2853 (WTR::TestInvocation::dumpResults): Use either the pixel result
2854 from the web process or generate a pixel result from the web view
2856 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2857 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2858 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2859 is created by the caller now, but the CG implementation needs to
2860 know if it's a Web or UI process snapshot.
2861 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2862 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2863 cairo surface for the given image.
2864 * WebKitTestRunner/cg/TestInvocationCG.cpp:
2865 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2866 CGContext for the given image.
2868 2015-09-28 Dean Johnson <dean_johnson@apple.com>
2870 Fix JS errors on dashboard metrics page
2871 https://bugs.webkit.org/show_bug.cgi?id=149608
2873 Reviewed by Alexey Proskuryakov.
2875 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2876 (initPlatformsByFamily):
2877 (updateHiddenPlatforms):
2878 (parsePlatformFamily): Deleted.
2879 (updateToggleButtons): Deleted.
2880 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2881 (updateHiddenPlatforms): Added to remove errors.
2882 (initPlatformsByFamily): Added to remove errors.
2883 (unhiddenQueues): Updated to use Settings.
2884 (documentReady): Added logic to add toggle buttons to the settings menu.
2885 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2886 (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2887 MetricsMain.js to Settings.
2888 (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2889 MetricsMain.js to Settings.
2890 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2891 (QueueView.prototype._updateHiddenState): Updated to use Settings.
2893 2015-09-28 Aakash Jain <aakash_jain@apple.com>
2895 Appscale query fails because of missing index
2896 https://bugs.webkit.org/show_bug.cgi?id=149609
2898 Reviewed by Darin Adler.
2900 * QueueStatusServer/index.yaml: Added the required index.
2902 2015-09-28 Brent Fulgham <bfulgham@apple.com>
2904 [Win] Fix the 64-bit build after switch to cmake.
2906 Reviewed by Alex Christensen.
2908 * Scripts/webkitdirs.pm:
2909 (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2912 2015-09-28 Brent Fulgham <bfulgham@apple.com>
2914 [Win] Allow Windows to run test-webkitpy without Cygwin
2915 https://bugs.webkit.org/show_bug.cgi?id=149602
2917 Reviewed by Alex Christensen.
2919 These changes mostly shift from hard-coded paths using UNIX-style
2920 separators to Python's "os.path.join" syntax that uses the correct
2921 path separator for each platform.
2923 * Scripts/webkitpy/common/system/path.py:
2924 (cygpath): Don't pass paths through Cygpath on native Windows.
2925 * Scripts/webkitpy/port/win.py:
2926 (WinPort._path_to_apache): Use os.path.join.
2927 (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2928 in 64-bit environments).
2929 * Scripts/webkitpy/style/checker.py: Use os.path.join.
2930 * Scripts/webkitpy/style/checker_unittest.py:
2931 (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2932 (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2933 (GlobalVariablesTest): Ditto.
2934 (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2935 (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2936 (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2937 (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2938 (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2939 (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2940 (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2941 (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2942 (StyleProcessor_CodeCoverageTest): Ditto.
2943 (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2944 (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2945 (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2946 * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2947 manual string concatenation of paths.
2949 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
2951 Add bugzilla addresses of committers to contributors.json
2952 https://bugs.webkit.org/show_bug.cgi?id=149520
2954 Reviewed by Darin Adler.
2956 * Scripts/webkitpy/common/config/contributors.json:
2958 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
2960 validate-committer-lists -b shouldn't need edituser privileges
2961 https://bugs.webkit.org/show_bug.cgi?id=149519
2963 Reviewed by Darin Adler.
2965 * Scripts/validate-committer-lists:
2966 (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2967 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2968 (BugzillaQueries.is_invalid_bugzilla_email):
2969 (BugzillaQueries): Deleted.
2970 (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2972 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
2974 Unreviewed. Gardening: skip media stream tests failing after r190262.
2976 * Scripts/run-gtk-tests:
2979 2015-09-25 Alexey Proskuryakov <ap@apple.com>
2981 [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2982 https://bugs.webkit.org/show_bug.cgi?id=149571
2984 Reviewed by Dan Bernstein.
2986 Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
2988 * DumpRenderTree/mac/Configurations/Base.xcconfig:
2989 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2990 * LayoutTestRelay/Configurations/Base.xcconfig:
2991 * MiniBrowser/Configurations/Base.xcconfig:
2992 * MiniBrowser/Configurations/DebugRelease.xcconfig:
2993 * TestWebKitAPI/Configurations/Base.xcconfig:
2994 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2995 * WebEditingTester/Configurations/Base.xcconfig:
2996 * WebEditingTester/Configurations/DebugRelease.xcconfig:
2997 * WebKitTestRunner/Configurations/Base.xcconfig:
2998 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2999 * WebKitTestRunner/iOS.xcconfig: Removed.
3001 2015-09-25 Eric Carlson <eric.carlson@apple.com>
3003 Clean up user media request internal API
3004 https://bugs.webkit.org/show_bug.cgi?id=149527
3006 Reviewed by Tim Horton.
3008 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3009 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
3011 * WebKitTestRunner/TestController.cpp:
3012 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
3014 2015-09-25 Simon Fraser <simon.fraser@apple.com>
3016 [iOS WK2] Add viewport tests and fix runUIScript() timing issues
3017 https://bugs.webkit.org/show_bug.cgi?id=149577
3019 Reviewed by Tim Horton.
3021 When calling testRunner.runUIScript() from a page load event, the script could run
3022 in the UI process before the current remote layer tree transaction had been handled
3023 there. This meant that runUIScript() could query state which was about to change.
3025 Fix by delaying the execution of the UI script until a layer tree transaction has
3026 been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
3028 * WebKitTestRunner/TestInvocation.cpp:
3029 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3030 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
3031 * WebKitTestRunner/TestInvocation.h:
3033 2015-09-25 Alexey Proskuryakov <ap@apple.com>
3035 [Mac] Media tests start to time out after a few days of bot uptime
3036 https://bugs.webkit.org/show_bug.cgi?id=149468
3038 Reviewed by Darin Adler.
3040 Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
3041 as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
3042 all temporary and cache files go to a custom location.
3044 * Scripts/webkitpy/port/base.py:
3045 * Scripts/webkitpy/port/driver.py:
3046 * Scripts/webkitpy/port/mac.py:
3047 * Scripts/webkitpy/port/win.py:
3048 (WinPort._driver_tempdir_for_environment): Deleted unused function.
3050 2015-09-25 Dan Bernstein <mitz@apple.com>
3052 Removed MiniBrowser.entitlements.
3054 Rubber-stamped by Anders Carlsson.
3056 The entitlements weren’t used anyway.
3058 * MiniBrowser/MiniBrowser.entitlements: Removed.
3059 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3061 2015-09-24 Daniel Bates <dabates@apple.com>
3063 Add WebKitSystemInterface for iOS 9.0
3064 https://bugs.webkit.org/show_bug.cgi?id=149550
3066 Rubber-stamped by Alexey Proskuryakov.
3068 * Scripts/copy-webkitlibraries-to-product-directory:
3070 2015-09-24 Daniel Bates <dabates@apple.com>
3072 Support building for arbitrary architectures
3073 https://bugs.webkit.org/show_bug.cgi?id=149539
3075 Reviewed by Alexey Proskuryakov.
3077 Teach buildbot to pass the architectures associated with the builder to build-webkit
3078 when building on OS X and iOS. As a side effect of this change we now support building
3079 universal binaries when multiples architectures are specified.
3081 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3082 (CompileWebKit.start):
3084 2015-09-24 Daniel Bates <dabates@apple.com>
3086 Fix the build after <http://trac.webkit.org/changeset/190212>
3087 (http://trac.webkit.org/changeset/190212)
3089 I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
3091 * BuildSlaveSupport/built-product-archive:
3094 2015-09-24 Daniel Bates <dabates@apple.com>
3096 Support running unit tests on iOS Simulator test bot
3097 https://bugs.webkit.org/show_bug.cgi?id=149536
3099 Reviewed by Alexey Proskuryakov.
3101 Implements support for running unit tests on a iOS test bot. At the time of writing,
3102 the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
3104 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3105 (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
3106 (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
3108 2015-09-24 Daniel Bates <dabates@apple.com>
3110 Add support infrastructure for OpenSource iOS builders and testers
3111 https://bugs.webkit.org/show_bug.cgi?id=149534
3113 Reviewed by Darin Adler.
3115 Towards setting up OpenSource iOS build bots, teach buildbot and its support
3118 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3119 (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
3120 --ios-simulator or --device for a builder/tester whose full platform name begins with
3121 "ios-simulator" or "ios", respectively.
3122 (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
3123 * BuildSlaveSupport/built-product-archive:
3124 (main): Pass the full platform name to determineWebKitBuildDirectory().
3125 (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
3126 command line flag when building for iOS.
3127 (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
3128 parameter fullPlatform. This parameter was originally added in r125066 to support the
3129 Chromium Android port, which has since been removed from the OpenSource WebKit Project.
3130 (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
3131 * BuildSlaveSupport/clean-build:
3132 (main): Call script webkit-build-directory with the appropriate command line flag when
3134 * BuildSlaveSupport/delete-stale-build-files:
3135 (main): Use the same logic for iOS as we do for Mac.
3136 (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
3137 flag when building for iOS.
3138 * BuildSlaveSupport/test-result-archive:
3139 (archiveTestResults): Use the same logic for iOS as we do for Mac.
3141 2015-09-24 Daniel Bates <dabates@apple.com>
3143 Remove Chromium-specific changes to script built-product-archive
3144 https://bugs.webkit.org/show_bug.cgi?id=149530
3146 Rubber-stamped by Csaba Osztrogonác.
3148 Reverts changes made in r113074 and r113067 to support Chromium testers. The
3149 Chromium code has long since been removed from the OpenSource WebKit Project.
3151 * BuildSlaveSupport/built-product-archive:
3152 (createZipManually):
3154 (archiveBuiltProduct):
3156 2015-09-24 Dan Bernstein <mitz@apple.com>
3160 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3162 2015-09-24 Mark Lam <mark.lam@apple.com>
3164 Unreviewed. Make Lucas Forschler a WebKit reviewer.
3166 * Scripts/webkitpy/common/config/contributors.json:
3168 2015-09-24 Carlos Garcia Campos <cgarcia@igalia.com>
3170 Unreviewed. Fix GObject DOM API breaks after r190120.
3172 Bring back code removed in r169931 to handle documentation of
3176 (WebKitDOMDocGenerator):
3177 (WebKitDOMDocGenerator.write_deleted_classes):
3178 (WebKitDOMDocGenerator.generate):
3179 (write_deleted_classes):
3180 (WebKitDOMDocGeneratorSections._deleted_class):
3181 (WebKitDOMDocGeneratorSections._deleted_class.in):
3182 (WebKitDOMDocGeneratorSections.write_deleted_classes):
3183 (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3185 2015-09-23 Myles C. Maxfield <mmaxfield@apple.com>
3187 [Cocoa] [Font Features] Implement font-variant-*
3188 https://bugs.webkit.org/show_bug.cgi?id=148413
3190 Reviewed by Darin Adler.
3192 Update test font to use "lnum" feature.
3194 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3195 (Generator::appendGSUBTable):
3197 2015-09-22 Andy Estes <aestes@apple.com>
3199 ContentFiltering.AllowDownloadAfterAddData is very flaky
3200 https://bugs.webkit.org/show_bug.cgi?id=148885
3201 <rdar://problem/22729563>
3203 Reviewed by Alexey Proskuryakov.
3205 The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3206 but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3207 -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3209 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3212 2015-09-22 Alexey Proskuryakov <ap@apple.com>
3214 Mavericks: Media tests start to time out after a few days of bot uptime
3215 https://bugs.webkit.org/show_bug.cgi?id=149468
3217 Reviewed by Chris Dumez.
3219 * Scripts/webkitpy/port/base.py:
3220 * Scripts/webkitpy/port/driver.py:
3221 * Scripts/webkitpy/port/mac.py:
3223 2015-09-22 Nan Wang <n_wang@apple.com>
3225 Unreviewed, add myself to the committers list.
3227 * Scripts/webkitpy/common/config/contributors.json:
3229 2015-09-21 Simon Fraser <simon.fraser@apple.com>
3231 Remove 'nullable' to fix older iOS builds.
3233 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3234 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3236 2015-09-21 Brent Fulgham <bfulgham@apple.com>
3238 [Win] Show tiled drawing debug overlay on Windows
3239 https://bugs.webkit.org/show_bug.cgi?id=149426
3241 Reviewed by Dean Jackson.
3243 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3244 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3245 * MiniBrowser/win/Common.cpp:
3246 (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3248 * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3250 2015-09-21 Brent Fulgham <bfulgham@apple.com>
3252 [Win] Use command-line argument to launch in regular or High DPI mode.
3253 https://bugs.webkit.org/show_bug.cgi?id=149417
3255 Reviewed by Dean Jackson.
3257 * MiniBrowser/win/Common.cpp:
3258 (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3259 very start of execution, before the MiniBrowser.dll is loaded.
3260 * win/DLLLauncher/DLLLauncherMain.cpp:
3261 (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3262 present. On WinCairo, always use High DPI.
3264 2015-09-21 Ryosuke Niwa <rniwa@webkit.org>
3266 32-bit Mac build fix attempt after r190065.
3268 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3270 2015-09-21 Alexey Proskuryakov <ap@apple.com>
3272 [OS X] Update for Xcode 7.0 on Yosemite
3273 https://bugs.webkit.org/show_bug.cgi?id=149389
3275 Reviewed by Dan Bernstein.
3277 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3278 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3279 Removed unneeded declarations - conforming to a protocol is sufficient.
3281 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3282 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3283 Changed the definitions to be compiled whenever the SDK requires it (so we will have
3284 dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3286 2015-09-21 Simon Fraser <simon.fraser@apple.com>
3288 Add the ability for tests to run script in the UI process in WebKitTestRunner
3289 https://bugs.webkit.org/show_bug.cgi?id=149356
3291 Reviewed by Tim Horton.
3293 This change adds testRunner.runUIScript(script, callback), which allows a test
3294 to execute script in a JSContext which runs in the UI process. That context
3295 has bindings exposed through the UIScriptController interface; currently one test
3296 function, and some iOS-specific functions are included. UIScriptController can be
3297 async with a callback, and runUIScript() itself is asynchronous. When the UI
3298 script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3299 is a string passed back to the web process, and given to the runUIScript()
3302 Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3304 * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3305 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3306 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3307 (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3308 complete, call back into TestRunner.
3309 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3310 (WTR::nextUIScriptCallbackID):
3311 (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3312 (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3313 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3314 * WebKitTestRunner/PlatformWebView.h:
3315 * WebKitTestRunner/TestController.cpp:
3316 (WTR::updateTestOptionsFromTestHeader):
3317 (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3318 (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3319 * WebKitTestRunner/TestInvocation.cpp:
3320 (WTR::TestInvocation::shouldUseFixedLayout):
3321 (WTR::TestInvocation::shouldUseThreadedScrolling):
3322 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3323 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3324 (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3325 (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3326 * WebKitTestRunner/TestInvocation.h:
3327 * WebKitTestRunner/TestOptions.h:
3328 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3329 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3330 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3331 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3332 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3333 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3334 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3335 (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3336 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3337 (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3338 * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3339 (WTR::UIScriptController::doAsyncTask):
3340 (WTR::UIScriptController::zoomToScale):
3341 (WTR::UIScriptController::zoomScale):
3342 (WTR::UIScriptController::minimumZoomScale):
3343 (WTR::UIScriptController::maximumZoomScale):
3344 (WTR::UIScriptController::contentVisibleRect):
3345 * WebKitTestRunner/mac/EventSenderProxy.mm:
3346 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3347 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3348 * WebKitTestRunner/mac/TestControllerMac.mm:
3349 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3350 (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3351 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3352 * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3353 (UIScriptContext::UIScriptContext):
3354 (UIScriptContext::~UIScriptContext):
3355 (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3356 asynchronous, call the callback.
3357 (UIScriptContext::nextTaskCallbackID):
3358 (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3359 that has a callback). Has to store the callbackID of the script, so code called from the completion
3360 callback knows which UI script invoked it.
3361 (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3362 (UIScriptContext::uiScriptComplete):
3363 (UIScriptContext::objectFromRect): Make a JS object from a rect.
3364 * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3365 (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3366 * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3367 (WTR::UIScriptController::UIScriptController):
3368 (WTR::UIScriptController::makeWindowObject):
3369 (WTR::UIScriptController::wrapperClass):
3370 (WTR::UIScriptController::doAsyncTask):
3371 (WTR::UIScriptController::zoomToScale):
3372 (WTR::UIScriptController::zoomScale):
3373 (WTR::UIScriptController::minimumZoomScale):
3374 (WTR::UIScriptController::maximumZoomScale):
3375 (WTR::UIScriptController::contentVisibleRect):
3376 (WTR::UIScriptController::uiScriptComplete):
3377 * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3378 (WTR::UIScriptController::create):
3379 * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3381 2015-09-21 Tim Horton <timothy_horton@apple.com>
3383 Turn on threaded scrolling by default in the tests
3384 https://bugs.webkit.org/show_bug.cgi?id=149377
3386 Reviewed by Simon Fraser.
3388 * WebKitTestRunner/mac/TestControllerMac.mm:
3389 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3390 (WTR::shouldUseThreadedScrolling): Deleted.
3391 Turn on threaded scrolling by default.
3393 2015-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
3395 [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3396 https://bugs.webkit.org/show_bug.cgi?id=149252
3398 Reviewed by Darin Adler.
3400 In case of glib tests the test runner notifies about tests
3401 crashing, but for google tests we don't get any feedback, which
3402 means that in case of a test crashing we get a list of **PASS**
3403 messages and at the summary we are notified that the test suite
3404 has failed, but it's impossible to know which test cases have failed.
3406 * Scripts/run-gtk-tests:
3407 (TestRunner._run_google_test): Add a **CRASH** message if test
3410 2015-09-20 Alexey Proskuryakov <ap@apple.com>
3412 WebKitTestRunner can leak user content script results between tests
3413 https://bugs.webkit.org/show_bug.cgi?id=149391
3415 Reviewed by Sam Weinig.
3417 Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3418 about:blank, and thus about:blank doesn't have unintended side effects.
3420 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3421 (WTR::InjectedBundle::beginTesting):
3422 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3423 (WTR::InjectedBundlePage::resetAfterTest):
3425 2015-09-20 Alexey Proskuryakov <ap@apple.com>
3427 [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3428 https://bugs.webkit.org/show_bug.cgi?id=149384
3430 Reviewed by Chris Fleizach.
3432 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3433 (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3434 (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3435 regardless of whether someone else holds a reference (we also call -stopListening in
3438 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3439 (AccessibilityController::platformResetToConsistentState):
3440 (AccessibilityController::addNotificationListener):
3443 2015-09-20 Youenn Fablet <youenn.fablet@crf.canon.fr>
3445 Remove XHR_TIMEOUT compilation guard
3446 https://bugs.webkit.org/show_bug.cgi?id=149260
3448 Reviewed by Benjamin Poulain.
3450 * Scripts/webkitperl/FeatureList.pm:
3452 2015-09-19 Dan Bernstein <mitz@apple.com>
3454 Attempted build fix.
3456 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3458 2015-09-18 Commit Queue <commit-queue@webkit.org>
3460 Unreviewed, rolling out r189908.
3461 https://bugs.webkit.org/show_bug.cgi?id=149368
3463 Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3467 "printing does not use minimum page zoom factor"
3468 https://bugs.webkit.org/show_bug.cgi?id=108507
3469 http://trac.webkit.org/changeset/189908
3471 2015-09-18 Andy Estes <aestes@apple.com>
3473 [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3474 https://bugs.webkit.org/show_bug.cgi?id=149360
3476 Reviewed by Tim Horton.
3480 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3481 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3482 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3483 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3484 (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3486 * TestWebKitAPI/ios/pages.pages: Added.
3488 2015-09-18 Nan Wang <n_wang@apple.com>
3490 AX: Implement ARIA 1.1 @aria-current on iOS
3491 https://bugs.webkit.org/show_bug.cgi?id=149297
3493 Reviewed by Chris Fleizach.
3495 Added support to test aria-current on iOS.
3497 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3498 (AccessibilityUIElement::stringAttributeValue):
3499 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3500 (WTR::AccessibilityUIElement::stringAttributeValue):
3502 2015-09-18 Alexey Proskuryakov <ap@apple.com>
3504 iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3505 https://bugs.webkit.org/show_bug.cgi?id=149352
3507 Reviewed by Simon Fraser.
3509 * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3510 m_context can be null. This may indicate a bug in webkitpy too, but
3511 WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3512 wrong with opening and immediately closing it.
3514 2015-09-18 Daniel Bates <dabates@apple.com>
3516 isGitSVNDirectory() returns true when Git is not installed
3517 https://bugs.webkit.org/show_bug.cgi?id=149351
3519 Reviewed by Alexey Proskuryakov.
3521 Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3522 Git is not installed on the machine.
3524 * Scripts/VCSUtils.pm:
3525 (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3526 status code 0 (success).
3528 2015-09-18 Alex Christensen <achristensen@webkit.org>
3530 Prevent build-webkit from building four times on Windows
3531 https://bugs.webkit.org/show_bug.cgi?id=149336
3533 Reviewed by Brent Fulgham.
3535 * Scripts/build-webkit:
3536 Move the Windows code out of the for loop iterating over each subdirectory to be build.
3537 They're built all at once.
3538 * Scripts/webkitdirs.pm:
3539 (buildVisualStudioProject):
3540 (cmakeGeneratedBuildfile):
3541 Don't generate the Visual Studio solution if it already exists.
3542 It will run CMake again if necessary.
3544 2015-09-17 Simon Fraser <simon.fraser@apple.com>
3546 [iOS WK2] WTR fails to set the key window in the UIKit sense
3547 https://bugs.webkit.org/show_bug.cgi?id=149325
3549 Reviewed by Tim Horton.
3551 -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3552 This causes UIKit to bypass code that actually sets the key window, resulting in
3553 [UIAppliation sharedApplication].keyWindow always being nil.
3555 Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3556 -[WebKitTestRunnerWindow isKeyWindow] call super.
3558 * WebKitTestRunner/PlatformWebView.h:
3559 (WTR::PlatformWebView::setWindowIsKey): Deleted.
3560 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3561 (WTR::PlatformWebView::setWindowIsKey):
3562 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3563 (WTR::PlatformWebView::setWindowIsKey):
3564 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3565 (-[WebKitTestRunnerWindow isKeyWindow]):
3566 (WTR::PlatformWebView::PlatformWebView):
3567 (WTR::PlatformWebView::~PlatformWebView):
3568 (WTR::PlatformWebView::setWindowIsKey):
3569 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3570 (WTR::PlatformWebView::setWindowIsKey):
3572 2015-09-17 Simon Fraser <simon.fraser@apple.com>
3574 [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3575 https://bugs.webkit.org/show_bug.cgi?id=149321
3577 Reviewed by Tim Horton.
3579 InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
3580 enabled the "testing" viewport configuration, which disables page scaling.
3582 If we're running viewport tests, we want the normal web page configuration.
3583 Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3584 based on whether the test is in a "viewport" directory.
3586 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3587 (WTR::InjectedBundle::beginTesting):
3588 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3589 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3590 * WebKitTestRunner/TestInvocation.cpp:
3591 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3592 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3593 (WTR::TestInvocation::shouldMakeViewportFlexible):
3594 (WTR::TestInvocation::invoke):
3595 * WebKitTestRunner/TestInvocation.h:
3596 * WebKitTestRunner/ios/TestControllerIOS.mm:
3597 (WTR::TestController::platformConfigureViewForTest):
3598 (WTR::shouldMakeViewportFlexible): Deleted.
3600 2015-09-17 Simon Fraser <simon.fraser@apple.com>
3602 Give iOS WebKitTestRunner a launch storyboard
3603 https://bugs.webkit.org/show_bug.cgi?id=149314
3605 Reviewed by Dan Bates.
3607 Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3608 that it's been built for specific device configurations, and puts the window
3609 at the top of the screen. This simplifies coordinate conversions in a future patch.
3611 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3612 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3613 * WebKitTestRunner/ios/Launch.storyboard: Added.
3615 2015-09-17 Myles C. Maxfield <mmaxfield@apple.com>
3617 Update licence in r189890
3618 https://bugs.webkit.org/show_bug.cgi?id=149306
3620 Reviewed by Dean Jackson.
3622 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3623 * FontWithFeatures/FontWithFeatures/FontCreator.h:
3624 * FontWithFeatures/FontWithFeatures/main.cpp:
3626 2015-09-17 Mark Lam <mark.lam@apple.com>
3628 Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3629 https://bugs.webkit.org/show_bug.cgi?id=149285
3631 Reviewed by Saam Barati.
3633 Just need to add an option to pass --no-jit to run-jsc-stress-test.
3635 * Scripts/run-javascriptcore-tests:
3636 (runJSCStressTests):
3638 2015-09-17 Alex Christensen <achristensen@webkit.org>
3640 Switch AppleWin build to use CMake
3641 https://bugs.webkit.org/show_bug.cgi?id=149163
3643 Reviewed by Brent Fulgham.
3645 * Scripts/build-webkit:
3646 * Scripts/run-api-tests:
3649 (prepareEnvironmentForRunningTestTool):
3651 (testToolPath): Deleted.
3652 Run the API tests as separate executables on Windows.
3653 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3654 * Scripts/webkitdirs.pm:
3655 (checkRequiredSystemConfig):
3656 (jhbuildWrapperPrefixIfNeeded):
3657 (generateBuildSystemFromCMakeProject):
3658 Fix configuration quirks.
3660 2015-09-17 Dean Johnson <dean_johnson@apple.com>
3662 Added toggle options for hiding and showing certain platform families on the dashboard.
3663 https://bugs.webkit.org/show_bug.cgi?id=148403
3665 Reviewed by David Kilzer.
3667 This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3668 individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3669 families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3670 in lieu of an "all" button in the toggle menu.
3672 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3673 (parsePlatformFamily): Helper function to parse out a platform family.
3674 (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3675 page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3676 (updateToggleButtons): Updates the status of the toggle buttons.
3677 (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3678 (documentReady): Added creation of toggle buttons.
3679 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3680 (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3681 (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3682 (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
3683 this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3684 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3685 (QueueView): Updated to use hiddenPlatformFamilies.
3686 (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3687 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3688 (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3689 (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3690 (Settings.prototype.toggleHiddenPlatform): Deleted.
3691 (Settings.prototype.clearHiddenPlatforms): Deleted.
3692 (Settings.prototype.toggleShowPlatformFamily): Deleted.
3693 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3694 (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3695 (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3696 (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3697 (table.queue-grid tr.headers th):
3698 (div.settingsWrapper.hide):
3699 (div.settingsWrapper):
3700 (div.familyToggleWrapper):
3701 (div.platformFamilyToggleButton):
3702 (div.platformFamilyShowToggleButton:not(:last-child)):
3704 (div.accessibilityButton):
3705 (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3706 (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3707 (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3708 platformFamilyToggleButton and settingsWrapper class.
3709 (.accessibilityButton): Deleted.
3711 2015-09-17 Tim Horton <timothy_horton@apple.com>
3713 Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3714 https://bugs.webkit.org/show_bug.cgi?id=148904
3716 Reviewed by Myles Maxfield.
3718 * WebKitTestRunner/TestController.cpp:
3719 (WTR::parseBooleanTestHeaderValue):
3720 (WTR::updateViewOptionsFromTestHeader):
3721 Check for the key "useThreadedScrolling".
3722 Add some code to check for "true" and "false" for boolean options.
3724 (WTR::TestController::viewOptionsForTest):
3725 Apply the test's overrides last, even after the platform's.
3727 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
3729 printing does not use minimum page zoom factor
3730 https://bugs.webkit.org/show_bug.cgi?id=108507
3732 Reviewed by Darin Adler.
3734 WebKitTestRunner always takes the snapshots from the UI process
3735 (expect for IOS), so in the case of printing, the layout in the
3736 web view is not the expected one. When printing, we need to take
3737 the snapshot in the web process and ensure it's rendered with a
3740 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3741 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3742 kWKSnapshotOptionsPrinting option to
3743 WKBundlePageCreateSnapshotWithOptions() when printing. When not
3744 printing, don't even create the snapshot, since it will be ignored
3745 by the UI process that always creates its own from the WebView (expect for IOS platform)
3746 * WebKitTestRunner/TestInvocation.cpp:
3747 (WTR::TestInvocation::dumpResults): Use always the snapshot image
3748 received from the web process if any when comparing pixel
3749 results. Now we only receive a snapshot from the web process in
3750 case of printing, or when platform is IOS. Otherwhise, generate
3751 the snapshot from the WebView as usual.
3752 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3753 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3754 is created by the caller now, but the CG implementation needs to
3755 know if it's a Web or UI process snapshot.
3756 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3757 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3758 cairo surface for the given image.
3759 * WebKitTestRunner/cg/TestInvocationCG.cpp:
3760 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3761 CGContext for the given image.
3763 2015-09-16 Myles C. Maxfield <mmaxfield@apple.com>
3765 Create a font which can be used for testing font features
3766 https://bugs.webkit.org/show_bug.cgi?id=149237
3768 Reviewed by Simon Fraser.
3770 This patch adds a new project in the Tools/ directory which generates a font which can
3771 be used for testing font features. This is a standalone project consisting of two files:
3772 1. A file which actually generates the byte vector representing the font. This file has
3773 a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3774 specific, and only relies on the C++ STL.
3775 2. A file with a main() which calls generateFont() and writes out the font, as well as
3776 uses the font to render some demonstration text into a .png file. This file is platform
3779 The font itself only supports the following characters:
3780 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3781 However, the shape of these letters are either an X or a check mark.
3783 The letter "A" always is a check mark.
3784 The letter "B" always is an X.
3785 Without any font features turned on, the rest of the letters are shown as X.
3787 Each font feature has an letter associated with it. When the font feature is enabled,
3788 that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3791 Here are the mappings of font features to letters:
3823 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3824 * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3826 (roundDownToPowerOfTwo):
3827 (isFourByteAligned):
3830 (writeCFFEncodedNumber):
3831 (CFFBuilder::CFFBuilder):
3832 (CFFBuilder::takeResult):
3833 (CFFBuilder::moveTo):
3834 (CFFBuilder::lineTo):
3835 (CFFBuilder::curveToCubic):
3836 (CFFBuilder::closePath):
3837 (CFFBuilder::writePoint):
3838 (generateBoxCharString):
3839 (generateCheckCharString):
3840 (generateXCharString):
3841 (charStringForGlyph):
3842 (Generator::generate):
3843 (Generator::Placeholder::Placeholder):
3844 (Generator::Placeholder::populate):
3845 (Generator::Placeholder::~Placeholder):
3846 (Generator::placeholder):
3847 (Generator::append16):
3848 (Generator::append32):
3849 (Generator::append32BitCode):
3850 (Generator::overwrite16):
3851 (Generator::overwrite32):
3852 (Generator::appendCFFTable):
3853 (Generator::appendSubstitutionSubtable):
3854 (Generator::appendScriptSubtable):
3855 (Generator::appendGSUBTable):
3856 (Generator::appendOS2Table):
3857 (Generator::appendFormat12CMAPTable):
3858 (Generator::appendFormat4CMAPTable):
3859 (Generator::appendCMAPTable):
3860 (Generator::appendHEADTable):
3861 (Generator::appendHHEATable):
3862 (Generator::appendHMTXTable):
3863 (Generator::appendMAXPTable):
3864 (Generator::appendNAMETable):
3865 (Generator::appendPOSTTable):
3866 (Generator::calculateChecksum):
3867 (Generator::appendTable):
3869 * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3870 * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3871 (drawTextWithFeature):
3874 2015-09-16 Commit Queue <commit-queue@webkit.org>
3876 Unreviewed, rolling out r189875 and r189878.
3877 https://bugs.webkit.org/show_bug.cgi?id=149235
3879 cygwin cmake build not ready yet (Requested by alexchristensen
3882 Reverted changesets:
3884 "Switch AppleWin build to use CMake"
3885 https://bugs.webkit.org/show_bug.cgi?id=149163
3886 http://trac.webkit.org/changeset/189875
3888 "Cygwin build fix after r189875"
3889 http://trac.webkit.org/changeset/189878
3891 2015-09-16 Alex Christensen <achristensen@webkit.org>
3893 Cygwin build fix after r189875
3895 * Scripts/build-webkit:
3896 * Scripts/webkitdirs.pm:
3897 (jhbuildWrapperPrefixIfNeeded):
3898 (generateBuildSystemFromCMakeProject):
3899 Make things work with cygwin and cmake.
3901 2015-09-16 Alex Christensen <achristensen@webkit.org>
3903 Switch AppleWin build to use CMake
3904 https://bugs.webkit.org/show_bug.cgi?id=149163
3906 Reviewed by Brent Fulgham.
3908 * Scripts/build-webkit:
3910 * Scripts/run-api-tests:
3913 (prepareEnvironmentForRunningTestTool):
3915 (testToolPath): Deleted.
3916 Run the API tests as separate executables on Windows.
3917 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3919 2015-09-16 Alexey Proskuryakov <ap@apple.com>
3921 Add newer build.webkit.org pages to robots.txt
3922 https://bugs.webkit.org/show_bug.cgi?id=149219
3924 Reviewed by Darin Adler.
3926 Indexing bot watcher's dashboard can't be good.
3928 * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3930 2015-09-16 Alex Christensen <achristensen@webkit.org>
3932 Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3934 * BuildSlaveSupport/built-product-archive:
3937 2015-09-16 Csaba Osztrogonác <ossy@webkit.org>
3939 [EFL] Fix the help message of separated web process option of MiniBrowser
3940 https://bugs.webkit.org/show_bug.cgi?id=149212
3942 Reviewed by Gyuyoung Kim.
3944 * MiniBrowser/efl/main.c:
3946 2015-09-16 Alex Christensen <achristensen@webkit.org>
3948 Fix python syntax after r189851.
3950 * BuildSlaveSupport/built-product-archive:
3952 For loops need a colon.
3954 2015-09-15 Alex Christensen <achristensen@webkit.org>
3956 Fix Windows test bots after changing to non-cygwin build
3957 https://bugs.webkit.org/show_bug.cgi?id=149196
3959 Reviewed by Daniel Bates.
3961 * BuildSlaveSupport/built-product-archive:
3963 Using different versions of python makes what I think is https://bugs.python.org/issue15795
3964 prevent us from executing files from the archive on the test bots.
3966 2015-09-15 Ryosuke Niwa <rniwa@webkit.org>
3968 Add ShadowRoot interface and Element.prototype.attachShadow
3969 https://bugs.webkit.org/show_bug.cgi?id=149187
3971 Reviewed by Antti Koivisto.
3973 * Scripts/webkitperl/FeatureList.pm:
3975 2015-09-15 Aakash Jain <aakash_jain@apple.com>
3977 Appscale queue status json output lacks bots
3978 https://bugs.webkit.org/show_bug.cgi?id=149194
3979 <rdar://problem/22171089>
3981 Reviewed by Alexey Proskuryakov.
3983 * QueueStatusServer/handlers/queuestatusjson.py:
3984 (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3985 * QueueStatusServer/index.yaml: Index according to appscale requirements.
3987 2015-09-15 Brent Fulgham <bfulgham@apple.com>
3989 [Win] Provide a means for viewing the layer tree
3990 https://bugs.webkit.org/show_bug.cgi?id=149165
3992 Reviewed by Simon Fraser.
3994 Update MiniBrowser with a new Debug menu option that will
3995 dump the current layer tree to the debug console.
3997 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3998 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3999 * MiniBrowser/win/Common.cpp:
4000 (WndProc): Add handler for 'Print Layer Tree' menu option.
4001 * MiniBrowser/win/MiniBrowser.cpp:
4002 (MiniBrowser::printLayerTree): Added Handler.
4003 * MiniBrowser/win/MiniBrowser.h:
4005 2015-09-14 Myles C. Maxfield <mmaxfield@apple.com>
4007 WebKitTestRunner declarative language setting is broken for iOS
4008 https://bugs.webkit.org/show_bug.cgi?id=149119
4012 In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
4013 lost in the final version which got committed. This simply implements the existing
4014 OS X behavior on iOS.
4016 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4017 (WTR::InjectedBundle::platformInitialize):
4019 2015-09-14 Dewei Zhu <dewei_zhu@apple.com>
4021 Unreviewed, add myself to committers list.
4023 * Scripts/webkitpy/common/config/contributors.json:
4025 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
4027 [Cocoa] Allow testing with the system language
4028 https://bugs.webkit.org/show_bug.cgi?id=148671
4030 Reviewed by Anders Carlsson and Alexey Proskuryakov.
4032 React to tests marked with language=lang1,lang2,etc in their header.
4033 Once this information is parsed, pass it to
4034 WKContextConfigurationSetOverrideLanguages().
4036 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4037 (WTR::InjectedBundle::platformInitialize): Don't clobber the language
4039 * WebKitTestRunner/TestController.cpp:
4040 (WTR::TestController::createWebViewWithOptions): Call
4041 WKContextConfigurationSetOverrideLanguages().
4042 (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
4043 * WebKitTestRunner/TestOptions.h:
4044 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4045 (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
4046 option to restart the web process.
4047 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4048 (WTR::PlatformWebView::viewSupportsOptions): Ditto.
4050 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
4052 [WKTR] Allow changing the WKContextConfiguration between successive tests
4053 https://bugs.webkit.org/show_bug.cgi?id=148833
4055 Reviewed by Tim Horton.
4057 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
4058 However, there are certain tests which require specifying options in this object. This patch makes
4059 our existing code for recreating the test runner web view also recreate the WKContext.
4061 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
4064 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
4065 * WebKitTestRunner/PlatformWebView.h:
4066 (WTR::PlatformWebView::options):
4067 * WebKitTestRunner/TestController.cpp:
4068 (WTR::TestController::initialize):
4069 (WTR::TestController::generateContextConfiguration):
4070 (WTR::TestController::generatePageConfiguration):
4071 (WTR::TestController::createWebViewWithOptions):
4072 (WTR::TestController::ensureViewSupportsOptionsForTest):
4073 (WTR::updateContextConfigurationOptionsFromTestHeader):
4074 (WTR::TestController::contextConfigurationOptionsForTest):
4075 (WTR::TestController::platformCreateWebView):
4076 (WTR::TestController::platformCreateOtherPage):
4077 (WTR::updateViewOptionsFromTestHeader): Deleted.
4078 (WTR::TestController::viewOptionsForTest): Deleted.
4079 * WebKitTestRunner/TestController.h:
4080 (WTR::TestController::injectedBundlePath):
4081 (WTR::TestController::testPluginDirectory):
4082 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4083 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4084 (WTR::TestController::platformCreateWebView):
4085 (WTR::TestController::platformCreateOtherPage):
4086 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4087 (WTR::PlatformWebView::PlatformWebView):
4088 (WTR::PlatformWebView::viewSupportsOptions):
4089 * WebKitTestRunner/efl/TestControllerEfl.cpp:
4090 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4091 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4092 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4093 (WTR::PlatformWebView::PlatformWebView):
4094 (WTR::PlatformWebView::viewSupportsOptions):
4095 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4096 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4097 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4098 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4099 (WTR::PlatformWebView::PlatformWebView):
4100 (WTR::PlatformWebView::viewSupportsOptions):
4101 * WebKitTestRunner/ios/TestControllerIOS.mm:
4102 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4103 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4104 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4105 (WTR::PlatformWebView::PlatformWebView):
4106 (WTR::PlatformWebView::viewSupportsOptions):
4107 * WebKitTestRunner/mac/TestControllerMac.mm:
4108 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4109 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4111 2015-09-11 Michael Saboff <msaboff@apple.com>
4113 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
4114 https://bugs.webkit.org/show_bug.cgi?id=149083
4116 Reviewed by Alexey Proskuryakov.
4118 Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
4120 * DumpRenderTree/mac/LayoutTestHelper.m:
4121 (colorProfileURLForDisplay):
4123 2015-09-11 Saam barati <sbarati@apple.com>
4125 There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
4126 https://bugs.webkit.org/show_bug.cgi?id=149058
4128 Reviewed by Geoffrey Garen.
4130 * Scripts/run-jsc-stress-tests:
4132 2015-09-10 Commit Queue <commit-queue@webkit.org>
4134 Unreviewed, rolling out r189595.
4135 https://bugs.webkit.org/show_bug.cgi?id=149052
4137 The tests still fail (Requested by ap on #webkit).
4141 "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
4143 https://bugs.webkit.org/show_bug.cgi?id=142929
4144 http://trac.webkit.org/changeset/189595
4146 2015-09-10 Alexey Proskuryakov <ap@apple.com>
4148 Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
4149 https://bugs.webkit.org/show_bug.cgi?id=142929
4151 Reviewed by Brent Fulgham.
4153 Silence the logging. We'll track fixing the root cause in Radar.
4155 * Scripts/webkitpy/port/mac.py:
4156 (MacPort.stderr_patterns_to_strip): Added a FIXME.
4158 * Scripts/webkitpy/port/win.py:
4159 (WinPort.logging_patterns_to_strip): Added.
4161 2015-09-09 Andy Estes <aestes@apple.com>
4163 [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
4164 https://bugs.webkit.org/show_bug.cgi?id=149022
4166 Reviewed by Daniel Bates.
4168 Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
4169 did not account for this.
4171 * Scripts/webkitpy/xcode/simulator.py:
4172 (Simulator): Optionally matched a revision at the end of a runtime version number.
4173 * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
4175 2015-09-09 Andy Estes <aestes@apple.com>
4177 [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
4178 https://bugs.webkit.org/show_bug.cgi?id=149029
4179 <rdar://problem/22432624>
4181 Reviewed by Daniel Bates.
4183 * Scripts/webkitpy/xcode/simulator.py:
4184 (Simulator): Taught to parse tvOS runtimes.
4185 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
4187 2015-09-09 Alexey Proskuryakov <ap@apple.com>
4189 Fix bit rot on bot watcher's dashboard page
4190 https://bugs.webkit.org/show_bug.cgi?id=149012
4192 Reviewed by Tim Horton.
4194 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4195 The code path used by the metrics page was trying to add properties to an undefined.
4197 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4198 Silence an expection that would occur when the step has no logs. This should never
4199 happen, but it did (perhaps buildbot was misconfigured for a while).
4201 2015-09-09 Alexey Proskuryakov <ap@apple.com>
4203 Update LayoutTestRelay xcconfig file.
4205 Rubber-stamped by Dan Bernstein.
4207 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
4209 2015-09-09 Saam barati <sbarati@apple.com>
4211 DFG should have a debugging option that runs a phase that flushes all locals
4212 https://bugs.webkit.org/show_bug.cgi?id=148916
4214 Reviewed by Filip Pizlo.
4216 * Scripts/run-jsc-stress-tests:
4218 2015-09-09 Commit Queue <commit-queue@webkit.org>
4220 Unreviewed, rolling out r189530 and r189534.
4221 https://bugs.webkit.org/show_bug.cgi?id=148996
4223 Caused assertion failures on Yosemite (Requested by litherum
4226 Reverted changesets:
4228 "[WKTR] Allow changing the WKContextConfiguration between
4230 https://bugs.webkit.org/show_bug.cgi?id=148833
4231 http://trac.webkit.org/changeset/189530
4233 "[Cocoa] Fix the tests after r189530"
4234 http://trac.webkit.org/changeset/189534
4236 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
4238 [Cocoa] Fix the tests after r189530
4242 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4243 (WTR::initializeWebViewConfiguration):
4245 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
4247 [WKTR] Allow changing the WKContextConfiguration between successive tests
4248 https://bugs.webkit.org/show_bug.cgi?id=148833
4250 Reviewed by Tim Horton.
4252 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
4253 However, there are certain tests which require specifying options in this object. This patch makes
4254 our existing code for recreating the test runner web view also recreate the WKContext.
4256 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
4259 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
4260 * WebKitTestRunner/PlatformWebView.h:
4261 (WTR::PlatformWebView::options):
4262 * WebKitTestRunner/TestController.cpp:
4263 (WTR::TestController::initialize):
4264 (WTR::TestController::generateContextConfiguration):
4265 (WTR::TestController::generatePageConfiguration):
4266 (WTR::TestController::createWebViewWithOptions):
4267 (WTR::TestController::ensureViewSupportsOptionsForTest):
4268 (WTR::updateContextConfigurationOptionsFromTestHeader):
4269 (WTR::TestController::contextConfigurationOptionsForTest):
4270 (WTR::TestController::platformCreateWebView):
4271 (WTR::TestController::platformCreateOtherPage):
4272 (WTR::updateViewOptionsFromTestHeader): Deleted.
4273 (WTR::TestController::viewOptionsForTest): Deleted.
4274 * WebKitTestRunner/TestController.h:
4275 (WTR::TestController::injectedBundlePath):
4276 (WTR::TestController::testPluginDirectory):
4277 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4278 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4279 (WTR::TestController::platformCreateWebView):
4280 (WTR::TestController::platformCreateOthe