AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
4         https://bugs.webkit.org/show_bug.cgi?id=180361
5
6         Reviewed by Zalan Bujtas.
7
8         * DumpRenderTree/AccessibilityUIElement.cpp:
9         (speakAsCallback):
10         (AccessibilityUIElement::speakAs):
11         (AccessibilityUIElement::getJSClass):
12         (speakCallback): Deleted.
13         (AccessibilityUIElement::speak): Deleted.
14         * DumpRenderTree/AccessibilityUIElement.h:
15         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
16         (AccessibilityUIElement::speakAs):
17         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
18         (AccessibilityUIElement::speakAs):
19         (AccessibilityUIElement::speak): Deleted.
20         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
21         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
22         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
23         (WTR::AccessibilityUIElement::speakAs):
24         (WTR::AccessibilityUIElement::speak): Deleted.
25         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
26         (WTR::AccessibilityUIElement::speakAs):
27         (WTR::AccessibilityUIElement::speak): Deleted.
28
29 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
30
31         REGRESSION (r226395): test-webkitperl test expectations incorrect
32         https://bugs.webkit.org/show_bug.cgi?id=181307
33         <rdar://problem/36306558>
34
35         Rubber-stamped by Aakash Jain.
36
37         r226395 added two lines towards the beginning of
38         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
39         numbers in the test expectations need to update.
40
41         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
42
43 2018-01-04  Tim Horton  <timothy_horton@apple.com>
44
45         WKWebView loses minimum layout size overrides that happen while the process is terminated
46         https://bugs.webkit.org/show_bug.cgi?id=181306
47         <rdar://problem/34398288>
48
49         Reviewed by Dan Bernstein.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
52         (TEST):
53         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
54         while the process is terminated results in the page getting the correct
55         minimum layout size.
56
57 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
58
59         [MediaStream] Add Mock screen capture source
60         https://bugs.webkit.org/show_bug.cgi?id=181291
61         <rdar://problem/36298164>
62
63         Reviewed by Dean Jackson.
64
65         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
66         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
67         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
68
69 2018-01-04  Lucas Forschler  <lforschler@apple.com>
70
71         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
72
73         Reviewed by Ling Ho.
74
75         * BuildSlaveSupport/build.webkit.org-config/steps.py:
76
77 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
78
79         [Attachment Support] Create attachment elements when dropping files on iOS
80         https://bugs.webkit.org/show_bug.cgi?id=181192
81         <rdar://problem/36280945>
82
83         Reviewed by Tim Horton.
84
85         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
86         switch is enabled. See below for more details.
87
88         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
89         (-[NSItemProvider registerData:type:]):
90         (platformCopyPNG):
91         (TestWebKitAPI::TEST):
92         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
93
94         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
95         source item provider when dragging rich text *without* attachments, so this should have been a check for just
96         kUTTypeRTF instead.
97
98         (TestWebKitAPI::TEST):
99
100         Tests a few cases of inserting attachment elements via drop:
101         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
102             Instead of inserting the contents as inline web content, this should generate attachment elements.
103         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
104             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
105             back to inserting the content as an attachment.
106         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
107             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
108             or at the end).
109
110         * TestWebKitAPI/cocoa/TestWKWebView.h:
111         * TestWebKitAPI/cocoa/TestWKWebView.mm:
112         (-[TestWKWebView objectByEvaluatingJavaScript:]):
113
114         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
115         -stringByEvaluatingJavaScript to just turn around and call this.
116
117         (-[TestWKWebView stringByEvaluatingJavaScript:]):
118
119 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
120
121         Replace hard-coded paths in shebangs with #!/usr/bin/env
122         https://bugs.webkit.org/show_bug.cgi?id=181040
123
124         Reviewed by Alex Christensen.
125
126         * BuildSlaveSupport/build-launcher-app:
127         * BuildSlaveSupport/build-launcher-dmg:
128         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
129         * BuildSlaveSupport/built-product-archive:
130         * BuildSlaveSupport/clean-build:
131         * BuildSlaveSupport/delete-stale-build-files:
132         * BuildSlaveSupport/download-built-product:
133         * BuildSlaveSupport/gtk/buildbot/log/run:
134         * BuildSlaveSupport/gtk/buildbot/run:
135         * BuildSlaveSupport/gtk/pulseaudio/run:
136         * BuildSlaveSupport/kill-old-processes:
137         * BuildSlaveSupport/test-result-archive:
138         * BuildSlaveSupport/win/kill-old-processes:
139         * Scripts/SpacingHeuristics.pm:
140         * Scripts/add-include:
141         * Scripts/build-api-tests:
142         * Scripts/build-dumprendertree:
143         * Scripts/build-imagediff:
144         * Scripts/build-jsc:
145         * Scripts/build-webkit:
146         * Scripts/build-webkittestrunner:
147         * Scripts/check-Xcode-source-file-types:
148         * Scripts/check-dom-results:
149         * Scripts/check-for-exit-time-destructors:
150         * Scripts/check-for-global-initializers:
151         * Scripts/check-for-inappropriate-objc-class-names:
152         * Scripts/check-for-weak-vtables-and-externals:
153         * Scripts/clean-header-guards:
154         * Scripts/compare-timing-files:
155         * Scripts/configure-xcode-for-ios-development:
156         * Scripts/copy-webkitlibraries-to-product-directory:
157         * Scripts/create-exports:
158         * Scripts/debug-minibrowser:
159         * Scripts/debug-safari:
160         * Scripts/debug-test-runner:
161         * Scripts/do-file-rename:
162         * Scripts/do-webcore-rename:
163         * Scripts/dump-webkit-tests-run:
164         * Scripts/ensure-valid-python:
165         * Scripts/execAppWithEnv:
166         * Scripts/extract-localizable-js-strings:
167         * Scripts/filter-build-webkit:
168         * Scripts/find-extra-includes:
169         * Scripts/fix-blink-patch:
170         * Scripts/generate-coverage-data:
171         * Scripts/git-add-reviewer:
172         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
173         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
174         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
175         * Scripts/make-new-script-test:
176         * Scripts/make-script-test-wrappers:
177         * Scripts/package-root:
178         * Scripts/parse-malloc-history:
179         * Scripts/report-include-statistics:
180         * Scripts/resolve-ChangeLogs:
181         * Scripts/run-api-tests:
182         * Scripts/run-bindings-tests:
183         * Scripts/run-content-extension-tester:
184         * Scripts/run-iexploder-tests:
185         * Scripts/run-javascriptcore-tests:
186         * Scripts/run-jsc:
187         * Scripts/run-leaks:
188         * Scripts/run-mangleme-tests:
189         * Scripts/run-minibrowser:
190         * Scripts/run-pageloadtest:
191         * Scripts/run-regexp-tests:
192         * Scripts/run-safari:
193         * Scripts/run-sunspider:
194         * Scripts/run-test-runner:
195         * Scripts/run-webkit-app:
196         * Scripts/run-webkit-httpd:
197         * Scripts/run-webkit-websocketserver:
198         * Scripts/set-webkit-configuration:
199         * Scripts/show-pretty-diff:
200         * Scripts/sort-Xcode-project-file:
201         * Scripts/split-file-by-class:
202         * Scripts/sunspider-compare-results:
203         * Scripts/svn-apply:
204         * Scripts/svn-unapply:
205         * Scripts/test-webkit-scripts:
206         * Scripts/test-webkitperl:
207         * Scripts/update-iexploder-cssproperties:
208         * Scripts/update-javascriptcore-test-results:
209         * Scripts/update-webkit:
210         * Scripts/update-webkit-auxiliary-libs:
211         * Scripts/update-webkit-dependency:
212         * Scripts/update-webkit-libs-jhbuild:
213         * Scripts/update-webkit-localizable-strings:
214         * Scripts/update-webkit-support-libs:
215         * Scripts/update-webkitgtk-libs:
216         * Scripts/update-webkitwpe-libs:
217         * Scripts/webkit-build-directory:
218         * Scripts/webkitperl/LoadAsModule.pm:
219         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
220         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
221         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
222         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
223         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
224         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
225         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
226         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
227         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
228         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
229         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
230         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
231         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
232         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
233         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
234         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
235         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
236         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
237         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
238         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
239         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
240         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
241         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
242         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
243         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
244         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
245         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
246         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
247         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
248         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
249         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
250         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
251         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
252         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
253         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
254         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
255         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
256         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
257         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
258         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
259         * ccache/ccache-clang:
260         * ccache/ccache-clang++:
261         * ccache/ccache-wrapper:
262         * gtk/install-dependencies:
263         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
264         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
265         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
266         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
267         * iExploder/iexploder-1.3.2/tools/showtest.rb:
268         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
269         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
270         * iExploder/iexploder-1.7.2/src/webserver.rb:
271         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
272         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
273         * wpe/install-dependencies:
274
275 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
276
277         filter-build-webkit filters out useful compiler error lines
278         https://bugs.webkit.org/show_bug.cgi?id=179864
279
280         Reviewed by Tim Horton.
281
282         Don't filter out lines that contain information about build errors by always showing lines
283         after a line that contains "note:" or "error:".
284
285         * Scripts/filter-build-webkit:
286         (shouldShowSubsequentLine):
287         (shouldIgnoreLine):
288
289 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
290
291         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
292         https://bugs.webkit.org/show_bug.cgi?id=173915
293
294         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
295         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
296         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
297         empty string in this case.
298
299         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
300         (emitFormSubmissionEvent):
301
302 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
303
304         [GTK] Add web process API to detect when form is submitted via JavaScript
305         https://bugs.webkit.org/show_bug.cgi?id=173915
306
307         Reviewed by Carlos Garcia Campos.
308
309         Test it.
310
311         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
312         (FormSubmissionTest::FormSubmissionTest):
313         (FormSubmissionTest::~FormSubmissionTest):
314         (FormSubmissionTest::testFormSubmissionResult):
315         (FormSubmissionTest::willSendDOMEventCallback):
316         (FormSubmissionTest::willCompleteCallback):
317         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
318         (testWebExtensionFormSubmissionSteps):
319         (beforeAll):
320         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
321         (DelayedSignal::DelayedSignal):
322         (emitFormSubmissionEvent):
323         (handleFormSubmissionCallback):
324         (willSubmitFormCallback):
325         (pageCreatedCallback):
326
327 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
328
329         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
330         https://bugs.webkit.org/show_bug.cgi?id=181251
331
332         * Scripts/run-gtk-tests:
333         (GtkTestRunner):
334
335 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
336
337         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
338         https://bugs.webkit.org/show_bug.cgi?id=181136
339
340         * Scripts/run-gtk-tests:
341         (GtkTestRunner):
342
343 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
344
345         [macOS, iOS] Adopt new secure coding APIs in WebKit
346         https://bugs.webkit.org/show_bug.cgi?id=181085
347         <rdar://problem/34837397>
348
349         Reviewed by Tim Horton.
350
351         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
352         capable of supporting NSSecureCoding, so pass through the current coding routines.
353
354         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
355         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
356         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
357         routines if necessary.
358         (TEST): Updated for NSSecureCoding.
359         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
360         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
361
362 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
363
364         Remove std::chrono completely
365         https://bugs.webkit.org/show_bug.cgi?id=181186
366
367         Reviewed by Alex Christensen.
368
369         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
370         (WTR::TestController::platformRunUntil):
371
372 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
373
374         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
375         https://bugs.webkit.org/show_bug.cgi?id=181231
376
377         Reviewed by Alex Christensen.
378
379         Implement TestController APIs needed by ResourceLoadStatistics tests.
380
381         * WebKitTestRunner/TestController.cpp:
382         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
383         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
384
385 2018-01-02  Tim Horton  <timothy_horton@apple.com>
386
387         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
388         https://bugs.webkit.org/show_bug.cgi?id=181219
389
390         Reviewed by Wenson Hsieh.
391
392         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
393
394 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
395
396         Add a WebAuthentication runtime feature flag
397         https://bugs.webkit.org/show_bug.cgi?id=181220
398         <rdar://problem/36055305>
399
400         Reviewed by Brent Fulgham.
401
402         Renames the CredentialManagement runtime feature flag into WebAuthentication.
403
404         * DumpRenderTree/TestOptions.h:
405         * DumpRenderTree/TestOptions.mm:
406         (TestOptions::TestOptions):
407         * DumpRenderTree/mac/DumpRenderTree.mm:
408         (enableExperimentalFeatures):
409         (setWebPreferencesForTestOptions):
410         * WebKitTestRunner/TestController.cpp:
411         (WTR::TestController::resetPreferencesToConsistentValues):
412         (WTR::updateTestOptionsFromTestHeader):
413         * WebKitTestRunner/TestOptions.h:
414         (WTR::TestOptions::hasSameInitializationOptions const):
415
416 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
417
418         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
419         https://bugs.webkit.org/show_bug.cgi?id=181143
420         <rdar://problem/36200381>
421
422         Reviewed by Tim Horton.
423
424         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
425         attachment elements are enabled.
426
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
429         (TestWebKitAPI::TEST):
430
431 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
432
433         Update Credential Management API for WebAuthentication
434         https://bugs.webkit.org/show_bug.cgi?id=181082
435         <rdar://problem/36055239>
436
437         Reviewed by Brent Fulgham.
438
439         Enable Credential Management API for testing.
440
441         * DumpRenderTree/TestOptions.h:
442         * WebKitTestRunner/TestOptions.h:
443
444 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
445
446         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
447         https://bugs.webkit.org/show_bug.cgi?id=168194
448
449         Reviewed by Carlos Garcia Campos.
450
451         Fix an assertion and unskip the test. The order that form controls are associated is not
452         guaranteed.
453
454         * Scripts/run-gtk-tests:
455         (GtkTestRunner):
456         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
457         (didAssociateFormControlsCallback):
458
459 2018-01-02  Alex Christensen  <achristensen@webkit.org>
460
461         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
462         https://bugs.webkit.org/show_bug.cgi?id=180897
463         <rdar://problem/35535328>
464
465         Reviewed by Brent Fulgham.
466
467         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
468
469         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
470         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
471         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
472         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
473         (websiteDataStoreTestWebView):
474         (TEST):
475
476 == Rolled over to ChangeLog-2018-01-01 ==