97ed87c0896f4324b5f21ab9fda34490a51ca13a
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
2
3         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
4         https://bugs.webkit.org/show_bug.cgi?id=103407
5
6         Reviewed by Kentaro Hara.
7
8         Changing the mock to use the new results delivery API.
9
10         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
11
12 2012-12-03  Alexis Menard  <alexis@webkit.org>
13
14         [Qt] Enable CSS3 background-position offsets by default.
15         https://bugs.webkit.org/show_bug.cgi?id=103877
16
17         Reviewed by Tor Arne Vestbø.
18
19         Enable by default CSS3 background-position offsets.
20
21         * qmake/mkspecs/features/features.pri:
22
23 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
24
25         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
26         https://bugs.webkit.org/show_bug.cgi?id=103863
27
28         Reviewed by Gyuyoung Kim.
29
30         Use float instead of int for zoomLevels variables for a clearer expression
31
32         * MiniBrowser/efl/main.c:
33         (on_key_down):
34
35 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
36
37         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
38         https://bugs.webkit.org/show_bug.cgi?id=99285
39
40         Reviewed by Gyuyoung Kim.
41
42          Add support for a zoom level setting to MiniBrowser.
43          Shortcuts for setting operations are same as common browsers:
44          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
45
46         * MiniBrowser/efl/main.c:
47         (on_key_down):
48
49 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
50
51         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
52         https://bugs.webkit.org/show_bug.cgi?id=103835
53
54         Reviewed by Kentaro Hara.
55
56         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
57
58         * MiniBrowser/efl/main.c:
59         (elm_main):
60
61 2012-12-02  Mike West  <mkwst@chromium.org>
62
63         Garden-o-matic shouldn't die when blank JSON results are received.
64         https://bugs.webkit.org/show_bug.cgi?id=103838
65
66         Reviewed by Adam Barth.
67
68         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
69             If the JSONP string doesn't contain '(' or ')', return an empty object.
70         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
71             Check that this behavior stays in place.
72
73 2012-12-02  Eric Seidel  <eric@webkit.org>
74
75         run-perf-tests --profile should use iprofiler instead of instruments on Mac
76         https://bugs.webkit.org/show_bug.cgi?id=103765
77
78         Unreviewed.  Updating the unittests after my previous change.
79
80         * Scripts/webkitpy/common/system/profiler_unittest.py:
81         (ProfilerFactoryTest.test_basic):
82
83 2012-12-02  Julie Parent  <jparent@chromium.org>
84
85         Remove dead code in flakiness dashboard for obsolete buildDir option
86         https://bugs.webkit.org/show_bug.cgi?id=103792
87
88         Reviewed by Dirk Pranke.
89
90         * TestResultServer/static-dashboards/dashboard_base.js:
91         (initBuilders):
92
93 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
94
95         nrwt: clean up logic for retrying failed tests a bit
96         https://bugs.webkit.org/show_bug.cgi?id=103829
97
98         Reviewed by Ojan Vafai.
99
100         The code for determining when to retry test failures and
101         show the results.html file was awkward and could stand some
102         cleaning up. This patch should have no functional changes.
103
104         The routine called _get_failures() returned a dict of test names
105         to failure types, but we only ever used the names, so I've converted
106         it to return a list (and renamed it); also, the show_results_html()
107         file was calling that routine to figure out if anything failed, when
108         the information was already in the result_summary (as either
109         unexpected_results or total_failures), so we were doing unnecessary work.
110
111         * Scripts/webkitpy/layout_tests/controllers/manager.py:
112         (Manager.__init__):
113         (Manager.run):
114         (Manager._run_tests):
115         (Manager._failed_test_names):
116         (Manager._copy_results_html_file):
117
118 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
119
120         nrwt: remove unused methods in manager.py
121         https://bugs.webkit.org/show_bug.cgi?id=103828
122
123         Reviewed by Eric Seidel.
124
125         These two methods weren't being called by anything and were no
126         longer needed.
127
128         * Scripts/webkitpy/layout_tests/controllers/manager.py:
129         (Manager._get_failures):
130         (Manager._upload_json_files):
131
132 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
133
134         Correct the spelling of the cmakeargs argument
135         https://bugs.webkit.org/show_bug.cgi?id=103814
136
137         Reviewed by Darin Adler.
138
139         The script expects cmakeargs (plural), so lets get the
140         documentation of the script report the same.
141
142         * Scripts/build-webkit:
143
144 2012-12-02  Mike West  <mkwst@chromium.org>
145
146         [gtk] Enable the CSP_NEXT runtime flag.
147         https://bugs.webkit.org/show_bug.cgi?id=103810
148
149         Reviewed by Adam Barth.
150
151         * DumpRenderTree/gtk/DumpRenderTree.cpp:
152         (resetDefaultsToConsistentValues):
153             Turn on the CSP_NEXT runtime flag when running tests under GTK.
154
155 2012-12-02  Eric Seidel  <eric@webkit.org>
156
157         run-perf-tests --profile should use iprofiler instead of instruments on Mac
158         https://bugs.webkit.org/show_bug.cgi?id=103765
159
160         Reviewed by Ryosuke Niwa.
161
162         Stephanie pointed out that iprofiler is the newer command-line interface
163         to replace /usr/bin/instruments in Instruments 4 (which according to the
164         interblags is supported on everything since 10.6.6), so I've moved --profile
165         to use iprofiler on Mac.
166
167         I also made the IProfiler class wait for iprofiler to complete so that
168         iprofiler won't continue running after run-perf-tests is complete (and
169         spam over the top of your shell output).
170
171         There are a couple of "got-chas" to this approach:
172         1.  iprofiler will ask for your password the first time you run it, which may
173             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
174         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
175             directory and basename arguments, making IProfiler a somewhat awkward
176             baseclass of SingleFileOutputProfiler
177
178         I suspect we'll iterate from here.  It does seem slightly faster than
179         /usr/bin/instruments was.
180
181         * Scripts/webkitpy/common/system/profiler.py:
182         (ProfilerFactory.create_profiler):
183         (IProfiler):
184         (IProfiler.__init__):
185         (IProfiler.attach_to_pid):
186
187 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
188
189         Need a method to close all idle localstorage databases immediately.
190         https://bugs.webkit.org/show_bug.cgi?id=103469
191
192         Reviewed by David Kilzer.
193
194         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
195         DumpRenderTree layout tests.
196
197         * DumpRenderTree/TestRunner.cpp:
198         (closeIdleLocalStorageDatabasesCallback):
199         (TestRunner::staticFunctions):
200         * DumpRenderTree/TestRunner.h:
201         (TestRunner):
202         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
203         (TestRunner::closeIdleLocalStorageDatabases):
204         * DumpRenderTree/efl/TestRunnerEfl.cpp:
205         (TestRunner::closeIdleLocalStorageDatabases):
206         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
207         (TestRunner::closeIdleLocalStorageDatabases):
208         * DumpRenderTree/mac/TestRunnerMac.mm:
209         (TestRunner::closeIdleLocalStorageDatabases):
210         * DumpRenderTree/win/TestRunnerWin.cpp:
211         (TestRunner::closeIdleLocalStorageDatabases):
212         * DumpRenderTree/wx/TestRunnerWx.cpp:
213         (TestRunner::closeIdleLocalStorageDatabases):
214
215 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
216
217         [EFL][WK2] MiniBrowser should have a legacy mode
218         https://bugs.webkit.org/show_bug.cgi?id=103679
219
220         Reviewed by Kenneth Rohde Christiansen.
221
222         Add an option to start MiniBrowser in legacy mode.
223
224         * MiniBrowser/efl/main.c:
225         (window_create):
226         (elm_main):
227
228 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
229
230         Unreviewed, rolling out r136236.
231         http://trac.webkit.org/changeset/136236
232         https://bugs.webkit.org/show_bug.cgi?id=103833
233
234         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
235         during GC. (Requested by mkwst on #webkit).
236
237         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
238
239 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
240
241         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
242         https://bugs.webkit.org/show_bug.cgi?id=103806
243
244         Reviewed by Dirk Pranke.
245
246         There are occasional mishaps on builders where XvfbDriver doesn't properly
247         clean up the Xvfb instance it was managing so the related guard lock files
248         are still existing when the webkitpy unit tests are run. This can cause failures
249         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
250         with a specific number but is unable to due to the stale locks.
251
252         The solution to this is to use MockFileLock when inside unit test. This is achievable
253         by creating a file lock through the SystemHost instance connected to the Port object,
254         the latter available to the Driver.
255
256         * Scripts/webkitpy/common/system/file_lock_mock.py:
257         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
258         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
259         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
260         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
261         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
262         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
263
264 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
265
266         [GTK] A11y tests in WK2 report badly-formatted AX roles
267         https://bugs.webkit.org/show_bug.cgi?id=102947
268
269         Reviewed by Xan Lopez.
270
271         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
272         These are expected in both tests and their baselines.
273
274         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
275         (WTR::roleToString):
276         (WTR):
277         (WTR::AccessibilityUIElement::role):
278
279 2012-11-30  Mike West  <mkwst@chromium.org>
280
281         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
282         https://bugs.webkit.org/show_bug.cgi?id=103652
283
284         Reviewed by Adam Barth.
285
286         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
287
288         * DumpRenderTree/chromium/TestShell.cpp:
289         (TestShell::TestShell):
290
291 2012-11-30  Roger Fong  <roger_fong@apple.com>
292
293         Unreviewed. Removed temporary debugging change from DRT (r136300).
294
295         * DumpRenderTree/win/DumpRenderTree.cpp:
296         (dump):
297
298 2012-11-30  Roger Fong  <roger_fong@apple.com>
299
300         Unreviewed. Temporary change to DRT for debugging purposes.
301
302         * DumpRenderTree/win/DumpRenderTree.cpp:
303         (dump):
304
305 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
306
307         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
308         https://bugs.webkit.org/show_bug.cgi?id=103407
309
310         Reviewed by Adam Barth.
311
312         Changing the mock to use the new results delivery API.
313
314         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
315
316 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
317
318         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
319         https://bugs.webkit.org/show_bug.cgi?id=99314
320
321         Reviewed by Tor Arne Vestbø.
322
323         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
324         shared libraries.
325
326         It's a big refactoring that mostly involves moving WebCore dependent
327         code into QtWebKit and accessing it through exported QWebFrameAdapter
328         and QWebPageAdapter classes.
329
330         * DumpRenderTree/qt/DumpRenderTree.pro:
331         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
332         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
333         * MiniBrowser/qt/MiniBrowser.pro:
334         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
335         * Scripts/webkitpy/style/checker_unittest.py:
336         (GlobalVariablesTest.test_path_rules_specifier):
337         * WebKitTestRunner/InjectedBundle/Target.pri:
338         * qmake/mkspecs/features/default_post.prf:
339         * qmake/mkspecs/features/webkit_modules.prf:
340         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
341
342 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
343
344         [Qt] Unreviewed trivial fix.
345
346         Add empty.cpp back, it was removed accidentally by r129092.
347
348         * qmake/config.tests/gccdepends/empty.cpp: Added.
349
350 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
351
352         [Qt] Add support for prepare_docs and generate_docs
353
354         Follow-up to changes in Qt in how documentation is built.
355
356         Reviewed by Simon Hausmann.
357
358         * qmake/mkspecs/features/default_post.prf:
359
360 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
361
362         Finally remove webkitpy.common.system.deprecated_logging
363         https://bugs.webkit.org/show_bug.cgi?id=103624
364
365         Reviewed by Adam Barth.
366
367         Remove the deprecated logging module and its unit tests now that such logging is not
368         used anymore in webkitpy.
369
370         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
371         The tee class is renamed to Tee to conform with the usual guidelines.
372
373         Only unit test for the Tee class is currently provided as the OutputTee is not currently
374         using the webkitpy Filesystem abstraction that would make its functionality testable.
375
376         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
377         (Executive.run_and_throw_if_fail):
378         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
379         (Tee):
380         (Tee.__init__):
381         (Tee.write):
382         (OutputTee):
383         (OutputTee.__init__):
384         (OutputTee.add_log):
385         (OutputTee.remove_log):
386         (OutputTee._open_log_file):
387         (OutputTee._tee_outputs_to_files):
388         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
389         (SimpleTeeTest):
390         (SimpleTeeTest.test_simple_tee):
391         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
392         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
393
394 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
395
396         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
397         https://bugs.webkit.org/show_bug.cgi?id=103634
398
399         Reviewed by Gyuyoung Kim.
400
401         Add support for PlatformWebView::simulateRightClick() and enable
402         WebKit2 API test HitTestResultNodeHandle.
403
404         * TestWebKitAPI/PlatformEfl.cmake:
405         * TestWebKitAPI/efl/PlatformWebView.cpp:
406         (TestWebKitAPI::PlatformWebView::simulateRightClick):
407         (TestWebKitAPI):
408
409 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
410
411         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
412         https://bugs.webkit.org/show_bug.cgi?id=101192
413
414         Reviewed by Hajime Morita.
415
416         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
417
418         Tests: No new tests because there is no functional change.
419
420         * DumpRenderTree/chromium/WebPreferences.cpp:
421         (WebPreferences::applyTo):
422
423 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
424
425         [HTMLTemplateElement] Add feature flag
426         https://bugs.webkit.org/show_bug.cgi?id=103694
427
428         Reviewed by Adam Barth.
429
430         This flag will guard the implementation of the HTMLTemplateElement.
431         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
432
433         * Scripts/webkitperl/FeatureList.pm:
434
435 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
436
437         Ignore errors when removing directories on win32 during autoinstall
438         https://bugs.webkit.org/show_bug.cgi?id=103699
439
440         Unreviewed, build fix.
441
442         I think this will work on win32; if not, I'll have to actually
443         reproduce this :). The problem is that the logilab files
444         appear to contain a write-protected file, and deleting those
445         is problematic on windows.
446
447         * Scripts/webkitpy/common/system/autoinstall.py:
448         (AutoInstaller._install):
449         (AutoInstaller.install):
450
451 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
452
453         webkitpy: autoinstaller is failing on windows
454         https://bugs.webkit.org/show_bug.cgi?id=103699
455
456         Unreviewed, build fix.
457
458         We're attempting to create directories with forward slashes in them;
459         this is a no-no on windows.
460
461         * Scripts/webkitpy/common/system/autoinstall.py:
462         (AutoInstaller._create_scratch_directory_inner):
463
464 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
465
466         Fix python unit tests after r136158 (android port tests failing)
467         https://bugs.webkit.org/show_bug.cgi?id=103581
468
469         Unreviewed, build fix.
470
471         The unit tests apparently weren't ran for this patch; we failed
472         to update the mock executive calls out to adb to determine various
473         aspects of the environment, and were failing to create drivers.
474
475         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
476         (MockRunCommand.mock_run_command_fn):
477
478 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
479
480         Unreviewed, rolling out r136175 and r136177.
481         http://trac.webkit.org/changeset/136175
482         http://trac.webkit.org/changeset/136177
483         https://bugs.webkit.org/show_bug.cgi?id=103683
484
485         Changes did not correct Windows build. (Requested by bfulgham
486         on #webkit).
487
488         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
489
490 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
491
492         [Windows, WinCairo] Unreviewed build correction. Correct debug
493         build case on build machine.
494
495         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
496
497 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
498
499         [Windows, WinCairo] Unreviewed build correction. Hide the
500         unexported 'notSolidColor' symbol when testing against
501         the BitmapImage class to avoid having to deal with a
502         debug-only symbol in the Windows export definition file.
503
504         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
505
506 2012-11-29  Peter Beverloo  <peter@chromium.org>
507
508         run-perf-tests --chromium-android should not require adb in my path
509         https://bugs.webkit.org/show_bug.cgi?id=103581
510
511         Reviewed by Eric Seidel.
512
513         Remove the need to have "adb" available in the path for Layout and Performance
514         tests. We'll determine the versions of the "adb" version in path (if any) and
515         the one provided in the Chromium Android checkout. Unless the "adb" available
516         in the path is newer, the provided version will be used.
517
518         Some other minor nits addressed:
519         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
520           section, as they're not overriding anything and are used by the driver.
521         - Make _restart_adb_as_root slightly more robust by waiting for the device
522           to come back online regardless of the output.
523
524         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
525         (ChromiumAndroidPort.__init__):
526         (ChromiumAndroidPort.check_build):
527         (ChromiumAndroidPort.path_to_adb):
528         (ChromiumAndroidPort):
529         (ChromiumAndroidPort.path_to_forwarder):
530         (ChromiumAndroidPort.path_to_md5sum):
531         (ChromiumAndroidPort._path_to_helper):
532         (ChromiumAndroidPort._determine_adb_version):
533         (ChromiumAndroidPort._get_devices):
534         (ChromiumAndroidDriver.__init__):
535         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
536         (ChromiumAndroidDriver._push_executable):
537         (ChromiumAndroidDriver._restart_adb_as_root):
538
539 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
540
541         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
542         https://bugs.webkit.org/show_bug.cgi?id=103277
543
544         Reviewed by Carlos Garcia Campos.
545
546         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
547         during gtkdoc generation.
548
549         * gtk/generate-gtkdoc:
550         (get_webkit2_options):
551
552 2012-11-29  Eric Seidel  <eric@webkit.org>
553
554         run-perf-tests --chromium-android fails due to Skia INFO logging
555         https://bugs.webkit.org/show_bug.cgi?id=103585
556
557         Reviewed by Adam Barth.
558
559         Ignore all INFO logging from Chromium code.
560         Also added some basic testing of the ignored-stderr lines code.
561
562         * Scripts/webkitpy/performance_tests/perftest.py:
563         (PerfTest):
564         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
565         (MainTest.test_ignored_stderr_lines):
566
567 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
568
569         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
570         https://bugs.webkit.org/show_bug.cgi?id=103252
571
572         Reviewed by Kenneth Rohde Christiansen.
573
574         Add support for PlatformWebView::simulateMouseMove() and enable
575         WebKit2 API test MouseMoveAfterCrash.
576
577         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
578         test.
579         * TestWebKitAPI/efl/PlatformWebView.cpp:
580         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
581         to prevent loading an error page since the test case is reloading actual
582         page after web process has terminated and recovered.
583         (TestWebKitAPI):
584         (TestWebKitAPI::PlatformWebView::PlatformWebView):
585         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
586
587 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
588
589         [Qt] Fix installation of QtWebProcess binary
590         https://bugs.webkit.org/show_bug.cgi?id=101735
591
592         Reviewed by Simon Hausmann.
593
594         Add config test to detect the availability of support
595         for "program executables" in Qt (libexec).
596
597         This test can be removed after the Qt5 release.
598
599         * Tools.pro:
600         * qmake/mkspecs/features/features.prf:
601         * qmake/config.tests/libexecdir/libexecdir.cpp:
602         * qmake/config.tests/libexecdir/libexecdir.pro:
603
604 2012-11-29  Eric Seidel  <eric@webkit.org>
605
606         run-perf-tests does not work when the layout test directory does not exist
607         https://bugs.webkit.org/show_bug.cgi?id=103572
608
609         Reviewed by Ryosuke Niwa.
610
611         Make sure that Profiler() calls maybe_make_directory for the output_dir
612         before ever using it.  It's a little awkward to create the directory
613         from the constructor, but its simplest that way as the various subclasses
614         all use the directory at different times.
615
616         Since this required having a filesystem in Profiler (and I didn't want
617         to grab inside Workspace to get one), I just made Profiler expect a
618         SystemHost instead of a separate filesystem, executive and workspace.
619
620         * Scripts/webkitpy/common/system/profiler.py:
621         (ProfilerFactory.create_profiler):
622         (Profiler.__init__):
623         (SingleFileOutputProfiler.__init__):
624         (GooglePProf.__init__):
625         (GooglePProf.profile_after_exit):
626         (Instruments.__init__):
627         (Instruments.attach_to_pid):
628         * Scripts/webkitpy/common/system/profiler_unittest.py:
629         (ProfilerFactoryTest.test_basic):
630
631 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
632
633         Adding secondary email id
634         https://bugs.webkit.org/show_bug.cgi?id=103594
635
636         Unreviewed. Adding secondary email.
637
638         * Scripts/webkitpy/common/config/committers.py:
639
640 2012-11-28  Kent Tamura  <tkent@chromium.org>
641
642         garden-o-matic: Use indeterminate <progress> in the status area
643         https://bugs.webkit.org/show_bug.cgi?id=103494
644
645         Reviewed by Adam Barth.
646
647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
648         Wrap the "Processing..." message with an indeterminate progress bar.
649         We keep the message as a fallback content.
650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
651         Follow the above change.
652
653 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
654
655         Adding Nima Ghanavatian to committers.py
656         https://bugs.webkit.org/show_bug.cgi?id=103533
657
658         Reviewed by Rob Buis.
659
660         Adding myself to committers.py as a Committer.
661
662         * Scripts/webkitpy/common/config/committers.py:
663
664 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
665
666         [WinCairo] Crash when requesting favicon.
667         https://bugs.webkit.org/show_bug.cgi?id=102689
668
669         Reviewed by Brent Fulgham.
670
671         * TestWebKitAPI/Tests/WebCore/win: Added.
672         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
673         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
674         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
675         (TestWebKitAPI::TEST): Added new test.
676         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
677        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
678
679 2012-11-28  Eric Seidel  <eric@webkit.org>
680
681         run-perf-tests should have a --profile option for easy profiling
682         https://bugs.webkit.org/show_bug.cgi?id=99517
683
684         Reviewed by Adam Barth.
685
686         This is a very basic implementation which works on Mac and Linux
687         and makes it trivial for anyone to profile a PerformanceTest.
688
689         Currently it's not "hard" to profile a PerformanceTest
690         but lowering the barriers to entry here allows all of us to focus
691         less on the tools and more on the code.
692
693         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
694         which is actually "hard", and this option will make much easier.
695
696         * Scripts/webkitpy/common/system/profiler.py: Added.
697         (ProfilerFactory):
698         (ProfilerFactory.create_profiler):
699         (Profiler):
700         (Profiler.__init__):
701         (Profiler.adjusted_environment):
702         (Profiler.attach_to_pid):
703         (Profiler.did_stop):
704         (SingleFileOutputProfiler):
705         (SingleFileOutputProfiler.__init__):
706         (GooglePProf):
707         (GooglePProf.__init__):
708         (GooglePProf.adjusted_environment):
709         (GooglePProf.did_stop):
710         (Instruments):
711         (Instruments.__init__):
712         (Instruments.attach_to_pid):
713         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
714         (ProfilerFactoryTest):
715         (ProfilerFactoryTest.test_basic):
716         * Scripts/webkitpy/layout_tests/port/driver.py:
717         (Driver.__init__):
718         (Driver._start):
719         (Driver.stop):
720         (Driver.cmd_line):
721         * Scripts/webkitpy/performance_tests/perftest.py:
722         (PerfTest.parse_output):
723         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
724         (MainTest.test_parse_output):
725         (MainTest.test_parse_output_with_failing_line):
726         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
727         (PerfTestsRunner._parse_args):
728         (PerfTestsRunner.run):
729
730 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
731
732         Remove deprecated logging usage from QueueEngine
733         https://bugs.webkit.org/show_bug.cgi?id=103532
734
735         Reviewed by Dirk Pranke.
736
737         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
738         logging through the Logger object. The unit test is modified to reflect
739         these changes.
740
741         After these changes the deprecated logging (i.e. logging to stderr) is not
742         used anymore through webkitpy and can be removed.
743
744         * Scripts/webkitpy/tool/bot/queueengine.py:
745         (QueueEngine.exit_after_handled_error):
746         (QueueEngine.run):
747         (QueueEngine._stopping):
748         (QueueEngine._sleep):
749         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
750         (QueueEngineTest._run_engine):
751
752 2012-11-28  Nate Chapin  <japhet@chromium.org>
753
754         Move empty loading to DocumentLoader, simplify FrameLoader::init()
755         https://bugs.webkit.org/show_bug.cgi?id=101512
756
757         Reviewed by Adam Barth.
758
759         * DumpRenderTree/chromium/WebViewHost.cpp:
760         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
761             interprets them as a non-empty load. This change is required for
762              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
763         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
764              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
765         (TestWebKitAPI::didFinishLoadForFrame):
766         (TestWebKitAPI::TEST):
767
768 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
769
770         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
771         https://bugs.webkit.org/show_bug.cgi?id=103092
772
773         Reviewed by Tony Chang.
774
775         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
776         from touch events.
777
778         * DumpRenderTree/chromium/TestWebPlugin.cpp:
779         (parseTouchEventRequestType):
780         (TestWebPlugin::TestWebPlugin):
781         (TestWebPlugin::initialize):
782         * DumpRenderTree/chromium/TestWebPlugin.h:
783         (TestWebPlugin):
784
785 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
786
787         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
788         https://bugs.webkit.org/show_bug.cgi?id=103123
789
790         Reviewed by Laszlo Gombos.
791
792         Add support for PlatformWebView::simulateSpacebarKeyPress().
793         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
794         which is going to be unskipped in bug #103252.
795
796         * TestWebKitAPI/efl/PlatformUtilities.cpp:
797         (TestWebKitAPI::Util::sleep):
798         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
799         sleep().
800         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
801         (TestWebKitAPI):
802
803 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
804
805         Minor cleanup in TestInvocation
806         https://bugs.webkit.org/show_bug.cgi?id=103512
807
808         Reviewed by Kenneth Rohde Christiansen.
809
810         Remove a function declaration that is not defined and not used.
811         Fix spelling error in m_webProcessIsUnresponsive.
812
813         * WebKitTestRunner/TestInvocation.cpp:
814         (WTR::TestInvocation::TestInvocation):
815         (WTR::TestInvocation::invoke):
816         * WebKitTestRunner/TestInvocation.h:
817         (TestInvocation):
818         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
819         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
820         * WebKitTestRunner/qt/TestInvocationQt.cpp:
821         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
822
823 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
824
825         Unreviewed. Use my personal email as bugzilla email.
826
827         * Scripts/webkitpy/common/config/committers.py:
828
829 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
830
831         Unreviewed. Adding myself to committers.py.
832
833         * Scripts/webkitpy/common/config/committers.py:
834
835 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
836
837         Unreviewed. Adding myself to committers.py.
838
839         * Scripts/webkitpy/common/config/committers.py:
840
841 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
842
843         Add basic implementation for MediaStreamAudioDestinationNode
844         https://bugs.webkit.org/show_bug.cgi?id=101815
845
846         Reviewed by Chris Rogers.
847
848         Adds a bit of code that exercises the WebKit API.
849
850         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
851         (MockWebMediaStreamSourceConsumer):
852         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
853         (MockWebMediaStreamCenter::didCreateMediaStream):
854
855 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
856
857         Unreviewed. Adding myself to committers list.
858
859         * Scripts/webkitpy/common/config/committers.py:
860
861 2012-11-27  Li Yin  <li.yin@intel.com>
862
863         Unreviewed. Adding myself to committers list.
864
865         * Scripts/webkitpy/common/config/committers.py:
866
867 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
868
869         Unreviewed. Adding myself to committers.py.
870
871         * Scripts/webkitpy/common/config/committers.py:
872
873 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
874
875         Unreviewd. Adding myself to committers list.
876
877         * Scripts/webkitpy/common/config/committers.py:
878
879 2012-11-27  Tony Chang  <tony@chromium.org>
880
881         Bring back partytime!
882         https://bugs.webkit.org/show_bug.cgi?id=103466
883
884         Reviewed by Adam Barth.
885
886         "code 404, message Unknown function images/partytime_gif" since we didn't
887         allow .gif or .png files to be served.
888
889         * Scripts/webkitpy/tool/servers/gardeningserver.py:
890         (GardeningHTTPRequestHandler):
891
892 2012-11-27  Adam Barth  <abarth@webkit.org>
893
894         run-perf-tests fails on Android because of stderr output
895         https://bugs.webkit.org/show_bug.cgi?id=103462
896
897         Reviewed by Ryosuke Niwa.
898
899         The chromium-android port produces some stderr output that causes
900         run-perf-tests to get sad and not record the results of the performance
901         test. This patch teaches run-perf-test to ignore this output much in
902         the same way that it currently ignores some stdout messages.
903
904         * Scripts/webkitpy/performance_tests/perftest.py:
905         (PerfTest.run):
906         (PerfTest._should_ignore_line):
907         (PerfTest):
908         (PerfTest._should_ignore_line_in_stderr):
909         (PerfTest._filter_stderr):
910         (PerfTest._should_ignore_line_in_parser_test_result):
911
912 2012-11-27  Tony Chang  <tony@chromium.org>
913
914         Fix garden-o-matic for non-chromium ports
915         https://bugs.webkit.org/show_bug.cgi?id=103458
916
917         Reviewed by Adam Barth.
918
919         I was getting a 403 error when trying to select any non-chromium port.
920
921         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
922         (ReflectionHandler._handle_request): Use the path without query params.
923
924 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
925
926         [EFL][WK2] 3D pixel tests are failing
927         https://bugs.webkit.org/show_bug.cgi?id=102833
928
929         Reviewed by Kenneth Rohde Christiansen.
930
931         Generate a snapshot of the view in the UI process instead of the web process.
932         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
933
934         * WebKitTestRunner/TestInvocation.h:
935         (TestInvocation):
936         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
937         (WTR::writeFunction):
938         (WTR::paintRepaintRectOverlay):
939         (WTR):
940         (WTR::TestInvocation::forceRepaintDoneCallback):
941         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
942         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
943         (WTR::PlatformWebView::windowSnapshotImage):
944
945 2012-11-27  Adam Barth  <abarth@webkit.org>
946
947         Make it possible to run performance tests on Chromium Android
948         https://bugs.webkit.org/show_bug.cgi?id=103268
949
950         Reviewed by Ryosuke Niwa.
951
952         Based on a patch by Peter Beverloo.
953
954         This patch (almost) makes it possible to run WebKit performance tests
955         on the Chromium port for Android. There are a few things I had to do
956         in order to make this happen:
957
958         1) The worker number when creating a driver for a port is zero-based
959            for layout tests and elsewhere. Android uses this to determine
960            which device it has to run on, so make it zero based for performance
961            tests as well.
962
963         2) Tests aren't available on the Android device, so we start an HTTP
964            server that serves the tests to the device or emulator.
965
966         The one shortcoming of this patch is that chromium-android produces
967         some stderr output that confuses run-perf-tests. I'll address that
968         issue in a subsequent CL. This patch also depends on
969         https://codereview.chromium.org/11416182 in order to work.
970
971         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
972         (ChromiumAndroidPort.start_http_server):
973         (ChromiumAndroidDriver._command_from_driver_input):
974         * Scripts/webkitpy/performance_tests/perftest.py:
975         (ReplayPerfTest.prepare):
976         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
977         (PerfTestsRunner.__init__):
978         (PerfTestsRunner._parse_args):
979         (PerfTestsRunner._start_servers):
980         (PerfTestsRunner):
981         (PerfTestsRunner._stop_servers):
982         (PerfTestsRunner.run):
983         (PerfTestsRunner._run_tests_set):
984
985 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
986
987         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
988         https://bugs.webkit.org/show_bug.cgi?id=103408
989
990         Reviewed by Dirk Pranke.
991
992         Remove the use of the deprecated log and error methods by replacing them with
993         logging through Python's logging.Logger objects.
994
995         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
996         updates any affected unit test.
997
998         * Scripts/webkitpy/common/checkout/changelog.py:
999         (ChangeLogEntry._parse_entry):
1000         * Scripts/webkitpy/common/checkout/checkout.py:
1001         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1002         (CheckoutTest.test_apply_patch):
1003         * Scripts/webkitpy/common/checkout/deps_mock.py:
1004         (MockDEPS.write_variable):
1005         * Scripts/webkitpy/common/checkout/scm/detection.py:
1006         (SCMDetector.default_scm):
1007         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1008         (SCMDetectorTest.test_detect_scm_system):
1009         * Scripts/webkitpy/common/checkout/scm/git.py:
1010         (Git._check_git_architecture):
1011         (Git._commit_on_branch):
1012         * Scripts/webkitpy/common/checkout/scm/scm.py:
1013         (SCM.ensure_clean_working_directory):
1014         (SCM.ensure_no_local_commits):
1015         (SCM.will.commit_locally_with_message):
1016         * Scripts/webkitpy/common/checkout/scm/svn.py:
1017         (SVN.apply_reverse_diff):
1018         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1019         (Attachment._validate_flag_value):
1020         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1021         (Bugzilla._fetch_bug_page):
1022         (Bugzilla.bug_id_for_attachment_id):
1023         (Bugzilla.authenticate):
1024         (Bugzilla._commit_queue_flag):
1025         (Bugzilla.add_attachment_to_bug):
1026         (Bugzilla.add_patch_to_bug):
1027         (Bugzilla.create_bug):
1028         (Bugzilla.clear_attachment_flags):
1029         (Bugzilla.set_flag_on_attachment):
1030         (Bugzilla.obsolete_attachment):
1031         (Bugzilla.add_cc_to_bug):
1032         (Bugzilla.post_comment_to_bug):
1033         (Bugzilla.close_bug_as_fixed):
1034         (Bugzilla.reassign_bug):
1035         (reopen_bug):
1036         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1037         (MockBugzilla.create_bug):
1038         (MockBugzilla.reassign_bug):
1039         (MockBugzilla.set_flag_on_attachment):
1040         (MockBugzilla.post_comment_to_bug):
1041         (MockBugzilla.add_attachment_to_bug):
1042         (MockBugzilla.add_patch_to_bug):
1043         (MockBugzilla.reopen_bug):
1044         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1045         (test_add_cc_to_bug):
1046         (_assert_reopen):
1047         (test_reopen_bug):
1048         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1049         (MockBuilder.force_build):
1050         * Scripts/webkitpy/common/net/credentials.py:
1051         (Credentials._run_security_tool):
1052         * Scripts/webkitpy/common/net/credentials_unittest.py:
1053         (_assert_security_call):
1054         * Scripts/webkitpy/common/net/irc/irc_mock.py:
1055         (MockIRC.post):
1056         (MockIRC.disconnect):
1057         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1058         (IRCProxy.__init__):
1059         (IRCProxy.disconnect):
1060         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1061         (IRCProxyTest.test_trivial):
1062         * Scripts/webkitpy/common/net/layouttestresults.py:
1063         (ORWTResultsHTMLParser._failures_from_fail_row):
1064         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1065         (test_failures_from_fail_row):
1066         * Scripts/webkitpy/common/net/networktransaction.py:
1067         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1068         (JSONTestResult._tokenize):
1069         (JSONTestResult._failure_types_from_actual_result):
1070         * Scripts/webkitpy/common/net/statusserver.py:
1071         (StatusServer.update_status):
1072         (StatusServer.update_svn_revision):
1073         * Scripts/webkitpy/common/net/statusserver_mock.py:
1074         (MockStatusServer.release_work_item):
1075         (MockStatusServer.update_work_items):
1076         (MockStatusServer.submit_to_ews):
1077         (MockStatusServer.update_status):
1078         * Scripts/webkitpy/common/net/unittestresults.py:
1079         (UnitTestResults.results_from_string):
1080         * Scripts/webkitpy/common/system/executive_mock.py:
1081         (MockExecutive.running_pids):
1082         (MockExecutive.run_and_throw_if_fail):
1083         (MockExecutive.run_command):
1084         (MockExecutive.popen):
1085         * Scripts/webkitpy/common/system/user_mock.py:
1086         (MockUser.confirm):
1087         (MockUser.open_url):
1088         * Scripts/webkitpy/common/system/workspace_unittest.py:
1089         (WorkspaceTest.test_create_zip):
1090         (WorkspaceTest.test_create_zip_exception):
1091         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
1092         (MockWatchList.determine_cc_and_messages):
1093         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1094         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1095         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1096         (EflPortTest.test_show_results_html_file):
1097         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1098         (GtkPortTest.test_show_results_html_file):
1099         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1100         (test_show_results_html_file):
1101         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1102         (test_build_driver):
1103         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1104         (QtPortTest.test_show_results_html_file):
1105         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1106         (WinPortTest.test_show_results_html_file):
1107         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1108         (XvfbDriverTest.assertDriverStartSuccessful):
1109         (XvfbDriverTest.test_start_no_pixel_tests):
1110         (XvfbDriverTest.test_start_pixel_tests):
1111         (XvfbDriverTest.test_start_arbitrary_worker_number):
1112         (XvfbDriverTest.test_start_next_worker):
1113         (XvfbDriverTest.test_stop):
1114         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1115         (TestLayoutTestApacheHttpd.test_start_cmd):
1116         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1117         (test_run_test_pause_before_testing):
1118         (test_run_memory_test):
1119         (_test_run_with_json_output):
1120         (test_run_respects_no_results):
1121         (test_run_generates_and_show_results_page):
1122         (test_run_respects_no_show_results):
1123         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1124         (FeedersTest.test_commit_queue_feeder):
1125         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1126         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
1127         (test_report_flaky_tests_creating_bug):
1128         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1129         (IRCCommandTest.test_rollout_updates_working_copy):
1130         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1131         (IRCBotTest.test_exception_during_command):
1132         (IRCBotTest.test_hi):
1133         (IRCBotTest.test_help):
1134         (IRCBotTest.test_restart):
1135         (IRCBotTest.test_rollout):
1136         (IRCBotTest.test_revert):
1137         (IRCBotTest.test_roll_chromium_deps):
1138         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1139         (IRCBotTest.test_multi_rollout):
1140         (IRCBotTest.test_rollout_with_r_in_svn_revision):
1141         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1142         (IRCBotTest.test_rollout_bananas):
1143         (IRCBotTest.test_rollout_invalidate_revision):
1144         (IRCBotTest.test_rollout_invalidate_reason):
1145         (test_multi_rollout_invalidate_reason):
1146         (test_rollout_no_reason):
1147         (test_multi_rollout_no_reason):
1148         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1149         (SheriffTest.test_post_blame_comment_on_bug):
1150         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1151         (ApplyWatchListLocalTest.test_args_parsing):
1152         (test_args_parsing_with_bug):
1153         * Scripts/webkitpy/tool/commands/download_unittest.py:
1154         (test_land_cowboy):
1155         (test_check_style):
1156         (test_create_rollout):
1157         (test_create_rollout_resolved):
1158         (test_rollout):
1159         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1160         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1161         (EarlyWarningSytemTest._default_expected_logs):
1162         (EarlyWarningSytemTest._test_builder_ews):
1163         (EarlyWarningSytemTest._test_testing_ews):
1164         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1165         (OpenBugsTest.test_args_parsing):
1166         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1167         (QueryCommandsTest.test_bugs_to_commit):
1168         (QueryCommandsTest.test_patches_in_commit_queue):
1169         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1170         (FeederQueueTest.test_feeder_queue):
1171         (AbstractPatchQueueTest.test_next_patch):
1172         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
1173         (CommitQueueTest.test_commit_queue):
1174         (test_commit_queue_failure):
1175         (test_commit_queue_failure_with_failing_tests):
1176         (test_rollout):
1177         (test_rollout_lands):
1178         (test_auto_retry):
1179         (test_manual_reject_during_processing):
1180         (test_report_flaky_tests):
1181         (StyleQueueTest.test_style_queue_with_style_exception):
1182         (test_style_queue_with_watch_list_exception):
1183         * Scripts/webkitpy/tool/commands/queuestest.py:
1184         (QueuesTest._default_begin_work_queue_logs):
1185         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1186         (RollCommandsTest.test_update_chromium_deps):
1187         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1188         (UploadCommandsTest.test_assign_to_committer):
1189         (test_post):
1190         (test_attach_to_bug):
1191         (test_attach_to_bug_no_description_or_comment):
1192         (test_land_safely):
1193         (test_prepare):
1194         (test_upload):
1195         (test_mark_bug_fixed):
1196         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1197         (ApplyWatchListTest.test_apply_watch_list_local):
1198         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1199         (CommitTest._test_check_test_expectations):
1200         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1201         (RunTestsTest.test_webkit_run_unit_tests):
1202         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1203         (StepsTest._assert_step_output_with_bug):
1204         (StepsTest._assert_post_diff_output_for_bug):
1205         (StepsTest.test_post_diff):
1206         (StepsTest.test_post_diff_for_commit):
1207         (StepsTest.test_ensure_bug_is_open_and_assigned):
1208         (StepsTest.test_runtests_args):
1209         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1210         (SuggestReviewersTest.test_basic):
1211         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1212         (ValidateChangeLogsTest._assert_start_line_produces_output):
1213
1214 2012-11-27  Pratik Solanki  <psolanki@apple.com>
1215
1216         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
1217         https://bugs.webkit.org/show_bug.cgi?id=101780
1218
1219         Reviewed by Brent Fulgham.
1220
1221         Clean up header includes so we don't include objc/objc-runtime.h.
1222
1223         * DumpRenderTree/mac/DumpRenderTree.mm:
1224         * DumpRenderTree/mac/ObjCPlugin.m:
1225         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
1226         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1227
1228 2012-11-27  Marja Hölttä  <marja@chromium.org>
1229
1230         Add callbacks to the FrameLoaderClient when a resource is requested
1231         https://bugs.webkit.org/show_bug.cgi?id=92761
1232
1233         Reviewed by Adam Barth.
1234
1235         In Chromium, when an extension script cancels a network
1236         request (which happens out of process), we'd like to
1237         notify content scripts running on the current page about
1238         which elements failed to load because the requests were
1239         cancelled (as opposed to e.g. the network request just
1240         didn't work). Since the resource request itself does not
1241         carry any information what DOM element is was made for,
1242         currently a content script has to search the DOM tree and
1243         guess which requests will be cancelled by its counter
1244         part. By adding these callbacks, the embedder can make
1245         this connection explictly.
1246
1247         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1248         (DRTTestRunner::DRTTestRunner):
1249         (DRTTestRunner::dumpResourceRequestCallbacks):
1250         (DRTTestRunner::reset):
1251         * DumpRenderTree/chromium/DRTTestRunner.h:
1252         (DRTTestRunner):
1253         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
1254         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
1255         * DumpRenderTree/chromium/TestShell.h:
1256         (TestShell::shouldDumpResourceRequestCallbacks):
1257         * DumpRenderTree/chromium/WebViewHost.cpp:
1258         (WebViewHost::willRequestResource):
1259         * DumpRenderTree/chromium/WebViewHost.h:
1260         (WebViewHost):
1261
1262 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1263
1264         [GStreamer] Verify if GStreamer was previously initialized
1265         https://bugs.webkit.org/show_bug.cgi?id=103151
1266
1267         Reviewed by Philippe Normand.
1268
1269         This patch adds the gst_init() in GtkLauncher, so we can add the
1270         GStreamer options in the command line through
1271         gst_init_get_option_group().
1272
1273         This approach is not valid for MiniBrowser because it uses WebKit2,
1274         where the GStreamer backend lives in the web process, which is
1275         different from the UI process.
1276
1277         * GNUmakefile.am:
1278         * GtkLauncher/main.c:
1279         (main):
1280
1281 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
1282
1283         [Qt] Fix the build with new Qt5 hash
1284         https://bugs.webkit.org/show_bug.cgi?id=103406
1285
1286         Reviewed by Csaba Osztrogonác.
1287
1288         Remove references to deprecated QApplication::GuiServer which
1289         has been removed, and use QStyleFactory::create instead of
1290         instantiating a QWindowsStyle directly since it is about to
1291         become an internal class.
1292
1293         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1294         (main):
1295         * QtTestBrowser/qttestbrowser.cpp:
1296         (LauncherApplication::LauncherApplication):
1297         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1298         (WTR::InjectedBundle::platformInitialize):
1299
1300 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1301
1302         [style] Add a style-check for enum-member names
1303         https://bugs.webkit.org/show_bug.cgi?id=103157
1304
1305         Reviewed by Daniel Bates.
1306
1307         * Scripts/webkitpy/style/checkers/cpp.py:
1308         (_EnumState):
1309         (_EnumState.__init__):
1310         (_EnumState.process_clean_line):
1311         (check_enum_casing):
1312         (check_style):
1313         (process_line):
1314         (_process_lines):
1315         (CppChecker):
1316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1317         (NoNonVirtualDestructorsTest.test_enum_casing):
1318         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
1319
1320 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
1321
1322         [EFL][jhbuild] Disable unnecessary options of elementary module
1323         https://bugs.webkit.org/show_bug.cgi?id=103360
1324
1325         Reviewed by Gyuyoung Kim.
1326
1327         When jhbuild configures elementary, unnecessary options may be enabled by
1328         user installed modules and it causes build break.
1329
1330         * efl/jhbuild.modules:
1331         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
1332
1333 2012-11-26  Varun Jain  <varunjain@chromium.org>
1334
1335         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
1336         https://bugs.webkit.org/show_bug.cgi?id=101545
1337
1338         Reviewed by Antonio Gomes.
1339
1340         For LongPress, we simulate drag by sending a mouse down and mouse drag
1341         events. If a drag is not started (because maybe there is no draggable
1342         element), then we show context menu instead (which is the current
1343         behavior for LongPress). For LongTap, we use the existing functions that
1344         LongPress uses to summon the context menu. LongPress initiated drag and
1345         drop can be enabled/disabled by the platform using the Setting
1346         touchDragDropEnabled which is disabled by default.
1347
1348         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1349         (WebTestRunner):
1350         (WebTestRunner::EventSender::EventSender):
1351         (WebTestRunner::EventSender::gestureLongTap):
1352         (WebTestRunner::EventSender::gestureEvent):
1353         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1354         (EventSender):
1355         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1356         (WebTestRunner::TestRunner::TestRunner):
1357         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
1358         (WebTestRunner):
1359         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1360         (TestRunner):
1361
1362 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
1363
1364         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
1365         https://bugs.webkit.org/show_bug.cgi?id=103224
1366
1367         Reviewed by Laszlo Gombos.
1368
1369         Add --local-storage command line argument to MiniBrowser to
1370         explicitely disable HTML5 local storage functionality. This
1371         is useful for testing purposes.
1372
1373         * MiniBrowser/efl/main.c:
1374         (window_create):
1375         (elm_main):
1376
1377 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
1378
1379         Remove use of deprecated logging from most of webkitpy.tool
1380         https://bugs.webkit.org/show_bug.cgi?id=103180
1381
1382         Reviewed by Dirk Pranke.
1383
1384         Remove calls to log and error methods of the deprecated_logging module, replacing them
1385         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
1386         except the QueueEngine.
1387
1388         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
1389
1390         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1391         (MockCommitQueue.run_command):
1392         (MockCommitQueue.command_passed):
1393         (MockCommitQueue.command_failed):
1394         (MockCommitQueue.report_flaky_tests):
1395         (MockCommitQueue.archive_last_test_results):
1396         (CommitQueueTaskTest._run_through_task):
1397         (CommitQueueTaskTest.test_success_case):
1398         (test_fast_success_case):
1399         (test_clean_failure):
1400         (test_update_failure):
1401         (test_apply_failure):
1402         (test_validate_changelog_failure):
1403         (test_build_failure):
1404         (test_red_build_failure):
1405         (test_flaky_test_failure):
1406         (test_failed_archive):
1407         (test_double_flaky_test_failure):
1408         (test_test_failure):
1409         (test_red_test_failure):
1410         (test_very_red_tree_retry):
1411         (test_red_tree_patch_rejection):
1412         (test_land_failure):
1413         * Scripts/webkitpy/tool/bot/feeders.py:
1414         (CommitQueueFeeder._update_work_items):
1415         (EWSFeeder.feed):
1416         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1417         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1418         (LayoutTestResultsReader.archive):
1419         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1420         (test_archive_last_layout_test_results):
1421         * Scripts/webkitpy/tool/bot/sheriff.py:
1422         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1423         (AbstractSequencedCommand.execute):
1424         * Scripts/webkitpy/tool/commands/commandtest.py:
1425         (CommandsTest.assert_execute_outputs):
1426         * Scripts/webkitpy/tool/commands/download.py:
1427         (AbstractPatchProcessingCommand._process_patch.execute):
1428         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1429         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1430         (AbstractRolloutPrepCommand._commit_info):
1431         * Scripts/webkitpy/tool/commands/download_unittest.py:
1432         (AbstractRolloutPrepCommandTest.test_commit_info):
1433         (DownloadCommandsTest.test_build):
1434         (DownloadCommandsTest.test_build_and_test):
1435         (test_apply_attachment):
1436         (test_apply_from_bug):
1437         (test_apply_watch_list):
1438         (test_land):
1439         (test_land_red_builders):
1440         (test_check_style):
1441         (test_build_attachment):
1442         (test_land_attachment):
1443         (test_land_from_bug):
1444         (test_land_from_url):
1445         (test_prepare_rollout):
1446         (test_create_rollout):
1447         (test_create_rollout_resolved):
1448         (test_rollout):
1449         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1450         (AbstractEarlyWarningSystem.handle_script_error.does):
1451         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1452         (EarlyWarningSytemTest._default_expected_stderr):
1453         (EarlyWarningSytemTest._default_expected_logs):
1454         (EarlyWarningSytemTest._test_testing_ews):
1455         * Scripts/webkitpy/tool/commands/openbugs.py:
1456         (OpenBugs.execute):
1457         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1458         (OpenBugsTest.test_args_parsing):
1459         * Scripts/webkitpy/tool/commands/perfalizer.py:
1460         (Perfalizer.handle_unexpected_error):
1461         * Scripts/webkitpy/tool/commands/queries.py:
1462         (PatchesInCommitQueue.execute):
1463         (PatchesToCommitQueue._needs_commit_queue):
1464         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1465         (QueryCommandsTest.test_bugs_to_commit):
1466         (QueryCommandsTest.test_patches_in_commit_queue):
1467         (QueryCommandsTest.test_patches_to_commit_queue):
1468         * Scripts/webkitpy/tool/commands/queues.py:
1469         (AbstractQueue._cc_watchers):
1470         (AbstractQueue.begin_work_queue):
1471         (FeederQueue.handle_unexpected_error):
1472         (CommitQueue.handle_script_error):
1473         (AbstractReviewQueue.handle_unexpected_error):
1474         (AbstractReviewQueue.handle_script_error):
1475         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1476         (test_auto_retry):
1477         * Scripts/webkitpy/tool/commands/queuestest.py:
1478         (QueuesTest.assert_outputs):
1479         (QueuesTest._default_begin_work_queue_stderr):
1480         (QueuesTest):
1481         (QueuesTest._default_begin_work_queue_logs):
1482         (QueuesTest.assert_queue_outputs):
1483         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1484         (RollCommandsTest.test_update_chromium_deps):
1485         (test_update_chromium_deps_older_revision):
1486         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1487         (SheriffBot.handle_unexpected_error):
1488         * Scripts/webkitpy/tool/commands/stepsequence.py:
1489         (StepSequence.run_and_handle_errors):
1490         * Scripts/webkitpy/tool/commands/upload.py:
1491         (AssignToCommitter._assign_bug_to_last_patch_attacher):
1492         (AbstractPatchUploadingCommand._prepare_state):
1493         (PostCommits.execute):
1494         (MarkBugFixed._determine_bug_id_and_svn_revision):
1495         (MarkBugFixed.execute):
1496         (CreateBug.create_bug_from_commit):
1497         (CreateBug.execute):
1498         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1499         (test_obsolete_attachments):
1500         (test_land_safely):
1501         (test_mark_bug_fixed):
1502         * Scripts/webkitpy/tool/multicommandtool.py:
1503         (Command.check_arguments_and_execute):
1504         (MultiCommandTool.main):
1505         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1506         (CommandTest.test_required_arguments):
1507         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
1508         (AddSvnMimetypeForPng.run):
1509         * Scripts/webkitpy/tool/steps/applypatch.py:
1510         (ApplyPatch.run):
1511         * Scripts/webkitpy/tool/steps/build.py:
1512         (Build.run):
1513         * Scripts/webkitpy/tool/steps/checkstyle.py:
1514         * Scripts/webkitpy/tool/steps/closebug.py:
1515         (CloseBug.run):
1516         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1517         (CloseBugForLandDiff.run):
1518         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1519         (CloseBugForLandDiffTest.test_empty_state):
1520         * Scripts/webkitpy/tool/steps/commit.py:
1521         (Commit.run):
1522         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1523         (CommitTest._test_check_test_expectations):
1524         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1525         (EnsureLocalCommitIfNeeded.run):
1526         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1527         (ObsoletePatches.run):
1528         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1529         (PrepareChangeLog.run):
1530         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1531         (ReopenBugAfterRollout.run):
1532         * Scripts/webkitpy/tool/steps/runtests.py:
1533         (RunTests.run):
1534         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1535         (RunTestsTest.test_webkit_run_unit_tests):
1536         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1537         (StepsTest.test_update_step):
1538         (StepsTest.test_runtests_args):
1539         * Scripts/webkitpy/tool/steps/update.py:
1540         (Update.run):
1541         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1542         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
1543         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
1544         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1545         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
1546         (UpdateChangeLogsWithReviewer.run):
1547         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
1548         (UpdateChromiumDEPS._validate_revisions):
1549         (UpdateChromiumDEPS.run):
1550         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1551         (ValidateChangeLogs._check_changelog_diff):
1552         (ValidateChangeLogs.run):
1553         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1554         (ValidateChangeLogsTest._assert_start_line_produces_output):
1555         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1556         (ValidateReviewer.run):
1557
1558 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
1559
1560         Coverage testing in webkitpy should omit some paths
1561         https://bugs.webkit.org/show_bug.cgi?id=103267
1562
1563         Reviewed by Dirk Pranke.
1564
1565         Omit testing coverage of any file under /usr directory and any file
1566         that is of third party origin and was autoinstalled.
1567
1568         * Scripts/webkitpy/test/main.py:
1569         (Tester._run_tests):
1570
1571 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
1572
1573         Text Autosizing: Add Text Autosizing APIs for WK2
1574         https://bugs.webkit.org/show_bug.cgi?id=100633
1575
1576         Reviewed by Sam Weinig.
1577
1578         Add test cases for Text Autosizing in WKPreferences.
1579
1580         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1581         (TestWebKitAPI::TEST):
1582
1583 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
1584
1585         [Qt] REGRESSION(r135575): It made all tests assert
1586         https://bugs.webkit.org/show_bug.cgi?id=103169
1587
1588         Reviewed by Simon Hausmann.
1589
1590         This fixes another regression introduced in r135515:
1591         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
1592         since it can be called from WebKit2 to initialize QStyle for testing.
1593         This would then lead to things such as PlatformStrategies being
1594         initialized twice.
1595
1596         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
1597         (WebCore::DumpRenderTree::DumpRenderTree):
1598
1599 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
1600
1601         Add the --order option to NRWT
1602         https://bugs.webkit.org/show_bug.cgi?id=102229
1603
1604         Reviewed by Dirk Pranke.
1605
1606         The --order option controls in what order the gathered tests will be run.
1607         There are 3 options:
1608         - natural, the tests are sorted in natural order,
1609         - random, the tests are sorted in random order,
1610         - none, the tests are kept in the order in which they were specified through
1611         arguments or the test list.
1612
1613         The natural option is the default one and maintains the current behavior.
1614
1615         The none option is primarily intended to be used with the --test-list option,
1616         with the test list file expected to list specific test names.
1617         When a directory is specified as one of the paths from under which tests should
1618         be gathered and the none option is used, that path will expand to all the tests
1619         under it, with these tests sorted in the natural order.
1620
1621         Using --order=random duplicated the behavior of the --randomize-order option, so
1622         the latter is removed.
1623
1624         This patch also incorporates the change with which makes it is possible to specify
1625         a test via arguments or the test list multiple tests and then have the test run
1626         that many times.
1627
1628         * Scripts/webkitpy/common/find_files.py:
1629         (find): Accept an optional sorting key that is used to sort files found in the directories
1630         that the given paths specify.
1631         (_normalized_find): Both paths that are then searched for the tests and the tests that
1632         were found are now kept in lists. This makes it possible to run a test multiple times
1633         by specifying it multiple times through arguments or the test list file.
1634         (_normalized_find.sort_by_directory_key):
1635         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1636         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
1637         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
1638         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1639         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
1640         (Sharder.__init__): Ditto.
1641         (Sharder._resize_shards):
1642         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1643         (SharderTests.get_shards): Modify the Shader initializing as required.
1644         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
1645         are now moved to the base Port unit tests.
1646         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1647         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
1648         the new --order option.
1649         * Scripts/webkitpy/layout_tests/port/base.py:
1650         (Port.tests): This method should now return a list of all the tests found in the specified
1651         paths.
1652         (Port._real_tests): A list is required, so no conversion to a set is made.
1653         (Port):
1654         (Port.test_key): Place this method here for now, but it should really move into a separate
1655         module.
1656         (Port._natural_sort_key): Ditto.
1657         (Port._natural_sort_key.tryint):
1658         (Port._virtual_tests): A list is required, so the function now operates on that rather than
1659         on a set.
1660         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1661         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
1662         list rather than an empty set.
1663         (PortTest.test_dont_require_http_server):
1664         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
1665         (NaturalCompareTest.assert_cmp):
1666         (NaturalCompareTest.test_natural_compare):
1667         (KeyCompareTest): The test name key unit tests are placed here for now.
1668         (KeyCompareTest.assert_cmp):
1669         (KeyCompareTest.test_test_key):
1670         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1671         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
1672         by using --order=random.
1673         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
1674         various aspects of this change.
1675         (MainTest.test_natural_order):
1676         (MainTest):
1677         (MainTest.test_natural_order_test_specified_multiple_times):
1678         (MainTest.test_random_order):
1679         (MainTest.test_random_order_test_specified_multiple_times):
1680         (MainTest.test_no_order):
1681         (MainTest.test_no_order_test_specified_multiple_times):
1682         (MainTest.test_no_order_with_directory_entries_in_natural_order):
1683         * Scripts/webkitpy/tool/commands/queries.py:
1684         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
1685
1686 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1687
1688         Unreviewed, rolling out r135600.
1689         http://trac.webkit.org/changeset/135600
1690         https://bugs.webkit.org/show_bug.cgi?id=103173
1691
1692         It made EFL API test is failed (Requested by gyuyoung_mbp on
1693         #webkit).
1694
1695         * TestWebKitAPI/PlatformEfl.cmake:
1696         * TestWebKitAPI/efl/PlatformUtilities.cpp:
1697         (TestWebKitAPI::Util::sleep):
1698         * TestWebKitAPI/efl/PlatformWebView.cpp:
1699
1700 2012-11-23  Alexis Menard  <alexis@webkit.org>
1701
1702         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
1703         https://bugs.webkit.org/show_bug.cgi?id=102104
1704
1705         Reviewed by Julien Chaffraix.
1706
1707         Protect the new feature behind a feature flag.
1708
1709         * Scripts/webkitperl/FeatureList.pm:
1710         * qmake/mkspecs/features/features.pri:
1711
1712 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
1713
1714         Unreviewed. Update my e-mail address.
1715
1716         * Scripts/webkitpy/common/config/committers.py:
1717
1718 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
1719
1720         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
1721         https://bugs.webkit.org/show_bug.cgi?id=100757
1722
1723         Reviewed by Laszlo Gombos.
1724
1725         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
1726         Updating CMake files due to changes from Bug 99011.
1727
1728         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1729         (WTR::AccessibilityController::AccessibilityController):
1730         (WTR):
1731         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1732         (AccessibilityController):
1733         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1734         (WTR):
1735         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1736         (AccessibilityUIElement):
1737         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
1738         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
1739
1740 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
1741
1742         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
1743         https://bugs.webkit.org/show_bug.cgi?id=102510
1744
1745         Reviewed by Pavel Feldman.
1746
1747         Added missing includes.
1748
1749         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1750
1751 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1752
1753         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
1754         https://bugs.webkit.org/show_bug.cgi?id=103123
1755
1756         Reviewed by Kenneth Rohde Christiansen.
1757
1758         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
1759         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
1760
1761         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
1762         test.
1763         * TestWebKitAPI/efl/PlatformUtilities.cpp:
1764         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
1765         test case is passing 0.5 seconds to sleep.
1766         * TestWebKitAPI/efl/PlatformWebView.cpp:
1767         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
1768         (TestWebKitAPI):
1769
1770 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
1771
1772         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
1773         https://bugs.webkit.org/show_bug.cgi?id=86881
1774
1775         Reviewed by Kenneth Rohde Christiansen.
1776
1777         eventSender object extended with contextClick() method in WebKitTestRunner.
1778         contextClick() method returns an array of menu items objects with field 'title' containing title of single
1779         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
1780         delivered in this patch.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1783         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1784         (WTR::EventSendingController::contextClick):
1785         (WTR):
1786         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1787         (EventSendingController):
1788
1789 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
1790
1791         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
1792         https://bugs.webkit.org/show_bug.cgi?id=102942
1793
1794         Reviewed by Tor Arne Vestbø.
1795
1796         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
1797         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
1798         to follow the same rules as other Qt 5 modules, with the exception that instead of
1799         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
1800         in other cross-platform header files to determine the correct meaning of export
1801         macros.
1802
1803         * qmake/mkspecs/features/default_post.prf:
1804         * qmake/mkspecs/features/win32/default_post.prf:
1805
1806 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
1807
1808         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
1809         https://bugs.webkit.org/show_bug.cgi?id=103111
1810
1811         Reviewed by Kenneth Rohde Christiansen.
1812
1813         This function was added as a slot during Qt 4.x times because adding
1814         virtual functions breaks binary compatibility. This constraint is gone
1815         with the initial release of WebKit with Qt 5, and therefore we can
1816         make it virtual now.
1817
1818         The change is fully source compatible as existing "re-implementations"
1819         as slots will now be called through it being a virtual function. They
1820         become unused slots.
1821
1822         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1823         (WebCore::WebPage::shouldInterruptJavaScript):
1824         (WebPage):
1825         * QtTestBrowser/webpage.h:
1826         (WebPage):
1827
1828 2012-11-22  Peter Beverloo  <peter@chromium.org>
1829
1830         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
1831         https://bugs.webkit.org/show_bug.cgi?id=103065
1832
1833         Reviewed by Dirk Pranke.
1834
1835         This addresses two further reliability issues in the Android test running
1836         scripts. Firstly, the run_tests.py script needs to have the --exit_code
1837         argument passed in order to return non-zero codes, which we need for the
1838         build master to distinguish failures from successful runs.
1839
1840         Secondly, it modifies the layout test runner to briefly wait (through
1841         the wait-for-device command) after requesting a device to switch to root
1842         mode. Without this waiting period, commands might get lost and thereby
1843         unexpectedly fail.
1844
1845         * Scripts/run-api-tests:
1846         * Scripts/run-chromium-webkit-unit-tests:
1847         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1848         (ChromiumAndroidDriver._setup_test):
1849         (ChromiumAndroidDriver._restart_adb_as_root):
1850
1851 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
1852
1853         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
1854         https://bugs.webkit.org/show_bug.cgi?id=102800
1855
1856         Reviewed by Tor Arne Vestbø.
1857
1858         This patch separates code that needs to use QWidget related APIs in
1859         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
1860         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
1861         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
1862         static library. WebKit1 is compiled without QT += widgets and therefore
1863         any widget related dependency has been moved "up" and out of WebKit1 into
1864         the WebKitWidgets library.
1865
1866         Between the code in WebKit.a and WebKitWidgets.a new adapters and
1867         interfaces have been introduced, such as QWebPageAdapter and
1868         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
1869         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
1870         The other way around if QWebPage wants to access WebCore or
1871         WebCoreSupport related functionality, it will go through
1872         QWebPageAdapater (as base class). The separation in the direction up
1873         into the API layer is complete with this patch, no code in WebKit1
1874         depends on QtWidgets. The separation the other way around, code in the
1875         API layer not using any WebCore types, is not complete yet.
1876
1877         Some classes such as QWebSettings, QWebElement or
1878         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
1879         they do not depend on widget related Qt APIs and they make much more
1880         use of WebCore internal APIs and therefore are easier to keep in
1881         WebKit1.
1882
1883         In the future we plan to place a real shared library boundary between
1884         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
1885         part of the QtWebKit shared library and by turning the WebKitWidgets
1886         static library into a shared one.
1887
1888         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1889         (WebCore::WebPage::resetSettings):
1890         (WebCore::WebPage::createWindow):
1891         (WebCore::DumpRenderTree::DumpRenderTree):
1892         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1893         (WebCore::DumpRenderTree::initJSObjects):
1894         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1895         (WebCore::DumpRenderTree::dumpFramesAsText):
1896         (WebCore::DumpRenderTree::dump):
1897         (WebCore::DumpRenderTree::createWindow):
1898         (WebCore::DumpRenderTree::pageAdapter):
1899         (WebCore):
1900         (WebCore::DumpRenderTree::mainFrameAdapter):
1901         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1902         (DumpRenderTree):
1903         * DumpRenderTree/qt/EventSenderQt.cpp:
1904         (EventSender::contextClick):
1905         (EventSender::scalePageBy):
1906         * DumpRenderTree/qt/TestRunnerQt.cpp:
1907         (TestRunner::reset):
1908         (TestRunner::display):
1909         (TestRunner::closeWebInspector):
1910         (TestRunner::showWebInspector):
1911         (TestRunner::evaluateInWebInspector):
1912         (TestRunner::setFrameFlatteningEnabled):
1913         (TestRunner::goBack):
1914         (TestRunner::setDefersLoading):
1915         (TestRunner::pauseAnimationAtTimeOnElementWithId):
1916         (TestRunner::pauseTransitionAtTimeOnElementWithId):
1917         (TestRunner::numberOfActiveAnimations):
1918         (TestRunner::setCaretBrowsingEnabled):
1919         (TestRunner::setAuthorAndUserStylesEnabled):
1920         (TestRunner::callShouldCloseOnWebView):
1921         (TestRunner::setSmartInsertDeleteEnabled):
1922         (TestRunner::setSelectTrailingWhitespaceEnabled):
1923         (TestRunner::execCommand):
1924         (TestRunner::isCommandEnabled):
1925         (TestRunner::findString):
1926         (TestRunner::elementDoesAutoCompleteForElementWithId):
1927         (TestRunner::setMockDeviceOrientation):
1928         (TestRunner::setGeolocationPermission):
1929         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1930         (TestRunner::setMockGeolocationPositionUnavailableError):
1931         (TestRunner::setMockGeolocationPosition):
1932         (TestRunner::evaluateScriptInIsolatedWorld):
1933         (TestRunner::addUserStyleSheet):
1934         (TestRunner::setMinimumTimerInterval):
1935         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1936         (TextInputController::selectedRange):
1937         (TextInputController::firstRectForCharacterRange):
1938         (TextInputController::unmarkText):
1939         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1940         (LoadAlternateHTMLStringItem::invoke):
1941         * qmake/mkspecs/features/default_post.prf:
1942         * qmake/mkspecs/features/production_build.prf:
1943         * qmake/mkspecs/features/webkit_modules.prf:
1944         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
1945
1946 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
1947
1948         WebKitTestRunner needs layoutTestController.setCacheModel
1949         https://bugs.webkit.org/show_bug.cgi?id=42684
1950
1951         Reviewed by Kenneth Rohde Christiansen.
1952
1953         Add support for testRunner.setCacheModel to WebKitTestRunner.
1954
1955         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1956         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1957         (WTR::InjectedBundle::beginTesting):
1958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1959         (WTR::TestRunner::setCacheModel):
1960         (WTR):
1961         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1962         (TestRunner):
1963
1964 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
1965
1966         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
1967         https://bugs.webkit.org/show_bug.cgi?id=101327
1968
1969         Reviewed by Simon Hausmann.
1970
1971         Avoid busy waiting for events in platformRunUntil while making
1972         sure we don't change the behavior of modal event loops.
1973
1974         * WebKitTestRunner/TestController.cpp:
1975         (WTR::TestController::~TestController):
1976         * WebKitTestRunner/TestController.h:
1977         (TestController):
1978         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1979         (WTR::TestController::platformDestroy):
1980         (WTR):
1981         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1982         (WTR::TestController::platformDestroy):
1983         (WTR):
1984         * WebKitTestRunner/mac/TestControllerMac.mm:
1985         (WTR::TestController::platformDestroy):
1986         (WTR):
1987         * WebKitTestRunner/qt/TestControllerQt.cpp:
1988         (TestController::RunLoop): Helper class to handle
1989         the event loop logic
1990         (WTR):
1991         (WTR::TestController::RunLoop::RunLoop):
1992         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
1993         the run loop. This is the appropriate API to push the WaitForMoreEvents
1994         flag to QCoreApplication::processEvents and also being able to exit the
1995         loop if we have timed out.
1996         (WTR::TestController::RunLoop::notifyDone):
1997         (WTR::TestController::RunLoop::timerFired):
1998         (WTR::TestController::RunLoop::runModal):
1999         (WTR::TestController::notifyDone):
2000         (WTR::TestController::platformInitialize):
2001         (WTR::TestController::platformDestroy):
2002         (WTR::TestController::platformRunUntil):
2003         (WTR::TestController::runModal):
2004         * WebKitTestRunner/win/TestControllerWin.cpp:
2005         (WTR::TestController::platformDestroy):
2006         (WTR):
2007
2008 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2009
2010         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
2011         https://bugs.webkit.org/show_bug.cgi?id=102926
2012
2013         Reviewed by Kenneth Rohde Christiansen.
2014
2015         Add missing bits needed by WKPreferences and AboutBlankLoad API
2016         tests in the test harness and enable these tests on EFL port.
2017
2018         * TestWebKitAPI/PlatformEfl.cmake:
2019         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2020         (TestWebKitAPI::TEST):
2021         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2022         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2023         (Util):
2024
2025 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
2026
2027         [GTK][WTR] Implement AccessibilityUIElement::stringValue
2028         https://bugs.webkit.org/show_bug.cgi?id=102951
2029
2030         Reviewed by Martin Robinson.
2031
2032         Implement AccessibilityUIElement::stringValue in the ATK backend
2033         in the same manner it is implemented in DumpRenderTree.
2034
2035         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2036         (WTR::replaceCharactersForResults):
2037         (WTR):
2038         (WTR::AccessibilityUIElement::stringValue):
2039
2040 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
2041
2042         Unreviewed. Adding myself to committers.py.
2043
2044         * Scripts/webkitpy/common/config/committers.py:
2045
2046 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
2047
2048         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
2049         https://bugs.webkit.org/show_bug.cgi?id=100061
2050
2051         Reviewed by Adam Barth.
2052
2053         On Android we're using a different pixel scaling implementation
2054         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
2055         platforms. In this mode, we don't make use of device-independent pixels. Device
2056         scale factor is provided to WebKit and get merged into page scale factor. Other
2057         than that device scale factor should have no effects on rendering.
2058
2059         * DumpRenderTree/chromium/WebPreferences.cpp:
2060         (WebPreferences::applyTo):
2061
2062 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
2063
2064         Clear MousePressed state on context menu to avoid initiating a drag
2065         https://bugs.webkit.org/show_bug.cgi?id=101786
2066
2067         Reviewed by Ojan Vafai.
2068
2069         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2070         (WebTestRunner):
2071         (WebTestRunner::EventSender::EventSender):
2072         (WebTestRunner::EventSender::contextClick):
2073         Only send a MouseUp on Windows. Keep the current mouse pressed state when
2074         calling up a context menu.
2075
2076 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2077
2078         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
2079         https://bugs.webkit.org/show_bug.cgi?id=102895
2080
2081         Reviewed by Gyuyoung Kim.
2082
2083         Change the link order so it wont override the new operator on gtest.
2084         Looks like it was crashing because an allocator mismatch (using libc's
2085         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
2086         the fastMalloc issue.
2087
2088         * TestWebKitAPI/CMakeLists.txt:
2089
2090 2012-11-21  Kentaro Hara  <haraken@chromium.org>
2091
2092         Unreviewed, rolling out r135340.
2093         http://trac.webkit.org/changeset/135340
2094         https://bugs.webkit.org/show_bug.cgi?id=102492
2095
2096         It broke Safari's internal build
2097
2098         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2099         (new):
2100         (GenerateModule):
2101         (GenerateInterface):
2102         (finish):
2103
2104 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
2105
2106         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
2107         https://bugs.webkit.org/show_bug.cgi?id=101526
2108
2109         Reviewed by Kenneth Rohde Christiansen.
2110
2111         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
2112
2113         * Scripts/webkitperl/FeatureList.pm:
2114         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
2115
2116 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
2117
2118         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
2119         https://bugs.webkit.org/show_bug.cgi?id=102867
2120
2121         Reviewed by Gyuyoung Kim.
2122
2123         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
2124
2125         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
2126         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
2127         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
2128
2129         * MiniBrowser/efl/main.c:
2130         (on_key_down):
2131
2132 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2133
2134         Unreviewed, rolling out r133859.
2135         http://trac.webkit.org/changeset/133859
2136         https://bugs.webkit.org/show_bug.cgi?id=102875
2137
2138         This patch makes API test broken (Requested by gyuyoung on
2139         #webkit).
2140
2141         * Scripts/webkitperl/FeatureList.pm:
2142
2143 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
2144
2145         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
2146         https://bugs.webkit.org/show_bug.cgi?id=99114
2147
2148         Reviewed by Gyuyoung Kim.
2149
2150         Implemented window_create and window_close smartcallback functions.
2151
2152         * MiniBrowser/efl/main.c:
2153         (on_window_create):
2154         (on_window_close):
2155         (window_create):
2156
2157 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2158
2159         Simplify builder filters now that we have lists of which builders run which tests
2160         https://bugs.webkit.org/show_bug.cgi?id=102849
2161
2162         Reviewed by Dirk Pranke.
2163
2164         We only need filters when we load the same master for multiple groups in the
2165         same test type, i.e. when we need to only include some of the builders that run
2166         a given test suite on a given master.
2167
2168         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
2169         Now just make it a method on BuilderGroup.
2170
2171         * TestResultServer/static-dashboards/builders.js:
2172         (BuilderGroup.prototype.append):
2173         (BuilderGroup.prototype.setup):
2174         (BuilderGroup.prototype._defaultBuilder):
2175         (BuilderGroup.prototype.master):
2176         (requestBuilderList):
2177         (isChromiumWebkitTipOfTreeTestRunner):
2178         (isChromiumWebkitDepsTestRunner):
2179         (loadBuildersList):
2180         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2181         (test):
2182
2183 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2184
2185         Remove perfav master for webkit_unit_tests and test_shell_tests.
2186         There are no bots on this master that run these tests.
2187         * TestResultServer/static-dashboards/builders.js:
2188
2189 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2190
2191         Remove special case for layout tests when builders fail to load
2192         https://bugs.webkit.org/show_bug.cgi?id=102842
2193
2194         Reviewed by Tony Chang.
2195
2196         Now that we load only builders that actually run the given test
2197         type, we can reliably show errors to the users because it
2198         represents a broken bot.
2199         * TestResultServer/static-dashboards/loader.js:
2200
2201 2012-11-15  Ojan Vafai  <ojan@chromium.org>
2202
2203         Generate a list of builders/test suites from the buildbot json
2204         https://bugs.webkit.org/show_bug.cgi?id=102443
2205
2206         Reviewed by Dirk Pranke.
2207
2208         Instead of the cludgy things we do now to track which bots run which tests,
2209         we generate all that data from the buildbots' json files.
2210         This is the minimal amount to keep everything working. Once this lands,
2211         we can also do a bunch of followup cleanup.
2212
2213         For now we commit the generated data. In theory, in the future, we could
2214         have the test results server generate the data on the fly.
2215
2216         For the sake of easily understanding what changes when we run the generate script,
2217         also checkin a pretty printed version of the output. The pretty printed version
2218         is too large to serve as part of the flakiness dashboard though.
2219
2220         This also has the benefit of making the dashboard load much faster since
2221         we no longer ever need to block on requests to buildbot.
2222
2223         * TestResultServer/generate_builders_json.py: Added.
2224         (master_json_url):
2225         (builder_json_url):
2226         (cached_build_json_url):
2227         (fetch_json):
2228         (insert_builder_and_test_data):
2229         (main):
2230         * TestResultServer/generate_builders_json_unittest.py: Added.
2231         (GenerateBuildersJsonTest):
2232         (GenerateBuildersJsonTest.test_master_json_url):
2233         (GenerateBuildersJsonTest.test_builder_json_url):
2234         (GenerateBuildersJsonTest.test_cached_build_json_url):
2235         (GenerateBuildersJsonTest.test_generate_json_data):
2236         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2237         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
2238         * TestResultServer/static-dashboards/builders.js:
2239         (LOAD_BUILDBOT_DATA):
2240         (BuilderGroup):
2241         (BuilderGroup.prototype.append):
2242         (BuilderGroup.prototype.master):
2243         (requestBuilderList):
2244         * TestResultServer/static-dashboards/builders.jsonp: Added.
2245         * TestResultServer/static-dashboards/builders_unittests.js: Added.
2246         * TestResultServer/static-dashboards/dashboard_base.js:
2247         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2248         (showPopupForBuild):
2249         (htmlForTestResults):
2250         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2251         (loadExpectationsLayoutTests):
2252         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2253         (resetGlobals):
2254         (test):
2255         * TestResultServer/static-dashboards/loader.js:
2256         * TestResultServer/static-dashboards/loader_unittests.js:
2257         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2258         * TestResultServer/static-dashboards/run-unittests.html:
2259         * TestResultServer/static-dashboards/timeline_explorer.html:
2260
2261 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2262
2263         [WTR][Qt] Enable fixedLayout when needed by the test
2264         https://bugs.webkit.org/show_bug.cgi?id=102811
2265
2266         Reviewed by Kenneth Rohde Christiansen.
2267
2268         Create a flickable view for CSS Device Adaptation tests. This is
2269         crucial for testing them since they will change the size of the
2270         viewport.
2271
2272         * WebKitTestRunner/PlatformWebView.h:
2273         (PlatformWebView):
2274         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2275         (WTR::PlatformWebView::PlatformWebView):
2276         (WTR::PlatformWebView::viewSupportsOptions):
2277         (WTR):
2278         * WebKitTestRunner/qt/main.cpp:
2279         (main):
2280
2281 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2282
2283         [WTR] WebKitTestRunner should be able to run tests using fixed layout
2284         https://bugs.webkit.org/show_bug.cgi?id=102517
2285
2286         Reviewed by Kenneth Rohde Christiansen.
2287
2288         WTR will now request the creation of a view that has a page using
2289         fixed layout for CSS Device Adaptation tests, but this feature might
2290         be used in the future by any other test that requires a mobile-like type
2291         of viewport (i.e. Viewport META tests should be ported).
2292
2293         The viewport type of the other tests remains unchanged and is restored
2294         when the runner leaves the device-adapt/ folder.
2295
2296         * WebKitTestRunner/PlatformWebView.h:
2297         (PlatformWebView):
2298         * WebKitTestRunner/TestInvocation.cpp:
2299         (WTR):
2300         (WTR::shouldUseFixedLayout):
2301         (WTR::updateLayoutType):
2302         (WTR::TestInvocation::invoke):
2303         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2304         (WTR::PlatformWebView::PlatformWebView):
2305         (WTR::PlatformWebView::viewSupportsOptions):
2306         (WTR):
2307
2308 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
2309
2310         [Qt] REGRESSION(r128174): Fast build path doesn't work now
2311         https://bugs.webkit.org/show_bug.cgi?id=100360
2312
2313         Reviewed by Tor Arne Vestbø.
2314
2315         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
2316
2317         * Scripts/webkitdirs.pm:
2318         (buildQMakeProjects):
2319
2320 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
2321
2322         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
2323         https://bugs.webkit.org/show_bug.cgi?id=99011
2324
2325         Reviewed by Martin Robinson.
2326
2327         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
2328
2329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
2330         (WTR::AccessibilityController::logAccessibilityEvents):
2331         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
2332
2333 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
2334
2335         webkitpy unit tests should run serially when checking code coverage
2336         https://bugs.webkit.org/show_bug.cgi?id=102693
2337
2338         Reviewed by Dirk Pranke.
2339
2340         When checking code coverage, the unit tests should not be run in parallel
2341         as this causes the tracing functions (set via sys.settrace in the coverage
2342         module) being overriden, resulting in incorrect coverage reports.
2343
2344         * Scripts/webkitpy/test/main.py:
2345         (Tester._run_tests):
2346
2347 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
2348
2349         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
2350         https://bugs.webkit.org/show_bug.cgi?id=102704
2351
2352         Reviewed by Laszlo Gombos.
2353
2354         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
2355
2356         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2357         (WTR::initEcoreEvas):
2358
2359 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
2360
2361         [garden-o-matic] Switch frontend to use the gardeningserver.
2362         https://bugs.webkit.org/show_bug.cgi?id=102712
2363
2364         Reviewed by Dirk Pranke.
2365
2366         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
2367         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
2375         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
2376
2377 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2378
2379         Unreviewed, rolling out r135172.
2380         http://trac.webkit.org/changeset/135172
2381         https://bugs.webkit.org/show_bug.cgi?id=102710
2382
2383         Broke some WebKit2 api tests :( (Requested by japhet on
2384         #webkit).
2385
2386         * DumpRenderTree/chromium/WebViewHost.cpp:
2387         (WebViewHost::updateForCommittedLoad):
2388
2389 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
2390
2391         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
2392         https://bugs.webkit.org/show_bug.cgi?id=102703
2393
2394         Reviewed by Ojan Vafai.
2395
2396         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
2397         from the same origin as the gardening server. This change gently massages the current
2398         logic to adapt an extension-sniffing-based approach of identifying static files,
2399         rather than requiring an explicit list.
2400
2401         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2402         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
2403         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
2404         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
2405
2406 2012-11-19  Ojan Vafai  <ojan@chromium.org>
2407
2408         Add DOM and HTML watchlists and add myself to a bunch of lists
2409         https://bugs.webkit.org/show_bug.cgi?id=102707
2410
2411         Reviewed by Eric Seidel.
2412
2413         * Scripts/webkitpy/common/config/watchlist:
2414
2415 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
2416
2417         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
2418         https://bugs.webkit.org/show_bug.cgi?id=102676
2419
2420         Reviewed by Tony Chang.
2421
2422         In addition, I've replaced parsePageNumber with the more commonly used
2423         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
2424         and removed setAutomaticLinkDetectionEnabled which wasn't used
2425         anywhere.
2426
2427         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2428         (DRTTestRunner::DRTTestRunner):
2429         (DRTTestRunner::reset):
2430         (DRTTestRunner::overridePreference):
2431         * DumpRenderTree/chromium/DRTTestRunner.h:
2432         (DRTTestRunner):
2433         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2434         (WebTestRunner::TestRunner::TestRunner):
2435         (WebTestRunner::TestRunner::reset):
2436         (WebTestRunner):
2437         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
2438         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
2439         (WebTestRunner::TestRunner::execCommand):
2440         (WebTestRunner::TestRunner::isCommandEnabled):
2441         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
2442         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
2443         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
2444         (WebTestRunner::TestRunner::numberOfActiveAnimations):
2445         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
2446         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
2447         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2448         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
2449         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
2450         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
2451         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
2452         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
2453         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
2454         (WebTestRunner::TestRunner::forceRedSelectionColors):
2455         (WebTestRunner::TestRunner::addUserScript):
2456         (WebTestRunner::TestRunner::addUserStyleSheet):
2457         (WebTestRunner::TestRunner::startSpeechInput):
2458         (WebTestRunner::TestRunner::loseCompositorContext):
2459         (WebTestRunner::TestRunner::markerTextForListItem):
2460         (WebTestRunner::TestRunner::findString):
2461         (WebTestRunner::TestRunner::setMinimumTimerInterval):
2462         (WebTestRunner::TestRunner::setAutofilled):
2463         (WebTestRunner::TestRunner::setValueForUser):
2464         (WebTestRunner::TestRunner::enableFixedLayoutMode):
2465         (WebTestRunner::TestRunner::setFixedLayoutSize):
2466         (WebTestRunner::TestRunner::selectionAsMarkup):
2467         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
2468         (WebTestRunner::TestRunner::resetPageVisibility):
2469         (WebTestRunner::TestRunner::setPageVisibility):
2470         (WebTestRunner::TestRunner::setTextDirection):
2471         (WebTestRunner::TestRunner::textSurroundingNode):
2472         (WebTestRunner::TestRunner::workerThreadCount):
2473         (WebTestRunner::TestRunner::cppVariantToBool):
2474         (WebTestRunner::TestRunner::cppVariantToInt32):
2475         (WebTestRunner::TestRunner::cppVariantToWebString):
2476         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
2477         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
2478         (WebTestRunner::TestRunner::fallbackMethod):
2479         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2480         (WebKit):
2481         (WebTestRunner::TestRunner::setWebView):
2482         (TestRunner):
2483         * DumpRenderTree/chromium/TestShell.cpp:
2484         (TestShell::createMainWindow):
2485         (TestShell::~TestShell):
2486
2487 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
2488
2489         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
2490         https://bugs.webkit.org/show_bug.cgi?id=101423
2491
2492         Reviewed by James Robinson.
2493
2494         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
2495         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
2496         in the future.
2497
2498         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2499         (TestWebPlugin::initialize):
2500
2501 2012-11-19  Nate Chapin  <japhet@chromium.org>
2502
2503         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2504         https://bugs.webkit.org/show_bug.cgi?id=101512
2505
2506         Reviewed by Adam Barth.
2507
2508         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
2509         interprets them as a non-empty load. This ensures
2510         http/tests/navigation/new-window-redirect-history.html continues to pass
2511         in chromium.
2512
2513         * DumpRenderTree/chromium/WebViewHost.cpp:
2514         (WebViewHost::updateForCommittedLoad):
2515
2516 2012-11-19  Vincent Scheib  <scheib@chromium.org>
2517
2518         [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
2519         https://bugs.webkit.org/show_bug.cgi?id=96946
2520
2521         Reviewed by Adam Barth.
2522
2523         The runtime flag functionality has already been removed.
2524         Now that Chromium no longer has a compile dependency on this
2525         API, it can be removed as well.
2526
2527         * DumpRenderTree/chromium/TestShell.cpp:
2528         (TestShell::TestShell):
2529
2530 2012-11-19  Kihong Kwon  <kihong.kwon@samsung.com>
2531
2532         Add PROXIMITY_EVENTS feature
2533         https://bugs.webkit.org/show_bug.cgi?id=102658
2534
2535         Reviewed by Kentaro Hara.
2536
2537         Add PROXIMITY_EVENTS feature to FeatureList and qmake.
2538
2539         * Scripts/webkitperl/FeatureList.pm:
2540         * qmake/mkspecs/features/features.pri:
2541
2542 2012-11-19  Christophe Dumez  <christophe.dumez@intel.com>
2543
2544         [WK2][WTR] Memory leak in TestController::initialize()
2545         https://bugs.webkit.org/show_bug.cgi?id=102616
2546
2547         Reviewed by Kenneth Rohde Christiansen.
2548
2549         Remove call to WKStringCreateWithUTF8CString() to construct
2550         the icon database path which was leaking memory since the
2551         returned WKStringRef was not adopted. The code now uses
2552         WTF::String instead of std::string and converts it to a
2553         WKStringRef using toWK().
2554
2555         * WebKitTestRunner/StringFunctions.h:
2556         (WTR::toWK): Overload toWK() to take a WTF::String in
2557         argument.
2558         (WTR):
2559         * WebKitTestRunner/TestController.cpp:
2560         (WTR::TestController::initialize):
2561
2562 2012-11-19  Kentaro Hara  <haraken@chromium.org>
2563
2564         Remove IDLStructure.pm
2565         https://bugs.webkit.org/show_bug.cgi?id=102642
2566
2567         Reviewed by Adam Barth.
2568
2569         Previously IDLStructure.pm was full of regular expressions to
2570         parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
2571         just contains several data structures for the IDL parser. We can
2572         move them to IDLParser.pm and thus remove IDLStructure.pm.
2573
2574         No tests. No change in generated code.
2575
2576         * WebKitTestRunner/DerivedSources.make:
2577         * WebKitTestRunner/GNUmakefile.am:
2578         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2579
2580 2012-11-18  KyungTae Kim  <ktf.kim@samsung.com>
2581
2582         [EFL] Not to include "ewk_view_private.h" in Tools
2583         https://bugs.webkit.org/show_bug.cgi?id=102644
2584
2585         Reviewed by Gyuyoung Kim.
2586
2587         Include ewk_view.h instead of ewk_view_private.h in Tools
2588
2589         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2590
2591 2012-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2592
2593         Unreviewed, rolling out r135104.
2594         http://trac.webkit.org/changeset/135104
2595         https://bugs.webkit.org/show_bug.cgi?id=102638
2596
2597         Should not use commit queue to add people to committer list.
2598         (Requested by ap_ on #webkit).
2599
2600         * Scripts/webkitpy/common/config/committers.py:
2601
2602 2012-11-18  Vivek Galatage  <vivek.vg@samsung.com>
2603
2604         Add myself to committers.py
2605         https://bugs.webkit.org/show_bug.cgi?id=102636
2606
2607         Reviewed by Laszlo Gombos.
2608
2609         Add myself to committers.py
2610
2611         * Scripts/webkitpy/common/config/committers.py:
2612
2613 2012-11-18  Genevieve Mak  <gmak@rim.com>
2614
2615         [BlackBerry] Enable Touch Sliders
2616         https://bugs.webkit.org/show_bug.cgi?id=102516
2617
2618         Reviewed by Rob Buis.
2619
2620         Enabled for BlackBerry only
2621         PR #242781
2622         PR #176014
2623
2624         * Scripts/webkitperl/FeatureList.pm:
2625
2626 2012-11-17  Dimitri Glazkov  <dglazkov@chromium.org>
2627
2628         Remove unused code I wrote a long time ago from gardeningserver.py
2629         https://bugs.webkit.org/show_bug.cgi?id=102605
2630
2631         Reviewed by Adam Barth.
2632
2633         * Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
2634         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
2635
2636 2012-11-16  Tony Chang  <tony@chromium.org>
2637
2638         Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
2639         https://bugs.webkit.org/show_bug.cgi?id=102554
2640
2641         Reviewed by Andreas Kling.
2642
2643         As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
2644         we're going to revist this feature once additional vendor support is
2645         achieved.
2646
2647         * Scripts/webkitperl/FeatureList.pm:
2648
2649 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2650
2651         [chromium] move stubs from DRTTestRunner to TestRunner
2652         https://bugs.webkit.org/show_bug.cgi?id=102489
2653
2654         Reviewed by Adam Barth.
2655
2656         This is part of moving all methods from DRTTestRunner to TestRunner.
2657         Instead of keeping one stub per method, I'm using a shared stub to
2658         clean up the code.
2659
2660         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2661         (DRTTestRunner::DRTTestRunner):
2662         * DumpRenderTree/chromium/DRTTestRunner.h:
2663         (DRTTestRunner):
2664         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2665         (WebTestRunner::TestRunner::TestRunner):
2666         (WebTestRunner):
2667         (WebTestRunner::TestRunner::fallbackMethod):
2668         (WebTestRunner::TestRunner::notImplemented):
2669         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2670         (WebTestRunner):
2671         (TestRunner):
2672         (WebTestRunner::TestRunner::setDelegate):
2673         * DumpRenderTree/chromium/TestShell.cpp:
2674         (TestShell::createMainWindow):
2675         (TestShell::~TestShell):
2676
2677 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2678
2679         [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost
2680         https://bugs.webkit.org/show_bug.cgi?id=102495
2681
2682         Reviewed by Adam Barth.
2683
2684         When a drag operation is initiated in a layout test, we need to
2685         simulate a corresponding drop event, otherwise the WebViewImpl will sit
2686         there waiting for it. Instead of having the embedder taking care of
2687         this, move this into the TestRunner library.
2688
2689         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2690         (WebKit):
2691         (WebTestProxyBase):
2692         (WebTestRunner::WebTestProxy::startDragging):
2693         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2694         (WebTestRunner::WebTestProxyBase::startDragging):
2695         (WebTestRunner):
2696         * DumpRenderTree/chromium/WebViewHost.cpp:
2697         * DumpRenderTree/chromium/WebViewHost.h:
2698         (WebViewHost):
2699
2700 2012-11-16  Tien-Ren Chen  <trchen@chromium.org>
2701
2702         Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
2703         https://bugs.webkit.org/show_bug.cgi?id=102462
2704
2705         Reviewed by James Robinson.
2706
2707         As we no longer have this "default" device scale factor.
2708
2709         * DumpRenderTree/chromium/WebPreferences.cpp:
2710         (WebPreferences::applyTo):
2711
2712 2012-11-15  Takashi Sakamoto  <tasak@google.com>
2713
2714         [Win] key event's location does not work on Windows platform.
2715         https://bugs.webkit.org/show_bug.cgi?id=89742
2716
2717         Reviewed by Brent Fulgham.
2718
2719         Modified keyDownCallback to use lparam to specify left-hand keys or
2720         right-hand keys.
2721
2722         * DumpRenderTree/win/EventSender.cpp:
2723         (makeKeyDataForScanCode):
2724         Given a virtual keycode, generate scancode and extended key bit of
2725         lparam.
2726         (keyDownCallback):
2727         Use lparam for left-hand and right-hand keys, because Windows doesn't
2728         directly provide a virtual keycode which distinguishes between
2729         left-hand and right-hand. For example, when control key is pressed,
2730         wparam has VK_CONTROL, neither VK_RCONTROL nor VK_LCONTROL.
2731
2732 2012-11-16  Tommy Widenflycht  <tommyw@google.com>
2733
2734         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
2735         https://bugs.webkit.org/show_bug.cgi?id=102386
2736
2737         Reviewed by Adam Barth.
2738
2739         Adding mock data channel functionality.
2740
2741         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2742         (MockWebRTCPeerConnectionHandler::openDataChannel):
2743
2744 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2745
2746         [chromium] delete unused testRunner methods
2747         https://bugs.webkit.org/show_bug.cgi?id=102479
2748
2749         Reviewed by Adam Barth.
2750
2751         These methods aren't used by any layout test. Remove them to avoid bit rot
2752
2753         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2754         (DRTTestRunner::DRTTestRunner):
2755         (DRTTestRunner::reset):
2756         * DumpRenderTree/chromium/DRTTestRunner.h:
2757         (DRTTestRunner):
2758         * DumpRenderTree/chromium/WebViewHost.cpp:
2759         (WebViewHost::shouldBeginEditing):
2760         (WebViewHost::shouldEndEditing):
2761         (WebViewHost::shouldInsertNode):
2762         (WebViewHost::shouldInsertText):
2763         (WebViewHost::shouldChangeSelectedRange):
2764         (WebViewHost::shouldDeleteRange):
2765         (WebViewHost::shouldApplyStyle):
2766         (WebViewHost::startDragging):
2767         (WebViewHost::enterFullScreenNow):
2768         (WebViewHost::exitFullScreenNow):
2769
2770 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
2771
2772         Private Browsing is a per-page setting that sets a global value
2773         https://bugs.webkit.org/show_bug.cgi?id=67870
2774
2775         Reviewed by Sam Weinig.
2776
2777         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2778         Call _switchNetworkLoaderToNewTestingSession before making other settings, so that
2779         they would actually apply to the testing session.
2780
2781         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2782         (WTR::InjectedBundle::initialize):
2783         (WTR::InjectedBundle::beginTesting):
2784         Only call WKBundleSwitchNetworkLoaderToNewTestingSession once per process, matching
2785         WebKit1. I'm not fully sure what is going wrong, but apparently creating mutiple
2786         sessions with the same identifier doesn't quite work.
2787
2788 2012-11-16  Yael Aharon  <yael.aharon@intel.com>
2789
2790         Unreviewed. Help bugzilla find me.
2791
2792         * Scripts/webkitpy/common/config/committers.py:
2793
2794 2012-11-16  Peter Beverloo  <peter@chromium.org>
2795
2796         Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
2797         https://bugs.webkit.org/show_bug.cgi?id=102245
2798
2799         Reviewed by Tony Chang.
2800
2801         When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
2802         the actual running part to the test runner which lives on the Chromium side.
2803         Re-implementing or even generalizing the device-interaction part in WebKit
2804         is error prone and not worth the effort.
2805
2806         * Scripts/run-api-tests:
2807         * Scripts/run-chromium-webkit-unit-tests:
2808
2809 2012-11-15  Yury Semikhatsky  <yurys@chromium.org>
2810
2811         Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
2812         https://bugs.webkit.org/show_bug.cgi?id=102384
2813
2814         Reviewed by Pavel Feldman.
2815
2816         Updated return type in accord with the changes in MemoryInstrumentationClient.
2817
2818         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2819
2820 2012-11-15  Gustavo Noronha Silva  <gns@gnome.org>
2821
2822         [GTK] Split WebCore/platform into a separate library
2823         https://bugs.webkit.org/show_bug.cgi?id=94435
2824
2825         Reviewed by Martin Robinson.
2826
2827         More people have been reporting problems when linking WebCore because
2828         the command line limit is being exceeded. Splitting WebCore a bit more
2829         is in order.
2830
2831         * GNUmakefile.am: link libWebCorePlatform into DRT
2832
2833 2012-11-15  Dana Jansens  <danakj@chromium.org>
2834
2835         [chromium] Stop using the WebCompositorSupport methods for changing settings
2836         https://bugs.webkit.org/show_bug.cgi?id=101968
2837
2838         Reviewed by James Robinson.
2839
2840         * DumpRenderTree/chromium/TestShell.cpp:
2841         * DumpRenderTree/chromium/TestShell.h:
2842         (TestShell::setPerTilePaintingEnabled):
2843         (TestShell::setAcceleratedAnimationEnabled):
2844
2845 2012-11-15  Tony Chang  <tony@chromium.org>
2846
2847         Generate Settings from a .in file
2848         https://bugs.webkit.org/show_bug.cgi?id=100393
2849
2850         Reviewed by Adam Barth.
2851
2852         Add the generated WebCore files to the include dir.
2853
2854         * TestWebKitAPI/CMakeLists.txt:
2855         * WebKitTestRunner/CMakeLists.txt:
2856
2857 2012-11-15  Roger Fong  <roger_fong@apple.com>
2858
2859         Make old-run-webkit-tests handle setting the results directory properly.
2860         https://bugs.webkit.org/show_bug.cgi?id=102273
2861         <rdar://problem/11571607>
2862
2863         Reviewed by Timothy Horton.
2864
2865         A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
2866         Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
2867         This caused many other problems including failure to upload test results and failed future test runs.
2868         The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory 
2869         using the saved directory when setting $testResultsDirectory.
2870
2871         * Scripts/old-run-webkit-tests:
2872
2873 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2874
2875         Unreviewed, rolling out r134800 and r134805.
2876         http://trac.webkit.org/changeset/134800
2877         http://trac.webkit.org/changeset/134805
2878         https://bugs.webkit.org/show_bug.cgi?id=102417
2879
2880         This patch broke chromium port (Requested by jianli on
2881         #webkit).
2882
2883         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2884         (MockWebRTCPeerConnectionHandler::openDataChannel):
2885
2886 2012-11-15  Tommy Widenflycht  <tommyw@google.com>
2887
2888         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
2889         https://bugs.webkit.org/show_bug.cgi?id=102386
2890
2891         Reviewed by Adam Barth.
2892
2893         Adding mock data channel functionality.
2894
2895         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2896         (MockWebRTCPeerConnectionHandler::openDataChannel):
2897
2898 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2899
2900         Unreviewed, rolling out r134649 and r134665.
2901         http://trac.webkit.org/changeset/134649
2902         http://trac.webkit.org/changeset/134665
2903         https://bugs.webkit.org/show_bug.cgi?id=102413
2904
2905         Broke a ton of downstream chromium tests (Requested by japhet
2906         on #webkit).
2907
2908         * DumpRenderTree/chromium/WebViewHost.cpp:
2909         (WebViewHost::updateForCommittedLoad):
2910
2911 2012-11-15  Andreas Kling  <akling@apple.com>
2912
2913         Update my e-mail address.
2914
2915         Rubber-stamped by Anders Koivisto.
2916
2917         * Scripts/webkitpy/common/config/committers.py:
2918
2919 2012-11-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2920
2921         [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
2922         https://bugs.webkit.org/show_bug.cgi?id=101323
2923
2924         Reviewed by Martin Robinson.
2925
2926         Bumping Harfbuzz to newer version so that we can remove the
2927         ifdef round the fix for bug 101009 for EFL, too.
2928         We're using the zip snapshot since jhbuild can fallback to the previously
2929         downloaded blob in case of network failures which leads to better
2930         buildbot robustness. This zip snapshot currently needs to be locally
2931         patched to fix ICU detection on systems that don't have icu pkg-config files.
2932         The patch is suggested for merging into HarfBuzz. We can remove it locally
2933         once it's accepted into HarfBuzz upstream.
2934
2935         * efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
2936         * efl/jhbuild.modules: Bumping harfbuzz version.
2937
2938 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
2939
2940         [Mac] Implement WTR --no-timeout-at-all option
2941         https://bugs.webkit.org/show_bug.cgi?id=102251
2942
2943         Reviewed by Eric Carlson.
2944
2945         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
2946         Just do it, and convert to Objective C on the way for simplicity.
2947
2948 2012-11-14  Ryuan Choi  <ryuan.choi@gmail.com>
2949
2950         [EFL] Port tiled backing store
2951         https://bugs.webkit.org/show_bug.cgi?id=71352
2952
2953         Reviewed by Gyuyoung Kim.
2954
2955         * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
2956         (_User_Arguments):
2957         (windowCreate):
2958         (parseUserArguments):
2959
2960 2012-11-14  Andy Estes  <aestes@apple.com>
2961
2962         Fix the build.
2963
2964         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2965
2966 2012-11-14  Dirk Pranke  <dpranke@chromium.org>
2967
2968         webkitpy: consolidate webkit-base-finding code
2969         https://bugs.webkit.org/show_bug.cgi?id=102007
2970
2971         Reviewed by Eric Seidel.
2972
2973         This patch creates a new "WebKitFinder" class that other
2974         modules can use to find the top of the WebKit tree and
2975         commonly used subdirectories. This logic was in the
2976         webkitpy.layout_test.port classes but wasn't specific to those
2977         classes and now can be used by other modules without needing a port
2978         (e.g., by the check-webkit-style python linter).
2979
2980         This code is somewhat redundant with the code for find_checkout_root()
2981         in the scm modules, but it does not rely on the presence of a version
2982         control system to work. This is a requirement for some uses of the
2983         tree (e.g., Chromium tester checkouts).
2984
2985         This patch removes most of the logic from the layout_tests.port.config
2986         module and makes that as private as possible. Now we just need to move
2987         the default_configuration and flag_from_configuration logic into
2988         DeprecatedPort (or someplace else appropriate) and we can finish
2989         getting rid of the Config class (but that is a separate patch).
2990
2991         * Scripts/webkitpy/common/webkit_finder.py: Added.
2992         (WebKitFinder):
2993         (WebKitFinder.__init__):
2994         (WebKitFinder.webkit_base):
2995         (WebKitFinder.path_from_webkit_base):
2996         (WebKitFinder.path_to_script):
2997         (WebKitFinder.layout_tests_dir):
2998         (WebKitFinder.perf_tests_dir):
2999         * Scripts/webkitpy/layout_tests/port/base.py:
3000         (Port.__init__):
3001         (Port):
3002         (Port.webkit_base):
3003         (Port.path_from_webkit_base):
3004         (Port.path_to_script):
3005         (Port.layout_tests_dir):
3006         (Port.perf_tests_dir):
3007         (Port.set_option_default):
3008         (Port._run_script):
3009         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3010         (PortTest.test_diff_text):
3011         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3012         (ChromiumLinuxPort._determine_driver_path_statically):
3013         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3014         * Scripts/webkitpy/layout_tests/port/config.py:
3015         (Config.__init__):
3016         (Config.build_directory):
3017         (Config.default_configuration):
3018         (Config._read_configuration):
3019         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3020         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3021         (ConfigTest.test_default_configuration__standalone):
3022         (ConfigTest.test_default_configuration__scripterror):
3023         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3024         (DriverTest.make_port):
3025         (DriverTest.test_no_timeout):
3026         * Scripts/webkitpy/layout_tests/port/gtk.py:
3027         (GtkPort.setup_environ_for_server):
3028         * Scripts/webkitpy/layout_tests/port/mac.py:
3029         (MacPort.show_results_html_file):
3030         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3031         (TestWebKitPort.__init__):
3032         (PortTestCase.make_port):
3033         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3034         (WinPortTest.test_expectations_files):
3035         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3036         (XvfbDriverTest.make_driver):
3037         (XvfbDriverTest.test_stop):
3038         * Scripts/webkitpy/style/checkers/python.py:
3039         (Pylinter.__init__):
3040
3041 2012-11-14  Dana Jansens  <danakj@chromium.org>
3042
3043         [chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
3044         https://bugs.webkit.org/show_bug.cgi?id=102296
3045
3046         Reviewed by James Robinson.
3047
3048         These settings are always set by TestShell anyhow, but we should be
3049         setting them to false here along with everything else.
3050
3051         * DumpRenderTree/chromium/WebPreferences.cpp:
3052         (WebPreferences::reset):
3053
3054 2012-11-08  Andy Estes  <aestes@apple.com>
3055
3056         [WebKit2] Need API in UIProcess to enable loading of custom protocols
3057         https://bugs.webkit.org/show_bug.cgi?id=101674
3058
3059         Reviewed by Brady Eidson.
3060
3061         Add an API test that implements a custom protocol and attempts to load
3062         a resource requiring that protocol in a WKView. The test passes only if
3063         didFinishLoadForFrame: fires.
3064
3065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3066         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
3067         (+[TestProtocol canInitWithRequest:]):
3068         (+[TestProtocol canonicalRequestForRequest:]):
3069         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3070         (-[TestProtocol startLoading]):
3071         (-[TestProtocol stopLoading]):
3072         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3073         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
3074         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
3075         (-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
3076         (-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):
3077
3078 2012-11-14  Ojan Vafai  <ojan@chromium.org>
3079
3080         Fix some defuct flakiness dashboard unittests.
3081         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3082
3083 2012-11-14  Glenn Adams  <glenn@skynav.com>
3084
3085         webkitpy: print-expectations - add --paths option to print only paths of test expectation files
3086         https://bugs.webkit.org/show_bug.cgi?id=102269
3087
3088         Reviewed by Dirk Pranke.
3089
3090         Add --paths option to print-expectations command in order to obtain list of applicable
3091         test expectation file paths.
3092
3093         * Scripts/webkitpy/tool/commands/queries.py:
3094         (PrintExpectations.__init__):
3095         (PrintExpectations.execute):
3096         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3097         (PrintExpectationsTest.run_test):
3098         (PrintExpectationsTest.test_paths):
3099
3100 2012-11-14  James Robinson  <jamesr@chromium.org>
3101
3102         webgl-background-color.html started failing
3103         https://bugs.webkit.org/show_bug.cgi?id=102247
3104
3105         Reviewed by Adrienne Walker.
3106
3107         The compositor thread should outlive the WebView.
3108
3109         * DumpRenderTree/chromium/TestShell.h:
3110         (TestShell):
3111
3112 2012-11-14  Nate Chapin  <japhet@chromium.org>
3113
3114         Move empty loading to DocumentLoader, simplify FrameLoader::init()
3115         https://bugs.webkit.org/show_bug.cgi?id=101512
3116
3117         Reviewed by Adam Barth.
3118
3119         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
3120         interprets them as a non-empty load. This ensures
3121         http/tests/navigation/new-window-redirect-history.html continues to pass
3122         in chromium.
3123
3124         * DumpRenderTree/chromium/WebViewHost.cpp:
3125         (WebViewHost::updateForCommittedLoad):
3126
3127 2012-11-14  Zan Dobersek  <zandobersek@gmail.com>
3128
3129         Remove uses of deprecated unittest.TestCase aliases
3130         https://bugs.webkit.org/show_bug.cgi?id=102253
3131
3132         Reviewed by Dirk Pranke.
3133
3134         Replace the deprecated unittest.TestCase methods with the corresponding methods
3135         everywhere inside the Tools directory. The following replacements are done:
3136         - assertEquals -> assertEqual
3137         - assert_ -> assertTrue
3138         - failUnlessRaises -> assertRaises
3139
3140         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3141         (SVNMirrorTest.test_CheckOutSource):
3142         * QueueStatusServer/model/queuepropertymixin_unittest.py:
3143         (QueuePropertyMixinTest.test_queue_property):
3144         * QueueStatusServer/model/queues_unittest.py:
3145         (QueueTest._assert_short_name):
3146         (QueueTest._assert_display_name):
3147         (QueueTest._assert_name_with_underscores):
3148         * QueueStatusServer/model/workitems_unittest.py:
3149         (WorkItemsTest.test_display_position_for_attachment):
3150         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3151         (test_parse_log_entries_from_changelog):
3152         (test_parse_log_entries_from_annotated_file):
3153         (_assert_parse_reviewer_text_and_list):
3154         (_assert_parse_reviewer_text_list):
3155         (_assert_fuzzy_reviewer_match):
3156         (_assert_parse_authors):
3157         (test_latest_entry_parse):
3158         (test_latest_entry_parse_single_entry):
3159         (test_set_reviewer):
3160         (test_set_short_description_and_bug_url):
3161         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3162         (DiffParserTest.test_diff_parser):
3163         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3164         (GitSVNTest.test_revisions_changing_files_with_local_commit):
3165         (GitSVNTest.test_upstream_branch):
3166         (GitSVNTest.test_create_patch_with_rm_and_changed_files):
3167         (GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
3168         * Scripts/webkitpy/common/config/ports_unittest.py:
3169         (DeprecatedPortTest.test_mac_port):
3170         (DeprecatedPortTest.test_gtk_port):
3171         (DeprecatedPortTest.test_efl_port):
3172         (DeprecatedPortTest.test_qt_port):
3173         (DeprecatedPortTest.test_chromium_port):
3174         (DeprecatedPortTest.test_chromium_android_port):
3175         (DeprecatedPortTest.test_chromium_xvfb_port):
3176         * Scripts/webkitpy/common/config/urls_unittest.py:
3177         (URLsTest.test_parse_bug_id):
3178         (URLsTest.test_parse_attachment_id):
3179         * Scripts/webkitpy/common/find_files_unittest.py:
3180         (TestWinNormalize.assert_filesystem_normalizes):
3181         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3182         (test_url_creation):
3183         (test_parse_bug_id):
3184         (_assert_dictionaries_equal):
3185         (test_parse_bugs_from_xml):
3186         (test_attachment_detail_bug_parsing):
3187         (_assert_result_count):
3188         (test_request_page_parsing):
3189         (test_quip_page_parsing):
3190         (EditUsersParserTest._assert_login_userid_pairs):
3191         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3192         (test_status_parsing):
3193         (test_latest_cached_build):
3194         (test_results_zip_url):
3195         * Scripts/webkitpy/common/net/credentials_unittest.py:
3196         (test_credentials_from_environment):
3197         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3198         (FailureMapTest.test_failing_revisions):
3199         (FailureMapTest.test_new_failures):
3200         (FailureMapTest.test_new_failures_with_old_revisions):
3201         (FailureMapTest.test_new_failures_with_more_old_revisions):
3202         (FailureMapTest.test_tests_failing_for):
3203         (FailureMapTest.test_failing_tests):
3204         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3205         (LayoutTestResultsTest.test_set_failure_limit_count):
3206         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
3207         (UnitTestResultsTest.test_nostring):
3208         (UnitTestResultsTest.test_emptystring):
3209         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
3210         (ReadChecksumFromPngTest.test_read_checksum):
3211         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
3212         (LoggingTest.assert_log_equals):
3213         * Scripts/webkitpy/common/system/executive_unittest.py:
3214         (ScriptErrorTest.test_string_from_args):
3215         (ScriptErrorTest.test_message_with_output):
3216         (ExecutiveTest.test_run_command_with_bad_command):
3217         (ExecutiveTest.test_run_command_with_unicode):
3218         (ExecutiveTest.serial_test_run_in_parallel):
3219         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3220         (MockFileSystemTest.quick_check):
3221         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3222         (GenericFileSystemTests.test_glob__trailing_asterisk):
3223         (GenericFileSystemTests.test_glob__leading_asterisk):
3224         (GenericFileSystemTests.test_glob__middle_asterisk):
3225         (GenericFileSystemTests.test_glob__period_is_escaped):
3226         (RealFileSystemTest.test_chdir):
3227         (RealFileSystemTest.test_remove_file_with_retry):
3228         (RealFileSystemTest.test_sep):
3229         * Scripts/webkitpy/common/system/logtesting.py:
3230         (TestLogStream.assertMessages):
3231         * Scripts/webkitpy/common/system/logutils_unittest.py:
3232         (GetLoggerTest.test_get_logger_in_webkitpy):
3233         (GetLoggerTest.test_get_logger_not_in_webkitpy):
3234         * Scripts/webkitpy/common/system/outputcapture.py:
3235         (OutputCaptureTestCaseBase.assertStdout):
3236         (OutputCaptureTestCaseBase.assertStderr):
3237         * Scripts/webkitpy/common/system/path_unittest.py:
3238         (AbspathTest.test_abspath_to_uri_cygwin):
3239         (AbspathTest.test_abspath_to_uri_unixy):
3240         (AbspathTest.test_abspath_to_uri_win):
3241         (AbspathTest.test_abspath_to_uri_escaping_unixy):
3242         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
3243         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3244         (TestPlatformInfo.test_real_code):
3245         (TestPlatformInfo.test_os_name_and_wrappers):
3246         (TestPlatformInfo.test_os_version):
3247         (TestPlatformInfo.test_total_bytes_memory):
3248         * Scripts/webkitpy/common/system/user_unittest.py:
3249         (UserTest.test_confirm.mock_raw_input):
3250         (UserTest.test_confirm):
3251         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3252         (ZipFileSetTest.test_open):
3253         (ZipFileSetTest.test_read):
3254         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3255         (WatchListTest.test_filename_definition_no_matches):
3256         (WatchListTest.test_filename_definition):
3257         (WatchListTest.test_cc_rules_simple):
3258         (WatchListTest.test_cc_rules_complex):
3259         (WatchListTest.test_cc_and_message_rules_complex):
3260         (WatchListTest.test_cc_and_message_rules_no_matches):
3261         (WatchListTest.test_added_match):
3262         (WatchListTest.test_deleted_match):
3263         (WatchListTest.test_more_and_less_match):
3264         (WatchListTest.test_complex_match):
3265         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3266         (LockCheckingRunner.handle_finished_list):
3267         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
3268         (LayoutTestRunnerTests.test_update_summary_with_result):
3269         (LayoutTestRunnerTests.test_servers_started):
3270         (SharderTests.assert_shards):
3271         (SharderTests.test_shard_in_two_has_no_locked_shards):
3272         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
3273         (NaturalCompareTest.assert_cmp):
3274         (KeyCompareTest.assert_cmp):
3275         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3276         (TestConfigurationTest.test_items):
3277         (TestConfigurationTest.test_keys):
3278         (TestConfigurationTest.test_str):
3279         (TestConfigurationTest.test_repr):
3280         (TestConfigurationTest.test_hash):
3281         (TestConfigurationTest.test_eq):
3282         (TestConfigurationTest.test_values):
3283         (SpecifierSorterTest.test_init):
3284         (SpecifierSorterTest.test_add_specifier):
3285         (SpecifierSorterTest.test_add_macros):
3286         (SpecifierSorterTest.test_category_priority):
3287         (SpecifierSorterTest.test_specifier_priority):
3288         (SpecifierSorterTest.test_sort_specifiers):
3289         (TestConfigurationConverterTest.test_symmetric_difference):
3290         (TestConfigurationConverterTest.test_to_config_set):
3291         (TestConfigurationConverterTest.test_macro_expansion):
3292         (TestConfigurationConverterTest.test_to_specifier_lists):
3293         (TestConfigurationConverterTest.test_macro_collapsing):
3294         (TestConfigurationConverterTest.test_converter_macro_collapsing):
3295         (TestConfigurationConverterTest.test_specifier_converter_access):
3296         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3297         (assert_exp):
3298         (MiscTests.test_result_was_expected):
3299         (MiscTests.test_remove_pixel_failures):
3300         (MiscTests.test_suffixes_for_expectations):
3301         (MiscTests.test_get_expectations_string):
3302         (SkippedTests.check):
3303         (ExpectationSyntaxTests.assert_tokenize_exp):
3304         (SemanticTests.test_bad_bugid):
3305         (SemanticTests.test_missing_bugid):
3306         (TestExpectationSerializationTests.test_reconstitute_only_these):
3307         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3308         (TestFailuresTest.test_crashes):
3309         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3310         (PortTest.test_nonexistant_expectations):
3311         (PortTest.test_additional_expectations):
3312         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
3313         (BuildersTest.test_path_from_name):
3314         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3315         (ChromiumAndroidPortTest.test_attributes):
3316         (ChromiumAndroidPortTest.test_default_timeout_ms):
3317         (ChromiumAndroidPortTest.test_get_devices_one_device):
3318         (ChromiumAndroidPortTest.test_get_devices_two_devices):
3319         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
3320         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
3321         (ChromiumAndroidPortTest.test_must_require_http_server):
3322         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
3323         (ChromiumAndroidDriverTest.test_get_crash_log):
3324         (ChromiumAndroidDriverTest.test_cmd_line):
3325         (ChromiumAndroidDriverTest.test_read_prompt):
3326         (ChromiumAndroidDriverTest.test_command_from_driver_input):
3327         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
3328         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
3329         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3330         (ChromiumLinuxPortTest.assert_architecture):
3331         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3332         (ChromiumLinuxPortTest.test_path_to_image_diff):
3333         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3334         (ChromiumMacPortTest.assert_name):
3335         (ChromiumMacPortTest.test_baseline_path):
3336         (ChromiumMacPortTest.test_path_to_image_diff):
3337         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3338         (ChromiumPortTestCase.test_default_max_locked_shards):
3339         (ChromiumPortTestCase.test_default_timeout_ms):
3340         (ChromiumPortTestCase.test_default_pixel_tests):
3341         (ChromiumPortTestCase.test_all_test_configurations):
3342         (ChromiumPortTestCase.test_default_configuration):
3343         (ChromiumPortTestCase.test_diff_image):
3344         (ChromiumPortTestCase.test_diff_image_crashed):
3345         (ChromiumPortTestCase.test_expectations_files):
3346         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3347         (ChromiumWinTest.test_setup_environ_for_server_cygpath):
3348         (ChromiumWinTest.assert_name):
3349         (ChromiumWinTest.test_baseline_path):
3350         (ChromiumWinTest.test_path_to_image_diff):
3351         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3352         (DriverTest.test_read_block):
3353         (DriverTest.test_read_binary_block):
3354         (DriverTest.test_read_base64_block):
3355         (DriverTest.test_no_timeout):
3356         (DriverTest.test_check_for_driver_crash.assert_crash):
3357         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
3358         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3359         (FactoryTest.test_get_from_builder_name):
3360         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3361         (GtkPortTest.test_default_timeout_ms):
3362         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3363         (HttpLockTest.test_current_lock_pid):
3364         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3365         (TestImageDiffer.test_diff_image_failed):
3366         (TestImageDiffer.test_diff_image_passed):
3367         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3368         (LeakDetectorTest.test_leaks_args):
3369         (test_parse_leaks_output):
3370         (test_leaks_files_in_directory):
3371         (test_count_total_leaks):
3372         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3373         (MacTest.test_default_timeout_ms):
3374         (assert_name):
3375         (test_setup_environ_for_server):
3376         (_assert_search_path):
3377         (test_32bit):
3378         (test_64bit):
3379         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3380         (MockTestShellTest.test_pixeltest__fails):
3381         (MockTestShellTest.test_test_shell_parse_options):
3382         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3383         (PortTestCase.test_default_max_locked_shards):
3384         (PortTestCase.test_default_timeout_ms):
3385         (PortTestCase.test_default_pixel_tests):
3386         (PortTestCase.test_diff_image):
3387         (PortTestCase.test_diff_image_crashed):
3388         (PortTestCase.test_get_crash_log):
3389         (PortTestCase.assert_build_path):
3390         (PortTestCase.test_expectations_ordering):
3391         (_assert_config_file_for_platform):
3392         (test_path_to_apache_config_file):
3393         (test_additional_platform_directory):
3394         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3395         (QtPortTest._assert_search_path):
3396         (QtPortTest._assert_expectations_files):
3397         (QtPortTest.test_setup_environ_for_server):
3398         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3399         (TestServerProcess.test_basic):
3400         (TestServerProcess.test_broken_pipe):
3401         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3402         (WinPortTest._assert_search_path):
3403         (WinPortTest._assert_version):
3404         (WinPortTest.test_runtime_feature_list):
3405         (WinPortTest.test_expectations_files):
3406         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3407         (LintTest.test_all_configurations):
3408         (MainTest.test_all):
3409         (MainTest.test_repeat_each):
3410         (MainTest.test_skipped_flag):
3411         (MainTest.test_iterations):
3412         (MainTest.test_run_chunk):
3413         (MainTest.test_run_part):
3414         (MainTest.test_run_singly):
3415         (MainTest.test_run_singly_actually_runs_tests):
3416         (MainTest.test_single_file):
3417         (MainTest.test_single_file_with_prefix):
3418         (MainTest.test_single_skipped_file):
3419         (MainTest.test_stderr_is_saved):
3420         (MainTest.test_test_list):
3421         (MainTest.test_test_list_with_prefix):
3422         (MainTest.test_missing_and_unexpected_results):
3423         (MainTest.test_pixel_test_directories):
3424         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3425         (MainTest.test_crash_log):
3426         (MainTest.test_web_process_crash_log):
3427         (MainTest.test_exit_after_n_failures_upload):
3428         (MainTest.test_exit_after_n_failures):
3429         (MainTest.test_exit_after_n_crashes):
3430         (MainTest.test_retrying_and_flaky_tests):
3431         (MainTest.test_run_order__inline):
3432         (MainTest.test_reftest_run):
3433         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
3434         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
3435         (MainTest.test_reftest_expected_html_should_be_ignored):
3436         (MainTest.test_reftest_driver_should_run_expected_html):
3437         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
3438         (MainTest.test_output_diffs):
3439         (MainTest.test_unsupported_platform):
3440         (EndToEndTest.test_end_to_end):
3441         (RebaselineTest.test_reset_results):
3442         (RebaselineTest.test_missing_results):
3443         (RebaselineTest.test_new_baseline):
3444         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3445         (BaseTest.integration_test_server__normal):
3446         (BaseTest.integration_test_server__fails):
3447         (BaseTest.integration_test_port_and_root):
3448         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3449         (TestHttpServer.test_start_cmd):
3450         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3451         (RegularTest.test_logging_not_included):
3452         (RegularTest._basic):
3453         (RegularTest.test_basic):
3454         (RegularTest.test_log_after_update):
3455         (RegularTest.test_log_args):
3456         (TtyTest.test_basic):
3457         (TtyTest.test_log_after_update):
3458         (VerboseTest.test_basic):
3459         (VerboseTest.test_log_after_update):
3460         (VerboseTest.test_log_args):
3461         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3462         (Testprinter.assertWritten):
3463         (test_test_status_line):
3464         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3465         (MainTest.assertWritten):
3466         * Scripts/webkitpy/style/checker_unittest.py:
3467         (GlobalVariablesTest.test_webkit_base_filter_rules):
3468         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
3469         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3470         (CheckerDispatcherDispatchTest.assert_checker):
3471         (CheckerDispatcherDispatchTest.test_changelog_paths):
3472         (CheckerDispatcherDispatchTest.test_cpp_paths):
3473         (CheckerDispatcherDispatchTest.test_json_paths):
3474         (CheckerDispatcherDispatchTest.test_python_paths):
3475         (CheckerDispatcherDispatchTest.test_text_paths):
3476         (CheckerDispatcherDispatchTest.test_xml_paths):
3477         (StyleProcessorConfigurationTest.test_init):
3478         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
3479         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
3480         (StyleProcessor_EndToEndTest.test_init):
3481         (StyleProcessor_EndToEndTest.test_process):
3482         (StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
3483         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3484         (ChangeLogCheckerTest.assert_error.handle_style_error):
3485         (ChangeLogCheckerTest.test_init):
3486         * Scripts/webkitpy/style/checkers/common_unittest.py:
3487         (CarriageReturnCheckerTest.assert_carriage_return):
3488         (TabCheckerTest.assert_tab):
3489         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3490         (CppFunctionsTest.test_convert_to_lower_with_underscores):
3491         (CppFunctionsTest.test_create_acronym):
3492         (CppFunctionsTest.test_parameter):
3493         (CppFunctionsTest.test_single_line_view):
3494         (CppFunctionsTest.test_create_skeleton_parameters):
3495         (CppFunctionsTest.test_find_parameter_name_index):
3496         (CppFunctionsTest.test_parameter_list):
3497         (CppFunctionsTest.test_check_parameter_against_text):
3498         (CppStyleTestBase.perform_lint):
3499         (CppStyleTestBase.assert_lint):
3500         (CppStyleTestBase.assert_lint_one_of_many_errors_re):
3501         (CppStyleTestBase.assert_multi_line_lint):
3502         (CppStyleTestBase.assert_language_rules_check):
3503         (CppStyleTestBase.assert_include_what_you_use):
3504         (CppStyleTestBase.assert_blank_lines_check):
3505         (CppStyleTestBase.assert_positions_equal):
3506         (FunctionDetectionTest.perform_function_detection):
3507         (CppStyleTest.test_get_line_width):
3508         (CppStyleTest.test_find_next_multi_line_comment_start):
3509         (CppStyleTest.test_find_next_multi_line_comment_end):
3510         (CppStyleTest.test_remove_multi_line_comments_from_range):
3511         (CppStyleTest.test_position):
3512         (CppStyleTest.test_rfind_in_lines):
3513         (CppStyleTest.test_close_expression):
3514         (CppStyleTest.test_include_what_you_use_no_implementation_files):
3515         (CppStyleTest.test_include_what_you_use):
3516         (CppStyleTest.test_files_belong_to_same_module):
3517         (CppStyleTest.test_cleanse_line):
3518         (CppStyleTest.test_multiline_strings):
3519         (CppStyleTest.test_newline_at_eof.do_test):
3520         (CppStyleTest.test_invalid_utf8.do_test):
3521         (CppStyleTest.test_is_blank_line):
3522         (CppStyleTest.test_allow_blank_line_before_closing_namespace):
3523         (CppStyleTest.test_allow_blank_line_before_if_else_chain):
3524         (CppStyleTest.test_else_on_same_line_as_closing_braces):
3525         (CppStyleTest.test_build_header_guard):
3526         (CppStyleTest.test_legal_copyright):
3527         (CleansedLinesTest.test_init):
3528         (CleansedLinesTest.test_init_empty):
3529         (CleansedLinesTest.test_collapse_strings):
3530         (CheckForFunctionLengthsTest.assert_function_lengths_check):
3531         (PassPtrTest.assert_pass_ptr_check):
3532         (LeakyPatternTest.assert_leaky_pattern_check):
3533         (WebKitStyleTest.test_parameter_names):
3534         (WebKitStyleTest.test_webkit_export_check):
3535         (CppCheckerTest.test_init):
3536         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
3537         (JSONCheckerTest.assert_error.handle_style_error):
3538         (JSONCheckerTest.test_init):
3539         * Scripts/webkitpy/style/checkers/png_unittest.py:
3540         (PNGCheckerTest.test_init):
3541         (PNGCheckerTest.test_check):
3542         * Scripts/webkitpy/style/checkers/python_unittest.py:
3543         (PythonCheckerTest.test_init):
3544         (PythonCheckerTest.test_check):
3545         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3546         (TestExpectationsTestCase._expect_port_for_expectations_path):
3547         (TestExpectationsTestCase.assert_lines_lint):
3548         * Scripts/webkitpy/style/checkers/text_unittest.py:
3549         (TextStyleTestCase.assertNoError):
3550         (TextStyleTestCase.assertError.error_for_test):
3551         (TextStyleTestCase.assertError):
3552         (TextCheckerTest.test_init):
3553         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
3554         (WatchListTest.test_basic_error_message.handle_style_error):
3555         (WatchListTest):
3556         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
3557         (XcodeProjectFileCheckerTest.assert_error):
3558         * Scripts/webkitpy/style/checkers/xml_unittest.py:
3559         (XMLCheckerTest.assert_error.handle_style_error):
3560         (XMLCheckerTest.test_init):
3561         * Scripts/webkitpy/style/error_handlers_unittest.py:
3562         (DefaultStyleErrorHandlerTest._check_initialized):
3563         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
3564         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
3565         (DefaultStyleErrorHandlerTest.test_line_numbers):
3566         * Scripts/webkitpy/style/filereader_unittest.py:
3567         (TextFileReaderTest._assert_file_reader):
3568         (TextFileReaderTest.test_process_file__does_not_exist):
3569         (TextFileReaderTest.test_count_delete_only_file):
3570         * Scripts/webkitpy/style/filter_unittest.py:
3571         (CategoryFilterTest.test_init):
3572         (CategoryFilterTest.test_init_default_arguments):
3573         (CategoryFilterTest.test_str):
3574         (FilterConfigurationTest.test_init):
3575         (FilterConfigurationTest.test_default_arguments):
3576         * Scripts/webkitpy/style/main_unittest.py:
3577         (ChangeDirectoryTest._assert_result):
3578         * Scripts/webkitpy/style/optparser_unittest.py:
3579         (ArgumentPrinterTest.test_to_flag_string):
3580         (ArgumentParserTest.test_parse_default_arguments):
3581         (ArgumentParserTest.test_parse_explicit_arguments):
3582         (ArgumentParserTest.test_parse_files):
3583         (CommandOptionValuesTest.test_init):
3584         * Scripts/webkitpy/style/patchreader_unittest.py:
3585         (PatchReaderTest._assert_checked):
3586         * Scripts/webkitpy/test/finder_unittest.py:
3587         (FinderTest.test_additional_system_paths):
3588         (FinderTest.test_to_module):
3589         (FinderTest.check_names):
3590         * Scripts/webkitpy/test/main_unittest.py:
3591         (TesterTest.test_individual_names_are_not_run_twice):
3592         (TesterTest.test_integration_tests_are_not_found_by_default):
3593         (TesterTest.test_integration_tests_are_found):
3594         (TesterTest.integration_test_coverage_works):
3595         * Scripts/webkitpy/test/runner_unittest.py:
3596         (RunnerTest.test_run):
3597         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3598         (_expect_validate):
3599         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3600         (ExpectedFailuresTest._assert_can_trust):
3601         (ExpectedFailuresTest.test_unexpected_failures_observed):
3602         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
3603         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3604         (test_patches_with_acceptable_review_flag):
3605         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3606         (IRCCommandTest.test_whois):
3607         (IRCCommandTest.test_create_bug):
3608         (IRCCommandTest.test_roll_chromium_deps):
3609         (IRCCommandTest.test_rollout):
3610         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3611         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3612         (test_missing_unit_test_results_path):
3613         (test_layout_test_results):
3614         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3615         (LoggingDelegate.process_work_item):
3616         (LoggingDelegate.handle_unexpected_error):
3617         (QueueEngineTest.test_trivial):
3618         (QueueEngineTest.test_unexpected_error):
3619         (QueueEngineTest.test_handled_error):
3620         (QueueEngineTest._test_terminating_queue):
3621         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3622         (OpenBugsTest.test_find_bugs_in_string):
3623         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3624         (FailureReasonTest.test_blame_line_for_revision):
3625         (PrintExpectationsTest.run_test):
3626         (PrintBaselinesTest.test_basic):
3627         (PrintBaselinesTest.test_multiple):
3628         (PrintBaselinesTest.test_csv):
3629         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3630         (AbstractQueueTest.test_log_directory):
3631         (AbstractPatchQueueTest.test_next_patch):
3632         (test_auto_retry):
3633         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3634         (test_rebaseline_updates_expectations_file):
3635         (test_rebaseline_does_not_include_overrides):
3636         (test_rebaseline_test):
3637         (test_rebaseline_test_with_results_directory):
3638         (test_rebaseline_test_and_print_scm_changes):
3639         (test_rebaseline_and_copy_test):
3640         (test_rebaseline_and_copy_test_no_existing_result):
3641         (test_rebaseline_and_copy_test_with_lion_result):
3642         (test_rebaseline_and_copy_no_overwrite_test):
3643         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
3644         (TestRebaselineJson.test_rebaseline_all):
3645         (TestRebaselineJson.test_rebaseline_debug):
3646         (TestRebaselineJson.test_move_overwritten):
3647         (TestRebaselineJson.test_no_optimize):
3648         (TestRebaselineJson.test_results_directory):
3649         (TestRebaseline.test_rebaseline):
3650         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
3651         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3652         (TestAnalyzeBaselines.test_default):
3653         (TestAnalyzeBaselines.test_missing_baselines):
3654         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3655         (PostRollCommandsTest.test_prepare_state):
3656         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3657         (BuildCoverageExtrapolatorTest.test_extrapolate):
3658         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
3659         (AddSvnMimetypeForPngTest.test_run):
3660         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3661         (PrepareChangeLogTest.test_ensure_bug_url):
3662         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3663         (_assert_message_for_revert_output):
3664         * TestResultServer/model/jsonresults_unittest.py:
3665         (JsonResultsTest._test_merge):
3666         (JsonResultsTest._test_get_test_list):
3667
3668 2012-11-14  János Badics  <jbadics@inf.u-szeged.hu>
3669
3670         [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
3671         https://bugs.webkit.org/show_bug.cgi?id=102083
3672
3673         Reviewed by Csaba Osztrogonác.
3674
3675         Modified compiler name regex in condition that tests if -std=c++0x, c++11,
3676         gnu++0x or gnu++11 are enabled in order to match linux-arm-gnueabi-g++ too,
3677         thus enabling -Wno-c++0x-compat also on ARM compiler.
3678
3679         * qmake/mkspecs/features/unix/default_post.prf:
3680
3681 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3682
3683         REGRESSION(r133757): Causing webkitpy unit tests to fail
3684         https://bugs.webkit.org/show_bug.cgi?id=101444
3685
3686         Reviewed by Csaba Osztrogonác.
3687
3688         Updated the bot name on the unit tests.
3689
3690         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3691         (TestRebaselineTest.test_baseline_directory):
3692
3693 2012-11-14  Byungwoo Lee  <bw80.lee@samsung.com>
3694
3695         [EFL][WK2] Rename variables, structures and functions of the MiniBrowser.
3696         https://bugs.webkit.org/show_bug.cgi?id=101517
3697
3698         Reviewed by Gyuyoung Kim.
3699
3700         Rename variables, structures and functions of the MiniBrowser
3701         for the naming consistency.
3702
3703         1) Browser_Window* {app_data|browser_window|window} -> window
3704
3705         2) Browser_Window::webview -> Browser_Window::ewk_view
3706              The webkit API functions are ewk_view_xxx not webview_xxx.
3707              So using ewk_view will be better than webview.
3708
3709         3) Browser_Window::window -> Browser_Window::elm_window
3710              The name is changed to be distinguished with 'Browser_Window *window'
3711
3712         4) browser_{window|view}_find() -> window_find_with_{elm_window|ewk_view}()
3713              This is changed because the name of the function can be confused.
3714              Currently, browser_window_find() returns Browser_Window*. And
3715              browser_view_find() also returns Browser_Window*.
3716
3717         5) FileSelectorData -> File_Selector_Data / AuthData -> Auth_Data
3718              The type definition is moved to the top of the source file
3719              and the name is changed to follow EFL style.
3720
3721         * MiniBrowser/efl/main.c:
3722         (miniBrowserViewSmartClass):
3723         (_Browser_Window):
3724         (_File_Selector_Data):
3725         (_Auth_Data):
3726         (window_find_with_ewk_view):
3727         (window_free):
3728         (on_key_down):
3729         (view_focus_set):
3730         (on_mouse_down):
3731         (title_set):
3732         (on_title_changed):
3733         (on_url_changed):
3734         (on_back_forward_list_changed):
3735         (on_new_window):
3736         (on_close_window):
3737         (on_progress):
3738         (on_error):
3739         (on_download_request):
3740         (close_file_picker):
3741         (on_filepicker_parent_deletion):
3742         (on_filepicker_deletion):
3743         (on_fileselector_done):
3744         (on_file_chooser_request):
3745         (on_download_finished):
3746         (on_download_failed):
3747         (on_favicon_received):
3748         (on_view_icon_changed):
3749         (on_url_bar_activated):
3750         (on_url_bar_clicked):
3751         (on_back_button_clicked):
3752         (on_forward_button_clicked):
3753         (on_refresh_button_clicked):
3754         (on_javascript_alert):
3755         (on_javascript_confirm):
3756         (on_javascript_prompt):
3757         (on_window_geometry_get):
3758         (on_window_geometry_set):
3759         (on_fullscreen_deny):
3760         (on_fullscreen_enter):
3761         (on_fullscreen_exit):
3762         (auth_popup_close):
3763         (on_auth_cancel):
3764         (on_auth_ok):
3765         (on_authentication_request):
3766         (on_tooltip_text_set):
3767         (on_tooltip_text_unset):
3768         (on_home_button_clicked):
3769         (on_window_deletion):
3770         (window_create):
3771
3772 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3773
3774         webkitpy: Update the EFL list of bots
3775         https://bugs.webkit.org/show_bug.cgi?id=102121
3776
3777         Reviewed by Kenneth Rohde Christiansen.
3778
3779         Update the EFL bots so we can use garden-o-matic.
3780
3781         * Scripts/webkitpy/layout_tests/port/builders.py:
3782
3783 2012-11-13  Yael Aharon  <yael.aharon@intel.com>
3784
3785         [EFL][WK2] New window size should consult the window attributes
3786         https://bugs.webkit.org/show_bug.cgi?id=102122
3787
3788         Reviewed by Kenneth Rohde Christiansen.
3789
3790         Take into account the size that was specified in window.open
3791         when creating a new window. This avoids ugly flashing on the screen.
3792
3793         * MiniBrowser/efl/main.c:
3794         (on_key_down):
3795         (on_new_window):
3796         (window_create):
3797         (elm_main):
3798
3799 2012-11-13  Dana Jansens  <danakj@chromium.org>
3800
3801         [chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
3802         https://bugs.webkit.org/show_bug.cgi?id=102146
3803
3804         Reviewed by James Robinson.
3805
3806         Pass settings that go through WebCompositorSupport also through
3807         WebLayerTreeSettings. When the compositor starts using those instead,
3808         we can remove the callers to the WebCompositorSupport setters.
3809
3810         * DumpRenderTree/chromium/TestShell.cpp:
3811         (TestShell::TestShell):
3812         (TestShell::resetWebSettings):
3813         (TestShell::setPerTilePaintingEnabled):
3814         (TestShell::setAcceleratedAnimationEnabled):
3815         * DumpRenderTree/chromium/TestShell.h:
3816         (TestShell):
3817         * DumpRenderTree/chromium/WebPreferences.cpp:
3818         (WebPreferences::applyTo):
3819         * DumpRenderTree/chromium/WebPreferences.h:
3820         (WebPreferences):
3821
3822 2012-11-13  Kentaro Hara  <haraken@chromium.org>
3823
3824         Unreviewed, rolling out r134503.
3825         http://trac.webkit.org/changeset/134503
3826
3827         Roll out a patch that was landed just to investigate svn
3828         trouble
3829
3830         * Scripts/webkitpy/common/config/committers.py:
3831
3832 2012-11-13  Kentaro Hara  <haraken@chromium.org>
3833
3834         Unreviewed. Investigating svn trouble. Test commit.
3835
3836         * Scripts/webkitpy/common/config/committers.py:
3837
3838 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
3839
3840         Unreviewed, rolling out r134446.
3841         http://trac.webkit.org/changeset/134446
3842         https://bugs.webkit.org/show_bug.cgi?id=101968
3843
3844         Need to try a different strategy for landing a two-sided patch
3845         (3/3).
3846
3847         * DumpRenderTree/chromium/TestShell.cpp:
3848         (TestShell::TestShell):
3849         (TestShell::resetWebSettings):
3850         (TestShell::setPerTilePaintingEnabled):
3851         (TestShell::setAcceleratedAnimationEnabled):
3852         * DumpRenderTree/chromium/TestShell.h:
3853         (TestShell):
3854         * DumpRenderTree/chromium/WebPreferences.cpp:
3855         (WebPreferences::applyTo):
3856         * DumpRenderTree/chromium/WebPreferences.h:
3857         (WebPreferences):
3858
3859 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
3860
3861         Unreviewed, rolling out r134449.
3862         http://trac.webkit.org/changeset/134449
3863         https://bugs.webkit.org/show_bug.cgi?id=102076
3864
3865         Re-rolling in the patch, it was innocent.
3866
3867         * TestWebKitAPI/PlatformEfl.cmake:
3868
3869 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
3870
3871         Unreviewed, rolling out r134424.
3872         http://trac.webkit.org/changeset/134424
3873         https://bugs.webkit.org/show_bug.cgi?id=102076
3874
3875         Made fast/dom/Window/open-window-min-size.html crash.
3876
3877         * TestWebKitAPI/PlatformEfl.cmake:
3878
3879 2012-11-12  Dana Jansens  <danakj@chromium.org>
3880
3881         [chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
3882         https://bugs.webkit.org/show_bug.cgi?id=101968
3883
3884         Reviewed by James Robinson.
3885
3886         * DumpRenderTree/chromium/TestShell.cpp:
3887         (TestShell::TestShell):
3888         (TestShell::resetWebSettings):
3889         * DumpRenderTree/chromium/TestShell.h:
3890         (TestShell::setPerTilePaintingEnabled):
3891         (TestShell::setAcceleratedAnimationEnabled):
3892         (TestShell):
3893         * DumpRenderTree/chromium/WebPreferences.cpp:
3894         (WebPreferences::applyTo):
3895         * DumpRenderTree/chromium/WebPreferences.h:
3896         (WebPreferences):
3897
3898 2012-11-13  Dirk Pranke  <dpranke@chromium.org>
3899
3900         Fix webkitpy issues arising from a partially-installed pylint.
3901         Unreviewed, build fix.
3902
3903         This patch ensures that we will re-install the pylint and logilab
3904         packages if any of them are missing, not just the pylint package.
3905
3906         * Scripts/webkitpy/thirdparty/__init__.py:
3907         (AutoinstallImportHook._install_pylint):
3908
3909 2012-11-13  No'am Rosenthal  <noam.rosenthal@nokia.com>
3910
3911         Unreviewed, adding my new email address to committers.py and watchlist.
3912
3913         * Scripts/webkitpy/common/config/committers.py:
3914         * Scripts/webkitpy/common/config/watchlist:
3915
3916 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3917
3918         [CMake] Incorrect dependency calculation when generating forwarding headers
3919         https://bugs.webkit.org/show_bug.cgi?id=102076
3920
3921         Reviewed by Kenneth Rohde Christiansen.
3922
3923         Explicitly call generate-forwarding-headers.pl on ${WEBKIT2_DIR} as
3924         well, since some dependencies pulled in via the WebKit2/WebKit2_C.h
3925         include in config.h are only generated from there.
3926
3927         This is a bit redundant since this is also done in WebKit2's
3928         PlatformEfl.cmake, however the WTF and WebCore API tests do not depend
3929         on WebKit2 so the script may not have been called when these tests are
3930         being built.
3931
3932         * TestWebKitAPI/PlatformEfl.cmake:
3933
3934 2012-11-13  Zeno Albisser  <zeno@webkit.org>
3935
3936         Unreviewed: Adding watchlist definition for CoordinatedGraphics.
3937
3938         * Scripts/webkitpy/common/config/watchlist:
3939
3940 2012-11-13  Hugo Parente Lima  <hugo.lima@openbossa.org>
3941
3942         [cmake] Do not use GLOB to add WTR IDL files to buildsystem.
3943         https://bugs.webkit.org/show_bug.cgi?id=101785
3944
3945         Reviewed by Caio Marcelo de Oliveira Filho.
3946
3947         Using *.idl makes impossible to add IDL files depending on compiler flags,
3948         like a possible GamepadController.idl file found on Chromium.
3949
3950         * WebKitTestRunner/CMakeLists.txt:
3951
3952 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
3953
3954         [chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself
3955         https://bugs.webkit.org/show_bug.cgi?id=102075
3956
3957         Reviewed by Pavel Feldman.
3958
3959         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3960
3961 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3962
3963         [EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender.
3964         https://bugs.webkit.org/show_bug.cgi?id=102074
3965
3966         Reviewed by Kenneth Rohde Christiansen.
3967
3968         * DumpRenderTree/efl/EventSender.cpp:
3969         (feedMouseEvent): Do not call DumpRenderTreeSupportEfl::layoutFrame()
3970         when sending an event, as it causes additional repaints that create
3971         wrong pixel results for tests such as
3972         fast/repaint/overflow-auto-in-overflow-auto-scrolled.html.
3973
3974 2012-11-13  Csaba Osztrogonác  <ossy@webkit.org>
3975
3976         [Qt] Enable Mutation observer
3977         https://bugs.webkit.org/show_bug.cgi?id=102066
3978
3979         Reviewed by Pavel Feldman.
3980
3981         * qmake/mkspecs/features/features.pri:
3982
3983 2012-11-13  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3984
3985         [BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed
3986         https://bugs.webkit.org/show_bug.cgi?id=102056
3987
3988         Reviewed by Rob Buis.
3989
3990         RIM PR 235836
3991
3992         TestRunner::findString() was changed to call Page::findString() instead
3993         of WebPage::findNextString(). Page::findString() doesn't update
3994         TextMatch markers.
3995         Work-around by calling both Page::findString() and WebPage::findNextString().
3996
3997         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3998         (TestRunner::findString):
3999
4000 2012-11-12  Jochen Eisinger  <jochen@chromium.org>
4001
4002         Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
4003         https://bugs.webkit.org/show_bug.cgi?id=101957
4004
4005         Reviewed by Adam Barth.
4006
4007         Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply.
4008
4009         * Scripts/webkitpy/common/config/watchlist:
4010
4011 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
4012
4013         [chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
4014         https://bugs.webkit.org/show_bug.cgi?id=101927
4015
4016         Reviewed by Adam Barth.
4017
4018         This will allow for sharing the code with content_shell
4019
4020         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4021         (DRTTestRunner::display):
4022         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4023         (WebKit):
4024         (WebTestProxyBase):
4025         (WebTestRunner::WebTestProxy::didInvalidateRect):
4026         (WebTestRunner::WebTestProxy::didScrollRect):
4027         (WebTestRunner::WebTestProxy::scheduleComposite):
4028         (WebTestRunner::WebTestProxy::scheduleAnimation):
4029         (WebTestRunner::WebTestProxy::setWindowRect):
4030         (WebTestRunner::WebTestProxy::show):
4031         (WebTestRunner::WebTestProxy::didAutoResize):
4032         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
4033         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4034         (WebTestRunner::WebTestProxyBase::setPaintRect):
4035         (WebTestRunner):
4036         (WebTestRunner::WebTestProxyBase::paintRect):
4037         (WebTestRunner::WebTestProxyBase::didInvalidateRect):
4038         (WebTestRunner::WebTestProxyBase::didScrollRect):
4039         (WebTestRunner::WebTestProxyBase::scheduleComposite):
4040         (WebTestRunner::WebTestProxyBase::scheduleAnimation):
4041         (WebTestRunner::WebTestProxyBase::show):
4042         (WebTestRunner::WebTestProxyBase::setWindowRect):
4043         (WebTestRunner::WebTestProxyBase::didAutoResize):
4044         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
4045         * DumpRenderTree/chromium/TestShell.cpp:
4046         (TestShell::createNewWindow):
4047         * DumpRenderTree/chromium/WebViewHost.cpp:
4048         (WebViewHost::scheduleAnimation):
4049         (WebViewHost::show):
4050         (WebViewHost::setWindowRect):
4051         (WebViewHost::WebViewHost):
4052         (WebViewHost::proxy):
4053         (WebViewHost::setProxy):
4054         (WebViewHost::reset):
4055         (WebViewHost::paintInvalidatedRegion):
4056         * DumpRenderTree/chromium/WebViewHost.h:
4057         (WebViewHost):
4058
4059 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4060
4061         webkitpy: clean up lint errors, part 1
4062         https://bugs.webkit.org/show_bug.cgi?id=102024
4063
4064         Reviewed by Adam Barth.
4065
4066         This patch cleans up a lot of miscellaneous minor lint errors that
4067         apparently aren't caught by unit tests, and suppresses a few
4068         false positives.
4069
4070         Also, this patch removes the garden-o-matic "rollout" entry point
4071         since it's no longer being used by the frontend (rather than
4072         fix it to not generate lint errors).
4073
4074         * Scripts/webkitpy/common/system/executive_mock.py:
4075         (MockExecutive2.run_command):
4076         * Scripts/webkitpy/common/system/filesystem_mock.py:
4077         (MockFileSystem.copyfile):
4078         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4079         (Manager._http_tests):
4080         * Scripts/webkitpy/layout_tests/port/apple.py:
4081         (ApplePort):
4082         * Scripts/webkitpy/layout_tests/port/base.py:
4083         (Port.reference_files):
4084         * Scripts/webkitpy/layout_tests/port/chromium.py:
4085         (ChromiumPort):
4086         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4087         (ChromiumAndroidDriver._teardown_performance):
4088         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
4089         (ChromiumPortTestCase.TestAndroidPort.__init__):
4090         (ChromiumPortTestCase.test_default_configuration):
4091         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4092         (PortTestCase):
4093         (PortTestCase.test_driver_cmd_line):
4094         (PortTestCase.test_expectations_ordering):
4095         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4096         (HttpServerBase._check_that_all_ports_are_available):
4097         * Scripts/webkitpy/style/checkers/python.py:
4098         (Pylinter):
4099         * Scripts/webkitpy/tool/commands/gardenomatic.py:
4100         (GardenOMatic.__init__):
4101         * Scripts/webkitpy/tool/commands/queues.py:
4102         (CommitQueue):
4103         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4104         (GardeningHTTPRequestHandler):
4105         (GardeningHTTPRequestHandler.localresult):
4106
4107 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4108
4109         webkitpy: clean up lint errors, part 2
4110         https://bugs.webkit.org/show_bug.cgi?id=102029
4111
4112         Reviewed by Adam Barth.
4113
4114         This cleans up the remaining lint errors in webkitpy with four exceptions:
4115         1) we don't lint thirdparty/ autoinstalled code, obviously
4116         2) there's an intentional error in the unit tests for pylint itself
4117         3) the implementation of webkit-patch optimize-expectations has
4118         an error but I think we can and should just remove that command as well.
4119         4) I have not yet linted the test code
4120
4121         * Scripts/webkitpy/common/newstringio.py:
4122         * Scripts/webkitpy/common/checkout/scm/scm.py:
4123         (SCM.find_checkout_root):
4124         (SCM.will.remote_merge_base):
4125         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4126         * Scripts/webkitpy/common/checkout/scm/svn.py:
4127         (SVNRepository.has_authorization_for_realm):
4128         (SVN.__init__):
4129         * Scripts/webkitpy/common/config/contributionareas.py:
4130         (ContributionAreas.names):
4131         * Scripts/webkitpy/common/config/ports.py:
4132         (DeprecatedPort):
4133         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4134         (Builder.force_build):
4135         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4136         * Scripts/webkitpy/style/checkers/cpp.py:
4137         (check_posix_threading):
4138         (check_spacing):
4139         * Scripts/webkitpy/style/optparser.py:
4140         (ArgumentParser._create_option_parser):
4141         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
4142         (AbstractLocalServerCommand.execute):
4143         * Scripts/webkitpy/tool/commands/download.py:
4144         (AbstractPatchProcessingCommand):
4145         (AbstractPatchProcessingCommand._process_patch):
4146         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4147         (AbstractEarlyWarningSystem):
4148
4149 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4150
4151         remove 'webkit-patch optimize-expectations'
4152         https://bugs.webkit.org/show_bug.cgi?id=102032
4153
4154         Reviewed by Adam Barth.
4155
4156         Removing this command because it is totally broken (probably
4157         broke when I added support for multiple files in a cascade)
4158         and doesn't seem to do anything much useful. It certainly
4159         didn't actually optimize things.
4160
4161         * Scripts/webkitpy/tool/commands/expectations.py: Removed.
4162
4163 2012-11-12  Xiaobo Wang  <xbwang@torchmobile.com.cn>
4164
4165         [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
4166         https://bugs.webkit.org/show_bug.cgi?id=101894
4167
4168         Reviewed by Rob Buis.
4169
4170         RIM PR 241686
4171         Also remove an un-needed pixel lock, and fix a klocwork error in SKIA
4172         code path.
4173
4174         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
4175         (readPixelsUserInterfaceThread):
4176         (createBitmapContextFromWebView):
4177
4178 2012-11-12  Daniel Bates  <dbates@webkit.org>
4179
4180         Perl errors from Tools/Scripts/copy-webkitlibraries-to-product-directory
4181         https://bugs.webkit.org/show_bug.cgi?id=101980
4182
4183         Reviewed by Mark Rowe.
4184
4185         Remove library libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceSnowLeopard.a
4186         from the list of libraries to copy to the specified built products directory
4187         as these libraries were removed from the repository in <http://trac.webkit.org/changeset/133670>.
4188
4189         * Scripts/copy-webkitlibraries-to-product-directory:
4190
4191 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4192
4193         webkitpy: integrate pylint into check-webkit-style, part I
4194         https://bugs.webkit.org/show_bug.cgi?id=101285
4195
4196         Reviewed by Ojan Vafai.
4197
4198         This patch re-works lint-webkitpy so that the logic is pushed
4199         into check-webkit-style (mostly); we don't yet control which
4200         messages are displayed using the rules in webkitpy/style/checker.py
4201         (we're still using the pylintrc to suppress messages instead),
4202         but otherwise things work. For now we will only report pylint
4203         "errors", not warnings.
4204
4205         * Scripts/lint-webkitpy:
4206         * Scripts/webkitpy/style/checker.py:
4207         * Scripts/webkitpy/style/checkers/python.py:
4208         (PythonChecker):
4209         (PythonChecker.check):
4210         (PythonChecker._check_pep8):
4211         (PythonChecker._check_pylint):
4212         (Pylinter):
4213         (Pylinter.__init__):
4214         (Pylinter.run):
4215         (_FilteredStringIO):
4216         (_FilteredStringIO.__init__):
4217         (_FilteredStringIO.write):
4218         (_FilteredStringIO._filter):
4219         * Scripts/webkitpy/style/checkers/python_unittest.py:
4220         (PythonCheckerTest.test_check):
4221         * Scripts/webkitpy/style/checkers/python_unittest_input.py:
4222
4223 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4224
4225         nrwt: remove a bunch of broken chromium-specific flags
4226         https://bugs.webkit.org/show_bug.cgi?id=101979
4227
4228         Reviewed by Tony Chang.
4229
4230         There were a bunch of chromium-specific flags that used to be
4231         supported by NRWT (and handled and passed on to DRT) but have
4232         probably been broken for a long time and are currently ignored.
4233
4234         This patch removes all of those flags; the rule of thumb going forward
4235         is that we should only add flags that affect how the python code functions.
4236         If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
4237         for that.
4238
4239         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4240         (parse_args):
4241         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4242         (MainTest.setUp):
4243
4244 2012-11-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4245
4246         [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
4247         https://bugs.webkit.org/show_bug.cgi?id=101930
4248
4249         Reviewed by Kenneth Rohde Christiansen.
4250
4251         Added --device-pixel-ratio command line option to EFL MiniBrowser which sets
4252         the ratio between the CSS units and device pixels when the content is unscaled.
4253         Option is applied for all the views created by mini browser.
4254
4255         * MiniBrowser/efl/main.c:
4256         (window_create):
4257         (elm_main):
4258
4259 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
4260
4261         remove the chromium-mac-mountainlion TestExpectations file
4262         https://bugs.webkit.org/show_bug.cgi?id=101789
4263
4264         Reviewed by Ojan Vafai.
4265
4266         Nearly all of the tests have been updated for 10.8 and the remaining
4267         failures have been merged into the main TestExpectations file. We
4268         don't need this hook any more.
4269
4270         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4271         (ChromiumMacPort.operating_system):
4272