[iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
2
3         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
4         https://bugs.webkit.org/show_bug.cgi?id=133835
5
6         Reviewed by Tim Horton.
7         
8         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
9
10         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
11         (-[WebKitTestRunnerWindow initWithFrame:]):
12         (-[WebKitTestRunnerWindow setFrame:]):
13
14 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
15
16         [GTK] Performance tests should be always ran with WKTR.
17         https://bugs.webkit.org/show_bug.cgi?id=133780
18
19         Reviewed by Ryosuke Niwa.
20
21         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
22         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
23         is GTK.
24
25 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
26
27         [GTK] REGRESSION: application name is not correctly appended to the UA
28         https://bugs.webkit.org/show_bug.cgi?id=133793
29
30         Reviewed by Carlos Garcia Campos.
31
32         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
33         (testWebKitSettingsUserAgent):
34
35 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
36
37         [GTK] Unsupported browser in www.icloud.com
38         https://bugs.webkit.org/show_bug.cgi?id=133403
39
40         Reviewed by Martin Robinson.
41
42         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
43         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
44         quirk that was removed.
45
46 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
47
48         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
49         https://bugs.webkit.org/show_bug.cgi?id=133779
50
51         Reviewed by Benjamin Poulain.
52         
53         Tell the WebPage to use the testing viewport configuration from the injected bundle.
54
55         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
56         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
57         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
58         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
59         on iOS.
60
61 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
62
63         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
64         https://bugs.webkit.org/show_bug.cgi?id=133770
65
66         Reviewed by Anders Carlsson.
67         
68         Push the per-test view configuration up to TestController, so that platforms
69         can modify the behavior. This also allows platform-specific changes (e.g.
70         for threaded scrolling) to made without #ifefs.
71
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::updateWebViewSizeForTest):
74         (WTR::TestController::updateWindowScaleForTest):
75         (WTR::shouldUseFixedLayout):
76         (WTR::TestController::updateLayoutTypeForTest):
77         (WTR::TestController::platformConfigureViewForTest):
78         (WTR::TestController::configureViewForTest):
79         * WebKitTestRunner/TestController.h:
80         * WebKitTestRunner/TestInvocation.cpp:
81         (WTR::TestInvocation::invoke):
82         (WTR::sizeWebViewForCurrentTest): Deleted.
83         (WTR::changeWindowScaleIfNeeded): Deleted.
84         (WTR::shouldUseThreadedScrolling): Deleted.
85         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
86         (WTR::shouldUseFixedLayout): Deleted.
87         (WTR::updateLayoutType): Deleted.
88         * WebKitTestRunner/TestInvocation.h:
89         (WTR::TestInvocation::pathOrURL):
90         * WebKitTestRunner/ios/TestControllerIOS.mm:
91         (WTR::shouldMakeViewportFlexible):
92         (WTR::TestController::platformConfigureViewForTest):
93         * WebKitTestRunner/mac/TestControllerMac.mm:
94         (WTR::shouldUseThreadedScrolling):
95         (WTR::TestController::platformConfigureViewForTest):
96
97 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
98
99         [EFL] Add dependencies packages to efl install-dependencies file
100         https://bugs.webkit.org/show_bug.cgi?id=133720
101
102         Reviewed by Csaba Osztrogonác.
103
104         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
105         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
106
107         * efl/install-dependencies:
108
109 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
110
111         Unreviewed. Moving myself to the list of reviewers.
112
113         * Scripts/webkitpy/common/config/contributors.json:
114
115 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
116
117         [EFL] Drop to maintain EFL 32bit release bot
118         https://bugs.webkit.org/show_bug.cgi?id=133710
119
120         Reviewed by Csaba Osztrogonác.
121
122         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
123
124 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
125
126         [GTK] Use a different user agent string depending on the site
127         https://bugs.webkit.org/show_bug.cgi?id=132681
128
129         Reviewed by Anders Carlsson.
130
131         Add a unit test to check user agent quirks.
132
133         * TestWebKitAPI/PlatformGTK.cmake:
134         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
137         (testWebKitSettings): Site specific quirks setting is now enabled
138         by default.
139
140 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
141
142         Unreviewed, update my list of email addresses in contributors.json.
143
144         * Scripts/webkitpy/common/config/contributors.json:
145
146 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
147
148         Always switch to an sRGB screen color profile when running tests
149         https://bugs.webkit.org/show_bug.cgi?id=133712
150
151         Reviewed by Tim Horton.
152         
153         Switch the screen color profile to sRGB when running tests, because even ref
154         tests need the screen to use the correct color profile.
155
156         * DumpRenderTree/mac/LayoutTestHelper.m:
157         (installLayoutTestColorProfile):
158         * Scripts/webkitpy/port/mac.py:
159         (MacPort.start_helper):
160
161 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
162
163         [EFL] Bump EFL libraries to 1.9
164         https://bugs.webkit.org/show_bug.cgi?id=125479
165
166         Reviewed by Gyuyoung Kim.
167
168         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
169         and László Langó <llango.u-szeged@partner.samsung.com>.
170
171         * ImageDiff/CMakeLists.txt:
172         * MiniBrowser/efl/CMakeLists.txt:
173         * efl/install-dependencies:
174         * efl/jhbuild.modules:
175         * efl/jhbuildrc:
176
177 2014-06-10  David Farler  <dfarler@apple.com>
178
179         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
180         https://bugs.webkit.org/show_bug.cgi?id=133663
181
182         Reviewed by David Kilzer.
183
184         * Scripts/old-run-webkit-tests:
185         (installAndLaunchDumpToolAppUsingNotification):
186         - Remove obsolete notification keys
187         - Key off of mandatory device UDID (a UUID)
188         - Create a device on demand via CoreSimulator if necessary
189         -- Grab the UDID from the created device plist.
190         * Scripts/webkitdirs.pm:
191         (iOSSimulatorDevicesPath): Added
192         (iOSSimulatorDevices): Added
193         (createiOSSimulatorDevice): Added
194         (deleteiOSSimulatorDevice): Added
195
196 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
197
198         [GTK][gtkdoc] remove -Wcast-align
199         https://bugs.webkit.org/show_bug.cgi?id=133640
200
201         Apparently gcc warns that GParamSpec is not castable to
202         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
203         though ARM hackers claim that those only need 4byte alignment. As long as gcc
204         behaves that way, this warning is not very useful, also they break the Debian
205         packaging.
206
207         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
208         scanner compilation, thus the compiler ignores the previous
209         -Waling-cast flag.
210
211         Reviewed by Martin Robinson.
212
213         * gtk/generate-gtkdoc:
214         (get_generator_for_config):
215
216 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
217
218         Disable button animations in regression tests
219         https://bugs.webkit.org/show_bug.cgi?id=133647
220         <rdar://problem/16677530>
221
222         Reviewed by Tim Horton.
223
224         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
225         (WTR::InjectedBundle::platformInitialize):
226
227 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
228
229         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
230         https://bugs.webkit.org/show_bug.cgi?id=133650
231
232         Reviewed by Tim Horton.
233         
234         No point checking for a Windows-style path in Cocoa code.
235
236         * WebKitTestRunner/TestInvocation.cpp:
237         (WTR::shouldUseThreadedScrolling):
238
239 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
240
241         Fix more latched scrolling test flakiness and slowness
242         https://bugs.webkit.org/show_bug.cgi?id=133601
243
244         Reviewed by Brent Fulgham.
245         
246         Latched scrolling tests were flakey for two reasons. First, the EventSender
247         wheel events were async from the web to the UI process, and the resulting
248         synthetic events also async from the UI to the web process. Make them sync
249         for testing.
250         
251         Secondly, the timer-based scrolling tree commit could result in the scrolling
252         tree (specifically the frame node's notion of the scrollable area and content
253         size) not being updated before the scrolling thread starts getting wheel events.
254         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
255         
256         Finally remove all the now-unnecessary timeouts from the tests.
257
258         * WebKitTestRunner/mac/EventSenderProxy.mm:
259         (WTR::EventSenderProxy::mouseMoveTo):
260         (WTR::EventSenderProxy::mouseScrollBy):
261         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
262
263 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
264
265         [EFL] Add parameter to MiniBrowser to disable web security
266         https://bugs.webkit.org/show_bug.cgi?id=121095
267
268         Reviewed by Gyuyoung Kim.
269
270         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
271         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
272         resources from other domains (cross-domain requests) such as access map location on another server.
273         Another possibility is to launch in a webkit browser local file tests that will refer to the links
274         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
275
276         * MiniBrowser/efl/main.c:
277         (window_create):
278         (elm_main):
279
280 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
281
282         32-bit build fix.
283
284         * WebKitTestRunner/mac/EventSenderProxy.mm:
285         (WTR::EventSenderProxy::mouseMoveTo):
286         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
287
288 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
289
290         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
291
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (createWebViewAndOffscreenWindow):
294         * DumpRenderTree/mac/EventSendingController.mm:
295         (-[EventSendingController mouseScrollByX:andY:continuously:]):
296         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
297         * WebKitTestRunner/mac/EventSenderProxy.mm:
298         (WTR::EventSenderProxy::mouseScrollBy):
299         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
300
301 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
302
303         Latched scrolling tests are flakey on Mavericks
304         https://bugs.webkit.org/show_bug.cgi?id=133578
305         <rdar://problem/17180591>
306
307         Reviewed by Brent Fulgham.
308         
309         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
310         be wrong on machines with more than one screen. This is because we use
311         [NSScreen mainScreen] when computing the global coordinates of the events, but
312         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
313         
314         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
315         add comments clarifying why the coordinate math works (which is not obvious given
316         the events have no target window).
317         
318         Some scrolling tests also dispatched events outside the 800x600 test window, so
319         fix those tests, and add logging that will appear in test output when this happens.
320
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         (createWebViewAndOffscreenWindow):
323         * DumpRenderTree/mac/EventSendingController.mm:
324         (-[EventSendingController mouseScrollByX:andY:continuously:]):
325         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
326         * WebKitTestRunner/mac/EventSenderProxy.mm:
327         (WTR::EventSenderProxy::mouseMoveTo):
328         (WTR::EventSenderProxy::mouseScrollBy):
329         (WTR::EventSenderProxy::continuousMouseScrollBy):
330         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
331
332 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
333
334         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
335         https://bugs.webkit.org/show_bug.cgi?id=133533
336
337         Reviewed by Carlos Garcia Campos.
338
339         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
340         (run): Remove the jhbuild-wrapper wrapper from here. It should be
341         on Scripts/webkitpy/port/gtk.py.
342         * Scripts/webkitpy/port/base.py:
343         (Port.set_option): Add a set_option(name, value) function to set
344         the optparse parameter "name" to the value "value", even if the
345         parameter "name" is already initialized.
346         * Scripts/webkitpy/port/gtk.py:
347         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
348         If another wrapper is specified via the option "-l --wrapper=x",
349         then prepend the jhbuild-wrapper to the one specified.
350
351 2014-06-04  David Farler  <dfarler@apple.com>
352
353         Build ASan WebKit for iOS Simulator
354         https://bugs.webkit.org/show_bug.cgi?id=133489
355
356         Reviewed by Darin Adler.
357
358         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
359         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
360         - Add missing ASan LDFLAGS.
361         * asan/asan.xcconfig:
362         - Split compiler-rt linker flags for OS X and iOS Simulator
363
364 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
365
366         Add myself (yoav@yoav.ws) to contributors.json
367         https://bugs.webkit.org/show_bug.cgi?id=133492
368
369         * Scripts/webkitpy/common/config/contributors.json:
370
371 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
372
373         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
374         https://bugs.webkit.org/show_bug.cgi?id=133149
375
376         Reviewed by Csaba Osztrogonác.
377
378         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
379
380 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
381
382         Add a verbose flag to binding tests
383         https://bugs.webkit.org/show_bug.cgi?id=122303
384
385         Reviewed by Csaba Osztrogonác.
386
387         This patch will:
388         - Add a verbose keyword argument to the BindingsTests constructor,
389         - Add --no-verbose option to the run-bindigs-test.
390         Verbose mode, which is on by default, prints positive results to stdout as before.
391         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
392
393         Original patch from Matthew Hanson <matthew_hanson@apple.com>
394
395         * Scripts/run-bindings-tests:
396         (main):
397         * Scripts/webkitpy/bindings/main.py:
398         (BindingsTests.__init__):
399         (BindingsTests.detect_changes):
400
401 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
402
403         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
404         https://bugs.webkit.org/show_bug.cgi?id=133455
405
406         Reviewed by Timothy Hatcher.
407
408         Since the perf. dashboard doesn't support following renamed benchmarks,
409         keep reporting Speedometer results as DoYouEvenBench results.
410
411         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
412         (_generate_results_dict):
413
414 2014-05-31  Darin Adler  <darin@apple.com>
415
416         Viewport percentage tests that resize the viewport are flaky
417         https://bugs.webkit.org/show_bug.cgi?id=133351
418
419         Reviewed by Anders Carlsson.
420
421         * DumpRenderTree/mac/DumpRenderTree.mm:
422         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
423         happens to be stored in the UI delegate object. This is part of resetting the
424         window position.
425
426         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
427         a frame rectangle. The size is stored in the size of the web view itself.
428         * DumpRenderTree/mac/UIDelegate.mm:
429         (-[UIDelegate resetWindowOrigin]): Added.
430         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
431         old version would store the frame, but not resize the web view!
432         (-[UIDelegate webViewFrame:]): Get the size from the web view.
433
434         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
435         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
436
437         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
438         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
439         the window.
440
441         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
442         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
443         window gets resized too, not just the web view.
444         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
445
446         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
447         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
448         window gets resized too, not just the web view.
449         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
450
451 2014-05-30  Michael Saboff  <msaboff@apple.com>
452
453         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
454         https://bugs.webkit.org/show_bug.cgi?id=133409
455
456         Reviewed by Filip Pizlo.
457
458         Handle creating a tarball the same way as running remote when processing
459         paths in prepareBundle.
460
461         * Scripts/run-jsc-stress-tests:
462
463 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
464
465         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
466         https://bugs.webkit.org/show_bug.cgi?id=132280
467
468         Reviewed by Chris Fleizach.
469
470         Remove implementation of logAccessibilityEvents() for ATK based
471         ports, as this has proved to be a flaky method of checking that
472         ATK events are being properly emitted. Instead, it's better to use
473         the addNotificationListener() functions and provide a JS callback
474         to check that the right events are being emmitted from the tests.
475
476         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
477         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
478         with dummy implementation.
479         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
480         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
481
482 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
483
484         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
485         https://bugs.webkit.org/show_bug.cgi?id=132280
486
487         Rubber stamped by Carlos Garcia Campos.
488
489         Fix two small issues with previous patch (r169483), that caused some tests to break.
490
491         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
492         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
493         duplicated entry.
494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
495         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
496
497 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
498
499         [ATK] Added new accessibility signal: text-caret-moved.
500         Make AccessibilityUIElement.setSelectedTextRange work
501         as atk_text_set_caret_offset when given offset == 0.
502         https://bugs.webkit.org/show_bug.cgi?id=132527
503
504         Reviewed by Mario Sanchez Prada.
505
506         text-caret-moved signal in accessibilityController is needed to
507         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
508         as LayoutTests. Add the signal to the controller.
509
510         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
511         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
512         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
513         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
514         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
515         (setSelectedTextRange): Change return type to bool.
516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
517         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
518         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
519         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
520         for extra arguments passed to handler and use it for text-caret-moved offset.
521         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
522         Connect callback to new listener for ATK:AtkText:text-caret-moved.
523         Refactor so that failures be reported.
524         Initialize atk interfaces before trying to connect to them, see
525         https://bugzilla.gnome.org/show_bug.cgi?id=729922
526         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
527         Simplify code by using a vector in place of dozen variables.
528         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
529         Comment about not synchronizing with accessibilityController.
530
531 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
532
533         [GTK] Add a WebKit2 Performance bot.
534         https://bugs.webkit.org/show_bug.cgi?id=132862
535
536         Reviewed by Csaba Osztrogonác.
537
538         This adds a GTK WebKit2 perf bot.
539
540         * BuildSlaveSupport/build.webkit.org-config/config.json:
541
542 2014-05-29  Dan Bernstein  <mitz@apple.com>
543
544         Fixed the WebKitTestRunner build after r169452.
545
546         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
547         (WTR::InjectedBundle::initialize):
548
549 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
550
551         Unreviewed. Update my email addresses in contributors.json.
552
553         * Scripts/webkitpy/common/config/contributors.json:
554
555 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
556
557         Need an API test for bug #133193 (r169315)
558         <https://bugs.webkit.org/show_bug.cgi?id=133324>
559
560         This adds an API test that ensures that calling "stop loading" during a
561         "did fail provisional load" callback doesn't crash.
562
563         Reviewed by Andy Estes.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         Add new files to project.
567
568         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
569         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
570         If the message is the "test done" message, record that.
571         (TestWebKitAPI::setInjectedBundleClient):
572         Register a function for the "did receive message from injected bundle"
573         callback.
574         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
575         Assert that we received the message from the injected bundle, and set
576         'done' to finish the test.
577         (TestWebKitAPI::TEST):
578         Create a WebView, register a page loader client for the "did fail
579         provisional load" callback, and load a non-existent resource.
580
581         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
582         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
583         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
584         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
585         provisional load failed.
586         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
587         Register a page loader client for the "did fail provisional load"
588         callback.
589         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
590         Call WKBundlePageStopLoading() during the callback. This not crashing
591         is what we're ensuring with this test.
592
593 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
594
595         [GTK] Make it possible to build with FTL enabled
596         https://bugs.webkit.org/show_bug.cgi?id=133219
597
598         Reviewed by Philippe Normand.
599
600         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
601         same revision than mac.
602
603 2014-05-27  Michael Saboff  <msaboff@apple.com>
604
605         REGRESSION(r169265): sh: line 0: cd: ../.vm
606         https://bugs.webkit.org/show_bug.cgi?id=133242
607
608         Rubber stamped by Oliver Hunt.
609
610         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
611         array since the command may contain character escapes that don't work with the
612         array form of system().
613
614         * Scripts/run-jsc-stress-tests:
615
616 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
617
618         [EFL] Change download url of freetype6
619         https://bugs.webkit.org/show_bug.cgi?id=133303
620
621         Reviewed by Csaba Osztrogonác.
622
623         freetype6 tarball isn't downloaded in Korea. So, we need to
624         change the url for now.
625
626         * efl/jhbuild.modules:
627
628 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
629
630         Remove BLOB guards
631         https://bugs.webkit.org/show_bug.cgi?id=132863
632
633         Reviewed by Csaba Osztrogonác.
634
635         * Scripts/webkitperl/FeatureList.pm:
636
637 2014-05-27  Alberto Garcia  <berto@igalia.com>
638
639         Remove leftover comment from r165182.
640
641         Rubber stamped by Carlos Garcia Campos.
642
643         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
644
645 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
646
647         [EFL] Add LLVM as optional jhbuild module for FTL developers
648         https://bugs.webkit.org/show_bug.cgi?id=133216
649
650         Reviewed by Gyuyoung Kim.
651
652         * efl/jhbuild.modules:
653
654 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
655
656         Fix test failures on python test
657         https://bugs.webkit.org/show_bug.cgi?id=133297
658
659         Reviewed by Dirk Schulze.
660
661         2 tests are failing because of unbounded local variable reference in test_importer.py.
662
663         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
664         (TestImporter.import_tests):
665
666 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
667
668         [GTK] GObject DOM bindings API break test fails in the tests bots
669         https://bugs.webkit.org/show_bug.cgi?id=133211
670
671         Reviewed by Martin Robinson.
672
673         When generating the built product archive on platform GTK, we need
674         to copy also the file gtkdoc-webkitdom.cfg and the directory
675         DerivedSources/webkitdom.
676
677         * BuildSlaveSupport/built-product-archive:
678         (archiveBuiltProduct):
679
680 2014-05-26  Commit Queue  <commit-queue@webkit.org>
681
682         Unreviewed, rolling out r169122.
683         https://bugs.webkit.org/show_bug.cgi?id=133288
684
685         Broke CJK font fallback (Requested by ap on #webkit).
686
687         Reverted changeset:
688
689         "[Mac] WebProcess doesn't follow localization of UI process
690         when run as a service"
691         https://bugs.webkit.org/show_bug.cgi?id=133126
692         http://trac.webkit.org/changeset/169122
693
694 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
695
696         [GTK] WebProcess leaked when closing pages with network process enabled
697         https://bugs.webkit.org/show_bug.cgi?id=129684
698
699         Reviewed by Anders Carlsson.
700
701         Enable the test to check that web processes finish when the web
702         view is destroyed.
703
704         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
705
706 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
709         https://bugs.webkit.org/show_bug.cgi?id=133279
710
711         Reviewed by Philippe Normand.
712
713         generator.saw_warnings is only set by GTKDoc::generate(), so it
714         should only be used after generate.
715
716         * gtk/generate-gtkdoc:
717         (generate_documentation_for_config): Do not check
718         generator.saw_warnings again, simply return the value returned by
719         generate_doc() which is generator.saw_warnings. When rebasing,
720         returns always False since there aren't warnings.
721
722 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
723
724         W3C test importer should catch exceptions coming from HTML/CSS conversion
725         https://bugs.webkit.org/show_bug.cgi?id=133176
726
727         Reviewed by Darin Adler.
728
729         Exceptions raised when converting HTML/CSS are caught.
730         Files for which conversion failed are still copied to the target directory.
731         Each individual conversion failure is logged.
732         Total conversion failure number is logged at the end of the import process.
733
734         * Scripts/webkitpy/w3c/test_importer.py:
735         (TestImporter.import_tests):
736
737 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
738
739         [GTK] Allow to run the tests on the native X display.
740         https://bugs.webkit.org/show_bug.cgi?id=133157
741
742         Reviewed by Benjamin Poulain.
743
744         This adds a new driver (xorgdriver) that runs the tests on the
745         X display referenced by the environment variable DISPLAY.
746
747         This new driver will be activated only if the environment variable
748         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
749         tests and performance tests.
750
751         This patch also makes the script run-perf-tests to check the
752         system dependencies before starting the tests. Previously this
753         was not checked, and if the system dependencies were not met,
754         the script tried to execute the tests anyway, causing massive
755         failures. For example, if you had Xvfb not installed and you
756         wanted to use the Xvfb driver (the default on GTK and EFL),
757         run-perf-tests would not abort.
758
759         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
760         (PerfTestsRunner._parse_args): Check the system dependencies of
761         the driver before starting the tests.
762         * Scripts/webkitpy/port/driver.py:
763         (Driver): Implement generic check_driver method.
764         (Driver.check_driver):
765         (Driver.check_driver.implementation):
766         * Scripts/webkitpy/port/gtk.py:
767         (GtkPort._driver_class): Check for environment variable
768         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
769         * Scripts/webkitpy/port/xorgdriver.py: Added.
770         (XorgDriver): Implement Xorg driver.
771         (XorgDriver.check_driver):
772         (XorgDriver._start):
773
774 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
775
776         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
777         https://bugs.webkit.org/show_bug.cgi?id=133215
778
779         Reviewed by Csaba Osztrogonác.
780
781         This reverts r166798.
782
783         * BuildSlaveSupport/kill-old-processes:
784         (main):
785
786 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
787
788         [EFL] Turn on ENABLE_CSS_FILTERS in build script
789         https://bugs.webkit.org/show_bug.cgi?id=133278
790
791         Reviewed by Gyuyoung Kim.
792
793         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
794
795 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
796
797         run-javascriptcore-tests warning fix on non Mac platforms
798         https://bugs.webkit.org/show_bug.cgi?id=133260
799
800         Reviewed by Darin Adler.
801
802         * Scripts/webkitdirs.pm:
803         (argumentsForConfiguration):
804
805 2014-05-23  Michael Saboff  <msaboff@apple.com>
806
807         REGRESSION(r169265): sh: line 0: cd: ../.vm
808         https://bugs.webkit.org/show_bug.cgi?id=133242
809
810         Rubber stamped by Geoffrey Garen.
811
812         Added missing shell escapes '\' required as part of previous fix.
813
814         * Scripts/run-jsc-stress-tests:
815
816 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
817
818         Revert the erroneous change committed in r169286.
819
820         * Scripts/webkitpy/performance_tests/perftest.py:
821         (PerfTest._run_with_driver):
822
823 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
824
825         run-perf-tests should ignore whitespace lines when snarfing test output
826         https://bugs.webkit.org/show_bug.cgi?id=133238
827
828         Reviewed by Ryosuke Niwa.
829
830         Required for PerformanceTests/Canvas/terrain.html.
831
832         * Scripts/webkitpy/performance_tests/perftest.py:
833         (PerfTest._run_with_driver):
834         (PerfTest):
835
836 2014-05-23  Michael Saboff  <msaboff@apple.com>
837
838         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
839         https://bugs.webkit.org/show_bug.cgi?id=133223
840
841         Reviewed by Geoffrey Garen.
842
843         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
844         string before calling IO.popen() to work with older versions of ruby.
845         Changed the remote path in runShellTestRunner to quote the command
846         string we want to run via ssh so that it will work correctly with array
847         to string conversion needed for popen.
848
849         * Scripts/run-jsc-stress-tests:
850
851 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
852
853         Remove 'css-shaders' option from the build-webkit
854         https://bugs.webkit.org/show_bug.cgi?id=133212
855
856         Reviewed by Daniel Bates.
857
858         Original CSS shaders removed in r162644.
859
860         * Scripts/webkitperl/FeatureList.pm:
861
862 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
863
864         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
865         https://bugs.webkit.org/show_bug.cgi?id=133209
866
867         Reviewed by Sergio Villar Senin.
868
869         Return FAILURE when the command failed to run.
870
871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
872         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
873
874 2014-05-23  Alberto Garcia  <berto@igalia.com>
875
876         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
877         https://bugs.webkit.org/show_bug.cgi?id=133210
878
879         Reviewed by Carlos Garcia Campos.
880
881         * gtk/install-dependencies:
882
883 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
884
885         Add Yusuke Suzuki to the list of contributors (for real)
886
887         Wrong section...
888
889         * Scripts/webkitpy/common/config/contributors.json:
890
891 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
892
893         Add Yusuke Suzuki to the list of contributors
894
895         * Scripts/webkitpy/common/config/contributors.json:
896
897 2014-05-22  Michael Saboff  <msaboff@apple.com>
898
899         Eliminate n/total progress update from run-jsc-stress-tests output to file
900         https://bugs.webkit.org/show_bug.cgi?id=133191
901
902         Reviewed by Geoffrey Garen.
903
904         Changed progressMeter setting to be based on stdout being a tty instead of
905         stdin.  Unified the processing of output from the shell runner to match the
906         same processing as is used by the makefile runner.  As part of this, the 
907         shell runner script was simplified.  It now forwards the output of each
908         test_script just like the Makefile and doesn't provide its own progress.
909
910         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
911         * Scripts/run-jsc-stress-tests:
912
913 2014-05-22  Michael Saboff  <msaboff@apple.com>
914
915         Add option to run-jsc-stress-tests to use installed jsc
916         https://bugs.webkit.org/show_bug.cgi?id=133102
917
918         Reviewed by Geoffrey Garen.
919
920         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
921         provied with the --jsc option.
922
923         * Scripts/run-jsc-stress-tests:
924
925 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
926
927         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
928         https://bugs.webkit.org/show_bug.cgi?id=132907
929
930         Reviewed by Gyuyoung Kim.
931
932         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
933         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
934
935         * efl/install-dependencies:
936
937 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
938
939         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
940         https://bugs.webkit.org/show_bug.cgi?id=133145
941
942         Reviewed by Csaba Osztrogonác.
943
944         * Scripts/run-jsc-stress-tests:
945
946 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
947
948         [Mac] WebProcess doesn't follow localization of UI process when run as a service
949         https://bugs.webkit.org/show_bug.cgi?id=133126
950         <rdar://problem/13396515>
951         <rdar://problem/16561084>
952
953         Reviewed by Sam Weinig and Tim Horton.
954
955         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
956         (WTR::InjectedBundle::platformInitialize): It was too late to override language
957         here, and it's not necessary any more. Keeping the code for older OS versions in
958         case it did have effect in some code paths.
959
960 2014-05-19  David Farler  <dfarler@apple.com>
961
962         Move WebKitTestRunner to std::unique_ptr
963         https://bugs.webkit.org/show_bug.cgi?id=133081
964
965         Reviewed by Daniel Bates.
966
967         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
968         (WTR::InjectedBundle::didCreatePage):
969         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
970         * WebKitTestRunner/TestController.cpp:
971         (WTR::TestController::initialize):
972         (WTR::TestController::createWebViewWithOptions):
973         (WTR::TestController::resetStateToConsistentValues):
974         (WTR::TestController::runTest):
975         * WebKitTestRunner/TestController.h:
976         * WebKitTestRunner/TestInvocation.cpp:
977         * WebKitTestRunner/TestInvocation.h:
978         * WebKitTestRunner/WorkQueueManager.cpp:
979         (WTR::WorkQueueManager::processWorkQueue):
980         (WTR::WorkQueueManager::enqueue):
981         * WebKitTestRunner/WorkQueueManager.h:
982
983 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
984
985         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
986         https://bugs.webkit.org/show_bug.cgi?id=133119
987
988         Reviewed by Sergio Villar Senin.
989
990         Check that redirect response parameter of
991         WebKitWebPage::send-request signal is NULL when not redirecting
992         and a valid WebKitURIResponse object when redirecting.
993
994         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
995         (testWebResourceSendRequest):
996         (serverCallback):
997         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
998         (sendRequestCallback):
999
1000 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1003         https://bugs.webkit.org/show_bug.cgi?id=133117
1004
1005         Reviewed by Philippe Normand.
1006
1007         Bring back missing tests to the build.
1008
1009         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1010
1011 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
1012
1013         Take care of some ARM64 test failures
1014         https://bugs.webkit.org/show_bug.cgi?id=133090
1015
1016         Reviewed by Geoffrey Garen.
1017
1018         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1019
1020 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1021
1022         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1023         <http://webkit.org/b/133089>
1024
1025         Reviewed by Darin Adler.
1026
1027         * Scripts/webkitdirs.pm:
1028         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1029         specified on the command line, we would remove the '--sdk'
1030         arguments, but leave '--sim', potentially passing it along to
1031         xcodebuild causing a build failure.  This happens when
1032         'old-run-webkit-tests --release --sim' invokes
1033         build-dumprendertree when DumpRenderTree hasn't been built yet.
1034
1035 2014-05-19  David Farler  <dfarler@apple.com>
1036
1037         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1038         https://bugs.webkit.org/show_bug.cgi?id=133086
1039
1040         Reviewed by Daniel Bates.
1041
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1043
1044 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1045
1046         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1047         <http://webkit.org/b/132954>
1048
1049         * Scripts/webkitdirs.pm:
1050         (sharedCommandLineOptionsUsage): Remove the prototype for the
1051         subroutine.  Older perls don't like the "+@" syntax.
1052
1053 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1054
1055         run-javascriptcore-tests should sort the list of failing stress tests
1056         https://bugs.webkit.org/show_bug.cgi?id=132989
1057
1058         Reviewed by Csaba Osztrogonác.
1059
1060         * Scripts/run-javascriptcore-tests:
1061
1062 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1063
1064         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1065         <http://webkit.org/b/132954>
1066
1067         Reviewed by Darin Adler.
1068
1069         Extract code into setupMacWebKitEnvironment() for setting up
1070         common environment variables so it may be shared.  Sets
1071         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1072         using guardmalloc to some scripts.
1073
1074         Also adds support for parsing shared (common) command-line
1075         switches, initially just -g|--guard-malloc.
1076
1077         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1078         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1079         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1080         local copy of %ENV when launching Safari so we don't have to
1081         restore variables.
1082
1083         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1084         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1085         Check result of GetOptions() to catch invalid command-line
1086         switches.
1087         (runTest): Use a local copy of %ENV when running tests so we
1088         don't have to restore variables.
1089         (prepareEnvironmentForRunningTestTool): Call
1090         setupMacWebKitEnvironment().
1091
1092         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1093         using sharedCommandLineOptions() and
1094         sharedCommandLineOptionsUsage().  Call
1095         setupMacWebKitEnvironment().
1096
1097         * Scripts/webkitdirs.pm:
1098         (sharedCommandLineOptions): Return array of common switches to
1099         pass to Getopt::Long::GetOptions().
1100         (sharedCommandLineOptionsUsage): Return formatted string of
1101         common switches for printing usage help text.
1102         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1103         guardmalloc.
1104         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1105         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1106         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1107         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1108         local copy of %ENV when launching Safari so we don't have to
1109         restore variables.
1110         (execMacWebKitAppForDebugging): Call
1111         setupMacWebKitEnvironment().
1112
1113 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1114
1115         support for navigator.hardwareConcurrency
1116         https://bugs.webkit.org/show_bug.cgi?id=132588
1117
1118         Reviewed by Filip Pizlo.
1119
1120         * Scripts/webkitperl/FeatureList.pm:
1121
1122 2014-05-18  Anders Carlsson  <andersca@apple.com>
1123
1124         Implement Navigations for all methods declared returning one
1125         https://bugs.webkit.org/show_bug.cgi?id=133048
1126         <rdar://problem/16830064>
1127
1128         Reviewed by Sam Weinig.
1129
1130         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1131         Import WebKit.h.
1132         
1133         * MiniBrowser/mac/WK2BrowserWindowController.m:
1134         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1135         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1136         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1137         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1138         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1139         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1140         Print out the navigations.
1141
1142 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1143
1144         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1145         https://bugs.webkit.org/show_bug.cgi?id=133029
1146
1147         Reviewed by Simon Fraser.
1148
1149         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1150         toggling it on a WK2 window needs restart.
1151         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1152         the WebPreferences just to support this temporary toggle.
1153
1154         * MiniBrowser/mac/BrowserWindowController.h:
1155         * MiniBrowser/mac/MainMenu.xib:
1156         * MiniBrowser/mac/WK1BrowserWindowController.m:
1157         (-[WK1BrowserWindowController validateMenuItem:]):
1158         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1159         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1160         * MiniBrowser/mac/WK2BrowserWindowController.m:
1161         (-[WK2BrowserWindowController validateMenuItem:]):
1162         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1163         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1164
1165 2014-05-17  Anders Carlsson  <andersca@apple.com>
1166
1167         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1168         https://bugs.webkit.org/show_bug.cgi?id=133033
1169         <rdar://problem/16830143>
1170
1171         Reviewed by Sam Weinig.
1172
1173         Set up the WebSQL and IndexedDB directories.
1174
1175         * WebKitTestRunner/TestController.cpp:
1176         (WTR::TestController::initialize):
1177
1178 2014-05-16  Martin Hock  <mhock@apple.com>
1179
1180         MemoryCache::addImageToCache should return the result of add().
1181         https://bugs.webkit.org/show_bug.cgi?id=132928
1182         <rdar://problem/16651547>
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1188         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1189         (TestWebKitAPI::TEST):
1190
1191 2014-05-15  David Farler  <dfarler@apple.com>
1192
1193         old-run-webkit-tests: allow specifying a simulator app path
1194         https://bugs.webkit.org/show_bug.cgi?id=132975
1195
1196         Reviewed by Anders Carlsson.
1197
1198         * Scripts/old-run-webkit-tests:
1199         (openIPhoneSimulator):
1200         Add new --simulator-app command line parameter for specifying the
1201         absolute path to the simulator app to launch before starting a
1202         session.
1203
1204 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1205
1206         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1207         https://bugs.webkit.org/show_bug.cgi?id=131363
1208
1209         Reviewed by Csaba Osztrogonác.
1210
1211         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1212         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1213         (MockBugzilla):
1214         * Scripts/webkitpy/tool/commands/download_unittest.py:
1215         (test_create_rollout_multiple_revision_with_one_resolved):
1216         (test_create_rollout_multiple_resolved):
1217         (test_rollout_two_revisions):
1218         (test_rollout_multiple_revisions):
1219         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1220         * Scripts/webkitpy/tool/steps/createbug.py:
1221         (CreateBug.run):
1222         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1223         (ReopenBugAfterRollout.run):
1224
1225 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1226
1227         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1228         https://bugs.webkit.org/show_bug.cgi?id=132956
1229
1230         Reviewed by Sam Weinig.
1231
1232         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1233         * MiniBrowser/mac/AppDelegate.m:
1234         * MiniBrowser/mac/WK2BrowserWindowController.m:
1235         * TestWebKitAPI/InjectedBundleController.h:
1236         * TestWebKitAPI/InjectedBundleMain.cpp:
1237         * TestWebKitAPI/JavaScriptTest.cpp:
1238         * TestWebKitAPI/PlatformUtilities.h:
1239         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1240         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1241         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1242         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1243         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1244         (TestWebKitAPI::TEST):
1245         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1246         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1247         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1248         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1249         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1250         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1251         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1252         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1253         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1254         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1255         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1256         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1257         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1258         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1259         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1260         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1261         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1262         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1263         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1264         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1265         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1266         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1267         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1268         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1269         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1270         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1271         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1272         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1273         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1274         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1275         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1276         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1277         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1278         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1279         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1280         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1281         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1282         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1283         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1284         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1285         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1286         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1287         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1288         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1289         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1290         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1291         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1292         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1293         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1294         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1295         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1296         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1297         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1298         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1299         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1300         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1301         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1302         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1303         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1304         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1305         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1306         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1307         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1308         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1309         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1310         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1311         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1312         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1313         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1314         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1315         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1316         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1317         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1318         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1319         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1320         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1321         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1322         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1323         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1324         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1325         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1326         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1327         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1328         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1329         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1330         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1331         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1332         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1333         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1334         * TestWebKitAPI/config.h:
1335         * TestWebKitAPI/efl/PlatformWebView.cpp:
1336         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1337         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1338         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1339         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1340         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1341         * WebKitTestRunner/EventSenderProxy.h:
1342         * WebKitTestRunner/GeolocationProviderMock.cpp:
1343         * WebKitTestRunner/GeolocationProviderMock.h:
1344         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1345         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1346         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1347         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1348         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1349         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1350         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1351         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1352         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1355         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1356         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1358         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1359         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1360         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1361         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1362         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1363         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1364         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1365         * WebKitTestRunner/PlatformWebView.h:
1366         * WebKitTestRunner/StringFunctions.h:
1367         * WebKitTestRunner/TestController.cpp:
1368         * WebKitTestRunner/TestController.h:
1369         * WebKitTestRunner/TestInvocation.cpp:
1370         * WebKitTestRunner/TestInvocation.h:
1371         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1372         * WebKitTestRunner/WebNotificationProvider.cpp:
1373         * WebKitTestRunner/WebNotificationProvider.h:
1374         * WebKitTestRunner/WorkQueueManager.cpp:
1375         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1376         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1377         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1378         * WebKitTestRunner/config.h:
1379         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1380         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1381         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1382         * WebKitTestRunner/ios/TestControllerIOS.mm:
1383         * WebKitTestRunner/mac/EventSenderProxy.mm:
1384         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1385         * WebKitTestRunner/mac/TestControllerMac.mm:
1386
1387 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1388
1389         [EFL][WK2] Skip failing unit tests
1390         https://bugs.webkit.org/show_bug.cgi?id=132979
1391
1392         Reviewed by Daniel Bates.
1393
1394         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1395
1396 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1397
1398         [iOS] Support TestWebKitAPI in the iOS Simulator
1399         <http://webkit.org/b/129535>
1400         <rdar://problem/16203529>
1401
1402         Reviewed by Daniel Bates.
1403
1404         * Scripts/run-api-tests:
1405         (runTest):
1406         (listAllTests):
1407         - Extract common arguments into local variable.
1408         - Use xcrun to find the sim tool in order to invoke
1409         TestWebKitAPI properly in the iOS Simulator. 
1410
1411         * Scripts/webkitdirs.pm:
1412         (argumentsForConfiguration): Set --device or --sim as
1413         appropriate to fix buildTestTool() in run-api-tests.
1414
1415 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1416
1417         Fix a logging typo in copy-webkitlibraries-to-product-directory
1418
1419         Reviewed by Dean Jackson.
1420
1421         * Scripts/copy-webkitlibraries-to-product-directory:
1422
1423 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1424
1425         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1426         <http://webkit.org/b/132959>
1427
1428         Reviewed by Dan Bernstein.
1429
1430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1431         Cocoa directory to project and move URLExtras.mm into it.
1432         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1433
1434 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         [GTK] Compile all installed resources as GResources
1437         https://bugs.webkit.org/show_bug.cgi?id=131099
1438
1439         Reviewed by Philippe Normand.
1440
1441         * Scripts/webkitpy/port/gtk.py:
1442         (GtkPort.setup_environ_for_server): Removed now unneeded
1443         AUDIO_RESOURCES_PATH env var.
1444
1445 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1446
1447         Remove CSS_STICKY_POSITION guards
1448         https://bugs.webkit.org/show_bug.cgi?id=132676
1449
1450         Reviewed by Simon Fraser.
1451
1452         * Scripts/webkitperl/FeatureList.pm:
1453
1454 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1455
1456         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1457         https://bugs.webkit.org/show_bug.cgi?id=132686
1458
1459         Reviewed by Philippe Normand.
1460
1461         Bring back InputMethodFilter test to the build and compile it into
1462         a single binary TestWebCore with the other WebCore tests. Also
1463         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1464
1465         * Scripts/run-gtk-tests:
1466         (TestRunner): Remove WebCoreGtk from the list of test directories.
1467         * TestWebKitAPI/PlatformGTK.cmake:
1468         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1469
1470 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1471
1472         [EFL] Make XVFBDriver optional
1473         https://bugs.webkit.org/show_bug.cgi?id=131036
1474
1475         Reviewed by Gyuyoung Kim.
1476
1477         * Scripts/webkitpy/port/efl.py:
1478         (EflPort._driver_class):
1479
1480 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1481
1482         Flakiness dashboard contains outdated list of bots on builders.jsonp
1483         https://bugs.webkit.org/show_bug.cgi?id=132874
1484
1485         Reviewed by Darin Adler.
1486
1487         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1488         file by changing to the directory Tools/TestResultServer and executing
1489         the script generate_builders_json.py
1490
1491 2014-05-11  Anders Carlsson  <andersca@apple.com>
1492
1493         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1494         https://bugs.webkit.org/show_bug.cgi?id=132809
1495
1496         Reviewed by Dan Bernstein.
1497
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::initialize):
1500         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1501
1502 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1503
1504         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1505         https://bugs.webkit.org/show_bug.cgi?id=132739
1506
1507         Reviewed Anders Carlsson.
1508
1509         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1510         the JSC unit tests.
1511         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1512
1513 2014-05-11  Anders Carlsson  <andersca@apple.com>
1514
1515         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1516         https://bugs.webkit.org/show_bug.cgi?id=132806
1517
1518         Reviewed by Beth Dakin.
1519
1520         Migrate to WKContextConfiguration.
1521
1522         * WebKitTestRunner/TestController.cpp:
1523         (WTR::TestController::initialize):
1524
1525 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1526
1527         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1528         https://bugs.webkit.org/show_bug.cgi?id=132685
1529
1530         Reviewed by Martin Robinson.
1531
1532         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1533
1534         * TestWebKitAPI/PlatformGTK.cmake:
1535
1536 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1537
1538         [iOS] Switch geolocation to an explicit authorization query model
1539         https://bugs.webkit.org/show_bug.cgi?id=132717
1540
1541         Reviewed by Sam Weinig.
1542
1543         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1544         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1545         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1546
1547 2014-05-09  David Farler  <dfarler@apple.com>
1548
1549         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1550         https://bugs.webkit.org/show_bug.cgi?id=132718
1551
1552         Reviewed by David Kilzer.
1553
1554         The simulator may not be able to look up runtimes by SDK paths
1555         and instead will map SDK versions to runtimes instead. In
1556         com.apple.iphonesimulator.startSession notifications,
1557         'runtimeIdentifier' (SDK version string) is preferred over
1558         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1559         when creating a new DRT or WKTR simulator session.
1560
1561         IPhoneSimulatorNotification.pm filters out keys for this
1562         notification's userInfo with a hard-coded list. There's no harm
1563         in including extra key-value pairs in an NSNotification userInfo
1564         dictionary anyway and the simulator may again change its
1565         userInfo schema for this notification.
1566
1567         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1568         (postStartSessionNotification):
1569         * Scripts/old-run-webkit-tests:
1570         (installAndLaunchDumpToolAppUsingNotification):
1571
1572 2014-05-09  Anders Carlsson  <andersca@apple.com>
1573
1574         Another build fix.
1575
1576         * Scripts/build-webkit:
1577         WebKit2 should always be built for OS X and iOS.
1578
1579 2014-05-09  Anders Carlsson  <andersca@apple.com>
1580
1581         Follow-up build fix.
1582
1583         * Scripts/build-webkit:
1584         WebKit2 should no longer be built before WebKit.
1585
1586 2014-05-09  Anders Carlsson  <andersca@apple.com>
1587
1588         Rename WebKit2.framework to WebKit.framework
1589         https://bugs.webkit.org/show_bug.cgi?id=132743
1590         <rdar://problem/15920046>
1591
1592         Reviewed by Dan Bernstein.
1593
1594         * Scripts/check-for-inappropriate-files-in-framework:
1595         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1596         Change WebKit2 to WebKit.
1597
1598         * Scripts/check-for-webkit-framework-include-consistency:
1599         Change WebKit to WebKitLegacy.
1600
1601 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1602
1603         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1604         https://bugs.webkit.org/show_bug.cgi?id=132732
1605
1606         Reviewed by Alexey Proskuryakov.
1607
1608         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1609
1610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1611         (EWS): Remove GTK+ WK1 EWS.
1612
1613 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1614
1615         Add new u-szeged contributors.
1616
1617         Reviewed by Csaba Osztrogonác.
1618
1619         * Scripts/webkitpy/common/config/contributors.json:
1620
1621 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1622
1623         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1624         https://bugs.webkit.org/show_bug.cgi?id=132736
1625
1626         Reviewed by Philippe Normand.
1627
1628         There are two problems, the path returned by common.library_build_path() is wrong when
1629         common.binary_build_path() has previously been called, and the test is still looking for
1630         the .la instead of .so
1631
1632         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1633         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1634         of .la as extension of the injected bundle library.
1635         * gtk/common.py:
1636         (binary_build_path): Remove unused global variable and add a new
1637         one for binary_build_dir instead of sharing the same global
1638         variable for library_build_path and binary_build_path.
1639
1640 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1641
1642         [EFL] Enable MEDIA_STREAM for EFL port
1643         https://bugs.webkit.org/show_bug.cgi?id=132648
1644
1645         Reviewed by Gyuyoung Kim.
1646
1647         Script modified to enable MEDIA_STREAM for EFL build.
1648
1649         * Scripts/webkitperl/FeatureList.pm: 
1650
1651 2014-05-08  David Farler  <dfarler@apple.com>
1652
1653         old-run-webkit-tests: update strings for simulator devices and app name
1654         https://bugs.webkit.org/show_bug.cgi?id=132687
1655
1656         Reviewed by Darin Adler.
1657
1658         iPhone Retina (4-inch) -> iPhone 5
1659         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1660
1661         * Scripts/old-run-webkit-tests:
1662         (installAndLaunchDumpToolAppUsingNotification):
1663         (openIPhoneSimulator):
1664         (quitIPhoneSimulator):
1665         quit iOS Simulator, not iPhone Simulator.
1666
1667 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1668
1669         REGRESSION(r168471): Update the builder names on the scheduler list.
1670         https://bugs.webkit.org/show_bug.cgi?id=132699
1671
1672         Reviewed by Martin Robinson.
1673
1674         On r168471 I missed to update the builder names for the GTK build
1675         bots on the AnyBranchScheduler type scheduler list of bots.
1676
1677         * BuildSlaveSupport/build.webkit.org-config/config.json:
1678
1679 2014-05-08  Brady Eidson  <beidson@apple.com>
1680
1681         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1682         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1683
1684         Reviewed by Tim Horton.
1685
1686         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1687         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1688
1689 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1690
1691         REGRESSION(r168471): Duplicate builddirs broke the build master.
1692         https://bugs.webkit.org/show_bug.cgi?id=132688
1693
1694         Reviewed by Carlos Garcia Campos.
1695
1696         Rename the builddirs of the new GTK bots introduced on r168471 to
1697         be unique. Otherwise the master will break.
1698
1699         * BuildSlaveSupport/build.webkit.org-config/config.json:
1700
1701 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1704         https://bugs.webkit.org/show_bug.cgi?id=132674
1705
1706         Reviewed by Philippe Normand.
1707
1708         Only ignore mkdir failure when exception is raised because the
1709         file already exists and it's a directory.
1710
1711         * gtk/webkitdom.py:
1712         (write_doc_files):
1713
1714 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1715
1716         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1717         https://bugs.webkit.org/show_bug.cgi?id=131358
1718
1719         Reviewed by Carlos Garcia Campos.
1720
1721         Current 64-bit GTK build bots (Release and Debug) not only test
1722         the build, but run all tests. Split each one of the bots in
1723         BuildOnly and TestWebKit2.
1724
1725         This will allow us to have a better overview of the status of
1726         the GTK port.
1727
1728         Original patch from Sergio Villar Senin <svillar@igalia.com>
1729
1730         * BuildSlaveSupport/build.webkit.org-config/config.json:
1731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1733         (WebKitBuildbot):
1734         * Scripts/webkitpy/port/builders.py:
1735         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1736         (TestRebaselineTest.test_baseline_directory):
1737         * TestResultServer/static-dashboards/builders.jsonp:
1738         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1739         (resetGlobals):
1740         * TestResultServer/static-dashboards/loader_unittests.js:
1741
1742 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1743
1744         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1745         https://bugs.webkit.org/show_bug.cgi?id=126022
1746
1747         Reviewed by Benjamin Poulain.
1748
1749         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1750
1751         Added an unit test case to check if scroll position and scale are restored properly.
1752
1753         * TestWebKitAPI/PlatformEfl.cmake:
1754         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1755         (TestWebKitAPI::didFinishLoadForFrame):
1756         (TestWebKitAPI::didChangeContentsPosition):
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1759         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1760
1761 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1762
1763         WebKit1 is flashy when compositing layers come and go
1764         https://bugs.webkit.org/show_bug.cgi?id=132655
1765         <rdar://problem/16830981&16788846>
1766
1767         Reviewed by Sam Weinig.
1768         
1769         Revert the change from r166117.
1770
1771         * DumpRenderTree/mac/DumpRenderTree.mm:
1772         (updateDisplay):
1773
1774 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1775
1776         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1777         https://bugs.webkit.org/show_bug.cgi?id=132622
1778
1779         Reviewed by Mario Sanchez Prada.
1780
1781         * DumpRenderTree/AccessibilityUIElement.cpp:
1782         (selectTextWithCriteriaCallback):
1783         (isEqualCallback):
1784         * DumpRenderTree/AccessibilityUIElement.h:
1785         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1786         (AccessibilityUIElement::selectTextWithCriteria):
1787         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1788         (AccessibilityUIElement::selectTextWithCriteria):
1789         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1790         (selectTextParameterizedAttributeForCriteria):
1791         (AccessibilityUIElement::selectTextWithCriteria):
1792         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1793         (AccessibilityUIElement::selectTextWithCriteria):
1794         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1795         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1796         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1797         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1798         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1799         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1800         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1801         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1802         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1803         (WTR::selectTextParameterizedAttributeForCriteria):
1804         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1805
1806 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1807
1808         [SOUP] TLSErrors do not cause page load to fail when not ignored
1809         https://bugs.webkit.org/show_bug.cgi?id=121548
1810
1811         Reviewed by Sergio Villar Senin.
1812
1813         Add unit tests to check that the load fails with TLS errors in
1814         case of a redirection.
1815
1816         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1817         (testTLSErrorsRedirect):
1818         (httpsServerCallback):
1819         (beforeAll):
1820
1821 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1822
1823         [CSS Grid Layout] Remove runtime feature
1824         https://bugs.webkit.org/show_bug.cgi?id=132382
1825
1826         Reviewed by Benjamin Poulain.
1827
1828         Remove cssGridLayoutEnabled setting usage.
1829
1830         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1831         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1832         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1833         (TestRunner::overridePreference):
1834         * DumpRenderTree/mac/DumpRenderTree.mm:
1835         (resetWebPreferencesToConsistentValues):
1836
1837 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1838
1839         Add Makefile targets for copying static libraries (LLVM and WKSI)
1840         <http://webkit.org/b/132619>
1841
1842         Reviewed by Mark Rowe.
1843
1844         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1845         sensible default for product directory if not specified on
1846         either the command-line or in the environment (by Xcode) by
1847         calling productDir() in webkitdirs.pm.
1848
1849 2014-05-06  Brady Eidson  <beidson@apple.com>
1850
1851         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1852         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1853
1854         Reviewed by Sam Weinig.
1855
1856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1857
1858         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1859         (TestWebKitAPI::itemURLLastComponentIsString):
1860         (TestWebKitAPI::didFinishLoadForFrame):
1861         (TestWebKitAPI::willGoToBackForwardListItem):
1862         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1863         (TestWebKitAPI::setPageLoaderClient):
1864         (TestWebKitAPI::TEST):
1865         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1866         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1867
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1870
1871 2014-05-06  Darin Adler  <darin@apple.com>
1872
1873         Try to fix iOS build.
1874
1875         * DumpRenderTree/mac/TestRunnerMac.mm:
1876         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1877         Updated since I changed testRunner into a pointer instead of a reference.
1878         Updated argument names to avoid conflict with field names.
1879         (-[APITestDelegateIPhone run]): Ditto.
1880         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1881
1882 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1883
1884         Unreviewed, rolling out r168304.
1885         https://bugs.webkit.org/show_bug.cgi?id=132607
1886
1887         Broke the build (Requested by KaL on #webkit).
1888
1889         Reverted changeset:
1890
1891         "[GTK][CMake] Unable to do make install"
1892         https://bugs.webkit.org/show_bug.cgi?id=130188
1893         http://trac.webkit.org/changeset/168304
1894
1895 2014-05-04  Darin Adler  <darin@apple.com>
1896
1897         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1898         https://bugs.webkit.org/show_bug.cgi?id=80222
1899
1900         Reviewed by Alexey Proskuryakov.
1901
1902         * DumpRenderTree/mac/TestRunnerMac.mm:
1903         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1904         do more work here so we don't use RetainPtr local variables.
1905         (-[APITestDelegateIPhone dealloc]): Added.
1906         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1907         created. Updated for changes to member names and types.
1908         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1909         updated for changes to member names and types. Changed to two word spelling.
1910         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1911         name of _cleanUp method.
1912         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1913         Ditto.
1914         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1915
1916 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1917
1918         Clean up Image Document and tweak the layout and viewport
1919         https://bugs.webkit.org/show_bug.cgi?id=132552
1920
1921         Reviewed by Anders Carlsson.
1922
1923         * DumpRenderTree/mac/DumpRenderTree.mm:
1924         (resetWebPreferencesToConsistentValues):
1925         Update the default settings to have something consistent with WebKit2.
1926
1927 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1928
1929         [GTK][CMake] Unable to do make install
1930         https://bugs.webkit.org/show_bug.cgi?id=130188
1931
1932         Reviewed by Carlos Garcia Campos.
1933
1934         * Scripts/webkitdirs.pm:
1935         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1936         will give an early signal that a change has broken the documentation.
1937
1938 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1939
1940         Update framework locations in package-root
1941         https://bugs.webkit.org/show_bug.cgi?id=132571
1942
1943         Reviewed by Simon Fraser.
1944
1945         * Scripts/package-root:
1946
1947 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1948
1949         [EFL][WK2] Refactor favicon database APIs
1950         https://bugs.webkit.org/show_bug.cgi?id=132519
1951
1952         Reviewed by Gyuyoung Kim.
1953
1954         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1955         (update_view_favicon):
1956         (on_icon_changed_cb):
1957         (window_free):
1958         (on_url_changed):
1959         (window_create):
1960         (on_view_favicon_changed): Deleted.
1961
1962 2014-05-02  Mark Rowe  <mrowe@apple.com>
1963
1964         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1965
1966         Reviewed by Dan Bernstein.
1967
1968         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1969         when determining which LLVM archive to extract.
1970
1971 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1972
1973         Add Jeremy as a committer.
1974         https://bugs.webkit.org/show_bug.cgi?id=132492
1975
1976         Reviewed by Jer Noble.
1977
1978         Add myself as a committer.
1979
1980         * Scripts/webkitpy/common/config/contributors.json:
1981
1982 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1983
1984         Add Jeremy as a committer.
1985         https://bugs.webkit.org/show_bug.cgi?id=132492
1986
1987         Reviewed by Jer Noble.
1988
1989         Add Jeremy Jones to the committers file.
1990
1991         * Scripts/webkitpy/common/config/contributors.json:
1992
1993 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1994
1995         Hard to figure out how to run a single test with run-api-tests
1996         https://bugs.webkit.org/show_bug.cgi?id=116332
1997
1998         Reviewed by Alexey Proskuryakov.
1999
2000         * Scripts/run-api-tests: add two examples to the help message.
2001
2002 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
2003
2004         Fix several memory leaks found by code inspection
2005         https://bugs.webkit.org/show_bug.cgi?id=132472
2006
2007         Reviewed by Geoffrey Garen.
2008         
2009         Fix memory leaks.
2010
2011         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2012         (TestWebKitAPI::TEST):
2013         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2014         (WTR::InjectedBundlePage::willSendRequestForFrame):
2015         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2016         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2017
2018 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2019
2020         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2021         https://bugs.webkit.org/show_bug.cgi?id=132446
2022
2023         Reviewed by Mark Hahnenberg.
2024         
2025         Test the FTL by default now that it's enabled by default.
2026
2027         * Scripts/run-javascriptcore-tests:
2028
2029 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2030
2031         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2032         https://bugs.webkit.org/show_bug.cgi?id=132240
2033
2034         Reviewed by Anders Carlsson.
2035
2036         Removed ewk_view_setting_tiled_backingstore related code.
2037
2038         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2039         (DumpRenderTreeChrome::createView):
2040         (shouldUseTiledBackingStore): Deleted.
2041         * EWebLauncher/main.c:
2042         (windowCreate):
2043         (parseUserArguments):
2044
2045 2014-05-01  Anders Carlsson  <andersca@apple.com>
2046
2047         window.testRunner.keepWebHistory() should update the UI process state
2048         https://bugs.webkit.org/show_bug.cgi?id=132440
2049
2050         Reviewed by Dan Bernstein.
2051
2052         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2053         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2054         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2056         (WTR::TestRunner::keepWebHistory):
2057         * WebKitTestRunner/TestInvocation.cpp:
2058         (WTR::TestInvocation::invoke):
2059         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2060
2061 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2062
2063         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2064         <http://webkit.org/b/132432>
2065
2066         Reviewed by Tim Horton.
2067
2068         * Scripts/webkitperl/FeatureList.pm: Remove support for
2069         --plugin-proxy-for-video switch.
2070
2071 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2072
2073         Kernel sysctl interface hw.activecpu don't exists on Linux.
2074         https://bugs.webkit.org/show_bug.cgi?id=132286
2075
2076         Reviewed by Filip Pizlo.
2077
2078         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2079         calling sysctl over hw.activecpu
2080
2081 2014-04-30  Anders Carlsson  <andersca@apple.com>
2082
2083         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2084         https://bugs.webkit.org/show_bug.cgi?id=132399
2085         <rdar://problem/15920046>
2086
2087         Reviewed by Dan Bernstein.
2088
2089         * Scripts/check-for-webkit-framework-include-consistency:
2090         Allos WAK headers in WebKitLegacy as well as WebKit.
2091
2092         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2093         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2094         Update header imports.
2095
2096 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2097
2098         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2099         https://bugs.webkit.org/show_bug.cgi?id=131954
2100
2101         Reviewed by Darin Adler.
2102         
2103         WebKitTestRunner was adding application-specific information to crash reports
2104         to log the test path, but only in the web process. Fix it to also do this
2105         for the UI process, for both iOS and OS X.
2106         
2107         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2108         both iOS and OS X.
2109         
2110         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2111         a new TestController::platformWillRunTest() function on Mac and iOS.
2112         
2113         Also remove Xcode-added unit test junk from the project.
2114
2115         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2116         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2117         * WebKitTestRunner/TestController.cpp:
2118         (WTR::TestController::runTest):
2119         * WebKitTestRunner/TestController.h:
2120         * WebKitTestRunner/TestInvocation.cpp:
2121         (WTR::TestInvocation::url):
2122         * WebKitTestRunner/TestInvocation.h:
2123         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2124         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2125         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2126         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2127         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2128         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2129         (WTR::testPathFromURL):
2130         (WTR::setCrashReportApplicationSpecificInformationToURL):
2131         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2132         (WTR::TestController::platformWillRunTest):
2133         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2134         (WTR::TestController::platformWillRunTest):
2135         * WebKitTestRunner/ios/TestControllerIOS.mm:
2136         (WTR::TestController::platformWillRunTest):
2137         (WTR::TestController::setHidden):
2138         * WebKitTestRunner/mac/TestControllerMac.mm:
2139         (WTR::TestController::platformWillRunTest):
2140
2141 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2142
2143         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2144
2145         Reviewed by Tim Horton.
2146
2147         * DumpRenderTree/mac/DumpRenderTree.mm:
2148         (resetWebPreferencesToConsistentValues):
2149         (prepareConsistentTestingEnvironment):
2150
2151 2014-04-30  Anders Carlsson  <andersca@apple.com>
2152
2153         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2154         https://bugs.webkit.org/show_bug.cgi?id=132397
2155
2156         Reviewed by Dan Bernstein.
2157
2158         * Scripts/check-for-inappropriate-macros-in-external-headers:
2159
2160 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2161
2162         [GTK] Make it easier to run CMake for downstreams
2163         https://bugs.webkit.org/show_bug.cgi?id=132370
2164
2165         Reviewed by Carlos Garcia Campos.
2166
2167         * Scripts/webkitdirs.pm:
2168         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2169         the GTK+ port.
2170
2171 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2172
2173         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2174         
2175         Rubber stamped by Jessie Berlin.
2176
2177         JSON.pm was removed from our tools setup.
2178
2179         * Scripts/generate-coverage-data:
2180
2181 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2182
2183         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2184         https://bugs.webkit.org/show_bug.cgi?id=112840
2185
2186         Rubber stamped by Geoffrey Garen.
2187
2188         * Scripts/build-jsc: Enable it on Mac.
2189         * Scripts/build-webkit: Enable it on Mac.
2190         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2191
2192 2014-04-28  Sam Weinig  <sam@webkit.org>
2193
2194         REGRESSION (r167751): svn-create-patch is very slow
2195         https://bugs.webkit.org/show_bug.cgi?id=132300
2196
2197         Reviewed by Alexey Proskuryakov.
2198
2199         * Scripts/svn-create-patch:
2200         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2201         by calling `svn-create-patch --style`.
2202
2203 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2204
2205         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2206         https://bugs.webkit.org/show_bug.cgi?id=132190
2207
2208         Reviewed by Gustavo Noronha Silva.
2209
2210         * Scripts/webkitdirs.pm:
2211         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2212             if ninja is in the path.
2213         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2214             to the previous ninja generator if not.
2215
2216 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2217
2218         check-webkit-style should understand --git-index
2219         https://bugs.webkit.org/show_bug.cgi?id=125364
2220
2221         Reviewed by Csaba Osztrogonác.
2222
2223         * Scripts/webkitpy/common/checkout/scm/git.py:
2224         (Git.create_patch): The command now supports the --cached option.
2225         * Scripts/webkitpy/style/main.py:
2226         (CheckWebKitStyle.main): Passing the --git-index option.
2227         * Scripts/webkitpy/style/optparser.py:
2228         (CommandOptionValues.__init__): The git-index option is switched off by default.
2229         (CommandOptionValues.__eq__): Equality check for the new option.
2230         (ArgumentParser._create_option_parser):Adding the --git-index option
2231         (ArgumentParser.parse):
2232         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2233         (CommandOptionValuesTest.test_init): 
2234         (CommandOptionValuesTest.test_eq):
2235
2236 2014-04-28  Michael Saboff  <msaboff@apple.com>
2237
2238         Crash in platform/mac/accessibility/table-visible-rows.html
2239         https://bugs.webkit.org/show_bug.cgi?id=132146
2240
2241         Reviewed by Filip Pizlo.
2242
2243         Instead of creating a local JSValueRef array on the stack and passing that to
2244         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2245         values using the JSObjectSetPropertyAtIndex() API.
2246
2247         * DumpRenderTree/AccessibilityUIElement.cpp:
2248         (elementsForRangeCallback):
2249         (convertElementsToObjectArray):
2250         * DumpRenderTree/mac/TestRunnerMac.mm:
2251         (originsArrayToJS):
2252         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2253         (WTR::EventSendingController::contextClick):
2254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2255         (WTR::stringArrayToJS):
2256         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2257         (WTR::convertElementsToObjectArray):
2258
2259 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2260
2261         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2262         "no-cjit" runs force the old-school threshold.
2263
2264         Rubber stamped by Mark Hahnenberg.
2265
2266         * Scripts/run-jsc-stress-tests:
2267
2268 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2269
2270         [GTK] install-dependencies should also install ruby-json and ruby-highline
2271         https://bugs.webkit.org/show_bug.cgi?id=132292
2272
2273         Reviewed by Philippe Normand.
2274
2275         * gtk/install-dependencies: Install ruby json and highline packages.
2276
2277 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2278
2279         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2280         https://bugs.webkit.org/show_bug.cgi?id=132176
2281
2282         Reviewed by Gyuyoung Kim.
2283
2284         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2285         and turn off indexedDB feature until the sqlite implementation is introduced.
2286
2287         * Scripts/webkitperl/FeatureList.pm:
2288
2289 2014-04-25  James Craig  <jcraig@apple.com>
2290
2291         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2292         https://bugs.webkit.org/show_bug.cgi?id=132209
2293
2294         Reviewed by Daniel Bates.
2295
2296         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2297         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2298
2299         * Scripts/prepare-ChangeLog:
2300         (main): 
2301
2302 2014-04-25  Michael Saboff  <msaboff@apple.com>
2303
2304         Crash in platform/mac/accessibility/table-visible-rows.html
2305         https://bugs.webkit.org/show_bug.cgi?id=132146
2306
2307         Reviewed by Mark Lam.
2308
2309         Changed to use a local JSValueRef array temporary instead of a
2310         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2311         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2312         the temporary values could be collected.
2313
2314         * DumpRenderTree/AccessibilityUIElement.cpp:
2315         (convertElementsToObjectArray):
2316         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2317         (WTR::EventSendingController::contextClick):
2318         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2319         (WTR::convertElementsToObjectArray):
2320
2321 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2322
2323         Unreviewed GTK gardening
2324
2325         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2326         (TestRunner):
2327
2328 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2329
2330         prepare-ChangeLog reports as deleted methods that has not been removed.
2331         https://bugs.webkit.org/show_bug.cgi?id=131733
2332
2333         Reviewed by Ryosuke Niwa.
2334
2335         * Scripts/prepare-ChangeLog:
2336         (originalFile): Set merge base to origin/master by default.
2337
2338 2014-04-23  James Craig  <jcraig@apple.com>
2339
2340         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2341         https://bugs.webkit.org/show_bug.cgi?id=131115
2342
2343         Reviewed by Daniel Bates.
2344
2345         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2346
2347         * Scripts/commit-log-editor: Added --no-style.
2348         * Scripts/prepare-ChangeLog: Primary patch.
2349         (main): Primary patch.
2350         (createPatchCommand): Added --no-style.
2351         * Scripts/svn-create-patch: Primary patch.
2352         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2353         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2354         (SVN.create_patch): Added --no-style.
2355
2356 2014-04-23  Anders Carlsson  <andersca@apple.com>
2357
2358         Try to fix iOS build.
2359
2360         * DumpRenderTree/mac/DumpRenderTree.mm:
2361
2362 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2363
2364         Eliminate internals.setMockScrollbarsEnabled()
2365         https://bugs.webkit.org/show_bug.cgi?id=132085
2366
2367         Reviewed by Tim Horton.
2368
2369         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2370         No need to reset the preference, there is no way it can change.
2371
2372 2014-04-23  James Craig  <jcraig@apple.com>
2373
2374         Unreviewed. Moving myself from Contributors to Committers list.
2375
2376         * Scripts/webkitpy/common/config/contributors.json:
2377
2378 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2379
2380         Mock scrollbars don't always work in DumpRenderTree
2381         https://bugs.webkit.org/show_bug.cgi?id=132082
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (prepareConsistentTestingEnvironment):
2387         Set the mock scrollbar setting before creating the WebView, as this setting
2388         cannot be dynamically changed, so any scrollbars that are created during
2389         WebView initialization and are not replaced before snapshotting will end
2390         up being platform scrollbars instead of mock ones.
2391         WebKitTestRunner already sets this preference before creating WKViews,
2392         so we're just matching its behavior.
2393
2394 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2395
2396         [GTK] ShadowRoot API was removed in r164131
2397         https://bugs.webkit.org/show_bug.cgi?id=132059
2398
2399         Reviewed by Gustavo Noronha Silva.
2400
2401         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2402         the API docs.
2403
2404         * gtk/webkitdom.py:
2405         (WebKitDOMDocGenerator):
2406
2407 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2408
2409         [GTK] run-webkit-tests script is failing to invoke run-launcher
2410         https://bugs.webkit.org/show_bug.cgi?id=132051
2411
2412         Reviewed by Philippe Normand.
2413
2414         After the WK1 support was dropped, if run-webkit-tests is executed
2415         without --no-show-results parameter, the launcher is being called
2416         using a -2 parameter that is it causing the run-launcher to break.
2417
2418         * Scripts/webkitpy/port/gtk.py:
2419         (GtkPort.show_results_html_file):
2420
2421 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2422
2423         DumpRenderTree generates black snapshots on some platforms
2424         https://bugs.webkit.org/show_bug.cgi?id=132029
2425         <rdar://problem/16679363>
2426
2427         Reviewed by Simon Fraser.
2428
2429         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2430         (createBitmapContextFromWebView):
2431         DRT checks with the WebView to determine whether it can use the window's
2432         backing store directly or (because of compositing) needs to take a WindowServer
2433         snapshot. However, on some platforms and in some situations, the window can
2434         be layer backed without the WebView necessarily currently being composited.
2435         We should check with the window in addition to the WebView before going
2436         ahead and using its backing store.
2437
2438 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2439
2440         DumpRenderTree generates white snapshots on some platforms
2441         https://bugs.webkit.org/show_bug.cgi?id=132026
2442         <rdar://problem/16679363>
2443
2444         Reviewed by Simon Fraser.
2445
2446         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2447         Link DRT against QuartzCore.
2448
2449         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2450         (createBitmapContextFromWebView):
2451         Force CoreAnimation to synchronously update layers in a more explicit
2452         way that doesn't depend on AppKit behavior. This is very similar to what
2453         WebKitTestRunner does (indirectly) during its force repaint.
2454
2455 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2456
2457         [Win] Support Python 2.7 in Cygwin
2458         https://bugs.webkit.org/show_bug.cgi?id=132023
2459
2460         Reviewed by Michael Saboff.
2461
2462         * Scripts/webkitdirs.pm:
2463         (checkInstalledTools): Remove check for Python 2.7, since
2464         it now works properly.
2465
2466 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2467
2468         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2469         https://bugs.webkit.org/show_bug.cgi?id=130867
2470         <rdar://problem/16432456> 
2471
2472         Reviewed by Mark Hahnenberg.
2473
2474         * Scripts/build-webkit:
2475         * Scripts/copy-webkitlibraries-to-product-directory:
2476
2477 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2478
2479         [GTK] Fails to build documentation when output is redirected
2480         https://bugs.webkit.org/show_bug.cgi?id=131178
2481
2482         Reviewed by Martin Robinson.
2483
2484         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2485         explicitly to avoid encoding issues when they are redirected.
2486
2487 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2488
2489         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2490         https://bugs.webkit.org/show_bug.cgi?id=131911
2491
2492         Reviewed by Martin Robinson.
2493
2494         common.get_build_path returns release path even though Debug configuration
2495         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2496
2497         * gtk/ycm_extra_conf.py:
2498         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2499         (FlagsForFile):
2500
2501 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2502
2503         Unreviewed build fix.
2504
2505         * DumpRenderTree/mac/EventSendingController.mm:
2506         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2507         Correct a typo that prevented tests from working properly.
2508
2509 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2510
2511         [GTK] Should have the ability to output composited contents during layout testing
2512         https://bugs.webkit.org/show_bug.cgi?id=131864
2513
2514         Reviewed by Philippe Normand.
2515
2516         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2517         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2518         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2519         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2520         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2521
2522 2014-04-21  Sam Weinig  <sam@webkit.org>
2523
2524         Attempt to fix the tests.
2525
2526         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2527         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2528         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2529
2530 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2531
2532         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2533         being the same as a "quick run", which is meant for genuinely slow tests).
2534
2535         * Scripts/run-jsc-stress-tests:
2536
2537 2014-04-21  Darin Adler  <darin@apple.com>
2538
2539         Add HashSet::takeAny
2540         https://bugs.webkit.org/show_bug.cgi?id=131928
2541
2542         Reviewed by Benjamin Poulain.
2543
2544         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2545
2546 2014-04-20  Dan Bernstein  <mitz@apple.com>
2547
2548         Fixed a test timing out after r167572.
2549
2550         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2551         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2552         -webView:didFinishLoadingNavigation:.
2553
2554 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2555
2556         Unreviewed, rolling out r167510.
2557         https://bugs.webkit.org/show_bug.cgi?id=131915
2558
2559         broke GTK Debug bot (Requested by philn on #webkit).
2560
2561         Reverted changeset:
2562
2563         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2564         it when running layout tests"
2565         https://bugs.webkit.org/show_bug.cgi?id=131472
2566         http://trac.webkit.org/changeset/167510
2567
2568 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2569
2570         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2571         https://bugs.webkit.org/show_bug.cgi?id=131472
2572
2573         Reviewed by Philippe Normand.
2574
2575         * Scripts/webkitpy/port/gtk.py:
2576         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2577         when running WebKitTestRunner with run-webkit-tests.
2578         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2579         installed.
2580         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2581         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2582         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2583         deal.
2584
2585 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2586
2587         DownloadDecideDestinationCrash API test uses an incorrect value for path
2588         https://bugs.webkit.org/show_bug.cgi?id=131845
2589         <rdar://problem/15925560>
2590
2591         Reviewed by Enrica Casucci.
2592
2593         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2594         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2595
2596 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2597
2598         [Mac] AttributedStringTest API tests fail with async text input
2599         https://bugs.webkit.org/show_bug.cgi?id=131833
2600
2601         Reviewed by Enrica Casucci.
2602
2603         Don't run sync NSTextInputClient tests where we don't implement these calls.
2604
2605         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2606         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2607         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2608         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2609         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2610         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2611         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2612
2613 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2614
2615         Remove NETWORK_INFO support
2616         https://bugs.webkit.org/show_bug.cgi?id=131841
2617
2618         Reviewed by Gyuyoung Kim.
2619
2620         * Scripts/webkitperl/FeatureList.pm:
2621
2622 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2623
2624         [GTK] YouCompleteMe doesn't work for cmake build system.
2625         https://bugs.webkit.org/show_bug.cgi?id=131591
2626
2627         Reviewed by Martin Robinson.
2628
2629         Add cmake build system support for YouCompleteMe. It should work regardless of
2630         using make or ninja. In addition, autotools related code is removed since it's
2631         not used anymore in WebKit.
2632
2633         * Scripts/webkitdirs.pm:
2634         (generateBuildSystemFromCMakeProject):
2635         * gtk/ycm_extra_conf.py:
2636         (transform_relative_paths_to_absolute_paths):
2637         (FlagsForFile):
2638
2639 2014-04-17  Anders Carlsson  <andersca@apple.com>
2640
2641         Fix build.
2642
2643         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2644         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2645         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2646
2647 2014-04-17  Anders Carlsson  <andersca@apple.com>
2648
2649         Remove unused API enums
2650         https://bugs.webkit.org/show_bug.cgi?id=131836
2651
2652         Reviewed by Tim Horton.
2653
2654         * MiniBrowser/mac/WK2BrowserWindowController.m:
2655         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2656
2657 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2658
2659         [Win] A few final cleanups to the DataObject classes.
2660         https://bugs.webkit.org/show_bug.cgi?id=131784
2661
2662         Reviewed by Anders Carlsson.
2663
2664         * DumpRenderTree/win/DRTDataObject.cpp:
2665         (DRTDataObject::clearData): Use 'last()' method.
2666         * DumpRenderTree/win/UIDelegate.cpp:
2667         (DRTUndoStack::pop): Use 'takeLast()' method.
2668
2669 2014-04-17  Andres Gomez  <agomez@igalia.com>
2670
2671         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2672         https://bugs.webkit.org/show_bug.cgi?id=131365
2673
2674         Reviewed by Brent Fulgham.
2675
2676         The cygwin installer is now downloading the wanted versions for
2677         the local installation given to the setup wizard.
2678
2679         * CygwinDownloader/cygwin-downloader.py:
2680         * CygwinDownloader/cygwin-downloader.zip:
2681
2682 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2683
2684         [GTK] Make run-webkit-tests always use WKTR
2685         https://bugs.webkit.org/show_bug.cgi?id=131737
2686
2687         Reviewed by Darin Adler.
2688
2689         Now that the GTK+ port only has support for WebKit2, instruct
2690         run-webkit-tests to always use WKTR. This avoids needing to pass
2691         flag "-2" every time.
2692
2693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2694         (_set_up_derived_options): Always set webkit_test_runner when
2695         the platform is GTK+.
2696
2697 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2698
2699         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2700         https://bugs.webkit.org/show_bug.cgi?id=131760
2701
2702         Reviewed by Philippe Normand.
2703
2704         * gtk/install-dependencies: Install ninja-build when it's available.
2705
2706 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2707
2708         [Win] run-javascriptcore-tests fails to run.
2709         https://bugs.webkit.org/show_bug.cgi?id=131761
2710
2711         Reviewed by Brent Fulgham.
2712
2713         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2714
2715 2014-04-16  Andres Gomez  <agomez@igalia.com>
2716
2717         [Win] Pass default parameters to cygwin setup wizard
2718         https://bugs.webkit.org/show_bug.cgi?id=131361
2719
2720         Reviewed by Brent Fulgham.
2721
2722         Added some parameters to the cygwin setup wizard so the user
2723         doesn't really have to do any interaction.
2724
2725         * CygwinDownloader/cygwin-downloader.py:
2726         * CygwinDownloader/cygwin-downloader.zip:
2727
2728 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2729
2730         [Win] Eliminate use of deleteAllValues in Windows Files
2731         https://bugs.webkit.org/show_bug.cgi?id=131631
2732
2733         Reviewed by Darin Adler.
2734
2735         Switch to std::unique_ptr for memory lifetime. Get rid of
2736         deleteAllValues now that it is no longer needed. Use ranged
2737         for loops where possible.
2738
2739         * DumpRenderTree/win/DRTDataObject.cpp:
2740         (WCEnumFormatEtc::WCEnumFormatEtc):
2741         (DRTDataObject::~DRTDataObject):
2742         (DRTDataObject::GetData):
2743         (DRTDataObject::QueryGetData):
2744         (DRTDataObject::SetData):
2745         (DRTDataObject::clearData):
2746         * DumpRenderTree/win/DRTDataObject.h:
2747         * DumpRenderTree/win/UIDelegate.cpp:
2748         (DRTUndoObject::DRTUndoObject):
2749         (DRTUndoObject::~DRTUndoObject):
2750         (DRTUndoStack::~DRTUndoStack):
2751         (DRTUndoStack::clear):
2752         (DRTUndoStack::pop):
2753         (DRTUndoManager::DRTUndoManager):
2754         (DRTUndoManager::redo):
2755         (DRTUndoManager::undo):
2756         (UIDelegate::UIDelegate):
2757         (UIDelegate::resetUndoManager):
2758         * DumpRenderTree/win/UIDelegate.h:
2759
2760 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2761
2762         [GTK] Unreviewed GTK gardening.
2763
2764         Update list of skipped unit tests:
2765
2766           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2767
2768           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2769           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2770
2771         * Scripts/run-gtk-tests:
2772         (TestRunner):
2773
2774 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2775
2776         check-webkit-style doesn't check code style in .mm or .m files
2777         https://bugs.webkit.org/show_bug.cgi?id=131708
2778
2779         Reviewed by Darin Adler.
2780
2781         * Scripts/webkitpy/style/checker.py:
2782         * Scripts/webkitpy/style/checker_unittest.py:
2783         (CheckerDispatcherDispatchTest.test_cpp_paths):
2784         (CheckerDispatcherDispatchTest.test_text_paths):
2785         Check .mm and .m files as C++.
2786
2787         * Scripts/webkitpy/style/checkers/cpp.py:
2788         (check_spacing):
2789         Add an override for our ordinary "missing spaces around =" for @synthesize,
2790         which should look like "@synthesize propertyName=_varName;"
2791
2792         Add an override for "missing space before {" for blocks' "^{".
2793
2794         Don't follow the "extra space before [" rule for Objective-C, because
2795         it breaks this rule in a multitude of ways because of method calls.
2796
2797         (check_braces):
2798         Don't complain about { not being on the end of the previous line if
2799         the previous line starts with "- (" or "+ (", which would indicate a
2800         Objective-C method definition.
2801
2802 2014-04-16  Darin Adler  <darin@apple.com>
2803
2804         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2805         https://bugs.webkit.org/show_bug.cgi?id=131735
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2810         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2811         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2812         way, but gtest works better this way.
2813
2814 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2815
2816         [EFL] Fix problems with the pixel dump.
2817         https://bugs.webkit.org/show_bug.cgi?id=131265
2818
2819         Reviewed by Gyuyoung Kim.
2820
2821         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2822         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2823         which causes that nothing is drawn.
2824
2825         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2826         One of new functions is AcceleratedCompositingContext::extractImageData(),
2827         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2828         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2829
2830         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2831         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2832
2833 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2834
2835         Update LLVM export scrpt to handle the build directory being different from the
2836         source directory.
2837
2838         Rubber stamped by Geoffrey Garen.
2839
2840         * Scripts/export-llvm-build:
2841
2842 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2843
2844         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2845         https://bugs.webkit.org/show_bug.cgi?id=131695
2846
2847         Reviewed by Antti Koivisto.
2848
2849         Updated.
2850
2851         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2852
2853 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         [GTK] Reduce the binary size by compressing the text based web inspector resources
2856         https://bugs.webkit.org/show_bug.cgi?id=121545
2857
2858         Reviewed by Gustavo Noronha Silva.
2859
2860         Compress text based files when compiling inspector resources. It
2861         reduces the binary size in 3MB.
2862
2863         * gtk/generate-inspector-gresource-manifest.py:
2864         (find_all_files_in_directory):
2865         (is_compressible):
2866
2867 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2868
2869         Remove Gtk WebKit1 tester.
2870
2871         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2872         results over and over as fast as it could.
2873
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2875         (WebKitBuildbot):
2876
2877 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2878
2879         Wrong link for webkitpy tests results in dashboard popover
2880         https://bugs.webkit.org/show_bug.cgi?id=131664
2881
2882         Reviewed by Timothy Hatcher.
2883
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2885         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2886         Use a correct link.
2887
2888 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2889
2890         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2891
2892         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2893
2894         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2895         (CommitMessageForThisCommitTest):
2896
2897 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2898
2899         Fix commit-log-editor bug revealed by r165447
2900         https://bugs.webkit.org/show_bug.cgi?id=130676
2901
2902         Reviewed by Csaba Osztrogonác.
2903
2904         * Scripts/commit-log-editor:
2905         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2906         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2907         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2908         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2909
2910 2014-04-13  Darin Adler  <darin@apple.com>
2911
2912         userVisibleString should not try to "encode" host names
2913         https://bugs.webkit.org/show_bug.cgi?id=131587
2914         rdar://problem/14686849
2915
2916         Reviewed by Alexey Proskuryakov.
2917
2918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2919
2920         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2921         Coverage is tiny at this point; we could add a lot more cases!
2922
2923 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2924
2925         Use #include instead of #import
2926         https://bugs.webkit.org/show_bug.cgi?id=131604
2927
2928         Reviewed by Darin Adler.
2929
2930         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2931
2932         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2933
2934 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2935
2936         Make slow-stress tests run faster by running fewer VM variants.
2937
2938         Rubber stamped by Geoffrey Garen.
2939
2940         * Scripts/run-javascriptcore-tests:
2941         * Scripts/run-jsc-stress-tests:
2942
2943 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2944
2945         [CMake] Add missing WTF unit tests
2946         https://bugs.webkit.org/show_bug.cgi?id=131459
2947
2948         Reviewed by Martin Robinson.
2949
2950         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2951         that should be compiled into the TestWTF binary.
2952
2953 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2954
2955         [Gtk] run-launcher doesn't work by default
2956         https://bugs.webkit.org/show_bug.cgi?id=131494
2957
2958         Reviewed by Philippe Normand.
2959
2960         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2961         * Scripts/webkitdirs.pm:
2962         (launcherName): Same.
2963         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2964         * gtk/common.py:
2965         (get_build_path.is_valid_build_directory): Same.
2966         * gtk/manifest.txt: Same.
2967
2968 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2969
2970         Unreviewed, rolling out r167046.
2971         https://bugs.webkit.org/show_bug.cgi?id=131479
2972
2973         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2974         on #webkit).
2975
2976         Reverted changeset:
2977
2978         "Remove "System Font" from whitelisted DRT fonts and char
2979         width calculations"
2980         https://bugs.webkit.org/show_bug.cgi?id=131411
2981         http://trac.webkit.org/changeset/167046
2982
2983 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2984
2985         Remove "System Font" from whitelisted DRT fonts and char width calculations
2986         https://bugs.webkit.org/show_bug.cgi?id=131411
2987
2988         Reviewed by Tim Horton.
2989
2990         Covered by existing tests.
2991
2992         * DumpRenderTree/mac/DumpRenderTree.mm:
2993         (allowedFontFamilySet):
2994
2995 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2996
2997         systemHiddenFontFamilySet in DRT is unnecessary
2998         https://bugs.webkit.org/show_bug.cgi?id=131414
2999
3000         Reviewed by Tim Horton.
3001
3002         It doesn't seem to affect test results on my machine.
3003
3004         * DumpRenderTree/mac/DumpRenderTree.mm:
3005         (drt_NSFontManager_availableFonts):
3006         (systemHiddenFontFamilySet): Deleted.
3007
3008 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3009
3010         [Win] Unreviewed test fix: Don't double-release BSTR.
3011
3012         * DumpRenderTree/win/DumpRenderTree.cpp:
3013         (dump): Remove unneeded call to SysFreeString now that we are
3014         using _bstr_t for this variable.
3015
3016 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3017
3018         [Win] Various DumpRenderTree Fixes.
3019         https://bugs.webkit.org/show_bug.cgi?id=131446.
3020
3021         Reviewed by Tim Horton.
3022
3023         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3024         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3025         (AccessibilityUIElement::description): Ditto.
3026         (AccessibilityUIElement::helpText): Ditto.
3027         (AccessibilityUIElement::intValue): Ditto.
3028         (AccessibilityUIElement::isPressActionSupported): Ditto.
3029         (AccessibilityUIElement::accessibilityValue): Ditto.
3030         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3031         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3032         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3033         (DRTDesktopNotificationPresenter::Release): Ditto.
3034         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3035         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3036         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3037         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3038         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3039         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3040         * DumpRenderTree/win/DumpRenderTree.cpp:
3041         (dumpFrameScrollPosition): Ditto.
3042         (dumpFramesAsText): Ditto.
3043         (compareHistoryItems): Ditto.
3044         (dumpHistoryItem): Ditto.
3045         (dump): Ditto.
3046         (resetDefaultsToConsistentValues): Ditto.
3047         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3048         (runTest): Ditto.
3049         (createWebViewAndOffscreenWindow): Ditto.
3050         * DumpRenderTree/win/EditingDelegate.cpp:
3051         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3052         (EditingDelegate::AddRef): Ditto.
3053         (EditingDelegate::Release): Ditto.
3054         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3055         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3056         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3057         (EditingDelegate::shouldInsertNode): Ditto.
3058         (EditingDelegate::shouldInsertText): Ditto.
3059         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3060         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3061         (EditingDelegate::shouldApplyStyle): Ditto.
3062         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3063         (EditingDelegate::doPlatformCommand): Ditto.
3064         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3065         (EditingDelegate::webViewDidChange): Ditto.
3066         (EditingDelegate::webViewDidEndEditing): Ditto.
3067         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3068         (EditingDelegate::webViewDidChangeSelection): Ditto.
3069         (EditingDelegate::checkSpellingOfString): Ditto.
3070         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3071         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3072         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3073         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3074         (FrameLoadDelegate::AddRef): Ditto.
3075         (FrameLoadDelegate::Release): Ditto.
3076         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3077         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3078         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3079         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3080         (FrameLoadDelegate::didReceiveTitle): Ditto.
3081         (FrameLoadDelegate::didChangeIcons): Ditto.
3082         (delegatesWithDelayedWork): Ditto.
3083         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3084         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3085         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3086         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3087         (FrameLoadDelegate::willCloseFrame): Ditto.
3088         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3089         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3090         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3091         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3092         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3093         * DumpRenderTree/win/FrameLoadDelegate.h:
3094         * DumpRenderTree/win/HistoryDelegate.cpp:
3095         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3096         (HistoryDelegate::updateHistoryTitle): Ditto.
3097         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3098         * DumpRenderTree/win/PolicyDelegate.cpp:
3099         (dumpPath):
3100         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3101         (PolicyDelegate::AddRef): Ditto.
3102         (PolicyDelegate::Release): Ditto.
3103         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3104         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3105         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3106         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3107         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3108         (ResourceLoadDelegate::AddRef): Ditto.
3109         (ResourceLoadDelegate::Release): Ditto.
3110         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3111         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3112         (ResourceLoadDelegate::willSendRequest): Ditto.
3113         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3114         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3115         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3116         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3117         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3118         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3119         (TestRunner::setUserStyleSheetLocation): Ditto.
3120         (TestRunner::execCommand): Ditto.
3121         (TestRunner::overridePreference): Ditto.
3122         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3123         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3124         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3125         (TextInputController::insertText): Ditto.
3126         * DumpRenderTree/win/UIDelegate.cpp:
3127         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3128         (UIDelegate::AddRef): Ditto.
3129         (UIDelegate::Release): Ditto.
3130         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3131         (UIDelegate::trackCustomPopupMenu): Ditto.
3132         (UIDelegate::registerUndoWithTarget): Ditto.
3133         (UIDelegate::removeAllActionsWithTarget): Ditto.
3134         (UIDelegate::setActionTitle): Ditto.
3135         (UIDelegate::undo): Ditto.
3136         (UIDelegate::redo): Ditto.
3137         (UIDelegate::canUndo): Ditto.
3138         (UIDelegate::canRedo): Ditto.
3139         (UIDelegate::printFrame): Ditto.
3140         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3141         (UIDelegate::webViewHeaderHeight): Ditto.
3142         (UIDelegate::webViewFooterHeight): Ditto.
3143         (UIDelegate::drawHeaderInRect): Ditto.
3144         (UIDelegate::drawFooterInRect): Ditto.
3145         (UIDelegate::webViewPrintingMarginRect): Ditto.
3146         (UIDelegate::canRunModal): Ditto.
3147         (UIDelegate::createModalDialog): Ditto.
3148         (UIDelegate::runModal): Ditto.
3149         (UIDelegate::isMenuBarVisible): Ditto.
3150         (UIDelegate::setMenuBarVisible): Ditto.
3151         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3152         (UIDelegate::paintCustomScrollbar): Ditto.
3153         (UIDelegate::paintCustomScrollCorner): Ditto.
3154         (UIDelegate::setFrame): Ditto.
3155         (UIDelegate::webViewFrame): Ditto.
3156         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3157         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3158         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3159         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3160         (UIDelegate::webViewAddMessageToConsole): Ditto.
3161         (UIDelegate::doDragDrop): Ditto.
3162         (UIDelegate::webViewGetDlgCode): Ditto.
3163         (UIDelegate::createWebViewWithRequest): Ditto.
3164         (UIDelegate::webViewClose): Ditto.
3165         (UIDelegate::webViewFocus): Ditto.
3166         (UIDelegate::webViewUnfocus): Ditto.
3167         (UIDelegate::webViewPainted): Ditto.
3168         (UIDelegate::exceededDatabaseQuota): Ditto.
3169         (UIDelegate::embeddedViewWithArguments): Ditto.
3170         (UIDelegate::webViewClosing): Ditto.
3171         (UIDelegate::webViewSetCursor): Ditto.
3172         (UIDelegate::webViewDidInvalidate): Ditto.
3173         (UIDelegate::setStatusText): Ditto.
3174         (UIDelegate::desktopNotificationsDelegate): Ditto.
3175         (UIDelegate::drawBackground): Ditto.
3176         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3177         (UIDelegate::didPressMissingPluginButton): Ditto.
3178         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3179         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3180         (LoadHTMLStringItem::invoke): Ditto.
3181         (ScriptItem::invoke): Ditto.
3182
3183 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3184
3185         Stylechecker: False positive on inline asm code.
3186         https://bugs.webkit.org/show_bug.cgi?id=130570
3187
3188         Reviewed by Csaba Osztrogonác.
3189
3190         Disable stylechecking in asm blocks.
3191
3192         * Scripts/webkitpy/style/checkers/cpp.py:
3193         (process_line):
3194         (_InlineASMState):
3195         (_InlineASMState.__init__):
3196         (_InlineASMState.process_line):
3197         (_InlineASMState.isInside):
3198         (_process_lines):
3199         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3200         (WebKitStyleTest.test_member_initialization_list):
3201
3202 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3203
3204         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3205         https://bugs.webkit.org/show_bug.cgi?id=131029
3206
3207         Reviewed by Philippe Normand.
3208
3209         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3210         tests and remove the getWebKit1TestResoucesDir() method.
3211
3212         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3213         (testDownloadLocalFile): Use Test::getResourcesDir().
3214         (testDownloadLocalFileError): Ditto.
3215         (serverCallback): Ditto.
3216         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3217         (serverCallback): Ditto.
3218         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3219         (httpServerCallback): Ditto.
3220         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3221         (serverCallback): Ditto.
3222         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3223         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3224         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3225         (Test::getWebKit1TestResoucesDir): Deleted.
3226
3227 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3228
3229         [WK2] HTTP authentication regression tests fail
3230         https://bugs.webkit.org/show_bug.cgi?id=81627
3231         <rdar://problem/11079296>
3232
3233         Reviewed by Anders Carlsson.
3234
3235         * WebKitTestRunner/TestController.h:
3236         * WebKitTestRunner/TestController.cpp:
3237         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3238         to pageLoaderClient structure.
3239         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3240         for password based authentication (we do get server trust challenges on some tests,
3241         which WKTR can't handle).
3242         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3243         calls won't be made, at least on CFNetwork based platforms.
3244         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3245         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3246         make sense to associate auth requests with individual resources - there can be
3247         multiple resources loading at once from the same protection space, so WebKit1 API
3248         that had a resource identifier was inherently racy.
3249
3250 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3251
3252         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3253         https://bugs.webkit.org/show_bug.cgi?id=131427
3254
3255         Reviewed by Gyuyoung Kim.
3256
3257         Since r166973, font path was changed.
3258
3259         * DumpRenderTree/PlatformEfl.cmake:
3260         * WebKitTestRunner/PlatformEfl.cmake:
3261
3262 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3263
3264         Fix the build-jsc build
3265         https://bugs.webkit.org/show_bug.cgi?id=131410
3266
3267         Reviewed by Michael Saboff.
3268
3269         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3270         WTF depends on it.
3271
3272 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3273
3274         [GTK] Remove WebKit1 unit tests
3275         https://bugs.webkit.org/show_bug.cgi?id=131359
3276
3277         Reviewed by Anders Carlsson.
3278
3279         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3280         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3281         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3282
3283         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3284         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3285         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3286         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3287         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3288         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3289         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3290         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3291         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3292         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3293         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3294         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3295         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3296         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3297         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3298         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3299         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3300         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3301         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3302         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3303         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3304         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3305         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3306         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3307         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3308         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3309         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3310         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3311         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3312         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3313         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3314         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3315         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3316         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3317         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3318         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3319         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3320         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3321
3322 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3323
3324         Unreviewed gardening (Take 2): Prevent users from attempting
3325         to build with known invalid cURL. 
3326
3327         * Scripts/webkitdirs.pm:
3328         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3329         7.33.0 (the known good version).
3330
3331 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3332
3333         [GTK] Remove DumpRenderTree and GtkLauncher
3334         https://bugs.webkit.org/show_bug.cgi?id=131373
3335
3336         Reviewed by Andreas Kling.
3337
3338         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3339         no longer necessary now that WebKit1 GTK+ will be removed.
3340
3341         * CMakeLists.txt:
3342         * DumpRenderTree/PlatformGTK.cmake: Removed.
3343         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3344         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3345         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3346         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3347         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3348         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3349         * DumpRenderTree/gtk/EventSender.h: Removed.
3350         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3351         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3352         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3353         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3354         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3355         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3356         * DumpRenderTree/gtk/TextInputController.h: Removed.
3357         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3358         * GtkLauncher/CMakeLists.txt: Removed.
3359         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3360         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3361         * GtkLauncher/main.c: Removed.
3362         * GtkLauncher/simple.svg: Removed.
3363         * GtkLauncher/text.html: Removed.
3364         * WebKitTestRunner/PlatformGTK.cmake:
3365         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3366         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3367         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3368
3369 2014-04-08  Mark Rowe  <mrowe@apple.com>
3370
3371         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3372         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3373
3374         Reviewed by Alexey Proskuryakov.
3375
3376         * Scripts/webkitdirs.pm:
3377         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3378         (execMacWebKitAppForDebugging): Ditto.
3379
3380 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3381
3382         Build bmalloc on iOS too
3383         https://bugs.webkit.org/show_bug.cgi?id=131381
3384
3385         Reviewed by Andreas Kling.
3386
3387         * Scripts/build-webkit:
3388
3389 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3390
3391         Unreviewed gardening: Prevent users from attempting
3392         to build with known invalid cURL.
3393
3394         * Scripts/webkitdirs.pm:
3395         (checkInstalledTools): Block build attempts with bad
3396         Cygwin tool set.
3397
3398 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3399
3400         Build bmalloc on Mac
3401         https://bugs.webkit.org/show_bug.cgi?id=131333
3402
3403         Reviewed by Mark Rowe.
3404
3405         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3406         (Note: Just testing Mac is not good enough because in this
3407         script 'Mac' means 'Mac or iOS'.)
3408
3409 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3410
3411         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3412         https://bugs.webkit.org/show_bug.cgi?id=130951
3413
3414         Reviewed by Geoffrey Garen.
3415
3416         * Scripts/run-javascriptcore-tests:
3417
3418 2014-04-06  Darin Adler  <darin@apple.com>
3419
3420         Rework CSS calc logic, fixing some reference count mistakes in Length
3421         https://bugs.webkit.org/show_bug.cgi?id=131280
3422
3423         Reviewed by Andreas Kling.
3424
3425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3426         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3427
3428 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3429
3430         Enable WEB_REPLAY for PLATFORM(MAC)
3431         https://bugs.webkit.org/show_bug.cgi?id=130700
3432
3433         Reviewed by Timothy Hatcher.
3434
3435         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3436
3437 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3438
3439         [CMake] Include X11's include dirs in TestNetscapePlugin
3440         https://bugs.webkit.org/show_bug.cgi?id=131270
3441
3442         Reviewed by Martin Robinson.
3443
3444         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3445         TestNetscapePlugin includes WebCore code that includes X headers.
3446
3447 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3448
3449         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3450         <http://webkit.org/b/130986>
3451
3452         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3453         prefix to TileCache class names in exception list.
3454
3455 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3456
3457         [GTK] kill-old-processes should kill dbus-daemon processes
3458         https://bugs.webkit.org/show_bug.cgi?id=127352
3459
3460         Reviewed by Martin Robinson.
3461
3462         * BuildSlaveSupport/kill-old-processes:
3463         (main):
3464
3465 2014-04-04  Andres Gomez  <agomez@igalia.com>
3466
3467         [Win] Update obsolete packages in cygwin
3468         https://bugs.webkit.org/show_bug.cgi?id=126264
3469
3470         Reviewed by Brent Fulgham.
3471
3472         Removed "apache" and "minires" as the first has been replaced by
3473         "lighttpd" and the second is now integrated into
3474         "cygwin". Replaced the transitional and now obsolete "gcc" package
3475         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3476         since the newer version available is "2.7.3" which breaks the
3477         build due to some funniness with environment variable handling.
3478
3479         * CygwinDownloader/cygwin-downloader.py:
3480         * CygwinDownloader/cygwin-downloader.zip:
3481
3482 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3483
3484         check-webkit-style: Improve warnings on Objective-C @property syntax
3485         https://bugs.webkit.org/show_bug.cgi?id=131200
3486
3487         Reviewed by Dan Bernstein.
3488
3489         * Scripts/webkitpy/style/checkers/cpp.py:
3490         (check_spacing):
3491         (CppChecker):
3492         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3493         (CppStyleTest.test_spacing_in_objective_c_properties):
3494
3495 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3496
3497         Unreviewed. Moving my name to commiter section
3498
3499         * Scripts/webkitpy/common/config/contributors.json:
3500
3501 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3502
3503         Unreviewed. Add myself as a committer.
3504
3505         * Scripts/webkitpy/common/config/contributors.json:
3506
3507 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3508
3509         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3510         https://bugs.webkit.org/show_bug.cgi?id=130391
3511
3512         Reviewed by Gyuyoung Kim.
3513
3514         Change the implementation of the zoom functionality from ewk_view_scale_set
3515         to ewk_view_page_zoom_set.
3516
3517         * MiniBrowser/efl/main.c:
3518
3519 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3520
3521         [webkitpy] perf profiler does not understand --call-graph argument
3522         https://bugs.webkit.org/show_bug.cgi?id=131132
3523
3524         Reviewed by Ryosuke Niwa.
3525
3526         New versions of perf profiler have changed the argument from --call-graph to -g.
3527
3528         * Scripts/webkitpy/common/system/profiler.py:
3529         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3530         * Scripts/webkitpy/port/driver_unittest.py:
3531         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3532
3533 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3534
3535         Add EFL WK2 performance bot to build.webkit.org
3536         https://bugs.webkit.org/show_bug.cgi?id=131034
3537
3538         Fix after r166707, use "Perf" instead of "perf" for consistency.
3539
3540         Reviewed by Csaba Osztrogonác.
3541
3542         * BuildSlaveSupport/build.webkit.org-config/config.json:
3543
3544 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3545
3546         Add EFL WK2 performance bot to build.webkit.org
3547         https://bugs.webkit.org/show_bug.cgi?id=131034
3548
3549         Reviewed by Csaba Osztrogonác.
3550
3551         * BuildSlaveSupport/build.webkit.org-config/config.json:
3552
3553 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3554
3555         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3556         https://bugs.webkit.org/show_bug.cgi?id=131151
3557
3558         Reviewed by Gyuyoung Kim.
3559
3560         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3561         (TouchEventInfo::TouchEventInfo):
3562         (sendTouchEvent):
3563         (addTouchPointCallback):
3564         (updateTouchPointCallback):
3565         (cancelTouchPointCallback):
3566         (releaseTouchPointCallback):
3567
3568 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3569
3570         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3571         <http://webkit.org/b/131045>
3572
3573         Reviewed by Daniel Bates.
3574
3575         * Scripts/filter-build-webkit:
3576         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3577         of clang, plus debug data for all DVTAssertions.
3578
3579 2014-04-01  Dean Jackson  <dino@apple.com>
3580
3581         Load Media Controls js/css from bundle
3582         https://bugs.webkit.org/show_bug.cgi?id=131086
3583
3584         Reviewed by Eric Carlson.
3585
3586         We're now putting CSS files into the bundle, so remove the test for them.
3587
3588         * Scripts/check-for-inappropriate-files-in-framework:
3589
3590 2014-04-02  Martin Hock  <mhock@apple.com>
3591
3592         Unify private browsing with sessions.
3593         https://bugs.webkit.org/show_bug.cgi?id=130099
3594
3595         Reviewed by Alexey Proskuryakov.
3596
3597         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3599         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3600         (TestWebKitAPI::didNavigateWithNavigationData):
3601         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3602         (TestWebKitAPI::TEST):
3603
3604         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3605         (TestWebKitAPI::didNavigateWithoutNavigationData):
3606         (TestWebKitAPI::didNavigateWithNavigationData):
3607         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3608         (TestWebKitAPI::TEST):
3609
3610 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3611
3612         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3613         https://bugs.webkit.org/show_bug.cgi?id=130343
3614
3615         Reviewed by Gustavo Noronha Silva.
3616
3617         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3618         of directories on the command line and look for all appropriate files in those directories for the
3619         GResource archive. Also make archive paths relative to those directories.
3620         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3621         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3622
3623 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3624
3625         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3626         https://bugs.webkit.org/show_bug.cgi?id=131106
3627
3628         Reviewed by Csaba Osztrogonác.
3629
3630         * Scripts/webkitpy/tool/commands/download.py:
3631         (AbstractRolloutPrepCommand._prepare_state):
3632         * Scripts/webkitpy/tool/commands/download_unittest.py:
3633         (test_prepare_rollout):
3634         (test_create_rollout):
3635         (test_create_rollout_resolved):
3636         (test_rollout):
3637
3638 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3639
3640         [EFL] Add option to use separate web process for new window in MiniBrowser
3641         https://bugs.webkit.org/show_bug.cgi?id=130190
3642
3643         Reviewed by Gyuyoung Kim.
3644
3645         New created window (CTRL + n) will be open in separated web process.
3646         This option is enabled by adding a flag (S/separate-process) with launching
3647         MiniBrowser.
3648
3649         * MiniBrowser/efl/main.c:
3650         (elm_main):
3651
3652 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3653