Add a way to check if a host is an IP address
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Add a way to check if a host is an IP address
4         https://bugs.webkit.org/show_bug.cgi?id=182427
5
6         Reviewed by Alex Christensen.
7
8         Add unit test for URL::hostIsIPAddress().
9
10         * TestWebKitAPI/Tests/WebCore/URL.cpp:
11         (TestWebKitAPI::TEST_F):
12
13 2018-02-03  Charlie Turner  <cturner@igalia.com>
14
15         Add libmount to WPE dependencies
16         https://bugs.webkit.org/show_bug.cgi?id=182345
17
18         Reviewed by Michael Catanzaro.
19
20         * wpe/install-dependencies:
21
22 2018-02-02  Youenn Fablet  <youenn@apple.com>
23
24         W3C test exporter should allow exporting newly added files
25         https://bugs.webkit.org/show_bug.cgi?id=182369
26
27         Reviewed by Ryosuke Niwa.
28
29         * Scripts/webkitpy/common/checkout/scm/git.py:
30         (Git.apply_mail_patch):
31
32 2018-02-02  David Quesada  <david_quesada@apple.com>
33
34         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
35         https://bugs.webkit.org/show_bug.cgi?id=182363
36         rdar://problem/37093498
37
38         Reviewed by Ryosuke Niwa.
39
40         Updated ApplicationManifestParserTests to account for the new default scope behavior.
41
42         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
43         (assertManifestHasDefaultValues):
44         (TEST_F):
45
46 2018-02-02  Youenn Fablet  <youenn@apple.com>
47
48         Clearing all service worker registrations should wait for importing service worker registration to finish
49         https://bugs.webkit.org/show_bug.cgi?id=182407
50
51         Reviewed by Chris Dumez.
52
53         Make sure we finish clearing service worker registrations before running tests.
54
55         * WebKitTestRunner/TestController.cpp:
56         (WTR::TestController::resetStateToConsistentValues):
57         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
58         (WTR::clearServiceWorkerRegistrationsCallback):
59         (WTR::TestController::clearServiceWorkerRegistrations):
60         * WebKitTestRunner/TestController.h:
61
62 2018-02-02  Youenn Fablet  <youenn@apple.com>
63
64         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
65         https://bugs.webkit.org/show_bug.cgi?id=182403
66
67         Reviewed by Alex Christensen.
68
69         * WebKitTestRunner/TestController.cpp:
70         (WTR::TestController::generateContextConfiguration const):
71         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
72         (WTR::initializeWebViewConfiguration):
73
74 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
75
76         [GTK] WebDriver: tests step always times out in the bot
77         https://bugs.webkit.org/show_bug.cgi?id=182437
78
79         Reviewed by Carlos Alberto Lopez Perez.
80
81         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
82         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
83
84         * Scripts/run-webdriver-tests: Call teardown() after run().
85         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
86         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
87         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
88         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
89         the display driver once and pass it to the test runners.
90         (WebDriverTestRunner.teardown): Stop the display server.
91         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
92         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
93         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
94         (WebDriverTestRunnerSelenium.run): Ditto.
95         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
96         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
97         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
98         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
99         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
100
101 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
102
103         Unreviewed, rolling out r227999.
104
105         It didn't fix the problem
106
107         Reverted changeset:
108
109         "Unreviewed. Try to avoid webdriver tests step timing out in
110         the bots."
111         https://trac.webkit.org/changeset/227999
112
113 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
114
115         Start timeout for the run-buildbot-test script is too aggressive
116         https://bugs.webkit.org/show_bug.cgi?id=182429
117
118         Reviewed by Carlos Garcia Campos.
119
120         15 seconds is not enough waiting for the update database process
121         to complete on a system backed with rotational HDDs. Raise it to 60.
122
123         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
124         (wait_for_master_ready):
125
126 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
127
128         re-add ARM JSCOnly bots on buildbot waterfall
129         https://bugs.webkit.org/show_bug.cgi?id=182428
130
131         Reviewed by Csaba Osztrogonác.
132
133         * BuildSlaveSupport/build.webkit.org-config/config.json:
134         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
135
136 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
137
138         Remove ARM JSCOnly bots from buildbot waterfall
139         https://bugs.webkit.org/show_bug.cgi?id=182398
140
141         Reviewed by Alexey Proskuryakov.
142
143         * BuildSlaveSupport/build.webkit.org-config/config.json:
144         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
145
146 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
149
150         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
151         workaround for a bug in python2.7 when using multiprocess module.
152
153         * Scripts/run-webdriver-tests:
154
155 2018-02-01  Youenn Fablet  <youenn@apple.com>
156
157         Delay service worker process creation until actually needed by SWServer
158         https://bugs.webkit.org/show_bug.cgi?id=182301
159
160         Reviewed by Chris Dumez.
161
162         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
163         (function):
164
165 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
166
167         Bubbles intermittently disappear from bot watchers dashboard
168         https://bugs.webkit.org/show_bug.cgi?id=182085
169
170         Reviewed by Alexey Proskuryakov.
171
172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
173         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
174         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
175         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
176
177 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
178
179         [GTK] Problem with Washington Post images
180         https://bugs.webkit.org/show_bug.cgi?id=181421
181
182         Reviewed by Carlos Alberto Lopez Perez.
183
184         Add test case for the new user agent quirk.
185
186         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
187         (TestWebKitAPI::TEST):
188
189 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         [GTK] MiniBrowser settings are just a list of names
192         https://bugs.webkit.org/show_bug.cgi?id=182005
193
194         Reviewed by Sergio Villar Senin.
195
196         The default size we are using is too small to show the values column, and the window is not resizable because
197         GObjectClass::constructed() is not called in the parent class.
198
199         * MiniBrowser/gtk/BrowserSettingsDialog.c:
200         (browser_settings_dialog_init): Use 600x400 as default size.
201         (browserSettingsDialogConstructed): Chain up to parent constructed.
202
203 2018-01-31  Andres Gomez  <agomez@igalia.com>
204
205         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
206
207         * Scripts/webkitpy/common/config/watchlist:
208
209 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
210
211         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
212         https://bugs.webkit.org/show_bug.cgi?id=181204
213         <rdar://problem/36256274>
214
215         Reviewed by Ryosuke Niwa.
216
217         Implement 'testRunner.forceImmediateCompletion()' for WK1.
218
219         * DumpRenderTree/TestRunner.cpp:
220         (forceImmediateCompletionCallback):
221         (TestRunner::staticFunctions):
222
223 2018-01-31  Alex Christensen  <achristensen@webkit.org>
224
225         Unreviewed, rolling out r227942.
226
227         r227875 should not have been rolled out.
228
229         Reverted changeset:
230
231         "Unreviewed, rolling out r227875."
232         https://bugs.webkit.org/show_bug.cgi?id=182357
233         https://trac.webkit.org/changeset/227942
234
235 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
236
237         Unreviewed, rolling out r227875.
238         https://bugs.webkit.org/show_bug.cgi?id=182357
239
240         Missing cross-platform TestController implementation
241
242         Reverted changeset:
243
244         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
245         https://bugs.webkit.org/show_bug.cgi?id=181958
246         https://trac.webkit.org/changeset/227875
247
248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
249         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
250         (WTR::InjectedBundle::didReceiveMessageToPage):
251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
252         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
253         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
254         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
256         * WebKitTestRunner/TestInvocation.cpp:
257         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
258         * WebKitTestRunner/TestInvocation.h:
259         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
260         (WTR::TestController::statisticsUpdateCookiePartitioning):
261         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
262
263 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
264
265         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
266         https://bugs.webkit.org/show_bug.cgi?id=182222
267
268         Reviewed by Alex Christensen.
269
270         Use the new API to notify when resource load statistics deletion is complete.
271
272         * WebKitTestRunner/TestController.cpp:
273         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
274         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
275         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
276
277 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
278
279         Add the support for running StyleBench to run-benchmark
280         https://bugs.webkit.org/show_bug.cgi?id=182323
281
282         Reviewed by Antti Koivisto.
283
284         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
285
286         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
287         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
288
289 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
290
291         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
292         https://bugs.webkit.org/show_bug.cgi?id=182339
293         <rdar://problem/36041396>
294
295         Reviewed by Andy Estes.
296
297         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
298         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
299         check against the length of the data written.
300
301         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
302         (testIconImageData):
303         (runTestWithTemporaryFolder):
304         (TestWebKitAPI::TEST):
305
306 2018-01-31  Dan Bernstein  <mitz@apple.com>
307
308         [macOS] MiniBrowser isn’t app-sandboxed
309         https://bugs.webkit.org/show_bug.cgi?id=182147
310
311         Reviewed by Sam Weinig.
312
313         Enable App Sandbox and add a temporary exception allowing read access to all files.
314
315         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
316         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
317         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
318           and read access from /.
319         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
320
321 2018-01-31  Philippe Normand  <pnormand@igalia.com>
322
323         [JHBuild] Add gstreamer-vaapi in moduleset
324         https://bugs.webkit.org/show_bug.cgi?id=182283
325
326         Reviewed by Carlos Alberto Lopez Perez.
327
328         GStreamer-VAAPI is required for hardware-accelerated video
329         playback support on Intel and AMD (using radeosi driver)
330         platforms.
331
332         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
333         * gtk/install-dependencies: Install libva.
334         * wpe/install-dependencies: Ditto.
335         * Scripts/webkitpy/port/gtk.py:
336         (GtkPort.setup_environ_for_server): Disable va-api support when
337         testing because it's incompatible with Mesa's softGL driver.
338
339 2018-01-31  Charlie Turner  <cturner@igalia.com>
340
341         [WPE] Update jhbuild dependencies
342         https://bugs.webkit.org/show_bug.cgi?id=182286
343
344         This upgrades the following packages,
345         glib 2.44.1 -> 2.54.3
346         glib-networking 2.42.0 -> 2.54.1
347         libsoup 2.48.0 -> 2.60.3
348
349         The initial reason for performing these upgrades was that when
350         visiting https://youtube.com, WPE was getting TLS certificate
351         errors. After upgrading glib-networking, these were fixed, but the
352         upgrade introduced dependencies on newer versions of the other
353         packages upgraded in this commit.
354
355         The upgrade to glib caused a linking error in gstreamer, the
356         following errors were being logged during linking,
357
358         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
359         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
360         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
361
362         This was fixed by adding the glib package built in the jhbuild to
363         harfbuzz.
364
365         Finally, the upgrade of glib caused the glib-warning-fix.patch to
366         no longer apply, so this patch was removed.
367
368         Reviewed by Michael Catanzaro.
369
370         * wpe/jhbuild.modules: Added dependecies.
371         * wpe/patches/glib-warning-fix.patch: Removed.
372
373 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
374
375         Unreviewed, rolling out r227782.
376
377         It didn't fix the problem
378
379         Reverted changeset:
380
381         "Unreviewed. Try to avoid webdriver tests step timing out in
382         the bots."
383         https://trac.webkit.org/changeset/227782
384
385 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
386
387         WebDriver: add domains to server config in w3c tests
388         https://bugs.webkit.org/show_bug.cgi?id=182294
389
390         Reviewed by Carlos Alberto Lopez Perez.
391
392         Several cookie tests expect server_config to have a domains key.
393
394         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
395                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
396
397         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
398         (WebDriverW3CExecutor.__init__):
399
400 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
401
402         Unreviewed. Update W3C WebDriver imported tests.
403
404         Show full pytest failure logs.
405
406         pytest truncates long lists when printing a failed assertion.
407         This is not great for debugging and arguably it should be the
408         default to show the full diff when comparing lists.
409
410         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
411         (run):
412
413 2018-01-30  John Wilander  <wilander@apple.com>
414
415         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
416         https://bugs.webkit.org/show_bug.cgi?id=181958
417         https://bugs.webkit.org/show_bug.cgi?id=182072
418         <rdar://problem/36801804>
419         <rdar://problem/36845795>
420
421         Reviewed by Brent Fulgham.
422
423         Because of the asynchronous nature of XPC and cookies,
424         we need callbacks in these TestRunner functions so that
425         the layout tests can wait for state changes to finish
426         before checking test conditions.
427
428         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
430         (WTR::InjectedBundle::didReceiveMessageToPage):
431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
432         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
433         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
434         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
436         * WebKitTestRunner/TestInvocation.cpp:
437         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
438         * WebKitTestRunner/TestInvocation.h:
439         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
440         (WTR::TestController::statisticsUpdateCookiePartitioning):
441         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
442
443 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
444
445         [webkitpy] Config file for apache is copied twice.
446         https://bugs.webkit.org/show_bug.cgi?id=182131
447
448         Reviewed by Daniel Bates.
449
450         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
451         (LayoutTestApacheHttpd.__init__):
452         (LayoutTestApacheHttpd._copy_apache_config_file):
453         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
454
455 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
456
457         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
458         https://bugs.webkit.org/show_bug.cgi?id=182312
459
460         Reviewed by Michael Catanzaro.
461
462         * DumpRenderTree/config.h:
463         * TestWebKitAPI/config.h:
464         * WebKitTestRunner/config.h:
465
466 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
467
468         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
469         https://bugs.webkit.org/show_bug.cgi?id=182307
470         <rdar://problem/36041485>
471
472         Reviewed by Ryosuke Niwa.
473
474         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
475         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
476         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
477         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
480         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
481         (TestWebKitAPI::TEST):
482
483 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
484
485         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
486         https://bugs.webkit.org/show_bug.cgi?id=182284
487
488         Reviewed by Michael Catanzaro.
489
490         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
491         * wpe/manifest.txt.in: Ditto.
492
493 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
494
495         Unreviewed, try to fix JSCOnly build
496         https://bugs.webkit.org/show_bug.cgi?id=177202
497
498         * CMakeLists.txt:
499
500 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
501
502         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
503
504         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
505         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
506         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
507         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
508
509         * Scripts/run-webdriver-tests:
510         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
511         (WebDriverTestRunner.dump_results_to_json_file):
512
513 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
514
515         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
516         https://bugs.webkit.org/show_bug.cgi?id=177202
517
518         Reviewed by Alex Christensen.
519
520         * CMakeLists.txt:
521
522 2018-01-29  Alex Christensen  <achristensen@webkit.org>
523
524         Clean up API after bugs 178240 and 176474
525         https://bugs.webkit.org/show_bug.cgi?id=182259
526
527         Reviewed by Dan Bernstein.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
530         (TEST):
531         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
532
533 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
534
535         [WebAuthN] Add a compile-time feature flag
536         https://bugs.webkit.org/show_bug.cgi?id=182211
537         <rdar://problem/36936365>
538
539         Reviewed by Brent Fulgham.
540
541         * Scripts/webkitperl/FeatureList.pm:
542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
543
544 2018-01-29  Brady Eidson  <beidson@apple.com>
545
546         Make the API test added in r227737 be Mac-only.
547
548         Unreviewed gardening.
549
550         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
551
552 2018-01-29  Matt Lewis  <jlewis3@apple.com>
553
554         Unreviewed, rolling out r227731.
555
556         This caused and assertion failure in API tests.
557
558         Reverted changeset:
559
560         "Layout Test fast/events/beforeunload-dom-manipulation-
561         crash.html is crashing"
562         https://bugs.webkit.org/show_bug.cgi?id=181204
563         https://trac.webkit.org/changeset/227731
564
565 2018-01-29  Youenn Fablet  <youenn@apple.com>
566
567         WPT test exporter should add WebKit export in its PR description
568         https://bugs.webkit.org/show_bug.cgi?id=182246
569
570         Reviewed by Chris Dumez.
571
572         Updating PR description body to contain the words 'WebKit export'.
573         That way, WPT PR bot will mark the PR as reviewed downstream.
574
575         * Scripts/webkitpy/w3c/test_exporter.py:
576         (TestExporter.__init__):
577         (TestExporter.make_pull_request):
578         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
579         (TestExporterTest.test_export):
580
581 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
582
583         Add the support for running Speedometer 2.0 to run-benchmark
584         https://bugs.webkit.org/show_bug.cgi?id=182231
585
586         Reviewed by Antti Koivisto.
587
588         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
589         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
590         requires aggregating the geometric mean out of total time spent in each suite.
591
592         Also added --show-iteration-values to show individual measured values in each iteration.
593
594         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
595         (BenchmarkResults.format): Added show_iteration_values as an option.
596         (BenchmarkResults._format_tests): Ditto.
597         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
598         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
599         is easily parsable as a JSON array.
600         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
601         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
602         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
603         had exactly one aggregator.
604         (BenchmarkResults._lint_results):
605         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
606         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
607         parent_aggregator_list.
608         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
609         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
610         (BenchmarkResults._lint_configuration):
611         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
612         (test_format_values_with_no_unit_scaling): Added.
613         (test_format_values_with_iteration_values): Added.
614         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
615         (test_aggregate_results_from_another_aggregator): Added.
616         (test_lint_results): Added a test case.
617         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
618         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
619         (BenchmarkRunner._run_benchmark): Ditto.
620         (BenchmarkRunner.show_results): Ditto.
621         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
622         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
623         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
624         (parse_args): Added --show-iteration-values as a boolean argument.
625         (run_benchmark_plan): Ditto.
626         (start): Ditto.
627         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
628         (WebServerBenchmarkRunner.__init__): Ditto.
629
630 2018-01-29  Brady Eidson  <beidson@apple.com>
631
632         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
633         https://bugs.webkit.org/show_bug.cgi?id=182229
634
635         Reviewed by Chris Dumez.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
639
640 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
641
642         WebDriver: properly recover w3c tests after a webdriver server crash
643         https://bugs.webkit.org/show_bug.cgi?id=182242
644
645         Reviewed by Carlos Alberto Lopez Perez.
646
647         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
648         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
649         relaunching the server after every test failure, because other failures, even when not crashing the server,
650         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
651         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
652
653         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
654         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
655         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
656         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
657         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
658         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
659         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
660         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
661
662 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
663
664         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
665         https://bugs.webkit.org/show_bug.cgi?id=181204
666         <rdar://problem/36256274>
667
668         Reviewed by Ryosuke Niwa.
669
670         Implement 'testRunner.forceImmediateCompletion()' for WK1.
671
672         * DumpRenderTree/TestRunner.cpp:
673         (forceImmediateCompletionCallback):
674         (TestRunner::staticFunctions):
675
676 2018-01-29  Frederic Wang  <fwang@igalia.com>
677
678         Unreviewed, add myself to some watch lists.
679
680         * Scripts/webkitpy/common/config/watchlist:
681
682 2018-01-27  Dan Bernstein  <mitz@apple.com>
683
684         HaveInternalSDK includes should be "#include?"
685         https://bugs.webkit.org/show_bug.cgi?id=179670
686
687         * DumpRenderTree/mac/Configurations/Base.xcconfig:
688
689 2018-01-26  Chris Dumez  <cdumez@apple.com>
690
691         Make sure service worker code does not launch a StorageProcess unnecessarily
692         https://bugs.webkit.org/show_bug.cgi?id=182192
693         <rdar://problem/36927427>
694
695         Reviewed by Geoffrey Garen.
696
697         Add API test coverage.
698
699         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
700
701 2018-01-26  Chris Dumez  <cdumez@apple.com>
702
703         Offlined content does not work for apps on home screen
704         https://bugs.webkit.org/show_bug.cgi?id=182070
705         <rdar://problem/36843906>
706
707         Reviewed by Youenn Fablet.
708
709         Add API test coverage to make sure an already registered service worker is able to intercept
710         the very first load.
711
712         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
713         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
714
715 2018-01-26  Chris Nardi  <cnardi@chromium.org>
716
717         Addressing post-review comments after r226614
718         https://bugs.webkit.org/show_bug.cgi?id=182151
719
720         Reviewed by Myles C. Maxfield.
721
722         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
723         (TestWebKitAPI::TEST):
724
725 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
726
727         Unreviewed, rolling out r224920.
728
729         Some Win EWS bots are not coming back up after starting reboot.
730
731         * EWSTools/start-queue-win.sh:
732
733 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
734
735         WebDriver: simplify the tests json report
736         https://bugs.webkit.org/show_bug.cgi?id=182171
737
738         Reviewed by Carlos Alberto Lopez Perez.
739
740         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
741         form the subtest name. We should do the same for simplicity and compatibility with WPT.
742
743         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
744         (WebDriverTestRunner.dump_results_to_json_file):
745
746 2018-01-25  Alex Christensen  <achristensen@webkit.org>
747
748         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
749         https://bugs.webkit.org/show_bug.cgi?id=182152
750
751         Reviewed by Joseph Pecoraro.
752
753         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
754         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
755         (TEST):
756
757 2018-01-25  Youenn Fablet  <youenn@apple.com>
758
759         WebPluginInfoProvider should handle null host queries
760         https://bugs.webkit.org/show_bug.cgi?id=182112
761
762         Reviewed by Chris Dumez.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
765         (TEST):
766
767 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
768
769         [webkitpy] Stop modifying path information only when running on Cygwin
770         https://bugs.webkit.org/show_bug.cgi?id=182136
771
772         On LayoutTestApacheHttpd, some path configuration is modified when platform
773         is Windows. This modification is only required for AppleWin running on Cygwin.
774         WinCairo uses native Windows environment, so the condition should be changed.
775
776         Reviewed by Per Arne Vollan.
777
778         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
779         (LayoutTestApacheHttpd.__init__):
780         (LayoutTestApacheHttpd._get_apache_config_file_path):
781
782 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
783
784         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
785         https://bugs.webkit.org/show_bug.cgi?id=182038
786         <rdar://problem/36812083>
787
788         Reviewed by Jer Noble.
789
790         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
791         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
792
793 2018-01-24  Daniel Bates  <dabates@apple.com>
794
795         webkit-patch upload emits irrelevant simulator warnings
796         https://bugs.webkit.org/show_bug.cgi?id=181702
797         <rdar://problem/36556359>
798
799         Reviewed by Aakash Jain.
800
801         Remove warning when a person explicitly passes --child-processes with a value greater than
802         the default number of simulator instances webkitpy would have used had --child-processes
803         been omitted. Moreover, the placement of the warning logic to support printing such a message
804         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
805
806         By default, webkitpy will parallelize running tests using the maximum number of simulator
807         instances that can be supported based on available system resources at the time run-webkit-tests
808         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
809         by specifying --child-processes knows what they are doing. The effects of picking a large
810         value be obvious, the system may become sluggish.
811
812         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
813         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
814
815         * Scripts/webkitpy/port/ios_simulator.py:
816         (IOSSimulatorPort.__init__):
817
818 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
819
820         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
821         https://bugs.webkit.org/show_bug.cgi?id=182102
822
823         Reviewed by Carlos Garcia Campos.
824
825         * MiniBrowser/gtk/main.c:
826         (main): Removed the call to set_enable_webvr().
827
828 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         WebDriver: add support for slow tests
831         https://bugs.webkit.org/show_bug.cgi?id=182095
832
833         Reviewed by Carlos Alberto Lopez Perez.
834
835         Add timeout mark to slow tests.
836
837         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
838         (TestExpectationsMarker.__init__): Save the timeout.
839         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
840         (run): Pass timeout to TestExpectationsMarker constructor.
841
842 2018-01-24  Alex Christensen  <achristensen@webkit.org>
843
844         Gracefully recover from NetworkProcess crashes in private browsing
845         https://bugs.webkit.org/show_bug.cgi?id=182073
846         <rdar://problem/36572023>
847
848         Reviewed by Geoff Garen.
849
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
851         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
852         (-[CrashDelegate webView:didFinishNavigation:]):
853         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
854         (-[CrashDelegate webView:didFailNavigation:withError:]):
855         (TEST):
856
857 2018-01-24  Ali Juma  <ajuma@chromium.org>
858
859         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
860         https://bugs.webkit.org/show_bug.cgi?id=182052
861
862         Reviewed by Simon Fraser.
863
864         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
865         immediately.
866
867         Test: fast/visual-viewport/viewport-dimensions.html
868
869         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
870         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
871
872 2018-01-24  Alex Christensen  <achristensen@webkit.org>
873
874         Remove pre-Sierra-OS-specific code in Tools
875         https://bugs.webkit.org/show_bug.cgi?id=182034
876
877         Reviewed by Tim Horton.
878
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (setDefaultsToConsistentValuesForTesting):
881         * MiniBrowser/mac/BrowserWindowController.m:
882         (-[BrowserWindowController windowDidLoad]):
883         (-[BrowserWindowController share:]):
884         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
885         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
886         (-[EventStreamPlayer playbackTimerFired:]):
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
889         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
890         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
891         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
892         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
893         (WTR::InjectedBundle::platformInitialize):
894         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
895         (WTR::initializeWebViewConfiguration):
896
897 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
898
899         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
900         https://bugs.webkit.org/show_bug.cgi?id=181400
901         <rdar://problem/36358768>
902
903         Reviewed by Joseph Pecoraro.
904
905         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
906
907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
908         Always disable poisoning when running with --leaks, as this should work locally,
909         not just on bots.
910
911 2018-01-24  Daniel Bates  <dabates@apple.com>
912
913         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
914         https://bugs.webkit.org/show_bug.cgi?id=181993
915         <rdar://problem/36421080>
916
917         Reviewed by David Hyatt.
918
919         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
920         as we no longer support this strategy.
921
922         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
923
924 2018-01-24  David Kilzer  <ddkilzer@apple.com>
925
926         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
927         <https://webkit.org/b/182015>
928         <rdar://problem/36449728>
929
930         Reviewed by Tim Horton.
931
932         * Scripts/webkitpy/style/checkers/cpp.py:
933         (regex_for_lambdas_and_blocks): Update regex to include
934         optional return type for block argument in Objective-C.
935         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
936         (WebKitStyleTest.test_braces): Add test.
937
938 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
939
940         WPE-focused test gardening.
941         https://bugs.webkit.org/show_bug.cgi?id=182051
942
943         Unreviewed test gardening.
944
945         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
946
947 2018-01-23  Mark Lam  <mark.lam@apple.com>
948
949         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
950         https://bugs.webkit.org/show_bug.cgi?id=182017
951         <rdar://problem/36795513>
952
953         Reviewed by Filip Pizlo and JF Bastien.
954
955         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
958         (TestWebKitAPI::TEST):
959         (TestWebKitAPI::passWithRef):
960         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
961         (TestWebKitAPI::TEST):
962         (TestWebKitAPI::f1):
963         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
964         (TestWebKitAPI::TEST):
965         (TestWebKitAPI::poisonedPtrFoo):
966         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
967         (TestWebKitAPI::TEST):
968         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
969         (TestWebKitAPI::TEST):
970
971 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
972
973         [WebVR] Add OpenVR to the tree and to the build
974         https://bugs.webkit.org/show_bug.cgi?id=177298
975
976         Reviewed by Žan Doberšek.
977
978         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
979         with reduced style checks.
980
981 2018-01-24  Chris Nardi  <cnardi@chromium.org>
982
983         Add Chris Nardi to contributors list
984         https://bugs.webkit.org/show_bug.cgi?id=182029
985
986         Reviewed by Antti Koivisto.
987
988         * Scripts/webkitpy/common/config/contributors.json:
989
990 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
991
992         Mac Sierra perf bots have been failing due to CG errors
993         https://bugs.webkit.org/show_bug.cgi?id=181955
994
995         Reviewed by Antti Koivisto.
996
997         Ignore the CoreGraphics error messages on macOS Sierra.
998
999         Also added tests for ignoring lines in stdout and stderr.
1000
1001         * Scripts/webkitpy/performance_tests/perftest.py:
1002         (PerfTest.run_failed): Refactored for clarity.
1003         (PerfTest):
1004         (PerfTest.filter_ignored_lines): Added.
1005         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1006         are now used to ignore lines in other kinds of tests than parser tests.
1007         (PerfTest._errors_to_ignore_in_sierra): Added.
1008         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1009         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1010         (test_parse_output_with_ignored_stdout): Added.
1011         (test_parse_output_with_ignored_stderr): Added.
1012         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1013
1014 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1015
1016         Resign NowPlaying status when no media element is eligible
1017         https://bugs.webkit.org/show_bug.cgi?id=181914
1018         <rdar://problem/35294116>
1019
1020         Reviewed by Jer Noble.
1021
1022         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1023         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1026
1027 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1028
1029         [WinCairo] Use 64-bit toolset
1030         https://bugs.webkit.org/show_bug.cgi?id=181979
1031
1032         Reviewed by Alex Christensen.
1033
1034         Use 64-bit toolset for 64-bit build in order to improve build time. 
1035
1036         * Scripts/webkitdirs.pm:
1037         (generateBuildSystemFromCMakeProject):
1038
1039 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1040
1041         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1042         https://bugs.webkit.org/show_bug.cgi?id=181741
1043         rdar://problem/36593581
1044
1045         Reviewed by Tim Horton.
1046         
1047         If zoomToScale:animated: is called with the current zoom level, call the callback
1048         rather than doing nothing.
1049
1050         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1051         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1052
1053 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1054
1055         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1056         https://bugs.webkit.org/show_bug.cgi?id=180820
1057
1058         Reviewed by David Kilzer.
1059
1060         * Scripts/webkitpy/common/checkout/scm/git.py:
1061         (Git.in_working_directory):
1062         (Git.clone):
1063         (Git.read_git_config):
1064         (Git.apply_reverse_diff):
1065         * Scripts/webkitpy/common/checkout/scm/scm.py:
1066         (SCM.run):
1067         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1068         * Scripts/webkitpy/common/checkout/scm/svn.py:
1069         (SVNRepository.has_authorization_for_realm):
1070         * Scripts/webkitpy/common/net/credentials_unittest.py:
1071         * Scripts/webkitpy/common/system/abstractexecutive.py:
1072         (AbstractExecutive.run_command):
1073         * Scripts/webkitpy/common/system/executive.py:
1074         (Executive.kill_process.is):
1075         (Executive.running_pids):
1076         (Executive.kill_all):
1077         (Executive.run_command):
1078         * Scripts/webkitpy/common/system/executive_mock.py:
1079         (MockExecutive.run_command):
1080         (MockExecutive2.run_command):
1081         * Scripts/webkitpy/common/system/executive_unittest.py:
1082         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1083         * Scripts/webkitpy/common/system/platforminfo.py:
1084         (PlatformInfo.xcode_sdk_version):
1085         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1086         (Lighttpd._check_and_kill):
1087         * Scripts/webkitpy/port/base.py:
1088         (Port._symbols_string):
1089         * Scripts/webkitpy/port/gtk.py:
1090         (GtkPort.setup_environ_for_server):
1091         * Scripts/webkitpy/port/win.py:
1092         (WinPort._runtime_feature_list):
1093         (WinPort.read_registry_value):
1094         * Scripts/webkitpy/port/win_unittest.py:
1095         (WinPortTest.test_runtime_feature_list):
1096         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1097         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1098
1099 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1100
1101         Unreviewed, rolling out r227279 and r227373.
1102         https://bugs.webkit.org/show_bug.cgi?id=181988
1103
1104         The LayoutTest crash fix introduced an API test failure.
1105         (Requested by ryanhaddad on #webkit).
1106
1107         Reverted changesets:
1108
1109         "Resign NowPlaying status when no media element is eligible"
1110         https://bugs.webkit.org/show_bug.cgi?id=181914
1111         https://trac.webkit.org/changeset/227279
1112
1113         "Resign NowPlaying status when no media element is eligible"
1114         https://bugs.webkit.org/show_bug.cgi?id=181914
1115         https://trac.webkit.org/changeset/227373
1116
1117 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1118
1119         Unreviewed. Add test case for slow in test_expectations.py.
1120
1121         I forgot to also check slow tests in test_expectations.py unit tests.
1122
1123         * Scripts/webkitpy/common/test_expectations_unittest.py:
1124         (assert_slow):
1125         (test_build_type):
1126         (test_slow):
1127
1128 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1129
1130         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1131
1132         * TestWebKitAPI/glib/TestExpectations.json:
1133
1134 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1135
1136         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1137         https://bugs.webkit.org/show_bug.cgi?id=181616
1138         <rdar://problem/36484908>
1139
1140         Reviewed by Wenson Hsieh.
1141
1142         Added tests to make sure we sanitize plain HTML, not just web archives,
1143         when and only when custom pasteboard data is enabled.
1144
1145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1146         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1147         (writeHTMLToPasteboard): Added.
1148         (createWebViewWithCustomPasteboardDataSetting): Added.
1149
1150 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1151
1152         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1153         https://bugs.webkit.org/show_bug.cgi?id=181400
1154         rdar://problem/36358768
1155
1156         Reviewed by JF Bastien.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1159
1160 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1161
1162         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1163         https://bugs.webkit.org/show_bug.cgi?id=181929
1164
1165         Reviewed by Michael Catanzaro.
1166
1167         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1168         the website data completion callback is not called immediately, and a new file is created when the operation
1169         finishes. We need to check that the file was removing after calling clear.
1170
1171         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1172         (fileChangedCallback):
1173         (testWebsiteDataResourceLoadStatistics):
1174
1175 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1176
1177         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
1178
1179         * TestWebKitAPI/glib/TestExpectations.json:
1180
1181 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1182
1183         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
1184
1185         Partially revert r226782, the fix was wrong for the GLib version we currently use.
1186
1187         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1188         (testWebKitConsoleMessageNetworkError):
1189
1190 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1191
1192         Unreviewed. Remove unused verbose mode from GLib API tests runner.
1193
1194         * glib/api_test_runner.py:
1195         (add_options):
1196
1197 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1200         https://bugs.webkit.org/show_bug.cgi?id=181918
1201
1202         Reviewed by Tim Horton.
1203
1204         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1205
1206         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1207
1208 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
1209
1210         Resign NowPlaying status when no media element is eligible
1211         https://bugs.webkit.org/show_bug.cgi?id=181914
1212         <rdar://problem/35294116>
1213
1214         Reviewed by Jer Noble.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1217         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1218         (TestWebKitAPI::TEST):
1219         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1220
1221 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
1222
1223         Fix broken unit-tests after r227192
1224         https://bugs.webkit.org/show_bug.cgi?id=181909
1225
1226         Reviewed by Carlos Garcia Campos.
1227
1228         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1229
1230 2018-01-20  Chris Dumez  <cdumez@apple.com>
1231
1232         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
1233         https://bugs.webkit.org/show_bug.cgi?id=174984
1234         <rdar://problem/33665676>
1235
1236         Reviewed by Alexey Proskuryakov.
1237
1238         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
1239
1240         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1241         (TEST):
1242
1243 2018-01-20  Brian Burg  <bburg@apple.com>
1244
1245         WebDriver: fix some nits that prevent running W3C tests on Mac
1246         https://bugs.webkit.org/show_bug.cgi?id=181864
1247
1248         Reviewed by Carlos Garcia Campos.
1249
1250         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1251         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
1252         as we assume that the property exists later.
1253
1254         (WebDriverW3CWebServer.stop): If the temporary file doesn't
1255         exist for some reason, the remove call will raise and exception.
1256         Gracefully handle the case where the file isn't created due to
1257         a problem/exception that happened elsewhere.
1258
1259 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
1260
1261         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
1262         https://bugs.webkit.org/show_bug.cgi?id=181881
1263
1264         Reviewed by Alexey Proskuryakov.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1267         (BubbleQueueServer):
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1270         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
1271
1272 2018-01-19  Youenn Fablet  <youenn@apple.com>
1273
1274         Do not go to the storage process when registering a service worker client if there is no service worker registered
1275         https://bugs.webkit.org/show_bug.cgi?id=181740
1276         <rdar://problem/36650400>
1277
1278         Reviewed by Chris Dumez.
1279
1280         Add support for internals inside API tests.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
1284         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
1285         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
1286         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
1287         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
1288         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1289         (setConfigurationInjectedBundlePath):
1290         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
1291
1292 2018-01-19  John Wilander  <wilander@apple.com>
1293
1294         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
1295         https://bugs.webkit.org/show_bug.cgi?id=181822
1296         https://bugs.webkit.org/show_bug.cgi?id=175263
1297         https://bugs.webkit.org/show_bug.cgi?id=178536
1298         https://bugs.webkit.org/show_bug.cgi?id=181223
1299         https://bugs.webkit.org/show_bug.cgi?id=181482
1300         <rdar://problem/33491222>
1301         <rdar://problem/33805293>
1302         <rdar://problem/36332683>
1303         <rdar://problem/36549026>
1304
1305         Reviewed by Alex Christensen.
1306
1307         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1309         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1310         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1312         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1313         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1314         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1315
1316 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
1317
1318         run-webkit-tests fails when there is a curly brace in Xcode build output
1319         https://bugs.webkit.org/show_bug.cgi?id=181254
1320         <rdar://problem/36453374>
1321
1322         Reviewed by Daniel Bates.
1323
1324         * Scripts/webkitpy/port/base.py:
1325         (Port._run_script): Encode script output before logging it.
1326
1327 2018-01-19  Chris Dumez  <cdumez@apple.com>
1328
1329         Service worker registrations restored from disk may not be reused when the JS calls register() again
1330         https://bugs.webkit.org/show_bug.cgi?id=181810
1331         <rdar://problem/36591711>
1332
1333         Reviewed by Youenn Fablet.
1334
1335         Add API test coverage.
1336
1337         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1338         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1339         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1340
1341 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
1342
1343         Remove El Capitan queues from flakiness dashboard
1344         https://bugs.webkit.org/show_bug.cgi?id=181860
1345
1346         Reviewed by Aakash Jain.
1347
1348         * TestResultServer/static-dashboards/builders.jsonp:
1349
1350 2018-01-19  Keith Miller  <keith_miller@apple.com>
1351
1352         HaveInternalSDK includes should be "#include?"
1353         https://bugs.webkit.org/show_bug.cgi?id=179670
1354
1355         Reviewed by Dan Bernstein.
1356
1357         * MiniBrowser/Configurations/Base.xcconfig:
1358         * MobileMiniBrowser/Configurations/Base.xcconfig:
1359         * TestWebKitAPI/Configurations/Base.xcconfig:
1360         * WebKitTestRunner/Configurations/Base.xcconfig:
1361
1362 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         WebDriver: driver environment not passed to pytest when running w3c tests
1365         https://bugs.webkit.org/show_bug.cgi?id=181852
1366
1367         Reviewed by Carlos Alberto Lopez Perez.
1368
1369         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
1370
1371         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1372         (WebDriverW3CExecutor.run):
1373
1374 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1375
1376         [GTK] WebDriver: wayland display no used in wayland bot
1377         https://bugs.webkit.org/show_bug.cgi?id=181851
1378
1379         Reviewed by Carlos Alberto Lopez Perez.
1380
1381         We need to handle the additionalArguments property in the WebDriverTests step.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1384         (RunWebDriverTests.start):
1385
1386 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1387
1388         [GTK] TERM environment variable is not passed to the test driver.
1389         https://bugs.webkit.org/show_bug.cgi?id=181847
1390
1391         Rubber-stamped by by Carlos Garcia Campos.
1392
1393         * Scripts/webkitpy/port/base.py:
1394         (Port.to.setup_environ_for_server):
1395
1396 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1397
1398         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
1399         https://bugs.webkit.org/show_bug.cgi?id=181844
1400
1401         Reviewed by Carlos Alberto Lopez Perez.
1402
1403         We always try to create the directory where to store the json file, but when the filename is given directly,
1404         like in the bots, the current dir is used.
1405
1406         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1407         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
1408         empty string.
1409
1410 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1411
1412         [GTK] WebDriver tests are running outside the jhbuild env
1413         https://bugs.webkit.org/show_bug.cgi?id=181842
1414
1415         Reviewed by Žan Doberšek.
1416
1417         We need to enter jhbuild env in run-webdriver-tests.
1418
1419         * Scripts/run-webdriver-tests:
1420
1421 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1422
1423         [GTK] Run WebDriver tests in the bots
1424         https://bugs.webkit.org/show_bug.cgi?id=181787
1425
1426         Reviewed by Michael Catanzaro.
1427
1428         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
1429         factory for the GTK port for now.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1432         (TestFactory.__init__):
1433         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1434         (RunWebDriverTests):
1435         (RunWebDriverTests.start):
1436         (RunWebDriverTests.commandComplete):
1437         (RunWebDriverTests.evaluateCommand):
1438         (RunWebDriverTests.getText):
1439         (RunWebDriverTests.getText2):
1440
1441 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1442
1443         [WinCairo] Pass correct url for http test to test driver.
1444         https://bugs.webkit.org/show_bug.cgi?id=181814
1445
1446         Reviewed by Alex Christensen.
1447
1448         * Scripts/webkitpy/port/driver.py:
1449         (Driver):
1450         (Driver.http_test_path_to_uri):
1451         (Driver.is_secure_path):
1452         (Driver.http_base_url):
1453         (Driver.uri_to_test):
1454
1455 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1456
1457         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
1458
1459         * BuildSlaveSupport/build.webkit.org-config/config.json:
1460
1461 2018-01-18  Dan Bernstein  <mitz@apple.com>
1462
1463         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1464         https://bugs.webkit.org/show_bug.cgi?id=181803
1465
1466         Reviewed by Tim Horton.
1467
1468         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
1469         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
1470         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
1471         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
1472         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1473         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1474         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1475         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1476         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
1477           helpers.
1478         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
1479           settings useful for defining settings that depend on the target macOS version.
1480         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
1481         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
1482
1483 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
1484
1485         Remove Opensource El Capitan queues from buildbot
1486         https://bugs.webkit.org/show_bug.cgi?id=181712
1487
1488         Reviewed by Aakash Jain.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/config.json:
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1492         (WebKitBuildbot):
1493         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1494
1495 2018-01-18  Chris Dumez  <cdumez@apple.com>
1496
1497         Service Workers restored from persistent storage have 'redundant' state
1498         https://bugs.webkit.org/show_bug.cgi?id=181749
1499         <rdar://problem/36556486>
1500
1501         Reviewed by Youenn Fablet.
1502
1503         Add API test coverage.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1506         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
1507
1508 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1509
1510         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
1511         https://bugs.webkit.org/show_bug.cgi?id=176796
1512
1513         Reviewed by Chris Fleizach.
1514
1515         Add sanity check that we have a URL before calling g_strstr_len().
1516
1517         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1518         (WTR::AccessibilityUIElement::url):
1519
1520 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1521
1522         Add triggers for Sierra test262 and perf queues
1523         https://bugs.webkit.org/show_bug.cgi?id=181799
1524
1525         Reviewed by Aakash Jain.
1526
1527         * BuildSlaveSupport/build.webkit.org-config/config.json:
1528
1529 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1530
1531         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
1532         https://bugs.webkit.org/show_bug.cgi?id=181783
1533         <rdar://problem/35785445>
1534
1535         Reviewed by Ryosuke Niwa.
1536
1537         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
1538         copying an image contains a relevant title.
1539
1540         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1541         (TestWebKitAPI::TEST):
1542         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1543         * TestWebKitAPI/ios/UIKitSPI.h:
1544
1545 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1546
1547         WebDriver: ignore the driver in selenium test names when getting expectations
1548         https://bugs.webkit.org/show_bug.cgi?id=181738
1549
1550         Reviewed by Carlos Alberto Lopez Perez.
1551
1552         In selenium tests, the driver is added as a parameter to every test which results in tests names like
1553         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
1554         driver name in the test expectations file, so we need to remove it when querying the expectations.
1555
1556         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1557         (TestExpectationsMarker.__init__): Save the param to ignore.
1558         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
1559         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
1560         (run): Pass param to ignore to TestExpectationsMarker().
1561         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1562         (WebDriverSeleniumExecutor.__init__): Save the driver name.
1563         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
1564
1565 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         [GTK][WPE] Show unit tests unexpectedly passing in the bots
1568         https://bugs.webkit.org/show_bug.cgi?id=181726
1569
1570         Reviewed by Michael Catanzaro.
1571
1572         Now that we have the info, let's show it also in the bots.
1573
1574         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1575         (RunGLibAPITests.commandComplete):
1576
1577 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
1578
1579         Fix broken unittest after r227048
1580         https://bugs.webkit.org/show_bug.cgi?id=181760
1581
1582         Reviewed by Aakash Jain.
1583
1584
1585 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1586
1587         WEBKIT_FRAMEWORK should not modify file-global include directories
1588         https://bugs.webkit.org/show_bug.cgi?id=181656
1589
1590         Reviewed by Konstantin Tokarev.
1591
1592         * TestWebKitAPI/PlatformWPE.cmake:
1593         * TestWebKitAPI/glib/CMakeLists.txt:
1594
1595 2018-01-17  Alicia Boya García  <aboya@igalia.com>
1596
1597         Unreviewed, mark Alicia as committer in contributors.json
1598
1599         * Scripts/webkitpy/common/config/contributors.json:
1600
1601 2018-01-17  Youenn Fablet  <youenn@apple.com>
1602
1603         Put fetch Request.keepalive behind a runtime flag
1604         https://bugs.webkit.org/show_bug.cgi?id=181592
1605
1606         Reviewed by Chris Dumez.
1607
1608         * DumpRenderTree/mac/DumpRenderTree.mm:
1609         (enableExperimentalFeatures):
1610         * DumpRenderTree/win/DumpRenderTree.cpp:
1611         (enableExperimentalFeatures):
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::resetPreferencesToConsistentValues):
1614
1615 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1616
1617         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1618         https://bugs.webkit.org/show_bug.cgi?id=181637
1619         <rdar://problem/36508471>
1620
1621         Reviewed by Tim Horton.
1622
1623         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
1624         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1627         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1628         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1629
1630         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1631         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1632
1633         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1634         (webViewForTestingAttachments):
1635         (-[TestWKWebView tagsInBody]):
1636         (-[TestWKWebView expectElementTagsInOrder:]):
1637         (-[TestWKWebView expectElementTag:toComeBefore:]):
1638
1639         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1640         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1641
1642         (TestWebKitAPI::TEST):
1643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1644         (WTR::InjectedBundlePage::InjectedBundlePage):
1645
1646 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1647
1648         WebDriver: add support for test expectations
1649         https://bugs.webkit.org/show_bug.cgi?id=180420
1650
1651         Reviewed by Carlos Alberto Lopez Perez.
1652
1653         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1654
1655         * Scripts/run-webdriver-tests: Get the retval from process_results().
1656         * Scripts/webkitpy/thirdparty/__init__.py:
1657         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1658         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1659         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1660         (TestExpectationsMarker.__init__): Initialize expectations.
1661         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1662         (run): Create and use TestExpectationsMarker plugin.
1663         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1664         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1665         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1666         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1667         (WebDriverTestRunner.run): Do not count results here.
1668         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1669         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1670         patch.
1671         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1672         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1673         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1674         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1675         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1676         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1677         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1678         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1679         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1680         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1681         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1682         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1683
1684 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         Unreviewed WPE gardening. Mark some known unit test failures.
1687
1688         * TestWebKitAPI/glib/TestExpectations.json:
1689
1690 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1691
1692         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1693         https://bugs.webkit.org/show_bug.cgi?id=181724
1694
1695         Reviewed by Philippe Normand.
1696
1697         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1698         reason to use different names. This way we can refer to the same test names for both and we can share the
1699         expectations in the TestExpectations.json file.
1700
1701         * TestWebKitAPI/glib/TestExpectations.json:
1702         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1703
1704 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1705
1706         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1707
1708         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1709         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1710
1711         * glib/api_test_runner.py:
1712         (TestRunner._run_test_glib):
1713         (TestRunner._run_google_test):
1714
1715 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1718         https://bugs.webkit.org/show_bug.cgi?id=179914
1719
1720         Reviewed by Žan Doberšek.
1721
1722         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1723         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1724         all symbols listed in the script are present in the library.
1725
1726         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1727         (bss_symbols):
1728         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1729         (script_symbols):
1730         * Scripts/make-dist:
1731         (Distcheck.build):
1732         (Distcheck):
1733         (Distcheck.check_symbols):
1734         (Distcheck.check):
1735
1736 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1737
1738         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1739         https://bugs.webkit.org/show_bug.cgi?id=181722
1740
1741         Reviewed by Žan Doberšek.
1742
1743         I forgot to pass the parameters to run() when restarting.
1744
1745         * glib/glib_test_runner.py:
1746         (GLibTestRunner.run):
1747
1748 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1749
1750         [CMake] Remove WebCoreDerivedSources library target
1751         https://bugs.webkit.org/show_bug.cgi?id=181664
1752
1753         Reviewed by Carlos Garcia Campos.
1754
1755         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1756         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1757
1758 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1759
1760         Move Debug Test262, Release Test262 and Performance queues to Sierra
1761         https://bugs.webkit.org/show_bug.cgi?id=181692
1762
1763         Unreviewed
1764
1765 2018-01-16  Zach Li  <zachli@apple.com>
1766
1767         Add pop-up policy support in website policies.
1768         https://bugs.webkit.org/show_bug.cgi?id=181544.
1769         rdar://problem/30521400.
1770
1771         Reviewed by Alex Christensen.
1772
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1774         Added pop-up-check.html.
1775
1776         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1779         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1780         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1781         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1782         (TEST):
1783
1784 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1785
1786         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1787         https://bugs.webkit.org/show_bug.cgi?id=181638
1788         <rdar://problem/36508702>
1789
1790         Reviewed by Dan Bernstein.
1791
1792         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1793         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1794
1795         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1796         (-[AttachmentUpdateObserver init]):
1797         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1798         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1799         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1800         (TestWebKitAPI::TEST):
1801         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1802
1803 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1804
1805         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1806
1807         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1808
1809         * glib/api_test_runner.py:
1810         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1811         * glib/glib_test_runner.py:
1812         (GLibTestRunner.run): Use given env.
1813
1814 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1815
1816         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1817         https://bugs.webkit.org/show_bug.cgi?id=181676
1818
1819         Reviewed by Carlos Alberto Lopez Perez.
1820
1821         The option was removed in r226967.
1822
1823         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1824         (RunGtkAPITests):
1825         (RunWPEAPITests):
1826
1827 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1830
1831         The bots are still passing that option and the step is failing because it was removed in r226967.
1832
1833         * glib/api_test_runner.py:
1834         (add_options):
1835
1836 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1837
1838         [GTK][WPE] Improve the way glib tests are run
1839         https://bugs.webkit.org/show_bug.cgi?id=181674
1840
1841         Reviewed by Žan Doberšek.
1842
1843         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1844         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1845         tests failing due to an expected assert in the test and unexpected crashes.
1846         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1847         not showing the subtest name in stdout in case of timeouts.
1848         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1849         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1850         of every test case.
1851
1852         * glib/api_test_runner.py:
1853         (TestRunner._run_test_glib): Use GLibTestRunner.
1854         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1855         (add_options):
1856         * glib/glib_test_runner.py: Added.
1857         (TestTimeout):
1858         (Message):
1859         (Message.__init__):
1860         (Message.create):
1861         (Message.create.read_unsigned):
1862         (Message.create.read_double):
1863         (Message.create.read_string):
1864         (GLibTestRunner):
1865         (GLibTestRunner.__init__):
1866         (GLibTestRunner._process_data):
1867         (GLibTestRunner._process_message):
1868         (GLibTestRunner._read_from_pipe):
1869         (GLibTestRunner._read_from_stderr):
1870         (GLibTestRunner._start_timeout):
1871         (GLibTestRunner._start_timeout._alarm_handler):
1872         (GLibTestRunner._stop_timeout):
1873         (GLibTestRunner._subtest_start):
1874         (GLibTestRunner._subtest_message):
1875         (GLibTestRunner._subtest_stderr):
1876         (GLibTestRunner._subtest_end):
1877         (GLibTestRunner.run):
1878
1879 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1880
1881         Unreviewed, add Thibault to contributors.json
1882
1883         It's a bit weird to add someone here before their first contribution, but this affects
1884         Bugzilla autocomplete, and that is serious business.
1885
1886         * Scripts/webkitpy/common/config/contributors.json:
1887
1888 2018-01-15  JF Bastien  <jfbastien@apple.com>
1889
1890         Remove makePoisonedUnique
1891         https://bugs.webkit.org/show_bug.cgi?id=181630
1892         <rdar://problem/36498623>
1893
1894         Reviewed by Mark Lam.
1895
1896         Update tests.
1897
1898         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1899         (TestWebKitAPI::TEST):
1900         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1901         (TestWebKitAPI::TEST):
1902
1903 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1904
1905         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1906         https://bugs.webkit.org/show_bug.cgi?id=181476
1907
1908         Reviewed by Michael Catanzaro.
1909
1910         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1911         the lists of packages to install libxfont2-devel (or equivalent).
1912
1913         * gtk/install-dependencies:
1914         * gtk/jhbuild.modules:
1915
1916 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1917
1918         [GTK][WPE] Add support for unit test expectations
1919         https://bugs.webkit.org/show_bug.cgi?id=181589
1920
1921         Reviewed by Michael Catanzaro.
1922
1923         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1924         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1925         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1926         script itself is not a good idea either.
1927
1928         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1929         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1930         convenient methods to query them.
1931
1932         * Scripts/run-gtk-tests:
1933         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1934         * Scripts/run-wpe-tests:
1935         (WPETestRunner): Ditto.
1936         * Scripts/webkitpy/common/test_expectations.py: Added.
1937         (TestExpectations):
1938         (TestExpectations.__init__):
1939         (TestExpectations._port_name_for_expected):
1940         (TestExpectations._expected_value):
1941         (TestExpectations.skipped_tests):
1942         (TestExpectations.skipped_subtests):
1943         (TestExpectations._expectation_value):
1944         (TestExpectations.is_slow):
1945         (TestExpectations.get_expectation):
1946         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1947         (MockTestExpectations):
1948         (MockTestExpectations.__init__):
1949         (MockTestExpectations.is_skip):
1950         (ExpectationsTest):
1951         (assert_exp):
1952         (assert_not_exp):
1953         (assert_bad_exp):
1954         (assert_skip):
1955         (test_basic):
1956         (test_skip):
1957         (test_flaky):
1958         (test_build_type):
1959         * TestWebKitAPI/glib/TestExpectations.json: Added.
1960         * glib/api_test_runner.py:
1961         (TestRunner): Remove SkippedTest implementation.
1962         (TestRunner.__init__): Create a TestExpectations.
1963         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
1964         (TestRunner._should_run_test_program): Ditto.
1965         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
1966         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
1967         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
1968         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
1969         (TestRunner.run_tests.report): Helper to write report to stdout.
1970
1971 2018-01-13  Mark Lam  <mark.lam@apple.com>
1972
1973         Replace all use of ConstExprPoisoned with Poisoned.
1974         https://bugs.webkit.org/show_bug.cgi?id=181542
1975         <rdar://problem/36442138>
1976
1977         Reviewed by JF Bastien.
1978
1979         1. Converted tests to using new uintptr_t& poison type.
1980         2. Added tests for Poisoned comparison operators.
1981
1982         * TestWebKitAPI/CMakeLists.txt:
1983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1984         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
1985         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1986         (TestWebKitAPI::TEST):
1987         (TestWebKitAPI::initializeTestPoison): Deleted.
1988         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1989         (TestWebKitAPI::TEST):
1990         (TestWebKitAPI::passWithRef):
1991         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1992         (TestWebKitAPI::TEST):
1993         (TestWebKitAPI::f1):
1994         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1995         (TestWebKitAPI::TEST):
1996         (TestWebKitAPI::poisonedPtrFoo):
1997         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2000         (TestWebKitAPI::TEST):
2001
2002 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2003
2004         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2005         <https://webkit.org/b/181606>
2006
2007         Reviewed by Darin Adler.
2008
2009         * Scripts/webkitpy/style/checkers/cpp.py:
2010         (check_spacing): Modify regular expression to ignore
2011         os_log format strings like '%{public}'.
2012         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2013         (CppStyleTest.test_spacing_before_braces): Add os_log
2014         format string test.
2015
2016 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2017
2018         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2019         https://bugs.webkit.org/show_bug.cgi?id=181626
2020
2021         Reviewed by Joseph Pecoraro.
2022
2023         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2024         Additionally, write a new API test covering the change in r226915.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2027         (webViewForTestingAttachments):
2028         (TestWebKitAPI::TEST):
2029
2030 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2031
2032         History state should be updated during client redirects with asynchronous policy decisions
2033         https://bugs.webkit.org/show_bug.cgi?id=181358
2034         <rdar://problem/35547689>
2035
2036         Reviewed by Andy Estes.
2037
2038         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2039         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2040         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2041         (TEST):
2042
2043 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2044
2045         webkitpy: Refactor simulator code (Part 4)
2046         https://bugs.webkit.org/show_bug.cgi?id=180555
2047         <rdar://problem/36131381>
2048
2049         Reviewed by Aakash Jain.
2050
2051         Move new_simulated_device.py to simulated_device.py.
2052
2053         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2054         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2055         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2056         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2057         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2058
2059 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2060
2061         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2062         https://bugs.webkit.org/show_bug.cgi?id=181595
2063
2064         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2065         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2066         I change the < and > to $ to make this test pass and continue to test what it used to.
2067
2068         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2069         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2070         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2071
2072 2018-01-11  Keith Miller  <keith_miller@apple.com>
2073
2074         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2075         https://bugs.webkit.org/show_bug.cgi?id=181573
2076
2077         Reviewed by Simon Fraser.
2078
2079         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2080
2081 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2082
2083         [WebAuthN] Import a CBOR coder from Chromium
2084         https://bugs.webkit.org/show_bug.cgi?id=181522
2085         <rdar://problem/36055729>
2086
2087         Reviewed by Brent Fulgham.
2088
2089         This patch also imports all unit tests into our API tests to ensure all
2090         workarounds and modification against the original codebase doesn't change
2091         any original functionalities.
2092
2093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2094         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2095         (TestWebKitAPI::TEST):
2096         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2097         (TestWebKitAPI::TEST):
2098         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2099         (TestWebKitAPI::eq):
2100         Workarounds applied.
2101         (TestWebKitAPI::TEST):
2102
2103 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2104
2105         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2106         https://bugs.webkit.org/show_bug.cgi?id=181538
2107         <rdar://problem/36440580>
2108
2109         Reviewed by Aakash Jain.
2110
2111         When disambiguating a device type, it is possible that the provided device type is sufficiently
2112         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2113         will result in a failure to disambiguate the type.
2114
2115         * Scripts/webkitpy/xcode/new_simulated_device.py:
2116         (SimulatedDeviceManager._disambiguate_device_type):
2117
2118 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2119
2120         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2121         https://bugs.webkit.org/show_bug.cgi?id=181136
2122         <rdar://problem/36116604>
2123
2124         Reviewed by Chris Dumez.
2125
2126         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2127         browsing sessions.
2128
2129         * Scripts/run-gtk-tests:
2130         (GtkTestRunner): Unskip test now that it passes.
2131         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2132         (TEST): Add new WebsiteDataStoreEphemeral test.
2133
2134 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2135
2136         Unreviewed, rolling out r226816.
2137
2138         This change broke LayoutTests on the bots.
2139
2140         Reverted changeset:
2141
2142         "run-webkit-tests fails when there is a curly brace in Xcode
2143         build output"
2144         https://bugs.webkit.org/show_bug.cgi?id=181254
2145         https://trac.webkit.org/changeset/226816
2146
2147 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2148
2149         webkitpy: Fix flakey webserver tests
2150         https://bugs.webkit.org/show_bug.cgi?id=181555
2151         <rdar://problem/36448273>
2152
2153         Reviewed by Aakash Jain.
2154
2155         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2156         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2157         determine if a specific server is running.
2158
2159 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2160
2161         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2162         https://bugs.webkit.org/show_bug.cgi?id=181561
2163         <rdar://problem/36452652>
2164
2165         Reviewed by Aakash Jain.
2166
2167         BeautifulSoup.find may return None, this case should be gracefully handled.
2168
2169         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2170         (BugzillaQueries._parse_result_count):
2171         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2172
2173 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2174
2175         run-webkit-tests fails when there is a curly brace in Xcode build output
2176         https://bugs.webkit.org/show_bug.cgi?id=181254
2177
2178         Reviewed by Daniel Bates.
2179
2180         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2181         (MeteredStream.write):
2182
2183 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2184
2185         webkitpy: Reimplement simulator code (Part 3)
2186         https://bugs.webkit.org/show_bug.cgi?id=180555
2187         <rdar://problem/36131381>
2188
2189         Reviewed by Aakash Jain.
2190
2191         Remove old simulator code.
2192
2193         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
2194         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
2195         * Scripts/webkitpy/xcode/simulator.py: Removed.
2196         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
2197
2198 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2199
2200         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
2201         https://bugs.webkit.org/show_bug.cgi?id=181337
2202         <rdar://problem/36324813>
2203
2204         Reviewed by Tim Horton.
2205
2206         Add 3 new API tests for attachment element dragging.
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2209         (-[TestWKWebView expectElementTag:toComeBefore:]):
2210         (-[NSItemProvider expectType:withData:]):
2211         (TestWebKitAPI::TEST):
2212
2213 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2214
2215         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
2216         https://bugs.webkit.org/show_bug.cgi?id=179621
2217         <rdar://problem/35589585>
2218
2219         Unreviewed infrastructure fix.
2220
2221         * Scripts/webkitpy/port/mac.py:
2222         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
2223         list if we are the VERSION_MAX, which usually corresponds with future.
2224
2225 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
2226
2227         CodeBlocks should be in IsoSubspaces
2228         https://bugs.webkit.org/show_bug.cgi?id=180884
2229
2230         Reviewed by Saam Barati.
2231         
2232         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
2233         shouldn't take a long time due to benchmarks we don't optimize for.
2234         
2235         * Scripts/run-jsc-benchmarks:
2236
2237 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
2238
2239         Test gardening for GTK.
2240         https://bugs.webkit.org/show_bug.cgi?id=181477
2241
2242         Unreviewed test gardening.
2243
2244         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
2245         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
2246
2247 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2248
2249         Add the new JSCOnly bot to the scheduler.
2250         https://bugs.webkit.org/show_bug.cgi?id=181487
2251
2252         Unreviewed follow-up patch after r226729
2253
2254         On r226729 I missed to add the new JSCOnly bot the default scheduler.
2255         This is needed to make the bot automatically pick each commit for testing.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/config.json:
2258
2259 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2260
2261         [Attachment Support] Support dragging attachment elements out as files on iOS
2262         https://bugs.webkit.org/show_bug.cgi?id=181199
2263         <rdar://problem/36299316>
2264
2265         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
2266
2267         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
2268         attachment API tests.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2271         (-[NSItemProvider expectType:withData:]):
2272         (TestWebKitAPI::TEST):
2273
2274         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
2275         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
2276         -expectType:withData: helper to inspect the item providers created from the drag source.
2277
2278         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2279         (TestWebKitAPI::TEST):
2280         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2281         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2282         (-[MockDragSession localContext]):
2283         (-[MockDragSession setLocalContext:]):
2284         (-[DataInteractionSimulator _resetSimulatedState]):
2285         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2286         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2287         (-[DataInteractionSimulator _advanceProgress]):
2288         (-[DataInteractionSimulator endDataTransfer]):
2289
2290         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
2291         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
2292         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
2293         MockDragSession to hold on to a localContext.
2294
2295 2018-01-11  Ali Juma  <ajuma@chromium.org>
2296
2297         Unreviewed. Add Ali Juma as contributor
2298
2299         * Scripts/webkitpy/common/config/contributors.json:
2300
2301 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         Unreviewed. Update Selenium WebDriver imported tests.
2304
2305         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
2306         environment variables.
2307
2308         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2309         (collect): Reorder the arguments to make pytest happy.
2310         (run): Ditto.
2311         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2312         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
2313
2314 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
2315
2316         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
2317         https://bugs.webkit.org/show_bug.cgi?id=181492
2318         <rdar://problem/36359679>
2319
2320         Reviewed by Alexey Proskuryakov. 
2321
2322 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2323
2324         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
2325         https://bugs.webkit.org/show_bug.cgi?id=181475
2326
2327         Reviewed by Michael Catanzaro.
2328
2329         * gtk/install-dependencies: Update package list for Arch Linux, extend
2330         message shown at end of installation with additional tips.
2331
2332 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2333
2334         REGRESSION(r222507): Composition highlight doesn't render when using IME
2335         https://bugs.webkit.org/show_bug.cgi?id=181485
2336         <rdar://problem/35896516>
2337
2338         Reviewed by Ryosuke Niwa.
2339
2340         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2341         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
2342         allow rendering composition backgrounds (see InlineTextBox::paint).
2343
2344         * DumpRenderTree/ios/TextInputControllerIOS.m:
2345         (+[TextInputController isSelectorExcludedFromWebScript:]):
2346         (+[TextInputController webScriptNameForSelector:]):
2347         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2348         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2349         * DumpRenderTree/mac/TextInputControllerMac.m:
2350         (+[TextInputController isSelectorExcludedFromWebScript:]):
2351         (+[TextInputController webScriptNameForSelector:]):
2352         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2353         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2354         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2355         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2356         (WTR::TextInputController::setMarkedText):
2357         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2358
2359 2018-01-10  JF Bastien  <jfbastien@apple.com>
2360
2361         Poison small JSObject derivatives which only contain pointers
2362         https://bugs.webkit.org/show_bug.cgi?id=181483
2363         <rdar://problem/36407127>
2364
2365         Reviewed by Mark Lam.
2366
2367         Test the new move-assign and move-copy from unique_ptr, as well as
2368         nullptr_t ctors.
2369
2370         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2371         (TestWebKitAPI::TEST):
2372         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2375         (TestWebKitAPI::TEST):
2376
2377 2018-01-10  Chris Dumez  <cdumez@apple.com>
2378
2379         Multiple http/wpt/beacon/contentextensions/ test are flaky.
2380         https://bugs.webkit.org/show_bug.cgi?id=179256
2381         <rdar://problem/35401978>
2382
2383         Reviewed by Alex Christensen.
2384
2385         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
2386         instance gets its own folder to avoid conflicts and flakiness.
2387
2388         * WebKitTestRunner/mac/TestControllerMac.mm:
2389         (WTR::TestController::platformConfigureViewForTest):
2390
2391 2018-01-10  Tim Horton  <timothy_horton@apple.com>
2392
2393         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
2394         https://bugs.webkit.org/show_bug.cgi?id=181269
2395         <rdar://problem/35110344>
2396
2397         Reviewed by Simon Fraser.
2398
2399         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2400         (WTR::UIScriptController::beginBackSwipe):
2401         (WTR::UIScriptController::completeBackSwipe):
2402         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2403         (WTR::UIScriptController::beginBackSwipe):
2404         (WTR::UIScriptController::completeBackSwipe):
2405         (WTR::UIScriptController::overridePreference):
2406         (WTR::UIScriptController::replaceTextAtRange):
2407         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2408         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2409         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2410         (WTR::UIScriptController::beginBackSwipe):
2411         (WTR::UIScriptController::completeBackSwipe):
2412         Implement beginBackSwipe and completeBackSwipe on iOS (they already
2413         exist on Mac) in terms of the new WKWebView testing SPI.
2414
2415 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2416
2417         REGRESSION (r226715): ignore WARNING output in linter tests
2418         https://bugs.webkit.org/show_bug.cgi?id=181486
2419         <rdar://problem/36408847>
2420
2421         Reviewed by Aakash Jain.
2422
2423         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
2424
2425         * Scripts/webkitpy/common/system/outputcapture.py:
2426         (OutputCapture.__init__): Pass logging level to be captured.
2427         * Scripts/webkitpy/style/main_unittest.py:
2428         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
2429         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
2430         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
2431         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
2432         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
2433         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
2434         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
2435         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
2436
2437 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2438
2439         Add a JSCOnly MIPS buildbot
2440         https://bugs.webkit.org/show_bug.cgi?id=181487
2441
2442         Reviewed by Michael Catanzaro.
2443
2444         Add the new bot configs definitions for the master and update the unit tests.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/config.json:
2447         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2448
2449 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2450
2451         REGRESSION (r226715): don't re-check number of simulators in child processes
2452         https://bugs.webkit.org/show_bug.cgi?id=181484
2453         <rdar://problem/36407151>
2454
2455         Reviewed by Aakash Jain.
2456
2457         * Scripts/webkitpy/port/ios_simulator.py:
2458         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
2459         are already initialized.
2460
2461 2018-01-10  Commit Queue  <commit-queue@webkit.org>
2462
2463         Unreviewed, rolling out r226667 and r226673.
2464         https://bugs.webkit.org/show_bug.cgi?id=181488
2465
2466         This caused a flaky crash. (Requested by mlewis13 on #webkit).
2467
2468         Reverted changesets:
2469
2470         "CodeBlocks should be in IsoSubspaces"
2471         https://bugs.webkit.org/show_bug.cgi?id=180884
2472         https://trac.webkit.org/changeset/226667
2473
2474         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
2475         https://bugs.webkit.org/show_bug.cgi?id=180884
2476         https://trac.webkit.org/changeset/226673
2477
2478 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2479
2480         Follow-up fix to r226715
2481         https://bugs.webkit.org/show_bug.cgi?id=180555
2482         <rdar://problem/36131381>
2483
2484         Unreviewed infrastructure fix.
2485
2486         * Scripts/webkitpy/xcode/new_simulated_device.py:
2487         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
2488         of delete.
2489
2490 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2491
2492         webkitpy: Refactor simulator code (Part 2)
2493         https://bugs.webkit.org/show_bug.cgi?id=180555
2494         <rdar://problem/36131381>
2495
2496         Reviewed by Aakash Jain.
2497
2498         The patch leverages the SimulatedDeviceManager when running layout tests.
2499         This patch is primarily code removal, since much of the IOSSimulatorPort
2500         was dedicated to managing simulators. The removed code is either now owned by the
2501         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
2502         boot multiple simulators which was made obsolete in Xcode 9.
2503
2504         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2505         (Manager._custom_device_for_test.in): Device names now have spaces in them,
2506         strip those spaces.
2507         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2508         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
2509         * Scripts/webkitpy/port/ios.py:
2510         (IOSPort.__init__): The _current_device idiom is no longer required since the
2511         SimulatedDeviceManager keeps track of any previously booted devices.
2512         (IOSPort.target_host): Even when only a single device is used, it will be accessed
2513         through the array of managed devices.
2514         (IOSPort.using_multiple_devices): Deleted.
2515         * Scripts/webkitpy/port/ios_device.py:
2516         (IOSDevicePort.using_multiple_devices): Deleted.
2517         * Scripts/webkitpy/port/ios_simulator.py:
2518         (IOSSimulatorPort): Remove constants required to manage simulators, change device
2519         class strings so they can be parsed by the DeviceType class.
2520         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
2521         the number of simulators currently booted, the number of child processes specified
2522         and the maximum number of simulators supported by this system.
2523         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
2524         devices owned by the SimulatedDeviceManager.
2525         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
2526         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
2527         the maximum number of supported simulators on this system.
2528         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
2529         request for each child process and send this list to the SimulatedDeviceManager to
2530         initialize the devices.
2531         (IOSSimulatorPort.clean_up_test_run):
2532         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
2533         specified version of iOS.
2534         (IOSSimulatorPort.reset_preferences):
2535         (IOSSimulatorPort.simulator_runtime): Deleted.
2536         (IOSSimulatorPort.simulator_device_type): Deleted.
2537         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
2538         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
2539         (IOSSimulatorPort._create_simulators): Deleted.
2540         (IOSSimulatorPort._quit_ios_simulator): Deleted.
2541         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
2542         (IOSSimulatorPort.using_multiple_devices): Deleted.
2543         (IOSSimulatorPort._create_device): Deleted.
2544         (IOSSimulatorPort.get_simulator_path): Deleted.
2545         (IOSSimulatorPort._createSimulatorApps): Deleted.
2546         (IOSSimulatorPort._createSimulatorApp): Deleted.
2547         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2548         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
2549         maximum number of simulators run on this system.
2550         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
2551         * Scripts/webkitpy/xcode/new_simulated_device.py:
2552         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
2553
2554 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2555
2556         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
2557         https://bugs.webkit.org/show_bug.cgi?id=181474
2558
2559         Reviewed by Carlos Alberto Lopez Perez.
2560
2561         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
2562         name as the name.
2563
2564         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2565         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
2566         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
2567
2568 2018-01-09  Andy Estes  <aestes@apple.com>
2569
2570         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
2571         https://bugs.webkit.org/show_bug.cgi?id=181459
2572
2573         Reviewed by Dan Bernstein.
2574
2575         * ImageDiff/cg/Configurations/Base.xcconfig:
2576
2577 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
2578
2579         font-display:fallback can cause a visual flash (which is supposed to be impossible)
2580         https://bugs.webkit.org/show_bug.cgi?id=181374
2581
2582         Reviewed by Simon Fraser.
2583
2584         The test requires Palatino.
2585
2586         * DumpRenderTree/mac/DumpRenderTree.mm:
2587         (allowedFontFamilySet):
2588         * WebKitTestRunner/mac/TestControllerMac.mm:
2589         (WTR::allowedFontFamilySet):
2590
2591 2018-01-09  Saam Barati  <sbarati@apple.com>
2592
2593         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
2594         https://bugs.webkit.org/show_bug.cgi?id=181449
2595
2596         Reviewed by JF Bastien.
2597
2598         This allows me to Cmd+f in my terminal to search for things without
2599         having the results become misaligned.
2600
2601         * Scripts/display-profiler-output:
2602
2603 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2604
2605         [webkitpy] PlatformInfo should have default argument for casual use
2606         https://bugs.webkit.org/show_bug.cgi?id=180827
2607
2608         Reviewed by David Kilzer.
2609
2610         PlatformInfo should be the only way to check platform specific thing instead
2611         of sys.platform or other various checks. If there is something you want to check,
2612         it should be placed in PlatformInfo.
2613
2614         Currently to instantiate PlatformInfo, it requires arguments, which is usually
2615         sys, platform and Executive(). They are straight forward and should be handled
2616         by default arguments. Then we can instantiate PlatformInfo more casual.
2617
2618         * Scripts/webkitpy/common/system/platforminfo.py:
2619         (PlatformInfo): Use relative module path import
2620         (PlatformInfo.__init__):
2621         (PlatformInfo.executive): Lazy instantiation of Executive()
2622         (PlatformInfo.total_bytes_memory): Accessing via above property
2623         (PlatformInfo.xcode_sdk_version): Ditto
2624         (PlatformInfo.xcode_simctl_list): Ditto
2625         (PlatformInfo.xcode_version): Ditto
2626         (PlatformInfo._win_version_str): Ditto
2627         * Scripts/webkitpy/common/system/systemhost.py:
2628         (SystemHost.__init__):
2629         * Scripts/webkitpy/common/system/user.py:
2630         (User.__init__):
2631
2632 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2633
2634         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2635         https://bugs.webkit.org/show_bug.cgi?id=176443
2636
2637         Reviewed by Darin Adler.
2638
2639         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2640         (TEST):
2641
2642 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2643
2644         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2645         https://bugs.webkit.org/show_bug.cgi?id=181394
2646
2647         Reviewed by Darin Adler.
2648
2649         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2650         as the second parameter instead of ios(WK_IOS_TBA). This generally
2651         builds for iOS on EWS but not when using the public SDK. See r224057,
2652         r223207 and r226211 for example. This patch adds a basic style check
2653         for that macro to prevent this kind of mistake.
2654
2655         * Scripts/webkitpy/style/checkers/cpp.py:
2656         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2657         (check_style): Run new style check.
2658         (CppChecker): Add build type for the new style check.
2659         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2660         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2661
2662 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2663
2664         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2665         https://bugs.webkit.org/show_bug.cgi?id=181420
2666         <rdar://problem/36365827>
2667
2668         Reviewed by Alex Christensen.
2669
2670         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2671         of corresponding _WKAttachments.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2674         (TestWebKitAPI::TEST):
2675
2676 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2677
2678         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2679         https://bugs.webkit.org/show_bug.cgi?id=181410
2680         <rdar://problem/36167199>
2681
2682         Reviewed by Wenson Hsieh.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2685         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2686         (TEST):
2687
2688 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2689
2690         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2691         https://bugs.webkit.org/show_bug.cgi?id=181408
2692         <rdar://problem/35884960>
2693
2694         Reviewed by Tim Horton.
2695
2696         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2697         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2698
2699 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2700
2701         [Attachment Support] Expose file name and content type of WKAttachment
2702         https://bugs.webkit.org/show_bug.cgi?id=181390
2703         <rdar://problem/36336837>
2704
2705         Reviewed by Tim Horton.
2706
2707         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2708
2709         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2710         (-[_WKAttachment synchronouslyRequestInfo:]):
2711         (-[_WKAttachment synchronouslyRequestData:]):
2712
2713         Reimplement this in terms of -synchronouslyRequestInfo:.
2714
2715         (-[_WKAttachment expectRequestedDataToBe:]):
2716         (TestWebKitAPI::TEST):
2717
2718 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2719
2720         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2721         https://bugs.webkit.org/show_bug.cgi?id=181365
2722         <rdar://problem/36340647>
2723
2724         Reviewed by Tim Horton.
2725
2726         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2727         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2728         detail.
2729
2730         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2731         (TestWebKitAPI::TEST):
2732
2733 2018-01-08  Youenn Fablet  <youenn@apple.com>
2734
2735         navigator.onLine does not work inside service workers
2736         https://bugs.webkit.org/show_bug.cgi?id=181079
2737         <rdar://problem/36178606>
2738
2739         Reviewed by Darin Adler.
2740
2741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2742         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2743
2744 2018-01-07  Saam Barati  <sbarati@apple.com>
2745
2746         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2747         https://bugs.webkit.org/show_bug.cgi?id=181372
2748
2749         Reviewed by Filip Pizlo.
2750
2751         Adding these sorting modes makes it easier to analyze functions
2752         that recompile a lot and exit a lot.
2753
2754         * Scripts/display-profiler-output:
2755
2756 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2757
2758         Unreviewed, remove my Cisco email from contributors.json
2759
2760         * Scripts/webkitpy/common/config/contributors.json:
2761
2762 2018-01-05  JF Bastien  <jfbastien@apple.com>
2763
2764         WebAssembly: poison JS object's secrets
2765         https://bugs.webkit.org/show_bug.cgi?id=181339
2766         <rdar://problem/36325001>
2767
2768         Reviewed by Mark Lam.
2769
2770         Update tests for swap(Poisoned<k, T>, T*)
2771
2772         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2773         (TestWebKitAPI::TEST):
2774         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2777         (TestWebKitAPI::TEST):
2778
2779 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2780
2781         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2782         https://bugs.webkit.org/show_bug.cgi?id=181359
2783
2784         Reviewed by Tim Horton.
2785
2786         Ensure that these tests still pass using older SDKs.
2787
2788         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2789         (TestWebKitAPI::TEST):
2790
2791 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2792
2793         Rebase API test after r226469
2794         https://bugs.webkit.org/show_bug.cgi?id=181308
2795
2796         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2797         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2798         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2799
2800 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2801
2802         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2803         https://bugs.webkit.org/show_bug.cgi?id=181217
2804
2805         Reviewed by Tim Horton.
2806
2807         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2808         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2809         (TEST):
2810
2811 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2812
2813         Add WKBundleFrameCreateFrameHandle
2814         https://bugs.webkit.org/show_bug.cgi?id=181232
2815         <rdar://problem/35926696>
2816
2817         Reviewed by Tim Horton.
2818
2819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2820         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2821         (mouseDidMoveOverElement):
2822         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2823         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2824         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2825         (TEST):
2826
2827 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2828
2829         iOS: Build fix after r226432.
2830         
2831         Unreviewed. Stop duplicating speakAs symbols for iOS.
2832
2833         * DumpRenderTree/AccessibilityUIElement.cpp:
2834         (AccessibilityUIElement::speakAs):
2835
2836 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2837
2838         Unreviewed, added myself as WebKit reviewer
2839
2840         * Scripts/webkitpy/common/config/contributors.json:
2841
2842 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2843
2844         WPE: Build fix after r226432.
2845
2846         Unreviewed. Rename ::speak() to ::speakAs().
2847         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2848         (WTR::AccessibilityUIElement::speakAs):
2849         (WTR::AccessibilityUIElement::speak): Deleted.
2850
2851 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2852
2853         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2854         https://bugs.webkit.org/show_bug.cgi?id=180361
2855
2856         Reviewed by Zalan Bujtas.
2857
2858         * DumpRenderTree/AccessibilityUIElement.cpp:
2859         (speakAsCallback):
2860         (AccessibilityUIElement::speakAs):
2861         (AccessibilityUIElement::getJSClass):
2862         (speakCallback): Deleted.
2863         (AccessibilityUIElement::speak): Deleted.
2864         * DumpRenderTree/AccessibilityUIElement.h:
2865         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2866         (AccessibilityUIElement::speakAs):
2867         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2868         (AccessibilityUIElement::speakAs):
2869         (AccessibilityUIElement::speak): Deleted.
2870         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2871         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2872         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2873         (WTR::AccessibilityUIElement::speakAs):
2874         (WTR::AccessibilityUIElement::speak): Deleted.
2875         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2876         (WTR::AccessibilityUIElement::speakAs):
2877         (WTR::AccessibilityUIElement::speak): Deleted.
2878
2879 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2880
2881         REGRESSION (r226395): test-webkitperl test expectations incorrect
2882         https://bugs.webkit.org/show_bug.cgi?id=181307
2883         <rdar://problem/36306558>
2884
2885         Rubber-stamped by Aakash Jain.
2886
2887         r226395 added two lines towards the beginning of
2888         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2889         numbers in the test expectations need to update.
2890
2891         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2892
2893 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2894
2895         WKWebView loses minimum layout size overrides that happen while the process is terminated
2896         https://bugs.webkit.org/show_bug.cgi?id=181306
2897         <rdar://problem/34398288>
2898
2899         Reviewed by Dan Bernstein.
2900
2901         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2902         (TEST):
2903         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2904         while the process is terminated results in the page getting the correct
2905         minimum layout size.
2906
2907 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2908
2909         [MediaStream] Add Mock screen capture source
2910         https://bugs.webkit.org/show_bug.cgi?id=181291
2911         <rdar://problem/36298164>
2912
2913         Reviewed by Dean Jackson.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2916         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2917         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2918
2919 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2920
2921         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2922
2923         Reviewed by Ling Ho.
2924
2925         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2926
2927 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2928
2929         [Attachment Support] Create attachment elements when dropping files on iOS
2930         https://bugs.webkit.org/show_bug.cgi?id=181192
2931         <rdar://problem/36280945>
2932
2933         Reviewed by Tim Horton.
2934
2935         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2936         switch is enabled. See below for more details.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2939         (-[NSItemProvider registerData:type:]):
2940         (platformCopyPNG):
2941         (TestWebKitAPI::TEST):
2942         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2943
2944         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2945         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2946         kUTTypeRTF instead.
2947
2948         (TestWebKitAPI::TEST):
2949
2950         Tests a few cases of inserting attachment elements via drop:
2951         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2952             Instead of inserting the contents as inline web content, this should generate attachment elements.
2953         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2954             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2955             back to inserting the content as an attachment.
2956         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2957             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2958             or at the end).
2959
2960         * TestWebKitAPI/cocoa/TestWKWebView.h:
2961         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2962         (-[TestWKWebView objectByEvaluatingJavaScript:]):
2963
2964         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
2965         -stringByEvaluatingJavaScript to just turn around and call this.
2966
2967         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2968
2969 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
2970
2971         Replace hard-coded paths in shebangs with #!/usr/bin/env
2972         https://bugs.webkit.org/show_bug.cgi?id=181040
2973
2974         Reviewed by Alex Christensen.
2975
2976         * BuildSlaveSupport/build-launcher-app:
2977         * BuildSlaveSupport/build-launcher-dmg:
2978         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2979         * BuildSlaveSupport/built-product-archive:
2980         * BuildSlaveSupport/clean-build:
2981         * BuildSlaveSupport/delete-stale-build-files:
2982         * BuildSlaveSupport/download-built-product:
2983         * BuildSlaveSupport/gtk/buildbot/log/run:
2984         * BuildSlaveSupport/gtk/buildbot/run:
2985         * BuildSlaveSupport/gtk/pulseaudio/run:
2986         * BuildSlaveSupport/kill-old-processes:
2987         * BuildSlaveSupport/test-result-archive:
2988         * BuildSlaveSupport/win/kill-old-processes:
2989         * Scripts/SpacingHeuristics.pm:
2990         * Scripts/add-include:
2991         * Scripts/build-api-tests:
2992         * Scripts/build-dumprendertree:
2993         * Scripts/build-imagediff:
2994         * Scripts/build-jsc:
2995         * Scripts/build-webkit:
2996         * Scripts/build-webkittestrunner:
2997         * Scripts/check-Xcode-source-file-types:
2998         * Scripts/check-dom-results:
2999         * Scripts/check-for-exit-time-destructors:
3000         * Scripts/check-for-global-initializers:
3001         * Scripts/check-for-inappropriate-objc-class-names:
3002         * Scripts/check-for-weak-vtables-and-externals:
3003         * Scripts/clean-header-guards:
3004         * Scripts/compare-timing-files:
3005         * Scripts/configure-xcode-for-ios-development:
3006         * Scripts/copy-webkitlibraries-to-product-directory:
3007         * Scripts/create-exports:
3008         * Scripts/debug-minibrowser:
3009         * Scripts/debug-safari:
3010         * Scripts/debug-test-runner:
3011         * Scripts/do-file-rename:
3012         * Scripts/do-webcore-rename:
3013         * Scripts/dump-webkit-tests-run:
3014         * Scripts/ensure-valid-python:
3015         * Scripts/execAppWithEnv:
3016         * Scripts/extract-localizable-js-strings:
3017         * Scripts/filter-build-webkit:
3018         * Scripts/find-extra-includes:
3019         * Scripts/fix-blink-patch:
3020         * Scripts/generate-coverage-data:
3021         * Scripts/git-add-reviewer:
3022         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3023         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3024         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3025         * Scripts/make-new-script-test:
3026         * Scripts/make-script-test-wrappers:
3027         * Scripts/package-root:
3028         * Scripts/parse-malloc-history:
3029         * Scripts/report-include-statistics:
3030         * Scripts/resolve-ChangeLogs:
3031         * Scripts/run-api-tests:
3032         * Scripts/run-bindings-tests:
3033         * Scripts/run-content-extension-tester:
3034         * Scripts/run-iexploder-tests:
3035         * Scripts/run-javascriptcore-tests:
3036         * Scripts/run-jsc:
3037         * Scripts/run-leaks:
3038         * Scripts/run-mangleme-tests:
3039         * Scripts/run-minibrowser:
3040         * Scripts/run-pageloadtest:
3041         * Scripts/run-regexp-tests:
3042         * Scripts/run-safari:
3043         * Scripts/run-sunspider:
3044         * Scripts/run-test-runner:
3045         * Scripts/run-webkit-app:
3046         * Scripts/run-webkit-httpd:
3047         * Scripts/run-webkit-websocketserver:
3048         * Scripts/set-webkit-configuration:
3049         * Scripts/show-pretty-diff:
3050         * Scripts/sort-Xcode-project-file:
3051         * Scripts/split-file-by-class:
3052         * Scripts/sunspider-compare-results:
3053         * Scripts/svn-apply:
3054         * Scripts/svn-unapply:
3055         * Scripts/test-webkit-scripts:
3056         * Scripts/test-webkitperl:
3057         * Scripts/update-iexploder-cssproperties:
3058         * Scripts/update-javascriptcore-test-results:
3059         * Scripts/update-webkit:
3060         * Scripts/update-webkit-auxiliary-libs:
3061         * Scripts/update-webkit-dependency:
3062         * Scripts/update-webkit-libs-jhbuild:
3063         * Scripts/update-webkit-localizable-strings:
3064         * Scripts/update-webkit-support-libs:
3065         * Scripts/update-webkitgtk-libs:
3066         * Scripts/update-webkitwpe-libs:
3067         * Scripts/webkit-build-directory:
3068         * Scripts/webkitperl/LoadAsModule.pm:
3069         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3070         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3071         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3072         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
3073         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
3074         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3075         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3076         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3077         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3078         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3079         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
3080         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
3081         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
3082         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3083         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3084         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3085         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3086         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
3087         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
3088         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
3089         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
3090         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
3091         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
3092         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3093         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3094         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3095         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
3096         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
3097         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
3098         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3099         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3100         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3101         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
3102         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
3103         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
3104         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3105         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3106         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3107         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
3108         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3109         * ccache/ccache-clang:
3110         * ccache/ccache-clang++:
3111         * ccache/ccache-wrapper:
3112         * gtk/install-dependencies:
3113         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
3114         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
3115         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
3116         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
3117         * iExploder/iexploder-1.3.2/tools/showtest.rb:
3118         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
3119         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
3120         * iExploder/iexploder-1.7.2/src/webserver.rb:
3121         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
3122         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
3123         * wpe/install-dependencies:
3124
3125 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
3126
3127         filter-build-webkit filters out useful compiler error lines
3128         https://bugs.webkit.org/show_bug.cgi?id=179864
3129
3130         Reviewed by Tim Horton.
3131
3132         Don't filter out lines that contain information about build errors by always showing lines
3133         after a line that contains "note:" or "error:".
3134
3135         * Scripts/filter-build-webkit:
3136         (shouldShowSubsequentLine):
3137         (shouldIgnoreLine):
3138
3139 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3140
3141         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
3142         https://bugs.webkit.org/show_bug.cgi?id=173915
3143
3144         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
3145         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
3146         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
3147         empty string in this case.
3148
3149         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3150         (emitFormSubmissionEvent):
3151
3152 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3153
3154         [GTK] Add web process API to detect when form is submitted via JavaScript
3155         https://bugs.webkit.org/show_bug.cgi?id=173915
3156
3157         Reviewed by Carlos Garcia Campos.
3158
3159         Test it.
3160
3161         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3162         (FormSubmissionTest::FormSubmissionTest):
3163         (FormSubmissionTest::~FormSubmissionTest):
3164         (FormSubmissionTest::testFormSubmissionResult):
3165         (FormSubmissionTest::willSendDOMEventCallback):
3166         (FormSubmissionTest::willCompleteCallback):
3167         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
3168         (testWebExtensionFormSubmissionSteps):
3169         (beforeAll):
3170         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3171         (DelayedSignal::DelayedSignal):
3172         (emitFormSubmissionEvent):
3173         (handleFormSubmissionCallback):
3174         (willSubmitFormCallback):
3175         (pageCreatedCallback):
3176
3177 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3178
3179         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
3180         https://bugs.webkit.org/show_bug.cgi?id=181251
3181
3182         * Scripts/run-gtk-tests:
3183         (GtkTestRunner):
3184
3185 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3186
3187         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
3188         https://bugs.webkit.org/show_bug.cgi?id=181136
3189
3190         * Scripts/run-gtk-tests:
3191         (GtkTestRunner):
3192
3193 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
3194
3195         [macOS, iOS] Adopt new secure coding APIs in WebKit
3196         https://bugs.webkit.org/show_bug.cgi?id=181085
3197         <rdar://problem/34837397>
3198
3199         Reviewed by Tim Horton.
3200
3201         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
3202         capable of supporting NSSecureCoding, so pass through the current coding routines.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
3205         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3206         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
3207         routines if necessary.
3208         (TEST): Updated for NSSecureCoding.
3209         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
3210         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
3211
3212 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3213
3214         Remove std::chrono completely
3215         https://bugs.webkit.org/show_bug.cgi?id=181186
3216
3217         Reviewed by Alex Christensen.
3218
3219         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3220         (WTR::TestController::platformRunUntil):
3221
3222 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3223
3224         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
3225         https://bugs.webkit.org/show_bug.cgi?id=181231
3226
3227         Reviewed by Alex Christensen.
3228
3229         Implement TestController APIs needed by ResourceLoadStatistics tests.
3230
3231         * WebKitTestRunner/TestController.cpp:
3232         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3233         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3234
3235 2018-01-02  Tim Horton  <timothy_horton@apple.com>
3236
3237         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
3238         https://bugs.webkit.org/show_bug.cgi?id=181219
3239
3240         Reviewed by Wenson Hsieh.
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3243
3244 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3245
3246         Add a WebAuthentication runtime feature flag
3247         https://bugs.webkit.org/show_bug.cgi?id=181220
3248         <rdar://problem/36055305>
3249
3250         Reviewed by Brent Fulgham.
3251
3252         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3253
3254         * DumpRenderTree/TestOptions.h:
3255         * DumpRenderTree/TestOptions.mm:
3256         (TestOptions::TestOptions):
3257         * DumpRenderTree/mac/DumpRenderTree.mm:
3258         (enableExperimentalFeatures):
3259         (setWebPreferencesForTestOptions):
3260         * WebKitTestRunner/TestController.cpp:
3261         (WTR::TestController::resetPreferencesToConsistentValues):
3262         (WTR::updateTestOptionsFromTestHeader):
3263         * WebKitTestRunner/TestOptions.h:
3264         (WTR::TestOptions::hasSameInitializationOptions const):
3265
3266 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3267
3268         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
3269         https://bugs.webkit.org/show_bug.cgi?id=181143
3270         <rdar://problem/36200381>
3271
3272         Reviewed by Tim Horton.
3273
3274         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
3275         attachment elements are enabled.
3276
3277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3278         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3279         (TestWebKitAPI::TEST):
3280
3281 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3282
3283         Update Credential Management API for WebAuthentication
3284         https://bugs.webkit.org/show_bug.cgi?id=181082
3285         <rdar://problem/36055239>
3286
3287         Reviewed by Brent Fulgham.
3288
3289         Enable Credential Management API for testing.
3290
3291         * DumpRenderTree/TestOptions.h:
3292         * WebKitTestRunner/TestOptions.h:
3293
3294 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3295
3296         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
3297         https://bugs.webkit.org/show_bug.cgi?id=168194
3298
3299         Reviewed by Carlos Garcia Campos.
3300
3301         Fix an assertion and unskip the test. The order that form controls are associated is not
3302         guaranteed.
3303
3304         * Scripts/run-gtk-tests:
3305         (GtkTestRunner):
3306         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3307         (didAssociateFormControlsCallback):
3308
3309 2018-01-02  Alex Christensen  <achristensen@webkit.org>
3310
3311         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
3312         https://bugs.webkit.org/show_bug.cgi?id=180897
3313         <rdar://problem/35535328>
3314
3315         Reviewed by Brent Fulgham.
3316
3317         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3320         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3321         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
3322         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3323         (websiteDataStoreTestWebView):
3324         (TEST):
3325
3326 == Rolled over to ChangeLog-2018-01-01 ==