The list of contributors in committers.py should be a separate JSON
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
2
3         The list of contributors in committers.py should be a separate JSON
4         https://bugs.webkit.org/show_bug.cgi?id=114673
5
6         Reviewed by Anders Carlsson.
7
8         Added webkitpy/common/config/contributors.json, made CommitterList load it.
9
10         * EWSTools/start-queue-mac.sh:
11         * EWSTools/start-queue.sh:
12         * Scripts/webkitpy/common/checkout/commitinfo.py:
13         (CommitInfo.committer):
14         * Scripts/webkitpy/common/config/contributors.json: Added.
15         * Scripts/webkitpy/common/config/committers.py:
16         (Reviewer.__init__):
17         (CommitterList.__init__):
18         (CommitterList.load_json): Added.
19         (CommitterList.load_json.emails):
20         (CommitterList.load_json.nicks):
21         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
22         (MockCommitInfo.author):
23
24 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
25
26         [EFL] Bump libsoup dependency to 2.42.0
27         https://bugs.webkit.org/show_bug.cgi?id=113927
28
29         Reviewed by Gyuyoung Kim.
30
31         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
32         required by libsoup for EFL port.
33
34         * efl/jhbuild.modules:
35         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
36         included in v2.42.0.
37
38 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
39
40         Remove Account class from committers.py
41         https://bugs.webkit.org/show_bug.cgi?id=114671
42
43         Reviewed by Csaba Osztrogonác.
44
45         Account class was added to support watch list email addresses that are not associated with
46         a particular contributor but nobody uses these email address since Chromium port forked.
47
48         Remove it.
49
50         Also removed account_by_login from CommitterList since it was never called except its unittests.
51
52         * Scripts/webkitpy/common/checkout/changelog.py:
53         * Scripts/webkitpy/common/config/committers.py:
54         (Contributor):
55         (Contributor.matches_glob):
56         (Reviewer.__init__):
57         (CommitterList.__init__):
58         (CommitterList._email_to_account_map):
59         (CommitterList._login_to_account_map):
60         (CommitterList.contributors_by_fuzzy_match):
61         (CommitterList.contributor_by_email):
62         (CommitterList.contributor_by_name):
63         (CommitterList.committer_by_email):
64         (CommitterList.reviewer_by_email):
65         * Scripts/webkitpy/common/config/committers_unittest.py:
66         (CommittersTest.test_committer_lookup):
67         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
68         (Bugzilla._commit_queue_flag):
69         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
70         (test_commit_queue_flag):
71         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
72         (WatchListParser._validate):
73
74 2013-04-16  Mike West  <mkwst@chromium.org>
75
76         Unreviewed update to the watchlist.
77
78         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
79         watchist file; moving to 'mkwst@chromium.org' instead.
80
81         * Scripts/webkitpy/common/config/committers.py:
82         * Scripts/webkitpy/common/config/watchlist:
83
84 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
85
86         Move webkitpy.layout_tests.port to webkitpy.port
87         https://bugs.webkit.org/show_bug.cgi?id=114668
88
89         Reviewed by Maciej Stachowiak.
90
91         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
92
93         * Scripts/webkitpy/common/host.py:
94         * Scripts/webkitpy/common/host_mock.py:
95         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
96         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
97         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
98         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
99         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
100         * Scripts/webkitpy/layout_tests/port: Removed.
101         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
102         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
103         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
104         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
105         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
106         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
107         * Scripts/webkitpy/performance_tests/perftest.py:
108         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
109         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
110         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
111         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
112         * Scripts/webkitpy/port/apple.py:
113         * Scripts/webkitpy/port/base.py:
114         * Scripts/webkitpy/port/base_unittest.py:
115         * Scripts/webkitpy/port/config_unittest.py:
116         (ConfigTest.test_default_configuration__standalone):
117         * Scripts/webkitpy/port/driver_unittest.py:
118         * Scripts/webkitpy/port/efl.py:
119         * Scripts/webkitpy/port/efl_unittest.py:
120         * Scripts/webkitpy/port/factory.py:
121         * Scripts/webkitpy/port/factory_unittest.py:
122         * Scripts/webkitpy/port/gtk.py:
123         * Scripts/webkitpy/port/gtk_unittest.py:
124         * Scripts/webkitpy/port/image_diff.py:
125         * Scripts/webkitpy/port/image_diff_unittest.py:
126         * Scripts/webkitpy/port/leakdetector_unittest.py:
127         * Scripts/webkitpy/port/mac.py:
128         * Scripts/webkitpy/port/mac_unittest.py:
129         * Scripts/webkitpy/port/mock_drt.py:
130         * Scripts/webkitpy/port/mock_drt_unittest.py:
131         * Scripts/webkitpy/port/port_testcase.py:
132         * Scripts/webkitpy/port/qt.py:
133         * Scripts/webkitpy/port/qt_unittest.py:
134         * Scripts/webkitpy/port/server_process_unittest.py:
135         * Scripts/webkitpy/port/test.py:
136         * Scripts/webkitpy/port/win.py:
137         * Scripts/webkitpy/port/win_unittest.py:
138         * Scripts/webkitpy/port/xvfbdriver.py:
139         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
140         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
141         * Scripts/webkitpy/tool/commands/gardenomatic.py:
142         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
143         * Scripts/webkitpy/tool/commands/queries.py:
144         * Scripts/webkitpy/tool/commands/queries_unittest.py:
145         * Scripts/webkitpy/tool/commands/rebaseline.py:
146         * Scripts/webkitpy/tool/servers/gardeningserver.py:
147         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
148         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
149         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
150
151 2013-04-16  Commit Queue  <rniwa@webkit.org>
152
153         Unreviewed, rolling out r148498.
154         http://trac.webkit.org/changeset/148498
155         https://bugs.webkit.org/show_bug.cgi?id=114669
156
157         Appears to have broken EWS (Requested by rniwa on #webkit).
158
159         * Scripts/webkitpy/common/config/ews.json: Removed.
160         * Scripts/webkitpy/tool/commands/__init__.py:
161         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
162         (AbstractEarlyWarningSystem):
163         (AbstractEarlyWarningSystem.__init__):
164         (AbstractEarlyWarningSystem.handle_script_error.does):
165         (GtkEWS):
166         (GtkWK2EWS):
167         (EflEWS):
168         (QtEWS):
169         (QtWK2EWS):
170         (WinEWS):
171         (MacEWS):
172         (MacWK2EWS):
173         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
174         (EarlyWarningSystemTest._default_expected_logs):
175         (_test_ews):
176         (test_ewses):
177
178 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
179
180         Isolate Early Warning System definitions into a JSON
181         https://bugs.webkit.org/show_bug.cgi?id=114558
182
183         Reviewed by Benjamin Poulain.
184
185         Added ews.json to common/config, and made tool/commands/__init__.py call
186         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
187
188         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
189         * Scripts/webkitpy/tool/commands/__init__.py:
190         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
191         (AbstractEarlyWarningSystem):
192         (AbstractEarlyWarningSystem.__init__):
193         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
194         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
195         (EarlyWarningSystemTest._default_expected_logs):
196         (_test_ews):
197         (test_ewses):
198
199 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
200
201         WKR gets stuck when there are many merges
202         https://bugs.webkit.org/show_bug.cgi?id=114632
203
204         Reviewed by Andreas Kling.
205
206         Move the last revision forward when it exists in a branch.
207         Otherwise, we'll be stuck looping over revisions made to merge patches.
208
209         * Scripts/webkitpy/tool/commands/newcommitbot.py:
210         (NewCommitBot.next_work_item):
211
212 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
213
214         [GTK] Missing a few packages for building on stock Fedora
215         https://bugs.webkit.org/show_bug.cgi?id=113916
216
217         Reviewed by Philippe Normand.
218
219         * gtk/install-dependencies: add packages that are missing.
220
221 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
222
223         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
224         https://bugs.webkit.org/show_bug.cgi?id=114602
225
226         Reviewed by Ryosuke Niwa.
227
228         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
229         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
230         interface so its value doesn't leak into the following tests.
231
232 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
233
234         Deprecate land-cowboy in favor of land-cowhand
235         https://bugs.webkit.org/show_bug.cgi?id=104470
236
237         Reviewed by Darin Adler.
238
239         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
240
241         * Scripts/webkitpy/tool/commands/download.py:
242         (LandCowhand):
243         (LandCowboy):
244         (LandCowboy._prepare_state):
245         * Scripts/webkitpy/tool/commands/download_unittest.py:
246         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
247         also checking the deprecation message in the output of the latter.
248
249 2013-04-15  Jonathan Liu  <net147@gmail.com>
250
251         Improve Windows cmd.exe detection
252         https://bugs.webkit.org/show_bug.cgi?id=114620
253
254         Reviewed by Jocelyn Turcotte.
255
256         The current detection code handles Windows cmd.exe and Cygwin shell
257         but not does not handle MSYS shell correctly. Simplify and improve the
258         detection by checking MINGW_IN_SHELL instead as used in other places
259         (e.g. qt_functions.prf).
260
261         * qmake/mkspecs/features/default_pre.prf:
262
263 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
264
265         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
266         https://bugs.webkit.org/show_bug.cgi?id=114506
267
268         Reviewed by Philippe Normand.
269
270         * Scripts/webkitpy/common/system/executive.py:
271         (Executive.cpu_count): Modify function in order to use the environment
272         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
273         greater than 0.
274
275 2013-04-15  Xan Lopez  <xlopez@igalia.com>
276
277         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
278         https://bugs.webkit.org/show_bug.cgi?id=114615
279
280         Reviewed by Carlos Garcia Campos.
281
282         Enable the style scoped feature if we have support for it.
283
284         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
285         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
286
287 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
288
289         [Qt] QtMultimedia not used when GStreamer is not found
290         https://bugs.webkit.org/show_bug.cgi?id=111842
291
292         Reviewed by Philippe Normand.
293
294         Fallback to using QtMultimedia when native libraries are not found.
295
296         * qmake/mkspecs/features/features.prf:
297
298 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
299
300         Build fix attempt for webkitbot. Unicodify everything.
301
302         * Scripts/webkitpy/tool/bot/irc_command.py:
303         (Whois.execute):
304
305 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
306
307         webkitbot should provide full name, email address, and IRC nicknames on whois
308         https://bugs.webkit.org/show_bug.cgi?id=114494
309
310         Reviewed by Benjamin Poulain.
311
312         A response like the one below is useless. Improve it:
313         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
314
315         We now report full name, email address, committer/reviewer status, and IRC nickname.
316
317         Also teach webkitbot how to respond to ping.
318
319         * Scripts/webkitpy/tool/bot/irc_command.py:
320         (PingPong): Moved 
321         (PingPong.execute):
322         (Whois._full_record_and_nick): Renamed and rewritten.
323         (Whois.execute):
324
325         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
326         (IRCCommandTest.test_whois): Updated test cases as needed.
327
328         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
329         (IRCBotTest.test_help): Added ping.
330
331         * Scripts/webkitpy/tool/commands/newcommitbot.py:
332         (NewCommitBot): Teached WKR how to respond to hi.
333
334 2013-04-13  Anders Carlsson  <andersca@apple.com>
335
336         Add form delegate method that's invoked right before sending a submit event to a form element
337         https://bugs.webkit.org/show_bug.cgi?id=114575
338
339         Reviewed by Dan Bernstein.
340
341         Add a test.
342
343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
344         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
345         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
346         (TestWebKitAPI):
347         (TestWebKitAPI::TEST):
348         
349         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
350         (TestWebKitAPI::Util::toSTD):
351         Don't crash when a null NSString is passed to toSTD.
352
353 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
354
355         Python test fix attempt after r148360.
356
357         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
358         (test_command_help):
359
360 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
361
362         Merge AbstractDeclarativeCommand into Command as a comment suggests
363         https://bugs.webkit.org/show_bug.cgi?id=114559
364
365         Reviewed by Antti Koivisto.
366
367         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
368         We need to merge a lot more classes to make webkitpy hackable.
369
370         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
371         (AbstractLocalServerCommand):
372         (AbstractLocalServerCommand.__init__):
373         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
374         (AbstractSequencedCommand):
375         (AbstractSequencedCommand.__init__):
376         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
377         (AddUsersToGroups):
378         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
379         (AnalyzeChangeLog):
380         (AnalyzeChangeLog.__init__):
381         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
382         * Scripts/webkitpy/tool/commands/bugfortest.py:
383         (BugForTest):
384         * Scripts/webkitpy/tool/commands/bugsearch.py:
385         (BugSearch):
386         * Scripts/webkitpy/tool/commands/chromechannels.py:
387         (ChromeChannels):
388         (__init__):
389         * Scripts/webkitpy/tool/commands/download.py:
390         (AbstractPatchProcessingCommand):
391         * Scripts/webkitpy/tool/commands/findusers.py:
392         (FindUsers):
393         * Scripts/webkitpy/tool/commands/openbugs.py:
394         (OpenBugs):
395         * Scripts/webkitpy/tool/commands/queries.py:
396         (BugsToCommit):
397         (PatchesInCommitQueue):
398         (PatchesToCommitQueue):
399         (PatchesToCommitQueue.__init__):
400         (PatchesToReview):
401         (PatchesToReview.__init__):
402         (PatchesToReview.execute):
403         (WhatBroke):
404         (ResultsFor):
405         (FailureReason):
406         (FindFlakyTests):
407         (TreeStatus):
408         (CrashLog):
409         (PrintExpectations):
410         (PrintExpectations.__init__):
411         (PrintBaselines):
412         (PrintBaselines.__init__):
413         * Scripts/webkitpy/tool/commands/queues.py:
414         (AbstractQueue.__init__):
415         * Scripts/webkitpy/tool/commands/rebaseline.py:
416         (AbstractRebaseliningCommand):
417         * Scripts/webkitpy/tool/commands/suggestnominations.py:
418         (SuggestNominations):
419         (SuggestNominations.__init__):
420         * Scripts/webkitpy/tool/commands/upload.py:
421         (CommitMessageForCurrentDiff):
422         (CommitMessageForCurrentDiff.__init__):
423         (CleanPendingCommit):
424         (CleanReviewQueue):
425         (AssignToCommitter):
426         (PostCommits):
427         (PostCommits.__init__):
428         (MarkBugFixed):
429         (MarkBugFixed.__init__):
430         (CreateBug):
431         (CreateBug.__init__):
432         * Scripts/webkitpy/tool/multicommandtool.py:
433         (Command):
434         (Command.__init__):
435         (Command.main):
436         (HelpCommand):
437         (HelpCommand.__init__):
438         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
439         (TrivialCommand):
440         (TrivialCommand.__init__):
441         (LikesToRetry):
442         (LikesToRetry.__init__):
443         (CommandTest.test_name_with_arguments):
444         (CommandTest.test_required_arguments):
445         (test_command_help):
446
447 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
448
449         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
450         https://bugs.webkit.org/show_bug.cgi?id=114048
451
452         Reviewed by Gyuyoung Kim.
453
454         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
455
456         * DumpRenderTree/efl/TestRunnerEfl.cpp:
457         (TestRunner::setViewModeMediaFeature):
458
459 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
460
461         Merge watchlistloader into host since it's an unnecessary indirection
462         https://bugs.webkit.org/show_bug.cgi?id=114555
463
464         Reviewed by Antti Koivisto.
465
466         We don't need a class to load a file.
467
468         * Scripts/webkitpy/common/host.py:
469         (Host.watch_list):
470         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
471         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
472
473 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
474
475         Rename JSONResultsGeneratorBase to JSONResultsGenerator
476         https://bugs.webkit.org/show_bug.cgi?id=114553
477
478         Reviewed by Philippe Normand.
479
480         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
481
482         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
483         (JSONLayoutResultsGenerator):
484         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
485         (JSONResultsGenerator):
486         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
487         (JSONGeneratorTest._test_json_generation):
488         (JSONGeneratorTest._verify_json_results):
489
490 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
491
492         Remove more Chromium specific code from webkitpy
493         https://bugs.webkit.org/show_bug.cgi?id=114552
494
495         Reviewed by Philippe Normand.
496
497         * Scripts/webkitpy/common/host.py:
498         (Host.checkout):
499         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
500         (JSONResultsGeneratorBase):
501         (JSONResultsGeneratorBase.__init__):
502         (JSONResultsGeneratorBase._is_results_all_of_type):
503         * Scripts/webkitpy/layout_tests/port/base.py:
504         (Port):
505         (Port.expected_filename):
506         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
507         (PerfTestsRunner._parse_args):
508         * Scripts/webkitpy/tool/commands/queues.py:
509         (PatchProcessingQueue._new_port_name_from_old):
510         (CommitQueue.did_pass_testing_ews):
511         * Scripts/webkitpy/tool/commands/rebaseline.py:
512         (RebaselineTest._results_url):
513         (Rebaseline._builder_with_name):
514         * Scripts/webkitpy/tool/mocktool.py:
515         (MockTool.irc):
516
517 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
518
519         Fix flakiness dashboard unit test failures
520         https://bugs.webkit.org/show_bug.cgi?id=114518
521
522         Reviewed by Ryosuke Niwa.
523
524         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
525         test cases to simulate loading the builders list from the webkit.org build master, replacing
526         the Chromium builders and platforms that are used in tests with builders and platforms for the
527         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
528         functionality of the dashboard.
529
530         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
531         code and hopefully general simplification of the dashboard codebase coming in near future.
532
533         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
534         (resetGlobals):
535         (test):
536         * TestResultServer/static-dashboards/loader_unittests.js:
537
538 2013-04-12  David Kilzer  <ddkilzer@apple.com>
539
540         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
541
542         Reviewed by Chris Fleizach.
543
544         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
545         -_accessibilityPath from the WebAccessibilityObjectWrapper
546         class.
547         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
548
549 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
550
551         Unreviewed, remove an old email address for myself.
552
553         * Scripts/webkitpy/common/config/committers.py:
554
555 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
556
557         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
558         https://bugs.webkit.org/show_bug.cgi?id=110743
559
560         Reviewed by Benjamin Poulain.
561
562         Adding a new test file to check if loading a page just after WebProcess
563         has crashed (or was terminated) works. The test executes the
564         following steps (Load, Crash, Load), thus stressing WebProcess
565         reattach and process termination code path.
566
567         * TestWebKitAPI/GNUmakefile.am:
568         * TestWebKitAPI/PlatformEfl.cmake:
569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
570         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
571         (TestWebKitAPI::setPageLoaderClient):
572         (TestWebKitAPI::TEST):
573         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
574         (TestWebKitAPI):
575         (WebKit2CrashLoader):
576         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
577         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
578         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
579         (TestWebKitAPI::didFinishLoad):
580         (TestWebKitAPI::TEST):
581         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
582
583 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
584
585         [Mac] REGRESSION: Auto substitution strips new lines
586         https://bugs.webkit.org/show_bug.cgi?id=114537
587
588         Reviewed by Enrica Casucci.
589
590         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
591
592         * DumpRenderTree/mac/DumpRenderTree.mm:
593         (resetDefaultsToConsistentValues):
594
595 2013-04-09  Roger Fong  <roger_fong@apple.com>
596
597         Re-enable WinEWS tests.
598
599         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
600         (WinEWS):
601
602 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
603
604         [GTK] Split GtkAuthenticationDialog in two widgets
605         https://bugs.webkit.org/show_bug.cgi?id=103644
606
607         Reviewed by Xan Lopez.
608
609         * gtk/generate-gtkdoc:
610         (get_webkit2_options): Do not generate api docs for
611         WebKitAuthenticationDialog which is private in WebKit2.
612         (get_webkit1_options): Do not generate api docs for
613         webkitauthenticationdialog which is private in WebKit1.
614
615 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
616
617         WebKit Queues should capitalize K in Wk2
618         https://bugs.webkit.org/show_bug.cgi?id=114524
619
620         Reviewed by Philippe Normand.
621
622         * QueueStatusServer/model/queues.py:
623         (Queue.display_name):
624
625 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
626
627         [Mac] Enable spellchecking tests added in r141471
628         https://bugs.webkit.org/show_bug.cgi?id=108525
629
630         Reviewed by Darin Adler.
631
632         * DumpRenderTree/mac/DumpRenderTree.mm:
633         (createWebViewAndOffscreenWindow):
634         (resetDefaultsToConsistentValues):
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::TestController::resetStateToConsistentValues):
637
638 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
639
640         [GTK] Enable WebKit2 building on GTK EWSs
641         https://bugs.webkit.org/show_bug.cgi?id=114500
642
643         Reviewed by Philippe Normand.
644
645         Add configuration in order to be able to setup GTK EWSs building
646         WebKit2. A new queue gtk-wk2-ews is added.
647
648         * QueueStatusServer/config/queues.py:
649         * Scripts/webkitpy/common/config/ports.py:
650         (DeprecatedPort.port):
651         (GtkWK2Port):
652         (GtkWK2Port.build_webkit_command):
653         (GtkWK2Port.run_webkit_tests_command):
654         * Scripts/webkitpy/common/config/ports_unittest.py:
655         (DeprecatedPortTest.test_gtk_port):
656         (DeprecatedPortTest):
657         (DeprecatedPortTest.test_gtk_wk2_port):
658         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
659         (GtkWK2EWS):
660
661 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
662
663         Remove Chromium scripts
664         https://bugs.webkit.org/show_bug.cgi?id=114492
665
666         Reviewed by Benjamin Poulain.
667
668         * Scripts/run-chromium-webkit-unit-tests: Removed.
669         * Scripts/update-webkit-chromium: Removed.
670
671 2013-04-12  Commit Queue  <rniwa@webkit.org>
672
673         Unreviewed, rolling out r148262.
674         http://trac.webkit.org/changeset/148262
675         https://bugs.webkit.org/show_bug.cgi?id=114493
676
677         Cairo dep should now build, rolling r148247 back in (Requested
678         by zdobersek on #webkit).
679
680         * Scripts/webkitdirs.pm:
681         (buildAutotoolsProject):
682         * gtk/jhbuild.modules:
683
684 2013-04-11  Commit Queue  <rniwa@webkit.org>
685
686         Unreviewed, rolling out r148247.
687         http://trac.webkit.org/changeset/148247
688         https://bugs.webkit.org/show_bug.cgi?id=114490
689
690         Cairo dep fails to build on builders due to missing EGL
691         headers (Requested by zdobersek on #webkit).
692
693         * Scripts/webkitdirs.pm:
694         (buildAutotoolsProject):
695         * gtk/jhbuild.modules:
696
697 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
698
699         [GTK] Add accelerated 2D canvas support using cairo-gl
700         https://bugs.webkit.org/show_bug.cgi?id=104672
701
702         Reviewed by Alejandro G. Castro.
703
704         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
705         dependencies, don't override value of the setting determined by configure.
706         This will make it easier for people using build-webkit, but not the
707         WebKit JHBuild.
708
709         * Scripts/webkitdirs.pm:
710         (buildAutotoolsProject): Add a blacklist for settings to never override.
711         * gtk/jhbuild.modules: Build CairoGL.
712
713 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
714
715         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
716         https://bugs.webkit.org/show_bug.cgi?id=114477
717
718         Reviewed by Benjamin Poulain.
719
720         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
721
722 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
723
724         Leaks builder should not be triggered upon new commits
725         https://bugs.webkit.org/show_bug.cgi?id=114475
726
727         Reviewed by Jessie Berlin.
728
729         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
730         the leak builder when builds are done.
731
732         * BuildSlaveSupport/build.webkit.org-config/config.json:
733
734 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
735
736         [GTK] Windows build failure after r136056
737         https://bugs.webkit.org/show_bug.cgi?id=114121
738
739         Reviewed by Martin Robinson.
740
741         * TestWebKitAPI/config.h: Make sure defines are correct for other
742         Windows ports than apple-win.
743
744 2013-04-11  Ojan Vafai  <ojan@chromium.org>
745
746         Remove myself from watchlists.
747         * Scripts/webkitpy/common/config/watchlist:
748
749 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
750
751         Build fix. Don't hard-code queues.webkit.org at least during the transition.
752
753         * QueueStatusServer/templates/statusbubble.html:
754
755 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
756
757         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
758         https://bugs.webkit.org/show_bug.cgi?id=114397
759
760         Reviewed by Benjamin Poulain.
761
762         Reland the patch since Alan appears to have finished the migration.
763
764         * Scripts/webkitpy/common/net/statusserver.py:
765         (StatusServer):
766
767 2013-04-11  Brian Holt  <brian.holt@samsung.com>
768
769         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
770         https://bugs.webkit.org/show_bug.cgi?id=76796
771
772         Reviewed by Chris Fleizach.
773
774         Make the Gtk window for the DRT a toplevel so that it gets the
775         focus from the window manager when the test starts.
776
777         * DumpRenderTree/gtk/DumpRenderTree.cpp:
778         (main):
779
780 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
781
782         Use CSS4 image-rendering to determing image scaling quality
783         https://bugs.webkit.org/show_bug.cgi?id=113405
784
785         Reviewed by Simon Fraser.
786
787         Introduce new flag to enable experimental support for CSS4 Images.
788
789         * Scripts/webkitperl/FeatureList.pm:
790
791 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
792
793         Remove code for Chromium from wkbuild.py
794         https://bugs.webkit.org/show_bug.cgi?id=114423
795
796         Reviewed by Benjamin Poulain.
797
798         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
799         (_should_file_trigger_build):
800         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
801         (ShouldBuildTest):
802
803 2013-04-11  Philippe Normand  <pnormand@igalia.com>
804
805         Unreviewed, update my IRC nickname.
806
807         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
808
809 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
810
811         Remove the rest of Chromium code from webkitpy
812         https://bugs.webkit.org/show_bug.cgi?id=114420
813
814         Reviewed by Benjamin Poulain.
815
816         * Scripts/webkitpy/common/config/urls.py:
817         (view_revision_url):
818         * Scripts/webkitpy/common/host.py:
819         (Host._engage_awesome_locale_hacks):
820         (Host.initialize_scm):
821         (Host):
822         * Scripts/webkitpy/common/host_mock.py:
823         (MockHost.__init__):
824         (MockHost.checkout):
825         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
826         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
827         (JSONResultsGeneratorBase._insert_generic_metadata):
828         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
829         (TestExpectationParser._tokenize_line):
830         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
831         (ExpectationSyntaxTests.test_bare_name_and_bugs):
832         (ExpectationSyntaxTests.test_warnings):
833         * Scripts/webkitpy/layout_tests/port/base.py:
834         (Port.skips_perf_test):
835         (Port.path_to_test_expectations_file):
836         (Port._port_flag_for_scripts):
837         * Scripts/webkitpy/style/checkers/cpp.py:
838         (check_function_definition):
839         (check_include_line):
840         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
841         (OrderOfIncludesTest.test_check_wtf_includes):
842         (WebKitStyleTest.test_webkit_export_check):
843         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
844         (TestExpectationsTestCase.test_valid_expectations):
845         * Scripts/webkitpy/tool/bot/irc_command.py:
846         (Rollout.execute):
847         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
848         (IRCCommandTest.test_whois):
849         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
850         (IRCBotTest.test_help):
851         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
852         (SheriffBotTest.test_command_aliases):
853
854 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
855
856         roll-chromium-deps doesn't roll DEPS
857         https://bugs.webkit.org/show_bug.cgi?id=114421
858
859         Reviewed by Antti Koivisto.
860
861         Roll DEPS. Rolling DEPS. Rolled DEPS.
862
863         * Scripts/webkitpy/tool/bot/irc_command.py:
864         (RollChromiumDEPS.execute):
865
866 2013-04-11  Glenn Adams  <glenn@skynav.com>
867
868         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
869         https://bugs.webkit.org/show_bug.cgi?id=114418
870
871         Reviewed by Ryosuke Niwa.
872
873         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
874         (MockSCM.add): Remove optional remove_exit_code argument.
875         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
876         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
877         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
878         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
879
880 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
881
882         Fix roll-chromium-deps and hi.
883
884         * Scripts/webkitpy/tool/bot/irc_command.py:
885         (Hi.execute):
886         (RollChromiumDEPS.execute):
887
888 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
889
890         Remove webkitpy code to roll Chromium DEPS
891         https://bugs.webkit.org/show_bug.cgi?id=114415
892
893         Reviewed by Benjamin Poulain.
894
895         Removed the code to roll Chromium DEPS in WebKit.
896
897         * Scripts/webkitpy/common/checkout/checkout.py:
898         (Checkout.bug_id_for_this_commit):
899         * Scripts/webkitpy/common/checkout/checkout_mock.py:
900         (MockCheckout.commit_message_for_this_commit):
901         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
902         (CheckoutTest.test_suggested_reviewers):
903         * Scripts/webkitpy/common/checkout/deps.py: Removed.
904         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
905         * Scripts/webkitpy/tool/bot/irc_command.py:
906         (RollChromiumDEPS): Teach webkitbot a sense of humor.
907         (RollChromiumDEPS.execute):
908         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
909         (IRCCommandTest.test_create_bug):
910         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
911         (IRCBotTest.test_revert):
912         * Scripts/webkitpy/tool/bot/sheriff.py:
913         (Sheriff.post_rollout_patch):
914         * Scripts/webkitpy/tool/commands/__init__.py:
915         * Scripts/webkitpy/tool/commands/roll.py: Removed.
916         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
917         * Scripts/webkitpy/tool/steps/__init__.py:
918         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
919         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
920         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
921
922 2013-04-11  Glenn Adams  <glenn@skynav.com>
923
924         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
925         https://bugs.webkit.org/show_bug.cgi?id=114386
926
927         Reviewed by Benjamin Poulain.
928
929         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
930         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
931         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
932         by default and to return exit code 1 if a file/dir had already been added.
933
934         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
935         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
936         * Scripts/webkitpy/common/checkout/scm/svn.py:
937         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
938
939 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
940
941         Unreviewed.
942
943         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
944
945 2013-04-10  Glenn Adams  <glenn@skynav.com>
946
947         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
948         https://bugs.webkit.org/show_bug.cgi?id=114410
949
950         Reviewed by Ryosuke Niwa.
951
952         * Scripts/webkitpy/common/checkout/scm/git.py:
953         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
954         * Scripts/webkitpy/common/checkout/scm/scm.py:
955         (SCM.add): Remove optional return_exit_code argument.
956         (SCM.add_list): Remove optional return_exit_code argument.
957         * Scripts/webkitpy/common/checkout/scm/svn.py:
958         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
959
960 2013-04-10  Eric Seidel  <eric@webkit.org>
961
962         Remove myself from the watchlists, I'm getting too much bug mail. :)
963
964         * Scripts/webkitpy/common/config/watchlist:
965
966 2013-04-10  Commit Queue  <rniwa@webkit.org>
967
968         Unreviewed, rolling out r148158.
969         http://trac.webkit.org/changeset/148158
970         https://bugs.webkit.org/show_bug.cgi?id=114405
971
972         We need to migrate status data (Requested by rniwa on
973         #webkit).
974
975         * Scripts/webkitpy/common/net/statusserver.py:
976         (StatusServer):
977
978 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
979
980         Mass remove all the empty directories
981
982         Rubberstamped by Ryosuke Niwa.
983
984         * BuildSlaveSupport/gtk/crashmon/log: Removed.
985         * BuildSlaveSupport/gtk/xvfb/log: Removed.
986         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
987         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
988         * MiniBrowser/gtk/WebBundle: Removed.
989         * MiniBrowser/win: Removed.
990         * QtTestPlatformPlugin/mac: Removed.
991         * Scripts/webkitpy/tool/bot/testdata: Removed.
992         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
993         * efl/ImageDiff: Removed.
994         * iExploder/htdocs: Removed.
995         * iExploder/iexploder-1.7.2/output: Removed.
996         * iExploder/tools: Removed.
997         * qmake/config.tests/libexecdir: Removed.
998         * qmake/config.tests/libjpeg: Removed.
999         * qmake/config.tests/libpng: Removed.
1000
1001 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1002
1003         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1004         https://bugs.webkit.org/show_bug.cgi?id=114397
1005
1006         Reviewed by Benjamin Poulain.
1007
1008         * Scripts/webkitpy/common/net/statusserver.py:
1009         (StatusServer):
1010
1011 2013-04-10  Adam Barth  <abarth@webkit.org>
1012
1013         Remove abarth from watchlists
1014         https://bugs.webkit.org/show_bug.cgi?id=114390
1015
1016         Reviewed by Ryosuke Niwa.
1017
1018         I'm trying to cut down on the amount of bugmail I get so that I'll have
1019         more of a chance to notice a piece of bugmail directed at me.
1020
1021         * Scripts/webkitpy/common/config/watchlist:
1022
1023 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1026         https://bugs.webkit.org/show_bug.cgi?id=114381
1027
1028         Reviewed by Benjamin Poulain.
1029
1030         Changed the defaults.
1031
1032         * TestResultServer/static-dashboards/builders.js:
1033         * TestResultServer/static-dashboards/dashboard_base.js:
1034         (currentBuilderGroupCategory):
1035
1036 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1037
1038         Remove Chromium EWS bots from the queue status server
1039         https://bugs.webkit.org/show_bug.cgi?id=113988
1040
1041         Reviewed by Benjamin Poulain.
1042
1043         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1044
1045         * QueueStatusServer/app.yaml:
1046         * QueueStatusServer/config/queues.py:
1047         * QueueStatusServer/model/queues.py:
1048         (Queue.short_name):
1049         (Queue.display_name):
1050         * QueueStatusServer/model/queues_unittest.py:
1051         (QueueTest.test_short_name):
1052         (QueueTest.test_display_name):
1053         (QueueTest.test_name_with_underscores):
1054         * QueueStatusServer/templates/activebots.html:
1055
1056 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1057
1058         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1059         https://bugs.webkit.org/show_bug.cgi?id=114370
1060
1061         Reviewed by Ryosuke Niwa.
1062
1063         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1064         Unfortunately, there's no way to test this until this is committed and there is
1065         a master restart.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1073         * TestResultServer/generate_builders_json.py:
1074         * TestResultServer/static-dashboards/dashboard_base.js:
1075         * TestResultServer/static-dashboards/loader.js:
1076
1077 2013-04-10  Glenn Adams  <glenn@skynav.com>
1078
1079         [Qt] Fix regression to test-webkitpy.
1080         https://bugs.webkit.org/show_bug.cgi?id=114368
1081
1082         Reviewed by Ryosuke Niwa.
1083
1084         * Scripts/webkitpy/layout_tests/port/factory.py:
1085         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1086         (PortFactory.get): Remove obsolete chromium port related code.
1087         * Scripts/webkitpy/layout_tests/port/mac.py:
1088         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1089
1090 2013-04-10  Anders Carlsson  <andersca@apple.com>
1091
1092         Remove unneeded headers from FrameLoader.h
1093         https://bugs.webkit.org/show_bug.cgi?id=114223
1094
1095         Reviewed by Geoffrey Garen.
1096
1097         Add back headers implicitly included by other headers.
1098
1099         * WebKitTestRunner/WorkQueueManager.cpp:
1100
1101 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1102
1103         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1104         https://bugs.webkit.org/show_bug.cgi?id=114365
1105
1106         Reviewed by Martin Robinson.
1107
1108         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1109         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1110         at-spi2-atk source tree and will be available with the next stable release, after which the
1111         patch should be removed and the dependency version bumped.
1112
1113         * gtk/jhbuild.modules:
1114         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1115
1116 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1117
1118         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1119
1120         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1121         match change in DropBox server behavior.
1122
1123 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1124
1125         Removed an annoying message from svn-create-patch
1126         https://bugs.webkit.org/show_bug.cgi?id=114332
1127
1128         Reviewed by Alexey Proskuryakov.
1129
1130         I see this message basically every time I write a patch, so it must not
1131         be true.
1132
1133         * Scripts/svn-create-patch:
1134         (generateDiff):
1135
1136 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1137
1138         [GTK] Add support for Page Visibility
1139         https://bugs.webkit.org/show_bug.cgi?id=97324
1140
1141         Reviewed by Sam Weinig.
1142
1143         Implemented test runner API for page visibility layout tests.
1144
1145         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1146         (TestRunner::resetPageVisibility):
1147         (TestRunner::setPageVisibility):
1148         * Scripts/webkitperl/FeatureList.pm:
1149
1150 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1151
1152         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1153         https://bugs.webkit.org/show_bug.cgi?id=114342
1154
1155         Reviewed by Gyuyoung Kim.
1156
1157         Commit 148033 only added an implementation for the Mac port, which made
1158         other ports fail most tests since loading the injected bundle failed
1159         with a missing symbol.
1160
1161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1162         (WTR::AccessibilityUIElement::pathDescription):
1163
1164 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1165
1166         [EFL] Add spell checking option to MiniBrowser
1167         https://bugs.webkit.org/show_bug.cgi?id=114282
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         Spell checking is enabled by adding a flag (t/text-checking)
1172         with launching MiniBrowser.
1173
1174         * MiniBrowser/efl/main.c:
1175         (window_create):
1176         (elm_main):
1177
1178 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1179
1180         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1181         https://bugs.webkit.org/show_bug.cgi?id=113281
1182
1183         Reviewed by Darin Adler.
1184
1185         * Scripts/run-gtk-tests:
1186         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1187
1188 2013-04-09  Glenn Adams  <glenn@skynav.com>
1189
1190         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1191
1192         Unreviewed.
1193
1194         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1195         (RunTest.test_build_check):
1196
1197 2013-04-09  Glenn Adams  <glenn@skynav.com>
1198
1199         [webkitpy] Remove chromium ports.
1200         https://bugs.webkit.org/show_bug.cgi?id=114326
1201
1202         Reviewed by Dirk Pranke.
1203
1204         As a side effect, also:
1205
1206         - remove chromium builders from webkitpy.layout_tests.port.builders
1207         - remove chromium builders from rebaseline
1208         - rewrite chromium dependent tests in rebaseline_unittest
1209         - remove chromium platform from garden-o-matic
1210         - select apple platform as default platform in garden-o-matic
1211         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1215         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1216         (BaselineOptimizerTest.test_move_baselines):
1217         (BaselineOptimizerTest.test_efl):
1218         (BaselineOptimizerTest.test_no_add_mac_future):
1219         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1220         (BaselineOptimizerTest.test_common_directory_includes_root):
1221         (BaselineOptimizerTest.test_complex_shadowing):
1222         (BaselineOptimizerTest.test_virtual_ports_filtered):
1223         * Scripts/webkitpy/layout_tests/port/builders.py:
1224         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1225         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1226         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1227         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1228         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1229         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1230         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1231         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1232         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1233         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1234         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1235         * Scripts/webkitpy/layout_tests/port/factory.py:
1236         (platform_options):
1237         (PortFactory):
1238         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1239         (FactoryTest.test_qt):
1240         (FactoryTest.test_get_from_builder_name):
1241         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1242         (RunTest.test_build_check):
1243         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1244         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1245         * Scripts/webkitpy/tool/commands/rebaseline.py:
1246         (Rebaseline._builders_to_pull_from):
1247         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1248         (_BaseTestCase):
1249         (_BaseTestCase.setUp):
1250         (TestRebaselineTest.setUp):
1251         (TestRebaselineTest.test_baseline_directory):
1252         (test_rebaseline_updates_expectations_file):
1253         (test_rebaseline_does_not_include_overrides):
1254         (test_rebaseline_test):
1255         (test_rebaseline_test_and_print_scm_changes):
1256         (test_rebaseline_and_copy_test):
1257         (test_rebaseline_and_copy_test_no_existing_result):
1258         (test_rebaseline_and_copy_test_with_lion_result):
1259         (test_rebaseline_and_copy_no_overwrite_test):
1260         (TestRebaselineExpectations.test_rebaseline_expectations):
1261
1262 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1263
1264         newcommitbot (WKR) requires a subversion checkout
1265         https://bugs.webkit.org/show_bug.cgi?id=114309
1266
1267         Reviewed by Benjamin Poulain.
1268
1269         Directly talk to the subversion server instead of relying on a local checkout.
1270         This allows us to run WKR off of a git clone.
1271
1272         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1273         (NewCommitBot.next_work_item):
1274         (NewCommitBot.process_work_item):
1275
1276 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1277
1278         webkitbot refers to sheriffbot in help
1279         https://bugs.webkit.org/show_bug.cgi?id=114307
1280
1281         Reviewed by Benjamin Poulain.
1282
1283         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1284
1285         * Scripts/webkitpy/tool/bot/irc_command.py:
1286         (Help):
1287         (Help.execute):
1288         (RollChromiumDEPS.execute):
1289         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1290         (IRCBotTest.test_help):
1291         * Scripts/webkitpy/tool/bot/sheriff.py:
1292         (Sheriff.name):
1293
1294 2013-04-06  Roger Fong  <roger_fong@apple.com>
1295
1296         Kill old processes between runs on WinEWS bots.
1297         Temporarily disable tests to let bots catch up again.
1298
1299         * EWSTools/start-queue-win.sh:
1300         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1301         (WinEWS):
1302
1303 2013-04-09  Glenn Adams  <glenn@skynav.com>
1304
1305         [webkitpy] Remove chromium deprecated port support.
1306         https://bugs.webkit.org/show_bug.cgi?id=114228
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         * Scripts/webkitpy/common/config/ports.py:
1311         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1312         (ChromiumPort): Removed.
1313         (ChromiumAndroidPort): Removed.
1314         (ChromiumXVFBPort): Removed.
1315         * Scripts/webkitpy/common/config/ports_unittest.py:
1316         (DeprecatedPortTest.test_chromium_port): Removed.
1317         (DeprecatedPortTest.test_chromium_android_port): Removed.
1318         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1319         * Scripts/webkitpy/tool/steps/update_unittest.py:
1320         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1321         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1322
1323 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1324
1325         AX: The bounding paths should be made available through accessibility
1326         https://bugs.webkit.org/show_bug.cgi?id=113817
1327
1328         Reviewed by David Kilzer.
1329
1330         Add a pathDescription property for testing so that it's possible
1331         to verify that a path is being returned correctly.
1332
1333         * DumpRenderTree/AccessibilityUIElement.cpp:
1334         (getPathDescriptionCallback):
1335         (AccessibilityUIElement::pathDescription):
1336         (AccessibilityUIElement::getJSClass):
1337         * DumpRenderTree/AccessibilityUIElement.h:
1338         (AccessibilityUIElement):
1339         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1340         (_CGPathEnumerationIteration):
1341         (AccessibilityUIElement::pathDescription):
1342         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1343         (AccessibilityUIElement::pathDescription):
1344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1345         (WTR::AccessibilityUIElement::pathDescription):
1346         (WTR):
1347         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1348         (AccessibilityUIElement):
1349         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1351         (WTR::AccessibilityUIElement::pathDescription):
1352         (WTR):
1353
1354 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1355
1356         [EFL] Declare TEST_THEME_DIR in a single place.
1357         https://bugs.webkit.org/show_bug.cgi?id=114285
1358
1359         Reviewed by Anders Carlsson.
1360
1361         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1362
1363         * DumpRenderTree/efl/CMakeLists.txt:
1364         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1365         (DumpRenderTreeChrome::createView):
1366         (DumpRenderTreeChrome::createInspectorView):
1367         (DumpRenderTreeChrome::initialize):
1368         (DumpRenderTreeChrome::onDownloadRequest):
1369         * EWebLauncher/CMakeLists.txt:
1370         * EWebLauncher/main.c:
1371         (findThemePath):
1372         * EWebLauncher/url_bar.c:
1373         (url_bar_add):
1374         * MiniBrowser/efl/CMakeLists.txt:
1375         * MiniBrowser/efl/main.c:
1376         (window_create):
1377         * TestWebKitAPI/PlatformEfl.cmake:
1378         * TestWebKitAPI/efl/PlatformWebView.cpp:
1379         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1380         * WebKitTestRunner/PlatformEfl.cmake:
1381         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1382         (WTR::PlatformWebView::PlatformWebView):
1383
1384 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1385
1386         [GTK][AC] upversion of clutter and its dependecy
1387         https://bugs.webkit.org/show_bug.cgi?id=114016
1388
1389         Reviewed by Gustavo Noronha Silva.
1390
1391         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1392
1393         * gtk/jhbuild-optional.modules:
1394
1395 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1396
1397         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1398         https://bugs.webkit.org/show_bug.cgi?id=89875
1399
1400         Reviewed by Maciej Stachowiak.
1401
1402         Add unit tests to verify if the handling of the open, openat, creat syscall
1403         is being done right. We check if the Read/Write/ReadAndWrite permissions
1404         are respected, if the canonical path is being resolved and if
1405         the permissions are falling back to the topmost parent directory with a
1406         policy set when the directory being opened has no policy.
1407
1408         We also test if any attempt of blocking SIGSYS is silently ignored.
1409         SIGSYS cannot be blocked because in it's handler is where we hook
1410         syscalls to the broker process.
1411
1412         Also added libseccomp to EFL's jhbuild to make the life of developers
1413         willing to help easier.
1414
1415         * Scripts/webkitperl/FeatureList.pm:
1416         * TestWebKitAPI/PlatformEfl.cmake:
1417         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1418         (TestWebKitAPI):
1419         (SeccompEnvironment):
1420         (TestWebKitAPI::SeccompEnvironment::SetUp):
1421         (TestWebKitAPI::SeccompEnvironment::TearDown):
1422         (TestWebKitAPI::dummyHandler):
1423         (TestWebKitAPI::TEST):
1424         (TestWebKitAPI::stressTest):
1425         * efl/jhbuild.modules:
1426         * qmake/mkspecs/features/features.pri:
1427
1428 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1429
1430         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1431         https://bugs.webkit.org/show_bug.cgi?id=113846
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         The problem was that we were replacing NSSpellCheck's dictionary with our own
1436         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1437
1438         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1439         and "would" respectively in DumpRenderTree.
1440
1441         * DumpRenderTree/mac/DumpRenderTree.mm:
1442         (resetDefaultsToConsistentValues):
1443
1444 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1445
1446         Remove the gyp files for Tools
1447         https://bugs.webkit.org/show_bug.cgi?id=114248
1448
1449         Reviewed by Ryosuke Niwa.
1450
1451         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1452         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1453         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1454         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1455         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1456         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1457         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1458         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1459
1460 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         WKR (new-commit-bot) is too slow
1463         https://bugs.webkit.org/show_bug.cgi?id=110087
1464
1465         Reviewed by Geoffrey Garen.
1466
1467         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1468         Just run "svn log -r <revision>" instead to cut down the delay.
1469
1470         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1471
1472         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1473         (NewCommitBot):
1474         (NewCommitBot.next_work_item):
1475         (NewCommitBot._is_empty_log):
1476         (NewCommitBot._update_checkout):
1477
1478 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1479
1480         Build fix. Can't remove appendCustomBuildFlags.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1483         (appendCustomBuildFlags):
1484
1485 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1486
1487         Remove Chromium builders from build.webkit.org
1488         https://bugs.webkit.org/show_bug.cgi?id=113990
1489
1490         Reviewed by Benjamin Poulain.
1491
1492         Removed.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/config.json:
1495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1496         (InstallGtkDependencies):
1497         (RunUnitTests.start):
1498         (RunWebKit2Tests.start):
1499         (Factory.__init__):
1500         (unitTestsSupported):
1501         (TestFactory.__init__):
1502         (BuildAndTestFactory.__init__):
1503         (BuildAndPerfTestFactory.__init__):
1504         (BuildAndPerfTestWebKit2Factory.__init__):
1505         (DownloadAndPerfTestFactory.__init__):
1506         (loadBuilderConfig):
1507         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1508
1509 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
1510
1511         Remove HTML Notification
1512         https://bugs.webkit.org/show_bug.cgi?id=114231
1513
1514         Reviewed by Ryosuke Niwa.
1515
1516         * qmake/mkspecs/features/features.pri:
1517
1518 2013-04-08  Glenn Adams  <glenn@skynav.com>
1519
1520         Remove chromium EWS support, and fix broken test.
1521         https://bugs.webkit.org/show_bug.cgi?id=114221
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1526         (AbstractChromiumEWS): Removed.
1527         (ChromiumLinuxEWS): Removed.
1528         (ChromiumLinuxDebugEWS): Removed.
1529         (ChromiumWindowsEWS): Removed.
1530         (ChromiumAndroidEWS): Removed.
1531         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1532         (EarlyWarningSystemTest): Fix misspelled class name.
1533         (test_ewses): Fix entry point name to ensure test is run.
1534
1535 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
1536
1537         [WIN] Remove WebKit2 source code
1538         https://bugs.webkit.org/show_bug.cgi?id=114096
1539
1540         Reviewed by Anders Carlsson.
1541
1542         Remove the windows specific parts of the MiniBrowser.
1543
1544         * MiniBrowser/MiniBrowser.vcproj: Removed.
1545         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1546         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1547         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1548         * MiniBrowser/win/BrowserView.cpp: Removed.
1549         * MiniBrowser/win/BrowserView.h: Removed.
1550         * MiniBrowser/win/BrowserWindow.cpp: Removed.
1551         * MiniBrowser/win/BrowserWindow.h: Removed.
1552         * MiniBrowser/win/MiniBrowser.cpp: Removed.
1553         * MiniBrowser/win/MiniBrowser.h: Removed.
1554         * MiniBrowser/win/MiniBrowser.rc: Removed.
1555         * MiniBrowser/win/main.cpp: Removed.
1556         * MiniBrowser/win/resource.h: Removed.
1557         * MiniBrowser/win/stdafx.cpp: Removed.
1558         * MiniBrowser/win/stdafx.h: Removed.
1559
1560 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1561
1562         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
1563
1564         * Scripts/webkitpy/common/config/irc.py:
1565
1566 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
1567
1568         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
1569         https://bugs.webkit.org/show_bug.cgi?id=113139
1570
1571         Reviewed by Anders Carlsson.
1572
1573         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1574         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1575         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1576         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
1577         (ToStringAndValueOfObject):
1578         (ToStringAndValueOfObject::ToStringAndValueOfObject):
1579         (ScriptableObject):
1580         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
1581         (ToStringAndValueOfObject::ScriptableObject::invoke):
1582         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
1583         (ToStringAndValueOfObject::NPP_GetValue):
1584         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1585         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1586         * GNUmakefile.am:
1587
1588 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
1589
1590         [GTK] Bump gnome-themes-standard to 3.6.0
1591         https://bugs.webkit.org/show_bug.cgi?id=114155
1592
1593         Reviewed by Martin Robinson.
1594
1595         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
1596         dependency of gnome-themes-standard accordingly.
1597
1598 2013-04-08  David Levin  <levin@chromium.org>
1599
1600         Remove my watchlist entries.
1601         https://bugs.webkit.org/show_bug.cgi?id=114180
1602
1603         Reviewed by Adam Barth.
1604
1605         * Scripts/webkitpy/common/config/committers.py:
1606         * Scripts/webkitpy/common/config/watchlist:
1607
1608 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1609
1610         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
1611         https://bugs.webkit.org/show_bug.cgi?id=114161
1612
1613         Reviewed by Gyuyoung Kim.
1614
1615         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
1616         as it is crashing due to Bug 111074.
1617
1618         * TestWebKitAPI/PlatformEfl.cmake:
1619
1620 2013-04-07  David Kilzer  <ddkilzer@apple.com>
1621
1622         Remove the rest of SVG_DOM_OBJC_BINDINGS
1623         <http://webkit.org/b/114112>
1624
1625         Reviewed by Geoffrey Garen.
1626
1627         * Scripts/webkitperl/FeatureList.pm:
1628         - Remove --svg-dom-objc-bindings switch.
1629         * qmake/mkspecs/features/features.pri:
1630         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1631
1632 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
1633
1634         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
1635         https://bugs.webkit.org/show_bug.cgi?id=114089
1636
1637         Reviewed by Chris Fleizach.
1638
1639         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
1640         * DumpRenderTree/AccessibilityController.cpp:
1641         * DumpRenderTree/AccessibilityUIElement.cpp:
1642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1643         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1644         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1645         (DumpRenderTreeChrome):
1646
1647 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
1648
1649         Build fix after r147857, remove remaining USE(JSC) guards.
1650
1651         Unreviewed.
1652
1653         * DumpRenderTree/config.h:
1654         * TestWebKitAPI/config.h:
1655         * WebKitTestRunner/config.h:
1656
1657 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1658
1659         Rename sheriffbot to webkitbot
1660         https://bugs.webkit.org/show_bug.cgi?id=114109
1661
1662         Reviewed by Benjamin Poulain.
1663
1664         Renamed since sheriffbot will be used in Blink.
1665
1666         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1667         (SheriffBot):
1668         (SheriffBot.begin_work_queue):
1669
1670 2013-04-06  Oliver Hunt  <oliver@apple.com>
1671
1672         Unify the many and varied stack trace mechanisms, and make the result sane.
1673         https://bugs.webkit.org/show_bug.cgi?id=114072
1674
1675         Reviewed by Filip Pizlo.
1676
1677         The commandline jsc executable no longer requires arguments, so
1678         I've made run-jsc work without them.
1679
1680         * Scripts/run-jsc:
1681
1682 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1683
1684         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1685         https://bugs.webkit.org/show_bug.cgi?id=114086
1686
1687         Reviewed by Tim Horton.
1688
1689         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1690
1691 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1692
1693         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1694         https://bugs.webkit.org/show_bug.cgi?id=114083
1695
1696         Reviewed by Ryosuke Niwa.
1697
1698         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1699         in TestWebKitAPI and WebKitTestRunner.
1700
1701         * TestWebKitAPI/config.h:
1702         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1703         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1704         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1705         (WTR::InjectedBundle::platformInitialize):
1706
1707 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1708
1709         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1710         https://bugs.webkit.org/show_bug.cgi?id=114094
1711
1712         Reviewed by Anders Carlsson.
1713
1714         * Scripts/run-jsc:
1715
1716 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1717
1718         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1719         https://bugs.webkit.org/show_bug.cgi?id=114080
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         This way, the WebKit and Blink dashboard code can change as appropriate without
1724         needing to consider the other project's needs. This still doesn't update the
1725         buildbots to upload to the new location, or the dashboard code to pull the
1726         results.json files from the new location, but it at least allows for changing the
1727         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1728
1729         * TestResultServer/app.yaml:
1730
1731 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1732
1733         Re-enable testing on the commit queue
1734         https://bugs.webkit.org/show_bug.cgi?id=114078
1735
1736         Reviewed by Darin Adler.
1737
1738         Re-enabled the feature and the associated tests.
1739
1740         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1741         (CommitQueueTask.run):
1742         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1743         (CommitQueueTaskTest._run_through_task):
1744         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1745         (CommitQueueTest._mock_test_result):
1746
1747 2013-04-05  Oliver Hunt  <oliver@apple.com>
1748
1749         Unify the many and varied stack trace mechanisms, and make the result sane.
1750         https://bugs.webkit.org/show_bug.cgi?id=114072
1751
1752         Reviewed by Filip Pizlo.
1753
1754         The commandline jsc executable no longer requires arguments, so
1755         I've made run-jsc work without them.
1756
1757         * Scripts/run-jsc:
1758
1759 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1760
1761         AX: Make SVG Group containers accessible elements
1762         https://bugs.webkit.org/show_bug.cgi?id=113939
1763
1764         Reviewed by Simon Fraser.
1765
1766         Implement axController.elementAtPoint for iOS.
1767         Implement a correct version of clickPoint for iOS.
1768
1769         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1770         (AccessibilityController::elementAtPoint):
1771         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1772         (AccessibilityUIElement::clickPointX):
1773         (AccessibilityUIElement::clickPointY):
1774
1775 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1776
1777         Unreviewed, rolling out r147773 and r147774.
1778         http://trac.webkit.org/changeset/147773
1779         http://trac.webkit.org/changeset/147774
1780         https://bugs.webkit.org/show_bug.cgi?id=114056
1781
1782         Causing some exceptions on AppEngine I don't understand
1783         (Requested by rniwa on #webkit).
1784
1785         * QueueStatusServer/config/queues.py:
1786         * QueueStatusServer/model/queues.py:
1787         (Queue.short_name):
1788         (Queue.display_name):
1789         * QueueStatusServer/model/queues_unittest.py:
1790         (QueueTest.test_short_name):
1791         (QueueTest.test_display_name):
1792         (QueueTest.test_name_with_underscores):
1793
1794 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1795
1796         Fixed run-bindings-tests by removing V8
1797         https://bugs.webkit.org/show_bug.cgi?id=114053
1798
1799         Reviewed by Benjamin Poulain.
1800
1801         * Scripts/run-bindings-tests:
1802         (main):
1803
1804 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1805
1806         Build fix.
1807
1808         * QueueStatusServer/model/queues.py:
1809         (Queue.short_name):
1810         (Queue.display_name):
1811
1812 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1813
1814         Remove Chromium EWS bots from the queue status server
1815         https://bugs.webkit.org/show_bug.cgi?id=113988
1816
1817         Reviewed by Benjamin Poulain.
1818
1819         Removed Chromium EWS bots.
1820
1821         * QueueStatusServer/config/queues.py:
1822         * QueueStatusServer/model/queues.py:
1823         (Queue.short_name):
1824         (Queue.display_name):
1825         * QueueStatusServer/model/queues_unittest.py:
1826         (QueueTest.test_short_name):
1827         (QueueTest.test_display_name):
1828         (QueueTest.test_name_with_underscores):
1829
1830 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1831
1832         [EFL] Enable indexed database
1833         https://bugs.webkit.org/show_bug.cgi?id=107248
1834
1835         Reviewed by Alexis Menard.
1836
1837         * Scripts/webkitperl/FeatureList.pm:
1838
1839 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1840
1841         Remove vestiges of Chromium bits from watchlists.
1842         https://bugs.webkit.org/show_bug.cgi?id=114047
1843
1844         Reviewed by Ryosuke Niwa.
1845
1846         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1847
1848 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1849
1850         Add James Craig to the contributors list.
1851
1852         * Scripts/webkitpy/common/config/committers.py:
1853
1854 2013-04-04  Kent Tamura  <tkent@chromium.org>
1855
1856         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1857
1858         * Scripts/webkitpy/common/config/watchlist:
1859
1860 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1861
1862         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1863         https://bugs.webkit.org/show_bug.cgi?id=113997
1864
1865         Reviewed by Ryosuke Niwa.
1866
1867         Disable the tests until Ryosuke gets the time and hardware to have
1868         a testing commit-queue.
1869
1870         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1871         (CommitQueueTaskTest):
1872         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1873         (CommitQueueTest):
1874
1875 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1876
1877         Remove Chromium builders from build.webkit.org
1878         https://bugs.webkit.org/show_bug.cgi?id=113990
1879
1880         Reviewed by Benjamin Poulain.
1881
1882         Land the part to disable triggering of Chromium builders first so that we may start
1883         deleting more Chromium code that breaks the update step.
1884
1885         * BuildSlaveSupport/build.webkit.org-config/config.json:
1886
1887 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1888
1889         Remove Chromium's DumpRenderTree
1890         https://bugs.webkit.org/show_bug.cgi?id=113989
1891
1892         Reviewed by Kent Tamura.
1893
1894         On second thought, let's not go to Camelot. It is a silly place.
1895
1896         * DumpRenderTree/mac/DumpRenderTree.mm:
1897         (resetDefaultsToConsistentValues):
1898
1899 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1900
1901         Nixed the defunct chromium folder from DumpRenderTree
1902         https://bugs.webkit.org/show_bug.cgi?id=113993
1903
1904         Reviewed by Ryosuke Niwa.
1905
1906         * DumpRenderTree/chromium: Removed.
1907         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1908         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1909         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1910         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1911         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1912         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1913         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1914         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1915         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1916         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1917         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1918         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1919         * DumpRenderTree/chromium/Task.cpp: Removed.
1920         * DumpRenderTree/chromium/Task.h: Removed.
1921         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1922         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1923         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1924         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1925         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1926         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1927         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1928         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1929         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1930         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1931         * DumpRenderTree/chromium/TestRunner: Removed.
1932         * DumpRenderTree/chromium/TestRunner/public: Removed.
1933         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1934         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1935         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1936         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1937         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1938         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1939         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1940         * DumpRenderTree/chromium/TestRunner/src: Removed.
1941         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1942         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1943         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1944         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1945         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1946         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1947         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1948         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1949         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1950         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1951         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1952         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1953         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1954         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1955         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1956         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1957         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1958         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1959         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1960         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1961         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1962         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1963         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1964         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1965         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1966         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1967         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1968         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1969         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1970         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1971         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1972         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1973         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1974         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1975         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1976         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1977         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1978         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1979         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1980         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1981         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1982         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1983         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1984         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1985         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1986         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1987         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1988         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1989         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1990         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1991         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1992         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1993         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1994         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1995         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1996         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1997         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1998         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1999         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2000         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2001         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2002         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2003         * DumpRenderTree/chromium/TestShell.h: Removed.
2004         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2005         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2006         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2007         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2008         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2009         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2010         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2011         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2012         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2013         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2014         * DumpRenderTree/chromium/config.h: Removed.
2015         * DumpRenderTree/chromium/fonts.conf: Removed.
2016
2017 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2020
2021         Rubber stamped by Benjamin Poulain.
2022
2023         * RebaselineQueueServer: Removed.
2024         * RebaselineQueueServer/app.yaml: Removed.
2025         * RebaselineQueueServer/handlers: Removed.
2026         * RebaselineQueueServer/handlers/__init__.py: Removed.
2027         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2028         * RebaselineQueueServer/handlers/pages.py: Removed.
2029         * RebaselineQueueServer/index.yaml: Removed.
2030         * RebaselineQueueServer/main.py: Removed.
2031         * RebaselineQueueServer/model: Removed.
2032         * RebaselineQueueServer/model/__init__.py: Removed.
2033         * RebaselineQueueServer/model/queueentry.py: Removed.
2034         * RebaselineQueueServer/static: Removed.
2035         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2036         * RebaselineQueueServer/static/styles.css: Removed.
2037         * RebaselineQueueServer/templates: Removed.
2038         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2039         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2040         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2041         * RebaselineQueueServer/templates/home.html: Removed.
2042
2043 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2044
2045         Fix setup-commit-queue and temporarily disable testing on commit-queue
2046         https://bugs.webkit.org/show_bug.cgi?id=113979
2047
2048         Reviewed by Benjamin Poulain.
2049
2050         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2051         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2052
2053         * EWSTools/setup-commit-queue.sh:
2054         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2055         (CommitQueueTask.run):
2056
2057 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2058
2059         temporarily make flakiness dashboard work again webkit.org bots
2060         https://bugs.webkit.org/show_bug.cgi?id=113972
2061
2062         Reviewed by Ojan Vafai.
2063
2064         This patch disables the chromium.org layout test bots TestExpectations
2065         parsing temporarily until we can work out the right way to split into
2066         two instances for webkit.org and chromium.org and figure out which
2067         code to delete where :).
2068
2069         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2070
2071 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2072
2073         Fix webkitpy tests after r147678.
2074
2075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2076         (CommitQueueTest.test_commit_queue):
2077         (test_manual_reject_during_processing):
2078
2079 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2080
2081         The commit queue should use Mac MountainLion port
2082         https://bugs.webkit.org/show_bug.cgi?id=113971
2083
2084         Reviewed by Lucas Forschler.
2085
2086         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2087         * Scripts/webkitpy/tool/commands/queues.py:
2088         (CommitQueue):
2089
2090 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2091
2092         turn off running tests on chromium linux EWS bots
2093         https://bugs.webkit.org/show_bug.cgi?id=113959
2094
2095         Reviewed by Geoffrey Garen.
2096
2097         Now that the Chromium port is no longer being maintained
2098         there's little point in running the tests. Soon we should
2099         just shut this bot off altogether.
2100
2101         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2102         (ChromiumLinuxEWS):
2103
2104 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2105
2106         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2107
2108         * Scripts/webkitpy/common/config/watchlist:
2109
2110 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2111
2112         Indentation fix to get webkit-patch working again after r147625
2113
2114         Unreviewed.
2115
2116         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2117         (MacEWS):
2118         (MacWK2EWS):
2119
2120 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2121
2122         Turn tests back on for Mac WK1/WK2 EWS.
2123         
2124         Unreviewed.
2125         
2126         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2127         (MacEWS):
2128         (MacWK2EWS):
2129
2130 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2131
2132         [GTK][WK2] MiniBrowser custom URI scheme support
2133         https://bugs.webkit.org/show_bug.cgi?id=112419
2134
2135         Reviewed by Carlos Garcia Campos.
2136
2137         Add support for about URIs in MiniBrowser. An example about page is show
2138         with URI "about:minibrowser", the rest of the cases it will show a
2139         proper message explaining that the about page didn't exist.
2140
2141         Internally it uses "minibrowser-about" prefix instead of "about", but
2142         from the user point of view it works with "about" prefix.
2143
2144         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2145         (getInternalURI): Method to convert URIs from "about" prefix to
2146         "minibrowser-about".
2147         (getExternalURI): Opposite method.
2148         (webViewURIChanged): Use "about" prefix to show the URI to users.
2149         (webViewEnterFullScreen): Ditto.
2150         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2151         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2152         (aboutURISchemeRequestCallback): Callback to manage about calls.
2153         (main): Register the URI scheme to manage about URIs.
2154
2155 2013-04-03  Roger Fong  <roger_fong@apple.com>
2156
2157         Re-enable WinEWS tests.
2158
2159         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2160         (WinEWS):
2161
2162 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2163
2164         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2165         https://bugs.webkit.org/show_bug.cgi?id=113883
2166
2167         Reviewed by Martin Robinson.
2168
2169         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2170         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2171         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2172
2173 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2174
2175         [GTK] Include Pango in jhbuild-optional.modules
2176         https://bugs.webkit.org/show_bug.cgi?id=113878
2177
2178         Reviewed by Martin Robinson.
2179
2180         Since r147547 Pango 1.32.0 is required. Including the module in the
2181         JHBuild optional moduleset.
2182
2183         * gtk/jhbuild-optional.modules: Add Pango module.
2184
2185 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2186
2187         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2188         https://bugs.webkit.org/show_bug.cgi?id=113864
2189
2190         Moving setDefersLoading from TestRunnerQt to TestRunner
2191         requires access to the non-Qt TestRunner.
2192         As long as we instantiate both TestRunner and TestRunnerQt,
2193         we need a separate getter for the non-Qt TestRunner instance.
2194
2195         Reviewed by Simon Hausmann.
2196
2197         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2198         (WebPage::resetSettings):
2199         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2200         (DumpRenderTree::jscTestRunner):
2201         * DumpRenderTree/qt/TestRunnerQt.cpp:
2202         (TestRunner::setDefersLoading):
2203             Moving setDefersLoading from TestRunnerQt
2204             to TestRunner.
2205         * DumpRenderTree/qt/TestRunnerQt.h:
2206         (TestRunnerQt):
2207
2208 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2209
2210         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2211         https://bugs.webkit.org/show_bug.cgi?id=104779
2212
2213         Reviewed by Carlos Garcia Campos.
2214
2215         * Scripts/run-gtk-tests:
2216         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2217         passing in current trunk.
2218
2219 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2220
2221         Fix HAVE(QTTESTSUPPORT) logic
2222
2223         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2224         resulting in HAVE(QTTESTSUPPORT) never being true.
2225         Move that logic down in sanitizeFeatures.
2226
2227         Rubber-stamped by Tor Arne Vestbø.
2228
2229         * qmake/mkspecs/features/features.prf:
2230
2231 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2232
2233         [GTK] Bump required versions of some dependencies
2234         https://bugs.webkit.org/show_bug.cgi?id=113282
2235
2236         Reviewed by Martin Robinson.
2237
2238         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2239
2240 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2241
2242         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2243         https://bugs.webkit.org/show_bug.cgi?id=113809
2244
2245         Reviewed by Philippe Normand.
2246
2247         Newer Linux kernels have removed some deprecated macros from v4l2
2248         headers, causing gst-plugins-good's build to break. We don't need it
2249         right now, so just disable it.
2250
2251         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2252
2253 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2254
2255         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2256         https://bugs.webkit.org/show_bug.cgi?id=113535
2257
2258         Reviewed by Simon Hausmann.
2259
2260         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2261
2262         * qmake/mkspecs/features/features.prf:
2263
2264 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2265
2266         [Qt] Move logic of simple forwarding functions to TestRunner.
2267         https://bugs.webkit.org/show_bug.cgi?id=113863
2268
2269         Reviewed by Simon Hausmann.
2270
2271         * DumpRenderTree/qt/TestRunnerQt.cpp:
2272         (TestRunner::setTextDirection):
2273         (TestRunner::goBack):
2274         (TestRunner::evaluateScriptInIsolatedWorld):
2275         (TestRunner::addUserStyleSheet):
2276         * DumpRenderTree/qt/TestRunnerQt.h:
2277         (TestRunnerQt):
2278
2279 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2280
2281         [Qt] Disable media support using QuickTime if deployment target != SDK
2282
2283         We link to a single libWebKitSystemInterface static lib, so unless the
2284         deployment target matches the SDK let's not pretend like we'll be able
2285         to run on anything lower than the SDK version.
2286
2287         Reviewed by Simon Hausmann.
2288
2289         * qmake/mkspecs/features/features.prf:
2290
2291 2013-04-02  James Craig  <james@cookiecrook.com>
2292
2293         AXRoleDescripton for DL is "list"; should be "description list"
2294         https://bugs.webkit.org/show_bug.cgi?id=111665
2295
2296         Reviewed by Chris Fleizach.
2297
2298         Defining the role and description strings.
2299
2300         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2301
2302 2013-04-02  Roger Fong  <roger_fong@apple.com>
2303
2304         Unreviewed. Disable running tests on Win EWS queue.
2305
2306         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2307         (WinEWS):
2308
2309 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2310
2311         Disable running tests on the MAC WK2 EWS queue.
2312         
2313         Unreviewed.
2314         
2315         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2316         (MacWK2EWS):
2317
2318 2013-04-02  Julie Parent  <jparent@chromium.org>
2319
2320         Dashboard refactor: Move dashboard specific history related features to History.
2321         https://bugs.webkit.org/show_bug.cgi?id=113717
2322
2323         Reviewed by Ojan Vafai.
2324         
2325         Each dashboard now creates its own History object, with a custom
2326         configuration. This changes from just overriding global functions
2327         to passing in callbacks for generatePage, handleValidHashParameter,
2328         and handleQueryParameterChange. Same with passing in defaultStateValues
2329         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2330         variables.
2331         
2332         All functions related to these features are now (mostly) private
2333         function on History. 
2334         
2335         Loader no longer needs a loadingComplete callback, since it can just
2336         initialize the history object itself.
2337
2338         * TestResultServer/static-dashboards/aggregate_results.js:
2339         (handleValidHashParameter):
2340         * TestResultServer/static-dashboards/dashboard_base.js:
2341         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2342         (generatePage):
2343         (.switch.return):
2344         (handleQueryParameterChange):
2345         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2346         (resetGlobals):
2347         * TestResultServer/static-dashboards/history.js:
2348         (.):
2349         * TestResultServer/static-dashboards/loader.js:
2350         (.):
2351         * TestResultServer/static-dashboards/loader_unittests.js:
2352         * TestResultServer/static-dashboards/timeline_explorer.js:
2353         (generatePage):
2354         (initCurrentBuilderTestResults):
2355         * TestResultServer/static-dashboards/treemap.js:
2356         (generatePage):
2357         (.switch.return):
2358         (handleQueryParameterChange):
2359
2360 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2361
2362         Unreviewed, rolling out r147401.
2363         http://trac.webkit.org/changeset/147401
2364         https://bugs.webkit.org/show_bug.cgi?id=113767
2365
2366         The patch makes it extremely hard to set up the dependencies
2367         properly on the GTK builders (Requested by zdobersek on
2368         #webkit).
2369
2370         * gtk/jhbuild.modules:
2371
2372 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2373
2374         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2375         https://bugs.webkit.org/show_bug.cgi?id=113382
2376
2377         Reviewed by Gyuyoung Kim.
2378
2379         Do not show the empty tooltip box if the text is null.
2380
2381         * MiniBrowser/efl/main.c:
2382         (popup_menu_populate):
2383
2384 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2385
2386         [GTK] Bump required versions of some dependencies
2387         https://bugs.webkit.org/show_bug.cgi?id=113282
2388
2389         Reviewed by Martin Robinson.
2390
2391         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2392
2393 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2394
2395         Unreviewed, rolling out r147319.
2396         http://trac.webkit.org/changeset/147319
2397         https://bugs.webkit.org/show_bug.cgi?id=113707
2398
2399         The unit test is still failing on the buildbot (Requested by
2400         zdobersek on #webkit).
2401
2402         * Scripts/run-gtk-tests:
2403         (TestRunner):
2404
2405 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2406
2407         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2408         https://bugs.webkit.org/show_bug.cgi?id=104779
2409
2410         Reviewed by Carlos Garcia Campos.
2411
2412         * Scripts/run-gtk-tests:
2413         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2414         passing in current trunk.
2415
2416 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2417
2418         Unreviewed, rolling out r147289.
2419         http://trac.webkit.org/changeset/147289
2420         https://bugs.webkit.org/show_bug.cgi?id=113678
2421
2422         broke Win7 (dbg) build (Requested by shinyak|gardener on
2423         #webkit).
2424
2425         * DumpRenderTree/DumpRenderTree.gypi:
2426         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2427         (WebTestRunner):
2428         (WebUserMediaClientMock):
2429         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2430         (WebTestRunner::WebUserMediaClientMock::taskList):
2431         * Scripts/webkitpy/style/checkers/cpp.py:
2432         (check_function_definition):
2433
2434 2013-03-31  Adam Barth  <abarth@webkit.org>
2435
2436         configure-svn-config.sh fails
2437         https://codereview.chromium.org/13392007/
2438
2439         Reviewed by Eric Seidel.
2440
2441         This script was trying to use "svn checkout" to dowload a file from
2442         svn.webkit.org, but "svn checkout" only works with directories.
2443         Instead, we should use "svn export".
2444
2445         * EWSTools/configure-svn-config.sh:
2446
2447 2013-03-31  Wei Jia  <wjia@chromium.org>
2448
2449         Allow WebUserMediaClientMock to be used by client
2450         https://bugs.webkit.org/show_bug.cgi?id=113633
2451
2452         Reviewed by Adam Barth.
2453
2454         Export WebUserMediaClientMock.
2455         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2456
2457         * DumpRenderTree/DumpRenderTree.gypi:
2458         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2459         (WebUserMediaClientMock):
2460         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2461         * Scripts/webkitpy/style/checkers/cpp.py:
2462         (check_function_definition):
2463
2464 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2465
2466         Expose FeatureObserver data to WebKit clients
2467         https://bugs.webkit.org/show_bug.cgi?id=113613
2468
2469         Reviewed by Sam Weinig.
2470
2471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2472         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2473
2474 2013-03-29  Greg Hughes  <ghughes@apple.com>
2475
2476         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
2477         https://bugs.webkit.org/show_bug.cgi?id=112276
2478
2479         Reviewed by Chris Fleizach.
2480
2481         Added support to test accessibility search predicates with multiple keys.  
2482
2483         * DumpRenderTree/AccessibilityUIElement.cpp:
2484         (uiElementForSearchPredicateCallback):
2485         * DumpRenderTree/AccessibilityUIElement.h:
2486         (AccessibilityUIElement):
2487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2488         (AccessibilityUIElement::uiElementForSearchPredicate):
2489         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2490         (AccessibilityUIElement::uiElementForSearchPredicate):
2491         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2492         (AccessibilityUIElement::uiElementForSearchPredicate):
2493         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2494         (AccessibilityUIElement::uiElementForSearchPredicate):
2495         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2496         (AccessibilityUIElement::uiElementForSearchPredicate):
2497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2498         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2499         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2500         (AccessibilityUIElement):
2501         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2503         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2504         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2505         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2506
2507 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
2508
2509         Fix a typo in r147147 to fix Mac EWS.
2510
2511         * Scripts/webkitpy/tool/commands/queues.py:
2512         (PatchProcessingQueue._new_port_name_from_old):
2513
2514 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
2515
2516         [EFL] Build break with latest EFL libraries after r146265
2517         https://bugs.webkit.org/show_bug.cgi?id=113558
2518
2519         Unreviewed build fix.
2520
2521         * TestWebKitAPI/PlatformWebView.h:
2522         * WebKitTestRunner/PlatformWebView.h:
2523
2524 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2525
2526         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
2527
2528         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
2529         in libgcrypt build.
2530
2531 2013-03-28  Lucas Forschler  <lforschler@apple.com>
2532
2533         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
2534
2535         Unreviewed.
2536
2537         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2538         (MacEWS):
2539
2540 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Use the right OS name on Mac EWS instead of mac-future.
2543
2544         Rubber-stamped by Dirk Pranke.
2545
2546         * Scripts/webkitpy/tool/commands/queues.py:
2547         (PatchProcessingQueue._new_port_name_from_old):
2548         (PatchProcessingQueue.begin_work_queue):
2549         (PatchProcessingQueue._upload_results_archive_for_patch):
2550
2551 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
2552
2553         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
2554         https://bugs.webkit.org/show_bug.cgi?id=112546
2555
2556         Reviewed by Martin Robinson.
2557
2558         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
2559         moved back to Source/WebCore/platform. Fix an indentation issue as well.
2560
2561 2013-03-28  Ming Xie  <mxie@blackberry.com>
2562
2563         [BlackBerry] Committer Email Updates
2564         https://bugs.webkit.org/show_bug.cgi?id=113435
2565
2566         Reviewed by Rob Buis.
2567
2568         Add the @blackberry.com email address for all our BlackBerry
2569         WebKit committers. This is the first step for our email address
2570         migration.
2571
2572         * Scripts/webkitpy/common/config/committers.py:
2573
2574 2013-03-28  Philippe Normand  <pnormand@igalia.com>
2575
2576         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
2577         https://bugs.webkit.org/show_bug.cgi?id=113508
2578
2579         Reviewed by Martin Robinson.
2580
2581         Prevent the GStreamer plugin scanner to load system-wide
2582         plugins. Only the ones built in JHBuild should be loaded and used
2583         at runtime.
2584
2585         * efl/jhbuildrc:
2586         * gtk/jhbuildrc:
2587
2588 2013-03-27  Philippe Normand  <pnormand@igalia.com>
2589
2590         [GTK] run-launcher --gtk -2 fails on a WK2-only build
2591         https://bugs.webkit.org/show_bug.cgi?id=113386
2592
2593         Reviewed by Carlos Garcia Campos.
2594
2595         * Scripts/webkitdirs.pm:
2596         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
2597         version to 3.0. Reflect this change so the builtDylibPathForName
2598         function doesn't fail to report the library as found.
2599
2600 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
2601
2602         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
2603         https://bugs.webkit.org/show_bug.cgi?id=113484
2604
2605         Unreviewed build fix.
2606
2607         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
2608
2609         * TestWebKitAPI/CMakeLists.txt:
2610         * WebKitTestRunner/CMakeLists.txt:
2611
2612 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2613
2614         Revision for the internal jhbuild is too old
2615         https://bugs.webkit.org/show_bug.cgi?id=113324
2616
2617         Reviewed by Martin Robinson.
2618
2619         Update the minimum required version to a point where jhbuild won't
2620         fail installing packages when trying to remove a symlink to a directory.
2621
2622         * jhbuild/jhbuild-wrapper: Updated revision.
2623
2624 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
2625
2626         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
2627         https://bugs.webkit.org/show_bug.cgi?id=113203
2628
2629         Reviewed by Philippe Normand.
2630
2631         We build our libsoup without GNOME support. gst-plugins-good does separate
2632         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
2633         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
2634         build failures as the headers of those diverge. We do not use souphttpsrc, so
2635         disable it when building gst-plugins-good.
2636
2637         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
2638
2639 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2640
2641         Build fix after r146852. Please another reference to the Lion leaks builder.
2642
2643         * BuildSlaveSupport/build.webkit.org-config/config.json:
2644
2645 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
2646
2647         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
2648         https://bugs.webkit.org/show_bug.cgi?id=113421
2649
2650         Reviewed by Dirk Pranke.
2651
2652         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
2653         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
2654         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
2655         in the GTK-specific TestExpectations files.
2656
2657         To avoid this only enable the warnings only when not using WKTR.
2658
2659         * Scripts/webkitpy/layout_tests/port/gtk.py:
2660         (GtkPort.warn_if_bug_missing_in_test_expectations):
2661
2662 2013-03-27  Antti Koivisto  <antti@apple.com>
2663
2664         Fix Zalan's email.
2665
2666         * Scripts/webkitpy/common/config/committers.py:
2667
2668 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2669
2670         master.cfg cleanup
2671         https://bugs.webkit.org/show_bug.cgi?id=113195
2672
2673         Reviewed by Ryosuke Niwa.
2674
2675         * BuildSlaveSupport/build.webkit.org-config/config.json:
2676         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2677
2678 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2679
2680         master.cfg fine-tuning for Qt Mountain Lion Release bot
2681         https://bugs.webkit.org/show_bug.cgi?id=113191
2682
2683         Reviewed by Ryosuke Niwa.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/config.json:
2686           - Rename the slave due to its location change.
2687           - Update the platform of the slave.
2688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2689         (RunQtAPITests): Enable running WK2 API tests on Qt.
2690         (RunQtAPITests.start):
2691         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2692         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2693
2694 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2695
2696         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2697         https://bugs.webkit.org/show_bug.cgi?id=113403
2698
2699         Reviewed by Kenneth Rohde Christiansen.
2700
2701         As of Evas 1.7.5, when Wayland is detected on the system, support for
2702         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2703         The code, however, seems to depend on a few other flags which must be
2704         explicitly enabled.
2705
2706         If those additional GL-related options are passed, we end up
2707         having issues on the WebKit side, so disable Wayland support for
2708         now.
2709
2710         * efl/jhbuild.modules:
2711
2712 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2713
2714         Unreviewed, rolling out r146864.
2715         http://trac.webkit.org/changeset/146864
2716         https://bugs.webkit.org/show_bug.cgi?id=113391
2717
2718         causes crashes on Wk2 EFL release bot (Requested by drott on
2719         #webkit).
2720
2721         * Scripts/webkitperl/FeatureList.pm:
2722
2723 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2724
2725         [jhbuild] Correctly specify an alternate number of make jobs.
2726         https://bugs.webkit.org/show_bug.cgi?id=113396
2727
2728         Reviewed by Philippe Normand.
2729
2730         So far, we were using the `MAKEFLAGS' environment variable to pass the
2731         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2732         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2733
2734         We now behave more closely to the rest of the WebKit tools by first
2735         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2736         not set, just letting jhbuild itself figure out how many jobs to use.
2737
2738         * efl/jhbuildrc:
2739         * gtk/jhbuildrc:
2740
2741 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2742
2743         [Qt] Remove Qt specific WorkQueueItem definitions.
2744         https://bugs.webkit.org/show_bug.cgi?id=112891
2745
2746         This patch is preparation work for removing
2747         WorkQueue related code from TestRunnerQt and
2748         replacing it with generic TestRunner code.
2749
2750         Reviewed by Benjamin Poulain.
2751
2752         * DumpRenderTree/qt/TestRunnerQt.cpp:
2753         (TestRunnerQt::queueBackNavigation):
2754         (TestRunnerQt::queueForwardNavigation):
2755         (TestRunnerQt::queueLoadHTMLString):
2756         (TestRunnerQt::queueReload):
2757         (TestRunnerQt::queueLoadingScript):
2758         (TestRunnerQt::queueNonLoadingScript):
2759         (TestRunner::queueLoad):
2760         * DumpRenderTree/qt/TestRunnerQt.h:
2761         (TestRunnerQt):
2762         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2763         (LoadItem::invoke):
2764         (LoadHTMLStringItem::invoke):
2765         (LoadAlternateHTMLStringItem::invoke):
2766         (ReloadItem::invoke):
2767         (ScriptItem::invoke):
2768         (BackForwardItem::invoke):
2769         * DumpRenderTree/qt/WorkQueueItemQt.h:
2770         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2771         (LoadAlternateHTMLStringItem):
2772
2773 2013-03-26  Julie Parent  <jparent@chromium.org>
2774
2775         Flakiness dashboard: simplify logic around which tests to show.
2776         https://bugs.webkit.org/show_bug.cgi?id=113250
2777
2778         Reviewed by Ojan Vafai.
2779         
2780         The different filters for showing results are only used for layout
2781         tests, otherwise, we show everything.
2782         
2783         Change the defaults to false (what layout tests used), and only
2784         look at the values when viewing layout tests.
2785
2786         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2787         (htmlForTestsWithExpectationsButNoFailures):
2788         (shouldHideTest):
2789
2790 2013-03-26  Isaac Levy  <ilevy@google.com>
2791
2792         Update bots on test-results.appspot
2793         https://bugs.webkit.org/show_bug.cgi?id=113333
2794
2795         Reviewed by Ojan Vafai.
2796
2797         * TestResultServer/static-dashboards/builders.jsonp:
2798
2799 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2800
2801         Unreviewed GTK gardening.
2802
2803         * Scripts/run-gtk-tests:
2804         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2805
2806 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2807
2808         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2809         https://bugs.webkit.org/show_bug.cgi?id=113287
2810
2811         Reviewed by Jocelyn Turcotte.
2812
2813         * Scripts/run-qtwebkit-tests:
2814         (Options.__init__):
2815
2816 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2817
2818         [EFL] Enable IndexedDB by default
2819         https://bugs.webkit.org/show_bug.cgi?id=107248
2820
2821         Reviewed by Laszlo Gombos.
2822
2823         * Scripts/webkitperl/FeatureList.pm:
2824         Enable IndexedDB by default on EFL.
2825
2826 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2827
2828         Sheriffbot should explain rollout failures in a human readable form.
2829         https://bugs.webkit.org/show_bug.cgi?id=107092
2830
2831         Reviewed by Ryosuke Niwa.
2832
2833         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2834
2835         * Scripts/webkitpy/tool/bot/irc_command.py:
2836         (Rollout._check_diff_failure):
2837         (Rollout.execute):
2838         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2839         (IRCCommandTest.test_rollout):
2840
2841 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2842
2843         Unreviewed GTK gardening.
2844
2845         * Scripts/run-gtk-tests:
2846         (TestRunner): Skipping a failing unit test after r146518.
2847
2848 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2849
2850         Remove Lion leaks builder
2851         https://bugs.webkit.org/show_bug.cgi?id=113252
2852
2853         Reviewed by Andreas Kling.
2854
2855         Removed.
2856
2857         * BuildSlaveSupport/build.webkit.org-config/config.json:
2858
2859 2013-03-25  Kent Tamura  <tkent@chromium.org>
2860
2861         Rename ENABLE_INPUT_TYPE_DATETIME
2862         https://bugs.webkit.org/show_bug.cgi?id=113254
2863
2864         Reviewed by Kentaro Hara.
2865
2866         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2867         Actually I'd like to remove the code, but we shouldn't remove it yet
2868         because we shipped products with it on some platforms.
2869
2870         * Scripts/webkitperl/FeatureList.pm:
2871         * qmake/mkspecs/features/features.pri:
2872
2873 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2874
2875         Remove one more line that was intended to be removed in r146657.
2876
2877         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2878         (summarize_results):
2879
2880 2013-03-25  Roger Fong  <roger_fong@apple.com>
2881
2882         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2883         Re-enable WinEWS tests.
2884
2885         * Scripts/webkitpy/common/config/ports.py:
2886         (WinPort.run_bindings_tests_command):
2887         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2888         (WinEWS):
2889
2890 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2891
2892         Unreviewed, rolling out r146793.
2893         http://trac.webkit.org/changeset/146793
2894         https://bugs.webkit.org/show_bug.cgi?id=113248
2895
2896         Fix did not work (Requested by rfong on #webkit).
2897
2898         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2899         (WinEWS):
2900
2901 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2902
2903         REGRESSION(r146657): Test failures reported incorrectly
2904         https://bugs.webkit.org/show_bug.cgi?id=113223
2905
2906         Reviewed by Dirk Pranke.
2907
2908         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2909
2910         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2911         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2912
2913         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2914         (Manager.run):
2915
2916         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2917         (RunDetails.__init__):
2918         (summarize_results): Remove the line I intended to remove in r146657.
2919
2920         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2921         (logging_run): Return details instead of the exit code.
2922         (run_and_capture): Ditto.
2923
2924         (RunTest.test_full_results_html):
2925         (RunTest.test_hung_thread):
2926         (RunTest.test_no_tests_found):
2927         (RunTest.test_no_tests_found_2):
2928         (RunTest.test_repeat_each_iterations_num_tests):
2929         (RunTest.test_run_singly_actually_runs_tests):
2930         (RunTest.test_test_list):
2931         (RunTest.test_missing_and_unexpected_results):
2932         (RunTest.test_pixel_test_directories):
2933         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2934         (RunTest.test_crash_with_stderr):
2935         (RunTest.test_no_image_failure_with_image_diff):
2936         (RunTest.test_crash_log):
2937         (RunTest.test_exit_after_n_failures_upload):
2938         (RunTest.test_results_directory_absolute):
2939         (RunTest.test_results_directory_relative):
2940         (RunTest.test_retrying_and_flaky_tests):
2941         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2942         (RunTest.test_retrying_uses_retries_directory):
2943         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2944         (RunTest.test_output_diffs):
2945         (EndToEndTest.test_reftest_with_two_notrefs):
2946         (RebaselineTest.test_reset_results):
2947         (RebaselineTest.test_missing_results):
2948         (RebaselineTest.test_new_baseline):
2949
2950         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2951         (BuildBotPrinter.print_results):
2952         (BuildBotPrinter.print_unexpected_results):
2953         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2954         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2955
2956 2013-03-25  Julie Parent  <jparent@chromium.org>
2957
2958         Dashboard refactor: Move cross dashboard history related code into history.js.
2959         https://bugs.webkit.org/show_bug.cgi?id=113104
2960
2961         Reviewed by Ojan Vafai.
2962
2963         All functions relating to cross dashboard behavior move from being
2964         globals to methods on the history.History object. Names stay the same,
2965         except many are made private, ones that should have been constants now
2966         are, and the long standing TODO to change "currentState" to 
2967         dashboardSpecificState is done.
2968         
2969         We now create a global history object in dashboard_base, as an 
2970         intermediate measure.  Once the dashboard specific code is
2971         added to history, each DB will need to create its own, and this
2972         global will be eliminated.
2973         
2974         * TestResultServer/static-dashboards/aggregate_results.js:
2975         (handleValidHashParameter):
2976         (htmlForBuilder):
2977         (rawValuesHTML):
2978         * TestResultServer/static-dashboards/dashboard_base.js:
2979         (parseDashboardSpecificParameters):
2980         (defaultValue):
2981         (currentBuilderGroupCategory):
2982         (currentBuilderGroupName):
2983         (handleLocationChange):
2984         (expectationsMap):
2985         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2986         (generatePage):
2987         (.switch.return):
2988         (platformAndBuildType):
2989         (individualTests):
2990         (substringList):
2991         (processMissingAndExtraExpectations):
2992         (pathToFailureLog):
2993         (showPopupForBuild):
2994         (htmlForTestsWithExpectationsButNoFailures):
2995         (shouldHideTest):
2996         (isCrossBuilderView):
2997         (tableHeaders):
2998         (htmlForSingleTestRow):
2999         (htmlForTableColumnHeader):
3000         (generatePageForExpectationsUpdate):
3001         (handleUpdate):
3002         (nextUpdate):
3003         (setUpdateIndex):
3004         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3005         (.appendExpectationsItem):
3006         (loadExpectations):
3007         (.dummyNode.onload):
3008         (loadExpectationsLayoutTests):
3009         (appendExpectations):
3010         (htmlForNavBar):
3011         (checkBoxToToggleState):
3012         (linkHTMLToToggleState):
3013         (generatePageForBuilder):
3014         (isInvalidKeyForCrossBuilderView):
3015         (handleQueryParameterChange):
3016         (showLegend):
3017         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3018         (resetGlobals):
3019         (test):
3020         * TestResultServer/static-dashboards/history.js:
3021         (.):
3022         * TestResultServer/static-dashboards/history_unittests.js:
3023         * TestResultServer/static-dashboards/loader.js:
3024         (.):
3025         * TestResultServer/static-dashboards/loader_unittests.js:
3026         * TestResultServer/static-dashboards/timeline_explorer.js:
3027         (generatePage):
3028         (initCurrentBuilderTestResults):
3029         (selectBuild):
3030         (showResultsDelta):
3031         * TestResultServer/static-dashboards/treemap.js:
3032         (generatePage):
3033         (.switch.return):
3034         (handleFocus):
3035         * TestResultServer/static-dashboards/ui.js:
3036
3037 2013-03-25  Roger Fong  <roger_fong@apple.com>
3038
3039         Unreviewed. Enable WinEWS tests again.
3040
3041         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3042         (WinEWS):
3043
3044 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3045
3046         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3047         https://bugs.webkit.org/show_bug.cgi?id=112166
3048
3049         HarfBuzz 0.9.14 merged my patch for icu detection without
3050         pkg-config files, as needed by for example Ubuntu 12.04.
3051         This obsoletes our local workaround. Removed it for GTK and EFL.
3052
3053         Reviewed by Martin Robinson.
3054
3055         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3056         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3057         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3058         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3059
3060 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3061
3062         Unreviewed.  Move self from contributor to committer list.
3063
3064         * Scripts/webkitpy/common/config/committers.py:
3065
3066 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3067
3068         EWS should use a human readable port name when uploading layout test archives
3069         https://bugs.webkit.org/show_bug.cgi?id=113099
3070
3071         Reviewed by Dirk Pranke.
3072
3073         Use new port's object's name() method to report human readable port names.
3074         This will also help us resolving the bug to apply layout test results posted by EWS.
3075
3076         * Scripts/webkitpy/tool/bot/botinfo.py:
3077         (BotInfo.__init__): Take port's name.
3078         (BotInfo.summary_text):
3079
3080         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3081         (BotInfoTest.test_summary_text):
3082
3083         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3084         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3085
3086         * Scripts/webkitpy/tool/commands/queues.py:
3087         (PatchProcessingQueue.__init__): Initialize self._port.
3088         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3089         and use that for the attachment filename and the comment posted.
3090
3091         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3092         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3093         "mac-snowleopard" as expected for TestPort.
3094
3095 2013-03-22  Roger Fong  <roger_fong@apple.com>
3096
3097         Unreviewed. Turn off EWS test on Win again.
3098         The battle continues.
3099
3100         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3101         (WinEWS):
3102
3103 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3104
3105         NRWT: Enable pixel tests when retrying tests
3106         https://bugs.webkit.org/show_bug.cgi?id=112898
3107
3108         Reviewed by Dirk Pranke.
3109
3110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3111         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3112         if we've forced pixel tests in the retry.
3113         (Manager._run_tests):
3114         (Manager._clean_up_run): Fixed the capitalizations.
3115         (Manager._force_pixel_tests_if_needed): Added.
3116
3117         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3118         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3119         'image_diff_percent' if it doesn't already exist.
3120
3121         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3122         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3123         treat this as a regular regression instead of a flakiness.
3124
3125         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3126         run had image diffs.
3127
3128         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3129         (summarized_results):
3130
3131         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3132         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3133         Also removed some dead code.
3134
3135         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3136         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3137         is set and pixel_tests_enabled is set to false.
3138         (EndToEndTest.test_reftest_with_two_notrefs):
3139
3140 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3141
3142         Make it possible to run layout tests on Retina MBP
3143         https://bugs.webkit.org/show_bug.cgi?id=93673
3144
3145         Reviewed by Ryosuke Niwa.
3146
3147         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3148         windows on 2x machines still run at 1x.
3149
3150         * DumpRenderTree/mac/DumpRenderTree.mm:
3151         (createWebViewAndOffscreenWindow):
3152         Reset the window resolution to 1x on creation.
3153         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3154         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3155         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3156         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3157         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3158         (WTR::PlatformWebView::PlatformWebView):
3159         Add NSWindow details, reset the window resolution to 1x on creation.
3160
3161 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3162
3163         Leak bots shouldn't build
3164         https://bugs.webkit.org/show_bug.cgi?id=112774
3165
3166         Reviewed by Simon Fraser.
3167
3168         Since leak bots use regular debug builds, there is no need to build on these bots.
3169         Simply downloading builds will dramatically improve the cycle time of these bots.
3170
3171         * BuildSlaveSupport/build.webkit.org-config/config.json:
3172         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3173         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3174         TestFactory instead of BuildAndTestFactory.
3175
3176 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3177
3178         [Qt] Fix the TestWebKitAPI build
3179         https://bugs.webkit.org/show_bug.cgi?id=113044
3180
3181         Reviewed by Tor Arne Vestbø.
3182
3183         The generate-forwarding-headers script would only be run
3184         after the targets in InjectedBundle.pri since the second
3185         addStrictSubdirOrderBetween call in
3186         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3187         the derived_sources -> injected_bundle order in SUBDIRS.
3188
3189         Fix it by only moving the dependent target at the end of
3190         SUBDIRS, don't touch its dependency.
3191
3192         * qmake/mkspecs/features/functions.prf:
3193
3194 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3195
3196         [EFL][WK2] View is not focused when fullscreen mode toggled
3197         https://bugs.webkit.org/show_bug.cgi?id=113009
3198
3199         Reviewed by Laszlo Gombos.
3200
3201         Set focus on view when fullscreen mode enabled/disabled
3202         by FullScreen API.
3203
3204         * MiniBrowser/efl/main.c:
3205         (on_fullscreen_accept):
3206         (on_fullscreen_deny):
3207
3208 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3209
3210         nrwt is no longer saving retry results in the retries/ subdirectory
3211         https://bugs.webkit.org/show_bug.cgi?id=112995
3212
3213         Reviewed by Ojan Vafai.
3214
3215         I think this has been broken a long time, unfortunately. This
3216         patch should fix that.
3217
3218         In order to do so, I had to pass the directory to use from
3219         the Worker object through the SingleTestWriter to the
3220         TestResultWriter. While I was plumbing that through, I rationalized
3221         the order of the parameter arguments a bit ...
3222
3223         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3224         (Worker._run_single_test):
3225         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3226         (run_single_test):
3227         (SingleTestRunner.__init__):
3228         (SingleTestRunner._run_compare_test):
3229         (SingleTestRunner._run_rebaseline):
3230         (SingleTestRunner._run_reftest):
3231         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3232         (write_test_result):
3233         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3234         (TestResultWriterTest.test_reftest_diff_image):
3235         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3236         (RunTest.test_retrying_uses_retries_directory):
3237
3238 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
3239
3240         JSC profiler should have an at-a-glance report of the success of DFG optimization
3241         https://bugs.webkit.org/show_bug.cgi?id=112988
3242
3243         Reviewed by Geoffrey Garen.
3244
3245         * Scripts/display-profiler-output:
3246
3247 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3248
3249         [chromium] Linux ASAN WebKit canary is running out of memory
3250         https://bugs.webkit.org/show_bug.cgi?id=112978
3251
3252         Reviewed by Tony Chang.
3253
3254         Running the AddressSanitizer on a crash takes a lot of
3255         memory, so we should serialize access to it to avoid running
3256         out of memory on a machine.
3257
3258         * Scripts/webkitpy/layout_tests/port/chromium.py:
3259         (ChromiumPort._get_crash_log):
3260         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3261         (HttpLock.__init__):
3262         (HttpLock.wait_for_httpd_lock):
3263
3264 2013-03-21  Min Qin  <qinmin@chromium.org>
3265
3266         Cleanup android media layout test code
3267         https://bugs.webkit.org/show_bug.cgi?id=112944
3268
3269         Reviewed by Adam Barth.
3270
3271         Chromium change: https://codereview.chromium.org/12892010/
3272         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
3273         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
3274         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
3275         Instead, we should switch to use content shell for layout tests.
3276
3277         * DumpRenderTree/chromium/TestShell.cpp:
3278         (TestShell::resetTestController):
3279
3280 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3281
3282         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
3283         https://bugs.webkit.org/show_bug.cgi?id=112953
3284
3285         Reviewed by Tony Chang.
3286
3287         When I created the DumpRenderTree_resources target in r144863 I
3288         forgot to declare the needed dependencies on the other resource
3289         targets. Due to a quirk of ordering, this appears to have been fine
3290         w/ ninja but not w/ Xcode (which is still being used on the chromium
3291         mac valgrind bots). Declaring the dependencies fixes the build
3292         failures.
3293
3294         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3295
3296 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
3297
3298         [WinCairo] Correct assert in Empty BitmapImage Test.
3299         https://bugs.webkit.org/show_bug.cgi?id=112934
3300
3301         Reviewed by Tim Horton.
3302
3303         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3304         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
3305         to avoid ref counting assertion when leaving test scope.
3306
3307 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
3308
3309         [GTK] generate-feature-defines-files is incompatible with Python3
3310         https://bugs.webkit.org/show_bug.cgi?id=112956
3311
3312         Reviewed by Martin Robinson.
3313
3314         Make the generate-feature-defines-files compatible with Python3 by calling the items()
3315         method on the dictionary objects when iterating through said dictionaries.
3316
3317         * gtk/generate-feature-defines-files:
3318         (write_feature_defines_header):
3319         (write_flattened_feature_defines_file):
3320
3321 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3322
3323         kill-old-processes spits out error messages on Mac
3324         https://bugs.webkit.org/show_bug.cgi?id=112878
3325
3326         Reviewed by Jessie Berlin.
3327
3328         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
3329         included in the list of options grep --help shows.
3330
3331         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
3332
3333         * BuildSlaveSupport/kill-old-processes:
3334         (main):
3335
3336 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
3337
3338         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
3339         https://bugs.webkit.org/show_bug.cgi?id=112597
3340
3341         Reviewed by Xan Lopez.
3342
3343         These were introduced for the Chromium port in r105295. We need
3344         dummy implementations in order to compile the BlackBerry port.
3345
3346         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3347         (AccessibilityUIElement::scrollToMakeVisible):
3348         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3349         (AccessibilityUIElement::scrollToGlobalPoint):
3350
3351 2013-03-21  Roger Fong  <roger_fong@apple.com>
3352
3353         Re-enable WinEWS tests following r146376.
3354
3355         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3356         (WinEWS):
3357
3358 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
3359
3360         Unreviewed. Add Bem Jones-Bey to the list of contributors.
3361
3362         * Scripts/webkitpy/common/config/committers.py:
3363
3364 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3365
3366         [GTK] Missing atk in install-dependencies script
3367         https://bugs.webkit.org/show_bug.cgi?id=112272
3368
3369         Reviewed by Gustavo Noronha Silva.
3370
3371         * gtk/install-dependencies: Add missing atk dependency.
3372
3373 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3374
3375         [GTK] Missing backslash in install-dependencies script
3376         https://bugs.webkit.org/show_bug.cgi?id=112907
3377
3378         Reviewed by Philippe Normand.
3379
3380         * gtk/install-dependencies: Add missing backslash to dependencies
3381         list.
3382
3383 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3384
3385         EWS bots have stopped uploading results to bugzilla
3386         https://bugs.webkit.org/show_bug.cgi?id=101091
3387
3388         Reviewed by Adam Barth.
3389
3390         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
3391         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
3392         this relative file path resoled to a file inside a non-existent directory for "zip".
3393
3394         Fixed the bug by resolving both test results directory and zip archive paths in
3395         LayoutTestResultsReader.archive.
3396
3397         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
3398         in the future.
3399
3400         * Scripts/webkitpy/common/system/filesystem_mock.py:
3401         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
3402
3403         * Scripts/webkitpy/common/system/workspace.py:
3404         (Workspace.create_zip): Log the source path when "zip" failed.
3405
3406         * Scripts/webkitpy/common/system/workspace_mock.py:
3407         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
3408
3409         * Scripts/webkitpy/common/system/workspace_unittest.py:
3410         (WorkspaceTest.test_create_zip_exception): Test that.
3411
3412         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3413         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
3414         This is the actual bug fix.
3415
3416         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3417         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
3418
3419 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
3420
3421         [chromium] move WebThemeEngine implementations to TestRunner library
3422         https://bugs.webkit.org/show_bug.cgi?id=112751
3423
3424         Reviewed by Adam Barth.
3425
3426         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3427         * DumpRenderTree/DumpRenderTree.gypi:
3428         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3429         (WebKit):
3430         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3431         (WebTestRunner::TestInterfaces::themeEngine):
3432         (WebTestRunner):
3433         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3434         (WebKit):
3435         (TestInterfaces):
3436         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3437         (WebTestRunner::WebTestInterfaces::themeEngine):
3438         (WebTestRunner):
3439         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3440         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3441         (WebTestRunner):
3442         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3443         (WebTestRunner::WebTestThemeControlWin::box):
3444         (WebTestRunner::WebTestThemeControlWin::line):
3445         (WebTestRunner::WebTestThemeControlWin::triangle):
3446         (WebTestRunner::WebTestThemeControlWin::roundRect):
3447         (WebTestRunner::WebTestThemeControlWin::oval):
3448         (WebTestRunner::WebTestThemeControlWin::circle):
3449         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3450         (WebTestRunner::WebTestThemeControlWin::markState):
3451         (WebTestRunner::WebTestThemeControlWin::draw):
3452         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3453         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3454         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3455         (WebTestRunner):
3456         (WebTestThemeControlWin):
3457         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3458         (WebTestRunner):
3459         (WebTestThemeEngineMac):
3460         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3461         (+[FakeActiveWindow alwaysActiveWindow]):
3462         (+[FakeActiveWindow alwaysInactiveWindow]):
3463         (-[FakeActiveWindow initWithActiveControls:]):
3464         (-[FakeActiveWindow _hasActiveControls]):
3465         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3466         (WebTestRunner):
3467         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3468         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3469         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3470         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3471         (WebTestRunner):
3472         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3473         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3474         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3475         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3476         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3477         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3478         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3479         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3480         (WebTestRunner::WebTestThemeEngineWin::getSize):
3481         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3482         (WebTestRunner):
3483         (WebTestThemeEngineWin):
3484         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3485         * DumpRenderTree/chromium/TestShell.cpp:
3486         (TestShell::initialize):
3487         * DumpRenderTree/chromium/TestShell.h:
3488         (WebKit):
3489         * DumpRenderTree/chromium/TestShellMac.mm:
3490         (platformInit):
3491         * DumpRenderTree/chromium/TestShellWin.cpp:
3492         (platformInit):
3493         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3494
3495 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3496
3497         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
3498
3499         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
3500         New property sheet that does not link against CoreFoundation and
3501         CFNetwork.
3502         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3503         Use new TestWebKitAPICommonWinCairo property sheet.
3504         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3505         Ditto.
3506
3507 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3508
3509         [WinCairo] Unreviewed build fix for VS2010.
3510
3511         Had to add WinCairo-specific property sheets to deal with some
3512         library and path differences with the main Apple port.
3513
3514         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3515         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3516         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3517         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
3518         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
3519         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
3520
3521 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
3522
3523         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
3524         https://bugs.webkit.org/show_bug.cgi?id=112849
3525
3526         Reviewed by Sam Weinig.
3527
3528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3531
3532 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3533
3534         [WinCairo] Build WebKit Tools under VS2010
3535         https://bugs.webkit.org/show_bug.cgi?id=112821
3536
3537         Reviewed by Tim Horton.
3538
3539         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3540         Add WinCairo-specific build target.
3541         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
3542         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
3543         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
3544         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
3545         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3546         Add WinCairo-specific build target.
3547         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3548         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3549         Add WinCairo-specific build target.
3550         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
3551         WinCairo-specific build target.
3552         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
3553         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
3554         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
3555         specific build target.
3556         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
3557         WinCairo-specific build target.
3558         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
3559         * win/record-memory/record-memoryDebugWinCairo.props: Added.
3560         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
3561
3562 2013-03-20  Roger Fong  <roger_fong@apple.com>
3563
3564         API test gardening AppleWin port.
3565
3566         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
3567
3568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3569         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3570
3571 2013-03-20  Roger Fong  <roger_fong@apple.com>
3572
3573         Test fix for Win EWS bots, catch various errors and restart script if necessary.
3574
3575         * EWSTools/start-queue-win.sh:
3576
3577 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
3578
3579         Unreviewed, add myself to committers.py.
3580
3581 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3582
3583         Unreviewed. Adding another email for me.
3584
3585         * Scripts/webkitpy/common/config/committers.py:
3586
3587 2013-03-20  Justin Novosad  <junov@google.com>
3588
3589         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
3590         https://bugs.webkit.org/show_bug.cgi?id=112605
3591
3592         Reviewed by James Robinson.
3593
3594         Deleting all the code that was used for propagating and supporting
3595         the Chromium setting for disabling deferred 2d canvas rendering.
3596
3597         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3598         (main):
3599         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3600         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3601         (WebTestRunner::WebPreferences::reset):
3602         (WebTestRunner::WebPreferences::applyTo):
3603         * DumpRenderTree/chromium/TestShell.cpp:
3604         (TestShell::TestShell):
3605         (TestShell::resetWebSettings):
3606         (TestShell::runFileTest):
3607         * DumpRenderTree/chromium/TestShell.h:
3608         (TestShell):
3609
3610 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
3611
3612         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
3613         https://bugs.webkit.org/show_bug.cgi?id=112699.
3614
3615         Reviewed by Adam Barth.
3616
3617         * Scripts/webkitpy/layout_tests/port/qt.py:
3618         (QtPort._search_paths):
3619         (QtPort._port_specific_expectations_files):
3620         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3621         (QtPortTest):
3622         (QtPortTest._assert_search_path):
3623         (QtPortTest._assert_expectations_files):
3624
3625 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3626
3627         [Qt] Enable kerning by default
3628         https://bugs.webkit.org/show_bug.cgi?id=112704
3629
3630         Reviewed by Jocelyn Turcotte.
3631
3632         Disable kerning by default, since some reference test expectations
3633         expect kerning to be default off.
3634
3635         * DumpRenderTree/qt/TestRunnerQt.cpp:
3636         (TestRunnerQt::reset):
3637         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3638         (WTR::activateFonts):
3639
3640 2013-03-20  Zeno Albisser  <zeno@webkit.org>
3641
3642         [Qt] Remove empty function stubs from TestRunnerQt.
3643         https://bugs.webkit.org/show_bug.cgi?id=112799
3644
3645         We are reducing the code in TestRunnerQt step by step,
3646         in order to finally replace all of it with the generic
3647         TestRunner implementation.
3648         This patch removes several simple function stubs that
3649         currently do not implement any actual functionality.
3650
3651         Reviewed by Kenneth Rohde Christiansen.
3652
3653         * DumpRenderTree/qt/TestRunnerQt.cpp:
3654         * DumpRenderTree/qt/TestRunnerQt.h:
3655         (TestRunnerQt):
3656
3657 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3658
3659         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
3660         https://bugs.webkit.org/show_bug.cgi?id=112687
3661
3662         Reviewed by Kenneth Rohde Christiansen.
3663
3664         Hide the SearchBar by default on window creation.
3665
3666         * MiniBrowser/efl/main.c:
3667         (window_create):
3668
3669 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3670
3671         Unreviewed, rolling out r146304.
3672         http://trac.webkit.org/changeset/146304
3673         https://bugs.webkit.org/show_bug.cgi?id=112788
3674
3675         to many expectations to update (Requested by antonm on
3676         #webkit).
3677
3678         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3679         * DumpRenderTree/DumpRenderTree.gypi:
3680         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3681         (WebKit):