95b0d5d41b43d408cadd3f05e674f9bbcceb81c1
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
2
3         Fix some errors on bot watcher's dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=149789
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
9         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
10         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
11
12 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
13
14         Bot watcher's dashboard builders should turn yellow when svn fails
15         https://bugs.webkit.org/show_bug.cgi?id=149791
16
17         Reviewed by Lucas Forschler.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
20         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
21         (BuildbotBuilderQueueView.prototype.update):
22
23 2015-10-02  Daniel Bates  <dabates@apple.com>
24
25         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
26         https://bugs.webkit.org/show_bug.cgi?id=149769
27
28         Reviewed by Alexey Proskuryakov.
29
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
31         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
32         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
33         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
34         (WebKitBuildbot):
35         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
36         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
37
38 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
39
40         REGRESSION(r190370): Speedometer spits out an extra console message
41         https://bugs.webkit.org/show_bug.cgi?id=149720
42
43         Unreviewed. Temporarily ignore the console error message.
44
45         * Scripts/webkitpy/performance_tests/perftest.py:
46         (PerfTest._filter_output):
47
48 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
49
50         Provide "--no-ninja" option to avoid using Ninja
51         https://bugs.webkit.org/show_bug.cgi?id=149757
52
53         Reviewed by Alex Christensen.
54
55         Add a new command line argument understood by webkitdirs.pm so
56         that we can conditionally avoid using Ninja. This is an
57         'opt-out' argument, so no existing Ninja users should be affected.
58         
59         * Scripts/webkitdirs.pm:
60         (canUseNinja): Check for option and block ninja if present.
61
62 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
63
64         Flakiness dashboard should support OS X El Capitan
65         https://bugs.webkit.org/show_bug.cgi?id=149648
66
67         Reviewed by Alexey Proskuryakov.
68
69         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
70
71 2015-10-02  Daniel Bates  <dabates@apple.com>
72
73         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
74         (https://bugs.webkit.org/show_bug.cgi?id=149753)
75
76         For now, pass --ios-simulator.
77
78         * Scripts/webkitpy/port/ios.py:
79         (IOSSimulatorPort._build_relay):
80
81 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
82
83         Remove a "nullable" that breaks the iOS 8 build.
84
85         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
86         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
87
88 2015-10-02  Daniel Bates  <dabates@apple.com>
89
90         LayoutTestRelay is not built and archived when building for iOS Simulator
91         https://bugs.webkit.org/show_bug.cgi?id=149753
92
93         Reviewed by Alexey Proskuryakov and Andy Estes.
94
95         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
96         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
97         product archive when building for iOS Simulator, respectively.
98
99         * BuildSlaveSupport/built-product-archive:
100         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
101         differentiate between iOS device and iOS Simulator platforms.
102         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
103         from determineWebKitBuildDirectories() into this function so that it can be used by both
104         determineWebKitBuildDirectories() and archiveBuiltProduct().
105         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
106         webkitBuildDirectoryForConfigurationAndPlatform().
107         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
108         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
109         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
110         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
111         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
112         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
113         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
114         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
115         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
116         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
117         * Scripts/build-layouttestrelay:
118             - Remove unnecessary include of Perl module POSIX.
119             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
120         * Scripts/build-webkit:
121             - Invoke script build-layouttestrelay when building for iOS Simulator.
122
123 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
124
125         [Win] Unreviewed test fix.
126
127         You cannot run 'run-webkit-tests' from the command line because it does not know
128         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
129         because they explicitly set use the 'root' argument to provide the full path to
130         the test binaries.
131
132         * Scripts/webkitpy/port/win.py:
133         (WinPort._build_path): Added.
134
135 2015-10-02  Alex Christensen  <achristensen@webkit.org>
136
137         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
138         https://bugs.webkit.org/show_bug.cgi?id=149430
139         rdar://problem/22742222
140
141         Reviewed by Geoffrey Garen.
142
143         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
144         (WTR::TestController::cocoaResetStateToConsistentValues):
145         * WebKitTestRunner/mac/TestControllerMac.mm:
146         (WTR::TestController::platformConfigureViewForTest):
147         Test what happens when you disable content blockers from the SPI.
148
149 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
150
151         [Win] Unreviewed build fix for run-api-tests
152
153         * Scripts/run-api-tests:
154         (testToolPaths): Windows run needs to specify the binary path.
155
156 2015-10-01  Daniel Bates  <dabates@apple.com>
157
158         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
159         (https://bugs.webkit.org/show_bug.cgi?id=149695)
160
161         Following r190424 we can now rely on webkit-build-directory to return the path to
162         the correct configuration-specific build directory on Windows.
163
164         * BuildSlaveSupport/built-product-archive:
165         (archiveBuiltProduct):
166
167 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
168
169         [Win] Unreviewed build fix.
170
171         * Scripts/webkitdirs.pm:
172         (setupAppleWinEnv): Use 64-bit build tools if available
173
174 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
175
176         [Win] Fix TestWebKitAPI build under CMake.
177
178         Reviewed by Alex Christensen.
179
180         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
181         for Psapi.lib.
182
183 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
184
185         [Win] Fix behavior of webkit-build-directory script
186         https://bugs.webkit.org/show_bug.cgi?id=149718
187
188         Reviewed by Alex Christensen.
189
190         * Scripts/webkitdirs.pm:
191         (determineConfigurationProductDir): Do not include the binary
192         sub-directory in the configuration product directory output.
193         (jscProductDir): Append correct binary path for Windows build.
194         (setPathForRunningWebKitApp): Include properly binary subdirectories.
195         (runSafari): Update for revised productDir behavior.
196         (runMiniBrowser): Ditto.
197
198 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
199
200         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
201         use iOS SDK, like with all the others.
202
203         * Scripts/build-webkit:
204
205 2015-10-01  Daniel Bates  <dabates@apple.com>
206
207         Attempt to fix the iOS 9 Simulator testers
208
209         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
210         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
211         LayoutTestRelay when building for iOS Simulator.
212
213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
214         * Scripts/build-webkit:
215
216 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
217
218         [GTK] Websites with invalid auth header keep loading forever
219         https://bugs.webkit.org/show_bug.cgi?id=149710
220
221         Reviewed by Martin Robinson.
222
223         Add test case to check that we can authenticate sites with an
224         empty realm.
225
226         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
227         (testWebViewAuthenticationEmptyRealm):
228         (serverCallback):
229         (beforeAll):
230
231 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
232
233         [Mac] Make run-api-tests work with System Integrity Protection
234         https://bugs.webkit.org/show_bug.cgi?id=149711
235         rdar://problem/22928202
236
237         Reviewed by Dan Bernstein.
238
239         * Scripts/run-api-tests:
240         (runTest):
241         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
242
243 2015-10-01  Daniel Bates  <dabates@apple.com>
244
245         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
246         (https://bugs.webkit.org/show_bug.cgi?id=149695)
247
248         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
249         For now, use the path to the top-level WebKit build directory instead of using the configuration-
250         specific build directory.
251
252         * BuildSlaveSupport/built-product-archive:
253         (archiveBuiltProduct):
254
255 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
256
257         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
258         https://bugs.webkit.org/show_bug.cgi?id=145837
259
260         Reviewed by Philippe Normand.
261
262         * efl/jhbuild.modules:
263         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
264         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
265
266 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         Unreviewed. Fix the iOS build after r190407.
269
270         * WebKitTestRunner/ios/IOKitSPI.h:
271
272 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
273
274         Implement keyboard event sending for iOS in WebKitTestRunner
275         https://bugs.webkit.org/show_bug.cgi?id=149676
276
277         Reviewed by Simon Fraser.
278
279         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
280         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
281         allows us to run code when the keyboard is shown or hidden.
282
283         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
284         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
285         (WTR::UIScriptController::setDidShowKeyboardCallback):
286         (WTR::UIScriptController::didShowKeyboardCallback):
287         (WTR::UIScriptController::setDidHideKeyboardCallback):
288         (WTR::UIScriptController::didHideKeyboardCallback):
289         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
290         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
291         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
292         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
293         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
294         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
295         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
296                 the notifications that the keyboard has been raised or lowered.
297         (-[TestRunnerWKWebView _keyboardDidShow:]):
298         (-[TestRunnerWKWebView _keyboardDidHide:]):
299         * WebKitTestRunner/ios/HIDEventGenerator.h:
300         * WebKitTestRunner/ios/HIDEventGenerator.m:
301         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
302         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
303         (hidUsageCodeForCharacter): Ditto.
304         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
305                 a keyDown event in WebKit.
306         * WebKitTestRunner/ios/IOKitSPI.h:
307         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
308
309 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
310
311         Unreviewed, rolling out r190399.
312
313         Tests are still failing even after r190362
314
315         Reverted changeset:
316
317         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
318         http://trac.webkit.org/changeset/190399
319
320 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
321
322         [jhbuild] switch to new upstream usrsctp library
323         https://bugs.webkit.org/show_bug.cgi?id=149494
324
325         Reviewed by Philippe Normand.
326
327         * efl/jhbuild.modules:
328         * gtk/jhbuild.modules:
329
330 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
331
332         Unreviewed. Unskip GTK+ user media unit tests after r190362.
333
334         They should pass now.
335
336         * Scripts/run-gtk-tests:
337         (TestRunner):
338
339 2015-09-30  Daniel Bates  <dabates@apple.com>
340
341         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
342         (https://bugs.webkit.org/show_bug.cgi?id=149695)
343
344         * BuildSlaveSupport/built-product-archive:
345         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
346         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
347
348 2015-09-30  Daniel Bates  <dabates@apple.com>
349
350         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
351         (https://bugs.webkit.org/show_bug.cgi?id=149695)
352
353         Actually, we need to pass --configuration to script webkit-build-directory to have
354         it return the path to the configuration-specific build directory.
355
356         * BuildSlaveSupport/built-product-archive:
357         (determineWebKitBuildDirectories):
358
359 2015-09-30  Daniel Bates  <dabates@apple.com>
360
361         built-product-archive archives incorrect build directory for iOS port
362         https://bugs.webkit.org/show_bug.cgi?id=149695
363
364         Reviewed by Darin Adler.
365
366         Fixes an issue where the script built-product-archive archives a non-existent
367         build directory for the iOS port. Without loss of generality, the script assumes
368         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
369         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
370
371         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
372         to determine the top-level build directory and computes the configuration-specific
373         build directory to be the concatenation of the the top-level build directory and
374         the configuration (e.g. Release). This is incorrect. Instead we should call
375         webkit-build-directory omitting the flag --top-level to compute the path to the
376         configuration-specific build directory.
377
378         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
379         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
380         its purpose and added global variable _configurationBuildDirectory to store the path
381         to the configuration-specific build directory. Ensure that we have a non-empty string
382         for both the top-level and configuration-specific build directories.
383         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
384         Compute the configuration-specific build directory and store it in the global variable
385         _configurationBuildDirectory.
386         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
387         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
388         as needed.
389         (determineWebKitBuildDirectory): Deleted.
390
391 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
392
393         [EFL] css3/device-adapt/* tests failed after r190335.
394         https://bugs.webkit.org/show_bug.cgi?id=149655
395
396         Reviewed by Simon Fraser.
397
398         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
399         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
400
401         * WebKitTestRunner/efl/TestControllerEfl.cpp:
402         (WTR::shouldUseFixedLayout):
403
404 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
405
406         Extend JetStream timeout for slow devices.
407
408         Reviewed by Chris Dumez.
409
410         Extend JetStream timeout to 20 minutes.
411
412         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
413
414 2015-09-30  Daniel Bates  <dabates@apple.com>
415
416         Rename iOS builders/testers to include version
417         https://bugs.webkit.org/show_bug.cgi?id=149685
418
419         Reviewed by Simon Fraser.
420
421         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
422         make it clear to a reader the version of iOS these builders/testers are using.
423
424         * BuildSlaveSupport/build.webkit.org-config/config.json:
425         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
426
427 2015-09-30  Daniel Bates  <dabates@apple.com>
428
429         Add iOS criterion for triggering a build
430         https://bugs.webkit.org/show_bug.cgi?id=149679
431
432         Rubber-stamped by Alexey Proskuryakov.
433
434         First pass at defining criterion for triggering an iOS build.
435
436         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
437         (_should_file_trigger_build):
438         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
439         (ShouldBuildTest):
440         (ShouldBuildTest.test_should_build):
441
442 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
443
444         [iOS] Allow tests to generate user gestures for UI testing
445         https://bugs.webkit.org/show_bug.cgi?id=149653
446
447         Reviewed by Tim Horton.
448
449         Expose functionality in UIScriptController to allow for testing single- and double-tap,
450         and to listen for completion of scrolling and zooming in the WKWebView.
451         
452         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
453         which hides the complexity of creating these events. Event dispatch is asynchronous.
454         We detect when the last event has been handled by dispatching a vendor-specific event,
455         which is detected via -_handleHIDEvent: in our UIApplication subclass.
456         
457         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
458         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
459         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
460         single and double taps.
461         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
462         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
463         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
464         (UIScriptContext::unregisterCallback):
465         (UIScriptContext::callbackWithID):
466         (UIScriptContext::fireCallback):
467         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
468         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
469         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
470         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
471         (WTR::UIScriptController::setDidEndZoomingCallback):
472         (WTR::UIScriptController::didEndZoomingCallback):
473         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
474         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
475         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
476         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
477         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
478         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
479         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
480         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
481         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
482         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
483         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
484         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
485         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
486         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
487         (simpleDragCurve):
488         (calculateNextLocation):
489         (delayBetweenMove):
490         (+[HIDEventGenerator sharedHIDEventGenerator]):
491         (+[HIDEventGenerator nextEventCallbackID]):
492         (-[HIDEventGenerator init]):
493         (-[HIDEventGenerator _createIOHIDEventType:]):
494         (-[HIDEventGenerator _sendHIDEvent:]):
495         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
496         (-[HIDEventGenerator _updateTouchPoints:count:]):
497         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
498         (-[HIDEventGenerator touchDown:touchCount:]):
499         (-[HIDEventGenerator touchDown:]):
500         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
501         (-[HIDEventGenerator liftUp:touchCount:]):
502         (-[HIDEventGenerator liftUp:]):
503         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
504         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
505         (-[HIDEventGenerator tap:completionBlock:]):
506         (-[HIDEventGenerator doubleTap:completionBlock:]):
507         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
508         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
509         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
510         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
511         (-[HIDEventGenerator markerEventReceived:]):
512         * WebKitTestRunner/ios/IOKitSPI.h: Added.
513         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
514         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
515         (WTR::globalToContentCoordinates):
516         (WTR::UIScriptController::singleTapAtPoint):
517         (WTR::UIScriptController::doubleTapAtPoint):
518         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
519         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
520         * WebKitTestRunner/ios/mainIOS.mm:
521         (-[WebKitTestRunnerApp _handleHIDEvent:]):
522
523 2015-09-30  Dana Burkart  <dburkart@apple.com>
524
525         git-add-reviewer should trim trailing spaces/newlines
526         https://bugs.webkit.org/show_bug.cgi?id=149513
527
528         Reviewed by Darin Adler.
529
530         * Scripts/git-add-reviewer:
531         (nonInteractive):
532
533 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
534
535         REGRESSION(r190262): User media unit test failures after r190262
536         https://bugs.webkit.org/show_bug.cgi?id=149580
537
538         Reviewed by Darin Adler.
539
540         * WebKitTestRunner/TestController.cpp:
541         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
542           order to WKUserMediaPermissionRequestAllow.
543
544 2015-09-30  Daniel Bates  <dabates@apple.com>
545
546         Add iOS builders and testers
547         https://bugs.webkit.org/show_bug.cgi?id=149549
548
549         Reviewed by Alexey Proskuryakov.
550
551         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
552         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
553
554         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
555         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
556
557 2015-09-30  Timothy Hatcher  <timothy@apple.com>
558
559         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
560         https://bugs.webkit.org/show_bug.cgi?id=149674
561
562         Reviewed by Lucas Forschler.
563
564         * WebKitLauncher/WebKitLauncher.entitlements: Added.
565         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
566
567 2015-09-30  Jason Marcell  <jmarcell@apple.com>
568
569         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
570         have an associated trac instance.
571         https://bugs.webkit.org/show_bug.cgi?id=149673
572
573         Reviewed by Alexey Proskuryakov.
574
575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
576         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
577         have an associated trac instance.
578
579 2015-09-30  Daniel Bates  <dabates@apple.com>
580
581         Prioritize testing latest build request on iOS test bots
582         https://bugs.webkit.org/show_bug.cgi?id=149669
583
584         Reviewed by Darin Adler.
585
586         We should prioritize testing of the latest build request on the iOS test bots
587         as we do for Mac and Windows test bots.
588
589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
590         (loadBuilderConfig):
591
592 2015-09-30  Daniel Bates  <dabates@apple.com>
593
594         Add buildbot category for iOS builders and testers
595         https://bugs.webkit.org/show_bug.cgi?id=149667
596
597         Reviewed by Darin Adler.
598
599         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
600         for iOS to the build.webkit.org home page.
601
602         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
603         (loadBuilderConfig):
604         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
605
606 2015-09-30  Daniel Bates  <dabates@apple.com>
607
608         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
609         (https://bugs.webkit.org/show_bug.cgi?id=149539)
610
611         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
612         in <http://trac.webkit.org/changeset/190351>.
613
614         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
615         (CompileWebKit.start):
616
617 2015-09-30  Daniel Bates  <dabates@apple.com>
618
619         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
620         (https://bugs.webkit.org/show_bug.cgi?id=149539)
621
622         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
623         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
624
625         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
626         (CompileWebKit.start):
627
628 2015-09-30  Lucas Forschler  <lforschler@apple.com>
629
630         bot210 was configured for a queue instead of bot126.
631         
632         Unreviewed config.json fix.
633         
634         * BuildSlaveSupport/build.webkit.org-config/config.json:
635
636 2015-09-30  Lucas Forschler  <lforschler@apple.com>
637
638         Bring El Capitan buildbot infrastructure online.
639         https://bugs.webkit.org/show_bug.cgi?id=149605
640         
641         Reviewed by Darin Adler.
642
643         * BuildSlaveSupport/build.webkit.org-config/config.json:
644
645 2015-09-30  Tomas Popela  <tpopela@redhat.com>
646
647         [GTK] Deprecation warnings in DOMNodeTest
648         https://bugs.webkit.org/show_bug.cgi?id=149663
649
650         After the webkit_dom_document_get_elements_by_tag_name deprecation we
651         need to update the tests to use webkit_dom_document_query_selector_all
652         to avoid compilation warnings.
653
654         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
655         (the suggested replacement for the deprecated function).
656
657         Reviewed by Carlos Garcia Campos.
658
659         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
660         (WebKitDOMNodeTest::testTagNamesNodeList):
661         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
662         (registerTests):
663         (WebKitDOMNodeTest::testTagNames): Deleted.
664         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
665         (prepareDOMForTagNamesTests):
666         (testWebKitDOMNodeTagNamesNodeList):
667         (testWebKitDOMNodeTagNamesHTMLCollection):
668         (beforeAll):
669         (testWebKitDOMNodeTagNames): Deleted.
670
671 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
672
673         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
674         https://bugs.webkit.org/show_bug.cgi?id=149650
675
676         Reviewed by Tim Horton.
677         
678         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
679         looks at the file path, and not the custom options that come from file comments.
680         
681         Fix by computing TestOptions before making the TestInvocation, and setting them
682         as const TestInvocation data. This meant changing various call sites to take
683         the std::string pathOrURL, rather than the TestInvocation itself.
684         
685         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
686
687         * WebKitTestRunner/CMakeLists.txt:
688         * WebKitTestRunner/TestController.cpp:
689         (WTR::TestController::ensureViewSupportsOptionsForTest):
690         (WTR::testPath):
691         (WTR::createTestURL):
692         (WTR::updateTestOptionsFromTestHeader):
693         (WTR::TestController::testOptionsForTest):
694         (WTR::TestController::updateWebViewSizeForTest):
695         (WTR::TestController::updateWindowScaleForTest):
696         (WTR::TestController::runTest):
697         * WebKitTestRunner/TestController.h:
698         * WebKitTestRunner/TestInvocation.cpp:
699         (WTR::TestInvocation::TestInvocation):
700         (WTR::TestInvocation::invoke):
701         (WTR::createWKURL): Deleted.
702         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
703         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
704         * WebKitTestRunner/TestInvocation.h:
705         (WTR::TestInvocation::options):
706         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
707         (WTR::pathContains):
708         (WTR::shouldMakeViewportFlexible):
709         (WTR::shouldUseFixedLayout):
710         (WTR::isSVGTestPath):
711         (WTR::isHiDPITestPath):
712         (WTR::TestOptions::TestOptions):
713         * WebKitTestRunner/TestOptions.h:
714         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
715         * WebKitTestRunner/efl/TestControllerEfl.cpp:
716         (WTR::pathContains):
717         (WTR::shouldUseFixedLayout):
718         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
719         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
720         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
721         * WebKitTestRunner/ios/TestControllerIOS.mm:
722         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
723         * WebKitTestRunner/mac/TestControllerMac.mm:
724         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
725
726 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
727
728         Flakiness dashboard should support OS X El Capitan
729         https://bugs.webkit.org/show_bug.cgi?id=149648
730
731         Reviewed by Alexey Proskuryakov.
732
733         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
734         difference between new appscale and old Google App Engine implementation.
735         * TestResultServer/app.yaml: Same.
736         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
737
738 2015-09-29  Daniel Bates  <dabates@apple.com>
739
740         configure-xcode-for-ios-development does not work with Xcode 7
741         https://bugs.webkit.org/show_bug.cgi?id=149640
742
743         Reviewed by Alexey Proskuryakov.
744
745         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
746         because it cannot find the Xcode specification files for iOS simulator and device. These
747         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
748         relevant definitions to the Xcode 7 specification files directly as opposed to creating
749         new specification files with the added definitions (as we did in older versions of Xcode)
750         in order for Xcode 7 to honor these definitions.
751
752         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
753         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
754         (updateXcode7SpecificationFile): Added.
755         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
756         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
757         appropriate success message.
758         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
759         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
760         (createXcodeSpecificationFromSpecificationAndId): Deleted.
761
762 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
763
764         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
765         https://bugs.webkit.org/show_bug.cgi?id=149639
766
767         Reviewed by Alex Christensen.
768
769         * Scripts/VCSUtils.pm:
770         (exitStatus): Use 'isWindows()' method.
771         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
772         an error. This method could probably just go away.
773         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
774         always changing to Unix style. 
775         (unixPath): Added. Needed so Windows can always show a Unix path in the
776         ChangeLog file.
777         (changeLogName): Work around the fact that 'getpwuid' is not available on
778         a pure Windows build of Perl.
779         * Scripts/prepare-ChangeLog:
780         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
781         path on Windows.
782         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
783         support using arrays for 'open' arguments.
784         (resolveChangeLogsPath): Ditto.
785         (resolveConflictedChangeLogs): Use new helper functions.
786         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
787         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
788         quotes. Unix systems are happy either way.
789         (statusCommand): Ditto.
790         * Scripts/webkitdirs.pm:
791         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
792
793 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Unreviewed 64-bit build fix after switch to CMake.
796
797         * Scripts/webkitdirs.pm:
798         (determineIsWin64FromArchitecture): Added.
799
800 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         printing does not use minimum page zoom factor
803         https://bugs.webkit.org/show_bug.cgi?id=108507
804
805         Reviewed by Darin Adler.
806
807         WebKitTestRunner always takes the snapshots from the UI process
808         (expect for IOS), so in the case of printing, the layout in the
809         web view is not the expected one. When printing, we need to take
810         the snapshot in the web process and ensure it's rendered with a
811         PrintContext.
812
813         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
814         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
815         kWKSnapshotOptionsPrinting option to
816         WKBundlePageCreateSnapshotWithOptions() when printing.
817
818 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
819
820         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
821         https://bugs.webkit.org/show_bug.cgi?id=149595
822
823         Reviewed by Tim Horton.
824
825         All ports except IOS implement
826         PlatformWebView::windowSnapshotImage() to generate the snapshot
827         for the pixel tests in the UI process. But we are still generating
828         a snapshot for pixel tests in the Web process too, that is passed
829         to the UI process but ignored.
830         Whether a pixel result is needed or not, is only known by the web
831         process depending on whether the test called dumpAsText with
832         dumpPixels == true or not. Since the pixels are now dump in the UI
833         process, we need to pass that information to the UI process when
834         the test is done. For that we set a PixelResultIsPending bool
835         parameter to the Done message, and we only add the PixelResult
836         when UI process doesn't need to generate the pixels dump.
837
838         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
839         (WTR::InjectedBundle::didReceiveMessageToPage): Set
840         m_pixelResultIsPending to false on reset.
841         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
842         Done message, and set the PixelResult if m_pixelResultIsPending is false.
843         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
844         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
845         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
847         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
848         port.
849         * WebKitTestRunner/TestInvocation.cpp:
850         (WTR::TestInvocation::dumpResults): Use either the pixel result
851         from the web process or generate a pixel result from the web view
852         if need it.
853         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
854         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
855         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
856         is created by the caller now, but the CG implementation needs to
857         know if it's a Web or UI process snapshot.
858         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
859         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
860         cairo surface for the given image.
861         * WebKitTestRunner/cg/TestInvocationCG.cpp:
862         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
863         CGContext for the given image.
864
865 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
866
867         Fix JS errors on dashboard metrics page
868         https://bugs.webkit.org/show_bug.cgi?id=149608
869
870         Reviewed by Alexey Proskuryakov.
871
872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
873         (initPlatformsByFamily): 
874         (updateHiddenPlatforms):
875         (parsePlatformFamily): Deleted.
876         (updateToggleButtons): Deleted.
877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
878         (updateHiddenPlatforms): Added to remove errors.
879         (initPlatformsByFamily): Added to remove errors.
880         (unhiddenQueues): Updated to use Settings.
881         (documentReady): Added logic to add toggle buttons to the settings menu.
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
883         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
884         MetricsMain.js to Settings.
885         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
886         MetricsMain.js to Settings.
887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
888         (QueueView.prototype._updateHiddenState): Updated to use Settings.
889
890 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
891
892         Appscale query fails because of missing index
893         https://bugs.webkit.org/show_bug.cgi?id=149609
894
895         Reviewed by Darin Adler.
896
897         * QueueStatusServer/index.yaml: Added the required index.
898
899 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
900
901         [Win] Fix the 64-bit build after switch to cmake.
902
903         Reviewed by Alex Christensen.
904
905         * Scripts/webkitdirs.pm:
906         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
907         run a 64-bit build.
908
909 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
910
911         [Win] Allow Windows to run test-webkitpy without Cygwin
912         https://bugs.webkit.org/show_bug.cgi?id=149602
913
914         Reviewed by Alex Christensen.
915
916         These changes mostly shift from hard-coded paths using UNIX-style
917         separators to Python's "os.path.join" syntax that uses the correct
918         path separator for each platform.
919         
920         * Scripts/webkitpy/common/system/path.py:
921         (cygpath): Don't pass paths through Cygpath on native Windows.
922         * Scripts/webkitpy/port/win.py:
923         (WinPort._path_to_apache): Use os.path.join.
924         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
925         in 64-bit environments).
926         * Scripts/webkitpy/style/checker.py: Use os.path.join.
927         * Scripts/webkitpy/style/checker_unittest.py:
928         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
929         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
930         (GlobalVariablesTest): Ditto.
931         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
932         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
933         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
934         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
935         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
936         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
937         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
938         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
939         (StyleProcessor_CodeCoverageTest): Ditto.
940         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
941         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
942         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
943         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
944         manual string concatenation of paths.
945
946 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
947
948         Add bugzilla addresses of committers to contributors.json
949         https://bugs.webkit.org/show_bug.cgi?id=149520
950
951         Reviewed by Darin Adler.
952
953         * Scripts/webkitpy/common/config/contributors.json:
954
955 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
956
957         validate-committer-lists -b shouldn't need edituser privileges
958         https://bugs.webkit.org/show_bug.cgi?id=149519
959
960         Reviewed by Darin Adler.
961
962         * Scripts/validate-committer-lists:
963         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
964         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
965         (BugzillaQueries.is_invalid_bugzilla_email):
966         (BugzillaQueries): Deleted.
967         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
968
969 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
970
971         Unreviewed. Gardening: skip media stream tests failing after r190262.
972
973         * Scripts/run-gtk-tests:
974         (TestRunner):
975
976 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
977
978         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
979         https://bugs.webkit.org/show_bug.cgi?id=149571
980
981         Reviewed by Dan Bernstein.
982
983         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
984
985         * DumpRenderTree/mac/Configurations/Base.xcconfig:
986         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
987         * LayoutTestRelay/Configurations/Base.xcconfig:
988         * MiniBrowser/Configurations/Base.xcconfig:
989         * MiniBrowser/Configurations/DebugRelease.xcconfig:
990         * TestWebKitAPI/Configurations/Base.xcconfig:
991         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
992         * WebEditingTester/Configurations/Base.xcconfig:
993         * WebEditingTester/Configurations/DebugRelease.xcconfig:
994         * WebKitTestRunner/Configurations/Base.xcconfig:
995         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
996         * WebKitTestRunner/iOS.xcconfig: Removed.
997
998 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
999
1000         Clean up user media request internal API
1001         https://bugs.webkit.org/show_bug.cgi?id=149527
1002
1003         Reviewed by Tim Horton.
1004
1005         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1006         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1007
1008         * WebKitTestRunner/TestController.cpp:
1009         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1010
1011 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1012
1013         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1014         https://bugs.webkit.org/show_bug.cgi?id=149577
1015
1016         Reviewed by Tim Horton.
1017         
1018         When calling testRunner.runUIScript() from a page load event, the script could run
1019         in the UI process before the current remote layer tree transaction had been handled
1020         there. This meant that runUIScript() could query state which was about to change.
1021         
1022         Fix by delaying the execution of the UI script until a layer tree transaction has
1023         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1024
1025         * WebKitTestRunner/TestInvocation.cpp:
1026         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1027         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1028         * WebKitTestRunner/TestInvocation.h:
1029
1030 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1031
1032         [Mac] Media tests start to time out after a few days of bot uptime
1033         https://bugs.webkit.org/show_bug.cgi?id=149468
1034
1035         Reviewed by Darin Adler.
1036
1037         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1038         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1039         all temporary and cache files go to a custom location.
1040
1041         * Scripts/webkitpy/port/base.py:
1042         * Scripts/webkitpy/port/driver.py:
1043         * Scripts/webkitpy/port/mac.py:
1044         * Scripts/webkitpy/port/win.py:
1045         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1046
1047 2015-09-25  Dan Bernstein  <mitz@apple.com>
1048
1049         Removed MiniBrowser.entitlements.
1050
1051         Rubber-stamped by Anders Carlsson.
1052
1053         The entitlements weren’t used anyway.
1054
1055         * MiniBrowser/MiniBrowser.entitlements: Removed.
1056         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1057
1058 2015-09-24  Daniel Bates  <dabates@apple.com>
1059
1060         Add WebKitSystemInterface for iOS 9.0
1061         https://bugs.webkit.org/show_bug.cgi?id=149550
1062
1063         Rubber-stamped by Alexey Proskuryakov.
1064
1065         * Scripts/copy-webkitlibraries-to-product-directory:
1066
1067 2015-09-24  Daniel Bates  <dabates@apple.com>
1068
1069         Support building for arbitrary architectures
1070         https://bugs.webkit.org/show_bug.cgi?id=149539
1071
1072         Reviewed by Alexey Proskuryakov.
1073
1074         Teach buildbot to pass the architectures associated with the builder to build-webkit
1075         when building on OS X and iOS. As a side effect of this change we now support building
1076         universal binaries when multiples architectures are specified.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1079         (CompileWebKit.start):
1080
1081 2015-09-24  Daniel Bates  <dabates@apple.com>
1082
1083         Fix the build after <http://trac.webkit.org/changeset/190212>
1084         (http://trac.webkit.org/changeset/190212)
1085
1086         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1087
1088         * BuildSlaveSupport/built-product-archive:
1089         (main):
1090
1091 2015-09-24  Daniel Bates  <dabates@apple.com>
1092
1093         Support running unit tests on iOS Simulator test bot
1094         https://bugs.webkit.org/show_bug.cgi?id=149536
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         Implements support for running unit tests on a iOS test bot. At the time of writing,
1099         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1102         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1103         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1104
1105 2015-09-24  Daniel Bates  <dabates@apple.com>
1106
1107         Add support infrastructure for OpenSource iOS builders and testers
1108         https://bugs.webkit.org/show_bug.cgi?id=149534
1109
1110         Reviewed by Darin Adler.
1111
1112         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1113         scripts about iOS.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1116         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1117         --ios-simulator or --device for a builder/tester whose full platform name begins with
1118         "ios-simulator" or "ios", respectively.
1119         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1120         * BuildSlaveSupport/built-product-archive:
1121         (main): Pass the full platform name to determineWebKitBuildDirectory().
1122         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1123         command line flag when building for iOS.
1124         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1125         parameter fullPlatform. This parameter was originally added in r125066 to support the
1126         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1127         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1128         * BuildSlaveSupport/clean-build:
1129         (main): Call script webkit-build-directory with the appropriate command line flag when
1130         building for iOS.
1131         * BuildSlaveSupport/delete-stale-build-files:
1132         (main): Use the same logic for iOS as we do for Mac.
1133         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1134         flag when building for iOS.
1135         * BuildSlaveSupport/test-result-archive:
1136         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1137
1138 2015-09-24  Daniel Bates  <dabates@apple.com>
1139
1140         Remove Chromium-specific changes to script built-product-archive
1141         https://bugs.webkit.org/show_bug.cgi?id=149530
1142
1143         Rubber-stamped by Csaba Osztrogonác.
1144
1145         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1146         Chromium code has long since been removed from the OpenSource WebKit Project.
1147
1148         * BuildSlaveSupport/built-product-archive:
1149         (createZipManually):
1150         (createZip):
1151         (archiveBuiltProduct):
1152
1153 2015-09-24  Dan Bernstein  <mitz@apple.com>
1154
1155         Build fix.
1156
1157         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1158
1159 2015-09-24  Mark Lam  <mark.lam@apple.com>
1160
1161         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1162
1163         * Scripts/webkitpy/common/config/contributors.json:
1164
1165 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1166
1167         Unreviewed. Fix GObject DOM API breaks after r190120.
1168
1169         Bring back code removed in r169931 to handle documentation of
1170         deleted classes.
1171
1172         * gtk/webkitdom.py:
1173         (WebKitDOMDocGenerator):
1174         (WebKitDOMDocGenerator.write_deleted_classes):
1175         (WebKitDOMDocGenerator.generate):
1176         (write_deleted_classes):
1177         (WebKitDOMDocGeneratorSections._deleted_class):
1178         (WebKitDOMDocGeneratorSections._deleted_class.in):
1179         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1180         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1181
1182 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1183
1184         [Cocoa] [Font Features] Implement font-variant-*
1185         https://bugs.webkit.org/show_bug.cgi?id=148413
1186
1187         Reviewed by Darin Adler.
1188
1189         Update test font to use "lnum" feature.
1190
1191         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1192         (Generator::appendGSUBTable):
1193
1194 2015-09-22  Andy Estes  <aestes@apple.com>
1195
1196         ContentFiltering.AllowDownloadAfterAddData is very flaky
1197         https://bugs.webkit.org/show_bug.cgi?id=148885
1198         <rdar://problem/22729563>
1199
1200         Reviewed by Alexey Proskuryakov.
1201
1202         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1203         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1204         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1205
1206         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1207         (downloadTest):
1208
1209 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1210
1211         Mavericks: Media tests start to time out after a few days of bot uptime
1212         https://bugs.webkit.org/show_bug.cgi?id=149468
1213
1214         Reviewed by Chris Dumez.
1215
1216         * Scripts/webkitpy/port/base.py:
1217         * Scripts/webkitpy/port/driver.py:
1218         * Scripts/webkitpy/port/mac.py:
1219
1220 2015-09-22  Nan Wang  <n_wang@apple.com>
1221
1222         Unreviewed, add myself to the committers list.
1223
1224         * Scripts/webkitpy/common/config/contributors.json:
1225
1226 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1227
1228         Remove 'nullable' to fix older iOS builds.
1229
1230         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1231         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1232
1233 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1234
1235         [Win] Show tiled drawing debug overlay on Windows
1236         https://bugs.webkit.org/show_bug.cgi?id=149426
1237
1238         Reviewed by Dean Jackson.
1239
1240         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1241         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1242         * MiniBrowser/win/Common.cpp:
1243         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1244         flag if needed.
1245         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1246
1247 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1248
1249         [Win] Use command-line argument to launch in regular or High DPI mode.
1250         https://bugs.webkit.org/show_bug.cgi?id=149417
1251
1252         Reviewed by Dean Jackson.
1253
1254         * MiniBrowser/win/Common.cpp:
1255         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1256         very start of execution, before the MiniBrowser.dll is loaded.
1257         * win/DLLLauncher/DLLLauncherMain.cpp:
1258         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1259         present. On WinCairo, always use High DPI.
1260
1261 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1262
1263         32-bit Mac build fix attempt after r190065.
1264
1265         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1266
1267 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1268
1269         [OS X] Update for Xcode 7.0 on Yosemite
1270         https://bugs.webkit.org/show_bug.cgi?id=149389
1271
1272         Reviewed by Dan Bernstein.
1273
1274         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1275         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1276         Removed unneeded declarations - conforming to a protocol is sufficient.
1277
1278         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1279         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1280         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1281         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1282
1283 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1284
1285         Add the ability for tests to run script in the UI process in WebKitTestRunner
1286         https://bugs.webkit.org/show_bug.cgi?id=149356
1287
1288         Reviewed by Tim Horton.
1289
1290         This change adds testRunner.runUIScript(script, callback), which allows a test
1291         to execute script in a JSContext which runs in the UI process. That context
1292         has bindings exposed through the UIScriptController interface; currently one test
1293         function, and some iOS-specific functions are included. UIScriptController can be
1294         async with a callback, and runUIScript() itself is asynchronous. When the UI 
1295         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1296         is a string passed back to the web process, and given to the runUIScript()
1297         callback function.
1298         
1299         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1300
1301         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1303         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1304         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1305         complete, call back into TestRunner.
1306         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1307         (WTR::nextUIScriptCallbackID):
1308         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1309         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1311         * WebKitTestRunner/PlatformWebView.h:
1312         * WebKitTestRunner/TestController.cpp:
1313         (WTR::updateTestOptionsFromTestHeader):
1314         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1315         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1316         * WebKitTestRunner/TestInvocation.cpp:
1317         (WTR::TestInvocation::shouldUseFixedLayout):
1318         (WTR::TestInvocation::shouldUseThreadedScrolling):
1319         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1321         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1322         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1323         * WebKitTestRunner/TestInvocation.h:
1324         * WebKitTestRunner/TestOptions.h:
1325         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1326         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1327         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1328         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1329         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1330         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1331         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1332         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1333         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1334         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1336         (WTR::UIScriptController::doAsyncTask):
1337         (WTR::UIScriptController::zoomToScale):
1338         (WTR::UIScriptController::zoomScale):
1339         (WTR::UIScriptController::minimumZoomScale):
1340         (WTR::UIScriptController::maximumZoomScale):
1341         (WTR::UIScriptController::contentVisibleRect):
1342         * WebKitTestRunner/mac/EventSenderProxy.mm:
1343         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1344         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1345         * WebKitTestRunner/mac/TestControllerMac.mm:
1346         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1347         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1348         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1349         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1350         (UIScriptContext::UIScriptContext):
1351         (UIScriptContext::~UIScriptContext):
1352         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1353         asynchronous, call the callback.
1354         (UIScriptContext::nextTaskCallbackID):
1355         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1356         that has a callback). Has to store the callbackID of the script, so code called from the completion
1357         callback knows which UI script invoked it.
1358         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1359         (UIScriptContext::uiScriptComplete):
1360         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1361         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1362         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1363         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1364         (WTR::UIScriptController::UIScriptController):
1365         (WTR::UIScriptController::makeWindowObject):
1366         (WTR::UIScriptController::wrapperClass):
1367         (WTR::UIScriptController::doAsyncTask):
1368         (WTR::UIScriptController::zoomToScale):
1369         (WTR::UIScriptController::zoomScale):
1370         (WTR::UIScriptController::minimumZoomScale):
1371         (WTR::UIScriptController::maximumZoomScale):
1372         (WTR::UIScriptController::contentVisibleRect):
1373         (WTR::UIScriptController::uiScriptComplete):
1374         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1375         (WTR::UIScriptController::create):
1376         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1377
1378 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1379
1380         Turn on threaded scrolling by default in the tests
1381         https://bugs.webkit.org/show_bug.cgi?id=149377
1382
1383         Reviewed by Simon Fraser.
1384
1385         * WebKitTestRunner/mac/TestControllerMac.mm:
1386         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1387         (WTR::shouldUseThreadedScrolling): Deleted.
1388         Turn on threaded scrolling by default.
1389
1390 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1391
1392         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1393         https://bugs.webkit.org/show_bug.cgi?id=149252
1394
1395         Reviewed by Darin Adler.
1396
1397         In case of glib tests the test runner notifies about tests
1398         crashing, but for google tests we don't get any feedback, which
1399         means that in case of a test crashing we get a list of **PASS**
1400         messages and at the summary we are notified that the test suite
1401         has failed, but it's impossible to know which test cases have failed.
1402
1403         * Scripts/run-gtk-tests:
1404         (TestRunner._run_google_test): Add a **CRASH** message if test
1405         case crashed.
1406
1407 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1408
1409         WebKitTestRunner can leak user content script results between tests
1410         https://bugs.webkit.org/show_bug.cgi?id=149391
1411
1412         Reviewed by Sam Weinig.
1413
1414         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1415         about:blank, and thus about:blank doesn't have unintended side effects.
1416
1417         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1418         (WTR::InjectedBundle::beginTesting):
1419         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1420         (WTR::InjectedBundlePage::resetAfterTest):
1421
1422 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1423
1424         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1425         https://bugs.webkit.org/show_bug.cgi?id=149384
1426
1427         Reviewed by Chris Fleizach.
1428
1429         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1430         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1431         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1432         regardless of whether someone else holds a reference (we also call -stopListening in
1433         -dealloc).
1434
1435         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1436         (AccessibilityController::platformResetToConsistentState):
1437         (AccessibilityController::addNotificationListener):
1438         Ditto.
1439
1440 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1441
1442         Remove XHR_TIMEOUT compilation guard
1443         https://bugs.webkit.org/show_bug.cgi?id=149260
1444
1445         Reviewed by Benjamin Poulain.
1446
1447         * Scripts/webkitperl/FeatureList.pm:
1448
1449 2015-09-19  Dan Bernstein  <mitz@apple.com>
1450
1451         Attempted build fix.
1452
1453         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1454
1455 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1456
1457         Unreviewed, rolling out r189908.
1458         https://bugs.webkit.org/show_bug.cgi?id=149368
1459
1460         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1461
1462         Reverted changeset:
1463
1464         "printing does not use minimum page zoom factor"
1465         https://bugs.webkit.org/show_bug.cgi?id=108507
1466         http://trac.webkit.org/changeset/189908
1467
1468 2015-09-18  Andy Estes  <aestes@apple.com>
1469
1470         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1471         https://bugs.webkit.org/show_bug.cgi?id=149360
1472
1473         Reviewed by Tim Horton.
1474
1475         Added an API test.
1476
1477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1478         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1479         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1480         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1481         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1482         (TEST):
1483         * TestWebKitAPI/ios/pages.pages: Added.
1484
1485 2015-09-18  Nan Wang  <n_wang@apple.com>
1486
1487         AX: Implement ARIA 1.1 @aria-current on iOS
1488         https://bugs.webkit.org/show_bug.cgi?id=149297
1489
1490         Reviewed by Chris Fleizach.
1491
1492         Added support to test aria-current on iOS.
1493
1494         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1495         (AccessibilityUIElement::stringAttributeValue):
1496         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1497         (WTR::AccessibilityUIElement::stringAttributeValue):
1498
1499 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1500
1501         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1502         https://bugs.webkit.org/show_bug.cgi?id=149352
1503
1504         Reviewed by Simon Fraser.
1505
1506         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1507         m_context can be null. This may indicate a bug in webkitpy too, but
1508         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1509         wrong with opening and immediately closing it.
1510
1511 2015-09-18  Daniel Bates  <dabates@apple.com>
1512
1513         isGitSVNDirectory() returns true when Git is not installed
1514         https://bugs.webkit.org/show_bug.cgi?id=149351
1515
1516         Reviewed by Alexey Proskuryakov.
1517
1518         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1519         Git is not installed on the machine.
1520
1521         * Scripts/VCSUtils.pm:
1522         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1523         status code 0 (success).
1524
1525 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1526
1527         Prevent build-webkit from building four times on Windows 
1528         https://bugs.webkit.org/show_bug.cgi?id=149336
1529
1530         Reviewed by Brent Fulgham.
1531
1532         * Scripts/build-webkit:
1533         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1534         They're built all at once.
1535         * Scripts/webkitdirs.pm:
1536         (buildVisualStudioProject):
1537         (cmakeGeneratedBuildfile):
1538         Don't generate the Visual Studio solution if it already exists.
1539         It will run CMake again if necessary.
1540
1541 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1542
1543         [iOS WK2] WTR fails to set the key window in the UIKit sense
1544         https://bugs.webkit.org/show_bug.cgi?id=149325
1545
1546         Reviewed by Tim Horton.
1547
1548         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1549         This causes UIKit to bypass code that actually sets the key window, resulting in
1550         [UIAppliation sharedApplication].keyWindow always being nil.
1551
1552         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1553         -[WebKitTestRunnerWindow isKeyWindow] call super.
1554
1555         * WebKitTestRunner/PlatformWebView.h:
1556         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1557         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1558         (WTR::PlatformWebView::setWindowIsKey):
1559         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1560         (WTR::PlatformWebView::setWindowIsKey):
1561         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1562         (-[WebKitTestRunnerWindow isKeyWindow]):
1563         (WTR::PlatformWebView::PlatformWebView):
1564         (WTR::PlatformWebView::~PlatformWebView):
1565         (WTR::PlatformWebView::setWindowIsKey):
1566         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1567         (WTR::PlatformWebView::setWindowIsKey):
1568
1569 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1570
1571         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1572         https://bugs.webkit.org/show_bug.cgi?id=149321
1573
1574         Reviewed by Tim Horton.
1575         
1576         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1577         enabled the "testing" viewport configuration, which disables page scaling.
1578         
1579         If we're running viewport tests, we want the normal web page configuration.
1580         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1581         based on whether the test is in a "viewport" directory.
1582
1583         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1584         (WTR::InjectedBundle::beginTesting):
1585         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1586         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1587         * WebKitTestRunner/TestInvocation.cpp:
1588         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1589         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1590         (WTR::TestInvocation::shouldMakeViewportFlexible):
1591         (WTR::TestInvocation::invoke):
1592         * WebKitTestRunner/TestInvocation.h:
1593         * WebKitTestRunner/ios/TestControllerIOS.mm:
1594         (WTR::TestController::platformConfigureViewForTest):
1595         (WTR::shouldMakeViewportFlexible): Deleted.
1596
1597 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1598
1599         Give iOS WebKitTestRunner a launch storyboard
1600         https://bugs.webkit.org/show_bug.cgi?id=149314
1601
1602         Reviewed by Dan Bates.
1603         
1604         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1605         that it's been built for specific device configurations, and puts the window
1606         at the top of the screen. This simplifies coordinate conversions in a future patch.
1607
1608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1609         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1610         * WebKitTestRunner/ios/Launch.storyboard: Added.
1611
1612 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1613
1614         Update licence in r189890
1615         https://bugs.webkit.org/show_bug.cgi?id=149306
1616
1617         Reviewed by Dean Jackson.
1618
1619         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1620         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1621         * FontWithFeatures/FontWithFeatures/main.cpp:
1622
1623 2015-09-17  Mark Lam  <mark.lam@apple.com>
1624
1625         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1626         https://bugs.webkit.org/show_bug.cgi?id=149285
1627
1628         Reviewed by Saam Barati.
1629
1630         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1631
1632         * Scripts/run-javascriptcore-tests:
1633         (runJSCStressTests):
1634
1635 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1636
1637         Switch AppleWin build to use CMake
1638         https://bugs.webkit.org/show_bug.cgi?id=149163
1639
1640         Reviewed by Brent Fulgham.
1641
1642         * Scripts/build-webkit:
1643         * Scripts/run-api-tests:
1644         (runTest):
1645         (listAllTests):
1646         (prepareEnvironmentForRunningTestTool):
1647         (testToolPaths):
1648         (testToolPath): Deleted.
1649         Run the API tests as separate executables on Windows.
1650         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1651         * Scripts/webkitdirs.pm:
1652         (checkRequiredSystemConfig):
1653         (jhbuildWrapperPrefixIfNeeded):
1654         (generateBuildSystemFromCMakeProject):
1655         Fix configuration quirks.
1656
1657 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1658
1659         Added toggle options for hiding and showing certain platform families on the dashboard.
1660         https://bugs.webkit.org/show_bug.cgi?id=148403
1661
1662         Reviewed by David Kilzer.
1663
1664         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1665         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1666         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1667         in lieu of an "all" button in the toggle menu.
1668
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1670         (parsePlatformFamily): Helper function to parse out a platform family.
1671         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1672         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1673         (updateToggleButtons): Updates the status of the toggle buttons.
1674         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1675         (documentReady): Added creation of toggle buttons.
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1677         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1678         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1679         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1680         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1682         (QueueView): Updated to use hiddenPlatformFamilies.
1683         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1685         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1686         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1687         (Settings.prototype.toggleHiddenPlatform): Deleted.
1688         (Settings.prototype.clearHiddenPlatforms): Deleted.
1689         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1691         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1692         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1693         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1694         (table.queue-grid tr.headers th):
1695         (div.settingsWrapper.hide):
1696         (div.settingsWrapper):
1697         (div.familyToggleWrapper):
1698         (div.platformFamilyToggleButton):
1699         (div.platformFamilyShowToggleButton:not(:last-child)):
1700         (div.familyShown):
1701         (div.accessibilityButton):
1702         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1703         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1704         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1705         platformFamilyToggleButton and settingsWrapper class.
1706         (.accessibilityButton): Deleted.
1707
1708 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1709
1710         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1711         https://bugs.webkit.org/show_bug.cgi?id=148904
1712
1713         Reviewed by Myles Maxfield.
1714
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::parseBooleanTestHeaderValue):
1717         (WTR::updateViewOptionsFromTestHeader):
1718         Check for the key "useThreadedScrolling".
1719         Add some code to check for "true" and "false" for boolean options.
1720
1721         (WTR::TestController::viewOptionsForTest):
1722         Apply the test's overrides last, even after the platform's.
1723
1724 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         printing does not use minimum page zoom factor
1727         https://bugs.webkit.org/show_bug.cgi?id=108507
1728
1729         Reviewed by Darin Adler.
1730
1731         WebKitTestRunner always takes the snapshots from the UI process
1732         (expect for IOS), so in the case of printing, the layout in the
1733         web view is not the expected one. When printing, we need to take
1734         the snapshot in the web process and ensure it's rendered with a
1735         PrintContext.
1736
1737         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1738         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1739         kWKSnapshotOptionsPrinting option to
1740         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1741         printing, don't even create the snapshot, since it will be ignored
1742         by the UI process that always creates its own from the WebView (expect for IOS platform)
1743         * WebKitTestRunner/TestInvocation.cpp:
1744         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1745         received from the web process if any when comparing pixel
1746         results. Now we only receive a snapshot from the web process in
1747         case of printing, or when platform is IOS. Otherwhise, generate
1748         the snapshot from the WebView as usual.
1749         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1750         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1751         is created by the caller now, but the CG implementation needs to
1752         know if it's a Web or UI process snapshot.
1753         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1754         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1755         cairo surface for the given image.
1756         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1757         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1758         CGContext for the given image.
1759
1760 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1761
1762         Create a font which can be used for testing font features
1763         https://bugs.webkit.org/show_bug.cgi?id=149237
1764
1765         Reviewed by Simon Fraser.
1766
1767         This patch adds a new project in the Tools/ directory which generates a font which can
1768         be used for testing font features. This is a standalone project consisting of two files:
1769         1. A file which actually generates the byte vector representing the font. This file has
1770         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1771         specific, and only relies on the C++ STL.
1772         2. A file with a main() which calls generateFont() and writes out the font, as well as
1773         uses the font to render some demonstration text into a .png file. This file is platform
1774         specific.
1775
1776         The font itself only supports the following characters:
1777         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1778         However, the shape of these letters are either an X or a check mark.
1779
1780         The letter "A" always is a check mark.
1781         The letter "B" always is an X.
1782         Without any font features turned on, the rest of the letters are shown as X.
1783
1784         Each font feature has an letter associated with it. When the font feature is enabled,
1785         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1786         as a check mark.
1787
1788         Here are the mappings of font features to letters:
1789         liga: C
1790         clig: D
1791         dlig: E
1792         hlig: F
1793         calt: G
1794         subs: H
1795         sups: I
1796         smcp: J
1797         c2sc: K
1798         pcap: L
1799         c2pc: M
1800         unic: N
1801         titl: O
1802         onum: P
1803         pnum: Q
1804         tnum: R
1805         frac: S
1806         afrc: T
1807         ordn: U
1808         zero: V
1809         hist: W
1810         jp78: X
1811         jp83: Y
1812         jp90: Z
1813         jp04: a
1814         smpl: b
1815         trad: c
1816         fwid: d
1817         pwid: e
1818         ruby: f
1819
1820         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1821         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1822         (integralLog2):
1823         (roundDownToPowerOfTwo):
1824         (isFourByteAligned):
1825         (clampTo):
1826         (append32):
1827         (writeCFFEncodedNumber):
1828         (CFFBuilder::CFFBuilder):
1829         (CFFBuilder::takeResult):
1830         (CFFBuilder::moveTo):
1831         (CFFBuilder::lineTo):
1832         (CFFBuilder::curveToCubic):
1833         (CFFBuilder::closePath):
1834         (CFFBuilder::writePoint):
1835         (generateBoxCharString):
1836         (generateCheckCharString):
1837         (generateXCharString):
1838         (charStringForGlyph):
1839         (Generator::generate):
1840         (Generator::Placeholder::Placeholder):
1841         (Generator::Placeholder::populate):
1842         (Generator::Placeholder::~Placeholder):
1843         (Generator::placeholder):
1844         (Generator::append16):
1845         (Generator::append32):
1846         (Generator::append32BitCode):
1847         (Generator::overwrite16):
1848         (Generator::overwrite32):
1849         (Generator::appendCFFTable):
1850         (Generator::appendSubstitutionSubtable):
1851         (Generator::appendScriptSubtable):
1852         (Generator::appendGSUBTable):
1853         (Generator::appendOS2Table):
1854         (Generator::appendFormat12CMAPTable):
1855         (Generator::appendFormat4CMAPTable):
1856         (Generator::appendCMAPTable):
1857         (Generator::appendHEADTable):
1858         (Generator::appendHHEATable):
1859         (Generator::appendHMTXTable):
1860         (Generator::appendMAXPTable):
1861         (Generator::appendNAMETable):
1862         (Generator::appendPOSTTable):
1863         (Generator::calculateChecksum):
1864         (Generator::appendTable):
1865         (generateFont):
1866         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1867         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1868         (drawTextWithFeature):
1869         (main):
1870
1871 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r189875 and r189878.
1874         https://bugs.webkit.org/show_bug.cgi?id=149235
1875
1876         cygwin cmake build not ready yet (Requested by alexchristensen
1877         on #webkit).
1878
1879         Reverted changesets:
1880
1881         "Switch AppleWin build to use CMake"
1882         https://bugs.webkit.org/show_bug.cgi?id=149163
1883         http://trac.webkit.org/changeset/189875
1884
1885         "Cygwin build fix after r189875"
1886         http://trac.webkit.org/changeset/189878
1887
1888 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1889
1890         Cygwin build fix after r189875
1891
1892         * Scripts/build-webkit:
1893         * Scripts/webkitdirs.pm:
1894         (jhbuildWrapperPrefixIfNeeded):
1895         (generateBuildSystemFromCMakeProject):
1896         Make things work with cygwin and cmake.
1897
1898 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1899
1900         Switch AppleWin build to use CMake
1901         https://bugs.webkit.org/show_bug.cgi?id=149163
1902
1903         Reviewed by Brent Fulgham.
1904
1905         * Scripts/build-webkit:
1906         Build with CMake.
1907         * Scripts/run-api-tests:
1908         (runTest):
1909         (listAllTests):
1910         (prepareEnvironmentForRunningTestTool):
1911         (testToolPaths):
1912         (testToolPath): Deleted.
1913         Run the API tests as separate executables on Windows.
1914         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1915
1916 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1917
1918         Add newer build.webkit.org pages to robots.txt
1919         https://bugs.webkit.org/show_bug.cgi?id=149219
1920
1921         Reviewed by Darin Adler.
1922
1923         Indexing bot watcher's dashboard can't be good.
1924
1925         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1926
1927 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1928
1929         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1930
1931         * BuildSlaveSupport/built-product-archive:
1932         (unzipArchive):
1933
1934 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1935
1936         [EFL] Fix the help message of separated web process option of MiniBrowser
1937         https://bugs.webkit.org/show_bug.cgi?id=149212
1938
1939         Reviewed by Gyuyoung Kim.
1940
1941         * MiniBrowser/efl/main.c:
1942
1943 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1944
1945         Fix python syntax after r189851.
1946
1947         * BuildSlaveSupport/built-product-archive:
1948         (unzipArchive):
1949         For loops need a colon.
1950
1951 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1952
1953         Fix Windows test bots after changing to non-cygwin build
1954         https://bugs.webkit.org/show_bug.cgi?id=149196
1955
1956         Reviewed by Daniel Bates.
1957
1958         * BuildSlaveSupport/built-product-archive:
1959         (unzipArchive):
1960         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1961         prevent us from executing files from the archive on the test bots.
1962
1963 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1964
1965         Add ShadowRoot interface and Element.prototype.attachShadow
1966         https://bugs.webkit.org/show_bug.cgi?id=149187
1967
1968         Reviewed by Antti Koivisto.
1969
1970         * Scripts/webkitperl/FeatureList.pm:
1971
1972 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1973
1974         Appscale queue status json output lacks bots
1975         https://bugs.webkit.org/show_bug.cgi?id=149194
1976         <rdar://problem/22171089>
1977
1978         Reviewed by Alexey Proskuryakov.
1979
1980         * QueueStatusServer/handlers/queuestatusjson.py:
1981         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1982         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1983
1984 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1985
1986         [Win] Provide a means for viewing the layer tree
1987         https://bugs.webkit.org/show_bug.cgi?id=149165
1988
1989         Reviewed by Simon Fraser.
1990
1991         Update MiniBrowser with a new Debug menu option that will
1992         dump the current layer tree to the debug console.
1993         
1994         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1995         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1996         * MiniBrowser/win/Common.cpp:
1997         (WndProc): Add handler for 'Print Layer Tree' menu option.
1998         * MiniBrowser/win/MiniBrowser.cpp:
1999         (MiniBrowser::printLayerTree): Added Handler.
2000         * MiniBrowser/win/MiniBrowser.h:
2001
2002 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2003
2004         WebKitTestRunner declarative language setting is broken for iOS
2005         https://bugs.webkit.org/show_bug.cgi?id=149119
2006
2007         Unreviewed.
2008
2009         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2010         lost in the final version which got committed. This simply implements the existing
2011         OS X behavior on iOS.
2012
2013         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2014         (WTR::InjectedBundle::platformInitialize):
2015
2016 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2017
2018         Unreviewed, add myself to committers list.
2019
2020         * Scripts/webkitpy/common/config/contributors.json:
2021
2022 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2023
2024         [Cocoa] Allow testing with the system language
2025         https://bugs.webkit.org/show_bug.cgi?id=148671
2026
2027         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2028
2029         React to tests marked with language=lang1,lang2,etc in their header.
2030         Once this information is parsed, pass it to
2031         WKContextConfigurationSetOverrideLanguages().
2032
2033         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2034         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2035         list.
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::createWebViewWithOptions): Call
2038         WKContextConfigurationSetOverrideLanguages().
2039         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2040         * WebKitTestRunner/TestOptions.h:
2041         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2042         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2043         option to restart the web process.
2044         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2045         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2046
2047 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2048
2049         [WKTR] Allow changing the WKContextConfiguration between successive tests
2050         https://bugs.webkit.org/show_bug.cgi?id=148833
2051
2052         Reviewed by Tim Horton.
2053
2054         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2055         However, there are certain tests which require specifying options in this object. This patch makes
2056         our existing code for recreating the test runner web view also recreate the WKContext.
2057
2058         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2059         class.
2060
2061         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2062         * WebKitTestRunner/PlatformWebView.h:
2063         (WTR::PlatformWebView::options):
2064         * WebKitTestRunner/TestController.cpp:
2065         (WTR::TestController::initialize):
2066         (WTR::TestController::generateContextConfiguration):
2067         (WTR::TestController::generatePageConfiguration):
2068         (WTR::TestController::createWebViewWithOptions):
2069         (WTR::TestController::ensureViewSupportsOptionsForTest):
2070         (WTR::updateContextConfigurationOptionsFromTestHeader):
2071         (WTR::TestController::contextConfigurationOptionsForTest):
2072         (WTR::TestController::platformCreateWebView):
2073         (WTR::TestController::platformCreateOtherPage):
2074         (WTR::updateViewOptionsFromTestHeader): Deleted.
2075         (WTR::TestController::viewOptionsForTest): Deleted.
2076         * WebKitTestRunner/TestController.h:
2077         (WTR::TestController::injectedBundlePath):
2078         (WTR::TestController::testPluginDirectory):
2079         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2080         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2081         (WTR::TestController::platformCreateWebView):
2082         (WTR::TestController::platformCreateOtherPage):
2083         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2084         (WTR::PlatformWebView::PlatformWebView):
2085         (WTR::PlatformWebView::viewSupportsOptions):
2086         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2087         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2088         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2089         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2090         (WTR::PlatformWebView::PlatformWebView):
2091         (WTR::PlatformWebView::viewSupportsOptions):
2092         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2093         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2094         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2095         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2096         (WTR::PlatformWebView::PlatformWebView):
2097         (WTR::PlatformWebView::viewSupportsOptions):
2098         * WebKitTestRunner/ios/TestControllerIOS.mm:
2099         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2100         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2101         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2102         (WTR::PlatformWebView::PlatformWebView):
2103         (WTR::PlatformWebView::viewSupportsOptions):
2104         * WebKitTestRunner/mac/TestControllerMac.mm:
2105         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2106         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2107
2108 2015-09-11  Michael Saboff  <msaboff@apple.com>
2109
2110         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2111         https://bugs.webkit.org/show_bug.cgi?id=149083
2112
2113         Reviewed by Alexey Proskuryakov.
2114
2115         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2116
2117         * DumpRenderTree/mac/LayoutTestHelper.m:
2118         (colorProfileURLForDisplay):
2119
2120 2015-09-11  Saam barati  <sbarati@apple.com>
2121
2122         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2123         https://bugs.webkit.org/show_bug.cgi?id=149058
2124
2125         Reviewed by Geoffrey Garen.
2126
2127         * Scripts/run-jsc-stress-tests:
2128
2129 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2130
2131         Unreviewed, rolling out r189595.
2132         https://bugs.webkit.org/show_bug.cgi?id=149052
2133
2134         The tests still fail (Requested by ap on #webkit).
2135
2136         Reverted changeset:
2137
2138         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2139         error -1"
2140         https://bugs.webkit.org/show_bug.cgi?id=142929
2141         http://trac.webkit.org/changeset/189595
2142
2143 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2144
2145         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2146         https://bugs.webkit.org/show_bug.cgi?id=142929
2147
2148         Reviewed by Brent Fulgham.
2149
2150         Silence the logging. We'll track fixing the root cause in Radar.
2151
2152         * Scripts/webkitpy/port/mac.py:
2153         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2154
2155         * Scripts/webkitpy/port/win.py:
2156         (WinPort.logging_patterns_to_strip): Added.
2157
2158 2015-09-09  Andy Estes  <aestes@apple.com>
2159
2160         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2161         https://bugs.webkit.org/show_bug.cgi?id=149022
2162
2163         Reviewed by Daniel Bates.
2164
2165         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2166         did not account for this.
2167
2168         * Scripts/webkitpy/xcode/simulator.py:
2169         (Simulator): Optionally matched a revision at the end of a runtime version number.
2170         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2171
2172 2015-09-09  Andy Estes  <aestes@apple.com>
2173
2174         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2175         https://bugs.webkit.org/show_bug.cgi?id=149029
2176         <rdar://problem/22432624>
2177
2178         Reviewed by Daniel Bates.
2179
2180         * Scripts/webkitpy/xcode/simulator.py:
2181         (Simulator): Taught to parse tvOS runtimes.
2182         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2183
2184 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2185
2186         Fix bit rot on bot watcher's dashboard page
2187         https://bugs.webkit.org/show_bug.cgi?id=149012
2188
2189         Reviewed by Tim Horton.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2192         The code path used by the metrics page was trying to add properties to an undefined.
2193
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2195         Silence an expection that would occur when the step has no logs. This should never
2196         happen, but it did (perhaps buildbot was misconfigured for a while).
2197
2198 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2199
2200         Update LayoutTestRelay xcconfig file.
2201
2202         Rubber-stamped by Dan Bernstein.
2203
2204         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2205
2206 2015-09-09  Saam barati  <sbarati@apple.com>
2207
2208         DFG should have a debugging option that runs a phase that flushes all locals
2209         https://bugs.webkit.org/show_bug.cgi?id=148916
2210
2211         Reviewed by Filip Pizlo.
2212
2213         * Scripts/run-jsc-stress-tests:
2214
2215 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2216
2217         Unreviewed, rolling out r189530 and r189534.
2218         https://bugs.webkit.org/show_bug.cgi?id=148996
2219
2220         Caused assertion failures on Yosemite (Requested by litherum
2221         on #webkit).
2222
2223         Reverted changesets:
2224
2225         "[WKTR] Allow changing the WKContextConfiguration between
2226         successive tests"
2227         https://bugs.webkit.org/show_bug.cgi?id=148833
2228         http://trac.webkit.org/changeset/189530
2229
2230         "[Cocoa] Fix the tests after r189530"
2231         http://trac.webkit.org/changeset/189534
2232
2233 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2234
2235         [Cocoa] Fix the tests after r189530
2236
2237         Unreviewed.
2238
2239         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2240         (WTR::initializeWebViewConfiguration):
2241
2242 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2243
2244         [WKTR] Allow changing the WKContextConfiguration between successive tests
2245         https://bugs.webkit.org/show_bug.cgi?id=148833
2246
2247         Reviewed by Tim Horton.
2248
2249         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2250         However, there are certain tests which require specifying options in this object. This patch makes
2251         our existing code for recreating the test runner web view also recreate the WKContext.
2252
2253         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2254         class.
2255
2256         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2257         * WebKitTestRunner/PlatformWebView.h:
2258         (WTR::PlatformWebView::options):
2259         * WebKitTestRunner/TestController.cpp:
2260         (WTR::TestController::initialize):
2261         (WTR::TestController::generateContextConfiguration):
2262         (WTR::TestController::generatePageConfiguration):
2263         (WTR::TestController::createWebViewWithOptions):
2264         (WTR::TestController::ensureViewSupportsOptionsForTest):
2265         (WTR::updateContextConfigurationOptionsFromTestHeader):
2266         (WTR::TestController::contextConfigurationOptionsForTest):
2267         (WTR::TestController::platformCreateWebView):
2268         (WTR::TestController::platformCreateOtherPage):
2269         (WTR::updateViewOptionsFromTestHeader): Deleted.
2270         (WTR::TestController::viewOptionsForTest): Deleted.
2271         * WebKitTestRunner/TestController.h:
2272         (WTR::TestController::injectedBundlePath):
2273         (WTR::TestController::testPluginDirectory):
2274         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2276         (WTR::TestController::platformCreateWebView):
2277         (WTR::TestController::platformCreateOtherPage):
2278         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2279         (WTR::PlatformWebView::PlatformWebView):
2280         (WTR::PlatformWebView::viewSupportsOptions):
2281         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2282         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2283         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2284         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2285         (WTR::PlatformWebView::PlatformWebView):
2286         (WTR::PlatformWebView::viewSupportsOptions):
2287         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2288         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2289         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2290         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2291         (WTR::PlatformWebView::PlatformWebView):
2292         (WTR::PlatformWebView::viewSupportsOptions):
2293         * WebKitTestRunner/ios/TestControllerIOS.mm:
2294         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2295         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2296         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2297         (WTR::PlatformWebView::PlatformWebView):
2298         (WTR::PlatformWebView::viewSupportsOptions):
2299         * WebKitTestRunner/mac/TestControllerMac.mm:
2300         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2301         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2302
2303 2015-09-08  Daniel Bates  <dabates@apple.com>
2304
2305         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2306         https://bugs.webkit.org/show_bug.cgi?id=148980
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         Add setting to enable/disable accelerated drawing so as to support testing
2311         this feature in MiniBrowser on Mac.
2312
2313         * MiniBrowser/mac/SettingsController.h:
2314         * MiniBrowser/mac/SettingsController.m:
2315         (-[SettingsController _populateMenu]): Add menu item.
2316         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2317         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2318         (-[SettingsController acceleratedDrawingEnabled]): Added.
2319         * MiniBrowser/mac/WK1BrowserWindowController.m:
2320         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2321         * MiniBrowser/mac/WK2BrowserWindowController.m:
2322         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2323
2324 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2325
2326         Unreviewed. Added myself as a commiter in contributors.json.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2015-09-08  Keith Miller  <keith_miller@apple.com>
2331
2332         Unreviewed, added myself to the list of contributors.
2333
2334         * Scripts/webkitpy/common/config/contributors.json:
2335
2336 2015-09-08  Daniel Bates  <dabates@apple.com>
2337
2338         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2339         https://bugs.webkit.org/show_bug.cgi?id=148921
2340
2341         Reviewed by Alexey Proskuryakov.
2342
2343         The ring image is positioned above the platform icon in markup and we specify the CSS
2344         property z-index for the ring image so that it is painted on top of the platform icon
2345         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2346         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2347         property z-index to achieve a similar effect.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2350         (documentReady): Create the platform icon image element before the ring image such that
2351         the ring image is painted on top of the platform icon.
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2353         (table.queue-grid td.logo img.ring): Removed property z-index.
2354
2355 2015-09-08  Daniel Bates  <dabates@apple.com>
2356
2357         Dashboard: Remove duplicate gear icon data URLs
2358         https://bugs.webkit.org/show_bug.cgi?id=148920
2359
2360         Reviewed by Alexey Proskuryakov.
2361
2362         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2363         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2364         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2365         as a mask and make use of the CSS background-color to define the fill color for each of these three
2366         states.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2369         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2370         (.settings:hover): Override CSS background-color for hover state.
2371         (.settings-visible .settings): Override CSS background-color for expanded state.
2372
2373 2015-09-07  Andy Estes  <aestes@apple.com>
2374
2375         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2376         https://bugs.webkit.org/show_bug.cgi?id=148946
2377         <rdar://problem/22603981>
2378
2379         Reviewed by Dan Bernstein.
2380
2381         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2382         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2383
2384 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2385
2386         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2387         https://bugs.webkit.org/show_bug.cgi?id=148927
2388
2389         Reviewed by Csaba Osztrogonác.
2390
2391         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2392         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2393
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2396         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2397         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2398
2399 2015-09-07  Andy Estes  <aestes@apple.com>
2400
2401         Fix the Production build after r189455.
2402
2403         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2404         In-App Purchase template instead of the Aggregate template. Whoops.
2405
2406 2015-09-06  Andy Estes  <aestes@apple.com>
2407
2408         WebKit.xcworkspace should be be able to build iOS platforms
2409         https://bugs.webkit.org/show_bug.cgi?id=148881
2410
2411         Reviewed by Daniel Bates.
2412
2413         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2414         for all supported platforms.
2415
2416         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2417         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2418         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2419         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2420
2421 2015-09-06  Andy Estes  <aestes@apple.com>
2422
2423         WebKitTestRunner should build for iOS using the default target
2424         https://bugs.webkit.org/show_bug.cgi?id=148918
2425
2426         Reviewed by Daniel Bates.
2427
2428         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2429         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2430         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2431
2432         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2433         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2434         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2435         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2436         WebKitTestRunner is skipped when installing on iOS.
2437
2438         The target dependency graph now looks like this:
2439
2440             All
2441                 WebKitTestRunnerApp
2442                     WebKitTestRunner (Library)
2443                         WebKitTestRunnerInjectedBundle
2444                             Derived Sources
2445                 WebKitTestRunner
2446                     WebKitTestRunner (Library)
2447                         WebKitTestRunnerInjectedBundle
2448                             Derived Sources
2449
2450         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2451         * Scripts/build-webkittestrunner: Ditto.
2452         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2453         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2454         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2455         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2456         excluded iOS-only files, and skipped installing on iOS.
2457         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2458         excluded Mac-only files, and skipped installing on Mac.
2459         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2460         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2461         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2462         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2463         new configuration files.
2464
2465 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2466
2467         Web Inspector: Improve prepare-ChangeLog for multiple cases
2468         https://bugs.webkit.org/show_bug.cgi?id=148875
2469
2470         Reviewed by Timothy Hatcher.
2471
2472         * Scripts/prepare-ChangeLog:
2473         (get_function_line_ranges_for_javascript):
2474         - We were ignoring everything inside of an anonymous function expression,
2475           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2476           Better handle this by inserting a few tweaks.
2477         - Allow method syntax outside of classes as long as they are at the global level.
2478         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2479
2480         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2481         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2482         (Foo.prototype.method1):
2483         (Foo.prototype.method2):
2484         (Foo.prototype.method3.innerFunction):
2485         (Foo.prototype.method3):
2486         (insideGlobalAnonymousFunctionExpression):
2487         (foo.insideGlobalFunctionExpression):
2488         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2489         (IssueWithMapGetAndSet.prototype.method1):
2490         (IssueWithMapGetAndSet.prototype.method2):
2491         (IssueWithMapGetAndSet.prototype.method3):
2492         (IssueWithMapGetAndSet):
2493
2494 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2495
2496         [ES6] Enable ES6 Module in JSC shell by default
2497         https://bugs.webkit.org/show_bug.cgi?id=148689
2498
2499         Reviewed by Geoffrey Garen.
2500
2501         * Scripts/run-javascriptcore-tests:
2502         (runJSCStressTests):
2503         * Scripts/run-jsc-stress-tests:
2504
2505 2015-09-04  Basile Clement  <basile_clement@apple.com>
2506
2507         Unreviewed, change my email address.
2508
2509         * Scripts/webkitpy/common/config/contributors.json:
2510
2511 2015-09-04  Beth Dakin  <bdakin@apple.com>
2512
2513         Should have a test to make sure links don't navigate after a cancelled force 
2514         click
2515         https://bugs.webkit.org/show_bug.cgi?id=148846
2516
2517         Reviewed by Tim Horton.
2518
2519         New EventSender function for a started then cancelled force click.
2520         * WebKitTestRunner/EventSenderProxy.h:
2521         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2522         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2523         (WTR::EventSendingController::mouseForceClick):
2524         (WTR::EventSendingController::startAndCancelMouseForceClick):
2525         (WTR::EventSendingController::mouseForceDown):
2526         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2529         * WebKitTestRunner/mac/EventSenderProxy.mm:
2530         (WTR::EventSenderProxy::mouseForceClick):
2531         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2532         (WTR::EventSenderProxy::mouseForceDown):
2533         (WTR::EventSenderProxy::mouseMoveTo):
2534
2535 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2536
2537         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2538         https://bugs.webkit.org/show_bug.cgi?id=148830
2539
2540         Reviewed by Beth Dakin.
2541
2542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2543         (WTR::InjectedBundle::beginTesting):
2544         Make sure that TestRunner callbacks don't leak between tests!
2545
2546 2015-09-04  Anders Carlsson  <andersca@apple.com>
2547
2548         It should be possible to pass relative HTTP test paths to DumpRenderTree
2549         https://bugs.webkit.org/show_bug.cgi?id=148825
2550         <rdar://problem/22583866>
2551
2552         Reviewed by Tim Horton.
2553
2554         Convert the path to an absolute path if needed.
2555
2556         * DumpRenderTree/mac/DumpRenderTree.mm:
2557         (computeTestURL):
2558
2559 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2560
2561         Fix Swift unit tests for prepare-ChangeLog.
2562         https://bugs.webkit.org/show_bug.cgi?id=148817
2563
2564         Reviewed by Alexey Proskuryakov.
2565
2566         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2567         Swift unit tests for prepare-ChangeLog.
2568
2569 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2570
2571         Modifications to the webkit-nightly logic.
2572         
2573         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2574         (updateAlertPanel):
2575         * WebKitLauncher/main.m:
2576         (displayErrorAndQuit):
2577
2578 2015-09-04  Beth Dakin  <bdakin@apple.com>
2579
2580         Speculative build fix.
2581
2582         * WebKitTestRunner/mac/EventSenderProxy.mm:
2583
2584 2015-09-04  Brian Burg  <bburg@apple.com>
2585
2586         Web Inspector: InspectorController should support multiple frontend channels
2587         https://bugs.webkit.org/show_bug.cgi?id=148538
2588
2589         Reviewed by Joseph Pecoraro.
2590
2591         InspectorClients must explicitly disconnect their frontend channel(s) from the
2592         inspected page's InspectorController.
2593
2594         To make this possible, DumpRenderTree should not destroy non-primary views until
2595         it has tried to close any abandoned Web Inspector instances. Performing teardown
2596         in the reverse order prevents disconnection of the frontend channel because that
2597         prematurely destroys the inspector frontend client.
2598
2599         * DumpRenderTree/mac/DumpRenderTree.mm:
2600         (runTest):
2601         * DumpRenderTree/win/DumpRenderTree.cpp:
2602         (runTest):
2603
2604 2015-09-04  Beth Dakin  <bdakin@apple.com>
2605
2606         Need to be able to test default behaviors on force click
2607         https://bugs.webkit.org/show_bug.cgi?id=148758
2608
2609         Reviewed by Tim Horton.
2610
2611         This patch adds a new eventSender method to do a full, completed force click, 
2612         and it re-works all of the existing force methods to dispatch their events in 
2613         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2614         To do this, first we need to send the events to the app rather than straight 
2615         to the view, and also needed to tweak some state and send the events in a 
2616         delayed fashion.
2617
2618         New public function mouseForceClick() and private helper functions to make 
2619         NSEvents.
2620         * WebKitTestRunner/EventSenderProxy.h:
2621
2622         New public function mouseForceClick().
2623         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2624         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2625         (WTR::EventSendingController::mouseMoveTo):
2626         (WTR::EventSendingController::mouseForceClick):
2627         (WTR::EventSendingController::mouseForceDown):
2628         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2629         * WebKitTestRunner/TestController.cpp:
2630         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2631
2632         initPressureEventAtLocation needs to take a stageTransition and a window.
2633         * WebKitTestRunner/mac/EventSenderProxy.mm:
2634         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2635         (-[EventSenderSyntheticEvent stageTransition]):
2636         (-[EventSenderSyntheticEvent timestamp]):
2637         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2638         (-[EventSenderSyntheticEvent window]):
2639
2640         In order to enter the gesture recognizer, we need to start with a mouse down 
2641         that has a NSEventMaskPressure modifier.
2642         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2643
2644         This ensures that the events queue properly for the force monitor in AppKit.
2645         (WTR::spinRunLoopForForce):
2646
2647          We need to start the pressure change events with a began.
2648         (WTR::EventSenderProxy::beginPressureEvent):
2649
2650         These functions can be used to create the NSEvent for a pressure change every 
2651         time we need one.
2652         (WTR::EventSenderProxy::pressureChangeEvent):
2653
2654         Send the right series of events to emulate a full, completed force click.
2655         (WTR::EventSenderProxy::mouseForceClick):
2656
2657         Use all of the new things for these existing functions.
2658         (WTR::EventSenderProxy::mouseForceDown):
2659         (WTR::EventSenderProxy::mouseForceUp):
2660         (WTR::EventSenderProxy::mouseForceChanged):
2661
2662         Set NSFakeForceTouchDevice to YES.
2663         * WebKitTestRunner/mac/main.mm:
2664         (setDefaultsToConsistentValuesForTesting):
2665
2666 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2667
2668         prepare-ChangeLog needs to know how to parse Swift files.
2669         https://bugs.webkit.org/show_bug.cgi?id=148784
2670         <rdar://problem/22510062>
2671
2672         Reviewed by Darin Adler.
2673
2674         * Scripts/prepare-ChangeLog:
2675         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2676         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2677         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2678         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2679         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2680         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2681         (freeFunction): Ditto.
2682         (MyClass.function): Ditto.
2683         (MyClass.functionWithArgument(_:)): Ditto.
2684         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2685         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2686         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2687         (MyClass.classFunction): Ditto.
2688         (MyClass.readWriteComputedVariable): Ditto.
2689         (MyClass.readOnlyComputedVariable): Ditto.
2690
2691 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2692
2693         Import css/css-color-3
2694         https://bugs.webkit.org/show_bug.cgi?id=148803
2695
2696         Reviewed by Chris Dumez.
2697
2698         Fixed a bug that the imported reference files used the same extention as tests.
2699         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2700
2701         * Scripts/webkitpy/w3c/test_importer.py:
2702         (TestImporter.find_importable_tests):
2703
2704 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2705
2706         Unreviewed, rolling out r189338.
2707         https://bugs.webkit.org/show_bug.cgi?id=148785
2708
2709         Caused tons of crashes (Requested by cdumez on #webkit).
2710
2711         Reverted changeset:
2712
2713         "Web Inspector: InspectorController should support multiple
2714         frontend channels"
2715         https://bugs.webkit.org/show_bug.cgi?id=148538
2716         http://trac.webkit.org/changeset/189338
2717
2718 2015-09-03  Brian Burg  <bburg@apple.com>
2719
2720         Web Inspector: InspectorController should support multiple frontend channels
2721         https://bugs.webkit.org/show_bug.cgi?id=148538
2722
2723         Reviewed by Joseph Pecoraro.
2724
2725         InspectorClients must explicitly disconnect their frontend channel(s) from the
2726         inspected page's InspectorController.
2727
2728         To make this possible, DumpRenderTree should not destroy non-primary views until
2729         it has tried to close any abandoned Web Inspector instances. Performing teardown
2730         in the reverse order prevents disconnection of the frontend channel because that
2731         prematurely destroys the inspector frontend client.
2732
2733         * DumpRenderTree/mac/DumpRenderTree.mm:
2734         (runTest):
2735         * DumpRenderTree/win/DumpRenderTree.cpp:
2736         (runTest):
2737
2738 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2739
2740         Update WebKit nightly icon to be more like Safari
2741         https://bugs.webkit.org/show_bug.cgi?id=148768
2742
2743         Reviewed by Joseph Pecoraro.
2744
2745         * WebKitLauncher/webkit.icns:
2746
2747 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2748
2749         JavaScriptCore should have some ES6 conformance tests
2750         https://bugs.webkit.org/show_bug.cgi?id=148771
2751
2752         Reviewed by Chris Dumez.
2753
2754         * Scripts/run-javascriptcore-tests:
2755         (runJSCStressTests): Added es6 as a test suite.
2756
2757         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2758
2759         Some of these tests currently fail, so I also added a way to expect
2760         failure for now. We'll migrate failing tests to expected passes as we
2761         fix them.
2762
2763 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2764
2765         Add a test for swipe-start hysteresis
2766         https://bugs.webkit.org/show_bug.cgi?id=148756
2767
2768         Reviewed by Anders Carlsson.
2769
2770         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2772         (WTR::cacheTestRunnerCallback):
2773         (WTR::TestRunner::clearTestRunnerCallbacks):
2774         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2775         Make sure that we log if a client tries to install a callback twice
2776         (since we use .add, the second call would not work).
2777
2778         Also, add clearTestRunnerCallbacks so tests can swap out installed
2779         callbacks.
2780
2781 2015-09-03  Anders Carlsson  <andersca@apple.com>
2782
2783         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2784         https://bugs.webkit.org/show_bug.cgi?id=148746
2785         rdar://problem/22568073
2786
2787         Reviewed by Tim Horton.
2788
2789         * DumpRenderTree/mac/DumpRenderTree.mm:
2790         (computeTestURL):
2791         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2792
2793         (runTest):
2794         Call computeTestURL.
2795
2796         (testPathFromURL):
2797         Get rid of this; computeTestURL does this for us now.
2798
2799         * Scripts/webkitpy/port/driver.py:
2800         (Driver._command_from_driver_input):
2801         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2802
2803 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2804
2805         Swipe tests fail on Mavericks
2806         https://bugs.webkit.org/show_bug.cgi?id=148752
2807
2808         Reviewed by Beth Dakin.
2809
2810         * WebKitTestRunner/mac/EventSenderProxy.mm:
2811
2812 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2813
2814         Fix the 32-bit build
2815
2816         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2817         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2818
2819 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2820
2821         Remove some logging that wasn't meant to be in the tree
2822
2823         * WebKitTestRunner/mac/EventSenderProxy.mm:
2824         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2825
2826 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2827
2828         [Mac] Add support for testing swipes
2829         https://bugs.webkit.org/show_bug.cgi?id=148700
2830
2831         Reviewed by Beth Dakin.
2832
2833         * WebKitTestRunner/EventSenderProxy.h:
2834         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2835         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2836         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2837         (WTR::cgEventPhaseFromString):
2838         (WTR::cgEventMomentumPhaseFromString):
2839         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2840         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2841         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2842         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2843         (WTR::InjectedBundle::didReceiveMessageToPage):
2844         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2845         (WTR::TestRunner::installDidBeginSwipeCallback):
2846         (WTR::TestRunner::installWillEndSwipeCallback):
2847         (WTR::TestRunner::installDidEndSwipeCallback):
2848         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2849         (WTR::TestRunner::callDidBeginSwipeCallback):
2850         (WTR::TestRunner::callWillEndSwipeCallback):
2851         (WTR::TestRunner::callDidEndSwipeCallback):
2852         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2853         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2854         * WebKitTestRunner/TestController.cpp:
2855         (WTR::TestController::createOtherPage):
2856         (WTR::TestController::createWebViewWithOptions):
2857         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2858         (WTR::TestController::didBeginNavigationGesture):
2859         (WTR::TestController::willEndNavigationGesture):
2860         (WTR::TestController::didEndNavigationGesture):
2861         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2862         * WebKitTestRunner/TestController.h:
2863         * WebKitTestRunner/TestInvocation.cpp:
2864         (WTR::TestInvocation::didBeginSwipe):
2865         (WTR::TestInvocation::willEndSwipe):
2866         (WTR::TestInvocation::didEndSwipe):
2867         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2868         * WebKitTestRunner/TestInvocation.h:
2869         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2870         when the snapshot is removed.
2871
2872         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2873         mouseScrollBy function.
2874
2875         * WebKitTestRunner/mac/EventSenderProxy.mm:
2876         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2877         (-[EventSenderSyntheticEvent type]):
2878         (-[EventSenderSyntheticEvent subtype]):
2879         (-[EventSenderSyntheticEvent locationInWindow]):
2880         (-[EventSenderSyntheticEvent location]):
2881         (-[EventSenderSyntheticEvent momentumPhase]):
2882         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2883         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2884         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2885         more adjustable values.
2886
2887         (WTR::EventSenderProxy::mouseForceDown):
2888         (WTR::EventSenderProxy::mouseForceUp):
2889         (WTR::EventSenderProxy::mouseForceChanged):
2890         Adopt EventSenderSyntheticEvent.
2891
2892         (WTR::nsEventPhaseFromCGEventPhase):
2893         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2894         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2895
2896         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2897         (WTR::PlatformWebView::PlatformWebView):
2898         Enable swipe.
2899
2900 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2901
2902         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2903         https://bugs.webkit.org/show_bug.cgi?id=148723
2904
2905         Reviewed by Anders Carlsson.
2906
2907         * WebKitTestRunner/TestController.cpp:
2908         (WTR::testPath):
2909         (WTR::updateViewOptionsFromTestHeader):
2910         (WTR::TestController::viewOptionsForTest):
2911
2912 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2913
2914         Test commit.
2915
2916 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2917
2918         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2919         https://bugs.webkit.org/show_bug.cgi?id=148693
2920
2921         Reviewed by Anders Carlsson.
2922
2923         * WebKitTestRunner/TestController.cpp:
2924         (WTR::TestController::createOtherPage):
2925         (WTR::TestController::createWebViewWithOptions):
2926
2927 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2928
2929         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2930         https://bugs.webkit.org/show_bug.cgi?id=148529
2931
2932         Reviewed by Darin Adler.
2933
2934         When there are pending EventSender messages after a test finishes,
2935         they could be processed in the main loop started by the
2936         resetStateToConsistentValues(), but the old EventSender has been
2937         replaced by a new one at that point. The new Eventsender can crash
2938         when processing messages that were sent to the old one. To avoid
2939         this, we return early when receiving an EventSender message and
2940         the TestController state is not RunningTest.
2941
2942         * WebKitTestRunner/TestController.cpp:
2943         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2944         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2945
2946 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2949         https://bugs.webkit.org/show_bug.cgi?id=148528
2950
2951         Reviewed by Darin Adler.
2952
2953         Before r188548 resetStateToConsistentValues() was called in
2954         TestController::run(), before tests are run, but now it's called
2955         for every test in TestInvocation::invoke(), after m_status has
2956         changed to RunningTest.
2957
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::TestController::resetStateToConsistentValues): Use
2960         TemporaryChange to reset m_state ot its previous value after reset
2961         is done.
2962
2963 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2964
2965         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2966         that are marked as requiring corresponding tests.
2967         https://bugs.webkit.org/show_bug.cgi?id=148498
2968         <rdar://problem/21555314>
2969
2970         Reviewed by Dan Bernstein and David Kilzer.
2971
2972         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2973         simulate Git's attribute behevaior.
2974         (main): Added "requiresTests" array to contain files that require tests.
2975         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2976         section in ChangeLog.
2977         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2978         however, we check if the file or any containing folder has the given property set to "1" and
2979         return 1 if so; return 0 otherwise.
2980         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2981         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2982
2983 2015-08-26  Andy Estes  <aestes@apple.com>
2984
2985         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2986         https://bugs.webkit.org/show_bug.cgi?id=148506
2987
2988         Reviewed by Brady Eidson.
2989
2990         Added download API tests covering every decision and decision point.
2991         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2992
2993         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2994         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2995         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2996         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2997         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2998         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2999         decision and decision point as a bundle parameter.
3000         (+[MockContentFilterEnabler supportsSecureCoding]):
3001         (-[MockContentFilterEnabler copyWithZone:]):
3002         (-[MockContentFilterEnabler initWithCoder:]):
3003         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
3004         (-[MockContentFilterEnabler encodeWithCoder:]):
3005         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
3006         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
3007         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
3008         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
3009         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
3010         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3011         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3012         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3013         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3014         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3015         (+[MockContentFilterEnabler supportsSecureCoding]):
3016         (-[MockContentFilterEnabler copyWithZone:]):
3017         (-[MockContentFilterEnabler initWithCoder:]):
3018         (-[MockContentFilterEnabler dealloc]):
3019         (-[MockContentFilterEnabler encodeWithCoder:]):
3020         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3021         (-[ContentFilteringPlugIn dealloc]): Stop observing.
3022         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3023         (+[ServerRedirectPlugIn initialize]): Deleted.
3024         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3025         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3026         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3027         (TEST): Deleted.
3028
3029 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
3030
3031         Skip slow lock tests on Windows/debug
3032         https://bugs.webkit.org/show_bug.cgi?id=148643
3033
3034         Reviewed by Alexey Proskuryakov.
3035
3036         The lock tests simulate a critical section by doing some floating point math, and then either
3037         make those critical sections very long or invoke them many times. This appears to be
3038         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3039         that kind of computation slow.
3040
3041         These tests are almost as useful in release as they are in debug, so it's probably better to
3042         just skip the in debug on platforms where this causes timeouts.
3043
3044         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3045         (TestWebKitAPI::runLockTest):
3046         (TestWebKitAPI::skipSlow):
3047         (TestWebKitAPI::TEST):
3048
3049 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
3050
3051         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3052         https://bugs.webkit.org/show_bug.cgi?id=125720
3053
3054         Reviewed by Daniel Bates.
3055
3056         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3057
3058         * DumpRenderTree/AccessibilityUIElement.cpp:
3059         (pressCallback):
3060         (scrollToMakeVisibleWithSubFocusCallback):
3061         (scrollToGlobalPointCallback):
3062         (scrollToMakeVisibleCallback):
3063         (AccessibilityUIElement::getJSClass):
3064         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3065         (AccessibilityUIElement::scrollToMakeVisible):
3066         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3067         (AccessibilityUIElement::scrollToGlobalPoint):
3068         (AccessibilityUIElement::selectedTextRange):
3069         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3070         (AccessibilityUIElement::AccessibilityUIElement):
3071         (AccessibilityUIElement::mathPrescriptsDescription):
3072         (AccessibilityUIElement::scrollToMakeVisible):
3073         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3074         (AccessibilityUIElement::scrollToGlobalPoint):
3075         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3076         (WTR::AccessibilityUIElement::isTextMarkerValid):
3077         (WTR::AccessibilityUIElement::textMarkerForIndex):
3078         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3079         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3080         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3081         (WTR::AccessibilityUIElement::supportedActions):
3082         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3083         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3084         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3085         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3086         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3087         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3088         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3089         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3090         (WTR::AccessibilityUIElement::selectedTextRange):
3091         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3092         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3093         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3094         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3095         (WTR::AccessibilityUIElement::selectedTextRange):
3096
3097 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3098
3099         Add a mysteriously nonproblematic missing comma.
3100
3101         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3102         (TestExpectationParser._collect_matching_tests):
3103         (TestExpectationParser):
3104
3105 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3106
3107         Remove an old temporary script that has served its purpose
3108
3109         * Scripts/convert-test-expectations: Removed.
3110
3111 2015-08-28  Jer Noble  <jer.noble@apple.com>
3112
3113         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3114         https://bugs.webkit.org/show_bug.cgi?id=148579
3115
3116         Reviewed by Anders Carlsson.
3117
3118         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3119
3120         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3121         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3122
3123         * DumpRenderTree/mac/DumpRenderTree.mm:
3124         (resetWebPreferencesToConsistentValues):
3125         (resetWebViewToConsistentStateBeforeTesting): 
3126         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3127         (WTR::initializeWebViewConfiguration):
3128
3129 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3130
3131         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3132         https://bugs.webkit.org/show_bug.cgi?id=148592
3133
3134         Reviewed by Tim Horton.
3135
3136         * Scripts/webkitpy/port/base.py:
3137         (Port.to.setup_environ_for_server):
3138         (Port.to):
3139         (Port.to._append_value_colon_separated):
3140         (Port.to.show_results_html_file):
3141         * Scripts/webkitpy/port/ios.py:
3142         (IOSSimulatorPort.setup_environ_for_server):
3143         * Scripts/webkitpy/port/mac.py:
3144         (MacPort.setup_environ_for_server):
3145
3146 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3147
3148         LICM should be sound even if the CFG has changed
3149         https://bugs.webkit.org/show_bug.cgi?id=148259
3150
3151         Reviewed by Benjamin Poulain.
3152
3153         Add a utility for creating tests that set some uncommon option.
3154
3155         * Scripts/run-jsc-stress-tests:
3156
3157 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3158
3159         [Win] Unreviewed EWS correction.
3160
3161         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3162
3163 2015-08-28  Jer Noble  <jer.noble@apple.com>
3164
3165         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3166         https://bugs.webkit.org/show_bug.cgi?id=147512
3167
3168         Reviewed by Anders Carlsson.
3169
3170         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3171         to a consistent (true) value.
3172
3173         * DumpRenderTree/mac/DumpRenderTree.mm:
3174         (setDefaultsToConsistentValuesForTesting):
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::TestController::resetPreferencesToConsistentValues):
3177
3178 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3179
3180         Add navigation gesture callbacks to WKPageNavigationClient
3181         https://bugs.webkit.org/show_bug.cgi?id=148568
3182         <rdar://problem/22371346>
3183
3184         Reviewed by Anders Carlsson.
3185
3186         * WebKitTestRunner/TestController.cpp:
3187         (WTR::TestController::createOtherPage):
3188         (WTR::TestController::createWebViewWithOptions):
3189         Add some zeroes.
3190
3191 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3192
3193         [Mac] kill-old-processes should kill more processes
3194         https://bugs.webkit.org/show_bug.cgi?id=148577
3195
3196         Reviewed by Tim Horton.
3197
3198         * BuildSlaveSupport/kill-old-processes:
3199
3200 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3201
3202         The status message for combined builder queues should say "all builds succeeded" if everything
3203         built correctly.
3204         https://bugs.webkit.org/show_bug.cgi?id=148535
3205
3206         Reviewed by David Kilzer and Alexey Proskuryakov.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3209         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3210         say "all builds succeeded" if everything built correctly.
3211
3212 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3213
3214         [GTK] Simplify the internal API to create a WebView
3215         https://bugs.webkit.org/show_bug.cgi?id=148570
3216
3217         Reviewed by Žan Doberšek.
3218
3219         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3220         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3221         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3222         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3223         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3224         passing the received PageConfiguration.
3225         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3226         (WTR::PlatformWebView::PlatformWebView): Create the WebView
3227         passing the received PageConfiguration.
3228
3229 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
3230
3231         iOS Simulator API tests fails as Simulator is not running
3232         https://bugs.webkit.org/show_bug.cgi?id=148501
3233         rdar://problem/22447525
3234
3235         Reviewed by Daniel Bates.
3236
3237         This change is a workaround for <rdar://problem/22388812>.
3238
3239          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3240          and quit it on program termination when running tests on the iOS port.
3241          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3242          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3243
3244 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3245
3246         Make DLLLauncherMain executables dependent on dll
3247         https://bugs.webkit.org/show_bug.cgi?id=148548
3248
3249         Reviewed by Brent Fulgham.
3250
3251         * DumpRenderTree/CMakeLists.txt:
3252         * DumpRenderTree/PlatformWin.cmake:
3253         * MiniBrowser/win/CMakeLists.txt:
3254         * TestWebKitAPI/CMakeLists.txt:
3255         * TestWebKitAPI/PlatformWin.cmake:
3256
3257 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3258
3259         Remove Mac slaves 188/189 after being replaced with 400/401.
3260         
3261         Unreviewed.
3262         
3263         * BuildSlaveSupport/build.webkit.org-config/config.json:
3264
3265 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3266
3267         Add two bots to the Mac Yosemite queue.
3268         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3269         
3270         Unreviewed.
3271         
3272         * BuildSlaveSupport/build.webkit.org-config/config.json:
3273
3274 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3275
3276         [Win CMake] Fix incremental build after r188673
3277         https://bugs.webkit.org/show_bug.cgi?id=148539
3278
3279         Reviewed by Brent Fulgham.
3280
3281         * TestWebKitAPI/PlatformWin.cmake:
3282         Copy forwarding headers from WebCore before building in case that was not yet done.
3283         It used to be done when running CMake, but now it's a build step.
3284
3285 2015-08-27  Nan Wang  <n_wang@apple.com>
3286
3287         AX: Fix accessibility/select-element-at-index.html test
3288         https://bugs.webkit.org/show_bug.cgi?id=148516
3289
3290         Reviewed by Chris Fleizach.
3291
3292         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3293
3294         * DumpRenderTree/AccessibilityUIElement.cpp:
3295         (setSelectedChildCallback):
3296         (setSelectedChildAtIndexCallback):
3297         (removeSelectionAtIndexCallback):
3298         (elementAtPointCallback):
3299         (sentenceAtOffsetCallback):
3300         (stringForSelectionCallback):
3301         (AccessibilityUIElement::getJSClass):
3302         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3303         (AccessibilityUIElement::setSelectedChild):
3304         (AccessibilityUIElement::setSelectedChildAtIndex):
3305         (AccessibilityUIElement::removeSelectionAtIndex):
3306         (AccessibilityUIElement::accessibilityValue):
3307         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3308         (WTR::AccessibilityUIElement::wordAtOffset):
3309         (WTR::AccessibilityUIElement::lineAtOffset):
3310         (WTR::AccessibilityUIElement::sentenceAtOffset):
3311         (WTR::AccessibilityUIElement::isSelectable):
3312         (WTR::AccessibilityUIElement::isMultiSelectable):
3313         (WTR::AccessibilityUIElement::setSelectedChild):
3314         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3315         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3316         (WTR::AccessibilityUIElement::selectedChildrenCount):
3317         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3318         (WTR::AccessibilityUIElement::isExpanded):
3319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3320         (WTR::AccessibilityUIElement::setSelectedChild):
3321         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3322         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3323         (WTR::AccessibilityUIElement::accessibilityValue):
3324
3325 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3326
3327         Build fix after r188982
3328
3329         * MiniBrowser/win/CMakeLists.txt:
3330         The directory structure changed in the move.
3331
3332 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3335
3336         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3337
3338         * gtk/install-dependencies:
3339
3340 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3341
3342         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3343
3344         * Scripts/run-gtk-tests:
3345         (TestRunner):
3346
3347 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         Fix GTK+ WTR crashes in initializeMainRunLoop()
3350
3351         Rubber-stamped by Žan Doberšek.
3352
3353         Initialize threading and main thread before
3354         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3355         the RunLoop uses isMainThread() to decide whether to create a new
3356         GMainContext or use the default one. Also use RunLoop::run() and
3357         ::stop() instead of gtk_main/quit.
3358
3359         * WebKitTestRunner/TestController.cpp:
3360         (WTR::TestController::initialize):
3361         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3362         (WTR::TestController::notifyDone):
3363         (WTR::TestController::platformRunUntil):
3364
3365 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3366
3367         Unreviewed, further shorten a test that times out because it's very long
3368         running.
3369
3370         I've locally run these tests on repeat for 24 hours and found no genuine
3371         failures, like deadlocks. So, the timeouts are probably because the test
3372         machine is slow and debug is slow. We should just run this test for fewer
3373         iterations.
3374
3375         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3376         (TestWebKitAPI::TEST):
3377
3378 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3379
3380         Unreviewed build fix attempt on EFL
3381
3382         * WebKitTestRunner/PlatformEfl.cmake:
3383
3384 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3385
3386         Build fix after r188982
3387
3388         * MiniBrowser/win/CMakeLists.txt:
3389         Find .rc files in correct directory.
3390
3391 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3392
3393         [EFL] Bump cairo version to 1.14.2
3394         https://bugs.webkit.org/show_bug.cgi?id=148474
3395
3396         Reviewed by Csaba Osztrogonác.
3397
3398         * efl/jhbuild.modules:
3399
3400 2015-08-26  Andy Estes  <aestes@apple.com>
3401
3402         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3403         https://bugs.webkit.org/show_bug.cgi?id=147651
3404
3405         Rubber-stamped by Brady Eidson.
3406
3407         Taught TestRunner how to decide the navigation policy after a delay.
3408
3409         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3411         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3412         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3413         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3414         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3415         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3416         * WebKitTestRunner/TestController.cpp:
3417         (WTR::TestController::initialize):
3418         (WTR::TestController::resetStateToConsistentValues):
3419         (WTR::TestController::decidePolicyForNavigationAction):
3420         * WebKitTestRunner/TestController.h:
3421         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3422         * WebKitTestRunner/TestInvocation.cpp:
3423         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3424
3425 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3426
3427         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3428         https://bugs.webkit.org/show_bug.cgi?id=148485
3429
3430         Reviewed by Alex Christensen
3431
3432         Move the WinLauncher project and source files to a subdirectory
3433         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3434         source code and project files.
3435         
3436         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3437         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3438         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3439         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3440         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3441         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3442         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3443         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3444         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3445         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3446         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3447         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3448         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3449         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3450         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3451         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3452         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3453         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3454         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3455         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3456         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3457         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3458         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3459         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3460         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3461         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3462         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3463         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3464         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3465         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3466         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3467         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3468         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3469         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3470         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3471         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3472         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3473         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3474         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3475         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3476         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3477         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3478         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3479         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3480         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3481         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3482         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3483         * MiniBrowser/win: Copied from WinLauncher.
3484         * MiniBrowser/win/Common.cpp:
3485         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3486         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3487         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3488         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3489         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3490         * MiniBrowser/win/PageLoadTestClient.cpp:
3491         * MiniBrowser/win/PageLoadTestClient.h:
3492         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3493         * MiniBrowser/win/ResourceLoadDelegate.h:
3494         * MiniBrowser/win/WinLauncher.cpp: Removed.
3495         * MiniBrowser/win/WinLauncher.h: Removed.
3496         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3497         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3498         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3499         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3500         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3501         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3502         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3503         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3504         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3505         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3506         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3507         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3508         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3509         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3510         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3511         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3512         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3513         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3514         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3515         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3516         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3517         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3518         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3519         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3520         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3521         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3522         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3523         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3524         * MiniBrowser/win/WinMain.cpp:
3525         * WinLauncher: Removed.
3526         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3527         * WinLauncher/AccessibilityDelegate.h: Removed.
3528         * WinLauncher/CMakeLists.txt: Removed.
3529         * WinLauncher/Common.cpp: Removed.
3530         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3531         * WinLauncher/DOMDefaultImpl.h: Removed.
3532         * WinLauncher/PageLoadTestClient.cpp: Removed.
3533         * WinLauncher/PageLoadTestClient.h: Removed.
3534         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3535         * WinLauncher/PrintWebUIDelegate.h: Removed.
3536         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3537         * WinLauncher/ResourceLoadDelegate.h: Removed.
3538         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3539         * WinLauncher/WebDownloadDelegate.h: Removed.
3540         * WinLauncher/WinLauncher.cpp: Removed.
3541         * WinLauncher/WinLauncher.h: Removed.
3542         * WinLauncher/WinLauncher.vcxproj: Removed.
3543         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3544         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3545         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3546         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3547         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3548         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3549         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3550         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3551         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3552         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3553         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3554         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3555         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3556         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3557         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3558         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3559         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3560         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3561         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3562         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3563         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3564         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3565         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3566         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3567         * WinLauncher/WinLauncherReplace.h: Removed.
3568         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3569         * WinLauncher/WinLauncherWebHost.h: Removed.
3570         * WinLauncher/WinMain.cpp: Removed.
3571         * WinLauncher/resource.h: Removed.
3572         * WinLauncher/stdafx.cpp: Removed.
3573         * WinLauncher/stdafx.h: Removed.
3574         * win/AssembleBuildLogs/AssembleLogs.cmd:
3575
3576 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3577
3578         [Win] Simplify menu handling code in WinLauncher
3579         https://bugs.webkit.org/show_bug.cgi?id=148461
3580
3581         Reviewed by Zalan Bujtas.
3582
3583         Revise 'ToggleMenuItem' to return a boolean value indicating if
3584         it handled the message. Revise WndProc to use this to decide if it
3585         should pass the message on to the default handler, rather than
3586         duplicating the logic in both places.
3587         
3588         * WinLauncher/Common.cpp:
3589         (ToggleMenuItem): Return true if the menu item message was handled.
3590         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3591         the message tothe default handler.
3592
3593 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3594
3595         Remove unused code after r188948
3596         https://bugs.webkit.org/show_bug.cgi?id=148467
3597
3598         Reviewed by Gyuyoung Kim.
3599
3600         * WebKitTestRunner/TestController.cpp:
3601         (WTR::TestController::platformPreferences): Deleted.
3602
3603 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3604
3605         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3606         https://bugs.webkit.org/show_bug.cgi?id=148377
3607
3608         Reviewed by Carlos Garcia Campos.
3609
3610         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3611         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3612         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3613         EFL and GTK at the moment.
3614
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::platformWillRunTest):
3617         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3618         (WTR::TestController::platformPreferences):
3619         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3620         (WTR::TestController::platformPreferences):
3621
3622 2015-08-25  Nan Wang  <n_wang@apple.com>
3623
3624         AX: Enable accessibility/aria-controls.html test for mac
3625         https://bugs.webkit.org/show_bug.cgi?id=148458
3626
3627         Reviewed by Chris Fleizach.
3628
3629         Implemented ariaControlsElementAtIndex(unsigned index).
3630
3631         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3632         (AccessibilityUIElement::ariaControlsElementAtIndex):
3633         (AccessibilityUIElement::disclosedRowAtIndex):
3634         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3635         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3636
3637 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3638
3639         Remove python tests for PassRefPtr 
3640         https://bugs.webkit.org/show_bug.cgi?id=148463
3641
3642         Reviewed by Andy Estes.
3643
3644         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3645
3646         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3647         (PassPtrTest): Deleted.
3648         (PassPtrTest.assert_pass_ptr_check): Deleted.
3649         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3650         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3651         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3652         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3653         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3654         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3655
3656 2015-08-25  Andy Estes  <aestes@apple.com>
3657
3658         [iOS] run-webkit-tests fails if watchOS SDK is installed
3659         https://bugs.webkit.org/show_bug.cgi?id=148453
3660
3661         Reviewed by David Kilzer.
3662
3663         * Scripts/webkitpy/xcode/simulator.py:
3664         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3665         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3666
3667 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3668
3669         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3670         https://bugs.webkit.org/show_bug.cgi?id=148197
3671         rdar://problem/22334382
3672
3673         Reviewed by Daniel Bates.
3674
3675         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3676         * Scripts/webkitpy/port/ios.py:
3677         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3678         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3679         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3680         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3681         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3682
3683 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3684
3685         Remove PassRefPtr style check rule
3686         https://bugs.webkit.org/show_bug.cgi?id=148432
3687
3688         Reviewed by Andreas Kling.
3689
3690         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3691
3692         * Scripts/webkitpy/style/checkers/cpp.py:
3693         (_check_parameter_name_against_text): Deleted.
3694         (check_function_definition_and_pass_ptr): Deleted.
3695         (check_function_definition): Deleted.
3696         (check_pass_ptr_usage): Deleted.
3697         (process_line): Deleted.
3698         (CppChecker): Deleted.
3699
3700 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3701
3702         [Win] Expose "Inverted Colors" option in WinLauncher
3703         https://bugs.webkit.org/show_bug.cgi?id=148451
3704
3705         Reviewed by Tim Horton.
3706
3707         Add the ability to toggle the "Inverted Colors" preference
3708         in WinLauncher.
3709         
3710         * WinLauncher/Common.cpp:
3711         (ToggleMenuItem): Toggle the feature when the menu item
3712         is selected.
3713         (WndProc): Recognize the new menu option.
3714         * WinLauncher/WinLauncher.cpp:
3715         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3716         Colors" turned off.
3717         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3718         entry for "Invert Colors".
3719         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3720
3721 2015-08-25  Nan Wang  <n_wang@apple.com>
3722
3723         [Mac] accessibility/document-attributes.html fails
3724         https://bugs.webkit.org/show_bug.cgi?id=116636
3725
3726         Reviewed by Chris Fleizach.
3727
3728         Implemented documentURI() and documentEncoding().
3729
3730         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3731         (AccessibilityUIElement::documentEncoding):
3732         (AccessibilityUIElement::documentURI):
3733         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3734         (WTR::AccessibilityUIElement::documentEncoding):
3735         (WTR::AccessibilityUIElement::documentURI):
3736
3737 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3738
3739         [Win] Unreviewed test gardening.
3740
3741         Fix another case where the logging string is constructed using the variable 'frame',
3742         but the method argument is not given a name. This causes the global 'frame' value to
3743         be used, producing incorrect output.
3744
3745         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3746         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3747         argument.
3748
3749 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3750
3751         (Finally...) get rid of WKViewIOS
3752         https://bugs.webkit.org/show_bug.cgi?id=148404
3753
3754         Reviewed by Anders Carlsson.
3755
3756         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3757         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3758         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3759         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3760         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3761         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3762         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3763         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3764         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3765         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3766         Mark tests that use WKBrowsingContextController as Mac-only.
3767
3768         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3769         (WTR::AccessibilityController::addNotificationListener):
3770         * WebKitTestRunner/ios/mainIOS.mm:
3771         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3772         Import UIKit instead of depending on WKView.h to do so.
3773
3774 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3775
3776         Add support to dashboard for displaying Git SHA's as revisions.
3777         https://bugs.webkit.org/show_bug.cgi?id=148387
3778
3779         Reviewed by Daniel Bates.
3780
3781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3782         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3784         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3786         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3787
3788 2015-08-24  Andy Estes  <aestes@apple.com>
3789
3790         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3791
3792         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3793
3794 2015-08-23  Andy Estes  <aestes@apple.com>
3795
3796         Addressed a missed piece of review feedback from r188851.
3797
3798         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3799
3800 2015-08-23  Andy Estes  <aestes@apple.com>
3801
3802         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3803         https://bugs.webkit.org/show_bug.cgi?id=147872
3804         rdar://problem/22044000
3805
3806         Reviewed by Dan Bernstein.
3807         
3808         Added an API test.
3809
3810         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3812         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3813         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3814         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3815         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3816         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3817         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3818         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3819         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3820         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3821
3822 2015-08-23  Andy Estes  <aestes@apple.com>
3823
3824         Fixed the 32-bit Mac build after r188844.
3825
3826         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3827         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3828
3829 2015-08-22  Andy Estes  <aestes@apple.com>
3830
3831         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3832         https://bugs.webkit.org/show_bug.cgi?id=148317
3833
3834         Reviewed by Dan Bernstein.
3835
3836         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3837         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3838         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3839         when creating WKWebViews.
3840
3841         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3842         added a new API test for bundle parameters.
3843
3844         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3845         named its executable TestWebKitAPI.bundle.
3846         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3848         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3849         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3850         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3851         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3852         bundle parameter and asked for an initial notification.
3853         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3854         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3855         mirror its value in the main frame's JSContext.
3856         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3857         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3858         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3859         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3860         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3861         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3862         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3863         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3864         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3865         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3866
3867 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3868
3869         URTBF after r188828.
3870
3871         * WebKitTestRunner/PlatformWebView.h:
3872
3873 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3874
3875         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3876         https://bugs.webkit.org/show_bug.cgi?id=148356
3877
3878         Reviewed by Darin Adler.
3879
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3881         (BuildbotCombinedQueueView.prototype.update):
3882
3883 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3884
3885         build.webkit.org/dashboard: Respect step's hidden flag
3886         https://bugs.webkit.org/show_bug.cgi?id=148357
3887
3888         Reviewed by Darin Adler.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3891         (BuildbotIteration.prototype._parseData):
3892
3893 2015-08-23  Nan Wang  <n_wang@apple.com>
3894
3895         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3896         https://bugs.webkit.org/show_bug.cgi?id=148328
3897
3898         Reviewed by Darin Adler.
3899
3900         We should only expose stringValue() when value attribute is set.
3901
3902         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3903         (AccessibilityUIElement::stringValue):
3904         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3905         (WTR::AccessibilityUIElement::stringValue):
3906
3907 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3908
3909         Remove style checking rule regarding OwnPtr and PassOwnPtr
3910         https://bugs.webkit.org/show_bug.cgi?id=148360
3911
3912         Reviewed by Darin Adler.
3913
3914         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3915         Removed it.
3916
3917         * Scripts/do-webcore-rename:
3918         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3919         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3920         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3921         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3922         (WebKitStyleTest.test_names): Deleted.
3923
3924 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3925
3926         WebKitTestRunner should use WKWebView on OS X and iOS
3927         https://bugs.webkit.org/show_bug.cgi?id=143743
3928         <rdar://problem/16947123>
3929
3930         Reviewed by Anders Carlsson.
3931         Patch by Enrica Casucci and myself.
3932
3933         * WebKitTestRunner/PlatformWebView.h:
3934         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3935         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3936         instead of WKContext and WKPageGroup.
3937
3938         Remove the unused, always-true windowSnapshotEnabled().
3939         While technically some platforms don't have window snapshotting,
3940         they just return null instead of implementing windowSnapshotEnabled().
3941
3942         * WebKitTestRunner/TestController.h:
3943         * WebKitTestRunner/TestController.cpp:
3944         (WTR::TestController::createOtherPage):
3945         (WTR::TestController::initialize):
3946         (WTR::TestController::createWebViewWithOptions):
3947         Delegate to the various platforms for creating PlatformWebView instances,
3948         for creating WKContexts, and for accessing WKPreferences,
3949         so that they can do special things (like, use WKWebView instead!).
3950
3951         (WTR::TestController::resetPreferencesToConsistentValues):
3952         Make explicit WebKitTestRunner's desired default for two preferences
3953         which have differing defaults between the antique and modern API,
3954         for consistency's sake.
3955
3956         (WTR::TestController::resetStateToConsistentValues):
3957         Add platformResetStateToConsistentValues.
3958
3959         * WebKitTestRunner/TestInvocation.cpp:
3960         (WTR::TestInvocation::dumpResults):
3961         Adjust to the aforementioned removal of windowSnapshotEnabled().
3962
3963         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3964         (WTR::TestController::platformResetStateToConsistentValues):
3965         (WTR::TestController::platformPreferences):
3966         (WTR::TestController::platformCreateWebView):
3967         (WTR::TestController::platformCreateOtherPage):
3968         (WTR::TestController::platformInitializeConfiguration):
3969         Implement the new platform functions for the Modern WebKit2 API,
3970         in a new TestControllerCocoa file that is shared between iOS and Mac.
3971         
3972         For platformMaybeCreateContext, use the trick that we know we can cast
3973         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3974         WKWebView's configuration.
3975
3976         Ditto for WKPreferencesRef and WKPreferences.
3977
3978         Remove user content filters on the WKWebView's userContentController.
3979
3980         * WebKitTestRunner/mac/TestControllerMac.mm:
3981         * WebKitTestRunner/ios/TestControllerIOS.mm:
3982         Move code into TestControllerCocoa.
3983
3984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3985         (WTR::InjectedBundle::beginTesting):
3986         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3987         (WTR::TestRunner::addUserScript):
3988         (WTR::TestRunner::addUserStyleSheet):
3989         Adopt WKBundlePage API for user scripts/sheets.
3990
3991         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3992         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3993         Make and keep a WKWebView instead of a WKView.
3994         
3995         * WebKitTestRunner/mac/EventSenderProxy.mm:
3996         (WTR::EventSenderProxy::mouseUp):
3997         (WTR::EventSenderProxy::mouseMoveTo):
3998         Reach inside the WKWebView to the WKView when dispatching events.
3999         This is fairly ugly and we should come up with a better solution.
4000         Also, fix some flipping and style errors.
4001
4002 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
4003
4004         Unreviewed, attempt to fix GTK build after r188718
4005
4006         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4007         (WTR::PlatformWebView::PlatformWebView):
4008
4009 2015-08-21  Commit Queue  <commit-queue@webkit.org>
4010
4011         Unreviewed, rolling out r188807, r188813, and r188815.
4012         https://bugs.webkit.org/show_bug.cgi?id=148349
4013
4014         lots of 32-bit build problems, better to resolve separately
4015         and try again (Requested by thorton on #webkit).
4016
4017         Reverted changesets:
4018
4019         "WebKitTestRunner should use WKWebView on OS X and iOS"
4020         https://bugs.webkit.org/show_bug.cgi?id=143743
4021         http://trac.webkit.org/changeset/188807
4022
4023         "Stop building WebKitTestRunner for 32-bit platforms"
4024         https://bugs.webkit.org/show_bug.cgi?id=143743
4025         http://trac.webkit.org/changeset/188813
4026
4027         "Stop building WebKitTestRunner for 32-bit platforms"
4028         https://bugs.webkit.org/show_bug.cgi?id=143743
4029         http://trac.webkit.org/changeset/188815
4030
4031 2015-08-21  Tim Horton  <timothy_horton@apple.com>
4032
4033         Stop building WebKitTestRunner for 32-bit platforms
4034         https://bugs.webkit.org/show_bug.cgi?id=143743
4035         <rdar://problem/16947123>
4036
4037         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4038         This is a restriction on the valid set, not the desired set.
4039
4040 2015-08-21  Jason Marcell  <jmarcell@apple.com>
4041
4042         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
4043         to work with these new objects.
4044         https://bugs.webkit.org/show_bug.cgi?id=148188
4045
4046         Reviewed by Daniel Bates.
4047
4048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
4049         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
4050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4051         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
4052         (repository, "branch name")-pair.
4053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
4054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4055         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
4056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4057         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
4058         objects which represent a (repository, "branch name")-pair.
4059         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
4060         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
4061         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
4062         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
4063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
4064         BuildbotQueue.branch to BuildbotQueue.branches.
4065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4066         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
4067
4068 2015-08-21  Tim Horton  <timothy_horton@apple.com>
4069
4070         Stop building WebKitTestRunner for 32-bit platforms
4071         https://bugs.webkit.org/show_bug.cgi?id=143743
4072         <rdar://problem/16947123>
4073
4074         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4075         WKWebView is not available on 32-bit OS X.
4076
4077 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
4078
4079         [Win] Unreviewed test correction after r188709.
4080
4081         I removed a function argument that happened to be mirrored by a global
4082         value with the same name. This prevented a compile error, but testing
4083         showed that the wrong value was being used in the function.
4084
4085         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4086         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
4087         back
4088
4089 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
4090
4091         WebKitTestRunner should use WKWebView on OS X and iOS
4092         https://bugs.webkit.org/show_bug.cgi?id=143743
4093         <rdar://problem/16947123>
4094
4095         Reviewed by Anders Carlsson.
4096         Patch by Enrica Casucci and myself.
4097
4098         * WebKitTestRunner/PlatformWebView.h:
4099         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
4100         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
4101         instead of WKContext and WKPageGroup.
4102
4103         Remove the unused, always-true windowSnapshotEnabled().
4104         While technically some platforms don't have window snapshotting,
4105         they just return null instead of implementing windowSnapshotEnabled().
4106
4107         * WebKitTestRunner/TestController.h:
4108         * WebKitTestRunner/TestController.cpp:
4109         (WTR::TestController::createOtherPage):
4110         (WTR::TestController::initialize):
4111         (WTR::TestController::createWebViewWithOptions):
4112         Delegate to the various platforms for creating PlatformWebView instances,
4113         for creating WKContexts, and for accessing WKPreferences,
4114         so that they can do special things (like, use WKWebView instead!).
4115
4116         (WTR::TestController::resetPreferencesToConsistentValues):
4117         Make explicit WebKitTestRunner's desired default for two preferences
4118         which have differing defaults between the antique and modern API,
4119         for consistency's sake.
4120
4121         (WTR::TestController::resetStateToConsistentValues):
4122         Add platformResetStateToConsistentValues.
4123
4124         * WebKitTestRunner/TestInvocation.cpp:
4125         (WTR::TestInvocation::dumpResults):
4126         Adjust to the aforementioned removal of windowSnapshotEnabled().
4127
4128         * WebKitTestRunner/ios/TestControllerCocoa.mm:
4129         (WTR::TestController::platformResetStateToConsistentValues):
4130         (WTR::TestController::platformPreferences):
4131         (WTR::TestController::platformCreateWebView):
4132         (WTR::TestController::platformCreateOtherPage):
4133         (WTR::TestController::platformInitializeConfiguration):
4134         Implement the new platform functions for the Modern WebKit2 API,
4135         in a new TestControllerCocoa file that is shared between iOS and Mac.
4136         
4137         For platformMaybeCreateContext, use the trick that we know we can cast
4138         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
4139         WKWebView's configuration.
4140
4141         Ditto for WKPreferencesRef and WKPreferences.
4142
4143         Remove user content filters on the WKWebView's userContentController.
4144
4145         * WebKitTestRunner/mac/TestControllerMac.mm:
4146         * WebKitTestRunner/ios/TestControllerIOS.mm:
4147         Move code into TestControllerCocoa.
4148
4149         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4150         (WTR::InjectedBundle::beginTesting):
4151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4152         (WTR::TestRunner::addUserScript):
4153         (WTR::TestRunner::addUserStyleSheet):
4154         Adopt WKBundlePage API for user scripts/sheets.
4155
4156         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4157         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4158         Make and keep a WKWebView instead of a WKView.
4159         
4160         * WebKitTestRunner/mac/EventSenderProxy.mm:
4161         (WTR::EventSenderProxy::mouseUp):
4162         (WTR::EventSenderProxy::mouseMoveTo):
4163         Reach inside the WKWebView to the WKView when dispatching events.
4164         This is fairly ugly and we should come up with a better solution.
4165         Also, fix some flipping and style errors.
4166
4167 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
4168
4169         Improve how UI events are dispatched by WebKitTestRunner
4170         https://bugs.webkit.org/show_bug.cgi?id=148326
4171
4172         Reviewed by Anders Carlsson.
4173
4174         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4175         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4176         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
4177         asynchronous (and really, it has always been for the most part).
4178
4179         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4180         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.