[Qt][WK2] Refactor on Qt5 Layout tests' structure
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2
3         [Qt][WK2] Refactor on Qt5 Layout tests' structure
4         https://bugs.webkit.org/show_bug.cgi?id=77450
5
6         Reviewed by Csaba Osztrogonác.
7
8         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
9         to qt-5.0-wk2 and qt-5.0-wk1.
10
11         * Scripts/old-run-webkit-tests:
12         (buildPlatformResultHierarchy):
13         (readSkippedFiles):
14         * Scripts/webkitpy/layout_tests/port/qt.py:
15         (QtPort._wk2_port_name):
16         (QtPort._skipped_file_search_paths):
17         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
18         (QtPortTest.test_baseline_search_path):
19         * Scripts/webkitpy/layout_tests/port/webkit.py:
20         (WebKitPort._wk2_port_name):
21
22 2012-02-09  Philippe Normand  <pnormand@igalia.com>
23
24         [GTK] EWS command-line option to run the tests
25         https://bugs.webkit.org/show_bug.cgi?id=78211
26
27         Reviewed by Adam Barth.
28
29         New --run-tests option (defaults to False) for the EWS commands.
30
31         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
32         (AbstractEarlyWarningSystem):
33         (AbstractEarlyWarningSystem.__init__):
34         (AbstractEarlyWarningSystem.review_patch):
35         (ChromiumLinuxEWS):
36         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
37         (EarlyWarningSytemTest._test_builder_ews):
38
39 2012-02-09  Eric Seidel  <eric@webkit.org>
40
41         Rename compare_text and compare_audio to make it clear that they're !=
42         https://bugs.webkit.org/show_bug.cgi?id=78301
43
44         Reviewed by Adam Barth.
45
46         I also removed the maybe_create_directory function which was redundant.
47
48         * Scripts/webkitpy/layout_tests/controllers/manager.py:
49         (Manager.set_up_run):
50         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
51         (TestResultWriter._make_output_directory):
52         * Scripts/webkitpy/layout_tests/port/base.py:
53         (Port.do_text_results_differ):
54         (Port.do_audio_results_differ):
55         (Port.diff_text):
56         (Port.driver_name):
57         (Port.skips_perf_test):
58         * Scripts/webkitpy/layout_tests/port/win.py:
59         (WinPort.do_text_results_differ):
60         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
61         (WinPortTest.test_do_text_results_differ):
62         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
63         (LayoutTestApacheHttpd.__init__):
64         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
65         (HttpServerBase.__init__):
66         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
67         (Rebaseliner._diff_baselines):
68
69 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
70
71         [GTK] Add DRT support for modal dialogs
72         https://bugs.webkit.org/show_bug.cgi?id=53600
73
74         Reviewed by Martin Robinson.
75
76         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
77         Most significantly, when creating a new web view in GtkLauncher, the window
78         of the web view opener is passed around. In DumpRenderTree, the window of
79         the main web view is always considered as the opener. This is required so
80         the modal dialog's toplevel can be made transient for the opener's toplevel.
81
82         * DumpRenderTree/gtk/DumpRenderTree.cpp:
83         (webViewRunModalDialog):
84         (createWebView):
85         * GtkLauncher/main.c:
86         (createWebViewCb):
87         (runModalDialogCb):
88         (createBrowser):
89         (createWindow):
90         (main):
91
92 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
93
94         [Gtk] security/set-form-autocomplete-attribute.html fails
95         https://bugs.webkit.org/show_bug.cgi?id=78261
96
97         Reviewed by Martin Robinson.
98
99         Use the new helper in DumpRenderTreeSupportGtk to properly
100         test whether an element performs autocompletion.
101
102         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
103         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
104
105 2012-02-09  James Robinson  <jamesr@chromium.org>
106
107         [chromium] Enable mock scrollbars for compositing layout tests
108         https://bugs.webkit.org/show_bug.cgi?id=78299
109
110         Reviewed by Dirk Pranke.
111
112         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
113         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
114         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
115
116         * DumpRenderTree/chromium/TestShell.cpp:
117         (TestShell::runFileTest):
118         * DumpRenderTree/chromium/WebPreferences.cpp:
119         (WebPreferences::reset):
120         (WebPreferences::applyTo):
121         * DumpRenderTree/chromium/WebPreferences.h:
122         (WebPreferences):
123
124 2012-02-09  Eric Seidel  <eric@webkit.org>
125
126         Remove more uses of "os" from our webkitpy code
127         https://bugs.webkit.org/show_bug.cgi?id=78292
128
129         Reviewed by Adam Barth.
130
131         * Scripts/webkitpy/common/checkout/checkout_mock.py:
132         (MockCheckout.__init__):
133         (MockCheckout.is_path_to_changelog):
134         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
135         * Scripts/webkitpy/common/system/filesystem_mock.py:
136         (MockFileSystem._split):
137         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
138         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
139         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
140         * Scripts/webkitpy/layout_tests/port/webkit.py:
141         * Scripts/webkitpy/tool/bot/queueengine.py:
142         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
143         * Scripts/webkitpy/tool/commands/download.py:
144         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
145         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
146         * Scripts/webkitpy/tool/commands/sheriffbot.py:
147         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
148         * Scripts/webkitpy/tool/commands/upload.py:
149         (CreateBug.prompt_for_bug_title_and_comment):
150         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
151         * Scripts/webkitpy/tool/steps/attachtobug.py:
152         (AttachToBug.run):
153         * Scripts/webkitpy/tool/steps/checkstyle.py:
154         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
155         * Scripts/webkitpy/tool/steps/commit_unittest.py:
156         * Scripts/webkitpy/tool/steps/editchangelog.py:
157         * Scripts/webkitpy/tool/steps/preparechangelog.py:
158         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
159         (PrepareChangeLogTest.test_ensure_bug_url):
160         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
161         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
162         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
163         * Scripts/webkitpy/tool/steps/validatereviewer.py:
164
165 2012-02-09  Eric Seidel  <eric@webkit.org>
166
167         Remove the cr-mac-ews (it's long been dead)
168         https://bugs.webkit.org/show_bug.cgi?id=78267
169
170         Reviewed by Adam Barth.
171
172         * QueueStatusServer/model/queues.py:
173         (Queue):
174         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
175         (ChromiumWindowsEWS):
176         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
177         (EarlyWarningSytemTest._test_builder_ews):
178         (EarlyWarningSytemTest._test_testing_ews):
179
180 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
181
182         some tests in webkitpy are being run three times
183         https://bugs.webkit.org/show_bug.cgi?id=78283
184
185         Reviewed by Ryosuke Niwa.
186
187         It turns out that if you import a class derived from
188         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
189         the unittest framework treats it as if the class was defined in
190         the file (as well in the original file). This led us to running
191         the tests in ChangeLogTest three times.
192
193         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
194         (PrepareChangeLogTest):
195         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
196         (_assert_message_for_revert_output):
197
198 2012-02-09  Adam Barth  <abarth@webkit.org>
199
200         Remove extraneous line in previous patch.  I forgot to remove this
201         before landing.
202
203         * Scripts/webkitpy/layout_tests/port/driver.py:
204         (DriverProxy.start):
205
206 2012-02-09  Adam Barth  <abarth@webkit.org>
207
208         run-perf-tests should have an option to pause before running tests so we can attach Instruments
209         https://bugs.webkit.org/show_bug.cgi?id=78271
210
211         Reviewed by Ryosuke Niwa.
212
213         This lets me attach instruments to profile the performance of the test.
214
215         * Scripts/webkitpy/layout_tests/port/chromium.py:
216         (ChromiumDriver.start):
217         * Scripts/webkitpy/layout_tests/port/driver.py:
218         (Driver.start):
219         (DriverProxy.start):
220         * Scripts/webkitpy/layout_tests/port/server_process.py:
221         (ServerProcess.start):
222         * Scripts/webkitpy/layout_tests/port/test.py:
223         (TestDriver.start):
224         * Scripts/webkitpy/layout_tests/port/webkit.py:
225         (WebKitDriver.start):
226         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
227         (get_tests_run.RecordingTestDriver.start):
228         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
229         (PerfTestsRunner._parse_args):
230         (PerfTestsRunner._run_tests_set):
231         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
232         (start):
233         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
234         (test_run_test_set_kills_drt_per_run):
235         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
236         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
237
238 2012-02-09  Adam Barth  <abarth@webkit.org>
239
240         run-perf-tests --chromium should run the chromium port
241         https://bugs.webkit.org/show_bug.cgi?id=78266
242
243         Reviewed by Ryosuke Niwa.
244
245         This patch makes run-perf-tests work more like run-webkit-tests.
246
247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
248         (PerfTestsRunner._parse_args):
249
250 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
251
252         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
253         https://bugs.webkit.org/show_bug.cgi?id=77466
254
255         Reviewed by Dirk Pranke.
256
257         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
258         is set or if we should raise an error. A unit test was added.
259
260         * Scripts/webkitpy/layout_tests/port/qt.py:
261         (QtPort.operating_system):
262         (QtPort):
263         (QtPort.check_sys_deps):
264         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
265         (QtPortTest.test_operating_system):
266         (QtPortTest):
267         (QtPortTest.test_check_sys_deps):
268
269 2012-02-09  Eric Seidel  <eric@webkit.org>
270
271         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
272         https://bugs.webkit.org/show_bug.cgi?id=78263
273
274         Reviewed by Adam Barth.
275
276         * Scripts/webkitpy/common/config/ports.py:
277         (DeprecatedPort):
278         (DeprecatedPort.name):
279         (DeprecatedPort.flag):
280         (DeprecatedPort.script_path):
281         (DeprecatedPort.script_shell_command):
282         (DeprecatedPort.port):
283         (DeprecatedPort.makeArgs):
284         (DeprecatedPort.update_webkit_command):
285         (DeprecatedPort.check_webkit_style_command):
286         (DeprecatedPort.prepare_changelog_command):
287         (DeprecatedPort.build_webkit_command):
288         (DeprecatedPort.run_javascriptcore_tests_command):
289         (DeprecatedPort.run_webkit_unit_tests_command):
290         (DeprecatedPort.run_webkit_tests_command):
291         (DeprecatedPort.run_python_unittests_command):
292         (DeprecatedPort.run_perl_unittests_command):
293         (DeprecatedPort.layout_tests_results_path):
294         (MacPort):
295         (WinPort):
296         (GtkPort):
297         (GtkPort.build_webkit_command):
298         (GtkPort.run_webkit_tests_command):
299         (QtPort):
300         (QtPort.build_webkit_command):
301         (EflPort):
302         (EflPort.build_webkit_command):
303         (ChromiumPort):
304         (ChromiumPort.update_webkit_command):
305         (ChromiumPort.build_webkit_command):
306         (ChromiumPort.run_webkit_tests_command):
307         (ChromiumPort.run_javascriptcore_tests_command):
308         (ChromiumXVFBPort):
309         (ChromiumXVFBPort.run_webkit_tests_command):
310         * Scripts/webkitpy/common/config/ports_unittest.py:
311         (DeprecatedPortTest):
312         (DeprecatedPortTest.test_mac_port):
313         (DeprecatedPortTest.test_gtk_port):
314         (DeprecatedPortTest.test_qt_port):
315         (DeprecatedPortTest.test_chromium_port):
316         (DeprecatedPortTest.test_chromium_xvfb_port):
317         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
318         (AbstractEarlyWarningSystem.__init__):
319         * Scripts/webkitpy/tool/commands/sheriffbot.py:
320         * Scripts/webkitpy/tool/main.py:
321         (WebKitPatch):
322         (WebKitPatch.handle_global_options):
323         * Scripts/webkitpy/tool/steps/abstractstep.py:
324         * Scripts/webkitpy/tool/steps/steps_unittest.py:
325         (StepsTest.test_runtests_args):
326
327 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
328
329         [chromium] always initialize makeArgs in buildChromiumNinja
330         https://bugs.webkit.org/show_bug.cgi?id=78231
331
332         Reviewed by Tony Gentilcore.
333
334         * Scripts/webkitdirs.pm:
335         (buildChromiumNinja):
336
337 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
338
339         [GTK] Show url of current hovered link in MiniBrowser
340         https://bugs.webkit.org/show_bug.cgi?id=78098
341
342         Reviewed by Martin Robinson.
343
344         * MiniBrowser/gtk/BrowserWindow.c:
345         (webViewMouseTargetChanged): Check whether hit test result is a
346         link and use the url to update the status bar text.
347         (browserWindowConstructed): Connect to
348         WebKitWebView::mouse-target-changed signal.
349
350 2012-02-09  Rob Buis  <rbuis@rim.com>
351
352         [BlackBerry] Upstream DumpRenderTreeBlackBerry
353         https://bugs.webkit.org/show_bug.cgi?id=78042
354
355         Reviewed by Antonio Gomes.
356
357         Upstream final part of our DRT implementation.
358
359         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
360         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
361         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
362         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
363         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
364
365 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
366
367         kill-old-processes should kill gcc and clang
368         https://bugs.webkit.org/show_bug.cgi?id=78189
369
370         Reviewed by Eric Seidel.
371
372         Added a bunch of processes names of gcc and clang to the list.
373
374         * BuildSlaveSupport/kill-old-processes:
375
376 2012-02-07  MORITA Hajime  <morrita@google.com>
377
378         Replacement text should be available from the marker.
379         https://bugs.webkit.org/show_bug.cgi?id=77934
380
381         Made the mock requestCheckingOfText() implementation to return
382         a replacement text for each misspelled word if available.
383
384         Reviewed by Kent Tamura.
385
386         * DumpRenderTree/chromium/WebViewHost.cpp:
387         (WebViewHost::finishLastTextCheck):
388
389 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
390
391         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
392         https://bugs.webkit.org/show_bug.cgi?id=78146
393
394         Reviewed by Ryosuke Niwa.
395
396         Our DumpRenderTree should support --no-timeout and --timeout options in order
397         to be able to use run-perf-tests and have a Performance Bot.
398         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
399         and the necessary code to handle such command line arguments to our DumpRenderTree.
400
401         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
402         (WebCore::DumpRenderTree::setTimeout):
403         (WebCore):
404         (WebCore::DumpRenderTree::setShouldTimeout):
405         * DumpRenderTree/qt/DumpRenderTreeQt.h:
406         (DumpRenderTree):
407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
408         (LayoutTestController::LayoutTestController):
409         (LayoutTestController::waitUntilDone):
410         (LayoutTestController::notifyDone):
411         * DumpRenderTree/qt/LayoutTestControllerQt.h:
412         (LayoutTestController::setTimeout):
413         (LayoutTestController::setShouldTimeout):
414         (LayoutTestController):
415         * DumpRenderTree/qt/main.cpp:
416         (isOption):
417         (printUsage):
418         (main):
419
420 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
421
422         Rubber-stamped by Martin Robinson.
423
424         * gtk/common.py:
425         (get_build_path): Move test for current directory being a valid
426         directory up so it takes precedence over WebKitBuild/Release and
427         WebKitBuild/Debug when they exist as well.
428
429 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
430
431         [GTK] doc rebasing does not respect DESTDIR
432         https://bugs.webkit.org/show_bug.cgi?id=78177
433
434         Reviewed by Martin Robinson.
435
436         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
437         calling it for rebasing.
438         * gtk/generate-gtkdoc:
439         (get_common_options): Handle the new --virtual-root option.
440         * gtk/gtkdoc.py:
441         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
442         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
443
444 2012-02-08  Adam Barth  <abarth@webkit.org>
445
446         Remove Python 2.5 support from WebKit
447         https://bugs.webkit.org/show_bug.cgi?id=71593
448
449         Reviewed by Eric Seidel.
450
451         This is the last vestige of our Python 2.5 support.
452
453         * Scripts/webkitpy/tool/commands/queues_unittest.py:
454         (AbstractQueueTest.test_log_from_script_error_for_upload):
455
456 2012-02-08  Adam Barth  <abarth@webkit.org>
457
458         version_check.py should inform users that we don't support Python 2.5 anymore
459         https://bugs.webkit.org/show_bug.cgi?id=78179
460
461         Reviewed by Eric Seidel.
462
463         We don't support Python 2.5 anymore.
464
465         * Scripts/webkitpy/common/version_check.py:
466
467 2012-02-08  Adam Barth  <abarth@webkit.org>
468
469         test_configuration.py shouldn't re-implement itertools
470         https://bugs.webkit.org/show_bug.cgi?id=78178
471
472         Reviewed by Eric Seidel.
473
474         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
475         (TestConfigurationConverter.to_specifiers_list):
476         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
477         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
478         (TestConfigurationConverter):
479
480 2012-02-08  Adam Barth  <abarth@webkit.org>
481
482         webkitpy should reply upon the multiprocessing package existing
483         https://bugs.webkit.org/show_bug.cgi?id=78176
484
485         Reviewed by Eric Seidel.
486
487         Now that we don't support Python 2.5, this import can't fail.
488
489         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
490         (get):
491         (_Process):
492         (_Process.__init__):
493         (_Process.run):
494         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
495         (FunctionTests.test_get__processes):
496         (MultiProcessBrokerTests.setUp):
497         * Scripts/webkitpy/layout_tests/port/base.py:
498         (Port.__init__):
499         (Port.default_worker_model):
500         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
501         (ChromiumMacPort.check_build):
502         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
503         (PortTestCase.test_default_worker_model):
504         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
505
506 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
507
508         Unreviewed typo fix that makes docs build again for the gtk2-based
509         library.
510
511         * gtk/generate-gtkdoc:
512
513 2012-02-08  Adam Barth  <abarth@webkit.org>
514
515         Don't re-implement ZipFile.extractall
516         https://bugs.webkit.org/show_bug.cgi?id=78173
517
518         Reviewed by Eric Seidel.
519
520         We can use ZipFile.extractall now that we don't support Python 2.5.
521
522         * Scripts/webkitpy/common/system/autoinstall.py:
523         (AutoInstaller._extract_targz):
524         (AutoInstaller._unzip):
525
526 2012-02-08  Adam Barth  <abarth@webkit.org>
527
528         Remove the ospath compat shim from webkitpy
529         https://bugs.webkit.org/show_bug.cgi?id=78170
530
531         Reviewed by Eric Seidel.
532
533         We no longer need this compat shim now that we don't support Python 2.5.
534
535         * Scripts/webkitpy/common/checkout/scm/git.py:
536         * Scripts/webkitpy/common/checkout/scm/svn.py:
537         * Scripts/webkitpy/common/system/filesystem.py:
538         (FileSystem.relpath):
539         * Scripts/webkitpy/common/system/filesystem_mock.py:
540         (MockFileSystem.relpath):
541         * Scripts/webkitpy/common/system/ospath.py: Removed.
542         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
543
544 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
545
546         Build fix attempt after r107053.
547
548         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
549         (test_collect_tests):
550
551 2012-02-08  Adam Barth  <abarth@webkit.org>
552
553         Remove simplejson because it's no longer used by webkitpy
554         https://bugs.webkit.org/show_bug.cgi?id=78164
555
556         Reviewed by Eric Seidel.
557
558         All the importers of this code were removed in a previous patch.
559
560         * Scripts/webkitpy/thirdparty/simplejson: Removed.
561         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
562         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
563         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
564         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
565         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
566         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
567         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
568         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
569         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
570         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
571
572 2012-02-08  Adam Barth  <abarth@webkit.org>
573
574         webkitpy still imports simplejson
575         https://bugs.webkit.org/show_bug.cgi?id=78161
576
577         Reviewed by Eric Seidel.
578
579         We no longer support Python 2.5, so we can rely upon Python's built-in
580         JSON package.
581
582         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
583         * Scripts/webkitpy/common/net/resultsjsonparser.py:
584         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
585         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
586         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
587         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
588         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
589         * Scripts/webkitpy/style/checkers/jsonchecker.py:
590         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
591         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
592         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
593
594 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
595
596         [GTK] Fails to build docs with non-standard build directories
597         https://bugs.webkit.org/show_bug.cgi?id=78118
598
599         * gtk/common.py:
600         (get_build_path): add comment to document changes done in r107098,
601         as requested by the reviewer and forgotten by me.
602
603 2012-02-08  Adam Barth  <abarth@webkit.org>
604
605         Stop importing with_statement from the mysterious future
606         https://bugs.webkit.org/show_bug.cgi?id=78156
607
608         Reviewed by Eric Seidel.
609
610         The future is now!  (Well, at least 2008, when Python 2.6 was released,
611         is no longer the __future__.)
612
613         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
614         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
615         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
616         * Scripts/webkitpy/common/net/credentials_unittest.py:
617         * Scripts/webkitpy/common/net/file_uploader.py:
618         * Scripts/webkitpy/common/newstringio_unittest.py:
619         * Scripts/webkitpy/common/system/autoinstall.py:
620         * Scripts/webkitpy/common/system/crashlogs.py:
621         * Scripts/webkitpy/common/system/fileset.py:
622         * Scripts/webkitpy/common/system/filesystem.py:
623         * Scripts/webkitpy/common/system/filesystem_unittest.py:
624         * Scripts/webkitpy/common/system/path.py:
625         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
626         * Scripts/webkitpy/layout_tests/controllers/manager.py:
627         * Scripts/webkitpy/layout_tests/port/base.py:
628         (of):
629         * Scripts/webkitpy/layout_tests/port/gtk.py:
630         * Scripts/webkitpy/layout_tests/port/test.py:
631         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
632         * Scripts/webkitpy/style/filereader_unittest.py:
633         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
634         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
635         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
636         * Scripts/webkitpy/tool/commands/queues.py:
637         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
638         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
639
640 2012-02-08  Rob Buis  <rbuis@rim.com>
641
642         [BlackBerry] Upstream DumpRenderTreeBlackBerry
643         https://bugs.webkit.org/show_bug.cgi?id=78042
644
645         Reviewed by Antonio Gomes.
646
647         Upstream more parts of our DRT implementation.
648
649         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
650         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
651         * DumpRenderTree/blackberry/EventSender.cpp: Added.
652         * DumpRenderTree/blackberry/EventSender.h: Added.
653         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
654         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
655
656 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
657
658         check-webkit-style failing with "Path does not exist."
659         https://bugs.webkit.org/show_bug.cgi?id=77873
660
661         Reviewed by Ojan Vafai.
662
663         This change fixes the way the style checker determines which
664         Port class to use for a given test_expectations.txt path; the
665         previous version used a heuristic that didn't really work in the
666         first place.
667
668         * Scripts/webkitpy/style/checkers/test_expectations.py:
669         (TestExpectationsChecker._determine_port_from_expectations_path):
670         (TestExpectationsChecker.__init__):
671         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
672         (TestExpectationsTestCase._expect_port_for_expectations_path):
673         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
674
675 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
676
677         nrwt: make --skip-pixel-test-if-no-baseline option
678         https://bugs.webkit.org/show_bug.cgi?id=70484
679
680         Reviewed by Dirk Pranke.
681
682         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
683         (SingleTestRunner.__init__):
684         (SingleTestRunner._should_fetch_expected_checksum):
685         * Scripts/webkitpy/layout_tests/controllers/worker.py:
686         (Worker.handle_test_list):
687         * Scripts/webkitpy/layout_tests/models/test_input.py:
688         (TestInput.__init__):
689         * Scripts/webkitpy/layout_tests/port/webkit.py:
690         (WebKitDriver.cmd_line):
691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
692         (_set_up_derived_options):
693         (parse_args):
694         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
695         (MainTest.test_skip_pixel_test_if_no_baseline_option):
696         * WebKitTestRunner/TestController.cpp:
697         (WTR::TestController::TestController):
698         (WTR::TestController::initialize):
699         (WTR::TestController::runTest):
700         * WebKitTestRunner/TestController.h:
701         (TestController):
702         * WebKitTestRunner/TestInvocation.cpp:
703         (WTR::TestInvocation::TestInvocation):
704         (WTR::TestInvocation::setIsPixelTest):
705         * WebKitTestRunner/TestInvocation.h:
706         (WTR::TestInvocation::setSkipPixelTestOption):
707         (TestInvocation):
708
709 2012-02-08  Rob Buis  <rbuis@rim.com>
710
711         [BlackBerry] Upstream DumpRenderTreeBlackBerry
712         https://bugs.webkit.org/show_bug.cgi?id=78042
713
714         Reviewed by Antonio Gomes.
715
716         Add implementation for our DumpRenderTree solution.
717
718         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
719         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
720
721 2012-02-08  Antti Koivisto  <antti@apple.com>
722
723         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
724         https://bugs.webkit.org/show_bug.cgi?id=78080
725
726         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
727         
728         Add API test.
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
732         (TestWebKitAPI):
733         (TestWebKitAPI::TEST):
734
735 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
736
737         [GTK] Fails to build docs with non-standard build directories
738         https://bugs.webkit.org/show_bug.cgi?id=78118
739
740         Reviewed by Martin Robinson.
741
742         * gtk/common.py:
743         (get_build_path): also try the current directory as a valid build
744         dir, which makes non-standard build directories such as build-2.0
745         and build-3.0 work
746
747 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
748
749         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
750         https://bugs.webkit.org/show_bug.cgi?id=78099
751
752         Reviewed by Martin Robinson.
753
754         * MiniBrowser/gtk/BrowserWindow.c:
755         (webViewDecidePolicy): Check whether it's a link clicked with the
756         middle mouse button and load the request in a new window.
757         (browserWindowConstructed): Connect to
758         WebKitWebView::decide-policy signal.
759
760 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
761
762         Revert a part of the change in r106687 as a build fix.
763
764         Since Chromium port doesn't checkout the entire WebKit trunk,
765         we can't run "svn info" on webkit_base.
766
767         * Scripts/webkitpy/layout_tests/port/base.py:
768         (Port.repository_paths):
769
770 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
771
772         run-perf-tests doesn't recognize paths that start with PerformanceTests
773         https://bugs.webkit.org/show_bug.cgi?id=78012
774
775         Reviewed by Adam Barth.
776
777         Use resolve paths using filesystem.relpath before passing it to find_files.find.
778
779         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
780         (PerfTestsRunner):
781         (PerfTestsRunner._collect_tests):
782         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
783         (test_collect_tests):
784         (test_collect_tests.add_file):
785
786 2012-02-07  Justin Novosad  <junov@chromium.org>
787
788         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
789         https://bugs.webkit.org/show_bug.cgi?id=78039
790
791         Reviewed by Stephen White.
792
793         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
794
795         * DumpRenderTree/chromium/DumpRenderTree.cpp:
796         (main):
797         * DumpRenderTree/chromium/TestShell.cpp:
798         (TestShell::TestShell):
799         (TestShell::resetWebSettings):
800         (TestShell::runFileTest):
801         * DumpRenderTree/chromium/TestShell.h:
802         (TestShell::setDeferred2dCanvasEnabled):
803         (TestShell):
804         * DumpRenderTree/chromium/WebPreferences.cpp:
805         (WebPreferences::reset):
806         (WebPreferences::applyTo):
807         * DumpRenderTree/chromium/WebPreferences.h:
808         (WebPreferences):
809
810 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
811
812         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
813         https://bugs.webkit.org/show_bug.cgi?id=77928
814
815         Reviewed by Daniel Bates.
816
817         CMake has used *Programs* directory for executable. In addition, shared libraries are being
818         built in source directory. It is better to set common places in order to maintain executable
819         and libraries. *bin* is for executable and *lib* is for library.
820
821         * DumpRenderTree/efl/CMakeLists.txt:
822         * EWebLauncher/CMakeLists.txt:
823         * Scripts/run-launcher:
824         * Scripts/webkitdirs.pm:
825         (jscProductDir):
826         * Scripts/webkitpy/layout_tests/port/efl.py:
827         (EflPort._path_to_driver):
828         (EflPort._path_to_image_diff):
829
830 2012-02-07  Adam Klein  <adamk@chromium.org>
831
832         Add JSC support for delivering mutations when the outermost script context exits
833         https://bugs.webkit.org/show_bug.cgi?id=70289
834
835         Reviewed by Eric Seidel.
836
837         * DumpRenderTree/mac/EventSendingController.mm: Add support for
838         eventSender.scheduleAsynchronousKeyDown.
839         (+[EventSendingController isSelectorExcludedFromWebScript:]):
840         (+[EventSendingController webScriptNameForSelector:]):
841         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
842         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
843         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
844
845 2012-02-07  Chris Rogers  <crogers@google.com>
846
847         Add Chris Rogers to reviewers section
848         https://bugs.webkit.org/show_bug.cgi?id=78016
849
850         Reviewed by Adam Barth.
851
852         * Scripts/webkitpy/common/config/committers.py:
853
854 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
855
856         layoutTestController.display() is flaky for SVG tests
857         https://bugs.webkit.org/show_bug.cgi?id=78021
858
859         Reviewed by Dan Bernstein.
860
861         Fix race condition in repaint rect tracking. When running a test using the repaint.js
862         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
863         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
864         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
865         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
866         the repaint test already run, thus invalidating the previously tracked repaint rects.
867
868         * DumpRenderTree/mac/DumpRenderTree.mm:
869         (dump):
870         (runTest):
871
872 2012-02-07  Hans Wennborg  <hans@chromium.org>
873
874         Chromium: remove WebSpeechInputResult::set
875         https://bugs.webkit.org/show_bug.cgi?id=77977
876
877         Reviewed by Darin Fisher.
878
879         It was renamed to assign() in r106475.
880
881         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
882         (makeRectResult):
883
884 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
885
886         [Qt] Give emulated touch-point a radius
887         https://bugs.webkit.org/show_bug.cgi?id=77985
888         
889         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
890
891         Reviewed by Kenneth Rohde Christiansen.
892
893         * MiniBrowser/qt/BrowserWindow.cpp:
894         (BrowserWindow::updateVisualMockTouchPoints):
895         * MiniBrowser/qt/MiniBrowserApplication.cpp:
896         (MiniBrowserApplication::notify):
897         * MiniBrowser/qt/qml/MockTouchPoint.qml:
898
899 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
900
901         [GTK] Include gdk-pixbuf in the jhbuild modules
902         https://bugs.webkit.org/show_bug.cgi?id=77980
903
904         Reviewed by Gustavo Noronha Silva.
905
906         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
907
908 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
909
910         [Qt] Prevent early test termination with newer Qt 5
911         https://bugs.webkit.org/show_bug.cgi?id=77945
912
913         Reviewed by Csaba Osztrogonác.
914
915         QTBUG-24120 tracks a regression in Qt that would make layout tests
916         terminate early. This patch works around it in a Qt 4 + 5 safe manner
917         by disabling the quitOnLastWindowClosed feature, which we don't want/need
918         for DRT anyway.
919
920         * DumpRenderTree/qt/main.cpp:
921         (main): Don't quit on last window closed.
922
923 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
924
925         Fix some miscellaneous 'make dist' error for WebKitGTK+.
926
927         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
928         files should not be distributed.
929
930 2012-02-02  Hajime Morrita  <morrita@chromium.org>
931
932         [PerformanceTests] Each Dromaeo test needs its landing html.
933         https://bugs.webkit.org/show_bug.cgi?id=77504
934
935         Reviewed by Ryosuke Niwa.
936
937         Added an ignorable pattern which happens in some Dromaeo tests.
938
939         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
940         (PerfTestsRunner):
941
942 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
943
944         [GTK] Add missing pango include dir to fix build
945         https://bugs.webkit.org/show_bug.cgi?id=77832
946
947         Reviewed by Martin Robinson.
948
949         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
950
951 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
952
953         [GTK] Fix remaining errors in GTK+ WebKit2 API
954         https://bugs.webkit.org/show_bug.cgi?id=77890
955
956         Reviewed by Gustavo Noronha Silva.
957
958         Verify that WebKit2 GTK+ test files are not skipped during style checks.
959         Skip soup_server_new when checking for NULL versus 0 usage.
960
961         * Scripts/webkitpy/style/checker_unittest.py:
962         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
963         * Scripts/webkitpy/style/checkers/cpp.py:
964         (check_for_null):
965
966 2012-02-06  Eric Seidel  <eric@webkit.org>
967
968         webkit-patch apply-from-bug should be able to apply non-reviewed patches
969         https://bugs.webkit.org/show_bug.cgi?id=77883
970
971         Reviewed by Adam Barth.
972
973         This is very helpful if you use bugzilla as a replacement for git-stash.
974         Makes it simpler to re-apply the patch w/o having to look up the patch id.
975
976         * Scripts/webkitpy/tool/commands/download.py:
977         (ProcessBugsMixin._fetch_list_of_patches_to_process):
978         * Scripts/webkitpy/tool/commands/download_unittest.py:
979         (DownloadCommandsTest.test_apply_from_bug):
980
981 2012-02-06  Philippe Normand  <pnormand@igalia.com>
982
983         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
984         https://bugs.webkit.org/show_bug.cgi?id=77866
985
986         Reviewed by Martin Robinson.
987
988         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
989         errors in some gstreamer source code files defining new GStreamer elements.
990         * Scripts/webkitpy/style/checker_unittest.py:
991         (GlobalVariablesTest.test_path_rules_specifier):
992
993 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
994
995         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
996         https://bugs.webkit.org/show_bug.cgi?id=77869
997
998         Reviewed by Philippe Normand.
999
1000         * gtk/gtkdoc.py:
1001         (GTKDoc.rebase_installed_docs): Check html_dir exists.
1002
1003 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1004
1005         [Qt] Don't version QtWebKit.experimental.
1006         https://bugs.webkit.org/show_bug.cgi?id=77739
1007
1008         Reviewed by Tor Arne Vestbø.
1009
1010         * MiniBrowser/qt/qml/BrowserWindow.qml:
1011
1012 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1013
1014         [GTK] Fix several gtkdoc-fixxref warnings
1015         https://bugs.webkit.org/show_bug.cgi?id=77613
1016
1017         Reviewed by Martin Robinson.
1018
1019         * gtk/generate-gtkdoc:
1020         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
1021         of ignored files, since it's private.
1022         * gtk/gtkdoc.py:
1023         (GTKDoc._ignored_files_basenames): Helper function that returns a
1024         string with the list of ignored files basenames separated by a
1025         spaces, as expected by several gtkdoc commands.
1026         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
1027         --ignore-headers option.
1028         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
1029         --ignore-files option.
1030
1031 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1032
1033         [GTK] Fix xrefs after installing API documentation
1034         https://bugs.webkit.org/show_bug.cgi?id=77551
1035
1036         Reviewed by Martin Robinson.
1037
1038         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
1039         api docs.
1040         * gtk/common.py:
1041         (prefix_of_pkg_config_file): Get the prefix variable of the given
1042         pkg-config file.
1043         (gtk_version_of_pkg_config_file): Get the gtk version required by
1044         the given pkg-config file.
1045         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
1046         installed documentation.
1047         (get_gtkdoc_module_paths): Get paths where API doc is installed
1048         for the dependencies of the given pkg-config file.
1049         (get_common_xref_deps): Get API doc directories of dependencies
1050         common to WebKit1 and WebKit2.
1051         (get_webkit2_options): Add cross_reference_deps option.
1052         (get_webkit1_options): Ditto
1053         (rebase_installed_docs): Helper function to create a generator for
1054         the given pkg-config file and options and call rebase_installed_docs.
1055         * gtk/gtkdoc.py:
1056         (GTKDoc.__init__): Initialize cross_reference_deps.
1057         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
1058         dependencies.
1059         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
1060         links of installed documentation.
1061         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
1062         file.
1063
1064 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
1065
1066         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
1067         https://bugs.webkit.org/show_bug.cgi?id=77672
1068
1069         Reviewed by Dirk Pranke.
1070
1071         Test repetitions must be taken into account when working out
1072         the statistics shown by run-webkit-tests.
1073
1074         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1075         (Manager.prepare_lists_and_print_output):
1076         (Manager._print_result_summary):
1077         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1078         (ResultSummary.__init__):
1079         (ResultSummary.add):
1080         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1081         (MainTest.test_repeat_each_iterations_num_tests):
1082
1083 2012-02-05  Dan Bernstein  <mitz@apple.com>
1084
1085         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
1086         https://bugs.webkit.org/show_bug.cgi?id=77823
1087
1088         Reviewed by Anders Carlsson.
1089
1090         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1091         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
1092
1093 2012-02-04  Dan Bernstein  <mitz@apple.com>
1094
1095         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
1096         https://bugs.webkit.org/show_bug.cgi?id=77822
1097
1098         Reviewed by Sam Weinig.
1099
1100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1101         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
1102
1103 2012-02-04  Sam Weinig  <sam@webkit.org>
1104
1105         Add ability to send WKURLRequests in WebKit2 API user messages
1106         https://bugs.webkit.org/show_bug.cgi?id=77819
1107
1108         Reviewed by Anders Carlsson.
1109
1110         Add testing for round-tripping WKTypes from the UIProcess,
1111         to the WebProcess, and back.
1112
1113         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
1114           More can easily be added.
1115
1116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1117         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
1118         (TestWebKitAPI):
1119         (WebKit2UserMessageRoundTripTest):
1120         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
1121         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
1122         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
1123         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1124         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1125         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
1126         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
1127         (TestWebKitAPI::TEST_F):
1128         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
1129         (TestWebKitAPI):
1130         (UserMessageTest):
1131         (TestWebKitAPI::UserMessageTest::UserMessageTest):
1132         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
1133         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1134         (TestWebKitAPI::PlatformWebView::resizeTo):
1135         (TestWebKitAPI):
1136         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1137         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1138
1139 2012-02-04  Dan Bernstein  <mitz@apple.com>
1140
1141         <rdar://problem/10772406> WKPreferences instances cannot be copied
1142         https://bugs.webkit.org/show_bug.cgi?id=77816
1143
1144         Reviewed by Sam Weinig.
1145
1146         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1147         (TestWebKitAPI::TEST):
1148
1149 2012-02-04  Adam Barth  <abarth@webkit.org>
1150
1151         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
1152         https://bugs.webkit.org/show_bug.cgi?id=77802
1153
1154         Reviewed by Eric Seidel.
1155
1156         This patch refactors our directory grouping code into base.js where it
1157         can be shared between failures.js and notifications.js.  It then adds
1158         an Examine action to each group of failures that triggers the "results"
1159         view.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
1167
1168 2012-02-04  Ojan Vafai  <ojan@chromium.org>
1169
1170         check-webkit-style is throwing an exception
1171         https://bugs.webkit.org/show_bug.cgi?id=77744
1172
1173         Reviewed by David Levin.
1174
1175         If the test_list is None, then we don't need to check for unsupported
1176         feature tests to skip.
1177
1178         * Scripts/webkitpy/layout_tests/port/webkit.py:
1179         (WebKitPort._has_test_in_directories):
1180         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1181         (test_skipped_tests_for_unsupported_features_empty_test_list):
1182
1183 2012-02-03  Adam Barth  <abarth@webkit.org>
1184
1185         List of all failures in garden-o-matic should actually list all the failures
1186         https://bugs.webkit.org/show_bug.cgi?id=77796
1187
1188         Reviewed by Eric Seidel.
1189
1190         This patch wires a bit more data into the new "All Failures" tab.  I've
1191         also iterated on how we enable this experimental feature.  The tab is
1192         still just a dumb list, but we'll make it smarter.
1193
1194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1198
1199 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1200
1201         Windows build fix after r106692.
1202
1203         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1204         (PortTest.test_reference_files):
1205
1206 2012-02-03  Beth Dakin  <bdakin@apple.com>
1207
1208         https://bugs.webkit.org/show_bug.cgi?id=77782
1209         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
1210         once on some pages with frames
1211         -and corresponding-
1212         <rdar://problem/10798474>
1213
1214         Reviewed by Sam Weinig.
1215
1216         One new test.
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
1219         (TestWebKitAPI):
1220         (TestWebKitAPI::didForceRepaint):
1221         (TestWebKitAPI::didFinishLoadForFrame):
1222         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
1223         (TestWebKitAPI::setPageLoaderClient):
1224         (TestWebKitAPI::TEST):
1225         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
1226         (TestWebKitAPI):
1227         (NewFirstVisuallyNonEmptyLayoutFramesTest):
1228         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
1229         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
1230         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
1231
1232 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
1233
1234         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
1235         https://bugs.webkit.org/show_bug.cgi?id=77781
1236
1237         Reviewed by Eric Seidel.
1238
1239         This change fixes a couple of issues discovered while debugging
1240         test-webkitpy; both calling exit() instead of sys.exit() --
1241         which is discouraged in program code instead of the interpreter
1242         -- and a particular usage of outputcapture were stdin to get whacked
1243         and preventing debugging.
1244        
1245         This change introduces a couple of common _exit() methods that
1246         will standardize how webkit-patch exit's, in case we need to do
1247         something different in the future.
1248
1249         * Scripts/webkitpy/common/system/deprecated_logging.py:
1250         (error):
1251         * Scripts/webkitpy/common/system/outputcapture.py:
1252         (OutputCapture.assert_outputs):
1253         * Scripts/webkitpy/tool/bot/queueengine.py:
1254         (QueueEngine.exit_after_handled_error):
1255         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1256         (AbstractSequencedCommand.execute):
1257         * Scripts/webkitpy/tool/commands/queues.py:
1258         (StyleQueue.handle_script_error):
1259         * Scripts/webkitpy/tool/commands/upload.py:
1260         (MarkBugFixed.execute):
1261         * Scripts/webkitpy/tool/multicommandtool.py:
1262         (Command._exit):
1263         * Scripts/webkitpy/tool/steps/abstractstep.py:
1264         (AbstractStep._exit):
1265         * Scripts/webkitpy/tool/steps/checkstyle.py:
1266         (CheckStyle.run):
1267         * Scripts/webkitpy/tool/steps/commit.py:
1268         (Commit._check_test_expectations):
1269         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1270         (ConfirmDiff.run):
1271
1272 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1273
1274         Perf bot build fix.
1275
1276         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1277         (PerfTestsRunner._generate_json):
1278
1279 2012-02-03  Adam Barth  <abarth@webkit.org>
1280
1281         Add a blank "Expected Failures" tab to garden-o-matic
1282         https://bugs.webkit.org/show_bug.cgi?id=77793
1283
1284         Reviewed by Eric Seidel.
1285
1286         This tab will help us explore and manage our expected failures.  The
1287         tab is hidden by default via a new "experimental features" flag.
1288
1289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1294         (#unexpected):
1295         (#onebar.partytime #unexpected):
1296
1297 2012-02-03  Lucas Forschler  <lforschler@apple.com>
1298
1299         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
1300         https://bugs.webkit.org/show_bug.cgi?id=77785
1301
1302         Fix the build bots.
1303         
1304         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
1305
1306         * Scripts/update-webkit-support-libs:
1307         (downloadExpectedVersionNumber):
1308
1309 2012-02-03  Lucas Forschler  <lforschler@apple.com>
1310
1311         Add a Mac Lion Performance bot.
1312         https://bugs.webkit.org/show_bug.cgi?id=77765
1313
1314         Reviewed by Adam Roben.
1315
1316         This will update the master configuration in the following ways:
1317             Add a new performance slave (apple-xseve-11)
1318             Add a new Factory to download a build and run perf tests.
1319             
1320         * BuildSlaveSupport/build.webkit.org-config/config.json:
1321         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1322         (DownloadAndPerfTestFactory):
1323         (DownloadAndPerfTestFactory.__init__):
1324
1325 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
1326
1327         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
1328         https://bugs.webkit.org/show_bug.cgi?id=77752
1329
1330         Reviewed by James Robinson.
1331
1332         Delete unneeded file accidentally checked in in r106481.
1333
1334         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
1335
1336 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1337
1338         Ref Tests should support plain SVG files
1339         https://bugs.webkit.org/show_bug.cgi?id=77685
1340
1341         Reviewed by Tony Chang.
1342
1343         Don't assume reference files always use .html as the extension.
1344         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
1345
1346         Also fix various bugs in MockFileSystem and TestPort.
1347
1348         * Scripts/webkitpy/common/system/filesystem_mock.py:
1349         (MockFileSystem.isdir):
1350         * Scripts/webkitpy/layout_tests/port/base.py:
1351         (Port.reference_files):
1352         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1353         (PortTest.test_is_test_file):
1354         (PortTest.test_reference_files):
1355         * Scripts/webkitpy/layout_tests/port/test.py:
1356         (TestInstance.__init__):
1357
1358 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         perf-o-matic should store chromium svn revision
1361         https://bugs.webkit.org/show_bug.cgi?id=77725
1362
1363         Reviewed by Dirk Pranke.
1364
1365         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
1366         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
1367         is implemented in terms of newly added svn_revision.
1368
1369         * Scripts/webkitpy/common/checkout/scm/git.py:
1370         (Git.svn_revision):
1371         * Scripts/webkitpy/common/checkout/scm/scm.py:
1372         (SCM.head_svn_revision):
1373         (SCM):
1374         (SCM.svn_revision):
1375         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1376         (MockSCM.svn_revision):
1377         * Scripts/webkitpy/common/checkout/scm/svn.py:
1378         (SVN.svn_revision):
1379         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1380         (JSONLayoutResultsGenerator.__init__):
1381         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1382         (JSONResultsGeneratorBase._insert_generic_metadata):
1383         * Scripts/webkitpy/layout_tests/port/base.py:
1384         (Port.repository_paths):
1385         * Scripts/webkitpy/layout_tests/port/chromium.py:
1386         (ChromiumPort.repository_paths):
1387         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1388         (PerfTestsRunner._generate_json):
1389         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1390         (test_run_test_set_with_json_output):
1391         (test_run_test_set_with_json_source):
1392         (test_run_test_set_with_multiple_repositories):
1393
1394 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1395
1396         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
1397         https://bugs.webkit.org/show_bug.cgi?id=77632
1398
1399         Reviewed by Kenneth Rohde Christiansen.
1400
1401         * MiniBrowser/qt/BrowserWindow.cpp:
1402         (BrowserWindow::BrowserWindow):
1403         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1404         (MiniBrowserApplication::sendTouchEvent):
1405         (MiniBrowserApplication::handleUserOptions):
1406         * MiniBrowser/qt/MiniBrowserApplication.h:
1407         (WindowOptions):
1408         (WindowOptions::WindowOptions):
1409         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1410         (WTR::PlatformWebView::PlatformWebView):
1411         * WebKitTestRunner/qt/main.cpp:
1412         (main):
1413         * qmake/mkspecs/features/default_post.prf:
1414
1415 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
1416
1417         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
1418         https://bugs.webkit.org/show_bug.cgi?id=77723
1419
1420         Reviewed by Tor Arne Vestbø.
1421
1422         * Tools.pro: Compile WTR again on all platforms with WK2.
1423
1424 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
1425
1426         Ensure that inspector disabled build works
1427         https://bugs.webkit.org/show_bug.cgi?id=77604
1428
1429         Reviewed by Tor Arne Vestbø.
1430
1431         * qmake/mkspecs/features/features.prf:
1432
1433 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
1434
1435         [chromium] add support for --makeargs to the ninja-based build
1436         https://bugs.webkit.org/show_bug.cgi?id=77688
1437
1438         Reviewed by Adam Barth.
1439
1440         * Scripts/webkitdirs.pm:
1441         (buildChromiumNinja):
1442
1443 2012-02-02  Eric Seidel  <eric@webkit.org>
1444
1445         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
1446         https://bugs.webkit.org/show_bug.cgi?id=75145
1447
1448         Reviewed by Dirk Pranke.
1449
1450         * Scripts/webkitpy/layout_tests/port/mac.py:
1451         (MacPort.default_child_processes):
1452         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1453         (test_operating_system):
1454         (test_default_child_processes):
1455
1456 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
1457
1458        nrwt shouldn't blow up when there are errors in test_expectations.txt
1459        https://bugs.webkit.org/show_bug.cgi?id=73603
1460
1461        Reviewed by Ojan Vafai.
1462
1463        This change removes the distinction between 'errors' and 'warnings'
1464        in the test expectations parser. Now, any problem is a
1465        'warning', and if we are linting the file, warnings become fatal (errors).
1466
1467         This will allow a normal run-webkit-tests run to proceed even if
1468         there are bad lines.
1469
1470         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1471         (ParseError.__init__):
1472         (ParseError.__str__):
1473         (ParseError.__repr__):
1474         (TestExpectationSerializer.to_string):
1475         (TestExpectationParser._parse_modifiers):
1476         (TestExpectationParser._parse_expectations):
1477         (TestExpectationParser._check_modifiers_against_expectations):
1478         (TestExpectationParser._tokenize):
1479         (TestExpectationLine.__init__):
1480         (TestExpectationLine.is_invalid):
1481         (TestExpectationsModel.add_expectation_line):
1482         (TestExpectationsModel._already_seen_better_match):
1483         (TestExpectations.__init__):
1484         (TestExpectations._report_warnings):
1485         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
1486         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1487         (assert_bad_expectations):
1488         (test_parse_warning):
1489         (test_overrides__duplicate):
1490         (ExpectationSyntaxTests.test_missing_expectation):
1491         (ExpectationSyntaxTests.test_missing_colon):
1492         (ExpectationSyntaxTests.test_too_many_colons):
1493         (ExpectationSyntaxTests.test_too_many_equals_signs):
1494         (ExpectationSyntaxTests.test_unrecognized_expectation):
1495         (SemanticTests.test_bug_format):
1496         (SemanticTests.test_bad_bugid):
1497         (SemanticTests.test_slow_and_timeout):
1498         (test_ambiguous):
1499         (test_more_modifiers):
1500         (test_order_in_file):
1501         (test_macro_overrides):
1502         (RebaseliningTest.assertRemove):
1503         (TestExpectationParserTests.test_tokenize_blank):
1504         (TestExpectationParserTests.test_tokenize_missing_colon):
1505         (TestExpectationParserTests.test_tokenize_extra_colon):
1506         (TestExpectationParserTests.test_tokenize_empty_comment):
1507         (TestExpectationParserTests.test_tokenize_comment):
1508         (TestExpectationParserTests.test_tokenize_missing_equal):
1509         (TestExpectationParserTests.test_tokenize_extra_equal):
1510         (TestExpectationParserTests.test_tokenize_valid):
1511         (TestExpectationParserTests.test_tokenize_valid_with_comment):
1512         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
1513         (TestExpectationSerializerTests.test_unparsed_to_string):
1514         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1515         (lint):
1516         * Scripts/webkitpy/style/checkers/test_expectations.py:
1517         (TestExpectationsChecker.check_test_expectations):
1518
1519 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1520
1521         Unreviewed, rolling out r106543.
1522         http://trac.webkit.org/changeset/106543
1523         https://bugs.webkit.org/show_bug.cgi?id=77671
1524
1525         Made tests less stable (Requested by rniwa on #webkit).
1526
1527         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1528         (PerfTestsRunner):
1529         (PerfTestsRunner.__init__):
1530         (PerfTestsRunner._run_tests_set):
1531         (PerfTestsRunner._run_single_test):
1532         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1533         (MainTest.TestDriver.run_test):
1534         (run_test):
1535
1536 2012-02-02  Beth Dakin  <bdakin@apple.com>
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=77664
1539         Add API tests for didNewFirstVisuallyNonEmptyLayout
1540
1541         Reviewed by Darin Adler.
1542
1543         Two new tests.
1544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1545         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
1546         (TestWebKitAPI):
1547         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
1548         (TestWebKitAPI::setPageLoaderClient):
1549         (TestWebKitAPI::TEST):
1550         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
1551         (TestWebKitAPI):
1552         (TestWebKitAPI::didForceRepaint):
1553         (TestWebKitAPI::didFinishLoadForFrame):
1554         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
1555         (TestWebKitAPI::setPageLoaderClient):
1556         (TestWebKitAPI::TEST):
1557         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
1558         (TestWebKitAPI):
1559         (NewFirstVisuallyNonEmptyLayoutFailsTest):
1560         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
1561         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
1562         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
1563         (TestWebKitAPI):
1564         (NewFirstVisuallyNonEmptyLayoutTest):
1565         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
1566         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
1567
1568 2012-02-02  Michael Saboff  <msaboff@apple.com>
1569
1570         Add Michael Saboff to reviewers list.
1571
1572         Rubber-stamped by Gavin Barraclough.
1573
1574         * Scripts/webkitpy/common/config/committers.py:
1575
1576 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1577
1578         Add myself as a committer
1579
1580         Unreviewed
1581
1582         * Scripts/webkitpy/common/config/committers.py:
1583
1584 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         [PerformanceTests] tests have dependencies
1587         https://bugs.webkit.org/show_bug.cgi?id=77506
1588
1589         Reviewed by Hajime Morita.
1590
1591         Load an initialization page before each test after starting a DRT so that
1592         warming up DRT won't affect the performance test results.
1593
1594         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1595         (PerfTestsRunner):
1596         (PerfTestsRunner.__init__):
1597         (PerfTestsRunner._run_tests_set):
1598         (PerfTestsRunner._run_single_test):
1599         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1600         (MainTest.TestDriver.run_test):
1601         (test_initial_page_loaded):
1602         (test_initial_page_loaded.run_test):
1603
1604 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
1605
1606         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
1607
1608         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1609         (PerfTestsRunner._run_tests_set):
1610         (PerfTestsRunner._run_single_test):
1611         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1612         (create_runner):
1613         (test_run_passing_test):
1614         (test_run_silent_test):
1615         (test_run_failed_test):
1616         (test_run_tonguey_test):
1617         (test_run_timeout_test):
1618         (test_run_crash_test):
1619         (test_run_test_set_kills_drt_per_run):
1620         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1621         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
1622         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
1623
1624 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
1625
1626         Webkit generate-coverage-data script needs update to use new test script
1627         https://bugs.webkit.org/show_bug.cgi?id=77597
1628
1629         Reviewed by Dirk Schulze.
1630
1631         * Scripts/generate-coverage-data:
1632
1633 2012-02-01  Adam Barth  <abarth@webkit.org>
1634
1635         Update the tests to show that the mac-ews processes patches from
1636         non-committers.
1637
1638         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1639         (EarlyWarningSytemTest.test_committer_only_ewses):
1640         (EarlyWarningSytemTest.test_builder_ewses):
1641
1642 2012-02-01  Adam Barth  <abarth@webkit.org>
1643
1644         Mac-ews logs are huge
1645         https://bugs.webkit.org/show_bug.cgi?id=77045
1646
1647         Reviewed by Eric Seidel.
1648
1649         In order to get the cr-linux-ews bot to run tests on EC2, we created
1650         the chromium-xvfb port, which contained a number of tweaks to the
1651         Chromium port's behavior.  This patch refactors those tweaks so they
1652         can be shared with the mac-ews, mostly by moving them into the
1653         non-interactive mode of RunTests.
1654
1655         * Scripts/webkitpy/common/config/ports.py:
1656         (WebKitPort):
1657         (WebKitPort.layout_tests_results_path):
1658         (ChromiumPort.run_javascriptcore_tests_command):
1659         (ChromiumXVFBPort):
1660         (ChromiumXVFBPort.run_webkit_tests_command):
1661         * Scripts/webkitpy/common/config/ports_mock.py:
1662         (MockPort):
1663         (MockPort.layout_tests_results_path):
1664         * Scripts/webkitpy/common/config/ports_unittest.py:
1665         (WebKitPortTest.test_chromium_xvfb_port):
1666         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1667         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1668         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1669         (CommitQueueTest.test_commit_queue):
1670         (test_rollout):
1671         (test_manual_reject_during_processing):
1672         * Scripts/webkitpy/tool/steps/runtests.py:
1673         (RunTests.run):
1674         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1675         (RunTestsTest.test_no_unit_tests):
1676         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1677         (StepsTest.test_runtests_args):
1678
1679 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
1680
1681         Roll out r106442. It made some tests more stable but others less stable.
1682
1683         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1684         (PerfTestsRunner._run_tests_set):
1685         (PerfTestsRunner._run_single_test):
1686         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1687         (create_runner):
1688         (test_run_passing_test):
1689         (test_run_silent_test):
1690         (test_run_failed_test):
1691         (test_run_tonguey_test):
1692         (test_run_timeout_test):
1693         (test_run_crash_test):
1694         (test_run_test_set):
1695
1696 2012-02-01  Lucas Forschler  <lforschler@apple.com>
1697
1698         Enable EWS for non-contributers.
1699         https://bugs.webkit.org/show_bug.cgi?id=77576
1700         
1701         Reviewed by Adam Barth.
1702
1703         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1704         (MacEWS):
1705
1706 2012-02-01  Beth Dakin  <bdakin@apple.com>
1707
1708         https://bugs.webkit.org/show_bug.cgi?id=77383
1709         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
1710         -and corresponding-
1711         <rdar://problem/10709560>
1712
1713         Reviewed by Sam Weinig.
1714
1715         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
1716         for.
1717         * MiniBrowser/mac/BrowserWindowController.m:
1718         (-[BrowserWindowController awakeFromNib]):
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::TestController::initialize):
1721
1722 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
1723
1724         TestWebKitAPI isn't being built on chromium bots any more
1725         https://bugs.webkit.org/show_bug.cgi?id=77563
1726
1727         Reviewed by Dimitri Glazkov.
1728
1729         I accidentally dropped it in the refactoring in r105449.
1730
1731         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
1732
1733 2012-02-01  Hans Wennborg  <hans@chromium.org>
1734
1735         Rename WebSpeechInputResult::set() to assign()
1736         https://bugs.webkit.org/show_bug.cgi?id=77540
1737
1738         Reviewed by Darin Fisher.
1739
1740         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1741         (MockWebSpeechInputController::addMockRecognitionResult):
1742         (MockWebSpeechInputController::speechTaskFired):
1743
1744 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1745
1746         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
1747         https://bugs.webkit.org/show_bug.cgi?id=77542
1748
1749         Reviewed by Martin Robinson.
1750
1751         * gtk/generate-gtkdoc: Check first whether there's
1752         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
1753         instead.
1754         (get_webkit2_options): Return just the options since the
1755         pkg_config_path doesn't depend on options
1756         (get_webkit1_options): Ditto.
1757         (generate_doc): Helper function to create a generator and generate
1758         documentation for the given pkg-config file with the given options.
1759         * gtk/gtkdoc.py:
1760         (GTKDoc.__init__): Don't use ** for args parameter, since it's
1761         used as a dict and never expanded.
1762         (PkgConfigGTKDoc.__init__): Ditto.
1763
1764 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1765
1766         [GTK] API documentation is not installed even when building with --enable-gtk-doc
1767         https://bugs.webkit.org/show_bug.cgi?id=77094
1768
1769         Reviewed by Martin Robinson.
1770
1771         * GNUmakefile.am: Add install-data-local and uninstall-local rules
1772         to install/uninstall WebKit1 and WebKit2 API documentation.
1773
1774 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1775
1776         Unreviewed, rolling out r106460.
1777         http://trac.webkit.org/changeset/106460
1778         https://bugs.webkit.org/show_bug.cgi?id=77552
1779
1780         It break unit tests if WEBKIT_TESTFONTS isn't defined.
1781         (Requested by Ossy on #webkit).
1782
1783         * Scripts/webkitpy/layout_tests/port/qt.py:
1784
1785 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1786
1787         [Qt] Automatic clean build feature always do clean build with --no-webkit2
1788         https://bugs.webkit.org/show_bug.cgi?id=74519
1789
1790         Reviewed by Tor Arne Vestbø.
1791
1792         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
1793
1794         * qmake/mkspecs/features/features.prf:
1795
1796 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1797
1798         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1799         https://bugs.webkit.org/show_bug.cgi?id=77466
1800
1801         Reviewed by Kenneth Rohde Christiansen.
1802
1803         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1804         is set or if we should raise an error.
1805
1806         * Scripts/webkitpy/layout_tests/port/qt.py:
1807         (QtPort.setup_environ_for_server):
1808
1809 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
1810
1811         Reviewed by Martin Robinson.
1812
1813         [GTK] Improve FrameLoader signals. Resource loading
1814         https://bugs.webkit.org/show_bug.cgi?id=49543
1815
1816         Support for the new loader signals in DRT.
1817
1818         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1819         (urlPath):
1820         (willSendRequestCallback):
1821         (urlSuitableForTestResult):
1822         (descriptionSuitableForTestResult):
1823         (didReceiveResponse):
1824         (didFinishLoading):
1825         (didFailLoadingWithError):
1826         (createWebView):
1827
1828 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
1829
1830         run-perf-tests should restart DRT for each test
1831         https://bugs.webkit.org/show_bug.cgi?id=77506
1832
1833         Reviewed by Adam Barth.
1834
1835         Always restart DRT when running performance tests in order to minimize the dependency between tests.
1836
1837         * Scripts/webkitpy/layout_tests/port/chromium.py:
1838         (ChromiumDriver.stop):
1839         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1840         (PerfTestsRunner._run_tests_set):
1841         (PerfTestsRunner._run_single_test):
1842         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1843         (create_runner):
1844         (test_run_passing_test):
1845         (test_run_silent_test):
1846         (test_run_failed_test):
1847         (test_run_tonguey_test):
1848         (test_run_timeout_test):
1849         (test_run_crash_test):
1850         (test_run_test_set_kills_drt_per_run):
1851         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1852         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
1853         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
1854
1855 2012-01-31  Hans Wennborg  <hans@chromium.org>
1856
1857         Speech Input: Report speech element rect relative to window rather than frame
1858         https://bugs.webkit.org/show_bug.cgi?id=76443
1859
1860         Reviewed by Darin Fisher.
1861
1862         Update LayoutTestController to allow for retrieving the speech
1863         element's position used in a request.
1864
1865         In Chromium this is handled by the MockWebSpeechInputController;
1866         adding stubs for the other implementations.
1867
1868         * DumpRenderTree/LayoutTestController.cpp:
1869         (setMockSpeechInputDumpRectCallback):
1870         (LayoutTestController::staticFunctions):
1871         * DumpRenderTree/LayoutTestController.h:
1872         (LayoutTestController):
1873         * DumpRenderTree/chromium/LayoutTestController.cpp:
1874         (LayoutTestController::LayoutTestController):
1875         (LayoutTestController::setMockSpeechInputDumpRect):
1876         * DumpRenderTree/chromium/LayoutTestController.h:
1877         (LayoutTestController):
1878         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1879         (MockWebSpeechInputController::setDumpRect):
1880         (MockWebSpeechInputController::clearResults):
1881         (MockWebSpeechInputController::startRecognition):
1882         (MockWebSpeechInputController::MockWebSpeechInputController):
1883         (makeRectResult):
1884         (MockWebSpeechInputController::speechTaskFired):
1885         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
1886         (MockWebSpeechInputController):
1887         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1888         (LayoutTestController::setMockSpeechInputDumpRect):
1889         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1890         (LayoutTestController::setMockSpeechInputDumpRect):
1891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1892         (LayoutTestController::setMockSpeechInputDumpRect):
1893         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1894         (LayoutTestController::setMockSpeechInputDumpRect):
1895         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1896         (LayoutTestController):
1897         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1898         (LayoutTestController::setMockSpeechInputDumpRect):
1899         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1900         (LayoutTestController::setMockSpeechInputDumpRect):
1901
1902 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
1903
1904         [EFL] Add basic DRT/Efl implementation to support viewport test.
1905         https://bugs.webkit.org/show_bug.cgi?id=77320
1906
1907         Reviewed by Andreas Kling.
1908
1909         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1910         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
1911
1912 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
1913
1914         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
1915         https://bugs.webkit.org/show_bug.cgi?id=77473
1916         <rdar://problem/10751357>
1917
1918         Reviewed by Darin Adler.
1919
1920         * DumpRenderTree/mac/EventSendingController.mm:
1921         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1922         * WebKitTestRunner/mac/EventSenderProxy.mm:
1923         (WTR::EventSenderProxy::keyDown):
1924         Added a new special keyDown value to test this.
1925
1926 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
1927
1928         nrwt: fix the mock port to work with DriverProxy, reftests
1929         https://bugs.webkit.org/show_bug.cgi?id=77170
1930
1931         Reviewed by Eric Seidel.
1932
1933         The DryrunPort used for benchmarking and testing NRWT has been
1934         broken since we added the DriverProxy code. It isn't really
1935         needed any more, so I've removed it.
1936
1937         The MockDRT port was also broken by DriverProxy, and moreover,
1938         never worked w/ reftests. Since we don't exercise this module in
1939         the unit tests, the code had also bitrotted some. I have cleaned
1940         it up and made it use DriverInput and DriverOutput for
1941         consistency.
1942
1943         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1944         (DryRunPort.__init__):
1945         (DryRunPort):
1946         (DryRunPort.real_name):
1947         (DryRunPort.create_driver):
1948         (DryRunPort.driver_cmd_line):
1949         (DryRunPort._driver_class):
1950         (DryrunDriver):
1951         (DryrunDriver.run_test):
1952         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1953         (MockDRTPort.create_driver):
1954         (MockChromiumDRT.run_one_test):
1955
1956 2012-01-31  Ojan Vafai  <ojan@chromium.org>
1957
1958         run-webkit-tests calls out to webkit-build-directory twice
1959         https://bugs.webkit.org/show_bug.cgi?id=77248
1960
1961         Reviewed by Dirk Pranke.
1962
1963         * Scripts/webkit-build-directory:
1964         If called with no arguments, print out both the top-level directory and the 
1965         configuration directory
1966
1967         * Scripts/webkitpy/layout_tests/port/config.py:
1968         (Config.build_directory):
1969         When called with no arguments, get and cache both the top-level and configuration directories.
1970
1971         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1972         (main):
1973         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1974         (ConfigTest.assert_configuration):
1975         (ConfigTest.test_build_directory.mock_webkit_build_directory):
1976         (ConfigTest.test_build_directory):
1977         (ConfigTest.test_default_configuration__notfound):
1978         * Scripts/webkitpy/layout_tests/port/webkit.py:
1979         (WebKitPort._build_path):
1980         Cache the build directory in the options object so that other users
1981         of the options object don't need to call out to webkit-build-directory.
1982         Also, properly support the existing --build-directory argument.
1983
1984 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1985
1986         Bump up the timeout for performance tests since DOM/DOMTable.html
1987         and Parser/html5-full-render.html are timing out on the bot.
1988
1989         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1990         (PerfTestsRunner._parse_args):
1991
1992 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
1993
1994         Fix the update_webgl_conformance_tests.py script in order to enable it
1995         to detect the SCM being used correctly.
1996         https://bugs.webkit.org/show_bug.cgi?id=77462
1997
1998         Reviewed by Kenneth Russell.
1999
2000         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2001         (default_out_dir):
2002
2003 2012-01-31  Eric Seidel  <eric@webkit.org>
2004
2005         webkit-patch apply-from-bug should work regardless of your CWD
2006         https://bugs.webkit.org/show_bug.cgi?id=77482
2007
2008         Reviewed by Adam Barth.
2009
2010         webkit-patch only ever works with patches made from the root
2011         directory.  We should pass the CWD to svn-apply in the case
2012         where we're running not from the webkit root.  I believe
2013         this used to work in the past and regressed.
2014
2015         * Scripts/webkitpy/common/checkout/checkout.py:
2016         (Checkout.apply_patch):
2017         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2018         (CheckoutTest.test_apply_patch):
2019
2020 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2021
2022         Unreviewed, rolling out r106302.
2023         http://trac.webkit.org/changeset/106302
2024         https://bugs.webkit.org/show_bug.cgi?id=77472
2025
2026         Broke building DRT before running the tests (Requested by ojan
2027         on #webkit).
2028
2029         * Scripts/webkit-build-directory:
2030         * Scripts/webkitpy/layout_tests/port/config.py:
2031         (Config.build_directory):
2032         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2033         (main):
2034         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2035         (ConfigTest.assert_configuration):
2036         (ConfigTest.test_build_directory.mock_webkit_build_directory):
2037         (ConfigTest.test_build_directory):
2038         (ConfigTest.test_default_configuration__notfound):
2039         * Scripts/webkitpy/layout_tests/port/webkit.py:
2040         (WebKitPort._build_path):
2041
2042 2012-01-31  Antoine Labour  <piman@chromium.org>
2043
2044         Merge WebGraphicsContext3D creation and initialization, and move it to
2045         WebViewClient.
2046         https://bugs.webkit.org/show_bug.cgi?id=76593
2047
2048         Reviewed by Darin Fisher.
2049
2050         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2051         (TestWebPlugin::TestWebPlugin):
2052         (TestWebPlugin::initialize):
2053         * DumpRenderTree/chromium/TestWebPlugin.h:
2054         * DumpRenderTree/chromium/WebViewHost.cpp:
2055         (WebViewHost::createGraphicsContext3D):
2056         (WebViewHost::createPlugin):
2057         * DumpRenderTree/chromium/WebViewHost.h:
2058
2059 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
2060
2061         [GTK] build-webkit warning.
2062         https://bugs.webkit.org/show_bug.cgi?id=77411
2063
2064         Reviewed by Philippe Normand.
2065
2066         * Scripts/webkitdirs.pm:
2067         (isCrossCompilation):
2068
2069 2012-01-31  Dan Bernstein  <mitz@apple.com>
2070
2071         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
2072
2073         Reviewed by Anders Carlsson.
2074
2075         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2076
2077 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
2078
2079         If the QTDIR environment variable is set, the build system fails to compile WinCairo
2080         https://bugs.webkit.org/show_bug.cgi?id=77112
2081
2082         Reviewed by Daniel Bates.
2083
2084         * Scripts/webkitdirs.pm:
2085         (determineIsQt):
2086
2087 2012-01-31  Adam Roben  <aroben@apple.com>
2088
2089         Only call -typingAttributes on WebViews, not WebHTMLViews
2090
2091         Looks like this case was just missed in r105908.
2092
2093         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
2094
2095         Reviewed by Antti Koivisto.
2096
2097         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2098         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
2099         earlier.
2100
2101 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2102
2103         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
2104         https://bugs.webkit.org/show_bug.cgi?id=77221
2105
2106         Reviewed by Kenneth Rohde Christiansen.
2107
2108         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
2109
2110         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2111         (MiniBrowserApplication::sendTouchEvent):
2112
2113 2012-01-26  Hans Wennborg  <hans@chromium.org>
2114
2115         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
2116         https://bugs.webkit.org/show_bug.cgi?id=77083
2117
2118         Reviewed by Darin Fisher.
2119
2120         Add MockWebSpeechInputController which provides a mock implementation
2121         of the WebSpeechInputController interface, and use that in
2122         DumpRenderTree.
2123
2124         * DumpRenderTree/DumpRenderTree.gypi:
2125         * DumpRenderTree/chromium/LayoutTestController.cpp:
2126         (LayoutTestController::addMockSpeechInputResult):
2127         * DumpRenderTree/chromium/LayoutTestController.h:
2128         ():
2129         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
2130         (MockWebSpeechInputController::create):
2131         (MockWebSpeechInputController::addMockRecognitionResult):
2132         (MockWebSpeechInputController::clearResults):
2133         (MockWebSpeechInputController::startRecognition):
2134         (MockWebSpeechInputController::cancelRecognition):
2135         (MockWebSpeechInputController::stopRecording):
2136         (MockWebSpeechInputController::MockWebSpeechInputController):
2137         (MockWebSpeechInputController::speechTaskFired):
2138         (MockWebSpeechInputController::SpeechTask::SpeechTask):
2139         (MockWebSpeechInputController::SpeechTask::stop):
2140         (MockWebSpeechInputController::SpeechTask::runIfValid):
2141         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
2142         (WebKit):
2143         (MockWebSpeechInputController):
2144         (MockWebSpeechInputController::taskList):
2145         (SpeechTask):
2146         * DumpRenderTree/chromium/TestShell.cpp:
2147         * DumpRenderTree/chromium/WebViewHost.cpp:
2148         (WebViewHost::speechInputController):
2149         * DumpRenderTree/chromium/WebViewHost.h:
2150         (WebKit):
2151         (WebViewHost::speechInputControllerMock):
2152         (WebViewHost):
2153         ():
2154
2155 2012-01-31  Hajime Morrita  <morrita@chromium.org>
2156
2157         [PerformanceTests] Add landing html for Dromaeo dom-query test
2158         https://bugs.webkit.org/show_bug.cgi?id=77329
2159
2160         Reviewed by Ryosuke Niwa.
2161
2162         Added some more ignorable output patterns to allow warnings
2163         from a third party test suite.
2164
2165         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2166         (PerfTestsRunner):
2167         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
2168
2169 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
2170
2171         [wx] Unreviewed. Update download URLs to new domain.
2172         
2173         * waf/build/build_utils.py:
2174         (update_wx_deps):
2175
2176 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
2177
2178         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
2179         to the list of build directories.
2180         
2181         * waf/build/settings.py:
2182
2183 2012-01-30  Kentaro Hara  <haraken@chromium.org>
2184
2185         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
2186         output an empty method name (i.e. "()")
2187         https://bugs.webkit.org/show_bug.cgi?id=77336
2188
2189         Reviewed by Darin Adler.
2190
2191         r105797 tried to detect a change outside methods, but it causes a bug that
2192         prepare-ChangeLog can output an empty method name, like this:
2193
2194             * foo/bar/baz.cpp:
2195             (method1):
2196             ():
2197             (method2):
2198
2199         This is because the cpp parser in prepare-ChangeLog cannot distinguish
2200         '{' as the beginning of a method with '{' as the beginning of an array definition
2201         at the top level.
2202
2203             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
2204
2205             void func() { // This '{' is the beginning of a method.
2206                 ...;
2207             }
2208
2209         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
2210
2211         * Scripts/prepare-ChangeLog:
2212         (get_function_line_ranges_for_cpp): Modified as described above.
2213         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
2214         an empty method name. Ideally this should not happen but may happen, since the
2215         parsers are not perfect.
2216         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2217         (NameSpace7):
2218         (NameSpace8):
2219         (Class109):
2220         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2221
2222 2012-01-30  Ojan Vafai  <ojan@chromium.org>
2223
2224         run-webkit-tests calls out to webkit-build-directory twice
2225         https://bugs.webkit.org/show_bug.cgi?id=77248
2226
2227         Reviewed by Dirk Pranke.
2228
2229         This reduces to calls to webkit-build-directory to one call and
2230         saves 500ms for run-webkit-tests over a single file.
2231
2232         * Scripts/webkit-build-directory:
2233         If called with no arguments, print out both the top-level directory and the 
2234         configuration directory.
2235
2236         * Scripts/webkit-build-directory:
2237         * Scripts/webkitpy/layout_tests/port/config.py:
2238         (Config.build_directory):
2239         When called with no arguments, get and cache both the top-level and configuration directories.
2240
2241         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2242         (main):
2243         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2244         (ConfigTest.assert_configuration):
2245         (ConfigTest.test_build_directory.mock_webkit_build_directory):
2246         (ConfigTest.test_build_directory):
2247         (ConfigTest.test_default_configuration__notfound):
2248         * Scripts/webkitpy/layout_tests/port/webkit.py:
2249         (WebKitPort._build_path):
2250         Cache the root directory in the options object so that other users
2251         of the options object don't need to call out to webkit-build-directory.
2252
2253 2012-01-30  Ojan Vafai  <ojan@chromium.org>
2254
2255         Parsing test_expecations.txt + Skipped lists takes too long
2256         https://bugs.webkit.org/show_bug.cgi?id=77059
2257
2258         Reviewed by Dirk Pranke.
2259
2260         This saves ~100ms on the Apple Mac port.
2261         -memoize a bunch of path methods.
2262         -Avoid doing multiple disk accesses per line.
2263         -Parse the skipped list directly instead of turning it into a test_expecations.txt
2264         formatting string and parsing that.
2265
2266         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2267         (TestExpectationParser):
2268         (TestExpectationParser.expectation_for_skipped_test):
2269         (TestExpectationParser._parse_line):
2270         (TestExpectationParser._collect_matching_tests):
2271         (TestExpectations.__init__):
2272         (TestExpectations._add_skipped_tests):
2273         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2274         (test_add_skipped_tests):
2275         (test_add_skipped_tests_duplicate):
2276         * Scripts/webkitpy/layout_tests/port/base.py:
2277         (Port):
2278         (Port.test_isfile):
2279         (Port.normalize_test_name):
2280         (Port.layout_tests_dir):
2281         (Port.abspath_for_test):
2282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2283
2284 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
2285
2286         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
2287         
2288         * Scripts/webkitpy/common/config/watchlist:
2289
2290 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
2291
2292         Unreviewed build fix following bug#76855
2293
2294         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2295         ():
2296         (TestWebKitAPI::TEST_F):
2297
2298 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2299
2300         [Qt] WKTR: Use a software rendering pipiline when running tests.
2301         https://bugs.webkit.org/show_bug.cgi?id=76708
2302
2303         Reviewed by Kenneth Rohde Christiansen.
2304
2305         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2306         (WTR::WrapperWindow::WrapperWindow):
2307         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
2308
2309 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2310
2311         [Qt] Store build config immediately instead of waiting for a successfull build
2312
2313         Otherwise we will not pick up changes to the config if the build is aborted,
2314         for example due to build errors or if the user pressed Ctrl+Z. We now write
2315         the new config before starting a build, but still defer to write the SVN
2316         revision once the build completes successfully.
2317
2318         Reviewed by Ossy.
2319
2320         * Scripts/webkitdirs.pm:
2321         (buildQMakeProjects):
2322
2323 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
2324
2325         [Qt] Add "New Window" button to the Qt MiniBrowser
2326         https://bugs.webkit.org/show_bug.cgi?id=77281
2327
2328         Reviewed by Tor Arne Vestbø.
2329
2330         * MiniBrowser/qt/BrowserWindow.cpp:
2331         (BrowserWindow::BrowserWindow):
2332         * MiniBrowser/qt/MiniBrowser.qrc:
2333         * MiniBrowser/qt/icons/plus.png: Added.
2334         * MiniBrowser/qt/qml/BrowserWindow.qml:
2335
2336 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2337
2338         Unreviewed rolling out r106222.
2339
2340         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2341         (SingleTestRunner.__init__):
2342         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2343         (Worker.handle_test_list):
2344         * Scripts/webkitpy/layout_tests/models/test_input.py:
2345         (TestInput.__init__):
2346         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2347         (_set_up_derived_options):
2348         (parse_args):
2349         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2350         (MainTest.test_repeat_each):
2351         * WebKitTestRunner/TestInvocation.cpp:
2352         (WTR::TestInvocation::setIsPixelTest):
2353
2354 2012-01-30  Hans Wennborg  <hans@chromium.org>
2355
2356         Unreviewed, rolling out r106219.
2357         http://trac.webkit.org/changeset/106219
2358         https://bugs.webkit.org/show_bug.cgi?id=77083
2359
2360         This broke Chromium's test_shell.
2361
2362         * DumpRenderTree/DumpRenderTree.gypi:
2363         * DumpRenderTree/chromium/LayoutTestController.cpp:
2364         (LayoutTestController::addMockSpeechInputResult):
2365         * DumpRenderTree/chromium/LayoutTestController.h:
2366         (WebKit):
2367         (LayoutTestController):
2368         ():
2369         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
2370         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
2371         * DumpRenderTree/chromium/TestShell.cpp:
2372         * DumpRenderTree/chromium/WebViewHost.cpp:
2373         (WebViewHost::speechInputController):
2374         * DumpRenderTree/chromium/WebViewHost.h:
2375         (WebKit):
2376         (WebViewHost::speechInputControllerMock):
2377         (WebViewHost):
2378         ():
2379
2380 2012-01-26  Hans Wennborg  <hans@chromium.org>
2381
2382         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
2383         https://bugs.webkit.org/show_bug.cgi?id=77083
2384
2385         Reviewed by Darin Fisher.
2386
2387         Add MockWebSpeechInputController which provides a mock implementation
2388         of the WebSpeechInputController interface, and use that in
2389         DumpRenderTree.
2390
2391         * DumpRenderTree/DumpRenderTree.gypi:
2392         * DumpRenderTree/chromium/LayoutTestController.cpp:
2393         (LayoutTestController::addMockSpeechInputResult):
2394         * DumpRenderTree/chromium/LayoutTestController.h:
2395         ():
2396         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
2397         (MockWebSpeechInputController::create):
2398         (MockWebSpeechInputController::addMockRecognitionResult):
2399         (MockWebSpeechInputController::clearResults):
2400         (MockWebSpeechInputController::startRecognition):
2401         (MockWebSpeechInputController::cancelRecognition):
2402         (MockWebSpeechInputController::stopRecording):
2403         (MockWebSpeechInputController::MockWebSpeechInputController):
2404         (MockWebSpeechInputController::speechTaskFired):
2405         (MockWebSpeechInputController::SpeechTask::SpeechTask):
2406         (MockWebSpeechInputController::SpeechTask::stop):
2407         (MockWebSpeechInputController::SpeechTask::runIfValid):
2408         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
2409         (WebKit):
2410         (MockWebSpeechInputController):
2411         (MockWebSpeechInputController::taskList):
2412         (SpeechTask):
2413         * DumpRenderTree/chromium/TestShell.cpp:
2414         * DumpRenderTree/chromium/WebViewHost.cpp:
2415         (WebViewHost::speechInputController):
2416         * DumpRenderTree/chromium/WebViewHost.h:
2417         (WebKit):
2418         (WebViewHost::speechInputControllerMock):
2419         (WebViewHost):
2420         ():
2421
2422 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2423
2424         Unreviewed, rolling out r106109.
2425         http://trac.webkit.org/changeset/106109
2426         https://bugs.webkit.org/show_bug.cgi?id=77302
2427
2428         It made tests crash (Requested by Ossy_weekend on #webkit).
2429
2430         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2431         (WTR::WrapperWindow::WrapperWindow):
2432         (WTR::PlatformWebView::PlatformWebView):
2433
2434 2012-01-28  Nico Weber  <thakis@chromium.org>
2435
2436         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
2437         https://bugs.webkit.org/show_bug.cgi?id=77243
2438
2439         Reviewed by Adam Barth.
2440
2441         * Scripts/update-webkit:
2442         * Scripts/webkitdirs.pm:
2443         (isChromiumNinja):
2444         (determineIsChromiumNinja):
2445         (buildChromiumNinja):
2446         (buildChromium):
2447
2448 2012-01-27  Kentaro Hara  <haraken@chromium.org>
2449
2450         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
2451         https://bugs.webkit.org/show_bug.cgi?id=77241
2452
2453         Reviewed by Ryosuke Niwa.
2454
2455         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
2456         in a method in some namespace or class is treated as a method.
2457         This patch fixes the bug.
2458
2459             class C {
2460                 void func()
2461                 {
2462                     if (1) {    // This should not be treated as a method.
2463                     }
2464                 }
2465             };
2466
2467         * Scripts/prepare-ChangeLog:
2468         (get_function_line_ranges_for_cpp):
2469         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2470         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2471         (Class108):
2472         (Class108::func35):
2473
2474 2012-01-27  Enrica Casucci  <enrica@apple.com>
2475
2476         Followup to http://trac.webkit.org/changeset/106171.
2477         Dan Bernstein pointed out correctly that I should
2478         have used copy instead of initWithString.
2479
2480         Reviewed by Dan Bernstein.
2481
2482         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2483         (-[LocalPasteboard initWithName:]):
2484
2485 2012-01-27  Enrica Casucci  <enrica@apple.com>
2486
2487         DRT pasteboard object should return the correct pasteboard name.
2488         https://bugs.webkit.org/show_bug.cgi?id=77260
2489         
2490         Currently the name property always returns nil.
2491         Adding a memeber variable to store the pasteboard name and return its
2492         value from the name method instead of returning nil always.
2493
2494         Reviewed by Dan Bernstein.
2495
2496         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2497         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2498         (-[LocalPasteboard initWithName:]):
2499         (-[LocalPasteboard name]):
2500
2501 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
2502
2503         [GTK] [WK2] Implement the policy client
2504         https://bugs.webkit.org/show_bug.cgi?id=76343
2505
2506         Reviewed by Gustavo Noronha Silva.
2507
2508         * gtk/generate-gtkdoc:
2509         (get_webkit2_options): Update the list of skipped source files to include all clients.
2510
2511 2012-01-27  Ada Chan  <adachan@apple.com>
2512
2513         Add test for WKBundleFrameGetParentFrame().
2514         https://bugs.webkit.org/show_bug.cgi?id=77161
2515
2516         Reviewed by Anders Carlsson.
2517
2518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
2519         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
2520         (TestWebKitAPI):
2521         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
2522         (TestWebKitAPI::setInjectedBundleClient):
2523         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
2524         Make sure the check is successful.
2525         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
2526         (TestWebKitAPI):
2527         (ParentFrameTest):
2528         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
2529         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
2530         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
2531         to the test controller.
2532         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
2533
2534 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
2535
2536         [Gtk] DumpRenderTree lacks --no-timeout command line option
2537         https://bugs.webkit.org/show_bug.cgi?id=77196
2538
2539         Reviewed by Martin Robinson.
2540
2541         Add the --no-timeout command line option and reorganize
2542         watchdog code to make running DumpRenderTree without
2543         timeout possible.
2544
2545         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2546         (setWaitToDumpWatchdog):
2547         (shouldSetWaitToDumpWatchdog):
2548         (initializeGlobalsFromCommandLineOptions):
2549         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2550         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2551         (waitToDumpWatchdogFired):
2552         (LayoutTestController::setWaitToDump):
2553
2554 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
2555
2556         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
2557         https://bugs.webkit.org/show_bug.cgi?id=77122
2558
2559         Reviewed by Kenneth Rohde Christiansen.
2560
2561         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2562         (MiniBrowserApplication::MiniBrowserApplication):
2563
2564 2012-01-27  Zeno Albisser  <zeno@webkit.org>
2565
2566         [Qt][Mac] Build fails after adding ICU support (r105997).
2567         https://bugs.webkit.org/show_bug.cgi?id=77118
2568
2569         Define WTF_USE_ICU_UNICODE if we are on mac.
2570
2571         Reviewed by Tor Arne Vestbø.
2572
2573         * qmake/mkspecs/features/features.prf:
2574
2575 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
2576
2577         Update committers.py with new contributors.
2578         https://bugs.webkit.org/show_bug.cgi?id=77207
2579
2580         I added six new contributors into committers.py:
2581
2582         - Adam Kallai
2583         - Balazs Ankes
2584         - Janos Badics
2585         - Nandor Huszka
2586         - Roland Takacs
2587         - Szilard Ledan-Muntean
2588
2589         * Scripts/webkitpy/common/config/committers.py:
2590
2591 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
2592
2593         Add Vsevolod Vlasov to reviewers list.
2594
2595         Reviewed by Pavel Feldman.
2596
2597         * Scripts/webkitpy/common/config/committers.py:
2598
2599 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2600
2601         [Qt] WKTR: Use a software rendering pipiline when running tests.
2602         https://bugs.webkit.org/show_bug.cgi?id=76708
2603
2604         Reviewed by Kenneth Rohde Christiansen.
2605
2606         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2607         (WTR::WrapperWindow::WrapperWindow):
2608         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
2609
2610 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
2611
2612         [wx] Unreviewed. Build fix, add WebCore/testing/js
2613         to the list of source directories we build.
2614
2615         * waf/build/settings.py:
2616
2617 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
2618
2619         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
2620         https://bugs.webkit.org/show_bug.cgi?id=77177
2621
2622         Reviewed by Jon Honeycutt.
2623
2624         * Scripts/commit-log-editor:
2625
2626 2012-01-26  Ojan Vafai  <ojan@chromium.org>
2627
2628         Decrease sleep time when killing server_process on Mac.
2629         https://bugs.webkit.org/show_bug.cgi?id=77169
2630
2631         Reviewed by Eric Seidel.
2632
2633         This shaves another ~70ms off single test runtime.
2634
2635         * Scripts/webkitpy/layout_tests/port/server_process.py:
2636         (ServerProcess.stop):
2637
2638 2012-01-26  Ojan Vafai  <ojan@chromium.org>
2639
2640         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
2641         https://bugs.webkit.org/show_bug.cgi?id=77164
2642
2643         Reviewed by Dirk Pranke.
2644
2645         http://trac.webkit.org/changeset/106035 depends on builder_name being
2646         falsey by default. There's other code that requires it to be iterable
2647         by default. So, make it be the empty string.
2648
2649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2650         (parse_args):
2651
2652 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
2653
2654         run-perf-test should include relative file paths in test names
2655         https://bugs.webkit.org/show_bug.cgi?id=77144
2656
2657         Reviewed by Adam Birth.
2658
2659         Include all directory names in the test name separated by "/".
2660         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
2661
2662         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2663         (PerfTestsRunner):
2664         (PerfTestsRunner._process_parser_test_result):
2665         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2666         (test_run_test_set_with_json_output):
2667         (test_run_test_set_with_json_source):
2668
2669 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
2670
2671         webkitpy: re-land cleanup of test scaffolding
2672         https://bugs.webkit.org/show_bug.cgi?id=77153
2673
2674         Reviewed by Eric Seidel.
2675
2676         This is an attempt to reland the change in bug 76973 / 
2677         r105935. My earlier attempt to manipulate PYTHONPATH
2678         seems to only work some of the time, for reasons that
2679         elude me. Directly adding Tools/Scripts to sys.path from
2680         inside the test script appears to work (more?) reliably.
2681
2682         Also, it seemed like the files didn't actually get deleted
2683         the last time; I don't know why.
2684
2685         * Scripts/test-webkitpy:
2686         * Scripts/webkitpy/common/system/executive_unittest.py:
2687         (command_line):
2688         (ExecutiveTest):
2689         (ExecutiveTest.test_run_command_args_type):
2690         (ExecutiveTest.test_run_command_with_unicode):
2691         (ExecutiveTest.test_running_pids):
2692         (main):
2693         * Scripts/webkitpy/common/system/fileutils.py: Removed.
2694         * Scripts/webkitpy/test/cat.py: Removed.
2695         * Scripts/webkitpy/test/cat_unittest.py: Removed.
2696         * Scripts/webkitpy/test/echo.py: Removed.
2697         * Scripts/webkitpy/test/echo_unittest.py: Removed.
2698
2699 2012-01-26  Ojan Vafai  <ojan@chromium.org>
2700
2701         run-webkit-tests calls "nm" when it doesn't need to
2702         https://bugs.webkit.org/show_bug.cgi?id=77143
2703
2704         Reviewed by Dirk Pranke.
2705
2706         If we are not running any test that can be skipped by checking
2707         the DRT feature list or looking at the list of symbols, avoid calling
2708         out to DRT or calling "nm".
2709
2710         This saves ~700ms on my Mac Pro. In cases where you still have to call out
2711         to "nm" it's only a couple ms slower.
2712
2713         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2714         (TestExpectations.__init__):
2715         * Scripts/webkitpy/layout_tests/port/base.py:
2716         (Port.skipped_tests):
2717         * Scripts/webkitpy/layout_tests/port/webkit.py:
2718         (WebKitPort._should_check_for_missing_features):
2719         (WebKitPort):
2720         (WebKitPort._should_check_for_missing_symbols):
2721         (WebKitPort._skipped_tests_for_unsupported_features):
2722         (WebKitPort.skipped_layout_tests):
2723         (WebKitPort.skipped_tests):
2724         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2725         (WebKitPortTest.test_skipped_directories_for_symbols):
2726         (test_skipped_directories_for_features):
2727         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2728         (test_skipped_layout_tests):
2729
2730 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
2731
2732         Support a suffix on ChangeLog filenames based on a configuration file
2733         https://bugs.webkit.org/show_bug.cgi?id=76956
2734
2735         Reviewed by Kentaro Hara.
2736
2737         Modify the tools used to generate, edit and resolve ChangeLogs to support
2738         the addition of a suffix to the ChangeLog filename.
2739
2740         This patch makes it easier to support alternate ChangeLog files in branches.
2741
2742         * Scripts/VCSUtils.pm:
2743         (changeLogSuffix):
2744         (changeLogFileName):
2745         * Scripts/commit-log-editor:
2746         * Scripts/prepare-ChangeLog:
2747         (getLatestChangeLogs):
2748         (generateNewChangeLogs):
2749         (generateFileList):
2750         * Scripts/resolve-ChangeLogs:
2751         (findChangeLog):
2752
2753 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2754
2755         Unreviewed, rolling out r106038.
2756         http://trac.webkit.org/changeset/106038
2757         https://bugs.webkit.org/show_bug.cgi?id=77142
2758
2759         Caused a bunch of skipped tests to not be skipped. (Requested
2760         by ojan on #webkit).
2761
2762         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2763         (TestExpectationParser):
2764         (TestExpectationParser.parse):
2765         (TestExpectationParser._parse_line):
2766         (TestExpectationParser._collect_matching_tests):
2767         (TestExpectations.__init__):
2768         (TestExpectations._add_skipped_tests):
2769         * Scripts/webkitpy/layout_tests/port/base.py:
2770         (Port.test_dirs):
2771         (Port.normalize_test_name):
2772         (Port.update_baseline):
2773         (Port.layout_tests_dir):
2774         (Port.relative_perf_test_filename):
2775         (Port.abspath_for_test):
2776
2777 2012-01-25  Ojan Vafai  <ojan@chromium.org>
2778
2779         Parsing test_expecations.txt + Skipped lists takes too long
2780         https://bugs.webkit.org/show_bug.cgi?id=77059
2781
2782         Reviewed by Dirk Pranke.
2783
2784         This saves ~100ms on the Apple Mac port.
2785         -memoize a bunch of path methods.
2786         -Avoid doing multiple disk accesses per line.
2787         -Parse the skipped list directly instead of turning it into a test_expecations.txt
2788         formatting string and parsing that.
2789
2790         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2791         (TestExpectationParser):
2792         (TestExpectationParser.parse_skipped_tests):
2793         (TestExpectationParser._parse_line):
2794         (TestExpectationParser._collect_matching_tests):
2795         (TestExpectations.__init__):
2796         (TestExpectations._add_skipped_tests):
2797         * Scripts/webkitpy/layout_tests/port/base.py:
2798         (Port):
2799         (Port.test_isfile):
2800         (Port.normalize_test_name):
2801         (Port.layout_tests_dir):
2802         (Port.abspath_for_test):
2803
2804 2012-01-25  Ojan Vafai  <ojan@chromium.org>
2805
2806         Only store the SVN revision in the summarized results if we're on a builder
2807         https://bugs.webkit.org/show_bug.cgi?id=76976
2808
2809         Reviewed by Dirk Pranke.
2810
2811         This shaves another ~130ms off the single test run-webkit-tests runtime.
2812
2813         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2814         (summarize_results):
2815         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2816         (ResultSummaryTest.get_result):
2817         (ResultSummaryTest):
2818         (ResultSummaryTest.get_result_summary):
2819         (ResultSummaryTest.get_unexpected_results):
2820         (ResultSummaryTest.test_no_svn_revision):
2821         (ResultSummaryTest.test_svn_revision):
2822         * Scripts/webkitpy/layout_tests/port/base.py:
2823         (Port.use_trac_links_in_results_html):
2824
2825 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
2826
2827         [Qt][WK2] fast/loader tests failed after r94178
2828         https://bugs.webkit.org/show_bug.cgi?id=67388
2829
2830         Reviewed by Simon Hausmann.
2831
2832         Applying the same fix used for Qt-WebKit1 from bug #67254 -
2833         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2834         https://bugs.webkit.org/show_bug.cgi?id=67254
2835         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2836         derived from the running location of DumpRenderTree binary.
2837
2838         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2839         (WTR::LayoutTestController::pathToLocalResource):
2840
2841 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2842
2843         Implement overridePreference for boolean preferences in WebKitTestRunner
2844         https://bugs.webkit.org/show_bug.cgi?id=77033
2845
2846         Reviewed by Alexey Proskuryakov.
2847
2848         For now overridePreference supports boolean values.
2849
2850         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2851         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2852         (WTR::LayoutTestController::setXSSAuditorEnabled):
2853         (WTR::LayoutTestController::overridePreference):
2854         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2855         * WebKitTestRunner/TestController.cpp:
2856         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
2857         explicitly and properly disable the use of PageCache when resetting the
2858         state. Tests that use PageCache can now enable it via overridePreference.
2859
2860 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
2861
2862         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
2863         https://bugs.webkit.org/show_bug.cgi?id=77100
2864
2865         Reviewed by Simon Hausmann.
2866
2867         This patch makes the MiniBrowser read multiple URL's from the command
2868         line such that there will be one browser window opened for each URL.
2869
2870         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2871         (MiniBrowserApplication::handleUserOptions):
2872
2873 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
2874
2875         [Qt] The Qt MiniBrowser crashes when given multiple URL's
2876         https://bugs.webkit.org/show_bug.cgi?id=77009
2877
2878         Reviewed by Simon Hausmann.
2879
2880         This patch fixes a crash in BrowserWindow::newWindow() where a
2881         BrowserWindow-object is constructed with a 0 pointer as the
2882         WindowOptions parameter which leads to a crash.
2883
2884         * MiniBrowser/qt/BrowserWindow.cpp:
2885         (BrowserWindow::BrowserWindow):
2886         (BrowserWindow::newWindow):
2887         * MiniBrowser/qt/BrowserWindow.h:
2888
2889 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2890
2891         [Qt] Use ICU if available
2892         https://bugs.webkit.org/show_bug.cgi?id=76821
2893
2894         Reviewed by Simon Hausmann.
2895
2896         Adding unicode defines for a Qt 5 based build.
2897
2898         * qmake/mkspecs/features/features.prf:
2899
2900 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2901
2902         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
2903         https://bugs.webkit.org/show_bug.cgi?id=42545
2904
2905         Reviewed by Zoltan Herczeg.
2906
2907         Implement the setGeolocationPermission method.
2908
2909         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2911         (WTR::LayoutTestController::setGeolocationPermission):
2912         (WTR):
2913         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2914         (LayoutTestController):
2915
2916 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
2917
2918         [NRWT] Support --ignore-metrics
2919         https://bugs.webkit.org/show_bug.cgi?id=76278
2920
2921         Reviewed by Tony Chang.
2922
2923         Port the feature from ORWT.
2924
2925         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2926         (SingleTestRunner._run_compare_test):
2927         * Scripts/webkitpy/layout_tests/port/driver.py:
2928         (DriverOutput):
2929         (DriverOutput.strip_metrics):
2930         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2931         (DriverOutputTest):
2932         (DriverOutputTest.test_strip_metrics):
2933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2934         (_set_up_derived_options):
2935         (parse_args):
2936
2937 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2938
2939         Unreviewed, rolling out r105935 and r105954.
2940         http://trac.webkit.org/changeset/105935
2941         http://trac.webkit.org/changeset/105954
2942         https://bugs.webkit.org/show_bug.cgi?id=77080
2943
2944         test-webkitpy is still broken (Requested by abarth on
2945         #webkit).
2946
2947         * Scripts/test-webkitpy:
2948         * Scripts/webkitpy/common/system/executive_unittest.py:
2949         (never_ending_command):
2950         (ExecutiveTest.test_run_command_args_type):
2951         (ExecutiveTest.test_run_command_with_unicode):
2952         (ExecutiveTest.test_running_pids):
2953         * Scripts/webkitpy/common/system/fileutils.py:
2954         (make_stdout_binary):
2955         * Scripts/webkitpy/test/cat.py:
2956         (command_arguments):
2957         (main):
2958         * Scripts/webkitpy/test/cat_unittest.py:
2959         (CatTest):
2960         (CatTest.assert_cat):
2961         (CatTest.test_basic):
2962         (CatTest.test_no_newline):
2963         (CatTest.test_unicode):
2964         (CatTest.test_as_command):
2965         * Scripts/webkitpy/test/echo.py:
2966         (command_arguments):
2967         (main):
2968         * Scripts/webkitpy/test/echo_unittest.py:
2969         (EchoTest):
2970         (EchoTest.test_basic):
2971         (EchoTest.test_no_newline):
2972         (EchoTest.test_unicode):
2973         (EchoTest.test_argument_order):
2974         (EchoTest.test_empty_arguments):
2975         (EchoTest.test_no_arguments):
2976         (EchoTest.test_as_command):
2977
2978 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
2979
2980         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
2981         https://bugs.webkit.org/show_bug.cgi?id=76138
2982
2983         Reviewed by Martin Robinson.
2984
2985         * Scripts/webkitdirs.pm:
2986         (isCrossCompilation):
2987         (buildAutotoolsProject):
2988
2989 2012-01-25  Adam Barth  <abarth@webkit.org>
2990
2991         Kentaro is a reviewer now.  Yay!
2992
2993         * Scripts/webkitpy/common/config/committers.py:
2994
2995 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2996
2997         nrwt: running w/ no arguments fails
2998         https://bugs.webkit.org/show_bug.cgi?id=77064
2999
3000         Unreviewed, build fix.
3001
3002         This change fixes a regression introduced in r105944
3003         where running without --platform <foo> or one of the other
3004         platform switches would cause a null deref :(.
3005
3006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3007         (main):
3008
3009 2012-01-25  Eric Seidel  <eric@webkit.org>
3010
3011         Automatically CC someone from Apple on any changes to Obj-C public API
3012         https://bugs.webkit.org/show_bug.cgi?id=77053
3013
3014         Reviewed by Timothy Hatcher.
3015
3016         This has long been de-facto practice, seems now that we have
3017         fancy watchlist support, we should just make the tools
3018         do this automatically.
3019
3020         * Scripts/webkitpy/common/config/watchlist:
3021
3022 2012-01-25  Antoine Labour  <piman@chromium.org>
3023
3024         Updating status in committers.py.
3025
3026         Unreviewed.
3027
3028         * Scripts/webkitpy/common/config/committers.py:
3029
3030 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3031
3032         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
3033         https://bugs.webkit.org/show_bug.cgi?id=77058
3034
3035         Reviewed by Eric Seidel.
3036
3037         r105935 broke executive_unittest by changing which script we
3038         were running and not ensuring that the PYTHONPATH was set up
3039         properly.
3040
3041         This change also fixes a regression introduced recently where
3042         test-webkitpy wasn't figuring out the path to Tools/Scripts
3043         right, either (so running ./test-webkitpy would fail).
3044
3045         * Scripts/test-webkitpy:
3046         * Scripts/webkitpy/common/system/executive_unittest.py:
3047         (script_dir):
3048         (ExecutiveTest.setUp):
3049         (ExecutiveTest):
3050         (ExecutiveTest.tearDown):
3051
3052 2012-01-25  Adam Barth  <abarth@webkit.org>
3053
3054         Disable tests on the mac-ews while we sort out hte stability issues.
3055
3056         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3057         (MacEWS):
3058
3059 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
3060
3061         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
3062         https://bugs.webkit.org/show_bug.cgi?id=76475
3063
3064         Reviewed by Eric Seidel.
3065
3066         This patch cleans up the internal usage of port names for the
3067         Apple mac and Apple win ports so that 'mac' and 'win are never
3068         considered "fully specified" port names: they are still legal
3069         input to the PortFactory.get() routine, but only if run on the given
3070         platform (i.e. trying to PortFactory.get('mac') on windows or
3071         linux will return an error, since we don't know which version of
3072         the port is desired.
3073
3074         This also cleans up handling of the webkit2 variants, so that
3075         the full port names consistently follow the
3076         <operating_system>-<version>[-<wk2>] convention.
3077
3078         Lastly this patch adds some assertions and removes some
3079         try/catch logic to catch more programming and usage errors;
3080         previously mac-tiger might've been allowed -- and it would've
3081         translated into using just the baselines in platform/mac -- but
3082         now it should fail.
3083
3084         * Scripts/webkitpy/layout_tests/port/apple.py:
3085         (ApplePort.determine_full_port_name):
3086         (ApplePort.__init__):
3087         (ApplePort):
3088         (ApplePort._port_name_with_version):
3089         * Scripts/webkitpy/layout_tests/port/builders.py:
3090         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3091         (FactoryTest.test_mac):
3092         (FactoryTest.test_win):
3093         * Scripts/webkitpy/layout_tests/port/mac.py:
3094         (MacPort.baseline_search_path):
3095         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3096         (MacTest.test_versions):
3097         * Scripts/webkitpy/layout_tests/port/win.py:
3098         (WinPort.baseline_search_path):
3099         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3100         (WinTest.test_versions):
3101
3102 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3103
3104         webkitpy: print nicer errors while linting expectations files, remove redundant tests
3105         https://bugs.webkit.org/show_bug.cgi?id=76955
3106
3107         Reviewed by Adam Barth.
3108
3109         This change cleans up the errors that are printed so that the
3110         are more "quickfix" compatible (path:lineno).
3111
3112         Also, there were a bunch of redundant tests between
3113         layout_tests.models.test_expectations_unittest and
3114         style.checkers.test_expectations_unittest. The latter should
3115         just expect the former to do most of the testing.
3116
3117         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3118         (TestExpectationParser._parse_modifiers):
3119         (TestExpectations._report_errors):
3120         (TestExpectations._add_skipped_tests):
3121         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3122         (test_parse_error_nonfatal):
3123         (SemanticTests.test_bad_bugid):
3124         * Scripts/webkitpy/style/checkers/test_expectations.py:
3125         (TestExpectationsChecker.__init__):
3126         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3127         (TestExpectationsTestCase.assert_lines_lint):
3128         (TestExpectationsTestCase.test_valid_expectations):
3129         (TestExpectationsTestCase.test_invalid_expectations):
3130         (TestExpectationsTestCase.test_tab):
3131
3132 2012-01-25  Eric Seidel  <eric@webkit.org>
3133
3134         webkit-patch apply-* should always continue after failures
3135         https://bugs.webkit.org/show_bug.cgi?id=77057
3136
3137         Reviewed by Adam Barth.
3138
3139         As far as I can tell there is only one potential drawback to always
3140         forcing: that if you're somehow in the wrong directory it will create new
3141         directories for new files.  Since webkit-patch always cd's to the root
3142         it seems that's not a drawback.  The drawback of not using --force for
3143         svn-apply, is that it will stop after the first failure, which is rarely
3144         (if ever) the desired behavior.  This just removes the force option
3145         (which was strangely hidden behind --non-interactive).  This should
3146         make for a better user experiance.
3147
3148         * Scripts/webkitpy/common/checkout/checkout.py:
3149         (Checkout.apply_patch):
3150         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3151         (MockCheckout.apply_patch):
3152         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3153         (CheckoutTest.test_chromium_deps):
3154         (CheckoutTest):
3155         (CheckoutTest.test_apply_patch):
3156         * Scripts/webkitpy/tool/commands/download_unittest.py:
3157         (DownloadCommandsTest._default_options):
3158         * Scripts/webkitpy/tool/steps/applypatch.py:
3159         (ApplyPatch.options):
3160         (ApplyPatch.run):
3161         * Scripts/webkitpy/tool/steps/options.py:
3162         (Options):
3163
3164 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3165
3166         nrwt: should be able to run --platform test interactively
3167         https://bugs.webkit.org/show_bug.cgi?id=76959
3168
3169         Reviewed by Adam Barth.
3170
3171         As part of refactoring the Port interfaces, in r103254 I made
3172         passing a Host object to the Port mandatory; previously TestPort
3173         objects would create their own (mock) hosts. However,
3174         new-run-webkit-tests always passed a real Host, not a MockHost,
3175         and so you couldn't run new-run-webkit-tests --platform test
3176         interactively to debug test failures.
3177
3178         This change fixes that by creating a MockHost instead of a real
3179         host if you say --platform test*.
3180
3181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3182         (main):
3183
3184 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3185
3186         run-webkit-tests --lint-test-files should lint all the ports by default
3187         https://bugs.webkit.org/show_bug.cgi?id=76749
3188
3189         Reviewed by Ojan Vafai.
3190
3191         Currently run-webkit-tests --lint-test-files will only lint the
3192         test_expectations for the single port determined by the command
3193         line options. This is not obvious and can produce unintended results
3194         if you want to lint the chromium port (probably the normal case
3195         for using --lint-test-files) but don't specify a port name or
3196         --chromium.
3197
3198         I think we should probably lint *all* of the ports if no port
3199         name is supplied. This change implements that, and also moves
3200         the linting logic out of the Manager class, since this really
3201         has nothing to do with Managers. It has little to do with
3202         run-webkit-tests, but splitting it into a different script would
3203         introduce compatibility issues. It might make sense to do that
3204         anyway, in a separate patch and combining that with cleaning up
3205         the style checker to share more code.
3206
3207         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3208         (Manager._strip_test_dir_prefix):
3209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3210         (lint):
3211         (run):
3212         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3213         (LintTest.test_all_configurations): added.
3214         (LintTest.test_lint_test_files): added.
3215         (LintTest.test_lint_test_files__errors): added.
3216         (MainTest.test_lint_test_files): removed.
3217         (MainTest.test_lint_test_files__errors): removed.
3218
3219 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3220
3221         webkitpy: clean up a bunch of test scaffolding
3222         https://bugs.webkit.org/show_bug.cgi?id=76973
3223
3224         Reviewed by Eric Seidel.
3225
3226         There were several helper modules in the webkitpy.test package
3227         that appear to only be used by executive_unittest.py. I am
3228         rolling them all into that file to make that clearer.
3229
3230         * Scripts/webkitpy/common/system/executive_unittest.py:
3231         (ExecutiveTest.test_run_command_args_type):
3232         (ExecutiveTest.test_run_command_with_unicode):
3233         (ExecutiveTest.test_running_pids):
3234         (command_line):
3235         (main):
3236         * Scripts/webkitpy/common/system/fileutils.py: Removed.
3237         * Scripts/webkitpy/test/cat.py: Removed.
3238         * Scripts/webkitpy/test/cat_unittest.py: Removed.
3239         * Scripts/webkitpy/test/echo.py: Removed.
3240         * Scripts/webkitpy/test/echo_unittest.py: Removed.
3241
3242 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3243
3244         webkitpy: clean up a bunch of test scaffolding
3245         https://bugs.webkit.org/show_bug.cgi?id=76973
3246
3247         Reviewed by Eric Seidel.
3248
3249         There were several helper modules in the webkitpy.test package
3250         that appear to only be used by executive_unittest.py. I am
3251         rolling them all into that file to make that clearer.
3252
3253         * Scripts/webkitpy/common/system/executive_unittest.py:
3254         (ExecutiveTest.test_run_command_args_type):
3255         (ExecutiveTest.test_run_command_with_unicode):
3256         (ExecutiveTest.test_running_pids):
3257         (command_line):
3258         (main):
3259         * Scripts/webkitpy/common/system/fileutils.py: Removed.
3260         * Scripts/webkitpy/test/cat.py: Removed.
3261         * Scripts/webkitpy/test/cat_unittest.py: Removed.
3262         * Scripts/webkitpy/test/echo.py: Removed.
3263         * Scripts/webkitpy/test/echo_unittest.py: Removed.
3264
3265 2012-01-25  Eric Seidel  <eric@webkit.org>
3266
3267         Remove Python 2.5 support from WebKit
3268         https://bugs.webkit.org/show_bug.cgi?id=71593
3269
3270         Reviewed by Adam Barth.
3271
3272         Just removing support from this one core file.
3273         I'll commit the rest of the (large) change once we've
3274         gone 24 hours and seen that no bots have exploded.
3275         We can roll out this one change if we break bots
3276         and then roll in the rest once those bots are fixed.
3277
3278         * Scripts/webkitpy/common/system/executive.py:
3279         (Executive.cpu_count):
3280
3281 2012-01-25  Hajime Morita  <morrita@google.com>
3282
3283         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
3284         https://bugs.webkit.org/show_bug.cgi?id=76863
3285
3286         Reviewed by Dimitri Glazkov.
3287
3288         Added a feature flag.
3289
3290         * Scripts/build-webkit:
3291         * qmake/mkspecs/features/features.prf:
3292
3293 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
3294
3295         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
3296         https://bugs.webkit.org/show_bug.cgi?id=76344
3297
3298         Reviewed by Sam Weinig.
3299
3300         Add a test verifying that the mouse button during policy decisions for
3301         events not triggered by mouse events is NoButton.
3302
3303         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3304         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
3305         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
3306
3307 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3308
3309         run-perf-tests should timeout sooner
3310         https://bugs.webkit.org/show_bug.cgi?id=77026
3311
3312         Reviewed by Adam Barth.
3313
3314         Bump off the timeout from 10 minutes to 4 minutes.
3315
3316         Also use float instead of str in test result values to compress the size of json files bots upload.
3317
3318         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3319         (PerfTestsRunner._parse_args):
3320         (PerfTestsRunner._process_chromium_style_test_result):
3321         (PerfTestsRunner._process_parser_test_result):
3322         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3323         (test_run_test_set_for_parser_tests):
3324         (test_run_test_set_with_json_output):
3325         (test_run_test_set_with_json_source):
3326
3327 2012-01-25  Enrica Casucci  <enrica@apple.com>
3328
3329         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
3330         https://bugs.webkit.org/show_bug.cgi?id=76951
3331         <rdar://problem/9325158>
3332
3333         Reviewed by Alexey Proskuryakov.
3334
3335         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
3336         and WebHTMLView.
3337         (TestWebKitAPI::TEST):
3338
3339 2012-01-23  MORITA Hajime  <morrita@google.com>
3340
3341         [Refactoring][Internals] Should have InternalSettings
3342         https://bugs.webkit.org/show_bug.cgi?id=76424
3343
3344         Reviewed by Kent Tamura.
3345
3346         * GNUmakefile.am: Added so new files.
3347
3348 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
3349
3350         webkitpy: new-run-webkit-websocket is broken
3351         https://bugs.webkit.org/show_bug.cgi?id=76999
3352
3353         Reviewed by Dirk Pranke.
3354
3355         r105674 broke new-run-webkit-websocket, since options.chromium
3356         doesn't exist any more. new-run-webkit-httpd was also broken
3357         and already fixed at r105835.
3358         * Scripts/new-run-webkit-websocketserver:
3359         (main):
3360
3361 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3362
3363         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
3364         https://bugs.webkit.org/show_bug.cgi?id=63458
3365
3366         Reviewed by Adam Roben.
3367
3368         Implement the setPopupBlockingEnabled method.
3369
3370         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3371         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3372         (WTR::LayoutTestController::setPopupBlockingEnabled):
3373         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3374
3375 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
3376
3377         [Qt] Cleanup testfonts handling
3378         https://bugs.webkit.org/show_bug.cgi?id=76068
3379
3380         Reviewed by Simon Hausmann.
3381
3382         Factor test font initialization into it's own file  so test
3383         font users can share the implementation by adding the file
3384         to their build.
3385         Use fonts.conf from the test font directory to not require the
3386         current directory to be the WebKit root.
3387         Fix the -use-test-fonts option of QtTestBrowser by initializing
3388         the fonts earlier, before it is too late (namely before calling
3389         show on the main window).
3390
3391         * DumpRenderTree/qt/DumpRenderTree.pro:
3392         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3393         (WebCore::DumpRenderTree::open):
3394         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3395         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3396         (WebKit::initializeTestFonts):
3397         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
3398         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
3399         we will use the one from the test fonts directory.
3400         * DumpRenderTree/qt/main.cpp:
3401         (main): Fix the ifdefs to make it clear that the code to
3402         set up the Dpi has not been ported to Qt5 yet.
3403         * QtTestBrowser/QtTestBrowser.pro:
3404         * QtTestBrowser/launcherwindow.h:
3405         (WindowOptions::WindowOptions):
3406         * QtTestBrowser/main.cpp:
3407         (launcherMain):
3408         (LauncherApplication::handleUserOptions):
3409         * WebKitTestRunner/InjectedBundle/Target.pri:
3410         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3411         (WTR::activateFonts): Remove the code to set up the Dpi
3412         because it does not work with Qt5.
3413
3414 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
3415
3416         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
3417
3418         Reviewed by Tor Arne Vestø.
3419
3420         Don't require it by making svnRevisionForDirectory return "unknown"
3421         instead of bailing out with an error.
3422
3423         * Scripts/VCSUtils.pm:
3424         (svnRevisionForDirectory):
3425
3426 2012-01-25  Adam Barth  <abarth@webkit.org>
3427
3428         Temporarily disable running the unit tests on the Chromium EWS.  These
3429         tests don't work properly (see
3430         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
3431         blocking the EWS.
3432
3433         * Scripts/webkitpy/common/config/ports.py:
3434         (ChromiumPort):
3435
3436 2012-01-25  Adam Barth  <abarth@webkit.org>
3437
3438         Update results.html version of PixelZoomer
3439         https://bugs.webkit.org/show_bug.cgi?id=76965
3440
3441         Reviewed by Ojan Vafai.
3442
3443         Improve readability as suggested by Ojan.
3444
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
3446
3447 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3448
3449         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
3450         https://bugs.webkit.org/show_bug.cgi?id=76899
3451
3452         Reviewed by Martin Robinson.
3453
3454         * gtk/generate-gtkdoc:
3455         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
3456         WebKitLoaderClient.
3457
3458 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
3459
3460         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/config.json:
3463
3464 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
3465
3466         WebKit needs public performance tests running on public bots
3467         https://bugs.webkit.org/show_bug.cgi?id=10266
3468
3469         Reviewed by Adam Barth.
3470
3471         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
3472         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
3473
3474         * BuildSlaveSupport/build.webkit.org-config/config.json:
3475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3476         (RunAndUploadPerfTests):
3477         (RunAndUploadPerfTests.start):
3478         (UploadPerfTestResults):
3479         (BuildAndPerfTestFactory):
3480         (BuildAndPerfTestFactory.__init__):
3481
3482 2012-01-24  Ojan Vafai  <ojan@chromium.org>
3483
3484         Initializing the browser property of the Bugzilla class takes too long
3485         https://bugs.webkit.org/show_bug.cgi?id=76960
3486
3487         Reviewed by Adam Barth.
3488
3489         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
3490         on my Mac Pro.
3491
3492         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3493         (Bugzilla.__init__):
3494         (Bugzilla._get_browser):
3495         (Bugzilla):
3496         (Bugzilla._set_browser):
3497
3498 2012-01-24  Mark Rowe  <mrowe@apple.com>
3499
3500         Death to JavaScriptGlue.
3501
3502         Rubber-stamped by Geoffrey Garen.
3503
3504         * BuildSlaveSupport/build-launcher-app:
3505         (copyNightlyLauncher):
3506         * Scripts/build-webkit:
3507         * Scripts/do-file-rename:
3508         * Scripts/do-webcore-rename:
3509         * Scripts/webkitpy/common/config/build.py:
3510         (_should_file_trigger_build):
3511         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
3512         path in conjunction with a cross-platform path.
3513         (ShouldBuildTest):
3514
3515 2012-01-24  Kentaro Hara  <haraken@chromium.org>
3516
3517         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
3518         https://bugs.webkit.org/show_bug.cgi?id=75836
3519
3520         Reviewed by David Kilzer.
3521
3522         Previously parser_unittests.pl can just test the returned value of
3523         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
3524         parser_unittests.pl so that it also tests the stdout and stderr of
3525         get_function_line_ranges().
3526
3527         This patch adds css_unittests_warning.css, which contains test cases
3528         for warning messages of the CSS parser of prepare-ChangeLog.
3529
3530         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3531         (captureOutput): Captures the stdout and stderr of a given method.
3532         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
3533         string to relative paths.
3534
3535         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
3536         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
3537         (element1):
3538         (element2):
3539         (element3):
3540         (element4):
3541         ():
3542         (element5):
3543         (element6):
3544
3545         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3546         Just updated the test results, i.e. added stdout and stderr results.
3547         No essential changes in the test results.
3548         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
3549         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
3550         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
3551         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
3552         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
3553
3554 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
3555
3556         webkitpy: new-run-webkit-httpd is broken
3557         https://bugs.webkit.org/show_bug.cgi?id=76963
3558
3559         Reviewed by Adam Barth.
3560
3561         r105674 broke new-run-webkit-httpd, since options.chromium
3562         doesn't exist any more. We didn't catch this because we don't
3563         run the integration tests by default anywhere :(.
3564
3565         * Scripts/new-run-webkit-httpd:
3566         (run):
3567         (main):
3568
3569 2012-01-24  Adam Barth  <abarth@webkit.org>
3570
3571         garden-o-matic pixel zoomer should let you look at every pixel of the image
3572         https://bugs.webkit.org/show_bug.cgi?id=76962
3573
3574         Reviewed by Ojan Vafai.
3575
3576         Previously, you couldn't get up to the right and bottom pixels.
3577
3578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
3579
3580 2012-01-24  Enrica Casucci  <enrica@apple.com>
3581
3582         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
3583         https://bugs.webkit.org/show_bug.cgi?id=76951
3584         <rdar://problem/9325158>
3585
3586         Added test to verify that WebHTMLView supports the typingAttributes method and that it
3587         works as expected.
3588         
3589         Reviewed by Alexey Proskuryakov.
3590
3591         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3592         (TestWebKitAPI::TEST):
3593
3594 2012-01-24  James Robinson  <jamesr@chromium.org>
3595
3596         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
3597         https://bugs.webkit.org/show_bug.cgi?id=76884
3598
3599         Reviewed by Adam Barth.
3600
3601         * Scripts/webkitpy/tool/bot/irc_command.py:
3602         (Rollout.execute):
3603         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3604         (SheriffIRCBotTest.test_rollout):
3605         (SheriffIRCBotTest.test_revert):
3606         (SheriffIRCBotTest.test_multi_rollout):
3607         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
3608         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3609         (SheriffIRCBotTest.test_rollout_invalidate_reason):
3610         (test_multi_rollout_invalidate_reason):
3611
3612 2012-01-24  Kentaro Hara  <haraken@chromium.org>
3613
3614         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
3615         https://bugs.webkit.org/show_bug.cgi?id=75531
3616
3617         Reviewed by David Kilzer.
3618
3619         Previously, the cpp parser of prepare-ChangeLog could not detect a change
3620         outside methods. Consider the following cpp file.
3621
3622             namespace N {
3623             int a;     // this change does not appear on ChangeLog.
3624             class C {
3625                 int b;     // this change does not appear on ChangeLog.
3626                 void f()
3627                 {
3628                     int c;     // this change appears on ChangeLog.
3629                 }
3630                 int d;     // this change does not appear on ChangeLog.
3631             };
3632             int e;     // this change does not appear on ChangeLog.
3633             };
3634
3635         The previous prepare-ChangeLog outputs just methods in which a change is found:
3636             (N::C::f):
3637
3638         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
3639         and methods in which a change is found:
3640             (N):
3641             (N::C):
3642             (N::C::f):
3643
3644         * Scripts/prepare-ChangeLog:
3645         (get_function_line_ranges_for_cpp): Modified as described above.
3646
3647         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
3648         (Class104):
3649         (Class105):
3650         (Class106):
3651         (Class106::func32):
3652         (Class106::func33):
3653         (NameSpace3):
3654         (NameSpace4):
3655         (NameSpace5):
3656         (NameSpace6):
3657         (Class107):
3658         (NameSpace5::NameSpace6::Class107::func34):
3659         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3660
3661 2012-01-24  Kentaro Hara  <haraken@chromium.org>
3662
3663         prepare-ChangeLog outputs warnings for top-level { ... } blocks
3664         https://bugs.webkit.org/show_bug.cgi?id=75943
3665
3666         Reviewed by David Kilzer.
3667
3668         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
3669         because it does not distinguish '}' at the end of a subroutine
3670         with '}' at the end of a if or for statement.
3671
3672         foo.pl:
3673             if (1) {
3674             }
3675             for (@v) {