3D transformed surfaces with z>0 gets cropped
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2
3         [EFL][DRT] Expose window.internals object
4         https://bugs.webkit.org/show_bug.cgi?id=79900
5
6         Exposes window.internals for EFL's DRT. Makes possible to
7         remove some tests from the skip list.
8
9         Reviewed by Antonio Gomes.
10
11         * DumpRenderTree/efl/CMakeLists.txt:
12         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13         (DumpRenderTreeChrome::onWindowObjectCleared):
14
15 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
16
17         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
18         https://bugs.webkit.org/show_bug.cgi?id=78853
19
20         Reviewed by Adam Barth.
21
22         * Scripts/build-webkit:
23         * qmake/mkspecs/features/features.prf:
24
25 2012-03-12  Antonio Gomes  <agomes@rim.com>
26
27         Convert nodesFromRect tests to use Internals interface
28         https://bugs.webkit.org/show_bug.cgi?id=80886
29
30         Reviewed by Ryosuke Niwa.
31
32         This clean up allows to remove port specific bits of each
33         DRT implementation that supports testing Document::nodesFromRect,
34         in favor of making use of the 'Internals' interface to test it.
35
36         This makes its code conveniently more expansible and cleaner.
37
38         Also removed stubs from Win and EFL DRTs.
39
40         * DumpRenderTree/LayoutTestController.cpp:
41         (LayoutTestController::staticFunctions):
42         * DumpRenderTree/LayoutTestController.h:
43         (LayoutTestController):
44         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
45         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
46         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
47         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
48         * DumpRenderTree/qt/LayoutTestControllerQt.h:
49         (LayoutTestController):
50         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
51
52 2012-03-13  Ojan Vafai  <ojan@chromium.org>
53
54         Rebaselining for a new port doesn't work right with multiple fallback ports
55         https://bugs.webkit.org/show_bug.cgi?id=80932
56
57         Reviewed by Adam Barth.
58
59         Since chromium-leopard also falls back to mac-leopard, we need to
60         copy the existing result for both chromium-leopard and chromium-snowleopard
61         before doing lion rebaselines.
62
63         * Scripts/webkitpy/layout_tests/port/builders.py:
64         (fallback_port_names_for_new_port):
65         * Scripts/webkitpy/tool/commands/rebaseline.py:
66         (RebaselineTest):
67         (RebaselineTest._copy_existing_baseline):
68         (RebaselineTest._rebaseline_test):
69         (RebaselineTest.execute):
70         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
71         * Scripts/webkitpy/tool/servers/gardeningserver.py:
72         (GardeningHTTPRequestHandler.rebaseline):
73         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
74         (GardeningServerTest.test_rebaseline_new_port):
75
76 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
77
78         [Qt] Tweak minibrowser UI
79
80         Add some margins to the scroll indicators, and set a dark background
81         color so you see the page dimensions.
82
83         Reviewed by Antonio Gomes.
84
85         * MiniBrowser/qt/qml/BrowserWindow.qml:
86         * MiniBrowser/qt/qml/ScrollIndicator.qml:
87
88 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
89
90         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
91         https://bugs.webkit.org/show_bug.cgi?id=79601
92
93         Reviewed by Gustavo Noronha Silva.
94
95         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
96         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
97         and is taken over to sendKeyDown.
98         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
99         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
100
101         * DumpRenderTree/efl/EventSender.cpp:
102         (KeyEventInfo::KeyEventInfo):
103         (KeyEventInfo):
104         (createKeyEventInfo):
105         (sendKeyDown):
106         (keyDownCallback):
107         (sendAsynchronousKeyDown):
108         (scheduleAsynchronousKeyDownCallback):
109
110 2012-03-12  Ojan Vafai  <ojan@chromium.org>
111
112         webkit-patch optimize-baselines sometimes creates a mac-future result
113         https://bugs.webkit.org/show_bug.cgi?id=80717
114
115         Reviewed by Adam Barth.
116
117         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
118         (_baseline_search_hypergraph):
119         (BaselineOptimizer._find_optimal_result_placement):
120         (BaselineOptimizer._filter_virtual_ports):
121         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
122         (BaselineOptimizerTest.test_no_add_mac_future):
123
124 2012-03-12  Jessie Berlin  <jberlin@apple.com>
125
126         More Windows build fixing.
127
128         * DumpRenderTree/win/WorkQueueItemWin.cpp:
129
130 2012-03-12  Jessie Berlin  <jberlin@apple.com>
131
132         More Windows build fixing.
133
134         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
135         * DumpRenderTree/win/EditingDelegate.cpp:
136         * DumpRenderTree/win/EventSender.cpp:
137         * DumpRenderTree/win/FrameLoadDelegate.cpp:
138         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
139         * DumpRenderTree/win/UIDelegate.cpp:
140
141 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
142
143         remove the 'gpu' group from the flakiness dashboard
144         https://bugs.webkit.org/show_bug.cgi?id=80353
145
146         Reviewed by Adam Barth.
147
148         Since those bots are obsolete, we don't need this any more.
149
150         * TestResultServer/static-dashboards/builders.js:
151         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
152         (testPlatformAndBuildType):
153         (testHtmlForTestTypeSwitcherGroup):
154
155 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
156
157         remove graphics_type from webkitpy.layout_tests.models.test_configuration
158         https://bugs.webkit.org/show_bug.cgi?id=80643
159
160         Reviewed by Ojan Vafai.
161
162         Now that the chromium-gpu ports are gone, there's no need for
163         the graphics_type CPU/GPU distinction. Most of this change is
164         just updating tests accordingly.
165
166         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
167         (TestExpectationEditorTests):
168         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
169         (TestConfiguration.__init__):
170         (TestConfiguration.category_order):
171         (TestConfiguration.__str__):
172         (TestConfiguration.__repr__):
173         (TestConfiguration.__hash__):
174         (TestConfigurationConverter.to_specifiers_list):
175         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
176         (make_mock_all_test_configurations_set):
177         (TestConfigurationTest.test_items):
178         (TestConfigurationTest.test_keys):
179         (TestConfigurationTest.test_str):
180         (TestConfigurationTest.test_repr):
181         (TestConfigurationTest.test_hash):
182         (TestConfigurationTest.test_hash.query_unknown_key):
183         (TestConfigurationTest.test_eq):
184         (TestConfigurationTest.test_values):
185         (SpecifierSorterTest.test_specifier_priority):
186         (SpecifierSorterTest.test_sort_specifiers):
187         (TestConfigurationConverterTest.test_to_config_set):
188         (TestConfigurationConverterTest.test_macro_expansion):
189         (TestConfigurationConverterTest.test_to_specifier_lists):
190         (TestConfigurationConverterTest.test_converter_macro_collapsing):
191         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
192         (test_error_on_different_build_type):
193         (TestExpectationSerializerTests.test_parsed_to_string):
194         (TestExpectationSerializerTests.test_reconstitute_only_these):
195         * Scripts/webkitpy/layout_tests/port/apple.py:
196         (ApplePort._generate_all_test_configurations):
197         * Scripts/webkitpy/layout_tests/port/base.py:
198         (Port.__init__):
199         (Port.name):
200         (Port.version):
201         (Port.test_configuration):
202         * Scripts/webkitpy/layout_tests/port/builders.py:
203         * Scripts/webkitpy/layout_tests/port/chromium.py:
204         (ChromiumPort):
205         (ChromiumPort._generate_all_test_configurations):
206         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
207         (ChromiumLinuxPort.__init__):
208         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
209         (ChromiumLinuxPortTest.test_check_illegal_port_names):
210         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
211         (ChromiumMacPortTest.test_baseline_path):
212         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
213         (ChromiumPortTest.test_all_test_configurations):
214         * Scripts/webkitpy/layout_tests/port/efl.py:
215         (EflPort._generate_all_test_configurations):
216         * Scripts/webkitpy/layout_tests/port/gtk.py:
217         (GtkPort._generate_all_test_configurations):
218         * Scripts/webkitpy/layout_tests/port/qt.py:
219         (QtPort._generate_all_test_configurations):
220         * Scripts/webkitpy/layout_tests/port/test.py:
221         (TestPort.all_test_configurations):
222         (TestPort._all_build_types):
223         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
224         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
225         (BuildCoverageExtrapolatorTest.test_extrapolate):
226         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
227         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
228         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
229         (GardeningExpectationsUpdaterTest.test_pass_expectation):
230         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
231         (GardeningExpectationsUpdaterTest.test_spurious_updates):
232
233 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
234
235         _runtime_feature_list isn't supported on Apple Mac DRT
236         https://bugs.webkit.org/show_bug.cgi?id=80906
237
238         Reviewed by Eric Seidel.
239
240         It looks like this feature is actually only supported on the Win
241         DRT port, so this patch reworks the code to make that clearer
242         and reduce unnecessary overrides.
243
244         * Scripts/webkitpy/layout_tests/port/efl.py:
245         (EflPort._path_to_webcore_library):
246         * Scripts/webkitpy/layout_tests/port/gtk.py:
247         (GtkPort._path_to_webcore_library):
248         * Scripts/webkitpy/layout_tests/port/qt.py:
249         (QtPort._skipped_file_search_paths):
250         * Scripts/webkitpy/layout_tests/port/webkit.py:
251         (WebKitPort._runtime_feature_list):
252         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
253         (TestWebKitPort.__init__):
254         (TestWebKitPort.all_test_configurations):
255         (test_skipped_directories_for_features):
256         * Scripts/webkitpy/layout_tests/port/win.py:
257         (WinPort):
258         (WinPort._runtime_feature_list):
259         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
260         (WinPortTest.test_operating_system):
261         (WinPortTest):
262         (WinPortTest.test_runtime_feature_list):
263
264 2012-03-12  Peter Beverloo  <peter@chromium.org>
265
266         [Chromium] Temporary build-fix for the Android bot
267         https://bugs.webkit.org/show_bug.cgi?id=80862
268
269         Reviewed by Adam Barth.
270
271         Manually set the environmental variables required to compile source
272         files through the Android NDK instead of relying on the envsetup.sh
273         script. A proper fix will be landed to Chromium ASAP, and following
274         a Chromium roll into WebKit this code will be removed.
275
276         * Scripts/webkitdirs.pm:
277         (buildChromiumMakefile):
278
279 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
280
281         [Qt] Use right construct to detect config_test_gccdepends
282
283         Reviewed by Andreas Kling.
284
285         * qmake/mkspecs/features/default_pre.prf:
286
287 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
288
289         [Qt] Expose location of WebKit's bin and imports dir through module file
290
291         Reviewed by Andreas Kling.
292
293         * qmake/qt_webkit.pri:
294
295 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
296
297         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
298         https://bugs.webkit.org/show_bug.cgi?id=80832
299
300         Reviewed by Tor Arne Vestbø.
301
302         Add a basic scroll indicator component to MiniBrowser so that it
303         behaves similar to the ScrollDecorator QML component.
304
305         * MiniBrowser/qt/MiniBrowser.qrc:
306         * MiniBrowser/qt/qml/BrowserWindow.qml:
307         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
308
309 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
310
311         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
312         https://bugs.webkit.org/show_bug.cgi?id=80809
313
314         Reviewed by Philippe Normand.
315
316         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
317
318 2012-03-12  Ming Xie  <mxie@rim.com>
319
320         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
321         https://bugs.webkit.org/show_bug.cgi?id=80812
322
323         Reviewed by Rob Buis.
324
325         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
326         * Scripts/webkitdirs.pm:
327         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
328
329
330 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
331
332         [Qt] Fix build with newer Qt 5.
333
334         Reviewed by Tor Arne Vestbø.
335
336         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
337         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
338         we should disable -Werror.
339
340         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
341         implicit load was removed recently.
342
343         * qmake/mkspecs/features/default_pre.prf:
344         * qmake/mkspecs/features/unix/default_post.prf:
345
346 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
347
348         Add --instruments option to sunspider to profile with Instruments
349         https://bugs.webkit.org/show_bug.cgi?id=80783
350
351         Reviewed by Filip Pizlo.
352
353         * Scripts/run-sunspider:
354
355 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
356
357         [Qt] [WK2] Support threaded renderer in WK2
358         https://bugs.webkit.org/show_bug.cgi?id=76661
359
360         Remove disabling of threaded rendering.
361
362         Reviewed by Noam Rosenthal.
363
364         * MiniBrowser/qt/main.cpp:
365         (main):
366
367 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
368
369         [WK2] run-perf-tests should be able to run with WTR
370         https://bugs.webkit.org/show_bug.cgi?id=80042
371
372         Reviewed by Martin Robinson.
373
374         Add an option to PerfTestRunner to use WebKitTestRunner instead of
375         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
376         to avoid timing out when running performance tests.
377
378         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
379         (PerfTestsRunner._parse_args):
380         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
381         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
382         to true.
383         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
384         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
385         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
386         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
387         publicly accessible.
388         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
389         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
390         is required.
391         * WebKitTestRunner/TestController.cpp:
392         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
393         to true.
394         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
395         if '--no-timeout' option is present.
396         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
397         value, or -1.0 if timeout should not occur.
398         * WebKitTestRunner/TestController.h:
399         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
400         publicly accessible.
401         * WebKitTestRunner/TestInvocation.cpp:
402         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
403         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
404         Waiting for final message should not time out if not necessary.
405         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
406         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
407         * WebKitTestRunner/qt/TestControllerQt.cpp:
408         (WTR::TestController::platformRunUntil): Ditto.
409         * WebKitTestRunner/mac/TestControllerMac.mm:
410         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
411         is missing.
412         * WebKitTestRunner/win/TestControllerWin.cpp:
413         (WTR::TestController::platformRunUntil): Ditto.
414
415 2012-03-09  Jon Lee  <jonlee@apple.com>
416
417         Rename NotificationPresenter to NotificationClient
418         https://bugs.webkit.org/show_bug.cgi?id=80488
419         <rdar://problem/10965558>
420
421         Reviewed by Kentaro Hara.
422
423         Refactor to use renamed WebCore::NotificationClient.
424         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
425         (DRTDesktopNotificationPresenter::checkNotificationPermission):
426
427 2012-03-07  James Robinson  <jamesr@chromium.org>
428
429         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
430         https://bugs.webkit.org/show_bug.cgi?id=80523
431
432         Reviewed by Darin Fisher.
433
434         * DumpRenderTree/chromium/WebViewHost.cpp:
435         (WebViewHost::createGraphicsContext3D):
436         * DumpRenderTree/chromium/WebViewHost.h:
437         (WebViewHost):
438
439 2012-03-09  Eric Seidel  <eric@webkit.org>
440
441         build-webkit should build Source/WTF on Mac
442         https://bugs.webkit.org/show_bug.cgi?id=80728
443
444         Reviewed by Adam Barth.
445
446         We'll add other ports to this list in future commits.
447
448         * Scripts/build-webkit:
449
450 2012-03-09  Jon Lee  <jonlee@apple.com>
451
452         Add support for ENABLE(LEGACY_NOTIFICATIONS)
453         https://bugs.webkit.org/show_bug.cgi?id=80497
454
455         Reviewed by Adam Barth.
456
457         Prep for b80472: Update API for Web Notifications
458         * Scripts/build-webkit:
459         * qmake/mkspecs/features/features.prf:
460
461 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
462
463         Bash scripts should support LF endings only
464         https://bugs.webkit.org/show_bug.cgi?id=79509
465
466         Reviewed by David Kilzer.
467
468         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
469         * EWSTools/start-queue.sh: Added property svn:eol-style.
470         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
471         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
472         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
473         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
474
475 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
476
477         [BUILD] use detected python to run generate-gtkdoc
478         https://bugs.webkit.org/show_bug.cgi?id=80695
479
480         Reviewed by Gustavo Noronha Silva.
481
482         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
483
484 2012-03-09  Nat Duca  <nduca@chromium.org>
485
486         Make check-webkit-style complain about "no new tests" lines in changelogs
487         https://bugs.webkit.org/show_bug.cgi?id=80582
488
489         Reviewed by David Levin.
490
491         * Scripts/webkitpy/style/checkers/changelog.py:
492         (ChangeLogChecker.check_entry):
493         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
494         (ChangeLogCheckerTest.test_no_new_tests):
495
496 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
497
498         Unreviewed, rolling out r110250.
499         http://trac.webkit.org/changeset/110250
500         https://bugs.webkit.org/show_bug.cgi?id=80682
501
502         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
503         qt-linux at all. (Requested by Ossy on #webkit).
504
505         * Scripts/old-run-webkit-tests:
506         * Scripts/webkitpy/layout_tests/port/qt.py:
507         (QtPort):
508         (QtPort.determine_full_port_name):
509         (QtPort.baseline_search_path):
510         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
511         (QtPortTest):
512         (QtPortTest._assert_search_path):
513         (QtPortTest.test_baseline_search_path):
514
515 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
516
517         [Qt] Use Qt's module system for install rules and depending on QtWebKit
518
519         Instead of rolling our own install rules we now use the same approach as
520         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
521
522         This ensures that we follow the same semantics as the rest of Qt on
523         what sort of config options are enabled by default (create_cmake eg.).
524         It also allows us to use QT += webkit instead of the workaround we had
525         with CONFIG += qtwebkit.
526
527         We do however force Qt to always treat our build as a non-developer build,
528         so the libraries will end up in the WebKit lib directory instead of the
529         qtbase directory (as with a normal developer-build). This allows us to
530         keep the webkit-build self-contained. If Qt is a developer build we still
531         copy the module file manually to Qt, so that you don't have to install
532         WebKit to make it available.
533
534         For non-developer builds of Qt, it is still possible to use the built
535         WebKit libraries without having to install them, by having the variable
536         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
537         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
538
539         https://bugs.webkit.org/show_bug.cgi?id=80590
540
541         Reviewed by Simon Hausmann.
542
543         * DumpRenderTree/qt/DumpRenderTree.pro:
544         * MiniBrowser/qt/BrowserWindow.cpp:
545         * MiniBrowser/qt/MiniBrowser.pro:
546         * MiniBrowser/qt/MiniBrowserApplication.cpp:
547         * MiniBrowser/qt/UrlLoader.cpp:
548         * QtTestBrowser/QtTestBrowser.pro:
549         * Tools.pro:
550         * WebKitTestRunner/InjectedBundle/Target.pri:
551         * WebKitTestRunner/Target.pri:
552         * qmake/mkspecs/features/default_post.prf:
553         * qmake/mkspecs/features/default_pre.prf:
554         * qmake/mkspecs/features/functions.prf:
555         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
556         * qmake/mkspecs/features/qtwebkit.prf:
557         * qmake/mkspecs/features/rpath.prf:
558         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
559         * qmake/qt_webkit.pri: Added.
560
561 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
562
563         Unreviewed. Update my email.
564
565         * Scripts/webkitpy/common/config/committers.py:
566
567 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
568
569         Recent changes to chromium.py etc. broke chromium_android.py
570         https://bugs.webkit.org/show_bug.cgi?id=80623
571
572         Reviewed by Dirk Pranke.
573
574         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
575         (ChromiumAndroidDriver.__init__):
576         (ChromiumAndroidDriver._start):
577
578 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
579
580         [Chromium] Exception running reftest with --no-pixel-tests
581         https://bugs.webkit.org/show_bug.cgi?id=80642
582
583         Reviewed by Dirk Pranke.
584
585         * Scripts/webkitpy/layout_tests/port/chromium.py:
586         (ChromiumDriver.__init__):
587         (ChromiumDriver._wrapper_options):
588
589 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
590
591         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
592         https://bugs.webkit.org/show_bug.cgi?id=72489
593
594         Reviewed by Dirk Pranke.
595
596         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
597         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
598         --platform will override the platform name and then we'll use it.
599
600         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
601         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
602         override it in the end.
603
604         * Scripts/old-run-webkit-tests:
605         * Scripts/webkitpy/layout_tests/port/qt.py:
606         (QtPort):
607         (QtPort.determine_full_port_name):
608         (QtPort.baseline_search_path):
609         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
610         (QtPortTest):
611         (QtPortTest._assert_search_path):
612         (QtPortTest.test_baseline_search_path):
613
614 2012-03-08  Beth Dakin  <bdakin@apple.com>
615
616         https://bugs.webkit.org/show_bug.cgi?id=80463
617         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
618         -and corresponding-
619         <rdar://problem/10970221>
620
621         Reviewed by Dan Bernstein.
622
623         New test!
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
626         (TestWebKitAPI):
627         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
628         (TestWebKitAPI::setPageLoaderClient):
629         (TestWebKitAPI::TEST):
630         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
631         (TestWebKitAPI):
632         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
633         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
634         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
635         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
636
637 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
638
639         [Qt] Prospective Windows build fix
640
641         Don't assume that windows-builds will always run inside a cmd.exe shell.
642
643         * qmake/mkspecs/features/default_pre.prf:
644
645 2012-03-08  Dan Bernstein  <mitz@apple.com>
646
647         <rdar://problem/10981173> Dashboard regions should not be in device space
648
649         Reviewed by John Sullivan.
650
651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
652         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
653         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
654         (TestWebKitAPI):
655         (TestWebKitAPI::TEST):
656
657 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
658
659         webkit-patch works oddly on local Git branches
660         https://bugs.webkit.org/show_bug.cgi?id=76958
661
662         Reviewed by Ojan Vafai.
663
664         This change makes the '-g' flag to webkit-patch behave a
665         little more consistently with git. The 'HEAD..' syntax
666         is changed to 'HEAD....' (four dots), so as to not
667         collide with the underlying git syntax. We also generalize
668         the syntax to support any refname, so 'foo....' means
669         diff against foo and include working copy changes.
670
671         This change also adds the 'UPSTREAM' shortcut to identify
672         whatever the current upstream/tracking branch is; this is
673         useful if you have multiple local branches stacked up.
674
675         * Scripts/webkitpy/common/checkout/scm/git.py:
676         (Git._branch_from_ref):
677         (Git):
678         (Git._current_branch):
679         (Git._upstream_branch):
680         (Git.merge_base):
681         (Git._commit_on_branch):
682         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
683         (GitSVNTest._second_local_commit):
684         (GitSVNTest._two_local_commits):
685         (GitSVNTest.test_commit_with_message_git_commit_range):
686         (GitSVNTest.test_upstream_branch):
687         (GitSVNTest.test_create_patch_working_copy_only):
688         (GitSVNTest.test_changed_files_local_plus_working_copy):
689         (GitSVNTest.test_changed_files_working_copy_only):
690         (GitSVNTest.test_changed_files_upstream):
691         * Scripts/webkitpy/tool/steps/options.py:
692         (Options):
693
694 2012-03-08  John Sullivan  <sullivan@apple.com>
695
696         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
697
698         Reviewed by Eric Carlson.
699
700         * Scripts/extract-localizable-strings:
701         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
702         with NSLocalized. Also improved an error message to include the troublesome token.
703
704 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
705
706         Unreviewed, rolling out r110115.
707         http://trac.webkit.org/changeset/110115
708         https://bugs.webkit.org/show_bug.cgi?id=80581
709
710         broke test-webkitpy (Requested by philn-tp on #webkit).
711
712         * Scripts/old-run-webkit-tests:
713         * Scripts/webkitpy/layout_tests/port/qt.py:
714         (QtPort):
715         (QtPort.determine_full_port_name):
716         (QtPort.baseline_search_path):
717
718 2012-03-08  Kentaro Hara  <haraken@chromium.org>
719
720         Unreviewed. Added myself to watchlist.
721
722         * Scripts/webkitpy/common/config/watchlist:
723
724 2012-03-07  Jessie Berlin  <jberlin@apple.com>
725
726         Clean Windows build fails after r110033
727         https://bugs.webkit.org/show_bug.cgi?id=80553
728
729         Rubber-stamped by Jon Honeycutt and Eric Seidel.
730
731         Add the new JavaScriptCore include directory to some more vsprops files.
732
733         * DumpRenderTree/win/ImageDiffCommon.vsprops:
734         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
735         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
736
737 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
738
739         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
740         https://bugs.webkit.org/show_bug.cgi?id=72489
741
742         Reviewed by Dirk Pranke.
743
744         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
745         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
746         --platform will override the platform name and then we'll use it.
747
748         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
749         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
750         override it in the end.
751
752         * Scripts/old-run-webkit-tests:
753         * Scripts/webkitpy/layout_tests/port/qt.py:
754         (QtPort):
755         (QtPort.determine_full_port_name):
756         (QtPort.baseline_search_path):
757
758 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
759
760         [Qt][WK2] MiniBrowser on desktop does not react to click events
761         https://bugs.webkit.org/show_bug.cgi?id=80314
762
763         Reviewed by Kenneth Rohde Christiansen.
764
765         Do not enable touch mocking on desktop mode.
766
767         * MiniBrowser/qt/MiniBrowserApplication.cpp:
768         (MiniBrowserApplication::handleUserOptions):
769
770 2012-03-07  Ojan Vafai  <ojan@chromium.org>
771
772         Automatically move to the next test after rebaseline in the results view
773         https://bugs.webkit.org/show_bug.cgi?id=80527
774
775         Reviewed by Dimitri Glazkov.
776
777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
779
780 2012-03-07  Ojan Vafai  <ojan@chromium.org>
781
782         garden-o-matic rebaseline is broken for ports that don't have a fallback port
783         https://bugs.webkit.org/show_bug.cgi?id=80526
784
785         Reviewed by Adam Barth.
786
787         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
788         since there is no "None" port.
789
790         * Scripts/webkitpy/tool/servers/gardeningserver.py:
791         (GardeningHTTPRequestHandler.rebaseline):
792         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
793         (GardeningServerTest.test_rebaseline):
794
795 2012-03-07  James Robinson  <jamesr@chromium.org>
796
797         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
798         https://bugs.webkit.org/show_bug.cgi?id=80521
799
800         Reviewed by Kenneth Russell.
801
802         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
803         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
804         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
805
806         Covered by platform/chromium/compositing/plugins/*
807
808         * DumpRenderTree/chromium/TestWebPlugin.cpp:
809         (TestWebPlugin::TestWebPlugin):
810         (TestWebPlugin::initialize):
811         (TestWebPlugin::updateGeometry):
812         (TestWebPlugin::initScene):
813         (TestWebPlugin::destroyScene):
814         * DumpRenderTree/chromium/TestWebPlugin.h:
815         (TestWebPlugin):
816         * DumpRenderTree/chromium/WebViewHost.cpp:
817         (WebViewHost::createPlugin):
818
819 2012-03-07  Philippe Normand  <pnormand@igalia.com>
820
821         [GTK] remove webkitpy dependency in run-gtk-tests
822         https://bugs.webkit.org/show_bug.cgi?id=80500
823
824         Reviewed by Martin Robinson.
825
826         Replace Executive calls with bare subprocess calls.
827
828         * Scripts/run-gtk-tests:
829         (TestRunner):
830         (TestRunner._lookup_atspi2_binary):
831         (TestRunner.run):
832         (TestRunner.run.run_for_real):
833
834 2012-03-07  Philippe Normand  <pnormand@igalia.com>
835
836         Unreviewed, GTK build fix after r110059.
837
838         * Scripts/run-gtk-tests:
839         (TestRunner._check_if_tests_have_timed_out):
840         (TestRunner.run.run_tests):
841         (TestRunner):
842
843 2012-03-07  Philippe Normand  <pnormand@igalia.com>
844
845         [GTK] race condition in run-gtk-tests
846         https://bugs.webkit.org/show_bug.cgi?id=80495
847
848         Reviewed by Martin Robinson.
849
850         Refactored the script to wait the a11y dbus service becomes
851         available before starting the tests.
852
853         * Scripts/run-gtk-tests:
854         (TestRunner._lookup_atspi2_binary):
855         (TestRunner):
856         (TestRunner._wait_dbus_service_and_run):
857         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
858         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
859         (TestRunner.run):
860         (TestRunner.run.bailout):
861         (TestRunner.run.run_for_real):
862
863 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
864
865         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
866         https://bugs.webkit.org/show_bug.cgi?id=80425
867
868         Reviewed by Simon Hausmann.
869
870         Set startScreenPos in mock touch point
871
872         * MiniBrowser/qt/MiniBrowserApplication.cpp:
873         (MiniBrowserApplication::notify):
874         * MiniBrowser/qt/MiniBrowserApplication.h:
875         (MiniBrowserApplication):
876
877 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
878
879         [Qt] Windows build fix.
880
881         Reviewed by Tor Arne Vestbø.
882
883         Pass the -j parameter only to "make", not "nmake".
884
885         * Scripts/webkitdirs.pm:
886         (buildQMakeProjects):
887
888 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
889
890         [Qt] Fix compilation without QtQuick1
891         https://bugs.webkit.org/show_bug.cgi?id=80503
892
893         Reviewed by Tor Arne Vestbø.
894
895         Introduce HAVE_QQUICK1 as feature and added haveQtModule
896         as convenience function.
897
898         * qmake/mkspecs/features/features.prf:
899         * qmake/mkspecs/features/functions.prf:
900
901 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
902
903         [Qt] Add qmake config tests for JPEG and PNG library
904         https://bugs.webkit.org/show_bug.cgi?id=80398
905
906         Add JPEG and PNG library tests to config.tests and
907         add error() abort to WebCore.pri if tests don't work.
908
909         Reviewed by Tor Arne Vestbø.
910
911         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
912         (main):
913         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
914         * qmake/config.tests/libpng/libpng.cpp: Added.
915         (main):
916         * qmake/config.tests/libpng/libpng.pro: Added.
917         * qmake/sync.profile:
918
919 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
920
921         [EFL] Build warning: Fix warn_unused_result warnings.
922         https://bugs.webkit.org/show_bug.cgi?id=79194
923
924         Reviewed by Filip Pizlo.
925
926         Fixed build warning which is getting generated when not using return
927         value of a fuction, especially declared with warn_unused_result
928         attribute.
929
930         * DumpRenderTree/efl/ImageDiff.cpp:
931         (printImage):
932
933 2012-03-07  Kangil Han  <kangil.han@samsung.com>
934
935         [DRT] Remove PlainTextController implementations.
936         https://bugs.webkit.org/show_bug.cgi?id=79959
937
938         Reviewed by Hajime Morita.
939
940         PlainTextController usages in existing tests have been
941         replaced by internals API by bug 78570.
942         So this patch will remove PlainTextController implementations
943         to avoid further usage in new tests.
944
945         * DumpRenderTree/DumpRenderTree.gypi:
946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
947         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
948         * DumpRenderTree/chromium/PlainTextController.h: Removed.
949         * DumpRenderTree/chromium/TestShell.cpp:
950         (TestShell::TestShell):
951         (TestShell::bindJSObjectsToWindow):
952         * DumpRenderTree/chromium/TestShell.h:
953         (TestShell):
954         * DumpRenderTree/gtk/DumpRenderTree.cpp:
955         (webViewWindowObjectCleared):
956         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
957         * DumpRenderTree/gtk/PlainTextController.h: Removed.
958         * DumpRenderTree/mac/FrameLoadDelegate.mm:
959         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
960         * DumpRenderTree/mac/PlainTextController.h: Removed.
961         * DumpRenderTree/mac/PlainTextController.mm: Removed.
962         * DumpRenderTree/qt/DumpRenderTree.pro:
963         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
964         (WebCore::DumpRenderTree::DumpRenderTree):
965         (WebCore::DumpRenderTree::initJSObjects):
966         * DumpRenderTree/qt/DumpRenderTreeQt.h:
967         (DumpRenderTree):
968         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
969         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
970         * GNUmakefile.am:
971
972 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
973
974         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
975         https://bugs.webkit.org/show_bug.cgi?id=80137
976
977         Reviewed by Eric Seidel.
978
979         Adds implementation LayoutTestController's setPopupBlockingEnabled.
980         To pass popup-blocking-click-in-iframe.html EventSender should not
981         repeat click events in idler's function. EventSender allows to
982         asynchronously send click event through ecore_idler_add.
983         This event will be called repeatedly as long as it return true.
984         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
985
986         * DumpRenderTree/efl/EventSender.cpp:
987         (sendMouseEvent): Changed return value from bool to void because it always returns true.
988         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
989         (mouseDownCallback): Remove unnecessary checking of return value.
990         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
991         (LayoutTestController::setPopupBlockingEnabled):
992
993 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
994
995         rebaseline_chromium_webkit_tests is obsolete and should be removed
996         https://bugs.webkit.org/show_bug.cgi?id=80347
997
998         Reviewed by Tony Chang.
999
1000         * Scripts/rebaseline-chromium-webkit-tests: Removed.
1001         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
1002         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
1003
1004 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
1005
1006         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
1007         https://bugs.webkit.org/show_bug.cgi?id=80468
1008
1009         Unreviewed, build fix.
1010
1011         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
1012
1013         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1014         (Lighttpd._prepare_config):
1015
1016 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
1017
1018         remove chromium_gpu ports
1019         https://bugs.webkit.org/show_bug.cgi?id=80345
1020
1021         Reviewed by Ojan Vafai.
1022
1023         This change leaves in the 'graphics_type' distinction in the
1024         test_expectations; removing that will require more updates and a
1025         pass over test_expectations.txt, so I'm separating that out.
1026
1027         * Scripts/webkitpy/layout_tests/port/builders.py:
1028         * Scripts/webkitpy/layout_tests/port/chromium.py:
1029         (ChromiumPort):
1030         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
1031         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
1032         * Scripts/webkitpy/layout_tests/port/factory.py:
1033         (PortFactory):
1034         (PortFactory.get):
1035         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1036         (FactoryTest.test_qt):
1037         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1038         (TestRebaseline.test_rebaseline_expectations):
1039
1040 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1041
1042         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
1043         https://bugs.webkit.org/show_bug.cgi?id=80282
1044
1045         Reviewed by Antonio Gomes.
1046
1047         Remove transitive library dependencies; they are especially
1048         dangerous when one ends up linking against WTF, JSC and then WTF
1049         again, since some symbols will not be defined.
1050
1051         Passing --no-copy-dt-needed-entries and --as-needed to the linker
1052         (which some recent Linux distros do by default) makes the issue
1053         even more evident.
1054
1055         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
1056         as the other libraries have the needed symbols. Explicitly link
1057         against fontconfig.
1058
1059 2012-03-06  Dean Jackson  <dino@apple.com>
1060
1061         filter-build-webkit needs more filters
1062         https://bugs.webkit.org/show_bug.cgi?id=80440
1063
1064         Reviewed by Joseph Pecoraro.
1065
1066         Added as many missing filters as I could find for Apple
1067         builds. Plus a few minor style updates.
1068
1069         * Scripts/filter-build-webkit:
1070         (printLine):
1071
1072 2012-03-06  Ojan Vafai  <ojan@chromium.org>
1073
1074         Copying old baselines throws an error if the new directory doesn't exist
1075         https://bugs.webkit.org/show_bug.cgi?id=80443
1076
1077         Reviewed by Adam Barth.
1078
1079         Existing tests cover the new code with the fix to filesystem_mock.
1080
1081         * Scripts/webkitpy/common/system/filesystem_mock.py:
1082         (MockFileSystem.copyfile):
1083         Fix the mock to better match python's copyfile semantics.
1084
1085         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1086         (Rebaseliner._create_html_baseline_files):
1087         * Scripts/webkitpy/tool/commands/rebaseline.py:
1088         (RebaselineTest._copy_existing_baseline):
1089
1090 2012-03-05  Ojan Vafai  <ojan@chromium.org>
1091
1092         Add a mechanism to rebaseline new ports
1093         https://bugs.webkit.org/show_bug.cgi?id=80355
1094
1095         Reviewed by Adam Barth.
1096
1097         For a test that's only failing on a new port, we want
1098         to first copy the existing result into the location for the
1099         port it's replacing in order to not break that port.
1100
1101         For example, bringing up the chromium-lion port, if we just
1102         stick the results in the chromium-mac directory, the snow leopard
1103         will start failing. Instead, we first copy the existing result
1104         to the chromium-mac-snowleopard directory.
1105
1106         * Scripts/webkitpy/layout_tests/port/builders.py:
1107         (builder_path_for_port_name):
1108         (fallback_port_name_for_new_port):
1109         * Scripts/webkitpy/tool/commands/rebaseline.py:
1110         (RebaselineTest):
1111         (RebaselineTest._copy_existing_baseline):
1112         (RebaselineTest._rebaseline_test):
1113         (RebaselineTest.execute):
1114         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1115         (TestRebaseline.test_rebaseline_test):
1116         (TestRebaseline):
1117         (TestRebaseline.test_rebaseline_and_copy_test):
1118         (test_rebaseline_and_copy_test_no_existing_result):
1119         (test_rebaseline_and_copy_test_with_lion_result):
1120         (test_rebaseline_and_copy_no_overwrite_test):
1121         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1122         (GardeningHTTPRequestHandler.rebaseline):
1123         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1124         (GardeningServerTest.test_rebaseline):
1125         (GardeningServerTest):
1126         (GardeningServerTest.test_rebaseline_new_port):
1127
1128 2012-03-06  Beth Dakin  <bdakin@apple.com>
1129
1130         https://bugs.webkit.org/show_bug.cgi?id=80351
1131         InlineTextBox is using the wrong origin when calling 
1132         addRelevantRepaintedObject
1133         -and corresponding-
1134         <rdar://problem/10970221>
1135
1136         Reviewed by Sam Weinig.
1137
1138         This test has actually been broken since revision 109273. This change makes 
1139         the test pass again, and it makes it specifically exercise the fix for this 
1140         bug.
1141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1143         (TestWebKitAPI::TEST):
1144
1145         Adjust comments in the other tests to reflect the API changes from 109273.
1146         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1149         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
1150         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1151         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
1152         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1153         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
1154         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
1155
1156 2012-03-06  Hans Wennborg  <hans@chromium.org>
1157
1158         Speech JavaScript API: add SpeechRecognitionError
1159         https://bugs.webkit.org/show_bug.cgi?id=80410
1160
1161         Chromium: enable the runtime flag for scripted speech so we can run
1162         the layout tests for it.
1163
1164         Reviewed by Adam Barth.
1165
1166         * DumpRenderTree/chromium/TestShell.cpp:
1167         (TestShell::TestShell):
1168
1169 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
1170
1171         Enable universal newlines in chromium android layout test runner
1172         https://bugs.webkit.org/show_bug.cgi?id=80418
1173
1174         Reviewed by Adam Barth.
1175
1176         The Chromium Android layout test runner uses the 'adb' program to
1177         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
1178         output lines from the test runner, while the test expectation files are
1179         written with LF ('\n') delimiters. This causes the results to have
1180         spurious whitespace differences, making them more difficult to
1181         interpret.
1182
1183         The fix is to enable universal newlines for the DumpRenderTree pipe,
1184         causing the output to only contain LF newlines like on other platforms.
1185
1186         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1187         (ChromiumAndroidDriver._start):
1188
1189 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1190
1191         [Qt] Revert r109900, it was completly busted
1192
1193         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
1194
1195         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
1196         of manual define checks.
1197
1198         Reviewed by Ossy.
1199
1200         * DumpRenderTree/qt/DumpRenderTree.pro:
1201         * QtTestBrowser/QtTestBrowser.pro:
1202         * WebKitTestRunner/InjectedBundle/Target.pri:
1203         * qmake/mkspecs/features/features.prf:
1204
1205 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1206
1207         [Qt] Use config test to determine if the compiler supports -MD
1208
1209         We used to assume that unix systems building against Qt5 would have
1210         a compiler that supported -MD. Although this was usually the case,
1211         we failed to take into account broken tools for distributed builds
1212         (e.g. teambuilder or icecream) which would end up producing .d files
1213         in the root of the build dir instead of along-side the object file.
1214
1215         Now that we use a config-test to determine the support, we'll capture
1216         those cases, unless distributed builds are enabled after the initial
1217         build-webkit run.
1218
1219         Reviewed by Csaba Osztrogonác.
1220
1221         * Tools.pro:
1222         * qmake/config.tests/gccdepends/empty.cpp: Added.
1223         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1224         * qmake/mkspecs/features/default_pre.prf:
1225         * qmake/mkspecs/features/features.prf:
1226         * qmake/mkspecs/features/unix/default_pre.prf:
1227         * qmake/sync.profile:
1228
1229 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1230
1231         REGRESSION(r109294): It broke the unittest of master.cfg
1232         https://bugs.webkit.org/show_bug.cgi?id=80253
1233
1234         Reviewed by Tor Arne Vestbø.
1235
1236         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
1237         (BuildBotConfigLoader._create_mock_passwords_dict):
1238         (BuildBotConfigLoader._mock_open):
1239         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
1240         (BuildBotConfigLoader.load_config):
1241
1242 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1243
1244         Qt API test buildstep throws exception after buildmaster update
1245         https://bugs.webkit.org/show_bug.cgi?id=80249
1246
1247         This patch based on Peter Gal's work.
1248
1249         Reviewed by Csaba Osztrogonác.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1252         (RunQtAPITests):
1253         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
1254
1255 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1256
1257         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
1258
1259         Reviewed by Simon Hausmann.
1260         Reviewed by Ossy.
1261
1262         * DumpRenderTree/qt/DumpRenderTree.pro:
1263         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1264         (WebKit::initializeTestFonts):
1265         * QtTestBrowser/QtTestBrowser.pro:
1266         * WebKitTestRunner/InjectedBundle/Target.pri:
1267         * qmake/mkspecs/features/features.prf:
1268
1269 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1270
1271         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
1272
1273         Reviewed by Ossy.
1274
1275         * qmake/mkspecs/features/default_post.prf:
1276
1277 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1278
1279         [Qt] Make sure clean builds are followed by make qmake && make if needed
1280
1281         On non-GNUmake systems we have to run make qmake so that the generated
1282         sources are generated before we run qmake on the target pro files. This
1283         is achieved by using the 'incremental' target.
1284
1285         Reviewed by Ossy.
1286
1287         * Scripts/webkitdirs.pm:
1288         (buildQMakeProjects):
1289
1290 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
1291
1292         DumpRenderTree should support preciseTime()
1293         https://bugs.webkit.org/show_bug.cgi?id=80397
1294
1295         Reviewed by Gavin Barraclough.
1296
1297         * DumpRenderTree/LayoutTestController.cpp:
1298         (preciseTimeCallback):
1299         (LayoutTestController::staticFunctions):
1300
1301 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1302
1303         Unreviewed, rolling out r109887.
1304         http://trac.webkit.org/changeset/109887
1305         https://bugs.webkit.org/show_bug.cgi?id=80402
1306
1307         It broke the build (Requested by Ossy on #webkit).
1308
1309         * DumpRenderTree/qt/DumpRenderTree.pro:
1310         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1311         (WebKit::initializeTestFonts):
1312         * QtTestBrowser/QtTestBrowser.pro:
1313         * WebKitTestRunner/InjectedBundle/Target.pri:
1314         * qmake/mkspecs/features/features.prf:
1315
1316 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1317
1318         Unreviewed, rolling out r109837.
1319         http://trac.webkit.org/changeset/109837
1320         https://bugs.webkit.org/show_bug.cgi?id=80399
1321
1322         breaks Mac Productions builds, too late to try and fix it
1323         tonight (Requested by eseidel on #webkit).
1324
1325         * Scripts/build-webkit:
1326
1327 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1328
1329         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
1330
1331         Reviewed by Simon Hausmann.
1332
1333         * DumpRenderTree/qt/DumpRenderTree.pro:
1334         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1335         (WebKit::initializeTestFonts):
1336         * QtTestBrowser/QtTestBrowser.pro:
1337         * WebKitTestRunner/InjectedBundle/Target.pri:
1338         * qmake/mkspecs/features/features.prf:
1339
1340 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1341
1342         [Qt] Create EWS to build WebKit2
1343         https://bugs.webkit.org/show_bug.cgi?id=80277
1344
1345         Reviewed by Csaba Osztrogonác.
1346
1347         * QueueStatusServer/model/queues.py:
1348         (Queue):
1349         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1350         (QtWK2EWS):
1351         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1352         (EarlyWarningSytemTest.test_builder_ewses):
1353
1354 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1355
1356         Unreviewed, rolling out r109733.
1357         http://trac.webkit.org/changeset/109733
1358         https://bugs.webkit.org/show_bug.cgi?id=80378
1359
1360         It broke Qt5 build system (Requested by Ossy on #webkit).
1361
1362         * Tools.pro:
1363         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1364         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1365         * qmake/mkspecs/features/default_pre.prf:
1366         * qmake/mkspecs/features/features.prf:
1367         * qmake/mkspecs/features/unix/default_pre.prf:
1368         * qmake/sync.profile:
1369
1370 2012-03-05  Eric Seidel  <eric@webkit.org>
1371
1372         Update JavaScriptCore files to use fully-qualified WTF include path
1373         https://bugs.webkit.org/show_bug.cgi?id=79960
1374
1375         Reviewed by Adam Barth.
1376
1377         Build WTF/WTF.xcodeproj by default on Mac.
1378
1379         * Scripts/build-webkit:
1380
1381 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1382
1383         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
1384         https://bugs.webkit.org/show_bug.cgi?id=69590
1385
1386         Reviewed by Ryosuke Niwa.
1387
1388         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
1389         to skip the 'optimize-expectations' step.
1390
1391         * Scripts/webkitpy/tool/commands/rebaseline.py:
1392         (RebaselineExpectations.__init__):
1393         (RebaselineExpectations.execute):
1394         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1395
1396 2012-03-05  Kent Tamura  <tkent@chromium.org>
1397
1398         [Chromium] Add new popup type: PagePopup
1399         https://bugs.webkit.org/show_bug.cgi?id=80106
1400
1401         Reviewed by Darin Fisher.
1402
1403         * DumpRenderTree/chromium/WebViewHost.cpp:
1404         (WebViewHost::createPopupMenu):
1405
1406 2012-03-05  Jessie Berlin  <jberlin@apple.com>
1407
1408         Add myself as a reviewer.
1409
1410         * Scripts/webkitpy/common/config/committers.py:
1411         Also, add my IRC nick so it is easier to find and yell at me.
1412
1413 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
1414
1415         Correctly compute the positions of GestureScroll* events on
1416         Chromium.
1417         https://bugs.webkit.org/show_bug.cgi?id=80075
1418
1419         Reviewed by Adam Barth.
1420
1421         * DumpRenderTree/chromium/EventSender.cpp:
1422         (EventSender::reset):
1423         (EventSender::gestureEvent):
1424         * DumpRenderTree/chromium/EventSender.h:
1425         (EventSender):
1426
1427 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1428
1429         flakiness dashboard doesn't display baselines for virtual tests correctly
1430         https://bugs.webkit.org/show_bug.cgi?id=80341
1431
1432         Reviewed by Ojan Vafai.
1433
1434         If the test is part of a virtual test suite, we need to look for
1435         baselines in the underlying fallback path for the actual test
1436         being run, as well as baselines for the virtual version.
1437
1438         This patch adds code to handle both branches and also pulls the
1439         mapping of the test suites up into a constant.
1440
1441         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1442         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1443         (testLookupVirtualTestSuite):
1444         (testBaseTest):
1445
1446 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1447
1448         Unreviewed, rolling out r109760.
1449         http://trac.webkit.org/changeset/109760
1450         https://bugs.webkit.org/show_bug.cgi?id=80320
1451
1452         Caused many GTK+ tests to crash (Requested by mrobinson on
1453         #webkit).
1454
1455         * gtk/jhbuild.modules:
1456
1457 2012-03-05  Charlie Reis  <creis@chromium.org>
1458
1459         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
1460         https://bugs.webkit.org/show_bug.cgi?id=80057
1461
1462         Reviewed by Darin Fisher.
1463
1464         * DumpRenderTree/chromium/WebViewHost.cpp:
1465         (WebViewHost::createView):
1466         * DumpRenderTree/chromium/WebViewHost.h:
1467         (WebViewHost):
1468
1469 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
1470
1471         [soup] Crash while loading http://www.jusco.cn
1472         https://bugs.webkit.org/show_bug.cgi?id=68238
1473
1474         Reviewed by Philippe Normand.
1475
1476         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
1477         in the jhbuild file.
1478
1479 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1480
1481         Unreviewed, rolling out r109748.
1482         http://trac.webkit.org/changeset/109748
1483         https://bugs.webkit.org/show_bug.cgi?id=80296
1484
1485         Made some tests crash, will fix and recommit (Requested by
1486         noamr on #webkit).
1487
1488         * MiniBrowser/qt/main.cpp:
1489         (main):
1490
1491 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
1492
1493         [GTK] plugins/netscape-plugin-page-cache-works.html fails
1494         https://bugs.webkit.org/show_bug.cgi?id=74409
1495
1496         Reviewed by Martin Robinson.
1497
1498         Add support for overriding the page-cache-for-plugins preference
1499         through DumpRenderTreeSupport.
1500
1501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1502         (booleanFromValue): A helper function to convert a string to boolean.
1503         (LayoutTestController::overridePreference):
1504
1505 2012-03-05  Rob Buis  <rbuis@rim.com>
1506
1507         [BlackBerry] Update Tools/DumpRenderTree
1508         https://bugs.webkit.org/show_bug.cgi?id=80287
1509
1510         Reviewed by Antonio Gomes.
1511
1512         Update so we are sure we can build our implementation of DRT.
1513
1514         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
1515         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
1516         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
1517         (AccessibilityController::addNotificationListener): add missing hook.
1518         (AccessibilityController::removeNotificationListener): add missing hook.
1519         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1520         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
1521         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1522         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
1523         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
1524
1525 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
1526
1527         [Qt] [WK2] Support threaded renderer in WK2
1528         https://bugs.webkit.org/show_bug.cgi?id=76661
1529
1530         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
1531
1532         Reviewed by Kenneth Rohde Christiansen.
1533
1534         * MiniBrowser/qt/main.cpp:
1535         (main):
1536
1537 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1538
1539         Unreviewed. Add myself to committer list.
1540
1541         * Scripts/webkitpy/common/config/committers.py:
1542
1543 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1544
1545         [Qt] Use config test to determine if the compiler supports -MD
1546
1547         We used to assume that unix systems building against Qt5 would have
1548         a compiler that supported -MD. Although this was usually the case,
1549         we failed to take into account broken tools for distributed builds
1550         (e.g. teambuilder or icecream) which would end up producing .d files
1551         in the root of the build dir instead of along-side the object file.
1552
1553         Now that we use a config-test to determine the support, we'll capture
1554         those cases, unless distributed builds are enabled after the initial
1555         build-webkit run.
1556
1557         Reviewed by Csaba Osztrogonác.
1558
1559         * Tools.pro:
1560         * qmake/config.tests/gccdepends/empty.cpp: Added.
1561         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1562         * qmake/mkspecs/features/default_pre.prf:
1563         * qmake/mkspecs/features/features.prf:
1564         * qmake/mkspecs/features/unix/default_pre.prf:
1565         * qmake/sync.profile:
1566
1567 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1568
1569         Qt API test buildstep throws exception after buildmaster update
1570         https://bugs.webkit.org/show_bug.cgi?id=80249
1571
1572         Reviewed by Zoltan Herczeg.
1573
1574         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
1575         (BuildAndTestFactory.__init__):
1576
1577 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1578
1579         [GTK] Unit tests are noisy when run under jhbuild
1580         https://bugs.webkit.org/show_bug.cgi?id=80241
1581
1582         Reviewed by Philippe Normand.
1583
1584         Force the 'memory' backend in GSettings so that each unit
1585         test doesn't produce a warning when it's forced to fall back
1586         to the 'memory' backend.
1587
1588         * Scripts/run-gtk-tests:
1589         (TestRunner.run): Force the 'memory' backend.
1590
1591 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1592
1593         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
1594         https://bugs.webkit.org/show_bug.cgi?id=80235
1595
1596         Reviewed by Philippe Normand.
1597
1598         * Scripts/run-gtk-tests:
1599         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
1600         inspector resources path determination is shared by all tests.
1601
1602 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1603
1604         [GTK] REGRESSION: r108278 broke some tests that expect focus
1605         https://bugs.webkit.org/show_bug.cgi?id=79084
1606
1607         Reviewed by Philippe Normand.
1608
1609         Grab focus when dumping test results and also when sending
1610         events. During the course of testing, the WebView may lose
1611         focus and this seems to snap it back when tests demand it.
1612
1613         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1614         (dump): Grab focus.
1615         * DumpRenderTree/gtk/EventSender.cpp:
1616         (dispatchEvent): Ditto.
1617
1618 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
1619
1620         Unreviewed, Add myself to committer list.
1621         https://bugs.webkit.org/show_bug.cgi?id=80232
1622
1623         * Scripts/webkitpy/common/config/committers.py:
1624
1625 2012-03-04  Anders Carlsson  <andersca@apple.com>
1626
1627         Newer versions of clang fail to compile WebKit.
1628
1629         Fix build.
1630
1631         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1632         (descriptionOfValue):
1633         (AccessibilityUIElement::rowIndexRange):
1634         (AccessibilityUIElement::columnIndexRange):
1635         (AccessibilityUIElement::selectedTextRange):
1636         * DumpRenderTree/mac/EditingDelegate.mm:
1637         (-[DOMRange dump]):
1638         * DumpRenderTree/mac/PolicyDelegate.mm:
1639         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
1640         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1641         (-[NSError _drt_descriptionSuitableForTestResult]):
1642         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1643         (WTR::descriptionOfValue):
1644         (WTR::AccessibilityUIElement::rowIndexRange):
1645         (WTR::AccessibilityUIElement::columnIndexRange):
1646         (WTR::AccessibilityUIElement::selectedTextRange):
1647
1648 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
1649
1650         [Qt] Fix static_libs_as_shared build
1651         https://bugs.webkit.org/show_bug.cgi?id=80214
1652
1653         Reviewed by Tor Arne Vestbø.
1654
1655         * WebKitTestRunner/qt/main.cpp:
1656         (main): Set the correct environment variable for choosing the theme in the
1657         web process.
1658
1659 2012-03-03  Hans Wennborg  <hans@chromium.org>
1660
1661         Implement Speech JavaScript API
1662         https://bugs.webkit.org/show_bug.cgi?id=80019
1663
1664         Reviewed by Adam Barth.
1665
1666         Add ENABLE_SCRIPTED_SPEECH.
1667
1668         * Scripts/build-webkit:
1669         * qmake/mkspecs/features/features.prf:
1670
1671 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
1672
1673         Fix commit queue, remove duplicate entry.
1674
1675         * Scripts/webkitpy/common/config/committers.py:
1676
1677 2012-03-02  Stephen Chenney  <schenney@chromium.org>
1678
1679         Unreviewed, add myself as a committer
1680
1681         * Scripts/webkitpy/common/config/committers.py:
1682
1683 2012-03-02  Ojan Vafai  <ojan@chromium.org>
1684
1685         Add the Chromium Lion canary bot to the flakiness dashboard.
1686         * TestResultServer/static-dashboards/builders.js:
1687
1688 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
1689
1690         links for virtual tests are broken in the flakiness dashboard
1691         https://bugs.webkit.org/show_bug.cgi?id=80180
1692
1693         Reviewed by Ojan Vafai.
1694
1695         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1696         (linkHTMLToOpenWindow):
1697         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1698         (testLinkHTMLToOpenWindow): added.
1699
1700 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1701
1702         [GTK] security/block-test.html baselines differ from mac
1703         https://bugs.webkit.org/show_bug.cgi?id=78343
1704
1705         Reviewed by Martin Robinson.
1706
1707         Improved the FrameLoader error heuristics to match mac behavior a
1708         bit more.
1709
1710         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1711         (pathFromSoupURI): Handle ftp urls the same as http urls.
1712         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
1713
1714 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1715
1716         [Qt][WK2] Fix typo in patch committed in r109575
1717
1718         Unreviewed typo fix.
1719
1720         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1721         (MiniBrowserApplication::notify): Cache the position
1722         in floating point coordinates.
1723
1724 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1725
1726         [Qt][WK2] Infinite loop on history navigation, when panning
1727         https://bugs.webkit.org/show_bug.cgi?id=79119
1728
1729         Reviewed by Simon Hausmann.
1730
1731         Make the touch mocking more robust by creating touch events
1732         directly and sending them synchronously to the browser window.
1733         If the sent touch event was not accepted we propagate the
1734         original mouse event to its target.
1735         This way we make sure we only send either a touch or a mouse
1736         event and do not end up in an infinite loop between our mocking
1737         code and the Qt5 automatic mouse event synthesizing.
1738
1739         * MiniBrowser/qt/BrowserWindow.cpp:
1740         (BrowserWindow::updateVisualMockTouchPoints):
1741         * MiniBrowser/qt/BrowserWindow.h:
1742         (BrowserWindow):
1743         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1744         (touchRectForPosition):
1745         (MiniBrowserApplication::notify):
1746         (MiniBrowserApplication::sendTouchEvent):
1747         * MiniBrowser/qt/MiniBrowserApplication.h:
1748         (MiniBrowserApplication):
1749
1750 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1751
1752         [Qt] Use 'all' as default target when debug_and_release is in effect
1753
1754         When debug_and_release is enabled, in combination with build_all,
1755         qmake will generate an aggregate makefile that calls make on both
1756         the debug and the release makefiles, but with the 'all' target.
1757
1758         In this case we can't use 'first' as the default target, as the
1759         extra targets would then not be run, so we append extra targets
1760         to 'all' instead.
1761
1762         Reviewed by Simon Hausmann.
1763
1764         * qmake/mkspecs/features/default_post.prf:
1765
1766 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1767
1768         [Qt] Make sure activeBuildConfig() returns the right config
1769
1770         Using isActiveConfig fails, as that only checks if the given
1771         argument is in CONFIG, not the order.
1772
1773         Reviewed by Simon Hausmann.
1774
1775         * qmake/mkspecs/features/functions.prf:
1776
1777 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1778
1779         [Qt] Fix tests run with WTR not using QStyle theme
1780         https://bugs.webkit.org/show_bug.cgi?id=80147
1781
1782         Reviewed by Csaba Osztrogonác.
1783
1784         * WebKitTestRunner/qt/main.cpp:
1785         (main): Set environment variable for web process to use QStyle theme.
1786
1787 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1788
1789         Unreviewed, remove debug print call.
1790
1791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1792         (descriptionSuitableForTestResult):
1793
1794 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1795
1796         Updated EventSender to send complete gesture events.
1797         https://bugs.webkit.org/show_bug.cgi?id=80075
1798
1799         Reviewed by Adam Barth.
1800
1801         * DumpRenderTree/chromium/EventSender.cpp:
1802         (EventSender::gestureEvent): set additional parameters in sent events.
1803
1804 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1805
1806         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1807         https://bugs.webkit.org/show_bug.cgi?id=80033
1808
1809         Reviewed by Gustavo Noronha Silva.
1810
1811         GCC 4.7 no longer includes unistd.h from most of the standard C++
1812         header files, so we need to explicitly include it for getcwd().
1813
1814         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1815         not only on Mac, but on all Unix platforms.
1816
1817 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1818
1819         Actually look at the args in driver_input :(.
1820
1821         Unreviewed, build fix.
1822
1823         * Scripts/webkitpy/layout_tests/port/chromium.py:
1824         (ChromiumDriver.run_test):
1825
1826 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1827
1828         Fix typo in flag used to run gpu virtual suites.
1829
1830         Unreviewed, build fix.
1831
1832         * Scripts/webkitpy/layout_tests/port/chromium.py:
1833         (ChromiumPort.virtual_test_suites):
1834
1835 2012-03-01  Adam Barth  <abarth@webkit.org>
1836
1837         Unreviewed, rolling out r109317.
1838         http://trac.webkit.org/changeset/109317
1839
1840         Let's try watchlists again now that we're using a pure git
1841         working copy
1842
1843         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1844         (StyleQueueTask.run):
1845         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1846
1847 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1848
1849         webkitpy: test_run_test_pause_before_testing is failing after r109482
1850         https://bugs.webkit.org/show_bug.cgi?id=80084
1851
1852         Unreviewed, build fix.
1853
1854         Fixes the test string compare to ignore the time spent running
1855         the tests.
1856
1857         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1858         (test_run_test_pause_before_testing):
1859
1860 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1861
1862         nrwt: virtual tests aren't being run
1863         https://bugs.webkit.org/show_bug.cgi?id=80083
1864
1865         Reviewed by Eric Seidel.
1866
1867         If we tried to run all of the tests by default (and
1868         didn't specify any paths), the virtual tests weren't
1869         picked up.
1870
1871         * Scripts/webkitpy/layout_tests/port/base.py:
1872         (Port._virtual_tests):
1873         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1874         (PortTest.test_tests):
1875         * Scripts/webkitpy/layout_tests/port/test.py:
1876         (TestPort.virtual_test_suites):
1877
1878 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1879
1880         run-perf-tests should report the test runtime
1881         https://bugs.webkit.org/show_bug.cgi?id=80078
1882
1883         Reviewed by Hajime Morita.
1884
1885         Record and output the aggreated test run time.
1886
1887         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1888         (PerfTestsRunner._run_single_test):
1889
1890 2012-03-01  Michael Nordman  <michaeln@google.com>
1891
1892         [chromium] Use webkit_support to create session storage namespaces in DRT.
1893         https://bugs.webkit.org/show_bug.cgi?id=79933
1894
1895         Reviewed by Tony Chang.
1896
1897         * DumpRenderTree/chromium/WebViewHost.cpp:
1898         (WebViewHost::createSessionStorageNamespace):
1899
1900 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1901
1902         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1903         https://bugs.webkit.org/show_bug.cgi?id=80048
1904
1905         Reviewed by Adam Barth.
1906
1907         * Scripts/webkitpy/layout_tests/port/base.py:
1908         (Port.test_isfile):
1909         (Port.test_isdir):
1910         (Port):
1911         (Port.test_exists):
1912         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1913         (PortTest.test_test_exists):
1914         (PortTest):
1915         (PortTest.test_test_isfile):
1916         (PortTest.test_test_isdir):
1917         * Scripts/webkitpy/layout_tests/port/test.py:
1918         (TestPort.virtual_test_suites):
1919         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1920         (MainTest.test_virtual):
1921
1922 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1923
1924         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1925         https://bugs.webkit.org/show_bug.cgi?id=80031
1926
1927         Reviewed by Gustavo Noronha Silva.
1928
1929         Only build the libTestRunnerInjectedBundle.la convenience library when
1930         ENABLE_WEBKIT2 is defined.
1931
1932         * WebKitTestRunner/GNUmakefile.am:
1933
1934 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1935
1936         Unreviewed, second attempt to fix GTK NRWT after r109242.
1937
1938         * Scripts/webkitpy/layout_tests/port/gtk.py:
1939         (GtkDriver._start):
1940
1941 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1942
1943         Unreviewed, GTK NRWT build fix attempt after r109242.
1944
1945         * Scripts/webkitpy/layout_tests/port/gtk.py:
1946         (GtkDriver._start):
1947
1948 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1949
1950         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1951         https://bugs.webkit.org/show_bug.cgi?id=80008
1952
1953         Reviewed by Adam Barth.
1954
1955         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1956         to "preprocess-idls.pl". This patch renames it.
1957
1958         Test: Confirm that run-bindings-tests runs.
1959
1960         * Scripts/webkitpy/bindings/main.py:
1961         (BindingsTests.generate_supplemental_dependency):
1962
1963 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1964
1965         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1966         https://bugs.webkit.org/show_bug.cgi?id=78047
1967
1968         Reviewed by Kenneth Rohde Christiansen.
1969
1970         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1971         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1972         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1973         the event handlers directly, and with the removal of our own dispatching we need to go through
1974         that code path.
1975
1976         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1977         (WTR::PlatformWebView::sendEvent):
1978         (WTR::PlatformWebView::postEvent):
1979
1980 2012-02-29  Adam Barth  <abarth@webkit.org>
1981
1982         Disable watchlist.  It's been spamming CCs.
1983
1984         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1985         (StyleQueueTask.run):
1986         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1987
1988 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1989
1990         need to clone the gpu baselines and expectations into the new "virtual" dir
1991         https://bugs.webkit.org/show_bug.cgi?id=79956
1992
1993         Reviewed by Adam Barth.
1994
1995         * Scripts/webkitpy/layout_tests/port/chromium.py:
1996         (ChromiumPort.virtual_test_suites):
1997
1998 2012-02-29  Mark Rowe  <mrowe@apple.com>
1999
2000         Switch to using json rather than simplejson now that the master is using Python 2.7.
2001
2002         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2003         (loadBuilderConfig):
2004
2005 2012-02-29  David Levin  <levin@chromium.org>
2006
2007         [chromium] Add the ability to turn off autoresize.
2008         https://bugs.webkit.org/show_bug.cgi?id=77452
2009
2010         Reviewed by Darin Fisher.
2011
2012         * DumpRenderTree/chromium/LayoutTestController.cpp:
2013         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
2014         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
2015         (LayoutTestController::disableAutoResizeMode):  Ditto.
2016         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
2017
2018 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2019
2020         nrwt: make --print trace work with virtual tests
2021         https://bugs.webkit.org/show_bug.cgi?id=79952
2022
2023         Reviewed by Adam Barth.
2024
2025         * Scripts/webkitpy/layout_tests/views/printing.py:
2026         (Printer._print_test_trace):
2027         (Printer._print_baseline):
2028
2029 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
2030
2031         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
2032         https://bugs.webkit.org/show_bug.cgi?id=79849
2033
2034         Reviewed by Beth Dakin.
2035
2036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2037         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
2038
2039 2012-02-29  Lucas Forschler  <lforschler@apple.com>
2040
2041         Removed unused Apple buildslaves from the master configuration
2042         https://bugs.webkit.org/show_bug.cgi?id=79925
2043
2044         Reviewed by Stephanie Lewis.
2045
2046         * BuildSlaveSupport/build.webkit.org-config/config.json:
2047
2048 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2049
2050         nrwt: implement simple 'virtual test suite' support
2051         https://bugs.webkit.org/show_bug.cgi?id=79737
2052
2053         Reviewed by Adam Barth.
2054
2055         Add very basic support for 'virtual test suites' to NRWT:
2056         a virtual suite is a directory that may contain new baselines,
2057         contains a pointer to a "base" directory of tests, and an
2058         optional list of command line arguments to pass to DRT;
2059         it gives us a way to run all of the tests in a given directory
2060         multiple times with multiple (potentially differing) sets of
2061         results and baselines.
2062
2063         This patch implements the support needed for this feature, and
2064         some basic tests, but no actual port will use the feature yet.
2065
2066         This is probably the simplest implementation possible - the
2067         list of virtual suites will be hard-coded into the port's
2068         implementation. One can imagine a more data-driven approach
2069         where the suite instructions are stored in a manifest file
2070         either in LayoutTests (all suites in one file), or per-port,
2071         or per-directory. If this feature ends up being useful we
2072         should probably add something like that so people don't have
2073         to hunt around in the code to add suites.
2074
2075         * Scripts/webkitpy/layout_tests/port/base.py:
2076         (Port.__init__):
2077         (Port.expected_filename):
2078         (Port.tests):
2079         (Port):
2080         (Port._real_tests):
2081         (Port._driver_class):
2082         (Port.virtual_test_suites):
2083         (Port.virtual_suite):
2084         (Port.virtual_suite.VirtualTestSuite):
2085         (Port.virtual_suite.VirtualTestSuite.__init__):
2086         (Port.virtual_suite.VirtualTestSuite.__repr__):
2087         (Port.populated_virtual_test_suites):
2088         (Port._virtual_tests):
2089         (Port.lookup_virtual_test_base):
2090         (Port.lookup_virtual_test_args):
2091         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2092         (PortTest.test_find_with_skipped_directories):
2093         * Scripts/webkitpy/layout_tests/port/driver.py:
2094         (DriverInput.__init__):
2095         (DriverProxy.run_test):
2096         * Scripts/webkitpy/layout_tests/port/test.py:
2097         (TestPort.virtual_test_suites):
2098         (TestDriver.run_test):
2099         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2100         (MainTest.test_all):
2101         (MainTest.test_virtual):
2102
2103 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2104
2105         nrwt: support more than two drivers in DriverProxy
2106         https://bugs.webkit.org/show_bug.cgi?id=79736
2107
2108         Reviewed by Adam Barth.
2109
2110         Now that we can support per-test command lines for
2111         Drivers, modify DriverProxy to keep a map of running
2112         drivers for each needed command-line; this will allow
2113         us to transparently maintain a pool of appropriately
2114         configured DRTs without having to constantly start and stop
2115         them.
2116
2117         Note that this potentially raises a garbage collection
2118         problem - the number of running DRTs will grow with the
2119         number of different sets of command line args. For now
2120         this is no worse than the current code - if you're running
2121         with pixel tests, you will only need one DRT per worker,
2122         and if you aren't, you'll need two (one for text-only tests,
2123         and one for reftests).
2124
2125         An alternative would be to only ever have one running driver,
2126         and restart the driver as the command line changes, but this
2127         might (?) slow down execution in the text-only case - we
2128         should benchmark this because it would be simpler and possibly
2129         allow us to eliminate DriverProxy altogether.
2130
2131         * Scripts/webkitpy/layout_tests/port/driver.py:
2132         (DriverProxy.__init__):
2133         (DriverProxy):
2134         (DriverProxy._make_driver):
2135         (DriverProxy.run_test):
2136         (DriverProxy.has_crashed):
2137         (DriverProxy.stop):
2138         (DriverProxy.cmd_line):
2139         (DriverProxy._cmd_line_as_key):
2140
2141 2012-02-29  Adrienne Walker  <enne@google.com>
2142
2143         Unreviewed, add myself as a reviewer
2144
2145         * Scripts/webkitpy/common/config/committers.py:
2146
2147 2012-02-29  Greg Billock  <gbillock@google.com>
2148
2149         Add more tests for web intents
2150         https://bugs.webkit.org/show_bug.cgi?id=79527
2151
2152         Reviewed by Adam Barth.
2153
2154         * DumpRenderTree/chromium/LayoutTestController.cpp:
2155         (LayoutTestController::LayoutTestController):
2156         (LayoutTestController::sendWebIntentResponse):
2157         * DumpRenderTree/chromium/LayoutTestController.h:
2158         (LayoutTestController):
2159         * DumpRenderTree/chromium/WebViewHost.h:
2160         (WebViewHost):
2161         (WebViewHost::currentIntentRequest):
2162
2163 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2164
2165         nrwt: port/Driver needs to support per-test command line args
2166         https://bugs.webkit.org/show_bug.cgi?id=79733
2167
2168         Reviewed by Adam Barth.
2169
2170         As part of removing the 'gpu' configurations and adding support
2171         for 'virtual test suites', the Driver classes need to support
2172         per-test command lines (since different tests will need to be
2173         run with different command line options).
2174
2175         The per-test args are not yet used, so this change should have
2176         no visible effects and need no additional testing.
2177
2178         * Scripts/webkitpy/layout_tests/port/base.py:
2179         (Port.driver_cmd_line):
2180         * Scripts/webkitpy/layout_tests/port/chromium.py:
2181         (ChromiumDriver.cmd_line):
2182         (ChromiumDriver._start):
2183         (ChromiumDriver.start):
2184         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2185         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
2186         (ChromiumDriverTest):
2187         (ChromiumDriverTest.test_two_drivers):
2188         * Scripts/webkitpy/layout_tests/port/driver.py:
2189         (Driver.cmd_line):
2190         (DriverProxy.__init__):
2191         (DriverProxy.start):
2192         (DriverProxy.cmd_line):
2193         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2194         (DriverTest.test_virtual_driver_methods):
2195         * Scripts/webkitpy/layout_tests/port/gtk.py:
2196         (GtkDriver.cmd_line):
2197         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2198         * Scripts/webkitpy/layout_tests/port/test.py:
2199         (TestPort._path_to_driver):
2200         (TestDriver.cmd_line):
2201         (TestDriver.start):
2202         * Scripts/webkitpy/layout_tests/port/webkit.py:
2203         (WebKitDriver.cmd_line):
2204         (WebKitDriver._start):
2205         (WebKitDriver.run_test):
2206         (WebKitDriver.start):
2207         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2208         (WebKitDriverTest.test_no_timeout):
2209         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2210         (PerfTestsRunner._run_tests_set):
2211         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2212         (test_run_test_pause_before_testing):
2213
2214 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2215
2216         perftestsrunner can call printer.write() after printer.cleanup()
2217         https://bugs.webkit.org/show_bug.cgi?id=79872
2218
2219         Reviewed by Ryosuke Niwa.
2220
2221         This patch fixes a unittest that was incorrectly calling
2222         PerfTestsRunner.run() twice (which led to a weird state in the
2223         printer object).
2224
2225         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2226         (MainTest.test_run_with_upload_json):
2227
2228 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
2229
2230         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2231         https://bugs.webkit.org/show_bug.cgi?id=76546
2232
2233         Reviewed by Simon Hausmann.
2234
2235         Revert the workaround introduced in r107868 and reintroduce
2236         the qml binding so we can test the code path that we are more
2237         interested in. The reason that it did not work before is that
2238         we don't have an active platform window which we now workaround
2239         by propagating the resize through QWindowSystemInterface.
2240
2241         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2242         (WTR::WrapperWindow::handleStatusChanged):
2243         (WTR::PlatformWebView::resizeTo):
2244
2245 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
2246
2247         [GTK] Small fix for cross compilation to not generate gtkdoc.
2248
2249         Rubber-stamped by Csaba Osztrogonác.
2250
2251         * Scripts/webkitdirs.pm:
2252         (isCrossCompilation):
2253
2254 2012-02-28  Lucas Forschler  <lforschler@apple.com>
2255
2256         Fix a typo in config.json
2257         linx -> linux
2258         
2259         * BuildSlaveSupport/build.webkit.org-config/config.json:
2260
2261 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2262
2263         [Qt] Allow read/write to the WebView.url property
2264         https://bugs.webkit.org/show_bug.cgi?id=77554
2265
2266         Reviewed by Tor Arne Vestbø.
2267
2268         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
2269
2270         * MiniBrowser/qt/qml/BrowserWindow.qml:
2271
2272 2012-02-28  Dan Winship  <danw@gnome.org>
2273
2274         [GTK] make tests explicitly request GSettingsBackendMemory
2275         https://bugs.webkit.org/show_bug.cgi?id=79788
2276
2277         Reviewed by Martin Robinson.
2278
2279         Explicitly request the fallback memory-based GSettings backend; if
2280         other backends are available then we don't want to use them,
2281         because they would make tests depend on the user's preferences.
2282         And if other backends aren't available, we don't need glib to
2283         print a warning about that fact.
2284
2285         * Scripts/webkitpy/layout_tests/port/gtk.py:
2286         (GtkPort.setup_environ_for_server):
2287
2288 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2289
2290         Unreviewed, rolling out r109110.
2291         http://trac.webkit.org/changeset/109110
2292         https://bugs.webkit.org/show_bug.cgi?id=79806
2293
2294         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
2295         (Requested by aroben on #webkit).
2296
2297         * Scripts/webkitpy/common/checkout/changelog.py:
2298         (parse_bug_id):
2299         (parse_bug_id_from_changelog):
2300         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2301         * Scripts/webkitpy/common/config/urls.py:
2302
2303 2012-02-28  Adam Roben  <aroben@webkit.org>
2304
2305         Add my new email address
2306
2307         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
2308
2309         Reviewed by Anders Carlsson.
2310
2311         * Scripts/webkitpy/common/config/committers.py:
2312
2313 2012-02-28  Adam Roben  <aroben@apple.com>
2314
2315         Teach webkitpy about wkb.ug URLs
2316
2317         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
2318         use wkb.ug URLs
2319
2320         Reviewed by Anders Carlsson.
2321
2322         * Scripts/webkitpy/common/checkout/changelog.py:
2323         (parse_bug_id):
2324         (parse_bug_id_from_changelog):
2325         Fall back to the tiny URL format if neither the short nor long URL formats work.
2326
2327         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2328         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
2329
2330         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
2331         wkb.ug URLs.
2332
2333 2012-02-28  János Badics  <dicska@gmail.com>
2334
2335         [Qt] build-webkit does not detect the number of CPUs
2336         https://bugs.webkit.org/show_bug.cgi?id=76445
2337
2338         Based on Seo Sanghyeon's work (modification:
2339         Automatically determine the number of CPUs for make
2340         only if -j make argument haven't already been specified.)
2341
2342         Reviewed by Csaba Osztrogonác.
2343
2344         * Scripts/webkitdirs.pm:
2345         (buildQMakeProjects):
2346
2347 2012-02-28  Kent Tamura  <tkent@chromium.org>
2348
2349         Update a pattern for forms files of watchlist
2350         https://bugs.webkit.org/show_bug.cgi?id=79767
2351
2352         Reviewed by Kentaro Hara.
2353
2354         * Scripts/webkitpy/common/config/watchlist:
2355         Catches the following files with the "Forms" pattern.
2356         - HTMLDatListElement.*
2357         - HTMLKeygenElement.*
2358         - HTMLLegendElement.*
2359         - HTMLOutputElement.*
2360         - FormAssociatedElement.*
2361         - SliderThumbElement.*
2362         - TextControlInnerElements.*
2363         - RenderFileUploadControl.*
2364
2365 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2366
2367         Unreviewed, rolling out r109041.
2368         http://trac.webkit.org/changeset/109041
2369         https://bugs.webkit.org/show_bug.cgi?id=79741
2370
2371         Broke Chromium Win build (Requested by bashi on #webkit).
2372
2373         * DumpRenderTree/chromium/LayoutTestController.cpp:
2374         (LayoutTestController::LayoutTestController):
2375         * DumpRenderTree/chromium/LayoutTestController.h:
2376         (LayoutTestController):
2377         * DumpRenderTree/chromium/WebViewHost.h:
2378
2379 2012-02-27  James Robinson  <jamesr@chromium.org>
2380
2381         [chromium] Remove media tests from ChromiumGpu configurations
2382         https://bugs.webkit.org/show_bug.cgi?id=79720
2383
2384         Reviewed by Adam Barth.
2385
2386         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
2387         composited playback path via tests in the compositing/ directory.
2388
2389         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2390         (_default_tests_paths):
2391         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2392         (ChromiumGpuTest.test_default_tests_paths):
2393         (ChromiumGpuTest.test_test_files):
2394
2395 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
2396
2397         nrwt: log multiline stderr/crash output properly
2398         https://bugs.webkit.org/show_bug.cgi?id=79722
2399
2400         Reviewed by Adam Barth.
2401
2402         This cleans up some nits in the log output to make things
2403         slightly easier to read (every line gets timestamped, etc.).
2404
2405         Also tweaks the log message for pixel hash mismatches.
2406
2407         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2408         (SingleTestRunner._handle_error):
2409         (SingleTestRunner._compare_image):
2410
2411 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2412
2413         Touch the master.cfg to force a reconfig.
2414
2415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2416         (BuildAndTestLeaksFactory):
2417         (NewBuildAndTestFactory):
2418
2419 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
2420
2421         [BlackBerry] Upstream BlackBerry API web page related files
2422         https://bugs.webkit.org/show_bug.cgi?id=74380
2423
2424         Reviewed by Antonio Gomes.
2425
2426         Adapt to the removing of WebPage::mainFrame(), use
2427         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
2428
2429         No new tests as this patch doesn't change behavior.
2430
2431         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2432         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2433         (BlackBerry::WebKit::DumpRenderTree::runTests):
2434
2435 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Add Windows and Linux Chromium perf bots
2438         https://bugs.webkit.org/show_bug.cgi?id=79418
2439
2440         Reviewed by Tony Chang.
2441
2442         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
2443         the dedicated perf bot slave (uses the same hardware).
2444
2445         * BuildSlaveSupport/build.webkit.org-config/config.json:
2446
2447 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2448
2449         Undefined variable 'current' when running chromium_android.py
2450         https://bugs.webkit.org/show_bug.cgi?id=79696
2451
2452         Reviewed by Adam Barth.
2453
2454         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2455         (ChromiumAndroidDriver._read_prompt):
2456
2457 2012-02-27  Greg Billock  <gbillock@google.com>
2458
2459         Add more tests for web intents
2460         https://bugs.webkit.org/show_bug.cgi?id=79527
2461
2462         Reviewed by Adam Barth.
2463
2464         * DumpRenderTree/chromium/LayoutTestController.cpp:
2465         (LayoutTestController::LayoutTestController):
2466         (LayoutTestController::sendWebIntentResponse):
2467         * DumpRenderTree/chromium/LayoutTestController.h:
2468         (LayoutTestController):
2469         * DumpRenderTree/chromium/WebViewHost.h:
2470         (WebViewHost):
2471         (WebViewHost::currentIntentRequest):
2472
2473 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2474
2475         Chromium-Android layout test script: the adb shell prompt is not always '# '
2476         https://bugs.webkit.org/show_bug.cgi?id=79506
2477
2478         Reviewed by Adam Barth.
2479
2480         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2481         (ChromiumAndroidDriver._start):
2482         (ChromiumAndroidDriver._read_prompt):
2483
2484 2012-02-27  Dan Bernstein  <mitz@apple.com>
2485
2486         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
2487         https://bugs.webkit.org/show_bug.cgi?id=79607
2488
2489         Reviewed by Adele Peterson.
2490
2491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2492         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
2493         (TestWebKitAPI::AcceptsFirstMouse::url):
2494         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
2495         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2496         (TestWebKitAPI::TEST_F):
2497         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
2498
2499 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2500
2501         Unreviewed. Fix make distcheck.
2502
2503         * GNUmakefile.am: Fix typo.
2504
2505 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2506
2507         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
2508
2509         Reviewed by Kenneth Rohde Christiansen..
2510
2511         * qmake/mkspecs/features/features.prf:
2512
2513 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
2514
2515         Add a ChromiumGpuAndroid port.
2516         https://bugs.webkit.org/show_bug.cgi?id=79628
2517
2518         Reviewed by Adam Barth.
2519
2520         Android does have a gpu port, so revert r107697.
2521
2522         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2523         (ChromiumAndroidPort.__init__):
2524         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2525         (ChromiumGpuAndroidPort):
2526         (ChromiumGpuAndroidPort.__init__):
2527         (ChromiumGpuAndroidPort.baseline_search_path):
2528         (ChromiumGpuAndroidPort.default_child_processes):
2529         (ChromiumGpuAndroidPort.tests):
2530         * Scripts/webkitpy/layout_tests/port/factory.py:
2531         (PortFactory):
2532
2533 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2534
2535         Change Build bot with BuildAndTest bot for EFL port.
2536         https://bugs.webkit.org/show_bug.cgi?id=77518
2537
2538         Reviewed by Ryosuke Niwa.
2539
2540         EFL build bot starts to support layout test.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/config.json:
2543         * BuildSlaveSupport/built-product-archive:
2544         (archiveBuiltProduct):
2545         (extractBuiltProduct):
2546         * BuildSlaveSupport/test-result-archive:
2547         (archiveTestResults):
2548         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
2549         (generateBuildSystemFromCMakeProject):
2550
2551 2012-02-24  Darin Fisher  <darin@chromium.org>
2552
2553         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
2554
2555         Reviewed by James Robinson.
2556
2557         * Scripts/webkitpy/common/config/watchlist:
2558
2559 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2560
2561         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
2562         https://bugs.webkit.org/show_bug.cgi?id=79258
2563
2564         Reviewed by Ryosuke Niwa.
2565
2566         Split the fuzzy matching into separate functions so that they
2567         can be sharded and run in parallel.
2568
2569         Also, fix a bug in the svn_blame_regexp that was causing us
2570         to require ChangeLog lines to have at least one space after the
2571         author, making the code require trailing whitespace in the
2572         changelog in some places (this was making my life harder because
2573         I have my text editor set to strip trailing whitespace in python
2574         files, and that was causing test_parse_log_entries_from_changelog() to fail
2575         when the whitespace on line 275 was removed).
2576
2577         * Scripts/webkitpy/common/checkout/changelog.py:
2578         (ChangeLog):
2579         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2580         (test_fuzzy_reviewer_match__none):
2581         (test_fuzzy_reviewer_match_adam_barth):
2582         (test_fuzzy_reviewer_match_darin_adler_et_al):
2583         (test_fuzzy_reviewer_match_dimitri_glazkov):
2584         (test_fuzzy_reviewer_match_george_staikos):
2585         (test_fuzzy_reviewer_match_mark_rowe):
2586
2587 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2588
2589         webkitpy: committers_unittest fuzzy matching is really slow
2590         https://bugs.webkit.org/show_bug.cgi?id=79179
2591
2592         Reviewed by Ryosuke Niwa.
2593
2594         Break the fuzzy matching tests into individual routines for
2595         each contributor so that the intent is a little clearer, so
2596         that it's easier to test individual names (and identify
2597         duplicate tests), and so that we can eventually run
2598         them in parallel.
2599
2600         Also, mark most of them as 'integration' tests so that they
2601         can be skipped if we want to go fast (we leave a few as
2602         regular tests for functional coverage).
2603
2604         * Scripts/webkitpy/common/config/committers_unittest.py:
2605         (CommittersTest):
2606         (CommittersTest.test_contributors_by_fuzzy_match):
2607         (CommittersTest.integration_test_contributors__none):
2608         (CommittersTest.integration_test_contributors__none_2):
2609         (CommittersTest.integration_test_contributors__none_3):
2610         (CommittersTest.integration_test_contributors_ada_chan):
2611         (CommittersTest.integration_test_contributors_adele_peterson):
2612         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
2613         (CommittersTest.integration_test_contributors_alice_liu):
2614         (CommittersTest.integration_test_contributors_alp_toker):
2615         (CommittersTest.integration_test_contributors_anders_carlsson):
2616         (CommittersTest.integration_test_contributors_antti_koivisto):
2617         (CommittersTest.integration_test_contributors_beth_dakin):
2618         (CommittersTest.integration_test_contributors_brady_eidson):
2619         (CommittersTest.integration_test_contributors_cameron_zwarich):
2620         (CommittersTest.integration_test_contributors_chris_blumenberg):
2621         (CommittersTest.integration_test_contributors_dan_bernstein):
2622         (CommittersTest.integration_test_contributors_dan_bernstein_2):
2623         (CommittersTest.integration_test_contributors_darin_adler):
2624         (CommittersTest.integration_test_contributors_david_harrison):
2625         (CommittersTest.integration_test_contributors_david_harrison_2):
2626         (CommittersTest.integration_test_contributors_david_hyatt):
2627         (CommittersTest.integration_test_contributors_david_kilzer):
2628         (CommittersTest.integration_test_contributors_don_melton):
2629         (CommittersTest.integration_test_contributors_eric_seidel):
2630         (CommittersTest.integration_test_contributors_geoffrey_garen):
2631         (CommittersTest.integration_test_contributors_greg_bolsinga):
2632         (CommittersTest.integration_test_contributors_holger_freyther):
2633         (CommittersTest.integration_test_contributors_jon_sullivan):
2634         (CommittersTest.integration_test_contributors_jon_honeycutt):
2635         (CommittersTest.integration_test_contributors_joseph_pecoraro):
2636         (CommittersTest.integration_test_contributors_ken_kocienda):
2637         (CommittersTest.integration_test_contributors_kenneth_russell):
2638         (CommittersTest.integration_test_contributors_kevin_decker):
2639         (CommittersTest.integration_test_contributors_kevin_mccullough):
2640         (CommittersTest.integration_test_contributors_lars_knoll):
2641         (CommittersTest.integration_test_contributors_lars_weintraub):
2642         (CommittersTest.integration_test_contributors_maciej_stachowiak):
2643         (CommittersTest.integration_test_contributors_mark_rowe):
2644         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
2645         (CommittersTest.integration_test_contributors_oliver_hunt):
2646         (CommittersTest.integration_test_contributors_rniwa):
2647         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
2648         (CommittersTest.integration_test_contributors_steve_falkenburg):
2649         (CommittersTest.integration_test_contributors_sam_weinig):
2650         (CommittersTest.integration_test_contributors_tim_omernick):
2651         (CommittersTest.integration_test_contributors_timothy_hatcher):
2652         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
2653         (CommittersTest.integration_test_contributors_vicki_murley):
2654         (CommittersTest.integration_test_contributors_zack_rusin):
2655
2656 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2657
2658         webkitpy: should autoinstall coverage
2659         https://bugs.webkit.org/show_bug.cgi?id=79535
2660
2661         Reviewed by Eric Seidel.
2662
2663         We should automatically print the coverage report after the run, too.
2664
2665         * Scripts/webkitpy/test/main.py:
2666         (Tester._run_tests):
2667         * Scripts/webkitpy/thirdparty/__init__.py:
2668         (AutoinstallImportHook.find_module):
2669         (AutoinstallImportHook._install_coverage):
2670
2671 2012-02-24  Pablo Flouret  <pablof@motorola.com>
2672
2673         Fix copypasta in build-webkit's --vibration option description
2674         https://bugs.webkit.org/show_bug.cgi?id=79528
2675
2676         Reviewed by Andreas Kling.
2677
2678         * Scripts/build-webkit:
2679
2680 2012-02-24  Antonio Gomes  <agomes@rim.com>
2681
2682         Adding myself to ScrollingCoordinator watchlist
2683         https://bugs.webkit.org/show_bug.cgi?id=79525
2684
2685         Reviewed by Rob Buis.
2686
2687         * Scripts/webkitpy/common/config/watchlist:
2688
2689 2012-02-24  Darin Fisher  <darin@chromium.org>
2690
2691         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
2692
2693         Reviewed by Adam Barth.
2694
2695         * Scripts/webkitpy/common/config/watchlist:
2696
2697 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2698
2699         webkitpy: config_unittest is sensitive to other tests that might've already run
2700         https://bugs.webkit.org/show_bug.cgi?id=79382
2701
2702         Reviewed by Adam Barth.
2703
2704         If another test runs prior to config_unittest and pokes the
2705         cached configuration, the first test in config_unittest might
2706         fail; the tearDown() will then allow subsequent tests to pass.
2707         Clearing the configuration prior to each test makes things
2708         slightly slower but safer.
2709
2710         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2711         (ConfigTest.setUp):
2712
2713 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2714
2715         Use xcrun to find compiler paths for Generate Derived Sources build phase script
2716         <http://webkit.org/b/79512>
2717
2718         Reviewed by Dan Bernstein.
2719
2720         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2721         (Generate Derived Sources): Use xcrun to find the path to the
2722         compiler since that works on both iOS and OS X.
2723
2724 2012-02-24  James Robinson  <jamesr@chromium.org>
2725
2726         Create a watchlist for ScrollingCoordinator changes
2727         https://bugs.webkit.org/show_bug.cgi?id=79511
2728
2729         Reviewed by Anders Carlsson.
2730
2731         * Scripts/webkitpy/common/config/watchlist:
2732
2733 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2734
2735         [EFL][DRT] Implement setValueForUser and setAutofilled.
2736         https://bugs.webkit.org/show_bug.cgi?id=79237
2737
2738         Reviewed by Andreas Kling.
2739
2740         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2741         Those implementations are related with input fields and allow to pass following tests:
2742         fast/forms/onchange-setvalueforuser.html
2743         fast/forms/input-autofilled.html
2744         fast/forms/reset-autofilled.html
2745
2746         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2747         (LayoutTestController::setValueForUser):
2748         (LayoutTestController::setAutofilled):
2749
2750 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2751
2752         [Qt] Allow to use WebCore imagedecoders
2753         https://bugs.webkit.org/show_bug.cgi?id=32410
2754
2755         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2756
2757         Reviewed by Simon Hausmann.
2758
2759         * qmake/mkspecs/features/features.prf:
2760
2761 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2762
2763         [Qt] Add Qt5 way to force 96 DPI for tests
2764         https://bugs.webkit.org/show_bug.cgi?id=79364
2765
2766         Reviewed by Simon Hausmann.
2767
2768         * DumpRenderTree/qt/main.cpp:
2769         (main):
2770         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2771         (WTR::activateFonts):
2772
2773 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2774
2775         [GTK] MiniBrowser should reload the view then the reload button is clicked
2776         https://bugs.webkit.org/show_bug.cgi?id=79472
2777
2778         Reviewed by Philippe Normand.
2779
2780         * MiniBrowser/gtk/BrowserWindow.c:
2781         (reloadCallback): Call webkit_web_view_reload().
2782         (browser_window_init): Connect reload item clicked even to
2783         reloadCallback instead of activateUriEntryCallback.
2784
2785 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2786
2787         Add performance tests for DOM attribute getters and setters
2788         https://bugs.webkit.org/show_bug.cgi?id=79208
2789
2790         Reviewed by Ryosuke Niwa.
2791
2792         We want to allow perf tests to output info messages
2793         that do not affect the test results. To accomplish this,
2794         this patch modifies perftestsrunner.py so that it ignores
2795         a line that starts from "Info:".
2796
2797         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2798         (PerfTestsRunner):
2799
2800 2012-02-24  Andrew Lo  <anlo@rim.com>
2801
2802         [BlackBerry] Enable requestAnimationFrame
2803         https://bugs.webkit.org/show_bug.cgi?id=79408
2804
2805         Enable requestAnimationFrame for BlackBerry.
2806
2807         Reviewed by Rob Buis.
2808
2809         * Scripts/build-webkit:
2810
2811 2012-02-24  Adam Barth  <abarth@webkit.org>
2812
2813         style-queue tries to apply the patch twice
2814         https://bugs.webkit.org/show_bug.cgi?id=79459
2815
2816         Reviewed by Eric Seidel.
2817
2818         Previously, we applied the patch using both apply-patch and
2819         check-style.  This patch introduces a check-style-local to mirror the
2820         apply-watchlist-local, which operates on the current working diff.
2821
2822         This patch also cleans up some other bugs I found by running the queue
2823         locally for a while.  The queue still prints out a slightly
2824         less-than-ideal message on the bugs when it find an error, but it's ok
2825         for now.  We'll need to iterate a bit.
2826
2827         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2828         (StyleQueueTask.validate):
2829         (StyleQueueTask._check_style):
2830         * Scripts/webkitpy/tool/commands/download.py:
2831         (CheckStyleLocal):
2832         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2833         (EarlyWarningSytemTest._default_expected_stderr):
2834         (EarlyWarningSytemTest._test_testing_ews):
2835         * Scripts/webkitpy/tool/commands/queues.py:
2836         (AbstractReviewQueue.handle_script_error):
2837         (StyleQueue.review_patch):
2838         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2839         * Scripts/webkitpy/tool/commands/queuestest.py:
2840         (QueuesTest.assert_queue_outputs):
2841
2842 2012-02-23  Adam Barth  <abarth@webkit.org>
2843
2844         should_proceed_with_work_item is unused and can be removed
2845         https://bugs.webkit.org/show_bug.cgi?id=79416
2846
2847         Reviewed by Eric Seidel.
2848
2849         We used to use this function to check whether the tree is red.  Now, we
2850         don't use external measures of whether to proceed with work items.
2851         Instead, we analyze them with the idea in mind that the tree might be
2852         red.
2853
2854         * Scripts/webkitpy/tool/bot/queueengine.py:
2855         (QueueEngineDelegate.next_work_item):
2856         (QueueEngine.run):
2857         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2858         (LoggingDelegate):
2859         (LoggingDelegate.next_work_item):
2860         (RaisingDelegate.process_work_item):
2861         (QueueEngineTest.test_terminating_error):
2862         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2863         (AbstractEarlyWarningSystem.__init__):
2864         * Scripts/webkitpy/tool/commands/queues.py:
2865         (AbstractQueue.next_work_item):
2866         (FeederQueue.next_work_item):
2867         (CommitQueue.next_work_item):
2868         (AbstractReviewQueue.next_work_item):
2869         (StyleQueue.__init__):
2870         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2871         (FeederQueueTest.test_feeder_queue):
2872         (CommitQueueTest.test_commit_queue):
2873         (test_commit_queue_failure):
2874         (test_commit_queue_failure_with_failing_tests):
2875         (test_rollout):
2876         (test_rollout_lands):
2877         (StyleQueueTest.test_style_queue_with_style_exception):
2878         (test_style_queue_with_watch_list_exception):
2879         * Scripts/webkitpy/tool/commands/queuestest.py:
2880         (QueuesTest.assert_queue_outputs):
2881         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2882         (SheriffBot.next_work_item):
2883
2884 2012-02-23  Adrienne Walker  <enne@google.com>
2885
2886         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2887
2888         * Scripts/webkitpy/common/config/committers.py:
2889
2890 2012-02-23  Adam Barth  <abarth@webkit.org>
2891
2892         style-queue logs bogus messages to the QueueStatusServer
2893         https://bugs.webkit.org/show_bug.cgi?id=79424
2894
2895         Reviewed by Eric Seidel.
2896
2897         Copy/paste error.
2898
2899         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2900         (StyleQueueTask._check_style):
2901         (StyleQueueTask._apply_watch_list):
2902         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2903
2904 2012-02-23  Eric Seidel  <eric@webkit.org>
2905
2906         Use self._filesystem in more places in the SCM classes
2907         https://bugs.webkit.org/show_bug.cgi?id=79415
2908
2909         Reviewed by Adam Barth.
2910
2911         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2912         (SCMDetectorTest.test_detect_scm_system):
2913         * Scripts/webkitpy/common/checkout/scm/git.py:
2914         (Git.find_checkout_root):
2915         (Git.to_object_name):
2916         * Scripts/webkitpy/common/checkout/scm/scm.py:
2917         (SCM.__init__):
2918         (SCM.in_working_directory):
2919         * Scripts/webkitpy/common/checkout/scm/svn.py:
2920         (SVN.find_uuid):
2921         (SVN.find_checkout_root):
2922
2923 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2924
2925         Unreviewed, rolling out r108685.
2926         http://trac.webkit.org/changeset/108685
2927         https://bugs.webkit.org/show_bug.cgi?id=79414
2928
2929         Broke Chromium builds (Requested by enne on #webkit).
2930
2931         * qmake/mkspecs/features/features.prf:
2932
2933 2012-02-23  Adam Barth  <abarth@webkit.org>
2934
2935         style-queue shouldn't spam bugs if it fails to update its working copy
2936         https://bugs.webkit.org/show_bug.cgi?id=79412
2937
2938         Reviewed by Eric Seidel.
2939
2940         This patch moves style-queue over to the new PatchAnalysisTask
2941         infrastructure, which is smarter about retrying patches when update
2942         fails.
2943
2944         * Scripts/webkitpy/common/system/executive_mock.py:
2945         (MockExecutive.run_and_throw_if_fail):
2946         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2947         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2948         (UnableToApplyPatch):
2949         (UnableToApplyPatch.__init__):
2950         (PatchAnalysisTask.__init__):
2951         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2952         (StyleQueueTaskDelegate):
2953         (StyleQueueTaskDelegate.parent_command):
2954         (StyleQueueTask):
2955         (StyleQueueTask.validate):
2956         (StyleQueueTask._check_style):
2957         (StyleQueueTask._apply_watch_list):
2958         (StyleQueueTask.run):
2959         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2960         * Scripts/webkitpy/tool/commands/queues.py:
2961         (StyleQueue):
2962         (StyleQueue.should_proceed_with_work_item):
2963         (StyleQueue.review_patch):
2964         (StyleQueue.run_command):
2965         (StyleQueue.command_passed):
2966         (StyleQueue.command_failed):
2967         (StyleQueue.expected_failures):
2968         (StyleQueue.refetch_patch):
2969         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2970         (StyleQueueTest.test_style_queue_with_style_exception):
2971         (test_style_queue_with_watch_list_exception):
2972
2973 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2974
2975         [Qt] Allow to use WebCore imagedecoders
2976         https://bugs.webkit.org/show_bug.cgi?id=32410
2977
2978         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2979
2980         Reviewed by Simon Hausmann.
2981
2982         * qmake/mkspecs/features/features.prf:
2983
2984 2012-02-23  Eric Seidel  <eric@webkit.org>
2985
2986         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2987         https://bugs.webkit.org/show_bug.cgi?id=79405
2988
2989         Reviewed by Adam Barth.
2990
2991         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2992         (SCMDetectorTest):
2993         (SCMDetectorTest.test_find_checkout_root):
2994         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2995         (SVNTestRepository.tear_down):
2996
2997 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2998
2999         [Qt][WK2] Implement proxy authentication dialog.
3000         https://bugs.webkit.org/show_bug.cgi?id=79350
3001
3002         Reviewed by Simon Hausmann.
3003
3004         * MiniBrowser/qt/MiniBrowser.qrc:
3005         * MiniBrowser/qt/qml/BrowserWindow.qml:
3006         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
3007
3008 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
3009
3010         [wx] Build fix, add recently added source dirs.
3011
3012         * waf/build/settings.py:
3013
3014 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
3015
3016         [Qt] Add support for touch cancellation
3017         https://bugs.webkit.org/show_bug.cgi?id=79348
3018
3019         Reviewed by Kenneth Rohde Christiansen.
3020
3021         Added straight-forward touch cancellation event sending to Qt WK1 DRT
3022         and WK2 WTR.
3023
3024         * DumpRenderTree/qt/EventSenderQt.cpp:
3025         (EventSender::touchCancel):
3026         (EventSender::cancelTouchPoint):
3027         * DumpRenderTree/qt/EventSenderQt.h:
3028         (EventSender):
3029         * WebKitTestRunner/EventSenderProxy.h:
3030         (EventSenderProxy):
3031         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3032         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3033         (WTR::EventSendingController::touchCancel):
3034         (WTR):
3035         (WTR::EventSendingController::cancelTouchPoint):
3036         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3037         (EventSendingController):
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3040         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3041         (WTR::EventSenderProxy::touchCancel):
3042         (WTR):
3043         (WTR::EventSenderProxy::cancelTouchPoint):
3044
3045 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3046
3047         Unreviewed, rolling out r108626.
3048         http://trac.webkit.org/changeset/108626
3049         https://bugs.webkit.org/show_bug.cgi?id=79370
3050
3051         broke qt-wk2 bot, somehow the workaround does not work on the
3052         bot (Requested by Ossy on #webkit).
3053
3054         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3055         (WTR::WrapperWindow::handleStatusChanged):
3056         (WTR::PlatformWebView::resizeTo):
3057
3058 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
3059
3060         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
3061         https://bugs.webkit.org/show_bug.cgi?id=78481
3062
3063         Reviewed by Gustavo Noronha Silva.
3064
3065         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
3066         to create gdk press key event.
3067         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
3068         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
3069
3070         * DumpRenderTree/gtk/EventSender.cpp:
3071         (scheduleAsynchronousClickCallback):
3072         (createKeyPressEvent):
3073         (sendKeyDown):
3074         (keyDownCallback):
3075         (sendAsynchronousKeyDown):
3076         (scheduleAsynchronousKeyDownCallback):
3077
3078 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
3079
3080         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3081         https://bugs.webkit.org/show_bug.cgi?id=76546
3082
3083         Reviewed by Simon Hausmann.
3084
3085         Co-authored with Simon Hausmann.
3086
3087         Revert the workaround introduced in r107868 and reintroduce
3088         the qml binding so we can test the code path that we are more
3089         interested in. The reason that it did not work before is that
3090         we don't have an active platform window which we now workaround
3091         by propagating the resize through QWindowSystemInterface.
3092
3093         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3094         (WTR::WrapperWindow::handleStatusChanged):
3095         (WTR::PlatformWebView::resizeTo):
3096
3097 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3098
3099         Unreviewed, rolling out r108577.
3100         http://trac.webkit.org/changeset/108577
3101         https://bugs.webkit.org/show_bug.cgi?id=79359
3102
3103         It doesn't work as expected (Requested by Ossy on #webkit).
3104
3105         * DumpRenderTree/qt/EventSenderQt.cpp:
3106         (EventSender::postEvent):
3107         * DumpRenderTree/qt/EventSenderQt.h:
3108         (EventSender):
3109
3110 2012-02-23  Philippe Normand  <pnormand@igalia.com>
3111
3112         [GTK] FullScreen signals
3113         https://bugs.webkit.org/show_bug.cgi?id=76181
3114
3115         Reviewed by Martin Robinson.
3116
3117         Use the two new entering/leaving fullscreen signals to hide/show
3118         the tool bar, the status bar and ask the user's permission before
3119         entering fullscreen.
3120
3121         * GtkLauncher/main.c:
3122         (webViewFullscreenMessageWindowClose):
3123         (webViewWindowStateEvent):
3124         (hide_widget):
3125         (show_widget):
3126         (webViewEnteringFullScreen):
3127         (webViewLeavingFullScreen):
3128         (createBrowser):
3129         (createWindow):
3130
3131 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
3132
3133         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
3134         https://bugs.webkit.org/show_bug.cgi?id=79076
3135
3136         Reviewed by Andreas Kling.
3137
3138         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
3139         (builtDylibPathForName):
3140
3141 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3142
3143         [Qt] Add eventSender.gestureTap
3144         https://bugs.webkit.org/show_bug.cgi?id=66173
3145
3146         Reviewed by Kenneth Rohde Christiansen.
3147
3148         * DumpRenderTree/qt/EventSenderQt.cpp:
3149         (EventSender::gestureTap):
3150         * DumpRenderTree/qt/EventSenderQt.h:
3151
3152 2012-02-22  Brady Eidson  <beidson@apple.com>
3153
3154         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
3155         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
3156
3157         Reviewed by Anders Carlsson.
3158
3159         Update our tools to the new form of the PageLoadClient.
3160
3161         * MiniBrowser/mac/BrowserWindowController.m:
3162         (-[BrowserWindowController awakeFromNib]): 
3163
3164         * WebKitTestRunner/TestController.cpp:
3165         (WTR::TestController::initialize):
3166
3167 2012-02-22  Daniel Bates  <dbates@webkit.org>
3168
3169         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
3170         https://bugs.webkit.org/show_bug.cgi?id=79277
3171
3172         Reviewed by Adam Barth.
3173
3174         Pass command line argument no-saved-state to run-safari to disable Safari
3175         state restoration for the session on OS 10.7.
3176
3177         * Scripts/webkitpy/layout_tests/port/mac.py:
3178         (MacPort.show_results_html_file):
3179         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3180         (test_show_results_html_file):
3181
3182 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
3183
3184         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
3185         https://bugs.webkit.org/show_bug.cgi?id=77759
3186
3187         Reviewed by Tony Chang.
3188
3189         Fixes build with gcc 4.7.
3190
3191         r100432 added the include only for ANDROID; this changes the ifdef to
3192         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
3193         longer implicitly includes unistd.h from standard headers and other
3194         unix platforms are likely to get gcc 4.7 as well in the future.
3195
3196         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3197
3198 2012-02-22  Philippe Normand  <pnormand@igalia.com>
3199
3200         Unreviewed, rolling out r108522.
3201         http://trac.webkit.org/changeset/108522
3202         https://bugs.webkit.org/show_bug.cgi?id=76181
3203
3204         Broke 4 fullscreen tests on GTK.
3205
3206         * GtkLauncher/main.c:
3207         (createBrowser):
3208         (createWindow):
3209
3210 2012-02-20  Philippe Normand  <pnormand@igalia.com>
3211
3212         [GTK] FullScreen signals
3213         https://bugs.webkit.org/show_bug.cgi?id=76181
3214
3215         Reviewed by Martin Robinson.
3216
3217         Use the two new entering/leaving fullscreen signals to hide/show
3218         the tool bar, the status bar and ask the user's permission before
3219         entering fullscreen.
3220
3221         * GtkLauncher/main.c:
3222         (webViewFullscreenMessageWindowClose):
3223         (webViewWindowStateEvent):
3224         (hide_widget):
3225         (show_widget):
3226         (webViewEnteringFullScreen):
3227         (webViewLeavingFullScreen):
3228         (createBrowser):
3229         (createWindow):
3230
3231 2012-02-22  Rob Flack  <flackr@chromium.org>
3232
3233         Update Linux ChromiumOS builders in flakiness dashboard.
3234         https://bugs.webkit.org/show_bug.cgi?id=79238
3235
3236         Reviewed by Ojan Vafai.
3237
3238         * TestResultServer/static-dashboards/builders.js:
3239
3240 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
3241
3242         webkitpy: test_function_length_check_definition_huge_lines is slow
3243         https://bugs.webkit.org/show_bug.cgi?id=79185
3244
3245         Reviewed by Adam Barth.
3246
3247         This test takes ~3 seconds to run, apparently because we're
3248         running a test on a 10,000 line function :). Dropping the
3249         function length to 640 still exercises the code path and
3250         provides a 10x speedup.
3251
3252         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3253         (CppStyleTest):
3254         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
3255
3256 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
3257
3258         webkitpy: speed up FileLockTest.test_lock_lifecycle
3259         https://bugs.webkit.org/show_bug.cgi?id=79189
3260
3261         Reviewed by Adam Barth.
3262
3263         The unit test had a second lock trying to acquire a
3264         lock already held, and a hard-coded timeout of one second.
3265         I have changed the timeouts to a tenth of a second (which
3266         is probably still fine) and changed the hard-spin on
3267         the lock to a slow-spin every hundredth of a second.
3268
3269         * Scripts/webkitpy/common/system/file_lock.py:
3270         (FileLock.acquire_lock):
3271         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
3272         (FileLockTest.setUp):
3273         (FileLockTest.test_stuck_lock):
3274
3275 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
3276
3277         build-webkit should use environment variable at number of CPU
3278         detection on all platform
3279         https://bugs.webkit.org/show_bug.cgi?id=79227
3280
3281         Reviewed by Martin Robinson.
3282
3283         * Scripts/webkitdirs.pm:
3284         (determineNumberOfCPUs):
3285
3286 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
3287
3288         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
3289         https://bugs.webkit.org/show_bug.cgi?id=78960
3290
3291         Reviewed by Csaba Osztrogonác.
3292
3293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3294         (LayoutTestController::overridePreference):
3295
3296 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
3297
3298         [chromium] Build WebKit with MEDIA_STREAM disabled.
3299         https://bugs.webkit.org/show_bug.cgi?id=79214
3300
3301         Reviewed by Kent Tamura.
3302
3303         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3304         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3305         * DumpRenderTree/chromium/WebViewHost.cpp:
3306         (WebViewHost::createMediaPlayer):
3307         * DumpRenderTree/chromium/WebViewHost.h:
3308         (WebViewHost):
3309
3310 2012-02-22  Zeno Albisser  <zeno@webkit.org>
3311
3312         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
3313         https://bugs.webkit.org/show_bug.cgi?id=79124
3314
3315         WebKitTestRunnerPrefix.h should also be included
3316         when building with clang.
3317
3318         Reviewed by Kenneth Rohde Christiansen.
3319
3320         * WebKitTestRunner/Target.pri:
3321
3322 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
3323
3324         <style scoped>: Add runtime-flag
3325         https://bugs.webkit.org/show_bug.cgi?id=79074
3326
3327         Enable the runtime-flag for DRT. 
3328
3329         Reviewed by Dimitri Glazkov.
3330
3331         * DumpRenderTree/chromium/TestShell.cpp:
3332         (TestShell::TestShell):
3333
3334 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         Unreviewed, rolling out r107351.
3337         http://trac.webkit.org/changeset/107351
3338         https://bugs.webkit.org/show_bug.cgi?id=53600
3339
3340         Several issues introduced in WebKitGTK+ API
3341
3342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3343         (createWebView):
3344         * GtkLauncher/main.c:
3345         (createWebViewCb):
3346         (createBrowser):
3347         (createWindow):
3348         (main):
3349
3350 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
3351
3352         JSC should be a triple-tier VM
3353         https://bugs.webkit.org/show_bug.cgi?id=75812
3354         <rdar://problem/10079694>
3355
3356         Reviewed by Gavin Barraclough.
3357
3358         Changed EFL's build system to include a new directory in JavaScriptCore.
3359
3360         * DumpRenderTree/efl/CMakeLists.txt:
3361
3362 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
3363
3364         [chromium] Fix image drag out on Chromium
3365         https://bugs.webkit.org/show_bug.cgi?id=79158
3366
3367         Reviewed by Tony Chang.
3368
3369         * DumpRenderTree/chromium/EventSender.cpp:
3370         (EventSender::dumpFilenameBeingDragged):
3371         (EventSender::beginDragWithFiles):
3372         * DumpRenderTree/chromium/WebViewHost.cpp:
3373         (addDRTFakeFileToDataObject):
3374
3375 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3376
3377         webkitpy: speed up hot filesystem_mock functions
3378         https://bugs.webkit.org/show_bug.cgi?id=79159
3379
3380         Reviewed by Adam Barth.
3381
3382         Profiling run_webkit_tests_integrationtest.py revealed that
3383         isdir(), normpath(), and join() are called a lot and were very
3384         slow.This patch speeds them up substantially, shaving 20 seconds
3385         off of the execution time.
3386
3387         * Scripts/webkitpy/common/system/filesystem_mock.py:
3388         (MockFileSystem.isdir):
3389         (MockFileSystem._slow_but_correct_join):
3390         (MockFileSystem.join):
3391         (MockFileSystem.listdir):
3392         (MockFileSystem._slow_but_correct_normpath):
3393         (MockFileSystem.normpath):
3394         (MockFileSystem.write_binary_file):
3395         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3396         (MockFileSystemTest.quick_check):
3397         (MockFileSystemTest):
3398         (MockFileSystemTest.test_join):
3399         (MockFileSystemTest.test_normpath):
3400         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3401         (get_test_config): Call write_binary_file() instead of updating
3402           filesystem.files directly, so that we create directories as
3403           needed.
3404
3405 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3406
3407         nrwt: make the delay between starting workers configurable per-port
3408         https://bugs.webkit.org/show_bug.cgi?id=79148
3409
3410         Reviewed by Eric Seidel.
3411
3412         Because of bug 79147, we have to sleep a bit in between starting
3413         DRTs; however, doing so across the board slows down the Test
3414         port. Making this configurable shaves 10 seconds off of
3415         run_webkit_tests_integrationtest.py
3416         
3417         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3418         (Manager._run_tests):
3419         * Scripts/webkitpy/layout_tests/port/base.py:
3420         (Port.worker_startup_delay_secs):
3421         * Scripts/webkitpy/layout_tests/port/test.py:
3422         (TestPort.worker_startup_delay_secs):
3423
3424 2012-02-21  Jon Lee  <jonlee@apple.com>
3425
3426         Bring notifications support to WK1 mac
3427         https://bugs.webkit.org/show_bug.cgi?id=78783
3428         <rdar://problem/10610578>
3429
3430         Reviewed by Anders Carlsson.
3431
3432         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
3433         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3434         (-[UIDelegate timerFired]):
3435
3436 2012-02-21  Kentaro Hara  <haraken@chromium.org>
3437
3438         Enable the IDL attribute checker in run-bindings-tests
3439         https://bugs.webkit.org/show_bug.cgi?id=79091
3440
3441         Reviewed by Adam Barth.
3442
3443         We have enabled the IDL attribute checker in Chromium in r108322.
3444         This patch enables the IDL attribute checker in run-bindings-tests.
3445
3446         No tests. I manually checked that [Custommm], [CallWith=],
3447         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
3448         run-bindings-tests failures.
3449
3450         * Scripts/webkitpy/bindings/main.py:
3451         (BindingsTests.generate_supplemental_dependency):
3452
3453 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
3454
3455         Add rafaelw as a committer.
3456
3457         Unreviewed.
3458
3459         * Scripts/webkitpy/common/config/committers.py:
3460
3461 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3462
3463         webkitpy: update names after deleting message_broker
3464         https://bugs.webkit.org/show_bug.cgi?id=79000
3465
3466         Reviewed by Eric Seidel.
3467
3468         Part 3 of 3 in deleting message_broker.py; this change just
3469         adjusts the names for the newly merged symbols so that they are
3470         private as appropriate.
3471
3472         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3473         (get):
3474         (_Broker):
3475         (_BrokerConnection):
3476         (_BrokerConnection.__init__):
3477         (AbstractWorker.__init__):
3478         (_ManagerConnection):
3479         (_ManagerConnection.__init__):
3480         (_WorkerConnection):
3481         (_WorkerConnection.__init__):
3482
3483 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3484
3485         webkitpy: merge message_broker.py into manager_worker_broker.py
3486         https://bugs.webkit.org/show_bug.cgi?id=78999
3487
3488         Reviewed by Tony Chang.
3489
3490         This is pretty much a straight cut-and-paste of one file into
3491         another (broken up so that docstrings and imports are in the
3492         right place).
3493
3494         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3495         (BrokerClient):
3496         (BrokerClient.is_done):
3497         (BrokerClient.name):
3498         (Broker):
3499         (Broker.__init__):
3500         (Broker.add_topic):
3501         (Broker._get_queue_for_topic):
3502         (Broker.post_message):
3503         (Broker.run_message_loop):
3504         (Broker.run_all_pending):
3505         (Broker._run_loop):
3506         (Broker._dispatch_message):
3507         (_Message):
3508         (_Message.loads):
3509         (_Message.__init__):
3510         (_Message.dumps):
3511         (_Message.__repr__):
3512         (BrokerConnection):
3513         (BrokerConnection.__init__):
3514         (BrokerConnection.run_message_loop):
3515         (BrokerConnection.post_message):
3516         (BrokerConnection.raise_exception):
3517         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
3518
3519 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3520
3521         webkitpy: prepare to delete message_broker.py
3522         https://bugs.webkit.org/show_bug.cgi?id=78997
3523
3524         Reviewed by Eric Seidel.
3525
3526         This is part 1 of 3 changes to fix bug 78187. This change
3527         prepares the code for merging message_broker.py into
3528         manager_worker_broker.py; the tests in message_broker_unittest
3529         are merged into manager_worker_broker_unittest, the symbols
3530         needed by the tests are exported from manager_worker_broker.py,
3531         and manager_worker_broker itself is updated to refer to the
3532         symbols directly (without the module prefix).
3533
3534         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3535         (get):
3536         (AbstractWorker):
3537         (AbstractWorker.__init__):
3538         (_ManagerConnection):
3539         (_ManagerConnection.__init__):
3540         (_WorkerConnection):
3541         (_WorkerConnection.__init__):
3542         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3543         (InterfaceTest.test_brokerclient_is_abstract):
3544         (InterfaceTest.test_brokerclient_is_abstract.methods):
3545         (MessageTest):
3546         (MessageTest.test__no_body):
3547         (MessageTest.test__body):
3548         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
3549
3550 2012-02-21  Sam Weinig  <sam@webkit.org>
3551
3552         Attempt to fix the Snow Leopard build.
3553
3554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3555         * MiniBrowser/Configurations/Base.xcconfig:
3556         * TestWebKitAPI/Configurations/Base.xcconfig:
3557         * WebKitTestRunner/Configurations/Base.xcconfig:
3558
3559 2012-02-21  Sam Weinig  <sam@webkit.org>
3560
3561         Use libc++ when building with Clang on Mac
3562         https://bugs.webkit.org/show_bug.cgi?id=78981
3563
3564         Reviewed by Dan Bernstein.
3565
3566         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3567         * MiniBrowser/Configurations/Base.xcconfig:
3568         * TestWebKitAPI/Configurations/Base.xcconfig:
3569         * WebKitTestRunner/Configurations/Base.xcconfig:
3570
3571 2012-02-21  Adam Roben  <aroben@apple.com>
3572
3573         Roll out r108309, r108323, and r108326
3574
3575         They broke the 32-bit Lion build.
3576
3577         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
3578
3579         * DumpRenderTree/efl/CMakeLists.txt:
3580
3581 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3582
3583         [Qt][WK2] Get rid of the dependency to QtWidgets
3584         https://bugs.webkit.org/show_bug.cgi?id=76276
3585
3586         Reviewed by Simon Hausmann.
3587
3588         * MiniBrowser/qt/MiniBrowser.pro:
3589         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3590         (MiniBrowserApplication::MiniBrowserApplication):
3591         (MiniBrowserApplication::notify):
3592         (MiniBrowserApplication::sendTouchEvent):
3593         * MiniBrowser/qt/MiniBrowserApplication.h:
3594         (MiniBrowserApplication):
3595         * QtTestBrowser/locationedit.h:
3596         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3597         (WTR::activateFonts):
3598         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3599
3600 2012-02-20  Adam Barth  <abarth@webkit.org>
3601
3602         mastercfg_unittest.py fails without simplejson
3603         https://bugs.webkit.org/show_bug.cgi?id=79070
3604
3605         Reviewed by Csaba Osztrogonác.
3606
3607         Now that we require Python 2.6 (and higher) we can import json rather
3608         than simplejson.  We still need to use the simplejson name because
3609         that's what the master.cfg script expects.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3612         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3613
3614 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3615
3616         JSC should be a triple-tier VM
3617         https://bugs.webkit.org/show_bug.cgi?id=75812
3618         <rdar://problem/10079694>
3619
3620         Reviewed by Gavin Barraclough.
3621
3622         Changed EFL's build system to include a new directory in JavaScriptCore.
3623
3624         * DumpRenderTree/efl/CMakeLists.txt:
3625
3626 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
3627
3628         Update pywebsocket to 0.7.2
3629         https://bugs.webkit.org/show_bug.cgi?id=79066
3630
3631         This version includes vendor-prefixed deflate-frame extension support.
3632
3633         Reviewed by Kent Tamura.
3634
3635         * Scripts/webkitpy/thirdparty/__init__.py:
3636         (AutoinstallImportHook._install_pywebsocket):
3637
3638 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3639
3640         [UNIX] Plugin information fields are not interpreted as UTF-8
3641         https://bugs.webkit.org/show_bug.cgi?id=78635
3642
3643         Reviewed by Gustavo Noronha Silva.
3644
3645         Interpret plugin metadata as UTF8 aways. This matches the behavior
3646         of Chromium and the Totem plugin.
3647
3648         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3649         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
3650
3651 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3652
3653         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
3654         https://bugs.webkit.org/show_bug.cgi?id=78935
3655
3656         Reviewed by Gustavo Noronha Silva.
3657
3658         Move the TestNetscapePlugin headers to a more appropriate directory and update
3659         the build files to match.
3660
3661         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
3662         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
3663         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
3664         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
3665         * GNUmakefile.am: Ditto.
3666
3667 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
3668
3669         Add a new API for the Vibration API(W3C).
3670         https://bugs.webkit.org/show_bug.cgi?id=72010
3671
3672         Reviewed by Hajime Morita.
3673
3674         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
3675
3676 2012-02-20  János Badics  <dicska@gmail.com>
3677
3678         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
3679         https://bugs.webkit.org/show_bug.cgi?id=71816
3680
3681         RunQtAPITests will notify if a timeout occurs during testing.
3682         Added unittest to the master.cfg
3683
3684         Reviewed by Csaba Osztrogonác.
3685
3686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3687         (RunQtAPITests.evaluateCommand):
3688         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3689         (RunQtAPITestsTest):
3690         (RunQtAPITestsTest.assertResults):
3691         (RunQtAPITestsTest.test_timeout):
3692         (test_success):
3693         (test_failure):
3694         (test_timeout_and_failure):
3695
3696 2012-02-20  Andy Wingo  <wingo@igalia.com>
3697
3698         Add wingo as a committer.
3699
3700         Unreviewed.
3701
3702         * Scripts/webkitpy/common/config/committers.py: Add myself to the
3703         committers list.
3704
3705 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
3706
3707         [chromium] check that we're not running multiple modal dialogs at the same time
3708         https://bugs.webkit.org/show_bug.cgi?id=78486
3709
3710         Reviewed by Kent Tamura.
3711
3712         * DumpRenderTree/chromium/TestShell.cpp:
3713         (TestShell::TestShell):
3714         * DumpRenderTree/chromium/TestShell.h:
3715         (TestShell::setIsDisplayingModalDialog):
3716         (TestShell::isDisplayingModalDialog):
3717         (TestShell):
3718         * DumpRenderTree/chromium/WebViewHost.cpp:
3719         (WebViewHost::runModal):
3720
3721 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3722