[Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedIma...
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-04  Andy Estes  <aestes@apple.com>
2
3         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
4         https://bugs.webkit.org/show_bug.cgi?id=171646
5         <rdar://problem/30306321>
6
7         Reviewed by Tim Horton.
8
9         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
10         (runTestWithWidth):
11         (TEST):
12         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
13         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
14         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
15         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
16         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
17         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
18
19 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
20
21         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
22         https://bugs.webkit.org/show_bug.cgi?id=171649
23
24         Reviewed by Carlos Garcia Campos.
25
26         Add two patches picked from the upstream repository to fix building of
27         the Fontconfig module in JHBuild. Additionally, this needed a patch to
28         add "autogen.sh" as it is not included in release tarballs. Also:
29         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
30         being regenerated (which is needed) so this is disabled for the
31         Fontconfig module.
32
33         * gtk/jhbuild.modules:
34         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
35         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
36         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
37
38 2017-05-04  Commit Queue  <commit-queue@webkit.org>
39
40         Unreviewed, rolling out r216172.
41         https://bugs.webkit.org/show_bug.cgi?id=171654
42
43         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
44         implementation. (Requested by ddkilzer on #webkit).
45
46         Reverted changeset:
47
48         "[MediaStream] Allow host application to enable/disable media
49         capture"
50         https://bugs.webkit.org/show_bug.cgi?id=171292
51         http://trac.webkit.org/changeset/216172
52
53 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
54
55         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
56         https://bugs.webkit.org/show_bug.cgi?id=171595
57
58         Reviewed by Xabier Rodriguez-Calvar.
59
60         * gtk/jhbuild.modules:
61         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
62         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
63         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
64         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
65         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
66         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
67         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
68
69 2017-05-03  Saam Barati  <sbarati@apple.com>
70
71         How we build polymorphic cases is wrong when making a call from Wasm
72         https://bugs.webkit.org/show_bug.cgi?id=171527
73
74         Reviewed by JF Bastien.
75
76         * Scripts/run-jsc-stress-tests:
77
78 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
79
80         [MediaStream] Allow host application to enable/disable media capture
81         https://bugs.webkit.org/show_bug.cgi?id=171292
82         <rdar://problem/31821492>
83
84         Reviewed by Jer Noble.
85
86         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
87         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
88         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
89         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
90         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
91         (MediaCaptureDisabledTest::SetUp):
92         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
93         (TEST_F):
94         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
95
96 2017-05-03  John Wilander  <wilander@apple.com>
97
98         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
99         https://bugs.webkit.org/show_bug.cgi?id=171584
100         <rdar://problem/24702576>
101
102         Reviewed by Brent Fulgham.
103
104         New function to call the clear function that takes a modifiedSince parameter.
105
106         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
108         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
112         * WebKitTestRunner/TestController.h:
113         * WebKitTestRunner/TestInvocation.cpp:
114         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
115
116 2017-05-03  Commit Queue  <commit-queue@webkit.org>
117
118         Unreviewed, rolling out r216160 and r216161.
119         https://bugs.webkit.org/show_bug.cgi?id=171640
120
121         These changes broke the iOS build. (Requested by mlewis13 on
122         #webkit).
123
124         Reverted changesets:
125
126         "[MediaStream] Allow host application to enable/disable media
127         capture"
128         https://bugs.webkit.org/show_bug.cgi?id=171292
129         http://trac.webkit.org/changeset/216160
130
131         "[MediaStream] Allow host application to enable/disable media
132         capture"
133         https://bugs.webkit.org/show_bug.cgi?id=171292
134         http://trac.webkit.org/changeset/216161
135
136 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
137
138         [MediaStream] Allow host application to enable/disable media capture
139         https://bugs.webkit.org/show_bug.cgi?id=171292
140         <rdar://problem/31821492>
141
142         Reviewed by Jer Noble.
143
144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
145         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
146         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
147         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
148         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
149         (MediaCaptureDisabledTest::SetUp):
150         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
151         (TEST_F):
152         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
153
154 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
155
156         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
157         https://bugs.webkit.org/show_bug.cgi?id=171350
158         <rdar://problem/28600836>
159
160         Patched by Brady Eidson.
161
162         Reviewed by Brent Fulgham.
163
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
166         (TestWebKitAPI::runJavaScriptAlert):
167         (TestWebKitAPI::decidePolicyForNavigationAction):
168         (TestWebKitAPI::decidePolicyForNavigationResponse):
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
171
172 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
173
174         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
175         https://bugs.webkit.org/show_bug.cgi?id=171619
176         https://bugs.webkit.org/show_bug.cgi?id=170195
177
178         Reviewed by Tim Horton.
179
180         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
181
182         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
183         (TEST):
184
185 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
186
187         YouTube user agent quirk breaks new YouTube
188         https://bugs.webkit.org/show_bug.cgi?id=171603
189
190         Reviewed by Carlos Garcia Campos.
191
192         Remove the YouTube quirk test.
193
194         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
195         (TestWebKitAPI::TEST):
196
197 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
198
199         Async image decoding should be disabled for snapshots, printing and preview
200         https://bugs.webkit.org/show_bug.cgi?id=171467
201
202         Reviewed by Simon Fraser.
203
204         Add a API test for snapshotting with large images. Ensure the images are
205         drawn correctly which implies they should have been synchronously decoded.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
209         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
210         (TEST):
211
212 2017-05-03  Chris Dumez  <cdumez@apple.com>
213
214         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
215         https://bugs.webkit.org/show_bug.cgi?id=171565
216         <rdar://problem/31204417>
217
218         Reviewed by Sam Weinig.
219
220         Add API test coverage.
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
224         (TestWebKitAPI::didFinishNavigation):
225         (TestWebKitAPI::didCrashWithReason):
226         (TestWebKitAPI::TEST):
227
228 2017-05-02  David Kilzer  <ddkilzer@apple.com>
229
230         check-webkit-style should also keep js-test-post[-async].js in sync
231         <https://webkit.org/b/171568>
232
233         Reviewed by Joseph Pecoraro.
234
235         * Scripts/webkitpy/style/checker.py:
236         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
237         JavaScript files not to be skipped.
238         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
239         (CheckerDispatcher._create_checker): Update to use
240         _NEVER_SKIPPED_JS_FILES.
241
242         * Scripts/webkitpy/style/checkers/jstest.py:
243         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
244         This is the list of files containing functions that need to be
245         kept in sync.
246         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
247         we can keep more sets of files in sync between
248         LayoutTests/resources and LayoutTests/http/tests/resources.
249         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
250         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
251         (JSTestChecker.check_js_test_files): Add 'file_group' argument
252         for list of files to check instead of using
253         KEEP_JS_TEST_FILES_IN_SYNC.
254         (JSTestChecker.check_js_test_functions): Update for
255         ALL_JS_TEST_FUNCTION_FILES rename.
256
257         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
258         (JSTestCheckerTestCase):
259         (JSTestCheckerTestCase.test_map_functions_to_dict):
260         - Add test case for map_functions_to_dict() in jstest.py.
261
262 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
263
264         ews should indicate in logs when it fails to fetch the attachment
265         https://bugs.webkit.org/show_bug.cgi?id=171583
266
267         Reviewed by Alexey Proskuryakov.
268
269         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
270         (Bugzilla.fetch_attachment): Added log statement.
271
272 2017-05-02  David Kilzer  <ddkilzer@apple.com>
273
274         Rolling out jstest_unittest.py so it can be reviewed
275
276         Follow-up fix for:
277         check-webkit-style should keep JavaScript test functions in sync
278         <https://webkit.org/b/171424>
279
280         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
281
282 2017-05-02  David Kilzer  <ddkilzer@apple.com>
283
284         check-webkit-style should keep JavaScript test functions in sync
285         <https://webkit.org/b/171424>
286
287         Reviewed by Joseph Pecoraro.
288
289         Add a new JSTestChecker for check-webkit-style that keeps these
290         two files in sync:
291
292             LayoutTests/http/tests/resources/js-test-pre.js
293             LayoutTests/resources/js-test-pre.js
294
295         And keeps implementations of shouldBe(), shouldNotBe(),
296         shouldNotThrow(), and shouldThrow() in sync across multiple
297         files (with the ability to add more functions later):
298
299             JSTests/stress/resources/standalone-pre.js
300             LayoutTests/http/tests/resources/js-test-pre.js
301             LayoutTests/resources/js-test-pre.js
302             LayoutTests/resources/js-test.js
303             LayoutTests/resources/standalone-pre.js
304
305         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
306         import for JSTestChecker.
307         (_NEVER_SKIPPED_FILES): Add array of file names that are never
308         skipped regardless of other rules.
309         (_all_categories): Add JSTestChecker categories.
310         (CheckerDispatcher.should_skip_without_warning): Use
311         _NEVER_SKIPPED_FILES.
312         (CheckerDispatcher._create_checker): Return JSTestChecker for
313         the files to check.
314
315         * Scripts/webkitpy/style/checkers/jstest.py: Add.
316         (map_functions_to_dict): Parse JavaScript source by splitting on
317         /^function\s+/ regex.  This is good enough for the sanity checks
318         to keep function implementations in sync.
319         (strip_blank_lines_and_comments): Strips blank lines and lines
320         with comments from the end of a chunk of text representing a
321         function.
322         (JSTestChecker): New checker.
323         (JSTestChecker.__init__):
324         (JSTestChecker.check):
325         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
326         (JSTestChecker.check_js_test_functions): Keeps individual
327         functions in sync.
328
329         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
330         case.
331         (JSTestTestCase):
332         (JSTestTestCase.test_map_functions_to_dict):
333
334 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
335
336         AX: Update implementation of aria-orientation
337         https://bugs.webkit.org/show_bug.cgi?id=171166
338
339         Reviewed by Chris Fleizach.
340
341         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
342         are both absent from the state set. Before we were returning an empty string
343         which was not consistent with what the Mac port does, thus making shared tests
344         harder.
345
346         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
347         (WTR::AccessibilityUIElement::orientation):
348
349 2017-05-01  David Kilzer  <ddkilzer@apple.com>
350
351         Stop using sprintf() in JavaScriptCore debugger
352         <https://webkit.org/b/171512>
353
354         Reviewed by Keith Miller.
355
356         * Scripts/webkitpy/style/checker.py:
357         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
358         Source/JavaScriptCore/disassembler/udis86/ is generated code.
359
360 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
361
362         Expose viewport-fit instead of clip-to-safe-area
363         https://bugs.webkit.org/show_bug.cgi?id=171503
364         <rdar://problem/31918249>
365
366         Reviewed by Simon Fraser.
367
368         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
369         (WTR::UIScriptController::setSafeAreaInsets):
370         (WTR::UIScriptController::setObscuredInsets): Deleted.
371         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
372         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
373         (WTR::UIScriptController::setSafeAreaInsets):
374         (WTR::UIScriptController::setObscuredInsets): Deleted.
375         * TestRunnerShared/UIScriptContext/UIScriptController.h:
376         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
377         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
378         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
379         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
380         * WebKitTestRunner/ios/TestControllerIOS.mm:
381         (WTR::TestController::platformResetStateToConsistentValues):
382         * WebKitTestRunner/ios/UIKitSPI.h:
383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
384         (WTR::UIScriptController::setSafeAreaInsets):
385         (WTR::UIScriptController::setObscuredInsets): Deleted.
386         Expose a safe area inset setter instead of obscured insets.
387
388 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
389
390         Unreviewed, fix the build on a new internal SDK
391
392         Replace usages of NSItemProviderRepresentationVisibilityAll with
393         UIItemProviderRepresentationOptionsVisibilityAll.
394
395         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
396         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
397         (TestWebKitAPI::TEST):
398
399 2017-05-01  David Kilzer  <ddkilzer@apple.com>
400
401         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
402         <https://webkit.org/b/171493>
403
404         Reviewed by Dan Bernstein.
405
406         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
407         Remove UIKit soft-link since TestWebKitAPI links to
408         UIKit.framework.
409         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
410         UIWindow and UIWebView classes directly.
411         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
412         Remove UIKit soft-link since TestWebKitAPI links to
413         UIKit.framework.
414         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
415         class directly.
416
417 2017-05-01  Brady Eidson  <beidson@apple.com>
418
419         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
420         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
421
422         Reviewed by Andy Estes.
423
424         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
425         (-[SchemeHandler webView:startURLSchemeTask:]):
426         (-[SchemeHandler webView:stopURLSchemeTask:]):
427         (-[SchemeHandler webView:startTask:]): Deleted.
428         (-[SchemeHandler webView:stopTask:]): Deleted.
429
430 2017-05-01  Jason Marcell  <jmarcell@apple.com>
431
432         Add a new function for getting the Git hash for a pure git directory.
433         https://bugs.webkit.org/show_bug.cgi?id=171450
434
435         Reviewed by David Kilzer.
436
437         * Scripts/VCSUtils.pm:
438         (gitHashForDirectory):
439
440 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
441
442         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
443         https://bugs.webkit.org/show_bug.cgi?id=171496
444
445         Reviewed by Chris Fleizach.
446
447         Add new attribute names so that the values of the object attributes can be tested.
448
449         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
450         (WTR::AccessibilityUIElement::numberAttributeValue):
451
452 2017-05-01  Beth Dakin  <bdakin@apple.com>
453
454         On-screen panel for candidate bar is in the wrong place when the caret is at the 
455         start of a paragraph
456         https://bugs.webkit.org/show_bug.cgi?id=171453
457         -and corresponding-
458         rdar://problem/29779764
459
460         Reviewed by Tim Horton.
461
462         This test hard-codes the y-coordinate for the expected candidateRect. 
463         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
464         (TEST):
465
466 2017-05-01  David Kilzer  <ddkilzer@apple.com>
467
468         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
469         <https://webkit.org/b/171494>
470
471         Reviewed by Brent Fulgham.
472
473         * Scripts/webkitpy/style/checkers/cpp.py:
474         (check_language): Change categories for certain checkers from
475         'runtime/printf' to 'security/printf' so they are no longer
476         filtered.
477         (CppChecker.categories): Add 'security/printf'.
478         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
479         (CppStyleTest.test_insecure_string_operations): Add new test for
480         sprintf(), strcat() and strcpy().
481         (CppStyleTest.test_format_strings): Update test results for new
482         'security/printf' category use.
483
484 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
485
486         AX: [GTK] Add support to query for aria-current
487         https://bugs.webkit.org/show_bug.cgi?id=149016
488
489         Reviewed by Chris Fleizach.
490
491         Implement support for "AXARIACurrent" string attribute value.
492
493         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
494
495 2017-05-01  David Kilzer  <ddkilzer@apple.com>
496
497         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
498
499         Unreviewed.
500
501         Follow-up fix for:
502         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
503         https://bugs.webkit.org/show_bug.cgi?id=171486
504
505         * Scripts/webkitpy/style/checkers/cpp.py:
506         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
507         match and capture the function name.  The latter also mistakenly
508         matches C-preprocessor directives.
509         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
510         is a requirement for the CppChecker class.
511
512 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
513
514         [GTK] Add automation session API
515         https://bugs.webkit.org/show_bug.cgi?id=171428
516
517         Reviewed by Carlos Alberto Lopez Perez.
518
519         Add an automation mode to MiniBrowser using the new API and add a unit test too.
520
521         * MiniBrowser/gtk/BrowserWindow.c:
522         (webViewTitleChanged):
523         (webViewDecidePolicy):
524         (newTabCallback):
525         (openPrivateWindow):
526         (browserWindowFinalize):
527         (browser_window_init):
528         (browser_window_get_or_create_web_view_for_automation):
529         * MiniBrowser/gtk/BrowserWindow.h:
530         * MiniBrowser/gtk/main.c:
531         (createBrowserTab):
532         (createWebViewForAutomationCallback):
533         (automationStartedCallback):
534         (main):
535         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
536         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
537         (testAutomationSessionRequestSession):
538         (beforeAll):
539         (afterAll):
540
541 2017-04-30  Dan Bernstein  <mitz@apple.com>
542
543         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
544         https://bugs.webkit.org/show_bug.cgi?id=171486
545
546         Reviewed by Sam Weinig.
547
548         * Scripts/webkitpy/style/checkers/cpp.py:
549         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
550           alloc…Instance() instead.
551         (check_style): Invoke new check.
552
553 2017-04-30  Brady Eidson  <beidson@apple.com>
554
555         More fixing after r215991
556         https://bugs.webkit.org/show_bug.cgi?id=171483
557
558         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
559         (TEST):
560
561 2017-04-30  Brady Eidson  <beidson@apple.com>
562
563         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
564         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
565
566         Reviewed by Geoff Garen (and kind of Andy Estes).
567
568         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
569         (TEST):
570
571 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
572
573         [ATK] Implement support for aria-autocomplete
574         https://bugs.webkit.org/show_bug.cgi?id=171167
575
576         Reviewed by Chris Fleizach.
577
578         Add "AXSupportsAutoCompletion" attribute so the presence of
579         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
580
581         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
582         (WTR::AccessibilityUIElement::boolAttributeValue):
583
584 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
585
586         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
587         https://bugs.webkit.org/show_bug.cgi?id=171170
588
589         Reviewed by Chris Fleizach.
590
591         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
592
593         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
594         (WTR::AccessibilityUIElement::boolAttributeValue):
595
596 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
597
598         [ATK] Emit object:state-changed:busy event when aria-busy value changes
599         https://bugs.webkit.org/show_bug.cgi?id=171181
600
601         Reviewed by Chris Fleizach.
602
603         Add handler for AXElementBusyChanged notifications.
604
605         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
606
607 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
608
609         Use PEP8 style guide for raising exceptions in webkitpy.
610         https://bugs.webkit.org/show_bug.cgi?id=171439
611
612         Reviewed by Daniel Bates.
613
614         As per https://www.python.org/dev/peps/pep-0008/
615         "When raising an exception in Python 2, use raise ValueError('message') 
616         instead of the older form raise ValueError, 'message'"
617
618         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
619         * Scripts/webkitpy/common/thread/messagepump.py: Same.
620         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
621         * Scripts/webkitpy/tool/commands/queues.py: Same.
622         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
623         * Scripts/webkitpy/tool/multicommandtool.py: Same.
624         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
625
626 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
627
628         Add system trace points for Document::updateTouchEventRegions()
629         https://bugs.webkit.org/show_bug.cgi?id=171470
630         rdar://problem/31901239
631
632         Reviewed by Tim Horton.
633
634         Add trace markers for updateTouchEventRegions.
635
636         * Tracing/SystemTracePoints.plist:
637
638 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
639
640         webkitpy: Add apple_additions to webkitpy to insert Internal tools
641         https://bugs.webkit.org/show_bug.cgi?id=170461
642         <rdar://problem/31433077>
643
644         Reviewed by Daniel Bates.
645
646         Allow a package to be pulled in by run-webkit-tests which provides an interface to
647         run layout tests on an iOS device.  If this package is not available, throw an
648         exception when attempting to run layout tests on an iOS device.
649
650         * Scripts/webkitpy/port/config.py:
651         (apple_additions): Import apple_additions package.
652         * Scripts/webkitpy/port/device.py:
653         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
654         installed on a device.
655         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
656         host, the bundle id of the app to be used for testing and a path to the layout test
657         directory to be mounted on the device.
658         (Device.finished_testing):
659         * Scripts/webkitpy/port/factory.py:
660         (platform_options): Add apple_additions platform options if apple_additions exists.
661         * Scripts/webkitpy/port/ios.py:
662         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
663         to forward, the bundle ID of the testing app and the layout tests directory to
664         each device.
665         * Scripts/webkitpy/port/ios_device.py:
666         (IOSDevicePort):
667         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
668         processes to be run.
669         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
670         a single device is used, it is still accessed through an array.
671         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
672         for worker number map.
673         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
674         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
675         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
676         (IOSDevicePort.look_for_new_crash_logs): Ditto.
677         (IOSDevicePort.look_for_new_samples): Ditto.
678         (IOSDevicePort.sample_process): Ditto.
679         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
680         (IOSDevicePort._create_devices): Check that devices are available for testing and check
681         that we have enough devices for each child process.
682         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
683         * Scripts/webkitpy/port/ios_device_unittest.py:
684         (IOSDeviceTest.test_operating_system):
685         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
686         (IOSDeviceTest.test_sample_process): Ditto.
687         (IOSDeviceTest.test_sample_process_exception): Ditto.
688
689 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
690
691         Fix and re-enable data interaction unit tests
692         https://bugs.webkit.org/show_bug.cgi?id=171446
693         <rdar://problem/31820646>
694
695         Reviewed by Tim Horton.
696
697         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
698         registering with the UIItemProvider, and instead just register data directly via
699         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
700
701         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
702         (TestWebKitAPI::TEST):
703         (temporaryURLForDataInteractionFileLoad): Deleted.
704         (cleanUpDataInteractionTemporaryPath): Deleted.
705         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
706         * TestWebKitAPI/ios/DataInteractionSimulator.h:
707         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
708
709 2017-04-28  Brady Eidson  <beidson@apple.com>
710
711         Teach the DatabaseProcess to be fully SessionID aware
712         https://bugs.webkit.org/show_bug.cgi?id=171451
713
714         Reviewed by Geoffrey Garen.
715
716         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
717
718 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
719
720         Unreviewed follow-up to r214705.
721
722         shut.copytree will fail if given a file as an argument instead of a directory.
723
724         * Scripts/webkitpy/common/system/filesystem.py:
725         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
726         when source is a file.
727         (FileSystem.copy_from_base_host): Ditto.
728
729 2017-04-28  Chris Dumez  <cdumez@apple.com>
730
731         Update DOMTokenList.replace() to match the latest DOM specification
732         https://bugs.webkit.org/show_bug.cgi?id=171388
733
734         Reviewed by Alex Christensen.
735
736         Add API test coverage for new Vector API.
737
738         * TestWebKitAPI/Tests/WTF/Vector.cpp:
739         (TestWebKitAPI::TEST):
740
741 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
742
743         WebKitTestRunner/DumpRenderTree prevent device from sleeping
744         https://bugs.webkit.org/show_bug.cgi?id=170731
745
746         Reviewed by Alex Christensen.
747
748         While running layout tests on a device, the device should not be put asleep.
749
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (dumpRenderTree): Disable idle timer.
752         * WebKitTestRunner/ios/TestControllerIOS.mm:
753         (WTR::TestController::platformInitialize): Ditto.
754
755 2017-04-28  Brady Eidson  <beidson@apple.com>
756
757         Start of support for multiple WebsiteDataStore/SessionIDs per process
758         https://bugs.webkit.org/show_bug.cgi?id=171422
759
760         Reviewed by Geoffrey Garen.
761
762         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
763         (TEST):
764
765 2017-04-28  Youenn Fablet  <youenn@apple.com>
766
767         Adding a runtime flag specific to MediaDevices
768         https://bugs.webkit.org/show_bug.cgi?id=171433
769
770         Reviewed by Geoffrey Garen.
771
772         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
773         Setting media devices runtime flag to true for WTR and DRT.
774
775         * DumpRenderTree/mac/DumpRenderTree.mm:
776         (enableExperimentalFeatures):
777         (resetWebPreferencesToConsistentValues):
778         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
779         (TestWebKitAPI::TEST):
780         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
781         (TestWebKitAPI::TEST):
782         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
783         (WTR::InjectedBundle::beginTesting):
784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
785         (WTR::TestRunner::setMediaDevicesEnabled):
786         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
787         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
789         * WebKitTestRunner/TestController.cpp:
790         (WTR::TestController::resetPreferencesToConsistentValues):
791
792 2017-04-28  Dean Jackson  <dino@apple.com>
793
794         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
795         https://bugs.webkit.org/show_bug.cgi?id=171441
796         <rdar://problem/31826915>
797
798         Reviewed by Tim Horton.
799
800         Add an API test for GPUCommandQueue, exercising creation
801         and setting the label.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
805         (TestWebKitAPI::TEST_F):
806
807 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
808
809         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
810         https://bugs.webkit.org/show_bug.cgi?id=171188
811
812         Reviewed by Chris Fleizach.
813
814         Add "AXModal" attribute string so that we can test the state's exposure.
815
816         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
817         (WTR::AccessibilityUIElement::boolAttributeValue):
818
819 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
820
821         [ATK] GridCellRole should implement AtkTableCell (regression?)
822         https://bugs.webkit.org/show_bug.cgi?id=171179
823
824         Reviewed by Chris Fleizach.
825
826         Add new "AXInterfaceTableCell" attribute so that we can test whether or
827         not there is an implementation of AtkTableCell (i.e. without risking false
828         negatives from bugs in the interface's implementation).
829
830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
831         (WTR::AccessibilityUIElement::boolAttributeValue):
832
833 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
834
835         Move UUID from WebCore/platform to WTF
836         https://bugs.webkit.org/show_bug.cgi?id=171372
837
838         Reviewed by Michael Catanzaro.
839
840         * WebKitTestRunner/TestController.cpp:
841
842 2017-04-27  Alex Christensen  <achristensen@webkit.org>
843
844         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
845         https://bugs.webkit.org/show_bug.cgi?id=171399
846
847         Reviewed by Brady Eidson.
848
849         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
850         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
851         (TEST):
852
853 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
854
855         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
856         https://bugs.webkit.org/show_bug.cgi?id=167914
857
858         Unreviewed test gardening.
859
860         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
861         (TEST):
862
863 2017-04-26  Saam Barati  <sbarati@apple.com>
864
865         Add some more testing modes for Wasm tests now that we have tier up
866         https://bugs.webkit.org/show_bug.cgi?id=171360
867
868         Reviewed by Keith Miller.
869
870         Lets enable the FTL on all Wasm tests. Let's also run each
871         test with and without CJIT.
872
873         * Scripts/run-jsc-stress-tests:
874
875 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
876
877         JSC EWS Patch Relevance skips few JSC scripts
878         https://bugs.webkit.org/show_bug.cgi?id=171351
879
880         Reviewed by Alexey Proskuryakov.
881
882         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
883         (CheckPatchRelevance): Added few jsc related scripts.
884
885 2017-04-26  Youenn Fablet  <youenn@apple.com>
886
887         Test importer should delete obsolete files based on w3c-import.log
888         https://bugs.webkit.org/show_bug.cgi?id=171348
889
890         Reviewed by Chris Dumez.
891
892         * Scripts/webkitpy/w3c/test_importer.py:
893         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
894         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
895         * Scripts/webkitpy/w3c/test_importer_unittest.py:
896         (test_remove_obsolete_content):
897
898 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
899
900         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
901         <rdar://problem/31816459>
902
903         Unreviewed infrastructure fix.
904
905         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
906         DYLD_FRAMEWORK_PATH when installing an app.
907
908         * Scripts/webkitpy/port/ios.py:
909         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
910
911 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
912
913         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
914         https://bugs.webkit.org/show_bug.cgi?id=171163
915
916         Reviewed by Chris Fleizach.
917
918         Add support for state-change notifications for ATK_STATE_ACTIVE.
919
920         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
921
922 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
923
924         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
925         https://bugs.webkit.org/show_bug.cgi?id=171293
926
927         Reviewed by Aakash Jain.
928
929         We should make an effort to teardown simulators which we booted even when an exception is
930         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
931         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
932         torn down.
933
934         * Scripts/webkitpy/layout_tests/controllers/manager.py:
935         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
936         * Scripts/webkitpy/port/ios_simulator.py:
937         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
938         iOS simulators and teardown and managed devices.
939         (IOSSimulatorPort._create_simulators): Register teardown function.
940         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
941         (IOSSimulatorPort._remove_device): Deleted.
942
943 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
944
945         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
946         https://bugs.webkit.org/show_bug.cgi?id=171164
947
948         Reviewed by Chris Fleizach.
949
950         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
951         AtkStateSet; not what is found in the AtkObject's attributes.
952
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
954         (WTR::AccessibilityUIElement::hasPopup):
955
956 2017-04-25  Alex Christensen  <achristensen@webkit.org>
957
958         Encoded filename should be decoded for WKContentExtension.identifier
959         https://bugs.webkit.org/show_bug.cgi?id=171316
960
961         Reviewed by Andy Estes.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
965         (TEST_F):
966         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
967
968 2017-04-25  Alex Christensen  <achristensen@webkit.org>
969
970         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
971         https://bugs.webkit.org/show_bug.cgi?id=171297
972         <rdar://problem/31530719>
973
974         Reviewed by Geoffrey Garen.
975
976         * TestWebKitAPI/PlatformWebView.h:
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
978         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
979         (TestWebKitAPI::didFinishLoadForFrame):
980         (TestWebKitAPI::mouseDidMoveOverElement):
981         (TestWebKitAPI::setClients):
982         (TestWebKitAPI::TEST):
983         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
984         (TestWebKitAPI::PlatformWebView::simulateRightClick):
985         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
986
987 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
988
989         Unreviewed, temporarily disable the data interaction unit tests.
990
991         The API around data interaction will change significantly in the near future, and
992         these tests will begin to fail. These will be reenabled once the bots are on an SDK
993         that supports the updated data interaction API.
994
995         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
996         * TestWebKitAPI/ios/DataInteractionSimulator.h:
997         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
998
999 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1000
1001         Limit allowed size of document.title to avoid locking WebKit clients
1002         https://bugs.webkit.org/show_bug.cgi?id=165113
1003         <rdar://problem/28324389>
1004
1005         Reviewed by Darin Adler.
1006
1007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1008         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
1009         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
1010         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
1011
1012 2017-04-25  John Wilander  <wilander@apple.com>
1013
1014         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
1015         https://bugs.webkit.org/show_bug.cgi?id=171295
1016         <rdar://problem/31823818>
1017
1018         Reviewed by Brent Fulgham.
1019
1020         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1021         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1022         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
1023         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
1024         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1025         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1026         * WebKitTestRunner/TestController.cpp:
1027         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
1028         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
1029         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1030         * WebKitTestRunner/TestController.h:
1031         * WebKitTestRunner/TestInvocation.cpp:
1032         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1033
1034 2017-04-25  Tim Horton  <timothy_horton@apple.com>
1035
1036         Try to fix the WKTR build after r215758
1037
1038         * Scripts/build-webkittestrunner:
1039
1040 2017-04-25  Daniel Bates  <dabates@apple.com>
1041
1042         Remove more EFL code
1043         https://bugs.webkit.org/show_bug.cgi?id=171288
1044
1045         Rubber-stamped by Simon Fraser.
1046
1047         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
1048         that was part of the EFL port.
1049
1050         * CMakeLists.txt:
1051         * DumpRenderTree/AccessibilityController.h:
1052         * DumpRenderTree/AccessibilityUIElement.cpp:
1053         (AccessibilityUIElement::getJSClass):
1054         * DumpRenderTree/AccessibilityUIElement.h:
1055         * DumpRenderTree/DumpRenderTree.h:
1056         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1057         * ImageDiff/efl/ImageDiff.cpp: Removed.
1058         * MiniBrowser/efl/CMakeLists.txt: Removed.
1059         * MiniBrowser/efl/main.c: Removed.
1060         * Scripts/build-dumprendertree:
1061         * Scripts/build-jsc:
1062         * Scripts/build-webkit:
1063         * Scripts/build-webkittestrunner:
1064         * Scripts/run-minibrowser:
1065         * Scripts/update-webkit-libs-jhbuild:
1066         * Scripts/update-webkitefl-libs: Removed.
1067         * Scripts/webkitdirs.pm:
1068         (argumentsForConfiguration):
1069         (extractNonMacOSHostConfiguration):
1070         (executableProductDir):
1071         (builtDylibPathForName):
1072         (determinePortName):
1073         (launcherPath):
1074         (launcherName):
1075         (getJhbuildPath):
1076         (wrapperPrefixIfNeeded):
1077         (generateBuildSystemFromCMakeProject):
1078         (buildCMakeProjectOrExit):
1079         (isEfl): Deleted.
1080         * Scripts/webkitperl/FeatureList.pm:
1081         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1082         * Scripts/webkitpy/common/config/ports.py:
1083         (DeprecatedPort.port):
1084         (GtkWK2Port.run_webkit_tests_command):
1085         (EflWK2Port): Deleted.
1086         (EflWK2Port.build_webkit_command): Deleted.
1087         * Scripts/webkitpy/port/builders.py:
1088         * Scripts/webkitpy/port/efl.py: Removed.
1089         * Scripts/webkitpy/port/efl_unittest.py: Removed.
1090         * Scripts/webkitpy/port/factory.py:
1091         (platform_options):
1092         (PortFactory):
1093         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1094         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1095         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1096         (TestRebaselineTest.test_baseline_directory):
1097         (TestRebaselineExpectations.test_rebaseline_expectations):
1098         * TestWebKitAPI/PlatformEfl.cmake: Removed.
1099         * TestWebKitAPI/PlatformWebView.h:
1100         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
1103         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
1104         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
1105         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
1106         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
1107         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
1108         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
1109         * TestWebKitAPI/efl/main.cpp: Removed.
1110         * WebKitTestRunner/EventSenderProxy.h:
1111         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1112         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1114         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1115         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1116         (WTR::EventSendingController::contextClick):
1117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1118         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1119         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1120         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1121         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
1122         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
1123         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
1124         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
1125         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
1126         * WebKitTestRunner/PlatformEfl.cmake: Removed.
1127         * WebKitTestRunner/PlatformWebView.h:
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::TestController::resetStateToConsistentValues):
1130         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
1131         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
1132         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
1133         * WebKitTestRunner/efl/main.cpp: Removed.
1134         * efl/install-dependencies: Removed.
1135         * efl/jhbuild-optional.modules: Removed.
1136         * efl/jhbuild.modules: Removed.
1137         * efl/jhbuildrc: Removed.
1138         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
1139         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
1140         * efl/patches/gst-libav.patch: Removed.
1141         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1142         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1143         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1144         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
1145         * gtk/manifest.txt.in:
1146
1147 2017-04-25  Daniel Bates  <dabates@apple.com>
1148
1149         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1150         https://bugs.webkit.org/show_bug.cgi?id=136452
1151         <rdar://problem/23412620>
1152
1153         Reviewed by Brent Fulgham.
1154
1155         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1156
1157         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
1158         as the EFL port is no longer in the WebKit OpenSource repository.
1159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1160
1161 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1162
1163         Unreviewed follow-up to r215739 and r215740.
1164
1165         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
1166         This (and r215740) was supposed to land in r215739, but I managed to
1167         specify the previous version of the patch.
1168
1169 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1170
1171         Unreviewed follow-up to r215739.
1172
1173         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
1174         libgcrypt patch that enforces the use of /dev/urandom.
1175
1176 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1177
1178         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
1179         https://bugs.webkit.org/show_bug.cgi?id=171270
1180
1181         Reviewed by Michael Catanzaro.
1182
1183         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
1184         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
1185         that use systems that don't yet provide libgcrypt >= 1.7.0.
1186
1187 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1188
1189         [GTK] Improve an unit test for the JHBuild wrapper.
1190         https://bugs.webkit.org/show_bug.cgi?id=168036
1191
1192         Unreviewed follow-up patch after r215727
1193
1194         * Scripts/webkitpy/port/base_unittest.py:
1195         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
1196         wasn't there before calling MockFileSystem.maybe_make_directory(), and
1197         also that it exists after calling it.
1198
1199 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1200
1201         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
1202         https://bugs.webkit.org/show_bug.cgi?id=168036
1203
1204         Reviewed by Michael Catanzaro.
1205
1206         Call ImageDiff with the JHBuild wrapper if we should use it.
1207         Also add some unit tests for the JHBuild wrapper feature.
1208
1209         * Scripts/webkitpy/port/base.py:
1210         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
1211         * Scripts/webkitpy/port/base_unittest.py:
1212         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
1213         * Scripts/webkitpy/port/image_diff.py:
1214         (ImageDiffer._start): The actual fix, use the wrapper if we should.
1215         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
1216         * Scripts/webkitpy/port/port_testcase.py:
1217         (PortTestCase):
1218         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
1219         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
1220         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
1221
1222 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1223
1224         Support reading NSURL titles from the pasteboard when performing data interaction
1225         https://bugs.webkit.org/show_bug.cgi?id=171156
1226         <rdar://problem/31356937>
1227
1228         Reviewed by Tim Horton.
1229
1230         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
1231
1232         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1233         (TestWebKitAPI::TEST):
1234
1235 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1236
1237         Respect fidelity order when reading web content from item providers
1238         https://bugs.webkit.org/show_bug.cgi?id=171155
1239         <rdar://problem/31356937>
1240
1241         Reviewed by Tim Horton.
1242
1243         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
1244         more details.
1245
1246         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1247         (TestWebKitAPI::TEST):
1248
1249 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1250
1251         SyntaxError fix after r215702.
1252         https://bugs.webkit.org/show_bug.cgi?id=168944
1253
1254         Unreviewed "build" fix.
1255
1256         * BuildSlaveSupport/built-product-archive:
1257         (archiveBuiltProduct):
1258
1259 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
1260
1261         Package ImageDiff built with host SDK
1262         https://bugs.webkit.org/show_bug.cgi?id=168944
1263         <rdar://problem/30745642>
1264
1265         Reviewed by David Kilzer.
1266
1267         iOS Simulator and iOS device should archive the ImageDiff built for the host
1268         machine.
1269
1270         * BuildSlaveSupport/built-product-archive:
1271         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
1272         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
1273
1274 2017-04-24  Keith Miller  <keith_miller@apple.com>
1275
1276         ThreadMessage API tests failing on release bots
1277         https://bugs.webkit.org/show_bug.cgi?id=171246
1278
1279         Reviewed by Saam Barati.
1280
1281         Need to make sure that C++ doesn't optimize away our spin loop.
1282
1283         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1284         (runThreadMessageTest):
1285         (TEST):
1286
1287 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1288
1289         Reduce copies and allocations in SharedBuffer::append
1290         https://bugs.webkit.org/show_bug.cgi?id=170956
1291
1292         Reviewed by Andreas Kling.
1293
1294         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1295         (TestWebKitAPI::TEST_F):
1296
1297 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1298
1299         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
1300         https://bugs.webkit.org/show_bug.cgi?id=166680
1301
1302         Reviewed by Michael Catanzaro.
1303
1304         Update remote inspector unit tests.
1305
1306         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
1307         (main):
1308         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1309         (connectToInspectorServer):
1310         (waitUntilInspectorServerIsReady):
1311         (startTestServer):
1312         (testInspectorServerPageList):
1313         (beforeAll):
1314
1315 2017-04-23  Youenn Fablet  <youenn@apple.com>
1316
1317         Add a tool to update expected.txt files from EWS bot results
1318         https://bugs.webkit.org/show_bug.cgi?id=169538
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         This script updates expected-txt files from bugzilla posted EWS results.
1323         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
1324         have results different from the generic baseline.
1325
1326         * Scripts/update-test-expectations-from-bugzilla: Added.
1327         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
1328         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
1329         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
1330
1331 2017-04-22  Youenn Fablet  <youenn@apple.com>
1332
1333         Add an option to import tip-of-tree WPT tests
1334         https://bugs.webkit.org/show_bug.cgi?id=171152
1335
1336         Reviewed by Joseph Pecoraro.
1337
1338         Adding a '-t' option to import tip of tree WPT tests.
1339         Updating importer based on the fact that csswg-test is no longer a thing. 
1340
1341         * Scripts/webkitpy/w3c/test_downloader.py:
1342         (TestDownloader.download_tests):
1343         * Scripts/webkitpy/w3c/test_importer.py:
1344         (configure_logging):
1345         (TestImporter.do_import):
1346         (TestImporter.write_import_log):
1347
1348 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1349
1350         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
1351         https://bugs.webkit.org/show_bug.cgi?id=171177
1352         <rdar://problem/31765379>
1353
1354         Reviewed by Andy Estes.
1355
1356         Tests uploading a JSON file to a file input.
1357
1358         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1359         (TestWebKitAPI::TEST):
1360
1361 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1362
1363         Support writing link titles to the pasteboard when beginning data interaction on a link
1364         https://bugs.webkit.org/show_bug.cgi?id=171154
1365         <rdar://problem/31356937>
1366
1367         Reviewed by Andy Estes.
1368
1369         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
1370         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
1371         matching the title of the link.
1372
1373         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1374         (TestWebKitAPI::TEST):
1375
1376 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1377
1378         Unreviewed, rolling out r215608.
1379
1380         Hundreds of test failures on GTK bot
1381
1382         Reverted changeset:
1383
1384         "Reduce copies and allocations in SharedBuffer::append"
1385         https://bugs.webkit.org/show_bug.cgi?id=170956
1386         http://trac.webkit.org/changeset/215608
1387
1388 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1389
1390         [WK2] Add delegate hooks for overriding unhanded data interaction operations
1391         https://bugs.webkit.org/show_bug.cgi?id=171005
1392         <rdar://problem/31669646>
1393
1394         Reviewed by Tim Horton.
1395
1396         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
1397         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
1398         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
1399
1400         New API test:
1401         DataInteractionTests.OverrideDataInteractionOperation
1402
1403         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1404         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1405         (TestWebKitAPI::TEST):
1406         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1407         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1408         (-[DataInteractionSimulator initWithWebView:]):
1409         (-[DataInteractionSimulator dealloc]):
1410         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1411         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
1412         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
1413
1414 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
1415
1416         Temporarily disable two flaky API tests.
1417
1418         Unreviewed test gardening.
1419
1420         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1421         (TEST):
1422         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1423         (TEST):
1424
1425 2017-04-21  Keith Miller  <keith_miller@apple.com>
1426
1427         Unreviewed, rolling out r215634.
1428
1429         underlying build issues should have been fixed
1430
1431         Reverted changeset:
1432
1433         "Unreviewed, rolling out r215620 and r215623."
1434         https://bugs.webkit.org/show_bug.cgi?id=171139
1435         http://trac.webkit.org/changeset/215634
1436
1437 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
1438
1439         Bubbles on dashboard doesn't turn red for test262 failures
1440         https://bugs.webkit.org/show_bug.cgi?id=171129
1441
1442         Reviewed by Alexey Proskuryakov.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
1445
1446 2017-04-21  Commit Queue  <commit-queue@webkit.org>
1447
1448         Unreviewed, rolling out r215620 and r215623.
1449         https://bugs.webkit.org/show_bug.cgi?id=171139
1450
1451         broke arm64 build (Requested by keith_miller on #webkit).
1452
1453         Reverted changesets:
1454
1455         "Add signaling API"
1456         https://bugs.webkit.org/show_bug.cgi?id=170976
1457         http://trac.webkit.org/changeset/215620
1458
1459         "Unreviewed, fix Cloop build."
1460         http://trac.webkit.org/changeset/215623
1461
1462 2017-04-20  Keith Miller  <keith_miller@apple.com>
1463
1464         Add signaling API
1465         https://bugs.webkit.org/show_bug.cgi?id=170976
1466
1467         Reviewed by Filip Pizlo.
1468
1469         Add tests for ThreadMessages.
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
1473         (runThreadMessageTest):
1474         (TEST):
1475
1476 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
1477
1478         commit-log-editor should respect the git editor if one is set
1479         https://bugs.webkit.org/show_bug.cgi?id=171085
1480         <rdar://problem/31745506>
1481
1482         Reviewed by Daniel Bates.
1483
1484         * Scripts/commit-log-editor:
1485         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
1486         deciding which editor to present. We examine the global editor preference since that may be
1487         set automatically by installers or third-party tools.
1488
1489 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1490
1491         Reduce copies and allocations in SharedBuffer::append
1492         https://bugs.webkit.org/show_bug.cgi?id=170956
1493
1494         Reviewed by Andreas Kling.
1495
1496         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1497         (TestWebKitAPI::TEST_F):
1498
1499 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
1500
1501         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
1502         https://bugs.webkit.org/show_bug.cgi?id=171071
1503
1504         Reviewed by Michael Catanzaro.
1505
1506         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
1507         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
1508         be available for all ports.
1509
1510         * DumpRenderTree/PlatformMac.cmake:
1511         * MiniBrowser/mac/CMakeLists.txt:
1512         * MiniBrowser/win/CMakeLists.txt:
1513         * TestWebKitAPI/PlatformJSCOnly.cmake:
1514         * TestWebKitAPI/PlatformMac.cmake:
1515         * TestWebKitAPI/PlatformWin.cmake:
1516         * WebKitTestRunner/PlatformMac.cmake:
1517
1518 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
1519
1520         Test262 bot does not go red with failures
1521         https://bugs.webkit.org/show_bug.cgi?id=171044
1522
1523         Reviewed by Aakash Jain.
1524
1525         The piped output of run-jsc-stress-tests is different from
1526         its non-piped output. Switch to parsing the correct output.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1529         (RunTest262Tests.countFailures):
1530         Just count the number of lines that start with "FAIL:".
1531
1532         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1533         (RunTest262TestsTest.test_no_regressions_output):
1534         (test_failure_output):
1535         (test_failures_output):
1536         Updated tests with new sample output produced partially from bots and
1537         locally. In cases of failure the return code of run-jsc-stress-tests
1538         is still 0 so update the expected return code in the tests.
1539
1540 2017-04-20  Brady Eidson  <beidson@apple.com>
1541
1542         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
1543         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
1544
1545         Reviewed by Andy Estes.
1546
1547         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
1548         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1549         (resetToConsistentState):
1550         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
1551         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1552         (TEST):
1553         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1554
1555 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1556
1557         [ios-simulator] PositionInformationTests API tests are timing out
1558         https://bugs.webkit.org/show_bug.cgi?id=171089
1559
1560         Rubber-stamped by Tim Horton.
1561
1562         Addresses failures observed in the new position information tests added in r215573 by only running them if the
1563         DATA_INTERACTION feature flag is enabled.
1564
1565         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1566
1567 2017-04-20  Brady Eidson  <beidson@apple.com>
1568
1569         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
1570         https://bugs.webkit.org/show_bug.cgi?id=171083
1571
1572         Unreviewed.
1573
1574         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1575
1576 2017-04-20  Brady Eidson  <beidson@apple.com>
1577
1578         Add CompletionHandlerCallChecker to SPI added in r215545.
1579         https://bugs.webkit.org/show_bug.cgi?id=171067
1580
1581         Reviewed by Dan Bernstein.
1582
1583         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1584         (TEST):
1585         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1586
1587 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1588
1589         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
1590         https://bugs.webkit.org/show_bug.cgi?id=170922
1591         <rdar://problem/31634990>
1592
1593         Reviewed by Tim Horton.
1594
1595         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
1596         WebKit2 ChangeLog for more details.
1597
1598         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1599         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
1600         (TestWebKitAPI::TEST):
1601         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
1602
1603 2017-04-20  Xan Lopez  <xlopez@igalia.com>
1604
1605         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
1606         https://bugs.webkit.org/show_bug.cgi?id=170942
1607
1608         Reviewed by Carlos Garcia Campos.
1609
1610         Update glib and glib-networking to the last stable releases. This
1611         is needed to get working TLS certificate verification at all at
1612         least in Fedora.
1613
1614         * gtk/install-dependencies: add libmount, needed for newer glib.
1615         * gtk/jhbuild.modules: update glib and glib-networking to last
1616         stable releases.
1617
1618 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
1619
1620         [ATK] Implement support for DPub ARIA roles
1621         https://bugs.webkit.org/show_bug.cgi?id=170679
1622
1623         Reviewed by Chris Fleizach.
1624
1625         Add DPub ARIA landmark roles to roleToString().
1626
1627         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1628
1629 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
1630
1631         Remove WebKitTestRunner code for enabling features that are already enabled by default
1632         https://bugs.webkit.org/show_bug.cgi?id=171033
1633
1634         Reviewed by Ryosuke Niwa.
1635
1636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1637         (WTR::InjectedBundle::beginTesting):
1638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1639         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
1640         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
1641         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
1642         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
1643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1644
1645 2017-04-19  Youenn Fablet  <youenn@apple.com>
1646
1647         [Mac] Allow customizing H264 encoder
1648         https://bugs.webkit.org/show_bug.cgi?id=170829
1649
1650         Reviewed by Alex Christensen.
1651
1652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1653
1654 2017-04-19  Brady Eidson  <beidson@apple.com>
1655
1656         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
1657         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
1658
1659         Reviewed by Tim Horton.
1660
1661         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1662         (TEST):
1663         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1664         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1665
1666 2017-04-19  Brady Eidson  <beidson@apple.com>
1667
1668         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
1669         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
1670
1671         Reviewed by Alex Christensen.
1672
1673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1674         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
1675
1676 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
1677
1678         [WK2] Run tests with ResourceLoadStatistics enabled
1679         https://bugs.webkit.org/show_bug.cgi?id=170952
1680
1681         Reviewed by Andy Estes.
1682
1683         Excercise the load statistics code during tests.
1684
1685         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1686         (WTR::initializeWebViewConfiguration):
1687
1688 2017-04-19  Bill Ming  <mbbill@gmail.com>
1689
1690         close_fds should be set to False on Windows.
1691         https://bugs.webkit.org/show_bug.cgi?id=170838
1692
1693         Reviewed by Brent Fulgham.
1694
1695         * Scripts/webkitpy/common/system/executive.py:
1696         (Executive._should_close_fds):
1697
1698 2017-04-19  David Kilzer  <ddkilzer@apple.com>
1699
1700         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
1701         <https://webkit.org/b/170994>
1702         <rdar://problem/29889932>
1703
1704         Reviewed by Brent Fulgham.
1705
1706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1707         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
1708         target.
1709         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
1710         (TestWebKitAPI::strip): Helper method to set/get environment
1711         variable for testing.
1712         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
1713         tests.
1714
1715 2017-04-19  JF Bastien  <jfbastien@apple.com>
1716
1717         WebAssembly: add script which can import GCC torture tests
1718         https://bugs.webkit.org/show_bug.cgi?id=170740
1719
1720         Reviewed by Saam Barati.
1721
1722         Add a script which can import the GCC torture tests and create a
1723         yaml file to run them as part of jsc's WebAssembly regression
1724         tests.
1725
1726         This patch doesn't commit the tests themselves because they're
1727         licensed differently.
1728
1729         * Scripts/run-jsc-stress-tests: learn how to run
1730         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
1731         the options because WebAssembly is enabled by default.
1732         * Scripts/update-wasm-gcc-torture.py: Added.
1733         (parse_args):
1734         (update_lkgr):
1735         (untar_torture):
1736         (list_js_files):
1737         (waterfall_known_failures):
1738         (create_yaml):
1739         (main):
1740
1741 2017-04-19  Youenn Fablet  <youenn@apple.com>
1742
1743         Import web-platform-tests/tools
1744         https://bugs.webkit.org/show_bug.cgi?id=170718
1745
1746         Reviewed by Alex Christensen.
1747
1748         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1749         (main):
1750         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1751         (WebPlatformTestServer.ports_to_forward):
1752         (WebPlatformTestServer._prepare_config):
1753         (WebPlatformTestServer._install_modules): Deleted.
1754         * Scripts/webkitpy/w3c/test_importer.py:
1755         (TestImporter.write_html_files_for_templated_js_tests):
1756
1757 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1758
1759         [WK2] Add infrastructure and unit tests for file uploads using data interaction
1760         https://bugs.webkit.org/show_bug.cgi?id=170903
1761         <rdar://problem/31314689>
1762
1763         Reviewed by Tim Horton.
1764
1765         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
1766         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
1767         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
1768         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
1769
1770         New tests:
1771         DataInteractionTests.ExternalSourceImageToFileInput
1772         DataInteractionTests.ExternalSourceHTMLToUploadArea
1773         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
1774         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
1775         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
1776
1777         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1778         (testIconImage):
1779         (temporaryURLForDataInteractionFileLoad):
1780         (cleanUpDataInteractionTemporaryPath):
1781
1782         Creates and tears down temporary file directories for testing data interaction.
1783
1784         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1787         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1788
1789         Make necessary changes to be able to test what happens when data interaction ends over an element with no
1790         operation. Previously, we would always simulate performing a data interaction operation when ending the
1791         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
1792         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
1793         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
1794         the phase to Cancelled and end the run.
1795
1796         (-[DataInteractionSimulator _resetSimulatedState]):
1797         (-[DataInteractionSimulator runFrom:to:]):
1798         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1799         (-[DataInteractionSimulator _advanceProgress]):
1800         (-[DataInteractionSimulator externalItemProviders]):
1801         (-[DataInteractionSimulator setExternalItemProviders:]):
1802
1803         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
1804         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
1805         take multiple item providers.
1806
1807         (-[DataInteractionSimulator externalItemProvider]): Deleted.
1808         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
1809
1810 2017-04-18  John Wilander  <wilander@apple.com>
1811
1812         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
1813         https://bugs.webkit.org/show_bug.cgi?id=170798
1814         <rdar://problem/31595108>
1815
1816         Reviewed by Alex Christensen.
1817
1818         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
1819         (TestWebKitAPI::TEST_F):
1820             Added two negative test cases for WebCore::isPublicSuffix().
1821             Added test cases with mixed case domains, localhost, and
1822             non-ASCII for WebCore::topPrivatelyControlledDomain().
1823
1824 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
1825
1826         Unreviewed, rolling out r215346 and 215361.
1827
1828         The problem these changes were fixing was addressed in
1829         <https://trac.webkit.org/changeset/215416/webkit>.
1830
1831         Reverted changesets:
1832
1833         "webkitpy: Ignore previously launched pid when system is under
1834         stress"
1835         https://bugs.webkit.org/show_bug.cgi?id=170741
1836         http://trac.webkit.org/changeset/215346
1837         http://trac.webkit.org/changeset/215361
1838
1839 2017-04-17  Alex Christensen  <achristensen@webkit.org>
1840
1841         Allow Variants of RetainPtrs
1842         https://bugs.webkit.org/show_bug.cgi?id=170923
1843
1844         Reviewed by Tim Horton and Sam Weinig.
1845
1846         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1847         (TestWebKitAPI::TEST):
1848         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
1849         work in Variants.
1850
1851 2017-04-17  Brady Eidson  <beidson@apple.com>
1852
1853         Make WKHTTPCookieStore public.
1854         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
1855
1856         Reviewed by Geoffrey Garen.
1857
1858         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1859         (TEST):
1860
1861 2017-04-17  Youenn Fablet  <youenn@apple.com>
1862
1863         Disable outdated WritableStream API
1864         https://bugs.webkit.org/show_bug.cgi?id=170749
1865         <rdar://problem/31446233>
1866
1867         Reviewed by Alex Christensen.
1868
1869         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
1870         - A STREAMS_API compilation flag.
1871         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
1872
1873         * DumpRenderTree/mac/DumpRenderTree.mm:
1874         (enableExperimentalFeatures):
1875         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1877         (WTR::InjectedBundle::beginTesting):
1878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1879         (WTR::TestRunner::setFetchAPIEnabled):
1880         (WTR::TestRunner::setWritableStreamAPIEnabled):
1881         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1883
1884 2017-04-17  Tim Horton  <timothy_horton@apple.com>
1885
1886         Provide a viewport parameter to disable clipping to the safe area
1887         https://bugs.webkit.org/show_bug.cgi?id=170766
1888         <rdar://problem/31564634>
1889
1890         Reviewed by Beth Dakin.
1891
1892         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1893         (WTR::UIScriptController::setObscuredInsets):
1894         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1895         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1896         (WTR::UIScriptController::setObscuredInsets):
1897         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1898         * WebKitTestRunner/ios/TestControllerIOS.mm:
1899         (WTR::TestController::platformResetStateToConsistentValues):
1900         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1901         (WTR::UIScriptController::setObscuredInsets):
1902         Add a UIScriptController mechanism to install obscured insets
1903         on the web view.
1904
1905 2017-04-17  Dan Bernstein  <mitz@apple.com>
1906
1907         [Cocoa] Move isNullFunctionPointer down into WTF
1908         https://bugs.webkit.org/show_bug.cgi?id=170892
1909
1910         Reviewed by Sam Weinig.
1911
1912         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
1915         (TestWebKitAPI::TEST):
1916         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
1917         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
1918         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
1919         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
1920
1921 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
1922
1923         webkitpy: Correct poll when killing ServerProcess
1924
1925         Unreviewed infrastructure fix.
1926
1927         * Scripts/webkitpy/port/server_process.py:
1928         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
1929
1930 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
1931
1932         [MediaStream] Enable getUserMedia API test
1933         https://bugs.webkit.org/show_bug.cgi?id=170901
1934         <rdar://problem/31656594>
1935
1936         Reviewed by Youenn Fablet.
1937
1938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
1939
1940         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1941         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1942         (TestWebKitAPI::TEST): Enable capture with mock devices.
1943         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
1944
1945 2017-04-17  Xan Lopez  <xan@igalia.com>
1946
1947         [GTK] Update the Fedora dependencies for WebKitGTK+
1948         https://bugs.webkit.org/show_bug.cgi?id=170590
1949
1950         Reviewed by Carlos Alberto Lopez Perez.
1951
1952         * gtk/install-dependencies: add a bunch of modules necessary to
1953         get a proper set of GStreamer codecs for WebRTC.
1954
1955 2017-04-16  Sam Weinig  <sam@webkit.org>
1956
1957         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
1958         https://bugs.webkit.org/show_bug.cgi?id=170843
1959
1960         Reviewed by Chris Dumez.
1961
1962         * DumpRenderTree/DerivedSources.make:
1963         * WebKitTestRunner/DerivedSources.make:
1964         * Scripts/webkitpy/bindings/main.py:
1965         (BindingsTests.generate_from_idl):
1966         Pass IDLAttributes.json, as it is now mandatory to have one.
1967
1968 2017-04-14  Mark Lam  <mark.lam@apple.com>
1969
1970         Update architectures in xcconfig files.
1971         https://bugs.webkit.org/show_bug.cgi?id=170867
1972         <rdar://problem/31628104>
1973
1974         Reviewed by Joseph Pecoraro.
1975
1976         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1977         * MobileMiniBrowser/Configurations/Base.xcconfig:
1978         * TestWebKitAPI/Configurations/Base.xcconfig:
1979         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1980         * WebKitTestRunner/Configurations/Base.xcconfig:
1981
1982 2017-04-14  Brady Eidson  <beidson@apple.com>
1983
1984         Fix basic WKURLSchemeHandler bugs.
1985         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
1986
1987         Reviewed by Andy Estes.
1988
1989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1990         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
1991         (-[SchemeHandler initWithData:mimeType:]):
1992         (-[SchemeHandler dealloc]):
1993         (-[SchemeHandler webView:startTask:]):
1994         (-[SchemeHandler webView:stopTask:]):
1995         (TEST):
1996
1997 2017-04-14  Bill Ming  <mbbill@gmail.com>
1998
1999         webkit-patch failed to detect git repository
2000         https://bugs.webkit.org/show_bug.cgi?id=170859
2001
2002         Reviewed by Daniel Bates.
2003
2004         Windows cmd does not accept single quoted path. So, using
2005         double quotes here will provide better platform compatibility.
2006
2007         * Scripts/VCSUtils.pm:
2008         (isGitDirectory):
2009         (isGitSVNDirectory):
2010         (svnRevisionForDirectory):
2011         (svnInfoForPath):
2012
2013 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2014
2015         Unreviewed, rolling out r215374.
2016
2017         This change causes LayoutTests to exit early with crashes on
2018         Sierra.
2019
2020         Reverted changeset:
2021
2022         "webkitpy: Ignore previously launched pid when system is under
2023         stress"
2024         https://bugs.webkit.org/show_bug.cgi?id=170741
2025         http://trac.webkit.org/changeset/215374
2026
2027 2017-04-14  Dan Bernstein  <mitz@apple.com>
2028
2029         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
2030         https://bugs.webkit.org/show_bug.cgi?id=170856
2031
2032         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
2033
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2035
2036 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2037
2038         webkitpy: Ignore previously launched pid when system is under stress
2039         https://bugs.webkit.org/show_bug.cgi?id=170741
2040
2041         Unreviewed infrastructure fix.
2042
2043         Drivers are destroyed between failing layout tests, which is not necessary and
2044         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2045
2046         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2047         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2048         * Scripts/webkitpy/port/driver.py:
2049         (Driver.stop): Reset driver values set in initializer.
2050
2051 2017-04-14  Andy Estes  <aestes@apple.com>
2052
2053         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2054         https://bugs.webkit.org/show_bug.cgi?id=167594
2055
2056         Re-enabled this API test now that webkit.org/b/161967 is fixed.
2057
2058         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2059         (TEST):
2060
2061 2017-04-14  Andy Estes  <aestes@apple.com>
2062
2063         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
2064         https://bugs.webkit.org/show_bug.cgi?id=161967
2065
2066         Reviewed by Alexey Proskuryakov.
2067
2068         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2069         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
2070
2071 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2072
2073         Unreviewed, rolling out r215363.
2074
2075         This change causes LayoutTests to exit early with crashes.
2076
2077         Reverted changeset:
2078
2079         "webkitpy: Ignore previously launched pid when system is under
2080         stress"
2081         https://bugs.webkit.org/show_bug.cgi?id=170741
2082         http://trac.webkit.org/changeset/215363
2083
2084 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2085
2086         webkitpy: Ignore previously launched pid when system is under stress
2087         https://bugs.webkit.org/show_bug.cgi?id=170741
2088
2089         Unreviewed infrastructure fix.
2090
2091         Drivers are destroyed between failing layout tests, which is not necessary and
2092         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2093
2094         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2095         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2096
2097 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2098
2099         webkitpy: Ignore previously launched pid when system is under stress
2100         https://bugs.webkit.org/show_bug.cgi?id=170741
2101
2102         Unreviewed infrastructure fix.
2103
2104         Server processes are destroyed in the driver, which is not necessary and prevents
2105         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2106
2107         * Scripts/webkitpy/port/driver.py:
2108         (Driver.run_test): Do not destroy server process.
2109         (Driver._start): Only create the server process if it is None.
2110         (Driver.stop): Do not destroy server process.
2111
2112 2017-04-13  Dan Bernstein  <mitz@apple.com>
2113
2114         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
2115         https://bugs.webkit.org/show_bug.cgi?id=170387
2116
2117         Reviewed by Sam Weinig.
2118
2119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2120         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
2121         (TEST):
2122         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
2123         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2124         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
2125         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
2127
2128 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
2129
2130         webkitpy: Ignore previously launched pid when system is under stress
2131         https://bugs.webkit.org/show_bug.cgi?id=170741
2132
2133         Reviewed by David Kilzer.
2134
2135         We have seen cases where xcrun simctl launch will return a pid of a previous
2136         process and the process will appear to be running even though it is crashing.
2137         Ensure that the PID that simulator_process is receiving is not the pid of the
2138         previously run process.
2139
2140         * Scripts/webkitpy/port/simulator_process.py:
2141         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
2142
2143 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
2144
2145         Build ImageDiff with host SDK
2146         https://bugs.webkit.org/show_bug.cgi?id=168531
2147
2148         Reviewed by David Kilzer.
2149
2150         ImageDiff should be built and run with the host SDK, not the target SDK.
2151         Build ImageDiff twice, once for the target SDK and once for the host
2152         as an intermediate step towards building for only the host SDK.
2153
2154         * ImageDiff/Makefile: Added.
2155         * Makefile: Add ImageDiff to list of targets.
2156         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
2157         * Scripts/build-webkit: Build ImageDiff for host.
2158         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
2159         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
2160         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
2161         * Scripts/webkitpy/port/base.py:
2162         (Port.check_build): Attempt to build image diff if not found.
2163         (Port.check_image_diff): Enable logging flag.
2164         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
2165
2166 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2167
2168         Clean up SharedBuffer public functions
2169         https://bugs.webkit.org/show_bug.cgi?id=170795
2170
2171         Reviewed by Andreas Kling.
2172
2173         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2174         (TestWebKitAPI::TEST_F):
2175
2176 2017-04-12  Dan Bernstein  <mitz@apple.com>
2177
2178         [Mac] Future-proof .xcconfig files
2179         https://bugs.webkit.org/show_bug.cgi?id=170802
2180
2181         Reviewed by Tim Horton.
2182
2183         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2184         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2185         * MiniBrowser/Configurations/Base.xcconfig:
2186         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2187         * TestWebKitAPI/Configurations/Base.xcconfig:
2188         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2190         * WebKitTestRunner/Configurations/Base.xcconfig:
2191         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2192
2193 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2194
2195         Remove unused SharedBuffer::wrapCFDataArray
2196         https://bugs.webkit.org/show_bug.cgi?id=170794
2197
2198         Reviewed by Brady Eidson.
2199
2200         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2201         (TestWebKitAPI::TEST_F):
2202
2203 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2204
2205         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
2206         https://bugs.webkit.org/show_bug.cgi?id=170502
2207
2208         Reviewed by Mark Lam.
2209
2210         Mechanical change. Use Thread:: APIs.
2211
2212         * DumpRenderTree/JavaScriptThreading.cpp:
2213         (runJavaScriptThread):
2214         (startJavaScriptThreads):
2215         (stopJavaScriptThreads):
2216         * DumpRenderTree/mac/DumpRenderTree.mm:
2217         (testThreadIdentifierMap):
2218         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2219         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2220         (TestWebKitAPI::runLockTest):
2221         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2222
2223 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2224
2225         Modernize vector adoption
2226         https://bugs.webkit.org/show_bug.cgi?id=170758
2227
2228         Reviewed by Geoffrey Garen.
2229
2230         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2231         (TestWebKitAPI::TEST_F):
2232
2233 2017-04-11  Dean Jackson  <dino@apple.com>
2234
2235         Disable outdated WritableStream API
2236         https://bugs.webkit.org/show_bug.cgi?id=170749
2237         <rdar://problem/31446233>
2238
2239         Reviewed by Tim Horton.
2240
2241         The API we implement is no longer accurate. Disable it until we
2242         are compatible with the new specification
2243
2244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2245
2246 2017-04-11  David Quesada  <david_quesada@apple.com>
2247
2248         Add SPI for handling geolocation authorization requests
2249         https://bugs.webkit.org/show_bug.cgi?id=170362
2250         rdar://problem/17508627
2251
2252         Reviewed by Alex Christensen.
2253
2254         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
2255         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
2256         provide a stub object to simulate the various configurations of geolocation permissions:
2257         1. The app doesn't have permission to use geolocation.
2258         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
2259         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
2260
2261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2262         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
2263         (-[TestCoreLocationProvider setListener:]):
2264         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
2265         (-[TestCoreLocationProvider start]):
2266         (-[TestCoreLocationProvider stop]):
2267         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
2268         (expectException):
2269         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
2270         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
2273
2274 2017-04-10  Matt Rajca  <mrajca@apple.com>
2275
2276         Change autoplay state to "prevented" when media is paused due to restrictions.
2277         https://bugs.webkit.org/show_bug.cgi?id=170686
2278
2279         Reviewed by Alex Christensen.
2280
2281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2282         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
2283         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2284         (TEST):
2285
2286 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
2287
2288         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
2289         https://bugs.webkit.org/show_bug.cgi?id=170725
2290
2291         Reviewed by Sam Weinig.
2292
2293         * TestWebKitAPI/Tests/WTF/Time.cpp:
2294         (TestWebKitAPI::TEST):
2295
2296 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2297
2298         Revert r215217
2299         https://bugs.webkit.org/show_bug.cgi?id=170703
2300
2301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2302
2303 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2304
2305         Continue enabling WebRTC
2306         https://bugs.webkit.org/show_bug.cgi?id=170703
2307
2308         Reviewed by Youenn Fablet.
2309
2310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2311
2312 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
2313
2314         Have parseRevisionProperty use default repo name as the Buildbot key.
2315         https://bugs.webkit.org/show_bug.cgi?id=170696
2316
2317         Reviewed by Daniel Bates.
2318
2319         Previously, we needed to set a key and a fallbackKey when addressing
2320         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
2321         that the repo name maps exactly to that key for every repository other
2322         than WebKit.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2325         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
2326
2327 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
2328
2329         Add test262 JavaScriptCore tests to dashboard
2330         https://bugs.webkit.org/show_bug.cgi?id=170711
2331
2332         Rubber-stamped by Joseph Pecoraro.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2335         (WebKitBuildbot): Added test262 JSC tests to dashboard.
2336
2337 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2338
2339         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
2340         https://bugs.webkit.org/show_bug.cgi?id=170707
2341         <rdar://problem/27788755>
2342
2343         Reviewed by Tim Horton.
2344
2345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
2346         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2347         (TEST_F):
2348         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2349         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2350         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2351         (TEST):
2352
2353 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2354
2355         Add API to get available content extension identifiers in a WKContentExtensionStore
2356         https://bugs.webkit.org/show_bug.cgi?id=170093
2357
2358         Reviewed by Geoffrey Garen.
2359
2360         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
2361         (TEST_F):
2362
2363 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2364
2365         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
2366         https://bugs.webkit.org/show_bug.cgi?id=170658
2367
2368         Reviewed by Tim Horton.
2369
2370         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
2371         preparation is synchronous, or passes if it is asynchronous.
2372
2373         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2374         (TestWebKitAPI::TEST):
2375         * TestWebKitAPI/cocoa/TestWKWebView.h:
2376         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2377         (-[TestWKWebView initWithFrame:]):
2378         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
2379         (-[TestWKWebView _setUpTestWindow:]):
2380
2381 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
2382
2383         [WK2][macOS] Block access to Apple Events before launch.
2384         https://bugs.webkit.org/show_bug.cgi?id=170626
2385         <rdar://problem/16079334>
2386
2387         Reviewed by Alexey Proskuryakov.
2388
2389         Add a new TestWebKitAPI test that fails if Apple Events are sent.
2390
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2392         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
2393         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2394         (TestWebKitAPI::didFinishLoadForFrame):
2395         (TestWebKitAPI::TEST):
2396         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
2397         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
2398         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
2399
2400 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
2401
2402         [JSC] Do not run FTL stress tests on MIPS
2403         https://bugs.webkit.org/show_bug.cgi?id=170684
2404
2405         Reviewed by Carlos Alberto Lopez Perez.
2406
2407         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
2408         logic to detect if the platform supports FTL ignores that MIPS does
2409         not support FTL. This adds detection of MIPS (with the magic number
2410         determined empirically) and fixes the determination of whether we
2411         support FTL.
2412
2413         * Scripts/run-jsc-stress-tests:
2414
2415 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
2416
2417         webkitpy: Increase estimate for processes run by iOS Simulators
2418         https://bugs.webkit.org/show_bug.cgi?id=170678
2419         <rdar://problem/31534061>
2420
2421         Reviewed by Aakash Jain.
2422
2423         Previously, it was estimated that each simulated iOS device would run about 100
2424         processes.  With newer versions of iOS, this is closer to 125.
2425
2426         * Scripts/webkitpy/port/ios_simulator.py:
2427         (IOSSimulatorPort): Increase process estimate from 100 to 125.
2428
2429 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
2430
2431         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
2432         https://bugs.webkit.org/show_bug.cgi?id=170553
2433
2434         Reviewed by Michael Catanzaro.
2435
2436         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
2437         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
2438         to properly position popup menus, and also avoids using functions
2439         which were deprecated starting at that GTK+ release.
2440
2441         * MiniBrowser/gtk/BrowserSearchBar.c:
2442         (searchEntryMenuIconPressedCallback):
2443         Update MiniBrowser to use gtk_menu_popup_at_pointer().
2444
2445 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2446
2447         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
2448         https://bugs.webkit.org/show_bug.cgi?id=170677
2449         <rdar://problem/31512633>
2450
2451         Reviewed by Tim Horton.
2452
2453         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
2454         to allow dropping URLs to trigger page navigation.
2455
2456         * DumpRenderTree/TestOptions.h:
2457         * DumpRenderTree/TestOptions.mm:
2458         (TestOptions::TestOptions):
2459         * DumpRenderTree/mac/DumpRenderTree.mm:
2460         (resetWebViewToConsistentStateBeforeTesting):
2461         * DumpRenderTree/mac/UIDelegate.h:
2462         * DumpRenderTree/mac/UIDelegate.mm:
2463         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
2464         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2465
2466 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2467
2468         update-webkit-dependency should report $response->message for diagnose
2469         https://bugs.webkit.org/show_bug.cgi?id=170666
2470
2471         Reviewed by Alex Christensen.
2472
2473         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
2474
2475 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2476
2477         Data interaction on an image enclosed by an anchor should vend the anchor's URL
2478         https://bugs.webkit.org/show_bug.cgi?id=170660
2479         <rdar://problem/31043220>
2480
2481         Reviewed by Tim Horton.
2482
2483         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
2484         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
2485         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
2486         rects, but should not be.
2487
2488         See WebCore ChangeLog for more details.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
2492         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2493         (TestWebKitAPI::TEST):
2494
2495 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2496
2497         [GTK] Remove the GDK dependency from ImageDiff
2498         https://bugs.webkit.org/show_bug.cgi?id=85299
2499
2500         Reviewed by Žan Doberšek.
2501
2502         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
2503         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
2504         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
2505         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
2506         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
2507         and also add CG implementation.
2508
2509         * ImageDiff/CMakeLists.txt:
2510         * ImageDiff/Cairo.cmake: Added.
2511         * ImageDiff/ImageDiff.cpp: Added.
2512         (main):
2513         * ImageDiff/PlatformGTK.cmake:
2514         * ImageDiff/PlatformImage.cpp: Added.
2515         (ImageDiff::PlatformImage::isCompatible):
2516         (ImageDiff::PlatformImage::difference):
2517         * ImageDiff/PlatformImage.h: Added.
2518         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
2519         (ImageDiff::PlatformImage::createFromStdin):
2520         (ImageDiff::PlatformImage::createFromDiffData):
2521         (ImageDiff::PlatformImage::PlatformImage):
2522         (ImageDiff::PlatformImage::~PlatformImage):
2523         (ImageDiff::PlatformImage::width):
2524         (ImageDiff::PlatformImage::height):
2525         (ImageDiff::PlatformImage::rowBytes):
2526         (ImageDiff::PlatformImage::hasAlpha):
2527         (ImageDiff::PlatformImage::pixels):
2528         (ImageDiff::PlatformImage::writeAsPNGToStdout):
2529         * ImageDiff/gtk/ImageDiff.cpp: Removed.
2530
2531 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2532
2533         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
2534         https://bugs.webkit.org/show_bug.cgi?id=170667
2535
2536         Reviewed by Žan Doberšek.
2537
2538         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
2539         that value.
2540
2541         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2542         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
2543
2544 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2545
2546         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
2547         https://bugs.webkit.org/show_bug.cgi?id=170653
2548
2549         Reviewed by Tim Horton.
2550
2551         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
2552         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
2553         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
2554         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
2555
2556         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
2557         * WebKitTestRunner/TestInvocation.cpp:
2558         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
2559         results were created in the web process.
2560         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
2561         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2562         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
2563         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
2564         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2565         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
2566         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
2567         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
2568         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
2569         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
2570         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2571         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
2572         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
2573         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2574         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
2575         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2576         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2577
2578 2017-04-10  Chris Dumez  <cdumez@apple.com>
2579
2580         Drop Timer::startOneShot() overload taking a double
2581         https://bugs.webkit.org/show_bug.cgi?id=170659
2582
2583         Reviewed by Yusuke Suzuki.
2584
2585         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2586
2587         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2588         (TestWebKitAPI::TEST):
2589         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2590         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2591
2592 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2593
2594         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
2595         https://bugs.webkit.org/show_bug.cgi?id=170658
2596         <rdar://problem/31431450>
2597
2598         Reviewed by Tim Horton.
2599
2600         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
2601         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
2602         should complete before the unresponsiveness timeout is triggered.
2603
2604         See WebKit2 ChangeLog for more details.
2605
2606         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2607         (TestWebKitAPI::TEST):
2608
2609 2017-04-09  Chris Dumez  <cdumez@apple.com>
2610
2611         Drop Timer::startRepeating() overload taking a double
2612         https://bugs.webkit.org/show_bug.cgi?id=170656
2613
2614         Reviewed by Yusuke Suzuki.
2615
2616         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2617
2618         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2619         (TestWebKitAPI::TEST):
2620
2621 2017-04-09  Youenn Fablet  <youenn@apple.com>
2622
2623         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
2624         https://bugs.webkit.org/show_bug.cgi?id=170647
2625
2626         Reviewed by Sam Weinig.
2627
2628         * Scripts/webkitpy/common/checkout/scm/git.py:
2629         (Git.fetch): Fetching origin remote in case there is more than one.
2630
2631 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
2632
2633         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
2634         https://bugs.webkit.org/show_bug.cgi?id=170643
2635
2636         Reviewed by Chris Dumez.
2637         
2638         Update the CSSProperties.json style checker to allow:
2639             - comments in codegen_properties
2640             - obsolete-category and obsolete-url in specification blocks
2641             - renamed "done" to "supported"
2642             
2643         Fix some references to codegen_properties to be codegen-properties.
2644
2645         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2646         (JSONCSSPropertiesChecker.validate_status_type):
2647         (JSONCSSPropertiesChecker.validate_property_specification):
2648         (JSONCSSPropertiesChecker.check_codegen_properties):
2649
2650 2017-04-08  Youenn Fablet  <youenn@apple.com>
2651
2652         WebRTC tests gardening
2653         https://bugs.webkit.org/show_bug.cgi?id=170508
2654
2655         Reviewed by Eric Carlson.
2656
2657         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2658
2659 2017-04-07  Keith Miller  <keith_miller@apple.com>
2660
2661         Add a PriorityQueue class
2662         https://bugs.webkit.org/show_bug.cgi?id=170579
2663
2664         Reviewed by Saam Barati.
2665
2666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2667         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
2668         (operator  _z ):
2669         (enqueue):
2670         (dequeue):
2671         (TEST):
2672         (compareMove):
2673
2674 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         Replace ES6SampleBench by ARES-6 in run-benchmark
2677         https://bugs.webkit.org/show_bug.cgi?id=170585
2678
2679         Reviewed by Saam Barati.
2680
2681         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
2682         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
2683
2684         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
2685         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
2686
2687 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
2688
2689         REGRESSION(r211382): Complex text with justification erroneously overflows containers
2690         https://bugs.webkit.org/show_bug.cgi?id=170399
2691         <rdar://problem/31442008>
2692
2693         Reviewed by Simon Fraser.
2694
2695         Check for the invariant that the sum of the advances is equal to m_totalWidth.
2696
2697         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2698         (TestWebKitAPI::TEST_F):
2699
2700 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
2701
2702         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2703         https://bugs.webkit.org/show_bug.cgi?id=167594
2704
2705         Unreviewed test gardening.
2706
2707         Disable this test because it is still timing out on the bots.
2708
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2710         (TEST):
2711
2712 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
2713
2714         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
2715         https://bugs.webkit.org/show_bug.cgi?id=170601
2716         <rdar://problem/31492696>
2717
2718         Reviewed by Simon Fraser.
2719
2720         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2721         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
2722         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
2723
2724 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
2725
2726         Add support for test262 JavaScriptCore tests
2727         https://bugs.webkit.org/show_bug.cgi?id=170523
2728
2729         Reviewed by Daniel Bates.
2730
2731         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
2732         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2733         (RunTest262Tests): Added class to run Test262 tests.
2734         (RunTest262Tests.start): Added.
2735         (RunTest262Tests.countFailures): Method to count the failures.
2736         (Test262Factory): Added Test262 factory class.
2737         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2738         (RunTest262TestsTest): Added unit tests.
2739         (RunTest262TestsTest.assertResults): Helper method.
2740         (RunTest262TestsTest.test_no_regressions_output): Added test case.
2741         (test_failure_output): Same. 
2742         (test_failures_output): Same.
2743
2744 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
2745
2746         [JSC] Change --debug option to --debugger
2747         https://bugs.webkit.org/show_bug.cgi?id=170587
2748
2749         Reviewed by Keith Miller.
2750
2751         * Scripts/run-jsc:
2752
2753         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
2754         to --debugger to avoid shadowing --debug flag used to run JSC with
2755         Debug build.
2756
2757 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
2758
2759         WebKit should percent encode single quotes in query strings
2760         https://bugs.webkit.org/show_bug.cgi?id=170561
2761         <rdar://problem/7415154>
2762
2763         Reviewed by Alex Christensen.
2764
2765         Add a test case for single-quote in the URL query string.
2766
2767         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2768
2769 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
2770
2771         Make FontWithFeatures test font pass OTS
2772         https://bugs.webkit.org/show_bug.cgi?id=169788
2773
2774         Reviewed by Tim Horton.
2775
2776         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
2777         Previously, our FontWithFeatures test font did not pass this check. This patch updates
2778         the font to pass the checks. Now, we can use this font on other platforms, and
2779         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
2780
2781         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2782         (Generator::appendCFFTable):
2783         (Generator::Feature::operator<):
2784         (Generator::appendGSUBTable):
2785         (Generator::appendOS2Table):
2786         (Generator::appendFormat4CMAPTable):
2787         (Generator::appendHEADTable):
2788         (Generator::appendHHEATable):
2789         (Generator::NameRecord::operator<):
2790         (Generator::appendNameSubtable):
2791         (Generator::appendNAMETable):
2792
2793 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
2794
2795         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
2796         for https://bugs.webkit.org/show_bug.cgi?id=170195
2797
2798         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2799
2800 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2801
2802         Unreviewed, rolling out r215046.
2803
2804         This change broke internal builds.
2805
2806         Reverted changeset:
2807
2808         "WebRTC tests gardening"
2809         https://bugs.webkit.org/show_bug.cgi?id=170508
2810         http://trac.webkit.org/changeset/215046
2811
2812 2017-04-06  Youenn Fablet  <youenn@apple.com>
2813
2814         WebRTC tests gardening
2815         https://bugs.webkit.org/show_bug.cgi?id=170508
2816
2817         Reviewed by Eric Carlson.
2818
2819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2820
2821 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
2822
2823         REGRESSION: Simulators failing to install after launch_app times out
2824         <rdar://problem/31478107>
2825
2826         Unreviewed infrastructure fix.
2827
2828         * Scripts/webkitpy/xcode/simulated_device.py:
2829         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
2830
2831 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
2832
2833         test262: module test progressions need updated expectations (@@iterator changes)
2834         https://bugs.webkit.org/show_bug.cgi?id=170535
2835
2836         Reviewed by Saam Barati.
2837
2838         * Scripts/run-jsc-stress-tests:
2839         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
2840         in JavaScriptCore or an outdated or incorrect test262 test.
2841
2842 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
2843
2844         Remove run-jsc-stress-tests benign warning about otool '-S' switch
2845         https://bugs.webkit.org/show_bug.cgi?id=170527
2846
2847         Reviewed by Aakash Jain.
2848
2849         * Scripts/run-jsc-stress-tests:
2850         The switch is not necessary and produces an error.
2851
2852 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
2853
2854         webkitpy: Add pid logging for simulator processes
2855         https://bugs.webkit.org/show_bug.cgi?id=170505
2856
2857         Reviewed by Alexey Proskuryakov.
2858
2859         * Scripts/webkitpy/port/simulator_process.py:
2860         (SimulatorProcess._start.handler): Add pid to exception.
2861         (SimulatorProcess._start): Ditto.
2862         * Scripts/webkitpy/xcode/simulated_device.py:
2863         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
2864         a pid is successfully returned.
2865
2866 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
2867
2868         Unreviewed, rolling out r214932.
2869
2870         This change broke an internal build.
2871
2872         Reverted changeset:
2873
2874         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
2875         timing out"
2876         https://bugs.webkit.org/show_bug.cgi?id=161967
2877         http://trac.webkit.org/changeset/214932
2878
2879 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
2880
2881         Unreviewed, rolling out r214962.
2882
2883         Roll r214937 back in because it wasn't at fault for the build
2884         breakage.
2885
2886         Reverted changeset:
2887
2888         "Unreviewed, rolling out r214937."
2889         https://bugs.webkit.org/show_bug.cgi?id=170365
2890         http://trac.webkit.org/changeset/214962
2891
2892 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
2893
2894         Unreviewed, rolling out r214937.
2895
2896         This change broke an internal build.
2897
2898         Reverted changeset:
2899
2900         "REGRESSION (r202472): Data Detection overwrites existing
2901         links in detected ranges"
2902         https://bugs.webkit.org/show_bug.cgi?id=170365
2903         http://trac.webkit.org/changeset/214937
2904
2905 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
2906
2907         Increase timeouts for simulator testing
2908         Unreviewed infrastructure fix.
2909
2910         r214895 was not sufficient, increasing timeouts again.
2911
2912         * Scripts/webkitpy/xcode/simulated_device.py:
2913         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
2914
2915 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
2916
2917         Formatting fix to remove extra space.
2918
2919         Unreviewed formatting fix.
2920
2921         * Scripts/webkitdirs.pm:
2922         (isEmbeddedWebKit): Remove extra space.
2923
2924 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
2925
2926         Rename isIOSLikeWebKit to isEmbeddedWebKit.
2927
2928         Rubber-stamped by Alexey Proskuryakov. 
2929
2930         * Scripts/webkitdirs.pm:
2931         (isEmbeddedWebKit): Added
2932         (isIOSLikeWebKit): Deleted.
2933
2934 2017-04-05  Alex Christensen  <achristensen@webkit.org>
2935
2936         Fix CMake build.
2937
2938         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
2939         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
2940         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
2941         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
2942         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
2943         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
2944         * WebKitTestRunner/PlatformMac.cmake:
2945         Add some missing files.
2946         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2947
2948 2017-04-05  Keith Miller  <keith_miller@apple.com>
2949
2950         Add debug option to run-jsc script
2951         https://bugs.webkit.org/show_bug.cgi?id=170503
2952
2953         Reviewed by Yusuke Suzuki.
2954
2955         Adds a new option to the run-jsc script so that when passed
2956         "--debug" it will wrap the jsc call with an lldb invocation. If
2957         someone wishes to use a different debugger they can set the
2958         DEBUGGER environment variable. Additionally, run-jsc now exits
2959         with the exit status of the jsc call.
2960
2961         * Scripts/run-jsc:
2962
2963 2017-04-05  Andy Estes  <aestes@apple.com>
2964
2965         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
2966         https://bugs.webkit.org/show_bug.cgi?id=170365
2967         <rdar://problem/29205721>
2968
2969         Reviewed by Tim Horton.
2970
2971         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2972         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
2973         (TEST): Re-enabled the test, which now passes.
2974
2975 2017-04-05  Andy Estes  <aestes@apple.com>
2976
2977         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2978         https://bugs.webkit.org/show_bug.cgi?id=167594
2979
2980         Re-enabled this API test now that webkit.org/b/161967 is fixed.
2981
2982         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2983         (TEST):
2984
2985 2017-04-05  Andy Estes  <aestes@apple.com>
2986
2987         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
2988         https://bugs.webkit.org/show_bug.cgi?id=161967
2989
2990         Reviewed by Alexey Proskuryakov.
2991
2992         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2993         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
2994
2995 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
2996
2997         Various settings in Minibrowser are off by default, and should be on
2998         https://bugs.webkit.org/show_bug.cgi?id=170465
2999         rdar://problem/31421543
3000
3001         Reviewed by Tim Horton.
3002
3003         Explicitly set preferences that should be on by default to enabled, if they have not been
3004         set previously.
3005
3006         * MiniBrowser/mac/SettingsController.m:
3007         (-[SettingsController init]):
3008
3009 2017-04-04  JF Bastien  <jfbastien@apple.com>
3010
3011         Add JF Bastien as reviewer
3012         https://bugs.webkit.org/show_bug.cgi?id=170481
3013
3014         Reviewed by Mark Lam.
3015
3016         * Scripts/webkitpy/common/config/contributors.json:
3017
3018 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
3019
3020         Increase timeouts for simulator testing
3021
3022         Unreviewed infrastructure fix.
3023
3024         * Scripts/webkitpy/port/simulator_process.py:
3025         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
3026         * Scripts/webkitpy/xcode/simulated_device.py:
3027         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
3028
3029 2017-04-04  Tim Horton  <timothy_horton@apple.com>
3030
3031         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
3032         https://bugs.webkit.org/show_bug.cgi?id=165801
3033         <rdar://problem/29649535>
3034
3035         Reviewed by Wenson Hsieh.
3036
3037         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3038         (TEST):
3039         Add some tests for wrapping finds.
3040
3041 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3042
3043         Add some new patterns to filter-build-webkit
3044         https://bugs.webkit.org/show_bug.cgi?id=170429
3045
3046         Reviewed by Alexey Proskuryakov.
3047
3048         * Scripts/filter-build-webkit:
3049         (setOutputFormatOption):
3050
3051 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3052
3053         Data interaction should register type identifiers in order of priority
3054         https://bugs.webkit.org/show_bug.cgi?id=170428
3055         <rdar://problem/30633296>
3056
3057         Reviewed by Tim Horton.
3058
3059         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
3060         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
3061         test for data interaction from a textarea to an input.
3062
3063         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3064         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
3065         (TestWebKitAPI::TEST):
3066         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3067         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3068         (-[DataInteractionSimulator _advanceProgress]):
3069         (-[DataInteractionSimulator sourceItemProviders]):
3070         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
3071
3072 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3073
3074         [GTK][JHBuild] Update mesa repository url for tarballs
3075         https://bugs.webkit.org/show_bug.cgi?id=170431
3076
3077         Reviewed by Michael Catanzaro.
3078
3079         * gtk/jhbuild.modules:
3080
3081 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3082
3083         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
3084         https://bugs.webkit.org/show_bug.cgi?id=170430
3085
3086         Reviewed by Alexey Proskuryakov.
3087
3088         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
3089         Eliminate one of the copies of Ahem.ttf.
3090
3091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3092         Once eliminated, there is now only one Ahem.ttf that is copied
3093         to the Resources bundle. Drive-by sort the project file.
3094
3095 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
3096
3097         Allow MiniBrowser windows to receive local file drags again
3098         https://bugs.webkit.org/show_bug.cgi?id=170422
3099
3100         Reviewed by Wenson Hsieh.
3101
3102         Adopt the new UIDelegate SPI to allow drops.
3103
3104         * MiniBrowser/mac/WK2BrowserWindowController.m:
3105         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
3106
3107 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3108
3109         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
3110         https://bugs.webkit.org/show_bug.cgi?id=170426
3111
3112         Reviewed by Michael Catanzaro.
3113
3114         * gtk/jhbuild.modules:
3115
3116 2017-04-03  Nan Wang  <n_wang@apple.com>
3117
3118         AX: Expose link children when doing search predication on iOS
3119         https://bugs.webkit.org/show_bug.cgi?id=170424
3120         <rdar://problem/31413335>
3121
3122         Reviewed by Chris Fleizach.
3123
3124         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3125         (AccessibilityUIElement::uiElementForSearchPredicate):
3126         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3127         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3128
3129 2017-04-03  Brian Burg  <bburg@apple.com>
3130
3131         run-safari should support launching with custom language and locale
3132         https://bugs.webkit.org/show_bug.cgi?id=170397
3133
3134         Reviewed by Alexey Proskuryakov.
3135
3136         Hook up -AppleLanguages and -AppleLocale to command line options.
3137
3138         * Scripts/webkitdirs.pm:
3139         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
3140         (argumentsForRunAndDebugMacWebKitApp):
3141
3142 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
3143
3144         webkitpy: Provide option to skip install
3145         https://bugs.webkit.org/show_bug.cgi?id=170344
3146
3147         Reviewed by Alexey Proskuryakov.
3148
3149         Installing can take time for on device testing.  Provide an option to skip install
3150         and use whatever driver is currently installed on the device or simulator.
3151
3152         * Scripts/webkitpy/port/base.py:
3153         (Port.check_build): Do not check driver if skipping install.
3154         * Scripts/webkitpy/port/factory.py:
3155         (platform_options): Add '--no-install' option.
3156         * Scripts/webkitpy/port/ios.py:
3157         (IOSPort.setup_test_run): Check install option before installing.
3158
3159 2017-04-03  Keith Miller  <keith_miller@apple.com>
3160
3161         WebAssembly: Update spec tests
3162         https://bugs.webkit.org/show_bug.cgi?id=170361
3163
3164         Rubber-stamped by Saam Barati.
3165
3166         Update the runner to know the new wasm spec test harness code.
3167
3168         * Scripts/run-jsc-stress-tests:
3169
3170 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
3171
3172         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
3173
3174         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
3175         https://bugs.webkit.org/show_bug.cgi?id=170365
3176
3177         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3178
3179 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3180
3181         Mac cmake buildfix after 214586.
3182         https://bugs.webkit.org/show_bug.cgi?id=170381
3183
3184         Unreviewed speculative buildfix.
3185
3186         * WebKitTestRunner/PlatformMac.cmake:
3187
3188 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3189
3190         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
3191         https://bugs.webkit.org/show_bug.cgi?id=161675
3192
3193         * WebKitTestRunner/PlatformMac.cmake:
3194
3195 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
3196
3197         webkitpy: Add target host concept
3198         https://bugs.webkit.org/show_bug.cgi?id=170186
3199         <rdar://problem/31301797>
3200
3201         Reviewed by Alexey Proskuryakov.
3202
3203         Adding the idea of a target host. Target hosts are objects conforming to the
3204         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
3205         Target hosts are the hosts associated with a worker process.
3206
3207         * Scripts/webkitpy/common/system/filesystem.py:
3208         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
3209         host to an absolute path on this host.
3210         (FileSystem.move_to_base_host): Move file from this host to the base host.
3211         (FileSystem.move_from_base_host): Move file from the base host to this host.
3212         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
3213         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
3214         * Scripts/webkitpy/common/system/filesystem_mock.py:
3215         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
3216         host to an absolute path on this host.
3217         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
3218         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
3219         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
3220         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
3221         * Scripts/webkitpy/port/base.py:
3222         (Port.target_host): Return host determined by worker number.
3223         (Port.abspath_for_test): Accept optional target_host argument to return location
3224         of test on a target host.
3225         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
3226         directory on a target host.
3227         (Port.sample_process): Accept optional target_host argument to sample process on
3228         a target host.
3229         * Scripts/webkitpy/port/darwin.py:
3230         (DarwinPort.sample_process): Run sample process on target host.
3231         (DarwinPort.sample_file_path): Accept directory for file.
3232         (DarwinPort.spindump_file_path): Ditto.
3233         * Scripts/webkitpy/port/darwin_testcase.py:
3234         (DarwinTest.test_spindump): Check file movement.
3235         (DarwinTest.test_sample_process): Ditto.
3236         (DarwinTest.test_sample_process_exception):
3237         * Scripts/webkitpy/port/driver.py:
3238         (Driver.__init__): Add and set self._target_host variable.
3239         (Driver._start): Pass target host to _driver_tempdir().
3240         (Driver.stop): Call the target host's rmtree.
3241         (Driver._check_for_driver_timeout): Pass target host to sample_process.
3242         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
3243         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
3244         layout test directory to target host.
3245         * Scripts/webkitpy/port/ios.py:
3246         (IOSPort):
3247         (IOSPort.target_host): Replaced device_for_worker_number.
3248         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
3249         (IOSPort.device_for_worker_number): Replaced with target_host.
3250         * Scripts/webkitpy/port/server_process.py:
3251         (ServerProcess.__init__): Accept target_host instead of worker_number.
3252         (ServerProcess._start): Replace _host with _target_host.
3253         (ServerProcess._handle_timeout): Ditto.
3254         (ServerProcess._kill): Ditto.
3255         * Scripts/webkitpy/port/simulator_process.py:
3256         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
3257         (SimulatorProcess._start): Replace _device with _target_host.
3258         (SimulatorProcess.stop): Ditto.
3259         (SimulatorProcess._kill): Deleted.
3260
3261 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
3262
3263         Unreviewed fix after r214569
3264         https://bugs.webkit.org/show_bug.cgi?id=170255
3265
3266         Unreviewed infrastructure fix.
3267
3268         * Scripts/webkitpy/port/ios.py:
3269         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
3270
3271 2017-03-31  Andy Estes  <aestes@apple.com>
3272
3273         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
3274         https://bugs.webkit.org/show_bug.cgi?id=170365
3275         <rdar://problem/29205721>
3276
3277         Reviewed by Tim Horton.
3278
3279         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3280         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
3281         (TEST): Re-enabled the test, which now passes.
3282
3283 2017-03-31  Tim Horton  <timothy_horton@apple.com>
3284
3285         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
3286         https://bugs.webkit.org/show_bug.cgi?id=170326
3287         <rdar://problem/30330395>
3288
3289         Reviewed by Simon Fraser.
3290
3291         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3292         (TEST):
3293
3294 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3295
3296         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
3297
3298         Fixes: http/tests/ssl/upgrade-origin-usage.html
3299                http/tests/websocket/tests/hybi/network-process-crash-error.html
3300                http/tests/websocket/tests/hybi/simple-wss.html
3301
3302         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3303         (WTR::TestController::platformContext): Return the context.
3304
3305 2017-03-30  Sam Weinig  <sam@webkit.org>
3306
3307         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
3308         https://bugs.webkit.org/show_bug.cgi?id=170315
3309
3310         Reviewed by Simon Fraser.
3311
3312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3313         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
3314         Add test showing the completion handler is called.
3315
3316 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
3317
3318         Air should support linear scan for optLevel<2
3319         https://bugs.webkit.org/show_bug.cgi?id=170161
3320
3321         Reviewed by Saam Barati.
3322         
3323         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
3324         pipeline.
3325
3326         * Scripts/run-jsc-stress-tests:
3327
3328 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
3329
3330         Support tvOS and watchOS in webkitdirs.pm
3331         https://bugs.webkit.org/show_bug.cgi?id=170267
3332
3333         Reviewed by Alexey Proskuryakov.
3334
3335         * Scripts/webkitdirs.pm:
3336         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
3337         (xcodeSDKPlatformName): Added support for tvos and watchos.
3338         (determinePortName): Same.
3339         (isAppleCocoaWebKit): Same.
3340         (willUseAppleTVDeviceSDK): Added.
3341         (willUseAppleTVSimulatorSDK): Added.
3342         (willUseWatchDeviceSDK): Added.
3343         (willUseWatchSimulatorSDK): Added.
3344         (isTVOSWebKit): Added.
3345         (isWATCHOSWebKit): Added.
3346         (isIOSLikeWebKit): Added.
3347
3348 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3349
3350         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
3351         https://bugs.webkit.org/show_bug.cgi?id=170291
3352         <rdar://problem/31301388>
3353
3354         Reviewed by Tim Horton.
3355
3356         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
3357         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
3358         shared UIApplication, and verify that data interaction completes successfully.
3359
3360         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3361         (TestWebKitAPI::TEST):
3362         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3363         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3364         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
3365         (-[DataInteractionSimulator initWithWebView:]):
3366         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
3367         (-[DataInteractionSimulator runFrom:to:]):
3368         (-[DataInteractionSimulator _advanceProgress]):
3369         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
3370
3371 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
3372
3373         [Win] Pass close_fds = True in Python popen call.
3374         https://bugs.webkit.org/show_bug.cgi?id=170172
3375
3376         Reviewed by Brent Fulgham.
3377
3378         This was previously not supported on Windows, but in Python 2.7.10 it is.
3379
3380         * Scripts/webkitpy/common/system/executive.py:
3381         (Executive._should_close_fds):
3382         * Scripts/webkitpy/port/server_process.py:
3383         (ServerProcess._start):
3384
3385 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
3386
3387         Change my status to be a WebKit reviewer.
3388
3389         Unreviewed status update edit.
3390
3391         * Scripts/webkitpy/common/config/contributors.json:
3392
3393 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3394
3395         Change my status to be a WebKit reviewer.
3396
3397         Unreviewed status update edit.
3398
3399         * Scripts/webkitpy/common/config/contributors.json:
3400
3401 2017-03-29  Tim Horton  <timothy_horton@apple.com>
3402
3403         Swipe gesture tests don't work on macOS Sierra
3404         https://bugs.webkit.org/show_bug.cgi?id=161675
3405         <rdar://problem/23379930>
3406
3407         Reviewed by Darin Adler.
3408
3409         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3410         (WTR::UIScriptController::platformPlayBackEventStream):
3411         (WTR::UIScriptController::beginBackSwipe):
3412         (WTR::UIScriptController::completeBackSwipe):
3413         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
3414         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
3415         (eventIsOfType):
3416         (eventIsOfTypes):
3417         (eventIsOfGestureType):
3418         (eventIsOfGestureTypes):
3419         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
3420         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
3421         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
3422         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
3423         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
3424         (beginSwipeBackEventStream):
3425         (completeSwipeBackEventStream):
3426         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3427         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3428         (WTR::UIScriptController::playBackEventStream):
3429         (WTR::UIScriptController::beginBackSwipe):
3430         (WTR::UIScriptController::completeBackSwipe):
3431         (WTR::UIScriptController::platformPlayBackEventStream):
3432         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
3433         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3434         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
3435         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
3436         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3437         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3438         (WTR::playBackEvents):
3439         (WTR::UIScriptController::beginBackSwipe):
3440         (WTR::UIScriptController::completeBackSwipe):
3441         (WTR::UIScriptController::platformPlayBackEventStream):
3442
3443 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
3444
3445         webkitpy: Robust test clean-up
3446         https://bugs.webkit.org/show_bug.cgi?id=170255
3447
3448         Reviewed by Alexey Proskuryakov.
3449
3450         On-device testing is the motivation for this change.  Failure to run clean-up functions can
3451         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
3452         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
3453
3454         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3455         (Manager._set_up_run): Clean up test run if set-up fails.
3456         * Scripts/webkitpy/port/ios.py:
3457         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
3458
3459 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
3460
3461         Simulator testing stops after the first crash
3462         <rdar://problem/31325362>
3463
3464         Unreviewed infrastructure fix.
3465
3466         * Scripts/webkitpy/xcode/simulated_device.py:
3467         (SimulatedDevice):
3468         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
3469
3470 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
3471
3472         webkitpy: Standardize web-server port definitions
3473         https://bugs.webkit.org/show_bug.cgi?id=170144
3474         <rdar://problem/31284026>
3475
3476         Reviewed by Daniel Bates.
3477
3478         Default web-server ports should be declared in global variables.
3479         Add functions to web-servers which return the ports these servers
3480         are using so that other tools can forward them.
3481
3482         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3483         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
3484         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3485         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
3486         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3487         (Lighttpd.__init__): Use shared constants in http_server_base.py.
3488         (Lighttpd._prepare_config): Ditto.
3489         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3490         (HttpServerBase): Add default port constants.
3491         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
3492         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3493         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
3494         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3495          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
3496         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3497         (PyWebSocket): Make default port values public.
3498         (PyWebSocket.__init__): Use public default port.
3499         (PyWebSocket.ports_to_forward): Return port used in an array.
3500         * Scripts/webkitpy/port/base.py:
3501         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
3502         (Port.to.start_websocket_server): Use PyWebSocket port constants.
3503
3504 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3505
3506         Links with empty hrefs should not be drag sources
3507         https://bugs.webkit.org/show_bug.cgi?id=170241
3508         <rdar://problem/31305505>
3509
3510         Reviewed by Tim Horton.
3511
3512         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
3513
3514         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3515         (TestWebKitAPI::TEST):
3516         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3517
3518         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
3519
3520         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3521         (-[DataInteractionSimulator phase]):
3522
3523 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
3524
3525         Use TCP instead of FIFOs for Simulator/Device communication
3526         https://bugs.webkit.org/show_bug.cgi?id=169419
3527         <rdar://problem/30949615>
3528
3529         Reviewed by Alexey Proskuryakov.
3530
3531         Using TCP instead of FIFOs when communicating with devices allows the device being tested
3532         to be on a different machine then the one handling the management of the test run.
3533
3534         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3535         * DumpRenderTree/mac/DumpRenderTree.mm:
3536         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
3537         * Scripts/webkitpy/port/device.py:
3538         (Device.__init__): Initialize the listening_socket.
3539         (Device.listening_port): Return port of listening socket.
3540         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
3541         fro testing.
3542         (Device.finished_testing): Close listening socket associated with this device, call the
3543         platform device's finished_testing function if it exists.
3544         * Scripts/webkitpy/port/ios.py:
3545         (IOSPort.setup_test_run): Prepare each device for testing.
3546         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
3547         * Scripts/webkitpy/port/ios_simulator.py:
3548         (IOSSimulatorPort): Work around device persistence bug.
3549         (IOSSimulatorPort.__init__): Ditto.
3550         * Scripts/webkitpy/port/simulator_process.py:
3551         (SimulatorProcess):
3552         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
3553         Python 2’s makefile.
3554         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
3555         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
3556         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
3557         (SimulatorProcess.__getattr__): Expose all file attributes.
3558         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
3559         create and return a file-like object from the incoming connection.
3560         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
3561         (SimulatorProcess._start.handler): Output server port in timeout exception.
3562         (SimulatorProcess._reset): Deleted.
3563         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
3564         (connectToServer): Return socket connected to the provided server address.
3565         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
3566         TCP server running on localhost.
3567         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
3568         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
3569         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3570         * WebKitTestRunner/ios/TestControllerIOS.mm:
3571         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
3572         instead of using FIFOs.
3573         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
3574
3575 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
3576
3577         webkitpy: Add IOSDevicePort and IOSPort tests
3578         https://bugs.webkit.org/show_bug.cgi?id=170206
3579         <rdar://problem/31308364>
3580
3581         Reviewed by Alexey Proskuryakov.
3582
3583         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
3584         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
3585         (iosDeviceTest): Contains tests for the IOSDevicePort.
3586         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
3587         (iosDeviceTest.test_operating_system): Check for the correct operating system.
3588         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
3589         (iosSimulatorTest): Inherit from ios_testcase.
3590         (iosSimulatorTest.make_port): Ditto.
3591         (iosSimulatorTest.test_get_crash_log): Ditto.
3592         * Scripts/webkitpy/port/ios_testcase.py: Added.
3593         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
3594         (iOSTest.test_driver_name): Tests for iOS app driver.
3595         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
3596         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
3597         * Scripts/webkitpy/port/port_testcase.py:
3598         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
3599         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
3600         (PortTestCase.test_diff_image_crashed): Ditto.
3601
3602 2017-03-28  Jason Marcell  <jmarcell@apple.com>
3603
3604         Fix `index-expected.txt` for dashboard test results.
3605         https://bugs.webkit.org/show_bug.cgi?id=170214
3606
3607         Reviewed by Alexey Proskuryakov.
3608
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
3610
3611 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
3612
3613         Bot watcher's dashboard has separate settings for "mac" and "macos"
3614         https://bugs.webkit.org/show_bug.cgi?id=170164
3615
3616         Reviewed by Tim Horton.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3619         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
3620
3621 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
3622
3623         Fix dashboard test results on the dashboard
3624         https://bugs.webkit.org/show_bug.cgi?id=170158
3625
3626         Reviewed by Tim Horton.
3627
3628         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
3629         further improved, as it's not super readable, but stdio is entirely useless in this context.
3630
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3632         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
3633
3634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3635         Fixed a typo in step name, so that it's actually treated as productive.
3636
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3638         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
3639         (BuildbotTesterQueueView.prototype.update):
3640         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3641         Added special handling for dashboard test results.
3642
3643 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
3644
3645         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
3646         https://bugs.webkit.org/show_bug.cgi?id=170193
3647
3648         Reviewed by Alexey Proskuryakov.
3649
3650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: