[GTK] Use GMainLoopSource in WebKitTestRunner
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Use GMainLoopSource in WebKitTestRunner
4         https://bugs.webkit.org/show_bug.cgi?id=138831
5
6         Reviewed by Sergio Villar Senin.
7
8         * WebKitTestRunner/InjectedBundle/TestRunner.h:
9         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
10         (WTR::TestRunner::platformInitialize):
11         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
12         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
13         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
14         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
15         (WTR::TestController::notifyDone):
16         (WTR::TestController::platformRunUntil):
17         (WTR::cancelTimeout): Deleted.
18
19 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
20
21         [GTK] Missing API detected in GObject DOM bindings after r176630
22         https://bugs.webkit.org/show_bug.cgi?id=139201
23
24         Reviewed by Gustavo Noronha Silva.
25
26         Handle deprecated symbols again when generating the GObject DOM
27         bindings documentation.
28
29         * gtk/webkitdom.py:
30         (WebKitDOMDocGenerator):
31         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
32         (WebKitDOMDocGenerator.generate):
33         (WebKitDOMDocGeneratorSections.__init__):
34         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
35         (WebKitDOMDocGeneratorSections.write_section):
36
37 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
38
39         [EFL][jhbuild] Fix libsoup build with clang
40         https://bugs.webkit.org/show_bug.cgi?id=139088
41
42         Reviewed by Gyuyoung Kim.
43
44         * efl/jhbuild.modules:
45         * efl/patches/soup-clang-warning-fix1.patch: Added.
46         * efl/patches/soup-clang-warning-fix2.patch: Added.
47
48 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
49
50         [Mac] DumpRenderTree sets storage directory incorrectly
51         https://bugs.webkit.org/show_bug.cgi?id=139347
52
53         Reviewed by Dan Bernstein.
54
55         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
56         Don't use user defaults to pass per-instance paths, as user defaults are shared
57         across all instances.
58
59 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
60
61         AX: I cannot activate links on the mobile version of news.google.com
62         https://bugs.webkit.org/show_bug.cgi?id=139330
63
64         Reviewed by Simon Fraser.
65
66         Implement press for iOS.
67
68         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
69         (AccessibilityUIElement::press):
70
71 2014-12-05  Daniel Bates  <dabates@apple.com>
72
73         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
74         https://bugs.webkit.org/show_bug.cgi?id=139326
75
76         Reviewed by Anders Carlsson.
77
78         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
79         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
80         using the same scale factor as used in WebKit.
81
82         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
83         (createBitmapContextFromWebView):
84
85 2014-12-05  Anders Carlsson  <andersca@apple.com>
86
87         REGRESSION (r176677): All tests crash on Windows
88         https://bugs.webkit.org/show_bug.cgi?id=139321
89
90         Reviewed by Alexey Proskuryakov.
91
92         * DumpRenderTree/win/DumpRenderTree.cpp:
93         (runTest):
94         Don't call CFRelease on the url while we have an outstanding pointer to its string,
95         and use the right number of bytes when allocating the testURL buffer.
96
97 2014-12-05  Daniel Bates  <dabates@apple.com>
98
99         [iOS] DumpRenderTree produces many reference test mismatches
100         https://bugs.webkit.org/show_bug.cgi?id=139314
101
102         Reviewed by Simon Fraser.
103
104         Fixes an issue where the scale factor used to render the snapshot taken by
105         DumpRenderTree may differ from the device scale factor. In particular, the
106         scale factor used to render a snapshot of a test may differ from the scale
107         factor used to render the snapshot of its expected result.
108
109         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
110         snapshot the UIWebBrowserView. This SPI always render using a scale factor
111         of one when the backing store for the LegacyTileLayer objects were out-of-
112         date regardless of the device scale factor. Instead we should use UIImage
113         and CALayer API to perform the snapshot with respect to the device scale
114         factor.
115
116         Additionally write iOS pixel dump support logic in terms of existing
117         DumpRenderTree abstractions so as to support generating and comparing
118         pixel dump checksums as well as make the iOS code more consistent with
119         the logic used by other ports.
120
121         * DumpRenderTree/PixelDumpSupport.cpp:
122         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
123         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
124         (BitmapContext::createFromUIImage): Added.
125         (BitmapContext::pixelData): Added.
126         (BitmapContext::BitmapContext): Added.
127         (computeMD5HashStringForBitmapContext): Added.
128         (dumpBitmap): Added.
129         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
130         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
131
132 2014-12-05  Anders Carlsson  <andersca@apple.com>
133
134         Give all web pages a website data store
135         https://bugs.webkit.org/show_bug.cgi?id=139317
136
137         Reviewed by Tim Horton.
138
139         * MiniBrowser/mac/AppDelegate.m:
140         (-[BrowserAppDelegate newPrivateWindow:]):
141         Don't release the controller - it's implicitly retained by the window.
142
143 2014-12-05  Daniel Bates  <dabates@apple.com>
144
145         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
146         https://bugs.webkit.org/show_bug.cgi?id=137581
147         <rdar://problem/18642906>
148
149         Reviewed by Simon Fraser.
150
151         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
152         of the test that proceeded the currently running test.
153
154         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
155         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
156         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
157         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
158
159 2014-12-05  Jer Noble  <jer.noble@apple.com>
160
161         [WTF] MediaTime should support round-tripping from and to doubles.
162         https://bugs.webkit.org/show_bug.cgi?id=139248
163
164         Reviewed by Eric Carlson.
165
166         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
167         the MediaTimes after this change.
168
169         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
170         (WTF::operator<<):
171         (TestWebKitAPI::TEST):
172         * lldb/lldb_webkit.py:
173         (WTFMediaTime_SummaryProvider):
174         (WTFMediaTimeProvider.timeValueAsDouble):
175         (WTFMediaTimeProvider.isIndefinite):
176         (WTFMediaTimeProvider):
177         (WTFMediaTimeProvider.hasDoubleValue):
178
179 2014-12-05  Anders Carlsson  <andersca@apple.com>
180
181         Add a private browsing mode to MiniBrowser
182         https://bugs.webkit.org/show_bug.cgi?id=139308
183
184         Reviewed by Sam Weinig.
185
186         * MiniBrowser/mac/AppDelegate.m:
187         (defaultConfiguration):
188         (-[BrowserAppDelegate newWindow:]):
189         (-[BrowserAppDelegate newPrivateWindow:]):
190         * MiniBrowser/mac/MainMenu.xib:
191         * MiniBrowser/mac/WK2BrowserWindowController.h:
192         * MiniBrowser/mac/WK2BrowserWindowController.m:
193         (-[WK2BrowserWindowController awakeFromNib]):
194         (-[WK2BrowserWindowController initWithConfiguration:]):
195         (-[WK2BrowserWindowController dealloc]):
196         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
197
198 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
199
200         Run http tests parallel
201         https://bugs.webkit.org/show_bug.cgi?id=138958
202
203         Reviewed by Daniel Bates.
204
205         Remove the concept of "locked shard". Now http tests are just like any other tests.
206         We start HTTP and WebSocket servers at the start if we need them, and terminate them
207         when done with all the tests (not when the last http test runs, which is unnecessarily
208         unpredictable).
209
210         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
211         patch, they used to take over 15 minutes.
212
213         As part of the fix, we no longer pass the number of servers to Apache. I don't
214         think that these parameters did what we wanted them to do; Apache handles the load
215         just fine without them.
216
217         The change applies to all platforms. I fixed everything I could find on Mac, and
218         Ossy told me that he's been running http tests in parallel for a long time. If
219         there is increased instability for some ports, it will need to be fixed - there is
220         generally nothing special about http tests at this point, and most code is
221         cross-platform in WebKit2.
222
223         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
224         (LayoutTestRunner.__init__):
225         (LayoutTestRunner.run_tests):
226         (LayoutTestRunner.start_servers_with_lock):
227         (LayoutTestRunner._handle_started_test):
228         (Worker.handle):
229         (Sharder.__init__):
230         (Sharder.shard_tests):
231         (Sharder._shard_every_file):
232         (Sharder._shard_by_directory):
233         (LayoutTestRunner._handle_finished_test_list): Deleted.
234         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
235         (Sharder._shard_in_two): Deleted.
236         (Sharder): Deleted.
237         (Sharder._resize_shards): Deleted.
238         (Sharder._resize_shards.divide_and_round_up): Deleted.
239         (Sharder._resize_shards.extract_and_flatten): Deleted.
240         (Sharder._resize_shards.split_at): Deleted.
241         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
242         (FakePrinter.print_workers_and_shards):
243         (LayoutTestRunnerTests.test_servers_started.start_http_server):
244         (LayoutTestRunnerTests.test_servers_started):
245         (SharderTests.get_shards):
246         (SharderTests.test_shard_by_dir):
247         (SharderTests.test_shard_every_file):
248         (SharderTests): Deleted.
249         (SharderTests.test_shard_in_two): Deleted.
250         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
251         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
252         (SharderTests.test_multiple_locked_shards): Deleted.
253         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
254         (ManagerTest.test_needs_servers.get_manager):
255         (ManagerTest.integration_test_needs_servers.get_manager):
256         (ManagerTest.test_look_for_new_crash_logs.get_manager):
257         (ManagerTest):
258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
259         (_set_up_derived_options):
260         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
261         (RunTest.test_batch_size):
262         (RunTest.test_max_locked_shards): Deleted.
263         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
264         (LayoutTestApacheHttpd.__init__):
265         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
266         (TestLayoutTestApacheHttpd.test_start_cmd):
267         * Scripts/webkitpy/layout_tests/servers/http_server.py:
268         (Lighttpd.__init__):
269         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
270         (HttpServerBase.__init__):
271         * Scripts/webkitpy/layout_tests/views/printing.py:
272         (Printer.print_workers_and_shards):
273         * Scripts/webkitpy/port/base.py:
274         (Port.default_child_processes):
275         (Port.to.start_http_server):
276         (Port.default_max_locked_shards): Deleted.
277         * Scripts/webkitpy/port/port_testcase.py:
278         (PortTestCase.make_port):
279         (PortTestCase.test_default_max_locked_shards): Deleted.
280         * Scripts/webkitpy/port/test.py:
281         (TestPort.start_http_server):
282
283 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
284
285         Don't lock perf tests in run-webkit-tests
286         https://bugs.webkit.org/show_bug.cgi?id=139264
287
288         Reviewed by Daniel Bates.
289
290         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
291         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
292         * Scripts/webkitpy/layout_tests/controllers/manager.py:
293         * Scripts/webkitpy/layout_tests/models/test_input.py:
294         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
295
296 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
297
298         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
299         https://bugs.webkit.org/show_bug.cgi?id=139243
300
301         Reviewed by Anders Carlsson.
302
303         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
304         chance to allow untrusted certificates.
305
306         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
307         Set up more client objects for secondary windows. We may be able to share some of the
308         code with main view creation function, but it's not exactly the same (notably, we
309         do not focus a secondary window when it's done loading).
310
311 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
312
313         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
314         https://bugs.webkit.org/show_bug.cgi?id=139071
315
316         Reviewed by Chris Fleizach.
317
318         Add string value for ATK_ROLE_STATIC in roleToString.
319
320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
321
322 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
323
324         check-webkit-style is confused by ternary expression inside first member initializer
325         https://bugs.webkit.org/show_bug.cgi?id=136442
326
327         Reviewed by Csaba Osztrogonác.
328
329         * Scripts/webkitpy/style/checkers/cpp.py:
330         (check_member_initialization_list):
331
332 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
333
334         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
335         https://bugs.webkit.org/show_bug.cgi?id=139220
336
337         Reviewed by Philippe Normand.
338
339         * gtk/jhbuild.modules:
340         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
341
342 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
343
344         Remove unused JSC runtime options
345         https://bugs.webkit.org/show_bug.cgi?id=133070
346
347         Reviewed by Csaba Osztrogonác.
348
349         * Scripts/run-jsc-stress-tests:
350
351 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
352
353         [EFL] Add subtle crypto to the build system
354         https://bugs.webkit.org/show_bug.cgi?id=138612
355
356         Reviewed by Csaba Osztrogonác.
357
358         * Scripts/webkitperl/FeatureList.pm:
359
360 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
361
362         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
363         https://bugs.webkit.org/show_bug.cgi?id=139005
364
365         Reviewed by Chris Fleizach.
366
367         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
368         Add mapping for ATK_ROLE_CAPTION to roleToString
369
370 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
371
372         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
373         https://bugs.webkit.org/show_bug.cgi?id=139149
374
375         Reviewed by Anders Carlsson.
376
377         WebKit2 already cleared application caches between runs (although it wasn't entirely
378         effective without WebCore changes in this patch).
379
380         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
381
382         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
383         function is not implemented on Windows, see below).
384
385         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
386         Ameded a FIXME.
387
388 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
389
390         Generalize PageActivityAssertionToken
391         https://bugs.webkit.org/show_bug.cgi?id=139106
392
393         Reviewed by Sam Weinig.
394
395         Add an API test for WTF::RefCounter.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
399         (TestWebKitAPI::TEST):
400             - added RefCounter test.
401
402 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
403
404         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
405         https://bugs.webkit.org/show_bug.cgi?id=139174
406
407         Reviewed by Simon Fraser.
408
409         * DumpRenderTree/TestRunner.cpp:
410         * DumpRenderTree/TestRunner.h:
411         Renamed testPathOrURL to testURL, because this variable always contains a URL.
412
413         * DumpRenderTree/mac/DumpRenderTree.mm:
414         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
415         (testPathFromURL): Moved from FrameLoadDelegate.mm.
416         (runTest): Set crash reporter information here, as we know the exact test URL.
417
418         * DumpRenderTree/mac/FrameLoadDelegate.mm:
419         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
420         reporter information here.
421
422         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
423         * DumpRenderTree/mac/TestRunnerMac.mm:
424         Updated for testPathOrURL renaming.
425
426         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
427         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
428         test URL until load starts, so save it into TestRunner now. A new TestRunner object
429         is created for each test.
430
431         * WebKitTestRunner/InjectedBundle/TestRunner.h:
432         (WTR::TestRunner::testURL):
433         (WTR::TestRunner::setTestURL):
434         Make TestRunner know the test name. For now, it's good enough to have it once load
435         starts, but if we ever need it earlier, we can send it with BeginTest message.
436
437         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
438         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
439         Use test URL, not currently loading URL for CrashReporter.
440
441         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
442         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
443         (WebKit1 already had it right).
444
445         * DumpRenderTree/win/DumpRenderTree.cpp:
446         (sizeWebViewForCurrentTest):
447         (runTest):
448         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
449         (ResourceLoadDelegate::willSendRequest):
450         Changed Windows DumpRenderTree to also use URL in TestRunner.
451
452 2014-12-02  Daniel Bates  <dabates@apple.com>
453
454         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
455         https://bugs.webkit.org/show_bug.cgi?id=139143
456
457         Reviewed by David Kilzer.
458
459         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
460         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
461         crashes. Run-webkit-tests will record as crashing the test associated with the
462         DumpRenderTree instance that wrote that string.
463
464         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
465         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
466         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
467         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
468         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
469         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
470         about a crash.
471
472         Additionally, update the crash message format written to standard error when LayoutTestRelay
473         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
474         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
475         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
476         when they crash in their test machinery logic/UI process code.
477
478         * DumpRenderTree/mac/DumpRenderTree.mm:
479         (writeCrashedMessageOnFatalError): Added.
480         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
481         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
482         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
483         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
484         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
485         the crash logs for WebKitTestRunner/DumpRenderTree.app.
486         * Scripts/webkitpy/port/driver.py:
487         (Driver.__init__): Update comment.
488         (Driver._check_for_driver_crash): Ditto.
489         * Scripts/webkitpy/port/ios.py:
490         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
491         regular expression. This constant is used as an optimization to avoid compiling the same
492         regular expression across invocations of _get_crash_log().
493         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
494         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
495         closer to where they are used.
496
497 2014-12-01  Anders Carlsson  <andersca@apple.com>
498
499         Remove WKBundleRemoveAllVisitedLinks
500         https://bugs.webkit.org/show_bug.cgi?id=139163
501
502         Reviewed by Sam Weinig.
503
504         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
505
506         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
507         (WTR::InjectedBundle::beginTesting):
508         * WebKitTestRunner/TestInvocation.cpp:
509         (WTR::TestInvocation::invoke):
510
511 2014-12-02  Anders Carlsson  <andersca@apple.com>
512
513         Fix Windows build.
514
515         * DumpRenderTree/win/DumpRenderTree.cpp:
516         (setAlwaysAcceptCookies):
517
518 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
519
520         [EFL] Remove edbus dependency from jhbuild
521         https://bugs.webkit.org/show_bug.cgi?id=139130
522
523         Reviewed by Gyuyoung Kim.
524
525         After http://trac.webkit.org/changeset/176555 we
526         don't need it anymore.
527
528         * efl/jhbuild.modules:
529
530 2014-12-02  Philippe Normand  <pnormand@igalia.com>
531
532         [jhbuild] wrong Dependencies path
533         https://bugs.webkit.org/show_bug.cgi?id=139176
534
535         Reviewed by Martin Robinson.
536
537         * Scripts/webkitpy/port/base.py:
538         (Port._should_use_jhbuild):
539
540 2014-12-02  Philippe Normand  <pnormand@igalia.com>
541
542         [GStreamer] Bump internal jhbuild versions to 1.4.4
543         https://bugs.webkit.org/show_bug.cgi?id=138866
544
545         Reviewed by Carlos Garcia Campos.
546
547         * gtk/jhbuild.modules:
548         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
549         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
550         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
551
552 2014-12-01  Commit Queue  <commit-queue@webkit.org>
553
554         Unreviewed, rolling out r176566.
555         https://bugs.webkit.org/show_bug.cgi?id=139124
556
557         It broke the GTK performance tests. (Requested by clopez on
558         #webkit).
559
560         Reverted changeset:
561
562         "[GTK] Use GMainLoopSource in WebKitTestRunner"
563         https://bugs.webkit.org/show_bug.cgi?id=138831
564         http://trac.webkit.org/changeset/176566
565
566 2014-11-29  Anders Carlsson  <andersca@apple.com>
567
568         Crash when calling WKPageClose on the originated page from within createNewPage callback
569         https://bugs.webkit.org/show_bug.cgi?id=139099
570         <rdar://problem/19052564>
571
572         Reviewed by Sam Weinig.
573
574         Add a test.
575
576         * TestWebKitAPI/PlatformWebView.h:
577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
578         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
579         (TestWebKitAPI::runJavaScriptAlert):
580         (TestWebKitAPI::createNewPage):
581         (TestWebKitAPI::TEST):
582         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
583         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
584         (TestWebKitAPI::PlatformWebView::PlatformWebView):
585
586 2014-11-28  Commit Queue  <commit-queue@webkit.org>
587
588         Unreviewed, rolling out r176564.
589         https://bugs.webkit.org/show_bug.cgi?id=139093
590
591         massive failures on release test bot (Requested by philn on
592         #webkit).
593
594         Reverted changeset:
595
596         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
597         https://bugs.webkit.org/show_bug.cgi?id=138866
598         http://trac.webkit.org/changeset/176564
599
600 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
601
602         [GTK] Use GMainLoopSource in WebKitTestRunner
603         https://bugs.webkit.org/show_bug.cgi?id=138831
604
605         Reviewed by Sergio Villar Senin.
606
607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
608         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
609         (WTR::TestRunner::platformInitialize):
610         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
611         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
612         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
613         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
614         (WTR::TestController::notifyDone):
615         (WTR::TestController::platformRunUntil):
616         (WTR::cancelTimeout): Deleted.
617
618 2014-11-24  Philippe Normand  <pnormand@igalia.com>
619
620         [GStreamer] Bump internal jhbuild versions to 1.4.4
621         https://bugs.webkit.org/show_bug.cgi?id=138866
622
623         Reviewed by Carlos Garcia Campos.
624
625         * gtk/jhbuild.modules:
626         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
627         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
628         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
629
630 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
631
632         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
633         https://bugs.webkit.org/show_bug.cgi?id=138834
634
635         Reviewed by Sergio Villar Senin.
636
637         It makes everyting simpler and the tests run faster too, since we
638         don't need to spawn the private bus and wait until the DBus name
639         is registered. The web extension registers a new JavaSCript class
640         with a status method to run the tests, similar to the DBus
641         method. In the UI process side, tests use webkit_web_view_run_java_script()
642         instead of sending a DBus message.
643
644         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
645         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
646         (WebKitDOMNodeFilterTest::create):
647         (WebKitDOMNodeFilterTest::testTreeWalker):
648         (WebKitDOMNodeFilterTest::testNodeIterator):
649         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
650         (WebKitDOMNodeFilterTest::runTest): Deleted.
651         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
652         (WebKitDOMNodeTest::create):
653         (WebKitDOMNodeTest::testHierarchyNavigation):
654         (WebKitDOMNodeTest::testInsertion):
655         (WebKitDOMNodeTest::testTagNames):
656         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
657         (WebKitDOMNodeTest::runTest): Deleted.
658         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
659         (WebKitDOMXPathNSResolverTest::create):
660         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
661         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
662         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
663         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
664         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
665         (WebKitFrameTest::create):
666         (WebKitFrameTest::testMainFrame):
667         (WebKitFrameTest::testURI):
668         (WebKitFrameTest::testJavaScriptContext):
669         (WebKitFrameTest::webPageFromArgs): Deleted.
670         (WebKitFrameTest::runTest): Deleted.
671         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
672         (testWebKitDOMNodeHierarchyNavigation):
673         (testWebKitDOMNodeInsertion):
674         (testWebKitDOMNodeTagNames):
675         (beforeAll):
676         (afterAll):
677         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
678         (runTest):
679         (beforeAll):
680         (afterAll):
681         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
682         (testWebKitDOMXPathNSResolverNative):
683         (testWebKitDOMXPathNSResolverCustom):
684         (beforeAll):
685         (afterAll):
686         (runTest): Deleted.
687         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
688         (webkitFrameTestRun):
689         (beforeAll):
690         (afterAll):
691         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
692         (testsMap):
693         (WebProcessTest::add):
694         (WebProcessTest::create):
695         (runTest):
696         (windowObjectClearedCallback):
697         (webkit_web_extension_initialize):
698         (methodCallCallback): Deleted.
699         (webkit_web_extension_initialize_with_user_data): Deleted.
700         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
701         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
702         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
703         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
704         (WebViewTest::runWebProcessTest):
705         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
706
707 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
708
709         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
710         https://bugs.webkit.org/show_bug.cgi?id=139086
711
712         Reviewed by Gyuyoung Kim.
713
714         * efl/jhbuild.modules:
715         * efl/patches/libseccomp-pick-up-CC.patch: Added.
716
717 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
718
719         [EFL] Add warning if CMake version is too old for building with ninja.
720         https://bugs.webkit.org/show_bug.cgi?id=139055
721
722         Reviewed by Gyuyoung Kim.
723
724         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
725         that version in their repositories.
726
727         * efl/install-dependencies:
728
729 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
730
731         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
732         https://bugs.webkit.org/show_bug.cgi?id=139044
733
734         Reviewed by Chris Fleizach.
735
736         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
737         The proposed solution will enable the use of this method for the object table.
738         Existing test shows the result.
739
740         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
741         (WTR::AccessibilityUIElement::columnHeaders):
742
743 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
744
745         [EFL] Remove E_Dbus dependency
746         https://bugs.webkit.org/show_bug.cgi?id=136355
747
748         Reviewed by Gyuyoung Kim.
749
750         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
751
752 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
753
754         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
755         https://bugs.webkit.org/show_bug.cgi?id=139047
756
757         Reviewed by Carlos Garcia Campos.
758
759         * efl/jhbuild.modules:
760         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
761         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
762         * gtk/jhbuild-optional.modules:
763         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
764         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
765
766 2014-11-25  Tanay C  <tanay.c@samsung.com>
767
768         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
769         https://bugs.webkit.org/show_bug.cgi?id=138090
770
771         Reviewed by Carlos Garcia Campos.
772
773         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
774         (browserWindowZoomIn): Added.
775         (browserWindowZoomOut): Added.
776         (scrollEventCallback): Added.
777         (zoomInCallback): Modified.
778         (zoomOutCallback): Modified.
779         (browserWindowConstructed): Modified.
780
781 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
782
783         [EFL] REGRESSION(r176514): It made performance tests fail
784         https://bugs.webkit.org/show_bug.cgi?id=139037
785
786         Reviewed by Gyuyoung Kim.
787
788         * Scripts/webkitpy/port/efl.py:
789         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
790         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
791         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
792
793 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
794
795         [GTK] update-webkitgtk-libs fails to build fontconfig
796         https://bugs.webkit.org/show_bug.cgi?id=139032
797
798         Reviewed by Martin Robinson.
799
800         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
801         fontconfig will try to generate documentation and fail.
802
803         * gtk/install-dependencies:
804
805 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
806
807         Unreviewed. Fix GTK+ make distcheck.
808
809         * gtk/manifest.txt: Remove deleted files.
810
811 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
812
813         [EFL] Utilize Eail library to support accessibility in EFL
814         https://bugs.webkit.org/show_bug.cgi?id=137742
815
816         Reviewed by Gyuyoung Kim.
817
818         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
819
820         * efl/jhbuild-optional.modules: Added.
821         * efl/jhbuild.modules:
822
823 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
824
825         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
826         https://bugs.webkit.org/show_bug.cgi?id=139023
827
828         Reviewed by Sergio Villar Senin.
829
830         Rename WebKitWebView/default-context as WebKitWebView/web-context
831         and check we are always using the right context for new web views.
832
833         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
834         (testWebViewWebContext):
835         (beforeAll):
836         (testWebViewDefaultContext): Deleted.
837
838 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
839
840         [GTK] Add API to override the default local storage directory
841         https://bugs.webkit.org/show_bug.cgi?id=138828
842
843         Reviewed by Gustavo Noronha Silva.
844
845         Add test to check that the local storage directory is created at
846         the path given on construction.
847
848         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
849         (testWebContextConfiguration):
850         (beforeAll):
851         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
852         (Test::Test):
853         (Test::~Test): Deleted.
854
855 2014-11-21  Zalan Bujtas  <zalan@apple.com>
856
857         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
858         https://bugs.webkit.org/show_bug.cgi?id=138981
859
860         Reviewed by Simon Fraser.
861
862         * MiniBrowser/mac/SettingsController.h:
863         * MiniBrowser/mac/SettingsController.m:
864         (-[SettingsController _populateMenu]):
865         (-[SettingsController validateMenuItem:]):
866         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
867         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
868         * MiniBrowser/mac/WK1BrowserWindowController.m:
869         (-[WK1BrowserWindowController didChangeSettings]):
870         * MiniBrowser/mac/WK2BrowserWindowController.m:
871         (-[WK2BrowserWindowController didChangeSettings]):
872
873 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
874
875         Remove http lock code from webkitperl
876         https://bugs.webkit.org/show_bug.cgi?id=138959
877
878         Reviewed by Alexey Proskuryakov.
879
880         * Scripts/webkitperl/httpd.pm:
881         (cleanUp):
882         (extractLockNumber): Deleted.
883         (getLockFiles): Deleted.
884         (getNextAvailableLockNumber): Deleted.
885         (getLockNumberForCurrentRunning): Deleted.
886         (waitForHTTPDLock): Deleted.
887         (scheduleHttpTesting): Deleted.
888         (getWaitTime): Deleted.
889
890 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
891
892         [EFL] The option value of fixed layout is false in MiniBrowser
893         https://bugs.webkit.org/show_bug.cgi?id=138830
894
895         Reviewed by Gyuyoung Kim.
896
897         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
898
899         * MiniBrowser/efl/main.c:
900
901 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
902
903         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
904         https://bugs.webkit.org/show_bug.cgi?id=138871
905
906         Reviewed by Carlos Garcia Campos.
907
908         Add a test case for the convenience API for posting user messages
909         added to the DOM bindings.
910
911         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
912         (testUserContentManagerMessageFromConvenienceDOMBindings):
913         (beforeAll):
914         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
915         (documentLoadedCallback):
916
917 2014-11-19  Dana Burkart  <dburkart@apple.com>
918
919         Work around the fact that different masters may have different names for their codebases.
920         https://bugs.webkit.org/show_bug.cgi?id=138878
921
922         Reviewed by Mark Rowe.
923
924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
925         (parseRevisionProperty): Changed.
926         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
927         opensource / internal codebase naming convention.
928
929 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
930
931         AX: Screen braille input doesn't work on forms.
932         https://bugs.webkit.org/show_bug.cgi?id=138804
933
934         Unreviewed build fix.
935
936         * DumpRenderTree/AccessibilityUIElement.cpp:
937         (AccessibilityUIElement::setValue):
938
939 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
940
941         AX: Screen braille input doesn't work on forms.
942         https://bugs.webkit.org/show_bug.cgi?id=138804
943
944         Reviewed by Mario Sanchez Prada.
945
946         Add a method to setValue through the AX API in DRT.
947
948         * DumpRenderTree/AccessibilityUIElement.cpp:
949         (setValueCallback):
950         (AccessibilityUIElement::getJSClass):
951         * DumpRenderTree/AccessibilityUIElement.h:
952         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
953         (AccessibilityUIElement::setValue):
954         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
955         (AccessibilityUIElement::setValue):
956
957 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
958
959         Remove the WinCairo buildbot
960         https://bugs.webkit.org/show_bug.cgi?id=138805
961
962         Reviewed by Alex Christensen.
963
964         * BuildSlaveSupport/build.webkit.org-config/config.json:
965         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
966         (appendCustomBuildFlags):
967         * BuildSlaveSupport/test-result-archive:
968         (archiveTestResults):
969
970 2014-11-18  Daniel Bates  <dabates@apple.com>
971
972         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
973         SPI are not available in public SDK
974         https://bugs.webkit.org/show_bug.cgi?id=138802
975
976         Reviewed by David Kilzer.
977
978         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
979
980         * DumpRenderTree/mac/CheckedMalloc.cpp:
981
982 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
983
984         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
985
986         Forgot to fix this test before landing.
987
988         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
989         (testWebViewDefaultContext):
990
991 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
992
993         [GTK] Add API to create a WebKitWebContext
994         https://bugs.webkit.org/show_bug.cgi?id=138826
995
996         Reviewed by Gustavo Noronha Silva.
997
998         Use a different WebKitWebContext for every test to ensure test
999         cases are independent to each other. Tests using DBus to
1000         communicate with the injected bundle extension now use a unique
1001         name for the well known DBus name.
1002
1003         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1004         (beforeAll): Remove comment about the order of the tests and
1005         move the success test before the failed one now that tests don't
1006         depend on each others.
1007         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1008         (beforeAll): Remove call to set the web extensions directory,
1009         since this is now done for all test in the Test constructor.
1010         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1011         (beforeAll): Do not create a temporary directory, a temporary data
1012         directory is now created for all tests.
1013         (afterAll):
1014         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1015         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
1016         to the web process test runner.
1017         (testWebKitDOMNodeInsertion): Ditto.
1018         (testWebKitDOMNodeTagNames): Ditto.
1019         (beforeAll): Remove call to set the web extensions directory.
1020         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1021         (runTest): Pass the web extension ID to the web process test runner.
1022         (beforeAll): Remove call to set the web extensions directory.
1023         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1024         (runTest): Pass the web extension ID to the web process test runner.
1025         (beforeAll): Remove call to set the web extensions directory.
1026         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1027         (createFileAtDestination): Use Test::dataDirectory() as base dir
1028         for temporary files.
1029         (beforeAll): Do not create a temporary directory.
1030         (afterAll):
1031         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1032         (webkitFrameTestRun): Pass the web extension ID to the web process
1033         test runner.
1034         (beforeAll): Remove call to set the web extensions directory.
1035         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1036         (beforeAll): Remove call to set the web extensions directory.
1037         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1038         (testProcessPerWebView): Use local member instead of global variable.
1039         (testMultiprocessWebViewCreateReadyClose): Ditto.
1040         (beforeAll): Do not connect to initialize-web-extensions, Test now
1041         connects to the signal for all tests and calls a virtual method
1042         that test can override.
1043         (afterAll):
1044         (initializeWebExtensions): Deleted.
1045         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1046         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
1047         for temporary files.
1048         (beforeAll): Do not create a temporary directory.
1049         (afterAll):
1050         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1051         (beforeAll): Remove call to set the web extensions directory.
1052         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1053         (beforeAll): Remove comment about the tests order.
1054         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1055         (testWebExtensionGetTitle): Build the DBus service name using the
1056         web extension ID.
1057         (testDocumentLoadedSignal): Ditto.
1058         (testWebKitWebViewProcessCrashed): Ditto.
1059         (testWebExtensionIsolatedWorld): Ditto.
1060         (beforeAll): Remove initialization-user-data test, since now all
1061         tests are passing user data to the web extension.
1062         (testWebExtensionInitializationUserData): Deleted.
1063         (initializeWebExtensions): Deleted.
1064         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1065         (testSetDirectory): Use the web context member inherited from Test.
1066         (testClearDatabase): Ditto.
1067         (testGetFaviconURI): Ditto.
1068         (beforeAll): Do not create a temporary directory.
1069         (afterAll):
1070         (webkitFaviconDatabaseFinalizedCallback): Deleted.
1071         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1072         (UserContentManagerTest::UserContentManagerTest):
1073         (beforeAll): Remove call to set the web extensions directory.
1074         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1075         (testWebContextDefault): Check also that a newly create web
1076         context is not the default web context.
1077         (testWebContextSpellChecker): Use the web context member inherited
1078         from Test.
1079         (testWebContextLanguages): Ditto.
1080         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1081         (methodCallCallback): Remove GetInitializationUserData method.
1082         (webkit_web_extension_initialize_with_user_data): Always create
1083         the DBus name using the user data provided.
1084         (makeBusName): Deleted.
1085         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1086         (webkit_web_extension_initialize_with_user_data): Create the DBus
1087         name using the user data provided.
1088         (webkit_web_extension_initialize): Deleted.
1089         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1090         (Test::dataDirectory): Return the temporary data directory.
1091         (removeNonEmptyDirectory): Also remove directories recursively.
1092         (main): Remove the disk cache directory initialization, since this
1093         is now done in the Test constructor.
1094         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1095         (Test::initializeWebExtensionsCallback): Call the virtual method
1096         initializeWebExtensions()
1097         (Test::Test): Create a new WebKitWebContext and initialize it.
1098         (Test::~Test): Disconnect initialize-web-extensions signal.
1099         (Test::initializeWebExtensions): Set the web extensions directory
1100         and user data.
1101         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1102         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
1103         (WebProcessTestRunner::runTest): Build the DBus proxy using a
1104         unique name created with the Test web extension ID.
1105         (WebProcessTestRunner::proxy): Deleted.
1106         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
1107         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1108         (WebViewTest::WebViewTest): Create the web view with the Test web
1109         context.
1110         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
1111         content manager parameter to the constructor.
1112
1113 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
1114
1115         [GTK] Mesa build fails over llvm-3.5
1116         https://bugs.webkit.org/show_bug.cgi?id=138825
1117
1118         Reviewed by Gustavo Noronha Silva.
1119
1120         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
1121
1122         * gtk/jhbuild.modules:
1123         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
1124
1125 2014-11-17  Daniel Bates  <dabates@apple.com>
1126
1127         Unreviewed, rolling out r176232.
1128
1129         Broke the Mac build. Will investigate offline.
1130
1131         Reverted changeset:
1132
1133         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1134         MobileGestalt"
1135         https://bugs.webkit.org/show_bug.cgi?id=138802
1136         http://trac.webkit.org/changeset/176232
1137
1138 2014-11-17  Daniel Bates  <dabates@apple.com>
1139
1140         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1141         SPI are not available in public SDK
1142         https://bugs.webkit.org/show_bug.cgi?id=138802
1143
1144         Reviewed by David Kilzer.
1145
1146         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1147
1148         * DumpRenderTree/mac/CheckedMalloc.cpp:
1149
1150 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
1151
1152         Having 30+ flaky failures breaks EWS
1153         https://bugs.webkit.org/show_bug.cgi?id=138743
1154
1155         Reviewed by Alexey Proskuryakov.
1156
1157         Adds tests to ensure that the problem has been solved.
1158         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1159         (test_first_failure_limit):
1160         (test_first_failure_limit_with_some_tree_redness):
1161         (test_second_failure_limit):
1162         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
1163         (test_first_and_second_failure_limit):
1164         (test_first_and_clean_failure_limit):
1165         (test_first_second_and_clean_failure_limit):
1166         (test_very_red_tree_retry): Deleted.
1167         Really this was renamed to test_first_second_and_clean_failure_limit.
1168         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1169         Makes the appropriate changes to PatchAnalysisTask to make sure that
1170         even when the first test run hits the failure limit, it will still try
1171         a second run.
1172         (PatchAnalysisTask._results_failed_different_tests):
1173         (PatchAnalysisTask._test_patch):
1174         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
1175
1176 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
1177
1178         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1179         https://bugs.webkit.org/show_bug.cgi?id=136018
1180
1181         Reviewed by Carlos Garcia Campos.
1182
1183         It is possible that the order of -L arguments in the output of
1184         pkg-config is wrong, which causes the linker to find the wrong
1185         version (usually older version) of libraries when running
1186         gtkdoc-scangobj.
1187
1188         * gtk/gtkdoc.py:
1189         (GTKDoc._run_gtkdoc_scangobj):
1190
1191 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1192
1193         Bump EFL version to 1.12.0
1194         https://bugs.webkit.org/show_bug.cgi?id=138733
1195
1196         Reviewed by Gyuyoung Kim.
1197
1198         * efl/jhbuild.modules:
1199
1200 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1201
1202         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1203         https://bugs.webkit.org/show_bug.cgi?id=138771
1204
1205         Reviewed by Chris Fleizach.
1206
1207         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1208
1209         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1210
1211 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1212
1213         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1214         https://bugs.webkit.org/show_bug.cgi?id=138767
1215
1216         Reviewed by Chris Fleizach.
1217
1218         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1219
1220         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1221
1222 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1223
1224         Add shortcut macros to Mac TestExpectations
1225         https://bugs.webkit.org/show_bug.cgi?id=138729
1226
1227         Reviewed by Simon Fraser.
1228
1229         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1230         Add version macros for current OS versions.
1231
1232 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1233
1234         https://bugs.webkit.org/show_bug.cgi?id=138628
1235         A patch that doesn't apply is stuck in commit queue
1236
1237         Rubber-stamped by David Kilzer.
1238
1239         This also hopefully fixes other issues:
1240         - a patch that has cq+ flag set by a non-committer kills commit queue;
1241         - EWS never reports failing tests, and keeps spinning instead.
1242
1243         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1244         (Bugzilla.set_flag_on_attachment):
1245         (Bugzilla.obsolete_attachment):
1246         Apply the fix from r174797 to more places.
1247
1248 2014-11-13  Dan Bernstein  <mitz@apple.com>
1249
1250         Policy client not called for navigations through the page cache
1251         https://bugs.webkit.org/show_bug.cgi?id=138703
1252
1253         Reviewed by Alexey Proskuryakov.
1254
1255         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1256         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1257         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1258
1259 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1260
1261         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1262         https://bugs.webkit.org/show_bug.cgi?id=137867
1263
1264         Reviewed by Chris Fleizach.
1265
1266         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1267         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1268         able to test for the presence of ATK_ROLE_INVALID.
1269
1270         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1271         (WTR::AccessibilityUIElement::role):
1272
1273 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1274
1275         Update the "combineModules" script to handel more LLVM metadata.
1276         https://bugs.webkit.org/show_bug.cgi?id=138514
1277
1278         Reviewed by Filip Pizlo.
1279
1280         * ReducedFTL/combineModules.rb:
1281
1282 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1283
1284         Allow constructing a base PassRef with a derived Ref
1285         https://bugs.webkit.org/show_bug.cgi?id=138701
1286
1287         Reviewed by Andreas Kling
1288
1289         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1290         (TestWebKitAPI::passWithPassRef):
1291         (TestWebKitAPI::passWithPassRefPtr):
1292         (TestWebKitAPI::TEST):
1293
1294 2014-11-05  Ada Chan  <adachan@apple.com>
1295
1296         Implement new plug-in API for muting plug-ins
1297         https://bugs.webkit.org/show_bug.cgi?id=138105
1298
1299         Reviewed by Anders Carlsson.
1300
1301         Add a new plug-in test for the mute API.
1302
1303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1304         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1305         (SetMuted::SetMuted):
1306         (SetMuted::isMuted):
1307         (SetMuted::cachedIsMuted):
1308         (SetMuted::ScriptableObject::hasProperty):
1309         (SetMuted::ScriptableObject::getProperty):
1310         (SetMuted::ScriptableObject::pluginTest):
1311         (SetMuted::NPP_New):
1312         (SetMuted::NPP_GetValue):
1313         (SetMuted::NPP_SetValue):
1314
1315 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1316
1317         Unreviewed, GTK gardening.
1318
1319         * Scripts/run-gtk-tests:
1320         (TestRunner): Skip the UserMediaBasic test because it depends on
1321         constraints validation which is going to be fixed in bug #136449.
1322
1323 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1324
1325         [GTK] Expose user script messages to GObject DOM bindings
1326         https://bugs.webkit.org/show_bug.cgi?id=138411
1327
1328         Reviewed by Philippe Normand.
1329
1330         Add a test case to check that user script messages sent using the
1331         DOM bindings API are also received in the UI process.
1332
1333         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1334         (UserScriptMessageTest::waitUntilMessageReceived):
1335         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1336         (testUserContentManagerScriptMessageFromDOMBindings):
1337         (beforeAll):
1338         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1339         (documentLoadedCallback):
1340
1341 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         Unreviewed. Fix GTK+ clean build after r175930.
1344
1345         Partial rollout of r175930 to not build the new unit test that
1346         broke clean builds in GTK+ port.
1347
1348         * TestWebKitAPI/PlatformGTK.cmake:
1349
1350 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1351
1352         [WK2] UserMediaClient support
1353         https://bugs.webkit.org/show_bug.cgi?id=123158
1354
1355         Reviewed by Benjamin Poulain.
1356
1357         Simple API test for the UserMedia permission request API. The
1358         required test infrastructure is also added, inspired by the
1359         Geolocation infrastructure.
1360
1361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1362         Permission request.
1363         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1364         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1365         (TestWebKitAPI::TEST):
1366         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1368         helper method to set the permission request result without user interaction.
1369         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1370         (WTR::InjectedBundle::setUserMediaPermission):
1371         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1372         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1373         (WTR::TestRunner::setUserMediaPermission):
1374         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1375         * WebKitTestRunner/TestController.cpp:
1376         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1377         request handler.
1378         (WTR::TestController::createOtherPage): Enable the new UserMedia
1379         permission request handler.
1380         (WTR::TestController::createWebViewWithOptions): Ditto.
1381         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1382         MediaStream support, this is needed for getUserMedia.
1383         (WTR::TestController::resetStateToConsistentValues): clear
1384         UserMedia permissions list and flags.
1385         (WTR::TestController::setUserMediaPermission): Set permission
1386         request result and distpatch it.
1387         (WTR::TestController::handleUserMediaPermissionRequest): Save
1388         request and dispatch it.
1389         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1390         Dispatch cached permission requests.
1391         * WebKitTestRunner/TestController.h:
1392         * WebKitTestRunner/TestInvocation.cpp:
1393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1394
1395 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1396
1397         webkit-patch --suggest-reviewers is broken with newer versions of git
1398         <http://webkit.org/b/138627>
1399
1400         Reviewed by Michael Saboff with feedback from Daniel Bates.
1401
1402         * Scripts/webkitpy/common/checkout/scm/git.py:
1403         (Git._changes_files_for_commit): Strip blank lines instead of
1404         assuming there is always a blank line at the beginning of the
1405         list.
1406
1407 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1408
1409         DRT and WKTR touch disk cache
1410         https://bugs.webkit.org/show_bug.cgi?id=138622
1411
1412         Reviewed by Geoffrey Garen.
1413
1414         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1415         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1416         because this function uses the shared cache.
1417
1418         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1419         Create an empty shared cache to prevent a default one from being created on disk.
1420
1421 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1422
1423         [CSS Grid Layout] Limit the size of explicit/implicit grid
1424         https://bugs.webkit.org/show_bug.cgi?id=136217
1425
1426         Reviewed by Andreas Kling.
1427
1428         Added a new unit test for the CSS parser. Right now it only checks
1429         that we properly clamp the maximum number of tracks on a grid to a
1430         maximum of 1 million.
1431
1432         * TestWebKitAPI/CMakeLists.txt:
1433         * TestWebKitAPI/PlatformEfl.cmake:
1434         * TestWebKitAPI/PlatformGTK.cmake:
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1437         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1438         (TestWebKitAPI::TEST): Added a
1439         CSSPropertyParserTest.GridTrackLimits test case.
1440
1441 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1442
1443         webkitpy test fix after r175867
1444         https://bugs.webkit.org/show_bug.cgi?id=138607
1445
1446         Reviewed by Philippe Normand.
1447
1448         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1449         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1450
1451 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1452
1453         webkitpy: demangle C++ symbols from crash log stderr
1454         https://bugs.webkit.org/show_bug.cgi?id=138565
1455
1456         Reviewed by Alexey Proskuryakov.
1457
1458         * Scripts/webkitpy/port/linux_get_crash_log.py:
1459         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1460         with c++filt.
1461
1462 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1463
1464         [GTK] fix up the GDB backtrace report tool
1465         https://bugs.webkit.org/show_bug.cgi?id=138564
1466
1467         Reviewed by Carlos Garcia Campos.
1468
1469         * Scripts/webkitpy/port/gtk.py:
1470         (GtkPort._get_crash_log): Match the process name reported by the
1471         driver with the GTK port WebProcess executable filename.
1472         * Scripts/webkitpy/port/linux_get_crash_log.py:
1473         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1474         program.
1475         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1476         pattern to workaround the 16 characters size limit of %e.
1477
1478 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1479
1480         Unreviewed, moved myself to the list of committers.
1481
1482         * Scripts/webkitpy/common/config/contributors.json:
1483
1484 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1485
1486         [EFL] Fix the test font path after r175555.
1487
1488         Reviewed by Csaba Osztrogonác.
1489
1490         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1491
1492 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1493
1494         Fix the exception fuzz helper to generate targets in the correct range
1495         https://bugs.webkit.org/show_bug.cgi?id=138544
1496
1497         Reviewed by Filip Pizlo.
1498
1499         Currently, the script generates exception fuzz targets in the range of
1500         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1501         always outside of the outermost try block of the tests, which therefore
1502         prints unexpected output and results in false failures when fired at.
1503         Additionally, target $checkCount is never generated.
1504
1505         This patch fixes the script to generate targets in the range of
1506         2..$checkCount.
1507
1508         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1509
1510 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1511
1512         make-passwords-json.py should generarate everything needed for testing
1513         https://bugs.webkit.org/show_bug.cgi?id=138503
1514
1515         Reviewed by Ryosuke Niwa.
1516
1517         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1518         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1519         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1520         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1521         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1522         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1523         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1524
1525 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1526
1527         [GTK] generate-gtkdoc should ignore invalid files
1528         https://bugs.webkit.org/show_bug.cgi?id=138542
1529
1530         Reviewed by Darin Adler.
1531
1532         * gtk/generate-gtkdoc:
1533         (files_to_ignore.file_should_be_ignored): Return True to ignore
1534         invalid files.
1535
1536 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1537
1538         Delete cookies between tests
1539         https://bugs.webkit.org/show_bug.cgi?id=138528
1540
1541         Reviewed by Sam Weinig.
1542
1543         * DumpRenderTree/mac/DumpRenderTree.mm:
1544         (resetWebPreferencesToConsistentValues):
1545         * WebKitTestRunner/TestController.cpp:
1546         (WTR::TestController::resetPreferencesToConsistentValues):
1547         Do it.
1548
1549         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1550         (WTR::InjectedBundle::beginTesting):
1551         Added a FIXME.
1552
1553 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1554
1555         [GTK] Run layout tests using the network process
1556         https://bugs.webkit.org/show_bug.cgi?id=138428
1557
1558         Reviewed by Martin Robinson.
1559
1560         Shared secondary process is the default in the GTK+ port, but we
1561         should run the tests using the network process to ensure
1562         everything works with the network process. In the future, the
1563         shared secondary process model might be a special case of multiple
1564         processes with 1 as maximum number of processes, but always using
1565         the network process.
1566
1567         * WebKitTestRunner/TestController.cpp:
1568         (WTR::TestController::initialize):
1569
1570 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         [GTK] Allow to create a view with a related page in WTR
1573         https://bugs.webkit.org/show_bug.cgi?id=138501
1574
1575         Reviewed by Martin Robinson.
1576
1577         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1578         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1579         related page to WKViewCreate.
1580         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1581         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1582         page to WKViewCreate.
1583
1584 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1585
1586         WTR crashes after running a test when NetworkProcess enabled
1587         https://bugs.webkit.org/show_bug.cgi?id=138500
1588
1589         Reviewed by Alexey Proskuryakov.
1590
1591         WebNotificationProvider destructor is calling
1592         WKNotificationManagerSetProvider, but m_notificationManager is
1593         null because removeNotificationManager was already called.
1594
1595         * WebKitTestRunner/WebNotificationProvider.cpp:
1596         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1597         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1598
1599 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1600
1601         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1602         regarding incorrect call to PatchAnalysisTask.report_failure
1603         https://bugs.webkit.org/show_bug.cgi?id=138229
1604
1605         Reviewed by Daniel Bates.
1606
1607         * Scripts/webkitpy/common/net/layouttestresults.py:
1608         Makes sure test_results returns a list.
1609         (LayoutTestResults.test_results):
1610         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1611         Makes unit tests also check to make sure
1612         task.results_from_patch_test_run() and
1613         task.results_from_test_run_without_patch return instances of
1614         LayoutTestResults.
1615         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1616         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1617         Condenses duplicate code into _should_defer_patch_or_throw, and
1618         removes the now-unused _clean_tree_results member.
1619         (PatchAnalysisTask.__init__):
1620         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1621         (PatchAnalysisTask._should_defer_patch_or_throw):
1622         (PatchAnalysisTask._test_patch):
1623         (PatchAnalysisTask.results_from_patch_test_run):
1624         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1625         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1626         Removes needless call to results_from_test_run_without_patch
1627         (AbstractEarlyWarningSystem._failing_tests_message):
1628         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1629         Changes order of test failure messages to be in the order that they
1630         appear.
1631         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1632         * Scripts/webkitpy/tool/commands/queues.py:
1633         Removes needless call to results_from_test_run_without_patch.
1634         (CommitQueue._failing_tests_message):
1635         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1636         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1637
1638 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1639
1640         Unreviewed. Reorder my e-mail addresses in contributors.json
1641
1642         * Scripts/webkitpy/common/config/contributors.json:
1643
1644 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1645
1646         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1647         https://bugs.webkit.org/show_bug.cgi?id=138475
1648
1649         Reviewed by Ryosuke Niwa.
1650
1651         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1652         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1653         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1654         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1655
1656         * Scripts/webkitpy/common/checkout/scm/git.py:
1657         (Git._run_git_svn_find_rev):
1658         Add comment mentioning that svn_revisions need to begin with 'r'.
1659         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1660         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1661         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1662
1663 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         [GTK] Add context menu API to Web Process Extensions
1666         https://bugs.webkit.org/show_bug.cgi?id=138311
1667
1668         Reviewed by Gustavo Noronha Silva.
1669
1670         Add tests cases for WebKitWebPage::context-menu signal.
1671
1672         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1673         (testContextMenuWebExtensionMenu):
1674         (testContextMenuWebExtensionNode):
1675         (beforeAll):
1676         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1677         (serializeContextMenu):
1678         (serializeNode):
1679         (contextMenuCallback):
1680         (pageCreatedCallback):
1681
1682 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1683
1684         Unreviewed, rolling out r175690.
1685         https://bugs.webkit.org/show_bug.cgi?id=138460
1686
1687         We are not ready to run layout tests using the network process
1688         yet (Requested by KaL on #webkit).
1689
1690         Reverted changeset:
1691
1692         "[GTK] Run layout tests using the network process"
1693         https://bugs.webkit.org/show_bug.cgi?id=138428
1694         http://trac.webkit.org/changeset/175690
1695
1696 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1697
1698         [GTK] Run layout tests using the network process
1699         https://bugs.webkit.org/show_bug.cgi?id=138428
1700
1701         Reviewed by Martin Robinson.
1702
1703         Shared secondary process is the default in the GTK+ port, but we
1704         should run the tests using the network process to ensure
1705         everything works with the network process. In the future, the
1706         shared secondary process model might be a special case of multiple
1707         processes with 1 as maximum number of processes, but always using
1708         the network process.
1709
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::initialize):
1712
1713 2014-11-05  Dan Bernstein  <mitz@apple.com>
1714
1715         Remove the unused deletion UI feature
1716         https://bugs.webkit.org/show_bug.cgi?id=138442
1717
1718         Rubber-stamped by Alexey Proskuryakov.
1719
1720         * DumpRenderTree/mac/EditingDelegate.mm:
1721         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1722         delegate method that’s been removed.
1723
1724 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1725
1726         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1727         https://bugs.webkit.org/show_bug.cgi?id=138334
1728
1729         Reviewed by Anders Carlsson.
1730
1731         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1732         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1733         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1734         it also needs to reset internal focus explicitly.
1735
1736         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1737         WebKit behavior appears wrong, but it matches Firefox.
1738
1739         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1740         (WTR::InjectedBundlePage::resetAfterTest):
1741
1742 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1743
1744         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1745         https://bugs.webkit.org/show_bug.cgi?id=137862
1746
1747         Reviewed by Gustavo Noronha Silva.
1748
1749         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1750         is emitted when a subresource load fails due to TLS errors.
1751
1752         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1753         (TLSSubresourceTest::resourceLoadStartedCallback):
1754         (TLSSubresourceTest::TLSSubresourceTest):
1755         (TLSSubresourceTest::subresourceFailedCallback):
1756         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1757         (TLSSubresourceTest::subresourceLoadStarted):
1758         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1759         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1760         (testSubresourceLoadFailedWithTLSErrors):
1761         (httpsServerCallback):
1762         (httpServerCallback):
1763         (beforeAll):
1764
1765 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1766
1767         Build fix for some compiler versions.
1768
1769         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1770         unhappy because this is a getter, and these shouldn't have side effects.
1771
1772 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1773
1774         Add a method for performing cherrypick-merges.
1775         https://bugs.webkit.org/show_bug.cgi?id=138375
1776
1777         Reviewed by Ryosuke Niwa.
1778
1779         Adds support for cherrypick-merges.
1780
1781         * Scripts/webkitpy/common/checkout/scm/git.py:
1782         (Git.cherrypick_merge): Added.
1783
1784 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1785
1786         Add a way to ascertain the SVN URL associated with a Git branch.
1787         https://bugs.webkit.org/show_bug.cgi?id=138374
1788
1789         Reviewed by Ryosuke Niwa.
1790
1791         The svn_url method returns the SVN URL associated with the current Git branch.
1792
1793         * Scripts/webkitpy/common/checkout/scm/git.py:
1794         (Git.svn_url): Added.
1795
1796 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1797
1798         Add the ability to search for modifications that are staged for commit.
1799         https://bugs.webkit.org/show_bug.cgi?id=138373
1800
1801         Reviewed by Ryosuke Niwa and Daniel Bates.
1802
1803         This makes is easy to do identify files that require merge post-processing,
1804         in addition to stand-alone utility.
1805
1806         * Scripts/webkitpy/common/checkout/scm/git.py:
1807         (Git.modifications_staged_for_commit): Added.
1808
1809 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1810
1811         Add a branch keyword argument to _run_git_svn_find_rev.
1812         https://bugs.webkit.org/show_bug.cgi?id=138372
1813
1814         Reviewed by Ryosuke Niwa.
1815
1816         The addition of this keyword argument allows clients to determine the Git hash
1817         of commits made on an SVN branch, provided that branch has been fetched locally.
1818
1819         * Scripts/webkitpy/common/checkout/scm/git.py:
1820         (Git._run_git_svn_find_rev):
1821         Add a branch keyword argument that is added to the end of the command, if present.
1822
1823 2014-11-04  Chris Dumez  <cdumez@apple.com>
1824
1825         Add ptr() method to Ref class
1826         https://bugs.webkit.org/show_bug.cgi?id=138361
1827
1828         Reviewed by Darin Adler.
1829
1830         Use the new Ref::ptr() method.
1831
1832         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1833         (TestWebKitAPI::TEST):
1834
1835 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1836
1837         [jhbuild] Make it possible to build GTK/EFL in same repository
1838         https://bugs.webkit.org/show_bug.cgi?id=137448
1839
1840         Reviewed by Martin Robinson.
1841
1842         * Scripts/webkitdirs.pm:
1843         (getJhbuildPath):
1844         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1845         (getPlatformFontsPath):
1846         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1847         (WTR::getFontsPath):
1848         * jhbuild/jhbuild-wrapper:
1849         (determine_platform):
1850         (install_jhbuild):
1851         * jhbuild/jhbuildrc_common.py:
1852         (init):
1853
1854 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1855
1856         [EFL] Bump LLVM to version 3.5.0
1857         https://bugs.webkit.org/show_bug.cgi?id=138312
1858
1859         Reviewed by Csaba Osztrogonác.
1860
1861         * efl/jhbuild.modules:
1862         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1863         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1864
1865 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1866
1867         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1868         https://bugs.webkit.org/show_bug.cgi?id=138257
1869
1870         Reviewed by Tim Horton.
1871         
1872         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1873         the user to toggle region page overlays on and off. Two overlays are available,
1874         for the non-fast scrollable region, and the region of element with wheel
1875         event handlers.
1876
1877         * MiniBrowser/mac/SettingsController.h:
1878         * MiniBrowser/mac/SettingsController.m:
1879         (-[SettingsController _populateMenu]):
1880         (-[SettingsController validateMenuItem:]):
1881         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1882         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1883         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1884         (-[SettingsController toggleDebugOverlay:]):
1885         (-[SettingsController debugOverlayVisible:]):
1886         * MiniBrowser/mac/WK2BrowserWindowController.m:
1887         (-[WK2BrowserWindowController didChangeSettings]):
1888
1889 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1890
1891         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1892         https://bugs.webkit.org/show_bug.cgi?id=138323
1893
1894         Reviewed by Zalan Bujtas.
1895
1896         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1897
1898 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1899
1900         [ninja] Don't remove response files for verbose builds
1901         https://bugs.webkit.org/show_bug.cgi?id=137816
1902
1903         Reviewed by Csaba Osztrogonác.
1904
1905         * Scripts/webkitdirs.pm:
1906         (determineNinjaVersion):
1907         (buildCMakeGeneratedProject):
1908
1909 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1910
1911         [GTK] Fix the build of FTL JIT
1912         https://bugs.webkit.org/show_bug.cgi?id=138298
1913
1914         Reviewed by Carlos Garcia Campos.
1915
1916         * gtk/jhbuild-optional.modules:
1917         Bump up LLVM version to 3.5.0 release and apply patches.
1918         * gtk/patches/llvm-elf-add-stackmaps.patch:
1919         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1920         trunk.
1921         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1922         Added. Ensures that PC-relative relocations in EH frames are not
1923         truncated to 32 bits on x86_64.
1924
1925 2014-10-31  Michael Saboff  <msaboff@apple.com>
1926
1927         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1928         https://bugs.webkit.org/show_bug.cgi?id=138268
1929
1930         Reviewed by Andreas Kling.
1931
1932         Added a --arch and --os option to set or override the values that are
1933         normally computed based on examining the JavaScriptCore we want to test.
1934
1935         * Scripts/run-jsc-stress-tests:
1936
1937 2014-10-31  Dan Bernstein  <mitz@apple.com>
1938
1939         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1940         https://bugs.webkit.org/show_bug.cgi?id=138259
1941
1942         Reviewed by Geoff Garen.
1943
1944         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1945         going to be empty to silence the warning.
1946
1947 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1948
1949         [GTK] Support script message handlers WebKitUserContentManager
1950         https://bugs.webkit.org/show_bug.cgi?id=133730
1951
1952         Reviewed by Carlos Garcia Campos.
1953
1954         Support user script message handlers in WebKitUserContentManager.
1955         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1956         an option is added to the CMake build files. The option is disabled
1957         globally by default, and the WebKitGTK port enables it. On the API
1958         level, two new methods to register and unregister names are provided
1959         in the "window.webkit" namespace, and on message reception the
1960         "WebKitUserContentManager::script-message-received" signal is
1961         emitted, using the registered names as signal detail.
1962
1963         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1964         Add test case for user script message handlers.
1965         (scriptMessageReceived):
1966         (testUserContentManagerScriptMessageReceived):
1967         (beforeAll):
1968
1969 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1970
1971         bisect-builds should support WebKit clients other than Safari
1972         https://bugs.webkit.org/show_bug.cgi?id=138225
1973
1974         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1975
1976         The -a / --application optional argument allows the user to specify which application (or application bundle)
1977         should be run against the WebKit nightly builds.
1978
1979         Reviewed by David Kilzer.
1980
1981         * Scripts/bisect-builds:
1982         Swap out $safariPath for the more general $applicationPath
1983         Leave --safari-path as a commandline option for backwards compatibility
1984         (mountAndRunNightly):
1985         Use File::Spec->cat correctly (one directory per argument)
1986         Use open --wait-apps instead of running the target application directly
1987
1988 2014-10-30  Dana Burkart  <dburkart@apple.com>
1989
1990         <rdar://problem/18821260> Perpare for the mysterious future
1991
1992         Reviewed by Lucas Forschler.
1993
1994         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1995         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1996         * LayoutTestRelay/Configurations/Base.xcconfig:
1997         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1998         * MiniBrowser/Configurations/Base.xcconfig:
1999         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2000         * TestWebKitAPI/Configurations/Base.xcconfig:
2001         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2002         * WebKitLauncher/Configurations/Base.xcconfig:
2003         * WebKitTestRunner/Configurations/Base.xcconfig:
2004         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2005
2006 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2007
2008         Update safariVersion to safariVersionString
2009         https://bugs.webkit.org/show_bug.cgi?id=138193
2010
2011         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
2012         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
2013
2014         Rubber-stamped by David Kilzer.
2015
2016         * Scripts/bisect-builds:
2017         (makeNightlyList):
2018         Compare safariVersionString to a string literal, instead of safariVersion.
2019
2020 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
2021
2022         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
2023         https://bugs.webkit.org/show_bug.cgi?id=137775
2024
2025         Reviewed by Carlos Garcia Campos.
2026
2027         * MiniBrowser/gtk/BrowserWindow.c:
2028         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
2029         (browser_window_init):
2030
2031 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
2032
2033         CommitQueue and EWS should reject any patches that result in consistent test
2034         failures that aren't present on the tree.
2035         https://bugs.webkit.org/show_bug.cgi?id=138184
2036
2037         Reviewed by Alexey Proskuryakov.
2038
2039         * Scripts/webkitpy/layout_tests/models/test_results.py:
2040         Adds a simple hashing function to allow for set operations to handle
2041         TestResult objects properly.
2042         (TestResult.__hash__):
2043         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2044         Adds one unit test, and modifies others to agree with the notion that
2045         patches that introduce new test failures (but also have flakyness)
2046         should be rejected rather than spin.
2047         (MockCommitQueue.report_flaky_tests):
2048         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2049         (test_double_flaky_test_failure):
2050         (test_two_flaky_tests):
2051         (test_very_flaky_patch):
2052         (test_very_flaky_patch_with_some_tree_redness):
2053         (test_different_test_failures):
2054         (test_different_test_failures_with_some_tree_redness):
2055         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
2056         (test_mildly_flaky_patch):
2057         (test_mildly_flaky_patch_with_some_tree_redness):
2058         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2059         Makes PatchAnalysisTask reject said patches.
2060         (PatchAnalysisTask._test_patch):
2061
2062 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2063
2064         WinCairoRequirements.zip cannot be downloaded from dropbox
2065         https://bugs.webkit.org/show_bug.cgi?id=138113
2066
2067         Reviewed by Alexey Proskuryakov.
2068
2069         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
2070
2071 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
2072
2073         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
2074         https://bugs.webkit.org/show_bug.cgi?id=138193
2075
2076         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
2077         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
2078
2079         It also does a bit of refactoring, including distinguishing between versions and version strings and
2080         saving versions to local variables instead of using eval in each conditional.
2081
2082         Reviewed by David Kilzer.
2083
2084         * Scripts/bisect-builds:
2085         (makeNightlyList):
2086         Restrict the set of nightlies to r174650 and above when running Yosemite.
2087         Restrict the set of nightlies to r157846 and above when running Mavericks.
2088         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
2089
2090 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2091
2092         [EFL] build-webkit should try harder to avoid re-running cmake
2093         https://bugs.webkit.org/show_bug.cgi?id=137949
2094
2095         Reviewed by Martin Robinson.
2096
2097         * Scripts/webkitdirs.pm:
2098         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
2099         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
2100
2101 2014-10-28  Daniel Bates  <dabates@apple.com>
2102
2103         Unify logic in RunTests.run() to run the Python unit tests
2104         https://bugs.webkit.org/show_bug.cgi?id=138160
2105
2106         Reviewed by Martin Robinson.
2107
2108         Unify the interactive and non-interactive code path for running the Python unit tests
2109         in step RunTests so as to remove duplicate code to compute the the path to the script
2110         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
2111
2112         No new tests since no functionality was changed.
2113
2114         * Scripts/webkitpy/port/base.py:
2115         (Port.python_unittest_results_directory):
2116         * Scripts/webkitpy/tool/steps/runtests.py:
2117         (RunTests.run):
2118
2119 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
2120
2121         Make runtest.py call test-webkitpy with the --json flag when in
2122         non-interactive mode.
2123         https://bugs.webkit.org/show_bug.cgi?id=137667
2124
2125         Reviewed by Daniel Bates.
2126
2127         * Scripts/webkitpy/port/base.py:
2128         Adds the python_unittest_results_directory method.
2129         (Port.python_unittest_results_directory):
2130         * Scripts/webkitpy/tool/steps/runtests.py:
2131         Changes RunTests to call test-webkitpy with the --json flag if the
2132         --non-interactive flag is set.
2133         (RunTests):
2134         (RunTests.run):
2135
2136 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
2137
2138         import-w3c-tests should use re.escape() wherever it's handling file paths
2139         https://bugs.webkit.org/show_bug.cgi?id=137934
2140
2141         This patch adds re.escape() to a few places where we're doing string
2142         conversions. This prevents errors when attribute values coincidentally
2143         have character sequences that can be interpreted as regular expressions.
2144
2145         Reviewed by Bem Jones-Bey.
2146
2147         * Scripts/webkitpy/w3c/test_converter.py:
2148         (_W3CTestConverter.convert_attributes_if_needed):
2149
2150 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2151
2152         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
2153         https://bugs.webkit.org/show_bug.cgi?id=138130
2154
2155         Reviewed by Csaba Osztrogonác.
2156
2157         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2158
2159 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
2160
2161         Fix link to Arch Linux Wiki
2162         https://bugs.webkit.org/show_bug.cgi?id=138010
2163
2164         Reviewed by Benjamin Poulain.
2165
2166         * gtk/install-dependencies:
2167
2168 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
2169
2170         Test regressions are not detected when image result is missing
2171         https://bugs.webkit.org/show_bug.cgi?id=138070
2172
2173         Reviewed by Simon Fraser.
2174
2175         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2176         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2177         Count these as regressions, not as flaky tests.
2178
2179         * Scripts/webkitpy/port/test.py:
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2181         Test it.
2182
2183 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2184
2185         Add Conrad Shultz to the contributors list.
2186
2187         * Scripts/webkitpy/common/config/contributors.json:
2188
2189 2014-10-24  Dan Bernstein  <mitz@apple.com>
2190
2191         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2192         https://bugs.webkit.org/show_bug.cgi?id=138046
2193
2194         Reviewed by Alexey Proskuryakov.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2197         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2198         401. Otherwise, we’ll retry normally in 45 seconds.
2199
2200 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2201
2202         [GTK] Implement is_selected method on WebKitHitTestResult
2203         https://bugs.webkit.org/show_bug.cgi?id=137110
2204
2205         Reviewed by Tim Horton.
2206
2207         Add tests for new context SELECTION on WebKitHitTestResult.
2208
2209         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2210         (testContextMenuDefaultMenu):
2211         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2212         (testWebViewMouseTarget):
2213
2214 2014-10-23  Roger Fong  <roger_fong@apple.com>
2215
2216         [Win] Skip failing JSC tests following r175078
2217         https://bugs.webkit.org/show_bug.cgi?id=130967.
2218
2219         * Scripts/run-javascriptcore-tests:
2220
2221 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2222
2223         commitqueuetask_unittest.py should be made more concise.
2224         https://bugs.webkit.org/show_bug.cgi?id=137985
2225
2226         Reviewed by Alexey Proskuryakov.
2227
2228         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2229         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2230         (MockCommitQueue.__init__):
2231         (MockCommitQueue.report_flaky_tests):
2232         (MockCommitQueue):
2233         (MockCommitQueue.get_reported_flaky_tests):
2234         (MockSimpleTestPlanCommitQueue.__init__):
2235         (MockSimpleTestPlanCommitQueue.run_command):
2236         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2237         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2238         (test_land_failure):
2239         (test_failed_archive):
2240         (test_double_flaky_test_failure):
2241         (test_test_failure):
2242         (test_red_test_failure):
2243         (test_very_red_tree_retry):
2244         (test_red_tree_patch_rejection):
2245         (test_one_flaky_test):
2246         (test_tree_more_red_than_patch):
2247         (MockCommitQueue.test_results): Deleted.
2248         (test_simple_flaky_test_failure): Deleted.
2249         (_expect_validate): Deleted.
2250         (_expect_validate.MockDelegate): Deleted.
2251         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2252         (_expect_validate.MockDelegate.expected_failures): Deleted.
2253         (_mock_patch): Deleted.
2254         (test_validate): Deleted.
2255         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2256         Fixes a bug that slipped through the cracks prior to this change.
2257         (PatchAnalysisTask._test_patch):
2258
2259 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2260
2261         Flakiness dashboard should support OS X Yosemite
2262         https://bugs.webkit.org/show_bug.cgi?id=137986
2263
2264         Reviewed by Ryosuke Niwa.
2265
2266         * TestResultServer/app.yaml:
2267         * TestResultServer/static-dashboards/builders.jsonp:
2268         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2269
2270 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2271
2272         commitqueuetask should include more tests to ensure that the behavior
2273         of PatchAnalysisTask._test_patch() is well defined
2274         https://bugs.webkit.org/show_bug.cgi?id=137977
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2279         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2280         and more readable to define tests that are meant to test the behaviour
2281         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2282         (FailingTestCommitQueue.test_results):
2283         (PatchAnalysisResult):
2284         (MockSimpleTestPlanCommitQueue):
2285         (MockSimpleTestPlanCommitQueue.__init__):
2286         (MockSimpleTestPlanCommitQueue.run_command):
2287         (MockSimpleTestPlanCommitQueue._mock_test_result):
2288         (MockSimpleTestPlanCommitQueue.test_results):
2289         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2290         (test_flaky_test_failure):
2291         (test_failed_archive):
2292         (test_two_flaky_tests):
2293         (test_one_flaky_test):
2294         (test_very_flaky_patch):
2295         (test_very_flaky_patch_with_some_tree_redness):
2296         (test_different_test_failures):
2297         (test_different_test_failures_with_some_tree_redness):
2298         (test_mildly_flaky_patch):
2299         (test_mildly_flaky_patch_with_some_tree_redness):
2300         (test_tree_more_red_than_patch):
2301
2302 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2303
2304         PatchAnalysisTask._test_patch() needs refactoring
2305         https://bugs.webkit.org/show_bug.cgi?id=137904
2306
2307         Reviewed by Alexey Proskuryakov.
2308
2309         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2310         Fixes several small bugs, and makes minor changes to accomodate the
2311         changes in PatchAnalysisTask.
2312         (MockCommitQueue.refetch_patch):
2313         (MockCommitQueue.test_results):
2314         (test_flaky_test_failure):
2315         (test_failed_archive):
2316         (test_very_red_tree_retry):
2317         (_expect_validate.MockDelegate.refetch_patch):
2318         (MockCommitQueue.expected_failures): Deleted.
2319         (_expect_validate.MockDelegate.expected_failures): Deleted.
2320         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2321         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2322         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2323         Removes the unexpected_failures member, adds the _clean_tree_results
2324         member, adds a helper function for _test_patch, and refactors
2325         _test_patch to be more readable.
2326         (PatchAnalysisTask.__init__):
2327         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2328         (PatchAnalysisTask._test_patch):
2329         (PatchAnalysisTask.results_from_test_run_without_patch):
2330         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2331         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2332         (AbstractEarlyWarningSystem.begin_work_queue):
2333         (AbstractEarlyWarningSystem._failing_tests_message):
2334         (AbstractEarlyWarningSystem.command_failed):
2335         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2336         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2337         Makes changes to accomodate the changes made to PatchAnalysisTask.
2338         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2339         * Scripts/webkitpy/tool/commands/perfalizer.py:
2340         Removes Perfalizer's dependancy on ExpectedFailures. 
2341         (PerfalizerTask.refetch_patch):
2342         (PerfalizerTask.expected_failures): Deleted.
2343         * Scripts/webkitpy/tool/commands/queues.py:
2344         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2345         initializer to allow for mock injection.
2346         (CommitQueue.__init__):
2347         (CommitQueue.begin_work_queue):
2348         (CommitQueue.process_work_item):
2349         (CommitQueue._failing_tests_message):
2350         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2351         Removes dependancy on ExpectedFailures, and instead uses mock
2352         injection.
2353         (MockCommitQueueTask):
2354         (MockCommitQueueTask.results_from_patch_test_run):
2355         (MockCommitQueueTask.results_from_test_run_without_patch):
2356         (mock_run_webkit_patch):
2357
2358 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2359
2360         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2361         https://bugs.webkit.org/show_bug.cgi?id=136736
2362
2363         Reviewed by Gyuyoung Kim.
2364
2365         * MiniBrowser/efl/main.c:
2366         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2367         (window_create):
2368
2369 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2370
2371         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2372         https://bugs.webkit.org/show_bug.cgi?id=137884
2373
2374         Reviewed by Gustavo Noronha Silva.
2375
2376         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2377         and adapt it to use the new InputMethodFilter WebKit class. Instead
2378         of having virtual methods just for testing, it has a testing mode
2379         that logs the events.
2380
2381         * TestWebKitAPI/PlatformGTK.cmake:
2382         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2383         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2384         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2385         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2386         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2387         (TestWebKitAPI::TEST):
2388         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2389         (TestWebKitAPI::temporaryResetOverride):
2390         (TestWebKitAPI::verifyCanceledComposition):
2391
2392 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2393
2394         build.webkit.org/dashboard: Cannot click on green tester bubbles
2395         https://bugs.webkit.org/show_bug.cgi?id=137909
2396
2397         Reviewed by Darin Adler.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2400         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2401
2402 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2403
2404         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2405         https://bugs.webkit.org/show_bug.cgi?id=137932
2406
2407         Reviewed by Simon Fraser.
2408
2409         This is the first step in moving over to native Windows rendering for our layout tests.
2410         Once this change lands, approximately 300 tests will start failing on Windows. I will
2411         rebaseline these changes against our test hardware and update this bug with the
2412         commits related to that work.
2413
2414         * DumpRenderTree/win/DumpRenderTree.cpp:
2415         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2416         we use native Windows drawing style.
2417
2418 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2419
2420         Fix FTL Native Inlining for EFL
2421         https://bugs.webkit.org/show_bug.cgi?id=137774
2422
2423         Reviewed by Michael Saboff.
2424
2425         Added Clang as an optional module to jhbuild.
2426
2427         * efl/jhbuild.modules:
2428
2429 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2430
2431         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2432         https://bugs.webkit.org/show_bug.cgi?id=137832
2433
2434         Reviewed by Carlos Garcia Campos.
2435
2436         Ensure each test sets the TLS errors policy that it really needs.
2437         Have each test except testTLSErrorsPolicy stash and restore the original
2438         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2439         default policy.
2440
2441         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2442         (testSSL):
2443         (testInsecureContent):
2444         (testTLSErrorsPolicy):
2445         (testTLSErrorsRedirect):
2446         (testTLSErrorsHTTPAuth):
2447         (testLoadFailedWithTLSErrors):
2448         (beforeAll):
2449
2450 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2451
2452         Unreviewed. Unskip inspector server unit tests.
2453
2454         They should pass now.
2455
2456         * Scripts/run-gtk-tests:
2457         (TestRunner):
2458
2459 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2460
2461         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2462         https://bugs.webkit.org/show_bug.cgi?id=132044
2463
2464         Reviewed by Brian Burg.
2465
2466         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2467         (openRemoteDebuggingSession): Remove trailing slash when
2468         concatenating base inspector URL with the page, because the
2469         inspector returns the relative paths with a leading slash.
2470
2471 2014-10-20  Tanay C  <tanay.c@samsung.com>
2472
2473         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2474         https://bugs.webkit.org/show_bug.cgi?id=137023
2475
2476         Reviewed by Gyuyoung Kim.
2477
2478         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2479         (search_box_show): Modified.
2480         (search_box_hide): Modified.
2481         (on_search_field_activated): Modified.
2482         (on_search_backward_button_clicked): Modified.
2483         (on_search_forward_button_clicked): Modified.
2484         (on_search_case_option_changed): Added.
2485         (on_search_word_start_option_changed): Added.
2486         (window_create): Modified.
2487
2488 2014-10-20  Tanay C  <tanay.c@samsung.com>
2489
2490         [GTK][Minibrowser] Escape key does not hide the search box
2491         https://bugs.webkit.org/show_bug.cgi?id=137734
2492
2493         Reviewed by Philippe Normand.
2494
2495         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2496         (stopPageLoad): Modified.
2497
2498 2014-10-18  Antti Koivisto  <antti@apple.com>
2499
2500         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2501         https://bugs.webkit.org/show_bug.cgi?id=137855
2502
2503         Reviewed by Dan Bernstein.
2504
2505         Test and warn if the dumped response mime type differs from the platform response mime type.
2506
2507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2508         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2509         (WTR::InjectedBundlePage::platformResponseMimeType):
2510         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2511         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2512         (WTR::InjectedBundlePage::platformResponseMimeType):
2513
2514 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2515
2516         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2517         https://bugs.webkit.org/show_bug.cgi?id=137835
2518
2519         Reviewed by Andreas Kling.
2520
2521         * Scripts/run-inspector-perf-tests.py: Removed.
2522         This script is stale, as PerformanceTests/inspector no longer exists.
2523
2524 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2525
2526         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2527
2528         * Scripts/webkitpy/port/ios.py:
2529         (IOSSimulatorPort.default_baseline_search_path):
2530
2531 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2532
2533         [iOS] Simplify test fallback paths for iOS Simulator testing
2534         https://bugs.webkit.org/show_bug.cgi?id=137830
2535
2536         Reviewed by Zalan Bujtas.
2537         
2538         Make the fallback paths be:
2539             ios-simulator -> generic
2540             ios-simulator-wk2->ios-simulator -> generic
2541         
2542         so don't include mac in the fallback path. Also remove the
2543         version handling for simplicity.
2544
2545         * Scripts/webkitpy/port/ios.py:
2546         (IOSSimulatorPort):
2547         (IOSSimulatorPort.default_baseline_search_path):
2548
2549 2014-10-17  Dana Burkart  <dburkart@apple.com>
2550
2551         Fix typos in the dashboard config file.
2552
2553         Unreviewed.
2554
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2556         (WebKitBuildbot):
2557
2558 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2559
2560         [Win] Allow WinLauncher to specify Custom User Agent strings
2561         https://bugs.webkit.org/show_bug.cgi?id=137828
2562
2563         Reviewed by Dean Jackson.
2564
2565         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2566         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2567         and set the user agent strings.
2568         * WinLauncher/WinLauncher.h:
2569         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2570         resources and dialog for setting custom User Agent strings.
2571         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2572
2573 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2574
2575         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2576         https://bugs.webkit.org/show_bug.cgi?id=137806
2577
2578         Reviewed by Sam Weinig.
2579
2580         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2581         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2582         to disable font autosizing.
2583         
2584         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2585         test controller to set platform-specific prefs.
2586
2587         * WebKitTestRunner/TestController.cpp:
2588         (WTR::TestController::resetPreferencesToConsistentValues):
2589         (WTR::TestController::platformResetPreferencesToConsistentValues):
2590         * WebKitTestRunner/TestController.h:
2591         * WebKitTestRunner/ios/TestControllerIOS.mm:
2592         (WTR::TestController::platformResetPreferencesToConsistentValues):
2593         * WebKitTestRunner/mac/TestControllerMac.mm:
2594         (WTR::TestController::platformResetPreferencesToConsistentValues):
2595
2596 2014-10-16  Dan Bernstein  <mitz@apple.com>
2597
2598         OSObjectPtr is missing leakRef()
2599         https://bugs.webkit.org/show_bug.cgi?id=137798
2600
2601         Reviewed by Sam Weinig.
2602
2603         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2604         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2605
2606 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2607
2608         Update target platform to remove Leopard, Snow Leopard, Lion.
2609         Add Yosemite. 
2610         
2611         Unreviewed.
2612
2613         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2614         (_should_file_trigger_build):
2615
2616 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2617
2618         commit-queue: fails to replace OO-PS! with reviewer name
2619         <http://webkit.org/b/137795>
2620
2621         Reviewed by Alexey Proskuryakov.
2622
2623         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2624         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2625         email addresses to unauthenticated page loads, so we must always
2626         authenticate before getting bug data so we get full email
2627         addresses.
2628
2629 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2630
2631         commit-queue: fails to close bugs after successfully landing patches
2632         <http://webkit.org/b/137794>
2633
2634         Reviewed by Alexey Proskuryakov.
2635
2636         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2637         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2638         tell Mechanize to use the second <textarea> on the page with
2639         name="comment".
2640
2641 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2642
2643         [Win] Update DRT to match Mac Logic
2644         https://bugs.webkit.org/show_bug.cgi?id=137787
2645
2646         Reviewed by Dean Jackson.
2647
2648         * DumpRenderTree/win/DumpRenderTree.cpp:
2649         (initialize): 0 -> nullptr
2650         (runTest): Initialize MSG structure before using.
2651         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2652         Also, cleanly shut down COM when exiting.
2653         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2654         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2655         header and add printf to match Mac.
2656         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2657         * DumpRenderTree/win/FrameLoadDelegate.h:
2658         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2659         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2660         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2661         (isLocalhost): Added.
2662         (hostIsUsedBySomeTestsToGenerateError): Added.
2663         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2664         of certain error and redirect host names.
2665         * DumpRenderTree/win/UIDelegate.cpp:
2666         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2667         anything should be output to the console. This modifies behavior to match the Mac.
2668         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2669         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2670         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2671         (UIDelegate::webViewAddMessageToConsole): Ditto.
2672         * WinLauncher/PageLoadTestClient.cpp:
2673         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2674         added last week.
2675
2676 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2677
2678         Unreviewed, rolling out r174754.
2679         https://bugs.webkit.org/show_bug.cgi?id=137789
2680
2681         Speculative fix for Windows test was ineffective. (Requested
2682         by rfong on #webkit).
2683
2684         Reverted changeset:
2685
2686         "[Windows] Add some more logging to debug Windows test
2687         issues."
2688         http://trac.webkit.org/changeset/174754
2689
2690 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2691
2692         Unreviewed, add myself to CoordinatedGraphics watchers.
2693
2694         * Scripts/webkitpy/common/config/watchlist:
2695
2696 2014-10-15  Roger Fong  <roger_fong@apple.com>
2697
2698         [Windows] Speculative Windows test fix.
2699
2700         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2701
2702 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2703
2704         import-w3c-test rewrites relative src paths in ref files incorrectly
2705         https://bugs.webkit.org/show_bug.cgi?id=137586
2706
2707         This patch fixes a bug in test_converter.py where src paths were getting 
2708         rewritten as ../../some-path instead of <script src="../../some-path>". 
2709         It also adds support for rewriting src paths in style  elements, which was 
2710         missing before and it adds tests for this case.
2711
2712         Reviewed by Bem Jones-Bey.
2713
2714         * Scripts/webkitpy/w3c/test_converter.py:
2715         (_W3CTestConverter.convert_attributes_if_needed):
2716         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2717         (test_convert_attributes_if_needed):
2718         (verify_reference_relative_paths):
2719
2720 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2721
2722         Add --json flag to test-webkitpy to emit JSON formatted test results
2723         to stdout
2724         https://bugs.webkit.org/show_bug.cgi?id=137353
2725
2726         Reviewed by Daniel Bates.
2727
2728         * Scripts/webkitpy/port/server_process_unittest.py:
2729         Adds the read method to MockFile to allow the stdout of test_webkitpy
2730         to be redirected without causing erroneous test failures.
2731         In particular,
2732         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2733         and
2734         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2735         because when redirecting to a file, the
2736         _wait_for_data_and_update_buffers_using_select method in 
2737         server_process.py will find that there is a read file descriptor in
2738         its call to select.select, which eventually leads to it calling read()
2739         on the MockFile object.
2740         (MockFile.read):
2741         * Scripts/webkitpy/test/main.py:
2742         Adds the _print_results_as_json method and the --json flag which
2743         determines whether _print_results_as_json will get called.
2744         (Tester._parse_args):
2745         (Tester._print_results_as_json):
2746         (Tester._print_results_as_json.result_dict_from_tuple):
2747         (Tester._run_tests):
2748
2749 2014-10-13  David Farler  <dfarler@apple.com>
2750
2751         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2752         https://bugs.webkit.org/show_bug.cgi?id=137662
2753
2754         Reviewed by Darin Adler.
2755
2756         The layout test harness can close LayoutTestRelay's subprocess
2757         stdout and stderr in the case of a timeout or if a run is
2758         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2759         finds that no one is listening to its stdout/stderr (broken
2760         pipe), then just exit(1), there is nothing to report.
2761
2762         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2763         (-[LTRelayController didReceiveStdoutData:]):
2764         Add @try/@catch for NSFileHandleOperationException.
2765         (-[LTRelayController didReceiveStderrData:]):
2766         Add @try/@catch for NSFileHandleOperationException.
2767
2768 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2769
2770         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2771         https://bugs.webkit.org/show_bug.cgi?id=137060
2772
2773         Reviewed by Philippe Normand.
2774
2775         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2776
2777         * MiniBrowser/gtk/BrowserWindow.c:
2778         (zoomInCallback):
2779         (zoomOutCallback):
2780         (defaultZoomCallback): Callback for default zoom keyboard support.
2781         (browser_window_init):
2782
2783 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2784
2785         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2786
2787         Reviewed by Alexey Proskuryakov.
2788         
2789         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2790         logging to stderr to get associated with the next test.
2791         
2792         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2793
2794         * DumpRenderTree/mac/DumpRenderTree.mm:
2795         (dumpTestResults):
2796         (runTest):
2797
2798 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2799
2800         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2801
2802         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2803
2804 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2805
2806         [cmake] Fix the make build after r174683
2807         https://bugs.webkit.org/show_bug.cgi?id=137703
2808
2809         Reviewed by Martin Robinson.
2810
2811         * Scripts/webkitdirs.pm:
2812         (buildCMakeGeneratedProject):
2813
2814 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2815
2816         Adding myself to the watchlist to CachedFont
2817
2818         Unreviewed.
2819
2820         * Scripts/webkitpy/common/config/watchlist:
2821
2822 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2823
2824         [EFL][GTK] Make it possible to get verbose output with ninja
2825         https://bugs.webkit.org/show_bug.cgi?id=137606
2826
2827         Reviewed by Csaba Osztrogonác.
2828
2829         * Scripts/webkitdirs.pm:
2830         (buildCMakeGeneratedProject):
2831
2832 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2833
2834         [EFL] Make it possible to use ninja for EFL build too
2835         https://bugs.webkit.org/show_bug.cgi?id=137605
2836
2837         Reviewed by Csaba Osztrogonác.
2838
2839         * Scripts/webkitdirs.pm:
2840         (generateBuildSystemFromCMakeProject):
2841         * efl/install-dependencies:
2842
2843 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2844
2845         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2846         https://bugs.webkit.org/show_bug.cgi?id=137486
2847
2848         Reviewed by Philippe Normand.
2849
2850         * MiniBrowser/gtk/BrowserWindow.c:
2851         (loadHomePage): Callback for home page load.
2852         (browser_window_init):
2853         * MiniBrowser/gtk/BrowserWindow.h:
2854         * MiniBrowser/gtk/main.c:
2855         (main):
2856
2857 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2858
2859         import-w3c-tests doesn't prefix property values
2860         https://bugs.webkit.org/show_bug.cgi?id=137600
2861
2862         Reviewed by Bem Jones-Bey.
2863
2864         Some property values are prefixed in WebKit. Modified the W3C import
2865         script in order to prefix property values and not only properties.
2866         The patch re-uses most of the already existent logic to prefix
2867         properties.
2868
2869         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2870         from CSSValueKeywords.in and adapt converter to modify both properties
2871         and property values.
2872         (convert_for_webkit):
2873         (_W3CTestConverter.__init__):
2874         (_W3CTestConverter.output):
2875         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2876         (_W3CTestConverter):
2877         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2878         (_W3CTestConverter.add_webkit_prefix_following_regex):
2879         (_W3CTestConverter.convert_reference_relpaths):
2880         (_W3CTestConverter.convert_style_data):
2881         (_W3CTestConverter.convert_attributes_if_needed):
2882         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2883         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2884         include checks for property values too.
2885         (W3CTestConverterTest.test_read_prefixed_property_list):
2886         (verify_no_conversion_happened):
2887         (verify_prefixed_properties):
2888         (verify_prefixed_property_values):
2889         (generate_test_content_properties_and_values):
2890         (generate_test_content):
2891         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2892         prefixed property values and inform about them.
2893         (TestImporter.import_tests):
2894         (TestImporter.write_import_log):
2895
2896 2014-10-13  Jer Noble  <jer.noble@apple.com>
2897
2898         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2899         https://bugs.webkit.org/show_bug.cgi?id=137533
2900
2901         Reviewed by Andy Estes.
2902
2903         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2904
2905         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2906         (TestWebKitAPI::isMSEEnabledCallback):
2907         (TestWebKitAPI::TEST):
2908
2909 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2910
2911         [Win] Implement a page load profiling tool
2912         https://bugs.webkit.org/show_bug.cgi?id=137673
2913
2914         Reviewed by Dean Jackson.
2915
2916         Add a tool to capture and summarize page load statistics.
2917
2918         * WinLauncher/Common.cpp:
2919         (parseCommandLine): Move from WinMain.cpp so that it can
2920         be shared with internal tools.
2921         * WinLauncher/PageLoadTestClient.cpp: Added.
2922         (PageLoadTestClient::PageLoadTestClient):
2923         (PageLoadTestClient::pageLoadStartedAtTime):
2924         (PageLoadTestClient::didStartProvisionalLoad):
2925         (PageLoadTestClient::didCommitLoad):
2926         (PageLoadTestClient::didFirstLayoutForMainFrame):
2927         (PageLoadTestClient::didHandleOnLoadEvents):
2928         (PageLoadTestClient::didFinishLoad):
2929         (PageLoadTestClient::didFailLoad):
2930         (PageLoadTestClient::didInitiateResourceLoad):
2931         (PageLoadTestClient::didEndResourceLoad):
2932         (PageLoadTestClient::pageLoadEndedAtTime):
2933         (PageLoadTestClient::endPageLoad):
2934         (PageLoadTestClient::clearPageLoadState):
2935         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2936         (PageLoadTestClient::maybeEndPageLoadSoon):
2937         (PageLoadTestClient::setPageURL):
2938         (PageLoadTestClient::dumpRunStatistics):
2939         * WinLauncher/PrintWebUIDelegate.cpp:
2940         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2941         nullptr URL properly.
2942         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2943         (ResourceLoadDelegate::QueryInterface):
2944         (ResourceLoadDelegate::AddRef):
2945         (ResourceLoadDelegate::Release):
2946         (ResourceLoadDelegate::identifierForInitialRequest):
2947         (ResourceLoadDelegate::willSendRequest):
2948         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2949         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2950         (ResourceLoadDelegate::didReceiveResponse):
2951         (ResourceLoadDelegate::didReceiveContentLength):
2952         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2953         (ResourceLoadDelegate::didFailLoadingWithError):
2954         (ResourceLoadDelegate::plugInFailedWithError):
2955         * WinLauncher/ResourceLoadDelegate.h: Added.
2956         (ResourceLoadDelegate::ResourceLoadDelegate):
2957         * WinLauncher/WinLauncher.cpp:
2958         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2959         page loading statistics.
2960         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2961         and set private load delegate state.
2962         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2963         that sets the view's resource load delegate.
2964         (WinLauncher::loadURL): If no URL is passed, load the test document.
2965         * WinLauncher/WinLauncher.h:
2966         (WinLauncher::pageLoadTestClient):
2967         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2968         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2969         * WinLauncher/WinLauncherWebHost.cpp:
2970         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2971         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2972         it could be used from other source files.
2973         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2974         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2975         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2976         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2977         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2978         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2979         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2980         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2981         * WinLauncher/WinLauncherWebHost.h:
2982         * WinLauncher/WinMain.cpp:
2983         (wWinMain): Create and use new delegates for gathering page load data.
2984         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2985
2986 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2987
2988         Improve the test image diffs page
2989         https://bugs.webkit.org/show_bug.cgi?id=137674
2990
2991         Reviewed by Alexey Proskuryakov.
2992         
2993         Don't treat the input file as a format string, otherwise we have to escape special
2994         characters. Just do a couple of replaces.
2995
2996         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2997         (TestResultWriter.write_image_diff_files):
2998
2999 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3000
3001         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
3002         https://bugs.webkit.org/show_bug.cgi?id=137659
3003
3004         Reviewed by Martin Robinson.
3005
3006         * Scripts/webkitpy/port/xvfbdriver.py:
3007         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
3008
3009 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
3010
3011         Add more detailed wait time information to EWS metrics
3012         https://bugs.webkit.org/show_bug.cgi?id=137649
3013
3014         Reviewed by Daniel Bates.
3015
3016         Added average and worst time (we used to only have median), and also a percentage
3017         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
3018
3019         There is always some wait due to the polling nature of the queues, which is well understood
3020         and doesn't need to be measured. What needs to be measured is whether there is enough
3021         bot machines to process patches as soon as they are submitted.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3024         (Analyzer.prototype._analyzeBubblePerformance):
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3026         (MetricsBubbleView.prototype._update):
3027
3028 2014-10-11  Jer Noble  <jer.noble@apple.com>
3029
3030         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3031         https://bugs.webkit.org/show_bug.cgi?id=137533
3032
3033         Reviewed by Darin Adler.
3034
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3037         (TestWebKitAPI::TEST):
3038         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
3039         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
3040
3041 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3042
3043         iOS DRT snapshots are limited to the page visible area
3044         https://bugs.webkit.org/show_bug.cgi?id=137650
3045
3046         Reviewed by Daniel Bates.
3047         
3048         LegacyTileCache drawing was limited to the window's visible area, found by
3049         crawling up the layer hierarchy to the root layer. This caused test snapshots to
3050         be missing non-composited content outside the iPhone visible area, which hinders
3051         testing.
3052         
3053         Fix by adding a test-only mode where the window visible area is the entire window.
3054         
3055         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3056         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
3057         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3058         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
3059         for the DRT window.
3060         
3061
3062 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Page not fully rendered in iOS DRT snapshots
3065         https://bugs.webkit.org/show_bug.cgi?id=137638
3066
3067         Reviewed by Tim Horton.
3068         
3069         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
3070         to ensure that the page has laid out and is rendered by the time we take
3071         the snapshot.
3072
3073         * DumpRenderTree/mac/DumpRenderTree.mm:
3074         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
3075         (-[DumpRenderTree _webThreadInvoked]): Moved.
3076         (-[DumpRenderTree _waitForWebThreadThenDump]):
3077         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
3078         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
3079         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
3080         relies on dispatch_async too, and the inner block won't complete until the outer block
3081         has completed.
3082         (dumpTestResults): Move the guts of dump() here.
3083         (runTest): Whitespace.
3084
3085 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
3086
3087         Adding svn:ignore so that .pyc files don't show up as new.
3088
3089         * Scripts/webkitpy/xcode: Added property svn:ignore.
3090
3091 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
3092
3093         [EFL] Introduce EWebKit_Extension
3094         https://bugs.webkit.org/show_bug.cgi?id=134921
3095
3096         Reviewed by Gyuyoung Kim.
3097
3098         * MiniBrowser/efl/main.c: Added x option to test extension path.
3099         (window_create):
3100         (elm_main):
3101         * Scripts/webkitpy/common/config/watchlist:
3102         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3103         * Scripts/webkitpy/style/checker.py:
3104         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3105
3106 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
3107
3108         After r174628 we send the test process a SIGTERM before the SIGKILL.
3109
3110         * Scripts/webkitpy/common/system/executive_unittest.py:
3111         (ExecutiveTest.serial_test_kill_process):
3112
3113 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
3114
3115         [EFL] Enable WebP support.
3116         https://bugs.webkit.org/show_bug.cgi?id=136156
3117
3118         Reviewed by Gyuyoung Kim.
3119
3120         Include libwebp-dev package to support WebP for WK2 Efl.
3121
3122         * efl/install-dependencies:
3123
3124 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3125
3126         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
3127         https://bugs.webkit.org/show_bug.cgi?id=137485
3128
3129         Reviewed by Sergio Villar Senin.
3130
3131         Update GMainLoopSource tests. Most of the tests are now run twice,
3132         first with a GMainLoopSource and then with a
3133         GThreadSafeMainLoopSource, since both should have the same
3134         behaviour. The threading test uses GThreadSafeMainLoopSource and
3135         the delete on destroy test uses GMainLoopSource. The tests
3136         themselves haven't changed, since there's no change in behaviour.
3137
3138         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3139         (TestWebKitAPI::GMainLoopSourceTest::source):
3140         (TestWebKitAPI::basicRescheduling):
3141         (TestWebKitAPI::TEST):
3142         (TestWebKitAPI::reentrantRescheduling):
3143         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3144         (TestWebKitAPI::basicDestroyCallbacks):
3145         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3146         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3147
3148 2014-10-10  Dana Burkart  <dburkart@apple.com>
3149
3150         Fix fat-fingered function name in git-add-reviewer.
3151
3152         Unreviewed.
3153
3154         * Scripts/git-add-reviewer:
3155         (getConfigValue):
3156
3157 2014-10-10  David Farler  <dfarler@apple.com>
3158
3159         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
3160         https://bugs.webkit.org/show_bug.cgi?id=137528
3161
3162         Reviewed by Simon Fraser.
3163
3164         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
3165         and SIGKILL the paired simulator app before exiting cleanly.
3166
3167         webkitpy only uses SIGKILL to kill processes which you cannot
3168         catch. Send SIGTERM to the process and give it chance to do
3169         its thing before sending SIGKILL. Sending a SIGKILL to an already
3170         dead PID is safe.
3171
3172         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3173         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3174         (-[LTRelayController finish]):
3175         * LayoutTestRelay/LayoutTestRelay/main.m:
3176         (receivedSignal):
3177         (main):
3178
3179 2014-10-10  David Farler  <dfarler@apple.com>
3180
3181         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3182         https://bugs.webkit.org/show_bug.cgi?id=137527
3183
3184         Reviewed by Simon Fraser.
3185
3186         NSFileHandle doesn't notify of EOF in its readability handler.
3187         Use a dispatch_source_t and an event handler that is called when reading is possible.
3188         In the handler block, do a run-of-the-mill read(2) from standard input and
3189         detect EOF in the usual way by checking that zero bytes were read.
3190
3191         Once an EOF is received, the FIFOs are disconnected, the simulator app
3192         is killed, and the relay exits with status 0.
3193
3194         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3195         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3196         (-[LTRelayController didDisconnect]):
3197         (-[LTRelayController didConnect]):
3198         (-[LTRelayController launchApp]):
3199         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3200         confusion with this new dispatch source, called "standardInputDispatchSource".
3201         (-[LTRelayController finish]): Added.
3202         (-[LTRelayController readFileHandle:]): Deleted.
3203
3204 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3205
3206         [EFL] Crash on facebook.com
3207         https://bugs.webkit.org/show_bug.cgi?id=137562
3208
3209         Reviewed by Chris Dumez.
3210
3211         Crash occurs on the facebook.com when the webview is resized
3212         after the <select> item is clicked but no item is chosen.
3213         This crash is just caused by the reference of invalidated variable.
3214         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3215         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3216         on MiniBrowser is called.
3217         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3218
3219         * MiniBrowser/efl/main.c:
3220         (on_popup_menu_hide):
3221
3222 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3223
3224         A small wording change for clarity.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3227         (MetricsBubbleView.prototype._update):
3228
3229 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3230
3231         Dashboard metrics page should have EWS statistics
3232         https://bugs.webkit.org/show_bug.cgi?id=137626
3233
3234         Reviewed by Ryosuke Niwa.
3235
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3237         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3238
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3240         (BubbleQueueServer): Re-ordered queues to match bubble order.
3241         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3242         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3245         Added analysis for bubble queues.
3246
3247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3250         (buildBubbleQueuesTable): Build the UI.
3251
3252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3253         Added JS sources to load.
3254
3255         * QueueStatusServer/app.yaml: To update app version.
3256
3257         * QueueStatusServer/handlers/processingtimesjson.py: Added.
3258
3259         * QueueStatusServer/main.py: Added a handler for processing-times-json.
3260
3261 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3262
3263         REGRESSION: Commit queue doesn't process rollouts
3264         https://bugs.webkit.org/show_bug.cgi?id=137623
3265
3266         Reviewed by Tim Horton.
3267
3268         * QueueStatusServer/app.yaml:
3269         * QueueStatusServer/handlers/updateworkitems.py:
3270         (UpdateWorkItems._work_items_from_request):
3271
3272 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
3273
3274         Fix syntax error after r174601.
3275
3276         * Scripts/run-javascriptcore-tests:
3277
3278 2014-10-10  Michael Saboff  <msaboff@apple.com>
3279
3280         Add ability to select tarfile name in run-jsc-stress-tests
3281         https://bugs.webkit.org/show_bug.cgi?id=137614
3282
3283         Reviewed by Mark Hahnenberg.
3284
3285         Added optional file name argument to the --tarball option.  
3286
3287         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
3288         extra test given after the options wont be used for the optional tarball file name.
3289         * Scripts/run-jsc-stress-tests:
3290
3291 2014-10-10  Chris Dumez  <cdumez@apple.com>
3292
3293         Unreviewed, update my information in contributors.json
3294
3295         Use my preferred first name and update my expertise areas.
3296
3297         * Scripts/webkitpy/common/config/contributors.json:
3298
3299 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
3300
3301         Fix perl scripts to run with env on Linux
3302         https://bugs.webkit.org/show_bug.cgi?id=137601
3303
3304         Reviewed by Csaba Osztrogonác.
3305
3306         Use of arguments in #! is nonstandard and does not behave the same on
3307         different systems. Linux would look for an executable named "perl -w" 
3308         "use warnings;" does the same things in a more portable way.
3309
3310         * Scripts/commit-log-editor:
3311         * Scripts/num-cpus:
3312         * Scripts/prepare-ChangeLog:
3313         * Scripts/run-launcher:
3314         * Scripts/svn-create-patch:
3315
3316 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3317
3318         [jhbuild] We should be able to disable wiping on configuration change
3319         https://bugs.webkit.org/show_bug.cgi?id=137446
3320
3321         Reviewed by Csaba Osztrogonác.
3322
3323         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
3324         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
3325         or passing --no-wipe-on-change command line option.
3326
3327         * Scripts/update-webkit-libs-jhbuild:
3328
3329 2014-10-09  Andy Estes  <aestes@apple.com>
3330
3331         Teach webkitpy about OS X Yosemite
3332         https://bugs.webkit.org/show_bug.cgi?id=137585
3333
3334         Reviewed by Simon Fraser.
3335
3336         * Scripts/webkitpy/common/system/platforminfo.py:
3337         (PlatformInfo._determine_mac_version):
3338         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3339         (TestPlatformInfo.test_os_version):
3340         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3341         (TestExpectationParser):
3342         * Scripts/webkitpy/port/builders.py:
3343         * Scripts/webkitpy/port/mac.py:
3344         (MacPort):
3345         * Scripts/webkitpy/port/mac_unittest.py:
3346         (test_versions):
3347         (test_baseline_search_path):
3348         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3349         (TestRebaselineTest.test_baseline_directory):
3350         (TestRebaselineExpectations.test_rebaseline_expectations):
3351
3352 2014-10-09  Dana Burkart  <dburkart@apple.com>
3353
3354         Add Mac OS Yosemite dashboard support.
3355
3356         Rubber-stamped by Lucas Forschler.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3363
3364 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3365
3366         Add Babak to contributors.json and add historical email addresses for some contributors
3367         https://bugs.webkit.org/show_bug.cgi?id=137546
3368
3369         Reviewed by Christophe Dumez.
3370
3371         contributors.json is used to analyze historical commit data and change logs.
3372
3373         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3374
3375         * Scripts/webkitpy/common/config/contributors.json:
3376
3377 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3378
3379         Add Mac OS Yosemite webkit build infrastructure.
3380         
3381         This patch adds 15 bots to our build.webkit.org configuration.
3382         We are matching the current Mavericks machines 1:1.
3383         
3384         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3385         
3386         Reviewed by Matt Hanson.
3387
3388         * BuildSlaveSupport/build.webkit.org-config/config.json:
3389
3390 2014-10-09  Dana Burkart  <dburkart@apple.com>
3391
3392         Don't use backticks when running commands, as we run into sh-related
3393         interpolation issues. Also, fix our usage of system() to properly
3394         retrieve the status code.
3395         https://bugs.webkit.org/show_bug.cgi?id=137541
3396
3397         Reviewed by Darin Adler.
3398
3399         * Scripts/git-add-reviewer:
3400         (interactive):
3401         (nonInteractive):
3402         (requireCleanWorkTree):
3403         (cherryPick):
3404         (commit):
3405         (addReviewerToFile):
3406         (head):
3407         (isAncestor):
3408         (toCommit):
3409         (changeLogsForCommit):
3410         (resetToCommit):
3411         (getConfigValue):
3412         (runCommandWithOutput):
3413
3414 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3415
3416         Add a WebKit1 preference for selection services
3417         https://bugs.webkit.org/show_bug.cgi?id=137498
3418         <rdar://problem/18572699>
3419
3420         Reviewed by Simon Fraser.
3421
3422         * MiniBrowser/mac/WK1BrowserWindowController.m:
3423         (-[WK1BrowserWindowController awakeFromNib]):
3424         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3425
3426 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3427
3428         Get the patch scripts running on Haiku
3429         https://bugs.webkit.org/show_bug.cgi?id=137559
3430
3431         Reviewed by Benjamin Poulain.
3432
3433         Use /usr/bin/env instead of hardcoding path to perl.
3434         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3435         failure.
3436
3437         * Scripts/commit-log-editor:
3438         * Scripts/num-cpus:
3439         * Scripts/prepare-ChangeLog:
3440         * Scripts/run-launcher:
3441         * Scripts/svn-create-patch:
3442         * Scripts/webkitpy/common/system/platforminfo.py:
3443         (PlatformInfo._determine_os_name):
3444
3445 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3446
3447         StyleQueue should throw a PatchIsNotValid exception to achieve
3448         consistency with CommitQueue and EWS
3449         https://bugs.webkit.org/show_bug.cgi?id=137500
3450
3451         Reviewed by Alexey Proskuryakov.
3452
3453         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3454         Adds a call to validate() in run().
3455         (StyleQueueTask.run):
3456         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3457         Adds a return False in the patch is not valid exception statement.
3458         (AbstractEarlyWarningSystem.review_patch):
3459         * Scripts/webkitpy/tool/commands/queues.py:
3460         Adds a return False in the patch is not valid exception statement in
3461         commit queue, and adds an except statement to catch PatchIsNotValid
3462         exceptions in style queue.
3463         (CommitQueue.process_work_item):
3464         (StyleQueue.review_patch):
3465
3466 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3467
3468         Race condition with WebKitWebView:is-loading after starting page load
3469         https://bugs.webkit.org/show_bug.cgi?id=136692
3470
3471         Reviewed by Gustavo Noronha Silva.
3472
3473         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3474         (loadChangedCallback): Only check is-loading is false when load
3475         has finished if the load didn't fail due to a cancellation.
3476         (loadFailedCallback): Only check is-loading is false if the load
3477         didn't fail due to a cancellation.
3478         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3479         (WebViewTest::loadURI): Check is-loading is true and active URI is
3480         the requested one rigth after requesting the load.
3481         (WebViewTest::loadHtml): Ditto.
3482         (WebViewTest::loadPlainText): Ditto.
3483         (WebViewTest::loadBytes): Ditto.
3484         (WebViewTest::loadRequest): Ditto.
3485         (WebViewTest::loadAlternateHTML): Ditto.
3486         (WebViewTest::goBack): Ditto.
3487         (WebViewTest::goForward): Ditto.
3488         (WebViewTest::goToBackForwardListItem): Ditto.
3489
3490 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3491
3492         [Win] Resolve various static analyzer warnings in Tools.
3493         https://bugs.webkit.org/show_bug.cgi?id=137534
3494
3495         Reviewed by Dean Jackson.
3496
3497         * DumpRenderTree/cg/ImageDiffCG.cpp:
3498         (main): User proper printf specifiers.
3499         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3500         (AccessibilityUIElement::childrenCount): Handle possibility that
3501         gcc_accChildCount returns with an error.
3502         (accessibilityState): Ditto for gcc_accState.
3503         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3504         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3505         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3506         be treated as such.
3507         * DumpRenderTree/win/DumpRenderTree.cpp:
3508         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3509         by comparing an unsigned value as being greater-than zero.
3510         * DumpRenderTree/win/EditingDelegate.cpp:
3511         (dump): Pass proper character pointer type to printf.
3512         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3513         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3514         (EditingDelegate::shouldInsertNode): Ditto.
3515         (EditingDelegate::shouldInsertText): Ditto.
3516         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3517         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3518         (EditingDelegate::shouldApplyStyle): Ditto.
3519         * DumpRenderTree/win/EventSender.cpp:
3520         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3521         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3522         system headers.
3523         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3524         from CreateDIBSection.
3525         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3526         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3527         older versions of MSVC we no longer support.
3528         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3529         for 64-bit builds.
3530         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3531         * TestWebKitAPI/TestsController.h: Ditto.
3532         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3533         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3534         performing bitwise | before the comparison is done.
3535
3536 2014-10-08  Ada Chan  <adachan@apple.com>
3537
3538         Add a test for WKPageIsPlayingAudio().
3539         https://bugs.webkit.org/show_bug.cgi?id=137048
3540
3541         Reviewed by Darin Adler.
3542
3543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3544         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3545         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3546         (TestWebKitAPI::nullJavaScriptCallback):
3547         (TestWebKitAPI::didFinishLoadForFrame):
3548         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3549         (TestWebKitAPI::setUpClients):
3550         (TestWebKitAPI::TEST):
3551         This test loads a page with a video in it. When the page is loaded, we first check that
3552         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3553         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3554         now returns true for the page.
3555         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3556         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3557         This is a video copied from LayoutTests/media/content.
3558
3559 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3560
3561         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3562         https://bugs.webkit.org/show_bug.cgi?id=137516
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         * Scripts/webkitpy/thirdparty/__init__.py:
3567         (AutoinstallImportHook._install_irc):
3568
3569 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3570
3571         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3572         https://bugs.webkit.org/show_bug.cgi?id=137520
3573
3574         Reviewed by Philippe Normand.
3575
3576         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3577         For other distributions, we are already installing libjpeg-turbo.
3578         So, do the same for Debian and derivatives.
3579
3580         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3581
3582 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3583
3584         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3585         https://bugs.webkit.org/show_bug.cgi?id=137519
3586
3587         Reviewed by Csaba Osztrogonác.
3588
3589         It was removed by <http://trac.webkit.org/changeset/174266>,
3590         because the comment stated it is a workaround for buggy python
3591         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3592         is still valid with python 2.7 shipped on the latest Ubuntu
3593         (12.04 and 14.04) and OS X 10.9.
3594
3595         * Scripts/webkitpy/common/system/autoinstall.py:
3596         (AutoInstaller):
3597         (AutoInstaller._extract_all):
3598         (AutoInstaller._unzip):
3599
3600 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3601
3602         Unreviewed, rolling out r174335.
3603         https://bugs.webkit.org/show_bug.cgi?id=137515
3604
3605         It broke EFL layout test totally (Requested by gyuyoung on
3606         #webkit).
3607
3608         Reverted changeset:
3609
3610         "[EFL] Introduce EWebKit_Extension"
3611         https://bugs.webkit.org/show_bug.cgi?id=134921
3612         http://trac.webkit.org/changeset/174335
3613
3614 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3615
3616         [GTK] Make forwarding headers generation depend on source code
3617         https://bugs.webkit.org/show_bug.cgi?id=137394
3618
3619         Reviewed by Philippe Normand.
3620
3621         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3622         * TestWebKitAPI/PlatformGTK.cmake: Only run
3623         generate-forwarding-headers.pl when source code changes.
3624         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3625
3626 2014-10-07  Tanay C  <tanay.c@samsung.com>
3627
3628         Remove build warnings in Hashmap API tests
3629         https://bugs.webkit.org/show_bug.cgi?id=137484
3630
3631         Reviewed by Darin Adler.
3632