Build fix. Use internal pcre on glib, make gnutls a dependency of
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2
3         Build fix. Use internal pcre on glib, make gnutls a dependency of
4         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
5         in non-interactive mode.
6
7         * Scripts/update-webkitgtk-libs:
8         * gtk/jhbuild.modules:
9         * gtk/run-with-jhbuild:
10
11 2011-12-02  Adam Roben  <aroben@apple.com>
12
13         Fix for Python 2.6
14
15         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
17         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
18         searching for "Tests that timed out:" etc. This makes our check less strict, but it
19         shouldn't matter given the kinds of content we parse.
20
21 2011-12-02  Adam Roben  <aroben@apple.com>
22
23         Fix names of failed/timed out tests in run-api-tests output
24
25         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
26         out tests
27
28         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
29
30         Reviewed by Simon Fraser.
31
32         * Scripts/run-api-tests:
33         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
34         of this function.
35
36 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
37
38         [GTK] generate-gtkdoc should respect build type
39         https://bugs.webkit.org/show_bug.cgi?id=73296
40
41         Reviewed by Philippe Normand.
42
43         * Scripts/webkitdirs.pm:
44         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
45         * gtk/common.py: If --build is passed give preference to the Debug build directory.
46
47 2011-12-02  Tony Chang  <tony@chromium.org>
48
49         [nrwt] fix wdiff output
50         https://bugs.webkit.org/show_bug.cgi?id=73604
51
52         Reviewed by Adam Barth.
53
54         * Scripts/webkitpy/layout_tests/port/base.py:
55         (Port.wdiff_text):
56         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
57         (PortTest.test_wdiff_text):
58
59 2011-12-02  Adam Roben  <aroben@apple.com>
60
61         Teach build.webkit.org to display how many unit tests failed or timed out
62
63         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
64         build.webkit.org
65
66         We now display something like "5 unit tests failed or timed out". Eventually we might want
67         to split out how many failure vs. timeouts there were.
68
69         Reviewed by Darin Adler.
70
71         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
72         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
73         classes that may want to subclass it.
74         (RunUnitTests): Changed to inherit from TestWithFailureCount.
75         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
76         timed out:" and "Tests that failed:" lines, if present.
77
78         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
79         (StubStdio):
80         (StubRemoteCommand):
81         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
82
83         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
84         the test run correctly.
85
86         (RunUnitTestsTest.test_no_failures_or_timeouts):
87         (RunUnitTestsTest.test_one_failure):
88         (RunUnitTestsTest.test_multiple_failures):
89         (RunUnitTestsTest.test_one_timeout):
90         (RunUnitTestsTest.test_multiple_timeouts):
91         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
92         Test various cases.
93
94 2011-12-02  Adam Roben  <aroben@apple.com>
95
96         Teach prepare-ChangeLog to treat master.cfg as a Python file
97
98         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
99         in buildbot's master.cfg
100
101         Reviewed by Darin Adler.
102
103         * Scripts/prepare-ChangeLog:
104         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
105         master.cfg.
106
107 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
108
109         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
110         https://bugs.webkit.org/show_bug.cgi?id=73669
111
112         Reviewed by Gustavo Noronha Silva.
113
114         Add a wrapper script that knows how to install jhbuild and also to wrap commands
115         in the jhbuild shell.
116
117         * Scripts/webkitdirs.pm:
118         (runAutogenForAutotoolsProject): Use the new wrapper script.
119         (mustReRunAutogen): Ditto.
120         (buildAutotoolsProject): Ditto.
121         * Scripts/webkitpy/layout_tests/port/gtk.py:
122         (GtkDriver.cmd_line): Ditto.
123         * gtk/run-with-jhbuild: Added.
124
125 2011-12-01  Adam Roben  <aroben@apple.com>
126
127         Teach check-webkit-style how to check the syntax of JSON files
128
129         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
130
131         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
132         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
133         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
134         been removed, since its output differs by platform.
135
136         Reviewed by Darin Adler.
137
138         * Scripts/webkitpy/style/checker.py:
139         (_all_categories): Added JSONChecker's categories to the set of all categories.
140         (FileType): Added a JSON type. Incremented other types.
141         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
142         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
143
144         * Scripts/webkitpy/style/checker_unittest.py:
145         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
146         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
147
148         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
149         which would have matched our other checkers, because I couldn't figure out how to call
150         "json.loads" without hitting namespace conflicts.)
151         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
152         just the modified lines from a patch.
153         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
154         exception.
155         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
156         try to extract a line number.
157
158         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
159         (MockErrorHandler.__init__):
160         (MockErrorHandler.turn_off_line_filtering):
161         (MockErrorHandler.__call__):
162         Helper class. Copied from xml_unittest.py.
163
164         (JSONCheckerTest.test_line_number_from_json_exception): Test the
165         line_number_from_json_exception helper method.
166
167         (JSONCheckerTest.assert_no_error):
168         (JSONCheckerTest.assert_error):
169         Helper methods to assert that we did or didn't get an error.
170
171         (JSONCheckerTest.mock_handle_style_error): Helper method.
172
173         (JSONCheckerTest.test_conflict_marker):
174         (JSONCheckerTest.test_single_quote):
175         (JSONCheckerTest.test_init):
176         (JSONCheckerTest.test_no_error):
177         Test various cases.
178
179 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
180
181         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
182         https://bugs.webkit.org/show_bug.cgi?id=73664
183
184         Reviewed by Martin Robinson.
185
186         This patch adds our HTTP library and its main dependencies; this
187         should not affect layout or rendering.
188
189         * gtk/jhbuild.modules:
190
191 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
192
193         [GTK] Also run DumpRenderTree under jhbuild
194         https://bugs.webkit.org/show_bug.cgi?id=73646
195
196         Reviewed by Martin Robinson.
197
198         * Scripts/webkitpy/layout_tests/port/gtk.py:
199         (GtkDriver.cmd_line):
200
201 2011-12-02  Hajime Morrita  <morrita@chromium.org>
202
203         Unreviewed, rolling out r101751 and r101775.
204         http://trac.webkit.org/changeset/101751
205         http://trac.webkit.org/changeset/101775
206         https://bugs.webkit.org/show_bug.cgi?id=73191
207
208         breaks Windows build
209
210         * DumpRenderTree/chromium/config.h:
211         * DumpRenderTree/config.h:
212         * TestWebKitAPI/config.h:
213         * WebKitTestRunner/config.h:
214
215 2011-12-02  Kentaro Hara  <haraken@chromium.org>
216
217         Move run-bindings-tests implementation to webkitpy/bindings/main.py
218         https://bugs.webkit.org/show_bug.cgi?id=73619
219
220         Reviewed by Adam Barth.
221
222         As run-bindings-tests has been growing, this patch just moves its implementation
223         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
224
225         No change in behavior.
226
227         * Scripts/run-bindings-tests:
228         (main):
229         * Scripts/webkitpy/bindings/__init__.py: Added.
230         * Scripts/webkitpy/bindings/main.py: Added.
231         (BindingsTests.__init__):
232         (BindingsTests.generate_from_idl):
233         (BindingsTests.generate_supplemental_dependency):
234         (BindingsTests.detect_changes):
235         (BindingsTests.run_tests):
236
237 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
238
239         Tools/Scripts: eliminate find_test_files from Port class.
240         https://bugs.webkit.org/show_bug.cgi?id=73553
241
242         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
243         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
244         Also I'll move _is_test_file() and related functions close to Port.tests().
245
246         Reviewed by Dirk Pranke.
247
248         * Scripts/webkitpy/layout_tests/port/base.py:
249         (Port.tests):
250         (Port.is_reference_html_file):
251         (Port._has_supported_extension):
252         (Port._is_test_file):
253         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
254         (PortTest.test_find_no_paths_specified):
255         (PortTest.test_find_one_test):
256         (PortTest.test_find_glob):
257         (PortTest.test_find_with_skipped_directories):
258         (PortTest.test_find_with_skipped_directories_2):
259         (PortTest.test_is_test_file):
260         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
261         (_default_tests_paths):
262         (ChromiumGpuLinuxPort.tests):
263         (ChromiumGpuCgMacPort.tests):
264         (ChromiumGpuMacPort.tests):
265         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
266         (ChromiumGpuTest.test_default_tests_paths.test_paths):
267         (ChromiumGpuTest.test_default_tests_paths):
268         (ChromiumGpuTest.test_test_files.test_paths):
269         (ChromiumGpuTest):
270         (ChromiumGpuTest.test_test_files):
271         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
272         (get_tests_run.RecordingTestDriver.run_test):
273         * Scripts/webkitpy/tool/commands/rebaseline.py:
274         (OptimizeBaselines._optimize_baseline):
275         (OptimizeBaselines.execute):
276         (AnalyzeBaselines._analyze_baseline):
277         (AnalyzeBaselines.execute):
278
279 2011-12-01  Hajime Morrita  <morrita@chromium.org>
280
281         JS_INLINE and WTF_INLINE should be visible from WebCore
282         https://bugs.webkit.org/show_bug.cgi?id=73191
283
284         Reviewed by Kevin Ollivier.
285
286         Removed macro definitions which is now provided by Platform.h
287
288         * DumpRenderTree/chromium/config.h:
289         * DumpRenderTree/config.h:
290         * TestWebKitAPI/config.h:
291         * WebKitTestRunner/config.h:
292
293 2011-12-01  Hayato Ito  <hayato@chromium.org>
294
295         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
296         https://bugs.webkit.org/show_bug.cgi?id=73406
297
298         Reviewed by Ryosuke Niwa.
299
300         WebKitPort's image_diff uses tolerance='0.1' in default.
301         When reftests fail, we should use tolerace=0 when diff-ing images.
302
303         Since ImageDiff on chromium port doesn't use tolerance value as of now,
304         this change doesn't affect chromium port's behavior.
305
306         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
307         (write_test_result):
308         * Scripts/webkitpy/layout_tests/port/base.py:
309         (Port.diff_image):
310         * Scripts/webkitpy/layout_tests/port/chromium.py:
311         (ChromiumPort.diff_image):
312         * Scripts/webkitpy/layout_tests/port/test.py:
313         (TestPort.diff_image):
314         * Scripts/webkitpy/layout_tests/port/webkit.py:
315         (WebKitPort.diff_image):
316         (WebKitPort._start_image_diff_process):
317         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
318         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
319
320 2011-12-01  Adam Klein  <adamk@chromium.org>
321
322         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
323         https://bugs.webkit.org/show_bug.cgi?id=73599
324
325         Reviewed by Ojan Vafai.
326
327         * TestResultServer/static-dashboards/builders.js:
328         * TestResultServer/static-dashboards/dashboard_base.js:
329         ():
330         (htmlForTestTypeSwitcher):
331         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
332         (testHtmlForTestTypeSwitcherGroup):
333
334 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
335
336         Parse reftest.list and extract types of ref tests
337         https://bugs.webkit.org/show_bug.cgi?id=66837
338
339         Reviewed by Dirk Pranke.
340
341         Add support for reftest.list to base port.
342
343         * Scripts/webkitpy/common/find_files.py:
344         (find):
345         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
346         (SingleTestRunner.__init__):
347         * Scripts/webkitpy/layout_tests/port/base.py:
348         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
349         to a dictionary of {test path: ("==" or "!=", reference file path)}
350         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
351         (Port._reference_file_for): Added; obtains the reference file name given a test name.
352         (Port.is_reftest): Added; Calls _reference_file_for.
353         (Port.reftest_expected_filename): Calls _reference_file_for.
354         (Port.reftest_expected_mismatch_filename): Ditto.
355         (Port.find_test_files):
356         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
357         -expected, -expected-mismach, -ref, or -notref as a reference file.
358         (_is_test_file):
359         (_parse_reftest_list): Added.
360         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
361         (PortTest.test_is_test_file):
362         (PortTest.test_parse_reftest_list):
363         * Scripts/webkitpy/layout_tests/port/dryrun.py:
364         (DryrunDriver.run_test):
365         * Scripts/webkitpy/layout_tests/port/test.py:
366         (unit_test_filesystem.add_test_file):
367         (unit_test_filesystem.add_file):
368         (unit_test_filesystem):
369         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
370         (get_tests_run.RecordingTestDriver.run_test):
371         (MainTest.test_unexpected_failures):
372         (MainTest.test_missing_and_unexpected_results):
373         (EndToEndTest.test_end_to_end):
374         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
375         (Rebaseliner._compile_rebaselining_tests):
376
377 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
378
379         Unreviewed, rolling out r101711.
380         http://trac.webkit.org/changeset/101711
381         https://bugs.webkit.org/show_bug.cgi?id=73605
382
383         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
384
385         * Scripts/webkitpy/style/checker.py:
386         (_all_categories):
387         (FileType):
388         (CheckerDispatcher._file_type):
389         (CheckerDispatcher._create_checker):
390         * Scripts/webkitpy/style/checker_unittest.py:
391         (CheckerDispatcherDispatchTest.assert_checker_cpp):
392         (CheckerDispatcherDispatchTest.test_cpp_paths):
393         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
394         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
395
396 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
397
398         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
399
400         * Scripts/webkitpy/common/config/watchlist:
401
402 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
403
404         [GTK] Read fonts from the jhbuild root
405         https://bugs.webkit.org/show_bug.cgi?id=73487
406
407         Reviewed by Gustavo Noronha Silva.
408
409         Read fonts from the jhbuild root instead of from the system. This will ensure
410         that all testers use the same fonts instead of leaving this up to luck.
411
412         * DumpRenderTree/gtk/DumpRenderTree.cpp:
413         (initializeFonts): Load fonts from jhbuild root.
414         * Scripts/webkitpy/layout_tests/port/gtk.py:
415         (GtkPort.setup_environ_for_server): Pass an environment variable containing
416         the path to the jhbuild root.
417         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
418         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
419
420 2011-12-01  Adam Roben  <aroben@apple.com>
421
422         Teach check-webkit-style how to check the syntax of JSON files
423
424         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
425
426         Reviewed by Darin Adler.
427
428         * Scripts/webkitpy/style/checker.py:
429         (_all_categories): Added JSONChecker's categories to the set of all categories.
430         (FileType): Added a JSON type. Incremented other types.
431         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
432         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
433
434         * Scripts/webkitpy/style/checker_unittest.py:
435         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
436         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
437
438         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
439         which would have matched our other checkers, because I couldn't figure out how to call
440         "json.loads" without hitting namespace conflicts.)
441         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
442         just the modified lines from a patch.
443         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
444         exception.
445         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
446         try to extract a line number.
447
448         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
449         (MockErrorHandler.__init__):
450         (MockErrorHandler.turn_off_line_filtering):
451         (MockErrorHandler.__call__):
452         Helper class. Copied from xml_unittest.py.
453
454         (JSONCheckerTest.test_line_number_from_json_exception): Test the
455         line_number_from_json_exception helper method.
456
457         (JSONCheckerTest.assert_no_error):
458         (JSONCheckerTest.assert_error):
459         Helper methods to assert that we did or didn't get an error.
460
461         (JSONCheckerTest.mock_handle_style_error): Helper method.
462
463         (JSONCheckerTest.test_conflict_marker):
464         (JSONCheckerTest.test_single_quote):
465         (JSONCheckerTest.test_init):
466         (JSONCheckerTest.test_missing_closing_brace):
467         (JSONCheckerTest.test_no_error):
468         Test various cases.
469
470 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
471
472         [GTK] Add a helper function to find the current executable's path
473         https://bugs.webkit.org/show_bug.cgi?id=73473
474
475         Reviewed by Gustavo Noronha Silva.
476
477         Update MiniBrowser to not pass the binary directory as an environment variable.
478         This means that you can move the binaries around without it breaking.
479
480         * MiniBrowser/gtk/main.c:
481         (main): No longer set the environment variable.
482         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
483         * WebKitTestRunner/gtk/main.cpp:  Ditto.
484
485 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
486
487         Unreviewed. Fix bad file =(.
488
489         * gtk/jhbuild.modules:
490         * Scripts/webkitdirs.pm:
491         (runAutogenForAutotoolsProject):
492
493 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
494
495         [GTK] Add freetype to our jhbuild setup
496         https://bugs.webkit.org/show_bug.cgi?id=73488
497
498         Reviewed by Martin Robinson.
499
500         This adds the first library to our jhbuild setup, and makes sure
501         build-webkit calls autogen.sh and make with jhbuild, so that the
502         environment is properly set.
503
504         * Scripts/webkitdirs.pm:
505         (saveSum):
506         (hashFile):
507         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
508         call autogen under jhbuild run;
509         (mustRunAutogen): generalized the arguments change checking to also force
510         running autogen when jhbuild files change;
511         (buildAutotoolsProject): run make under jhbuild;
512         * gtk/jhbuild.modules: add freetype.
513
514 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
515
516         Fix WebKitTestRunner compile warnings with XCode 3.2
517         https://bugs.webkit.org/show_bug.cgi?id=73378
518
519         Reviewed by Chris Fleizach.
520
521         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
522         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
523         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
524         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
525         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
526         (WTR::AccessibilityUIElement::AccessibilityUIElement):
527         (WTR::AccessibilityUIElement::verticalScrollbar):
528
529 2011-12-01  Adam Roben  <aroben@apple.com>
530
531         Allow committers to use their Trac credentials to force builds on the buildbots
532
533         Fixes <http://webkit.org/b/73353>
534
535         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
536         three files to do its job: a config file that contains a list of WebKit committer usernames,
537         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
538         those two files.
539
540         Reviewed by Darin Adler.
541
542         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
543         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
544         whether credentials were valid or not.
545         (CommitterAuth.__init__): Just store the path to auth.json.
546         (CommitterAuth.auth_json): Load, parse, and return auth.json.
547         (CommitterAuth.auth_json_filename): Return the path to auth.json.
548         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
549         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
550         checking those conditions.
551         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
552         false otherwise or if an exception was thrown.
553         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
554         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
555
556         (CommitterAuth.open_auth_json_file):
557         (CommitterAuth.open_trac_credentials_file):
558         (CommitterAuth.open_webkit_committers_file):
559         Open the specified file. These are mostly useful for testing purposes.
560
561         (CommitterAuth.trac_credentials_filename):
562         (CommitterAuth.webkit_committers_filename):
563         Return the path to the specified file by retrieving it from auth.json.
564
565         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
566         of WebKit committers from it.
567
568         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
569         (CMStringIO.__enter__):
570         (CMStringIO.__exit__):
571         Helper class that makes it possible to use StringIO with the "with" statement.
572
573         (open_override): Helper context manager for overriding the global "open" function
574         temporarily.
575
576         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
577         tests.
578         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
579         "open" to test that the expected path was opened.
580         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
581         successfully.
582         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
583         somehow have no Trac account can't authenticate.
584
585         (CommitterAuthTest.test_fail_to_open_auth_json_file):
586         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
587         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
588         Test what happens when we can't open the three files we depend upon.
589
590         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
591         an authentication class.
592
593         (CommitterAuthTest.test_invalid_auth_json_file):
594         (CommitterAuthTest.test_invalid_committers_file):
595         (CommitterAuthTest.test_invalid_trac_credentials_file):
596         (CommitterAuthTest.test_missing_auth_json_keys):
597         Test what happens when the three files we depend upon are invalid in some way.
598
599         (CommitterAuthTest.test_open_auth_json_file):
600         (CommitterAuthTest.test_open_trac_credentials_file):
601         (CommitterAuthTest.test_open_webkit_committers_file):
602         Test that we open the expected paths.
603
604         (CommitterAuthTest.test_trac_credentials_filename):
605         (CommitterAuthTest.test_webkit_committers_filename):
606         Test that we extract filenames out of auth.json correctly.
607
608         (CommitterAuthTest.test_non_committer_fails):
609         (CommitterAuthTest.test_unknown_user_fails):
610         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
611         (CommitterAuthTest.test_wrong_password_fails):
612         Test various failed authentication attempts.
613
614         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
615         committers out of the committers file correctly.
616
617         (CommitterAuthTest.fake_auth_json_file):
618         (CommitterAuthTest.invalid_auth_json_file):
619         (CommitterAuthTest.fake_committers_file):
620         (CommitterAuthTest.invalid_committers_file):
621         (CommitterAuthTest.fake_htdigest_file):
622         (CommitterAuthTest.invalid_htdigest_file):
623         Return various fake files for testing.
624
625         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
626         to be used for authentication in the web interface, and specify that only authenticated
627         users may force builds.
628
629 2011-12-01  Adam Roben  <aroben@apple.com>
630
631         Add an HTDigestParser class to webkitpy
632
633         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
634
635         This class can be used to parse Apache's htdigest files and check whether a given
636         username/realm/password tuple is present in the file. Eventually this will be used for
637         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
638
639         Reviewed by Eric Seidel.
640
641         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
642         (HTDigestParser.__init__): Stores the parsed representation of the file.
643         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
644         password and returns whether the resulting tuple is present in the file.
645         (HTDigestParser.entries): Just returns the parsed representation of the file.
646         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
647         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
648         whole file as invalid and all authentication attempts will fail.
649
650         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
651         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
652         optionally appended with some extra data, generates the expected entries.
653         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
654         authenticate, and tuples not present cannot.
655         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
656         fake_htdigest_file.
657
658         (HTDigestParserTest.test_empty_file):
659         (HTDigestParserTest.test_too_few_colons):
660         (HTDigestParserTest.test_too_many_colons):
661         (HTDigestParserTest.test_invalid_hash):
662         Test various forms of invalid files.
663
664         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
665
666 2011-12-01  Philippe Normand  <pnormand@igalia.com>
667
668         [GTK] Make the new 64-bit Release bot part of the core set
669         https://bugs.webkit.org/show_bug.cgi?id=73570
670
671         Reviewed by Adam Roben.
672
673         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
674         Debug bot which was already part of the core set. The GTK
675         gardeners are willing to actively maintain it.
676
677         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
678         (BuildBot.__init__):
679         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
680         (test_builder_name_regexps):
681
682 2011-12-01  Philippe Normand  <pnormand@igalia.com>
683
684         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
685         https://bugs.webkit.org/show_bug.cgi?id=73547
686
687         Reviewed by Adam Roben.
688
689         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
690         the 32-bit Debug configuration to 64-bit Release. The new slave is
691         a 64-bit machine already. The 32-bit slave will be shut down.
692
693 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
694
695         [GTK] build-jsc should not trigger gtkdoc generation
696         https://bugs.webkit.org/show_bug.cgi?id=73552
697
698         Reviewed by Philippe Normand.
699
700         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
701         that build-jsc does not try to generate gtkdoc.
702
703         * Scripts/webkitdirs.pm:
704         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
705
706 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
707
708         tests_run0.txt gets clobbered when re-running failing tests
709         https://bugs.webkit.org/show_bug.cgi?id=63844
710
711         Reviewed by Dirk Pranke.
712
713         * Scripts/webkitpy/layout_tests/controllers/manager.py:
714         (Manager.results_directory):
715         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
716         (AbstractWorker.__init__):
717         (_ManagerConnection.start_worker):
718         (_InlineManager.start_worker):
719         (_MultiProcessManager.start_worker):
720         (_WorkerConnection.__init__):
721         (_InlineWorkerConnection.__init__):
722         (_MultiProcessWorkerConnection.__init__):
723         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
724         (_TestWorker.__init__):
725         (_TestsMixin.test_cancel):
726         (_TestsMixin.test_done):
727         (_TestsMixin.test_unknown_message):
728         (InterfaceTest.test_managerconnection_is_abstract):
729         (InterfaceTest.test_workerconnection_is_abstract):
730         * Scripts/webkitpy/layout_tests/controllers/worker.py:
731         (Worker.__init__):
732         (Worker.safe_init):
733         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
734         (MainTest.test_retries_directory):
735
736 2011-12-01  Adam Roben  <aroben@apple.com>
737
738         Buildbot fix
739
740         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
741         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
742         it possible for build steps to reference things like the buildbotURL property of the config.
743
744 2011-11-30  Adam Roben  <aroben@apple.com>
745
746         Use curl for downloading builds to test slaves
747
748         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
749         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
750         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
751         overhead (courtesy of the Twisted framework).
752
753         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
754         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
755         This should make the test slaves quite a bit faster, and should ease the CPU load on
756         build.webkit.org a bit.
757
758         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
759
760         Reviewed by Mark Rowe.
761
762         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
763         to Test slaves. It's run just before DownloadBuiltProduct.
764         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
765         download.
766         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
767         FileDownload used to do this for us automatically.
768
769 2011-11-21  Philippe Normand  <pnormand@igalia.com>
770
771         [GTK] enable-webaudio websetting
772         https://bugs.webkit.org/show_bug.cgi?id=69836
773
774         Reviewed by Martin Robinson.
775
776         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
777         (LayoutTestController::overridePreference): Update WebKitGTK
778         enable-webaudio setting when a layout test requests it.
779
780 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
781
782         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
783         https://bugs.webkit.org/show_bug.cgi?id=73079
784
785         The idea is to have performance tests for WebInspector.
786         I was suggested to put these tests into PerformanceTests/inspector.
787         They produce output in a format that is suitable for chromium perf bot drawing scripts.
788
789         I'd like to reuse code for scanning folders for test files.
790         Because of the fact that original test_files.py has common and layout specific parts
791         I decided to extract the generic part and put it into webkitpy/common
792         I think the two packages with name test_files look strange but I have no idea about a better name.
793
794         Reviewed by Dirk Pranke.
795
796         * Scripts/run-inspector-perf-tests.py: Added.
797         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
798         (find):
799         (_normalize):
800         * Scripts/webkitpy/common/find_files_unittest.py: Added.
801         (MockWinFileSystem.join):
802         (MockWinFileSystem):
803         (MockWinFileSystem.normpath):
804         (TestWinNormalize.assert_filesystem_normalizes):
805         (TestWinNormalize.test_mocked_win):
806         (TestWinNormalize):
807         (TestWinNormalize.test_win):
808         * Scripts/webkitpy/layout_tests/port/base.py:
809         (Port.tests):
810         (Port.find_test_files):
811         (Port._driver_class):
812         (is_reference_html_file):
813         (_has_supported_extension):
814         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
815         (PortTest.test_find_no_paths_specified):
816         (PortTest.test_find_one_test):
817         (PortTest.test_find_glob):
818         (PortTest.test_find_with_skipped_directories):
819         (PortTest.test_find_with_skipped_directories_2):
820         (PortTest):
821         (PortTest.test_is_test_file):
822         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
823         (_tests):
824         * Scripts/webkitpy/layout_tests/port/test.py:
825         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
826         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
827         * Scripts/webkitpy/performance_tests/__init__.py: Added.
828         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
829         (PerfTestsRunner.__init__):
830         (PerfTestsRunner._parse_args):
831         (PerfTestsRunner._collect_tests._is_test_file):
832         (PerfTestsRunner._collect_tests):
833         (PerfTestsRunner.run):
834         (PerfTestsRunner._run_tests_set):
835         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
836         (MainTest.TestPort):
837         (MainTest.TestPort.create_driver):
838         (MainTest.TestDriver.run_test):
839         (MainTest.TestDriver):
840         (MainTest.TestDriver.stop):
841         (MainTest.create_runner):
842         (MainTest.run_test):
843         (MainTest.test_run_passing_test):
844         (MainTest.test_run_silent_test):
845         (MainTest.test_run_failed_test):
846         (MainTest.test_run_tonguey_test):
847         (MainTest.test_run_timeout_test):
848         (MainTest.test_run_crash_test):
849         (MainTest.test_run_test_set):
850         (MainTest.test_collect_tests):
851         (MainTest):
852         (MainTest.test_parse_args):
853         * Scripts/webkitpy/tool/commands/rebaseline.py:
854         (OptimizeBaselines.execute):
855         (AnalyzeBaselines.execute):
856
857 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
858
859         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
860         https://bugs.webkit.org/show_bug.cgi?id=70838
861
862         Reviewed by James Robinson.
863
864         * DumpRenderTree/chromium/TestShell.cpp:
865         (TestShell::resetWebSettings):
866         * DumpRenderTree/chromium/TestShell.h:
867         (TestShell::threadedCompositingEnabled):
868         * DumpRenderTree/chromium/WebPreferences.cpp:
869         (WebPreferences::reset):
870         (WebPreferences::applyTo):
871         * DumpRenderTree/chromium/WebPreferences.h:
872         * DumpRenderTree/chromium/WebViewHost.cpp:
873         (WebViewHost::WebViewHost):
874         (WebViewHost::~WebViewHost):
875
876 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
877
878         AX: Nodes are reporting that focus can be set when they really can't
879         https://bugs.webkit.org/show_bug.cgi?id=72791
880
881         Reviewed by Beth Dakin.
882
883         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
884         (AccessibilityUIElement::isFocusable):
885         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
887         (WTR::AccessibilityUIElement::isFocusable):
888
889 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
890
891         Moved myself to the reviewers list.
892
893         * Scripts/webkitpy/common/config/committers.py:
894
895 2011-11-30  David Levin  <levin@chromium.org>
896
897         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
898         https://bugs.webkit.org/show_bug.cgi?id=73415
899
900         Reviewed by Darin Fisher.
901
902         * DumpRenderTree/chromium/WebViewHost.cpp:
903         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
904         it being moved to a new interface and having the parameter removed.
905         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
906
907 2011-11-30  Adam Roben  <aroben@apple.com>
908
909         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
910
911         This will make it a lot easier to investigate build failures on the bots.
912
913         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
914
915         Reviewed by Eric Seidel.
916
917         * Scripts/webkitpy/common/system/executive_mock.py:
918         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
919         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
920         seen in practice.
921
922         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
923         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
924         The Printer was modifying the root logger in way that would cause my new tests in
925         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
926         seem important to the functioning of this test, and passing False makes Printer not modify
927         the root logger.
928
929         * Scripts/webkitpy/layout_tests/port/webkit.py:
930         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
931         up when --verbose is passed but not otherwise.
932         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
933         output at the ERROR level so it will always show up.
934
935         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
936         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
937         cases. Test that the build scripts' output is logged when --verbose is passed or the build
938         fails.
939
940 2011-11-30  Adam Roben  <aroben@apple.com>
941
942         Add a way to set OutputCapture's log level
943
944         This will be used by some unit tests I'm planning to add.
945
946         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
947
948         Reviewed by Eric Seidel.
949
950         * Scripts/webkitpy/common/system/outputcapture.py:
951         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
952         level we ever used before this patch.
953         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
954         being tested uses. Sets the log level for any current or future logging handlers.
955         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
956
957         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
958         (OutputCaptureTest.setUp): Create an OutputCapture to test.
959         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
960         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
961         was logged.
962         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
963         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
964         level.
965
966 2011-11-29  Beth Dakin  <bdakin@apple.com>
967
968         https://bugs.webkit.org/show_bug.cgi?id=72751
969         WebKit2.MouseMoveAfterCrash API test is failing 
970
971         Reviewed by Sam Weinig.
972
973         Like DumpRenderTree, the NSWindow should act as an active window.
974         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
975         (-[ActiveOffscreenWindow isKeyWindow]):
976         (TestWebKitAPI::PlatformWebView::PlatformWebView):
977
978 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
979
980         Add step to update gtk dependencies to the buildbot
981         https://bugs.webkit.org/show_bug.cgi?id=73455
982
983         Reviewed by Martin Robinson.
984
985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
986
987 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
988
989         [Qt] Add a fullscreen option to MiniBrowser.
990         https://bugs.webkit.org/show_bug.cgi?id=73445
991
992         Reviewed by Noam Rosenthal.
993
994         This bypasses the compositor on the N9 to increase performances
995         and remove the huge useless gray bar part of the window frame
996         at the bottom.
997
998         * MiniBrowser/qt/BrowserWindow.cpp:
999         (BrowserWindow::BrowserWindow):
1000         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1001         (printHelp):
1002         (MiniBrowserApplication::handleUserOptions):
1003         * MiniBrowser/qt/MiniBrowserApplication.h:
1004         (WindowOptions::setStartFullScreen):
1005         (WindowOptions::startFullScreen):
1006
1007 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
1008
1009         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
1010         https://bugs.webkit.org/show_bug.cgi?id=73425
1011
1012         Reviewed by Gustavo Noronha Silva.
1013
1014         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
1015         ensure that the jhbuild root is up-to-date. Currently the only module is
1016         the font module.
1017
1018         * Scripts/update-webkitgtk-libs: Added.
1019         * gtk/common.py: Added a helper to get the number of CPUs.
1020         * gtk/jhbuild.modules: Added.
1021         * gtk/jhbuildrc: Added.
1022
1023 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1024
1025         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
1026
1027         Reviewed by Csaba Osztrogonác.
1028
1029         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
1030         instead of one that pulls in JavaScriptCore headers.
1031         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
1032         with load(javascriptcore).
1033
1034 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1035
1036         Unreviewed, rolling out r101440 and r101442.
1037         http://trac.webkit.org/changeset/101440
1038         http://trac.webkit.org/changeset/101442
1039         https://bugs.webkit.org/show_bug.cgi?id=73429
1040
1041         multiple crashes on layout tests (Requested by hayato on
1042         #webkit).
1043
1044         * DumpRenderTree/chromium/TestShell.cpp:
1045         (TestShell::resetWebSettings):
1046         * DumpRenderTree/chromium/TestShell.h:
1047         * DumpRenderTree/chromium/WebPreferences.cpp:
1048         (WebPreferences::reset):
1049         (WebPreferences::applyTo):
1050         * DumpRenderTree/chromium/WebPreferences.h:
1051         * DumpRenderTree/chromium/WebViewHost.cpp:
1052         (WebViewHost::WebViewHost):
1053         (WebViewHost::~WebViewHost):
1054
1055 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
1056
1057         [Chromium] Fix broken DRT build for Aura Linux
1058         https://bugs.webkit.org/show_bug.cgi?id=72667
1059
1060         Reviewed by Tony Chang.
1061
1062         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
1063
1064         The following changes have been made:
1065
1066           1. Renamed TestShellAndroid to TestShellLinux.
1067           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
1068           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
1069
1070         * DumpRenderTree/DumpRenderTree.gypi:
1071         * DumpRenderTree/chromium/EventSender.cpp:
1072         (EventSender::keyDown):
1073         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1074         * DumpRenderTree/chromium/TestShellGtk.cpp:
1075         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1076         (AlarmHandler):
1077         (TestShell::waitTestFinished):
1078         (setupFontconfig):
1079         (platformInit):
1080         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
1081         (checkLayoutTestSystemDependencies):
1082         (openStartupDialog):
1083
1084 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
1085
1086         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
1087         https://bugs.webkit.org/show_bug.cgi?id=73328
1088
1089         Reviewed by Kent Tamura.
1090
1091         * DumpRenderTree/chromium/LayoutTestController.cpp:
1092         (LayoutTestController::enableFixedLayoutMode):
1093         (LayoutTestController::setFixedLayoutSize):
1094
1095 2011-11-29  Hayato Ito  <hayato@chromium.org>
1096
1097         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
1098         https://bugs.webkit.org/show_bug.cgi?id=73381
1099
1100         Reviewed by Ryosuke Niwa.
1101
1102         This is a quick fix for the breakage of tests on non-chromium port.
1103         We should implement diff_image later on non-chromium ports.
1104
1105         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1106         (write_test_result):
1107
1108 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1109
1110         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
1111         https://bugs.webkit.org/show_bug.cgi?id=72489
1112
1113         Reviewed by Eric Seidel.
1114
1115         Before the this fix always added "qt" option for the option list
1116         * Scripts/run-webkit-tests:
1117         * Scripts/webkitpy/layout_tests/port/qt.py:
1118
1119 2011-11-29  David Levin  <levin@chromium.org>
1120
1121         Add a way to revert a variable to its previous value after leaving a scope.
1122         https://bugs.webkit.org/show_bug.cgi?id=73371
1123
1124         Reviewed by Adam Barth.
1125
1126         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
1127         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
1128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1129         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1130         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
1131         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
1132
1133 2011-11-28  Kentaro Hara  <haraken@chromium.org>
1134
1135         Implement [Supplemental] IDL and support it in run-bindings-tests
1136         https://bugs.webkit.org/show_bug.cgi?id=73162
1137
1138         Reviewed by Adam Barth.
1139
1140         run-bindings-tests supports the [Supplemental] IDL in the following way.
1141             (1) It creates a file |x| listing all IDL files.
1142             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
1143             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
1144                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
1145                 including all attributes in IDL files that are supplementing the IDL file |z|.
1146
1147         * Scripts/run-bindings-tests:
1148         (generate_from_idl):
1149         (generate_supplemental_dependency):
1150         (detect_changes):
1151         (run_tests):
1152         (main):
1153
1154 2011-11-18  Nat Duca  <nduca@chromium.org>
1155
1156         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
1157         https://bugs.webkit.org/show_bug.cgi?id=70838
1158
1159         Reviewed by James Robinson.
1160
1161         * DumpRenderTree/chromium/TestShell.cpp:
1162         (TestShell::resetWebSettings):
1163         * DumpRenderTree/chromium/TestShell.h:
1164         (TestShell::threadedCompositingEnabled):
1165         * DumpRenderTree/chromium/WebPreferences.cpp:
1166         (WebPreferences::reset):
1167         (WebPreferences::applyTo):
1168         * DumpRenderTree/chromium/WebPreferences.h:
1169         * DumpRenderTree/chromium/WebViewHost.cpp:
1170         (WebViewHost::WebViewHost):
1171         (WebViewHost::~WebViewHost):
1172
1173 2011-11-29  Ojan Vafai  <ojan@chromium.org>
1174
1175         List of builders in the flakiness dashboard is out of date
1176         https://bugs.webkit.org/show_bug.cgi?id=73347
1177
1178         Reviewed by Adam Barth.
1179
1180         The chromium gpu bots no longer run layout tests, so kill that
1181         group entirely.
1182
1183         * TestResultServer/static-dashboards/builders.js:
1184         * TestResultServer/static-dashboards/dashboard_base.js:
1185
1186 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1187
1188         [Qt] Don't hard-code the list of WebKit2 generated sources
1189
1190         The generated sources are... wait for it... generated. So
1191         use the generator itself to figure out which sources we need
1192         to compile.
1193
1194         Reviewed by Simon Hausmann.
1195
1196         * qmake/mkspecs/features/default_post.prf:
1197
1198 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
1199
1200         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
1201         https://bugs.webkit.org/show_bug.cgi?id=73216
1202
1203         Reviewed by Philippe Normand.
1204
1205         Add a script that tries to sniff out 'make dist' problems without running
1206         'make dist.' 'make distcheck' takes a very long time to run and this should
1207         reduce the amount of times it needs to be run consecutively.
1208
1209         * gtk/common.py:
1210         (get_build_path.is_valid_build_directory): Guess the source directory
1211         by the existence of the GNUmakefile instead of the .libs directory. This
1212         allows one to run the script after running autogen.sh but before fully
1213         building.
1214         * gtk/find-make-dist-errors: Added.
1215
1216 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1217
1218         [Qt] Remove use of internal headers in the MiniBrowser
1219
1220         Reviewed by Simon Hausmann.
1221
1222         * MiniBrowser/qt/MiniBrowser.pro:
1223
1224 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
1225
1226         [Qt] Fix debug-shlib build without webkit2
1227
1228         Reviewed by Tor Arne Vestbø.
1229
1230         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
1231
1232 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
1233
1234         [Qt][WK2] Unreviewed buildfix after r101307.
1235
1236         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
1237
1238 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
1239
1240         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
1241         https://bugs.webkit.org/show_bug.cgi?id=72848
1242
1243         Add option to build-webkit.
1244
1245         Reviewed by Dimitri Glazkov.
1246
1247         * Scripts/build-webkit:
1248
1249 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1250
1251         gtest normalization in the test results server is sometimes wrong
1252         https://bugs.webkit.org/show_bug.cgi?id=73262
1253
1254         Reviewed by Tony Chang.
1255
1256         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
1257         entries in the incremental JSON, one of the entries will have the correct data
1258         from the run and the other will have dummy no-data values. Make sure to
1259         always pick the one with real data.
1260
1261         * TestResultServer/model/jsonresults.py:
1262         (JsonResults._remove_gtest_modifiers):
1263         * TestResultServer/model/jsonresults_unittest.py:
1264         (JsonResultsTest.test_remove_gtest_modifiers):
1265
1266 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1267
1268         Some of the results.json files have results/times entries at the directory level
1269         https://bugs.webkit.org/show_bug.cgi?id=73261
1270
1271         Reviewed by Tony Chang.
1272
1273         This is just a bug that got introduced in a temporary push of the results server.
1274         This patch repairs the broken files. After all the bots have cycled, we can simplify
1275         this code to just assert that results/times are not at the directory level.
1276
1277         Also, when catching exceptions, log the full stacktrace.
1278
1279         * TestResultServer/model/jsonresults.py:
1280         (_is_directory):
1281         (JsonResults._load_json):
1282         (JsonResults._merge_tests):
1283         (JsonResults.merge):
1284         * TestResultServer/model/jsonresults_unittest.py:
1285         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
1286
1287 2011-11-28  Tony Chang  <tony@chromium.org>
1288
1289         ews bots should pass --force to update-webkit-chromium
1290         https://bugs.webkit.org/show_bug.cgi?id=73230
1291
1292         Reviewed by Adam Barth.
1293
1294         This makes it less likely for gclient changes to break the bots (e.g.,
1295         if a DEPS repository moves or is switched to a branch).
1296
1297         Also pass --force when using |build-webkit --update-chromium| since this
1298         appears to only be used by the bots.
1299
1300         Take 2: Add Options.non_interactive to update.py's options() method.
1301
1302         * Scripts/update-webkit:
1303         * Scripts/webkitdirs.pm:
1304         (determineIsChromium): Add --force-update to update-webkit --chromium.
1305         (forceChromiumUpdate):
1306         (buildChromium): Pass --force to update-webkit-chromium.
1307         * Scripts/webkitpy/tool/steps/update.py:
1308         (Update.run): Add --force-update if non-interactive (i.e., bots).
1309         * Scripts/webkitpy/tool/steps/update_unittest.py:
1310
1311 2011-11-28  Tony Chang  <tony@chromium.org>
1312
1313         Revert r101279, broke the ews and cq bots.
1314
1315         * Scripts/update-webkit:
1316         * Scripts/webkitdirs.pm:
1317         (determineIsChromium):
1318         (buildChromium):
1319         * Scripts/webkitpy/common/config/ports.py:
1320         (WebKitPort.update_webkit_command):
1321         (ChromiumPort.update_webkit_command):
1322         * Scripts/webkitpy/common/config/ports_mock.py:
1323         (MockPort.update_webkit_command):
1324         * Scripts/webkitpy/tool/steps/update.py:
1325         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
1326
1327 2011-11-28  Ojan Vafai  <ojan@chromium.org>
1328
1329         testlistjson on the test results server doesn't understand hierarchical results format
1330         https://bugs.webkit.org/show_bug.cgi?id=73246
1331
1332         Reviewed by Tony Chang.
1333
1334         * TestResultServer/model/jsonresults.py:
1335         (JsonResults._delete_results_and_times):
1336         Instead of just getting the top-level keys, we now walk the tests tree and
1337         delete the results and times values.
1338
1339         * TestResultServer/model/jsonresults_unittest.py:
1340         Simplify the test harness to take in the same JSON format for the tests
1341         that the actual results.json uses instead of something very similar but
1342         needlessly different. This also allows for testing the broken case of
1343         results and times values being at non-leaf level.
1344
1345 2011-11-28  Tony Chang  <tony@chromium.org>
1346
1347         ews bots should pass --force to update-webkit-chromium
1348         https://bugs.webkit.org/show_bug.cgi?id=73230
1349
1350         Reviewed by Adam Barth.
1351
1352         This makes it less likely for gclient changes to break the bots (e.g.,
1353         if a DEPS repository moves or is switched to a branch).
1354
1355         Also pass --force when using |build-webkit --update-chromium| since this
1356         appears to only be used by the bots.
1357
1358         * Scripts/update-webkit:
1359         * Scripts/webkitdirs.pm:
1360         (determineIsChromium): Add --force-update to update-webkit --chromium.
1361         (forceChromiumUpdate):
1362         (buildChromium): Pass --force to update-webkit-chromium.
1363         * Scripts/webkitpy/tool/steps/update.py:
1364         (Update.run): Add --force-update if non-interactive (i.e., bots).
1365         * Scripts/webkitpy/tool/steps/update_unittest.py:
1366
1367 2011-11-28  Michael Saboff  <msaboff@apple.com>
1368
1369         Fixed help message for --exclude-kraken to say that
1370         it excludes Kraken and not SunSpider.
1371
1372         Rubber-stamped by Filip Pizlo.
1373
1374         * Scripts/bencher:
1375
1376 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1377
1378         Unreviewed, rolling out r101273.
1379         http://trac.webkit.org/changeset/101273
1380         https://bugs.webkit.org/show_bug.cgi?id=73244
1381
1382         multiple test failures and timeouts (Requested by tony^work on
1383         #webkit).
1384
1385         * DumpRenderTree/DumpRenderTree.gypi:
1386         * DumpRenderTree/chromium/EventSender.cpp:
1387         (EventSender::keyDown):
1388         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1389         (AlarmHandler):
1390         (TestShell::waitTestFinished):
1391         (platformInit):
1392         (openStartupDialog):
1393         (checkLayoutTestSystemDependencies):
1394         * DumpRenderTree/chromium/TestShellGtk.cpp:
1395         (AlarmHandler):
1396         (setupFontconfig):
1397         (TestShell::waitTestFinished):
1398         (platformInit):
1399         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
1400         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1401
1402 2011-11-28  John Yani  <vanuan@gmail.com>
1403
1404         new-run-webkit-tests is locale dependent
1405         https://bugs.webkit.org/show_bug.cgi?id=68691
1406
1407         Reviewed and modified by Eric Seidel.
1408
1409         This is a simpler version of John's patch which I'm landing.
1410         This just engages the hacks from the Host constructor on a global
1411         basis.
1412
1413         * Scripts/webkitpy/common/host.py:
1414         (Host.__init__):
1415         (Host._engage_awesome_locale_hacks):
1416
1417 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
1418
1419         [Chromium] Fix broken DRT build for Aura Linux
1420         https://bugs.webkit.org/show_bug.cgi?id=72667
1421
1422         Reviewed by Tony Chang.
1423
1424         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
1425
1426         The following changes have been made:
1427
1428           1. Renamed TestShellAndroid to TestShellLinux.
1429           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
1430           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
1431
1432         * DumpRenderTree/DumpRenderTree.gypi:
1433         * DumpRenderTree/chromium/EventSender.cpp:
1434         (EventSender::keyDown):
1435         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1436         * DumpRenderTree/chromium/TestShellGtk.cpp:
1437         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
1438         (AlarmHandler):
1439         (TestShell::waitTestFinished):
1440         (setupFontconfig):
1441         (platformInit):
1442         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
1443         (checkLayoutTestSystemDependencies):
1444         (openStartupDialog):
1445
1446 2011-11-28  Eric Seidel  <eric@webkit.org>
1447
1448         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1449         https://bugs.webkit.org/show_bug.cgi?id=71983
1450
1451         Reviewed by Adam Barth.
1452
1453         We'll add more code to Environment overtime,
1454         allowing us to mock out more of our direct interactions with os.environ.
1455
1456         This patch also makes run_command print the passed in environment.
1457
1458         * Scripts/webkitpy/common/host_mock.py:
1459         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1460         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1461         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1462         * Scripts/webkitpy/common/system/executive.py:
1463         * Scripts/webkitpy/common/system/executive_mock.py:
1464         * Scripts/webkitpy/layout_tests/port/webkit.py:
1465         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1466         * Scripts/webkitpy/tool/commands/download_unittest.py:
1467         * Scripts/webkitpy/tool/steps/build.py:
1468
1469 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1470
1471         [Qt] Build system fixes against V8.
1472
1473         Reviewed by Tor Arne Vestbø.
1474
1475         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
1476         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
1477         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
1478
1479 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1480
1481         Make sure the useFixedLayout feature is consistently handled
1482         https://bugs.webkit.org/show_bug.cgi?id=73212
1483
1484         Reviewed by Simon Hausmann.
1485
1486         The web page parameters are set to our Qt defaults and are now altered
1487         in the WebKitTestRunner.
1488
1489         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1490         (WTR::WrapperWindow::WrapperWindow):
1491
1492 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
1493
1494         [Qt] WTF should be built as separate static library
1495         https://bugs.webkit.org/show_bug.cgi?id=73201
1496
1497         Reviewed by Tor Arne Vestbø.
1498
1499         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
1500         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
1501         thus wtf dependency.
1502         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
1503         * WebKitTestRunner/Target.pri: Ditto.
1504         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
1505         consider wtf, too.
1506         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
1507         moved into wtf.prf.
1508         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
1509         link in libwtf.
1510         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
1511
1512 2011-11-28  Kentaro Hara  <haraken@chromium.org>
1513
1514         run-bindings-tests shows diff error for a newly added binding test
1515         https://bugs.webkit.org/show_bug.cgi?id=73179
1516
1517         Reviewed by Adam Barth.
1518
1519         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
1520         run-bindings-tests just shows diff error because reference files
1521         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
1522
1523             FAIL: (V8) V8TestSupplemental.h
1524             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
1525
1526         Instead, this patch treats a non-existent reference file as an empty file and
1527         shows the result of the newly added binding test, like this:
1528
1529             FAIL: (V8) V8TestSupplemental.h
1530             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
1531             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
1532             @@ -0,0 +1,84 @@
1533             +/*
1534             +    This file is part of the WebKit open source project.
1535             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
1536             +
1537             (omitted)
1538
1539         * Scripts/run-bindings-tests:
1540         (detect_changes): Just added an -N option to the diff command.
1541
1542 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
1543
1544         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
1545         https://bugs.webkit.org/show_bug.cgi?id=73165
1546
1547         Reviewed by Philippe Normand.
1548
1549         Fix some syntax errors in this script and remove an unused variable.
1550
1551         * gtk/generate-gtkdoc:
1552         (get_webkit2_options.src_path): 
1553         (get_webkit2_options):
1554         (get_webkit1_options.src_path):
1555
1556 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
1557
1558         [wx] Unreviewed build fix. Enable the inspector.
1559         
1560         * waf/build/settings.py:
1561
1562 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
1563
1564         Try to fix the build after r101174.
1565
1566         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
1567
1568 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
1569
1570         [GTK] Integrate build-gtkdoc into build-webkit and make
1571         https://bugs.webkit.org/show_bug.cgi?id=72626
1572
1573         Reviewed by Philippe Normand.
1574
1575         * GNUmakefile.am: Added support for new scripts and "make docs".
1576         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
1577         (buildAutotoolsProject):
1578         * gtk/generate-gtkdoc: Added.
1579         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
1580
1581 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1582
1583         [Qt] Add support for using OWRT with Qt5
1584         https://bugs.webkit.org/show_bug.cgi?id=72947
1585
1586         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
1587
1588         Reviewed by Csaba Osztrogonác.
1589
1590         * Scripts/old-run-webkit-tests:
1591
1592 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
1593
1594         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
1595         https://bugs.webkit.org/show_bug.cgi?id=73126
1596
1597         No need to have a separate client call for this. The front-end can store messages
1598         which arrive before front-end loaded and dispatch them later. This happens in layout
1599         tests only by the way as all other messages should be initiated by the front-end code.
1600
1601         Reviewed by Pavel Feldman.
1602
1603         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1604         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1605         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1606         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1607
1608 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1609
1610         Replace subprocess.call() with subprocess.Popen()
1611         https://bugs.webkit.org/show_bug.cgi?id=73105
1612
1613         Reviewed by Adam Barth.
1614
1615         Currently, the stdout and stderr of the child processes of run-bindings-tests
1616         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
1617         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
1618         between a parent process and a child process. This patch replaces subprocess.call() with
1619         subprocess.Popen() and synchronizes the stdout and stderr between them.
1620         This patch also makes output messages of run-bindings-tests more readable.
1621
1622         With this patch, the output messages of run-bindings-tests look like as follows:
1623
1624             PASS: (CPP) WebDOMTestObj.h
1625             PASS: (CPP) WebDOMTestObj.cpp
1626             FAIL: (CPP) WebDOMTestInterface.h
1627             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
1628             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
1629             @@ -23,7 +23,7 @@
1630              #ifndef WebDOMTestInterface_h
1631              #define WebDOMTestInterface_h
1632
1633             -#if ENABLE(Condition1) || ENABLE(Condition2)
1634             +#if ENABLE(Condition1) || ENABLE(Condition3)
1635
1636              #include <WebDOMObject.h>
1637              #include <WebDOMString.h>
1638              @@ -53,5 +53,5 @@
1639              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
1640
1641              #endif
1642             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
1643             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
1644             PASS: (CPP) WebDOMFloat64Array.cpp
1645             PASS: (CPP) WebDOMFloat64Array.h
1646
1647             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
1648
1649         * Scripts/run-bindings-tests:
1650         (generate_from_idl):
1651         (detect_changes):
1652         (run_tests):
1653         (main):
1654
1655 2011-11-24  Kentaro Hara  <haraken@chromium.org>
1656
1657         Fix the current working directory of run-bindings-tests
1658         https://bugs.webkit.org/show_bug.cgi?id=73106
1659
1660         Reviewed by Adam Barth.
1661
1662         Currently, run-bindings-tests outputs the following error
1663         (although it outputs "all tests passed!" in the end):
1664
1665             Testing the ObjC generator on TestObj.idl
1666             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
1667             gcc: warning: '-x objective-c' after last input file has no effect
1668             gcc: no input files
1669
1670         This is because CodeGeneratorObjC.pm assumes that the current working directory
1671         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
1672         Thus, this patch changes it to WebKit/Source/.
1673
1674         * Scripts/run-bindings-tests:
1675         (generate_from_idl):
1676         (main):
1677
1678 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1679
1680         [Qt] Get rid of the buildDirForSource() function in the build system
1681
1682         At some point the plan was to allow for running qmake on sub-trees
1683         of the sources, into the top level build directory, but this is no
1684         longer possible, so no reason to keep the convenience function around.
1685
1686         Reviewed by Simon Hausmann.
1687
1688         * WebKitTestRunner/DerivedSources.pri:
1689         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1690         * qmake/mkspecs/features/default_post.prf:
1691         * qmake/mkspecs/features/default_pre.prf:
1692         * qmake/mkspecs/features/functions.prf:
1693         * qmake/mkspecs/features/javascriptcore.prf:
1694         * qmake/mkspecs/features/webcore.prf:
1695         * qmake/mkspecs/features/webkit2.prf:
1696
1697 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1698
1699         Unreviewed, rolling out r101107.
1700         http://trac.webkit.org/changeset/101107
1701         https://bugs.webkit.org/show_bug.cgi?id=73062
1702
1703         Breaks the commit-queue (Requested by abarth on #webkit).
1704
1705         * Scripts/webkitpy/common/host.py:
1706         (Host._engage_awesome_windows_hacks):
1707         * Scripts/webkitpy/common/host_mock.py:
1708         (MockHost.__init__):
1709         * Scripts/webkitpy/common/system/environment.py: Removed.
1710         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
1711         * Scripts/webkitpy/common/system/executive.py:
1712         (Executive._run_command_with_teed_output):
1713         (Executive.run_and_throw_if_fail):
1714         * Scripts/webkitpy/common/system/executive_mock.py:
1715         (MockExecutive.run_and_throw_if_fail):
1716         (MockExecutive.run_command):
1717         * Scripts/webkitpy/layout_tests/port/webkit.py:
1718         (WebKitPort._driver_build_script_name):
1719         (WebKitPort._run_script):
1720         (WebKitPort._build_driver):
1721         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1722         (test_build_driver):
1723         * Scripts/webkitpy/tool/commands/download_unittest.py:
1724         * Scripts/webkitpy/tool/steps/build.py:
1725         (Build.build):
1726
1727 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1728
1729         Unreviewed, rolling out r101110.
1730         http://trac.webkit.org/changeset/101110
1731         https://bugs.webkit.org/show_bug.cgi?id=73057
1732
1733         The bots have now cycled and this patch is no longer needed.
1734
1735         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1736         (Manager._upload_json_files):
1737
1738 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1739
1740         Temporarily save the incremental results json in order to identify bug
1741         https://bugs.webkit.org/show_bug.cgi?id=73057
1742
1743         Reviewed by Dean Jackson.
1744
1745         The test results server needed to be rolled back from tip of tree
1746         due to a JSON merging bug. It's hard to identify what the bug is without
1747         the raw data.
1748
1749         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1750         (Manager._upload_json_files):
1751
1752 2011-11-23  Ojan Vafai  <ojan@chromium.org>
1753
1754         Merging two version 4 results hits an error in the test results server
1755         https://bugs.webkit.org/show_bug.cgi?id=73042
1756
1757         Reviewed by Adam Barth.
1758
1759         The old code assumed that if the aggregate results value was not a leaf
1760         value that the incremental results would exist, which is just totally
1761         wrong. Added a test for that case as well.
1762
1763         * TestResultServer/model/jsonresults.py:
1764         (JsonResults._merge_tests):
1765         * TestResultServer/model/jsonresults_unittest.py:
1766         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
1767         (JsonResultsTest.test_merge_build_directory_hierarchy):
1768
1769 2011-11-23  Eric Seidel  <eric@webkit.org>
1770
1771         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
1772         https://bugs.webkit.org/show_bug.cgi?id=71983
1773
1774         Reviewed by Adam Barth.
1775
1776         We'll add more code to Environment overtime,
1777         allowing us to mock out more of our direct interactions with os.environ.
1778
1779         This patch also makes run_command print the passed in environment.
1780
1781         * Scripts/webkitpy/common/host_mock.py:
1782         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1783         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1784         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
1785         * Scripts/webkitpy/common/system/executive.py:
1786         * Scripts/webkitpy/common/system/executive_mock.py:
1787         * Scripts/webkitpy/layout_tests/port/webkit.py:
1788         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1789         * Scripts/webkitpy/tool/commands/download_unittest.py:
1790         * Scripts/webkitpy/tool/steps/build.py:
1791
1792 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1793
1794         [Qt] Re-generate QtWebKit API forwarding headers when API changes
1795
1796         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
1797         so we need sync.profile to live in the same directory as the project file
1798         that will be touched when adding/removing API (api.pri in our case).
1799
1800         Since the WebKit2 APIs live in a separate static library, we have to
1801         add the project file for WebKit2 as a dependency of the api.pri file
1802         as well, so that any changes to the WebKit2 API will still trigger a
1803         run of qmake (and then syncqt).
1804
1805         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
1806         that the forwarding headers are still generated in the root build dir,
1807         not in the Source dir along with the internal forwarding headers.
1808
1809         Reviewed by Andreas Kling.
1810
1811         * qmake/mkspecs/features/default_pre.prf:
1812         * qmake/mkspecs/features/functions.prf:
1813
1814 2011-11-23  Johnny Ding  <jnd@chromium.org>
1815
1816         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
1817         https://bugs.webkit.org/show_bug.cgi?id=72950
1818
1819         Reviewed by Tony Chang.
1820
1821         * DumpRenderTree/chromium/LayoutTestController.cpp:
1822         (LayoutTestController::queueLoadHTMLString):
1823
1824 2011-11-23  Adam Barth  <abarth@webkit.org>
1825
1826         garden-o-matic should display a message if it can't find results to display
1827         https://bugs.webkit.org/show_bug.cgi?id=72991
1828
1829         Reviewed by Dimitri Glazkov.
1830
1831         Not all failures (e.g., TIMEOUT) have results that we can display.
1832         This patch adds a short message so that the user can see that we're
1833         done trying to load the results.
1834
1835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1838
1839 2011-11-23  Adam Barth  <abarth@webkit.org>
1840
1841         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
1842         https://bugs.webkit.org/show_bug.cgi?id=72992
1843
1844         Reviewed by Dimitri Glazkov.
1845
1846         This patch also prepares us to list other sorts of failures, like
1847         performance and unit test.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1853
1854 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
1855
1856         Add new Chromium tests to the flakiness dashboard
1857         https://bugs.webkit.org/show_bug.cgi?id=72997
1858
1859         Reviewed by Ojan Vafai.
1860
1861         * TestResultServer/static-dashboards/dashboard_base.js:
1862         ():
1863
1864 2011-11-23  Adam Barth  <abarth@webkit.org>
1865
1866         garden-o-matic should support AUDIO failures
1867         https://bugs.webkit.org/show_bug.cgi?id=69477
1868
1869         Reviewed by Dimitri Glazkov.
1870
1871         This is a first iteration at supporting AUDIO failures in
1872         garden-o-matic.  We'll probably need to iterate a bit when we have a
1873         real audio failure in the tree to play with.  For example, we'll
1874         probably want to add and <audio> element to the "Examine" view to hear
1875         the differences, but that all can be done in a subsequent patch.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1878
1879 2011-11-23  Scott Graham  <scottmg@chromium.org>
1880
1881         Adding gamepad support
1882         https://bugs.webkit.org/show_bug.cgi?id=69451
1883
1884         Reviewed by Darin Fisher.
1885
1886         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
1887         gamepad data that will be retrieved when JS code pulls via API access.
1888
1889         * DumpRenderTree/DumpRenderTree.gypi:
1890         * DumpRenderTree/chromium/GamepadController.cpp: Added.
1891         (GamepadController::GamepadController):
1892         (GamepadController::bindToJavascript):
1893         (GamepadController::reset):
1894         (GamepadController::connect):
1895         (GamepadController::disconnect):
1896         (GamepadController::setId):
1897         (GamepadController::setButtonCount):
1898         (GamepadController::setButtonData):
1899         (GamepadController::setAxisCount):
1900         (GamepadController::setAxisData):
1901         (GamepadController::fallbackCallback):
1902         * DumpRenderTree/chromium/GamepadController.h: Added.
1903         * DumpRenderTree/chromium/TestShell.cpp:
1904         (TestShell::TestShell):
1905         (TestShell::resetTestController):
1906         (TestShell::bindJSObjectsToWindow):
1907         * DumpRenderTree/chromium/TestShell.h:
1908         (TestShell::gamepadController):
1909
1910 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1911
1912         [CMake] Move the top-level logic to the top-level directory.
1913         https://bugs.webkit.org/show_bug.cgi?id=72685
1914
1915         Reviewed by Brent Fulgham.
1916
1917         * CMakeLists.txt: Added.
1918         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
1919         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
1920         * Scripts/webkitdirs.pm:
1921         (generateBuildSystemFromCMakeProject):
1922         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
1923
1924 2011-11-17  Vincent Scheib  <scheib@chromium.org>
1925
1926         Pointer Lock: Initial Tests for navigator.webkitPonter
1927         https://bugs.webkit.org/show_bug.cgi?id=72659
1928
1929         Reviewed by Darin Fisher.
1930
1931         * DumpRenderTree/chromium/TestShell.cpp:
1932         (TestShell::TestShell):
1933             Enabling PointerLock in TestShell
1934
1935 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
1936
1937         Update flakiness dashboard for new Chromium builders and tests
1938         https://bugs.webkit.org/show_bug.cgi?id=72931
1939
1940         Reviewed by Ojan Vafai.
1941
1942         * TestResultServer/static-dashboards/builders.js:
1943         * TestResultServer/static-dashboards/dashboard_base.js:
1944
1945 2011-11-22  Adam Roben  <aroben@apple.com>
1946
1947         Remove some debugging code I accidentally left in r101005
1948
1949         * Scripts/prepare-ChangeLog:
1950         (get_function_line_ranges_for_python):
1951
1952 2011-11-22  Adam Roben  <aroben@apple.com>
1953
1954         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
1955
1956         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
1957         classes/methods in Python source files
1958
1959         Reviewed by Dan Bates.
1960
1961         * Scripts/prepare-ChangeLog:
1962         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
1963         or that use python as their interpreter. Modified the code that extracts the interpreter to
1964         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
1965         scripts.
1966         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
1967         for class/def lines and generate ranges based on them.
1968
1969 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
1970
1971         [GTK] Enable WebSocket hybi tests
1972         https://bugs.webkit.org/show_bug.cgi?id=72870
1973
1974         Reviewed by Xan Lopez.
1975
1976         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1977         (resetDefaultsToConsistentValues):
1978         Reset the setting value to the default value (true).
1979         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1980         (LayoutTestController::overridePreference):
1981         Change the setting value through a function in DumpRenderTreeSupportGtk.
1982
1983 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
1984
1985         ChangeLogEntry should be able to parse entries with multiple authors
1986         https://bugs.webkit.org/show_bug.cgi?id=72690
1987
1988         Reviewed by Eric Seidel.
1989
1990         Support multi-author change log entries in ChangeLogEntry. Split author names using
1991         the same logic as splitting reviewer names. _authors now stores list of dictionaries
1992         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
1993         accounts because some contributors are never listed in committers.py. 
1994
1995         * Scripts/webkitpy/common/checkout/changelog.py:
1996         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1997         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
1998         throws an exception when the argument is None.
1999
2000 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
2001
2002         [Qt] Speed up debug builds.
2003         https://bugs.webkit.org/show_bug.cgi?id=72882
2004
2005         Reviewed by Tor Arne Vestbø.
2006
2007         Introduce a special type of build that replaces the static jsc/wc/wk2
2008         static libraries with shared libraries, that individually are much faster
2009         to link and don't require relinking into the big library when changing just
2010         one file in one module. It can be enabled with
2011         --qmakearg="CONFIG+=force_static_libs_as_shared"
2012
2013         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
2014         disable symbol visibility, static linkage and enable rpath.
2015         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
2016         we need to link the convenience libraries together or not and renamed linkStaticLibrary
2017         to just linkLibrary (because linkage is not necessarily static).
2018         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
2019         link against jsc/wc/wk2 when linking app code against QtWebKit.
2020         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
2021         function.
2022         * qmake/mkspecs/features/webcore.prf: Ditto.
2023         * qmake/mkspecs/features/webkit2.prf: Ditto.
2024
2025 2011-11-21  Adam Klein  <adamk@chromium.org>
2026
2027         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
2028         https://bugs.webkit.org/show_bug.cgi?id=72898
2029
2030         Reviewed by Ojan Vafai.
2031
2032         Also removed a comment that was going to be more trouble to keep up to
2033         date than seemed worthwhile (the code is now the documentation).
2034
2035         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2036
2037 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
2038
2039         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
2040         https://bugs.webkit.org/show_bug.cgi?id=72895
2041
2042         Reviewed by Chris Fleizach.
2043
2044         * DumpRenderTree/chromium/WebViewHost.cpp:
2045         (WebViewHost::postAccessibilityNotification):
2046
2047 2011-11-21  Philippe Normand  <pnormand@igalia.com>
2048
2049         Unreviewed, run-gtk-tests temporary workaround after r98500.
2050
2051         * Scripts/run-gtk-tests: Try to find the build directory like in
2052         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
2053
2054 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2055
2056         [GTK] Add a way to skip unit tests in the bots
2057         https://bugs.webkit.org/show_bug.cgi?id=72879
2058
2059         Reviewed by Philippe Normand.
2060
2061         Rewrite the script in python to make it easier for everybody to
2062         change it and add support for skipping tests.
2063
2064         * Scripts/run-gtk-tests:
2065
2066 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
2067
2068         [EFL] Add more appcache functions to ewk_settings.
2069         https://bugs.webkit.org/show_bug.cgi?id=72143
2070
2071         Reviewed by Kenneth Rohde Christiansen.
2072
2073         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2074         (LayoutTestController::clearAllApplicationCaches):
2075         (LayoutTestController::setAppCacheMaximumSize): Use the right
2076         function, this is not related to the memory cache, but rather to the
2077         appcache.
2078
2079 2011-11-18  Adam Roben  <aroben@apple.com>
2080
2081         Make NRWT consider all lines of output from parse-malloc-history, not just the first
2082
2083         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
2084         found" even when there are more than 1 unique leaks
2085
2086         Reviewed by Darin Adler.
2087
2088         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2089         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
2090         "^" will be considered to match the beginning of any line, not only the beginning of the
2091         string.
2092
2093         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2094         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
2095         fake output and updated expectations to match.
2096
2097 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
2098
2099         [Qt] Clean up MiniBrowser project file after recent changes
2100         https://bugs.webkit.org/show_bug.cgi?id=72869
2101
2102         Reviewed by Simon Hausmann.
2103
2104         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
2105
2106         * MiniBrowser/qt/MiniBrowser.pro:
2107
2108 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
2109
2110         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
2111         https://bugs.webkit.org/show_bug.cgi?id=72479
2112
2113         Reviewed by Chris Fleizach.
2114
2115         * DumpRenderTree/AccessibilityUIElement.cpp:
2116         (getIsSelectedOptionActiveCallback):
2117         (AccessibilityUIElement::getJSClass):
2118         * DumpRenderTree/AccessibilityUIElement.h:
2119         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2120         (AccessibilityUIElement::AccessibilityUIElement):
2121         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
2122         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2123         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2124         (AccessibilityUIElement::isSelectedOptionActive):
2125         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2126         (AccessibilityUIElement::isSelectedOptionActive):
2127         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2128         (AccessibilityUIElement::isSelectedOptionActive):
2129
2130 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
2131
2132         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
2133         https://bugs.webkit.org/show_bug.cgi?id=72859
2134
2135         Reviewed by Eric Seidel.
2136         
2137         * Scripts/new-run-webkit-websocketserver:
2138
2139 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
2140
2141         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
2142         https://bugs.webkit.org/show_bug.cgi?id=72655
2143
2144         Reviewed by Hajime Morita.
2145
2146         Fixed the calculation of offset.
2147
2148         * DumpRenderTree/chromium/WebViewHost.cpp:
2149         (WebViewHost::finishLastTextCheck):
2150
2151 2011-11-20  Ojan Vafai  <ojan@chromium.org>
2152
2153         Change the final place where we use version 3 of the results json output
2154         https://bugs.webkit.org/show_bug.cgi?id=72838
2155
2156         Reviewed by Adam Barth.
2157
2158         This converts the json from being a flat map of test name --> results
2159         to being hierarchical by directory. This will make the json files 
2160         considerably smaller.
2161
2162         Also cleaned up some functions that were returning/checking boolean values
2163         that were always True.
2164
2165         * TestResultServer/model/jsonresults.py:
2166         * TestResultServer/model/jsonresults_unittest.py:
2167
2168 2011-11-20  Ojan Vafai  <ojan@chromium.org>
2169
2170         Include the master name when querying the test results server.
2171         This will soon be required since leaving the master name out mean
2172         that multiple files could match the query.
2173
2174         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2175
2176 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2177
2178         Fix jsonp callback code to add the callback if json content
2179         is not jsonp.
2180         * TestResultServer/handlers/testfilehandler.py:
2181
2182 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
2183
2184         Modify dashboard_base.js to optionally accept version 4 results json.
2185
2186         Reviewed by Ojan Vafai.
2187
2188         * TestResultServer/static-dashboards/dashboard_base.js:
2189         (ADD_RESULTS):
2190         (flattenTrie):
2191         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2192         (testFlattenTrie):
2193
2194 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2195
2196         Stop storing results files as jsonp in the test results server
2197         https://bugs.webkit.org/show_bug.cgi?id=72814
2198
2199         Reviewed by Adam Barth.
2200
2201         * TestResultServer/model/jsonresults.py:
2202         * TestResultServer/model/jsonresults_unittest.py:
2203
2204 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2205
2206         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
2207         https://bugs.webkit.org/show_bug.cgi?id=72813
2208
2209         Reviewed by Adam Barth.
2210
2211         Once this lands, we can start storing pure json in the test results server and then
2212         we can delete the code with all the FIXMEs added here.
2213
2214         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2215         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2216         Only add jsonp for full_results.json.
2217         * TestResultServer/model/jsonresults.py:
2218         * TestResultServer/model/jsonresults_unittest.py:
2219         Accept pure json uploads.
2220         * TestResultServer/static-dashboards/dashboard_base.js:
2221         (appendJSONScriptElementFor):
2222         Use the callback parameter so that the server can start returning pure json if it's left out.
2223
2224 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2225
2226         Allow json NRWT downloads to be pure json and not jsonp
2227         https://bugs.webkit.org/show_bug.cgi?id=72809
2228
2229         Reviewed by Adam Barth.
2230
2231         I'm moving the server to storing and serving up raw json instead of jsonp.
2232         You can still get the jsonp by passing a "callback" parameter, but there's no
2233         need for run-webkit-tests to get jsonp when all it wants is the raw json.
2234
2235         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2236         Make the wrapper stripping only happen if the json is actually wrapped.
2237         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2238
2239 2011-11-18  Daniel Bates  <dbates@rim.com>
2240
2241         Add CMake build infrastructure for the BlackBerry port
2242         https://bugs.webkit.org/show_bug.cgi?id=72768
2243
2244         Reviewed by Antonio Gomes.
2245
2246         Add optional --blackberry command line argument to build-webkit to build the
2247         BlackBerry port.
2248
2249         * Scripts/build-webkit:
2250         * Scripts/webkitdirs.pm:
2251         (determineBaseProductDir):
2252         (argumentsForConfiguration):
2253         (builtDylibPathForName):
2254         (determineIsQt):
2255         (isBlackBerry): Added.
2256         (determineIsBlackBerry): Added.
2257         (blackberryTargetArchitecture): Added.
2258         (isAppleWebKit):
2259
2260 2011-11-18  James Robinson  <jamesr@chromium.org>
2261
2262         Unreviewed, rolling out r100835.
2263         http://trac.webkit.org/changeset/100835
2264         https://bugs.webkit.org/show_bug.cgi?id=72778
2265
2266         Broke some page scale tests
2267
2268         * DumpRenderTree/chromium/EventSender.cpp:
2269         (EventSender::scalePageBy):
2270
2271 2011-11-18  Adam Barth  <abarth@webkit.org>
2272
2273         Prepare to move manual-tests out of WebCore
2274         https://bugs.webkit.org/show_bug.cgi?id=72782
2275
2276         Reviewed by Eric Seidel.
2277
2278         Update this file to refer to the new location of ManualTests.
2279
2280         * Scripts/webkitpy/common/config/build.py:
2281
2282 2011-11-18  James Robinson  <jamesr@chromium.org>
2283
2284         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
2285         https://bugs.webkit.org/show_bug.cgi?id=72778
2286
2287         Reviewed by Kenneth Russell.
2288
2289         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
2290
2291         * DumpRenderTree/chromium/EventSender.cpp:
2292         (EventSender::scalePageBy):
2293
2294 2011-11-18  Scott Graham  <scottmg@chromium.org>
2295
2296         IDL changes for gamepad support
2297         https://bugs.webkit.org/show_bug.cgi?id=71753
2298
2299         Reviewed by Adam Barth.
2300
2301         Runtime enable gamepad in chromium test shell.
2302
2303         * DumpRenderTree/chromium/TestShell.cpp:
2304         (TestShell::TestShell):
2305
2306 2011-10-27  Darin Fisher  <darin@chromium.org>
2307
2308         [chromium] Improve fullscreen API
2309         https://bugs.webkit.org/show_bug.cgi?id=70477
2310
2311         Reviewed by Adam Barth.
2312
2313         Implement enter/exitFullScreen.  The implementation is asynchronous,
2314         via postDelayedTask, to simulate how the browser actually behaves.
2315
2316         * DumpRenderTree/chromium/WebViewHost.cpp:
2317         (WebViewHost::enterFullScreen):
2318         (WebViewHost::exitFullScreen):
2319         (WebViewHost::setAddressBarURL):
2320         (WebViewHost::enterFullScreenNow):
2321         (WebViewHost::exitFullScreenNow):
2322         * DumpRenderTree/chromium/WebViewHost.h:
2323
2324 2011-11-18  Adam Roben  <aroben@apple.com>
2325
2326         Ignore an ANGLE leak that is not WebKit's fault
2327
2328         * Scripts/old-run-webkit-tests:
2329         (countAndPrintLeaks):
2330         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2331         (LeakDetector._callstacks_to_exclude_from_leaks):
2332         Added ScanFromString to the call stacks to exclude on all OS versions.
2333
2334 2011-11-18  Adam Roben  <aroben@apple.com>
2335
2336         Ignore another Lion-specific leak that is not WebKit's fault
2337
2338         * Scripts/old-run-webkit-tests:
2339         (countAndPrintLeaks):
2340         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2341         (LeakDetector._callstacks_to_exclude_from_leaks):
2342         Added SecTransformExecute to the call stacks to exclude.
2343
2344 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
2345
2346         [Qt] Enable WebSocket hybi tests
2347         https://bugs.webkit.org/show_bug.cgi?id=72687
2348
2349         Reviewed by Simon Hausmann.
2350
2351         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
2352
2353         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2354         (WebCore::WebPage::resetSettings):
2355         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2356         (LayoutTestController::overridePreference):
2357
2358 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
2359
2360         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
2361         https://bugs.webkit.org/show_bug.cgi?id=72707
2362
2363         Reviewed by Philippe Normand.
2364
2365         Make new-run-webkit-tests use the right path to locate the test
2366         plugin used by WebKitTestRunner.
2367
2368         * Scripts/webkitpy/layout_tests/port/gtk.py:
2369
2370 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
2371
2372         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
2373         https://bugs.webkit.org/show_bug.cgi?id=72697
2374
2375         Reviewed by Kenneth Rohde Christiansen.
2376
2377         * Tools.pro: Make WTR linux only for the moment.
2378         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
2379         * WebKitTestRunner/Target.pri: Ditto.
2380         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
2381         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
2382
2383 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2384
2385         [Qt] Change default size of the MiniBrowser
2386
2387         Reviewed by Simon Hausmann.
2388
2389         As we lay out desktop pages using the width of 980, change our default
2390         size to 980x735 so that we are not scaling down by default.
2391
2392         * MiniBrowser/qt/MiniBrowserApplication.h:
2393         (WindowOptions::WindowOptions):
2394
2395 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2396
2397         [EFL] Clean up the use of DATA_DIR in the buildsystem
2398         https://bugs.webkit.org/show_bug.cgi?id=72681
2399
2400         Reviewed by Daniel Bates.
2401
2402         Instead of adding -DDATA_DIR in all scopes, only define it in
2403         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
2404         it.
2405
2406         We can then define DATA_DIR to the generated theme directory for
2407         EWebLauncher, since it's what we want here.
2408
2409         * CMakeListsEfl.txt:
2410
2411 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2412
2413         [EFL] Move platform includes last in DRT's include directories.
2414         https://bugs.webkit.org/show_bug.cgi?id=72684
2415
2416         Reviewed by Daniel Bates.
2417
2418         This is the first step in fixing the build when a platform include (in
2419         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
2420         is included instead of WebKit's.
2421
2422         * DumpRenderTree/efl/CMakeLists.txt:
2423
2424 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
2425
2426         fuzzy_match doesn't recognize "Dan B" or "hyatt"
2427         https://bugs.webkit.org/show_bug.cgi?id=72636
2428
2429         Reviewed by Eric Seidel.
2430
2431         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
2432         and user names of email addreses such as rniwa in rniwa@webkit.org.
2433
2434         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
2435
2436         * Scripts/webkitpy/common/config/committers.py:
2437         * Scripts/webkitpy/common/config/committers_unittest.py:
2438
2439 2011-11-17  Eric Seidel  <eric@webkit.org>
2440
2441         Remove support for running check-webkit-style w/o a webkit checkout
2442         https://bugs.webkit.org/show_bug.cgi?id=72678
2443
2444         Reviewed by Adam Barth.
2445
2446         After talking to Dave Levin we've decided to remove this
2447         code.  I know of no users of check-webkit-style w/o a webkit checkout
2448         and this needlessly adds complexity.
2449
2450         * Scripts/webkitpy/style/main.py:
2451
2452 2011-11-17  Eric Seidel  <eric@webkit.org>
2453
2454         Remove more direct uses of os.path
2455         https://bugs.webkit.org/show_bug.cgi?id=72677
2456
2457         Reviewed by Adam Barth.
2458
2459         Remove more uses of os.path, including refactoring
2460         CommitterValidator to use a Host object instead of
2461         manual hacks to emulate what SCM and FileSystem provide.
2462
2463         * Scripts/webkitpy/common/checkout/changelog.py:
2464         * Scripts/webkitpy/common/config/committervalidator.py:
2465         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2466         * Scripts/webkitpy/common/system/filesystem_mock.py:
2467          - Turns out none of our unittests actually looked at this path.
2468            now I've made it be a valid path.
2469         * Scripts/webkitpy/tool/bot/feeders.py:
2470         * Scripts/webkitpy/tool/commands/queues.py:
2471
2472 2011-11-17  Eric Seidel  <eric@webkit.org>
2473
2474         Teach TextFileReader about FileSystem
2475         https://bugs.webkit.org/show_bug.cgi?id=72673
2476
2477         Reviewed by Adam Barth.
2478
2479         Unfortunately TextFileReader doesn't use FileSystem
2480         everywhere yet, so we can't move the unittests to
2481         using MockFileSystem, but we're close.
2482
2483         * Scripts/webkitpy/style/filereader.py:
2484         * Scripts/webkitpy/style/filereader_unittest.py:
2485         * Scripts/webkitpy/style/main.py:
2486
2487 2011-11-17  Eric Seidel  <eric@webkit.org>
2488
2489         Give check-webkit-style a Host
2490         https://bugs.webkit.org/show_bug.cgi?id=72670
2491
2492         Reviewed by Adam Barth.
2493
2494         * Scripts/webkitpy/common/checkout/scm/detection.py:
2495         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2496          - We don't run these unittests, but this one was looking for the wrong exception.
2497         * Scripts/webkitpy/style/main.py:
2498         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2499          - This was create a new scm object even though it already had one?
2500
2501 2011-11-17  Eric Seidel  <eric@webkit.org>
2502
2503         Move check-webkit-style change_directory code to more modern mocks
2504         https://bugs.webkit.org/show_bug.cgi?id=72664
2505
2506         Reviewed by Adam Barth.
2507
2508         * Scripts/check-webkit-style:
2509         * Scripts/webkitpy/style/main.py:
2510         * Scripts/webkitpy/style/main_unittest.py:
2511
2512 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
2513
2514         [GTK] enable ref tests
2515         https://bugs.webkit.org/show_bug.cgi?id=72601
2516
2517         Re-enable ref tests. Run the driver under evenly numbered display if performing
2518         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
2519         being run in an already used Xvfb instance if pixel tests are disabled.
2520
2521         Reviewed by Tony Chang.
2522
2523         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
2524         after the process is killed
2525
2526 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2527
2528         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
2529         https://bugs.webkit.org/show_bug.cgi?id=72620
2530
2531         Reviewed by David Levin.
2532
2533         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
2534         adding the suffix the cpp file. One example of false positive
2535         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
2536
2537         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
2538         basename contains the cpp's basename.
2539         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2540
2541 2011-11-17  Eric Seidel  <eric@webkit.org>
2542
2543         Move check-webkit-style's guts into webkitpy/style/main.py
2544         https://bugs.webkit.org/show_bug.cgi?id=72657
2545
2546         Reviewed by Adam Barth.
2547
2548         * Scripts/check-webkit-style:
2549         * Scripts/webkitpy/style/main.py:
2550
2551 2011-11-17  Eric Seidel  <eric@webkit.org>
2552
2553         new-run-webkit-tests is locale dependent
2554         https://bugs.webkit.org/show_bug.cgi?id=68691
2555
2556         Reviewed by Adam Barth.
2557
2558         Make NRWT use a clean environment, just like ORWT did.
2559
2560         * Scripts/webkitpy/layout_tests/port/base.py:
2561         * Scripts/webkitpy/layout_tests/port/chromium.py:
2562         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2563         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2564         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2565         * Scripts/webkitpy/layout_tests/port/efl.py:
2566         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2567         * Scripts/webkitpy/layout_tests/port/mac.py:
2568         * Scripts/webkitpy/layout_tests/port/qt.py:
2569         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2570         * Scripts/webkitpy/layout_tests/port/webkit.py:
2571         * Scripts/webkitpy/layout_tests/port/win.py:
2572
2573 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
2574
2575         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
2576         https://bugs.webkit.org/show_bug.cgi?id=72615
2577
2578         Reviewed by James Robinson.
2579
2580         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2581
2582 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
2583
2584         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
2585         https://bugs.webkit.org/show_bug.cgi?id=72595
2586
2587         Reviewed by Noam Rosenthal.
2588
2589         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2590         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
2591         ensure the registration of the DRTNode JS bindings.
2592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2593         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
2594         registration of QWebElement (now done implicitly through QWebPage ->
2595         QtWebElementRunTime::initialize code path)
2596
2597 2011-11-17  Adam Roben  <aroben@apple.com>
2598
2599         Fix a crash-inducing typo I introduced in r100648
2600
2601         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
2602         handling a crashing test
2603
2604         Reviewed by Adam Barth.
2605
2606         * Scripts/webkitpy/layout_tests/port/chromium.py:
2607         (ChromiumDriver.run_test): Get the driver name from the port.
2608
2609         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2610         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
2611         right crashed process name.
2612
2613 2011-11-17  Adam Roben  <aroben@apple.com>
2614
2615         Fix NRWT's parsing of the number of excluded leaks
2616
2617         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
2618         leaks were excluded
2619
2620         Reviewed by Adam Barth.
2621
2622         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2623         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
2624         regular expression match, not the entire matched string.
2625
2626         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2627         (LeakDetectorTest): Added some example output that shows how things look when leaks are
2628         excluded.
2629         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
2630         correctly.
2631
2632 2011-11-17  Adam Roben  <aroben@apple.com>
2633
2634         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
2635
2636         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
2637         when web process crashes, but WebProcess crash log should get saved instead
2638
2639         Reviewed by Eric Seidel.
2640
2641         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2642         (write_test_result): Simplified a little to share more code between the case where we
2643         crashed when running the test and where we crashed when checking the expected rendering for
2644         a reftest. Changed to pass the crashed process name down to write_crash_report.
2645         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
2646         along to CrashLogs.find_newest_log rather than always using the driver name.
2647
2648         * Scripts/webkitpy/layout_tests/port/chromium.py:
2649         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
2650         crashed.
2651
2652         * Scripts/webkitpy/layout_tests/port/test.py:
2653         (TestInstance.__init__): Initialize new web_process_crash attribute.
2654         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
2655         test this patch adds.
2656         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
2657         specifies that the driver crashed or the web process crashed.
2658
2659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2660         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
2661         which we pretend the web process crashed rather than the driver process.
2662
2663         (MainTest.test_run_singly_actually_runs_tests):
2664         (MainTest.test_unexpected_failures):
2665         (EndToEndTest.test_end_to_end):
2666         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
2667
2668 2011-11-17  Tony Chang  <tony@chromium.org>
2669
2670         [chromium] stop spamming features warning on every build
2671         https://bugs.webkit.org/show_bug.cgi?id=72629
2672
2673         Reviewed by Ojan Vafai.
2674
2675         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
2676         $mediaStreamSupport is on by default for chromium, make the default
2677         for $blobSupport also on.
2678
2679         * Scripts/build-webkit:
2680
2681 2011-11-17  Adam Roben  <aroben@apple.com>
2682
2683         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
2684
2685         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
2686         that are supposed to be ignored
2687
2688         Reviewed by Adam Barth.
2689
2690         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2691         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
2692         required when passing arguments via the shell (which we aren't doing here). It is not
2693         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
2694
2695         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2696         (LeakDetectorTest.test_leaks_args): Updated expectations.
2697
2698 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2699
2700         Unreviewed, run-bindings-tests fix after r91028.
2701
2702         * Scripts/run-bindings-tests: Use scm.detection module.
2703
2704 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
2705
2706         Silence a warning about control reaching the end of a non-void function
2707         https://bugs.webkit.org/show_bug.cgi?id=72616
2708
2709         Reviewed by Tony Gentilcore.
2710
2711         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2712         (AccessibilityUIElement::verticalScrollbar):
2713
2714 2011-11-17  Adam Roben  <aroben@apple.com>
2715
2716         Ignore some leaks in frameworks we link against on Lion
2717
2718         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
2719         aren't WebKit's fault
2720
2721         Reviewed by Antti Koivisto.
2722
2723         * Scripts/old-run-webkit-tests:
2724         (countAndPrintLeaks):
2725         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2726         (LeakDetector._callstacks_to_exclude_from_leaks):
2727         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
2728
2729         * Scripts/webkitpy/layout_tests/port/mac.py:
2730         (MacPort.is_lion): Added.
2731
2732         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2733         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
2734         methods.
2735
2736 2011-11-17  Philippe Normand  <pnormand@igalia.com>
2737
2738         [GTK] Disable ref tests
2739         https://bugs.webkit.org/show_bug.cgi?id=72599
2740
2741         Reviewed by Xan Lopez.
2742
2743         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
2744         tests to avoid massive flakiness.
2745
2746 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2747
2748         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
2749
2750         A new extension object has been added to QQuickWebView (the same approach should be used
2751         for other API classes that need experimental APIs). The QML extension mechanism is then
2752         built on top of the experimental object.
2753
2754         https://bugs.webkit.org/show_bug.cgi?id=72522
2755
2756         Reviewed by Simon Hausmann.
2757
2758         * MiniBrowser/qt/BrowserWindow.cpp:
2759         (BrowserWindow::BrowserWindow):
2760         (BrowserWindow::webView):
2761         * MiniBrowser/qt/BrowserWindow.h:
2762         * MiniBrowser/qt/UrlLoader.cpp:
2763         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2764         * qmake/mkspecs/features/default_post.prf:
2765         * qmake/mkspecs/features/default_pre.prf:
2766         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
2767         * qmake/mkspecs/features/qtwebkit.prf:
2768
2769 2011-11-17  Adam Barth  <abarth@webkit.org>
2770
2771         Move test_results_uploader.py out of layout_package
2772         https://bugs.webkit.org/show_bug.cgi?id=72590
2773
2774         Reviewed by Eric Seidel.
2775
2776         Most of the lines of code in this file are wrong, but I've restrained
2777         myself and only changed a few of them to generalized this class to the
2778         common package.
2779
2780         This is part of a series of patches to remove layout_package.
2781
2782         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
2783         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2784         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
2785
2786 2011-11-17  Adam Barth  <abarth@webkit.org>
2787
2788         Unreviewed. Fix style nits in printing.py.
2789
2790         * Scripts/webkitpy/layout_tests/views/printing.py:
2791
2792 2011-11-17  Adam Barth  <abarth@webkit.org>
2793
2794         Minor style nits in run_webkit_tests.py
2795         https://bugs.webkit.org/show_bug.cgi?id=72583
2796
2797         Reviewed by Eric Seidel.
2798
2799         This patch just fixes some minor style issues as I work my way back
2800         into this code.
2801
2802         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2803
2804 2011-11-17  Adam Barth  <abarth@webkit.org>
2805
2806         Move test_result_writer out of layout_package
2807         https://bugs.webkit.org/show_bug.cgi?id=72586
2808
2809         Rubber-stamped by Eric Seidel.
2810
2811         This is part of a series of patches to remove layout_package.
2812
2813         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2814         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
2815         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
2816         * Scripts/webkitpy/tool/commands/rebaseline.py:
2817
2818 2011-11-17  Adam Barth  <abarth@webkit.org>
2819
2820         svn-apply shouldn't magically move files into Source anymore
2821         https://bugs.webkit.org/show_bug.cgi?id=72579
2822
2823         Reviewed by Eric Seidel.
2824
2825         The Source directory has existed for long enough that we don't need
2826         svn-apply to magically re-write old-style patches anymore.
2827
2828         * Scripts/VCSUtils.pm:
2829         (parseGitDiffHeader):
2830         (parseSvnDiffHeader):
2831
2832 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2833
2834         Add a list of contribution areas
2835         https://bugs.webkit.org/show_bug.cgi?id=72566
2836
2837         Reviewed by Eric Seidel.
2838
2839         Added ContributionAreas class.
2840
2841         * Scripts/webkitpy/common/config/contributionareas.py: Added.
2842         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
2843
2844 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2845
2846         Refactor ChangeLogTest.test_parse_reviewer_text
2847         https://bugs.webkit.org/show_bug.cgi?id=72572
2848
2849         Reviewed by Eric Seidel.
2850
2851         Refactored the test code by introduing two helper functions.
2852
2853         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2854
2855 2011-11-16  Eric Seidel  <eric@webkit.org>
2856
2857         Add SCMDetector object to make scm detection mockable
2858         https://bugs.webkit.org/show_bug.cgi?id=72247
2859
2860         Reviewed by Adam Barth.
2861
2862         I think SCM detection may eventually be rolled into Checkout,
2863         but this patch at least makes it possible to mock code-paths
2864         which rely on scm detection.
2865         In the process of replacing callers of these free-functions
2866         I found that one of the functions was no longer used,
2867         and that one of the callers could instead just use the SCM
2868         object it already had access to through port.host.scm().
2869         I also discovered that I was not calling Host._initialize_scm()
2870         and thus host.scm() was always returning None!
2871
2872         * Scripts/check-webkit-style:
2873         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2874         * Scripts/webkitpy/common/checkout/deps.py:
2875         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2876         * Scripts/webkitpy/common/checkout/scm/detection.py:
2877         * Scripts/webkitpy/common/checkout/scm/git.py:
2878         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2879         * Scripts/webkitpy/common/checkout/scm/svn.py:
2880         * Scripts/webkitpy/common/host.py:
2881         * Scripts/webkitpy/common/host_mock.py:
2882         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2883         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2884         * Scripts/webkitpy/layout_tests/port/base.py:
2885         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2887         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2888         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2889
2890 2011-11-16  Mark Rowe  <mrowe@apple.com>
2891
2892         Fix the build.
2893
2894         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
2895         Apply the workaround that we use in other projects to WebKitTestRunner.
2896
2897         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
2898         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2899         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
2900
2901 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2902
2903         [Qt] Fix build after WTR AX support
2904         https://bugs.webkit.org/show_bug.cgi?id=72560
2905
2906         Reviewed by Geoffrey Garen.
2907
2908         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2909         * WebKitTestRunner/InjectedBundle/Target.pri:
2910
2911 2011-11-16  Tony Chang  <tony@chromium.org>
2912
2913         repurpose the flexbox bot for grid layout
2914         https://bugs.webkit.org/show_bug.cgi?id=72557
2915
2916         Reviewed by Ryosuke Niwa.
2917
2918         Since new flexbox is enabled everywhere, we don't need this bot
2919         anymore.  However, work on grid layout has begun, so we can use this
2920         bot to compile with ENABLE_CSS_GRID_LAYOUT.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
2923         the bot on the waterfall, I will change the slave config to enable
2924         the compile flag and tests.
2925
2926 2011-11-11  Adrienne Walker  <enne@google.com>
2927
2928         [chromium] Expose mock scrollbars to window.internals
2929         https://bugs.webkit.org/show_bug.cgi?id=72195
2930
2931         Reviewed by James Robinson.
2932
2933         Because mock scrollbars are a global setting, reset between runs.
2934
2935         * DumpRenderTree/chromium/WebPreferences.cpp:
2936         (WebPreferences::applyTo):
2937
2938 2011-11-16  James Robinson  <jamesr@chromium.org>
2939
2940         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
2941         https://bugs.webkit.org/show_bug.cgi?id=72562
2942
2943         Reviewed by Dirk Pranke.
2944
2945         * DumpRenderTree/chromium/TestShell.cpp:
2946         (TestShell::runFileTest):
2947
2948 2011-11-16  Tony Chang  <tony@chromium.org>
2949
2950         [NRWT] speculative fix for multiple subprocess test on cygwin
2951         https://bugs.webkit.org/show_bug.cgi?id=72518
2952
2953         Reviewed by Adam Barth.
2954
2955         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
2956             tries to emulate posix fd behavior.
2957         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2958
2959 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2960
2961         Revert r100509; change was committed twice (first time as r100491).
2962         Unreviewed, build fix.
2963
2964         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2965
2966 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
2967
2968         Run a dummy test in the gpu configurations if there's nothing to do.
2969         https://bugs.webkit.org/show_bug.cgi?id=72498
2970
2971         Reviewed by James Robinson.
2972
2973         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2974
2975 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         contributors_by_fuzzy_match is super slow
2978         https://bugs.webkit.org/show_bug.cgi?id=72540
2979
2980         Reviewed by Eric Seidel.
2981
2982         Make contributors_by_name do case insensitive search using a dictionary.
2983
2984         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
2985         because that's the most common case.
2986
2987         * Scripts/webkitpy/common/config/committers.py:
2988         * Scripts/webkitpy/common/config/committers_unittest.py:
2989
2990 2011-11-16  David Levin  <levin@chromium.org>
2991
2992         check-webkit-style should recognize functions even if they have OVERRIDE after them.
2993         https://bugs.webkit.org/show_bug.cgi?id=72515
2994
2995         Reviewed by Adam Barth.
2996
2997         * Scripts/webkitpy/style/checkers/cpp.py:
2998         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2999
3000 2011-11-16  Tony Chang  <tony@chromium.org>
3001
3002         [NRWT] refactor drivers to require pixel_tests param
3003         https://bugs.webkit.org/show_bug.cgi?id=72517
3004
3005         Reviewed by Ojan Vafai.
3006
3007         No tests, just a refactoring.
3008
3009         * Scripts/webkitpy/layout_tests/port/chromium.py:
3010         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3011         * Scripts/webkitpy/layout_tests/port/webkit.py:
3012         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3013
3014 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
3015
3016         Run a dummy test in the gpu configurations if there's nothing to do.
3017         https://bugs.webkit.org/show_bug.cgi?id=72498
3018
3019         Reviewed by James Robinson.
3020
3021         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3022
3023 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
3024
3025         WebKitTestRunner needs to support accessibility-related DRT APIs
3026         https://bugs.webkit.org/show_bug.cgi?id=42131
3027
3028         Reviewed by Beth Dakin.
3029
3030         Port the AX code in DRT to WKTestRunner by using IDL.
3031
3032         * DumpRenderTree/AccessibilityUIElement.cpp:
3033         (horizontalScrollbarCallback):
3034         (verticalScrollbarCallback):
3035         (AccessibilityUIElement::horizontalScrollbar):
3036         (AccessibilityUIElement::verticalScrollbar):
3037         (AccessibilityUIElement::getJSClass):
3038         * DumpRenderTree/AccessibilityUIElement.h:
3039         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3040         (AccessibilityUIElement::horizontalScrollbar):
3041         (AccessibilityUIElement::verticalScrollbar):
3042         * WebKitTestRunner/DerivedSources.make:
3043         * WebKitTestRunner/GNUmakefile.am:
3044         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
3045         (WTR::AccessibilityController::create):
3046         (WTR::AccessibilityController::AccessibilityController):
3047         (WTR::AccessibilityController::~AccessibilityController):
3048         (WTR::AccessibilityController::makeWindowObject):
3049         (WTR::AccessibilityController::wrapperClass):
3050         (WTR::AccessibilityController::rootElement):
3051         (WTR::AccessibilityController::focusedElement):
3052         (WTR::AccessibilityController::elementAtPoint):
3053         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
3054         (WTR::AccessibilityController::logFocusEvents):
3055         (WTR::AccessibilityController::logValueChangeEvents):
3056         (WTR::AccessibilityController::logScrollingStartEvents):
3057         (WTR::AccessibilityController::logAccessibilityEvents):
3058         (WTR::AccessibilityController::addNotificationListener):
3059         (WTR::AccessibilityController::notificationReceived):
3060         (WTR::AccessibilityController::resetToConsistentState):
3061         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
3062         (WTR::AccessibilityTextMarker::create):
3063         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3064         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
3065         (WTR::AccessibilityTextMarker::platformTextMarker):
3066         (WTR::AccessibilityTextMarker::wrapperClass):
3067         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
3068         (WTR::AccessibilityTextMarker::isEqual):
3069         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
3070         (WTR::AccessibilityTextMarkerRange::create):
3071         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3072         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3073         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
3074         (WTR::AccessibilityTextMarkerRange::wrapperClass):
3075         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
3076         (WTR::AccessibilityTextMarkerRange::isEqual):
3077         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
3078         (WTR::AccessibilityUIElement::create):
3079         (WTR::AccessibilityUIElement::wrapperClass):
3080         (WTR::AccessibilityUIElement::isValid):
3081         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3082         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
3083         (WTR::AccessibilityUIElement::isEqual):
3084         (WTR::AccessibilityUIElement::elementAtPoint):
3085         (WTR::AccessibilityUIElement::childAtIndex):
3086         (WTR::AccessibilityUIElement::indexOfChild):
3087         (WTR::AccessibilityUIElement::childrenCount):
3088         (WTR::AccessibilityUIElement::titleUIElement):
3089         (WTR::AccessibilityUIElement::parentElement):
3090         (WTR::AccessibilityUIElement::takeFocus):
3091         (WTR::AccessibilityUIElement::takeSelection):
3092         (WTR::AccessibilityUIElement::addSelection):
3093         (WTR::AccessibilityUIElement::removeSelection):
3094         (WTR::AccessibilityUIElement::allAttributes):
3095         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
3096         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3097         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
3098         (WTR::AccessibilityUIElement::attributesOfChildren):
3099         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
3100         (WTR::AccessibilityUIElement::increment):
3101         (WTR::AccessibilityUIElement::decrement):
3102         (WTR::AccessibilityUIElement::showMenu):
3103         (WTR::AccessibilityUIElement::press):
3104         (WTR::AccessibilityUIElement::stringAttributeValue):
3105         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3106         (WTR::AccessibilityUIElement::numberAttributeValue):
3107         (WTR::AccessibilityUIElement::boolAttributeValue):
3108         (WTR::AccessibilityUIElement::isAttributeSupported):
3109         (WTR::AccessibilityUIElement::isAttributeSettable):
3110         (WTR::AccessibilityUIElement::isActionSupported):
3111         (WTR::AccessibilityUIElement::role):
3112         (WTR::AccessibilityUIElement::subrole):
3113         (WTR::AccessibilityUIElement::roleDescription):
3114         (WTR::AccessibilityUIElement::title):
3115         (WTR::AccessibilityUIElement::description):
3116         (WTR::AccessibilityUIElement::language):
3117         (WTR::AccessibilityUIElement::stringValue):
3118         (WTR::AccessibilityUIElement::accessibilityValue):
3119         (WTR::AccessibilityUIElement::helpText):
3120         (WTR::AccessibilityUIElement::orientation):
3121         (WTR::AccessibilityUIElement::x):
3122         (WTR::AccessibilityUIElement::y):
3123         (WTR::AccessibilityUIElement::width):
3124         (WTR::AccessibilityUIElement::height):
3125         (WTR::AccessibilityUIElement::intValue):
3126         (WTR::AccessibilityUIElement::minValue):
3127         (WTR::AccessibilityUIElement::maxValue):
3128         (WTR::AccessibilityUIElement::valueDescription):
3129         (WTR::AccessibilityUIElement::insertionPointLineNumber):
3130         (WTR::AccessibilityUIElement::selectedTextRange):
3131         (WTR::AccessibilityUIElement::isEnabled):
3132         (WTR::AccessibilityUIElement::isRequired):
3133         (WTR::AccessibilityUIElement::isFocused):
3134         (WTR::AccessibilityUIElement::isFocusable):
3135         (WTR::AccessibilityUIElement::isSelected):
3136         (WTR::AccessibilityUIElement::isSelectable):
3137         (WTR::AccessibilityUIElement::isMultiSelectable):
3138         (WTR::AccessibilityUIElement::setSelectedChild):
3139         (WTR::AccessibilityUIElement::selectedChildrenCount):
3140         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3141         (WTR::AccessibilityUIElement::isExpanded):
3142         (WTR::AccessibilityUIElement::isChecked):
3143         (WTR::AccessibilityUIElement::isVisible):
3144         (WTR::AccessibilityUIElement::isOffScreen):
3145         (WTR::AccessibilityUIElement::isCollapsed):
3146         (WTR::AccessibilityUIElement::isIgnored):
3147         (WTR::AccessibilityUIElement::hasPopup):
3148         (WTR::AccessibilityUIElement::hierarchicalLevel):
3149         (WTR::AccessibilityUIElement::clickPointX):
3150         (WTR::AccessibilityUIElement::clickPointY):
3151         (WTR::AccessibilityUIElement::documentEncoding):
3152         (WTR::AccessibilityUIElement::documentURI):
3153         (WTR::AccessibilityUIElement::url):
3154         (WTR::AccessibilityUIElement::speak):
3155         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3156         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3157         (WTR::AccessibilityUIElement::attributesOfColumns):
3158         (WTR::AccessibilityUIElement::attributesOfRows):
3159         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3160         (WTR::AccessibilityUIElement::attributesOfHeader):
3161         (WTR::AccessibilityUIElement::indexInTable):
3162         (WTR::AccessibilityUIElement::rowIndexRange):
3163         (WTR::AccessibilityUIElement::columnIndexRange):
3164         (WTR::AccessibilityUIElement::rowCount):
3165         (WTR::AccessibilityUIElement::columnCount):
3166         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3167         (WTR::AccessibilityUIElement::disclosedByRow):
3168         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3169         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3170         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3171         (WTR::AccessibilityUIElement::ariaIsGrabbed):
3172         (WTR::AccessibilityUIElement::ariaDropEffects):
3173         (WTR::AccessibilityUIElement::lineForIndex):
3174         (WTR::AccessibilityUIElement::rangeForLine):
3175         (WTR::AccessibilityUIElement::boundsForRange):
3176         (WTR::AccessibilityUIElement::setSelectedTextRange):
3177         (WTR::AccessibilityUIElement::stringForRange):
3178         (WTR::AccessibilityUIElement::attributedStringForRange):
3179         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3180         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3181         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3182         (WTR::AccessibilityUIElement::horizontalScrollbar):
3183         (WTR::AccessibilityUIElement::verticalScrollbar):
3184         (WTR::AccessibilityUIElement::addNotificationListener):
3185         (WTR::AccessibilityUIElement::removeNotificationListener):
3186         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3187         (WTR::AccessibilityUIElement::textMarkerRangeLength):
3188         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3189         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3190         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3191         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3192         (WTR::AccessibilityUIElement::textMarkerForPoint):
3193         (WTR::AccessibilityUIElement::previousTextMarker):
3194         (WTR::AccessibilityUIElement::nextTextMarker):
3195         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3196         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
3197         (WTR::AccessibilityUIElement::platformUIElement):
3198         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
3199         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
3200         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
3201         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
3202         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3204         (WTR::InjectedBundle::beginTesting):
3205         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3206         (WTR::InjectedBundle::accessibilityController):
3207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3208         (WTR::InjectedBundlePage::didClearWindowForFrame):
3209         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3210         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
3211         (WTR::LayoutTestController::platformName):
3212         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
3213         (WTR::AccessibilityTextMarker::isEqual):
3214         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
3215         (WTR::AccessibilityTextMarkerRange::isEqual):
3216         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
3217         (+[NSString stringWithJSStringRef:]):
3218         (-[NSString createJSStringRef]):
3219         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
3220         (-[AccessibilityNotificationHandler dealloc]):
3221         (-[AccessibilityNotificationHandler _notificationReceived:]):
3222         (-[AccessibilityNotificationHandler setCallback:]):
3223         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3224         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
3225         (WTR::AccessibilityUIElement::isEqual):
3226         (WTR::descriptionOfValue):
3227         (WTR::attributesOfElement):
3228         (WTR::concatenateAttributeAndValue):
3229         (WTR::convertNSArrayToVector):
3230         (WTR::descriptionOfElements):
3231         (WTR::AccessibilityUIElement::getLinkedUIElements):
3232         (WTR::AccessibilityUIElement::getDocumentLinks):
3233         (WTR::AccessibilityUIElement::getChildren):
3234         (WTR::AccessibilityUIElement::getChildrenWithRange):
3235         (WTR::AccessibilityUIElement::childrenCount):
3236         (WTR::AccessibilityUIElement::elementAtPoint):
3237         (WTR::AccessibilityUIElement::indexOfChild):
3238         (WTR::AccessibilityUIElement::childAtIndex):
3239         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3240         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3241         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3242         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3243         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3244         (WTR::AccessibilityUIElement::selectedChildrenCount):
3245         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3246         (WTR::AccessibilityUIElement::titleUIElement):
3247         (WTR::AccessibilityUIElement::parentElement):
3248         (WTR::AccessibilityUIElement::disclosedByRow):
3249         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
3250         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
3251         (WTR::AccessibilityUIElement::attributesOfChildren):
3252         (WTR::AccessibilityUIElement::allAttributes):
3253         (WTR::AccessibilityUIElement::stringAttributeValue):
3254         (WTR::AccessibilityUIElement::numberAttributeValue):
3255         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3256         (WTR::AccessibilityUIElement::boolAttributeValue):
3257         (WTR::AccessibilityUIElement::isAttributeSettable):
3258         (WTR::AccessibilityUIElement::isAttributeSupported):
3259         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
3260         (WTR::AccessibilityUIElement::role):
3261         (WTR::AccessibilityUIElement::subrole):
3262         (WTR::AccessibilityUIElement::roleDescription):
3263         (WTR::AccessibilityUIElement::title):
3264         (WTR::AccessibilityUIElement::description):
3265         (WTR::AccessibilityUIElement::orientation):
3266         (WTR::AccessibilityUIElement::stringValue):
3267         (WTR::AccessibilityUIElement::language):
3268         (WTR::AccessibilityUIElement::helpText):
3269         (WTR::AccessibilityUIElement::x):
3270         (WTR::AccessibilityUIElement::y):
3271         (WTR::AccessibilityUIElement::width):
3272         (WTR::AccessibilityUIElement::height):
3273         (WTR::AccessibilityUIElement::clickPointX):
3274         (WTR::AccessibilityUIElement::clickPointY):
3275         (WTR::AccessibilityUIElement::intValue):
3276         (WTR::AccessibilityUIElement::minValue):
3277         (WTR::AccessibilityUIElement::maxValue):
3278         (WTR::AccessibilityUIElement::valueDescription):
3279         (WTR::AccessibilityUIElement::insertionPointLineNumber):
3280         (WTR::AccessibilityUIElement::isActionSupported):
3281         (WTR::AccessibilityUIElement::isEnabled):
3282         (WTR::AccessibilityUIElement::isRequired):
3283         (WTR::AccessibilityUIElement::isFocused):
3284         (WTR::AccessibilityUIElement::isSelected):
3285         (WTR::AccessibilityUIElement::isExpanded):
3286         (WTR::AccessibilityUIElement::isChecked):
3287         (WTR::AccessibilityUIElement::hierarchicalLevel):
3288         (WTR::AccessibilityUIElement::speak):
3289         (WTR::AccessibilityUIElement::ariaIsGrabbed):
3290         (WTR::AccessibilityUIElement::ariaDropEffects):
3291         (WTR::AccessibilityUIElement::lineForIndex):
3292         (WTR::AccessibilityUIElement::rangeForLine):
3293         (WTR::AccessibilityUIElement::boundsForRange):
3294         (WTR::AccessibilityUIElement::stringForRange):
3295         (WTR::AccessibilityUIElement::attributedStringForRange):
3296         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3297         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3298         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3299         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3300         (WTR::AccessibilityUIElement::attributesOfColumns):
3301         (WTR::AccessibilityUIElement::attributesOfRows):
3302         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3303         (WTR::AccessibilityUIElement::attributesOfHeader):
3304         (WTR::AccessibilityUIElement::rowCount):
3305         (WTR::AccessibilityUIElement::columnCount):
3306         (WTR::AccessibilityUIElement::indexInTable):
3307         (WTR::AccessibilityUIElement::rowIndexRange):
3308         (WTR::AccessibilityUIElement::columnIndexRange):
3309         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3310         (WTR::AccessibilityUIElement::horizontalScrollbar):
3311         (WTR::AccessibilityUIElement::verticalScrollbar):
3312         (WTR::AccessibilityUIElement::selectedTextRange):
3313         (WTR::AccessibilityUIElement::setSelectedTextRange):
3314         (WTR::AccessibilityUIElement::increment):
3315         (WTR::AccessibilityUIElement::decrement):
3316         (WTR::AccessibilityUIElement::showMenu):
3317         (WTR::AccessibilityUIElement::press):
3318         (WTR::AccessibilityUIElement::setSelectedChild):
3319         (WTR::AccessibilityUIElement::accessibilityValue):
3320         (WTR::AccessibilityUIElement::documentEncoding):
3321         (WTR::AccessibilityUIElement::documentURI):
3322         (WTR::AccessibilityUIElement::url):
3323         (WTR::AccessibilityUIElement::addNotificationListener):
3324         (WTR::AccessibilityUIElement::removeNotificationListener):
3325         (WTR::AccessibilityUIElement::isFocusable):
3326         (WTR::AccessibilityUIElement::isSelectable):
3327         (WTR::AccessibilityUIElement::isMultiSelectable):
3328         (WTR::AccessibilityUIElement::isVisible):
3329         (WTR::AccessibilityUIElement::isOffScreen):
3330         (WTR::AccessibilityUIElement::isCollapsed):
3331         (WTR::AccessibilityUIElement::isIgnored):
3332         (WTR::AccessibilityUIElement::hasPopup):
3333         (WTR::AccessibilityUIElement::takeFocus):
3334         (WTR::AccessibilityUIElement::takeSelection):
3335         (WTR::AccessibilityUIElement::addSelection):
3336         (WTR::AccessibilityUIElement::removeSelection):
3337         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3338         (WTR::AccessibilityUIElement::textMarkerRangeLength):
3339         (WTR::AccessibilityUIElement::previousTextMarker):
3340         (WTR::AccessibilityUIElement::nextTextMarker):
3341         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3342         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3343         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3344         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3345         (WTR::AccessibilityUIElement::textMarkerForPoint):
3346         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3347         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3348         (WTR::LayoutTestController::platformName):
3349         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3350         (WTR::LayoutTestController::platformName):
3351         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3352         (WTR::LayoutTestController::platformName):
3353         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3354         * WebKitTestRunner/win/InjectedBundle.vcproj:
3355
3356 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3357
3358         [Qt] Fix use of config.tests
3359
3360         We were checking @buildArgs to determine if the optional argument was
3361         passed or not, but this is not the right way to do that in Perl. The
3362         right way is to not use a prototype for the function, and to pass
3363         the list as a reference (to avoid list expansion). That way we can
3364         check the number of arguments, and choose the right code path based
3365         on that.
3366
3367         We were also missing a default-value of 0 for any feature that's not
3368         set in features.prf.
3369
3370         Reviewed by Kenneth Rohde Christiansen.
3371
3372         * Scripts/build-webkit:
3373         * Scripts/webkitdirs.pm:
3374         (qtFeatureDefaults):
3375         (buildQMakeProject):
3376
3377 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3378
3379         [Qt] Prospective fix for broken plugin tests
3380
3381         Don't hide symbols for the NPAPI test plugin
3382
3383         Rubber-stamped by Andreas Kling.
3384
3385         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3386
3387 2011-11-16  Adam Roben  <aroben@apple.com>
3388
3389         Move filenames/line numbers off to the right edge in Leaks Viewer
3390
3391         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
3392         because filenames/line numbers are right next to function names
3393
3394         Reviewed by Andreas Kling.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
3397         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
3398         function name. Use the filename as the profile node's URL (we don't have enough info to
3399         compute a real URL currently) and the line number as the profile node's line number so the
3400         Inspector code will put them on the right side of the callstack graph.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3403         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
3404         passed here, just filenames.
3405
3406         (WebInspector.linkifyURLAsNode):
3407         (WebInspector.linkifyResourceAsNode):
3408         Copied and slightly modified from inspector.js.
3409
3410 2011-11-16  Adam Roben  <aroben@apple.com>
3411
3412         Make Leaks Viewer load builds from the new Lion Leaks bot
3413
3414         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
3415
3416         Reviewed by Andreas Kling.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3419         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
3420         SnowLeopard one.
3421
3422 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3423
3424         [EFL] Clean up the offline apps-related functions in ewk_settings.
3425         https://bugs.webkit.org/show_bug.cgi?id=72132
3426
3427         Reviewed by Kenneth Rohde Christiansen.
3428
3429         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
3430         prefixes for code that is related only to the HTML5 app cache
3431         features.
3432
3433         Use `ewk_settings_application_cache' and
3434         `ewk_view_setting_application_cache' instead.
3435
3436         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3437         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3438
3439 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
3440
3441         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
3442
3443         Reviewed by Tor Arne Vestbø.
3444
3445         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
3446         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
3447         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
3448         removes the .so.0.0.0 and just produces .so.
3449
3450 2011-11-16  Peter Beverloo  <peter@chromium.org>
3451
3452         Explicitly include unistd.h in TestNetscapePlugIn
3453         https://bugs.webkit.org/show_bug.cgi?id=72385
3454
3455         This is needed for the sleep() call in the indicateTestFailure method,
3456         which seems to be implicitly available for other platforms. This is not
3457         the case on Android.
3458
3459         Reviewed by Steve Block.
3460
3461         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3462
3463 2011-11-16  Peter Beverloo  <peter@chromium.org>
3464
3465         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
3466         https://bugs.webkit.org/show_bug.cgi?id=72384
3467
3468         Update to Android NDK r7, which was released last Friday. This adds
3469         support for RTTI and the -mimplicit-it gcc flag, which are required to
3470         respectively build ICU and Skia.
3471
3472         Reviewed by Steve Block.
3473
3474         * Scripts/update-webkit-chromium:
3475         * Scripts/webkitdirs.pm:
3476         (buildChromiumMakefile):
3477
3478 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
3479
3480         Unreviewed, rolling out r100266.
3481         http://trac.webkit.org/changeset/100266
3482
3483         Broke WTR.
3484
3485         * qmake/mkspecs/features/default_post.prf:
3486
3487 2011-11-16  Eric Seidel  <eric@webkit.org>
3488
3489         check-webkit-style broken by r99773: "Could not determine the port"
3490         https://bugs.webkit.org/show_bug.cgi?id=72275
3491
3492         Reviewed by Adam Barth.
3493
3494         I will continue engaging hacks, until windows improves.
3495
3496         * Scripts/webkitpy/common/host.py:
3497          - Host uses self.executive instead of self._executive like Port does.
3498          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
3499
3500 2011-11-16  Eric Seidel  <eric@webkit.org>
3501
3502         check-webkit-style broken by r99773: "Could not determine the port"
3503         https://bugs.webkit.org/show_bug.cgi?id=72275
3504
3505         Reviewed by Adam Barth.
3506
3507         Engage windows hacks harder.
3508
3509         This is a speculative fix for ChromiumWin.  We're now
3510         creating an SCM object much earlier, so we need to
3511         engage our "awesome" windows hacks earlier.
3512
3513         * Scripts/webkitpy/common/host.py:
3514         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3515
3516 2011-11-15  Darin Adler  <darin@apple.com>
3517
3518         DRT's uiElementAttributeValueCallback function is leaky
3519         https://bugs.webkit.org/show_bug.cgi?id=72453
3520
3521         Reviewed by Dan Bernstein.
3522
3523         * DumpRenderTree/AccessibilityUIElement.cpp:
3524         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
3525
3526 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
3527
3528         Implement edit-distance based reviewer recognition algorithm
3529         https://bugs.webkit.org/show_bug.cgi?id=72351
3530
3531         Reviewed by Eric Seidel.
3532
3533         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
3534         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
3535         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
3536         "build fix" to a reviewer's name (e.g. with with edit distance 9).
3537
3538         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
3539         the edit distance is implemented in edit_distance.py.
3540
3541         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
3542         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
3543
3544         * Scripts/webkitpy/common/checkout/changelog.py:
3545         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3546         * Scripts/webkitpy/common/config/committers.py:
3547         * Scripts/webkitpy/common/config/committers_unittest.py:
3548         * Scripts/webkitpy/common/editdistance.py: Added.
3549         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
3550         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3551         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
3552
3553 2011-11-15  Tony Chang  <tony@chromium.org>
3554
3555         Skip a failing webkitpy test on cygwin.
3556
3557         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3558
3559 2011-11-15  Sam Weinig  <sam@webkit.org>
3560
3561         TestWebKitAPI should not put its resources in the root products directory
3562         https://bugs.webkit.org/show_bug.cgi?id=72446
3563
3564         Reviewed by Anders Carlsson.
3565
3566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3567         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
3568         directory.
3569
3570         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3571         (TEST_F):
3572         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3575         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3576         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3577         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
3578         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3579         (TestWebKitAPI::Util::createURLForResource):
3580         Update calls to retrieve files from the bundle to look in the newly
3581         created subdirectory.
3582
3583 2011-11-15  Tony Chang  <tony@chromium.org>
3584
3585         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
3586
3587         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3588
3589 2011-11-15  Tony Chang  <tony@chromium.org>
3590
3591         Unreviewed, fix test-webkitpy tests.  Move the check for image results
3592         earlier.
3593
3594         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3595         * Scripts/webkitpy/layout_tests/port/webkit.py:
3596
3597 2011-11-15  James Robinson  <jamesr@chromium.org>
3598
3599         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
3600         https://bugs.webkit.org/show_bug.cgi?id=72444
3601
3602         Reviewed by Adam Barth.
3603
3604         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3605
3606 2011-11-15  Tony Chang  <tony@chromium.org>
3607
3608         Unreviewed, better fix for ref tests failures on SL Intel bot.
3609         Revert the previous change and return None if pixel results from
3610         either the test page or the expected page is missing.
3611