REGRESSION(183583): [Mac] make without SDKROOT has issues
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2
3         REGRESSION(183583): [Mac] make without SDKROOT has issues
4         https://bugs.webkit.org/show_bug.cgi?id=144431
5
6         Reviewed by Dan Bernstein.
7
8         * Makefile:
9         * WebKitTestRunner/Makefile:
10         Assume an empty SDKROOT means an macosx variant, so only
11         enable settings if the SDKROOT is not empty and does not
12         contain "macosx".
13
14 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
15
16         Expand test infrastructure to support scrolling tests
17         https://bugs.webkit.org/show_bug.cgi?id=143684
18         <rdar://problem/20375516>
19
20         Reviewed by Simon Fraser.
21
22         * DumpRenderTree/mac/DumpRenderTree.mm:
23         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
24         reset before the next test run.
25         * WebKitTestRunner/TestController.cpp:
26         (WTR::TestController::resetStateToConsistentValues): Ditto."
27
28 2015-04-29  Alex Christensen  <achristensen@webkit.org>
29
30         Run javascriptcore tests on Windows without cygwin
31         https://bugs.webkit.org/show_bug.cgi?id=144419
32
33         Reviewed by Brent Fulgham.
34
35         * Scripts/run-javascriptcore-tests:
36         (runJSCStressTests):
37         Just call ruby, not /usr/bin/env ruby.
38
39 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
40
41         [GTK] Add --enable-shared option to LLVM to build mesa
42         https://bugs.webkit.org/show_bug.cgi?id=144393
43
44         Reviewed by Martin Robinson.
45
46         The updated mesa requires the shared LLVM libraries.
47         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
48         to LLVM configure script. It will provide shared libraries in addition to static libraries.
49
50         * gtk/jhbuild-optional.modules:
51
52 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
53
54         [GTK] Add support for automatic hyphenation
55         https://bugs.webkit.org/show_bug.cgi?id=44478
56
57         Reviewed by Carlos Garcia Campos.
58
59         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
60         all systems will use the same dictionaries for testing purposes.
61
62 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
63
64         Failure when building WebKit for appletvsimulator.
65         https://bugs.webkit.org/show_bug.cgi?id=144356
66
67         Reviewed by Alexey Proskuryakov.
68
69         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
70         make TVOS and WatchOS behave correctly.
71
72         * Makefile:
73         * WebKitTestRunner/Makefile:
74
75 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
76
77         Use-after-free when invalidating WKPageForceRepaint callback
78         https://bugs.webkit.org/show_bug.cgi?id=144401
79         rdar://problem/20741111
80
81         Reviewed by Tim Horton.
82
83         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
84
85         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
86         Don't do anything on error, because the context may be a stale pointer now.
87
88 2015-04-29  David Kilzer  <ddkilzer@apple.com>
89
90         check-webkit-style: Don't complain about returning value from Objective-C method call in header
91         <http://webkit.org/b/144395>
92
93         Reviewed by Andy Estes.
94
95         * Scripts/webkitpy/style/checkers/cpp.py:
96         (check_spacing): Update regex so 'return' is ignored if it
97         precedes the whitespace and bracket.  Change category name to
98         'whitespace/brackets'.  Add period to error message.
99         (CppChecker): Add 'whitespace/brackets' as a category.
100         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
101         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
102         'CppChecker.categories' since that's where the list lives now.
103         (CppStyleTest.test_spacing_before_brackets): Add tests for
104         'whitespace/brackets' issues and non-issues.
105
106 2015-04-29  Alex Christensen  <achristensen@webkit.org>
107
108         Fix WinCairo bot.
109
110         * Scripts/webkitdirs.pm:
111         (determinePassedConfiguration):
112         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
113
114 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
115
116         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
117         https://bugs.webkit.org/show_bug.cgi?id=132159
118
119         Reviewed by Darin Adler.
120
121         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
122         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
123
124         * DumpRenderTree/mac/DumpRenderTree.mm:
125         (fontWhitelist):
126         (adjustFonts):
127         (createWebViewAndOffscreenWindow):
128         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
129         (WTR::activateFonts):
130         * WebKitTestRunner/mac/TestControllerMac.mm:
131         (WTR::allowedFontFamilySet):
132         (WTR::systemHiddenFontFamilySet):
133         (WTR::generateWhitelist):
134         (WTR::TestController::platformInitializeContext):
135
136 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
137
138         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
139         https://bugs.webkit.org/show_bug.cgi?id=144155
140
141         Reviewed by Andreas Kling.
142
143         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
144         Make sure that test window is "visible" before each test. While there is no concrete
145         evidence that this is the problem indeed, the behavior is consistent with what would
146         happen for an invisible window. Also, WKTR obviously needs to do this to protect
147         against potential buggy tests that hide the window and don't show it.
148
149 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
150
151         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
152
153         Latest changes in the inspector UI made this test fail. We were
154         relying that the sidebar was always visible and the first 'li'
155         element of the inspector was the one containing the title. This is
156         no longer true, so better use document title that is not likely
157         to change.
158
159         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
160         (openRemoteDebuggingSession):
161
162 2015-04-29  Andres Gomez  <agomez@igalia.com>
163
164         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
165
166         * Scripts/webkitpy/common/config/contributors.json:
167
168 2015-04-29  Andres Gomez  <agomez@igalia.com>
169
170         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
171
172         * Scripts/webkitpy/common/config/watchlist:
173
174 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
175
176         [EFL] Allow to run the tests on the native X display
177         https://bugs.webkit.org/show_bug.cgi?id=144247
178
179         Reviewed by Gyuyoung Kim.
180
181         Added the USE_NATIVE_XDISPLAY option for the WTR.
182         We can select the Xorg driver if environment variable is set up before running the tests.
183
184         * Scripts/webkitpy/port/efl.py:
185         (EflPort._driver_class):
186
187 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
188
189         [GTK] Add libnotify-dev in gtk install-dependencies
190         https://bugs.webkit.org/show_bug.cgi?id=144379
191
192         Reviewed by Žan Doberšek.
193
194         * gtk/install-dependencies:
195
196 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
197
198         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
199         https://bugs.webkit.org/show_bug.cgi?id=143001
200
201         Reviewed by Gyuyoung Kim.
202
203         * WebKitTestRunner/TestController.cpp:
204         (WTR::shouldUseFixedLayout):
205
206 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
207
208         Increase stablility of run-benchmark script
209         https://bugs.webkit.org/show_bug.cgi?id=144361
210
211         Reviewed by Ryosuke Niwa.
212
213         * Scripts/run-benchmark:
214         (main):
215         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
216         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
217         (GenericBenchmarkBuilder.clean):
218         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
219         (BenchmarkRunner.__init__):
220         (BenchmarkRunner.execute):
221         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
222         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
223         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
224         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
225         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
226         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
227         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
228         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
229         (HTTPServerDriver.fetchResult):
230         (HTTPServerDriver):
231         (HTTPServerDriver.killServer): Add kill server interface.
232         (HTTPServerDriver.getReturnCode): Add get return code interface.
233         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
234         (SimpleHTTPServerDriver.serve):
235         (SimpleHTTPServerDriver.fetchResult):
236         (SimpleHTTPServerDriver):
237         (SimpleHTTPServerDriver.killServer):
238         (SimpleHTTPServerDriver.getReturnCode):
239         * Scripts/webkitpy/benchmark_runner/utils.py:
240         (forceRemove): Provide python version of 'rm -rf'.
241
242 2015-04-28  Sam Weinig  <sam@webkit.org>
243
244         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
245         https://bugs.webkit.org/show_bug.cgi?id=144363
246
247         Reviewed by Alex Christensen.
248
249         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
250         (TestWebKitAPI::createNFAs):
251         (TestWebKitAPI::TEST_F):
252         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
253         (TestWebKitAPI::countLiveNodes):
254         (TestWebKitAPI::createNFAs):
255         (TestWebKitAPI::buildDFAFromPatterns):
256         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
257
258 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
259
260         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
261         https://bugs.webkit.org/show_bug.cgi?id=144304
262
263         Reviewed by Geoffrey Garen.
264
265         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
266         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
267         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
268
269 2015-04-28  Commit Queue  <commit-queue@webkit.org>
270
271         Unreviewed, rolling out r183514.
272         https://bugs.webkit.org/show_bug.cgi?id=144359
273
274         It broke cloop test bots (Requested by mcatanzaro on #webkit).
275
276         Reverted changeset:
277
278         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
279         https://bugs.webkit.org/show_bug.cgi?id=144304
280         http://trac.webkit.org/changeset/183514
281
282 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
283
284         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
285         https://bugs.webkit.org/show_bug.cgi?id=144304
286
287         Reviewed by Geoffrey Garen.
288
289         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
290         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
291         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
292         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
293
294 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
295
296         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
297         https://bugs.webkit.org/show_bug.cgi?id=144319
298
299         Reviewed by Csaba Osztrogonác.
300
301         * TestWebKitAPI/CMakeLists.txt:
302         * TestWebKitAPI/PlatformEfl.cmake:
303
304 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
305
306         Fix common typo "targetting" => "targeting"
307         https://bugs.webkit.org/show_bug.cgi?id=144349
308
309         Reviewed by Daniel Bates.
310
311         * Scripts/webkitdirs.pm:
312         (execMacWebKitAppForDebugging):
313
314 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
315
316         [GTK][jhbuild] Mesa build failure with llvm 3.6
317         https://bugs.webkit.org/show_bug.cgi?id=144250
318
319         Reviewed by Žan Doberšek.
320
321         Bump the version of Mesa to 10.5.4
322
323         * gtk/jhbuild.modules:
324
325 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
326
327         Disable App Nap in WebKitTestRunner UI process
328         https://bugs.webkit.org/show_bug.cgi?id=144308
329
330         Reviewed by Daniel Bates.
331
332         * WebKitTestRunner/mac/main.mm:
333         (disableAppNapInUIProcess):
334         (main):
335
336 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
337
338         [GTK] Update JHBuild Mesa download directory
339         https://bugs.webkit.org/show_bug.cgi?id=144318
340
341         Update the download directory of Mesa module since the previous one
342         doesn't exist any more.
343
344         Reviewed by Žan Doberšek.
345
346         * gtk/jhbuild.modules:
347
348 2015-04-28  Commit Queue  <commit-queue@webkit.org>
349
350         Unreviewed, rolling out r183477.
351         https://bugs.webkit.org/show_bug.cgi?id=144334
352
353         Roll back the Mesa dependency bump in fear of uncaught
354         regressions while the testing bots are no-op. (Requested by
355         zdobersek on #webkit).
356
357         Reverted changeset:
358
359         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
360         https://bugs.webkit.org/show_bug.cgi?id=144250
361         http://trac.webkit.org/changeset/183477
362
363 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
364
365         [GTK][jhbuild] Mesa build failure with llvm 3.6
366         https://bugs.webkit.org/show_bug.cgi?id=144250
367
368         Reviewed by Žan Doberšek.
369
370         Bump the version of Mesa to 10.5.4
371
372         * gtk/jhbuild.modules:
373
374 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
375
376         Add '__init__.py' and fix known bug in benchmark runner.
377         https://bugs.webkit.org/show_bug.cgi?id=144296
378
379         Reviewed by Ryosuke Niwa
380
381         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
382         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
383         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
384         (BenchmarkRunner.__init__):
385         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
386         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
387         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
388
389 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
390
391         More build fix.
392
393         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
394         (-[AccessibilityNotificationHandler _notificationReceived:]):
395         Use -objectForKey:, not array subscript.
396
397 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
398
399         Catch unexpected exits in DumpRenderTree
400         https://bugs.webkit.org/show_bug.cgi?id=144288
401
402         Reviewed by Tim Horton.
403
404         * DumpRenderTree/mac/DumpRenderTree.mm:
405         (atexitFunction):
406         (DumpRenderTreeMain):
407
408 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
409
410         Build fix
411
412         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
413         (-[AccessibilityNotificationHandler _notificationReceived:]):
414         Use -objectForKey:, not array subscript.
415
416 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
417
418         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
419         https://bugs.webkit.org/show_bug.cgi?id=144155
420
421         Reviewed by Tim Horton.
422
423         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
424         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
425         and we clearly don't want App Nap while testing.
426
427 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
428
429         [CMake] Autogenerate cmakeconfig.h.cmake
430         https://bugs.webkit.org/show_bug.cgi?id=143997
431
432         Reviewed by Csaba Osztrogonác.
433
434         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
435         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
436
437 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
438
439         REGRESSION(r182879): Images and video can no longer be downloaded
440         https://bugs.webkit.org/show_bug.cgi?id=144267
441         <rdar://problem/20702844>
442
443         Reviewed by Simon Fraser.
444
445         Revise tests to check for proper download menu state.
446         1. Downloading a loal image should be disabled.
447         2. Downloading a local media file should be disabled.
448         3. Downloading non-downloadable media should be disabled.
449
450         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
451         (TestWebKitAPI::TEST):
452
453 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
454
455         Merge run-launcher into run-minibrowser
456         https://bugs.webkit.org/show_bug.cgi?id=141928
457
458         Reviewed by Darin Adler.
459
460         * Scripts/run-iexploder-tests:
461         (runSafariWithIExploder):
462         * Scripts/run-launcher: Removed.
463         * Scripts/run-minibrowser:
464         * Scripts/webkitdirs.pm:
465         (launcherPath):
466         * Scripts/webkitpy/port/efl.py:
467         (EflPort.show_results_html_file):
468         * Scripts/webkitpy/port/efl_unittest.py:
469         (EflPortTest.test_show_results_html_file):
470         * Scripts/webkitpy/port/gtk.py:
471         (GtkPort.print_leaks_summary):
472         (GtkPort.show_results_html_file):
473         (GtkPort): Deleted.
474         * Scripts/webkitpy/port/gtk_unittest.py:
475         (GtkPortTest.test_show_results_html_file):
476
477 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
478
479         [buildbot] Fix the output of perf-test buildstep on timeout
480         https://bugs.webkit.org/show_bug.cgi?id=144097
481
482         Reviewed by Ryosuke Niwa.
483
484         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
485         (RunAndUploadPerfTests.getText2):
486         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
487         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
488         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
489
490 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
491
492         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
493         https://bugs.webkit.org/show_bug.cgi?id=143874
494
495         Reviewed by Gyuyoung Kim.
496
497         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
498
499 2015-04-24  Philippe Normand  <pnormand@igalia.com>
500
501         [JHBuild] Move to upstream OpenWebRTC
502         https://bugs.webkit.org/show_bug.cgi?id=144145
503
504         Reviewed by Carlos Garcia Campos.
505
506         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
507         and add a new simple patch to gst-plugins-base, required for
508         OpenWebRTC build.
509         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
510         * gtk/jhbuild.modules: Ditto.
511         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
512
513 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
514
515         [ES6] Implement ES6 template literals
516         https://bugs.webkit.org/show_bug.cgi?id=142691
517
518         Reviewed by Darin Adler.
519
520         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
521
522         * Scripts/webkitperl/FeatureList.pm:
523
524 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
525
526         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
527         https://bugs.webkit.org/show_bug.cgi?id=144217
528
529         Reviewed by Darin Adler.
530
531         * WebKitTestRunner/PlatformEfl.cmake:
532
533 2015-04-26  Doug Russell  <d_russell@apple.com>
534
535         AX: richer text change notifications (142719)
536         https://bugs.webkit.org/show_bug.cgi?id=142719
537
538         Reviewed by Darin Adler.
539
540         Richer accessibility value change notifications. Introduce AXTextEditType,
541         postTextStateChangeNotification and postTextReplacementNotification to give assistive
542         tech apps more reliable context for responding to changes in web content. Also implement
543         a mechanism to post value changes in password form fields in coalesced ticks to thwart
544         analyzing the cadence of changes.
545
546         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
547         and an overload of postTextReplacementNotification to give assistive tech apps more
548         reliable context for responding to changes in web content selection. Also block posting
549         selection changes on password fields.
550
551         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
552         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
553         (-[AccessibilityNotificationHandler stopObserving]):
554         (-[AccessibilityNotificationHandler _notificationReceived:]):
555         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
556         (AccessibilityUIElement::removeNotificationListener):
557         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
558         (-[AccessibilityNotificationHandler _notificationReceived:]):
559         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
560         (WTR::AccessibilityUIElement::removeNotificationListener):
561
562 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
563
564         Add myself to contributors.json
565         https://bugs.webkit.org/show_bug.cgi?id=144204
566
567         Reviewed by Darin Adler.
568
569         * Scripts/webkitpy/common/config/contributors.json:
570
571 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
572
573         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
574         https://bugs.webkit.org/show_bug.cgi?id=144182
575
576         Reviewed by Simon Fraser.
577
578         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
579
580 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
581
582         https://bugs.webkit.org/show_bug.cgi?id=144038
583
584         Reviewed by Ryosuke Niwa
585
586         Add a script to run Speedometer and JetStream on a browser.
587
588         * Scripts/run-benchmark: Wrapper script to run benchmark.
589         (main):
590         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
591         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
592         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
593         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
594         (BenchmarkBuilderFactory):
595         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
596         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
597         (GenericBenchmarkBuilder):
598         (GenericBenchmarkBuilder.prepare):
599         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
600         (GenericBenchmarkBuilder._applyPatch):
601         (GenericBenchmarkBuilder.clean):
602         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
603         (JetStreamBenchmarkBuilder):
604         (JetStreamBenchmarkBuilder.prepare):
605         (JetStreamBenchmarkBuilder._runCreateScript):
606         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
607         (BenchmarkRunner):
608         (BenchmarkRunner.__init__):
609         (BenchmarkRunner.execute):
610         (BenchmarkRunner.dump):
611         (BenchmarkRunner.wrap):
612         (BenchmarkRunner.merge):
613         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
614         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
615         (BrowserDriver):
616         (BrowserDriver.prepareEnv):
617         (BrowserDriver.launchUrl):
618         (BrowserDriver.closeBrowser):
619         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
620         (BrowserDriverFactory):
621         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
622         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
623         (OSXChromeDriver):
624         (OSXChromeDriver.prepareEnv):
625         (OSXChromeDriver.launchUrl):
626         (OSXChromeDriver.closeBrowsers):
627         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
628         (OSXSafariDriver):
629         (OSXSafariDriver.prepareEnv):
630         (OSXSafariDriver.launchUrl):
631         (OSXSafariDriver.closeBrowsers):
632         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
633         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
634         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
635         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
636         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
637         (GenericFactory):
638         (GenericFactory.iterateGetItem):
639         (GenericFactory.create):
640         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
641         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
642         (ServerControl):
643         (ServerControl.render_GET):
644         (ServerControl.render_POST):
645         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
646         (HTTPServerDriver):
647         (HTTPServerDriver.serve):
648         (HTTPServerDriver.fetchResult):
649         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
650         (HTTPServerDriverFactory):
651         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
652         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
653         (SimpleHTTPServerDriver):
654         (SimpleHTTPServerDriver.depends):
655         (SimpleHTTPServerDriver.__init__):
656         (SimpleHTTPServerDriver.serve):
657         (SimpleHTTPServerDriver.baseUrl):
658         (SimpleHTTPServerDriver.fetchResult):
659         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
660         (ModuleNotFoundError):
661         (loadModule):
662         (getPathFromProjectRoot):
663         (loadJSONFromFile):
664         (TimeoutError):
665         (timeout):
666         (timeout.__init__):
667         (timeout.handle_timeout):
668         (timeout.__enter__):
669         (timeout.__exit__):
670
671 2015-04-24  Commit Queue  <commit-queue@webkit.org>
672
673         Unreviewed, rolling out r183303.
674         https://bugs.webkit.org/show_bug.cgi?id=144181
675
676         Change was incorrect, broke builds (Requested by smfr on
677         #webkit).
678
679         Reverted changeset:
680
681         "Fix the build."
682         http://trac.webkit.org/changeset/183303
683
684 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
685
686         Fix the build.
687
688         * MiniBrowser/mac/WK2BrowserWindowController.m:
689         (-[WK2BrowserWindowController initWithConfiguration:]):
690
691 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
692
693         Disable ActionMenusPDFTest due to timeout on test bot
694
695         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
696         (TestWebKitAPI::TEST):
697
698 2015-04-24  Commit Queue  <commit-queue@webkit.org>
699
700         Unreviewed, rolling out r183266.
701         https://bugs.webkit.org/show_bug.cgi?id=144164
702
703         Broke 32-bit build and a test. (Requested by ap on #webkit).
704
705         Reverted changeset:
706
707         "AX: richer text change notifications (142719)"
708         https://bugs.webkit.org/show_bug.cgi?id=142719
709         http://trac.webkit.org/changeset/183266
710
711 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
712
713         REGRESSION: WebKit2.ActionMenusTest API test fails
714         https://bugs.webkit.org/show_bug.cgi?id=144149
715         <rdar://problem/20677770>
716
717         Reviewed by Tim Horton.
718
719         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
720         as the 'ActionMenusPDFTest'.
721         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
722         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
723         to match the hit test on the 'action-menu-target.pdf' test file.
724
725 2015-04-24  Daniel Bates  <dabates@apple.com>
726
727         Cleanup: Use @memoized for property IOSSimulator.testing_device
728         https://bugs.webkit.org/show_bug.cgi?id=141715
729
730         Reviewed by Darin Adler.
731
732         Simplify the caching of the result of IOSSimulator.testing_device
733         and make the code more readable by making use of the @memoized declarator
734         instead of explicitly managing a private instance variable,
735         IOSSimulator._testing_device, for the cached result.
736
737         * Scripts/webkitpy/port/ios.py:
738         (IOSPort.determine_full_port_name):
739         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
740         (IOSSimulatorPort):
741         (IOSSimulatorPort.testing_device): No need to cache the created device object in
742         IOSSimulatorPort._testing_device since we are marking this function @memoized.
743         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
744         of caching in local variable since we only make use of this value exactly once in this function.
745         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
746         been used since being added in r178622. So, we can remove this constructor since
747         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
748
749 2015-04-24  Anders Carlsson  <andersca@apple.com>
750
751         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
752         https://bugs.webkit.org/show_bug.cgi?id=144158
753
754         Reviewed by Beth Dakin.
755
756         * MiniBrowser/mac/WK2BrowserWindowController.m:
757         (-[WK2BrowserWindowController initWithConfiguration:]):
758
759 2015-04-24  Doug Russell  <d_russell@apple.com>
760
761         AX: richer text change notifications (142719)
762         https://bugs.webkit.org/show_bug.cgi?id=142719
763
764         Reviewed by Darin Adler.
765
766         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
767
768         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
769
770         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
771         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
772         (-[AccessibilityNotificationHandler stopObserving]):
773         (-[AccessibilityNotificationHandler _notificationReceived:]):
774         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
775         (AccessibilityUIElement::removeNotificationListener):
776         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
777         (-[AccessibilityNotificationHandler _notificationReceived:]):
778         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
779         (WTR::AccessibilityUIElement::removeNotificationListener):
780
781 2015-04-24  Darin Adler  <darin@apple.com>
782
783         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
784         https://bugs.webkit.org/show_bug.cgi?id=128007
785
786         Reviewed by Anders Carlsson.
787
788         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
789         * DumpRenderTree/win/UIDelegate.h: Ditto.
790
791         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
792         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
793
794         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
795
796         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
797         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
798         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
799         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
800         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
801         (WebKitDOMDOMWindowTest::create): Ditto.
802         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
803         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
804         of smart pointers to DelayedSIgnal objects.
805         (uriChangedCallback): Ditto.
806
807 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
808
809         [Mac] Unreviewed test fix.
810         https://bugs.webkit.org/show_bug.cgi?id=144149
811
812         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
813         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
814         test.
815
816 2015-04-23  Darin Adler  <darin@apple.com>
817
818         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
819         https://bugs.webkit.org/show_bug.cgi?id=144090
820
821         Reviewed by Anders Carlsson.
822
823         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
824
825 2015-04-23  Michael Saboff  <msaboff@apple.com>
826
827         lldb macro btjs sometimes can't get a frame description
828         https://bugs.webkit.org/show_bug.cgi?id=144130
829
830         Reviewed by Filip Pizlo.
831
832         We look to execute ExecState::describeFrame().  It appears that in some contexts the
833         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
834         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
835
836         * lldb/lldb_webkit.py:
837         (btjs):
838
839 2015-04-23  Alex Christensen  <achristensen@webkit.org>
840
841         Use less memory when compiling content extensions.
842         https://bugs.webkit.org/show_bug.cgi?id=144051
843
844         Reviewed by Darin Adler and Benjamin Poulain.
845
846         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
847         (TestWebKitAPI::TEST_F):
848         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
849         (TestWebKitAPI::countLiveNodes):
850
851 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
852
853         [CMake] Clean up JSC JIT options
854         https://bugs.webkit.org/show_bug.cgi?id=143998
855
856         Reviewed by Filip Pizlo.
857
858         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
859         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
860
861 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
862
863         [Mac] Extend action menus to support PDF
864         https://bugs.webkit.org/show_bug.cgi?id=143895
865         <rdar://problem/19003333>
866
867         Reviewed by Tim Horton.
868
869         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
870         of PDF content works.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
873         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
874         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
875         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
876         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
877         Update to support PDF tests.
878         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
879         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
880
881 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
882
883         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
884
885         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
886         (beforeAll):
887         (testWebViewAudioOnlyUserMediaPermissionRequests):
888
889 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
890
891         Add myself to watchlist
892         https://bugs.webkit.org/show_bug.cgi?id=144041
893
894         Reviewed by Alex Christensen.
895
896         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
897
898         * Scripts/webkitpy/common/config/watchlist:
899
900 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
901
902         [GTK] MiniBrowser should use NetworkProcess by default
903         https://bugs.webkit.org/show_bug.cgi?id=143948
904
905         Reviewed by Sergio Villar Senin.
906
907         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
908         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
909
910         * MiniBrowser/gtk/main.c:
911         (main):
912
913 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
914
915         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
916
917         Unreviewed build fix.
918
919         * Scripts/prepare-ChangeLog:
920         (get_function_line_ranges_for_cpp):
921         Use grep instead of any to determine if a string is an element of an array.
922
923 2015-04-21  Anders Carlsson  <andersca@apple.com>
924
925         Fix block signatures
926         https://bugs.webkit.org/show_bug.cgi?id=144002
927
928         Reviewed by Andreas Kling.
929
930         * MiniBrowser/mac/WK2BrowserWindowController.m:
931         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
932
933 2015-04-21  Philippe Normand  <pnormand@igalia.com>
934
935         [GTK] jhbuild should not use a branch for openwebrtc
936         https://bugs.webkit.org/show_bug.cgi?id=143981
937
938         Reviewed by Carlos Garcia Campos.
939
940         * gtk/jhbuild.modules:
941
942 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
943
944         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
945
946         Unreviewed build fix.
947
948         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
949         However, it has been exposed by List::MoreUtils since its inception. This patch uses
950         the any function exposed by List::MoreUtils for greater compatibility.
951
952         * Scripts/prepare-ChangeLog:
953         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
954         the any function in all of versions of Perl used by our infrastructure.
955
956 2015-04-20  Alex Christensen  <achristensen@webkit.org>
957
958         Remove unnecessary logs when resetting tests.
959
960         * WebKitTestRunner/mac/TestControllerMac.mm:
961         (WTR::TestController::platformResetPreferencesToConsistentValues):
962         In r183020 I added some logs when compiling or removing content extensions fails.
963         We often try to remove a content extension that does not exist, and that is not a problem.
964
965 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
966
967         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
968         https://bugs.webkit.org/show_bug.cgi?id=143897
969
970         Reviewed by David Kilzer.
971
972         This is a speculative fix that addresses two issues:
973
974         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
975         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
976
977         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
978         Before: (723, 729)
979         After: (721, 720)
980
981         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
982         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
983
984         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
985         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
986
987         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
988
989         2. Creating git diffs from HEAD and not origin/master by default.
990
991         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
992         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
993
994         * Scripts/prepare-ChangeLog:
995         (originalFile):
996         Use HEAD instead of origin/master in default Git case.
997
998         (generateFunctionLists):
999         Ensure that the end line is not less than the start line.
1000
1001         (extractLineRangeAfterChange):
1002         Set the end line to the start line if the end line is less than the start line.
1003
1004         (extractLineRangeBeforeChange):
1005         Ditto.
1006
1007 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1008
1009         Suppress warning in prepare-ChangeLog.
1010         https://bugs.webkit.org/show_bug.cgi?id=143882
1011
1012         Reviewed by David Kilzer.
1013
1014         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1015         instead of the deprecated smartmatch operator.
1016
1017         * Scripts/prepare-ChangeLog:
1018         Import the List::Util::any function.
1019
1020         (get_function_line_ranges_for_cpp):
1021         Use the any function instead of smartmatch.
1022
1023 2015-04-20  Anders Carlsson  <andersca@apple.com>
1024
1025         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1026         https://bugs.webkit.org/show_bug.cgi?id=143966
1027
1028         Reviewed by Dan Bernstein.
1029
1030         * MiniBrowser/mac/WK2BrowserWindowController.m:
1031         (dataTypes):
1032         (-[WK2BrowserWindowController fetchWebsiteData:]):
1033         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1034         (-[WK2BrowserWindowController clearWebsiteData:]):
1035
1036 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1037
1038         Fix content extension test flakiness.
1039         https://bugs.webkit.org/show_bug.cgi?id=143950
1040
1041         Reviewed by Brady Eidson.
1042
1043         * WebKitTestRunner/mac/TestControllerMac.mm:
1044         (WTR::TestController::platformResetPreferencesToConsistentValues):
1045         Remove the TestContentExtensions if it exists.
1046         (WTR::TestController::platformConfigureViewForTest):
1047         Log errors in case there are any.
1048
1049 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1050
1051         Properly report errors from _WKUserContentExtensionStore.
1052         https://bugs.webkit.org/show_bug.cgi?id=143808
1053
1054         Reviewed by Darin Adler.
1055
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1057         (TEST_F):
1058
1059 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1060
1061         Add a rule for NetworkCache to watchlist file
1062         https://bugs.webkit.org/show_bug.cgi?id=143945
1063
1064         Reviewed by Sergio Villar Senin.
1065
1066         And add myself to the list of watchers.
1067
1068         * Scripts/webkitpy/common/config/watchlist:
1069
1070 2015-04-19  Darin Adler  <darin@apple.com>
1071
1072         Update RefPtr documentation and deprecation
1073         https://bugs.webkit.org/show_bug.cgi?id=143936
1074
1075         Reviewed by Andreas Kling.
1076
1077         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1078
1079 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1080
1081         Introduce bytecode intrinsics
1082         https://bugs.webkit.org/show_bug.cgi?id=143926
1083
1084         Reviewed by Filip Pizlo.
1085
1086         Change cpplint to accept emit_intrinsic_XXX.
1087
1088         * Scripts/webkitpy/style/checkers/cpp.py:
1089         (check_identifier_name_in_declaration):
1090
1091 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1092
1093         Fix lldb_webkit.py to show StringImpls correctly
1094         https://bugs.webkit.org/show_bug.cgi?id=143920
1095
1096         Reviewed by Andreas Kling.
1097         
1098         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1099
1100         * lldb/lldb_webkit.py:
1101         (WTFStringImplProvider.is_8bit):
1102
1103 2015-04-17  Daniel Bates  <dabates@apple.com>
1104
1105         Not able to build WebKit against iOS Simulator 8.3 SDK
1106         https://bugs.webkit.org/show_bug.cgi?id=143883
1107
1108         Reviewed by David Kilzer.
1109
1110         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1111         so that Xcode uses them.
1112
1113         * Scripts/copy-webkitlibraries-to-product-directory:
1114
1115 2015-04-17  Beth Dakin  <bdakin@apple.com>
1116
1117         Force mouse events should go through normal mouse event handling code paths
1118         https://bugs.webkit.org/show_bug.cgi?id=143749
1119         -and corresponding-
1120         rdar://problem/20472895
1121
1122         Reviewed by Dean Jackson.
1123
1124         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1125         Since there is not a way to create an NSEventTypePressure from scratch, we 
1126         subclass NSEvent and override all of the critical methods.
1127
1128         * WebKitTestRunner/EventSenderProxy.h:
1129         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1130         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1131         (WTR::EventSendingController::mouseForceDown):
1132         (WTR::EventSendingController::mouseForceUp):
1133         (WTR::EventSendingController::mouseForceChanged):
1134         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1135         * WebKitTestRunner/TestController.cpp:
1136         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1137         * WebKitTestRunner/mac/EventSenderProxy.mm:
1138         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1139         (-[EventSenderPressureEvent timestamp]):
1140         (-[EventSenderPressureEvent type]):
1141         (-[EventSenderPressureEvent locationInWindow]):
1142         (-[EventSenderPressureEvent location]):
1143         (-[EventSenderPressureEvent stage]):
1144         (-[EventSenderPressureEvent pressure]):
1145         (-[EventSenderPressureEvent phase]):
1146         (-[EventSenderPressureEvent eventNumber]):
1147         (WTR::EventSenderProxy::mouseForceDown):
1148         (WTR::EventSenderProxy::mouseForceUp):
1149         (WTR::EventSenderProxy::mouseForceChanged):
1150
1151 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1152
1153         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1154         https://bugs.webkit.org/show_bug.cgi?id=143885
1155
1156         Reviewed by Tim Horton.
1157
1158         Fixed a case where we have two builds with the same revision(s). An in order build
1159         is one for which the revision is strictly higher.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1162         (BuildbotQueue.prototype._checkForInOrderResult):
1163         (BuildbotQueue.prototype.compareIterationsByRevisions):
1164
1165 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1166
1167         Unreviewed, rolling out r182912 and r182920.
1168         https://bugs.webkit.org/show_bug.cgi?id=143881
1169
1170         Build breakage in some configurations (Requested by ap on
1171         #webkit).
1172
1173         Reverted changesets:
1174
1175         "Force mouse events should go through normal mouse event
1176         handling code paths"
1177         https://bugs.webkit.org/show_bug.cgi?id=143749
1178         http://trac.webkit.org/changeset/182912
1179
1180         http://trac.webkit.org/changeset/182920
1181
1182 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1183
1184         [GTK] One more unreviewed fix after r182882.
1185
1186         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1187
1188 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1189
1190         [GTK] Unreviewed speculative clean build fix after r182882.
1191
1192         TestWebKitAPI's forwarding header generator depended on WeKit2's
1193         which generated SOUP related forwarding headers too.
1194
1195         This dependency isn't necessary and was removed by r182882 to make
1196         forwarding header generators parallelizable. But in this case
1197         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1198         should generate SOUP related forwarding headers too similar to EFL.
1199
1200         * TestWebKitAPI/PlatformGTK.cmake:
1201         * WebKitTestRunner/PlatformGTK.cmake:
1202
1203 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1204
1205         [SOUP] Redirect to non HTTP destination is broken
1206         https://bugs.webkit.org/show_bug.cgi?id=143866
1207
1208         Reviewed by Sergio Villar Senin.
1209
1210         Add a unit test to check that redirect to a data URI works.
1211
1212         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1213         (testRedirectToDataURI):
1214         (serverCallback):
1215         (beforeAll):
1216
1217 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1218
1219         Changes method of quitting iOS Simulator to be more correct.
1220         https://bugs.webkit.org/show_bug.cgi?id=143847
1221         <rdar://problem/20530344>
1222
1223         Reviewed by Darin Adler.
1224
1225         Fixes by addressing the app by ID rather than by name.
1226
1227         * Scripts/webkitdirs.pm:
1228         (quitIOSSimulator):
1229         * Scripts/webkitpy/port/ios.py:
1230         (IOSSimulatorPort.check_sys_deps):
1231
1232 2015-04-16  Anders Carlsson  <andersca@apple.com>
1233
1234         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1235         https://bugs.webkit.org/show_bug.cgi?id=143844
1236
1237         Reviewed by Dan Bernstein.
1238
1239         * MiniBrowser/mac/AppDelegate.m:
1240         (-[BrowserAppDelegate newPrivateWindow:]):
1241         * MiniBrowser/mac/WK2BrowserWindowController.m:
1242         (-[WK2BrowserWindowController initWithConfiguration:]):
1243         (-[WK2BrowserWindowController fetchWebsiteData:]):
1244         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1245         (-[WK2BrowserWindowController clearWebsiteData:]):
1246
1247 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1248
1249         32-bit build fix.
1250
1251         * WebKitTestRunner/mac/TestControllerMac.mm:
1252         (WTR::TestController::platformResetPreferencesToConsistentValues):
1253         (WTR::TestController::platformConfigureViewForTest):
1254         Added WK_API_ENABLED.
1255
1256 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1257
1258         Removed unused WKUserContentFilterRef.
1259         https://bugs.webkit.org/show_bug.cgi?id=143852
1260
1261         Reviewed by Sam Weinig.
1262
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1264         * WebKitTestRunner/mac/TestControllerMac.mm:
1265         (WTR::TestController::platformResetPreferencesToConsistentValues):
1266         (WTR::TestController::platformConfigureViewForTest):
1267
1268 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1269
1270         Unreviewed. Adding myself as a commiter in contributers.json.
1271
1272         * Scripts/webkitpy/common/config/contributors.json:
1273
1274 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
1275
1276         It is very hard to attach a debugger to WebProcess to debug tests
1277         https://bugs.webkit.org/show_bug.cgi?id=143837
1278
1279         Reviewed by Chris Dumez.
1280
1281         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1282         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1283
1284         Now it disables all timeouts in tools, as is best for debugging tests.
1285
1286         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1287         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1288
1289         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1290         now has the same functionality.
1291
1292 2015-04-16  Beth Dakin  <bdakin@apple.com>
1293
1294         Force mouse events should go through normal mouse event handling code paths
1295         https://bugs.webkit.org/show_bug.cgi?id=143749
1296         -and corresponding-
1297         rdar://problem/20472895
1298
1299         Reviewed by Dean Jackson.
1300
1301         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1302         Since there is not a way to create an NSEventTypePressure from scratch, we 
1303         subclass NSEvent and override all of the critical methods.
1304
1305         * WebKitTestRunner/EventSenderProxy.h:
1306         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1307         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1308         (WTR::EventSendingController::mouseForceDown):
1309         (WTR::EventSendingController::mouseForceUp):
1310         (WTR::EventSendingController::mouseForceChanged):
1311         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1312         * WebKitTestRunner/TestController.cpp:
1313         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1314         * WebKitTestRunner/mac/EventSenderProxy.mm:
1315         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1316         (-[EventSenderPressureEvent timestamp]):
1317         (-[EventSenderPressureEvent type]):
1318         (-[EventSenderPressureEvent locationInWindow]):
1319         (-[EventSenderPressureEvent location]):
1320         (-[EventSenderPressureEvent stage]):
1321         (-[EventSenderPressureEvent pressure]):
1322         (-[EventSenderPressureEvent phase]):
1323         (-[EventSenderPressureEvent eventNumber]):
1324         (WTR::EventSenderProxy::mouseForceDown):
1325         (WTR::EventSenderProxy::mouseForceUp):
1326         (WTR::EventSenderProxy::mouseForceChanged):
1327
1328 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1329
1330         [EFL] Bump LLVM to version 3.6.0 on X86_64
1331         https://bugs.webkit.org/show_bug.cgi?id=143604
1332
1333         Reviewed by Gyuyoung Kim.
1334
1335         * efl/jhbuild.modules:
1336         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1337         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1338         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1339         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1340
1341 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1342
1343         [EFL] Remove an unnecessary workaround from jhbuildrc
1344         https://bugs.webkit.org/show_bug.cgi?id=143823
1345
1346         Reviewed by Gyuyoung Kim.
1347
1348         * efl/jhbuildrc:
1349
1350 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1351
1352         [GTK] Run forwarding headers generator unconditionally
1353         https://bugs.webkit.org/show_bug.cgi?id=143819
1354
1355         Reviewed by Carlos Garcia Campos.
1356
1357         * TestWebKitAPI/PlatformGTK.cmake:
1358         * WebKitTestRunner/PlatformGTK.cmake:
1359
1360 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1361
1362         [EFL] Add gnutls to jhbuild.module
1363         https://bugs.webkit.org/show_bug.cgi?id=143777
1364
1365         Reviewed by Csaba Osztrogonác.
1366
1367         EFL port has required at least 3.0.0 version of gnutls since r176712.
1368         However some old linux distributions don't support 3.0.0 version. Besides
1369         other projects sometimes need to use lower version of gnutls.
1370
1371         This patch supports to download gnutls through jhbuild, and use it.
1372
1373         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
1374         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1375
1376 2015-04-15  Mark Lam  <mark.lam@apple.com>
1377
1378         Remove obsolete VMInspector debugging tool.
1379         https://bugs.webkit.org/show_bug.cgi?id=143798
1380
1381         Reviewed by Michael Saboff.
1382
1383         * TestWebKitAPI/CMakeLists.txt:
1384         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1385         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1388
1389 2015-04-15  Jer Noble  <jer.noble@apple.com>
1390
1391         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1392
1393         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1394
1395 2015-04-15  Jer Noble  <jer.noble@apple.com>
1396
1397         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1398
1399         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1400         (TestWebKitAPI::TEST_F):
1401
1402 2015-04-15  Chris Dumez  <cdumez@apple.com>
1403
1404         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1405         https://bugs.webkit.org/show_bug.cgi?id=143779
1406
1407         Reviewed by Brent Fulgham.
1408
1409         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1410         similarly to what is done on Mac / WK1. Without this, PageCache could
1411         stay enabled after page cache tests and cause weird behaviors.
1412
1413         * DumpRenderTree/win/DumpRenderTree.cpp:
1414         (resetWebPreferencesToConsistentValues):
1415
1416 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
1417
1418         Re-enable custom dilation for antialiased fonts
1419         https://bugs.webkit.org/show_bug.cgi?id=143738
1420
1421         Reviewed by Tim Horton.
1422         
1423         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1424         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1425         a private WebKit pref. This pref defaults to YES, enabling the feature by default
1426         in WK1 as we do for WK2.
1427
1428         * DumpRenderTree/mac/DumpRenderTree.mm:
1429         (resetWebPreferencesToConsistentValues):
1430         * WebKitTestRunner/TestController.cpp:
1431         (WTR::TestController::resetPreferencesToConsistentValues):
1432
1433 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
1434
1435         Correct layering violation in DumpRenderTree Build
1436         https://bugs.webkit.org/show_bug.cgi?id=143732
1437
1438         Reviewed by Simon Fraser.
1439
1440         Correct a layering violation in DumpRenderTree by calling functions on the
1441         WebCoreTestSupport library, rather than attempting to work with WebCore
1442         types directly.
1443
1444         * DumpRenderTree/mac/EventSendingController.mm:
1445         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1446         than WebCore itself.,
1447         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1448
1449 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
1450
1451         Add a conservative DFA minimizer for the content extension matcher
1452         https://bugs.webkit.org/show_bug.cgi?id=143501
1453
1454         Reviewed by Alex Christensen.
1455
1456         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1457         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1458
1459 2015-04-14  Daniel Bates  <dabates@apple.com>
1460
1461         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1462         https://bugs.webkit.org/show_bug.cgi?id=143693
1463         <rdar://problem/20530316>
1464
1465         Reviewed by Tim Horton.
1466
1467         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1468         to use the fixed layout code on iOS at this time.
1469
1470         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1471
1472 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1473
1474         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1475         https://bugs.webkit.org/show_bug.cgi?id=143705
1476
1477         Unreviewed change to watchlist file.
1478
1479         * Scripts/webkitpy/common/config/watchlist:
1480
1481 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
1482
1483         [EFL] favicon wasn't updated for google.com sometimes.
1484         https://bugs.webkit.org/show_bug.cgi?id=141940
1485
1486         Reviewed by Gyuyoung Kim.
1487
1488         As elm_entry_utf8_to_markup can include additional characters, parameter for the
1489         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1490
1491         * MiniBrowser/efl/main.c:
1492         (on_url_changed):
1493
1494 2015-04-13  Tim Horton  <timothy_horton@apple.com>
1495
1496         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1497         https://bugs.webkit.org/show_bug.cgi?id=143560
1498         <rdar://problem/16302047>
1499
1500         Reviewed by Darin Adler.
1501
1502         * MiniBrowser/mac/BrowserWindowController.h:
1503         * MiniBrowser/mac/MainMenu.xib:
1504         * MiniBrowser/mac/WK1BrowserWindowController.m:
1505         (-[WK1BrowserWindowController setScale:]):
1506         * MiniBrowser/mac/WK2BrowserWindowController.m:
1507         (viewScaleForMenuItemTag):
1508         (-[WK2BrowserWindowController setScale:]):
1509         (-[WK2BrowserWindowController validateMenuItem:]):
1510         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1511         When in use, we resize the window so that the view fits correctly, and
1512         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1513         layout size will not change when scaling down (but will update appropriately
1514         when the view is resized).
1515
1516 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1517
1518         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1519         https://bugs.webkit.org/show_bug.cgi?id=138630
1520
1521         Reviewed by Tim Horton.
1522
1523         Make sure that we always load at least one in order productive iteration.
1524
1525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1526         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1527         is done loading at least one iteration that wasn't an out of order build.
1528         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1529         when that's needed to check for out of order builds.
1530         (BuildbotQueue.prototype.update): Ditto.
1531         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1532         result, and if it does not, load more iterations.
1533         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1534         an in order iteration loaded too.
1535         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1536         corrected to always sort loaded iterations before unloaded ones.
1537
1538 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1539
1540         Expand test infrastructure to support scrolling tests
1541         https://bugs.webkit.org/show_bug.cgi?id=143286
1542         <rdar://problem/20375516>
1543
1544         Reviewed by Simon Fraser.
1545
1546         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1547         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1548         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1549         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1550         relevant rubberband, scroll, and scroll-snap animations are finished.
1551
1552         * DumpRenderTree/mac/EventSendingController.mm:
1553         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1554         and 'monitorWheelEvents'.
1555         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1556         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1557         debugging test failures.
1558         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1559         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1560         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1561         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1562         'callAfterScrollingCompletes' method.
1563         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1564         and 'monitorWheelEvents'.
1565         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1566         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1567         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1568         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1569         'callAfterScrollingComplates' method.
1570         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1571
1572 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1573
1574         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1575         https://bugs.webkit.org/show_bug.cgi?id=143656
1576
1577         Reviewed by Darin Adler.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1580         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1581
1582 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1583
1584         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1585         https://bugs.webkit.org/show_bug.cgi?id=142387
1586
1587         Reviewed by Carlos Garcia Campos.
1588
1589         Running mixed content is blocked by default since r181134. Updated
1590         the test case to reflect the new default settings.
1591
1592         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1593         (testInsecureContent):
1594
1595 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1596
1597         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1598         https://bugs.webkit.org/show_bug.cgi?id=143667
1599
1600         Reviewed by Csaba Osztrogonác.
1601
1602         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1603         since r169017. Added $hardwareConcurrencySupport for it.
1604
1605         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1606
1607         * Scripts/webkitperl/FeatureList.pm:
1608
1609 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1610
1611         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1612         https://bugs.webkit.org/show_bug.cgi?id=143664
1613
1614         Reviewed by Gyuyoung Kim.
1615
1616         * Scripts/webkitperl/FeatureList.pm:
1617
1618 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1619
1620         [EFL] Enable Media Source
1621         https://bugs.webkit.org/show_bug.cgi?id=143635
1622
1623         Reviewed by Csaba Osztrogonác.
1624
1625         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1626
1627 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
1628
1629         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1630         https://bugs.webkit.org/show_bug.cgi?id=143646
1631
1632         Reviewed by David Kilzer.
1633
1634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1635         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1636
1637 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
1638
1639         Use en_US spell checker for tests on Mac instead of Multilingual
1640         https://bugs.webkit.org/show_bug.cgi?id=143641
1641
1642         Reviewed by Dan Bernstein.
1643
1644         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1645         While at it, override NSUserDictionaryReplacementItems, so that user replacements
1646         cannot affect tests.
1647
1648         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1649         Made this more like WebKit1 version.
1650
1651 2015-04-10  Tim Horton  <timothy_horton@apple.com>
1652
1653         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1654         https://bugs.webkit.org/show_bug.cgi?id=143576
1655
1656         Reviewed by Simon Fraser.
1657
1658         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1659         (TEST):
1660         Adopt.
1661
1662 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1663
1664         Update my email address and expertise.
1665         https://bugs.webkit.org/show_bug.cgi?id=143586
1666
1667         Unreviewed, just update my info.
1668
1669         * Scripts/webkitpy/common/config/contributors.json:
1670
1671 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
1672
1673         Flakiness Dashboard not loading insecure content if loaded with https URL
1674         https://bugs.webkit.org/show_bug.cgi?id=143570
1675
1676         Reviewed by Alexey Proskuryakov.
1677
1678         * TestResultServer/app.yaml:
1679         * TestResultServer/static-dashboards/loader.js:
1680         Switch to https scheme.
1681
1682 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1683
1684         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1685         https://bugs.webkit.org/show_bug.cgi?id=142907
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         * TestWebKitAPI/PlatformEfl.cmake:
1690         * TestWebKitAPI/PlatformGTK.cmake:
1691         * WebKitTestRunner/PlatformEfl.cmake:
1692         * WebKitTestRunner/PlatformGTK.cmake:
1693
1694 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1695
1696         [Mac] Unreviewed test fix after r182584
1697         https://bugs.webkit.org/show_bug.cgi?id=143452
1698
1699         Put both of these tests back to their original state now that the underlying
1700         problem is fixed.
1701
1702         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1705         (TestWebKitAPI::TEST):
1706
1707 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
1708
1709         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1710         https://bugs.webkit.org/show_bug.cgi?id=143553
1711
1712         Reviewed by Ryosuke Niwa.
1713         
1714         Remove the spurious printVMs left over from an earlier change.
1715
1716         * Scripts/run-jsc-benchmarks:
1717
1718 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1719
1720         [Mac] Unreviewed test fix after r182581
1721
1722         The behavior of control-left-click is controlled by a system preference.
1723         Our test bots have this turned off.
1724
1725         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1728         (TestWebKitAPI::TEST):
1729
1730 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1731
1732         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1733         https://bugs.webkit.org/show_bug.cgi?id=143452
1734         <rdar://problem/20437483>
1735
1736         Reviewed by Tim Horton.
1737
1738         Add a new API test to confirm that Cocoa mouse button press events are properly
1739         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1740
1741         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1742         some registered event handlers that the expected button press and context menu
1743         events are received.
1744
1745         The WK1 unit test creates an NSEvent with the desired button press state, and then
1746         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1747         We check the resulting PlatformMouseEvent for proper state.
1748
1749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1750         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1751         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1752         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1753         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1754         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1755         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1756         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1757         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1758         mouse down events.
1759         * TestWebKitAPI/mac/PlatformWebViewMac.h:
1760
1761 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1762
1763         [GTK] Add pango to jhbuild-optional.modules
1764         https://bugs.webkit.org/show_bug.cgi?id=143537
1765
1766         Reviewed by Martin Robinson.
1767
1768         * gtk/jhbuild-optional.modules: Add pango.
1769
1770 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1771
1772         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1773         https://bugs.webkit.org/show_bug.cgi?id=143530
1774
1775         Reviewed by Žan Doberšek.
1776
1777         Assume that the default value for display (:0) is reserved and start checking on :1
1778         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1779         and for X server named Xorg.bin (previous bug 1376599)
1780
1781         * Scripts/webkitpy/port/xvfbdriver.py:
1782         (XvfbDriver._next_free_display)
1783         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1784         (XvfbDriverTest.test_start_no_pixel_tests):
1785         (XvfbDriverTest.test_start_pixel_tests):
1786         (XvfbDriverTest.test_start_arbitrary_worker_number):
1787         (XvfbDriverTest.test_next_free_display):
1788         (XvfbDriverTest.test_start_next_worker):
1789 2015-04-08  Alex Christensen  <achristensen@webkit.org>
1790
1791         Block popups from content extensions.
1792         https://bugs.webkit.org/show_bug.cgi?id=143497
1793
1794         Reviewed by Brady Eidson.
1795
1796         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1797         (TestWebKitAPI::TEST_F):
1798         Added popup test.
1799
1800 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
1801
1802         Add CMake build system for WinCairo port.
1803         https://bugs.webkit.org/show_bug.cgi?id=115944
1804
1805         Reviewed by Chris Dumez.
1806
1807         * CMakeLists.txt:
1808         * WinLauncher/CMakeLists.txt: Added.
1809
1810 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1811
1812         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1813         https://bugs.webkit.org/show_bug.cgi?id=143521
1814
1815         Reviewed by Martin Robinson.
1816
1817         Add a way to detect unexpected web process crashes to WebViewTest,
1818         and a test case to testDOMCache to trigger the crash.
1819
1820         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1821         (WebKitDOMNodeTest::testDOMCache):
1822         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1823         (testWebKitWebViewProcessCrashed):
1824         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1825         (WebViewTest::WebViewTest):
1826         (WebViewTest::webProcessCrashed):
1827         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1828
1829 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
1830
1831         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
1832         rdar://problem/20461342
1833
1834         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1835
1836 2015-04-07  Commit Queue  <commit-queue@webkit.org>
1837
1838         Unreviewed, rolling out r182511.
1839         https://bugs.webkit.org/show_bug.cgi?id=143507
1840
1841         caused debug test failures (Requested by alexchristensen on
1842         #webkit).
1843
1844         Reverted changeset:
1845
1846         "Block popups from content extensions."
1847         https://bugs.webkit.org/show_bug.cgi?id=143497
1848         http://trac.webkit.org/changeset/182511
1849
1850 2015-04-07  Alex Christensen  <achristensen@webkit.org>
1851
1852         Block popups from content extensions.
1853         https://bugs.webkit.org/show_bug.cgi?id=143497
1854
1855         Reviewed by Brady Eidson.
1856
1857         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1858         (TestWebKitAPI::TEST_F):
1859         Added popup test.
1860
1861 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
1862
1863         Get the features.json files ready for open contributions
1864         https://bugs.webkit.org/show_bug.cgi?id=143436
1865
1866         Reviewed by Darin Adler.
1867
1868         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1869         (JSONFeaturesChecker.check):
1870         Extend the syntax checking a bit, but leave everything non-mandatory
1871         very loose until we figure what fields are important.
1872
1873 2015-04-07  Tim Horton  <timothy_horton@apple.com>
1874
1875         Expose and test fixedLayoutSize via modern WebKit SPI
1876         https://bugs.webkit.org/show_bug.cgi?id=143500
1877
1878         Reviewed by Simon Fraser.
1879
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
1882         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
1883         (TEST):
1884         Add a test that verifies that fixedLayoutSize works at all, that
1885         it persists through a navigation, and that turning it back off reverts to
1886         laying out at the size of the view.
1887
1888 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1889
1890         Unreviewed. Add myself as a committer.
1891
1892         * Scripts/webkitpy/common/config/contributors.json:
1893
1894 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
1895
1896         [Win] Bots complain about missing /etc/catalog
1897         https://bugs.webkit.org/show_bug.cgi?id=143484
1898
1899         Reviewed by Chris Dumez.
1900
1901         The libxml2 build on Mac, iOS, and Windows does not provide the set
1902         of default catalog files. We do not actually need these for our
1903         purposes, but we get warnings and some bot flakiness because they
1904         are not present.
1905
1906         We can avoid both problems the same way the Mac and iOS ports do,
1907         by setting the XML_CATALOG_FILES environment variable to 'empty string',
1908         which avoid the warnings and bot problems.
1909
1910         * Scripts/webkitpy/port/win.py:
1911         (WinPort.setup_environ_for_server): Added.
1912
1913 2015-04-06  Sam Weinig  <sam@webkit.org>
1914
1915         Use content extensions in MiniBrowser.
1916         https://bugs.webkit.org/show_bug.cgi?id=143446
1917
1918         Reviewed by Alex Christensen.
1919
1920         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1921         * MiniBrowser/mac/AppDelegate.h:
1922         * MiniBrowser/mac/AppDelegate.m:
1923         (-[BrowserAppDelegate init]):
1924         (-[BrowserAppDelegate showExtensionsManager:]):
1925         (-[BrowserAppDelegate userContentContoller]):
1926         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1927         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1928         (-[ExtensionManagerWindowController init]):
1929         (-[ExtensionManagerWindowController windowDidLoad]):
1930         (-[ExtensionManagerWindowController add:]):
1931         (-[ExtensionManagerWindowController remove:]):
1932         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1933         * MiniBrowser/mac/MainMenu.xib:
1934
1935 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1936
1937         web-platform-tests server should retrieve the modules file relatively to its docroot path
1938         https://bugs.webkit.org/show_bug.cgi?id=142742
1939
1940         Reviewed by Darin Adler.
1941
1942         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1943         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1944
1945 2015-04-06  Commit Queue  <commit-queue@webkit.org>
1946
1947         Unreviewed, rolling out r182445.
1948         https://bugs.webkit.org/show_bug.cgi?id=143459
1949
1950         broke 32 bit build (Requested by alexchristensen on #webkit).
1951
1952         Reverted changeset:
1953
1954         "Use content extensions in MiniBrowser."
1955         https://bugs.webkit.org/show_bug.cgi?id=143446
1956         http://trac.webkit.org/changeset/182445
1957
1958 2015-04-06  Sam Weinig  <sam@webkit.org>
1959
1960         Use content extensions in MiniBrowser.
1961         https://bugs.webkit.org/show_bug.cgi?id=143446
1962
1963         Reviewed by Alex Christensen.
1964
1965         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1966         * MiniBrowser/mac/AppDelegate.h:
1967         * MiniBrowser/mac/AppDelegate.m:
1968         (-[BrowserAppDelegate init]):
1969         (-[BrowserAppDelegate showExtensionsManager:]):
1970         (-[BrowserAppDelegate userContentContoller]):
1971         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1972         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1973         (-[ExtensionManagerWindowController init]):
1974         (-[ExtensionManagerWindowController windowDidLoad]):
1975         (-[ExtensionManagerWindowController add:]):
1976         (-[ExtensionManagerWindowController remove:]):
1977         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1978         * MiniBrowser/mac/MainMenu.xib:
1979
1980 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1981
1982         [GTK] install-dependencies should prefer dnf to yum
1983         https://bugs.webkit.org/show_bug.cgi?id=143441
1984
1985         Reviewed by Martin Robinson.
1986
1987         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1988
1989         * gtk/install-dependencies:
1990
1991 2015-04-06  Andy Estes  <aestes@apple.com>
1992
1993         [iOS] 'make clean' fails in Tools/WebKitTestRunner
1994         https://bugs.webkit.org/show_bug.cgi?id=143455
1995
1996         Reviewed by Dan Bernstein.
1997
1998         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1999         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2000
2001         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2002
2003 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2004
2005         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2006         https://bugs.webkit.org/show_bug.cgi?id=143450
2007
2008         Reviewed by Anders Carlsson.
2009
2010         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2011         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2012         Also, removed unnecessary get() calls.
2013
2014 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2015
2016         Reduce the dependency on Flash in regression tests
2017         https://bugs.webkit.org/show_bug.cgi?id=143391
2018
2019         Reviewed by Anders Carlsson.
2020
2021         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2022         Only allow QuickTime and the test plug-in.
2023
2024 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2025
2026         W3C test importer should generate the modules installed dynamically to run wpt tests
2027         https://bugs.webkit.org/show_bug.cgi?id=142738
2028
2029         Reviewed by Ryosuke Niwa.
2030
2031         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2032         The implementation is done within TestDownloader and it is activated for the WPT repository.
2033         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2034
2035         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2036         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2037         * Scripts/webkitpy/w3c/test_downloader.py:
2038         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2039         (TestDownloader):
2040         (TestDownloader._git_submodules_description): Computes submodule description.
2041         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2042         * Scripts/webkitpy/w3c/test_importer.py:
2043         (TestImporter.do_import): Added the possibility to post process the tests.
2044         (TestImporter):
2045         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2046         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2047         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2048         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2049         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2050         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2051         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2052         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2053
2054 2015-04-05  Antti Koivisto  <antti@apple.com>
2055
2056         Bloom filter should support longer hashes
2057         https://bugs.webkit.org/show_bug.cgi?id=143419
2058
2059         Reviewed by Dan Bernstein.
2060
2061         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2062         (TestWebKitAPI::generateRandomDigests):
2063         (TestWebKitAPI::TEST):
2064
2065 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2066
2067         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2068         https://bugs.webkit.org/show_bug.cgi?id=143372
2069
2070         Reviewed by Darin Adler.
2071
2072         * Scripts/run-jsc-stress-tests:
2073
2074 2015-04-03  Antti Koivisto  <antti@apple.com>
2075
2076         Add non-counting bloom filter class
2077         https://bugs.webkit.org/show_bug.cgi?id=143366
2078
2079         Reviewed by Sam Weinig.
2080
2081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2082         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2083         (TestWebKitAPI::generateRandomHashes):
2084         (TestWebKitAPI::TEST):
2085
2086 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2087
2088         FTL JIT tests should fail if LLVM library isn't available
2089         https://bugs.webkit.org/show_bug.cgi?id=143374
2090
2091         Reviewed by Mark Lam.
2092
2093         * Scripts/run-jsc-stress-tests:
2094
2095 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2096
2097         [EFL] Speedup jhbuild with disable running autogen.sh
2098         https://bugs.webkit.org/show_bug.cgi?id=143369
2099
2100         Reviewed by Gyuyoung Kim.
2101
2102         * efl/jhbuild.modules:
2103
2104 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2105
2106         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2107         https://bugs.webkit.org/show_bug.cgi?id=143282
2108
2109         Reviewed by Daniel Bates.
2110
2111         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2112
2113 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2114
2115         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2116         https://bugs.webkit.org/show_bug.cgi?id=143240
2117         rdar://problem/19990425
2118
2119         Reviewed by Tim Horton.
2120
2121         * DumpRenderTree/mac/LayoutTestHelper.m:
2122         (colorProfileURLForDisplay):
2123         (saveDisplayColorProfiles):
2124         Gracefully handle it when the current profile cannot be retrieved, fixing at
2125         least one case when LayoutTestHelper couldn't start.
2126
2127         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2128         (Manager._set_up_run):
2129         (Manager._force_pixel_tests_if_needed):
2130         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2131         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2132         Return and check an error from start_helper().
2133
2134 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2135
2136         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2137         https://bugs.webkit.org/show_bug.cgi?id=143321
2138
2139         Reviewed by Alexey Proskuryakov.
2140
2141         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2142
2143 2015-04-01  Enrica Casucci  <enrica@apple.com>
2144
2145         Injected bundle messages should be at the page level.
2146         https://bugs.webkit.org/show_bug.cgi?id=143283
2147
2148         Reviewed by Alexey Proskuryakov.
2149
2150         Updating WebKitTestRunner to use the new page level messaging.
2151         The author of this patch is Tim Horton, I just finished it.
2152
2153         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2154         (WTR::EventSendingController::mouseDown):
2155         (WTR::EventSendingController::mouseUp):
2156         (WTR::EventSendingController::mouseMoveTo):
2157         (WTR::EventSendingController::leapForward):
2158         (WTR::EventSendingController::scheduleAsynchronousClick):
2159         (WTR::EventSendingController::keyDown):
2160         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2161         (WTR::EventSendingController::mouseScrollBy):
2162         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2163         (WTR::EventSendingController::continuousMouseScrollBy):
2164         (WTR::EventSendingController::addTouchPoint):
2165         (WTR::EventSendingController::updateTouchPoint):
2166         (WTR::EventSendingController::setTouchModifier):
2167         (WTR::EventSendingController::setTouchPointRadius):
2168         (WTR::EventSendingController::touchStart):
2169         (WTR::EventSendingController::touchMove):
2170         (WTR::EventSendingController::touchEnd):
2171         (WTR::EventSendingController::touchCancel):
2172         (WTR::EventSendingController::clearTouchPoints):
2173         (WTR::EventSendingController::releaseTouchPoint):
2174         (WTR::EventSendingController::cancelTouchPoint):
2175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2176         (WTR::InjectedBundle::didReceiveMessage):
2177         (WTR::InjectedBundle::didReceiveMessageToPage):
2178         (WTR::InjectedBundle::done):
2179         (WTR::InjectedBundle::outputText):
2180         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2181         (WTR::InjectedBundle::postAddChromeInputField):
2182         (WTR::InjectedBundle::postRemoveChromeInputField):
2183         (WTR::InjectedBundle::postFocusWebView):
2184         (WTR::InjectedBundle::postSetBackingScaleFactor):
2185         (WTR::InjectedBundle::postSetWindowIsKey):
2186         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2187         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2188         (WTR::InjectedBundle::setGeolocationPermission):
2189         (WTR::InjectedBundle::setMockGeolocationPosition):
2190         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2191         (WTR::InjectedBundle::setUserMediaPermission):
2192         (WTR::InjectedBundle::setCustomPolicyDelegate):
2193         (WTR::InjectedBundle::setHidden):
2194         (WTR::InjectedBundle::setCacheModel):
2195         (WTR::InjectedBundle::shouldProcessWorkQueue):
2196         (WTR::InjectedBundle::processWorkQueue):
2197         (WTR::InjectedBundle::queueBackNavigation):
2198         (WTR::InjectedBundle::queueForwardNavigation):
2199         (WTR::InjectedBundle::queueLoad):
2200         (WTR::InjectedBundle::queueLoadHTMLString):
2201         (WTR::InjectedBundle::queueReload):
2202         (WTR::InjectedBundle::queueLoadingScript):
2203         (WTR::InjectedBundle::queueNonLoadingScript):
2204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2205         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2206         (WTR::TestRunner::setAuthenticationUsername):
2207         (WTR::TestRunner::setAuthenticationPassword):
2208         (WTR::TestRunner::secureEventInputIsEnabled):
2209         (WTR::TestRunner::setBlockAllPlugins):
2210         * WebKitTestRunner/TestController.cpp:
2211         (WTR::TestController::createWebViewWithOptions):
2212         (WTR::TestController::resetStateToConsistentValues):
2213         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2214         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2215         * WebKitTestRunner/TestController.h:
2216         * WebKitTestRunner/TestInvocation.cpp:
2217         (WTR::TestInvocation::invoke):
2218         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2219
2220 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2221
2222         Unreviewed, rolling out r182174 and r182177.
2223         https://bugs.webkit.org/show_bug.cgi?id=143314
2224
2225         Try to correct EWS failures (Requested by bfulgham on
2226         #webkit).
2227
2228         Reverted changesets:
2229
2230         "Python SCM should be able to retrieve untracked files"
2231         https://bugs.webkit.org/show_bug.cgi?id=143135
2232         http://trac.webkit.org/changeset/182174
2233
2234         "[buildbot] clean-build script should remove untracked files
2235         and revert local changes too"
2236         https://bugs.webkit.org/show_bug.cgi?id=142400
2237         http://trac.webkit.org/changeset/182177
2238
2239 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2240
2241         [Content Extensions] Properly handle regexes that match everything.
2242         https://bugs.webkit.org/show_bug.cgi?id=143281
2243
2244         Reviewed by Benjamin Poulain.
2245
2246         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2247         (TestWebKitAPI::testRequest):
2248         (TestWebKitAPI::makeBackend):
2249         (TestWebKitAPI::TEST_F):
2250         Removed duplicate code and added test.
2251
2252 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2253
2254         Content Extensions: split the state machines to minimize prefix states
2255         https://bugs.webkit.org/show_bug.cgi?id=143253
2256
2257         Reviewed by Alex Christensen.
2258
2259         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2260         (TestWebKitAPI::TEST_F):
2261         (TestWebKitAPI::testPatternStatus):
2262
2263 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2264
2265         Clean up Identifier factories to clarify the meaning of StringImpl*
2266         https://bugs.webkit.org/show_bug.cgi?id=143146
2267
2268         Reviewed by Filip Pizlo.
2269
2270         Simple API tests for StringImpl are added.
2271
2272         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2273         (TestWebKitAPI::TEST):
2274
2275 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
2276
2277         [EFL] Add AArch64 builder and tester bot to build.webkit.org
2278         https://bugs.webkit.org/show_bug.cgi?id=143092
2279
2280         Reviewed by Gyuyoung Kim.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/config.json:
2283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2284         (Factory.__init__):
2285         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2286
2287 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2288
2289         [buildbot] clean-build script should remove untracked files and revert local changes too
2290         https://bugs.webkit.org/show_bug.cgi?id=142400
2291
2292         Reviewed by Ryosuke Niwa.
2293
2294         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2295         A helper routine SCM.discard_untracked_files is added for that purpose.
2296
2297         * BuildSlaveSupport/clean-build:
2298         (main): Making call to Scripts/clean-webkit
2299         * Scripts/clean-webkit: Added.
2300         (main): Revert changes and delete untracked files.
2301         * Scripts/webkitpy/common/checkout/scm/scm.py:
2302         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2303         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2304         (SCMTest._shared_test_discard_untracked_files):
2305         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2306
2307 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2308
2309         Python SCM should be able to retrieve untracked files
2310         https://bugs.webkit.org/show_bug.cgi?id=143135
2311
2312         Reviewed by Ryosuke Niwa.
2313
2314         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2315         Ignored files may be included or not in this list according boolean passed to the function.
2316
2317         * Scripts/webkitpy/common/checkout/scm/git.py:
2318         (Git.untracked_files):
2319         * Scripts/webkitpy/common/checkout/scm/scm.py:
2320         (SCM.untracked_files):
2321         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2322         (SCMTest._shared_test_untracked_files):
2323         (test_untracked_files):
2324         (GitSVNTest.test_untracked_files):
2325         * Scripts/webkitpy/common/checkout/scm/svn.py:
2326         (SVN.untracked_files):
2327
2328 2015-03-30  Alex Christensen  <achristensen@webkit.org>
2329
2330         [Content Extensions] Correctly handle regular expressions matching everything
2331         https://bugs.webkit.org/show_bug.cgi?id=143235
2332
2333         Reviewed by Benjamin Poulain.
2334
2335         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2336         (TestWebKitAPI::checkCompilerError):
2337         (TestWebKitAPI::TEST_F):
2338         Test ContentExtensionErrors.
2339
2340 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
2341
2342         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2343         https://bugs.webkit.org/show_bug.cgi?id=143241
2344         rdar://problem/20351297
2345
2346         Reviewed by Mark Lam.
2347
2348         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2349
2350 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2351
2352         [CMake][EFL] Remove redundant library link and include path
2353         https://bugs.webkit.org/show_bug.cgi?id=143221
2354
2355         Reviewed by Csaba Osztrogonác.
2356
2357         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2358
2359 2015-03-30  Sam Weinig  <sam@webkit.org>
2360
2361         [Content Extensions] Flesh out the UserContentExtensionStore
2362         https://bugs.webkit.org/show_bug.cgi?id=143123
2363
2364         Reviewed by Benjamin Poulain.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2368         Add tests for _WKUserContentExtensionStore.
2369
2370 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2371
2372         Update install-dependencies Fedora packages after r181624
2373         https://bugs.webkit.org/show_bug.cgi?id=143215
2374
2375         Add json-glib, libv4l, openssl and pulseaudio development packages to
2376         the Fedora list providing we need them to build WebKit dependencies
2377         for this distribution.
2378
2379         Reviewed by Philippe Normand.
2380
2381         * gtk/install-dependencies:
2382
2383 2015-03-30  Commit Queue  <commit-queue@webkit.org>
2384
2385         Unreviewed, rolling out r182119.
2386         https://bugs.webkit.org/show_bug.cgi?id=143196
2387
2388         problem with syntax (Requested by youenn on #webkit).
2389
2390         Reverted changeset:
2391
2392         "[buildbot] clean-build script should remove untracked files
2393         and revert local changes too"
2394         https://bugs.webkit.org/show_bug.cgi?id=142400
2395         http://trac.webkit.org/changeset/182119
2396
2397 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
2398
2399         Start the features.json files
2400         https://bugs.webkit.org/show_bug.cgi?id=143207
2401
2402         Reviewed by Darin Adler.
2403
2404         I kept the style checking light. We'll have to figure
2405         what is the best format for each field.
2406
2407         * Scripts/webkitpy/style/checker.py:
2408         (CheckerDispatcher._create_checker):
2409         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2410         (JSONContributorsChecker.check):
2411         (JSONFeaturesChecker):
2412         (JSONFeaturesChecker.check):
2413
2414 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2415
2416         [buildbot] clean-build script should remove untracked files and revert local changes too
2417         https://bugs.webkit.org/show_bug.cgi?id=142400
2418
2419         Reviewed by Ryosuke Niwa.
2420
2421         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2422
2423         * BuildSlaveSupport/clean-build:
2424         (main): Adding call to Tools/Scripts/clean-webkit.
2425         * Scripts/clean-webkit: Added.
2426         (main): Removes untracked and changed files.
2427         * Scripts/webkitpy/common/checkout/scm/git.py:
2428         (Git.untracked_files): Retrieves GIT untracked files.
2429         * Scripts/webkitpy/common/checkout/scm/scm.py:
2430         (SCM.untracked_files): Retrieves SVN untracked files.
2431         (SCM):
2432         (SCM.discard_untracked_files): Deletes untracked files/folders.
2433         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2434         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2435         (test_untracked_files):
2436         (GitSVNTest.test_untracked_files):
2437         * Scripts/webkitpy/common/checkout/scm/svn.py:
2438         (SVN.untracked_files):
2439
2440 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2441
2442         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
2443         https://bugs.webkit.org/show_bug.cgi?id=143138
2444
2445         Reviewed by Csaba Osztrogonác.
2446
2447         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2448         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2449
2450         * ImageDiff/CMakeLists.txt:
2451         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2452         * WebKitTestRunner/CMakeLists.txt: ditto.
2453
2454 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
2455
2456         Support building WTF on Windows without Cygwin
2457         https://bugs.webkit.org/show_bug.cgi?id=143084
2458
2459         Reviewed by Brent Fulgham.
2460
2461         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2462         This patch also migrates to using File::Spec->catfile() for directory separators.
2463
2464         * Scripts/update-webkit-dependency:
2465         (wanted):
2466         * Scripts/update-webkit-support-libs:
2467         (wanted):
2468         (downloadExpectedVersionNumber):
2469         (zipFileVersion):
2470         (toUnixPath): Deleted.
2471         * Scripts/webkitdirs.pm:
2472         (determineSourceDir):
2473         (windowsSourceSourceDir):
2474         (windowsLibrariesDir):
2475         (windowsOutputDir):
2476         (checkInstalledTools):
2477         (buildVisualStudioProject):
2478
2479 2015-03-27  Alex Christensen  <achristensen@webkit.org>
2480
2481         Fix WinCairo bot.
2482         https://bugs.webkit.org/show_bug.cgi?id=143086
2483
2484         Reviewed by Brent Fulgham.
2485
2486         * Scripts/webkitdirs.pm:
2487         (buildVisualStudioProject):
2488         (runSvnUpdateAndResolveChangeLogs):
2489         Use ActivePerl-friendly perl.
2490
2491 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2492
2493         URTBF after r182059 to fix the EFL build.
2494
2495         * TestWebKitAPI/CMakeLists.txt:
2496
2497 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
2498
2499         Layout test results URL loads in WK1 but not WK2 minibrowser
2500         https://bugs.webkit.org/show_bug.cgi?id=143117
2501
2502         Reviewed by Tim Horton.
2503
2504         * MiniBrowser/mac/WK2BrowserWindowController.m:
2505         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2506         everything.
2507         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2508
2509 2015-03-26  Jer Noble  <jer.noble@apple.com>
2510
2511         Add --allowed-host support to run-webkit-tests
2512         https://bugs.webkit.org/show_bug.cgi?id=142938
2513
2514         Reviewed by Brent Fulgham.
2515
2516         Accept --allowed-host arguments from run-webkit-tests and pass them through to
2517         DumpRenderTree and WebKitTestRunner.
2518
2519         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2520         are placed in the wrong location. The argument is compared with each tests's path, and if a
2521         relative path or a path with '..' was used, results are placed alongside the test. Take the
2522         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2523
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2525         (parse_args):
2526         * Scripts/webkitpy/port/base.py:
2527         (Port.__init__):
2528         (Port.allowed_hosts):
2529         * Scripts/webkitpy/port/driver.py:
2530         (Driver.cmd_line):
2531
2532 2015-03-26  Jer Noble  <jer.noble@apple.com>
2533
2534         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2535         https://bugs.webkit.org/show_bug.cgi?id=142931
2536
2537         Reviewed by Brent Fulgham.
2538
2539         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2540         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2541         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2542         runtime.
2543
2544         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2545         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2546
2547         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2548         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2549         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2550         the top loading frame from the page, as we do elsewhere in this class.
2551
2552         * DumpRenderTree/TestRunner.h:
2553         (TestRunner::allowedHosts):
2554         (TestRunner::setAllowedHosts):
2555         * DumpRenderTree/mac/DumpRenderTree.mm:
2556         (initializeGlobalsFromCommandLineOptions):
2557         (runTest):
2558         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2559         (isAllowedHost):
2560         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2561         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2562         (WTR::InjectedBundle::didReceiveMessage):
2563         (WTR::InjectedBundle::isAllowedHost):
2564         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2565         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2566         (WTR::isAllowedHost):
2567         (WTR::InjectedBundlePage::willSendRequestForFrame):
2568         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2569         * WebKitTestRunner/Options.cpp:
2570         (WTR::handleOptionAllowedHost):
2571         (WTR::OptionsHandler::OptionsHandler):
2572         * WebKitTestRunner/Options.h:
2573         * WebKitTestRunner/TestController.cpp:
2574         (WTR::TestController::initialize):
2575         (WTR::TestController::resetStateToConsistentValues):
2576         * WebKitTestRunner/TestController.h:
2577
2578 2015-03-26  Brady Eidson  <beidson@apple.com>
2579
2580         Apply ContentExtension actions after redirects.
2581         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2582
2583         Reviewed by Alex Christensen.
2584
2585         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2586         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2587           which is specifically interesting to a new test.
2588
2589 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2590
2591         [EFL] Disable building libseccomp on AArch64
2592         https://bugs.webkit.org/show_bug.cgi?id=143094
2593
2594         Reviewed by Gyuyoung Kim.
2595
2596         * efl/jhbuildrc:
2597
2598 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2599
2600         [jhbuild] git should use only 1 thread for cloning jhbuild
2601         https://bugs.webkit.org/show_bug.cgi?id=143095
2602
2603         Reviewed by Gyuyoung Kim.
2604
2605         * jhbuild/jhbuild-wrapper:
2606         (clone_jhbuild):
2607
2608 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2609
2610         Update prepare-ChangeLog to work with ES6 Class syntax
2611         https://bugs.webkit.org/show_bug.cgi?id=143069
2612
2613         Reviewed by Timothy Hatcher.
2614
2615         * Scripts/prepare-ChangeLog:
2616         (get_function_line_ranges_for_javascript):
2617         Better handle ES6 Class syntax.
2618
2619         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2620         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2621         (BaseClass):
2622         (DerivedClass):
2623         (DerivedClass.staticMethod):
2624         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2625         (DerivedClass.prototype.method):
2626         (DerivedClass.prototype.get getter):
2627         (namespace.MyClass):
2628         (namespace.MyClass.staticMethod):
2629         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2630         (namespace.MyClass.prototype.method):
2631         (namespace.MyClass.prototype.get getter):
2632         Proof!
2633
2634 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
2635
2636         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2637         https://bugs.webkit.org/show_bug.cgi?id=142993
2638
2639         Reviewed by Mark Lam.
2640         
2641         Bunch of support for testing executable allocation failure.
2642
2643         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2644         (fail):
2645         * Scripts/run-javascriptcore-tests:
2646         (runJSCStressTests):
2647         * Scripts/run-jsc-stress-tests:
2648
2649 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2650
2651         Fix Windows build from r181977.
2652
2653         Unreviewed.
2654
2655         * Scripts/update-webkit-dependency:
2656
2657 2015-03-25  Sam Weinig  <sam@webkit.org>
2658
2659         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2660
2661         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2662         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2663
2664 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2665
2666         Migrate update-webkit for Windows to not require Cygwin
2667         https://bugs.webkit.org/show_bug.cgi?id=143040
2668
2669         Reviewed by Brent Fulgham.
2670
2671         * Scripts/update-webkit-dependency:
2672         (wanted):
2673         (toUnixPath): Deleted.
2674         * Scripts/webkitdirs.pm:
2675         (fontExists):
2676         (checkInstalledTools):
2677         (setupAppleWinEnv):
2678
2679 2015-03-25  Sam Weinig  <sam@webkit.org>
2680
2681         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2682         https://bugs.webkit.org/show_bug.cgi?id=143059
2683
2684         Reviewed by Alex Christensen.
2685
2686         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2687         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2688         Update for new interface of compileRuleList().
2689
2690 2015-03-25  Alex Christensen  <achristensen@webkit.org>
2691
2692         [Content Extensions] Add multi-DFA compiling and interpreting.
2693         https://bugs.webkit.org/show_bug.cgi?id=143010
2694
2695         Reviewed by Benjamin Poulain.
2696
2697         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2698         (TestWebKitAPI::testRequest):
2699         (TestWebKitAPI::TEST_F):
2700         Add some tests for ignore-previous-rules and large rulesets.
2701
2702 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
2703
2704         Mavericks WK1 still runs JSC tests
2705         https://bugs.webkit.org/show_bug.cgi?id=143035
2706
2707         Reviewed by Csaba Osztrogonác.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2710         with other bots.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2713         accordingly.
2714
2715 2015-03-25  Commit Queue  <commit-queue@webkit.org>
2716
2717         Unreviewed, rolling out r181932.
2718         https://bugs.webkit.org/show_bug.cgi?id=143041
2719
2720         The test fails most of the time on bots (Requested by ap on
2721         #webkit).
2722
2723         Reverted changeset:
2724
2725         "[Content Extensions] Add multi-DFA compiling and
2726         interpreting."
2727         https://bugs.webkit.org/show_bug.cgi?id=143010
2728         http://trac.webkit.org/changeset/181932
2729
2730 2015-03-24  Alex Christensen  <achristensen@webkit.org>
2731
2732         [Content Extensions] Add multi-DFA compiling and interpreting.
2733         https://bugs.webkit.org/show_bug.cgi?id=143010
2734
2735         Reviewed by Benjamin Poulain.
2736
2737         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2738         (TestWebKitAPI::testRequest):
2739         (TestWebKitAPI::TEST_F):
2740         Add some tests for ignore-previous-rules and large rulesets.
2741
2742 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
2743
2744         Make URL filter patterns matching consistent and add a simple canonicalization step
2745         https://bugs.webkit.org/show_bug.cgi?id=142998
2746
2747         Reviewed by Alex Christensen.
2748
2749         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2750
2751 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2752
2753         [EFL] Add OpenWebRTC in jhbuild
2754         https://bugs.webkit.org/show_bug.cgi?id=142778
2755
2756         Reviewed by Gyuyoung Kim.
2757
2758         Original patch by Philippe Normand <pnormand@igalia.com>
2759
2760         * efl/install-dependencies: Dependencies for OpenWebRTC.
2761         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2762         the openwebrtc gst plugins.
2763
2764 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
2765
2766         Regression(r181257): WTF_WorkQueue.Simple is flaky
2767         https://bugs.webkit.org/show_bug.cgi?id=142560
2768
2769         Remove the check that the refCount has returned to one after the
2770         individual tasks have completed. It's too nondeterministic when
2771         the reference count will be reduced.
2772
2773         Reviewed by Alexey Proskuryakov
2774
2775         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2776         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2777
2778 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2779
2780         [CMake][EFL] Put failure API test excutables into failure directory
2781         https://bugs.webkit.org/show_bug.cgi?id=142965
2782
2783         Reviewed by Csaba Osztrogonác.
2784
2785         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2786
2787         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2788         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2789
2790 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
2791
2792         CSS Selectors: fix attribute case-insensitive matching of Contain and List
2793         https://bugs.webkit.org/show_bug.cgi?id=142932
2794
2795         Reviewed by Darin Adler.
2796
2797         Add tests for the new features and fix some existing tests using the 
2798         stringFromUTF8() utility recently added by Dhi.
2799
2800         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2801         (TestWebKitAPI::stringFromUTF8):
2802         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2803
2804 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2805
2806         [GTK] install-dependencies should install orc
2807         https://bugs.webkit.org/show_bug.cgi?id=142955
2808
2809         Reviewed by Martin Robinson.
2810
2811         Install orc, needed by openwebrtc
2812
2813         * gtk/install-dependencies:
2814
2815 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
2816
2817         Detect when url filter pattern with groups match the empty string
2818         https://bugs.webkit.org/show_bug.cgi?id=142930
2819
2820         Reviewed by Sam Weinig.
2821
2822         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2823
2824 2015-03-22  Anders Carlsson  <andersca@apple.com>
2825
2826         _WKWebsiteDataStore should clear WebSQL databases
2827         https://bugs.webkit.org/show_bug.cgi?id=142947
2828
2829         Reviewed by Sam Weinig.
2830
2831         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
2832
2833         * MiniBrowser/mac/WK2BrowserWindowController.m:
2834         (-[WK2BrowserWindowController fetchWebsiteData:]):
2835         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2836         (-[WK2BrowserWindowController clearWebsiteData:]):
2837
2838 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
2839
2840         GCTimer should know keep track of nested GC phases
2841         https://bugs.webkit.org/show_bug.cgi?id=142675
2842
2843         Reviewed by Darin Adler.
2844
2845         Adds a tool to aid in parsing the GC phase timing output into a
2846         tree-like structure based on the parent-child relationships
2847         of nested GC phases.
2848
2849         * Scripts/parse-gc-phase-timings: Added.
2850         (Timing):
2851         (Timing.__init__):
2852         (Timing.__unicode__):
2853         (Timing.__str__):
2854         (Timing.__repr__):
2855         (parse_input):
2856         (print_timing_node):
2857         (print_timing_tree):
2858         (link_parents):
2859         (main):
2860
2861 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
2862
2863         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
2864
2865         * Scripts/webkitpy/common/config/ews.json:
2866
2867 2015-03-20  Philippe Normand  <pnormand@igalia.com>
2868
2869         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
2870         https://bugs.webkit.org/show_bug.cgi?id=142867
2871
2872         Rubber-stamped by Csaba Osztrogon.
2873
2874         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
2875         a fixed revision for the openwebrtc-gst-plugins.
2876
2877 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2878
2879         Unreviewed build fix. Don't try to report stats for all benchmarks.
2880         Just report the geometric mean of preferred means.
2881
2882         * Scripts/run-jsc-benchmarks:
2883
2884 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2885
2886         run-jsc-benchmarks should only report preferred mean
2887         https://bugs.webkit.org/show_bug.cgi?id=142874
2888
2889         Reviewed by Geoffrey Garen.
2890
2891         Just collect statistics for the preferred mean.
2892
2893         * Scripts/run-jsc-benchmarks:
2894
2895 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2896
2897         [Content Extensions] Test regular expression parse failures.
2898         https://bugs.webkit.org/show_bug.cgi?id=142872
2899
2900         Reviewed by Benjamin Poulain.
2901
2902         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2903         (TestWebKitAPI::testPatternStatus):
2904         (TestWebKitAPI::TEST_F):
2905         Added tests for each parsing status.
2906
2907 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2908
2909         Fix API tests after r181754.
2910
2911         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2912         (TestWebKitAPI::testRequest):
2913
2914 2015-03-19  Brady Eidson  <beidson@apple.com>
2915
2916         Part of content extensions should apply css selectors
2917         https://bugs.webkit.org/show_bug.cgi?id=142604
2918
2919         Reviewed by Alex Christensen.
2920
2921         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2922         (WebCore::ContentExtensions::operator<<):
2923
2924 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
2925
2926         [Win] Activate tests on EWS
2927         https://bugs.webkit.org/show_bug.cgi?id=142850
2928
2929         Reviewed by Alexey Proskuryakov.
2930
2931         * Scripts/webkitpy/common/config/ews.json: Add me as
2932         the EWS bot watcher, and activate tests.
2933
2934 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
2935
2936         [GTK] Fix inspector userinterface related incremental build issue
2937         https://bugs.webkit.org/show_bug.cgi?id=142849
2938
2939         Reviewed by Carlos Garcia Campos.
2940
2941         * Scripts/webkitdirs.pm:
2942         (shouldRemoveCMakeCache):
2943
2944 2015-03-18  Alex Christensen  <achristensen@webkit.org>
2945
2946         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2947         https://bugs.webkit.org/show_bug.cgi?id=142799
2948
2949         Reviewed by Brady Eidson.
2950
2951         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2952         (TestWebKitAPI::testPattern):
2953         (TestWebKitAPI::TEST_F):
2954         Start testing regex failures.
2955
2956 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
2957
2958         Fix StringView typos after r181525 and r181558
2959         https://bugs.webkit.org/show_bug.cgi?id=142772
2960
2961         Reviewed by Darin Adler.
2962
2963         Add some tests in [1] to cover the StringView::startsWith, 
2964         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
2965         StringView::endsWithIgnoringASCIICase implementations.
2966
2967         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2968         (TestWebKitAPI::TEST):
2969
2970 2015-03-18  Dana Burkart  <dburkart@apple.com>
2971
2972         Remove extraneous import to fix the build.
2973
2974         Unreviewed.
2975
2976         * Scripts/webkitpy/port/driver.py:
2977
2978 2015-03-18  Dana Burkart  <dburkart@apple.com>
2979
2980         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
2981         https://bugs.webkit.org/show_bug.cgi?id=142547
2982
2983         Reviewed by Alexey Proskuryakov.
2984
2985         * Scripts/webkitpy/port/driver.py:
2986         (Driver._setup_environ_for_driver):
2987
2988 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
2989
2990         Tweak how AppleSystemFontOSSubversion default is added
2991         https://bugs.webkit.org/show_bug.cgi?id=142835
2992
2993         Reviewed by Dan Bernstein.
2994
2995         * DumpRenderTree/mac/DumpRenderTree.mm:
2996         (setDefaultsToConsistentValuesForTesting):
2997
2998 2015-03-18  Dan Bernstein  <mitz@apple.com>
2999
3000         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3001         https://bugs.webkit.org/show_bug.cgi?id=142815
3002
3003         Reviewed by Darin Adler.
3004
3005         * Scripts/prepare-ChangeLog:
3006         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3007         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3008         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3009         warning only if a line ends without a backslash before the matching quotation mark was found.
3010
3011 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3012
3013         Remove unused "preprocessor" parameter to sub-CodeGenerators
3014         https://bugs.webkit.org/show_bug.cgi?id=142793
3015
3016         Reviewed by Darin Adler.
3017
3018         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3019         (new):
3020
3021 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3022
3023         [EFL] Bump gstreamer version to 1.4.4
3024         https://bugs.webkit.org/show_bug.cgi?id=142782
3025
3026         Reviewed by Philippe Normand.
3027
3028         * efl/jhbuild.modules:
3029         * efl/patches/gst-libav.patch:
3030         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3031         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3032
3033 2015-03-17  Tim Horton  <timothy_horton@apple.com>
3034
3035         Fix the iOS build.
3036
3037         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3038         (WTR::InjectedBundle::platformInitialize):
3039
3040 2015-03-17  Dean Jackson  <dino@apple.com>
3041
3042         check-webkit-style should allow "bool a : 1"
3043         https://bugs.webkit.org/show_bug.cgi?id=142794
3044
3045         Reviewed by Brent Fulgham.
3046
3047         We should allow member bitfields of the form:
3048
3049         bool m_var : 1;
3050
3051         It seems that Visual Studio 8 was the last compiler that
3052         wasn't happy about not using unsigned here. We already have
3053         about 500 cases (in WebCore) where people were ignoring this rule.
3054
3055         * Scripts/webkitpy/style/checkers/cpp.py:
3056         (check_language): Allow "bool".
3057         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3058         (CppStyleTest.test_enum_bitfields):
3059         (CppStyleTest.test_plain_integral_bitfields):
3060
3061 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
3062
3063         Compile character ranges targeting the same state as range check in the bytecode
3064         https://bugs.webkit.org/show_bug.cgi?id=142759
3065
3066         Reviewed by Alex Christensen.
3067
3068         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3069         (TestWebKitAPI::TEST_F):
3070
3071 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3072
3073         W3C test parser and converter should use test importer host
3074         https://bugs.webkit.org/show_bug.cgi?id=142729
3075
3076         Reviewed by Bem Jones-Bey.
3077
3078         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3079         This enables adding more TestImporter unit testing.
3080         This patch also ensures that the git object instantiated by TestDownloader is using the
3081         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3082
3083         * Scripts/webkitpy/common/system/filesystem_mock.py:
3084         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3085         * Scripts/webkitpy/w3c/test_downloader.py:
3086         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3087         (TestDownloader.checkout_test_repository): Making use of the new git function.
3088         * Scripts/webkitpy/w3c/test_importer.py:
3089         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3090         (TestImporter.import_tests): Adding host as parameter to the converter.
3091         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3092         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3093         (TestImporterTest):
3094         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
3095         * Scripts/webkitpy/w3c/test_parser.py:
3096         (TestParser.__init__): Adding host as parameter constructor.
3097
3098 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3099
3100         [GTK] WebKitDOM objects leaking
3101         https://bugs.webkit.org/show_bug.cgi?id=118788
3102
3103         Reviewed by Darin Adler and Sergio Villar Senin.
3104
3105         Update DOMObjectCache unit test to check that DOM objects are also
3106         released when new contents are loaded in the web view, and the old
3107         document is detached from the frame.
3108
3109         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3110         (testWebKitDOMObjectCache):
3111         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3112         (runTest):
3113
3114 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3115
3116         W3C test importer default import folder should be LayoutTests/imported/w3c
3117         https://bugs.webkit.org/show_bug.cgi?id=142728
3118
3119         Reviewed by Bem Jones-Bey.
3120
3121         * Scripts/webkitpy/w3c/test_importer.py:
3122         (parse_args): Updating the default destination option value to 'imported/w3c'.
3123
3124 2015-03-17  Philippe Normand  <pnormand@igalia.com>
3125
3126         [GTK] basic OpenWebRTC build support
3127         https://bugs.webkit.org/show_bug.cgi?id=142393
3128
3129         Reviewed by Carlos Garcia Campos.
3130
3131         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3132         is not the upstream OpenWebRTC repository. This temporary fork
3133         contains a few patches needed by WebKit for audio/video rendering.
3134
3135 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3136
3137         [CMake][EFL] Build test tools only for developer mode
3138         https://bugs.webkit.org/show_bug.cgi?id=142761
3139
3140         Reviewed by Csaba Osztrogonác.
3141
3142         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3143
3144         * CMakeLists.txt:
3145
3146 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
3147
3148         Remove never used "useLayerOnTop" bindings generator argument
3149         https://bugs.webkit.org/show_bug.cgi?id=142773
3150
3151         Reviewed by Darin Adler.
3152
3153         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3154         (new):
3155
3156 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
3157
3158         Enable ES6 classes by default
3159         https://bugs.webkit.org/show_bug.cgi?id=142774
3160
3161         Reviewed by Gavin Barraclough.
3162
3163         * Scripts/webkitperl/FeatureList.pm:
3164
3165 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3166
3167         Fix webkitpy tests after r181585.
3168
3169         Looks like "me" cannot be anyone's email, it's a special case.
3170
3171         * Scripts/webkitpy/common/config/contributors.json:
3172
3173 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3174
3175         Add tolerance to WebAudio tests
3176         https://bugs.webkit.org/show_bug.cgi?id=142676
3177
3178         Reviewed by Tim Horton.
3179
3180         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3181
3182         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3183         (TestResultWriter.create_audio_diff_and_write_result):
3184         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3185         (FailureAudio.write_failure):
3186         * Scripts/webkitpy/port/base.py:
3187         (Port.do_audio_results_differ):
3188         Diff audio failures.
3189
3190         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3191         tests to use real parseable WAV data, and got rid of base64, which there didn't
3192         seem to have been any reason for.
3193
3194 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3195
3196         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3197         https://bugs.webkit.org/show_bug.cgi?id=142720
3198
3199         Reviewed by Myles C. Maxfield.
3200
3201         Activate system copies of Microsoft fonts for the current process, thus overriding
3202         any other ones that could be preferred by the system otherwise.
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (activateSystemCoreWebFonts):
3206         (adjustFonts):
3207         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3208         (WTR::activateSystemCoreWebFonts):
3209         (WTR::activateFonts):
3210
3211 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3212
3213         Created Streams API watchlist
3214         https://bugs.webkit.org/show_bug.cgi?id=142684
3215
3216         Reviewed by Benjamin Poulain.
3217
3218         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3219         watchlist and added Benjamin, Youenn and me to it.
3220
3221 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
3222
3223         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3224         https://bugs.webkit.org/show_bug.cgi?id=142715
3225
3226         Reviewed by Brent Fulgham.
3227
3228         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3229         (TestWebKitAPI::TEST):
3230
3231 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
3232
3233         Change the exact attribute matching to be ASCII case-insensitive
3234         https://bugs.webkit.org/show_bug.cgi?id=142609
3235
3236         Reviewed by Darin Adler.
3237
3238         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3239         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3240
3241 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3242
3243         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3244         https://bugs.webkit.org/show_bug.cgi?id=134764
3245
3246         Reviewed by Ryosuke Niwa.
3247
3248         TestDownloader is introduced to download W3C tests from the official
3249         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3250         and https://github.com/w3c/csswg-test.git).
3251         TestDownloader clones the repositories and checkouts revisions of the tests
3252         defined in LayoutTests/imported/w3c/resources/TestRepositories.
3253
3254         Similarly to https://codereview.chromium.org/148173016,
3255         TestDownloader copies part of the files based on the rules
3256         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3257
3258         TestDownloader is used by TestImporter when no source directory is provided.
3259
3260         * Scripts/webkitpy/w3c/test_downloader.py: Added.
3261         (TestDownloader):
3262         (TestDownloader.default_options):
3263         (TestDownloader.load_test_repositories):
3264         (TestDownloader.__init__):
3265         (TestDownloader.checkout_test_repository):
3266         (TestDownloader._init_paths_from_expectations):
3267         (TestDownloader._add_test_suite_paths):
3268         (TestDownloader._empty_directory):
3269         (TestDownloader.copy_tests):
3270         (TestDownloader.download_tests):
3271         * Scripts/webkitpy/w3c/test_importer.py:
3272         (main):
3273         (parse_args):
3274         (TestImporter.__init__):
3275         (TestImporter.do_import):
3276         (TestImporter.test_downloader):
3277         (TestImporter.find_importable_tests.should_keep_subdir):
3278         (TestImporter.should_convert_test_harness_links):
3279         (TestImporter.import_tests):
3280         (TestImporter.write_import_log):
3281
3282 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3283
3284         [Mavericks] Test snapshots are 1600x1200 on Retina devices
3285         https://bugs.webkit.org/show_bug.cgi?id=142630
3286
3287         Reviewed by Tim Horton.
3288
3289         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3290         Removed an ifdef that disabled the fix on Mavericks.
3291
3292 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3293
3294         Remove isWK2 cruft from webkitdirs.pm after r170426
3295         https://bugs.webkit.org/show_bug.cgi?id=142618
3296
3297         Reviewed by Daniel Bates.
3298
3299         * Scripts/webkitdirs.pm:
3300         (isWK2): Deleted.
3301
3302 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3303
3304         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
3305         https://bugs.webkit.org/show_bug.cgi?id=138687
3306
3307         Reviewed by Carlos Garcia Campos.
3308
3309         Always change cookie policy from UI process, as changing it from WebProcess doesn't
3310         affect other processes.
3311
3312         The implementation is imperfect, because the change happens asynchronously, but I
3313         don't expect it to be a problem in practice.
3314
3315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3316         (WTR::InjectedBundle::beginTesting):
3317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3318         (WTR::TestRunner::setAlwaysAcceptCookies):
3319         * WebKitTestRunner/TestInvocation.cpp:
3320         (WTR::TestInvocation::invoke):
3321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3322
3323 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3324
3325         [EFL] Enable building EFL 1.13 with NEON support
3326         https://bugs.webkit.org/show_bug.cgi?id=142619
3327
3328         Reviewed by Gyuyoung Kim.
3329
3330         * efl/jhbuild.modules:
3331
3332 2015-03-11  Alex Christensen  <achristensen@webkit.org>
3333
3334         [Content Extensions] Add resource type and load type triggers.
3335         https://bugs.webkit.org/show_bug.cgi?id=142422
3336
3337         Reviewed by Benjamin Poulain.
3338
3339         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3340         (TestWebKitAPI::testRequest):
3341         (TestWebKitAPI::mainDocumentRequest):
3342         (TestWebKitAPI::TEST_F):
3343         (TestWebKitAPI::testURL): Deleted.
3344
3345 2015-03-10  Sam Weinig  <sam@webkit.org>
3346
3347         Allow adding a button in input elements for auto fill related functionality
3348         <rdar://problem/19782066>
3349         https://bugs.webkit.org/show_bug.cgi?id=142564
3350
3351         Reviewed by Anders Carlsson.
3352
3353         * WebKitTestRunner/TestController.cpp:
3354         (WTR::TestController::createOtherPage):
3355         (WTR::TestController::createWebViewWithOptions):
3356         Update for new callback.
3357
3358 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
3359
3360         Add basic support for BOL and EOL assertions to the URL Filter parser
3361         https://bugs.webkit.org/show_bug.cgi?id=142568
3362
3363         Reviewed by Alex Christensen.
3364
3365         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3366         (TestWebKitAPI::TEST_F):
3367
3368 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3369
3370         [GTK] Add support for handling TLS errors to MiniBrowser
3371         https://bugs.webkit.org/show_bug.cgi?id=142576
3372
3373         Reviewed by Sergio Villar Senin.
3374
3375         It's useful for testing TLS errors handling itself, but also to
3376         allow ignoring TLS errors when testing.
3377
3378         * MiniBrowser/gtk/BrowserWindow.c:
3379         (webViewLoadFailedWithTLSerrors):
3380         (browserWindowConstructed):
3381
3382 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3383
3384         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
3385         https://bugs.webkit.org/show_bug.cgi?id=142569
3386
3387         Reviewed by David Hyatt.
3388
3389         Test Optional::valueOrCompute().
3390
3391         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3392         (TestWebKitAPI::TEST):
3393
3394 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3395
3396         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
3397         https://bugs.webkit.org/show_bug.cgi?id=126688
3398
3399         Reviewed by Gustavo Noronha Silva.
3400
3401         * CMakeLists.txt: Build testing tools only for developer builds,
3402         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
3403         * MiniBrowser/gtk/CMakeLists.txt: Only add
3404         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
3405         and add a rule to install the MiniBrowser.
3406         * MiniBrowser/gtk/main.c:
3407         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
3408         builds.
3409
3410 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
3411
3412         Add some DateMath tests to TestWebKitAPI
3413         https://bugs.webkit.org/show_bug.cgi?id=142565
3414
3415         Reviewed by Alexey Proskuryakov.
3416
3417         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
3418         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3419         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
3421         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
3422
3423 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
3424
3425         Regression(r181257): WTF_WorkQueue.Simple is flaky
3426         https://bugs.webkit.org/show_bug.cgi?id=142560
3427
3428         Unreviewed attempt to improve test stability.
3429
3430         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3431         the WorkQueue a little later to redue flakiness.
3432
3433 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3434
3435         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3436         https://bugs.webkit.org/show_bug.cgi?id=142555
3437
3438         Reviewed by Simon Fraser.
3439
3440         * DumpRenderTree/mac/DumpRenderTree.mm:
3441         (setDefaultsToConsistentValuesForTesting):
3442         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3443         (WTR::InjectedBundle::platformInitialize):
3444
3445 2015-03-10  Alex Christensen  <achristensen@webkit.org>
3446
3447         Use unsigned for HashSet size.
3448         https://bugs.webkit.org/show_bug.cgi?id=142518
3449
3450         Reviewed by Benjamin Poulain.
3451
3452         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3453         (TestWebKitAPI::TEST):
3454         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3455         (TestWebKitAPI::testInitialCapacity):
3456         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3457         (TestWebKitAPI::TEST):
3458
3459 2015-03-10  Daniel Bates  <dabates@apple.com>
3460
3461         [iOS] Add WebKitSystemInterface for iOS 8.2
3462         https://bugs.webkit.org/show_bug.cgi?id=142505
3463
3464         Rubber-stamped by Anders Carlsson.
3465
3466         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3467         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3468         copy-webkitlibraries-to-product-directory in r181286.
3469
3470         * Scripts/copy-webkitlibraries-to-product-directory:
3471
3472 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
3473
3474         Extend URL filter's Term definition to support groups/subpatterns
3475         https://bugs.webkit.org/show_bug.cgi?id=142519
3476
3477         Reviewed by Alex Christensen.
3478
3479         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3480         (TestWebKitAPI::testURL):
3481
3482 2015-03-06  Jer Noble  <jer.noble@apple.com>
3483
3484         Add an option to run-webkit-tests to override the LayoutTests/ directory
3485         https://bugs.webkit.org/show_bug.cgi?id=142418
3486
3487         Reviewed by David Kilzer.
3488
3489         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3490         directory. The base port will parse the options during initialization and store the override
3491         location if present. layout_tests_dir() will return this overridden location if set.
3492
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3494         (parse_args):
3495         * Scripts/webkitpy/port/base.py:
3496         (Port.__init__):
3497         (Port.layout_tests_dir):
3498
3499 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
3500
3501         [CMake] Enable WorkQueue tests for CMake ports
3502         https://bugs.webkit.org/show_bug.cgi?id=142473
3503
3504         Reviewed by Darin Adler.
3505
3506         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3507         the list of source files.
3508         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3509         to the list of include directories for EFL.
3510
3511 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3512
3513         Attempt to fix timeouts on iOS Simulator layout tests
3514
3515         * Scripts/webkitpy/port/ios.py:
3516         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3517         Simulator end after the first 50 tests time out.  Some analysis
3518         this past weekend shows that the 'Booted' status in the output
3519         of `xcrun simctl list` is not sufficient (and watching the test
3520         run shows that SpringBoard hasn't fully started to the point
3521         where it's displaying icons on the home screen).  The workaround
3522         until we have a better fix is to add an arbitrary timeout to let
3523         SpringBoard finish launching.  In practice, 15 seconds is
3524         probably enough, but 30 seconds should nearly always work.
3525
3526 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
3527
3528         Unreviewed. Add myself as a committer.
3529
3530         * Scripts/webkitpy/common/config/contributors.json:
3531
3532 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3533
3534         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3535
3536         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3537         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3538         an expectation that will fail if we hit the race condition.
3539         This test is inherently racy and will deadlock if the first job
3540         for queue2 takes the mutex lock before the second job for
3541         queue1.
3542
3543 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3544
3545         [Win] WTF::WorkQueue does not balance ref/deref properly
3546         https://bugs.webkit.org/show_bug.cgi?id=142471
3547
3548         Reviewed by Antti Koivisto.
3549
3550         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3551         (TestWebKitAPI::TEST): Check that the refcount is correct.
3552
3553 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3554
3555         Do not show passing test result on output of EFL layout test
3556         https://bugs.webkit.org/show_bug.cgi?id=142380
3557
3558         Reviewed by Darin Adler.
3559
3560         To show passing tests has caused inconvenience when we detect problem tests
3561         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3562         in order not to show passing tests in the output of EFL layout test.
3563
3564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3565         (RunWebKitTests.start):
3566
3567 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3568
3569         Unreviewed build fix.
3570
3571         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3572         (TestWebKitAPI::TEST): Remove two unused variables.
3573
3574 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3575
3576         Add some WorkQueue tests to TestWebKitAPI
3577         https://bugs.webkit.org/show_bug.cgi?id=142447
3578
3579         Reviewed by Sam Weinig.
3580
3581         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3582         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3585         (TestWebKitAPI::simpleTest):
3586         (TestWebKitAPI::longTest):
3587         (TestWebKitAPI::thirdTest):
3588         (TestWebKitAPI::finishedTests):
3589         (TestWebKitAPI::TEST):
3590         (TestWebKitAPI::longTest2):
3591
3592 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3593
3594         Remove willDestroyFrame in WKBundlePageLoaderClient
3595         https://bugs.webkit.org/show_bug.cgi?id=142389
3596
3597         Reviewed by Anders Carlsson.
3598
3599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3600         (WTR::InjectedBundlePage::InjectedBundlePage):
3601
3602 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3603
3604         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3605         https://bugs.webkit.org/show_bug.cgi?id=142433
3606
3607         Reviewed by Darin Adler.
3608
3609         Include more TestWebKitAPI tests when building for Windows. Also
3610         fix a build error in MetaAllocator.cpp caused by one of the
3611         Microsoft headers #defining 'small'.
3612
3613         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3614         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3615         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3616
3617 2015-03-06  Sam Weinig  <sam@webkit.org>
3618
3619         [Content Extensions] Move compiling of content extensions to the UIProcess
3620         https://bugs.webkit.org/show_bug.cgi?id=142402
3621
3622         Reviewed by Benjamin Poulain.
3623
3624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3625         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3626         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3627         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3628         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3629         (TestWebKitAPI::TEST_F):
3630         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3631         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3632         is now abstract).
3633
3634 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
3635
3636         [Win] Correct Windows build.
3637
3638         Rubberstamped by Michael Saboff
3639
3640         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3641         in the GOTO labels.
3642
3643 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3644
3645         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3646         https://bugs.webkit.org/show_bug.cgi?id=142385
3647
3648         Reviewed by Sergio Villar Senin.
3649
3650         Use stack allocated GMainLoopSources to make sure they are
3651         cancelled automatically if the test finishes before they have
3652         been processed.
3653
3654         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3655         (testWebViewSyncRequestOnMaxConns):
3656
3657 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3658
3659         Remove Mountain Lion libraries since ML isn't supported
3660         https://bugs.webkit.org/show_bug.cgi?id=142332
3661
3662         Reviewed by Darin Adler.
3663
3664         * Scripts/copy-webkitlibraries-to-product-directory:
3665
3666 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
3667
3668         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3669         https://bugs.webkit.org/show_bug.cgi?id=142083
3670
3671         Reviewed by Simon Fraser.
3672
3673         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3674
3675         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3676         (WebPlatformTestServer._copy_webkit_test_files):
3677
3678 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3679
3680         setup-git-clone fails due to the failure to download python-irclib-0.4.8
3681         https://bugs.webkit.org/show_bug.cgi?id=141946
3682
3683         Reviewed by Ryosuke Niwa.
3684
3685         Check in ircbot.py and irclib.py to avoid network problems in the future.
3686
3687         * Scripts/webkitpy/common/net/irc/ircbot.py:
3688         * Scripts/webkitpy/thirdparty/__init__.py:
3689         (AutoinstallImportHook.find_module):
3690         (AutoinstallImportHook._install_irc): Deleted.
3691         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3692         (ThirdpartyTest.test_imports):
3693         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.