Unreviewed, rolling out r234489.
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-02  David Fenton  <david_fenton@apple.com>
2
3         Unreviewed, rolling out r234489.
4
5         Caused 50+ crashes and 60+ API failures on iOS
6
7         Reverted changeset:
8
9         "[WTF] Rename String::format to String::deprecatedFormat"
10         https://bugs.webkit.org/show_bug.cgi?id=188191
11         https://trac.webkit.org/changeset/234489
12
13 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
14
15         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
16         https://bugs.webkit.org/show_bug.cgi?id=188244
17
18         Reviewed by Daniel Bates.
19
20         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
21
22         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
23
24 2018-08-01  Tomas Popela  <tpopela@redhat.com>
25
26         [WTF] Rename String::format to String::deprecatedFormat
27         https://bugs.webkit.org/show_bug.cgi?id=188191
28
29         Reviewed by Darin Adler.
30
31         It should be replaced with string concatenation.
32
33         * DumpRenderTree/win/DumpRenderTree.cpp:
34         (applicationId):
35         (main):
36         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
37         (TestWebKitAPI::Util::createURLForResource):
38         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
39         (WTR::cacheTestRunnerCallback):
40         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
41         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
42         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
43         (WTR::AccessibilityUIElement::attributedStringForRange):
44         (WTR::AccessibilityUIElement::url):
45         (WTR::stringAtOffset):
46         * WebKitTestRunner/TestController.cpp:
47         (WTR::TestController::didReceiveAuthenticationChallenge):
48         (WTR::TestController::downloadDidFail):
49         (WTR::originUserVisibleName):
50         (WTR::userMediaOriginHash):
51         (WTR::TestController::didNavigateWithNavigationData):
52         (WTR::TestController::didPerformClientRedirect):
53         (WTR::TestController::didPerformServerRedirect):
54         (WTR::TestController::didUpdateHistoryTitle):
55
56 2018-08-01  Nan Wang  <n_wang@apple.com>
57
58         AX: AOM: Add ARIA IDL Attribute Reflection
59         https://bugs.webkit.org/show_bug.cgi?id=184676
60         <rdar://problem/39476882>
61
62         Reviewed by Chris Fleizach.
63
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         (enableExperimentalFeatures):
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::resetPreferencesToConsistentValues):
68
69 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
70
71         Use iPhone SE as the default simulated device
72         https://bugs.webkit.org/show_bug.cgi?id=188227
73
74         Reviewed by Aakash Jain.
75
76         * Scripts/webkitpy/port/ios_simulator.py:
77         (IOSSimulatorPort):
78
79 2018-08-01  Commit Queue  <commit-queue@webkit.org>
80
81         Unreviewed, rolling out r234443 and r234445.
82         https://bugs.webkit.org/show_bug.cgi?id=188224
83
84         Revision caused 3 api failures across all platforms.
85         (Requested by Truitt on #webkit).
86
87         Reverted changesets:
88
89         "Add configuration for automatic process pre-warming"
90         https://bugs.webkit.org/show_bug.cgi?id=187108
91         https://trac.webkit.org/changeset/234443
92
93         "Add configuration for automatic process pre-warming"
94         https://bugs.webkit.org/show_bug.cgi?id=187108
95         https://trac.webkit.org/changeset/234445
96
97 2018-07-31  Ben Richards  <benton_richards@apple.com>
98
99         Add configuration for automatic process pre-warming
100         https://bugs.webkit.org/show_bug.cgi?id=187108
101
102         Reviewed by Ryosuke Niwa.
103
104         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
105
106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
108         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
109         (TEST):
110
111 2018-07-31  John Wilander  <wilander@apple.com>
112
113         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
114         https://bugs.webkit.org/show_bug.cgi?id=188109
115         <rdar://problem/42664391>
116
117         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
118
119         This patch removes cookie partitioning which reduces the model to just
120         blocked cookies (in third-party contexts) and first-party cookie access.
121
122         Several of the changes are renaming to reflect that there are no more
123         cookie partitions.
124
125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
126            Removed or renamed functions to reflect that there are no more
127            partitioned cookies.
128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
129         (WTR::InjectedBundle::didReceiveMessageToPage):
130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
131         (WTR::TestRunner::statisticsUpdateCookieBlocking):
132         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
133         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
134         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
135         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
136         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
137         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
138         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
140         * WebKitTestRunner/TestController.cpp:
141         (WTR::TestController::statisticsUpdateCookieBlocking):
142         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
143         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
144         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
145         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
146         * WebKitTestRunner/TestController.h:
147         * WebKitTestRunner/TestInvocation.cpp:
148         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
149         (WTR::TestInvocation::didSetBlockCookiesForHost):
150         (WTR::TestInvocation::didSetHasHadUserInteraction):
151         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
152         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
153         * WebKitTestRunner/TestInvocation.h:
154         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
155         (WTR::initializeWebViewConfiguration):
156
157 2018-07-31  Alex Christensen  <achristensen@webkit.org>
158
159         Build fix.  Remove unused variable.
160
161         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
162         (TestWebKitAPI::TEST):
163         transform was never used. It was introduced in r205871
164         Apparently I'm the first one to build in a certain configuration that found it.
165
166 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
167
168         server_process.py should print returncode in debug log if the process crashed
169         https://bugs.webkit.org/show_bug.cgi?id=188160
170
171         Reviewed by Konstantin Tokarev.
172
173         * Scripts/webkitpy/port/server_process.py:
174         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
175
176 2018-07-31  Tomas Popela  <tpopela@redhat.com>
177
178         [WTF] String::formatWithArguments() is unused
179         https://bugs.webkit.org/show_bug.cgi?id=187955
180
181         Reviewed by Darin Adler.
182
183         Remove tests for WTF::String::formatWithArguments() as it's unused and
184         we are removing it.
185
186         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
187
188 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
189
190         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
191
192         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
193         other builders.
194
195 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
196
197         [ews-build] Add support for API tests in OpenSource EWS
198         https://bugs.webkit.org/show_bug.cgi?id=188156
199
200         Reviewed by Lucas Forschler.
201
202         * BuildSlaveSupport/ews-build/config.json:
203         * BuildSlaveSupport/ews-build/factories.py:
204         (BuildFactory.__init__): Added triggers parameter.
205         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
206         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
207         (APITestsFactory): Factory for running API tests.
208         * BuildSlaveSupport/ews-build/steps.py:
209         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
210         source of the property.
211
212 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
213
214         [ews-build] loadConfig should ensure that the triggers are valid
215         https://bugs.webkit.org/show_bug.cgi?id=188134
216
217         Reviewed by Lucas Forschler.
218
219         * BuildSlaveSupport/ews-build/loadConfig.py:
220         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
221         (checkValidSchedulers): Ensures that the scheduler is not un-used.
222         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
223
224 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
225
226         Unreviewed, fix typo in test expectations and mark another test as timing out
227
228         * TestWebKitAPI/glib/TestExpectations.json:
229
230 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
231
232         More unreviewed GTK test gardening
233
234         * TestWebKitAPI/glib/TestExpectations.json:
235
236 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
237
238         Be more conservative with compositing layer creation when memory is low
239         https://bugs.webkit.org/show_bug.cgi?id=187866
240         rdar://problem/42366345
241
242         Reviewed by Zalan Bujtas.
243         
244         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
245         compositing layers. We avoid compositing for these situations:
246         1. Layers with 3D transforms which are affine (like translateZ(0)).
247         2. Layers with will-change
248         3. Layers for canvases (other than WebGL/WebGPU)
249         
250         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
251         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
252         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
253         
254         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
255         flakily falling into a different mode, and so that we can impose the conservative
256         mode for testing.
257
258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
259         (WTR::InjectedBundlePage::prepare):
260
261 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         Unreviewed GTK test gardening
264
265         * TestWebKitAPI/glib/TestExpectations.json:
266
267 2018-07-27  Alex Christensen  <achristensen@webkit.org>
268
269         Fix API tests after r234314
270         https://bugs.webkit.org/show_bug.cgi?id=188077
271
272         Make API tests use new delegate method.
273
274         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
275         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
276         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
277
278 2018-07-27  Alex Christensen  <achristensen@webkit.org>
279
280         Fix API tests after r234314
281         https://bugs.webkit.org/show_bug.cgi?id=188077
282
283         Make API tests use new delegate method.
284
285         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
286         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
287         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
288         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
289         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
290         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
291         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
292         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
293         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
294         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
295         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
296
297 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
298
299         [INTL] Remove INTL sub-feature compile flags
300         https://bugs.webkit.org/show_bug.cgi?id=188081
301
302         Reviewed by Michael Catanzaro.
303
304         * Scripts/webkitperl/FeatureList.pm:
305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
306
307 2018-07-26  Chris Dumez  <cdumez@apple.com>
308
309         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
310         https://bugs.webkit.org/show_bug.cgi?id=188078
311         <rdar://problem/42562493>
312
313         Reviewed by Geoff Garen.
314
315         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
316         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
317
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
320         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
321         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
322         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
323         (TEST):
324
325 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
326
327         Add Aaron Chu as a committer to contributors.json
328         https://bugs.webkit.org/show_bug.cgi?id=188066
329
330         Unreviwed. Added myself as committer.
331
332         * Scripts/webkitpy/common/config/contributors.json:
333
334 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-build] Add build step to run API Tests
337         https://bugs.webkit.org/show_bug.cgi?id=188079
338
339         Reviewed by Lucas Forschler.
340
341         * BuildSlaveSupport/ews-build/steps.py:
342         (TestWithFailureCount): Common class for various tests with failure count.
343         (TestWithFailureCount.start): Configure Buildbot's logobserver.
344         (TestWithFailureCount.commandComplete): Updates the failure count.
345         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
346         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
347         (RunAPITests): Build step to run API tests.
348         (RunAPITests.countFailures): Count the failures by parsing the output.
349         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
350
351 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
352
353         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
354         https://bugs.webkit.org/show_bug.cgi?id=187963
355
356         Reviewed by Alex Christensen.
357
358         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
359         Add tests for String::split and String::splitAllowingEmptyEntries.
360
361         * TestWebKitAPI/Tests/WTF/StringView.cpp:
362         * WebKitTestRunner/TestController.cpp:
363         (WTR::updateTestOptionsFromTestHeader):
364         Update split/splitAllowingEmptyEntries usage.
365
366 2018-07-26  Commit Queue  <commit-queue@webkit.org>
367
368         Unreviewed, rolling out r234181 and r234189.
369         https://bugs.webkit.org/show_bug.cgi?id=188075
370
371         These are not needed right now (Requested by thorton on
372         #webkit).
373
374         Reverted changesets:
375
376         "Enable Web Content Filtering on watchOS"
377         https://bugs.webkit.org/show_bug.cgi?id=187979
378         https://trac.webkit.org/changeset/234181
379
380         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
381         https://bugs.webkit.org/show_bug.cgi?id=187985
382         https://trac.webkit.org/changeset/234189
383
384 2018-07-04  Darin Adler  <darin@apple.com>
385
386         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
387         https://bugs.webkit.org/show_bug.cgi?id=187333
388
389         Reviewed by Sam Weinig.
390
391         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
392         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
393         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
394         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
395         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
396
397 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
398
399         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
400         https://bugs.webkit.org/show_bug.cgi?id=188031
401
402         Reviewed by Lucas Forschler.
403
404         * BuildSlaveSupport/ews-build/steps.py:
405         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
406         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
407         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
408
409 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
410
411         [ews-build] Add build step UploadBuiltProduct
412         https://bugs.webkit.org/show_bug.cgi?id=188016
413
414         Reviewed by Lucas Forschler.
415
416         * BuildSlaveSupport/ews-build/steps.py:
417         (UploadBuiltProduct): Added build step UploadBuiltProduct.
418         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
419
420 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
421
422         [ews-build] Add build step ArchiveBuiltProduct
423         https://bugs.webkit.org/show_bug.cgi?id=188014
424
425         Reviewed by Lucas Forschler.
426
427         * BuildSlaveSupport/ews-build/steps.py:
428         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
429         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
430
431 2018-07-25  Chris Dumez  <cdumez@apple.com>
432
433         navigator.userAgent may return outdated value after webView.customUserAgent is set
434         https://bugs.webkit.org/show_bug.cgi?id=188009
435         <rdar://problem/42566456>
436
437         Reviewed by Alex Christensen.
438
439         Add API test coverage.
440
441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
442         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
443         (TEST):
444
445 2018-07-25  Charlie Turner  <cturner@igalia.com>
446
447         [Flatpak] Pass more environment variables to sandbox
448         https://bugs.webkit.org/show_bug.cgi?id=188002
449
450         Reviewed by Michael Catanzaro.
451
452         * flatpak/flatpakutils.py:
453         (WebkitFlatpak.run_in_sandbox):
454
455 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
456
457         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
458         https://bugs.webkit.org/show_bug.cgi?id=187997
459
460         Reviewed by Carlos Garcia Campos.
461
462         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
463         the EGL-oriented API that simply serves EGLImageKHR objects instead of
464         raw buffer resources. This allows us not to wrangle with creating and
465         managing lifetime of the same EGLImageKHR by ourselves.
466
467         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
468         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
469         the exportable object. This means that for each frame we're served an
470         EGLImageKHR object that is passed on to the displayBuffer()
471         implementation.
472
473         HeadlessViewBackend now just manages the pending and committed image
474         objects. Width and height values used during pixel data retrieval are
475         gathered from the ViewBackend's size that was specified when
476         constructed.
477
478         WindowViewBackend similarly only manages the committed image object,
479         not having to create an equivalent EGLImageKHR object from the raw
480         buffer resource anymore.
481
482         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
483         classes are removed, and destructors for both classes are made virtual.
484
485         The WPEBackend-fdo version is bumped in order to have the EGL-specific
486         export API available.
487
488         * flatpak/org.webkit.WPE.yaml:
489         * wpe/backends/HeadlessViewBackend.cpp:
490         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
491         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
492         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
493         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
494         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
495         * wpe/backends/HeadlessViewBackend.h:
496         * wpe/backends/ViewBackend.cpp:
497         (WPEToolingBackends::ViewBackend::initialize):
498         * wpe/backends/ViewBackend.h:
499         * wpe/backends/WindowViewBackend.cpp:
500         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
501         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
502         (WPEToolingBackends::WindowViewBackend::displayBuffer):
503         * wpe/backends/WindowViewBackend.h:
504         * wpe/jhbuild.modules:
505
506 2018-07-24  Thomas Denney  <tdenney@apple.com>
507
508         Remove support for the double type from WHLSL
509         https://bugs.webkit.org/show_bug.cgi?id=187977
510
511         Reviewed by Myles C. Maxfield.
512
513         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
514         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
515         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
516         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
517         * WebGPUShadingLanguageRI/Parse.js:
518         (parseTerm): Removed parsing of double literals.
519         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
520         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
521         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
522         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
523         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
524         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
525
526 2018-07-24  Tim Horton  <timothy_horton@apple.com>
527
528         Enable Web Content Filtering on watchOS
529         https://bugs.webkit.org/show_bug.cgi?id=187979
530         <rdar://problem/42559346>
531
532         Reviewed by Wenson Hsieh.
533
534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
535
536 2018-07-24  Daniel Bates  <dabates@apple.com>
537
538         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
539         https://bugs.webkit.org/show_bug.cgi?id=187971
540
541         Reviewed by Saam Barati.
542
543         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
544         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
545         data type.
546
547         * TestWebKitAPI/CMakeLists.txt:
548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
549         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
550         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
551         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
552         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
553         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
554         (TestWebKitAPI::TEST):
555         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
556         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
557         (TestWebKitAPI::TEST):
558
559 2018-07-24  Thomas Denney  <tdenney@apple.com>
560         Minor changes to the WHLSL interpreter to support the new compiler
561         https://bugs.webkit.org/show_bug.cgi?id=187728
562
563         Reviewed by Myles C. Maxfield.
564
565         This bug contains small changes that are make minor changes to the
566         behaviour of the existing interpreter (the tests are unaffected and all
567         still pass).
568
569         * WebGPUShadingLanguageRI/EnumType.js:
570         (EnumType.prototype.get isEnum): Property added to EnumType and Type
571         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
572         * WebGPUShadingLanguageRI/Func.js:
573         (Func.prototype.get isEntryPoint): Add boolean property
574         * WebGPUShadingLanguageRI/FuncInstantiator.js:
575         (FuncInstantiator.prototype.get instances): Public accessor for existing
576         private field
577         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
578         that it directly wraps a Func instance (therefore the only interface
579         change is to the constructor and the addition of the func accessor).
580         This change allows the de-inlining of functions.
581         (FunctionLikeBlock):
582         (FunctionLikeBlock.prototype.get func):
583         (FunctionLikeBlock.prototype.get returnType):
584         (FunctionLikeBlock.prototype.get parameters):
585         (FunctionLikeBlock.prototype.get body):
586         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
587         constructor
588         (Inliner.prototype.visitCallExpression):
589         (Inliner):
590         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
591         to native functions (with additional support in StandardLibrary.js).
592         This reduces first-time compile-time from around 4s to around 0.1s.
593         (Intrinsics):
594         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
595         comments completes correctly
596         (Lexer.prototype.next):
597         (Lexer):
598         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
599         property, which is based on the type of the lValue and the semantics of
600         the language (the @ operator yields an array reference with the thread
601         scope).
602         (MakeArrayRefExpression):
603         (MakeArrayRefExpression.prototype.get type):
604         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
605         implementationData to support swizzle operator change
606         (NativeFunc.prototype.get implementationData):
607         (NativeFunc.prototype.set implementationData):
608         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
609         constructor
610         (Rewriter.prototype.visitFunctionLikeBlock):
611         * WebGPUShadingLanguageRI/StandardLibrary.js:
612         (_generateSwizzle): Deleted.
613         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
614         carrying metadata about swizzle operators so that they are implemented
615         as native functions rather than generated at compile time.
616         (SwizzleOp):
617         (SwizzleOp.prototype.get outSize):
618         (SwizzleOp.prototype.get components):
619         (SwizzleOp.prototype.get inSize):
620         (SwizzleOp.prototype.toString):
621         (SwizzleOp.allSwizzleOperators.):
622         (SwizzleOp.allSwizzleOperators):
623         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
624         (SwizzleOp.prototype.get outSize):
625         (SwizzleOp.prototype.get components):
626         (SwizzleOp.prototype.get inSize):
627         (SwizzleOp.prototype.toString):
628         (generateSwizzles):
629         (_generateSwizzle): Deleted.
630         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
631         above.
632         (Type.prototype.get isEnum):
633
634 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
635
636         Unreviewed, rolling out r234121.
637
638         Caused perf test failures.
639
640         Reverted changeset:
641
642         "We should cache the compiled sandbox profile in a data vault"
643         https://bugs.webkit.org/show_bug.cgi?id=184991
644         https://trac.webkit.org/changeset/234121
645
646 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
647
648         [Flatpak] Add openh264 as needed by WebRTC
649         https://bugs.webkit.org/show_bug.cgi?id=187956
650
651         Reviewed by Philippe Normand.
652
653         * flatpak/org.webkit.WebKit.yaml:
654
655 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
656
657         WebCore::URL::hostIsIPAddress needs a Windows implementation
658         https://bugs.webkit.org/show_bug.cgi?id=187859
659
660         Reviewed by Fujii Hironori.
661
662         * TestWebKitAPI/Tests/WebCore/URL.cpp:
663         Check for a few other ways an IP address could be invalid.
664
665 2018-07-24  Charlie Turner  <cturner@igalia.com>
666
667         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
668         https://bugs.webkit.org/show_bug.cgi?id=187951
669
670         When running run-webkit-tests --wpe --debug, it was observed that
671         both self.platform != 'wpe' and self.debug != True. This turned
672         out to be because of the "args" argument consuming the remainder
673         of future arguments that came after it. Since the first argument
674         to load_from_args was the test script to run, it would end up
675         never processing the other arguments supplied to the wrapper
676         script.
677
678         Tested this by rebuilding GTK in debug mode, running the
679         minibrowser with various extra options, and running some tests
680         with various extra options.
681
682         Reviewed by Michael Catanzaro.
683
684         * flatpak/flatpakutils.py:
685         (WebkitFlatpak.load_from_args):
686
687 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
688
689         [Flatpak] Remove now unnecessary 'hacks' for running tests
690         https://bugs.webkit.org/show_bug.cgi?id=187608
691
692         Reviewed by Philippe Normand.
693
694         We used to need to not share X11 with the sandbox when running tests
695         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
696         sandbox (we mount it on `/run/host/tmp` now).
697
698         This has the advantage of making running the MiniBrowser to display test
699         results working again.
700
701         * flatpak/flatpakutils.py:
702         (WebkitFlatpak.clean_args):
703         (WebkitFlatpak.run_in_sandbox):
704         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
705
706 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
707
708         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
709         https://bugs.webkit.org/show_bug.cgi?id=187581
710
711         Reviewed by Daniel Bates.
712
713         There are two failures in this test case:
714         1. proc.poll() doesn't return 0.
715         2. stderr is not output.
716
717         For failure #1, this is expected. the process should not exit at
718         the time. proc.poll() should return None because the process is
719         still alive.
720
721         This change added a new test to check proc.poll() becomes 0 after
722         the process successfully exits.
723
724         For failure #2, stderr is not flushed even though stdout is
725         flushed. This change uses '-u' command switch to force stdin,
726         stdout and stderr to be totally unbuffered.
727
728         * Scripts/webkitpy/port/server_process_unittest.py:
729         (TestServerProcess.test_basic): Added -u command switch. Do not
730         flush stdout. Removed the special condition for Windows. Add a new
731         test to check proc.poll() returns 0.
732         (TestServerProcess.test_process_crashing): Added -u command
733         switch. Do not flush stdout.
734
735 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
736
737         WTF::StringView::split should have an allowEmptyEntries flag
738         https://bugs.webkit.org/show_bug.cgi?id=187864
739
740         Reviewed by Konstantin Tokarev.
741
742         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
743
744 2018-07-23  Ben Richards  <benton_richards@apple.com>
745
746         We should cache the compiled sandbox profile in a data vault
747         https://bugs.webkit.org/show_bug.cgi?id=184991
748
749         Reviewed by Ryosuke Niwa.
750
751         Added trace points for sandbox initialization
752
753         * Tracing/SystemTracePoints.plist:
754
755 2018-07-23  Zalan Bujtas  <zalan@apple.com>
756
757         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
758         https://bugs.webkit.org/show_bug.cgi?id=187924
759         <rdar://problem/41745884>
760
761         Reviewed by Simon Fraser.
762
763         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
764
765         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
766         (createBitmapContextFromWebView):
767
768 2018-07-23  Chris Dumez  <cdumez@apple.com>
769
770         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
771         https://bugs.webkit.org/show_bug.cgi?id=187910
772         <rdar://problem/42356526>
773
774         Reviewed by Brent Fulgham.
775
776         Add API test coverage.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
780         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
781         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
782         (TEST):
783         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
784
785 2018-07-23  Daniel Bates  <dabates@apple.com>
786
787         test-webkitpy should take configuration command line options
788         https://bugs.webkit.org/show_bug.cgi?id=187872
789
790         Reviewed by David Kilzer.
791
792         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
793         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
794         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
795
796         * BuildSlaveSupport/build.webkit.org-config/steps.py:
797         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
798         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
799         * Scripts/webkitpy/test/main.py:
800         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
801         the specified configuration is None then we fall back to using the default configuration (as set
802         by script set-webkit-configuration).
803         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
804         with a Debug configuration and a Release configuration, respectively
805         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
806         the command line options. It may be None if neither --debug nor --release were passed.
807
808 2018-07-23  Commit Queue  <commit-queue@webkit.org>
809
810         Unreviewed, rolling out r233030.
811         https://bugs.webkit.org/show_bug.cgi?id=187904
812
813         Broke tarball builds (Requested by mcatanzaro on #webkit).
814
815         Reverted changeset:
816
817         "run-gtk-tests (glib/common.py) cannot determine build
818         directory when webKitBranchBuild=true"
819         https://bugs.webkit.org/show_bug.cgi?id=185643
820         https://trac.webkit.org/changeset/233030
821
822 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
823
824         Fix lldb summarizers for HashMaps and HashSets
825         https://bugs.webkit.org/show_bug.cgi?id=187883
826
827         Reviewed by Dan Bates.
828         
829         HashMap and HashSet summarizers were broken in various ways.
830         
831         The 'type summary add -x' regexp needs to match at the start and end of the string
832         to avoid finding types nested inside other templates.
833         
834         The HashTable synthetic child code incorrectly used the type of the key, rather than
835         the value when synthesizing children.
836         
837         Add HashMap and HashSet summarizers.
838
839         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
840
841         * lldb/lldbWebKitTester/main.cpp:
842         (testSummaryProviders):
843         * lldb/lldb_webkit.py:
844         (__lldb_init_module):
845         (__lldb_init_module.lldb_webkit):
846         (WTFHashMap_SummaryProvider):
847         (WTFHashSet_SummaryProvider):
848         (WebCoreColorProvider._to_string_extended):
849         (WebCoreURLProvider.to_string):
850         (WTFHashMapProvider):
851         (WTFHashMapProvider.__init__):
852         (WTFHashMapProvider.tableSize):
853         (WTFHashMapProvider.keyCount):
854         (WTFHashSetProvider):
855         (WTFHashSetProvider.__init__):
856         (WTFHashSetProvider.tableSize):
857         (WTFHashSetProvider.keyCount):
858         (WTFHashTableProvider.tableSize):
859         (WTFHashTableProvider):
860         (WTFHashTableProvider.keyCount):
861         (WTFHashTableProvider.get_child_at_index):
862         (WTFHashTableProvider.update):
863         * lldb/lldb_webkit_unittest.py:
864         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
865         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
866         (TestSummaryProviders):
867         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
868         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
869         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
870
871 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
872
873         Add lldb formatters for WebCore geometry types
874         https://bugs.webkit.org/show_bug.cgi?id=187884
875
876         Reviewed by Daniel Bates.
877         
878         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
879         and LayoutRect.
880         
881         Testing is blocked by webkit.org/b/187872.
882
883         * lldb/lldbWebKitTester/main.cpp:
884         (testSummaryProviders):
885         * lldb/lldb_webkit.py:
886         (__lldb_init_module.lldb_webkit):
887         (__lldb_init_module):
888         (WebCoreLayoutRect_SummaryProvider):
889         (WebCoreIntSize_SummaryProvider):
890         (WebCoreIntPoint_SummaryProvider):
891         (WebCoreFloatSize_SummaryProvider):
892         (WebCoreFloatPoint_SummaryProvider):
893         (WebCoreIntRect_SummaryProvider):
894         (WebCoreFloatRect_SummaryProvider):
895         (WebCoreLayoutRectProvider):
896         (WebCoreLayoutRectProvider.__init__):
897         (WebCoreLayoutRectProvider.get_x):
898         (WebCoreLayoutRectProvider.get_y):
899         (WebCoreLayoutRectProvider.get_width):
900         (WebCoreLayoutRectProvider.get_height):
901         (WebCoreIntPointProvider):
902         (WebCoreIntPointProvider.__init__):
903         (WebCoreIntPointProvider.get_x):
904         (WebCoreIntPointProvider.get_y):
905         (WebCoreIntSizeProvider):
906         (WebCoreIntSizeProvider.__init__):
907         (WebCoreIntSizeProvider.get_width):
908         (WebCoreIntSizeProvider.get_height):
909         (WebCoreIntRectProvider):
910         (WebCoreIntRectProvider.__init__):
911         (WebCoreIntRectProvider.get_x):
912         (WebCoreIntRectProvider.get_y):
913         (WebCoreIntRectProvider.get_width):
914         (WebCoreIntRectProvider.get_height):
915         (WebCoreFloatPointProvider):
916         (WebCoreFloatPointProvider.__init__):
917         (WebCoreFloatPointProvider.get_x):
918         (WebCoreFloatPointProvider.get_y):
919         (WebCoreFloatSizeProvider):
920         (WebCoreFloatSizeProvider.__init__):
921         (WebCoreFloatSizeProvider.get_width):
922         (WebCoreFloatSizeProvider.get_height):
923         (WebCoreFloatRectProvider):
924         (WebCoreFloatRectProvider.__init__):
925         (WebCoreFloatRectProvider.get_x):
926         (WebCoreFloatRectProvider.get_y):
927         (WebCoreFloatRectProvider.get_width):
928         (WebCoreFloatRectProvider.get_height):
929
930 2018-07-20  John Wilander  <wilander@apple.com>
931
932         Resource Load Statistics: Enable basic functionality in experimental debug mode
933         https://bugs.webkit.org/show_bug.cgi?id=187835
934         <rdar://problem/42408590>
935
936         Reviewed by Chris Dumez.
937
938         This patch makes the experimental ITP Debug Mode feature work, at least
939         to a basic level. All of the changes to TestRunner are to support the
940         layout tests for the functionality.
941
942         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
943         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
944         (WTR::InjectedBundle::didReceiveMessageToPage):
945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
946         (WTR::TestRunner::setStatisticsDebugMode):
947         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
948         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
949         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
950         * WebKitTestRunner/InjectedBundle/TestRunner.h:
951         * WebKitTestRunner/TestController.cpp:
952         (WTR::TestController::setStatisticsDebugMode):
953         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
954         * WebKitTestRunner/TestController.h:
955         * WebKitTestRunner/TestInvocation.cpp:
956         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
957         (WTR::TestInvocation::didSetStatisticsDebugMode):
958         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
959         * WebKitTestRunner/TestInvocation.h:
960
961 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
962
963         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
964         https://bugs.webkit.org/show_bug.cgi?id=187846
965
966         Reviewed by Simon Fraser.
967
968         Fixed the bug that testRunner.execCommand was using the second argument as the value.
969
970         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
971         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
972
973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
974         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
975         (WTR::TestRunner::execCommand):
976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
977
978 2018-07-20  Dean Jackson  <dino@apple.com>
979
980         Accidentally checked in the wrong version of these files.
981
982         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
983         * lldb/lldbWebKitTester/main.cpp:
984         (testSummaryProviders):
985         * lldb/lldb_webkit_unittest.py:
986         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
987         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
988         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
989         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
990         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
991         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
992
993 2018-07-20  Dean Jackson  <dino@apple.com>
994
995         Provide an lldb type summary for WebCore::Color
996         https://bugs.webkit.org/show_bug.cgi?id=187776
997
998         Reviewed by Dan Bates.
999
1000         This time without the tests because we don't want to build
1001         all of WebKit just for python tests.
1002
1003         * lldb/lldb_webkit.py: Add a Color summary provider.
1004         (__lldb_init_module):
1005         (WebCoreColor_SummaryProvider):
1006         (WebCoreColorProvider):
1007         (WebCoreColorProvider.__init__):
1008         (WebCoreColorProvider._is_extended):
1009         (WebCoreColorProvider._is_valid):
1010         (WebCoreColorProvider._is_semantic):
1011         (WebCoreColorProvider._to_string_extended):
1012         (WebCoreColorProvider.to_string):
1013
1014 2018-07-20  Brady Eidson  <beidson@apple.com>
1015
1016         Add WKNavigation/WKNavigationAction related SPI.
1017         https://bugs.webkit.org/show_bug.cgi?id=187826
1018
1019         Reviewed by Chris Dumez.
1020
1021         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1022         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
1023         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1024         (TEST):
1025
1026 2018-07-20  Commit Queue  <commit-queue@webkit.org>
1027
1028         Unreviewed, rolling out r233943, r233988, r234004, and
1029         r234012.
1030         https://bugs.webkit.org/show_bug.cgi?id=187856
1031
1032         webkitpy tests are failing to build lldbWebKitTester
1033         (Requested by ryanhaddad on #webkit).
1034
1035         Reverted changesets:
1036
1037         "Provide an lldb type summary for WebCore::Color"
1038         https://bugs.webkit.org/show_bug.cgi?id=187776
1039         https://trac.webkit.org/changeset/233943
1040
1041         "Provide an lldb type summary for WebCore::Color"
1042         https://bugs.webkit.org/show_bug.cgi?id=187776
1043         https://trac.webkit.org/changeset/233988
1044
1045         "Provide an lldb type summary for WebCore::Color"
1046         https://bugs.webkit.org/show_bug.cgi?id=187776
1047         https://trac.webkit.org/changeset/234004
1048
1049         "Provide an lldb type summary for WebCore::Color"
1050         https://bugs.webkit.org/show_bug.cgi?id=187776
1051         https://trac.webkit.org/changeset/234012
1052
1053 2018-07-20  Philippe Normand  <pnormand@igalia.com>
1054
1055         [GTK][WPE] enable-media-capabilities websetting
1056         https://bugs.webkit.org/show_bug.cgi?id=187847
1057
1058         Reviewed by Carlos Garcia Campos.
1059
1060         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1061         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
1062
1063 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1064
1065         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
1066         https://bugs.webkit.org/show_bug.cgi?id=187798
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         Update test cases to the new API and use a destroy function and vtable in the test case of calling
1071         jsc_context_evaluate_in_object() with a JSCClass.
1072
1073         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1074         (testJSCEvaluateInObject):
1075
1076 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
1077
1078         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
1079         https://bugs.webkit.org/show_bug.cgi?id=187712
1080
1081         Reviewed by Fujii Hironori.
1082
1083         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1084         Mark result of unsigned short test case as platform-specific,
1085         since Windows' behavior is actually *less* surprising here.
1086
1087 2018-07-19  Lucas Forschler  <lforschler@apple.com>
1088
1089         Teach the AWS Lambda to use the [minified]-platforms database
1090         https://bugs.webkit.org/show_bug.cgi?id=187817
1091         
1092         Reviewed by David Kilzer.
1093
1094         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
1095         (lambda_handler): Add support for the platforms.webkit.org database
1096         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
1097         (lambda_handler): Add support for the minified-platforms.webkit.org database
1098
1099 2018-07-19  Dean Jackson  <dino@apple.com>
1100
1101         Provide an lldb type summary for WebCore::Color
1102         https://bugs.webkit.org/show_bug.cgi?id=187776
1103
1104         Dan Bates helped me with this attempted fix. Fingers crossed!
1105
1106         * Scripts/build-lldbwebkittester:
1107
1108 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
1109
1110         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
1111         https://bugs.webkit.org/show_bug.cgi?id=187786
1112
1113         Reviewed by Fujii Hironori.
1114
1115         * Scripts/webkitdirs.pm:
1116         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
1117         for WinCairo builds.
1118
1119 2018-07-19  Dean Jackson  <dino@apple.com>
1120
1121         Provide an lldb type summary for WebCore::Color
1122         https://bugs.webkit.org/show_bug.cgi?id=187776
1123
1124         Another attempted build fix for Debug.
1125
1126         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1127         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1128
1129 2018-07-19  Thomas Denney  <tdenney@apple.com>
1130
1131         [WHLSL] The interpreter doesn't support boolean short-circuiting
1132         https://bugs.webkit.org/show_bug.cgi?id=187779
1133
1134         Reviewed by Alex Christensen.
1135
1136         * WebGPUShadingLanguageRI/Evaluator.js:
1137         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
1138         * WebGPUShadingLanguageRI/Test.js:
1139         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
1140
1141 2018-07-19  Dean Jackson  <dino@apple.com>
1142
1143         Provide an lldb type summary for WebCore::Color
1144         https://bugs.webkit.org/show_bug.cgi?id=187776
1145
1146         Attempted build fix.
1147
1148         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1149
1150 2018-07-19  Brady Eidson  <beidson@apple.com>
1151
1152         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
1153         https://bugs.webkit.org/show_bug.cgi?id=187789
1154
1155         Reviewed by Andy Estes.
1156
1157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1158         (-[PSONNavigationDelegate init]):
1159         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1160
1161 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
1162
1163         [Flatpak] Let flatpak process handle SIGINT
1164         https://bugs.webkit.org/show_bug.cgi?id=187521
1165
1166         Reviewed by Philippe Normand.
1167
1168         Ensuring that flatpak process ends properly and that the sandbox is teard down.
1169         It also avoids showing usless backtrace to the end user and makes gdb
1170         much more usable.
1171
1172         Also make flatpakutils not verbose by default
1173
1174         * flatpak/flatpakutils.py:
1175         (disable_signals):
1176         (WebkitFlatpak.run_in_sandbox):
1177         (WebkitFlatpak.run_gdb):
1178
1179 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1180
1181         Unreviewed. Fix contributors entry.
1182
1183         * Scripts/webkitpy/common/config/contributors.json:
1184
1185 2018-07-18  Dean Jackson  <dino@apple.com>
1186
1187         Provide an lldb type summary for WebCore::Color
1188         https://bugs.webkit.org/show_bug.cgi?id=187776
1189
1190         Reviewed by Dan Bates.
1191
1192         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1193             to get to WebCore.
1194         * lldb/lldbWebKitTester/main.cpp:
1195         (testSummaryProviders): Create some Color objects for testing.
1196
1197         * lldb/lldb_webkit.py: Add a Color summary provider.
1198         (__lldb_init_module):
1199         (WebCoreColor_SummaryProvider):
1200         (WebCoreColorProvider):
1201         (WebCoreColorProvider.__init__):
1202         (WebCoreColorProvider._is_extended):
1203         (WebCoreColorProvider._is_valid):
1204         (WebCoreColorProvider._is_semantic):
1205         (WebCoreColorProvider._to_string_extended):
1206         (WebCoreColorProvider.to_string):
1207
1208         * lldb/lldb_webkit_unittest.py: Tests.
1209         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1210         (TestSummaryProviders):
1211         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1212         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1213         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1214         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1215
1216 2018-07-18  Truitt Savell  <tsavell@apple.com>
1217
1218         Unreviewed, rolling out r233934.
1219
1220         Revision caused 5 webkitpy failures on Mac and broke webkitpy
1221         testing on iOS simulator
1222
1223         Reverted changeset:
1224
1225         "Provide an lldb type summary for WebCore::Color"
1226         https://bugs.webkit.org/show_bug.cgi?id=187776
1227         https://trac.webkit.org/changeset/233934
1228
1229 2018-07-18  Chris Dumez  <cdumez@apple.com>
1230
1231         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1232         https://bugs.webkit.org/show_bug.cgi?id=187784
1233         <rdar://problem/42329230>
1234
1235         Reviewed by Brady Eidson.
1236
1237         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1238         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1239         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1240
1241         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1242         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1243         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1244         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1245         result.
1246
1247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1248         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1249
1250 2018-07-18  Dean Jackson  <dino@apple.com>
1251
1252         Provide an lldb type summary for WebCore::Color
1253         https://bugs.webkit.org/show_bug.cgi?id=187776
1254
1255         Reviewed by Dan Bates.
1256
1257         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1258             to get to WebCore.
1259         * lldb/lldbWebKitTester/main.cpp:
1260         (testSummaryProviders): Create some Color objects for testing.
1261
1262         * lldb/lldb_webkit.py: Add a Color summary provider.
1263         (__lldb_init_module):
1264         (WebCoreColor_SummaryProvider):
1265         (WebCoreColorProvider):
1266         (WebCoreColorProvider.__init__):
1267         (WebCoreColorProvider._is_extended):
1268         (WebCoreColorProvider._is_valid):
1269         (WebCoreColorProvider._is_semantic):
1270         (WebCoreColorProvider._to_string_extended):
1271         (WebCoreColorProvider.to_string):
1272
1273         * lldb/lldb_webkit_unittest.py: Tests.
1274         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1275         (TestSummaryProviders):
1276         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1277         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1278         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1279         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1280
1281 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1282
1283         Adding myself to contributors.json
1284
1285         Unreviewed contributors.json change.
1286
1287         * Scripts/webkitpy/common/config/contributors.json:
1288
1289 2018-07-18  Jer Noble  <jer.noble@apple.com>
1290
1291         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
1292         https://bugs.webkit.org/show_bug.cgi?id=187739
1293         <rdar://problem/42304518>
1294
1295         Reviewed by Tim Horton.
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1298         (TEST):
1299
1300 2018-07-18  Jer Noble  <jer.noble@apple.com>
1301
1302         PiP from Element Fullscreen should match AVKit's behavior
1303         https://bugs.webkit.org/show_bug.cgi?id=187623
1304         <rdar://problem/41212379>
1305
1306         Reviewed by Jon Lee.
1307
1308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1309         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
1310         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
1311         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1312         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
1313         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
1314         (TestWebKitAPI::TEST):
1315
1316 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
1317
1318         [ews-build] Add build step to run layout-test
1319         https://bugs.webkit.org/show_bug.cgi?id=187674
1320
1321         Reviewed by Lucas Forschler.
1322
1323         * BuildSlaveSupport/ews-build/steps.py:
1324         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
1325         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1326         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
1327
1328 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1329
1330         Add SPI to defer running async script until after document load
1331         https://bugs.webkit.org/show_bug.cgi?id=187748
1332         <rdar://problem/42317378>
1333
1334         Reviewed by Ryosuke Niwa and Tim Horton.
1335
1336         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
1337         executed after the DOMContentLoaded event.
1338
1339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1340         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
1341         (TEST):
1342
1343 2018-07-18  Charlie Turner  <cturner@igalia.com>
1344
1345         [WPE] Update WPEBackend in flatpak
1346         https://bugs.webkit.org/show_bug.cgi?id=187753
1347
1348         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
1349         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
1350         in the version guard,
1351
1352         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
1353
1354         This doesn't work as intended, since the C preprocessor first expands
1355         all macro arguments in the #if expression before evaluating the
1356         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
1357         lead to a syntax error and some head scratching.
1358
1359         A future patch should address the buggy macro check, when it is
1360         decided whether the assume the macro is always defined and bump
1361         the API requirements on WPEBackend, or to move the check into two
1362         conditionals to avoid the expansion problem.
1363
1364         Unreviewed build fix.
1365         
1366         * flatpak/org.webkit.WPE.yaml:
1367
1368 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
1369
1370         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
1371         https://bugs.webkit.org/show_bug.cgi?id=187747
1372
1373         Reviewed by Ryosuke Niwa.
1374         
1375         Add textInputController.attributedStringForTyping(), which returns a one-character
1376         attributed string whose attributes are the typing attributes, making it possible to
1377         test -[WebView typingAttributes].
1378         
1379         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
1380         so we can't return -typingAttributes directly.
1381
1382         * DumpRenderTree/mac/TextInputControllerMac.m:
1383         (+[TextInputController isSelectorExcludedFromWebScript:]):
1384         (-[TextInputController attributedStringForTyping]):
1385
1386 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         [GLIB] Add jsc_context_check_syntax() to GLib API
1389         https://bugs.webkit.org/show_bug.cgi?id=187694
1390
1391         Reviewed by Yusuke Suzuki.
1392
1393         Add a new test case.
1394
1395         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1396         (testJSCCheckSyntax):
1397         (main):
1398
1399 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
1400
1401         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
1402         https://bugs.webkit.org/show_bug.cgi?id=187066
1403         <rdar://problem/41609065>
1404
1405         Reviewed by Chris Dumez.
1406
1407         In r232668 we started to do reload if web process crashes by default. As we killed the web 
1408         process explicitly in this test, if web page got reloaded, messages would be sent again, 
1409         and flag set in message handler could keep the test continue to evaluate the expectation 
1410         without waiting for removeDataOfTypes to finish.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1413         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
1414         (TEST):
1415
1416 2018-07-17  Chris Dumez  <cdumez@apple.com>
1417
1418         Turn on PSON in WebKitTestRunner
1419         https://bugs.webkit.org/show_bug.cgi?id=186542
1420
1421         Reviewed by Brady Eidson.
1422
1423         Turn on PSON by default in WebKitTestRunner.
1424
1425         * WebKitTestRunner/TestOptions.h:
1426
1427 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1428
1429         Add an SPI hook to allow clients to yield document parsing and script execution
1430         https://bugs.webkit.org/show_bug.cgi?id=187682
1431         <rdar://problem/42207453>
1432
1433         Reviewed by Ryosuke Niwa.
1434
1435         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
1436         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
1437         synchronous script, or after "DOMContentLoaded").
1438
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1440         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
1441         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
1442         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
1443         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1444         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1445         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1446         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1447
1448         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
1449
1450         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
1451         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
1452         (+[ParserYieldTokenTestWebView webView]):
1453         (-[ParserYieldTokenTestWebView bundle]):
1454         (-[ParserYieldTokenTestWebView schemeHandler]):
1455         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
1456         (-[ParserYieldTokenTestWebView didFinishLoad]):
1457         (waitForDelay):
1458         (TEST):
1459         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
1460         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
1461         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
1462         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
1463         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
1464         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
1465         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
1466         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
1467
1468         Add a new test helper class to handle custom schemes via a block-based API.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
1471
1472         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
1473         script element, and then some text, images, and links.
1474
1475         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
1476
1477 2018-07-17  Truitt Savell  <tsavell@apple.com>
1478
1479         Adding myself to Contributors.json
1480
1481         Unreviewed
1482
1483         * Scripts/webkitpy/common/config/contributors.json:
1484
1485 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
1486
1487         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
1488         https://bugs.webkit.org/show_bug.cgi?id=187730
1489
1490         Reviewed by Jer Noble.
1491
1492         This regression was introduced by r233865. PIP can now only be initiated from a
1493         window that is on screen.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1496         (TestWebKitAPI::TEST):
1497
1498 2018-07-17  John Wilander  <wilander@apple.com>
1499
1500         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
1501         https://bugs.webkit.org/show_bug.cgi?id=187710
1502         <rdar://problem/42252757>
1503
1504         Reviewed by Chris Dumez.
1505
1506         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1507         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1508         (WTR::InjectedBundle::didReceiveMessageToPage):
1509         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1510         (WTR::TestRunner::setStatisticsLastSeen):
1511         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
1512         (WTR::TestRunner::setStatisticsPrevalentResource):
1513         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
1514         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1515         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
1516         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1517         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
1518         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
1519         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1520         * WebKitTestRunner/TestController.cpp:
1521         (WTR::TestController::setStatisticsLastSeen):
1522         (WTR::TestController::setStatisticsPrevalentResource):
1523         (WTR::TestController::setStatisticsVeryPrevalentResource):
1524         (WTR::TestController::setStatisticsHasHadUserInteraction):
1525         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1526         * WebKitTestRunner/TestInvocation.cpp:
1527         (WTR::TestInvocation::didSetLastSeen):
1528         (WTR::TestInvocation::didSetPrevalentResource):
1529         (WTR::TestInvocation::didSetVeryPrevalentResource):
1530         (WTR::TestInvocation::didSetHasHadUserInteraction):
1531         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
1532         * WebKitTestRunner/TestInvocation.h:
1533
1534 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
1535
1536         Fix API Test failures introduced by r233865
1537         https://bugs.webkit.org/show_bug.cgi?id=187720
1538
1539         Unreviewed APITest fix after r233865.
1540
1541         Fullscreen can now only be initiated from a window that is on screen.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1544         (TestWebKitAPI::TEST):
1545         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1546         (TestWebKitAPI::TEST):
1547
1548 2018-07-11  Dean Jackson  <dino@apple.com>
1549
1550         Allow removal of white backgrounds
1551         https://bugs.webkit.org/show_bug.cgi?id=187574
1552         <rdar://problem/41146792>
1553
1554         Reviewed by Simon Fraser.
1555
1556         Add a new menu item for punching out white backgrounds in MiniBrowser.
1557         In WebKitTestRunner, expose the new setting and hook that up to
1558         drawing a background in the WebView.
1559
1560         * MiniBrowser/mac/AppDelegate.m:
1561         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
1562
1563         * MiniBrowser/mac/SettingsController.h: Ditto.
1564         * MiniBrowser/mac/SettingsController.m:
1565         (-[SettingsController _populateMenu]):
1566         (-[SettingsController validateMenuItem:]):
1567         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
1568         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
1569
1570         * MiniBrowser/mac/WK1BrowserWindowController.m:
1571         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
1572
1573         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
1574         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
1575         (WTR::PlatformWebView::drawsBackground const):
1576         (WTR::PlatformWebView::setDrawsBackground):
1577         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
1578         (WTR::PlatformWebView::drawsBackground const):
1579         (WTR::PlatformWebView::setDrawsBackground):
1580         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
1581         set its SPI.
1582         (WTR::PlatformWebView::drawsBackground const):
1583         (WTR::PlatformWebView::setDrawsBackground):
1584         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
1585         (WTR::PlatformWebView::drawsBackground const):
1586         (WTR::PlatformWebView::setDrawsBackground):
1587
1588         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
1589         (WTR::TestController::resetPreferencesToConsistentValues):
1590         (WTR::updateTestOptionsFromTestHeader):
1591         * WebKitTestRunner/TestOptions.h:
1592         (WTR::TestOptions::hasSameInitializationOptions const):
1593
1594         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1595         (WTR::TestController::platformCreateWebView): If the option for punching
1596         out the background was set, tell the WebView to not draw its background.
1597
1598 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
1599
1600         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
1601         https://bugs.webkit.org/show_bug.cgi?id=186531
1602
1603         Reviewed by Tim Horton.
1604
1605         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
1606         visibility of the suggestions view.
1607
1608         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1609         (WTR::UIScriptController::isShowingDataListSuggestions const):
1610         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1611         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1612         (WTR::UIScriptController::isShowingDataListSuggestions const):
1613         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1614         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1615         (WTR::UIScriptController::isShowingDataListSuggestions const):
1616
1617 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1618
1619         Add --target-path option to dump-class-layout
1620         https://bugs.webkit.org/show_bug.cgi?id=187687
1621
1622         Reviewed by Simon Fraser.
1623
1624         We add an escape hatch to dump-class-layout for specifying target path directly.
1625         This `--target-path` allows us to use dump-class-layout in the other ports
1626         like JSCOnly.
1627
1628         We can dump class layout if we build the target with clang by using the following command.
1629
1630         Tools/Scripts/dump-class-layout \
1631             --architecture=x86_64 \
1632             --target-path=path/to/libJavaScriptCore.so \
1633             JavaScriptCore \
1634             ScopeNode
1635
1636         * Scripts/dump-class-layout:
1637         (main):
1638
1639 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
1640
1641         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
1642         https://bugs.webkit.org/show_bug.cgi?id=187631
1643         <rdar://problem/42164227>
1644
1645         Reviewed by Brady Eidson.
1646
1647         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1648         (TEST):
1649
1650 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1651
1652         [GLIB] Add API to evaluate code using a given object to store global symbols
1653         https://bugs.webkit.org/show_bug.cgi?id=187639
1654
1655         Reviewed by Michael Catanzaro.
1656
1657         Add a new test case.
1658
1659         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1660         (testJSCEvaluateInObject):
1661         (testJSCExceptions):
1662         (main):
1663
1664 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
1665
1666         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
1667         https://bugs.webkit.org/show_bug.cgi?id=187353
1668
1669         Reviewed by Youenn Fablet.
1670
1671         When using run-web-platform-tests, allow specifying custom WPT metadata
1672         directory. This will avoid generating such metadata-filled directory
1673         from the port-specific JSON expectations file, and instead will search
1674         for the metadata files and the include manifest inside the specified
1675         directory. The MANIFEST.json file will also be generated under there.
1676
1677         Rationale for this change is prototyping using custom metadata
1678         directories and avoiding generating all this content from a JSON file.
1679         Using this by default in the future would avoid sporradic changes in how
1680         WPT handles metadata .ini files and releases us from the obligation of
1681         adjusting the generator for every such change. This would also allow
1682         managing this metadata content in a separate repository, avoiding
1683         polluting the main webkit.org repository with thousands of .ini files.
1684
1685         If this turns out to be the preferable way of managing the metadata
1686         content, the JSON files under WebPlatformTests/ and the related code in
1687         wpt_runner.py would be removed.
1688
1689         * Scripts/webkitpy/w3c/wpt_runner.py:
1690         (parse_args):
1691         (WPTRunner._wpt_run_paths):
1692         (WPTRunner.run):
1693         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1694         (WPTRunnerTest.test_run_with_specified_options):
1695
1696 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
1697
1698         [WinCairo] run-api-tests is timing out for almost all test cases
1699         https://bugs.webkit.org/show_bug.cgi?id=187547
1700
1701         Reviewed by Fujii Hironori.
1702
1703         * Scripts/webkitpy/port/server_process.py:
1704         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1705         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
1706
1707         * Scripts/webkitpy/port/server_process_unittest.py:
1708         (TestServerProcess.test_read_after_process_exits):
1709         Add test case.
1710
1711 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1712
1713         Add TestExpectations and baselines for iOS 12
1714         https://bugs.webkit.org/show_bug.cgi?id=187628
1715
1716         Reviewed by Alexey Proskuryakov.
1717
1718         * Scripts/webkitpy/port/ios.py:
1719         (IOSPort): Bump current version to 12.
1720
1721 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1722
1723         Add TestExpectations and baselines for Mojave.
1724         https://bugs.webkit.org/show_bug.cgi?id=187620
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * Scripts/webkitpy/port/mac.py:
1729         (MacPort): Bump current version to 10.14.
1730
1731 2018-07-13  Timothy Hatcher  <timothy@apple.com>
1732
1733         Add _drawsBackground to WKWebViewConfiguration.
1734         https://bugs.webkit.org/show_bug.cgi?id=187665
1735         rdar://problem/42182268
1736
1737         Reviewed by Tim Horton.
1738
1739         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
1740         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
1741
1742 2018-07-13  Chris Dumez  <cdumez@apple.com>
1743
1744         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1745         https://bugs.webkit.org/show_bug.cgi?id=187565
1746         <rdar://problem/42095701>
1747
1748         Unreviewed WKTR fix after r233782.
1749
1750         * WebKitTestRunner/TestInvocation.cpp:
1751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1752
1753 2018-07-13  Chris Dumez  <cdumez@apple.com>
1754
1755         Reduce size of WebCore::URL
1756         https://bugs.webkit.org/show_bug.cgi?id=186820
1757         <rdar://problem/42087508>
1758
1759         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
1763         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
1764         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
1765         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1766         (TEST):
1767
1768 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1769
1770         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
1771         https://bugs.webkit.org/show_bug.cgi?id=187578
1772         <rdar://problem/42104637>
1773
1774         Reviewed by Ryosuke Niwa.
1775
1776         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
1777         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
1778         articles).
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
1782         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
1783         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1784         (TEST):
1785
1786 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1787
1788         Change my status to be a WebKit reviewer.
1789
1790         Unreviewed status update.
1791
1792         * Scripts/webkitpy/common/config/contributors.json:
1793
1794 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1795
1796         Unreviewed contributors.json update
1797
1798         Just run "validate-committer-lists -c" to canonicalize the style.
1799
1800         * Scripts/webkitpy/common/config/contributors.json:
1801
1802 2018-07-12  Alex Christensen  <achristensen@webkit.org>
1803
1804         Reduce size of WebCore::URL
1805         https://bugs.webkit.org/show_bug.cgi?id=186820
1806
1807         Reviewed by Yusuke Suzuki and Youenn Fablet.
1808
1809         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1810         (TestWebKitAPI::TEST_F):
1811
1812 2018-07-12  Brady Eidson  <beidson@apple.com>
1813
1814         Make process-swap-on-navigation an experimental feature.
1815         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
1816
1817         Reviewed by Chris Dumez.
1818
1819         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
1820
1821         * WebKitTestRunner/TestController.cpp:
1822         (WTR::TestController::createWebViewWithOptions):
1823         (WTR::TestController::resetPreferencesToConsistentValues):
1824
1825         * WebKitTestRunner/TestOptions.h:
1826         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
1827
1828 2018-07-12  Youenn Fablet  <youenn@apple.com>
1829
1830         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1831         https://bugs.webkit.org/show_bug.cgi?id=187565
1832
1833         Reviewed by Alex Christensen.
1834
1835         Added new test runner API to check for willInjectUserScriptForFrame callback.
1836
1837         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1838         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1839         (WTR::InjectedBundle::resetUserScriptInjectedCount):
1840         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
1841         (WTR::InjectedBundle::userScriptInjectedCount const):
1842         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1843         (WTR::InjectedBundlePage::InjectedBundlePage):
1844         (WTR::InjectedBundlePage::resetAfterTest):
1845         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
1846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1847         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1848         (WTR::TestRunner::userScriptInjectedCount const):
1849         (WTR::TestRunner::injectUserScript):
1850         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1851         * WebKitTestRunner/TestController.cpp:
1852         (WTR::TestController::injectUserScript):
1853         * WebKitTestRunner/TestController.h:
1854         * WebKitTestRunner/TestInvocation.cpp:
1855         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1856         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1857         (WTR::TestController::injectUserScript):
1858
1859 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
1860
1861         IndexedDB: database file of subframe cannot be removed
1862         https://bugs.webkit.org/show_bug.cgi?id=187564
1863
1864         Reviewed by Youenn Fablet.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1868         (TEST):
1869
1870 2018-07-12  Timothy Hatcher  <timothy@apple.com>
1871
1872         Make WebKit.LinkColorWithSystemAppearance work across system versions.
1873         https://bugs.webkit.org/show_bug.cgi?id=187573
1874
1875         Reviewed by Wenson Hsieh.
1876
1877         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1878         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
1879
1880 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1881
1882         [WPE] Pass the backend library name as command line parameter to the web process
1883         https://bugs.webkit.org/show_bug.cgi?id=186841
1884
1885         Reviewed by Žan Doberšek.
1886
1887         * MiniBrowser/wpe/main.cpp:
1888         (main): Stop using WPE_BACKEND_LIBRARY env var.
1889         * Scripts/run-wpe-tests:
1890         (WPETestRunner.__init__): Ditto.
1891         * Scripts/webkitpy/port/wpe.py:
1892         (WPEPort.setup_environ_for_server): Ditto.
1893         * wpe/backends/ViewBackend.cpp:
1894         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
1895         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
1896
1897 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1898
1899         [GLIB] Add API to allow creating variadic functions
1900         https://bugs.webkit.org/show_bug.cgi?id=187517
1901
1902         Reviewed by Michael Catanzaro.
1903
1904         Add test cases.
1905
1906         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1907         (testJSCFunction):
1908         (fooCreateWithFooV):
1909         (multiplyFooV):
1910
1911 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1912
1913         [GLIB] Add jsc_context_get_global_object() to GLib API
1914         https://bugs.webkit.org/show_bug.cgi?id=187515
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         Add test cases.
1919
1920         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1921         (testJSCGlobalObject):
1922         (main):
1923
1924 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1925
1926         [GLIB] Handle G_TYPE_STRV in glib API
1927         https://bugs.webkit.org/show_bug.cgi?id=187512
1928
1929         Reviewed by Michael Catanzaro.
1930
1931         Add test cases.
1932
1933         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1934         (testJSCTypes):
1935         (joinFunction):
1936         (testJSCFunction):
1937
1938 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
1939
1940         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
1941         https://bugs.webkit.org/show_bug.cgi?id=187549
1942
1943         Reviewed by Alexey Proskuryakov.
1944
1945         * BuildSlaveSupport/ews-build/factories.py:
1946         (JSCTestsFactory.__init__):
1947         * BuildSlaveSupport/ews-build/steps.py:
1948         (CompileJSCOnlyToT): Build ToT without patch.
1949         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
1950         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1951         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
1952         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
1953         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1954         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
1955         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
1956         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1957
1958 2018-07-11  Commit Queue  <commit-queue@webkit.org>
1959
1960         Unreviewed, rolling out r233742.
1961         https://bugs.webkit.org/show_bug.cgi?id=187577
1962
1963         Binary incompatible change with respect to Service Worker
1964         registration map (Requested by dydz on #webkit).
1965
1966         Reverted changeset:
1967
1968         "Reduce size of WebCore::URL"
1969         https://bugs.webkit.org/show_bug.cgi?id=186820
1970         https://trac.webkit.org/changeset/233742
1971
1972 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1973
1974         REGRESSION (231276): Attempting to copy an image fails
1975         https://bugs.webkit.org/show_bug.cgi?id=187212
1976
1977         Reviewed by Ryosuke Niwa.
1978         <rdar://problem/41540074>
1979
1980         Augmented test to include a URL where the lastPathComponent looks similar to a
1981         file URL.
1982
1983         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1984         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1985         (TestWebKitAPI::TEST):
1986
1987 2018-07-11  Alex Christensen  <achristensen@webkit.org>
1988
1989         Add SPI for immediate injection of user scripts
1990         https://bugs.webkit.org/show_bug.cgi?id=173342
1991         <rdar://problem/29202285>
1992
1993         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
1994
1995         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1996         (waitForMessage):
1997         (TEST):
1998
1999 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2000
2001         Move WHLSL spec work to the W3C GPUWeb GitHub repository
2002
2003         See https://github.com/gpuweb/WHLSL
2004
2005         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
2006         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
2007         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
2008         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
2009         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
2010
2011 2018-07-11  Dean Jackson  <dino@apple.com>
2012
2013         Force WKTR to use the light appearance
2014         https://bugs.webkit.org/show_bug.cgi?id=187572
2015         <rdar://problem/42097805>
2016
2017         Reviewed by Simon Fraser.
2018
2019         Set the NSAppearance on the NSWindow to light mode.
2020
2021         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2022         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
2023
2024 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2025
2026         Reduce size of WebCore::URL
2027         https://bugs.webkit.org/show_bug.cgi?id=186820
2028
2029         Reviewed by Yusuke Suzuki.
2030
2031         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2032         (TestWebKitAPI::TEST_F):
2033
2034 2018-07-11  Youenn Fablet  <youenn@apple.com>
2035
2036         Fix remaining Cross-Origin-Resource-Policy failures, if any
2037         https://bugs.webkit.org/show_bug.cgi?id=186761
2038         <rdar://problem/41209829>
2039
2040         Reviewed by Alex Christensen.
2041
2042         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2043         (TestWebKitAPI::TEST):
2044
2045  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2046  
2047         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
2048         https://bugs.webkit.org/show_bug.cgi?id=187358
2049  
2050         Reviewed by Alexey Proskuryakov.
2051  
2052         * BuildSlaveSupport/ews-build/factories.py:
2053         (BuildFactory.__init__):
2054         * BuildSlaveSupport/ews-build/steps.py:
2055         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
2056         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
2057         (CompileWebKitToT): Build ToT without patch.
2058         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
2059         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
2060
2061 2018-07-11  Robin Morisset  <rmorisset@apple.com>
2062
2063         [WSL] WIP, more of the spec
2064         https://bugs.webkit.org/show_bug.cgi?id=186310
2065
2066         Rubberstamped by Filip Pizlo.
2067
2068         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
2069         and started writing some of the english in the spec.
2070
2071         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
2072         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
2073
2074 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
2075
2076         [ews-build] Add build step to UnApply patch
2077         https://bugs.webkit.org/show_bug.cgi?id=187357
2078
2079         Reviewed by Alexey Proskuryakov.
2080
2081         * BuildSlaveSupport/ews-build/steps.py:
2082         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
2083         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
2084         properties will be set by build-steps for build and test.
2085         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
2086
2087 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
2088
2089         Update ARES-6.patch file accordingly for r233631.
2090         https://bugs.webkit.org/show_bug.cgi?id=187534
2091
2092         Reviewed by Saam Barati.
2093
2094         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
2095         avoid warning while applying the patch.
2096
2097         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2098
2099 2018-07-10  Tim Horton  <timothy_horton@apple.com>
2100
2101         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
2102         https://bugs.webkit.org/show_bug.cgi?id=187500
2103         <rdar://problem/41294139>
2104
2105         Reviewed by Simon Fraser.
2106
2107         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2108         (-[AnimatedResizeWebView _endAnimatedResize]):
2109         Set didEndAnimatedResize before calling super, because it makes the
2110         new test easier and doesn't affect any of the existing ones.
2111
2112         (AnimatedResizeBlocksViewportFitChanges):
2113         This doAfterNextPresentationUpdate is always called during animated resize,
2114         and then synchronously waited for, so it /must/ use
2115         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
2116         
2117         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
2118         Add a test ensuring that doAfterNextPresentationUpdate is deferred
2119         until endAnimatedResize is called.
2120
2121         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2122         (-[WKWebView _test_waitForDidFinishNavigation]):
2123         _test_waitForDidFinishNavigation is sometimes called during animated resize,
2124         and synchronously waits for a doAfterNextPresentationUpdate, so
2125         it cannot wait for the animated resize to complete.
2126
2127 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2128
2129         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
2130         https://bugs.webkit.org/show_bug.cgi?id=184441
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         All executables of TestWebKitAPI need the forwarding headers of
2135         WebCore and PAL because config.h includes
2136         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
2137
2138         The forwarding headers of WebCore are generated by
2139         generate-forwarding-headers.pl in GTK and WPE ports. The
2140         forwarding headers of PAL are generated by
2141         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
2142
2143         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
2144         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
2145         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
2146         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2147
2148 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
2149
2150         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
2151         https://bugs.webkit.org/show_bug.cgi?id=187415
2152
2153         Reviewed by Brian Burg.
2154
2155         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2156         (WebKitBrowserWindow::WebKitBrowserWindow):
2157
2158 2018-07-10  John Wilander  <wilander@apple.com>
2159
2160         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
2161         https://bugs.webkit.org/show_bug.cgi?id=187499
2162         <rdar://problem/41999431>
2163
2164         Reviewed by Chris Dumez.
2165
2166         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2167         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2168         (WTR::InjectedBundle::didReceiveMessageToPage):
2169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2170         (WTR::TestRunner::statisticsResetToConsistentState):
2171         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
2172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::TestController::statisticsResetToConsistentState):
2175         * WebKitTestRunner/TestInvocation.cpp:
2176         (WTR::TestInvocation::didResetStatisticsToConsistentState):
2177         * WebKitTestRunner/TestInvocation.h:
2178
2179 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2180
2181         Disable cross-origin-window-policy by default
2182         https://bugs.webkit.org/show_bug.cgi?id=187509
2183
2184         Reviewed by Chris Dumez.
2185
2186         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
2187
2188         * WebKitTestRunner/TestController.cpp:
2189         (WTR::TestController::resetPreferencesToConsistentValues):
2190
2191 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2192
2193         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
2194         https://bugs.webkit.org/show_bug.cgi?id=187470
2195
2196         Reviewed by Philippe Normand.
2197
2198         Never force building, the user is responsible to make that decision and the workflow is
2199         now based on external scripts so it doesn't make sense anymore. Doing that leads
2200         to ignoring the options the user passed in.
2201
2202         * flatpak/flatpakutils.py:
2203         (WebkitFlatpak.setup_dev_env):
2204
2205 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2206
2207         [Flatpak] Fix running wpt tests inside flatpak
2208         https://bugs.webkit.org/show_bug.cgi?id=187490
2209
2210         Reviewed by Philippe Normand.
2211
2212         Still not *all* passing but a big majority do.
2213
2214         * Scripts/webkitpy/w3c/wpt_runner.py:
2215         (main): Generate the /etc/hosts and mount it in flatpak as required.
2216         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
2217         (WPTRunner._prepare_wpt_checkout): Deleted.
2218         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
2219         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
2220         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
2221         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
2222
2223 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2224
2225         [Flatpak] Use logging to print debug information
2226         https://bugs.webkit.org/show_bug.cgi?id=187496
2227
2228         Reviewed by Philippe Normand.
2229
2230         * flatpak/flatpakutils.py:
2231         (WebkitFlatpak.load_from_args):
2232         (WebkitFlatpak.clean_args):
2233         (WebkitFlatpak.run_in_sandbox):
2234
2235 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2236
2237         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2238         https://bugs.webkit.org/show_bug.cgi?id=187425
2239         rdar://problem/39948240
2240         rdar://problem/41796865
2241
2242         Reviewed by Tim Horton.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2245         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2246
2247 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2248
2249         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2250         https://bugs.webkit.org/show_bug.cgi?id=187442
2251
2252         Reviewed by Daniel Bates.
2253         
2254         Synthetic padding members were shown with the wrong offset because they used the
2255         absolute offset rather than the class-relative offset. This didn't change the padding
2256         math, but made the output confusing.
2257         
2258         Also add support for showing empty bits in bitfields, and fix computation of padding
2259         after bitfields. Empty bits are computed by inserting a bit padding member after
2260         a bitfield that is not followed by another bitfield (making the assumption that bit
2261         padding will fill to the next byte boundary).
2262         
2263         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
2264         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
2265         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
2266         this allows byte padding following the bitfield to be computed correctly.
2267         
2268         Add or modify test to cover these issues.
2269
2270         * lldb/dump_class_layout_unittest.py:
2271         (serial_test_ClassWithPaddedBitfields):
2272         (serial_test_MemberHasBitfieldPadding):
2273         (serial_test_InheritsFromClassWithPaddedBitfields):
2274         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2275         (avoidClassDeadStripping):
2276         * lldb/lldb_dump_class_layout.py:
2277         (ClassLayoutBase):
2278         (ClassLayoutBase._to_string_recursive):
2279         (ClassLayout._parse):
2280         (ClassLayout._compute_padding_recursive):
2281
2282 2018-07-09  Youenn Fablet  <youenn@apple.com>
2283
2284         StringView operator==(char*) should check the length of the string
2285         https://bugs.webkit.org/show_bug.cgi?id=187422
2286
2287         Reviewed by Chris Dumez.
2288
2289         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2290         (TestWebKitAPI::equal2):
2291         (TestWebKitAPI::TEST):
2292
2293 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
2294
2295         [WinCairo] httpd service install needs to precede server start
2296         https://bugs.webkit.org/show_bug.cgi?id=187283
2297
2298         Reviewed by Daniel Bates.
2299
2300         * Scripts/webkitpy/port/base.py:
2301         (Port.check_build):
2302         Remove unused parameter `needs_http`.
2303         
2304         (Port.check_sys_deps):
2305         (Port.start_http_server):
2306         Move `check_httpd` call.
2307
2308         * Scripts/webkitpy/port/win.py:
2309         (WinPort.check_httpd): Added.
2310         (WinCairoPort.check_httpd): Deleted.
2311         Move `httpd -k install` logic to common Windows location.
2312
2313         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2314         (Manager._set_up_run):
2315         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2316         * Scripts/webkitpy/port/gtk.py:
2317         (GtkPort.check_sys_deps):
2318         * Scripts/webkitpy/port/ios_simulator.py:
2319         (IOSSimulatorPort.check_sys_deps):
2320         * Scripts/webkitpy/port/mock_drt.py:
2321         (MockDRTPort.check_build):
2322         (MockDRTPort.check_sys_deps):
2323         * Scripts/webkitpy/port/port_testcase.py:
2324         (PortTestCase.integration_test_check_sys_deps):
2325         (test_check_build):
2326         * Scripts/webkitpy/port/test.py:
2327         * Scripts/webkitpy/port/wpe.py:
2328         (WPEPort.check_sys_deps):
2329         * Scripts/webkitpy/tool/commands/perfalizer.py:
2330         (PerfalizerTask.run):
2331         Remove `needs_http` arguments.
2332
2333 2018-07-09  Philippe Normand  <pnormand@igalia.com>
2334
2335         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
2336         
2337         * flatpak/org.webkit.WebKit.yaml:
2338
2339 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2340
2341         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
2342         https://bugs.webkit.org/show_bug.cgi?id=187384
2343
2344         Reviewed by Philippe Normand.
2345
2346         And make it usable inside the sandbox even when
2347         perl is launched "tainted" (as the PERL5LIB won't
2348         work otherwise).
2349
2350         * flatpak/flatpakutils.py:
2351         (WebkitFlatpak.run_in_sandbox):
2352         * flatpak/org.webkit.WebKit.yaml:
2353
2354 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2355
2356         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
2357         https://bugs.webkit.org/show_bug.cgi?id=187400
2358
2359         Reviewed by Philippe Normand.
2360
2361         This is where it is expected to be when it is a symlink,
2362         without mounting it the websocket python server can't work
2363         inside the sandbox.
2364
2365         * flatpak/flatpakutils.py:
2366         (WebkitFlatpak.run_in_sandbox):
2367
2368 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
2369
2370         run-benchmark should run ARES-6 1.0.1
2371         https://bugs.webkit.org/show_bug.cgi?id=187452
2372
2373         Reviewed by Sam Weinig.
2374         
2375         We forgot to update this when we released 1.0.1!
2376
2377         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2378
2379 2018-07-07  Youenn Fablet  <youenn@apple.com>
2380
2381         WPT importer should create dummy HTML files for *.window.js script files
2382         https://bugs.webkit.org/show_bug.cgi?id=187426
2383
2384         Reviewed by Ryosuke Niwa.
2385
2386         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
2387         Do the same strategy as done for worker.js/any.js files.
2388
2389         * Scripts/webkitpy/w3c/test_importer.py:
2390         (TestImporter.write_html_files_for_templated_js_tests):
2391
2392 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2393
2394         Introduce a layout milestone to track when the document contains a large number of rendered characters
2395         https://bugs.webkit.org/show_bug.cgi?id=187412
2396         <rdar://problem/41744338>
2397
2398         Reviewed by Ryosuke Niwa.
2399
2400         Add a new API test to check that we observe the new rendering milestone in an article-like document.
2401
2402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2403         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
2404         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2405         (TEST):
2406
2407 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
2408
2409         dump-class-layout reports wrong padding in many cases
2410         https://bugs.webkit.org/show_bug.cgi?id=185801
2411
2412         Reviewed by Dan Bates.
2413         
2414         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
2415         the patch from bug 187141.
2416         
2417         Move the code that uses lldb to fetch the class layout to its own module,
2418         lldb_dump_class_layout.py, so it can be unit tested. Change this code
2419         to build up a data structure for the class. This is necessary since correct
2420         padding computation is easier with second traversal over the data structure.
2421         
2422         Try to deal with the empty base class optimization, which is necessary to report
2423         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
2424         
2425         The ClassLayoutBase class knows how to test for equality and generate a string
2426         or string list representation of itself. The derived ClassLayout class knows
2427         how to build up the class layout using the lldb Python bindings.
2428         
2429         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
2430         have to make a new one for each unit test. The tests have to run serially.
2431         
2432         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
2433         dump-class-layout.
2434
2435         * Scripts/dump-class-layout:
2436         (main):
2437         * lldb/dump_class_layout_unittest.py:
2438         (destroy_cached_debug_session):
2439         (TestDumpClassLayout):
2440         (TestDumpClassLayout.setUpClass):
2441         (TestDumpClassLayout.setUp):
2442         (TestDumpClassLayout.serial_test_BasicClassLayout):
2443         (serial_test_PaddingBetweenClassMembers):
2444         (serial_test_BoolPaddingClass):
2445         (serial_test_ClassWithEmptyClassMembers):
2446         (serial_test_SimpleVirtualClass):
2447         (serial_test_SimpleVirtualClassWithNonVirtualBase):
2448         (serial_test_InterleavedVirtualNonVirtual):
2449         (serial_test_ClassWithTwoVirtualBaseClasses):
2450         (serial_test_ClassWithClassMembers):
2451         (serial_test_ClassWithBitfields):
2452         (serial_test_ClassWithUniquePtrs):
2453         (serial_test_ClassWithOptionals):
2454         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
2455         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2456         (EmptyClass::doStuff):
2457         (VirtualBaseClass::~VirtualBaseClass):
2458         (VirtualBaseClass2::~VirtualBaseClass2):
2459         (SimpleVirtualClass::~SimpleVirtualClass):
2460         (SimpleVirtualClass::doStuff):
2461         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
2462         (SimpleVirtualClassWithNonVirtualBase::doStuff):
2463         (avoidClassDeadStripping):
2464         * lldb/lldb_dump_class_layout.py:
2465         (ansi_colors):
2466         (ClassLayoutBase):
2467         (ClassLayoutBase.__init__):
2468         (ClassLayoutBase.__ne__):
2469         (ClassLayoutBase.__eq__):
2470         (ClassLayoutBase._to_string_recursive):
2471         (ClassLayoutBase.as_string_list):
2472         (ClassLayoutBase.as_string):
2473         (ClassLayoutBase.dump):
2474         (ClassLayoutExpected):
2475         (ClassLayoutExpected.__init__):
2476         (ClassLayout):
2477         (ClassLayout.__init__):
2478         (ClassLayout._has_polymorphic_base_class):
2479         (ClassLayout._parse):
2480         (ClassLayout._probably_has_empty_base_class_optimization):
2481         (ClassLayout._compute_padding_recursive):
2482         (ClassLayout._compute_padding):
2483         (LLDBDebuggerInstance):
2484         (LLDBDebuggerInstance.__init__):
2485         (LLDBDebuggerInstance.__del__):
2486         (LLDBDebuggerInstance._get_first_file_architecture):
2487         (LLDBDebuggerInstance.layout_for_classname):
2488         (ClassLayoutDumper): Deleted.
2489         (ClassLayoutDumper.__init__): Deleted.
2490         (ClassLayoutDumper._get_first_file_architecture): Deleted.
2491         (ClassLayoutDumper.verify_type): Deleted.
2492         (ClassLayoutDumper.verify_type_recursive): Deleted.
2493         (ClassLayoutDumper._class_layout_as_string): Deleted.
2494         (ClassLayoutDumper.dump_to_string): Deleted.
2495         (ClassLayoutDumper.dump): Deleted.
2496
2497 2018-07-06  Christopher Reid  <chris.reid@sony.com>
2498
2499         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
2500         https://bugs.webkit.org/show_bug.cgi?id=187167
2501
2502         Reviewed by Alex Christensen.
2503
2504         A null byte was written past the end of the buffer causing the crash.
2505         Some of the heap allocated buffers were also not getting deleted.
2506
2507         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2508
2509 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
2510
2511         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
2512         https://bugs.webkit.org/show_bug.cgi?id=187401
2513
2514         Reviewed by Philippe Normand.
2515
2516         * flatpak/org.webkit.WebKit.yaml:
2517
2518 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
2519
2520         [ews-build] EWS should run javascriptcore tests
2521         https://bugs.webkit.org/show_bug.cgi?id=187365
2522
2523         Reviewed by David Kilzer.
2524
2525         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
2526         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2527         * BuildSlaveSupport/ews-build/factories.py:
2528
2529 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2530
2531         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
2532         https://bugs.webkit.org/show_bug.cgi?id=187383
2533
2534         Reviewed by Žan Doberšek.
2535
2536         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
2537         quite the main loop when the message is received, which happens before the run js operation has been
2538         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
2539         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
2540         fix it. We should wait for the js run to complete, instead of the message.
2541
2542         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2543         (UserScriptMessageTest::scriptMessageReceived):
2544         (UserScriptMessageTest::waitUntilMessageReceived):
2545         (UserScriptMessageTest::runJavaScriptFinished):
2546         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2547
2548 2018-07-05  Youenn Fablet  <youenn@apple.com>
2549
2550         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
2551         https://bugs.webkit.org/show_bug.cgi?id=187346
2552         <rdar://problem/41773974>
2553
2554         Reviewed by Ryosuke Niwa.
2555
2556         * WebKitTestRunner/TestController.cpp:
2557         (WTR::TestController::resetStateToConsistentValues):
2558         (WTR::TestController::setBlockAllPlugins):
2559         When not blocked, set the load policy to allow once.
2560         * WebKitTestRunner/TestController.h:
2561
2562 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2563
2564         [ews-build] Bindings-tests-EWS should output result in json
2565         https://bugs.webkit.org/show_bug.cgi?id=187330
2566
2567         Reviewed by David Kilzer.
2568
2569         * BuildSlaveSupport/ews-build/steps.py:
2570         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
2571         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2572
2573 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2574
2575         [ews-build] WebKitPy-Tests-EWS should output result in json
2576         https://bugs.webkit.org/show_bug.cgi?id=187331
2577
2578         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
2579
2580 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews-build] WebKitPy-Tests-EWS should output result in json
2583         https://bugs.webkit.org/show_bug.cgi?id=187331
2584
2585         Reviewed by David Kilzer.
2586
2587         * BuildSlaveSupport/ews-build/steps.py:
2588         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
2589         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2590
2591 2018-07-05  Philippe Normand  <pnormand@igalia.com>
2592
2593         [Flatpak] Add gst-libav to dependencies
2594         https://bugs.webkit.org/show_bug.cgi?id=187340
2595
2596         Reviewed by Žan Doberšek.
2597
2598         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
2599         clones because the FFMPeg git server doesn't support shallow
2600         clones.
2601
2602 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
2603
2604         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
2605         https://bugs.webkit.org/show_bug.cgi?id=187322
2606
2607         Reviewed by Žan Doberšek.
2608
2609         * flatpak/flatpakutils.py:
2610         (WebkitFlatpak.__init__):
2611
2612 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
2613
2614         Unreviewed, rolling out r233511.
2615
2616         Proper fix provided in bug #187322
2617
2618         Reverted changeset:
2619
2620         "Unreviewed. Fixing a call in flatpakutils.py to
2621         PortFactory.get(),"
2622         https://trac.webkit.org/changeset/233511
2623
2624 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
2625
2626         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
2627         enforcing the passed platform argument to always be lowercase, as is
2628         expected from the PortFactory code.
2629
2630         * flatpak/flatpakutils.py:
2631         (WebkitFlatpak.clean_args):
2632
2633 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2634
2635         Introduce PLATFORM(IOSMAC)
2636         https://bugs.webkit.org/show_bug.cgi?id=187315
2637
2638         Reviewed by Dan Bernstein.
2639
2640         * TestWebKitAPI/Configurations/Base.xcconfig:
2641         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2642
2643 2018-07-03  Brady Eidson  <beidson@apple.com>
2644
2645         WebKit.ResponsivenessTimerCrash sometimes fails.
2646         https://bugs.webkit.org/show_bug.cgi?id=187314
2647
2648         Reviewed by Tim Horton.
2649
2650         Actually unregister observers from objects we're about to destroy before destroying them.
2651
2652         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
2653         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
2654
2655 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2656
2657         update-webkitgtk-flatpak fails if running with python2
2658         https://bugs.webkit.org/show_bug.cgi?id=187240
2659
2660         Reviewed by Michael Catanzaro.
2661
2662         urllib.urlretrieve of Python2 sends invalid requests. Use
2663         urllib2.urlopen instead.
2664
2665         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
2666         urllib.request.urlopen for Python3.
2667         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
2668         temporary file.
2669
2670 2018-07-03  Chris Dumez  <cdumez@apple.com>
2671
2672         Make CallbackMap::invalidate() safe to re-enter
2673         https://bugs.webkit.org/show_bug.cgi?id=187298
2674         <rdar://problem/41057167>
2675
2676         Reviewed by Geoffrey Garen.
2677
2678         Add API test coverage.
2679
2680         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
2681         (TEST):
2682
2683 2018-07-03  Chris Dumez  <cdumez@apple.com>
2684
2685         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
2686         https://bugs.webkit.org/show_bug.cgi?id=187270
2687         <rdar://problem/40674034>
2688
2689         Reviewed by Geoffrey Garen.
2690
2691         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
2692         expected environment variable in the test driver.
2693
2694         * Scripts/webkitpy/port/driver.py:
2695         (Driver._setup_environ_for_driver):
2696
2697 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
2698
2699         Video sometimes flickers when playing to AppleTV
2700         https://bugs.webkit.org/show_bug.cgi?id=187193
2701         <rdar://problem/40153865>
2702
2703         Unreviewed, fix test broken by r233435.
2704
2705         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2706         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
2707         category because it doesn't necessarily happen synchronously.
2708         (TestWebKitAPI::TEST):
2709
2710 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
2711
2712         Unreviewed, add myself as a WebKit committer.
2713
2714         And canonicalize the file as suggested by `check-webkit-style`
2715
2716         * Scripts/webkitpy/common/config/contributors.json:
2717
2718 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2719
2720         check-webkit-style: Run the tool without SVN client.
2721         https://bugs.webkit.org/show_bug.cgi?id=187294
2722
2723         Reviewed by Daniel Bates.
2724
2725         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
2726         Using Git repository is acceptable workflow according to the wording on:
2727         <https://webkit.org/getting-the-code/#checking-out-with-git>
2728         and using Subversion is considered optional by following link:
2729         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
2730         This patch makes it so that people with only a Git checkout of WebKit that commit using
2731         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
2732
2733         * Scripts/webkitpy/common/checkout/scm/svn.py:
2734         (SVN.in_working_directory):
2735
2736 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2737
2738         Remove old JSCTestsFactory
2739
2740         Follow-up fix to r233471.
2741
2742 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-build] Add support for JSC-Tests-EWS
2745         https://bugs.webkit.org/show_bug.cgi?id=187201
2746
2747         Reviewed by Lucas Forschler.
2748
2749         * BuildSlaveSupport/ews-build/factories.py:
2750         (JSCTestsFactory): Added JSCTestsFactory.
2751         * BuildSlaveSupport/ews-build/steps.py:
2752         (CompileJSCOnly): Command to compile JSC.
2753         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2754         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
2755
2756 2018-07-03  Zalan Bujtas  <zalan@apple.com>
2757
2758         [LFC] Add test-list file for regression testing
2759         https://bugs.webkit.org/show_bug.cgi?id=187296
2760
2761         Reviewed by Antti Koivisto.
2762
2763         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
2764
2765         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
2766
2767 2018-07-03  John Wilander  <wilander@apple.com>
2768
2769         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
2770         https://bugs.webkit.org/show_bug.cgi?id=187277
2771         <rdar://problem/41745510>
2772
2773         Reviewed by Chris Dumez.
2774
2775         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2776         (WTR::TestController::getAllStorageAccessEntries):
2777
2778 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2779
2780         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
2781         https://bugs.webkit.org/show_bug.cgi?id=187280
2782
2783         Reviewed by Tim Horton.
2784
2785         Add a missing `adoptNS()`.
2786
2787         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2788         (TestWebKitAPI::TEST):
2789
2790 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
2791
2792         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
2793         https://bugs.webkit.org/show_bug.cgi?id=187228
2794         <rdar://problem/40967280>
2795
2796         Reviewed by Brent Fulgham.
2797
2798         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
2799
2800         * WebKitTestRunner/mac/TestControllerMac.mm:
2801         (WTR::allowedFontFamilySet):
2802
2803 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
2804
2805         run-benchmark should include the version number of MotionMark's results
2806         https://bugs.webkit.org/show_bug.cgi?id=187274
2807
2808         Reviewed by Jon Lee.
2809
2810         Append the version number as a part of the suite name.
2811
2812         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2813
2814 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2815
2816         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
2817         https://bugs.webkit.org/show_bug.cgi?id=187253
2818
2819         Reviewed by Tim Horton.
2820
2821         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
2822
2823         * DumpRenderTree/TestRunner.cpp:
2824         (setSpellCheckerResultsCallback):
2825
2826         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
2827
2828         (TestRunner::staticFunctions):
2829         (setSpellCheckerTextReplacementsCallback): Deleted.
2830         * DumpRenderTree/TestRunner.h:
2831         * DumpRenderTree/mac/TestRunnerMac.mm:
2832         (TestRunner::setSpellCheckerResults):
2833         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2834         * DumpRenderTree/win/TestRunnerWin.cpp:
2835         (TestRunner::setSpellCheckerResults):
2836         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2837         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
2838         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2839         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
2840         (-[LayoutTestTextCheckingResult grammarDetails]):
2841         (-[LayoutTestSpellChecker reset]):
2842         (-[LayoutTestSpellChecker results]):
2843         (-[LayoutTestSpellChecker setResults:]):
2844         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
2845
2846         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
2847
2848         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2849
2850         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
2851         outpointers if applicable.
2852
2853         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
2854
2855         Added support for simulating asynchronous spell checking.
2856
2857         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
2858         (-[LayoutTestSpellChecker replacements]): Deleted.
2859         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
2860         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
2861
2862 2018-07-02  Brady Eidson  <beidson@apple.com>
2863
2864         Another unreviewed followup to:
2865         Crash notifying observers of responsiveness state change
2866
2867         * TestWebKitAPI/cocoa/TestWKWebView.h:
2868         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2869         (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
2870           test on iOS for other reasons.
2871
2872 2018-07-02  Brady Eidson  <beidson@apple.com>
2873
2874         Unreviewed followup to:
2875         Crash notifying observers of responsiveness state change
2876
2877         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.
2878
2879 2018-07-02  Brady Eidson  <beidson@apple.com>
2880
2881         Crash notifying observers of responsiveness state change
2882         <rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262
2883
2884         Reviewed by Tim Horton.
2885
2886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2887         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.
2888         (-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
2889         (TestWebKitAPI::TEST):
2890         * TestWebKitAPI/cocoa/TestWKWebView.h:
2891         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2892         (-[TestWKWebView typeCharacter:]):
2893         (-[TestWKWebView hostWindow]):
2894
2895 2018-07-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2896
2897         [WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
2898         https://bugs.webkit.org/show_bug.cgi?id=187218
2899
2900         Reviewed by Philippe Normand.
2901
2902         Using the webkitpy Config module, if the build type is not passed on the command line, we
2903         read it from WebKitBuild/Configuration and respect it.
2904
2905         * flatpak/flatpakutils.py:
2906         (WebkitFlatpak.__init__):
2907         (WebkitFlatpak.clean_args):
2908
2909 2018-07-02  Zan Dobersek  <zdobersek@igalia.com>
2910
2911         [WPE] Add touch support to WindowViewBackend
2912         https://bugs.webkit.org/show_bug.cgi?id=187245
2913
2914         Reviewed by Carlos Garcia Campos.
2915
2916         Add touch input support to the WindowViewBackend implementation,
2917         plugging into the Wayland protocol in order to get properly notified
2918         about these events, and then dispatching them against the appropriate
2919         wpe_view_backend object so that WebKit can process them.
2920
2921         * wpe/backends/ViewBackend.cpp:
2922         (WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):
2923         * wpe/backends/ViewBackend.h:
2924         * wpe/backends/WindowViewBackend.cpp:
2925         * wpe/backends/WindowViewBackend.h:
2926
2927 2018-07-02  Rob Buis  <rbuis@igalia.com>
2928
2929         [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
2930         https://bugs.webkit.org/show_bug.cgi?id=186838
2931
2932         This URL constructor expects canonicalized input, so fix the passed URL. I missed
2933         this one some weeks ago since I had an older checkout.
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2938         (TestWebKitAPI::TEST):
2939
2940 2018-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2941
2942         [macOS] Text replacements that end with symbols are expanded immediately
2943         https://bugs.webkit.org/show_bug.cgi?id=187225
2944         <rdar://problem/41112433>
2945
2946         Reviewed by Darin Adler.
2947
2948         Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
2949         layout test for an example of its usage.
2950
2951         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2952         * DumpRenderTree/TestRunner.cpp:
2953         (setSpellCheckerTextReplacementsCallback):
2954
2955         Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
2956         maps a string representing an input to the NSSpellChecker to some information describing the spell checking
2957         result that LayoutTestSpellChecker will return.
2958
2959         (TestRunner::staticFunctions):
2960         * DumpRenderTree/TestRunner.h:
2961         * DumpRenderTree/mac/DumpRenderTree.mm:
2962         (resetWebViewToConsistentStateBeforeTesting):
2963
2964         Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.
2965
2966         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
2967         * DumpRenderTree/mac/TestRunnerMac.mm:
2968         (TestRunner::setSpellCheckerLoggingEnabled):
2969         (TestRunner::setSpellCheckerTextReplacements):
2970
2971         These testRunner methods ensure that `-[NSSpellChecker sharedSpellChecker]` is swizzled to return our mock
2972         LayoutTestSpellChecker instance before calling into it.
2973
2974         * DumpRenderTree/win/TestRunnerWin.cpp:
2975         (TestRunner::setSpellCheckerTextReplacements):
2976         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
2977         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.
2978
2979         Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
2980         (modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.
2981
2982         (existingGlobalLayoutTestSpellChecker):
2983         (ensureGlobalLayoutTestSpellChecker):
2984         (stringForCorrectionResponse):
2985         (nsTextCheckingType):
2986         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
2987         (-[LayoutTestTextCheckingResult range]):
2988         (-[LayoutTestTextCheckingResult resultType]):
2989         (-[LayoutTestTextCheckingResult replacementString]):
2990         (-[LayoutTestTextCheckingResult description]):
2991
2992         LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
2993         by the layout test.
2994
2995         (+[LayoutTestSpellChecker installIfNecessary]):
2996         (+[LayoutTestSpellChecker uninstallAndReset]):
2997
2998         Helper methods to begin and end swizzling the shared NSSpellChecker.
2999
3000         (-[LayoutTestSpellChecker reset]):
3001
3002         Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
3003         turning off logging for recorded spellchecking responses).
3004
3005         (-[LayoutTestSpellChecker replacements]):
3006         (-[LayoutTestSpellChecker setReplacements:]):
3007         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):
3008
3009         Helper method to take a `JSObjectRef` supplied by the test runner and transform it into a map of spell checking
3010         string inputs to LayoutTestTextCheckingResults.
3011
3012         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
3013
3014         Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
3015         logic to perform spellchecking.
3016
3017         (-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):
3018
3019         Reimplement the original functionality in DumpRenderTreeSpellChecker to make `-recordResponse:…` print to stdout
3020         by overriding the method and printing if the `-spellCheckerLoggingEnabled` property has been set to YES.
3021
3022         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3023
3024 2018-07-01  Thibault Saunier  <tsaunier@igalia.com>
3025
3026         [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
3027         https://bugs.webkit.org/show_bug.cgi?id=187232
3028
3029         Reviewed by Michael Catanzaro.
3030
3031         The place where host tmp folder is mounted changed to /run/host/ we
3032         need to take that into account.
3033
3034         Also explicitely close temporary files as relying on garbage collection to
3035         remove them is a bad idea.
3036
3037         Also minor optimization avoiding to compile regex for each backtrace
3038         retrieval.
3039
3040         * Scripts/webkitpy/port/linux_get_crash_log.py:
3041         (GDBCrashLogGenerator):
3042         (GDBCrashLogGenerator._get_tmp_file_name):
3043         (GDBCrashLogGenerator._get_trace_from_systemd):
3044
3045 2018-06-30  Daniel Bates  <dabates@apple.com>
3046
3047         test-webkitpy never rebuilds lldbWebKitTester
3048         https://bugs.webkit.org/show_bug.cgi?id=187229
3049
3050         Reviewed by David Kilzer.
3051
3052         Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
3053
3054         Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
3055         exist in the build products directory for the active configuration (e.g. Debug); => we do not
3056         build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
3057         Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
3058         that we have an up-to-date build of lldbWebKitTester.
3059
3060         * Scripts/webkitpy/test/main.py:
3061         (Tester._run_tests):
3062         (_find_lldb_webkit_tester): Deleted.
3063
3064 2018-06-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3065
3066         [CMake] build-webkit should be able to enable address sanitizer
3067         https://bugs.webkit.org/show_bug.cgi?id=187222
3068
3069         Reviewed by Daniel Bates.
3070
3071         If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
3072         -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
3073
3074         This also works for build-jsc.
3075
3076         * Scripts/webkitdirs.pm:
3077         (generateBuildSystemFromCMakeProject):
3078
3079 2018-06-30  Thibault Saunier  <tsaunier@igalia.com>
3080
3081         Make check_flatpak() not verbose when only trying to run command inside flatpak
3082         https://bugs.webkit.org/show_bug.cgi?id=187187
3083
3084         Reviewed by Michael Catanzaro.
3085
3086         * flatpak/flatpakutils.py:
3087         (run_in_sandbox_if_available):
3088
3089 2018-06-29  Daniel Bates  <dabates@apple.com>
3090
3091         build-webkit: Perl "use of uninitialized value $previousContents"
3092         https://bugs.webkit.org/show_bug.cgi?id=185776
3093
3094         Reviewed by Michael Catanzaro.
3095
3096         Fixes an issue where reading an empty cached argument file would cause
3097         Perl "uninitialized value" warnings of the form:
3098             Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
3099             Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
3100
3101         * Scripts/webkitdirs.pm:
3102         (isCachedArgumentfileOutOfDate):
3103
3104 2018-06-29  Daniel Bates  <dabates@apple.com>
3105
3106         Perl uninitialized value $isEnabled when running build-jsc using a CMake build
3107         https://bugs.webkit.org/show_bug.cgi?id=187208
3108
3109         Reviewed by Tim Horton.
3110
3111         Share logic for computing the feature flags to enable in CMake with both script
3112         build-webkit and script build-jsc instead of duplicating it. This also fixes a
3113         bug in the version of this logic in build-jsc that was inadvertently not updated
3114         in r222394. In r222394 we removed the notion of a default value for a feature flag
3115         listed in webkitperl::FeatureList.
3116
3117         We keep the current behavior of build-jsc and leave it up to the build system
3118         to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.
3119
3120         * Scripts/build-jsc:
3121         (buildMyProject):
3122         (cMakeArgsFromFeatures): Deleted.
3123         * Scripts/build-webkit:
3124         (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
3125         * Scripts/webkitdirs.pm:
3126         (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
3127         with build-jsc.
3128
3129 2018-06-29  Tim Horton  <timothy_horton@apple.com>
3130
3131         Add -apple-color-filter and system appearance toggles to MiniBrowser
3132         https://bugs.webkit.org/show_bug.cgi?id=187210
3133
3134         Reviewed by Simon Fraser.
3135
3136         * MiniBrowser/mac/AppDelegate.m:
3137         (defaultConfiguration):
3138         * MiniBrowser/mac/SettingsController.h:
3139         * MiniBrowser/mac/SettingsController.m:
3140         (-[SettingsController _populateMenu]):
3141         (-[SettingsController validateMenuItem:]):
3142         (-[SettingsController toggleAppleColorFilterEnabled:]):
3143         (-[SettingsController appleColorFilterEnabled]):
3144         (-[SettingsController toggleUseSystemAppearance:]):
3145         (-[SettingsController useSystemAppearance]):
3146         * MiniBrowser/mac/WK1BrowserWindowController.m:
3147         (-[WK1BrowserWindowController didChangeSettings]):
3148         * MiniBrowser/mac/WK2BrowserWindowController.m:
3149         (-[WK2BrowserWindowController didChangeSettings]):
3150
3151 2018-06-29  Aditya Keerthi  <akeerthi@apple.com>
3152
3153         [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
3154         https://bugs.webkit.org/show_bug.cgi?id=187183
3155
3156         Reviewed by Wenson Hsieh.
3157
3158         Added a 'runSingly' option to the TestOptions struct. Setting this option to true
3159         will force a new PlatformWebView to be created before running a test. This ensures
3160         that any state set by previous tests are not preserved.
3161
3162         One example of the importance of having this ability is in the case where we want
3163         to test functionality that deals with read access to files. If a test were to
3164         load a valid file URL, universal read access will be granted in WebProcessProxy.
3165         This prevents us from testing cases that rely on us not have universal read
3166         access. Now, if we write the test using the 'runSingly' option, any state set
3167         by previous tests is cleared. Consequently, our test will behave as expected.
3168
3169         * WebKitTestRunner/PlatformWebView.h:
3170         (WTR::PlatformWebView::viewSupportsOptions const):
3171         * WebKitTestRunner/TestController.cpp:
3172         (WTR::updateTestOptionsFromTestHeader):
3173         * WebKitTestRunner/TestOptions.h:
3174         (WTR::TestOptions::hasSameInitializationOptions const):
3175
3176 2018-06-29  Daniel Bates  <dabates@apple.com>
3177
3178         [lldb-webkit] Non-empty strings may be pretty-printed as empty
3179         https://bugs.webkit.org/show_bug.cgi?id=187185
3180
3181         Reviewed by Simon Fraser.
3182
3183         For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
3184         via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
3185         WTF::StringImplShape* before accessing such members makes LLDB happy.
3186
3187         I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
3188         tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
3189         debugging sessions so far.
3190
3191         * lldb/lldb_webkit.py:
3192         (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
3193         (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
3194         (WTFStringImplProvider.get_data16): Ditto.
3195
3196 2018-06-29  Chris Dumez  <cdumez@apple.com>
3197
3198         WebKitLegacy: Can trigger recursive loads triggering debug assertions
3199         https://bugs.webkit.org/show_bug.cgi?id=187121
3200         <rdar://problem/41259430>
3201
3202         Reviewed by Brent Fulgham.
3203
3204         Add API test coverage.
3205
3206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3207         * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
3208         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3209         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
3210         (TestWebKitAPI::TEST):
3211
3212 2018-06-29  Lucas Forschler  <lforschler@apple.com>
3213
3214         Teach bisect-builds to retrieve supported platforms from the rest api.
3215         https://bugs.webkit.org/show_bug.cgi?id=187195
3216         
3217         This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
3218         These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
3219         The identifier keys are in the format: platform-architecture-configuration.
3220
3221         Reviewed by Aakash Jain.
3222
3223         * Scripts/bisect-builds:
3224         (get_api_archive_url): refactored from get_api_url.
3225         (get_platforms): helper function to retrieve from the platforms api.
3226         (minified_platforms): returns a list of minified platforms currently in the database
3227         (unminified_platforms): returns a list of unminified platforms currently in the database
3228         (is_supported_platform): checks if the platform-architecture-configuration combo is supported
3229         (fetch_revision_list): refactored to use get_api_archive_url
3230         (get_api_url): Deleted/refactored to get_api_archive_url.
3231
3232 2018-06-29  Keith Miller  <keith_miller@apple.com>
3233
3234         run-jsc should print when jsc exits with non-zero status
3235         https://bugs.webkit.org/show_bug.cgi?id=187192
3236
3237         Reviewed by Saam Barati.
3238
3239         * Scripts/run-jsc:
3240
3241 2018-06-29  Aakash Jain  <aakash_jain@apple.com>
3242
3243         [ews-build] Add timeout to webkitpy and webkitperl tests
3244         https://bugs.webkit.org/show_bug.cgi?id=187191
3245
3246         Reviewed by Lucas Forschler.
3247
3248         * BuildSlaveSupport/ews-build/steps.py:
3249         (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
3250         (RunWebKitPyTests.__init__): Ditto.
3251         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3252
3253 2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3254
3255         [WPE]: Fix exception handling when flatpak is not installed
3256         https://bugs.webkit.org/show_bug.cgi?id=186771
3257
3258         Unreviewed followup-fix after r233362
3259
3260         This was causing failures when flatpak is not installed.
3261
3262         * flatpak/flatpakutils.py:
3263         (check_flatpak):
3264
3265 2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>
3266
3267         [JSCOnly] Restore Windows build.
3268         https://bugs.webkit.org/show_bug.cgi?id=187127
3269
3270         Reviewed by Michael Catanzaro.
3271
3272         * Scripts/build-jsc:
3273         Fix condition for disabling FTL JIT on Windows.
3274
3275         * Scripts/webkitdirs.pm:
3276         (executableProductDir):
3277         JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
3278         (determineIsWin64):
3279         JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.
3280
3281 2018-06-29  Thibault Saunier  <tsaunier@igalia.com>
3282
3283         [GTK][WPE]: Add a way to setup our development environment inside flatpak
3284         https://bugs.webkit.org/show_bug.cgi?id=186771
3285
3286         Reviewed by Carlos Alberto Lopez Perez.
3287
3288         This patch introduce a way to setup the development environment inside flatpak[0]
3289         removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
3290         layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.
3291
3292         The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
3293         of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).
3294
3295         Our scripts have been updated to be able to run inside that new build environment.
3296
3297         Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
3298         easily with the `--gdb` option:
3299
3300           $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]
3301
3302         The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.
3303
3304         [0] http://flatpak.org
3305
3306         * Scripts/build-webkit:
3307         * Scripts/generate-jsc-bundle:
3308         (main):
3309         * Scripts/run-gtk-tests:
3310         * Scripts/run-minibrowser:
3311         * Scripts/run-webdriver-tests:
3312         * Scripts/run-webkit-tests:
3313         * Scripts/run-wpe-tests:
3314         * Scripts/update-webkitgtk-libs:
3315         * Scripts/update-webkitwpe-libs:
3316         * Scripts/webkit-flatpak: Added.
3317         * Scripts/webkitdirs.pm:
3318         (getJhbuildPath):
3319         (getFlatpakPath):
3320         (inFlatpakSandbox):
3321         (runInFlatpak):
3322         (runInFlatpakIfAvalaible):
3323         (wrapperPrefixIfNeeded):
3324         (shouldUseFlatpak):
3325         * Scripts/webkitpy/port/base.py:
3326         (Port._path_to_apache):
3327         (Port._is_flatpak):
3328         (Port._apache_config_file_name_for_platform):
3329         (Port._should_use_flatpak):
3330         (Port):
3331         (Port._in_flatpak_sandbox):
3332         (Port._should_use_jhbuild):
3333         * Scripts/webkitpy/port/gtk.py:
3334         (GtkPort.setup_environ_for_server):
3335         * Scripts/webkitpy/port/linux_get_crash_log.py:
3336         (GDBCrashLogGenerator._get_trace_from_systemd):
3337         (GDBCrashLogGenerator.generate_crash_log):
3338         * Scripts/webkitpy/port/wpe.py:
3339         (WPEPort.setup_environ_for_server):
3340         * Scripts/webkitpy/w3c/wpt_runner.py:
3341         (main):
3342         * flatpak/files/default.xkm: Added.
3343         * flatpak/files/httpd-autogen.sh: Added.
3344         * flatpak/flatpakutils.py: Added.
3345         (Colors):
3346         (Console):
3347         (Console.message):
3348         (remove_extension_points):
3349         (remove_comments):
3350         (remove_comments._replacer):
3351         (load_manifest):
3352         (expand_manifest):
3353         (FlatpakObject):
3354         (FlatpakObject.__init__):
3355         (FlatpakObject.flatpak):
3356         (FlatpakPackages):
3357         (FlatpakPackages.__init__):
3358         (FlatpakPackages.__detect_packages):
3359         (FlatpakPackages.__detect_packages.in):
3360         (FlatpakPackages.__detect_runtimes):
3361         (FlatpakPackages.__detect_apps):
3362         (FlatpakPackages.__iter__):
3363         (FlatpakRepos):
3364         (FlatpakRepos.__init__):
3365         (FlatpakRepos.update):
3366         (FlatpakRepos.add):
3367         (FlatpakRepo):
3368         (FlatpakRepo.__init__):
3369         (FlatpakRepo.repo_file):
3370         (FlatpakPackage):
3371         (FlatpakPackage.__init__):
3372         (FlatpakPackage.__str__):
3373         (FlatpakPackage.is_installed):
3374         (FlatpakPackage.install):
3375         (FlatpakPackage.update):
3376         (WebkitFlatpak):
3377         (WebkitFlatpak.load_from_args):
3378         (WebkitFlatpak.__init__):
3379         (WebkitFlatpak.check_flatpak):
3380         (WebkitFlatpak.check_flatpak.comparable_version):
3381         (WebkitFlatpak.clean_args):
3382         (WebkitFlatpak.run_in_sandbox):
3383         (WebkitFlatpak.run):
3384         (WebkitFlatpak.has_environment):
3385         (WebkitFlatpak.setup_dev_env):
3386         (WebkitFlatpak.install_all):
3387         (WebkitFlatpak.run_gdb):
3388         (WebkitFlatpak.update_all):
3389         (is_sandboxed):
3390         (run_in_sandbox_if_available):
3391         * flatpak/org.webkit.GTK.yaml: Added.
3392         * flatpak/org.webkit.WPE.yaml: Added.
3393         * flatpak/org.webkit.WebKit.yaml: Added.
3394         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
3395         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.
3396
3397 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3398
3399         [iOS] DataTransfer.getData always returns the empty string when dropping text
3400         https://bugs.webkit.org/show_bug.cgi?id=187130
3401         <rdar://problem/41014117>
3402
3403         Reviewed by Ryosuke Niwa.
3404
3405         Add 2 new API tests to verify that:
3406         -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
3407             "text/plain" and "text/uri-list" data.
3408         -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
3409             DataTransfer.getData().
3410
3411         Additionally tweaks a couple of existing API tests. Namely, in two API tests
3412         (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
3413         we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
3414         them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
3415         tests, and specifying UIPreferredPresentationStyleAttachment in the other).
3416
3417         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3418         (TestWebKitAPI::TEST):
3419
3420 2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3421
3422         Unreviewed, rolling out r226652.
3423         https://bugs.webkit.org/show_bug.cgi?id=180827
3424
3425         "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
3426         not have default argument values. The preferred way to get a PlatformInfo object
3427         is to instantiate a Host object." (Requested by dbates).
3428
3429         Reverted changeset:
3430
3431         "[webkitpy] PlatformInfo should have default argument for casual use"
3432         https://bugs.webkit.org/show_bug.cgi?id=180827
3433
3434 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3435
3436         Try to address test failures on the bots.
3437
3438         Allow the test to distinguish between a failure to find the variable, and an error
3439         reporting vector capacity.
3440
3441         * lldb/lldb_webkit_unittest.py:
3442         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3443         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3444
3445 2018-06-28  Lucas Forschler  <lforschler@apple.com>
3446
3447         Add Windows support for WEBKIT_API_KEY.
3448         https://bugs.webkit.org/show_bug.cgi?id=187155
3449
3450         Reviewed by Daniel Bates.
3451
3452         * EWSTools/start-queue-win.sh:
3453
3454 2018-06-28  Aakash Jain  <aakash_jain@apple.com>
3455
3456         [ews-build] Add support for WebKitPy-Tests-EWS
3457         https://bugs.webkit.org/show_bug.cgi?id=187148
3458
3459         Reviewed by Lucas Forschler.
3460
3461         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
3462         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
3463         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3464         * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 
3465
3466 2018-06-28  Daniel Bates  <dabates@apple.com>
3467
3468         Fix the iOS build following r233299
3469         (https://bugs.webkit.org/show_bug.cgi?id=183744)
3470
3471         Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
3472
3473         * Makefile:
3474
3475 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
3476
3477         Cookie API: cookie creation time is wrong
3478         https://bugs.webkit.org/show_bug.cgi?id=187101
3479
3480         Reviewed by Geoffrey Garen.
3481
3482         Add test coverage: make sure the cookie creation time returned is the same as set.
3483
3484         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3485         (TEST):
3486
3487 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3488
3489         The lldb vector summary provider always shows zero capacity
3490         https://bugs.webkit.org/show_bug.cgi?id=187132
3491
3492         Reviewed by Daniel Bates.
3493         
3494         WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
3495         on the buffer instead of the valobj.
3496
3497         * lldb/lldbWebKitTester/main.cpp:
3498         (testSummaryProviders):
3499         * lldb/lldb_webkit.py:
3500         (WTFVectorProvider.update):
3501         * lldb/lldb_webkit_unittest.py:
3502         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3503         (TestSummaryProviders):
3504         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3505         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3506
3507 2018-06-28  Adam Barth  <abarth@webkit.org>
3508
3509         Switch OS(FUCHSIA) to using JSCOnly
3510         https://bugs.webkit.org/show_bug.cgi?id=187133
3511
3512         Reviewed by Yusuke Suzuki.
3513
3514         Switch Fuchsia from being a port to just being an OS. We now use a
3515         CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
3516
3517         * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
3518         can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
3519         --cmakeargs flag.
3520
3521 2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3522
3523         Make MotionMark's plan file more robust against code changes
3524         https://bugs.webkit.org/show_bug.cgi?id=187116
3525         <rdar://problem/41533956>
3526
3527         Reviewed by Saam Barati.
3528
3529         Moved the code to auto-start the test to the load event listener.
3530
3531         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3532
3533 2018-06-27  Daniel Bates  <dabates@apple.com>
3534
3535         Add some tests for lldb_webkit.py
3536         https://bugs.webkit.org/show_bug.cgi?id=183744
3537
3538         Reviewed by Alexey Proskuryakov.
3539
3540         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
3541         and WTF::String objects.
3542
3543         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
3544         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
3545         on Mac.
3546
3547         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
3548         * Scripts/build-lldbwebkittester: Added.
3549         (buildProjectOrDie):
3550         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
3551         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
3552         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
3553         the file and take advantage of Python's default error semantics to throw an exception
3554         if the import fails instead of handling it ourself. This has the side effect that we
3555         now always import the LLDB Python module even if this script is invoked with --help.
3556         If this turns out to be a significant annoyance then we can look to dynamically import
3557         the module as we did before this change.
3558         (webkit_build_dir):
3559         (main):
3560         (developer_dir): Deleted.
3561         (import_lldb): Deleted.
3562         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
3563         that fact that test-webkitpy does not support class and module fixtures. This is because
3564         test-webkitpy currently implements parallelism by breaking down existing test classes
3565         into individual test methods itself and having each worker run exactly one test method (via
3566         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
3567         setUpModule()/setUpClass() are called for each test method as opposed to once per test
3568         class/test module.
3569         (remove_dir): Ditto.
3570         * Scripts/webkitpy/common/system/systemhost.py:
3571         (SystemHost):
3572         (SystemHost.path_to_lldb_python_directory): Added.
3573         * Scripts/webkitpy/test/main.py:
3574         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
3575         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
3576         lldbWebKitTester on Mac.
3577         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
3578         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
3579         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
3580         If we will run these tests then build lldbWebKitTester if it has not already been built as the
3581         unit tests depend on this program.
3582         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
3583         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
3584         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
3585         * lldb/lldbWebKitTester/Makefile: Added.
3586         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
3587         * lldb/lldbWebKitTester/main.cpp: Added.
3588         (breakForTestingSummaryProviders):
3589         (utf16String):
3590         (testSummaryProviders):
3591         (main):
3592         * lldb/lldb_webkit_unittest.py: Added.
3593         (destroy_cached_debug_session):
3594         (LLDBDebugSession):
3595         (LLDBDebugSession.setup):
3596         (LLDBDebugSession.tearDown):
3597         (TestSummaryProviders):
3598         (TestSummaryProviders.setUpClass):
3599         (TestSummaryProviders._sbFrame):
3600         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
3601         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
3602         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
3603         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
3604         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
3605         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
3606         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
3607         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3608
3609 2018-06-27  Adam Barth  <abarth@webkit.org>
3610
3611         Add Fuchsia support to build-jsc
3612         https://bugs.webkit.org/show_bug.cgi?id=187086
3613
3614         Reviewed by Yusuke Suzuki.
3615
3616         Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
3617         build-jsc kick off a cmake for Fuchsia.
3618
3619         * Scripts/webkitdirs.pm:
3620         (determineSourceDir):
3621         (argumentsForConfiguration):
3622         (determineXcodeSDK):
3623         (findMatchingArguments):
3624         (determinePortName):
3625         (isFuchsia):
3626         (setupAppleWinEnv):
3627         (wrapperPrefixIfNeeded):
3628         (relaunchIOSSimulator):