Unreviewed GTK+ gardening. Skip imported/w3c/webdriver/tests/sessions/new_session...
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
2
3         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
4         https://bugs.webkit.org/show_bug.cgi?id=181881
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
9         (BubbleQueueServer):
10         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
12         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
13
14 2018-01-19  Youenn Fablet  <youenn@apple.com>
15
16         Do not go to the storage process when registering a service worker client if there is no service worker registered
17         https://bugs.webkit.org/show_bug.cgi?id=181740
18         <rdar://problem/36650400>
19
20         Reviewed by Chris Dumez.
21
22         Add support for internals inside API tests.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
26         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
27         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
28         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
29         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
30         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
31         (setConfigurationInjectedBundlePath):
32         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
33
34 2018-01-19  John Wilander  <wilander@apple.com>
35
36         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
37         https://bugs.webkit.org/show_bug.cgi?id=181822
38         https://bugs.webkit.org/show_bug.cgi?id=175263
39         https://bugs.webkit.org/show_bug.cgi?id=178536
40         https://bugs.webkit.org/show_bug.cgi?id=181223
41         https://bugs.webkit.org/show_bug.cgi?id=181482
42         <rdar://problem/33491222>
43         <rdar://problem/33805293>
44         <rdar://problem/36332683>
45         <rdar://problem/36549026>
46
47         Reviewed by Alex Christensen.
48
49         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
50         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
51         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
52         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
53         * WebKitTestRunner/InjectedBundle/TestRunner.h:
54         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
55         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
56         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
57
58 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
59
60         run-webkit-tests fails when there is a curly brace in Xcode build output
61         https://bugs.webkit.org/show_bug.cgi?id=181254
62         <rdar://problem/36453374>
63
64         Reviewed by Daniel Bates.
65
66         * Scripts/webkitpy/port/base.py:
67         (Port._run_script): Encode script output before logging it.
68
69 2018-01-19  Chris Dumez  <cdumez@apple.com>
70
71         Service worker registrations restored from disk may not be reused when the JS calls register() again
72         https://bugs.webkit.org/show_bug.cgi?id=181810
73         <rdar://problem/36591711>
74
75         Reviewed by Youenn Fablet.
76
77         Add API test coverage.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
80         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
81         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
82
83 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
84
85         Remove El Capitan queues from flakiness dashboard
86         https://bugs.webkit.org/show_bug.cgi?id=181860
87
88         Reviewed by Aakash Jain.
89
90         * TestResultServer/static-dashboards/builders.jsonp:
91
92 2018-01-19  Keith Miller  <keith_miller@apple.com>
93
94         HaveInternalSDK includes should be "#include?"
95         https://bugs.webkit.org/show_bug.cgi?id=179670
96
97         Reviewed by Dan Bernstein.
98
99         * MiniBrowser/Configurations/Base.xcconfig:
100         * MobileMiniBrowser/Configurations/Base.xcconfig:
101         * TestWebKitAPI/Configurations/Base.xcconfig:
102         * WebKitTestRunner/Configurations/Base.xcconfig:
103
104 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
105
106         WebDriver: driver environment not passed to pytest when running w3c tests
107         https://bugs.webkit.org/show_bug.cgi?id=181852
108
109         Reviewed by Carlos Alberto Lopez Perez.
110
111         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
112
113         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
114         (WebDriverW3CExecutor.run):
115
116 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
117
118         [GTK] WebDriver: wayland display no used in wayland bot
119         https://bugs.webkit.org/show_bug.cgi?id=181851
120
121         Reviewed by Carlos Alberto Lopez Perez.
122
123         We need to handle the additionalArguments property in the WebDriverTests step.
124
125         * BuildSlaveSupport/build.webkit.org-config/steps.py:
126         (RunWebDriverTests.start):
127
128 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
129
130         [GTK] TERM environment variable is not passed to the test driver.
131         https://bugs.webkit.org/show_bug.cgi?id=181847
132
133         Rubber-stamped by by Carlos Garcia Campos.
134
135         * Scripts/webkitpy/port/base.py:
136         (Port.to.setup_environ_for_server):
137
138 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
139
140         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
141         https://bugs.webkit.org/show_bug.cgi?id=181844
142
143         Reviewed by Carlos Alberto Lopez Perez.
144
145         We always try to create the directory where to store the json file, but when the filename is given directly,
146         like in the bots, the current dir is used.
147
148         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
149         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
150         empty string.
151
152 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
153
154         [GTK] WebDriver tests are running outside the jhbuild env
155         https://bugs.webkit.org/show_bug.cgi?id=181842
156
157         Reviewed by Žan Doberšek.
158
159         We need to enter jhbuild env in run-webdriver-tests.
160
161         * Scripts/run-webdriver-tests:
162
163 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
164
165         [GTK] Run WebDriver tests in the bots
166         https://bugs.webkit.org/show_bug.cgi?id=181787
167
168         Reviewed by Michael Catanzaro.
169
170         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
171         factory for the GTK port for now.
172
173         * BuildSlaveSupport/build.webkit.org-config/factories.py:
174         (TestFactory.__init__):
175         * BuildSlaveSupport/build.webkit.org-config/steps.py:
176         (RunWebDriverTests):
177         (RunWebDriverTests.start):
178         (RunWebDriverTests.commandComplete):
179         (RunWebDriverTests.evaluateCommand):
180         (RunWebDriverTests.getText):
181         (RunWebDriverTests.getText2):
182
183 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
184
185         [WinCairo] Pass correct url for http test to test driver.
186         https://bugs.webkit.org/show_bug.cgi?id=181814
187
188         Reviewed by Alex Christensen.
189
190         * Scripts/webkitpy/port/driver.py:
191         (Driver):
192         (Driver.http_test_path_to_uri):
193         (Driver.is_secure_path):
194         (Driver.http_base_url):
195         (Driver.uri_to_test):
196
197 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
198
199         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
200
201         * BuildSlaveSupport/build.webkit.org-config/config.json:
202
203 2018-01-18  Dan Bernstein  <mitz@apple.com>
204
205         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
206         https://bugs.webkit.org/show_bug.cgi?id=181803
207
208         Reviewed by Tim Horton.
209
210         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
211         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
212         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
213         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
214         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
215         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
216         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
217         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
218         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
219           helpers.
220         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
221           settings useful for defining settings that depend on the target macOS version.
222         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
223         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
224
225 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
226
227         Remove Opensource El Capitan queues from buildbot
228         https://bugs.webkit.org/show_bug.cgi?id=181712
229
230         Reviewed by Aakash Jain.
231
232         * BuildSlaveSupport/build.webkit.org-config/config.json:
233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
234         (WebKitBuildbot):
235         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
236
237 2018-01-18  Chris Dumez  <cdumez@apple.com>
238
239         Service Workers restored from persistent storage have 'redundant' state
240         https://bugs.webkit.org/show_bug.cgi?id=181749
241         <rdar://problem/36556486>
242
243         Reviewed by Youenn Fablet.
244
245         Add API test coverage.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
248         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
249
250 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
251
252         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
253         https://bugs.webkit.org/show_bug.cgi?id=176796
254
255         Reviewed by Chris Fleizach.
256
257         Add sanity check that we have a URL before calling g_strstr_len().
258
259         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
260         (WTR::AccessibilityUIElement::url):
261
262 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
263
264         Add triggers for Sierra test262 and perf queues
265         https://bugs.webkit.org/show_bug.cgi?id=181799
266
267         Reviewed by Aakash Jain.
268
269         * BuildSlaveSupport/build.webkit.org-config/config.json:
270
271 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
272
273         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
274         https://bugs.webkit.org/show_bug.cgi?id=181783
275         <rdar://problem/35785445>
276
277         Reviewed by Ryosuke Niwa.
278
279         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
280         copying an image contains a relevant title.
281
282         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
285         * TestWebKitAPI/ios/UIKitSPI.h:
286
287 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
288
289         WebDriver: ignore the driver in selenium test names when getting expectations
290         https://bugs.webkit.org/show_bug.cgi?id=181738
291
292         Reviewed by Carlos Alberto Lopez Perez.
293
294         In selenium tests, the driver is added as a parameter to every test which results in tests names like
295         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
296         driver name in the test expectations file, so we need to remove it when querying the expectations.
297
298         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
299         (TestExpectationsMarker.__init__): Save the param to ignore.
300         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
301         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
302         (run): Pass param to ignore to TestExpectationsMarker().
303         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
304         (WebDriverSeleniumExecutor.__init__): Save the driver name.
305         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
306
307 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
308
309         [GTK][WPE] Show unit tests unexpectedly passing in the bots
310         https://bugs.webkit.org/show_bug.cgi?id=181726
311
312         Reviewed by Michael Catanzaro.
313
314         Now that we have the info, let's show it also in the bots.
315
316         * BuildSlaveSupport/build.webkit.org-config/steps.py:
317         (RunGLibAPITests.commandComplete):
318
319 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
320
321         Fix broken unittest after r227048
322         https://bugs.webkit.org/show_bug.cgi?id=181760
323
324         Reviewed by Aakash Jain.
325
326
327 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
328
329         WEBKIT_FRAMEWORK should not modify file-global include directories
330         https://bugs.webkit.org/show_bug.cgi?id=181656
331
332         Reviewed by Konstantin Tokarev.
333
334         * TestWebKitAPI/PlatformWPE.cmake:
335         * TestWebKitAPI/glib/CMakeLists.txt:
336
337 2018-01-17  Alicia Boya García  <aboya@igalia.com>
338
339         Unreviewed, mark Alicia as committer in contributors.json
340
341         * Scripts/webkitpy/common/config/contributors.json:
342
343 2018-01-17  Youenn Fablet  <youenn@apple.com>
344
345         Put fetch Request.keepalive behind a runtime flag
346         https://bugs.webkit.org/show_bug.cgi?id=181592
347
348         Reviewed by Chris Dumez.
349
350         * DumpRenderTree/mac/DumpRenderTree.mm:
351         (enableExperimentalFeatures):
352         * DumpRenderTree/win/DumpRenderTree.cpp:
353         (enableExperimentalFeatures):
354         * WebKitTestRunner/TestController.cpp:
355         (WTR::TestController::resetPreferencesToConsistentValues):
356
357 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
358
359         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
360         https://bugs.webkit.org/show_bug.cgi?id=181637
361         <rdar://problem/36508471>
362
363         Reviewed by Tim Horton.
364
365         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
366         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
367
368         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
369         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
370         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
371
372         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
373         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
374
375         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
376         (webViewForTestingAttachments):
377         (-[TestWKWebView tagsInBody]):
378         (-[TestWKWebView expectElementTagsInOrder:]):
379         (-[TestWKWebView expectElementTag:toComeBefore:]):
380
381         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
382         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
383
384         (TestWebKitAPI::TEST):
385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
386         (WTR::InjectedBundlePage::InjectedBundlePage):
387
388 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
389
390         WebDriver: add support for test expectations
391         https://bugs.webkit.org/show_bug.cgi?id=180420
392
393         Reviewed by Carlos Alberto Lopez Perez.
394
395         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
396
397         * Scripts/run-webdriver-tests: Get the retval from process_results().
398         * Scripts/webkitpy/thirdparty/__init__.py:
399         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
400         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
401         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
402         (TestExpectationsMarker.__init__): Initialize expectations.
403         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
404         (run): Create and use TestExpectationsMarker plugin.
405         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
406         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
407         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
408         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
409         (WebDriverTestRunner.run): Do not count results here.
410         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
411         amount of failures. Printing the test summary while processing results will be made optional in a follow up
412         patch.
413         (WebDriverTestRunner.process_results.report): Return the amount of failures.
414         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
415         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
416         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
417         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
418         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
419         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
420         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
421         (WebDriverTestRunnerW3C._scan_directory): Ditto.
422         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
423         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
424         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
425
426 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         Unreviewed WPE gardening. Mark some known unit test failures.
429
430         * TestWebKitAPI/glib/TestExpectations.json:
431
432 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
433
434         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
435         https://bugs.webkit.org/show_bug.cgi?id=181724
436
437         Reviewed by Philippe Normand.
438
439         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
440         reason to use different names. This way we can refer to the same test names for both and we can share the
441         expectations in the TestExpectations.json file.
442
443         * TestWebKitAPI/glib/TestExpectations.json:
444         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
445
446 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
447
448         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
449
450         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
451         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
452
453         * glib/api_test_runner.py:
454         (TestRunner._run_test_glib):
455         (TestRunner._run_google_test):
456
457 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
460         https://bugs.webkit.org/show_bug.cgi?id=179914
461
462         Reviewed by Žan Doberšek.
463
464         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
465         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
466         all symbols listed in the script are present in the library.
467
468         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
469         (bss_symbols):
470         * Scripts/check-for-invalid-symbols-in-version-script: Added.
471         (script_symbols):
472         * Scripts/make-dist:
473         (Distcheck.build):
474         (Distcheck):
475         (Distcheck.check_symbols):
476         (Distcheck.check):
477
478 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
481         https://bugs.webkit.org/show_bug.cgi?id=181722
482
483         Reviewed by Žan Doberšek.
484
485         I forgot to pass the parameters to run() when restarting.
486
487         * glib/glib_test_runner.py:
488         (GLibTestRunner.run):
489
490 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
491
492         [CMake] Remove WebCoreDerivedSources library target
493         https://bugs.webkit.org/show_bug.cgi?id=181664
494
495         Reviewed by Carlos Garcia Campos.
496
497         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
498         * TestWebKitAPI/PlatformWin.cmake: Ditto.
499
500 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
501
502         Move Debug Test262, Release Test262 and Performance queues to Sierra
503         https://bugs.webkit.org/show_bug.cgi?id=181692
504
505         Unreviewed
506
507 2018-01-16  Zach Li  <zachli@apple.com>
508
509         Add pop-up policy support in website policies.
510         https://bugs.webkit.org/show_bug.cgi?id=181544.
511         rdar://problem/30521400.
512
513         Reviewed by Alex Christensen.
514
515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
516         Added pop-up-check.html.
517
518         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
521         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
522         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
523         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
524         (TEST):
525
526 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
527
528         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
529         https://bugs.webkit.org/show_bug.cgi?id=181638
530         <rdar://problem/36508702>
531
532         Reviewed by Dan Bernstein.
533
534         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
535         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
536
537         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
538         (-[AttachmentUpdateObserver init]):
539         (-[AttachmentUpdateObserver sourceForIdentifier:]):
540         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
541         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
542         (TestWebKitAPI::TEST):
543         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
544
545 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
546
547         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
548
549         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
550
551         * glib/api_test_runner.py:
552         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
553         * glib/glib_test_runner.py:
554         (GLibTestRunner.run): Use given env.
555
556 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
559         https://bugs.webkit.org/show_bug.cgi?id=181676
560
561         Reviewed by Carlos Alberto Lopez Perez.
562
563         The option was removed in r226967.
564
565         * BuildSlaveSupport/build.webkit.org-config/steps.py:
566         (RunGtkAPITests):
567         (RunWPEAPITests):
568
569 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
570
571         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
572
573         The bots are still passing that option and the step is failing because it was removed in r226967.
574
575         * glib/api_test_runner.py:
576         (add_options):
577
578 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
579
580         [GTK][WPE] Improve the way glib tests are run
581         https://bugs.webkit.org/show_bug.cgi?id=181674
582
583         Reviewed by Žan Doberšek.
584
585         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
586         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
587         tests failing due to an expected assert in the test and unexpected crashes.
588         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
589         not showing the subtest name in stdout in case of timeouts.
590         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
591         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
592         of every test case.
593
594         * glib/api_test_runner.py:
595         (TestRunner._run_test_glib): Use GLibTestRunner.
596         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
597         (add_options):
598         * glib/glib_test_runner.py: Added.
599         (TestTimeout):
600         (Message):
601         (Message.__init__):
602         (Message.create):
603         (Message.create.read_unsigned):
604         (Message.create.read_double):
605         (Message.create.read_string):
606         (GLibTestRunner):
607         (GLibTestRunner.__init__):
608         (GLibTestRunner._process_data):
609         (GLibTestRunner._process_message):
610         (GLibTestRunner._read_from_pipe):
611         (GLibTestRunner._read_from_stderr):
612         (GLibTestRunner._start_timeout):
613         (GLibTestRunner._start_timeout._alarm_handler):
614         (GLibTestRunner._stop_timeout):
615         (GLibTestRunner._subtest_start):
616         (GLibTestRunner._subtest_message):
617         (GLibTestRunner._subtest_stderr):
618         (GLibTestRunner._subtest_end):
619         (GLibTestRunner.run):
620
621 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
622
623         Unreviewed, add Thibault to contributors.json
624
625         It's a bit weird to add someone here before their first contribution, but this affects
626         Bugzilla autocomplete, and that is serious business.
627
628         * Scripts/webkitpy/common/config/contributors.json:
629
630 2018-01-15  JF Bastien  <jfbastien@apple.com>
631
632         Remove makePoisonedUnique
633         https://bugs.webkit.org/show_bug.cgi?id=181630
634         <rdar://problem/36498623>
635
636         Reviewed by Mark Lam.
637
638         Update tests.
639
640         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
641         (TestWebKitAPI::TEST):
642         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
643         (TestWebKitAPI::TEST):
644
645 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
646
647         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
648         https://bugs.webkit.org/show_bug.cgi?id=181476
649
650         Reviewed by Michael Catanzaro.
651
652         Update to xorg-server 1.19.6 which depends on libxfont2, and change
653         the lists of packages to install libxfont2-devel (or equivalent).
654
655         * gtk/install-dependencies:
656         * gtk/jhbuild.modules:
657
658 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
659
660         [GTK][WPE] Add support for unit test expectations
661         https://bugs.webkit.org/show_bug.cgi?id=181589
662
663         Reviewed by Michael Catanzaro.
664
665         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
666         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
667         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
668         script itself is not a good idea either.
669
670         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
671         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
672         convenient methods to query them.
673
674         * Scripts/run-gtk-tests:
675         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
676         * Scripts/run-wpe-tests:
677         (WPETestRunner): Ditto.
678         * Scripts/webkitpy/common/test_expectations.py: Added.
679         (TestExpectations):
680         (TestExpectations.__init__):
681         (TestExpectations._port_name_for_expected):
682         (TestExpectations._expected_value):
683         (TestExpectations.skipped_tests):
684         (TestExpectations.skipped_subtests):
685         (TestExpectations._expectation_value):
686         (TestExpectations.is_slow):
687         (TestExpectations.get_expectation):
688         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
689         (MockTestExpectations):
690         (MockTestExpectations.__init__):
691         (MockTestExpectations.is_skip):
692         (ExpectationsTest):
693         (assert_exp):
694         (assert_not_exp):
695         (assert_bad_exp):
696         (assert_skip):
697         (test_basic):
698         (test_skip):
699         (test_flaky):
700         (test_build_type):
701         * TestWebKitAPI/glib/TestExpectations.json: Added.
702         * glib/api_test_runner.py:
703         (TestRunner): Remove SkippedTest implementation.
704         (TestRunner.__init__): Create a TestExpectations.
705         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
706         (TestRunner._should_run_test_program): Ditto.
707         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
708         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
709         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
710         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
711         (TestRunner.run_tests.report): Helper to write report to stdout.
712
713 2018-01-13  Mark Lam  <mark.lam@apple.com>
714
715         Replace all use of ConstExprPoisoned with Poisoned.
716         https://bugs.webkit.org/show_bug.cgi?id=181542
717         <rdar://problem/36442138>
718
719         Reviewed by JF Bastien.
720
721         1. Converted tests to using new uintptr_t& poison type.
722         2. Added tests for Poisoned comparison operators.
723
724         * TestWebKitAPI/CMakeLists.txt:
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
727         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
728         (TestWebKitAPI::TEST):
729         (TestWebKitAPI::initializeTestPoison): Deleted.
730         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
731         (TestWebKitAPI::TEST):
732         (TestWebKitAPI::passWithRef):
733         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
734         (TestWebKitAPI::TEST):
735         (TestWebKitAPI::f1):
736         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
737         (TestWebKitAPI::TEST):
738         (TestWebKitAPI::poisonedPtrFoo):
739         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
740         (TestWebKitAPI::TEST):
741         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
742         (TestWebKitAPI::TEST):
743
744 2018-01-13  David Kilzer  <ddkilzer@apple.com>
745
746         check-webkit-style: false positive for [whitespace/braces] with os_log format string
747         <https://webkit.org/b/181606>
748
749         Reviewed by Darin Adler.
750
751         * Scripts/webkitpy/style/checkers/cpp.py:
752         (check_spacing): Modify regular expression to ignore
753         os_log format strings like '%{public}'.
754         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
755         (CppStyleTest.test_spacing_before_braces): Add os_log
756         format string test.
757
758 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
759
760         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
761         https://bugs.webkit.org/show_bug.cgi?id=181626
762
763         Reviewed by Joseph Pecoraro.
764
765         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
766         Additionally, write a new API test covering the change in r226915.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
769         (webViewForTestingAttachments):
770         (TestWebKitAPI::TEST):
771
772 2018-01-12  Alex Christensen  <achristensen@webkit.org>
773
774         History state should be updated during client redirects with asynchronous policy decisions
775         https://bugs.webkit.org/show_bug.cgi?id=181358
776         <rdar://problem/35547689>
777
778         Reviewed by Andy Estes.
779
780         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
781         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
782         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
783         (TEST):
784
785 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
786
787         webkitpy: Refactor simulator code (Part 4)
788         https://bugs.webkit.org/show_bug.cgi?id=180555
789         <rdar://problem/36131381>
790
791         Reviewed by Aakash Jain.
792
793         Move new_simulated_device.py to simulated_device.py.
794
795         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
796         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
797         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
798         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
799         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
800
801 2018-01-12  Alex Christensen  <achristensen@webkit.org>
802
803         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
804         https://bugs.webkit.org/show_bug.cgi?id=181595
805
806         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
807         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
808         I change the < and > to $ to make this test pass and continue to test what it used to.
809
810         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
811         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
812         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
813
814 2018-01-11  Keith Miller  <keith_miller@apple.com>
815
816         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
817         https://bugs.webkit.org/show_bug.cgi?id=181573
818
819         Reviewed by Simon Fraser.
820
821         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
822
823 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
824
825         [WebAuthN] Import a CBOR coder from Chromium
826         https://bugs.webkit.org/show_bug.cgi?id=181522
827         <rdar://problem/36055729>
828
829         Reviewed by Brent Fulgham.
830
831         This patch also imports all unit tests into our API tests to ensure all
832         workarounds and modification against the original codebase doesn't change
833         any original functionalities.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
836         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
837         (TestWebKitAPI::TEST):
838         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
841         (TestWebKitAPI::eq):
842         Workarounds applied.
843         (TestWebKitAPI::TEST):
844
845 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
846
847         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
848         https://bugs.webkit.org/show_bug.cgi?id=181538
849         <rdar://problem/36440580>
850
851         Reviewed by Aakash Jain.
852
853         When disambiguating a device type, it is possible that the provided device type is sufficiently
854         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
855         will result in a failure to disambiguate the type.
856
857         * Scripts/webkitpy/xcode/new_simulated_device.py:
858         (SimulatedDeviceManager._disambiguate_device_type):
859
860 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
861
862         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
863         https://bugs.webkit.org/show_bug.cgi?id=181136
864         <rdar://problem/36116604>
865
866         Reviewed by Chris Dumez.
867
868         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
869         browsing sessions.
870
871         * Scripts/run-gtk-tests:
872         (GtkTestRunner): Unskip test now that it passes.
873         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
874         (TEST): Add new WebsiteDataStoreEphemeral test.
875
876 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
877
878         Unreviewed, rolling out r226816.
879
880         This change broke LayoutTests on the bots.
881
882         Reverted changeset:
883
884         "run-webkit-tests fails when there is a curly brace in Xcode
885         build output"
886         https://bugs.webkit.org/show_bug.cgi?id=181254
887         https://trac.webkit.org/changeset/226816
888
889 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
890
891         webkitpy: Fix flakey webserver tests
892         https://bugs.webkit.org/show_bug.cgi?id=181555
893         <rdar://problem/36448273>
894
895         Reviewed by Aakash Jain.
896
897         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
898         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
899         determine if a specific server is running.
900
901 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
902
903         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
904         https://bugs.webkit.org/show_bug.cgi?id=181561
905         <rdar://problem/36452652>
906
907         Reviewed by Aakash Jain.
908
909         BeautifulSoup.find may return None, this case should be gracefully handled.
910
911         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
912         (BugzillaQueries._parse_result_count):
913         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
914
915 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
916
917         run-webkit-tests fails when there is a curly brace in Xcode build output
918         https://bugs.webkit.org/show_bug.cgi?id=181254
919
920         Reviewed by Daniel Bates.
921
922         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
923         (MeteredStream.write):
924
925 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
926
927         webkitpy: Reimplement simulator code (Part 3)
928         https://bugs.webkit.org/show_bug.cgi?id=180555
929         <rdar://problem/36131381>
930
931         Reviewed by Aakash Jain.
932
933         Remove old simulator code.
934
935         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
936         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
937         * Scripts/webkitpy/xcode/simulator.py: Removed.
938         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
939
940 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
941
942         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
943         https://bugs.webkit.org/show_bug.cgi?id=181337
944         <rdar://problem/36324813>
945
946         Reviewed by Tim Horton.
947
948         Add 3 new API tests for attachment element dragging.
949
950         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
951         (-[TestWKWebView expectElementTag:toComeBefore:]):
952         (-[NSItemProvider expectType:withData:]):
953         (TestWebKitAPI::TEST):
954
955 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
956
957         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
958         https://bugs.webkit.org/show_bug.cgi?id=179621
959         <rdar://problem/35589585>
960
961         Unreviewed infrastructure fix.
962
963         * Scripts/webkitpy/port/mac.py:
964         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
965         list if we are the VERSION_MAX, which usually corresponds with future.
966
967 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
968
969         CodeBlocks should be in IsoSubspaces
970         https://bugs.webkit.org/show_bug.cgi?id=180884
971
972         Reviewed by Saam Barati.
973         
974         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
975         shouldn't take a long time due to benchmarks we don't optimize for.
976         
977         * Scripts/run-jsc-benchmarks:
978
979 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
980
981         Test gardening for GTK.
982         https://bugs.webkit.org/show_bug.cgi?id=181477
983
984         Unreviewed test gardening.
985
986         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
987         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
988
989 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
990
991         Add the new JSCOnly bot to the scheduler.
992         https://bugs.webkit.org/show_bug.cgi?id=181487
993
994         Unreviewed follow-up patch after r226729
995
996         On r226729 I missed to add the new JSCOnly bot the default scheduler.
997         This is needed to make the bot automatically pick each commit for testing.
998
999         * BuildSlaveSupport/build.webkit.org-config/config.json:
1000
1001 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1002
1003         [Attachment Support] Support dragging attachment elements out as files on iOS
1004         https://bugs.webkit.org/show_bug.cgi?id=181199
1005         <rdar://problem/36299316>
1006
1007         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1008
1009         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1010         attachment API tests.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1013         (-[NSItemProvider expectType:withData:]):
1014         (TestWebKitAPI::TEST):
1015
1016         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1017         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1018         -expectType:withData: helper to inspect the item providers created from the drag source.
1019
1020         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1021         (TestWebKitAPI::TEST):
1022         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1023         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1024         (-[MockDragSession localContext]):
1025         (-[MockDragSession setLocalContext:]):
1026         (-[DataInteractionSimulator _resetSimulatedState]):
1027         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1028         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1029         (-[DataInteractionSimulator _advanceProgress]):
1030         (-[DataInteractionSimulator endDataTransfer]):
1031
1032         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1033         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1034         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1035         MockDragSession to hold on to a localContext.
1036
1037 2018-01-11  Ali Juma  <ajuma@chromium.org>
1038
1039         Unreviewed. Add Ali Juma as contributor
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1044
1045         Unreviewed. Update Selenium WebDriver imported tests.
1046
1047         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1048         environment variables.
1049
1050         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1051         (collect): Reorder the arguments to make pytest happy.
1052         (run): Ditto.
1053         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1054         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1055
1056 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1057
1058         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1059         https://bugs.webkit.org/show_bug.cgi?id=181492
1060         <rdar://problem/36359679>
1061
1062         Reviewed by Alexey Proskuryakov. 
1063
1064 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1065
1066         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1067         https://bugs.webkit.org/show_bug.cgi?id=181475
1068
1069         Reviewed by Michael Catanzaro.
1070
1071         * gtk/install-dependencies: Update package list for Arch Linux, extend
1072         message shown at end of installation with additional tips.
1073
1074 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1075
1076         REGRESSION(r222507): Composition highlight doesn't render when using IME
1077         https://bugs.webkit.org/show_bug.cgi?id=181485
1078         <rdar://problem/35896516>
1079
1080         Reviewed by Ryosuke Niwa.
1081
1082         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1083         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1084         allow rendering composition backgrounds (see InlineTextBox::paint).
1085
1086         * DumpRenderTree/ios/TextInputControllerIOS.m:
1087         (+[TextInputController isSelectorExcludedFromWebScript:]):
1088         (+[TextInputController webScriptNameForSelector:]):
1089         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1090         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1091         * DumpRenderTree/mac/TextInputControllerMac.m:
1092         (+[TextInputController isSelectorExcludedFromWebScript:]):
1093         (+[TextInputController webScriptNameForSelector:]):
1094         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1095         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1096         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1097         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1098         (WTR::TextInputController::setMarkedText):
1099         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1100
1101 2018-01-10  JF Bastien  <jfbastien@apple.com>
1102
1103         Poison small JSObject derivatives which only contain pointers
1104         https://bugs.webkit.org/show_bug.cgi?id=181483
1105         <rdar://problem/36407127>
1106
1107         Reviewed by Mark Lam.
1108
1109         Test the new move-assign and move-copy from unique_ptr, as well as
1110         nullptr_t ctors.
1111
1112         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1113         (TestWebKitAPI::TEST):
1114         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1117         (TestWebKitAPI::TEST):
1118
1119 2018-01-10  Chris Dumez  <cdumez@apple.com>
1120
1121         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1122         https://bugs.webkit.org/show_bug.cgi?id=179256
1123         <rdar://problem/35401978>
1124
1125         Reviewed by Alex Christensen.
1126
1127         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1128         instance gets its own folder to avoid conflicts and flakiness.
1129
1130         * WebKitTestRunner/mac/TestControllerMac.mm:
1131         (WTR::TestController::platformConfigureViewForTest):
1132
1133 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1134
1135         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1136         https://bugs.webkit.org/show_bug.cgi?id=181269
1137         <rdar://problem/35110344>
1138
1139         Reviewed by Simon Fraser.
1140
1141         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1142         (WTR::UIScriptController::beginBackSwipe):
1143         (WTR::UIScriptController::completeBackSwipe):
1144         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1145         (WTR::UIScriptController::beginBackSwipe):
1146         (WTR::UIScriptController::completeBackSwipe):
1147         (WTR::UIScriptController::overridePreference):
1148         (WTR::UIScriptController::replaceTextAtRange):
1149         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1150         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1151         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1152         (WTR::UIScriptController::beginBackSwipe):
1153         (WTR::UIScriptController::completeBackSwipe):
1154         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1155         exist on Mac) in terms of the new WKWebView testing SPI.
1156
1157 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1158
1159         REGRESSION (r226715): ignore WARNING output in linter tests
1160         https://bugs.webkit.org/show_bug.cgi?id=181486
1161         <rdar://problem/36408847>
1162
1163         Reviewed by Aakash Jain.
1164
1165         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1166
1167         * Scripts/webkitpy/common/system/outputcapture.py:
1168         (OutputCapture.__init__): Pass logging level to be captured.
1169         * Scripts/webkitpy/style/main_unittest.py:
1170         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1171         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1172         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1173         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1174         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1175         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1176         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1177         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1178
1179 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1180
1181         Add a JSCOnly MIPS buildbot
1182         https://bugs.webkit.org/show_bug.cgi?id=181487
1183
1184         Reviewed by Michael Catanzaro.
1185
1186         Add the new bot configs definitions for the master and update the unit tests.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/config.json:
1189         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1190
1191 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1192
1193         REGRESSION (r226715): don't re-check number of simulators in child processes
1194         https://bugs.webkit.org/show_bug.cgi?id=181484
1195         <rdar://problem/36407151>
1196
1197         Reviewed by Aakash Jain.
1198
1199         * Scripts/webkitpy/port/ios_simulator.py:
1200         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1201         are already initialized.
1202
1203 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1204
1205         Unreviewed, rolling out r226667 and r226673.
1206         https://bugs.webkit.org/show_bug.cgi?id=181488
1207
1208         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1209
1210         Reverted changesets:
1211
1212         "CodeBlocks should be in IsoSubspaces"
1213         https://bugs.webkit.org/show_bug.cgi?id=180884
1214         https://trac.webkit.org/changeset/226667
1215
1216         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1217         https://bugs.webkit.org/show_bug.cgi?id=180884
1218         https://trac.webkit.org/changeset/226673
1219
1220 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1221
1222         Follow-up fix to r226715
1223         https://bugs.webkit.org/show_bug.cgi?id=180555
1224         <rdar://problem/36131381>
1225
1226         Unreviewed infrastructure fix.
1227
1228         * Scripts/webkitpy/xcode/new_simulated_device.py:
1229         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1230         of delete.
1231
1232 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1233
1234         webkitpy: Refactor simulator code (Part 2)
1235         https://bugs.webkit.org/show_bug.cgi?id=180555
1236         <rdar://problem/36131381>
1237
1238         Reviewed by Aakash Jain.
1239
1240         The patch leverages the SimulatedDeviceManager when running layout tests.
1241         This patch is primarily code removal, since much of the IOSSimulatorPort
1242         was dedicated to managing simulators. The removed code is either now owned by the
1243         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1244         boot multiple simulators which was made obsolete in Xcode 9.
1245
1246         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1247         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1248         strip those spaces.
1249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1250         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1251         * Scripts/webkitpy/port/ios.py:
1252         (IOSPort.__init__): The _current_device idiom is no longer required since the
1253         SimulatedDeviceManager keeps track of any previously booted devices.
1254         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1255         through the array of managed devices.
1256         (IOSPort.using_multiple_devices): Deleted.
1257         * Scripts/webkitpy/port/ios_device.py:
1258         (IOSDevicePort.using_multiple_devices): Deleted.
1259         * Scripts/webkitpy/port/ios_simulator.py:
1260         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1261         class strings so they can be parsed by the DeviceType class.
1262         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1263         the number of simulators currently booted, the number of child processes specified
1264         and the maximum number of simulators supported by this system.
1265         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1266         devices owned by the SimulatedDeviceManager.
1267         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1268         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1269         the maximum number of supported simulators on this system.
1270         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1271         request for each child process and send this list to the SimulatedDeviceManager to
1272         initialize the devices.
1273         (IOSSimulatorPort.clean_up_test_run):
1274         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1275         specified version of iOS.
1276         (IOSSimulatorPort.reset_preferences):
1277         (IOSSimulatorPort.simulator_runtime): Deleted.
1278         (IOSSimulatorPort.simulator_device_type): Deleted.
1279         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1280         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1281         (IOSSimulatorPort._create_simulators): Deleted.
1282         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1283         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1284         (IOSSimulatorPort.using_multiple_devices): Deleted.
1285         (IOSSimulatorPort._create_device): Deleted.
1286         (IOSSimulatorPort.get_simulator_path): Deleted.
1287         (IOSSimulatorPort._createSimulatorApps): Deleted.
1288         (IOSSimulatorPort._createSimulatorApp): Deleted.
1289         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1290         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1291         maximum number of simulators run on this system.
1292         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1293         * Scripts/webkitpy/xcode/new_simulated_device.py:
1294         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1295
1296 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1297
1298         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1299         https://bugs.webkit.org/show_bug.cgi?id=181474
1300
1301         Reviewed by Carlos Alberto Lopez Perez.
1302
1303         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1304         name as the name.
1305
1306         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1307         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1308         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1309
1310 2018-01-09  Andy Estes  <aestes@apple.com>
1311
1312         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1313         https://bugs.webkit.org/show_bug.cgi?id=181459
1314
1315         Reviewed by Dan Bernstein.
1316
1317         * ImageDiff/cg/Configurations/Base.xcconfig:
1318
1319 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1320
1321         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1322         https://bugs.webkit.org/show_bug.cgi?id=181374
1323
1324         Reviewed by Simon Fraser.
1325
1326         The test requires Palatino.
1327
1328         * DumpRenderTree/mac/DumpRenderTree.mm:
1329         (allowedFontFamilySet):
1330         * WebKitTestRunner/mac/TestControllerMac.mm:
1331         (WTR::allowedFontFamilySet):
1332
1333 2018-01-09  Saam Barati  <sbarati@apple.com>
1334
1335         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1336         https://bugs.webkit.org/show_bug.cgi?id=181449
1337
1338         Reviewed by JF Bastien.
1339
1340         This allows me to Cmd+f in my terminal to search for things without
1341         having the results become misaligned.
1342
1343         * Scripts/display-profiler-output:
1344
1345 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1346
1347         [webkitpy] PlatformInfo should have default argument for casual use
1348         https://bugs.webkit.org/show_bug.cgi?id=180827
1349
1350         Reviewed by David Kilzer.
1351
1352         PlatformInfo should be the only way to check platform specific thing instead
1353         of sys.platform or other various checks. If there is something you want to check,
1354         it should be placed in PlatformInfo.
1355
1356         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1357         sys, platform and Executive(). They are straight forward and should be handled
1358         by default arguments. Then we can instantiate PlatformInfo more casual.
1359
1360         * Scripts/webkitpy/common/system/platforminfo.py:
1361         (PlatformInfo): Use relative module path import
1362         (PlatformInfo.__init__):
1363         (PlatformInfo.executive): Lazy instantiation of Executive()
1364         (PlatformInfo.total_bytes_memory): Accessing via above property
1365         (PlatformInfo.xcode_sdk_version): Ditto
1366         (PlatformInfo.xcode_simctl_list): Ditto
1367         (PlatformInfo.xcode_version): Ditto
1368         (PlatformInfo._win_version_str): Ditto
1369         * Scripts/webkitpy/common/system/systemhost.py:
1370         (SystemHost.__init__):
1371         * Scripts/webkitpy/common/system/user.py:
1372         (User.__init__):
1373
1374 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1375
1376         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1377         https://bugs.webkit.org/show_bug.cgi?id=176443
1378
1379         Reviewed by Darin Adler.
1380
1381         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1382         (TEST):
1383
1384 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1385
1386         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1387         https://bugs.webkit.org/show_bug.cgi?id=181394
1388
1389         Reviewed by Darin Adler.
1390
1391         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1392         as the second parameter instead of ios(WK_IOS_TBA). This generally
1393         builds for iOS on EWS but not when using the public SDK. See r224057,
1394         r223207 and r226211 for example. This patch adds a basic style check
1395         for that macro to prevent this kind of mistake.
1396
1397         * Scripts/webkitpy/style/checkers/cpp.py:
1398         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1399         (check_style): Run new style check.
1400         (CppChecker): Add build type for the new style check.
1401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1402         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1403
1404 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1405
1406         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1407         https://bugs.webkit.org/show_bug.cgi?id=181420
1408         <rdar://problem/36365827>
1409
1410         Reviewed by Alex Christensen.
1411
1412         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1413         of corresponding _WKAttachments.
1414
1415         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1416         (TestWebKitAPI::TEST):
1417
1418 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1419
1420         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1421         https://bugs.webkit.org/show_bug.cgi?id=181410
1422         <rdar://problem/36167199>
1423
1424         Reviewed by Wenson Hsieh.
1425
1426         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1427         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1428         (TEST):
1429
1430 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1431
1432         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1433         https://bugs.webkit.org/show_bug.cgi?id=181408
1434         <rdar://problem/35884960>
1435
1436         Reviewed by Tim Horton.
1437
1438         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1439         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1440
1441 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1442
1443         [Attachment Support] Expose file name and content type of WKAttachment
1444         https://bugs.webkit.org/show_bug.cgi?id=181390
1445         <rdar://problem/36336837>
1446
1447         Reviewed by Tim Horton.
1448
1449         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1450
1451         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1452         (-[_WKAttachment synchronouslyRequestInfo:]):
1453         (-[_WKAttachment synchronouslyRequestData:]):
1454
1455         Reimplement this in terms of -synchronouslyRequestInfo:.
1456
1457         (-[_WKAttachment expectRequestedDataToBe:]):
1458         (TestWebKitAPI::TEST):
1459
1460 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1463         https://bugs.webkit.org/show_bug.cgi?id=181365
1464         <rdar://problem/36340647>
1465
1466         Reviewed by Tim Horton.
1467
1468         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1469         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1470         detail.
1471
1472         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1473         (TestWebKitAPI::TEST):
1474
1475 2018-01-08  Youenn Fablet  <youenn@apple.com>
1476
1477         navigator.onLine does not work inside service workers
1478         https://bugs.webkit.org/show_bug.cgi?id=181079
1479         <rdar://problem/36178606>
1480
1481         Reviewed by Darin Adler.
1482
1483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1484         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1485
1486 2018-01-07  Saam Barati  <sbarati@apple.com>
1487
1488         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1489         https://bugs.webkit.org/show_bug.cgi?id=181372
1490
1491         Reviewed by Filip Pizlo.
1492
1493         Adding these sorting modes makes it easier to analyze functions
1494         that recompile a lot and exit a lot.
1495
1496         * Scripts/display-profiler-output:
1497
1498 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1499
1500         Unreviewed, remove my Cisco email from contributors.json
1501
1502         * Scripts/webkitpy/common/config/contributors.json:
1503
1504 2018-01-05  JF Bastien  <jfbastien@apple.com>
1505
1506         WebAssembly: poison JS object's secrets
1507         https://bugs.webkit.org/show_bug.cgi?id=181339
1508         <rdar://problem/36325001>
1509
1510         Reviewed by Mark Lam.
1511
1512         Update tests for swap(Poisoned<k, T>, T*)
1513
1514         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1517         (TestWebKitAPI::TEST):
1518         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1519         (TestWebKitAPI::TEST):
1520
1521 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1522
1523         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1524         https://bugs.webkit.org/show_bug.cgi?id=181359
1525
1526         Reviewed by Tim Horton.
1527
1528         Ensure that these tests still pass using older SDKs.
1529
1530         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1531         (TestWebKitAPI::TEST):
1532
1533 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1534
1535         Rebase API test after r226469
1536         https://bugs.webkit.org/show_bug.cgi?id=181308
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1539         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1540         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1541
1542 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1543
1544         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1545         https://bugs.webkit.org/show_bug.cgi?id=181217
1546
1547         Reviewed by Tim Horton.
1548
1549         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1550         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1551         (TEST):
1552
1553 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1554
1555         Add WKBundleFrameCreateFrameHandle
1556         https://bugs.webkit.org/show_bug.cgi?id=181232
1557         <rdar://problem/35926696>
1558
1559         Reviewed by Tim Horton.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1563         (mouseDidMoveOverElement):
1564         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1565         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1566         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1567         (TEST):
1568
1569 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1570
1571         iOS: Build fix after r226432.
1572         
1573         Unreviewed. Stop duplicating speakAs symbols for iOS.
1574
1575         * DumpRenderTree/AccessibilityUIElement.cpp:
1576         (AccessibilityUIElement::speakAs):
1577
1578 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1579
1580         Unreviewed, added myself as WebKit reviewer
1581
1582         * Scripts/webkitpy/common/config/contributors.json:
1583
1584 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1585
1586         WPE: Build fix after r226432.
1587
1588         Unreviewed. Rename ::speak() to ::speakAs().
1589         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1590         (WTR::AccessibilityUIElement::speakAs):
1591         (WTR::AccessibilityUIElement::speak): Deleted.
1592
1593 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1594
1595         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1596         https://bugs.webkit.org/show_bug.cgi?id=180361
1597
1598         Reviewed by Zalan Bujtas.
1599
1600         * DumpRenderTree/AccessibilityUIElement.cpp:
1601         (speakAsCallback):
1602         (AccessibilityUIElement::speakAs):
1603         (AccessibilityUIElement::getJSClass):
1604         (speakCallback): Deleted.
1605         (AccessibilityUIElement::speak): Deleted.
1606         * DumpRenderTree/AccessibilityUIElement.h:
1607         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1608         (AccessibilityUIElement::speakAs):
1609         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1610         (AccessibilityUIElement::speakAs):
1611         (AccessibilityUIElement::speak): Deleted.
1612         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1613         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1614         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1615         (WTR::AccessibilityUIElement::speakAs):
1616         (WTR::AccessibilityUIElement::speak): Deleted.
1617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1618         (WTR::AccessibilityUIElement::speakAs):
1619         (WTR::AccessibilityUIElement::speak): Deleted.
1620
1621 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1622
1623         REGRESSION (r226395): test-webkitperl test expectations incorrect
1624         https://bugs.webkit.org/show_bug.cgi?id=181307
1625         <rdar://problem/36306558>
1626
1627         Rubber-stamped by Aakash Jain.
1628
1629         r226395 added two lines towards the beginning of
1630         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1631         numbers in the test expectations need to update.
1632
1633         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1634
1635 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1636
1637         WKWebView loses minimum layout size overrides that happen while the process is terminated
1638         https://bugs.webkit.org/show_bug.cgi?id=181306
1639         <rdar://problem/34398288>
1640
1641         Reviewed by Dan Bernstein.
1642
1643         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1644         (TEST):
1645         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1646         while the process is terminated results in the page getting the correct
1647         minimum layout size.
1648
1649 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1650
1651         [MediaStream] Add Mock screen capture source
1652         https://bugs.webkit.org/show_bug.cgi?id=181291
1653         <rdar://problem/36298164>
1654
1655         Reviewed by Dean Jackson.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1658         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1659         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1660
1661 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1662
1663         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1664
1665         Reviewed by Ling Ho.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1668
1669 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1670
1671         [Attachment Support] Create attachment elements when dropping files on iOS
1672         https://bugs.webkit.org/show_bug.cgi?id=181192
1673         <rdar://problem/36280945>
1674
1675         Reviewed by Tim Horton.
1676
1677         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1678         switch is enabled. See below for more details.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1681         (-[NSItemProvider registerData:type:]):
1682         (platformCopyPNG):
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1685
1686         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1687         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1688         kUTTypeRTF instead.
1689
1690         (TestWebKitAPI::TEST):
1691
1692         Tests a few cases of inserting attachment elements via drop:
1693         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1694             Instead of inserting the contents as inline web content, this should generate attachment elements.
1695         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1696             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1697             back to inserting the content as an attachment.
1698         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1699             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1700             or at the end).
1701
1702         * TestWebKitAPI/cocoa/TestWKWebView.h:
1703         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1704         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1705
1706         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1707         -stringByEvaluatingJavaScript to just turn around and call this.
1708
1709         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1710
1711 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1712
1713         Replace hard-coded paths in shebangs with #!/usr/bin/env
1714         https://bugs.webkit.org/show_bug.cgi?id=181040
1715
1716         Reviewed by Alex Christensen.
1717
1718         * BuildSlaveSupport/build-launcher-app:
1719         * BuildSlaveSupport/build-launcher-dmg:
1720         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1721         * BuildSlaveSupport/built-product-archive:
1722         * BuildSlaveSupport/clean-build:
1723         * BuildSlaveSupport/delete-stale-build-files:
1724         * BuildSlaveSupport/download-built-product:
1725         * BuildSlaveSupport/gtk/buildbot/log/run:
1726         * BuildSlaveSupport/gtk/buildbot/run:
1727         * BuildSlaveSupport/gtk/pulseaudio/run:
1728         * BuildSlaveSupport/kill-old-processes:
1729         * BuildSlaveSupport/test-result-archive:
1730         * BuildSlaveSupport/win/kill-old-processes:
1731         * Scripts/SpacingHeuristics.pm:
1732         * Scripts/add-include:
1733         * Scripts/build-api-tests:
1734         * Scripts/build-dumprendertree:
1735         * Scripts/build-imagediff:
1736         * Scripts/build-jsc:
1737         * Scripts/build-webkit:
1738         * Scripts/build-webkittestrunner:
1739         * Scripts/check-Xcode-source-file-types:
1740         * Scripts/check-dom-results:
1741         * Scripts/check-for-exit-time-destructors:
1742         * Scripts/check-for-global-initializers:
1743         * Scripts/check-for-inappropriate-objc-class-names:
1744         * Scripts/check-for-weak-vtables-and-externals:
1745         * Scripts/clean-header-guards:
1746         * Scripts/compare-timing-files:
1747         * Scripts/configure-xcode-for-ios-development:
1748         * Scripts/copy-webkitlibraries-to-product-directory:
1749         * Scripts/create-exports:
1750         * Scripts/debug-minibrowser:
1751         * Scripts/debug-safari:
1752         * Scripts/debug-test-runner:
1753         * Scripts/do-file-rename:
1754         * Scripts/do-webcore-rename:
1755         * Scripts/dump-webkit-tests-run:
1756         * Scripts/ensure-valid-python:
1757         * Scripts/execAppWithEnv:
1758         * Scripts/extract-localizable-js-strings:
1759         * Scripts/filter-build-webkit:
1760         * Scripts/find-extra-includes:
1761         * Scripts/fix-blink-patch:
1762         * Scripts/generate-coverage-data:
1763         * Scripts/git-add-reviewer:
1764         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1765         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1766         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1767         * Scripts/make-new-script-test:
1768         * Scripts/make-script-test-wrappers:
1769         * Scripts/package-root:
1770         * Scripts/parse-malloc-history:
1771         * Scripts/report-include-statistics:
1772         * Scripts/resolve-ChangeLogs:
1773         * Scripts/run-api-tests:
1774         * Scripts/run-bindings-tests:
1775         * Scripts/run-content-extension-tester:
1776         * Scripts/run-iexploder-tests:
1777         * Scripts/run-javascriptcore-tests:
1778         * Scripts/run-jsc:
1779         * Scripts/run-leaks:
1780         * Scripts/run-mangleme-tests:
1781         * Scripts/run-minibrowser:
1782         * Scripts/run-pageloadtest:
1783         * Scripts/run-regexp-tests:
1784         * Scripts/run-safari:
1785         * Scripts/run-sunspider:
1786         * Scripts/run-test-runner:
1787         * Scripts/run-webkit-app:
1788         * Scripts/run-webkit-httpd:
1789         * Scripts/run-webkit-websocketserver:
1790         * Scripts/set-webkit-configuration:
1791         * Scripts/show-pretty-diff:
1792         * Scripts/sort-Xcode-project-file:
1793         * Scripts/split-file-by-class:
1794         * Scripts/sunspider-compare-results:
1795         * Scripts/svn-apply:
1796         * Scripts/svn-unapply:
1797         * Scripts/test-webkit-scripts:
1798         * Scripts/test-webkitperl:
1799         * Scripts/update-iexploder-cssproperties:
1800         * Scripts/update-javascriptcore-test-results:
1801         * Scripts/update-webkit:
1802         * Scripts/update-webkit-auxiliary-libs:
1803         * Scripts/update-webkit-dependency:
1804         * Scripts/update-webkit-libs-jhbuild:
1805         * Scripts/update-webkit-localizable-strings:
1806         * Scripts/update-webkit-support-libs:
1807         * Scripts/update-webkitgtk-libs:
1808         * Scripts/update-webkitwpe-libs:
1809         * Scripts/webkit-build-directory:
1810         * Scripts/webkitperl/LoadAsModule.pm:
1811         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1812         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1813         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1814         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1815         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1816         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1817         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1818         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1819         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1820         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1821         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1822         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1823         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1824         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1825         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1826         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1827         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1828         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1829         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1830         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1831         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1832         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1833         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1834         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1835         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1836         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1837         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1838         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1839         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1840         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1841         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1842         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1843         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1844         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1845         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1846         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1847         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1848         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1849         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1850         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1851         * ccache/ccache-clang:
1852         * ccache/ccache-clang++:
1853         * ccache/ccache-wrapper:
1854         * gtk/install-dependencies:
1855         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1856         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1857         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1858         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1859         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1860         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1861         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1862         * iExploder/iexploder-1.7.2/src/webserver.rb:
1863         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1864         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1865         * wpe/install-dependencies:
1866
1867 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1868
1869         filter-build-webkit filters out useful compiler error lines
1870         https://bugs.webkit.org/show_bug.cgi?id=179864
1871
1872         Reviewed by Tim Horton.
1873
1874         Don't filter out lines that contain information about build errors by always showing lines
1875         after a line that contains "note:" or "error:".
1876
1877         * Scripts/filter-build-webkit:
1878         (shouldShowSubsequentLine):
1879         (shouldIgnoreLine):
1880
1881 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1882
1883         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1884         https://bugs.webkit.org/show_bug.cgi?id=173915
1885
1886         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1887         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1888         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1889         empty string in this case.
1890
1891         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1892         (emitFormSubmissionEvent):
1893
1894 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1895
1896         [GTK] Add web process API to detect when form is submitted via JavaScript
1897         https://bugs.webkit.org/show_bug.cgi?id=173915
1898
1899         Reviewed by Carlos Garcia Campos.
1900
1901         Test it.
1902
1903         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1904         (FormSubmissionTest::FormSubmissionTest):
1905         (FormSubmissionTest::~FormSubmissionTest):
1906         (FormSubmissionTest::testFormSubmissionResult):
1907         (FormSubmissionTest::willSendDOMEventCallback):
1908         (FormSubmissionTest::willCompleteCallback):
1909         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1910         (testWebExtensionFormSubmissionSteps):
1911         (beforeAll):
1912         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1913         (DelayedSignal::DelayedSignal):
1914         (emitFormSubmissionEvent):
1915         (handleFormSubmissionCallback):
1916         (willSubmitFormCallback):
1917         (pageCreatedCallback):
1918
1919 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1920
1921         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1922         https://bugs.webkit.org/show_bug.cgi?id=181251
1923
1924         * Scripts/run-gtk-tests:
1925         (GtkTestRunner):
1926
1927 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1928
1929         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1930         https://bugs.webkit.org/show_bug.cgi?id=181136
1931
1932         * Scripts/run-gtk-tests:
1933         (GtkTestRunner):
1934
1935 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1936
1937         [macOS, iOS] Adopt new secure coding APIs in WebKit
1938         https://bugs.webkit.org/show_bug.cgi?id=181085
1939         <rdar://problem/34837397>
1940
1941         Reviewed by Tim Horton.
1942
1943         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1944         capable of supporting NSSecureCoding, so pass through the current coding routines.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1947         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1948         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1949         routines if necessary.
1950         (TEST): Updated for NSSecureCoding.
1951         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1952         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1953
1954 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1955
1956         Remove std::chrono completely
1957         https://bugs.webkit.org/show_bug.cgi?id=181186
1958
1959         Reviewed by Alex Christensen.
1960
1961         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1962         (WTR::TestController::platformRunUntil):
1963
1964 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1965
1966         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1967         https://bugs.webkit.org/show_bug.cgi?id=181231
1968
1969         Reviewed by Alex Christensen.
1970
1971         Implement TestController APIs needed by ResourceLoadStatistics tests.
1972
1973         * WebKitTestRunner/TestController.cpp:
1974         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1975         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1976
1977 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1978
1979         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1980         https://bugs.webkit.org/show_bug.cgi?id=181219
1981
1982         Reviewed by Wenson Hsieh.
1983
1984         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1985
1986 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1987
1988         Add a WebAuthentication runtime feature flag
1989         https://bugs.webkit.org/show_bug.cgi?id=181220
1990         <rdar://problem/36055305>
1991
1992         Reviewed by Brent Fulgham.
1993
1994         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1995
1996         * DumpRenderTree/TestOptions.h:
1997         * DumpRenderTree/TestOptions.mm:
1998         (TestOptions::TestOptions):
1999         * DumpRenderTree/mac/DumpRenderTree.mm:
2000         (enableExperimentalFeatures):
2001         (setWebPreferencesForTestOptions):
2002         * WebKitTestRunner/TestController.cpp:
2003         (WTR::TestController::resetPreferencesToConsistentValues):
2004         (WTR::updateTestOptionsFromTestHeader):
2005         * WebKitTestRunner/TestOptions.h:
2006         (WTR::TestOptions::hasSameInitializationOptions const):
2007
2008 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2009
2010         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2011         https://bugs.webkit.org/show_bug.cgi?id=181143
2012         <rdar://problem/36200381>
2013
2014         Reviewed by Tim Horton.
2015
2016         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2017         attachment elements are enabled.
2018
2019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2020         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2021         (TestWebKitAPI::TEST):
2022
2023 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2024
2025         Update Credential Management API for WebAuthentication
2026         https://bugs.webkit.org/show_bug.cgi?id=181082
2027         <rdar://problem/36055239>
2028
2029         Reviewed by Brent Fulgham.
2030
2031         Enable Credential Management API for testing.
2032
2033         * DumpRenderTree/TestOptions.h:
2034         * WebKitTestRunner/TestOptions.h:
2035
2036 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2037
2038         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2039         https://bugs.webkit.org/show_bug.cgi?id=168194
2040
2041         Reviewed by Carlos Garcia Campos.
2042
2043         Fix an assertion and unskip the test. The order that form controls are associated is not
2044         guaranteed.
2045
2046         * Scripts/run-gtk-tests:
2047         (GtkTestRunner):
2048         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2049         (didAssociateFormControlsCallback):
2050
2051 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2052
2053         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2054         https://bugs.webkit.org/show_bug.cgi?id=180897
2055         <rdar://problem/35535328>
2056
2057         Reviewed by Brent Fulgham.
2058
2059         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2060
2061         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2062         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2063         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2064         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2065         (websiteDataStoreTestWebView):
2066         (TEST):
2067
2068 == Rolled over to ChangeLog-2018-01-01 ==