[WebAuthN] Enable LocalAuthenticator for macOS
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2
3         [WebAuthN] Enable LocalAuthenticator for macOS
4         https://bugs.webkit.org/show_bug.cgi?id=182772
5         <rdar://problem/43347920>
6
7         Reviewed by Brent Fulgham.
8
9         Add an entitlement file to WebKitTestRunner such that it can access
10         the modern macOS keychain.
11
12         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
13         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
14         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
15         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
16         (WTR::TestController::addTestKeyToKeychain):
17         (WTR::TestController::cleanUpKeychain):
18         (WTR::TestController::keyExistsInKeychain):
19
20 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
21
22         [results.webkit.org Timeline] Performance improvements
23         https://bugs.webkit.org/show_bug.cgi?id=200406
24
25         Reviewed by Jonathan Bedard.
26
27         1. Unhook the scroll event when a series/axis have been removed from the container 
28         2. Fix the axis's cache data structure out of sync.
29         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
30         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
31
32
33         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
34         (Signal.prototype.removeListener):
35         (prototype.stopAction): Unregsiter an action handler
36         (Ref):
37         (Ref.prototype.apply):
38         (Ref.prototype.destory):
39         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
40         (ApplyNewChildren):
41         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
42         (Timeline.CanvasSeriesComponent):
43
44 2019-08-06  Jer Noble  <jer.noble@apple.com>
45
46         Add test for behavior introduced in r248174
47         https://bugs.webkit.org/show_bug.cgi?id=200446
48
49         Reviewed by Eric Carlson.
50
51         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
52         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
53         (WebKit::configureSecheuristic):
54         (WebKit::TEST):
55
56 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
57
58         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
59         https://bugs.webkit.org/show_bug.cgi?id=200464
60
61         Reviewed by Ross Kirsling.
62
63         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
64         menu, Alt-F4 to close window, and etc) don't work.
65
66         WK1 WebView doesn't have this issue because it processes key events
67         properly.
68
69         * MiniBrowser/win/WebKitBrowserWindow.cpp:
70         (WebKitBrowserWindow::WebKitBrowserWindow):
71         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
72         unhandled key events to the main window.
73         * MiniBrowser/win/WebKitBrowserWindow.h:
74
75 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
76
77         iOS 13: Overflow:hidden on body prevents PDF scroll
78         https://bugs.webkit.org/show_bug.cgi?id=200435
79         rdar://problem/53942888
80
81         Reviewed by Tim Horton.
82     
83         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
84         to make sure that the scroll view is scrollable.
85
86         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
87         (TestWebKitAPI::TEST):
88
89 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
90
91         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
92         https://bugs.webkit.org/show_bug.cgi?id=200400
93
94         Reviewed by Jonathan Bedard.
95
96         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
97         (StatusBubble._build_bubble):
98         (StatusBubble._queue_position):
99
100 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
101
102         run-webkit-tests asserts when the iPhone XR simulator is running
103         https://bugs.webkit.org/show_bug.cgi?id=200404
104         <rdar://problem/53878739>
105
106         Reviewed by Dean Jackson.
107
108         Support unicode in all logging statements tied to device model.
109
110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
111         (Manager.run):
112         * Scripts/webkitpy/layout_tests/views/printing.py:
113         (Printer.print_baseline_search_path):
114         * Scripts/webkitpy/port/device.py:
115         (Device.__repr__):
116         * Scripts/webkitpy/port/device_port.py:
117         (DevicePort._install):
118         (DevicePort.setup_test_run):
119         (DevicePort.clean_up_test_run):
120         (DevicePort.configuration_for_upload):
121         * Scripts/webkitpy/port/ios.py:
122         (IOSPort.default_baseline_search_path):
123         * Scripts/webkitpy/xcode/device_type.py:
124         (DeviceType.__str__):
125         * Scripts/webkitpy/xcode/simulated_device.py:
126         (SimulatedDeviceManager.populate_available_devices):
127         (SimulatedDeviceManager._find_available_name):
128         (SimulatedDeviceManager._get_device_identifier_for_type):
129         (SimulatedDeviceManager._create_or_find_device_for_request):
130         (SimulatedDeviceManager._does_fulfill_request):
131         (SimulatedDeviceManager._wait_until_device_in_state):
132         (SimulatedDeviceManager._wait_until_device_is_usable):
133         (SimulatedDeviceManager._boot_device):
134         (SimulatedDeviceManager.initialize_devices):
135         (SimulatedDeviceManager.max_supported_simulators):
136         (SimulatedDeviceManager.swap):
137         (SimulatedDevice.is_usable):
138         (SimulatedDevice._shut_down):
139         (SimulatedDevice._delete):
140         (SimulatedDevice.launch_app):
141         (SimulatedDevice.__repr__):
142
143 2019-08-04  Chris Dumez  <cdumez@apple.com>
144
145         Ping loads should not prevent page caching
146         https://bugs.webkit.org/show_bug.cgi?id=200418
147         <rdar://problem/53901632>
148
149         Reviewed by Darin Adler.
150
151         Add TestOption to enable PageCache at UIProcess-level so that we can test
152         page caching when navigating cross-origin with PSON enabled.
153
154         * WebKitTestRunner/TestController.cpp:
155         (WTR::TestController::resetPreferencesToConsistentValues):
156         (WTR::updateTestOptionsFromTestHeader):
157         * WebKitTestRunner/TestOptions.h:
158         (WTR::TestOptions::hasSameInitializationOptions const):
159
160 2019-08-02  Keith Rollin  <krollin@apple.com>
161
162         Consistently use Obj-C boolean literals
163         https://bugs.webkit.org/show_bug.cgi?id=200405
164         <rdar://problem/53880043>
165
166         Reviewed by Simon Fraser, Joseph Pecoraro.
167
168         There are places where we use equivalent but different expressions for
169         Obj-C boolean objects. For example, we use both [NSNumber
170         numberWithBool:YES] and @YES. There are places where both are used in
171         the same function, such as -[WebPreferences initialize]. The boolean
172         literal is in greater use and is more succinct, so standardize on
173         that. Also, change @(YES/NO) to @YES/NO.
174
175         * DumpRenderTree/mac/ObjCController.m:
176         (-[ObjCController objectOfClass:]):
177         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
178         (TEST):
179         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
180         (overrideAddObserverForName):
181         * TestWebKitAPI/ios/mainIOS.mm:
182         (main):
183         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
184         (TestWebKitAPI::InjectedBundleController::platformInitialize):
185         * TestWebKitAPI/mac/mainMac.mm:
186         (main):
187         * WebKitLauncher/WebKitNightlyEnabler.m:
188         (enableWebKitNightlyBehaviour):
189
190 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
191
192         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
193         https://bugs.webkit.org/show_bug.cgi?id=200402
194         <rdar://problem/53823368>
195
196         Reviewed by Tim Horton.
197
198         Make it possible to run this test using the iPad simulator.
199
200         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
201
202         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
203         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
204         since this would result in differently sized text.
205
206         (mainScreenReferenceBoundsOverride):
207         * TestWebKitAPI/ios/UIKitSPI.h:
208
209 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
210
211         API tests using permanent credentials should clear credentials left by previous tests
212         https://bugs.webkit.org/show_bug.cgi?id=199729
213
214         Reviewed by Alex Christensen.
215
216         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those 
217         credentials will not affect tests running after. There is a case where permanent credentials were left on the 
218         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading 
219         failure. To prevent this from happening again, add cleanup at the begining of the tests.
220
221         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
222         (TEST):
223         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
224         (TestWebKitAPI::TEST):
225
226 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
227
228         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
229         https://bugs.webkit.org/show_bug.cgi?id=200394
230         <rdar://problem/52914964>
231
232         Reviewed by Chris Fleizach.
233
234         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
235
236         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
237         (WTR::AccessibilityUIElement::isInTableCell const):
238         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
239         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
240         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
241         (WTR::AccessibilityUIElement::isInTableCell const):
242
243 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
244
245         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
246         https://bugs.webkit.org/show_bug.cgi?id=200397
247
248         Reviewed by Jonathan Bedard.
249
250         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
251
252 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
253
254         [macOS 10.15] Image dragged from Safari does not appear in Notes
255         https://bugs.webkit.org/show_bug.cgi?id=188490
256         <rdar://problem/39462717>
257
258         Reviewed by Andy Estes.
259
260         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
261
262         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
263
264 2019-08-02  Alex Christensen  <achristensen@webkit.org>
265
266         Fix API test after r248139
267         https://bugs.webkit.org/show_bug.cgi?id=200102
268
269         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
270         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
271         This was supposed to be removed as part of reverting r245322.
272
273 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
274
275         results.webkit.org: Force update cache when timeline updated
276         https://bugs.webkit.org/show_bug.cgi?id=200363
277
278         Reviewed by Jonathan Bedard.
279
280         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
281         (offscreenCachedRenderFactory): Add ability to force the redraw.
282         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
283         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
284
285 2019-08-01  Alex Christensen  <achristensen@webkit.org>
286
287         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
288         https://bugs.webkit.org/show_bug.cgi?id=200360
289
290         Reviewed by Tim Horton.
291
292         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
293         (cleanupITPDatabase):
294         (TEST):
295
296 2019-08-01  Alex Christensen  <achristensen@webkit.org>
297
298         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
299         https://bugs.webkit.org/show_bug.cgi?id=200102
300         <rdar://problem/53275114>
301
302         Reviewed by Darin Adler.
303
304         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
305         and because clicking on a TestWKWebView only works on Mac.
306
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
309         (-[UploadDelegate initWithDirectory:]):
310         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
311         (-[UploadDelegate sentDirectory]):
312         (TEST):
313         * TestWebKitAPI/cocoa/TestWKWebView.h:
314         * TestWebKitAPI/cocoa/TestWKWebView.mm:
315         (-[TestWKWebView sendClickAtPoint:]):
316
317 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
318
319         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
320         https://bugs.webkit.org/show_bug.cgi?id=200321
321
322         Reviewed by Jonathan Bedard.
323
324         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
325         Let the axis' height be defined in the option. Timeine component will use this value as 
326         padding-top for headers which allows headers start in the right position, even with multiple 
327         top axises.
328         (Timeline.CanvasSeriesComponent):
329         (prototype.Timeline.CanvasContainer):
330
331 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
332
333         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
334         https://bugs.webkit.org/show_bug.cgi?id=200347
335
336         Reviewed by Jonathan Bedard.
337
338         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
339         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
340
341 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
342
343         Improve flakiness of SOAuthorizationRedirect tests
344         https://bugs.webkit.org/show_bug.cgi?id=200320
345         <rdar://problem/53767057>
346
347         Reviewed by Alex Christensen.
348
349         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
350         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
351         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
352         is executed.
353
354         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
355         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
356         (resetState):
357         (TestWebKitAPI::TEST):
358
359 2019-08-01  Keith Rollin  <krollin@apple.com>
360
361         Update TestWebKitAPI for XCBuild
362         https://bugs.webkit.org/show_bug.cgi?id=200311
363         <rdar://problem/53773804>
364
365         Reviewed by Alex Christensen.
366
367         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
368         technique. Now update WebKitLegacy to build under XCBuild after those
369         changes. This work involves adding an "Apply Configuration to
370         XCFileLists" build target, adding a check-xcfilelists.sh script,
371         adding a "Check xcfilelists" build phase that calls that script,
372         adding knowledge of the project to the generate-xcfilelists script,
373         creating new .xcfilelist files, and adding those to the project.
374
375         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
376         (Application.__init__):
377         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
378         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
379         (TestWebKitAPIGenerator):
380         (TestWebKitAPIGenerator._get_project_file_path):
381         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
382         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
385
386 2019-08-01  Youenn Fablet  <youenn@apple.com>
387
388         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
389         https://bugs.webkit.org/show_bug.cgi?id=200317
390
391         Reviewed by Eric Carlson.
392
393         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
395         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
396         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
397         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
398         (TestWebKitAPI::TEST):
399
400 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
401
402         New EWS: Cannot see build status page when patch is waiting for tester
403         https://bugs.webkit.org/show_bug.cgi?id=200333
404
405         Reviewed by Jonathan Bedard.
406
407         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
408         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
409
410 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
411
412         [SOUP] Switch to use libsoup WebSockets API
413         https://bugs.webkit.org/show_bug.cgi?id=200162
414
415         Reviewed by Michael Catanzaro.
416
417         Update libsoup version to 2.67.90.
418
419         * gtk/jhbuild.modules:
420         * wpe/jhbuild.modules:
421
422 2019-07-31  Andy Estes  <aestes@apple.com>
423
424         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
425         https://bugs.webkit.org/show_bug.cgi?id=200293
426         <rdar://problem/52937749>
427
428         Reviewed by Alex Christensen.
429
430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
431         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
432         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
433         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
434         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
435         (TEST):
436
437 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
438
439         [ews-build] Enable all macOS queues on new EWS
440         https://bugs.webkit.org/show_bug.cgi?id=199944
441
442         Reviewed by Jonathan Bedard.
443
444         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
445         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
446         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
447         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
449         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
450
451 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
452
453         Unreviewed test gardening, disable failing test for rdar://51752593.
454
455         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
456
457 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
458
459         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
460         https://bugs.webkit.org/show_bug.cgi?id=200318
461
462         Reviewed by Aakash Jain.
463
464         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
465         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
466         (Timeline.CanvasXAxisComponent): Use getLabel function.
467
468 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
469
470         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
471         https://bugs.webkit.org/show_bug.cgi?id=200306
472
473         Reviewed by Michael Catanzaro.
474
475         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
476         jsc-glib-4.0-scan for example).
477
478         * Scripts/webkitdirs.pm:
479         (generateBuildSystemFromCMakeProject):
480
481 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
482
483         Unreviewed test gardening, disable failing test for rdar://52355829.
484
485         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
486         (TEST):
487
488 2019-07-31  Keith Rollin  <krollin@apple.com>
489
490         Update WebKitLegacy for XCBuild
491         https://bugs.webkit.org/show_bug.cgi?id=200310
492         <rdar://problem/53773708>
493
494         Reviewed by Alex Christensen.
495
496         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
497         technique. Now update WebKitLegacy to build under XCBuild after those
498         changes. This work involves adding an "Apply Configuration to
499         XCFileLists" build target, adding a check-xcfilelists.sh script,
500         adding a "Check xcfilelists" build phase that calls that script,
501         adding knowledge of the project to the generate-xcfilelists script,
502         creating new .xcfilelist files, and adding those to the project.
503
504         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
505         (Application.__init__):
506         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
507         (JavaScriptCoreGenerator):
508         (WebCoreGenerator):
509         (WebKitGenerator):
510         (WebKitGenerator._get_generate_unified_sources_script):
511         (WebKitLegacyGenerator):
512         (WebKitLegacyGenerator._get_project_file_path):
513         (WebKitLegacyGenerator._get_generate_unified_sources_script):
514
515 2019-07-31  Chris Dumez  <cdumez@apple.com>
516
517         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
518         https://bugs.webkit.org/show_bug.cgi?id=200086
519         <rdar://problem/53501721>
520
521         Reviewed by Alex Christensen.
522
523         re-enable the API test.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
526         (TEST):
527
528 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
531         https://bugs.webkit.org/show_bug.cgi?id=200291
532         <rdar://problem/53717946>
533
534         Reviewed by Megan Gardner.
535
536         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
537         after closing the web view, while the web view's content view isn't the first responder.
538
539         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
540         * TestWebKitAPI/ios/UIKitSPI.h:
541
542 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
543
544         [GTK] Datalist element support for TextFieldInputType
545         https://bugs.webkit.org/show_bug.cgi?id=98934
546
547         Reviewed by Michael Catanzaro.
548
549         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
550
551         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
552         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
553         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
554
555 2019-07-30  Tim Horton  <timothy_horton@apple.com>
556
557         Remove some needless comments that snuck into the tree
558
559         * TestRunnerShared/UIScriptContext/UIScriptController.h:
560         (WTR::UIScriptController::setHardwareKeyboardAttached):
561         (WTR::UIScriptController::playBackEventStream):
562
563 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
564
565         [WebKit] Add PageLoadState::Observer C API
566         https://bugs.webkit.org/show_bug.cgi?id=199848
567
568         Reviewed by Alex Christensen.
569
570         * MiniBrowser/win/WebKitBrowserWindow.cpp:
571         (WebKitBrowserWindow::WebKitBrowserWindow):
572         (WebKitBrowserWindow::didChangeTitle):
573         (WebKitBrowserWindow::didFinishNavigation): Deleted.
574         * MiniBrowser/win/WebKitBrowserWindow.h:
575         * TestWebKitAPI/CMakeLists.txt:
576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
577         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
578         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
579         (TestWebKitAPI::didChangeActiveURL):
580         (TestWebKitAPI::didChangeCanGoBack):
581         (TestWebKitAPI::didChangeCanGoForward):
582         (TestWebKitAPI::didChangeCertificateInfo):
583         (TestWebKitAPI::didChangeEstimatedProgress):
584         (TestWebKitAPI::didChangeHasOnlySecureContent):
585         (TestWebKitAPI::didChangeIsLoading):
586         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
587         (TestWebKitAPI::didChangeTitle):
588         (TestWebKitAPI::didChangeWebProcessIsResponsive):
589         (TestWebKitAPI::didSwapWebProcesses):
590         (TestWebKitAPI::willChangeActiveURL):
591         (TestWebKitAPI::willChangeCanGoBack):
592         (TestWebKitAPI::willChangeCanGoForward):
593         (TestWebKitAPI::willChangeCertificateInfo):
594         (TestWebKitAPI::willChangeEstimatedProgress):
595         (TestWebKitAPI::willChangeHasOnlySecureContent):
596         (TestWebKitAPI::willChangeIsLoading):
597         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
598         (TestWebKitAPI::willChangeTitle):
599         (TestWebKitAPI::willChangeWebProcessIsResponsive):
600         (TestWebKitAPI::didFinishNavigation):
601         (TestWebKitAPI::TEST):
602
603 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
604
605         DumpRenderTree.app: Add CFBundleShortVersionString
606         https://bugs.webkit.org/show_bug.cgi?id=200269
607         <rdar://problem/53412596>
608
609         Rubber-stamped by Aakash Jain.
610
611         * DumpRenderTree/ios/Info.plist:
612
613 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
614
615         Add layout test coverage for <https://webkit.org/b/200215>
616         https://bugs.webkit.org/show_bug.cgi?id=200245
617         <rdar://problem/52976965>
618
619         Reviewed by Tim Horton.
620
621         Add new testing infrastructure. See below for more details.
622
623         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
624         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
625         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
626         (WTR::UIScriptController::setWillCreateNewPageCallback):
627         (WTR::UIScriptController::willCreateNewPageCallback const):
628
629         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
630         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
631
632         * TestRunnerShared/UIScriptContext/UIScriptController.h:
633         (WTR::UIScriptController::becomeFirstResponder):
634
635         Add and implement a Cocoa platform hook to make the web view first responder.
636
637         * WebKitTestRunner/TestController.cpp:
638         (WTR::TestController::createOtherPage):
639         * WebKitTestRunner/TestInvocation.cpp:
640         (WTR::TestInvocation::willCreateNewPage):
641         * WebKitTestRunner/TestInvocation.h:
642         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
643         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
644         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
645
646 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
647
648         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
649         https://bugs.webkit.org/show_bug.cgi?id=200217
650
651         Reviewed by Alex Christensen.
652
653         * MiniBrowser/win/BrowserWindow.h:
654         * MiniBrowser/win/MainWindow.cpp:
655         (MainWindow::init):
656         (MainWindow::resizeSubViews):
657         (MainWindow::WndProc):
658         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
659         * MiniBrowser/win/MiniBrowserLib.rc:
660         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
661         * MiniBrowser/win/WebKitBrowserWindow.cpp:
662         (WebKitBrowserWindow::reload):
663         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
664         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
665         (WebKitLegacyBrowserWindow::reload):
666         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
667
668 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
669
670         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
671         https://bugs.webkit.org/show_bug.cgi?id=200218
672
673         Reviewed by Alex Christensen.
674
675         Moved the scheme supplementing logic from
676         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
677
678         * MiniBrowser/win/MainWindow.cpp:
679         (MainWindow::loadURL):
680         (MainWindow::onURLBarEnter):
681         * MiniBrowser/win/MainWindow.h:
682         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
683         (WebKitLegacyBrowserWindow::loadURL):
684
685 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
686
687         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
688         https://bugs.webkit.org/show_bug.cgi?id=200254
689
690         Unreviewed infrastructure fix.
691
692         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
693
694 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
695
696         [Canvas Timeline] Compact canvas timeline
697         https://bugs.webkit.org/show_bug.cgi?id=200177
698
699         Reviewed by Jonathan Bedard.
700
701         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
702         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
703         (Timeline.CanvasSeriesComponent):
704
705 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
706
707         Multiple context menu actions broken for YouTube videos
708         https://bugs.webkit.org/show_bug.cgi?id=199999
709
710         Reviewed by Eric Carlson.
711
712         Add a test case to check copy link address, open in new window and download options are not included in the
713         context menu for non-downloadable media.
714
715         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
716         (writeNextChunk):
717         (serverCallback):
718         (testContextMenuLiveStream):
719         (beforeAll):
720         (afterAll):
721
722 2019-07-28  Tim Horton  <timothy_horton@apple.com>
723
724         Reorganize UIScriptController into platform-specific subclasses
725         https://bugs.webkit.org/show_bug.cgi?id=200027
726
727         Reviewed by Simon Fraser.
728
729         Instead of a mishmash of #ifdefs and extraneous empty functions,
730         reorganize UIScriptController so that we have a base class
731         with functions that assert if called (to make it harder to
732         accidentally write a test that depends on unimplemented
733         functionality), and override them in platform specific subclasses
734         as functionality is added.
735
736         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
737         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
738         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
739         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
740         * DumpRenderTree/mac/UIScriptControllerMac.mm:
741         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
742         * TestRunnerShared/UIScriptContext/UIScriptController.h:
743         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
744         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
745         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
746         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
747         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
748         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
749         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
750         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
751         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
752
753 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
754
755         [Win][MiniBrowser] Remove PageLoadTestClient
756         https://bugs.webkit.org/show_bug.cgi?id=200155
757
758         Reviewed by Brent Fulgham.
759
760         It is not used nowadays.
761
762         * MiniBrowser/win/CMakeLists.txt:
763         * MiniBrowser/win/Common.cpp:
764         (parseCommandLine):
765         * MiniBrowser/win/Common.h:
766         * MiniBrowser/win/MainWindow.cpp:
767         (MainWindow::init):
768         * MiniBrowser/win/MainWindow.h:
769         * MiniBrowser/win/MiniBrowserWebHost.cpp:
770         (MiniBrowserWebHost::updateAddressBar):
771         (MiniBrowserWebHost::didFinishLoadForFrame):
772         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
773         (MiniBrowserWebHost::didFailLoadWithError):
774         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
775         (MiniBrowserWebHost::didFirstLayoutInFrame):
776         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
777         * MiniBrowser/win/PageLoadTestClient.h: Removed.
778         * MiniBrowser/win/ResourceLoadDelegate.cpp:
779         (ResourceLoadDelegate::identifierForInitialRequest):
780         (ResourceLoadDelegate::willSendRequest):
781         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
782         (ResourceLoadDelegate::didFailLoadingWithError):
783         * MiniBrowser/win/WebKitBrowserWindow.cpp:
784         (WebKitBrowserWindow::create):
785         (WebKitBrowserWindow::createNewPage):
786         * MiniBrowser/win/WebKitBrowserWindow.h:
787         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
788         (WebKitLegacyBrowserWindow::create):
789         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
790         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
791         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
792         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
793         * MiniBrowser/win/WinMain.cpp:
794         (wWinMain):
795
796 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
797
798         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
799         https://bugs.webkit.org/show_bug.cgi?id=200150
800         <rdar://problem/53280170>
801
802         Reviewed by Brent Fulgham.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
805         (TestWebKitAPI::TEST):
806
807 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
808
809         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
810         https://bugs.webkit.org/show_bug.cgi?id=200090
811
812         Unreviewed follow-up fix.
813
814         * resultsdbpy/resultsdbpy/view/view_routes.py:
815         (ViewRoutes.__init__): Keep /search endpoint for existing links
816
817 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
818
819         results.webkit.org: Add switch to filter results by expectation
820         https://bugs.webkit.org/show_bug.cgi?id=200134
821
822         Rubber-stamped by Aakash Jain.
823
824         Users of the results database should be able to easily differentiate tests which are expected
825         to fail verse tests which are unexpectedly failing.
826
827         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
828         (Timeline.render): Respect the willFilterExpected variable.
829         (LegendLabel): Generates html for label in the legend.
830         (Legend): Add switch for filter results.
831         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
832         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
833
834 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
835
836         [ews-build] Use update-webkit script in Style EWS
837         https://bugs.webkit.org/show_bug.cgi?id=193196
838
839         Reviewed by Jonathan Bedard.
840
841         * BuildSlaveSupport/ews-build/factories.py:
842         (StyleFactory): Updated to use CheckOutSource step as well.
843         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
844         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
845
846 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
847
848         results.webkit.org: Support buildbot 0.8 CI links
849         https://bugs.webkit.org/show_bug.cgi?id=200146
850
851         Reviewed by Aakash Jain.
852
853         * resultsdbpy/resultsdbpy/model/ci_context.py:
854         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
855         (BuildbotEightURLFactory.__init__):
856         (BuildbotEightURLFactory.url):
857         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
858         (URLFactoryTest.test_old_builder_url):
859         (URLFactoryTest):
860         (URLFactoryTest.test_old_worker_url):
861
862 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
863
864         results.webkit.org: Suite results shouldn't be the landing page
865         https://bugs.webkit.org/show_bug.cgi?id=200090
866
867         Reviewed by Aakash Jain.
868
869         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
870         * resultsdbpy/resultsdbpy/view/view_routes.py:
871         (ViewRoutes.__init__): Make search the landing page instead of suite results.
872         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
873         (WebSiteUnittest.test_main):
874
875 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
876
877         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
878         https://bugs.webkit.org/show_bug.cgi?id=200127
879
880         Unreviewed follow-up fix.
881
882         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
883         (Dot.toString): Use self instead of this in render callback.
884
885 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
886
887         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
888         https://bugs.webkit.org/show_bug.cgi?id=200108
889         <rdar://problem/53521238>
890
891         Reviewed by Chris Dumez.
892
893         Added an API test.
894
895         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
896         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
897         (TEST):
898
899 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
900
901         results.webkit.org: Color should be the worst result, count should include all results
902         https://bugs.webkit.org/show_bug.cgi?id=200127
903
904         Rubber-stamped by Aakash Jain.
905
906         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
907         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
908
909 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
910
911         [Timeline]: Make timeline header width automatic, instead of fixed width
912         https://bugs.webkit.org/show_bug.cgi?id=200059
913
914         Reviewed by Jonathan Bedard.
915
916         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
917         (.dot.crash):
918         (.timeline>.header): Deleted.
919         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
920         (.timeline>.content):
921         (.timeline>.header):
922
923 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
924
925         [ESNext] Implement nullish coalescing
926         https://bugs.webkit.org/show_bug.cgi?id=200072
927
928         Reviewed by Darin Adler.
929
930         * Scripts/run-jsc-stress-tests:
931
932 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
933
934         Add Takashi Komori and Tomoki Imai as contributors
935
936         Unreviewed.
937
938         * Scripts/webkitpy/common/config/contributors.json:
939
940 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
941
942         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
943         https://bugs.webkit.org/show_bug.cgi?id=200103
944
945         Reviewed by Mark Lam.
946
947         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
948         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
949
950         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
951         to the future implementation changes while it catches the severe issues we had.
952
953         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
954         (assertEmptyPointerSet):
955         (assertHasOnlyObjects):
956         (assertClean):
957         (TEST):
958         (allocateAndDeallocate):
959
960 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
961
962         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
963         https://bugs.webkit.org/show_bug.cgi?id=200074
964
965         Reviewed by Michael Catanzaro.
966
967         There was a latent issue. PluginTest::indicateTestFailure was
968         using WTF::sleep without linking WTF.
969
970         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
971         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
972
973 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
974
975         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
976         https://bugs.webkit.org/show_bug.cgi?id=200073
977
978         Reviewed by Michael Catanzaro.
979
980         * TestWebKitAPI/PlatformGTK.cmake:
981         * TestWebKitAPI/PlatformWPE.cmake:
982         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
983
984 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
985
986         [webkitperl] runCommand doesn't work in Windows Perl
987         https://bugs.webkit.org/show_bug.cgi?id=199900
988
989         Reviewed by Don Olmstead.
990
991         runCommand was always failing implicit fork by using 'open' with
992         '-|' in Windows Perl. Explicitly specify the command to 'open' not
993         to do the implicit fork.
994
995         There is one more difference between Windows and Unix. 'open'
996         successes on Windows even for non existent command while it fails
997         on Unix. So, return the same error code on Unix as well as
998         Windows.
999
1000         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1001         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1002         command is not available on Windows. Use Perl ($^X) instead.
1003
1004 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1005
1006         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1007         https://bugs.webkit.org/show_bug.cgi?id=199326
1008         rdar://problem/42816957
1009
1010         Reviewed by Wenson Hsieh.
1011
1012         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1013         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1014         is being properly populated with additional context dictionary.
1015
1016         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1017         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1018         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1019         which will populate the additional autofill context dictionary.
1020
1021         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1022         populates the additional autofill context dictionary.
1023
1024         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1025         context dictionary.
1026
1027         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the 
1028         input field requires strong password work.
1029
1030         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1031         input field requires strong password work.
1032
1033         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1034         password work.
1035
1036 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1037
1038         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1039         https://bugs.webkit.org/show_bug.cgi?id=199489
1040
1041         Reviewed by Aakash Jain.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1044         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1045         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1046         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1047         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1048         (runTest): Record test binary failure
1049         (reportTestFailures): Report test binary failure
1050         (runJSCStressTests): 
1051         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1052         (JscOnlyPort.build_jsc_command):
1053         (JscOnlyPort):
1054         (JscOnlyPort.run_javascriptcore_tests_command):
1055         * Scripts/webkitpy/common/config/ports_unittest.py:
1056         (DeprecatedPortTest.test_jsconly_port):
1057
1058 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1059
1060         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1061         https://bugs.webkit.org/show_bug.cgi?id=200079
1062         <rdar://problem/53474325>
1063
1064         Reviewed by Wenson Hsieh.
1065
1066         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1067
1068         * WebKitTestRunner/ios/TestControllerIOS.mm:
1069         (WTR::TestController::platformResetPreferencesToConsistentValues):
1070
1071 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1072
1073         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1074         https://bugs.webkit.org/show_bug.cgi?id=199927
1075
1076         Reviewed by Alex Christensen.
1077
1078         convertAbsolutepathToWebKitPath was failing to convert paths on
1079         Windows Perl due to path separators mismatch.
1080
1081         Renamed convertAbsolutepathToWebKitPath to
1082         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1083         paths to relative Unix paths.
1084
1085         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1086         (convertAbsolutePathToRelativeUnixPath): Added.
1087         (convertAbsolutepathToWebKitPath): Deleted.
1088
1089 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1090
1091         Fix iOS API test after r247759
1092         https://bugs.webkit.org/show_bug.cgi?id=200045
1093
1094         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1095         (TEST):
1096         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1097         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1098
1099 2019-07-23  Keith Rollin  <krollin@apple.com>
1100
1101         Remove rest of NavigatorContentUtils support
1102         https://bugs.webkit.org/show_bug.cgi?id=200052
1103         <rdar://problem/53467357>
1104
1105         Reviewed by Alex Christensen.
1106
1107         Bug 196070 removes most of the support for the never-used
1108         NavigatorContentUtils facility. However, there were still a couple of
1109         left-over references after that change. This patch sweeps those up.
1110
1111         * Scripts/webkitperl/FeatureList.pm:
1112
1113 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1114
1115         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1116         https://bugs.webkit.org/show_bug.cgi?id=200045
1117
1118         Reviewed by Mark Lam.
1119
1120         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1121         (TEST):
1122
1123 2019-07-23  Russell Epstein  <repstein@apple.com>
1124
1125         Unreviewed, rolling out r247745.
1126
1127         This broke API test
1128         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
1129         indicated by EWS
1130
1131         Reverted changeset:
1132
1133         "Move javaScriptConfigurationDirectory SPI from
1134         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
1135         runtime switchable"
1136         https://bugs.webkit.org/show_bug.cgi?id=200045
1137         https://trac.webkit.org/changeset/247745
1138
1139 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1140
1141         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1142         https://bugs.webkit.org/show_bug.cgi?id=200045
1143
1144         Reviewed by Mark Lam.
1145
1146         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1147         (TEST):
1148
1149 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1150
1151         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
1152         https://bugs.webkit.org/show_bug.cgi?id=199972
1153
1154         Reviewed by Jer Noble.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1157         (TEST):
1158
1159 2019-07-23  Alicia Boya García  <aboya@igalia.com>
1160
1161         [WTF] Add DataMutex and MainThreadData wrappers
1162         https://bugs.webkit.org/show_bug.cgi?id=199831
1163
1164         Reviewed by Alex Christensen.
1165
1166         Added a very simple test that checks that DataMutex<T> indeed takes
1167         the lock and indeed holds data.
1168
1169         * TestWebKitAPI/CMakeLists.txt:
1170         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
1171         (TestWebKitAPI::TEST):
1172
1173 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1174
1175         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
1176         https://bugs.webkit.org/show_bug.cgi?id=200021
1177         <rdar://problem/53301325>
1178
1179         Reviewed by Ryosuke Niwa.
1180
1181         Add support for grabbing the child menu items of a context menu item.
1182
1183         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1184         (WTR::getMenuItemChildrenCallback):
1185
1186 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1187
1188         WebKit should strip away system font names from the pasted content
1189         https://bugs.webkit.org/show_bug.cgi?id=199975
1190         <rdar://problem/53336353>
1191
1192         Reviewed by Darin Adler.
1193
1194         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
1195
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1198         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
1199
1200 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1201
1202         [ews-build] EWS fails to parse multi-line full_results.json
1203         https://bugs.webkit.org/show_bug.cgi?id=199992
1204
1205         Reviewed by Alexey Proskuryakov.
1206
1207         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1208         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1209         * BuildSlaveSupport/ews-build/steps_unittest.py:
1210         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1211
1212 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1213
1214         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1215         https://bugs.webkit.org/show_bug.cgi?id=200015
1216
1217         Reviewed by Aakash Jain.
1218
1219         * resultsdbpy/resultsdbpy/model/repository.py:
1220         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1221
1222 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1223
1224         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1225         https://bugs.webkit.org/show_bug.cgi?id=200013
1226         <rdar://problem/52526901>
1227
1228         Reviewed by Simon Fraser.
1229
1230         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1231
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1233         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1234         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1235         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1236         * TestWebKitAPI/ios/UIKitSPI.h:
1237
1238 2019-07-22  Jer Noble  <jer.noble@apple.com>
1239
1240         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1241         https://bugs.webkit.org/show_bug.cgi?id=199971
1242         <rdar://problem/51951218>
1243
1244         Reviewed by Alex Christensen.
1245
1246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1248         (TestWebKitAPI::TEST):
1249
1250 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1251
1252         [ews-build] Add an EWS to run services tests
1253         https://bugs.webkit.org/show_bug.cgi?id=199994
1254
1255         Reviewed by Jonathan Bedard.
1256
1257         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1258         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1259         * BuildSlaveSupport/ews-build/steps.py:
1260         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1261         (RunEWSUnitTests): Build step to run EWS unit-tests.
1262         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1263         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1264         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1265
1266 2019-07-22  Youenn Fablet  <youenn@apple.com>
1267
1268         Disable MediaRecorder for legacy WebKit
1269         https://bugs.webkit.org/show_bug.cgi?id=200001
1270         <rdar://problem/53400030>
1271
1272         Reviewed by Eric Carlson.
1273
1274         Enable MediaRecorder for testing purposes.
1275
1276         * DumpRenderTree/mac/DumpRenderTree.mm:
1277         (createWebViewAndOffscreenWindow):
1278
1279 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1280
1281         results.webkit.org: Timeline header is too small
1282         https://bugs.webkit.org/show_bug.cgi?id=199955
1283
1284         Reviewed by Aakash Jain.
1285
1286         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1287         (.timeline>.header): Make timeline header larder to fit configuration names.
1288
1289 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1290
1291         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1292         https://bugs.webkit.org/show_bug.cgi?id=199954
1293
1294         Reviewed by Geoff Garen.
1295
1296         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1297         (TEST):
1298
1299 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1300
1301         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1302         https://bugs.webkit.org/show_bug.cgi?id=199917
1303
1304         Reviewed by Sam Weinig.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1307         (TEST):
1308
1309 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1312         https://bugs.webkit.org/show_bug.cgi?id=199980
1313
1314         Reviewed by Jonathan Bedard.
1315
1316         * BuildSlaveSupport/ews-build/steps.py:
1317         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1318         * BuildSlaveSupport/ews-build/steps_unittest.py:
1319         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1320         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1321
1322 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1323
1324         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1325         https://bugs.webkit.org/show_bug.cgi?id=199945
1326
1327         Reviewed by Michael Catanzaro.
1328
1329         This adds an unit test for the change implemented in r247663.
1330
1331         * Scripts/webkitpy/port/driver_unittest.py:
1332         (DriverTest.test_setup_environ_base_vars):
1333         (DriverTest):
1334         (DriverTest.test_setup_environ_without_starting_driver):
1335
1336 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1337
1338         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1339         https://bugs.webkit.org/show_bug.cgi?id=199993
1340         <rdar://problem/49523528>
1341
1342         Reviewed by Beth Dakin.
1343
1344         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1347         (TestWebKitAPI::TEST):
1348         * TestWebKitAPI/cocoa/TestWKWebView.h:
1349
1350 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1351
1352         Add accessibilityInsertText for text insertion in edit fields.
1353         https://bugs.webkit.org/show_bug.cgi?id=199973
1354
1355         Reviewed by Chris Fleizach.
1356
1357         Renamed accessibilityInsertText to _accessibilityInsertText.
1358
1359         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1360         (AccessibilityUIElement::insertText):
1361         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1362         (AccessibilityUIElement::insertText):
1363         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1364         (WTR::AccessibilityUIElement::insertText):
1365         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1366         (WTR::AccessibilityUIElement::insertText):
1367
1368 2019-07-20  Chris Dumez  <cdumez@apple.com>
1369
1370         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1371         https://bugs.webkit.org/show_bug.cgi?id=199982
1372
1373         Reviewed by Saam Barati.
1374
1375         Add API test coverage.
1376
1377         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1378         (TestWebKitAPI::TEST):
1379
1380 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
1381
1382         Add accessibilityInsertText for text insertion in edit fields.
1383         https://bugs.webkit.org/show_bug.cgi?id=199973
1384
1385         Reviewed by Chris Fleizach.
1386
1387         Glue code to run new LayoutTests.
1388         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1389         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1390         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1391         (WTR::AccessibilityUIElement::insertText):
1392         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1393         (WTR::AccessibilityUIElement::insertText):
1394         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1395         (WTR::AccessibilityUIElement::insertText):
1396         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1397         (WTR::AccessibilityUIElement::insertText):
1398
1399 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1400
1401         Move webkit.css to opensource to support resultsdbpy's frontend
1402         https://bugs.webkit.org/show_bug.cgi?id=199957
1403
1404         Reviewed by Jonathan Bedard.
1405
1406         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
1407         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
1408         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
1409         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
1410
1411 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1412
1413         Move Ref.js to WebKit to support resultsdbpy's frontend
1414         https://bugs.webkit.org/show_bug.cgi?id=199956
1415
1416         Reviewed by Jonathan Bedard.
1417
1418         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1419         * resultsdbpy/resultsdbpy/view/static/js/search.js:
1420         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1421         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
1422         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
1423         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
1424         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
1425         * resultsdbpy/resultsdbpy/view/templates/base.html:
1426         * resultsdbpy/resultsdbpy/view/templates/commits.html:
1427         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1428         * resultsdbpy/resultsdbpy/view/templates/search.html:
1429         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1430         * resultsdbpy/resultsdbpy/view/view_routes.py:
1431
1432 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1433
1434         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
1435         https://bugs.webkit.org/show_bug.cgi?id=199945
1436
1437         Reviewed by Michael Catanzaro.
1438
1439         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
1440         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
1441         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
1442
1443         * Scripts/webkitpy/port/driver.py:
1444         (Driver._setup_environ_for_driver):
1445         (Driver._create_temporal_directories):
1446         (Driver):
1447         (Driver._start):
1448         (Driver._delete_temporal_directories):
1449         (Driver.stop):
1450         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
1451         (main):
1452         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
1453         (WebDriverTestRunner.__init__):
1454         * glib/api_test_runner.py:
1455         (TestRunner._setup_testing_environment): Ditto.
1456
1457 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
1458
1459         [ews-build] Display pre-existing Layout test failure names in the build summary
1460         https://bugs.webkit.org/show_bug.cgi?id=199941
1461
1462         Reviewed by Jonathan Bedard.
1463
1464         * BuildSlaveSupport/ews-build/steps.py:
1465         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1466
1467 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1468
1469         [GTK][WPE] run-webkit-tests should run with a temporal homedir
1470         https://bugs.webkit.org/show_bug.cgi?id=199738
1471
1472         Reviewed by Michael Catanzaro.
1473
1474         Run the tests with an empty homedir that is created inside the driver tmpdir.
1475         The driver tmpdir is a random directory created for each test runner that is purged after the run.
1476
1477         This is done to ensure that the test results are not affected by the user settings of any library.
1478
1479         * Scripts/webkitpy/port/driver.py:
1480         (Driver._setup_environ_for_driver):
1481         * Scripts/webkitpy/port/driver_unittest.py:
1482         (DriverTest.test_setup_environ_base_vars):
1483         (DriverTest):
1484         (DriverTest.test_create_temporal_home_dir):
1485
1486 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         Remove pywebsockets from thirdparty
1489         https://bugs.webkit.org/show_bug.cgi?id=199710
1490
1491         Reviewed by Jonathan Bedard.
1492
1493         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
1494         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
1495
1496         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1497         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
1498         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
1499         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
1500         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
1501         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
1502         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
1503         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
1504         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
1505         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
1506         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
1507         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
1508         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
1509         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
1510         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
1511         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
1512         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
1513         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
1514         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
1515         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
1516         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
1517         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
1518
1519 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
1520
1521         results.webkit.org: Move resultsdbpy to WebKit
1522         https://bugs.webkit.org/show_bug.cgi?id=199837
1523         <rdar://problem/53172130>
1524
1525         Rubber-stamped by Aakash Jain.
1526
1527         Moving the entirety of the resultsdbpy library, which provides utilities to build
1528         a database designed to store, visualize and organize test results, into WebKit.
1529
1530         * Scripts/webkitpy/style/checker.py:
1531         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
1532         * resultsdbpy: Added.
1533         * resultsdbpy/MANIFEST.in: Added.
1534         * resultsdbpy/README.md: Added.
1535         * resultsdbpy/resultsdbpy: Added.
1536         * resultsdbpy/resultsdbpy/__init__.py: Added.
1537         * resultsdbpy/resultsdbpy/controller: Added.
1538         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
1539         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
1540         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
1541         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
1542         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
1543         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
1544         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
1545         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
1546         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
1547         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
1548         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
1549         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
1550         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
1551         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
1552         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
1553         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
1554         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
1555         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
1556         * resultsdbpy/resultsdbpy/flask_support: Added.
1557         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
1558         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
1559         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
1560         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
1561         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
1562         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
1563         * resultsdbpy/resultsdbpy/model: Added.
1564         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
1565         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
1566         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
1567         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
1568         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
1569         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
1570         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
1571         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
1572         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
1573         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
1574         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
1575         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
1576         * resultsdbpy/resultsdbpy/model/docker.py: Added.
1577         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
1578         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
1579         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
1580         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
1581         * resultsdbpy/resultsdbpy/model/model.py: Added.
1582         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
1583         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
1584         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
1585         * resultsdbpy/resultsdbpy/model/repository.py: Added.
1586         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
1587         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
1588         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
1589         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
1590         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
1591         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
1592         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
1593         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
1594         * resultsdbpy/resultsdbpy/run-tests: Added.
1595         * resultsdbpy/resultsdbpy/view: Added.
1596         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
1597         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
1598         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
1599         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
1600         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
1601         * resultsdbpy/resultsdbpy/view/static: Added.
1602         * resultsdbpy/resultsdbpy/view/static/css: Added.
1603         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
1604         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
1605         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
1606         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
1607         * resultsdbpy/resultsdbpy/view/static/js: Added.
1608         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
1609         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
1610         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
1611         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
1612         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
1613         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
1614         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
1615         * resultsdbpy/resultsdbpy/view/templates: Added.
1616         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
1617         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
1618         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
1619         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
1620         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
1621         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
1622         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
1623         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
1624         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
1625         * resultsdbpy/setup.py: Added.
1626
1627 2019-07-18  Alex Christensen  <achristensen@webkit.org>
1628
1629         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
1630         https://bugs.webkit.org/show_bug.cgi?id=199923
1631
1632         Reviewed by Youenn Fablet.
1633
1634         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1635         (TestWebKitAPI::TEST):
1636
1637 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
1638
1639         [ews-build] Enable iOS WK2 tester queue on new EWS
1640         https://bugs.webkit.org/show_bug.cgi?id=199867
1641
1642         Reviewed by Jonathan Bedard.
1643
1644         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
1645         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
1647         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
1648
1649 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
1650
1651         [ews-build] Add build step to AnalyzeLayoutTestsResults
1652         https://bugs.webkit.org/show_bug.cgi?id=199877
1653
1654         Reviewed by Jonathan Bedard.
1655
1656         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
1657
1658         * BuildSlaveSupport/ews-build/steps.py:
1659         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
1660         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
1661         (AnalyzeLayoutTestsResults.report_failure):
1662         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1663         (AnalyzeLayoutTestsResults.retry_build):
1664         (AnalyzeLayoutTestsResults._results_failed_different_tests):
1665         (AnalyzeLayoutTestsResults._report_flaky_tests):
1666         (AnalyzeLayoutTestsResults.start):
1667         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1668
1669 2019-07-18  Alex Christensen  <achristensen@webkit.org>
1670
1671         Move NetworkCache ownership from NetworkProcess to NetworkSession
1672         https://bugs.webkit.org/show_bug.cgi?id=199817
1673
1674         Reviewed by Geoff Garen.
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1677         (TEST):
1678         * TestWebKitAPI/cocoa/TestWKWebView.h:
1679         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1680         (-[WKWebView synchronouslyLoadRequest:]):
1681
1682 2019-07-18  Youenn Fablet  <youenn@apple.com>
1683
1684         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
1685         https://bugs.webkit.org/show_bug.cgi?id=199769
1686         <rdar://problem/49390297>
1687
1688         Reviewed by Myles C. Maxfield.
1689
1690         Add a font containing one extended character not found in system fonts.
1691
1692         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1693         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
1694
1695 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
1696
1697         Unreviewed, Add Olivier Blin as contributor
1698
1699         * Scripts/webkitpy/common/config/contributors.json:
1700
1701 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1702
1703         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
1704         https://bugs.webkit.org/show_bug.cgi?id=199855
1705
1706         Reviewed by Michael Catanzaro.
1707
1708         The webkitpy drivers for GTK and WPE use their own versions for setting
1709         up the environment and starting/stopping the drivers.
1710         This refactors those drivers to use the base class driver functions.
1711         As a benefit we get some fixes like support for setting the profiler
1712         environment variables, and a simpler code.
1713
1714         * Scripts/webkitpy/port/driver.py:
1715         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1716         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1717         * Scripts/webkitpy/port/headlessdriver.py:
1718         (HeadlessDriver._setup_environ_for_test):
1719         * Scripts/webkitpy/port/waylanddriver.py:
1720         (WaylandDriver._setup_environ_for_test):
1721         * Scripts/webkitpy/port/westondriver.py:
1722         (WestonDriver._setup_environ_for_test):
1723         (WestonDriver.stop):
1724         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1725         (WestonDriverTest.make_driver):
1726         * Scripts/webkitpy/port/xorgdriver.py:
1727         (XorgDriver._setup_environ_for_test):
1728         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1729         (XvfbDriver._setup_environ_for_test):
1730         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1731         (XvfbDriverTest.make_driver):
1732         (XvfbDriverTest.test_start):
1733         (XvfbDriverTest.test_start_arbitrary_worker_number):
1734         * Scripts/webkitpy/w3c/wpt_runner.py:
1735         (main): Start the driver before trying to get its environment to define all the environment variables.
1736         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1737         (WebDriverTestRunner.__init__): Ditto.
1738         * glib/api_test_runner.py:
1739         (TestRunner._setup_testing_environment): Ditto.
1740
1741 2019-07-17  Antoine Quint  <graouts@apple.com>
1742
1743         Disable Pointer Events prior to watchOS 6
1744         https://bugs.webkit.org/show_bug.cgi?id=199890
1745         <rdar://problem/53206113>
1746
1747         Reviewed by Dean Jackson.
1748
1749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1750
1751 2019-07-17  Christopher Reid  <chris.reid@sony.com>
1752
1753         Bytecode cache should use FileSystem
1754         https://bugs.webkit.org/show_bug.cgi?id=199759
1755
1756         Reviewed by Yusuke Suzuki.
1757
1758         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1759
1760 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
1761
1762         check-webkit-style: Add limited Python3 support
1763         https://bugs.webkit.org/show_bug.cgi?id=199870
1764
1765         Rubber-stamped by Aakash Jain.
1766
1767         Since new services will be added in the near future which are Python 3, we
1768         need to support Python 3 style checks. For now, assume all Python files are
1769         Python 2 unless otherwise specified.
1770
1771         * Scripts/webkitpy/style/checker.py:
1772         (_all_categories): Add pycodestyle to valid categories for testing.
1773         (CheckerDispatcher._create_checker): Check that the provided Python file is in
1774         one of the declared Python 3 directories.
1775         * Scripts/webkitpy/style/checkers/python.py:
1776         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
1777         instead of pep8.
1778         (Python3Checker.__init__):
1779         (Python3Checker.check):
1780         * Scripts/webkitpy/thirdparty/__init__.py:
1781         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
1782         (AutoinstallImportHook._install_pycodestyle):
1783
1784 2019-07-17  Sam Weinig  <weinig@apple.com>
1785
1786         Add StringBuilder member function which allows makeString() style variadic argument construction
1787         https://bugs.webkit.org/show_bug.cgi?id=198997
1788
1789         Reviewed by Darin Adler.
1790
1791         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1792         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1793         append one or more string adaptable types. 
1794
1795         * TestWebKitAPI/CMakeLists.txt:
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         Add WTFStringUtilities.cpp
1798
1799         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1800         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1801         append one or more string adaptable types. 
1802
1803         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1804         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
1805         * TestWebKitAPI/WTFStringUtilities.h:
1806         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
1807         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
1808
1809 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
1810
1811         Remove the file superfluously added in r247535.
1812
1813         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
1814         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
1815
1816 2019-07-17  Alex Christensen  <achristensen@webkit.org>
1817
1818         Add a runtime-disabled dialog element skeleton
1819         https://bugs.webkit.org/show_bug.cgi?id=199839
1820
1821         Reviewed by Ryosuke Niwa.
1822
1823         * DumpRenderTree/mac/DumpRenderTree.mm:
1824         (resetWebPreferencesToConsistentValues):
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::resetPreferencesToConsistentValues):
1827         Enable the dialog element for layout tests.
1828
1829 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
1830
1831         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
1832         https://bugs.webkit.org/show_bug.cgi?id=199851
1833
1834         Reviewed by Wenson Hsieh.
1835
1836         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
1837         this code is getting directly triggered from UIKeyboard's code.
1838
1839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1840         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
1841         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
1842         * TestWebKitAPI/ios/UIKitSPI.h:
1843
1844 2019-07-17  Commit Queue  <commit-queue@webkit.org>
1845
1846         Unreviewed, rolling out r247505.
1847         https://bugs.webkit.org/show_bug.cgi?id=199871
1848
1849         "Caused failed ASSERT in stress test" (Requested by creid on
1850         #webkit).
1851
1852         Reverted changeset:
1853
1854         "Bytecode cache should use FileSystem"
1855         https://bugs.webkit.org/show_bug.cgi?id=199759
1856         https://trac.webkit.org/changeset/247505
1857
1858 2019-07-17  Russell Epstein  <russell_e@apple.com>
1859
1860         Adding self to contributors.json
1861
1862         Unreviewed.
1863
1864         * Scripts/webkitpy/common/config/contributors.json:
1865
1866 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
1867
1868         [ews-build] Parse full_results.json for layout-tests
1869         https://bugs.webkit.org/show_bug.cgi?id=199804
1870
1871         Reviewed by Jonathan Bedard.
1872
1873         * BuildSlaveSupport/ews-build/steps.py:
1874         (RunWebKitTests.start): Monitor json output.
1875         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
1876         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
1877         by the patch or are pre-existing.
1878         (ReRunWebKitTests.commandComplete): Ditto.
1879         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
1880         * BuildSlaveSupport/ews-build/steps_unittest.py:
1881         (BuildStepMixinAdditions.getProperty): Added.
1882         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
1883         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
1884
1885 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1886
1887         Unreviewed, rolling out r247512.
1888
1889         Broke API test runners
1890
1891         Reverted changeset:
1892
1893         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
1894         for setting up the environment and start the drivers."
1895         https://bugs.webkit.org/show_bug.cgi?id=199855
1896         https://trac.webkit.org/changeset/247512
1897
1898 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1899
1900         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
1901         https://bugs.webkit.org/show_bug.cgi?id=199855
1902
1903         Reviewed by Carlos Garcia Campos.
1904
1905         The webkitpy drivers for GTK and WPE use their own versions for setting
1906         up the environment and starting/stopping the drivers.
1907         This refactors those drivers to use the base class driver functions.
1908         As a benefit we get some fixes like support for setting the profiler
1909         environment variables, and a simpler code.
1910
1911         * Scripts/webkitpy/port/driver.py:
1912         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1913         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1914         * Scripts/webkitpy/port/headlessdriver.py:
1915         (HeadlessDriver._setup_environ_for_test):
1916         * Scripts/webkitpy/port/waylanddriver.py:
1917         (WaylandDriver._setup_environ_for_test):
1918         * Scripts/webkitpy/port/westondriver.py:
1919         (WestonDriver._setup_environ_for_test):
1920         (WestonDriver.stop):
1921         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1922         (WestonDriverTest.make_driver):
1923         * Scripts/webkitpy/port/xorgdriver.py:
1924         (XorgDriver._setup_environ_for_test):
1925         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1926         (XvfbDriver._setup_environ_for_test):
1927         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1928         (XvfbDriverTest.make_driver):
1929         (XvfbDriverTest.test_start):
1930         (XvfbDriverTest.test_start_arbitrary_worker_number):
1931
1932 2019-07-16  Christopher Reid  <chris.reid@sony.com>
1933
1934         Bytecode cache should use FileSystem
1935         https://bugs.webkit.org/show_bug.cgi?id=199759
1936
1937         Reviewed by Yusuke Suzuki.
1938
1939         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1940
1941 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
1942
1943         svn-create-patch duplicates diffs when adding directories
1944         https://bugs.webkit.org/show_bug.cgi?id=199842
1945
1946         Reviewed by Dewei Zhu.
1947
1948         * Scripts/svn-create-patch:
1949         (findKind): Add function which returns what 'kind' of file the provided path is.
1950         (generateFileList): If the path is a directory and being added, don't add it.
1951         Instead, rely on the fact that its children will be added.
1952
1953 2019-07-16  Tim Horton  <timothy_horton@apple.com>
1954
1955         NSTextFinder holes don't scroll with the page
1956         https://bugs.webkit.org/show_bug.cgi?id=199815
1957         <rdar://problem/52280514>
1958
1959         Reviewed by Simon Fraser.
1960
1961         * MiniBrowser/mac/WK2BrowserWindowController.m:
1962         (-[MiniBrowserNSTextFinder performAction:]):
1963         (-[WK2BrowserWindowController awakeFromNib]):
1964         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
1965         -performAction: so that we can intercept the close action and
1966         hide our own find UI, since there is no delegate for that action yet.
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1969         (TEST):
1970
1971 2019-07-15  Keith Miller  <keith_miller@apple.com>
1972
1973         JSGlobalObject type macros should support feature flags and WeakRef should have one
1974         https://bugs.webkit.org/show_bug.cgi?id=199601
1975
1976         Reviewed by Mark Lam.
1977
1978         JSC options need to be set before the window is created for the test.
1979
1980         * DumpRenderTree/mac/DumpRenderTree.mm:
1981         (resetWebViewToConsistentStateBeforeTesting):
1982         * DumpRenderTree/win/DumpRenderTree.cpp:
1983         (setJSCOptions):
1984         (resetWebViewToConsistentStateBeforeTesting):
1985
1986 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1987
1988         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
1989         https://bugs.webkit.org/show_bug.cgi?id=193108
1990
1991         Reviewed by Simon Fraser.
1992
1993         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
1994         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
1995         at the wrong scale.
1996
1997         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1998         (takeWindowSnapshot):
1999         (createBitmapContextFromWebView):
2000
2001 2019-07-15  Brady Eidson  <beidson@apple.com>
2002
2003         Make WKURLSchemeTask thread safe.
2004         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2005
2006         Reviewed by Alex Christensen.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2009
2010 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2011
2012         Unreviewed, a build fix after r247437
2013
2014         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2015         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2016
2017 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2018
2019         [macOS 10.15] Cannot unbold selected text when the system font is used
2020         https://bugs.webkit.org/show_bug.cgi?id=199788
2021         <rdar://problem/52142570>
2022
2023         Reviewed by Tim Horton.
2024
2025         Add a new API test to verify that bolding and unbolding updates the
2026         shared font manager's selected font.
2027
2028         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2029         (TestWebKitAPI::TEST):
2030
2031 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2032
2033         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2034         https://bugs.webkit.org/show_bug.cgi?id=199790
2035         <rdar://problem/52790112>
2036
2037         Reviewed by Brent Fulgham.
2038
2039         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2040
2041         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2042         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2043         (configureSOAuthorizationWebView):
2044         (TestWebKitAPI::TEST):
2045         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2046         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2047         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2048         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2049         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2050
2051 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2052
2053         window.openDatabase is not writable
2054         https://bugs.webkit.org/show_bug.cgi?id=199737
2055         <rdar://problem/52551332>
2056
2057         Reviewed by Chris Dumez.
2058
2059         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2060         (TEST):
2061         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2062
2063 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-build] Parse and display layout test failures
2066         https://bugs.webkit.org/show_bug.cgi?id=199709
2067
2068         Rubber-stamped by Jonathan Bedard.
2069
2070         * BuildSlaveSupport/ews-build/steps.py:
2071         (RunWebKitTests.start): Initialize log_observer.
2072         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2073         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2074         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2075         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2076         (RunWebKitTests.getResultSummary): Update build and step summary.
2077         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2078
2079 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2080
2081         Unreviewed, rolling out r247393.
2082         https://bugs.webkit.org/show_bug.cgi?id=199797
2083
2084         broke mips and arm EWS (Requested by guijemont on #webkit).
2085
2086         Reverted changeset:
2087
2088         "run-javascriptcore-tests won't report test results for
2089         testmasm, testair, testb3, testdfg and test api"
2090         https://bugs.webkit.org/show_bug.cgi?id=199489
2091         https://trac.webkit.org/changeset/247393
2092
2093 2019-07-12  Andy Estes  <aestes@apple.com>
2094
2095         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2096         https://bugs.webkit.org/show_bug.cgi?id=199768
2097         <rdar://problem/52002206>
2098
2099         Reviewed by Geoffrey Garen.
2100
2101         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2102         (TEST):
2103
2104 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-build] Remove wincairo queue from old EWS and dashboard
2107         https://bugs.webkit.org/show_bug.cgi?id=199776
2108
2109         Reviewed by Don Olmstead.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2112         * QueueStatusServer/config/queues.py:
2113
2114 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2115
2116         [ews-build] Enable wincairo queue on new EWS
2117         https://bugs.webkit.org/show_bug.cgi?id=199593
2118
2119         Reviewed by Don Olmstead.
2120
2121         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
2122         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
2123         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2124         (StatusBubble): Enable wincairo status-bubble.
2125
2126 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2127
2128         [ews-app] Enable logging for clicking SubmitToEWS button
2129         https://bugs.webkit.org/show_bug.cgi?id=199757
2130
2131         Unreviewed minor infrastructure fix.
2132
2133         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2134         (SubmitToEWS.post): Change logging level from debug to info.
2135
2136 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2137
2138         Enable client certificate authentication unit test
2139         https://bugs.webkit.org/show_bug.cgi?id=199735
2140
2141         Reviewed by Chris Dumez.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2144         (TEST):
2145         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
2146         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
2147
2148 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2149
2150         Begin unifying TestWebKitAPI build
2151         https://bugs.webkit.org/show_bug.cgi?id=199728
2152
2153         Reviewed by Keith Miller.
2154
2155         * TestWebKitAPI/Configurations/Base.xcconfig:
2156         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
2157         * TestWebKitAPI/Sources.txt: Added.
2158         * TestWebKitAPI/SourcesCocoa.txt: Added.
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160
2161 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
2162
2163         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2164         https://bugs.webkit.org/show_bug.cgi?id=199489
2165         <rdar://problem/47891081>
2166
2167         Reviewed by Aakash Jain.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2170         (RunJavaScriptCoreTests.countFailures):
2171         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2172         * Scripts/run-javascriptcore-tests:
2173         (runTest):
2174         (reportTestFailures):
2175         (runJSCStressTests):
2176
2177 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
2180         https://bugs.webkit.org/show_bug.cgi?id=199743
2181
2182         Reviewed by Jonathan Bedard.
2183
2184         * BuildSlaveSupport/ews-build/steps.py:
2185         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2186
2187 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2188
2189         Unreviewed follow-up fix to r247364.
2190         [ews-build] Add build step to clean up .git/index.lock file
2191         https://bugs.webkit.org/show_bug.cgi?id=199722
2192
2193         * BuildSlaveSupport/ews-build/steps.py:
2194         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
2195         to be run after this step.
2196
2197 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
2198
2199         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
2200         https://bugs.webkit.org/show_bug.cgi?id=199524
2201         <rdar://problem/52783816>
2202
2203         Reviewed by Saam Barati.
2204
2205         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
2206         But this test has several problems.
2207
2208         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2209            number is calculated by pageSize / sizeof(T), and this does not account the header
2210            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2211            is very small, we can have many objects in one IsoPage. As a result, we need a large
2212            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2213            less than numObjects.
2214
2215         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2216            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2217            page. This also makes the intention of this test wrong.
2218
2219         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2220
2221         We make this test robust while we still keep this test white-box one to test the critical feature
2222         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2223         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2224         tier live, and check whether the deallocated memory is reused.
2225
2226         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2227         (TEST):
2228
2229 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2230
2231         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2232         https://bugs.webkit.org/show_bug.cgi?id=199625
2233
2234         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2235         with ENABLE(ACCESSIBILITY) in the code.
2236
2237         Additionally, the TestRunner code generator now honors the
2238         Conditional IDL format.
2239
2240         Reviewed by Konstantin Tokarev.
2241
2242         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2243         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2244         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2245         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2246         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2247         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2248         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2249         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2250         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2251         (_generateImplementationFile):
2252
2253 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2254
2255         [ews-build] Add build step to clean up .git/index.lock file
2256         https://bugs.webkit.org/show_bug.cgi?id=199722
2257
2258         Reviewed by Jonathan Bedard.
2259
2260         * BuildSlaveSupport/ews-build/steps.py:
2261         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2262         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2263         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2264         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2265
2266 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2267
2268         [iOS 13] Enable WebKit build
2269         https://bugs.webkit.org/show_bug.cgi?id=199481
2270         <rdar://problem/52619048>
2271
2272         Reviewed by Tim Horton.
2273
2274         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2275
2276 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2277
2278         Add test expectations and baselines for iOS 13
2279         https://bugs.webkit.org/show_bug.cgi?id=199329
2280
2281         Reviewed by Jonathan Bedard.
2282
2283         * Scripts/webkitpy/port/ios.py:
2284         (IOSPort): Increment current version to 13.
2285         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2286         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2287         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2288         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2289         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2290         (IOSSimulatorTest.make_port):
2291         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2292         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2293         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2294         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2295         (IOSTest.make_port):
2296
2297 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2298
2299         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2300         https://bugs.webkit.org/show_bug.cgi?id=199692
2301
2302         Reviewed by Chris Fleizach.
2303
2304         Add support for output of AXDeletion and AXInsertion roles for tests.
2305         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2306         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2307
2308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2309         * gtk/jhbuild.modules:
2310         * wpe/jhbuild.modules:
2311
2312 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2313
2314         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2315         https://bugs.webkit.org/show_bug.cgi?id=199707
2316
2317         Reviewed by Aakash Jain.
2318
2319         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2320
2321 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2322
2323         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2324         https://bugs.webkit.org/show_bug.cgi?id=199693
2325         rdar://problem/51930364
2326
2327         Reviewed by Tim Horton.
2328         
2329         New API tests that test scrollability with various combinations of content, insets,
2330         input accessory bars etc.
2331
2332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2333         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2334         (TestWebKitAPI::webViewWithAutofocusedInput):
2335         (TestWebKitAPI::TEST):
2336
2337 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2338
2339         Long pressing on attachments will crash the WebContent process
2340         https://bugs.webkit.org/show_bug.cgi?id=199696
2341         <rdar://problem/52920241>
2342
2343         Reviewed by Dean Jackson.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2346         (TestWebKitAPI::TEST):
2347         Add a test that previously crashed.
2348
2349 2019-07-10  Dean Jackson  <dino@apple.com>
2350
2351         Support MacCatalyst in run-webkit-app
2352         https://bugs.webkit.org/show_bug.cgi?id=199690
2353
2354         Reviewed by Tim Horton.
2355
2356         Add a --maccatalyst option to run-webkit-app that
2357         can launch MacCatalyst applications with a built WebKit.
2358
2359         * Scripts/webkitdirs.pm:
2360         (argumentsForConfiguration):
2361         (determineXcodeSDK):
2362         (xcodeSDKPlatformName):
2363         (determineConfigurationProductDir):
2364         (determinePortName):
2365         (isCatalystWebKit):
2366         (isAppleCocoaWebKit):
2367         (willUseCatalystSDK):
2368
2369 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2370
2371         [MacOS] Filter VPA info logged to stdout
2372         https://bugs.webkit.org/show_bug.cgi?id=199673
2373
2374         Reviewed by Eric Carlson.
2375
2376         * Scripts/webkitpy/port/mac.py:
2377         (MacPort.logging_patterns_to_strip):
2378
2379 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2380
2381         Unreviewed, rolling out r247286.
2382
2383         Caused TestWTF.WTF.StringOperators to fail on debug bots
2384
2385         Reverted changeset:
2386
2387         "Add StringBuilder member function which allows makeString()
2388         style variadic argument construction"
2389         https://bugs.webkit.org/show_bug.cgi?id=198997
2390         https://trac.webkit.org/changeset/247286
2391
2392 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-build] Explicitly use perl or python while invoking scripts
2395         https://bugs.webkit.org/show_bug.cgi?id=199669
2396
2397         Reviewed by Jonathan Bedard.
2398
2399         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
2400         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2401
2402 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
2403
2404         Run tests on mips EWS
2405         https://bugs.webkit.org/show_bug.cgi?id=196854
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         * Scripts/webkitpy/common/config/ews.json:
2410
2411 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2412
2413         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
2414         https://bugs.webkit.org/show_bug.cgi?id=199579
2415
2416         Reviewed by Carlos Garcia Campos.
2417
2418         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
2419         (TestWebKitAPI::TEST):
2420
2421 2019-07-09  Chris Dumez  <cdumez@apple.com>
2422
2423         Fix integer type encoding / decoding in WKRemoteObjectCoder
2424         https://bugs.webkit.org/show_bug.cgi?id=199643
2425         <rdar://problem/52732342>
2426
2427         Reviewed by Anders Carlsson.
2428
2429         Update API test coverage.
2430
2431         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2432         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2433         (TEST):
2434         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2435         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
2436         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
2437         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
2438         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
2439
2440 2019-07-09  Sam Weinig  <weinig@apple.com>
2441
2442         Add StringBuilder member function which allows makeString() style variadic argument construction
2443         https://bugs.webkit.org/show_bug.cgi?id=198997
2444
2445         Reviewed by Darin Adler.
2446
2447         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2448         Add basic test showing that StringBuilder::flexibleAppend can be used to 
2449         append one or more string adaptable types. 
2450
2451 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
2452
2453         Only allow fetching and removing session credentials from WebsiteDataStore
2454         https://bugs.webkit.org/show_bug.cgi?id=199385
2455         <rdar://problem/52622080>
2456
2457         Reviewed by Alex Christensen.
2458
2459         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
2460         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
2461         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2464         (TEST):
2465         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2466         (TestWebKitAPI::TEST):
2467
2468 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2469
2470         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
2471         https://bugs.webkit.org/show_bug.cgi?id=199628
2472
2473         Reviewed by Brady Eidson.
2474
2475         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2476         (TestWebKitAPI::TEST_F):
2477
2478 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2479
2480         Remove invalid assertion in URLParser::domainToASCII
2481         https://bugs.webkit.org/show_bug.cgi?id=199624
2482
2483         Reviewed by Brady Eidson.
2484
2485         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2486         (TestWebKitAPI::TEST_F):
2487
2488 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2489
2490         URLParser should reserialize IPv6 addresses that end with a colon
2491         https://bugs.webkit.org/show_bug.cgi?id=199627
2492
2493         Reviewed by Brady Eidson.
2494
2495         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2496         (TestWebKitAPI::TEST_F):
2497
2498 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2499
2500         [ews-build] Do not run unix commands for windows in PrintConfiguration
2501         https://bugs.webkit.org/show_bug.cgi?id=199605
2502
2503         Reviewed by Jonathan Bedard.
2504
2505         * BuildSlaveSupport/ews-build/steps.py:
2506
2507 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2508
2509         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
2510         https://bugs.webkit.org/show_bug.cgi?id=199487
2511
2512         Reviewed by Ross Kirsling.
2513
2514         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
2515         failing to open testglobalscope_constructors_file which was
2516         created by using tempfile.mkstemp() because it keeps the file
2517         open. Use tempfile.mkdtemp() to create temporary files in the
2518         temporary directory instead of tempfile.mkstemp().
2519
2520         * Scripts/webkitpy/bindings/main.py:
2521         (BindingsTests.run_tests):
2522         (BindingsTests.main):
2523         (BindingsTests.close_and_remove): Deleted.
2524
2525 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] Add KillOldProcesses step before running API or Layout tests
2528         https://bugs.webkit.org/show_bug.cgi?id=199592
2529
2530         Reviewed by Jonathan Bedard.
2531
2532         * BuildSlaveSupport/ews-build/factories.py:
2533
2534 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
2535
2536         test-webkitpy: Explicitly use Python 2.7 lldb library
2537         https://bugs.webkit.org/show_bug.cgi?id=199578
2538         <rdar://problem/51853557>
2539
2540         Reviewed by Aakash Jain.
2541
2542         * Scripts/webkitpy/common/system/systemhost.py:
2543         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
2544         * Scripts/webkitpy/test/main.py:
2545         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
2546
2547 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
2548
2549         Add test expectations and baselines for Catalina
2550         https://bugs.webkit.org/show_bug.cgi?id=199328
2551
2552         Reviewed by Jonathan Bedard.
2553
2554         * Scripts/webkitpy/port/mac.py:
2555         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
2556
2557 2019-07-08  Christopher Reid  <chris.reid@sony.com>
2558
2559         Implement MappedFileData for Windows
2560         https://bugs.webkit.org/show_bug.cgi?id=198269
2561
2562         Reviewed by Darin Adler.
2563
2564         * TestWebKitAPI/PlatformWin.cmake:
2565
2566 2019-07-08  Charlie Turner  <cturner@igalia.com>
2567
2568         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
2569         https://bugs.webkit.org/show_bug.cgi?id=197558
2570
2571         Reviewed by Xabier Rodriguez-Calvar.
2572
2573         On shutdown we can easily deadlock the web process if we don't
2574         ensure all network operations are completed before comitting state
2575         changes. In HLS, make sure the network operations are cancelled,
2576         and also prevent hlsdemux's retry logic from scuppering our
2577         efforts.
2578
2579         * gstreamer/jhbuild.modules: Include the patch.
2580         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
2581
2582 2019-07-08  Antoine Quint  <graouts@apple.com>
2583
2584         [Pointer Events] Enable only on the most recent version of the supported iOS family
2585         https://bugs.webkit.org/show_bug.cgi?id=199562
2586         <rdar://problem/52766511>
2587
2588         Reviewed by Dean Jackson.
2589
2590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2591
2592 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
2593
2594         Long hang when loading a cnn.com page on iOS
2595         https://bugs.webkit.org/show_bug.cgi?id=199556
2596
2597         Reviewed by Zalan Bujtas.
2598
2599         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
2600         to load a test page of your choice.
2601
2602         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
2603         (-[WebViewController viewDidLoad]):
2604
2605 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2606
2607         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
2608         https://bugs.webkit.org/show_bug.cgi?id=199503
2609
2610         Reviewed by Wenson Hsieh.
2611
2612         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
2613         _requestActivatedElementAtPosition
2614
2615         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2616         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2617         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2618         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2619         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2620         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2621         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2622         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2623         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2624         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2625         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
2626         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2627
2628 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
2629
2630         Unreviewed, rolling out r247115.
2631
2632         Breaks lldbWebKitTester (and by extension, test-webkitpy)
2633
2634         Reverted changeset:
2635
2636         "[WHLSL] Standard library is too big to directly include in
2637         WebCore"
2638         https://bugs.webkit.org/show_bug.cgi?id=198186
2639         https://trac.webkit.org/changeset/247115
2640
2641 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
2642
2643         Unreviewed, rolling out r247123.
2644
2645         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
2646         fail.
2647
2648         Reverted changeset:
2649
2650         "Only allow fetching and removing session credentials from
2651         WebsiteDataStore"
2652         https://bugs.webkit.org/show_bug.cgi?id=199385
2653         https://trac.webkit.org/changeset/247123
2654
2655 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2656
2657         Touching media controls sometimes shows software keyboard
2658         https://bugs.webkit.org/show_bug.cgi?id=199490
2659         <rdar://problem/52076270>
2660
2661         Reviewed by Eric Carlson.
2662
2663         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
2664         ChangeLog entries for more detail.
2665
2666         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2667         (WTR::UIScriptController::hasInputSession const):
2668         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2669         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2670         (WTR::UIScriptController::hasInputSession const):
2671         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2672         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2673         (WTR::UIScriptController::hasInputSession const):
2674
2675 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
2678         https://bugs.webkit.org/show_bug.cgi?id=199458
2679
2680         Reviewed by Michael Catanzaro.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2683         * QueueStatusServer/config/queues.py:
2684
2685 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2686
2687         [GTK] Fix browserperfdash script after r239522
2688         https://bugs.webkit.org/show_bug.cgi?id=199496
2689
2690         Reviewed by Michael Catanzaro.
2691
2692         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
2693         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
2694
2695 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2696
2697         [webkitpy] test-webkitpy is broken on Linux since r246662
2698         https://bugs.webkit.org/show_bug.cgi?id=199493
2699
2700         Reviewed by Michael Catanzaro.
2701
2702         * Scripts/webkitpy/test/main.py:
2703         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
2704
2705 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2706
2707         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
2708         https://bugs.webkit.org/show_bug.cgi?id=199406
2709
2710         Reviewed by Michael Catanzaro.
2711
2712         Install the Woff2 libraries and headers from the system package
2713         and stop building them on the JHBuild.
2714
2715         * gtk/install-dependencies:
2716         * gtk/jhbuild.modules:
2717         * wpe/install-dependencies:
2718         * wpe/jhbuild.modules:
2719
2720 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2721
2722         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
2723         https://bugs.webkit.org/show_bug.cgi?id=199449
2724
2725         Reviewed by Michael Catanzaro.
2726
2727         * Scripts/webkitdirs.pm:
2728         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
2729
2730 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2731
2732         Unreviewed, GTK a11y tests fix after r247071
2733
2734         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2735         (WTR::AccessibilityUIElement::popupValue const):
2736
2737 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
2738
2739         [ews-build] Enable WPE and GTK queues on new EWS
2740         https://bugs.webkit.org/show_bug.cgi?id=199234
2741
2742         Reviewed by Jonathan Bedard.
2743
2744         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
2745         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
2746         * BuildSlaveSupport/ews-build/steps.py:
2747         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
2748         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2749         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2750         (StatusBubble): Enable gtk and wpe status-bubbles.
2751
2752 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
2753
2754         Only allow fetching and removing session credentials from WebsiteDataStore
2755         https://bugs.webkit.org/show_bug.cgi?id=199385
2756
2757         Reviewed by Alex Christensen.
2758
2759         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2760         (TestWebKitAPI::TEST):
2761
2762 2019-07-03  Tim Horton  <timothy_horton@apple.com>
2763
2764         UI process exception when dragging an <attachment> with no content type
2765         https://bugs.webkit.org/show_bug.cgi?id=199480
2766         <rdar://problem/44351353>
2767
2768         Reviewed by Wenson Hsieh.
2769
2770         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2771         (TestWebKitAPI::TEST):
2772         Add a test; before the change, it crashes.
2773
2774 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
2775
2776         [Catalina] Enable WebKit build
2777         https://bugs.webkit.org/show_bug.cgi?id=199209
2778
2779         Reviewed by Darin Adler.
2780
2781         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
2782
2783 2019-07-03  Sam Weinig  <weinig@apple.com>
2784
2785         Adopt simple structured bindings in more places
2786         https://bugs.webkit.org/show_bug.cgi?id=199247
2787
2788         Reviewed by Alex Christensen.
2789
2790         Replaces simple uses of std::tie() with structured bindings. Does not touch
2791         uses of std::tie() that are not initial declarations, use std::ignore or in
2792         case where the binding is captured by a lambda, as structured bindings don't
2793         work for those cases yet.
2794
2795         * TestWebKitAPI/ios/PreferredContentMode.mm:
2796         (TestWebKitAPI::TEST):
2797
2798 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
2799
2800         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
2801
2802         * BuildSlaveSupport/ews-build/steps.py:
2803         (PrintConfiguration.run):
2804
2805 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-build] Add build steps to Install Wpe and Gtk dependencies
2808         https://bugs.webkit.org/show_bug.cgi?id=199408
2809
2810         Reviewed by Michael Catanzaro.
2811
2812         * BuildSlaveSupport/ews-build/steps.py:
2813         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
2814         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
2815         (InstallWpeDependencies): Ditto for WPE.
2816         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2817
2818 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2819
2820         [ews-build] Allow skipping uploading built product for few builders
2821         https://bugs.webkit.org/show_bug.cgi?id=199422
2822
2823         Reviewed by Michael Catanzaro.
2824
2825         * BuildSlaveSupport/ews-build/steps.py:
2826         (CompileWebKit.__init__): Added optional skipUpload parameter.
2827         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
2828
2829 2019-07-02  Tim Horton  <timothy_horton@apple.com>
2830
2831         REGRESSION (r243240): Unable to swipe back in Safari
2832         https://bugs.webkit.org/show_bug.cgi?id=199394
2833         <rdar://problem/51137447>
2834
2835         Reviewed by Wenson Hsieh.
2836
2837         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2838         Make sure that we actually end up with swipe gesture recognizers installed
2839         after process swap and crash.
2840
2841 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
2842
2843         Enhance support of aria-haspopup per ARIA 1.1 specification.
2844         https://bugs.webkit.org/show_bug.cgi?id=199216
2845         <rdar://problem/46221342>
2846
2847         Reviewed by Chris Fleizach.
2848
2849         * DumpRenderTree/AccessibilityUIElement.cpp:
2850         (getPopupValueCallback):
2851         (AccessibilityUIElement::getJSClass):
2852         * DumpRenderTree/AccessibilityUIElement.h:
2853         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2854         (AccessibilityUIElement::popupValue const):
2855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2857         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2858         (WTR::AccessibilityUIElement::popupValue const):
2859         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2860         (WTR::AccessibilityUIElement::popupValue const):
2861
2862 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2863
2864         [ews-build] Do not print worker environment variables in each build step [part 2]
2865         https://bugs.webkit.org/show_bug.cgi?id=199405
2866
2867         Reviewed by Jonathan Bedard.
2868
2869         * BuildSlaveSupport/ews-build/steps.py:
2870         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
2871         (CleanWorkingDirectory.__init__): Ditto.
2872         (RunBindingsTests.__init__): Ditto.
2873         (RunWebKitPerlTests.__init__): Ditto.
2874         (RunWebKitPyTests.__init__): Ditto.
2875         (CompileWebKit.__init__): Ditto.
2876         (ArchiveTestResults.__init__): Ditto.
2877         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2878
2879 2019-07-02  Jer Noble  <jer.noble@apple.com>
2880
2881         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
2882         https://bugs.webkit.org/show_bug.cgi?id=199381
2883         <rdar://problem/52483103>
2884
2885         Reviewed by Eric Carlson.
2886
2887         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2888
2889 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] Update bot configuration for WPE and GTK
2892         https://bugs.webkit.org/show_bug.cgi?id=199238
2893
2894         Reviewed by Michael Catanzaro.
2895
2896         * BuildSlaveSupport/ews-build/config.json:
2897
2898 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2899
2900         [ews-build] Make PrintConfiguration platform aware
2901         https://bugs.webkit.org/show_bug.cgi?id=196657
2902
2903         Reviewed by Lucas Forschler.
2904
2905         * BuildSlaveSupport/ews-build/steps.py:
2906         (PrintConfiguration): Specified platform-specific command lists.
2907         (PrintConfiguration.run): Override run method and specify platform specific commands.
2908         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2909
2910 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
2911
2912         [Wasm-References] Disable references by default
2913         https://bugs.webkit.org/show_bug.cgi?id=199390
2914
2915         Reviewed by Saam Barati.
2916
2917         * Scripts/run-jsc-stress-tests:
2918
2919 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
2920
2921         Unreviewed. Revert r246965 to fix build break
2922         since r247019 reverted its related changes.
2923
2924         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2925         (WTR::AccessibilityUIElement::popupValue const): Deleted.
2926
2927 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2928
2929         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
2930         https://bugs.webkit.org/show_bug.cgi?id=199371
2931         <rdar://problem/52352905>
2932
2933         Reviewed by Tim Horton.
2934
2935         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2936         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
2937         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
2938         (-[NavigationActionSPIDelegate spiCalled]):
2939         (TEST):
2940
2941 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2942
2943         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
2944         https://bugs.webkit.org/show_bug.cgi?id=199296
2945         <rdar://problem/51041960>
2946
2947         Reviewed by Darin Adler.
2948
2949         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2950         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2951
2952 2019-07-01  Truitt Savell  <tsavell@apple.com>
2953
2954         Unreviewed, rolling out r246958.
2955
2956         Broke inspector/dom/getAccessibilityPropertiesForNode.html
2957
2958         Reverted changeset:
2959
2960         "Enhance support of aria-haspopup per ARIA 1.1 specification."
2961         https://bugs.webkit.org/show_bug.cgi?id=199216
2962         https://trac.webkit.org/changeset/246958
2963
2964 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2965
2966         Unreviewed, GTK a11y tests fix after r246958
2967
2968         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2969         (WTR::AccessibilityUIElement::popupValue const):
2970
2971 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
2972
2973         Enhance support of aria-haspopup per ARIA 1.1 specification.
2974         https://bugs.webkit.org/show_bug.cgi?id=199216
2975         <rdar://problem/46221342>
2976
2977         Reviewed by Chris Fleizach.
2978
2979         * DumpRenderTree/AccessibilityUIElement.cpp:
2980         (getPopupValueCallback):
2981         (AccessibilityUIElement::getJSClass):
2982         * DumpRenderTree/AccessibilityUIElement.h:
2983         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2984         (AccessibilityUIElement::popupValue const):
2985         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2986         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2987         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2988         (WTR::AccessibilityUIElement::popupValue const):
2989         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2990         (WTR::AccessibilityUIElement::popupValue const):
2991
2992 2019-06-28  Robin Morisset  <rmorisset@apple.com>
2993
2994         Adding myself as a reviewer to contributors.json.
2995
2996         Unreviewed.
2997
2998         * Scripts/webkitpy/common/config/contributors.json:
2999
3000 2019-06-28  Jer Noble  <jer.noble@apple.com>
3001
3002         Add new -[WKWebView _closeAllMediaPresentations] SPI
3003         https://bugs.webkit.org/show_bug.cgi?id=199294
3004         <rdar://problem/51965958>
3005
3006         Reviewed by Alex Christensen.
3007
3008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3009         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3010         (TEST):
3011
3012 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3013
3014         Add a regression test for change r246901
3015         https://bugs.webkit.org/show_bug.cgi?id=199290
3016
3017         Reviewed by Geoffrey Garen.
3018
3019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3020         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3021         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3022         (TEST):
3023         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3024
3025 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3026
3027         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3028         https://bugs.webkit.org/show_bug.cgi?id=199317
3029
3030         Reviewed by Michael Catanzaro.
3031
3032         While IconDatabase and all code using it was removed,
3033         ENABLE_ICONDATABASE still exists as build option and C++ macro.
3034
3035         * Scripts/webkitperl/FeatureList.pm:
3036         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3037         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
3038         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
3039
3040 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3041
3042         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
3043         https://bugs.webkit.org/show_bug.cgi?id=199310
3044         <rdar://problem/52292137>
3045
3046         Reviewed by Megan Gardner.
3047
3048         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
3049         _elementDidFocus.
3050
3051         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3054         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3055         (-[TestInputDelegate setDidStartInputSessionHandler:]):
3056         (-[TestInputDelegate didStartInputSessionHandler]):
3057
3058         Add plumbing for a handler block in TestInputDelegate.
3059
3060         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3061
3062         Drive-by style fixes to add a space between id and < for Objective-C protocols.
3063
3064         (-[TestInputDelegate willStartInputSessionHandler]):
3065         (-[TestInputDelegate _webView:willStartInputSession:]):
3066         (-[TestInputDelegate _webView:didStartInputSession:]):
3067         * TestWebKitAPI/cocoa/TestWKWebView.h:
3068         * TestWebKitAPI/ios/UIKitSPI.h:
3069
3070         Add a declaration for _selectionClipRects.
3071
3072 2019-06-27  Zalan Bujtas  <zalan@apple.com>
3073
3074         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
3075         https://bugs.webkit.org/show_bug.cgi?id=199303
3076         <rdar://problem/51340927>
3077
3078         Reviewed by Tim Horton.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3081         (TEST):
3082
3083 2019-06-27  Beth Dakin  <bdakin@apple.com>
3084
3085         Upstream use of MACCATALYST
3086         https://bugs.webkit.org/show_bug.cgi?id=199245
3087         rdar://problem/51687723
3088
3089         Reviewed by Tim Horton.
3090
3091         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
3092         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
3093         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
3094         * MiniBrowser/Configurations/SDKVariant.xcconfig:
3095         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
3096         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3097         (JavaScriptCoreGenerator):
3098         (WebCoreGenerator):
3099         (WebKitGenerator):
3100         * TestWebKitAPI/Configurations/Base.xcconfig:
3101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3102         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
3103         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3104         * WebEditingTester/Configurations/SDKVariant.xcconfig:
3105         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
3106         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
3107         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
3108
3109 2019-06-27  Saam Barati  <sbarati@apple.com>
3110
3111         Make WEBGPU enabled only on Mojave and later.
3112
3113         Rubber-stamped by Myles C. Maxfield.
3114
3115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3116
3117 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
3118
3119         [ews-build] Do not print worker environment variables in each build step
3120         https://bugs.webkit.org/show_bug.cgi?id=197319
3121
3122         Reviewed by Lucas Forschler.
3123
3124         * BuildSlaveSupport/ews-build/steps.py:
3125         (CheckOutSource.__init__): Disabled logging of environment variables.
3126         (ApplyPatch.__init__): Ditto.
3127         (KillOldProcesses.__init__): Ditto.
3128         (ArchiveBuiltProduct.__init__): Ditto.
3129         (DownloadBuiltProduct.__init__): Ditto.
3130         (ExtractBuiltProduct.__init__): Ditto.
3131         (RunAPITests.__init__): Ditto.
3132         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3133
3134 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
3135
3136         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
3137         https://bugs.webkit.org/show_bug.cgi?id=199232
3138         <rdar://problem/51718328>
3139
3140         Reviewed by Youenn Fablet.
3141
3142         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3143         (TestWebKitAPI::TEST):
3144         Add a test that utilizes TCPServer as local files always omit referrer.
3145
3146 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3147
3148         [ews-build] Add configuration and architecture for WPE and GTK builders
3149         https://bugs.webkit.org/show_bug.cgi?id=199249
3150
3151         Reviewed by Jonathan Bedard.
3152
3153         * BuildSlaveSupport/ews-build/config.json:
3154
3155 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3156
3157         [ews-build] Add check for duplicate workers in config.json
3158         https://bugs.webkit.org/show_bug.cgi?id=199240
3159
3160         Reviewed by Jonathan Bedard.
3161
3162         * BuildSlaveSupport/ews-build/loadConfig.py:
3163         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
3164         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3165         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
3166
3167 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3168
3169         [Win] MiniBrowser should make better font choices
3170         https://bugs.webkit.org/show_bug.cgi?id=199244
3171
3172         Reviewed by Brent Fulgham.
3173
3174         * MiniBrowser/win/MainWindow.cpp:
3175         (MainWindow::updateDeviceScaleFactor):
3176         * MiniBrowser/win/MiniBrowserLib.rc:
3177
3178 2019-06-26  Alex Christensen  <achristensen@webkit.org>
3179
3180         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
3181         https://bugs.webkit.org/show_bug.cgi?id=199230
3182         <rdar://51757107>
3183
3184         Reviewed by Andy Estes.
3185
3186         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3187         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3188         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3189         * WebKitTestRunner/TestController.cpp:
3190         (WTR::TestController::generatePageConfiguration):
3191         (WTR::TestController::createWebViewWithOptions):
3192         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
3193         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
3194         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3195         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
3196         * WebKitTestRunner/TestController.h:
3197         * WebKitTestRunner/TestInvocation.cpp:
3198         (WTR::TestInvocation::invoke):
3199         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3200
3201 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3202
3203         [Win][MiniBrowser] Remove obsolete code after r246814.
3204         https://bugs.webkit.org/show_bug.cgi?id=199233
3205
3206         Reviewed by Fujii Hironori.
3207
3208         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3209         (MiniBrowserWebHost::didFinishLoadForFrame):
3210         (SimpleEventListener::SimpleEventListener): Deleted.
3211         (SimpleEventListener::handleEvent): Deleted.
3212
3213 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
3214
3215         Implement a new SPI to inform clients about AppSSO
3216         https://bugs.webkit.org/show_bug.cgi?id=199085
3217         <rdar://problem/50028246>
3218
3219         Reviewed by Geoffrey Garen.
3220
3221         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3222         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
3223         (-[TestSOAuthorizationNavigationDelegate init]):
3224         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3225         (TestWebKitAPI::TEST):
3226
3227 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-build] Retry Layout test in case of failures
3230         https://bugs.webkit.org/show_bug.cgi?id=199194
3231
3232         Reviewed by Jonathan Bedard.
3233
3234         * BuildSlaveSupport/ews-build/steps.py:
3235         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
3236         (ReRunWebKitTests): Build step to re-run layout tests.
3237         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
3238         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
3239         (RunWebKitTestsWithoutPatch.evaluateCommand):
3240
3241 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3242
3243         [ews-build] Combine various patchFailed*Tests properties
3244         https://bugs.webkit.org/show_bug.cgi?id=199193
3245
3246         Reviewed by Jonathan Bedard.
3247
3248         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
3249         can also be used for layout-tests later on.
3250         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3251
3252 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
3253
3254         [Win] MiniBrowser should default to webkit.org
3255         https://bugs.webkit.org/show_bug.cgi?id=199201
3256
3257         Reviewed by Don Olmstead.
3258
3259         * MiniBrowser/win/BrowserWindow.h:
3260         * MiniBrowser/win/MiniBrowserReplace.h:
3261         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3262         (WebKitBrowserWindow::loadHTMLString): Deleted.
3263         * MiniBrowser/win/WebKitBrowserWindow.h:
3264         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3265         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
3266         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3267         * MiniBrowser/win/WinMain.cpp:
3268         (wWinMain):
3269
3270 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3271
3272         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
3273         https://bugs.webkit.org/show_bug.cgi?id=199192
3274         <rdar://problem/51554509>
3275
3276         Reviewed by Tim Horton.
3277
3278         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
3279         verify that we gracefully handle web process termination and web view unparenting mid-drag.
3280
3281         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3282         (TestWebKitAPI::TEST):
3283         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3284         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3285         (-[DragAndDropSimulator _resetSimulatedState]):
3286         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3287         (-[DragAndDropSimulator _advanceProgress]):
3288         (-[DragAndDropSimulator liftPreviews]):
3289         (-[DragAndDropSimulator cancellationPreviews]):
3290         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
3291         (-[DragAndDropSimulator sessionWillBeginBlock]):
3292         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
3293
3294 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3295
3296         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
3297         https://bugs.webkit.org/show_bug.cgi?id=199178
3298
3299         Reviewed by Jonathan Bedard.
3300
3301         * BuildSlaveSupport/ews-build/steps.py:
3302         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
3303         (ExtractTestResults.__init__): Ditto.
3304         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
3305
3306 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3307
3308         Add user agent quirk for bankofamerica.com
3309         https://bugs.webkit.org/show_bug.cgi?id=199154
3310
3311         Reviewed by Carlos Garcia Campos.
3312
3313         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3314         (TestWebKitAPI::TEST):
3315
3316 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3317
3318         Fully rename WebKitGTK+ -> WebKitGTK everywhere
3319         https://bugs.webkit.org/show_bug.cgi?id=199159
3320
3321         Reviewed by Carlos Garcia Campos.
3322
3323         * BuildSlaveSupport/gtk/README:
3324         * MiniBrowser/gtk/BrowserWindow.c:
3325         * MiniBrowser/gtk/main.c:
3326         (aboutURISchemeRequestCallback):
3327         * Scripts/webkitpy/common/config/contributionareas.py:
3328         * Scripts/webkitpy/common/config/contributors.json:
3329         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
3330         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3331         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3332         (testWebViewResources):
3333         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3334         (testWebViewMouseTarget):
3335         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3336         (testWebExtensionGetTitle):
3337         (testDocumentLoadedSignal):
3338         (testWebExtensionFormControlsAssociated):
3339         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3340         (testWebKitSettingsUserAgent):
3341         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3342         (testWebViewRunJavaScript):
3343         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
3344         (main):
3345         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3346         (prepareContextMenuTestView):
3347         (testContextMenuPopulateMenu):
3348         (testContextMenuCustomMenu):
3349         (testContextMenuDisableMenu):
3350         (testContextMenuSubMenu):
3351         (testContextMenuDismissed):
3352         (testContextMenuWebExtensionMenu):
3353         (testContextMenuWebExtensionNode):
3354         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3355         (testInspectorDefault):
3356         (testInspectorManualAttachDetach):
3357         (testInspectorCustomContainerDestroyed):
3358         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3359         (testWebViewPrint):
3360         (testPrintOperationPrint):
3361         (testPrintOperationErrors):
3362         * gtk/install-dependencies:
3363         * gtk/jhbuild.modules:
3364         * gtkdoc/generate-gtkdoc:
3365         * wpe/install-dependencies:
3366
3367 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3368
3369         contributors.json not canonicalized since r243297
3370         https://bugs.webkit.org/show_bug.cgi?id=199161
3371
3372         Reviewed by Alexey Proskuryakov.
3373
3374         Canonicalize it using 'validate-committer-lists --canonicalize'
3375
3376         * Scripts/webkitpy/common/config/contributors.json:
3377
3378 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
3379
3380         webkitpy: Build style should be lower-case
3381         https://bugs.webkit.org/show_bug.cgi?id=199158
3382
3383         Reviewed by Aakash Jain.
3384
3385         * Scripts/webkitpy/test/main.py:
3386         (Tester._run_tests): Make all styles lower-case.
3387
3388 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3389
3390         [ews-build] Remove iOS queue from old EWS and dashboard
3391         https://bugs.webkit.org/show_bug.cgi?id=199150
3392
3393         Reviewed by Jonathan Bedard.
3394
3395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3396         * QueueStatusServer/config/queues.py:
3397
3398 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
3399
3400         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
3401         https://bugs.webkit.org/show_bug.cgi?id=198795
3402
3403         Unreviewed test gardening.
3404
3405         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3406         (TestWebKitAPI::TEST): Disable flaky test.
3407
3408 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3409
3410         [ews-build] Enable iOS-12-Build queue on new EWS
3411         https://bugs.webkit.org/show_bug.cgi?id=199149
3412
3413         Reviewed by Jonathan Bedard.
3414
3415         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
3416         this queue.
3417         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3418         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
3419         will keep the builders to the left and testers to the right.
3420
3421 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3422
3423         [ews-build] Upload test results after running layout-tests
3424         https://bugs.webkit.org/show_bug.cgi?id=199120
3425
3426         Reviewed by Jonathan Bedard.
3427
3428         * BuildSlaveSupport/ews-build/steps.py:
3429         (RunWebKitTests.evaluateCommand):
3430         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3431
3432 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3433
3434         [ews-build] EWS should provide option to download layout test results zip file
3435         https://bugs.webkit.org/show_bug.cgi?id=199121
3436
3437         Reviewed by Jonathan Bedard.
3438
3439         * BuildSlaveSupport/ews-build/steps.py:
3440         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
3441         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
3442
3443 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3444
3445         Add user agent quirk for Google Drive
3446         https://bugs.webkit.org/show_bug.cgi?id=199153
3447
3448         Reviewed by Carlos Garcia Campos.
3449
3450         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3451         (TestWebKitAPI::TEST):
3452
3453 2019-06-22  Zalan Bujtas  <zalan@apple.com>
3454
3455         [LFC] Expand tests coverage (328 new tests -> 2652).
3456
3457         * LayoutReloaded/misc/LFC-passing-tests.txt:
3458
3459 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
3460
3461         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
3462         https://bugs.webkit.org/show_bug.cgi?id=199107
3463         <rdar://problem/43663611>
3464
3465         Reviewed by Chris Fleizach.
3466
3467         iOS implementation for AccessibilityUIElement::hasPopup.
3468         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3469         (WTR::AccessibilityUIElement::hasPopup const):
3470
3471 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
3472
3473         Unreviewed, add myself to CMake watchlist
3474
3475         * Scripts/webkitpy/common/config/watchlist:
3476
3477 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
3478
3479         openDatabase should return an empty object when WebSQL is disabled
3480         https://bugs.webkit.org/show_bug.cgi?id=198805
3481
3482         Reviewed by Geoffrey Garen.
3483
3484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3485         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
3486         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
3487         (TEST):
3488         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
3489
3490 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
3491
3492         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
3493         https://bugs.webkit.org/show_bug.cgi?id=199114
3494         <rdar://problem/51671674>
3495
3496         Reviewed by Youenn Fablet.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3499         (-[TestSOAuthorizationNavigationDelegate init]):
3500         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3501         (configureSOAuthorizationWebView):
3502         (TestWebKitAPI::TEST):
3503
3504 2019-06-21  Youenn Fablet  <youenn@apple.com>
3505
3506         WebPageProxy should use the right path for sandbox extension
3507         https://bugs.webkit.org/show_bug.cgi?id=198902
3508         <rdar://problem/50772810>
3509
3510         Reviewed by Geoffrey Garen.
3511
3512         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3513         (TEST):
3514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3515
3516 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3517
3518         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
3519         https://bugs.webkit.org/show_bug.cgi?id=199094
3520
3521         Reviewed by Carlos Garcia Campos.
3522
3523         * MiniBrowser/gtk/BrowserTab.c:
3524         (runColorChooserCallback):
3525         (browserTabConstructed):
3526         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3527         (testWebViewSyncRequestOnMaxConns):
3528         (beforeAll):
3529         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3530         (testWebSocketTLSErrors):
3531         (beforeAll):
3532         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3533         (WebKitTestServer::~WebKitTestServer):
3534         (WebKitTestServer::getWebSocketURIForPath const):
3535         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3536         (WTR::AccessibilityUIElement::rowHeaders const):
3537         (WTR::AccessibilityUIElement::columnHeaders const):
3538         (WTR::AccessibilityUIElement::isAttributeSettable):
3539         (WTR::AccessibilityUIElement::x):
3540         (WTR::AccessibilityUIElement::y):
3541         (WTR::AccessibilityUIElement::width):
3542         (WTR::AccessibilityUIElement::height):
3543         (WTR::AccessibilityUIElement::clickPointX):
3544         (WTR::AccessibilityUIElement::clickPointY):
3545         (WTR::AccessibilityUIElement::intValue const):
3546         (WTR::AccessibilityUIElement::minValue):
3547         (WTR::AccessibilityUIElement::maxValue):
3548         (WTR::stringAtOffset):
3549
3550 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
3551
3552         test-webkitpy is broken on macOS Catalina
3553         https://bugs.webkit.org/show_bug.cgi?id=199078
3554
3555         Reviewed by Jonathan Bedard.
3556
3557         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
3558         to the runner.
3559         (main): 
3560         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
3561
3562 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
3563
3564         Change status to "committer" in contributors.json
3565
3566         Unreviewed.
3567
3568         * Scripts/webkitpy/common/config/contributors.json:
3569
3570 2019-06-20  Alex Christensen  <achristensen@webkit.org>
3571
3572         Add unit test for UIContextMenuConfiguration API
3573         https://bugs.webkit.org/show_bug.cgi?id=199043
3574
3575         Reviewed by Wenson Hsieh.
3576
3577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3578         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
3579         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3580         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
3581         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3582         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
3583         (TEST):
3584         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
3585         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
3586         (-[TestContextMenuDriver delegate]):
3587         (-[TestContextMenuDriver setDelegate:]):
3588         (-[TestContextMenuDriver view]):
3589         (-[TestContextMenuDriver setView:]):
3590         (-[TestContextMenuDriver allowableMovement]):
3591         (-[TestContextMenuDriver setAllowableMovement:]):
3592         (-[TestContextMenuDriver primaryGestureRecognizer]):
3593         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
3594         (-[TestContextMenuDriver touchDuration]):
3595         (-[TestContextMenuDriver setTouchDuration:]):
3596         (-[TestContextMenuDriver locationInCoordinateSpace:]):
3597         (-[TestContextMenuDriver cancelInteraction]):
3598         (-[TestContextMenuDriver begin:]):
3599         (-[TestContextMenuDriver clickDown]):
3600         (-[TestContextMenuDriver clickUp]):
3601         (-[TestContextMenuDriver end]):
3602         * TestWebKitAPI/ios/UIKitSPI.h:
3603
3604 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3605
3606         [ews-app] Status bubble should not turn orange when any build step is skipped
3607         https://bugs.webkit.org/show_bug.cgi?id=199079
3608
3609         Reviewed by Jonathan Bedard.
3610
3611         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3612
3613 2019-06-20  Alex Christensen  <achristensen@webkit.org>
3614
3615         Fix an internal engineering build after r246605
3616        ​https://bugs.webkit.org/show_bug.cgi?id=197800
3617
3618         * TestWebKitAPI/TCPServer.cpp:
3619
3620 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3621
3622         [ews-build] Triggered builds should use same revision as parent build
3623         https://bugs.webkit.org/show_bug.cgi?id=198289
3624
3625         Reviewed by Jonathan Bedard.
3626
3627         * BuildSlaveSupport/ews-build/steps.py:
3628         (CheckOutSpecificRevision): Build step to checkout specific revision.
3629         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
3630         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
3631         (CheckOutSpecificRevision.start): Run appropriate git command.
3632         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
3633         builds use same revision as parent build.
3634         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3635         * BuildSlaveSupport/ews-build/factories.py:
3636         (Factory.__init__): Added CheckOutSpecificRevision step.
3637
3638 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
3641         https://bugs.webkit.org/show_bug.cgi?id=199073
3642
3643         Reviewed by Jonathan Bedard.
3644
3645         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
3646
3647 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
3648
3649         [GTK] Enable navigation swipe layout tests
3650         https://bugs.webkit.org/show_bug.cgi?id=198995
3651
3652         Reviewed by Michael Catanzaro.
3653
3654         Add a way for tests to enable and then control swipe gesture on GTK.
3655
3656         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
3657       &nb