Unreviewed, remove empty directories.
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Unreviewed, remove empty directories.
4
5         * DumpRenderTree/gtk: Removed.
6         * DumpRenderTree/gtk/fonts: Removed.
7         * DumpRenderTree/unix: Removed.
8         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
9         * GtkLauncher: Removed.
10         * TestWebKitAPI/Tests/WebKitGtk: Removed.
11         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
12         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
13         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
14
15 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
16
17         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
18         https://bugs.webkit.org/show_bug.cgi?id=141519
19
20         Reviewed by Alexey Proskuryakov.
21
22         * Scripts/build-webkittestrunner:
23
24 2015-02-12  Alex Christensen  <achristensen@webkit.org>
25
26         Removed empty directory.
27
28         * WinCELauncher: Removed.
29
30 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
31
32         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
33         https://bugs.webkit.org/show_bug.cgi?id=141202
34
35         Reviewed by Darin Adler.
36
37         * Scripts/run-jsc-stress-tests:
38
39 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
40
41         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
42         https://bugs.webkit.org/show_bug.cgi?id=141517
43
44         Reviewed by Anders Carlsson.
45
46         We do not need to locate or use the DLL's that came with Safari, so stop
47         failing when we cannot find them. Also remove some old Qt cruft from this
48         script.
49
50         * BuildSlaveSupport/built-product-archive:
51         (archiveBuiltProduct): 
52         (extractBuiltProduct):
53
54 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
55
56         [Win] [64-bit] Work around MSVC2013 Runtime Bug
57         https://bugs.webkit.org/show_bug.cgi?id=141498
58         <rdar://problem/19803642>
59
60         Reviewed by Anders Carlsson.
61
62         Disable FMA3 instruction use in the MSVC math library to
63         work around a VS2013 runtime crash. We can remove this
64         workaround when we switch to VS2015.
65
66         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
67         disable FMA3 support.
68         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
69         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
70         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
71         * Scripts/webkitperl/httpd.pm: Ditto.
72         * TestWebKitAPI/win/main.cpp: Ditto.
73         * WinLauncher/Common.cpp: Ditto.
74         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
75
76 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
77
78         run-jsc-stress-tests should accept remote host config from JSON file
79         https://bugs.webkit.org/show_bug.cgi?id=141509
80
81         Reviewed by Michael Saboff.
82
83         * Scripts/run-javascriptcore-tests:
84         (runJSCStressTests):
85         * Scripts/run-jsc-stress-tests:
86
87 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
88
89         [GTK] Add API to allow overriding the default color chooser implementation
90         https://bugs.webkit.org/show_bug.cgi?id=98935
91
92         Reviewed by Gustavo Noronha Silva.
93
94         Add a color chooser implementation for MiniBrowser using
95         GtkPopover when the GTK+ version is recent enough.
96         And a test case to check the new color chooser API.
97
98         * MiniBrowser/gtk/BrowserWindow.c:
99         (colorChooserRGBAChanged):
100         (popoverColorClosed):
101         (colorChooserRequestFinished):
102         (runColorChooserCallback):
103         (browserWindowConstructed):
104         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
105         (testWebViewColorChooserRequest):
106         (beforeAll):
107
108 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
109
110         Make run-jsc-stress-tests --remote work with make-based runner
111         https://bugs.webkit.org/show_bug.cgi?id=141079
112
113         Reviewed by Darin Adler.
114
115         * Scripts/run-javascriptcore-tests:
116         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
117         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
118         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
119         to avoid code duplication.
120
121 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
122
123         run-jsc-stress tests should detect the number of processors on the remote machine too
124         https://bugs.webkit.org/show_bug.cgi?id=141196
125
126         Reviewed by Darin Adler.
127
128         * Scripts/run-javascriptcore-tests:
129         (runJSCStressTests): Pass through the --child-processes argument.
130         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
131         to detect the number of local and remote processors with the same algorithm.
132         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
133         same as $numProcessors.
134
135 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
136
137         run-jsc-stress-tests should pass JSC_timeout to remote hosts
138         https://bugs.webkit.org/show_bug.cgi?id=141164
139
140         Reviewed by Darin Adler.
141
142         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
143
144         * Scripts/run-jsc-stress-tests:
145
146 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         [GTK] Add default color chooser implementation using GtkColorChooserDialog
149         https://bugs.webkit.org/show_bug.cgi?id=141392
150
151         Reviewed by Gustavo Noronha Silva.
152
153         Enable INPUT_TYPE_COLOR by default for GTK+ port.
154
155         * Scripts/webkitperl/FeatureList.pm:
156
157 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
158
159         run-jsc-stress-tests shell test runner should run tests in fixed order
160         https://bugs.webkit.org/show_bug.cgi?id=141383
161
162         Reviewed by Darin Adler.
163
164         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
165
166 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
167
168         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
169         https://bugs.webkit.org/show_bug.cgi?id=140485
170
171         Reviewed by Anders Carlsson.
172
173         Implement takeFocus() as a way to set focus through accessibility wrappers.
174
175         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
176         (AccessibilityUIElement::takeFocus):
177         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
178         (WTR::AccessibilityUIElement::takeFocus):
179
180 2015-02-08  Darin Adler  <darin@apple.com>
181
182         Remove the SVG instance tree
183         https://bugs.webkit.org/show_bug.cgi?id=140602
184
185         Reviewed by Dean Jackson.
186
187         * Scripts/check-for-global-initializers: Removed special case for
188         SVGElementInstance.o.
189
190 2015-02-07  David Kilzer  <ddkilzer@apple.com>
191
192         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
193         <http://webkit.org/b/141365>
194
195         Reviewed by Daniel Bates.
196
197         * Scripts/webkitpy/xcode/simulator.py:
198         (Simulator): Add unavailable_version_re precompiled regex.
199         (Simulator._parse_devices): Check for unavailable versions and
200         ignore them if found when parsing the output of
201         `xcrun simctl list`.
202         * Scripts/webkitpy/xcode/simulator_unittest.py:
203         (test_unavailable_devices): Add test with output from
204         `xcrun simctl list` with unavailable runtimes that fails before
205         the fix.
206
207 2015-02-07  Chris Dumez  <cdumez@apple.com>
208
209         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
210         https://bugs.webkit.org/show_bug.cgi?id=141321
211
212         Reviewed by Darin Adler.
213
214         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
215
216 2015-02-07  David Kilzer  <ddkilzer@apple.com>
217
218         [iOS] Make Simulator class testable
219         <http://webkit.org/b/141358>
220
221         Rubber-stamped by Darin Adler.
222
223         * Scripts/webkitpy/common/system/platforminfo.py:
224         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
225         command to here from Simulator.refresh() in xcode/simulator.py
226         so that the output of the command can be mocked.
227
228         * Scripts/webkitpy/common/system/platforminfo_mock.py:
229         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
230         to None.
231         (MockPlatformInfo.xcode_simctl_list): Add method that returns
232         self.expected_xcode_simctl_list expectation.
233
234         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
235         and license header.
236         (Simulator.__init__): Add optional 'host' parameter to make it
237         possible to pass in a mock object for testing.  Set self._host
238         to 'host' parameter or create Host() object.
239         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
240         method.
241
242         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
243         for current code.
244         (SimulatorTest):
245         (SimulatorTest.setUp):
246         (SimulatorTest._set_expected_xcrun_simctl_list):
247         (SimulatorTest.test_simulator_device_types):
248         (test_invalid_device_types_header):
249         (test_invalid_runtimes_header):
250         (test_invalid_devices_header):
251
252 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
253
254         run-jsc-stress-tests --remote should use the default ssh port
255         https://bugs.webkit.org/show_bug.cgi?id=141287
256
257         Reviewed by Darin Adler.
258
259         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
260
261 2015-02-06  Dana Burkart  <dburkart@apple.com>
262
263         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
264         https://bugs.webkit.org/show_bug.cgi?id=141349
265
266         Reviewed by Alexey Proskuryakov.
267
268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
269         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
270         (BuildbotTesterQueueView.prototype.update):
271
272 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
273
274         Report network process crashes during layout tests
275         https://bugs.webkit.org/show_bug.cgi?id=139646
276
277         Reviewed by Anders Carlsson.
278
279         * WebKitTestRunner/TestController.cpp:
280         (WTR::TestController::initialize):
281         (WTR::TestController::networkProcessName):
282         (WTR::TestController::networkProcessDidCrash):
283         * WebKitTestRunner/TestController.h:
284
285 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
286
287         run-jsc-stress-tests --remote should create remote directory before copying the bundle
288         https://bugs.webkit.org/show_bug.cgi?id=141329
289
290         Reviewed by Michael Saboff.
291
292         * Scripts/run-jsc-stress-tests:
293
294 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
295
296         [GTK] Remove WebKitWebView::close-notification signal
297         https://bugs.webkit.org/show_bug.cgi?id=141330
298
299         Reviewed by Gustavo Noronha Silva.
300
301         Update notifications unit tests according to the API changes, and
302         add a test case to check that onclose event is fired when a
303         notification is closed by the user.
304
305         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
306         (testWebViewNotification):
307
308 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
309
310         Dashboard doesn't consider building ASan a productive step
311         https://bugs.webkit.org/show_bug.cgi?id=141312
312
313         Reviewed by Simon Fraser.
314
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
316
317 2015-02-05  Daniel Bates  <dabates@apple.com>
318
319         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
320         https://bugs.webkit.org/show_bug.cgi?id=141306
321
322         Reviewed by Alexey Proskuryakov.
323
324         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
325         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
326         existent runtime.
327
328         * Scripts/webkitpy/xcode/simulator.py:
329         (Runtime.from_identifier):
330
331 2015-02-05  Daniel Bates  <dabates@apple.com>
332
333         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
334         https://bugs.webkit.org/show_bug.cgi?id=139746
335         <rdar://problem/19283658>
336
337         Reviewed by Alexey Proskuryakov.
338
339         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
340         if the simulator device is not in state Booted.
341
342         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
343         launching/relaunching the iOS Simulator app and a simulator app can only be installed
344         on a device that is in the Booted state. LayoutTestRelay may run before the
345         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
346         We should defer executing LayoutTestRelay until the simulator device booted by
347         iOS Simulator is in the Booted state.
348
349         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
350         Simulator methods with the module name, simulator.
351         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
352         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
353         before launching iOS Simulator to boot it.
354         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
355         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
356         * Scripts/webkitpy/xcode/simulator.py:
357         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
358         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
359         interested in the state of the device are more likely interested in the current state of the device as
360         opposed to the state of the device when the Device object was created.
361         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
362         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
363         from both this function and Simulator.device_state().
364         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
365         (Simulator.DeviceState): Added; class of constants.
366         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
367         device is in the specified state.
368         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
369         (Simulator.device_directory): Added.
370         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
371
372 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
373
374         Disable retries on Mac debug testers
375         https://bugs.webkit.org/show_bug.cgi?id=141296
376
377         Reviewed by Simon Fraser.
378
379         * BuildSlaveSupport/build.webkit.org-config/config.json:
380
381 2015-02-05  Dan Bernstein  <mitz@apple.com>
382
383         Need a way to force $xcodeSDK in webkitdirs.pm
384         https://bugs.webkit.org/show_bug.cgi?id=141291
385
386         Reviewed by Anders Carlsson.
387
388         * Scripts/webkitdirs.pm:
389         (setXcodeSDK): Added.
390
391 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
392
393         [Streams API] Implement a barebone ReadableStream interface
394         https://bugs.webkit.org/show_bug.cgi?id=141045
395
396         Reviewed by Benjamin Poulain.
397
398         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
399
400 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
401
402         filter-build-webkit: reduce more unfiltered output
403         https://bugs.webkit.org/show_bug.cgi?id=141282
404
405         Reviewed by Daniel Bates.
406
407         * Scripts/filter-build-webkit:
408         Report CompileDTraceScript and Preprocess lines as successful.
409
410 2015-02-04  Dana Burkart  <dburkart@apple.com>
411
412         Botwatcher's Dashboard is cramped
413         https://bugs.webkit.org/show_bug.cgi?id=140273
414
415         Reviewed by Alexey Proskuryakov.
416
417         Add a heading key which will allow for arbitrary headings in builder queues.
418
419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
420         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
421         (BuildbotBuilderQueueView.prototype.update):
422         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
424         (BuildbotIteration.prototype._parseData):
425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
426         (BuildbotLeaksQueueView.prototype.update):
427         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
429         (BuildbotPerformanceQueueView.prototype.update):
430         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
432         (BuildbotQueue):
433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
434         (BuildbotQueueView.prototype._unauthorizedAccess):
435         (BuildbotQueueView.prototype._appendBuild):
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
437         (BuildbotTestResults):
438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
439         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
440         (BuildbotTesterQueueView.prototype.update):
441         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
442
443 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
444
445         WKTR should not use -mainScreen to pick a color profile
446         https://bugs.webkit.org/show_bug.cgi?id=141265
447
448         Reviewed by Tim Horton.
449         
450         -[NSScreen mainScreen] depends on the active window, so use the first screen
451         (which is the one we put the window on anyway).
452         
453         Do some cleanup in DRT that makes the code look similar.
454
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         (createWebViewAndOffscreenWindow):
457         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
458         (WTR::PlatformWebView::PlatformWebView):
459
460 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
461
462         LayoutTestHelper should set the color profile of all displays
463         https://bugs.webkit.org/show_bug.cgi?id=141260
464
465         Reviewed by Tim Horton.
466         
467         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
468         which is the screen with the active window. Make things more robust by changing
469         the colorspace of all displays, not just the main screen, when running layout tests.
470
471         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
472         * DumpRenderTree/mac/LayoutTestHelper.m: 
473         (originalColorProfileURLs):
474         (colorProfileURLForDisplay):
475         (displayUUIDStrings):
476         (saveDisplayColorProfiles):
477         (setDisplayColorProfile):
478         (restoreDisplayColorProfiles):
479         (installLayoutTestColorProfile):
480         (restoreUserColorProfile):
481         (main):        
482         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
483         toll-free bridged, sadly). Use the map to restore all profiles on exit.
484         Convert to use more Obj-C types.
485
486 2015-02-04  Daniel Bates  <dabates@apple.com>
487
488         test-webkitpy fails on Mac without iphoneos SDK
489         https://bugs.webkit.org/show_bug.cgi?id=141255
490         <rdar://problem/19619691>
491
492         I inadvertently committed the wrong exception message. Fix up the exception message
493         to instruct a person to install the iOS SDK when it cannot be found.
494
495         * Scripts/webkitpy/port/ios.py:
496         (IOSPort.determine_full_port_name):
497
498 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
499
500         W3C test importer should sort the list of files when generating the w3c-import.log
501         https://bugs.webkit.org/show_bug.cgi?id=141156
502
503         Reviewed by Bem Jones-Bey.
504
505         Sort explicitly the list of imported files written in the w3c-import.log.
506         Removed logging of the import date.
507
508         * Scripts/webkitpy/w3c/test_importer.py:
509         (TestImporter.write_import_log):
510
511 2015-02-04  Daniel Bates  <dabates@apple.com>
512
513         test-webkitpy fails on Mac without iphoneos SDK
514         https://bugs.webkit.org/show_bug.cgi?id=141255
515         <rdar://problem/19619691>
516
517         Reviewed by David Kilzer and Alexey Proskuryakov.
518
519         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
520         should not require the iphoneos SDK to be installed to run the webkitpy tests.
521
522         * Scripts/webkitpy/common/system/platforminfo.py:
523         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
524         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
525         to standard output if the SDK is installed to return the empty string if the SDK is
526         not installed.
527         * Scripts/webkitpy/common/system/platforminfo_mock.py:
528         (MockPlatformInfo.xcode_sdk_version): Added.
529         * Scripts/webkitpy/port/ios.py:
530         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
531         to get the version of the iphoneos SDK, if installed.
532
533 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
534
535         run-webkit-tests doesn't always capture ASan violation reports
536         https://bugs.webkit.org/show_bug.cgi?id=141231
537
538         Reviewed by Darin Adler.
539
540         * Scripts/webkitpy/port/driver.py:
541         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
542         by the driver already (as is the case with ASan violations, which are printed to
543         stderr).
544         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
545         report.
546         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
547         a separate variable for reporting.
548
549 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
550
551         [webkitpy] Add platform specific Skipped file mechanism for performance tests
552         https://bugs.webkit.org/show_bug.cgi?id=141152
553
554         Reviewed by Csaba Osztrogonác.
555
556         Support a test-expectation-like syntax in performance tests' skipped files.
557         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
558
559         * Scripts/webkitpy/port/base.py:
560         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
561
562         * Scripts/webkitpy/port/base_unittest.py:
563         (PortTest.test_skipped_perf_tests): Test the new syntax.
564
565 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
566
567         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
568         https://bugs.webkit.org/show_bug.cgi?id=141236
569
570         Reviewed by Sam Weinig.
571
572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
573         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
574
575 2015-02-04  Chris Dumez  <cdumez@apple.com>
576
577         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
578         https://bugs.webkit.org/show_bug.cgi?id=141192
579
580         Reviewed by Benjamin Poulain.
581
582         Add API tests for Vector::removeFirst(value) and
583         Vector::removeAll(value).
584
585         * TestWebKitAPI/Tests/WTF/Vector.cpp:
586         (TestWebKitAPI::TEST):
587
588 2015-02-03  Tim Horton  <timothy_horton@apple.com>
589
590         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
591         https://bugs.webkit.org/show_bug.cgi?id=141217
592
593         Reviewed by Sam Weinig.
594
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::copyWebCryptoMasterKey):
597         (WTR::TestController::createOtherPage):
598         (WTR::TestController::createWebViewWithOptions):
599         (WTR::TestController::ensureViewSupportsOptions):
600         (WTR::TestController::didCommitNavigation):
601         (WTR::TestController::didFinishNavigation):
602         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
603         (WTR::TestController::didReceiveAuthenticationChallenge):
604         (WTR::TestController::decidePolicyForPluginLoad):
605         (WTR::TestController::decidePolicyForNavigationAction):
606         (WTR::TestController::decidePolicyForNavigationResponse):
607         (WTR::TestController::didCommitLoadForFrame): Deleted.
608         (WTR::TestController::didFinishLoadForFrame): Deleted.
609         * WebKitTestRunner/TestController.h:
610         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
611
612 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
613
614         Unreviewed. Add myself as a committer.
615
616         * Scripts/webkitpy/common/config/contributors.json:
617
618 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
619
620         [Win] Unreviewed test fix.
621
622         * DumpRenderTree/win/PolicyDelegate.cpp:
623         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
624         so was not matching expected output.
625
626 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
627
628         Unreviewed. Moving myself to the committer section at last.
629
630         * Scripts/webkitpy/common/config/contributors.json:
631
632 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
633
634         [Win] Tests fail because DRT reports '(null)' instead of an empty string
635         https://bugs.webkit.org/show_bug.cgi?id=141205
636
637         Reviewed by Anders Carlsson.
638
639         * DumpRenderTree/win/HistoryDelegate.cpp:
640         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
641         properly so that we match expected DumpRenderTree output.
642
643 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
644
645         [GTK] TestWebKitAccessibility is not skipped
646         https://bugs.webkit.org/show_bug.cgi?id=141179
647
648         Reviewed by Carlos Garcia Campos.
649
650         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
651         skipped, and it apparently works reliably on the bots.
652
653         * Scripts/run-gtk-tests:
654         (TestRunner):
655
656 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
657
658         run-perf-tests: allow to specify a wrapper command.
659         https://bugs.webkit.org/show_bug.cgi?id=141172
660
661         Reviewed by Ryosuke Niwa.
662
663         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
664         (parse_args): Update text to indicate is also valid for WTR.
665         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
666         (PerfTestsRunner._parse_args): Add wrapper command.
667
668 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
669
670         [Win] Correct version parsing warning in update-webkit
671         https://bugs.webkit.org/show_bug.cgi?id=141200
672
673         Reviewed by Anders Carlsson.
674
675         * Scripts/webkitdirs.pm:
676         (setupAppleWinEnv): Strip out any specific version build level
677         from the Cygwin version information.
678   
679
680 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
681
682         [Win] Attempt to improve the reliability of HTTP service
683         https://bugs.webkit.org/show_bug.cgi?id=141191
684
685         Reviewed by Darin Adler.
686
687         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
688         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
689         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
690         when stopping the service doesn't do so on its own (for Windows runs).
691
692 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
693
694         Web platform test server should not need to create __init__.py files
695         https://bugs.webkit.org/show_bug.cgi?id=141030
696
697         Reviewed by Ryosuke Niwa.
698
699         W3C TestImporter ensures that copied __init__.py files are not empty.
700         If needed, a comment is inserted in __init__.py files.
701         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
702
703         * Scripts/webkitpy/common/system/filesystem.py:
704         (FileSystem.getsize):
705         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
706         (TestWebPlatformTestServer.test_start_cmd):
707         (TestWebPlatformTestServer):
708         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
709         * Scripts/webkitpy/w3c/test_importer.py:
710         (TestImporter.import_tests):
711
712 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
713
714         Unreviewed. Moving myself to the committer section.
715
716         * Scripts/webkitpy/common/config/contributors.json:
717
718 2015-02-02  Saam Barati  <saambarati1@gmail.com>
719
720         Create tests for JSC's Control Flow Profiler
721         https://bugs.webkit.org/show_bug.cgi?id=141123
722
723         Reviewed by Filip Pizlo.
724
725         * Scripts/run-javascriptcore-tests:
726         (runJSCStressTests):
727         * Scripts/run-jsc-stress-tests:
728
729 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
730
731         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
732         https://bugs.webkit.org/show_bug.cgi?id=141158
733
734         Reviewed by Darin Adler.
735
736         * Scripts/run-jsc-stress-tests:
737
738 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
739
740         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
741         https://bugs.webkit.org/show_bug.cgi?id=141142
742
743         Reviewed by Carlos Garcia Campos.
744
745         * MiniBrowser/gtk/BrowserWindow.c:
746         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
747
748 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
749
750         Web platform test server is not always launching properly on Mac EWS bots
751         https://bugs.webkit.org/show_bug.cgi?id=141141
752
753         Unreviewed.
754
755         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
756         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
757
758 2015-01-31  Sam Weinig  <sam@webkit.org>
759
760         Remove even more Mountain Lion support
761         https://bugs.webkit.org/show_bug.cgi?id=141124
762
763         Reviewed by Alexey Proskuryakov.
764
765         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
766         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
767         * DumpRenderTree/mac/Configurations/Base.xcconfig:
768         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
769         * DumpRenderTree/mac/DumpRenderTree.mm:
770         (activateTestingFonts):
771         (prepareConsistentTestingEnvironment):
772         * DumpRenderTree/mac/EventSendingController.mm:
773         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
774         (-[EventSendingController contextClick]):
775         * DumpRenderTree/mac/TextInputController.m:
776         * LayoutTestRelay/Configurations/Base.xcconfig:
777         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
778         * MiniBrowser/Configurations/Base.xcconfig:
779         * MiniBrowser/Configurations/DebugRelease.xcconfig:
780         * MiniBrowser/mac/WK2BrowserWindowController.m:
781         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
782         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
783         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
784         * TestWebKitAPI/Configurations/Base.xcconfig:
785         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
786         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
787         (-[DownloadDelegate _downloadDidFinish:]):
788         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
789         (TestWebKitAPI::TEST):
790         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
791         (TestWebKitAPI::InjectedBundleController::platformInitialize):
792         * WebKitLauncher/Configurations/Base.xcconfig:
793         * WebKitTestRunner/Configurations/Base.xcconfig:
794         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
795         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
796         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
797         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
798         (WTR::activateFonts):
799         * WebKitTestRunner/TestController.cpp:
800         (WTR::TestController::initialize):
801         (WTR::TestController::webProcessName):
802         * WebKitTestRunner/mac/EventSenderProxy.mm:
803         * asan/asan.xcconfig:
804
805 2015-01-31  Commit Queue  <commit-queue@webkit.org>
806
807         Unreviewed, rolling out r179408.
808         https://bugs.webkit.org/show_bug.cgi?id=141117
809
810         This didn't fully fix the issue (Requested by anttik on
811         #webkit).
812
813         Reverted changeset:
814
815         "OSObjectPtr does not work with dispatch_data_t on Maverics"
816         https://bugs.webkit.org/show_bug.cgi?id=141081
817         http://trac.webkit.org/changeset/179408
818
819 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
820
821         https://trac.webkit.org/changeset/179439 breaks a python test
822         https://bugs.webkit.org/show_bug.cgi?id=141114
823
824         Unreviewed.
825
826         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
827         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
828
829 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
830
831         Import W3C web platform tests infrastructure
832         https://bugs.webkit.org/show_bug.cgi?id=140934
833
834         Reviewed by Ryosuke Niwa.
835
836         Loading necessary web platform tests modules before launching server.
837         Ensuring that some empty __init__.py files are present and create them if necessary. 
838
839         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
840         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
841
842 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
843
844         [Win] Another unreviewed test fix.
845
846         Correct copy/paste error in buildbot handling.
847
848         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
849         (LayoutTestApacheHttpd.__init__):
850         (LayoutTestApacheHttpd._get_apache_config_file_path):
851
852 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
853
854         [Win] Unreviewed test fix.
855
856         Correct path handling based on failures on test bots to get things running again.
857
858         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
859         (LayoutTestApacheHttpd.__init__):
860         (LayoutTestApacheHttpd._get_apache_config_file_path):
861
862 2015-01-30  Chris Dumez  <cdumez@apple.com>
863
864         Unreviewed. Fix Windows build after r179409.
865
866         * DumpRenderTree/win/TestRunnerWin.cpp:
867         (TestRunner::notifyDone):
868         (TestRunner::queueLoad):
869
870 2015-01-30  Chris Dumez  <cdumez@apple.com>
871
872         Rename shared() static member functions to singleton() for singleton classes.
873         https://bugs.webkit.org/show_bug.cgi?id=141088
874
875         Reviewed by Ryosuke Niwa and Benjamin Poulain.
876
877         Rename shared() static member functions to singleton() for singleton
878         classes as per the recent coding style change.
879
880 2015-01-30  Antti Koivisto  <antti@apple.com>
881
882         OSObjectPtr does not work with dispatch_data_t on Maverics
883         https://bugs.webkit.org/show_bug.cgi?id=141081
884
885         Reviewed by Pratik Solanki.
886
887         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
888         (TestWebKitAPI::TEST):
889
890 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
891
892         [Win] Switch to Apache on Windows
893         https://bugs.webkit.org/show_bug.cgi?id=141060
894
895         Reviewed by Alexey Proskuryakov.
896
897         Update our scripts under Windows (and Cygwin) to locate and use
898         the XAMPP installation of Apache for running tests.
899
900         * Scripts/run-webkit-httpd:
901         * Scripts/webkitperl/httpd.pm:
902         (getHTTPDPath):
903         (getDefaultConfigForTestDirectory):
904         (getHTTPDConfigPathForTestDirectory):
905         * Scripts/webkitpy/common/system/executive_unittest.py:
906         (ExecutiveTest.serial_test_kill_process):
907         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
908         (LayoutTestApacheHttpd.__init__):
909         (LayoutTestApacheHttpd._get_apache_config_file_path):
910         (LayoutTestApacheHttpd._stop_running_server):
911         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
912         (HttpServerBase._is_server_running_on_all_ports):
913         * Scripts/webkitpy/port/base.py:
914         (Port._apache_config_file_name_for_platform):
915         * Scripts/webkitpy/port/port_testcase.py:
916         (test_apache_config_file_name_for_platform):
917         * Scripts/webkitpy/port/win.py:
918         (WinPort.show_results_html_file):
919         (WinPort._uses_apache):
920         (WinPort):
921         (WinPort._path_to_apache):
922
923 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
924
925         Built result takes too long to be compressed on bots
926         https://bugs.webkit.org/show_bug.cgi?id=141056
927
928         Reviewed by Daniel Bates.
929
930         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
931
932         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
933
934 2015-01-29  Sam Weinig  <sam@webkit.org>
935
936         Remove support for screen font substitution
937         https://bugs.webkit.org/show_bug.cgi?id=141038
938
939         Reviewed by Tim Horton.
940
941         * DumpRenderTree/win/DumpRenderTree.cpp:
942         (resetWebPreferencesToConsistentValues):
943         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
944
945 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
946
947         Make run-jsc-stress-tests --remote work on Linux too
948         https://bugs.webkit.org/show_bug.cgi?id=141000
949
950         Reviewed by Darin Adler.
951
952         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
953         use bash/dash compatible signal names, use Linux/Mac compatible find options,
954         use bash/dash compatible functions.
955         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
956
957 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
958
959         [buildbot] Simplify jscore-test buildstep
960         https://bugs.webkit.org/show_bug.cgi?id=140821
961
962         Reviewed by Alexey Proskuryakov.
963
964         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
965         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
966         (RunJavaScriptCoreTests.countFailures): Added.
967         (RunJavaScriptCoreTests.commandComplete): Deleted.
968         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
969         (RunJavaScriptCoreTests.getText): Deleted.
970         (RunJavaScriptCoreTests.getText2): Deleted.
971         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
972         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
973         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
974         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
975         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
976
977 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
978
979         Unreviewed, revert r179337, we don't need this dependency.
980
981         * efl/install-dependencies:
982         * gtk/install-dependencies:
983
984 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
985
986         Unreviewed. Moving myself to the committer section.
987
988         * Scripts/webkitpy/common/config/contributors.json:
989
990 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
991
992         URTBF after r179326, added uuid-dev package as new dependency.
993
994         * efl/install-dependencies:
995         * gtk/install-dependencies:
996
997 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
998
999         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1000         https://bugs.webkit.org/show_bug.cgi?id=140673
1001
1002         Reviewed by Sam Weinig.
1003
1004         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1005         Add a DTrace script that outputs a small blob of JSON per message.
1006
1007 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1008
1009         Removed fastMallocForbid / fastMallocAllow
1010         https://bugs.webkit.org/show_bug.cgi?id=141012
1011
1012         Reviewed by Mark Hahnenberg.
1013
1014         Fixed a test bug I noticed while testing.
1015
1016         * DumpRenderTree/JavaScriptThreading.cpp:
1017         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1018         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1019
1020 2015-01-28  Dana Burkart  <dburkart@apple.com>
1021
1022         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1023         https://bugs.webkit.org/show_bug.cgi?id=141015
1024
1025         Reviewed by Alexey Proskuryakov.
1026
1027         * asan/asan.xcconfig:
1028
1029 2015-01-28  Sam Weinig  <sam@webkit.org>
1030
1031         Fix the build.
1032
1033         * Scripts/copy-webkitlibraries-to-product-directory:
1034
1035 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1036
1037         Increase the FileUpload block size in an attempt to improve network performance.
1038         
1039         Reviewed by Alexey Proskuryakov.
1040         
1041         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1042         (UploadBuiltProduct.__init__):
1043
1044 2015-01-28  Dana Burkart  <dburkart@apple.com>
1045
1046         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1047         https://bugs.webkit.org/show_bug.cgi?id=136765
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1052         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1053         * LayoutTestRelay/Configurations/Base.xcconfig:
1054         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1055         * MiniBrowser/Configurations/Base.xcconfig:
1056         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1057         * TestWebKitAPI/Configurations/Base.xcconfig:
1058         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1059         * WebKitLauncher/Configurations/Base.xcconfig:
1060         * WebKitTestRunner/Configurations/Base.xcconfig:
1061         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1062
1063 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1064
1065         AX: [ATK] Implement support for new AtkRole types for MathML
1066         https://bugs.webkit.org/show_bug.cgi?id=140916
1067
1068         Reviewed by Chris Fleizach.
1069
1070         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1071         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1072
1073 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         [GTK] Stop removing color marks from unit tests output
1076         https://bugs.webkit.org/show_bug.cgi?id=140996
1077
1078         Reviewed by Philippe Normand.
1079
1080         Since r178236 google tests use a custom simplified output without
1081         any colors, so we don't need to handle the case of non ttys to
1082         remove the color marks.
1083
1084         * Scripts/run-gtk-tests:
1085         (TestRunner.__init__):
1086         (TestRunner._run_test_command.parse_line):
1087
1088 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1089
1090         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1091         https://bugs.webkit.org/show_bug.cgi?id=131731
1092
1093         Reviewed by Žan Doberšek.
1094
1095         A web page loaded offscreen is in prerender state not hidden.
1096
1097         * Scripts/run-gtk-tests:
1098         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1099         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1100         (testWebViewPageVisibility):
1101
1102 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1103
1104         Partially revert r178802.
1105
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1108
1109 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1110
1111         build.webkit.org/dashboard asserts on some commits
1112         https://bugs.webkit.org/show_bug.cgi?id=140926
1113
1114         Reviewed by Tim Horton.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1117         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1118
1119 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1120
1121         Make flakiness dashboard OS list actually match test_expectations.py
1122         https://bugs.webkit.org/show_bug.cgi?id=140969
1123
1124         Reviewed by Ryosuke Niwa.
1125
1126         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1127
1128 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1129
1130         [Win] WinLauncher crashes on eleventh site visited
1131         https://bugs.webkit.org/show_bug.cgi?id=140960
1132
1133         Reviewed by Anders Carlsson.
1134
1135         * WinLauncher/WinLauncher.cpp:
1136         (WinLauncher::showLastVisitedSites): Don't access off the end of
1137         the history array.
1138
1139 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1140
1141         [Mac] Disable building Java applets by default
1142         https://bugs.webkit.org/show_bug.cgi?id=140957
1143         rdar://problem/19619529
1144
1145         Reviewed by Anders Carlsson.
1146
1147         It was actually already disabled unconditionally, by accident.
1148
1149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1150         * Scripts/webkitpy/port/mac.py:
1151         (MacPort._check_port_build):
1152         (MacPort._build_java_test_support):
1153
1154 2015-01-27  Daniel Bates  <dabates@apple.com>
1155
1156         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1157         https://bugs.webkit.org/show_bug.cgi?id=140949
1158
1159         Reviewed by Alexey Proskuryakov.
1160
1161         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1162         builders so that run-webkit-tests can lint the appropriate TestExpectation
1163         files.
1164
1165         * Scripts/webkitpy/port/builders.py:
1166         * Scripts/webkitpy/port/ios.py:
1167         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1168         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1169         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1170         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1171         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1172         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1173         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1174
1175
1176 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1177
1178         Update bots on the flakiness dashboard
1179         https://bugs.webkit.org/show_bug.cgi?id=140956
1180
1181         Reviewed by Ryosuke Niwa.
1182
1183         * TestResultServer/static-dashboards/builders.jsonp:
1184         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1185
1186 2015-01-27  Daniel Bates  <dabates@apple.com>
1187
1188         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1189         https://bugs.webkit.org/show_bug.cgi?id=140942
1190
1191         Reviewed by Alexey Proskuryakov.
1192
1193         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1194         are applicable to all WebKit2 ports. We should make use of this information when
1195         running layout tests using iOS WebKit2.
1196
1197         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1198         of the WebKit2 port instead of directly using string concatenation.
1199
1200         * Scripts/webkitpy/port/ios.py:
1201         (IOSSimulatorPort.default_baseline_search_path):
1202
1203 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1204
1205         [Win] Disable FTL stress tests
1206         https://bugs.webkit.org/show_bug.cgi?id=140932
1207
1208         Reviewed by Brent Fulgham.
1209
1210         * Scripts/run-javascriptcore-tests:
1211
1212 2015-01-27  Daniel Bates  <dabates@apple.com>
1213
1214         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1215         https://bugs.webkit.org/show_bug.cgi?id=140939
1216
1217         Reviewed by Eric Carlson.
1218
1219         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1220
1221         * Scripts/webkitdirs.pm:
1222         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1223         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1224         and define a function called wanted.
1225
1226 2015-01-27  Daniel Bates  <dabates@apple.com>
1227
1228         Teach run-webkit-app --simulator how to install custom built app
1229         https://bugs.webkit.org/show_bug.cgi?id=140691
1230
1231         Fix inadvertent omission of directory test flag in expression to check for the
1232         existence of the iOS simulator device-specific directory for user installed apps.
1233
1234         * Scripts/webkitdirs.pm:
1235         (hasUserInstalledAppInSimulatorDevice):
1236
1237 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1238
1239         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1240         https://bugs.webkit.org/show_bug.cgi?id=87426
1241         <rdar://problem/11527899>
1242
1243         Reviewed by Darin Adler.
1244
1245         Revise COMPtr to work better with our HashMap implementation. Use
1246         modern loop syntax.
1247
1248         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1249         (AccessibilityController::~AccessibilityController):
1250         (AccessibilityController::winNotificationReceived):
1251         * DumpRenderTree/win/DumpRenderTree.cpp:
1252         (dumpBackForwardListForAllWindows):
1253
1254 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1255
1256         [Win] Enable JSC stress tests by default
1257         https://bugs.webkit.org/show_bug.cgi?id=128307
1258
1259         Reviewed by Brent Fulgham.
1260
1261         * Scripts/run-javascriptcore-tests:
1262
1263 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1264
1265         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1266         arguments for build and test scripts
1267         https://bugs.webkit.org/show_bug.cgi?id=139748
1268
1269         Reviewed by Daniel Bates.
1270
1271         There was much confusion resulting from the multitude of aliases used to build/test for
1272         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1273         tests directory.
1274
1275         This fixes an issue where run-api-tests and some other scripts failed when run with
1276         --simulator.
1277
1278         * Scripts/build-webkit:
1279         * Scripts/package-root:
1280         (usage):
1281         * Scripts/webkitdirs.pm:
1282         (argumentsForConfiguration):
1283         (determineXcodeSDK):
1284         * Scripts/webkitpy/port/factory.py:
1285         (platform_options):
1286
1287 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1288
1289         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1290         https://bugs.webkit.org/show_bug.cgi?id=140203
1291         rdar://problem/19198492
1292
1293         Reviewed by Sam Weinig.
1294
1295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1296         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1297         (TEST):
1298
1299 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1300
1301         Add iOS EWS to build.webkit.org/dashboard
1302         <http://webkit.org/b/140627>
1303
1304         Reviewed by Alexey Proskuryakov.
1305
1306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1309         (BubbleQueueServer): Add ios-ews queue info.
1310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1311         Add iOS8Device platform.
1312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1313         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1314         iOS device logo.
1315
1316 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1317
1318         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1319         https://bugs.webkit.org/show_bug.cgi?id=140896
1320
1321         Reviewed by Michael Saboff.
1322         
1323         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1324         makes our script do this.
1325         
1326         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1327         this would be harder given llvm's autoconf setup.
1328
1329         * Scripts/copy-webkitlibraries-to-product-directory:
1330
1331 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1332
1333         Update bot assignments.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/config.json:
1336
1337 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1338
1339         Integrate WP python server into WebKit test framework
1340         https://bugs.webkit.org/show_bug.cgi?id=127094
1341
1342         Reviewed by Ryosuke Niwa.
1343
1344         This patch adds W3C web server (wptserver) as a new HTTP server.
1345         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1346         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1347
1348         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1349         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1350         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1351
1352         * Scripts/webkitpy/common/system/executive_mock.py:
1353         (MockProcess.communicate):
1354         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1355         (LayoutTestRunner.__init__):
1356         (LayoutTestRunner.run_tests):
1357         (LayoutTestRunner.start_servers):
1358         (LayoutTestRunner.stop_servers):
1359         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1360         (LayoutTestRunnerTests._run_tests):
1361         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1362         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1363         (LayoutTestRunnerTests):
1364         (LayoutTestRunnerTests.test_servers_started):
1365         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1366         (Manager.__init__):
1367         (Manager._is_http_test):
1368         (Manager._is_web_platform_test):
1369         (Manager._run_tests):
1370         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1371         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1372         (ManagerTest.test_needs_servers.get_manager):
1373         (ManagerTest.test_needs_servers):
1374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1375         (parse_args):
1376         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1377         (main):
1378         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1379         (doc_root):
1380         (base_url):
1381         (WebPlatformTestServer):
1382         (WebPlatformTestServer.__init__):
1383         (WebPlatformTestServer._set_start_cmd):
1384         (WebPlatformTestServer._copy_webkit_test_files):
1385         (WebPlatformTestServer._clean_webkit_test_files):
1386         (WebPlatformTestServer._prepare_config):
1387         (WebPlatformTestServer._spawn_process):
1388         (WebPlatformTestServer._stop_running_server):
1389         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1390         (TestWebPlatformTestServer):
1391         (TestWebPlatformTestServer.test_start_cmd):
1392         * Scripts/webkitpy/port/base.py:
1393         (Port.__init__):
1394         (Port.to.start_web_platform_test_server):
1395         (Port.to):
1396         (Port.to.web_platform_test_server_doc_root):
1397         (Port.to.web_platform_test_server_base_url):
1398         (Port.to.stop_web_platform_test_server):
1399         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1400         (Driver.__init__):
1401         (Driver.is_web_platform_test):
1402         (Driver.test_to_uri):
1403         (Driver.uri_to_test):
1404         (Driver._command_from_driver_input):
1405         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1406         (DriverTest.test_test_to_uri):
1407         (DriverTest.test_uri_to_test):
1408
1409 2015-01-26  Daniel Bates  <dabates@apple.com>
1410
1411         Teach run-webkit-app --simulator how to install custom built app
1412         https://bugs.webkit.org/show_bug.cgi?id=140691
1413
1414         Reviewed by David Kilzer.
1415
1416         We should teach run-webkit-app --simulator how to install a custom built app.
1417
1418         Currently run-webkit-app --simulator can only run a system app or an app that
1419         was installed using the simctl command line tool. For convenience we should
1420         teach run-webkit-app --simulator how to install a custom built app.
1421
1422         As a side effect of this change run-safari --simulator will install and run
1423         a custom built of MobileSafari (if it exists).
1424
1425         * Scripts/webkitdirs.pm:
1426         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1427         Perl from the structure of the device.plist file.
1428         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1429         file system check to determine the plist path for a Mac app bundle.
1430         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1431         it will complain that it cannot find the file: "Domain ... does not exist".
1432         (appDisplayNameFromBundle): Ditto.
1433         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1434         until a simulator device is the specified state.
1435         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1436         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1437         the specified device.
1438         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1439         As implied by its name, this function will not return until the specified simulator
1440         device UDID is in the shutdown state.
1441         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1442         device with the specified UDID.
1443         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1444         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1445         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1446         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1447         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1448         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1449         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1450         (hasUserInstalledAppInSimulatorDevice): Added.
1451         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1452         "Booted" state.
1453         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1454         switching between a system installed app and a custom built version of the same app (e.g.
1455         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1456         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1457         as that was the only caller of this function.
1458         (bootedIOSSimulatorDevice): Deleted.
1459         (openIOSSimulator): Deleted.
1460
1461 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1462
1463         Update bot assignments.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/config.json:
1466
1467 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1468
1469         Leaks bot shouldn't run JSC tests
1470         https://bugs.webkit.org/show_bug.cgi?id=140877
1471
1472         Reviewed by Darin Adler.
1473
1474         Shaves off 48 minutes of time.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1477         (TestLeaksFactory): Slim down the leaks queue.
1478
1479         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1480         * Scripts/webkitpy/port/ios.py:
1481         (IOSSimulatorPort.print_leaks_summary):
1482         * Scripts/webkitpy/port/mac.py:
1483         (MacPort.print_leaks_summary):
1484         Don't yell when leaks are detected.
1485
1486 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1487
1488         Refactor run-javascriptcore-tests
1489         https://bugs.webkit.org/show_bug.cgi?id=140824
1490
1491         Reviewed by Darin Adler.
1492
1493         Separated mozilla, stress test code paths and
1494         determining skipped mozilla tests into subroutines.
1495
1496         * Scripts/run-javascriptcore-tests:
1497         (runMozillaTests):
1498         (runJSCStressTests):
1499         (defaultJsDriverArgsForMozillaTests):
1500
1501 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1502
1503         [buildbot] Fix grammar of TestWithFailureCount
1504         https://bugs.webkit.org/show_bug.cgi?id=140884
1505
1506         Reviewed by Alexey Proskuryakov.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1509         (TestWithFailureCount):
1510         (TestWithFailureCount.commandComplete):
1511         (TestWithFailureCount.getText2):
1512         (RunUnitTests):
1513         (RunPythonTests):
1514         (RunPerlTests):
1515         (RunLLINTCLoopTests):
1516         (Run32bitJSCTests):
1517         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1518         (RunLLINTCLoopTestsTest.test_failure):
1519         (Run32bitJSCTestsTest.test_failure):
1520         (RunUnitTestsTest.assertFailures):
1521
1522 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1523
1524         Unreviewed. Moving myself to the committer section.
1525
1526         * Scripts/webkitpy/common/config/contributors.json:
1527
1528 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1529
1530         [GTK] gtkdoc does not appear in DevHelp
1531         https://bugs.webkit.org/show_bug.cgi?id=139369
1532
1533         Reviewed by Philippe Normand.
1534
1535         * gtk/generate-gtkdoc: Create the generators in the main function
1536         and use them to get the local cross renference dependencies. Also
1537         pass the generator module name to webkitdom.write_doc_files().
1538         (get_gtkdoc_module_paths): Receive a list of local cross reference
1539         dependencies.
1540         (get_generator_for_config): Set the main_sgml_file property of the
1541         GtkDoc object from the configuration file.
1542         (generate_documentation): Generate the documentation for the given
1543         generator.
1544         (generate_documentation_for_config): Deleted.
1545         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1546         * gtk/webkitdom.py:
1547         (write_doc_files): Receive the module name used to build the
1548         -sections.txt filename.
1549
1550 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1551
1552         Unreviewed, rolling out r179107.
1553         https://bugs.webkit.org/show_bug.cgi?id=140880
1554
1555         The GCC in the bots doesn't support the AsyncTask
1556         implementation (Requested by KaL on #webkit).
1557
1558         Reverted changeset:
1559
1560         "[GTK] Enable IndexedDB"
1561         https://bugs.webkit.org/show_bug.cgi?id=98932
1562         http://trac.webkit.org/changeset/179107
1563
1564 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1565
1566         [EFL] Bump libseccomp version to 2.1.1
1567         https://bugs.webkit.org/show_bug.cgi?id=140357
1568
1569         Reviewed by Gyuyoung Kim.
1570
1571         * efl/jhbuild.modules:
1572
1573 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1574
1575         [GTK] Enable IndexedDB
1576         https://bugs.webkit.org/show_bug.cgi?id=98932
1577
1578         Reviewed by Žan Doberšek.
1579
1580         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1581
1582 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1583
1584         Would like leaks bot results at build.webkit.org/dashboard
1585         https://bugs.webkit.org/show_bug.cgi?id=122657
1586
1587         Reviewed by Darin Adler.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1590         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1591         than necessary, could use the ones from buildbot in more places.
1592
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1594         (BuildbotQueue): Reflect configuration option for leaks queues.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1597         Add leaks queues to performance column. First, leaks are about performance indeed,
1598         and second, this is where we have some space to spare.
1599
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1601         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1602         least a year.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1605         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1606         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1607         results - once the results are loaded, all rows are currently higher than that.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1610         (.leaks-popover): Added.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1613         Added.
1614
1615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1616         Load BuildbotLeaksQueueView.js.
1617
1618 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1619
1620         [Win] Add WebKit message loop interface.
1621         https://bugs.webkit.org/show_bug.cgi?id=140857
1622
1623         Reviewed by Brent Fulgham.
1624
1625         Added message loop interface which will run the message loop,
1626         and perform required tasks (like calling CFRunLoopRunInMode)
1627         on each iteration of the loop.
1628
1629         * WinLauncher/WinMain.cpp:
1630         (wWinMain): Use new message loop interface.
1631
1632 2015-01-24  Dan Bernstein  <mitz@apple.com>
1633
1634         update-webkit’s --internal option is unused
1635         https://bugs.webkit.org/show_bug.cgi?id=140861
1636
1637         Reviewed by Anders Carlsson.
1638
1639         * Scripts/update-webkit: Removed the option.
1640
1641 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1642
1643         DumpRenderTree needs to run with Windows native controls on Windows
1644         https://bugs.webkit.org/show_bug.cgi?id=25592
1645
1646         Reviewed by Anders Carlsson.
1647
1648         * DumpRenderTree/win/DumpRenderTree.cpp:
1649         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1650         (prepareConsistentTestingEnvironment): Ditto.
1651
1652 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1653
1654         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1655         <http://webkit.org/b/140787>
1656
1657         Reviewed by Daniel Bates.
1658
1659         * Scripts/webkitpy/port/ios.py:
1660         (IOSPort.determine_full_port_name): Instead of checking the type
1661         of the current host, test if /usr/bin/xcrun exists before trying
1662         to use it.
1663
1664 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1665
1666         Fix the false positive build failures on the Windows buildbots
1667         https://bugs.webkit.org/show_bug.cgi?id=140819
1668
1669         Reviewed by Brent Fulgham.
1670
1671         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1672         the default 20 minutes is enough for others since they produce output during the build.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1675         (BuildFactory.__init__):
1676
1677 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1678
1679         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1680         https://bugs.webkit.org/show_bug.cgi?id=140839
1681
1682         Reviewed by Dean Jackson.
1683
1684         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1685         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1686         from the IA2Locale structure and pass it to DRT.
1687
1688 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1689
1690         [Win] Update DRT Accessibility implementation to better match Mac.
1691         https://bugs.webkit.org/show_bug.cgi?id=140830
1692
1693         Reviewed by Dean Jackson.
1694
1695         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1696         (AccessibilityUIElement::titleUIElement):
1697         (AccessibilityUIElement::parentElement):
1698         (convertToDRTLabel):
1699         (AccessibilityUIElement::role):
1700         (AccessibilityUIElement::title):
1701         (AccessibilityUIElement::description):
1702         (AccessibilityUIElement::stringValue):
1703         (AccessibilityUIElement::helpText):
1704         (AccessibilityUIElement::isFocused):
1705
1706 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1707
1708         REGRESSION: run-perf-tests --profiler= seems to have broken
1709         https://bugs.webkit.org/show_bug.cgi?id=113528
1710
1711         Reviewed by Daniel Bates.
1712
1713         The problem is that "perf --record" (or the equivalent call for
1714         other profilers) is never called whenever there is a wrapper
1715         option in the port. We should inject the profiler call first
1716         (should it exists) and then use the port wrapper.
1717
1718         * Scripts/webkitpy/port/driver.py:
1719         (Driver._command_wrapper):
1720         * Scripts/webkitpy/port/driver_unittest.py:
1721         (DriverTest.test_profiler_and_wrapper): New unit test.
1722
1723 2015-01-22  David Kilzer  <ddkilzer@apple.com>
1724
1725         configure-xcode-for-ios-development needs to import webkitdirs.pm
1726         <http://webkit.org/b/140704>
1727
1728         Fixes the following runtime error:
1729
1730             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
1731
1732         * Scripts/configure-xcode-for-ios-development: Add back code to
1733         import webkitdirs.pm for the exitStatus() method.  Not sure why
1734         I removed it before patch review.
1735
1736 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
1737
1738         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
1739         https://bugs.webkit.org/show_bug.cgi?id=140795
1740
1741         Reviewed by Jon Honeycutt.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/config.json:
1744         r178847 accidentally remove the scheduler for this bot. Re-add it to the
1745         Yosemite scheduler.
1746
1747 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
1748
1749         [Win] Expose missing editing features through WebView interface
1750         https://bugs.webkit.org/show_bug.cgi?id=140773
1751         <rdar://problem/19565421>
1752
1753         Reviewed by Dean Jackson.
1754
1755         Connect the various WebView editing delegate methods to our
1756         test infrastructure. Also prefer _bstr_t to raw BSTR types
1757         to simplify life cycle management.
1758
1759         * DumpRenderTree/win/DumpRenderTree.cpp:
1760         (resetWebViewToConsistentStateBeforeTesting):
1761         * DumpRenderTree/win/EditingDelegate.cpp:
1762         (EditingDelegate::QueryInterface):
1763         (dumpPath):
1764         (dump):
1765         (EditingDelegate::shouldBeginEditingInDOMRange):
1766         (EditingDelegate::shouldEndEditingInDOMRange):
1767         (EditingDelegate::shouldInsertNode):
1768         (EditingDelegate::shouldInsertText):
1769         (EditingDelegate::shouldDeleteDOMRange):
1770         (EditingDelegate::shouldChangeSelectedDOMRange):
1771         (EditingDelegate::shouldApplyStyle):
1772         (EditingDelegate::shouldChangeTypingStyle):
1773         (EditingDelegate::doPlatformCommand):
1774         (EditingDelegate::webViewDidBeginEditing):
1775         (EditingDelegate::webViewDidChange):
1776         (EditingDelegate::webViewDidEndEditing):
1777         (EditingDelegate::webViewDidChangeTypingStyle):
1778         (EditingDelegate::webViewDidChangeSelection):
1779         (EditingDelegate::checkSpellingOfString):
1780         (EditingDelegate::onNotify):
1781         * DumpRenderTree/win/EditingDelegate.h:
1782
1783 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1784
1785         Add a build flag for ES6 class syntax
1786         https://bugs.webkit.org/show_bug.cgi?id=140760
1787
1788         Reviewed by Michael Saboff.
1789
1790         * Scripts/webkitperl/FeatureList.pm:
1791
1792 2015-01-22  Daniel Bates  <dabates@apple.com>
1793
1794         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
1795         runtime in simctl output
1796         https://bugs.webkit.org/show_bug.cgi?id=140751
1797
1798         Reviewed by David Kilzer.
1799
1800         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
1801         with an error because it does not know how to parse the output of the simctl tool
1802         to identify an Apple Internal runtime.
1803
1804         * Scripts/webkitpy/xcode/simulator.py:
1805         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
1806         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
1807         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
1808         the runtime is an internal runtime.
1809         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
1810         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
1811         appropriate value.
1812         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
1813         it updates the appropriate Runtime object.
1814         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
1815         looking up a Runtime object for an internal runtime.
1816
1817 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
1818
1819         LeaksViewer doesn't show recent builds if there are less than 10
1820         https://bugs.webkit.org/show_bug.cgi?id=140716
1821
1822         Reviewed by Tim Horton.
1823
1824         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1825
1826 2015-01-22  Lucas Forschler  <lforschler@apple.com>
1827
1828         Add Apple build slaves.
1829         Fixed text alignment for slave list.
1830         
1831         Unreviewed.
1832         
1833         * BuildSlaveSupport/build.webkit.org-config/config.json:
1834
1835 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1836
1837         Teach build.webkit.org about bot308 and bot309.
1838         
1839         Unreviewed.
1840         
1841         * BuildSlaveSupport/build.webkit.org-config/config.json:
1842
1843 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1844
1845         Add two Apple Mavericks slaves.
1846         
1847         Unreviewed.
1848         
1849         * BuildSlaveSupport/build.webkit.org-config/config.json:
1850
1851 2015-01-21  Daniel Bates  <dabates@apple.com>
1852
1853         Add iOS WebKit1 TestExpectation file
1854         https://bugs.webkit.org/show_bug.cgi?id=140739
1855
1856         Reviewed by David Kilzer.
1857
1858         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
1859         expectations in directory LayoutTests/platform/ios-simulator-wk1.
1860
1861         * Scripts/webkitpy/port/ios.py:
1862         (IOSSimulatorPort.default_baseline_search_path):
1863
1864 2015-01-21  David Kilzer  <ddkilzer@apple.com>
1865
1866         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
1867         <http://webkit.org/b/140704>
1868
1869         Reviewed by Daniel Bates.
1870
1871         * Scripts/configure-xcode-for-ios-development:
1872         - Update copyright.
1873         - Remove FIXME addressed by r178709.
1874         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
1875         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
1876         missing headers from iphonesimulator SDK to iphoneos SDK.
1877         (sdkDirectory): Add method that returns SDK directory.
1878         (sdkPlatformDirectory): Extract method from
1879         xcodeSDKSpecificationsPath() that returns SDK platform
1880         directory.
1881         (xcodeSDKSpecificationsPath): Update to use
1882         sdkPlatformDirectory().
1883
1884 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
1885
1886         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
1887         https://bugs.webkit.org/show_bug.cgi?id=140731
1888
1889         Reviewed by Tim Horton.
1890
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1892         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
1893
1894 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
1895
1896         [Win] eventSender does not support scalePageBy
1897         https://bugs.webkit.org/show_bug.cgi?id=140726
1898         <rdar://problem/19549865>
1899
1900         Reviewed by Dean Jackson.
1901
1902         * DumpRenderTree/win/EventSender.cpp:
1903         (scalePageByCallback): Provide implementation using new WebView method.
1904
1905 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1906
1907         Remove Apple Mountain Lion Build & Test slaves.
1908         
1909         Unreviewed.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/config.json:
1912
1913 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1914
1915         Remove ENABLE(INSPECTOR) ifdef guards
1916         https://bugs.webkit.org/show_bug.cgi?id=140668
1917
1918         Reviewed by Darin Adler.
1919
1920         * DumpRenderTree/mac/TestRunnerMac.mm:
1921         (TestRunner::showWebInspector):
1922         (TestRunner::closeWebInspector):
1923         (TestRunner::evaluateInWebInspector):
1924         * Scripts/webkitperl/FeatureList.pm:
1925         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1926         (WTR::TestRunner::showWebInspector):
1927         (WTR::TestRunner::closeWebInspector):
1928         (WTR::TestRunner::evaluateInWebInspector):
1929         * WebKitTestRunner/TestInvocation.cpp:
1930         (WTR::TestInvocation::invoke):
1931
1932 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
1933
1934         Update build.webkit.org/dashboard to match current Mac queues.
1935
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1943         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
1944         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
1945
1946 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1947
1948         Update Apple MountainLion Leaks slave to Yosemite
1949         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
1950         
1951         Unreviewed.
1952
1953         * BuildSlaveSupport/build.webkit.org-config/config.json:
1954
1955 2015-01-20  Lucas Forschler  <lforschler@apple.com>
1956
1957         Update LeaksViewer from MountainLion to Yosemite
1958         
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1962         (LeaksViewer._displayURLPrompt):
1963
1964 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
1965
1966         Fix EWS python unit tests and address code comments as per 140476
1967         https://bugs.webkit.org/show_bug.cgi?id=140637
1968
1969         Reviewed by David Kilzer.
1970
1971         * Scripts/webkitpy/port/base.py:
1972         (Port):
1973         (Port.__init__):
1974         Adds DEFAULT_ARCHITECTURE member.
1975         (Port.architecture):
1976         Removes architecture member and instead uses
1977         self.get_option('architecture'). Also removes redundant architecture
1978         method.
1979         (Port.set_architecture):
1980         Adds a setter for the architecture variable to be able to set a flag
1981         upon modification.
1982         (Port.test_configuration):
1983         Uses self.architecture() instead of self._architecture.
1984         * Scripts/webkitpy/port/ios.py:
1985         Overrides DEFAULT_ARCHITECTURE.
1986         (IOSPort):
1987         (IOSPort.determine_full_port_name):
1988         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
1989         strip. Fixes regex to not match arbitrary characters after the
1990         relevent digits are matched.
1991         (IOSPort.__init__):
1992         Removes old _architecture defaulting strategy.
1993         (IOSPort._build_driver_flags):
1994         Uses self.architecture() instead of self._architecture.
1995         (IOSSimulatorPort):
1996         Overrides DEFAULT_ARCHITECTURE.
1997         (IOSSimulatorPort.__init__):
1998         Removes old _architecture defaulting strategy.
1999         * Scripts/webkitpy/port/mac.py:
2000         (MacPort):
2001         Overrides DEFAULT_ARCHITECTURE.
2002         (MacPort.__init__):
2003         Removes old _architecture defaulting strategy.
2004         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2005         (AbstractEarlyWarningSystem.run_command):
2006         Checks the did_override_architecture flag to determine whether to add
2007         the --architecture option.
2008         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2009         Uses ews.architecture rather than trying to discern the correct
2010         architecture using a port object.
2011         (EarlyWarningSystemTest._default_expected_logs):
2012         * Scripts/webkitpy/tool/commands/queues.py:
2013         Removes use of optparse, and removes the import statement.
2014         (AbstractQueue.__init__):
2015         (PatchProcessingQueue.begin_work_queue):
2016
2017 2015-01-20  Sam Weinig  <sam@webkit.org>
2018
2019         Attempt to fix Mountain Lion and EFL tests.
2020
2021         * WebKitTestRunner/TestController.cpp:
2022         (WTR::TestController::initialize):
2023         Disable Process-per-tab and network process on Mountain Lion and EFL.
2024
2025 2015-01-20  Darin Adler  <darin@apple.com>
2026
2027         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2028         https://bugs.webkit.org/show_bug.cgi?id=140679
2029
2030         Reviewed by Anders Carlsson.
2031
2032         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2033         Removed a reference to SVGElementInstanceList.
2034
2035 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2036
2037         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2038         https://bugs.webkit.org/show_bug.cgi?id=140028
2039
2040         Reviewed by Carlos Garcia Campos.
2041
2042         This won't work as expected, since this function is called before the
2043         WebViewTest constructor completes.
2044
2045         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2046
2047 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2048
2049         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2050         <http://webkit.org/b/140661>
2051
2052         Reviewed by Daniel Bates.
2053
2054         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2055         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2056         "iphoneos" and "iphonesimulator" SDKs.
2057         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2058         the main body of the script.
2059
2060 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2061
2062         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2063         https://bugs.webkit.org/show_bug.cgi?id=139443
2064
2065         Reviewed by Carlos Garcia Campos.
2066
2067         Create the new test cases for setting the editable property on the web
2068         view and on the contenteditable enabled document. Also rework the
2069         current tests that are expecting that the web view is editable.
2070
2071         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2072         (loadTestHtml):
2073         (testWebViewEditorCutCopyPasteNonEditable):
2074         (testWebViewEditorCutCopyPasteEditable):
2075         (testWebViewEditorSelectAllNonEditable):
2076         (testWebViewEditorSelectAllEditable):
2077         (runEditorEditableCutTests):
2078         (testWebViewEditorEditableOnNonEditable):
2079         (testWebViewEditorEditableOnContentEditable):
2080         (testWebViewEditorNonEditable):
2081         (beforeAll):
2082         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2083         (WebViewTest::isEditable):
2084         (WebViewTest::setEditable):
2085
2086 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2087
2088         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2089         https://bugs.webkit.org/show_bug.cgi?id=140617
2090
2091         Reviewed by Gustavo Noronha Silva.
2092
2093         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2094         (testWebViewSnapshot): Check that the same snapshot with
2095         transparent background is different than the default one filled
2096         with white.
2097
2098 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2099
2100         [GTK] Add API to change the WebKitWebView background color
2101         https://bugs.webkit.org/show_bug.cgi?id=140610
2102
2103         Reviewed by Gustavo Noronha Silva.
2104
2105         Add --bg-color command line option to MiniBrowser to be able to
2106         manually test the API passing any RGBA color to MiniBrowser.
2107         Also add a simple unit test to check that getting and setting
2108         colors from the API point of view.
2109
2110         * MiniBrowser/gtk/BrowserWindow.c:
2111         (browser_window_set_background_color):
2112         * MiniBrowser/gtk/BrowserWindow.h:
2113         * MiniBrowser/gtk/main.c:
2114         (createBrowserWindow):
2115         (parseBackgroundColor):
2116         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2117         (testWebViewBackgroundColor):
2118         (beforeAll):
2119
2120 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2121
2122         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2123         https://bugs.webkit.org/show_bug.cgi?id=140665
2124
2125         Reviewed by Brian Burg.
2126
2127         * DumpRenderTree/win/UIDelegate.cpp:
2128         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2129         match expected test output.
2130
2131 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2132
2133         Remove the support for custom suffixes on ChangeLog
2134         https://bugs.webkit.org/show_bug.cgi?id=140648
2135
2136         Reviewed by David Kilzer.
2137
2138         Custom suffixes were used for the iOS branch of WebKit.
2139         Now that everything is opensource, there is no need for it.
2140
2141         * Scripts/VCSUtils.pm:
2142         (changeLogSuffix): Deleted.
2143         (changeLogFileName): Deleted.
2144         * Scripts/commit-log-editor:
2145         * Scripts/prepare-ChangeLog:
2146         (getLatestChangeLogs):
2147         (generateNewChangeLogs):
2148         (generateFileList):
2149         * Scripts/resolve-ChangeLogs:
2150         (findChangeLog):
2151
2152 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2153
2154         Adjust naming of action menu SPI
2155         https://bugs.webkit.org/show_bug.cgi?id=140644
2156         <rdar://problem/19448129>
2157
2158         Reviewed by Brian Weinstein.
2159
2160         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2161         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2162         (TestWebKitAPI::TEST):
2163
2164 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2165
2166         [GTK] Generate the make dist manifest from a CMake template file
2167         https://bugs.webkit.org/show_bug.cgi?id=139387
2168
2169         Reviewed by Martin Robinson.
2170
2171         Remove the code that performs variable substitution on manifest.txt.
2172         Replace the custom variables used in that file with CMake variables.
2173
2174         * gtk/make-dist.py:
2175         (Manifest.add_directory):
2176         (Manifest.get_full_source_path):
2177         (Manifest.process_line):
2178         (Manifest.resolve_variables): Deleted.
2179         (Manifest.get_full_tarball_path): Deleted.
2180         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2181
2182 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2183
2184         [Win] Correct merge error in last commit.
2185
2186         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2187         (findAccessibleObjectById): Undo accidental paste made during landing.
2188
2189 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2190
2191         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2192         https://bugs.webkit.org/show_bug.cgi?id=139906
2193
2194         Reviewed by Dean Jackson.
2195
2196         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2197         to use them. This patch fixes that.
2198
2199         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2200         (findAccessibleObjectById):
2201         (AccessibilityController::focusedElement):
2202         (logEventProc):
2203         (notificationListenerProc):
2204         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2205         (AccessibilityUIElement::getChildAtIndex):
2206         (AccessibilityUIElement::titleUIElement):
2207         (self):
2208         (AccessibilityUIElement::role):
2209         (AccessibilityUIElement::valueDescription):
2210         (accessibilityState):
2211         (AccessibilityUIElement::isChecked):
2212         * DumpRenderTree/win/DumpRenderTree.cpp:
2213         (dumpFrameScrollPosition):
2214         (dumpFramesAsText):
2215         * DumpRenderTree/win/PolicyDelegate.cpp:
2216         (PolicyDelegate::decidePolicyForNavigationAction):
2217         * DumpRenderTree/win/UIDelegate.cpp:
2218         (UIDelegate::exceededDatabaseQuota):
2219         * WinLauncher/Common.cpp:
2220         (setWindowText):
2221
2222 2015-01-19  Dean Jackson  <dino@apple.com>
2223
2224         Add "override" to fix the build with newer clangs.
2225
2226         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2227         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2228
2229 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2230
2231         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2232         <http://webkit.org/b/140623>
2233
2234         Reviewed by Daniel Bates.
2235
2236         * Scripts/build-webkit: Update help for --device switch.
2237         * Scripts/webkitdirs.pm:
2238         (determineXcodeSDK): When passing --device, prefer the internal
2239         iOS SDK if it exists, else fall back to the external iOS SDK.
2240         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2241         xcodebuild instead of trying to sanitize values.
2242
2243 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2244
2245         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2246         https://bugs.webkit.org/show_bug.cgi?id=140606
2247
2248         Reviewed by Csaba Osztrogonác.
2249
2250         * Scripts/webkitpy/bindings/main.py:
2251         (BindingsTests.generate_supplemental_dependency):
2252         (BindingsTests.main):
2253
2254 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2255
2256         [GTK] [WK2] TestWebKitWebView snapshot fails
2257         https://bugs.webkit.org/show_bug.cgi?id=120404
2258
2259         Reviewed by Žan Doberšek.
2260
2261         Rework the test to make sure the snapshot is always created at the
2262         desired size.
2263
2264         * Scripts/run-gtk-tests:
2265         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2266         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2267         (testWebViewSnapshot): Use a fixed size for the document, and
2268         disable scrollbars to make sure the visible area is always the
2269         WebView size.
2270         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2271         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2272         and height parameters to create the window with a given size.
2273         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2274
2275 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2276
2277         iOS EWS queue name should be consistent
2278         <http://webkit.org/b/140585>
2279
2280         Reviewed by Daniel Bates.
2281
2282         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2283         to 'ios'.
2284         * Scripts/webkitpy/common/config/ports.py: Ditto.
2285         (DeprecatedPort.port):
2286         (IOSPort):
2287         * Scripts/webkitpy/port/ios.py: Ditto.
2288         (IOSPort):
2289
2290         * Scripts/webkitpy/port/factory.py:
2291         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2292         appears before ios.IOSPort.  If this is not done,
2293         `run-webkit-tests --ios-simulator` will get the wrong Port class
2294         (IOSPort instead of IOSSimulatorPort) due to the way that
2295         PortFactory.get() uses prefix matching of <Port>.port_name to
2296         find the correct class to use.
2297
2298 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2299
2300         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2301         https://bugs.webkit.org/show_bug.cgi?id=140595
2302
2303         Reviewed by Csaba Osztrogonác.
2304
2305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2306         (BubbleQueueServer):
2307
2308 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2309
2310         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2311
2312         * Scripts/webkitpy/port/ios.py:
2313         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2314         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2315         the Mountain Lion and Mavericks bots.
2316
2317 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2318
2319         Attempt to fix webkitpy tests on GTK Linux ports
2320
2321         * Scripts/webkitpy/port/ios.py:
2322         (IOSPort.determine_full_port_name): Set a sensible default if
2323         not running on a Mac platform or if no iOS SDK is installed.
2324
2325 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2326
2327         Create iOS-EWS client queue
2328         https://bugs.webkit.org/show_bug.cgi?id=140476
2329
2330         Reviewed by Alexey Proskuryakov.
2331
2332         * EWSTools/start-queue-mac.sh:
2333         Adds call to configure-xcode-for-ios-development for iOS EWS.
2334         * Scripts/webkitpy/common/config/ews.json:
2335         Adds the iOS EWS config entry.
2336         * Scripts/webkitpy/common/config/ports.py:
2337         (DeprecatedPort.port):
2338         Adds IOSPort to the port map.
2339         (IOSPort):
2340         (IOSPort.build_webkit_command):
2341         Adds --sdk=iphoneos to the webkit build command.
2342         * Scripts/webkitpy/port/base.py:
2343         (Port.architecture):
2344         Adds an accessor for the architecture member variable.
2345         * Scripts/webkitpy/port/factory.py:
2346         (PortFactory):
2347         Adds IOSPort to the port class list.
2348         * Scripts/webkitpy/port/ios.py:
2349         Adds the IOSPort to encapsulate iOS-specific things.
2350         (IOSPort):
2351         (IOSPort.determine_full_port_name):
2352         (IOSPort.__init__):
2353         (IOSPort._build_driver_flags):
2354         (IOSPort.operating_system):
2355         * Scripts/webkitpy/tool/commands/download_unittest.py:
2356         Adds the archetecture option to the mock options.
2357         (DownloadCommandsTest._default_options):
2358         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2359         Appends the archetecture option into calls to webkit-patch.
2360         (AbstractEarlyWarningSystem.review_patch):
2361         (AbstractEarlyWarningSystem.run_command):
2362         (AbstractEarlyWarningSystem.load_ews_classes):
2363         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2364         Adds logic to soothe the unittest now that --architecture is being
2365         thrown around everywhere.
2366         (EarlyWarningSystemTest._default_expected_logs):
2367         * Scripts/webkitpy/tool/commands/queues.py:
2368         Adds glue code to ferry the --architecture option around.
2369         (AbstractQueue.__init__):
2370         (PatchProcessingQueue.begin_work_queue):
2371         * Scripts/webkitpy/tool/steps/abstractstep.py:
2372         Adds the archetecture option to all AbstractSteps so that
2373         EarlyWarningSystem doesn't start shoving --architecture into
2374         unsuspecting commands.
2375         (AbstractStep.options):
2376         * Scripts/webkitpy/tool/steps/build.py:
2377         Translates the --architecture option into an ARCHS= format to pass to
2378         build-webkit.
2379         (Build.build):
2380         * Scripts/webkitpy/tool/steps/options.py:
2381         Adds a definition for the --architecture option.
2382         (Options):
2383
2384 2015-01-16  Sam Weinig  <sam@webkit.org>
2385
2386         Add a basic configuration object for WKView
2387         https://bugs.webkit.org/show_bug.cgi?id=140559
2388
2389         Reviewed by Anders Carlsson.
2390
2391         Add tests for WKPageConfigurationRef.
2392
2393         * TestWebKitAPI/PlatformWebView.h:
2394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2395         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2396         (TestWebKitAPI::TEST):
2397         (TestWebKitAPI::didFinishLoadForFrame):
2398         (TestWebKitAPI::setPageLoaderClient):
2399         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2400         (TestWebKitAPI::PlatformWebView::initialize):
2401         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2402
2403 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2404
2405         WeakPtr functions crash when created with default constructor
2406         https://bugs.webkit.org/show_bug.cgi?id=140479
2407
2408         Reviewed by Andreas Kling.
2409
2410         Add WeakPtr API tests.
2411
2412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2413         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2414         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2415
2416 2015-01-16  Chris Dumez  <cdumez@apple.com>
2417
2418         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2419         https://bugs.webkit.org/show_bug.cgi?id=140568
2420
2421         Reviewed by Alexey Proskuryakov.
2422
2423         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2424         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2425         e.g. "Longhands=background-position-x|background-position-y".
2426         This would confuse the script and treat this as a CSS property:
2427         "background-position-x|background-position-y".
2428
2429         We now split on white space and treat the first string on the line
2430         to be the property name (this is the syntax in this file).
2431
2432         * Scripts/webkitpy/w3c/test_converter.py:
2433         (_W3CTestConverter.__init__):
2434         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2435
2436 2015-01-16  Daniel Bates  <dabates@apple.com>
2437
2438         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2439         https://bugs.webkit.org/show_bug.cgi?id=135589
2440
2441         Reviewed by David Kilzer.
2442
2443         Derived from a patch by David Farler.
2444
2445         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2446         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2447         in terms of the simctl command line utility.
2448
2449         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2450         (eraseIOSSimulatorDevice): Added.
2451         (bootedIOSSimulatorDevice): Added.
2452         (iosSimulatorApplicationsPath): Added.
2453         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2454         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2455         (quitIOSSimulator): Added.
2456         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2457         the specified name and currently selected iOS runtime.
2458         (isIOSSimulatorSystemInstalledApp): Added.
2459         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2460         (deleteiOSSimulatorDevice): Deleted.
2461         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2462         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2463
2464 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2465
2466         Resurrect the WinCairo bot.
2467         https://bugs.webkit.org/show_bug.cgi?id=139908
2468
2469         Reviewed by Csaba Osztrogonác.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/config.json:
2472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2473         (appendCustomBuildFlags):
2474         * BuildSlaveSupport/test-result-archive:
2475         (archiveTestResults):
2476         Add WinCairo buildbot.
2477
2478 2015-01-16  Chris Dumez  <cdumez@apple.com>
2479
2480         webkit-patch should auto-install the keyring python module
2481         https://bugs.webkit.org/show_bug.cgi?id=140547
2482
2483         Reviewed by David Kilzer.
2484
2485         Auto-install the keyring python module. This is the module that
2486         webkit-patch uses for cross-platform access to the keyring
2487         service.
2488
2489         Without this module, if the password if not in the keychain,
2490         webkit-patch will keep asking for your username / password and
2491         never remember them.
2492
2493         * Scripts/webkitpy/common/net/credentials.py:
2494         * Scripts/webkitpy/thirdparty/__init__.py:
2495         (AutoinstallImportHook.find_module):
2496         (AutoinstallImportHook._install_keyring):
2497
2498 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2499
2500         Remove ENABLE(SQL_DATABASE) guards
2501         https://bugs.webkit.org/show_bug.cgi?id=140434
2502
2503         Reviewed by Darin Adler.
2504
2505         * Scripts/webkitperl/FeatureList.pm:
2506
2507 2015-01-15  Daniel Bates  <dabates@apple.com>
2508
2509         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2510         https://bugs.webkit.org/show_bug.cgi?id=139685
2511         <rdar://problem/19281317>
2512
2513         Reviewed by Simon Fraser.
2514
2515         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2516         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2517
2518         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2519         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2520         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2521         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2522         dumping the test result again. Instead we want DRT to dump the test result synchronously
2523         such that we capture the state of the web page either when the page is loaded or when
2524         window.testRunner.notifyDone() is called.
2525
2526         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2527         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2528         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2529         flush CA transactions to the window.
2530         * DumpRenderTree/mac/DumpRenderTree.mm:
2531         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2532         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2533         (dump): Renamed; formerly named dumpTestResults().
2534         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2535         enabling repaint support on iOS.
2536         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2537         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2538         (dumpTestResults): Deleted.
2539
2540 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2541
2542         [Win] Miscellaneous DRT fixes
2543         https://bugs.webkit.org/show_bug.cgi?id=116562
2544
2545         Reviewed by Tim Horton.
2546
2547         While investigating the cause of several Windows crashes, I found:
2548         (1) Messy conversions to and from BSTR types
2549         (2) Weird mixes of wide-string and narrow string conversions
2550         (3) Passing nullptr to some CoreFoundation routines that do not
2551             permit null arguments.
2552         (4) Commands to link the executable to the VS2005 runtime.
2553
2554         This patch cleans up these issues to improve DRT reliability on
2555         Windows.
2556
2557         * DumpRenderTree/cg/ImageDiffCG.cpp:
2558         (main): Get rid of VS2005 runtime linking.
2559         * DumpRenderTree/win/DumpRenderTree.cpp:
2560         (urlSuitableForTestResult): Protect against being asked
2561         to process an empty URL.
2562         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2563         than converting to/from wchar_t buffers.
2564         (runTest): Simplify string and BSTR handling.
2565         (createWebViewAndOffscreenWindow): Ditto.
2566         (main): Get rid of VS2005 runtime linking.
2567         * DumpRenderTree/win/TestRunnerWin.cpp:
2568         (jsStringRefToWString): Simplify code.
2569         (TestRunner::pathToLocalResource):
2570         (TestRunner::setUserStyleSheetLocation):
2571         * TestWebKitAPI/win/main.cpp: Get rid of
2572         VS2005 runtime linking.
2573         * win/DLLLauncher/DLLLauncherMain.cpp:
2574         (wWinMain): Ditto.
2575
2576 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2577
2578         Stop hardcoding mac-mountainlion in commit queue
2579         https://bugs.webkit.org/show_bug.cgi?id=140492
2580
2581         Reviewed by Anders Carlsson.
2582
2583         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2584         there should be no change in behavior, because:
2585         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2586         using it to create a port object.
2587         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2588         is actually correct to use "mac" for the name there. We only used to get the expected
2589         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2590         for unknown deprecated port names.
2591
2592         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2593
2594 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2595
2596         Create iOS-EWS server queue
2597         https://bugs.webkit.org/show_bug.cgi?id=140473
2598
2599         Reviewed by Benjamin Poulain.
2600
2601         * QueueStatusServer/app.yaml: Updates the SVN version number.
2602         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2603         * QueueStatusServer/model/queues.py:         
2604         (Queue.display_name): Makes sure the display name is pretty!
2605
2606 2015-01-14  Daniel Bates  <dabates@apple.com>
2607
2608         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2609         https://bugs.webkit.org/show_bug.cgi?id=140301
2610         <rdar://problem/19389266>
2611
2612         Reviewed by Jon Honeycutt.
2613
2614         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2615         with an unavailable runtime.
2616
2617         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2618         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2619         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2620         specified runtime cannot be used because it is unavailable.
2621         * Scripts/webkitpy/port/ios.py:
2622         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2623         which was formerly named testing_device.
2624         * Scripts/webkitpy/xcode/simulator.py:
2625         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2626         more robust than looking up the simulator device by name and runtime. This approach also
2627         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2628         unavailable runtimes under the same iOS heading it would use to show it as available).
2629         (Simulator.find_device_by_udid): Added.
2630         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2631         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2632         (Simulator.available_runtimes): Added.
2633         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2634         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2635         first element of the sorted list is the runtime with the highest version number.
2636         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2637
2638 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2639
2640         Remove WK2 Windows cruft
2641         https://bugs.webkit.org/show_bug.cgi?id=140440
2642
2643         Reviewed by Anders Carlsson.
2644
2645         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2646         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2647         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2648
2649 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2650
2651         Fix TestWTF failed in TestWebKitAPI
2652         https://bugs.webkit.org/show_bug.cgi?id=140333
2653
2654         Reviewed by Sam Weinig.
2655
2656         Clear the std::ostringstream before starting test.
2657
2658         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2659         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2660
2661 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2662
2663         TestWebKitWebContext depends on British English spellcheck dictionary
2664         https://bugs.webkit.org/show_bug.cgi?id=140403
2665
2666         Reviewed by Martin Robinson.
2667
2668         Install all English hunspell dictionaries on Fedora and Arch.
2669
2670         * gtk/install-dependencies:
2671
2672 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2673
2674         [GTK] install-dependencies should grok dnf
2675         https://bugs.webkit.org/show_bug.cgi?id=140396
2676
2677         Reviewed by Martin Robinson.
2678
2679         Fedora: install dependencies with dnf if yum is not installed.
2680
2681         * gtk/install-dependencies:
2682
2683 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2684
2685         [EFL][GTK] Fix build after r178309  
2686         https://bugs.webkit.org/show_bug.cgi?id=140381
2687
2688         Reviewed by Gyuyoung Kim.
2689
2690         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2691
2692 2015-01-11  Sam Weinig  <sam@webkit.org>
2693
2694         Remove support for SharedWorkers
2695         https://bugs.webkit.org/show_bug.cgi?id=140344
2696
2697         Reviewed by Anders Carlsson.
2698
2699         * Scripts/webkitperl/FeatureList.pm:
2700
2701 2015-01-12  Anders Carlsson  <andersca@apple.com>
2702
2703         Make delegates conform to formal delegate protocols
2704         https://bugs.webkit.org/show_bug.cgi?id=140370
2705
2706         Reviewed by Dan Bernstein.
2707
2708         * DumpRenderTree/mac/TestRunnerMac.mm:
2709         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2710         (TestRunner::setGeolocationPermission):
2711
2712 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2713
2714         build-webkit: silence output of 'which'
2715         https://bugs.webkit.org/show_bug.cgi?id=140278
2716
2717         Reviewed by Daniel Bates.
2718
2719         Use a more elegent test for the existance of ninja and eclipse.
2720
2721         * Scripts/webkitdirs.pm:
2722         (commandExists): Don't assume the command supports --version
2723         (canUseNinja): Use commandExists()
2724         (canUseEclipse): Use commandExists()
2725
2726 2015-01-09  Sam Weinig  <sam@webkit.org>
2727
2728         Update the output format for run-api-tests
2729         https://bugs.webkit.org/show_bug.cgi?id=140332
2730
2731         Reviewed by Dan Bernstein.
2732
2733         Changes the output format for run-api-tests be a bit simpler (no longer 
2734         indented based on suite, as we were not really using suite very well) but
2735         also include details in the case of failure.
2736
2737         Changes verbose mode to no longer spew out the gtest default printer output,
2738         as the custom printer now includes the failure information.
2739
2740         * Scripts/run-api-tests:
2741         (runTestsBySuite):
2742         (runTest):
2743         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
2744         with colorized variants and strip out leaks spew (the leaks can be added back using
2745         the new --show-leaks argument).
2746
2747         * TestWebKitAPI/TestsController.cpp:
2748         (TestWebKitAPI::Printer::OnTestPartResult):
2749         (TestWebKitAPI::Printer::OnTestEnd):
2750         (TestWebKitAPI::TestsController::run):
2751         Implement a custom result printer that just prints out the information we want.
2752
2753 2015-01-09  Sam Weinig  <sam@webkit.org>
2754
2755         TestWebKitAPI should print out the lists that fail at the end
2756         https://bugs.webkit.org/show_bug.cgi?id=140329
2757
2758         Reviewed by Tim Horton.
2759
2760         * Scripts/run-api-tests:
2761         (runTestsBySuite):
2762         Print out failures and timeouts in all modes, not just verbose.
2763
2764 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
2765
2766         Make bmalloc work with ASan
2767         https://bugs.webkit.org/show_bug.cgi?id=140194
2768
2769         Reviewed by Mark Lam.
2770
2771         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
2772         ASan automatically (by forwarding to system malloc at runtime).
2773
2774 2015-01-09  Daniel Bates  <dabates@apple.com>
2775
2776         [iOS] Make DumpRenderTree build with public SDK
2777         https://bugs.webkit.org/show_bug.cgi?id=140311
2778
2779         Reviewed by Sam Weinig.
2780
2781         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
2782         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
2783         Additionally, remove unused header CoreGraphics/CGFontDB.h.
2784
2785         * DumpRenderTree/mac/DumpRenderTree.mm:
2786         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
2787
2788 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
2789
2790         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
2791         https://bugs.webkit.org/show_bug.cgi?id=140300
2792
2793         Reviewed by Simon Fraser.
2794
2795         * WebKitTestRunner/TestController.cpp:
2796         (WTR::TestController::createOtherPage):
2797         (WTR::TestController::updateWindowScaleForTest):
2798         (WTR::TestController::configureViewForTest):
2799         * WebKitTestRunner/TestController.h:
2800
2801 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2802
2803         Unreviewed. Moving myself to the committer section.
2804
2805         * Scripts/webkitpy/common/config/contributors.json:
2806
2807 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2808
2809         Add a script to check for platform layering violations
2810         https://bugs.webkit.org/show_bug.cgi?id=140248
2811
2812         Reviewed by Darin Adler.
2813
2814         It prints all the cases where files inside platform include
2815         headers that are not in platform directory.
2816
2817         * Scripts/check-for-platform-layering-violations: Added.
2818         (get_platform_headers):
2819         (check_source_file):
2820
2821 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2822
2823         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
2824         https://bugs.webkit.org/show_bug.cgi?id=139884
2825
2826         Reviewed by Tim Horton.
2827
2828         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2829         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
2830         what the "nominal resolution" is, but this appears to work in practice.
2831
2832 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
2833
2834         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
2835         https://bugs.webkit.org/show_bug.cgi?id=140256
2836
2837         Reviewed by Anders Carlsson.
2838
2839         * DumpRenderTree/win/DumpRenderTree.cpp:
2840         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
2841         running with heap validation checks.
2842         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
2843         the "svg\\W3C-SVG-1.1" test directory.
2844         (removeFontFallbackIfPresent): Use nullptr instead of 0.
2845         * DumpRenderTree/win/TestRunnerWin.cpp:
2846         (TestRunner::clearPersistentUserStyleSheet): Ditto.
2847
2848 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2849
2850         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2851         https://bugs.webkit.org/show_bug.cgi?id=140218
2852
2853         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
2854         Undone an accidental change - check for self.has_crashed() again. This code path
2855         is for ports that don't have a signal handler printing #CRASHED when main process
2856         crashes.
2857
2858         * Scripts/webkitpy/port/driver_unittest.py:
2859         (DriverTest.test_check_for_driver_crash.assert_crash):
2860         (DriverTest.test_check_for_driver_crash):
2861         Updated the tests, all changes are expected.
2862
2863 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2864
2865         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2866         https://bugs.webkit.org/show_bug.cgi?id=140218
2867
2868         Reviewed by Darin Adler.
2869
2870         * Scripts/webkitpy/port/driver.py:
2871         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
2872         "process crashed" condition. These don't make sense together - it's either a crash
2873         or a timeout, and we should detect those properly at a much lower level.
2874         (Driver.run_test): Ditto.
2875         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
2876         cases.
2877
2878         * WebKitTestRunner/TestController.h:
2879         * WebKitTestRunner/TestController.cpp:
2880         (WTR::TestController::webProcessName): 
2881         (WTR::TestController::processDidCrash):
2882         Factored out hardcoded child process names, as we now use these in two places.
2883
2884         * WebKitTestRunner/TestInvocation.cpp:
2885         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
2886         process name, so that it can be sampled (fixes sampling on Mavericks and above).
2887
2888 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2889
2890         Reorder my list of email addresses, keeping the Bugzilla address at the
2891         top since Bugzilla and other webkitpy scripts rely on that ordering.
2892
2893         * Scripts/webkitpy/common/config/contributors.json:
2894
2895 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
2896
2897         Moving myself to the reviewers section and updating
2898         the list of my email addresses.
2899
2900         * Scripts/webkitpy/common/config/contributors.json:
2901
2902 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2903
2904         [GTK] Build gtk-doc without gtkdoc-mktmpl
2905         https://bugs.webkit.org/show_bug.cgi?id=140225
2906
2907         Reviewed by Darin Adler.
2908
2909         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
2910         don't modify the tmpl files that it generates, it's not doing anything
2911         for us.
2912
2913         * gtk/gtkdoc.py:
2914         (GTKDoc.generate):
2915         (GTKDoc._run_gtkdoc_scangobj):
2916         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
2917
2918 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
2919
2920         [GTK][ThreadedCompositor] Add support for threaded compositor.
2921         https://bugs.webkit.org/show_bug.cgi?id=118265
2922
2923         Reviewed by Martin Robinson.
2924
2925         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
2926         autotools build systems. The feature is disabled by default.
2927         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
2928         from the feature flags.
2929
2930         * Scripts/webkitperl/FeatureList.pm:
2931
2932 2015-01-07  Daniel Bates  <dabates@apple.com>
2933
2934         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2935         https://bugs.webkit.org/show_bug.cgi?id=137371
2936
2937         Reviewed by David Kilzer.
2938
2939         Use SPI wrapper headers instead of directly referencing private SPI headers.
2940
2941         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2942         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2943         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2944         to the list of iOS header search directories so that we can include header UIKitSPI.h.
2945         * DumpRenderTree/mac/DumpRenderTree.mm:
2946         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2947         * DumpRenderTree/mac/EventSendingController.mm:
2948         * DumpRenderTree/mac/TestRunnerMac.mm:
2949
2950 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2951
2952         Unreviewed, rolling out r178068.
2953         https://bugs.webkit.org/show_bug.cgi?id=140235
2954
2955         Breaks the iOS build (Requested by enrica on #webkit).
2956
2957         Reverted changeset:
2958
2959         "[iOS] Make WebKit2 build with public iOS SDK and more build
2960         fixes for DRT"
2961         https://bugs.webkit.org/show_bug.cgi?id=137371
2962         http://trac.webkit.org/changeset/178068
2963
2964 2015-01-07  Daniel Bates  <dabates@apple.com>
2965
2966         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2967         https://bugs.webkit.org/show_bug.cgi?id=137371
2968
2969         Reviewed by David Kilzer.
2970
2971         Use SPI wrapper headers instead of directly referencing private SPI headers.
2972
2973         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2974         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2975         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
2976         to the list of header search directories so that we can include header UIKitSPI.h.
2977         * DumpRenderTree/mac/DumpRenderTree.mm:
2978         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2979         * DumpRenderTree/mac/EventSendingController.mm:
2980         * DumpRenderTree/mac/TestRunnerMac.mm:
2981
2982 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
2983
2984         [Win] Unreviewed test change to improve run reproducibility
2985
2986         * Scripts/webkitpy/port/win.py:
2987         (WinPort.default_child_processes): Run a single DRT instance to help
2988         identify failures caused by earlier test runs.
2989
2990 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
2991
2992         Myles C. Maxfield is a reviewer now
2993         https://bugs.webkit.org/show_bug.cgi?id=140196
2994
2995         Reviewed by Dean Jackson.
2996
2997         * Scripts/webkitpy/common/config/contributors.json:
2998
2999 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3000
3001         Make webkit-patch try harder to find keychain credentials
3002         https://bugs.webkit.org/show_bug.cgi?id=140170
3003
3004         Reviewed by Ryosuke Niwa.
3005
3006         When the user manually enters a password into webkit-patch, we hand that off to the
3007         Keyring Python module. However, that module creates a generic password entry instead
3008         of an internet password entry. We should look for both kinds.
3009
3010         * Scripts/webkitpy/common/net/credentials.py:
3011         (Credentials._run_security_tool):
3012         (Credentials._credentials_from_keychain):
3013         * Scripts/webkitpy/common/net/credentials_unittest.py:
3014         (test_security_output_parse_entry_not_found):
3015         (_assert_security_call):
3016
3017 2015-01-06  Anders Carlsson  <andersca@apple.com>
3018
3019         Try to fix the Mountain Lion build.
3020
3021         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3022         (TestWebKitAPI::didGetImageForMatchResult):
3023
3024 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3025
3026         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3027         https://bugs.webkit.org/show_bug.cgi?id=140095
3028
3029         Reviewed by Anders Carlsson.
3030
3031         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3032         builds, but not in debug ones.
3033
3034 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3035
3036         [Win] Extend WinLauncher with support for Page Zoom
3037         https://bugs.webkit.org/show_bug.cgi?id=140152
3038
3039         Reviewed by Anders Carlsson.
3040
3041         * WinLauncher/Common.cpp:
3042         (WndProc):
3043         * WinLauncher/WinLauncher.cpp:
3044         (WinLauncher::resetZoom):
3045         (WinLauncher::zoomIn):
3046         (WinLauncher::zoomOut):
3047         * WinLauncher/WinLauncher.h:
3048         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3049         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3050         * win/DLLLauncher/DLLLauncherMain.cpp:
3051         (wWinMain):
3052
3053 2015-01-06  Anders Carlsson  <andersca@apple.com>
3054
3055         Fix API tests that are broken under HiDPI
3056         https://bugs.webkit.org/show_bug.cgi?id=140146
3057
3058         Reviewed by Tim Horton.
3059
3060         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3061         (TestWebKitAPI::didGetImageForMatchResult):
3062         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3063
3064         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3065         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3066         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3067         out in a window that has a backing scale factor of 1.
3068  
3069         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3070         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3071         Ditto.
3072
3073 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3074
3075         ADDRESS_SANITIZER macro is overloaded
3076         https://bugs.webkit.org/show_bug.cgi?id=140130
3077
3078         Reviewed by Anders Carlsson.
3079
3080         * WebKitTestRunner/TestController.cpp: Use the new macro.
3081
3082 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3083
3084         Remove some stale class names in check-for-inappropriate-objc-class-names
3085         https://bugs.webkit.org/show_bug.cgi?id=140104
3086
3087         Reviewed by Darin Adler.
3088
3089         * Scripts/check-for-inappropriate-objc-class-names:
3090         These UIWK* classes no longer exist.
3091
3092 2015-01-05  Anders Carlsson  <andersca@apple.com>
3093
3094         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3095         https://bugs.webkit.org/show_bug.cgi?id=140096
3096         rdar://problem/19368938
3097
3098         Reviewed by Alexey Proskuryakov.
3099
3100         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3101         since clientInfo points to a web view, not the test controller.
3102
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::createOtherPage):
3105
3106 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3107
3108         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3109         https://bugs.webkit.org/show_bug.cgi?id=140077
3110
3111         Reviewed by Csaba Osztrogonác.
3112
3113         WebKit C SPI is available on EFL,GTK.
3114         Changed the define order to pass the API test.
3115
3116         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3117         (TestWebKitAPI::TEST):
3118
3119 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3120
3121         Simplify WebKitTestRunner timeout tracking
3122         https://bugs.webkit.org/show_bug.cgi?id=140036
3123
3124         Reviewed by Darin Adler.
3125
3126         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3127         passes the --timeout option to WebKitTestRunner.
3128
3129         * WebKitTestRunner/Options.h:
3130         * WebKitTestRunner/Options.cpp:
3131         (WTR::Options::Options):
3132         (WTR::OptionsHandler::OptionsHandler):
3133         (WTR::handleOptionTimeout): Deleted.
3134         Removed support for --timeout. Timeouts are passed for each test individually,
3135         and defaults are good enough for the rare cases where WebKitTestRunner is run
3136         manually without run-webkit-tests.
3137
3138         * WebKitTestRunner/TestController.cpp:
3139         (WTR::TestController::TestController):
3140         (WTR::TestController::initialize):
3141         (WTR::TestController::resetStateToConsistentValues):
3142         (WTR::TestController::reattachPageToWebProcess):
3143         (WTR::TestController::runUntil):
3144         * WebKitTestRunner/TestController.h:
3145         Simplified runUntil by passing the actual timeout, not an enum.
3146         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3147         quite a while.
3148
3149         * WebKitTestRunner/TestInvocation.cpp:
3150         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3151
3152         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3153         (WTR::TestController::platformRunUntil):
3154         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3155         (WTR::TestController::platformRunUntil):
3156         Build fixes.
3157
3158 2015-01-02  Anders Carlsson  <andersca@apple.com>
3159
3160         Remove now unused storage tracker glue from DumpRenderTree
3161         https://bugs.webkit.org/show_bug.cgi?id=140045
3162
3163         Reviewed by Darin Adler.
3164
3165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3166         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3167         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3168         * DumpRenderTree/TestRunner.cpp:
3169         (TestRunner::staticFunctions):
3170         (syncLocalStorageCallback): Deleted.
3171         (observeStorageTrackerNotificationsCallback): Deleted.
3172         (deleteAllLocalStorageCallback): Deleted.
3173         (deleteLocalStorageForOriginCallback): Deleted.
3174         (localStorageDiskUsageForOriginCallback): Deleted.
3175         (originsWithLocalStorageCallback): Deleted.
3176         * DumpRenderTree/TestRunner.h:
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (allocateGlobalControllers):
3179         (releaseGlobalControllers):
3180         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3181         * DumpRenderTree/mac/TestRunnerMac.mm:
3182         (TestRunner::syncLocalStorage): Deleted.
3183         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3184         (TestRunner::observeStorageTrackerNotifications): Deleted.
3185         (TestRunner::deleteAllLocalStorage): Deleted.
3186         (TestRunner::originsWithLocalStorage): Deleted.
3187         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3188         * DumpRenderTree/win/TestRunnerWin.cpp:
3189         (TestRunner::syncLocalStorage): Deleted.
3190         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3191         (TestRunner::observeStorageTrackerNotifications): Deleted.
3192         (TestRunner::deleteAllLocalStorage): Deleted.
3193         (TestRunner::originsWithLocalStorage): Deleted.
3194         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3195
3196 2015-01-01  Darin Adler  <darin@apple.com>
3197
3198         We often misspell identifier as "identifer"
3199         https://bugs.webkit.org/show_bug.cgi?id=140025
3200
3201         Reviewed by Michael Saboff.
3202
3203         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3204         * Scripts/webkitdirs.pm:
3205         (appIdentifierFromBundle):
3206         (installAndLaunchIOSWebKitAppInSimulator):
3207         Fix misspellings
3208
3209 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3210
3211         Saturated arithmetics: Incorrect float/double clamping.
3212         https://bugs.webkit.org/show_bug.cgi?id=139888
3213         rdar://problem/19330885
3214
3215         Reviewed by Simon Fraser.
3216
3217         Clamp float and double values correctly when applying saturated arithmetics.
3218
3219         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3220         (TestWebKitAPI::TEST):
3221
3222 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3223
3224         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3225         https://bugs.webkit.org/show_bug.cgi?id=139816
3226
3227         Reviewed by Gyuyoung Kim.
3228
3229         Bump version of ATK used by jhbuild to 2.15.2
3230
3231         * efl/jhbuild.modules:
3232
3233 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3234
3235         [jhBuild] cairo build error (-flto)
3236         https://bugs.webkit.org/show_bug.cgi?id=139056
3237
3238         Reviewed by Philippe Normand.
3239
3240         cairo fails to link  with gcc 4.9 due to lto
3241         related issue. This problem has been partially
3242         addressed by cairo:
3243         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3244         use the cairo --disable-lto option and remove jhbuild
3245         makeargs fixes the issue.
3246
3247         * gtk/jhbuild.modules:
3248         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3249
3250 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3251         [Mac] Enable kerning, ligatures, and printer fonts 
3252         https://bugs.webkit.org/show_bug.cgi?id=139970
3253
3254         Rubber stamped by Simon Fraser.
3255
3256         Flip the switch.
3257
3258         * DumpRenderTree/mac/DumpRenderTree.mm:
3259         * WebKitTestRunner/TestController.cpp:
3260         * WebKitTestRunner/mac/main.mm:
3261
3262 2014-12-26  Dan Bernstein  <mitz@apple.com>
3263
3264         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3265         https://bugs.webkit.org/show_bug.cgi?id=139950
3266
3267         Reviewed by David Kilzer.
3268
3269         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3270         in a manner that works with Xcode 5.1.1.
3271
3272 2014-12-24  Dan Bernstein  <mitz@apple.com>
3273
3274         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3275         https://bugs.webkit.org/show_bug.cgi?id=139941
3276
3277         Reviewed by Darin Adler.
3278
3279         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3280         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3281         to YES.
3282         * MiniBrowser/mac/AppDelegate.m:
3283         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3284         deprecated NSOKButton.
3285
3286 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3287
3288         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3289         https://bugs.webkit.org/show_bug.cgi?id=134763
3290
3291         Reviewed by Ryosuke Niwa.
3292
3293         Adding an option to disable test harness link conversion.
3294
3295         * Scripts/webkitpy/w3c/test_converter.py:
3296         (convert_for_webkit):
3297         (_W3CTestConverter.__init__):
3298         (_W3CTestConverter.convert_attributes_if_needed):
3299         * Scripts/webkitpy/w3c/test_importer.py:
3300         (parse_args):
3301         (TestImporter.import_tests):
3302
3303 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3304
3305         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3306         https://bugs.webkit.org/show_bug.cgi?id=139933
3307
3308         Reviewed by Daniel Bates.
3309
3310         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3311         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3312         until ReportCrash lets it go.
3313
3314         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3315         even get the actual crash log eventually - even when it times out waiting for the log, it
3316         makes a second lookup at the very end, after all tests finish. There may be further
3317         improvements needed here, but this small fix addresses most cases that happen in practice.
3318
3319         * DumpRenderTree/mac/DumpRenderTree.mm:
3320         (writeCrashedMessageOnFatalError):
3321         (dumpRenderTree):
3322         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3323
3324         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3325         unhelpful comment.
3326
3327 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3328
3329         Don't force -O1 for debug ASan builds
3330         https://bugs.webkit.org/show_bug.cgi?id=139926
3331
3332         Reviewed by Darin Adler.
3333
3334         * asan/asan.xcconfig:
3335
3336 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3337
3338         Simplify building with ASan
3339         https://bugs.webkit.org/show_bug.cgi?id=139916
3340
3341         Reviewed by Mark Rowe.
3342
3343         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3344         We could also update Configuration file format, but that's a little scary because
3345         of how many places in code read it.
3346
3347         * Scripts/webkitdirs.pm:
3348         (determineASanIsEnabled): Read it from ASan configuration file.
3349         (argumentsForConfiguration): Added a FIXME.
3350         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3351         (XcodeOptions): Pass the options needed for ASan.
3352
3353         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3354         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3355         that automatically.
3356
3357 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3358
3359         TestWebKitAPI build is broken when ASan is enabled
3360         https://bugs.webkit.org/show_bug.cgi?id=139902
3361
3362         Reviewed by Darin Adler.
3363
3364         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3365         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
3366         Inherit linker flags from DebugRelease, which respects ASAN.
3367
3368 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
3369
3370         Sort the Xcode project file.
3371
3372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3373
3374 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3375
3376         Update apple-mac-114 to bot629.
3377         
3378         Unreviewed.
3379         
3380         * BuildSlaveSupport/build.webkit.org-config/config.json:
3381
3382 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3383
3384         Replace Apple bot104 with bot124.
3385         
3386         Unreviewed.
3387         
3388         * BuildSlaveSupport/build.webkit.org-config/config.json:
3389
3390 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3391
3392         URTBF after r177639.
3393
3394         * TestWebKitAPI/CMakeLists.txt:
3395
3396 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3397
3398         [EFL] MiniBrowser steals web view's focus
3399         https://bugs.webkit.org/show_bug.cgi?id=139482
3400
3401         Reviewed by Gyuyoung Kim.
3402
3403         Although we set focus on ewk_view while MiniBrowser initialization
3404         Ecore steals it in a favor of main window. As a result
3405         focused element on web page is unable to receive events.
3406
3407         * MiniBrowser/efl/main.c:
3408         (window_create):
3409         Prevent window from stealing web view's focus on start up.
3410
3411 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3412
3413         [Win] Revise DRT logic to match Mac.
3414
3415         Rubberstamped by Anders Carlsson.
3416
3417         Update the Windows logic to perform initialization of preferences and WebKit
3418         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
3419         the same circumstances as the Mac version.
3420
3421         * DumpRenderTree/win/DumpRenderTree.cpp:
3422         (dump):
3423         (resetWebPreferencesToConsistentValues):
3424         (setDefaultsToConsistentValuesForTesting):
3425         (resetWebViewToConsistentStateBeforeTesting):
3426         (sizeWebViewForCurrentTest):
3427         (runTest):
3428         (createWebViewAndOffscreenWindow):
3429         (allocateGlobalControllers):
3430         (prepareConsistentTestingEnvironment):
3431         (main):
3432         (resetDefaultsToConsistentValues): Deleted.
3433
3434 2014-12-19  Roger Fong  <roger_fong@apple.com>
3435
3436         Unreviewed. Rollout r177605.
3437
3438         * EWSTools/start-queue-win.sh:
3439
3440 2014-12-19  Roger Fong  <roger_fong@apple.com>
3441
3442         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
3443
3444         * EWSTools/start-queue-win.sh:
3445
3446 2014-12-19  Daniel Bates  <dabates@apple.com>
3447
3448         [iOS] Add WebKitSystemInterface for iOS 8.1
3449         https://bugs.webkit.org/show_bug.cgi?id=139831
3450
3451         Reviewed by Alexey Proskuryakov.
3452
3453         Implement support in copy-webkitlibraries-to-product-directory to copy
3454         WebKitSystemInterface for iOS to the product directory and have build-webkit
3455         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
3456
3457         * Scripts/build-webkit:
3458         * Scripts/copy-webkitlibraries-to-product-directory:
3459
3460 2014-12-19  Daniel Bates  <dabates@apple.com>
3461
3462         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
3463         https://bugs.webkit.org/show_bug.cgi?id=139829
3464
3465         Reviewed by Alexey Proskuryakov.
3466
3467         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
3468         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
3469         expects the Xcode SDK to be specified using the --sdk-name command line argument.
3470
3471         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
3472         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
3473         logic to both avoid duplicating effort and make the command line options for
3474         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
3475         with the approach used in other WebKit tools.
3476
3477         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
3478         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
3479         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
3480
3481         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
3482         improve the readability of the code.
3483         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
3484         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
3485         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
3486         be included in a library.
3487         (unpackIfNecessary): Modified to call executeRanlib().
3488
3489 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3490
3491         REGRESSION (177368): Some tests started to immediately time out
3492         https://bugs.webkit.org/show_bug.cgi?id=139826
3493
3494         Reviewed by Daniel Bates.
3495
3496         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3497         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3498         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3499         ends in a load failure, we don't dump, so we used to leak the timer.
3500         
3501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3502         Added a comment.
3503
3504 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3505
3506         [Win] Add accessor for serializing HTTP loads
3507         https://bugs.webkit.org/show_bug.cgi?id=139817
3508
3509         Reviewed by Mark Lam.
3510
3511         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3512         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3513         remove some redundant code from the destructor.
3514
3515 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3516
3517         Clean up a fix for performance test bot failing to build
3518         https://bugs.webkit.org/show_bug.cgi?id=139818
3519
3520         Reviewed by Csaba Osztrogonác.
3521
3522         The "_1" in step name was annoying.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3525         (CleanBuildIfScheduled.start):
3526         (RunAndUploadPerfTests):
3527         (DownloadAndPerfTestFactory.__init__):
3528         (DownloadAndPerfTestWebKit2Factory.__init__):
3529         (CleanBuildUnconditionally): Deleted.
3530         (CleanBuildUnconditionally.start): Deleted.
3531
3532 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
3533
3534         REGRESSION(r177535): It broke the GTK performance bot
3535         https://bugs.webkit.org/show_bug.cgi?id=139811
3536
3537         Reviewed by Carlos Garcia Campos.
3538
3539         Trigger clean build only on mac platform.
3540
3541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3542         (DownloadAndPerfTestFactory.__init__):
3543         (DownloadAndPerfTestWebKit2Factory.__init__):
3544
3545 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
3546
3547         Unreviewed, moved myself to the list of committers.
3548
3549         * Scripts/webkitpy/common/config/contributors.json:
3550
3551 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3552
3553         [Win] Update DumpRenderTree to more closely match Mac version
3554         https://bugs.webkit.org/show_bug.cgi?id=139799
3555
3556         Reviewed by Tim Horton.
3557
3558         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3559         (AccessibilityController::accessibleElementById): Correct
3560         use of BSTR to avoid leak.
3561         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
3562         update to match Mac version more closely.
3563         (dumpFramesAsText):
3564         (dump):
3565         (resetDefaultsToConsistentValues):
3566         (resetWebViewToConsistentStateBeforeTesting):
3567         (sizeWebViewForCurrentTest):
3568         (runTest):
3569         (openWindows):
3570         (windowToWebViewMap):
3571         (createWebViewAndOffscreenWindow):
3572         (sharedCFURLCache):
3573         (initializeGlobalsFromCommandLineOptions):
3574         (main):
3575         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3576         (TestRunner::addDisallowedURL):
3577         (TestRunner::applicationCacheDiskUsageForOrigin):
3578         (TestRunner::syncLocalStorage):
3579         (TestRunner::localStorageDiskUsageForOrigin):
3580         (TestRunner::observeStorageTrackerNotifications):
3581         (TestRunner::clearApplicationCacheForOrigin):
3582         (TestRunner::originsWithApplicationCache):
3583         (TestRunner::deleteAllLocalStorage):
3584         (TestRunner::setStorageDatabaseIdleInterval):
3585         (TestRunner::closeIdleLocalStorageDatabases):
3586         (TestRunner::originsWithLocalStorage):
3587         (TestRunner::deleteLocalStorageForOrigin):
3588         (TestRunner::copyDecodedHostName):
3589         (TestRunner::copyEncodedHostName):
3590         (TestRunner::keepWebHistory):
3591         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3592         (TestRunner::setAppCacheMaximumSize):
3593         (TestRunner::setCustomPolicyDelegate):
3594         (TestRunner::goBack):
3595         (TestRunner::setDefersLoading):
3596         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3597         (TestRunner::setMockDeviceOrientation):
3598         (TestRunner::setMockGeolocationPosition):
3599         (TestRunner::setMockGeolocationPositionUnavailableError):
3600         (TestRunner::setIconDatabaseEnabled):
3601         (TestRunner::setMainFrameIsFirstResponder):
3602         (TestRunner::setSpatialNavigationEnabled):
3603         (TestRunner::setPluginsEnabled):
3604         (TestRunner::setAutomaticLinkDetectionEnabled):
3605         (TestRunner::setUseDashboardCompatibilityMode):
3606         (TestRunner::dispatchPendingLoadRequests):
3607         (TestRunner::findString):
3608         (TestRunner::setCacheModel):
3609         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3610         (TestRunner::setWebViewEditable):
3611         (TestRunner::authenticateSession):
3612         (TestRunner::abortModal):
3613         (TestRunner::setSerializeHTTPLoads):
3614         (TestRunner::addChromeInputField):
3615         (TestRunner::removeChromeInputField):
3616         (TestRunner::focusWebView):
3617         (TestRunner::setBackingScaleFactor):
3618         (TestRunner::grantWebNotificationPermission):
3619         (TestRunner::denyWebNotificationPermission):
3620         (TestRunner::removeAllWebNotificationPermissions):
3621         (TestRunner::simulateWebNotificationClick):
3622
3623 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
3624
3625         Add strong typing to RefCounter interface, return value as a bool.
3626         https://bugs.webkit.org/show_bug.cgi?id=139776
3627
3628         Reviewed by Geoff Garen.
3629
3630         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
3631         This means there is no compile time type checking to prevent mistakes. Update the count()
3632         method to token<>(), templated on type used to identify the token being returned.
3633         Calls to token<T>() will return a result of type RefCounter::Token<T>.
3634
3635         There are a few problems with the fact the counter will return you an exact count of the
3636         number of outstanding tokens:
3637           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
3638             to do so if the value is only readable as a boolean.
3639           - It is desirable to provide the value as an argument to the callback, however to make
3640             this useful for integer values it is also necessary to indicate the direction of change
3641             (0->1 is often interesting where 2->1 is not).
3642           - There is a mismatch between the precision of returning a count, and the inherent
3643             imprecision of a token based mechanism, where it may be difficult to guarantee
3644             absolutely no unnecessary refcount churn, and thus unintentional counter values.
3645
3646         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3647         (TestWebKitAPI::TEST):
3648             - update API test.
3649
3650 2014-12-18  Alexey Proskuryakov  <ap@apple.com>